Matt-Yorkley
d34b8c52b8
Update all locales with the latest Transifex translations
2018-12-17 11:17:54 +00:00
Pau Pérez Fabregat
54775f6b6a
Merge pull request #3221 from zvkemp/skylight-1.7.2
...
update Skylight to 1.7.2
2018-12-17 10:44:16 +01:00
Pau Pérez Fabregat
1876ec42dc
Merge pull request #3201 from kevinchristianson/add-missing-stars
...
Add missing 'required field' stars in new product form
2018-12-17 10:36:51 +01:00
Pau Pérez Fabregat
554d650b8c
Merge pull request #3176 from kevinchristianson/button-translation-fix
...
Fix untranslated buttons at image step of registration modal
2018-12-17 10:36:07 +01:00
Pau Pérez Fabregat
2deffb9c9f
Merge pull request #3076 from Matt-Yorkley/orders_checkboxes
...
Fix checkbox values on orders page
2018-12-17 10:35:46 +01:00
zvkemp
d3d43c8808
update Skylight to 1.7.2
2018-12-14 12:25:41 -08:00
Pau Pérez Fabregat
fe0c56c800
Merge pull request #3174 from kevinchristianson/footer-url-fix
...
Fix broken registration link in footer
2018-12-14 15:42:08 +01:00
Pau Pérez Fabregat
34a42cc592
Merge pull request #3181 from luisramos0/roadie-rails-upgrade
...
Bump roadie-rails from 1.0.3 to 1.1.1
2018-12-14 15:26:25 +01:00
Pau Pérez Fabregat
2eb6d0a047
Merge pull request #3185 from openfoodfoundation/dependabot/bundler/oj-3.7.4
...
Bump oj from 3.6.10 to 3.7.4
2018-12-13 18:10:55 +01:00
Maikel
eb016c0471
Merge pull request #3145 from openfoodfoundation/dependabot/bundler/i18n-js-3.1.0
...
Bump i18n-js from 3.0.11 to 3.1.0
2018-12-13 10:58:22 +11:00
Pau Pérez Fabregat
d317603872
Merge pull request #3187 from openfoodfoundation/dependabot/bundler/rspec-rails-3.8.1
...
Bump rspec-rails from 3.7.2 to 3.8.1
2018-12-12 17:14:05 +01:00
Pau Pérez Fabregat
64e41712c6
Merge pull request #3130 from coopdevs/extract-restart-checkout
...
Extract restart checkout
2018-12-12 17:12:53 +01:00
haseleyi
835617159e
Add missing 'required field' stars in new product form
2018-12-10 18:02:39 -08:00
Matt-Yorkley
0c5ac99e0f
Fix multiple results with 'inventory_items_shipment_id_null' ransack query
...
The q['inventory_items_shipment_id_null'] search element was generating duplicates where there were multiple line items on an order that were ready to be shipped, with id = null
2018-12-10 20:48:53 +00:00
Matt-Yorkley
e711c5ed03
Add spec for search filters
2018-12-10 20:48:53 +00:00
Matt-Yorkley
d48774e3a2
Add comment
2018-12-10 20:48:53 +00:00
Matt-Yorkley
997169b974
Fix checkbox values on orders page
2018-12-10 20:48:53 +00:00
Maikel
046ba14da4
Merge pull request #3191 from openfoodfoundation/dependabot/bundler/knapsack-1.17.1
...
Bump knapsack from 1.16.0 to 1.17.1
2018-12-07 15:18:25 +11:00
haseleyi
3f6e96dd5d
Fix comment
2018-12-06 14:07:45 -08:00
haseleyi
4a0744dd94
Add comment to explain hard-coded link
2018-12-06 11:49:39 -08:00
dependabot[bot]
6ae2df7b92
Bump knapsack from 1.16.0 to 1.17.1
...
Bumps [knapsack](https://github.com/ArturT/knapsack ) from 1.16.0 to 1.17.1.
- [Release notes](https://github.com/ArturT/knapsack/releases )
- [Changelog](https://github.com/ArturT/knapsack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ArturT/knapsack/compare/v1.16.0...v1.17.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-06 19:16:09 +00:00
Maikel
3a3c9f3847
Merge pull request #3177 from coopdevs/dont-clean-db-twice-in-feature-specs
...
Do not clean DB twice on feature specs
2018-12-06 12:36:34 +11:00
haseleyi
75277e92e4
Lazy-load the translations for images step of registration
2018-12-05 11:36:27 -08:00
dependabot[bot]
727cc9d578
Bump rspec-rails from 3.7.2 to 3.8.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 3.7.2 to 3.8.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.7.2...v3.8.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:19:50 +00:00
dependabot[bot]
ebff8be996
Bump oj from 3.6.10 to 3.7.4
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.6.10 to 3.7.4.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.6.10...v3.7.4 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:16:55 +00:00
luisramos0
bbc61b4eda
Bump roadie-rails to 1.1.1
2018-12-05 15:11:45 +00:00
Pau Pérez Fabregat
1052d98255
Merge pull request #3175 from haseleyi/patch-1
...
Fix link to Mac setup guide in Getting Started
2018-12-05 12:52:08 +01:00
Pau Perez
25567d6bd6
Do not clean DB twice on feature specs
...
It turns out that we were executing `DatabaseCleaner.clean` on two
`after(:each)` blocks. One for all specs and another one for `js: true`
specs. As a result feature specs were hitting both which slows them down
considerably.
On my machine this changes consistently saves 2sec on
`spec/features/consumer/shops_spec.rb` but chances are it has an
accumulative effect when run on the whole test suite.
2018-12-05 09:58:14 +01:00
Pau Pérez Fabregat
3b56212290
Merge pull request #3151 from coopdevs/remove-frontoffice-enterprises-n+1
...
Remove frontoffice enterprises n+1
2018-12-05 08:12:19 +01:00
Pau Pérez Fabregat
e5a267f4c2
Merge pull request #2735 from luisramos0/cookies_colors
...
Moved definition of colors in the cookies modal and banner colors to common darkswarm/base/colors
2018-12-05 08:06:58 +01:00
haseleyi
94d12217de
Fix untranslated buttons at image step of registration modal
2018-12-04 21:30:42 -08:00
Isaac Haseley
76e5d281bf
Fix link for Mac setup guide
2018-12-04 20:37:23 -08:00
Maikel
609a4fde4d
Merge pull request #3173 from openfoodfoundation/transifex
...
Transifex
2018-12-05 11:55:29 +11:00
Transifex-Openfoodnetwork
18a5f53330
Updating translations for config/locales/fr.yml
2018-12-05 09:17:00 +11:00
haseleyi
e863c3dec8
Fix broken link in register call partial
2018-12-04 10:23:46 -08:00
Pau Pérez Fabregat
24415226bf
Merge pull request #3168 from luisramos0/google-maps-comment-specs
...
Temporarily xit 2 broken specs (shops and producers search by url)
2018-12-04 19:13:40 +01:00
Transifex-Openfoodnetwork
9bedc69df8
Updating translations for config/locales/en_GB.yml
2018-12-05 04:52:44 +11:00
luisramos0
7dc208fb8c
Temporarily move 2 broken specs to pending (shops and producers search by url) due to google maps api changes
2018-12-04 13:20:20 +00:00
Maikel Linke
66585e93a8
Update all locales with the latest Transifex translations
2018-12-04 14:48:03 +11:00
luisramos0
1c5d94472f
Make colors.css relative reference to branding.css an absolute reference so that colors can be imported in engines
2018-11-29 18:39:58 +00:00
Pau Pérez Fabregat
08297863be
Merge pull request #3047 from mllocs/feature/expand-all-steps-in-checkout-page
...
Expand all steps in the checkout page by default
2018-11-29 16:28:42 +01:00
Pau Pérez Fabregat
9f17acd63c
Merge pull request #3136 from kevinchristianson/dashboard-translation
...
Add missing translation for 'Has Shopfront' in single-enterprise dashboard
2018-11-29 16:27:05 +01:00
luisramos0
93e1310deb
Fixed bug in cookies css, import colors, not branding
2018-11-29 11:47:51 +00:00
luisramos0
cdc5899791
Moved cookies policy modal and cookies banner colors to darkswarm/base/colors.scss
2018-11-29 11:47:51 +00:00
Pau Pérez Fabregat
949efd88ce
Merge pull request #3154 from mkllnk/update-db-schema
...
Update schema for latest migration
2018-11-29 11:34:43 +01:00
Maikel Linke
285346fcda
Update schema for latest migration
...
I feel embarrased that this is the second follow up of my last
migration: https://github.com/openfoodfoundation/openfoodnetwork/pull/3126
The last migration didn't change any database structure, but the schema
still needs the latest migration version. Otherwise it will display
pending migrations when setting up the database.
This commit allows to run `bundle exec rake db:reset` in development
without the following message:
Run `rake db:migrate` to update your database then try again.
You have 1 pending migrations:
20181123012635 AssociateCustomersToUsers
The next pull request with a migration would have solved this problem as
well.
2018-11-29 10:29:56 +11:00
Pau Pérez Fabregat
3ea7fac25f
Merge pull request #3095 from luisramos0/admin-users-transl
...
In admin/users, convert Spree.t calls to t calls and use lazy lookup
2018-11-28 17:37:42 +01:00
Pau Pérez Fabregat
8df781887a
Merge pull request #3111 from kevinchristianson/pay-list-translation
...
Add translation for 'Back to Payments List' button in new payment form
2018-11-28 17:03:29 +01:00
Pau Pérez Fabregat
64c12c7a65
Merge pull request #2955 from HugsDaniel/import-spree-views-for-orders#edit
...
Import Spree views for orders#edit in our codebase
2018-11-28 17:02:40 +01:00
Pau Perez
96202ab00d
Fix Rubocop violations
2018-11-28 16:23:56 +01:00
Pau Perez
e0f43191e2
Make helper methods private
...
Otherwise next dev might think these are attributes of the resulting
JSON serialized object.
They just made the refactoring a bit easier.
2018-11-28 16:21:40 +01:00
Pau Perez
c330d931ce
Eager load product properties to avoid N+1
...
This totally removes the following N+1 query from the GET /shops request
```sql
SELECT "spree_properties".* FROM "spree_properties"
INNER JOIN "spree_product_properties"
ON "spree_product_properties"."property_id" = "spree_properties"."id"
INNER JOIN "spree_products"
ON "spree_products"."id" = "spree_product_properties"."product_id"
INNER JOIN "enterprises"
ON "enterprises"."id" = "spree_products"."supplier_id"
WHERE "spree_products"."supplier_id" = 24;
```
The product properties of the corresponding enterprises are now loaded
in a single query fired from the controller.
2018-11-28 16:21:40 +01:00
Pau Perez
4608c434b4
Eager load producer properties to avoid N+1
...
This totally removes the following N+1 query from the GET /shops request
```sql
SELECT "spree_properties".* FROM "spree_properties"
INNER JOIN "producer_properties"
ON "spree_properties"."id" = "producer_properties"."property_id"
WHERE "producer_properties"."producer_id" = 17
ORDER BY producer_properties.position;
```
The producer properties of the corresponding enterprises are now loaded
in a single query fired from the controller.
2018-11-28 16:21:40 +01:00
Pau Perez
e40c1c08ca
Refactor spec to not stub the class under test
...
This also relies on ActiveRecord which will come in handy as we move on
the refactor.
2018-11-28 16:21:40 +01:00
Pau Perez
149fc1ac6f
Inline PropertyMerge's #merge into serializer
...
Now that it has become a plain Ruby #uniq, there's no point on having
the abstraction and indirection.
2018-11-28 16:21:40 +01:00
Pau Perez
faac5f4b2d
Refactor PropertyMerge to use Ruby's #uniq instead
2018-11-28 16:21:40 +01:00
Pau Perez
1363a2a17d
Improve readability of spec
2018-11-28 16:21:40 +01:00
Pau Perez
8e1f9a1ba3
Refactor #product_properties not to fetch ids
2018-11-28 16:21:40 +01:00
Pau Perez
bc7258d43b
Test #supplied_properties helper methods
2018-11-28 16:21:40 +01:00
Pau Perez
23f629cfd6
Autofix all Rubocop violations in serializer
2018-11-28 13:54:42 +01:00
Pau Perez
c6ab5feb81
Move cached & uncached serializers to their files
2018-11-28 13:54:42 +01:00
Pau Perez
41d988176c
Pass enterprises to inject method from controller
2018-11-28 13:54:42 +01:00
Pau Perez
5a85d7a77b
RSpec3-ize controller spec
2018-11-28 13:54:42 +01:00
Pau Pérez Fabregat
b9dfaea274
Merge pull request #3143 from coopdevs/setup-rack-mini-profiler
...
Enable rack-mini-profiler in development
2018-11-28 13:54:27 +01:00
Pau Pérez Fabregat
438cff6e6d
Merge pull request #3080 from Matt-Yorkley/pi/french_issue
...
Pi/french issue
2018-11-28 13:39:04 +01:00
Hugo Daniel
69e186f482
Define dynamic classes in variables as a turnaround to HAML bug
2018-11-28 10:31:47 +01:00
Hugo Daniel
65dd3eb5b9
Change line items controller HTML response spec to look for form order_edit class
2018-11-28 10:31:47 +01:00
Hugo Daniel
60214b9a90
Fix failing specs
2018-11-28 10:31:47 +01:00
Hugo Daniel
422a68630f
Remove data-hook tags
2018-11-28 10:31:47 +01:00
Hugo Daniel
652191a4c5
Fixing missing variable none
2018-11-28 10:31:47 +01:00
Hugo Daniel
c233ea38cf
Import Spree views for orders#edit in our codebase and integrate deface modifications
2018-11-28 10:31:47 +01:00
dependabot[bot]
7b95e3a8d7
Bump i18n-js from 3.0.11 to 3.1.0
...
Bumps [i18n-js](https://github.com/fnando/i18n-js ) from 3.0.11 to 3.1.0.
- [Release notes](https://github.com/fnando/i18n-js/releases )
- [Changelog](https://github.com/fnando/i18n-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fnando/i18n-js/compare/v3.0.11...v3.1.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-27 19:17:57 +00:00
Pau Pérez Fabregat
5c8a638320
Merge pull request #3055 from HugsDaniel/3051-products-edit-views
...
[Defacepocalypse] Import products#edit and form partial in our codebase and apply overrides
2018-11-27 17:32:25 +01:00
Pau Pérez Fabregat
869f17256d
Merge pull request #3011 from HugsDaniel/3000-api-endpoint-enterprise-fee
...
Add an API endpoint for EnterpriseFeesController#destroy
2018-11-27 17:28:43 +01:00
Pau Pérez Fabregat
ea6f44e78d
Merge pull request #3144 from mkllnk/2841-fix-migration-encoding
...
Encode records with special chars as well
2018-11-27 17:28:13 +01:00
Pau Pérez Fabregat
04d57f8e6e
Merge pull request #3135 from openfoodfoundation/dependabot/bundler/unicorn-rails-2.2.1
...
Bump unicorn-rails from 1.1.0 to 2.2.1
2018-11-27 17:26:12 +01:00
Pau Pérez Fabregat
d073157424
Merge pull request #3134 from coopdevs/update-skylight
...
Update Skylight from 1.6.1 to 1.7.1
2018-11-27 08:54:39 +01:00
Maikel
2967fdccf7
Merge pull request #3142 from kristinalim/fix-rubocop_block_length_ignore_describe_context
...
Ignore `describe` and `context` in Rubocop BlockLength
2018-11-27 14:54:46 +11:00
Maikel Linke
9efa45663c
Encode records with special chars as well
...
Using Marshal.dump on the French production database raised an error:
Encoding::UndefinedConversionError: "\xC3" from ASCII-8BIT to UTF-8
Replacing Marshal with YAML solves the problem. It is also more reliable
and human readable.
This code was run against the French, Australian and UK production
data successfully.
2018-11-27 14:34:03 +11:00
Pau Perez
b365488653
Enable rack-mini-profiler in development
...
This will run it always in development mode.
2018-11-26 12:10:49 +01:00
Kristina Lim
5c6ec50dea
Ignore describe and context in Rubocop BlockLength
2018-11-26 13:55:55 +08:00
Maikel
c152da8122
Merge pull request #3126 from mkllnk/2841-convert-guest-customer
...
2841 Associate customers with their user records
2018-11-26 13:56:31 +11:00
haseleyi
691de9199f
Add missing translation for 'Has Shopfront' in single-enterprise dashboard
2018-11-23 11:23:28 -08:00
dependabot[bot]
4499c38cfe
Bump unicorn-rails from 1.1.0 to 2.2.1
...
Bumps [unicorn-rails](https://github.com/samuelkadolph/unicorn-rails ) from 1.1.0 to 2.2.1.
- [Release notes](https://github.com/samuelkadolph/unicorn-rails/releases )
- [Commits](https://github.com/samuelkadolph/unicorn-rails/compare/v1.1.0...v2.2.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-23 19:14:51 +00:00
Maxim Colls
4b588cbfb0
Removed unused toggle helpers in spec/support
2018-11-23 16:47:55 +00:00
Pau Perez
2abb316bcc
Update Skylight from 1.6.1 to 1.7.1
...
This doesn't bring too many improvements but it's the latest version can
work on our Rails 3.2 version.
You can read the changelog at
https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md#170-april-24-2018 .
2018-11-23 17:31:53 +01:00
Pau Perez
453b2a99de
Rename redundant #restart_checkout to #call
2018-11-23 12:05:39 +01:00
Pau Perez
88afa70f37
Simplify and speed up service tests
2018-11-23 12:04:42 +01:00
Pau Perez
2c8a1f5e78
Check for value and not object identity in spec
2018-11-23 12:04:42 +01:00
Pau Perez
99463427ce
Refactor RestartCheckout service just extracted
2018-11-23 12:04:42 +01:00
Pau Perez
3b681a59ba
Move controller tests to service class tests
2018-11-23 12:04:42 +01:00
Pau Perez
a62a2cb52f
Extract #restart_checkout to a service
2018-11-23 12:04:42 +01:00
Maikel Linke
f4d5727fb4
Associate customers with their user records
...
When we introduced the Customer model, we didn't associate any existing
customers with users that have the same email address.
Later we decided to create that association when users sign up. But we didn't
update all the existing customers. We do that now for data consistency and to
solve several bugs.
2018-11-23 15:38:35 +11:00
Maikel Linke
95dbfae757
Use expect syntax
2018-11-22 15:42:56 +11:00
Maikel
be7fea9d14
Merge pull request #3003 from kevinchristianson/getting-started-edits
...
Getting Started edits
2018-11-22 12:51:16 +11:00
haseleyi
07e246db39
Remove outdated time zone precaution from Getting Started wiki
2018-11-21 15:56:14 -08:00
haseleyi
364a00074b
Remove Resources header
2018-11-21 15:56:14 -08:00
Kevin Christianson
7dce6e1180
Remove weird red "for" text in Troubleshooting
2018-11-21 15:56:14 -08:00
Kevin Christianson
1216567be9
Add Troubleshooting section with an alternative database setup
2018-11-21 15:56:13 -08:00
Samuel Nozaki
a7032a8822
Clarify that the time zone should be Melbourne
2018-11-21 15:56:13 -08:00
nozakis
6a73ee86f8
Clarify GETTING_STARTED.md in regards to rspec test failures and time zones
2018-11-21 15:56:13 -08:00
haseleyi
d4b49a662f
Add translation for 'Back to Payments List' button in new payment form
2018-11-21 15:33:45 -08:00
Matt-Yorkley
b3a9b502fa
Add missing translation key
2018-11-21 19:16:08 +00:00
Matt-Yorkley
a5407d780c
Include unexpected validation errors
2018-11-21 19:16:07 +00:00
Pau Pérez Fabregat
ac9cfaa8c3
Merge pull request #3093 from mllocs/fix/factories-ignore-warning
...
Fixed Factory warning while running tests
2018-11-21 14:44:03 +01:00
Pau Pérez Fabregat
6a1776b84a
Merge pull request #3053 from HugsDaniel/3050-products-new-views
...
[Defacepocalypse] Import products#new view into our codebase and apply overrides
2018-11-21 14:43:22 +01:00
luisramos0
783e0eed3c
In admin/users, convert Spree.t calls to t calls using lazy lookup and move translations to ofn's en.yml
2018-11-21 11:46:14 +00:00
luisramos0
0189cefd1c
Update all locales with the latest Transifex translations
2018-11-20 22:40:11 +00:00
Maxim Colls
f179bf8c49
Fixed Factory warning while running tests
2018-11-20 18:27:43 +00:00
Pau Pérez Fabregat
398092fa50
Merge pull request #3065 from openfoodfoundation/dependabot/bundler/turbo-sprockets-rails3-0.3.14
...
Bump turbo-sprockets-rails3 from 0.3.6 to 0.3.14
2018-11-20 12:13:23 +01:00
Pau Pérez Fabregat
4c6dec6203
Merge pull request #3082 from coopdevs/remove-travis-leftovers
...
Remove all database.travis.yml
2018-11-20 09:35:12 +01:00
Pau Perez
9301c5e1d5
Remove all database.travis.yml
...
We no longer use this file since we started with Semaphore CI.
2018-11-19 17:16:04 +01:00
Maikel
90e8813ff6
Merge pull request #3054 from coopdevs/fix/incorrect-order-dates
...
Fix/incorrect order dates
2018-11-19 09:17:11 +11:00
Maxim Colls
884d4d0122
Fixed specs
2018-11-17 19:46:09 +01:00
Maxim Colls
3301b5850a
Improved UX in the accordion steps in the checkout page
2018-11-17 18:48:10 +01:00
dependabot[bot]
e655e60b56
Bump turbo-sprockets-rails3 from 0.3.6 to 0.3.14
...
Bumps [turbo-sprockets-rails3](https://github.com/ndbroadbent/turbo-sprockets-rails3 ) from 0.3.6 to 0.3.14.
- [Release notes](https://github.com/ndbroadbent/turbo-sprockets-rails3/releases )
- [Commits](https://github.com/ndbroadbent/turbo-sprockets-rails3/compare/v0.3.6...v0.3.14 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-16 19:16:27 +00:00
Maikel
f593a70000
Merge pull request #2967 from openfoodfoundation/dependabot/bundler/unicorn-5.4.1
...
Bump unicorn from 4.9.0 to 5.4.1
2018-11-16 14:05:47 +11:00
dependabot[bot]
0d93705856
Bump unicorn from 4.9.0 to 5.4.1
...
Bumps [unicorn](https://bogomips.org/unicorn/ ) from 4.9.0 to 5.4.1.
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-16 02:00:48 +00:00
Pau Perez
23bda74ecb
Match name of filter and db column for consistency
2018-11-15 19:09:17 +01:00
Pau Perez
a4bbe2b696
Query completed_at filtering orders by date range
2018-11-15 19:09:17 +01:00
Pau Perez
c7a1c4b253
Change order date column translation in BOM
...
This makes it consistent with the order page. In both cases we use the
`completed_at` column underneath.
2018-11-15 19:09:17 +01:00
Hugo Daniel
a50786be34
Remove old do_not_remove_referenced_fees method
2018-11-15 17:59:06 +01:00
Hugo Daniel
0868404e98
Add specs for new Api::EnterpriseFeesController
2018-11-15 17:58:56 +01:00
Hugo Daniel
1309d80f65
Import products#edit and form partial in our codebase and apply overrides
2018-11-15 17:39:36 +01:00
Pau Pérez Fabregat
ee2ace8023
Merge pull request #3022 from HugsDaniel/2756-duplicate-product-with-image
...
Add specs for cloning a product with image
2018-11-15 17:35:28 +01:00
Hugo Daniel
094d88d03a
Import products#new view into our codebase and apply overrides
2018-11-15 16:35:31 +01:00
Hugo Daniel
d060704e86
Change Spree step-6a commit reference in Gemfile
2018-11-15 15:40:44 +01:00
Pau Perez
52e58a1c31
Remove unused @show_only_completed from view
...
Now there's no difference in behavior. In both cases we sort by
completed_at in the second column of the orders page.
2018-11-15 15:40:13 +01:00
Pau Perez
b7a3255dbe
Replace completed_at in orders table w/ created_at
2018-11-15 15:40:13 +01:00
Pau Perez
b1b04b505e
Fetch orders sorted by completion date
2018-11-15 15:40:13 +01:00
Pau Perez
e69d297f86
Wrap long and unreadable lines
2018-11-15 14:26:13 +01:00
Hugo Daniel
a162a2c50b
Move product distributions check as a before_destroy in EnterpriseFee model
2018-11-15 14:05:15 +01:00
Hugo Daniel
7b33712f7a
Add an API endpoint for EnterpriseFeesController#destroy
2018-11-15 14:05:08 +01:00
Hugo Daniel
4e29589be0
Add specs for cloning a product with image
2018-11-15 13:51:40 +01:00
Pau Pérez Fabregat
605f84d30a
Merge pull request #3010 from openfoodfoundation/transifex
...
Transifex
2018-11-14 11:27:01 +01:00
Pau Pérez Fabregat
8ee193dbcf
Merge pull request #2984 from Matt-Yorkley/email_https_links2
...
Specify only email link protocol setting
2018-11-14 11:26:14 +01:00
Pau Pérez Fabregat
e66f406ea6
Merge pull request #2946 from luisramos0/improve_taxons
...
Sort Product categories alphabetically by name
2018-11-14 11:23:59 +01:00
Transifex-Openfoodnetwork
f9fae06a7a
Updating translations for config/locales/en_BE.yml
2018-11-10 07:09:02 +11:00
Maikel
5c208a68c6
Merge pull request #3007 from openfoodfoundation/revert-2859-instagram_pattern
...
Revert "Instagram pattern"
2018-11-09 14:23:44 +11:00
Maikel
d8d20429aa
Revert "Instagram pattern"
2018-11-09 13:33:11 +11:00
Pau Pérez Fabregat
51a94c8194
Merge pull request #2964 from openfoodfoundation/dependabot/bundler/awesome_print-1.8.0
...
Bump awesome_print from 1.0.2 to 1.8.0
2018-11-07 18:48:32 +00:00
Pau Pérez Fabregat
72a9d39ee1
Merge pull request #2932 from luisramos0/2931-weight-calculator
...
2931 Refactor and prepare weight calculator for spree 2
2018-11-07 18:40:38 +00:00
Pau Pérez Fabregat
ecc69c2c58
Merge pull request #2948 from pfac/pfac-config-time-zone
...
Fix default time zone config
2018-11-07 18:39:25 +00:00
Matt-Yorkley
5b16353938
Specify only link protocol setting
2018-11-07 11:22:24 +00:00
luisramos0
b7ffde795a
Add migration to update calculator class name of weight calculators
2018-11-07 09:54:53 +00:00
luisramos0
9490da329a
Move Calculator::Weight from models/open_food_network/calculator to models/calculator
2018-11-07 09:54:30 +00:00
luisramos0
bf55f50a7e
Fix rubocop warnings on weight and weight_spec
2018-11-07 09:54:30 +00:00
luisramos0
275a192270
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/models/calculator/weight_spec.rb
* 3 conversions
from: == expected
to: eq(expected)
* 3 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-11-07 09:54:30 +00:00
luisramos0
1ef04354fd
Add capacity to weight calculator to calculate based on any object with an order (needed in spree 2 to calculate based on package)
2018-11-07 09:54:30 +00:00
Luis Ramos
0c02e8c15f
Merge pull request #2981 from coopdevs/remove-commented-out-code
...
Remove old commented out code
2018-11-06 16:06:59 +00:00
Luis Ramos
1ceb632b83
Merge pull request #2980 from coopdevs/fix-long-line
...
Fix long line
2018-11-06 16:05:22 +00:00
Pau Perez
51155bb368
Remove old commented out code
...
You know, git already keeps old code for us.
2018-11-06 14:23:15 +00:00
Pau Perez
26d95b7250
Fix long lines
2018-11-06 13:59:51 +00:00
Pau Pérez Fabregat
4155f086e0
Merge pull request #2968 from openfoodfoundation/transifex
...
Transifex
2018-11-05 19:40:33 +01:00
Transifex-Openfoodnetwork
98d79ec939
Updating translations for config/locales/fr_BE.yml
2018-11-05 18:46:40 +11:00
Maikel
4930c9bc06
Merge pull request #2934 from mkllnk/manual-rubocop-todo-config
...
Add offending files to rubocop config
2018-11-05 10:37:03 +11:00
Maikel Linke
7ad40074a5
Make Code Climate show our real score ans split rubocop config
...
Our rubocop config hides all current violations. It allows us to have a
passing rubocop run on the current code and improve it gradually. It
detects new violations, but doesn't annoy us with all the existing ones.
Code Climate has its own way of remembering all current violations which
is more sophisticated than ours. The new config for Code Climate doesn't
hide any violations so that Code Climate can give us a realistic score
of code quality and warn us about every new violation.
Splitting the configuration into the main three parts gives a quicker
overview and makes maintaining the parts easier.
2018-11-05 10:19:30 +11:00
Maikel Linke
e798532a2f
Add offending files to rubocop config
...
The file .rubocop_todo.yml is generated automatically and contains a
configuration to make all files pass. For a lot of cops it just lists
the offending files. But for some cops it sets a different metric.
Since we don't want these lax metrics, we override them in our config
file .rubocop.yml. This leads to a lot of offences again. This patch
lists all offending files for each cop to make rubocop pass. We can
improve the code over time and remove items from the list.
2018-11-05 10:11:35 +11:00
Pau Pérez Fabregat
3b85bbe911
Merge pull request #2923 from mkllnk/2882-extract-email-setup-in-specs
...
Extract email setup in specs for easy upgrade
2018-11-02 15:40:19 +01:00
Maikel
3259b3ecf1
Merge pull request #2912 from Matt-Yorkley/admin_orders_refactor
...
Admin orders refactor
2018-11-02 16:57:28 +11:00
Maikel
cbfe1b535d
Merge pull request #2871 from openfoodfoundation/dependabot/bundler/figaro-1.1.1
...
Bump figaro from 0.7.0 to 1.1.1
2018-11-02 12:09:53 +11:00
dependabot[bot]
6416d0e1c3
Bump awesome_print from 1.0.2 to 1.8.0
...
Bumps [awesome_print](https://github.com/awesome-print/awesome_print ) from 1.0.2 to 1.8.0.
- [Release notes](https://github.com/awesome-print/awesome_print/releases )
- [Changelog](https://github.com/awesome-print/awesome_print/blob/master/CHANGELOG.md )
- [Commits](https://github.com/awesome-print/awesome_print/compare/v1.0.2...v1.8.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-01 19:15:40 +00:00
Maikel
931c1207da
Merge pull request #2813 from openfoodfoundation/dependabot/bundler/haml-4.0.7
...
Bump haml from 4.0.4 to 4.0.7
2018-11-01 16:52:07 +11:00
Maikel
7c4370be69
Merge pull request #2963 from luisramos0/2960_migration
...
Fix variant_overrides permissions for overrides that belong to the supplier herself
2018-11-01 11:41:51 +11:00
luisramos0
079d4e0bf5
Fix variant_overrides permissions for overrides that belong to the supplier herself
2018-10-31 11:26:15 +00:00
Pau Pérez Fabregat
1fbeb43c3a
Merge pull request #2958 from coopdevs/pull-translations
...
Update all locales with the latest Transifex translations
2018-10-31 10:52:02 +01:00
Pau Pérez Fabregat
fc6a2d4a53
Merge pull request #2959 from coopdevs/fix-name-error-on-migrate
...
Move default_url_options set up to an initializer
2018-10-31 10:51:06 +01:00
Pau Perez
f16897a0b8
Fix DE translations manually
...
We don't want 🇩🇪 to have a broken menu.
2018-10-31 08:39:25 +01:00
Pedro Costa
1ddbc24a8b
Fix default time zone config
...
Why:
* Starting the environment, even with just `bundle exec rake`, results
in the following error:
```sh
Value assigned to config.time_zone not recognized.Run "rake -D time"
for a list of tasks for finding appropriate time zone names.
```
This change addresses the issue by:
* Adding the time zone setting to environment specific configurations,
defaulting to UTC in development, and using Melbourne in tests.
2018-10-30 23:50:23 +00:00
Pau Perez
2e2c7c56cb
Move default_url_options set up to an initializer
...
For some reason running `bundle exec rake db:migrate RAILS_ENV=staging`
fails with:
```
rake aborted!
NameError: uninitialized constant Spree::Config
```
Running `bundle exec rails server` for instance, does not. There must be
a difference on the way a rake task and the rails commands load the app.
Moving this configuration to an initializer, at the end of the
initialization process, fixes it. The constant `Spree::Config` is
already loaded.
**This is preventing the release v1.22.0 from being staged and tested**
2018-10-30 19:45:04 +01:00
luisramos0
3d106d749b
Fix rubocop warnings on load_sample_data task
2018-10-30 18:00:52 +00:00
luisramos0
82befd945b
Sort Product categories alphabetically by name and fixsample data by fixing taxons taxonomy id
2018-10-30 18:00:48 +00:00
Pau Pérez Fabregat
e4b988c9a2
Merge pull request #2924 from kristinalim/fix-disable_hiding_of_offcanvas_upon_resize
...
Disable hiding of hamburger menu upon resize <= 1024px width
2018-10-30 19:00:14 +01:00
Pau Pérez Fabregat
b35b24d4ae
Merge pull request #2914 from luisramos0/checkout-language-bug
...
Fix multi lingual issue in cart and checkout: the user language selection was not being used
2018-10-30 17:46:37 +01:00
Pau Pérez Fabregat
7ffa3a2ca1
Merge pull request #2913 from HugsDaniel/2905_password_reset_missing_translations
...
Add password confirmation, token and expired keys
2018-10-30 17:34:01 +01:00
Pau Pérez Fabregat
3d88199257
Merge pull request #2896 from Matt-Yorkley/email_https_links
...
Use https on all links in emails in production
2018-10-30 17:33:32 +01:00
Pau Pérez Fabregat
8e602d453b
Merge pull request #2876 from luisramos0/subs-states-fix
...
Fix bug in subscriptions address controller where country states were not correctly returned
2018-10-30 17:32:34 +01:00
Pau Perez
7f177598f2
Update all locales with the latest Transifex translations
2018-10-30 15:13:57 +01:00
Maikel
d63670d675
Merge pull request #2846 from Matt-Yorkley/pi/rename_enterprise_fields
...
[Product Import] Rename enterprise fields and update template
2018-10-30 15:11:02 +11:00
Maikel
7609496df3
Merge pull request #2859 from albarnaz/instagram_pattern
...
Instagram pattern
2018-10-30 15:10:27 +11:00
Maikel
ee042f51a4
Merge pull request #2949 from pfac/pfac-fix-new-preferences-migration
...
Fix new preferences migration
2018-10-30 15:09:35 +11:00
Pau Pérez Fabregat
5fade045f8
Merge pull request #2928 from luisramos0/line_items_controller_spec
...
Reorganize LineItemsController's destroy line item specs
2018-10-29 16:09:20 +01:00
Pedro Costa
91e4f99c19
Fix new preferences migration
...
Why:
* In a clean environment, running the new preferences migration fails,
due to a missing file from Spree core being manually required. This
file has now been missing since ab707cf .
This change addresses the issue by:
* Copying the missing file from Spree Core 1.3.6.beta into the migration.
This fixes the issue for now, but also means that a migration merge
and/or rewrite might be in order for the future.
2018-10-29 14:53:01 +00:00
Matt-Yorkley
443515dae4
Improve comment in index action
2018-10-29 10:34:05 +00:00
Matt-Yorkley
f3124e5472
Explicitly add :host to actionmailer config
2018-10-26 22:42:47 +01:00
Matt-Yorkley
b826beb0d7
Inline hashes in tests
2018-10-26 21:38:57 +01:00
Matt-Yorkley
29492d61f9
Use #allow syntax
2018-10-26 21:38:57 +01:00
Matt-Yorkley
8c19d1afec
Move tests from spree/admin/orders_controller_spec to api/orders_controller_spec and tidy up
2018-10-26 21:38:57 +01:00
Matt-Yorkley
033ae4f570
Add basic SearchOrders service spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
1f8f7b0495
Add new Api::OrdersController spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
46b1317159
Update orders resource js spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
334eebeab1
Move json to API and strip index action
2018-10-26 21:38:57 +01:00
Matt-Yorkley
0bd67bd06a
Remove unnecessary Spree::Config fallback value
2018-10-26 21:38:57 +01:00
Matt-Yorkley
77251848ee
Refactor Spree::Admin::OrdersController
2018-10-26 21:38:57 +01:00
luisramos0
09f8df6340
Reorganize LineItemsController's destroy line item specs to separate contexts with different test orders (completed_with_total and completed_with_fees)
2018-10-25 18:06:48 +01:00
Pau Pérez Fabregat
8a3f621b42
Merge pull request #2893 from luisramos0/deleted_products_break_inventory
...
Fix bug in inventory management page
2018-10-25 18:20:42 +02:00
Pau Pérez Fabregat
7cac4637fe
Merge pull request #2916 from luisramos0/date-transl-fix
...
Add Portuguese and German to list of momentJS locales
2018-10-25 18:18:53 +02:00
Kristina Lim
2cc594dc98
Proceed to hide off-canvas when resized to >1024px
2018-10-25 20:36:27 +08:00
Kristina Lim
14eaa49204
Disable hiding the off-canvas upon window resize.
...
In some browsers for mobile devices, the address bar is automatically
hidden when scrolling down the page. This is not workable if the height
of the contents of the off-canvas exceeds the height of the screen,
because the latter portion of the contents stays hidden to the user.
https://github.com/openfoodfoundation/angular-foundation/blob/0.9.0-20180826174721/src/offcanvas/offcanvas.js
2018-10-25 19:29:19 +08:00
Maikel
acb8ec772e
Merge pull request #2922 from mkllnk/update-rubocop-todo
...
Update rubocop todo list
2018-10-25 14:48:51 +11:00
Maikel
3cab3d1798
Merge pull request #2921 from openfoodfoundation/transifex
...
Transifex
2018-10-25 14:22:10 +11:00
Maikel Linke
cd5c23993a
Update rubocop todo list
...
Since we activated more cops in 0ac16ce096
we had a lot of files missing in the todo list. They are likely from
other pull requests that have been open at the same time. This is a
quick update so that rubocop gives us some useful feedback again.
2018-10-25 14:08:04 +11:00
Maikel Linke
e6adb8a3b9
Extract email setup in specs for easy upgrade
...
The way we set up email sending completely changes with Spree 2. This
change encapsulates that code in a single method so that it can be
changed easily and doesn't create further merge conflicts while we are
still working on the master branch and the Spree upgrade.
2018-10-25 13:53:22 +11:00
Maikel
51a1787881
Merge pull request #2908 from Matt-Yorkley/bulk_orders_bug
...
Fix pagination conflict with LineItemsCtrl requests
2018-10-25 13:18:11 +11:00
Maikel Linke
dc5302ca08
Speed up database queries and make them scale
...
This commit makes use of three ActiveRecord features:
1. Using `select` instead of `all.map` enables ActiveRecord to nest one
select into the other, resulting in one more efficient query instead of
two.
2. Using `find_each` saves memory by loading records in batches.
https://api.rubyonrails.org/classes/ActiveRecord/Batches.html#method-i-find_each
3. Using `pluck` creates only an array, avoiding loading all the other
columns of the records into objects.
Running this on the current Canadian database, fixes the following
variant overrides:
```
[]
[]
[]
[]
[]
[]
[925, 924, 966, 965]
[]
[]
[]
[]
[462,
863,
464,
822,
949,
947,
944,
939,
942,
946,
945,
943,
438,
937,
938,
941,
940,
467,
952,
875,
453,
953,
454,
951,
487,
460,
457,
528,
527,
486,
459,
458,
461,
529,
530,
950,
642,
384,
380,
643,
385,
381,
644,
386,
382,
960,
959,
379,
640,
377,
375,
532,
639,
376,
374,
646,
390,
389,
637,
406,
408,
647,
391,
393,
633,
396,
400,
398,
645,
388,
387,
648,
394,
392,
536,
632,
399,
397,
395,
634,
403,
401,
635,
404,
402,
636,
407,
405,
535,
534,
638,
410,
409,
948,
533,
537,
531,
877,
880,
894,
893,
672,
671,
673,
674,
703,
714,
715,
716,
717,
862,
864,
879,
876,
865,
881,
878,
463,
954,
866,
823,
957,
958,
955,
956,
899,
897]
[]
[969]
```
2018-10-25 11:33:14 +11:00
Transifex-Openfoodnetwork
c17939631f
Updating translations for config/locales/en_US.yml
2018-10-25 09:31:36 +11:00
Pau Pérez Fabregat
ce93c52dfe
Merge pull request #2850 from Matt-Yorkley/password_change_logout
...
Password change logout
2018-10-24 11:43:09 +02:00
Pau Pérez Fabregat
9ef4852bd4
Merge pull request #2818 from nikobozi/refactor-variant-overrides-query
...
Move query from variant_overrides_controller to its model scope
2018-10-24 11:42:22 +02:00
Pau Pérez Fabregat
7651ee0909
Merge pull request #2798 from as1729/as1729-update-docs-Stripe-publishable_key-for-pr
...
Better docs for Stripe.publishable_key and Stripe.endpoint_secret.
2018-10-24 11:23:21 +02:00
luisramos0
c9784a5eda
Add Portuguese and German to list of moment locales. The main usage is in the order cycle closure time in the shopfront
2018-10-23 17:53:08 +01:00
luisramos0
034d9ef72a
Refactor multilingual spec: extract method with repeated assertion
2018-10-23 14:10:52 +01:00
luisramos0
9d9f5d38d7
Fix multi lingual issue in cart and checkout: the user language selection was not being used
2018-10-23 14:10:48 +01:00
Hugo Daniel
c5f6af95c7
Add password confirmation, token and expired keys
2018-10-23 10:40:20 +02:00
Maikel
6f5289c730
Merge pull request #2894 from openfoodfoundation/transifex
...
Transifex
2018-10-23 16:21:20 +11:00
Matt-Yorkley
42c1584e6f
Fix pagination conflict with LineItemsCtrl requests
2018-10-22 18:13:56 +01:00
Pau Pérez Fabregat
a1bbf5328e
Merge pull request #2872 from mkllnk/2765-fix-geocoding
...
2765 Fix geocoding to display enterprises on map
2018-10-22 16:44:30 +02:00
luisramos0
d375bb8c55
Migration: Revoke variant overrides without permissions
2018-10-20 12:32:55 +01:00
luisramos0
9079437284
Add before_destroy to enterprise_relationship so that variant overrides are revoked when permission is deleted
2018-10-20 12:32:51 +01:00
luisramos0
5ae0ad87a7
Refactor EnterpriseRelationship before save hook: some renames and extract methods
2018-10-20 11:52:11 +01:00
Matt-Yorkley
c3cef699ca
Use https on all links in emails in production
2018-10-19 17:03:51 +01:00
Transifex-Openfoodnetwork
c911462737
Updating translations for config/locales/en_GB.yml
2018-10-20 02:04:33 +11:00
Maikel Linke
9698fd3c5a
Style spec
2018-10-18 11:07:16 +11:00
Maikel Linke
d197c8587f
Test address deletion
2018-10-18 11:06:32 +11:00
Maikel Linke
e96cab957a
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/models/spree/addresses_spec.rb
* 13 conversions
from: obj.should
to: expect(obj).to
* 2 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 1 conversion
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-10-18 10:52:46 +11:00
luisramos0
fe9f4a1c95
Move countryStates service from ofn.admin to admin.utils to remove bad dependency from admin modules (customers and subscriptions) to main ofn.admin module. Now the dependency admin.utils is used instead
2018-10-17 12:16:33 +01:00
luisramos0
c281927372
Fix subscription address form. It now clears the state selection when a different country is selected
2018-10-16 23:02:26 +01:00
luisramos0
1804bf5a2b
Extract countryStates logic from customer_address modal and re-use new CountryStates service
2018-10-16 22:45:38 +01:00
luisramos0
5c5a2194d6
Extract country states logic out of subscriptions address controller into new service CountryStates
2018-10-16 21:58:27 +01:00
luisramos0
feaf16d878
Fix bug in subscriptions address controller where the country id lookup was not exact and states returned were incorrect. Add unit tests to cover different cases
2018-10-16 20:59:34 +01:00
fabricio.albarnaz
419493f153
Move instagram regex to an method to fix codeclimate
2018-10-16 16:09:15 -03:00
fabricio.albarnaz
8e4adbd23a
Add more test cases
2018-10-16 15:34:46 -03:00
fabricio.albarnaz
93a051bf5a
Regex ajust
2018-10-16 15:33:10 -03:00
Pau Pérez Fabregat
590091c42a
Merge pull request #2842 from Matt-Yorkley/pi/missing_variable
...
Fix missing local variable in EntryProcessor
2018-10-16 13:19:23 +02:00
Maikel Linke
8fb81bb6a7
Configure Geocoder with API key as required by Google
2018-10-16 16:49:52 +11:00
Maikel Linke
61797fff56
Restrict deletion of address explicitely
...
Enterprises have an `address_id` which must point to a valid
`Spree::Address`. As Rubocop suggested, I restricted the deletion of
addresses when they are still associated to an enterprise.
Without declaring `dependent: :restrict`, trying to delete the address
would raise `ActiveRecord::InvalidForeignKey`. Now it is more specific
and raises `ActiveRecord::DeleteRestrictionError`.
I didn't find code rescuing the InvalidForeignKey when deleting addresses. I
actually think that we never delete addresses. So this change should not
have any impact on the execution.
2018-10-16 15:18:44 +11:00
Maikel Linke
a8705ca179
Simplify address methods
2018-10-16 14:49:36 +11:00
Maikel Linke
5021ed9c69
Simplify by using Rails tools
2018-10-16 14:49:35 +11:00
Maikel Linke
34849c441a
Reduce complexity and duplication
2018-10-16 14:48:12 +11:00
Maikel Linke
c4437a6437
Style address decorator
2018-10-16 14:48:12 +11:00
Maikel Linke
b109f6d78c
Remove temporary reporting code
2018-10-16 14:48:12 +11:00
fabricio.albarnaz
02bc134c59
Change befor save check to format validation
2018-10-15 17:51:33 -03:00
dependabot[bot]
dc6c8ec455
Bump figaro from 0.7.0 to 1.1.1
...
Bumps [figaro](https://github.com/laserlemon/figaro ) from 0.7.0 to 1.1.1.
- [Release notes](https://github.com/laserlemon/figaro/releases )
- [Changelog](https://github.com/laserlemon/figaro/blob/master/CHANGELOG.md )
- [Commits](https://github.com/laserlemon/figaro/compare/v0.7.0...v1.1.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-15 19:14:26 +00:00
Pau Pérez Fabregat
f8bccda6ab
Merge pull request #2847 from Matt-Yorkley/emails/validation
...
Emails/validation
2018-10-15 15:54:41 +02:00
Pau Pérez Fabregat
8946fe3ce8
Merge pull request #2829 from Matt-Yorkley/bi/results_per_page
...
Add per_page controls to admin orders index
2018-10-15 12:17:39 +02:00
Pau Pérez Fabregat
0e4a3dbc26
Merge pull request #2845 from coopdevs/fix-invalid-variant-creation
...
Fix invalid variant creation
2018-10-15 12:16:39 +02:00
Pau Pérez Fabregat
fe149967e4
Merge pull request #2521 from luisramos0/cookies_in_engine
...
[OFN Domains] Breaking OFN into domains - POC cookies inside an engine
2018-10-15 10:03:30 +02:00
Matt-Yorkley
fcff835922
Update results on dropdown select
2018-10-12 17:06:42 +01:00
Matt-Yorkley
a2828ea305
Use :for_hubs scope
2018-10-12 17:00:19 +01:00
Matt-Yorkley
123d1963ad
Remove duplicate method
2018-10-12 17:00:19 +01:00
Matt-Yorkley
3cb43121d5
Refactor long lines for new character limit
2018-10-12 17:00:18 +01:00
Matt-Yorkley
8fcaa54de7
Update CSV templates
2018-10-12 16:57:13 +01:00
Matt-Yorkley
bd4f0507ce
Adjustments for new Settings and ResetAbsent classes
2018-10-12 16:57:13 +01:00
Matt-Yorkley
1c85de6f58
Use producer and distributor for field names
2018-10-12 16:57:13 +01:00
Matt-Yorkley
2c9dc8899a
Update fields in specs
2018-10-12 16:57:13 +01:00
Matt-Yorkley
5c2b5377bc
Assign supplier_id when saving new product to products list
2018-10-12 16:57:13 +01:00
Matt-Yorkley
e7a909e828
Rename supplier to enterprise
2018-10-12 16:57:13 +01:00
Matt-Yorkley
8a0a33deec
Merge pull request #2858 from Matt-Yorkley/rubocop_line_limit
...
Increase rubocop line limit to 100
2018-10-12 16:52:37 +01:00
fabricio.albarnaz
6ad32fb66d
Add check for instagram.com
2018-10-11 18:05:18 -03:00
fabricio.albarnaz
e46b3566c3
Remove the check for www.instagram.com
2018-10-11 16:51:43 -03:00
fabricio.albarnaz
48720c835c
Add spec to instagram pattern
2018-10-11 16:30:17 -03:00
fabricio.albarnaz
e87075aed7
Add before save to check the instagram link pattern
2018-10-11 15:27:46 -03:00
Matt-Yorkley
57c6530e46
DRY code and use more flexible I18n
2018-10-11 16:38:14 +01:00
Matt-Yorkley
ebb03906cf
Increase rubocop line limit to 100
2018-10-11 15:37:38 +01:00
Pau Perez
60d05a941c
Fix variants with 'weight' and missing unit_value
...
This adds a data migration to fix those cases. It defaults to showing
1 unit of the specified weight. That is, if the user chose Kg, it'll
display 1 as unit.
Note that migration logs the process in a log/migrate.log file separate
from the regular Rails log/production.log file.
When you run the migration you'll see something like:
Fixing variants missing unit_value...
Processing variant 12...
Succesfully fixed variant 12
Done!
This helps auditing the changes applied and debug any possible failure
scenarios. You can delete it once all is ok.
2018-10-11 15:52:40 +02:00
Pau Perez
5bd375d422
Favor early return over dumb else branch
2018-10-11 15:52:40 +02:00
Pau Perez
c8c16f0e8a
Use Rails 3.2 validates syntax
2018-10-11 15:52:40 +02:00
Pau Perez
cbac916e66
Validate unit value when updating variant_unit
...
Variants whose product's variant_unit is weight or volume require
a unit_value.
2018-10-11 15:52:40 +02:00
Pau Perez
a2228d4131
Make ProductSet parseable by humans
...
Now it's imposible to understand what is really going on. Feels more
like assembler than Ruby.
2018-10-11 15:52:40 +02:00
Pau Perez
575d76e23e
Cover variant creation and update with basic tests
2018-10-11 15:52:40 +02:00
Pau Perez
d43726504b
Make #update_attributes parseable by humans
...
As it is this is impossible to follow.
2018-10-11 15:52:40 +02:00
Pau Perez
f54c69cbba
Add first test case for ProductSet
...
This covers creation and update of a product.
2018-10-11 15:52:40 +02:00
Pau Perez
2d60b3180e
Wrap and improve comment block readability
2018-10-11 15:52:40 +02:00
Matt-Yorkley
4760ebb80c
Use global config
2018-10-11 09:04:37 +01:00
Matt-Yorkley
dafcd0ddc2
Add per_page controls to admin orders index
2018-10-10 18:32:12 +01:00
Pau Pérez Fabregat
1bafa0cb7d
Merge pull request #2853 from mkllnk/remove-parallel-tests
...
Remove parallel tests
2018-10-10 16:01:44 +02:00
Pau Pérez Fabregat
227dd3e399
Merge pull request #2831 from kristinalim/fix-product_import_date_error
...
Fix product import date error when some but not all variants have import date
2018-10-09 16:37:25 +02:00
Pau Pérez Fabregat
85962158b8
Merge pull request #2821 from nikobozi/oc-clear-filter
...
Make 'Clear All' button work on order cycle page
2018-10-09 16:35:57 +02:00
Matt-Yorkley
900c65e0fc
Merge pull request #2855 from openfoodfoundation/transifex
...
Transifex
2018-10-09 14:21:14 +01:00
Matt-Yorkley
edca209f67
Merge pull request #2844 from Matt-Yorkley/bi/angular_orders_changing_page
...
Fix bindings on angular orders data
2018-10-09 14:15:38 +01:00
Transifex-Openfoodnetwork
c2c492cd6b
Updating translations for config/locales/es.yml
2018-10-09 21:57:06 +11:00
Matt-Yorkley
55411af3fa
Improve user account spec
2018-10-09 10:07:41 +01:00
Maikel Linke
245d900b58
Remove unused CI scripts
...
We used to have our own CI server, but now we are using Travis and
Semaphore. We don't need these scripts any more. And since
parallel_tests was removed in the previous commit, they are broken
anyway.
2018-10-09 17:06:59 +11:00
Maikel Linke
4cbc449a51
Remove unused parallel_tests gem
...
Reverts db47c01784
2018-10-09 16:54:08 +11:00
Pau Pérez Fabregat
5606550cd2
Merge pull request #2815 from openfoodfoundation/dependabot/bundler/rspec-retry-0.6.1
...
Bump rspec-retry from 0.5.6 to 0.6.1
2018-10-09 07:30:25 +02:00
Maikel
68c58dcb68
Merge pull request #2770 from openfoodfoundation/transifex
...
Transifex
2018-10-09 15:18:17 +11:00
Matt-Yorkley
3e39f3e749
Disable logout on password change
2018-10-08 23:06:54 +01:00
Matt-Yorkley
8f5fd41c8b
Update email confirmation address
2018-10-08 21:38:47 +01:00
Matt-Yorkley
3ec8c12899
Update account setting spec for updating email address
2018-10-08 20:41:59 +01:00
Pau Pérez Fabregat
ea6e522775
Merge pull request #2826 from 73VW/master
...
[README] Updated build status badge
2018-10-08 17:47:52 +02:00
Pau Pérez Fabregat
f5573f419b
Merge pull request #2778 from coopdevs/refactor-entry-processor
...
Refactor entry processor
2018-10-08 17:11:23 +02:00
Matt-Yorkley
37a7cceead
Fix bindings on angular orders data
2018-10-08 15:42:46 +01:00
Matt-Yorkley
b78716c283
Fix missing local variable
2018-10-08 14:49:29 +01:00
Transifex-Openfoodnetwork
8b59943256
Updating translations for config/locales/de_DE.yml
2018-10-08 16:58:01 +11:00
luisramos0
574f031020
Fix typo in matomo optout iframe url in cookies_policy_helper
2018-10-05 21:36:03 +01:00
Kristina Lim
da904c908d
Fix product import date when not all variants have it
2018-10-06 03:03:22 +08:00
Pau Pérez Fabregat
58a99a7f89
Merge pull request #2692 from Matt-Yorkley/bi/angular_orders
...
Angularise orders page
2018-10-04 21:10:48 +02:00
73VW
7a1cffb4b5
Updated build status badge
2018-10-04 18:43:30 +02:00
Pau Pérez Fabregat
b139f3839a
Merge pull request #2806 from luisramos0/rep
...
Delete representative_view dependency, not used
2018-10-04 13:02:35 +02:00
niko
f99ed81863
Make 'Clear All' button work on order cycle page
2018-10-04 11:46:38 +02:00
niko
f65d3c2815
fix rubocop issue
2018-10-04 03:30:32 +02:00
niko
3ae38178a3
Move query from variant_overrides_controller to its model scope
2018-10-04 02:43:02 +02:00
dependabot[bot]
8a6da745a3
Bump rspec-retry from 0.5.6 to 0.6.1
...
Bumps [rspec-retry](https://github.com/noredink/rspec-retry ) from 0.5.6 to 0.6.1.
- [Release notes](https://github.com/noredink/rspec-retry/releases )
- [Changelog](https://github.com/NoRedInk/rspec-retry/blob/master/changelog.md )
- [Commits](https://github.com/noredink/rspec-retry/compare/v0.5.6...v0.6.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-02 19:15:12 +00:00
dependabot[bot]
4e1521fd6a
Bump haml from 4.0.4 to 4.0.7
...
Bumps [haml](https://github.com/haml/haml ) from 4.0.4 to 4.0.7.
- [Release notes](https://github.com/haml/haml/releases )
- [Changelog](https://github.com/haml/haml/blob/master/CHANGELOG.md )
- [Commits](https://github.com/haml/haml/compare/4.0.4...4.0.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-02 19:13:34 +00:00
luisramos0
daafe73d81
Delete representative_view dependency, not used
2018-10-02 15:11:13 +01:00
Pau Pérez Fabregat
aa78b9e54c
Merge pull request #2777 from coopdevs/setup-simplecov
...
Setup simplecov
2018-10-02 14:39:43 +02:00
Pau Pérez Fabregat
6ddcb01b7c
Merge pull request #2736 from openfoodfoundation/dependabot/bundler/oj-3.6.10
...
Bump oj from 2.1.2 to 3.6.10
2018-10-02 14:38:26 +02:00
Matt-Yorkley
55d7d5d1e4
Rename #capture_path to #payment_capture_path
2018-10-02 11:10:51 +01:00
Matt-Yorkley
017e3d14df
Use variable colour assignment
2018-10-02 11:10:21 +01:00
Pau Perez
6a7359a3c5
Pass supplier_ids in strategy #reset instead
...
This removes the need to expose supplier_ids through #<< and makes both
ResetAbsent and its strategies simpler.
This could be made even simpler if the strategies just implemented
`#relation` as public method and ResetAbsent called `#update_all` on
them. The data to be fetched is the only thing that changes but the
update is the same.
2018-10-01 17:37:49 +02:00
Pau Perez
82654cd1ee
Turn delegation to a reader to make it simpler
...
This makes the solution less smart and as a result ResetAbsent improves
it's consistency and returns always an integer.
2018-10-01 16:40:34 +02:00
Pau Perez
148321f7b7
Make strategies class names more explicit
2018-10-01 16:40:34 +02:00
Pau Perez
af93af1a64
Replace strategy with a more explicit name
2018-10-01 16:40:34 +02:00
Pau Perez
8715fce295
Remove @import_settings in favor of Settings
2018-10-01 13:12:06 +02:00
Pau Perez
fd69c7672d
Add specs for ResetAbsent strategies
...
This also fixes the case where there are no overrides to exclude.
2018-10-01 13:12:06 +02:00
Pau Perez
d527f6265a
Remove pointless sum
2018-10-01 13:12:06 +02:00
Pau Perez
5eb10edbfd
Inject #updated_ids to strategy
...
Their values are known beforehand.
2018-10-01 13:12:06 +02:00
Pau Perez
186801a1e2
Remove unused supplier_ids argument
2018-10-01 13:12:06 +02:00
Pau Perez
718f529ede
Use nested module in test to improve readability
2018-10-01 13:12:06 +02:00
Pau Perez
f04fa4ed63
Do not treat ResetAbsent as a decorator anymore
...
This fully encapsulates it's logic and reduces its tight coupling with
EntryProcessor.
2018-10-01 13:12:06 +02:00
Pau Perez
95ae18a1ba
Remove method delegation
2018-10-01 13:12:06 +02:00
Pau Perez
54d6bc5443
Don't use importing_into_inventory? in ResetAbsent
...
This completely decouples ResetAbsent from the particular strategy used.
2018-10-01 13:12:06 +02:00
Pau Perez
a10e58e20a
Inject strategy_factory into ResetAbsent
2018-10-01 13:12:06 +02:00
Pau Perez
a9444b8909
Extract InventoryReset and Products strategies
...
Extract this strategy classes from ResetAbsent and move #reset there.
2018-10-01 13:12:06 +02:00
Pau Perez
8d7a11b0ac
Make all steps of the algorithm have 2 branches
2018-10-01 13:12:06 +02:00
Pau Perez
23471346b6
Do not call ResetAbsent when preconditions not met
2018-10-01 13:12:06 +02:00
Pau Perez
a409353d37
Move import_settings query methods to Settings
2018-10-01 13:12:06 +02:00
Pau Perez
fd84bea463
Test that variants or overrides are actually reset
2018-10-01 13:12:06 +02:00
Pau Perez
b940f06238
Return early if reset_all_absent is not set
...
No need to go through half of the algorithm if the setting is not
enabled. It does not change per enterprise.
This also assumes "Previously we were updating both (products and inventory)
at the same time during one import, but now it's one or the other" in
Matt's words.
2018-10-01 13:12:06 +02:00
Pau Perez
c955e151b7
Pass enterprise ids as strs as current code does
2018-10-01 13:12:06 +02:00
Pau Perez
e04162415a
Move code comment to be the method's doc
2018-10-01 13:12:06 +02:00
Pau Perez
5ac3598550
Inject Settings object in ResetAbsent
2018-10-01 13:12:06 +02:00
Pau Perez
b5766a2dd9
Extract common conditional clauses
...
This also turns local vars into ivars so that the behaviour can be
thoroughly tested. These ivars are meant to be removed once this class
is refactored further. Now there's no other way to ensure its state.
2018-10-01 13:12:06 +02:00
Pau Perez
ed073e9750
Rely on Settings and don't access internal struct.
2018-10-01 13:12:06 +02:00
Aditya Sridhar
372ae8e4aa
updated the spacing to be consistent.
2018-09-30 16:10:57 -04:00
Aditya Sridhar
06b28c1ab4
Better docs for Stripe.publishable_key and Stripe.endpoint_secret.
2018-09-30 15:50:33 -04:00
Pau Perez
663db47433
Move products_reset_count to ResetAbsent
2018-09-29 10:57:23 +02:00
Pau Perez
3150741849
Extract ResetAbsent class from EntryProcessor
2018-09-29 10:57:18 +02:00
luisramos0
3cf10020bf
Fix bug on slow page loads where banner and policy modal were both loaded
...
This solution makes the banner aware of the policy modal: the banner doesnt open if the policy modal is enabled
2018-09-27 17:47:36 +01:00
Pau Perez
16badcd1b5
Setup Simplecov to have code coverage analysis
...
This enables code coverage analysis when running specs in your dev
environment. Simply run them as usual and you'll see a line like the
following at the end of the output:
Coverage report generated for RSpec to /home/pau/dev/openfoodnetwork/coverage
Simply browse to coverage/index.html and the results in a web UI.
This is a useful tool that helps you decide if the tests you added are
enough or not.
2018-09-27 15:57:02 +02:00
Matt-Yorkley
54b17ac701
Use Spree::Order.pending_payments and remove service
2018-09-27 13:04:56 +01:00
Maikel
d488ae3f44
Merge pull request #2725 from mkllnk/2699-email-confirm-jobs
...
2699 email confirm jobs
2018-09-27 14:27:43 +10:00
Maikel Linke
f0021be53c
Style I18n call
2018-09-27 13:33:09 +10:00
Maikel Linke
af1ac333df
Create MailMethod before User when seeding
2018-09-27 13:33:09 +10:00
Maikel Linke
9dcc683dc0
Notify Bugsnag on sign-up errors
...
This may lead to more error reports than we want to see. A not existing
email address may cause Bugsnag to be notified. If this happens, we can
rescue form these specific errors and only report the rest.
2018-09-27 13:33:09 +10:00
Maikel Linke
17d951f99d
Rescue from any sign-up errors
...
The most common failure would happen when sending the confirmation email
triggered by `user.save`. We rescue any errors here and give feedback to
the user.
This allows for immediate feedback when the user types an email address
that is not accepted by our mail server or the email setup is not
configured properly.
2018-09-27 13:33:08 +10:00
Maikel Linke
3ae073dce5
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/controllers/user_registrations_controller_spec.rb
* 10 conversions
from: obj.should
to: expect(obj).to
* 7 conversions
from: == expected
to: eq(expected)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-09-27 13:33:08 +10:00
Maikel Linke
600c8fcd4c
Send confirmation emails immediately
...
Using deferred methods on the user model breaks delayed jobs when the
user is deleted while the job still exists. We could create a proper job
referencing a user id for sending these emails instead. But since the
user has to wait for the confirmation email anyway, we can send it
within the current request. This should be revised if performance
becomes an issue.
Sending the email directly also has the advantage that we can tell the
user if emailing failed. See the following commits.
This change impacts a bunch of specs as we now need a working email
setup to create unconfirmed users. This commit introduces a custom
matcher to unify testing for confirmation emails.
2018-09-27 13:33:08 +10:00
luisramos0
921105301c
Move angular-templates route and controller into Web engine
...
The route and controller were in the main app and the views in the engine, with this commit they stay all inside the engine
This is done to keep it simple and remove the unnecessary dependency between main app and engine
If we use this mechanism in the future for other things in the main app or other engines, we can find a way to extract/abstract this
2018-09-26 12:39:51 +01:00
luisramos0
b1c7e6c091
Fix assets precompilation by including web/all.js and web/all.css in the assets precompilation list in application.rb
2018-09-26 12:30:45 +01:00
luisramos0
a23b1b980d
Make Web engine an isolated namespace engine mounted on / (without /web prefix)
...
This approach is better to separate concerns, see “Isolated Engine” here: https://api.rubyonrails.org/v3.2/classes/Rails/Engine.html
2018-09-26 12:30:06 +01:00
Matt-Yorkley
2dcc8ea4bb
Add spec for pending payments service
2018-09-25 10:05:32 +01:00
Matt-Yorkley
e93d46e75a
Use .find instead of .select().first
2018-09-25 09:35:05 +01:00
Maikel
51f9a0afa1
Merge pull request #2562 from Matt-Yorkley/pi/product_attributes
...
[Product Import] Product attributes
2018-09-25 11:36:03 +10:00
Maikel
bf1f2b93c6
Merge pull request #2768 from coopdevs/fire-unused-users-task
...
Remove no longer used rake task
2018-09-25 11:30:04 +10:00
Transifex-Openfoodnetwork
97775c0bc1
Updating translations for config/locales/fr_CA.yml
2018-09-25 06:12:48 +10:00
Matt-Yorkley
1d9243af19
DRY and clarify serializer and service
2018-09-24 16:58:43 +01:00
Pau Perez
4a7ee9b91e
Remove no longer used rake task
2018-09-24 17:17:10 +02:00
Matt-Yorkley
6f2760cf92
Move translations into their namespace and use '.key' format
2018-09-24 15:54:05 +01:00
Pau Perez
f743b5f02f
Extract Settings from Product Import processor
...
This encapsulates the data structure used by the entry processor to
check various settings. It still requires a lot of work to move more
logic to this new class.
2018-09-24 13:55:33 +02:00
Pau Pérez Fabregat
b8417058b4
Merge pull request #2741 from coopdevs/refactor-checkout-process-bits
...
Refactor checkout process bits
2018-09-24 12:08:19 +02:00
Maikel
9d48ea7b62
Merge pull request #2759 from luisramos0/del_old_spec_helper
...
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-24 11:25:51 +10:00
Matt-Yorkley
9f57b43a13
Move sortble header elements to a partial
2018-09-23 22:14:12 +01:00
Maikel
f0bb927020
Merge pull request #2734 from coopdevs/make-rubocop-useful
...
Get useful feedback from Rubocop Metrics cops
2018-09-23 19:48:05 +10:00
Maikel
89be54f79e
Merge pull request #2750 from openfoodfoundation/transifex
...
Transifex
2018-09-22 16:05:04 +10:00
Transifex-Openfoodnetwork
7175434910
Updating translations for config/locales/en_US.yml
2018-09-22 01:25:48 +10:00
Maikel
e2fd5a36d8
Merge pull request #2757 from luisramos0/delete_dead_specs
...
Deleted sample specs and one pending spec
2018-09-21 15:41:49 +10:00
luisramos0
33d2b65d65
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-20 23:01:23 +01:00
luisramos0
2a68184c01
Deleted unused test helper for rabl views
2018-09-20 20:09:14 +01:00
Pau Pérez Fabregat
20077c99b5
Merge pull request #2618 from coopdevs/enable-style-send-cop
...
Favor #public_send over #send using Rubocop's cop
2018-09-20 19:03:40 +02:00
Pau Pérez Fabregat
3dd1fcbc72
Merge pull request #2749 from luisramos0/delete-li-ship-method-name
...
Drop unused db column line_items.shipping_method_name
2018-09-20 13:26:26 +02:00
Matt-Yorkley
897e43fe0b
Remove Spree's Deface data-hooks from new view
2018-09-20 11:33:22 +01:00
Maikel Linke
5763bf0518
Update all translations
2018-09-20 10:33:02 +10:00
luisramos0
0e6b0aa248
Deleted sample specs and one pending spec
2018-09-19 23:45:00 +01:00
Matt-Yorkley
fc68e28e4d
Add :description to non-updatable attributes list
2018-09-19 22:30:10 +01:00
Matt-Yorkley
ebb18e9394
Remove unneccesary method
2018-09-19 21:12:30 +01:00
Matt-Yorkley
cc98cc832c
Prefer #public_send over #send
2018-09-19 21:12:30 +01:00
Matt-Yorkley
b57c6cf9ac
Add errors when attempting to update non-updatable fields
2018-09-19 21:12:29 +01:00
Pau Perez
0ac16ce096
Get useful feedback from Rubocop Metrics cops
...
One of the biggest pros of linters like Rubocop is to get valuable feedback to
help write better code. The way we have Rubocop configured now we don't prevent
new code from adhere improved code quality and this is specially important when
touching code that already suffers from complexity.
Without all Rubocop's Metrics cops enabled there's no way to get this insights
and write better code. This enables them while regenerating the
`.rubocop_todo.yml` to hide the current violations.
So, next time we touch existing code that we think could be simpler, we should
go to `.rubocop_todo.yml` and remove any occurrences of the file in question.
This way we could Rubocop's feedback right in the editor. This is tremendously
helpful when refactoring. It shows you where to start.
2018-09-19 19:27:40 +02:00
Pau Pérez Fabregat
62bebdb15e
Merge pull request #2698 from openfoodfoundation/dependabot/bundler/uglifier-4.1.19
...
[Security] Bump uglifier from 2.7.1 to 4.1.19
2018-09-19 18:02:06 +02:00
Pau Perez
a2b3d8372e
Reduce complexity of OrderUpdater decorator
2018-09-19 16:03:33 +02:00
Transifex-Openfoodnetwork
454cd8bfbf
Updating translations for config/locales/nb.yml
2018-09-19 22:30:06 +10:00
HugsDaniel
c4d4b52668
Merge pull request #2742 from openfoodfoundation/transifex
...
Transifex
2018-09-19 14:18:03 +02:00
Matt-Yorkley
3cbb576b4f
Move payment object logic out of order serializer and delete code
2018-09-19 13:00:30 +01:00
Matt-Yorkley
ba254802f8
Move angular_pagination to /views/admin/shared/
2018-09-19 13:00:30 +01:00
Matt-Yorkley
9ce32e3c14
Add new ordersCtrl spec
2018-09-19 13:00:30 +01:00
Matt-Yorkley
64620c2797
Tidy up response formats for easier testing
2018-09-19 13:00:30 +01:00
Matt-Yorkley
6768055b4d
Split orders into 2 angular controllers
2018-09-19 13:00:30 +01:00
Matt-Yorkley
b2551b4e0b
Rewrite existing specs
2018-09-19 13:00:30 +01:00
Matt-Yorkley
68f0c80016
Add loading message and spinner
2018-09-19 13:00:30 +01:00
Matt-Yorkley
9da6a5a9b3
Add column sorting to table
2018-09-19 13:00:30 +01:00
Matt-Yorkley
2112f296e4
Angularise filters
2018-09-19 13:00:30 +01:00
Matt-Yorkley
3b9d9db16b
Add pagination
2018-09-19 13:00:29 +01:00
luisramos0
524f9af148
Drop unused db column line_items.shipping_method_name
2018-09-19 11:38:19 +01:00
Matt-Yorkley
93d273f94a
Convert orders index table to use angular ng-repeat
2018-09-19 09:33:25 +01:00
Transifex-Openfoodnetwork
f0d015be0d
Updating translations for config/locales/de_DE.yml
2018-09-19 08:34:42 +10:00
Transifex-Openfoodnetwork
258347bc63
Updating translations for config/locales/fr.yml
2018-09-19 01:45:12 +10:00
Pau Pérez Fabregat
9f7d24934d
Merge pull request #2671 from kristinalim/translations-any_enterprise_in_oc_filters
...
Translate "Any Enterprise" and "Any Schedule" in OC filters
2018-09-18 11:42:19 +02:00
Pau Perez
2a0e0eed73
Move state_machine's additions inside class_eval
...
And also cover them with tests.
2018-09-18 11:20:32 +02:00
Pau Perez
1fdc578901
Increase readability (a bit) of OrderUpdater
2018-09-18 11:20:32 +02:00
Pau Perez
99cdeca0b1
Remove useless RSpec context block
2018-09-18 11:20:32 +02:00
Pau Perez
13f73b4512
Test :restart_checkout state machine event
2018-09-18 11:20:32 +02:00
Maikel
19df4ff640
Merge pull request #2701 from mkllnk/2700-improve-product-refresh-scheduling
...
2700 improve product refresh scheduling
2018-09-18 12:09:24 +10:00
dependabot[bot]
ccf7d91487
Bump oj from 2.1.2 to 3.6.10
...
Bumps [oj](https://github.com/ohler55/oj ) from 2.1.2 to 3.6.10.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/commits/v3.6.10 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-17 19:16:27 +00:00
luisramos0
c22ac0086b
Moved cookies_policy_helper to Web engine and respective spec
2018-09-17 16:05:38 +01:00
luisramos0
95f2f92cf3
Extracted cookies footer links from view to footer links helper
2018-09-17 16:05:38 +01:00
luisramos0
bded530137
Moved web api endpoint from /api to /web/api
2018-09-17 16:05:38 +01:00
luisramos0
dc5eb6448e
Change web/all.css from sprockets to SASS and include web/all.css through darkswarm/all.css
2018-09-17 16:05:38 +01:00
luisramos0
d170a4d489
New domain Web (rails engine) with the following features extracted from the main app:
...
- cookies banner
- cookies policy page
- cookies policy and privacy policy links in the footer
2018-09-17 16:05:32 +01:00
Matt-Yorkley
e577bcb46f
Prepare angular controller and serialized data
2018-09-17 14:18:23 +01:00
Pau Pérez Fabregat
0f627cdf39
Merge pull request #2661 from kristinalim/translations-copy_of_order_cycle
...
Translate "COPY OF" when cloning an OC
2018-09-17 12:38:29 +02:00
Pau Pérez Fabregat
0520f2187c
Merge pull request #2540 from luisramos0/delete_dead_store
...
removed assets related to spree store: dead code
2018-09-17 11:33:56 +02:00
Kristina Lim
798a6ed391
Translate more text in OC filters
2018-09-17 10:09:17 +10:00
Maikel Linke
ac85b90315
Clarify private class method declaration
2018-09-15 10:18:54 +10:00
Maikel
ce7be68fac
Merge pull request #2660 from kristinalim/translations-failed_oc_creation
...
Translate and fix fallback errors when creating or updating OC
2018-09-14 16:58:39 +10:00
dependabot[bot]
05225aaba7
[Security] Bump uglifier from 2.7.1 to 4.1.19
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 2.7.1 to 4.1.19. **This update includes security fixes.**
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v2.7.1...v4.1.19 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-14 06:29:22 +00:00
Maikel
c3f461ad6e
Merge pull request #2622 from openfoodfoundation/dependabot/bundler/db2fog-0.9.0
...
Bump db2fog from 0.8.0 to 0.9.0
2018-09-14 16:26:54 +10:00
Maikel
e836ac0234
Merge pull request #2686 from HugsDaniel/2593_customize_user_guide_link
...
Enable setting a customized user guide link in general settings
2018-09-14 15:46:05 +10:00
Maikel
beedd933e9
Merge pull request #2512 from kristinalim/feature-remove_enterprise_images
...
Support removal of enterprise logo and promo image
2018-09-14 15:07:24 +10:00
Maikel
eabb9f4574
Merge pull request #2659 from kristinalim/translations-admin_area_fixes
...
Simple translation fixes for admin area and profile page
2018-09-14 14:38:25 +10:00
Maikel
da2f278060
Merge pull request #2649 from kristinalim/translations-fix_store_link_in_admin_header
...
Fix i18n translation for Store link in admin header for `fr`
2018-09-14 14:24:29 +10:00
Maikel
43a3ecff06
Merge pull request #2612 from openfoodfoundation/dependabot/bundler/jwt-1.5.6
...
Bump jwt from 1.5.4 to 1.5.6
2018-09-14 14:13:02 +10:00
Maikel
514f64c8d0
Merge pull request #2650 from kristinalim/translations-more_admin_header
...
Add "more" translation key
2018-09-14 13:31:13 +10:00
Maikel
6b56def649
Merge pull request #2697 from mkllnk/2655-fix-admin-payments
...
2655 fix admin payments
2018-09-14 11:26:20 +10:00
Maikel
1000bd4d24
Merge pull request #2658 from kristinalim/translations-order_and_shipment_emails
...
Allow fixing and customizing translations for order cancellation and shipment emails
2018-09-14 10:11:56 +10:00
Hugo Daniel
8dd0e01b8e
Use explicit syntax for section objects in preference_sections definition
2018-09-13 12:34:06 +02:00
Maikel Linke
ec953e1db0
Style cache refreshment class
2018-09-13 17:22:01 +10:00
Maikel Linke
2e635f94f6
Make job queuing more robust and efficient
2018-09-13 17:20:11 +10:00
dependabot[bot]
b676bfdcc8
Bump jwt from 1.5.4 to 1.5.6
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 1.5.4 to 1.5.6.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v1.5.4...v1.5.6 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-13 02:34:11 +00:00
Maikel
065df96872
Merge pull request #2675 from Matt-Yorkley/bi/remake_views
...
Remake orders index view
2018-09-13 12:29:54 +10:00
Maikel
5e722bf57d
Merge pull request #2634 from luisramos0/cookies_matomo_optout
...
[Cookies] Adds matomo optout iframe to cookies policy page
2018-09-13 12:29:09 +10:00
Maikel
f46c1e8414
Merge pull request #2424 from frank-west-iii/issue-2100-mini-racer
...
Replace therubyracer with mini_racer
2018-09-13 12:28:03 +10:00
Maikel Linke
81f60aab46
Make PaymentMethod serialisable with fees
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/2655
2018-09-13 12:01:17 +10:00
Maikel Linke
d7b19750e5
Add spec for GH issue #2655
2018-09-13 12:01:16 +10:00
Maikel Linke
a447fe4f40
Require lib file where needed
...
We can't always rely on other parts of the code been loaded first. We
need to declare dependencies so that they are always present.
I just ran into this problem in my dev environment.
2018-09-13 12:01:16 +10:00
luisramos0
478dd68072
In cookies policy helper, added string interpolation to variable to avoid variable (Spree::Config entry) to break the concatenation. Added unit test to validate the error case
2018-09-12 18:30:24 +01:00
luisramos0
409f084bd4
Added matomo opt out iframe to cookies policy page
2018-09-12 18:30:24 +01:00
Pau Pérez Fabregat
3f5c799166
Merge pull request #2648 from kristinalim/fix-ask_anonymous_users_to_login_for_order_page
...
Fix ask anonymous users to login for order page
2018-09-12 16:17:34 +02:00
Hugo Daniel
cc43d789e2
Refacto edit method for content controller and enable custom user guide link
2018-09-12 14:51:53 +02:00
dependabot[bot]
91c0de3f2a
Bump db2fog from 0.8.0 to 0.9.0
...
Bumps [db2fog](https://github.com/itbeaver/db2fog ) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/itbeaver/db2fog/releases )
- [Changelog](https://github.com/itbeaver/db2fog/blob/master/CHANGELOG.md )
- [Commits](https://github.com/itbeaver/db2fog/commits/v0.9.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-12 11:09:57 +00:00
Pau Pérez Fabregat
e474271698
Merge pull request #2637 from Vadlusk/remove_css_splitter
...
Remove duplicate css_splitter references, delete split css file.
2018-09-12 13:07:15 +02:00
Pau Pérez Fabregat
64e71a1ee7
Merge pull request #2544 from kristinalim/fix-scrolling_in_modals
...
Fix top position, height, and scrolling with modals
2018-09-12 13:05:20 +02:00
Matt-Yorkley
4d9ebf0550
Apply submenu override
2018-09-11 12:17:28 +01:00
Matt-Yorkley
f08d6389d8
Apply capture order override
2018-09-11 12:06:58 +01:00
Matt-Yorkley
507f4d0878
OCD tidy up of visually misaligned filter
2018-09-11 11:53:37 +01:00
Matt-Yorkley
afedaea2b5
Apply special instructions override
2018-09-11 11:49:28 +01:00
Matt-Yorkley
8f174b1308
Apply ship shortcut override
2018-09-11 11:43:38 +01:00
Matt-Yorkley
ba0701457e
Apply distributor td override
2018-09-11 11:42:08 +01:00
Matt-Yorkley
6389c552ca
Apply distributor th override
2018-09-11 11:41:25 +01:00
Matt-Yorkley
1958ac9932
Apply distributor filter inputs override
2018-09-11 11:39:05 +01:00
Matt-Yorkley
c7e2f817ed
Apply colgroup override
2018-09-11 11:34:34 +01:00
Matt-Yorkley
5a2491cb47
Apply ng-app override
2018-09-11 11:30:14 +01:00
Matt-Yorkley
980c46c63f
Convert Spree view to HAML
2018-09-11 11:22:54 +01:00
Kristina Lim
02a909c1b1
Do not use image_tag for enterprise image previews
...
If Rails config.assets.compile is false and config.assets.digest is
true, which is the case for staging and production, image_tag fails when
the image file is not found.
We do not need sprockets to ensure presence of the image file for these
tags, because the correct SRC values are assigned through the JS.
Inserting HTML should be sufficient.
2018-09-08 23:23:49 +08:00
Maikel
5e0997d03e
Merge pull request #2635 from apoc64/timezone_comments
...
Adds comments for setting up timezone in application.yml
2018-09-08 15:55:16 +10:00
Kristina Lim
003e65fbed
Translate error when failing to create order cycle
2018-09-08 02:15:52 +08:00
Kristina Lim
2c2dd62f6a
Translate "COPY OF" when cloning an OC
2018-09-08 02:06:52 +08:00
Kristina Lim
9dcdb67352
Translate inherits_properties label in product form
2018-09-08 01:37:57 +08:00
Kristina Lim
fc79aae17c
Translate authorized shops headers in account page
2018-09-08 00:34:47 +08:00
Kristina Lim
c64acf47ab
Fix translation key for "involving" in OC filters
2018-09-07 21:38:44 +08:00
Kristina Lim
86f4a118dd
Translate placeholder for order cycle name filter
2018-09-07 17:58:34 +08:00
Kristina Lim
40443b19f1
Add translations for headers in enterprise index
...
This is for the view when logged in as enterprise manager.
The translations added are:
* Producer?
* Package
* Status
2018-09-07 17:51:08 +08:00
Kristina Lim
2cf608ffdf
Add translations for shipment emails
2018-09-07 17:08:12 +08:00
Kristina Lim
f1d5088aaa
Add translations for order cancellation emails
2018-09-07 17:01:43 +08:00
Maikel
62f5228f1f
Merge pull request #2643 from luisramos0/transifex_manual
...
Fetched latest translations from transifex with tx pull --force
2018-09-07 16:46:24 +10:00
Maikel
3e0c74494d
Merge pull request #2604 from Matt-Yorkley/pi/updating_variants_bug
...
Pi/updating variants bug
2018-09-07 15:10:18 +10:00
Maikel Linke
d6c2a36451
Blacklist libv8 version that breaks mini_racer
2018-09-07 14:11:33 +10:00
Frank West
b9fe1ced16
Replace therubyracer with mini_racer
...
This is being replaced to increase the reliability and speed of asset
compilation.
2018-09-07 14:11:30 +10:00
Maikel
937da277f7
Merge pull request #2628 from openfoodfoundation/dependabot/bundler/rubyzip-1.2.2
...
[Security] Bump rubyzip from 1.2.1 to 1.2.2
2018-09-07 10:51:41 +10:00
Kristina Lim
d06bccb832
Change i18n key for Store link in admin header
...
spree_i18n translates the "store" key in different ways, sometimes like
"shop" and sometimes like "save". This could be because of a clash in
usage between Spree add-ons.
To be more specific, the "Store" link in the admin section now uses the
"admin.header.store" translation key.
2018-09-06 22:03:39 +08:00
Kristina Lim
6d5f8553ef
Add "more" translation key
...
This is used in places such as the adaptive menu in the admin section.
This is actually included in spree_i18n but not correctly translated for
fr.
2018-09-06 18:10:27 +08:00
Kristina Lim
f9533f8fb8
Refactor redirecting back after requiring login
2018-09-06 19:46:17 +10:00
Kristina Lim
cd41498da9
Ask to login when not authenticated for order page
...
Redirect the user to the login page, instead of responding with HTTP
401.
2018-09-06 16:26:48 +08:00
Kristina Lim
3bf9e95511
Add specs for existing behaviour in order page
2018-09-06 16:26:45 +08:00
Kristina Lim
28d2bb3d47
Wrap controller specs for viewing cart
2018-09-06 15:04:11 +08:00
Kristina Lim
339ea6fa91
Clean up SCSS as suggested by scss-lint
2018-09-06 04:21:35 +10:00
Kristina Lim
9258e8c464
Remove height limit for modals in small screens
2018-09-05 23:58:26 +08:00
Kristina Lim
169aa752d8
Enlarge potential size of modals for large screens
...
Change modals for large screens from 10% position from top and 80% max
height, to 5% position from top and 90% max height.
This is to accommodate the taller cookies policy modal.
It seems that it is not easy to apply a custom position and height to a
specific modal only. This doesn't seem to be supported by the modal
library currently being used.
Before the recent changes, most modals were rendering at 10px top
position (not the originally planned 10%), so changing this to 5%
doesn't seem to be much of a compromise.
2018-09-05 23:58:26 +08:00
Kristina Lim
f4725198e8
Move some CSS to pages/ subdirectory.
2018-09-05 23:58:26 +08:00
Kristina Lim
f03eb02269
Keep height of modal, dialog within screen height
2018-09-05 23:58:25 +08:00
Kristina Lim
a37e9f1b87
Use v0.9.0-20180826174721 in kristinalim fork of angular-foundation
...
There is a bug in the handling of % values for the "top" CSS property of
the modals. See details here:
https://github.com/kristinalim/angular-foundation/pull/1
A PR to the original repository has also been submitted, but the project
doesn't seem to be active anymore:
https://github.com/yalabot/angular-foundation/pull/319
And to another fork of the repository:
https://github.com/cwadrupldijjit/angular-foundation/pull/1
The bug was causing the 10% "top" CSS property for the modal to be
treated as 10px.
2018-09-05 23:58:25 +08:00
Kristina Lim
34adf7cf6c
Lower the start point for sliding of modals
...
Occasionally, the page scrolls up while the modal is being opened. This
was causing the final position of the modal to be at the wrong location
relative to the viewport.
This was happening because of a race condition between the animation
that slides the modal from above the viewport to the middle, and focus()
which the modal does:
https://github.com/yalabot/angular-foundation/blob/0.8.0/src/modal/modal.js#L109
The final vertical position of the modal is at 10%, so the animation
which translates the modal -25% vertically was starting -15% above the
viewport. The focus() was then causing vertical scroll.
This lowers the starting point of the animation, so there will no longer
be scrolling.
Additionally, the animation would only happen on large screens. The CSS
property "top" is 0 for smaller screens.
2018-09-05 23:58:25 +08:00
Kristina Lim
6e55e5b1c7
Use maximum of 80% for modals in large screens
...
When there is enough content in the modal, the height of the modal plus
its top margin could exceed the height of the viewport.
Considering a top position of 10%, a max height of 80% renders a tall
modal vertically centered, with 10% remaining space at the bottom.
2018-09-05 23:58:22 +08:00
luisramos0
138fa41b8d
Fetched latest translations from transifex with tx pull --force
2018-09-05 14:02:51 +01:00
Pau Pérez Fabregat
0a05e6944e
Merge pull request #2625 from kristinalim/translations-rename_entreprise_keys_to_enterprise
...
Rename "entreprise" in i18n keys to "enterprise"
2018-09-05 13:23:02 +02:00
Pau Perez
b23cb55525
Fix current violations of Style/Send cop
2018-09-05 12:05:05 +02:00
Maikel
0d2fa3dc40
Merge pull request #2611 from luisramos0/cookies_banner_font_size
...
[Cookies] Increased cookies banner font size for med/large screens to improve readability
2018-09-04 11:35:32 +10:00
Kristina Lim
ce0758d420
Add confirm dialog for enterprise image removal
2018-09-04 02:08:26 +08:00
Kristina Lim
368612cad6
Allow removal of enterprise logo and promo image
2018-09-04 02:08:25 +08:00
Kristina Lim
c9370672c6
Add JS support for removal of enterprise images
2018-09-04 02:08:12 +08:00
Kristina Lim
9c3bb863da
Add endpoints for removing enterprise images
2018-09-04 01:32:39 +08:00
Kristina Lim
01d4b8fb10
Allow custom resource permission for admin controllers
2018-09-04 01:18:48 +08:00
Kristina Lim
f30032eee7
Include image URLs in serialized enterprise for admin
2018-09-04 01:18:45 +08:00
VadLusk
8efbe0e6d2
Delete _split2.css from application.rb assets precompile array.
2018-09-03 11:08:38 -06:00
Pau Pérez Fabregat
7dbbc3e9d8
Merge pull request #2610 from luisramos0/cookies_banner_bug
...
[Cookies] Added new test to cookies spec to cover bug on cookies banner and fix…
2018-09-03 17:23:17 +02:00
apoc64
fbce828305
Breaks comment into multiple lines
2018-09-03 08:56:42 -06:00
Pau Pérez Fabregat
903d70090e
Merge pull request #2636 from luisramos0/heroku_dead_code
...
Removed old files that were used with, now unsupported, heroku
2018-09-03 12:49:19 +02:00
luisramos0
14d526efc2
removed assets related to spree store: dead code
2018-09-03 09:50:42 +01:00
Maikel
129e2c915e
Merge pull request #2579 from openfoodfoundation/dependabot/bundler/angular-rails-templates-0.3.0
...
Bump angular-rails-templates from 0.2.0 to 0.3.0
2018-09-03 14:39:21 +10:00
Maikel
1b264403e0
Merge pull request #2624 from kristinalim/fix-no_order_link_in_subscription_emails_unless_user
...
Subscription emails for customer should not link to order page if customer has no user account
2018-09-03 14:38:56 +10:00
Maikel
3fadd06dc7
Merge pull request #2613 from luisramos0/cookies_better_policy_page
...
[Cookies] Updated cookies policy page text
2018-09-03 11:49:14 +10:00
Maikel
42afd426d5
Merge pull request #2620 from openfoodfoundation/dependabot/bundler/foreigner-1.7.4
...
Bump foreigner from 1.6.1 to 1.7.4
2018-09-03 11:48:48 +10:00
Maikel
11ab875b9a
Merge pull request #2623 from openfoodfoundation/dependabot/bundler/eventmachine-1.2.7
...
Bump eventmachine from 1.2.3 to 1.2.7
2018-09-03 11:48:34 +10:00
VadLusk
f74a6e47d5
Remove css_splitter references, delete all_split2.css. #1361 #2633
2018-09-03 09:20:26 +10:00
luisramos0
512577768c
Removed old files that were used with, now unsuported, heroku
2018-09-02 22:13:42 +01:00
apoc64
e62a755ddb
Adds comments for setting up timezone in application.yml
2018-09-02 11:08:27 -06:00
luisramos0
59f8dd4458
Improved cookies spec by keeping global config values as they were before the test
2018-09-01 20:35:07 +01:00
Kristina Lim
f844236b9c
Remove order link in non-user order cancellation email
2018-09-01 23:46:12 +08:00
Kristina Lim
5f2c3a1955
Remove order link in non-user failed payment email
2018-09-01 23:46:12 +08:00
Kristina Lim
f8244a400a
Custom subscription placement email if non-user
...
The order link should not be provided if the order does not have an
associated user account.
2018-09-01 23:46:11 +08:00
Kristina Lim
ad8b120e48
Extract format for order cycle closing in emails
...
Using a helper for this, but this can be changed to look up a
translation key.
2018-09-01 23:46:08 +08:00
Matt-Yorkley
9d05e5c97a
Remove duplicate line in spec
2018-09-01 14:09:07 +01:00
Kristina Lim
dc4037474d
Test order links in subscription placement emails
2018-09-01 15:40:36 +08:00
Matt-Yorkley
d8bbcdc54b
Decrease batch size to reduce chance of timeouts
2018-08-31 22:52:44 +01:00
Matt-Yorkley
4dfbbd60d4
Fix occasional StaleObjectError on variant updates
2018-08-31 19:47:08 +01:00
dependabot[bot]
4557bfbc17
[Security] Bump rubyzip from 1.2.1 to 1.2.2
...
Bumps [rubyzip](https://github.com/rubyzip/rubyzip ) from 1.2.1 to 1.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/rubyzip/rubyzip/releases )
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md )
- [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.1...v1.2.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-31 17:49:12 +00:00
Matt-Yorkley
75a9ea5bfa
Prefer .flat_map(&foo) over .map(&foo).flatten
2018-08-31 15:38:38 +01:00
Matt-Yorkley
04d50d4555
Fix filter results bug in validation section
2018-08-31 15:00:29 +01:00
Kristina Lim
f5c44ef0e6
Rename "entreprise" in i18n keys to "enterprise"
2018-08-31 15:26:30 +08:00
Maikel
a9c8c033c7
Merge pull request #2566 from openfoodfoundation/dependabot/bundler/daemons-1.2.6
...
Bump daemons from 1.2.2 to 1.2.6
2018-08-31 14:54:53 +10:00
Maikel
c30e29051a
Merge pull request #2594 from openfoodfoundation/dependabot/bundler/compass-rails-3.1.0
...
Bump compass-rails from 2.0.4 to 3.1.0
2018-08-31 13:47:22 +10:00
Maikel Linke
13b9ecab21
Fix font issue in mobile menu
2018-08-31 11:23:11 +10:00
luisramos0
1b4e0cd73a
Made the menu config default values more user friendly
2018-08-31 11:23:11 +10:00
luisramos0
e573a3fc2b
The main menu is now translatable and configurable using Content configuration and translations. Added 7 menu entries to the translations file (each with text and url) and 7 content configuration points to enable/disable these. The mobile menu icons can also be configured.
2018-08-31 11:23:11 +10:00
dependabot[bot]
508643b64e
Bump eventmachine from 1.2.3 to 1.2.7
...
Bumps [eventmachine](https://github.com/eventmachine/eventmachine ) from 1.2.3 to 1.2.7.
- [Release notes](https://github.com/eventmachine/eventmachine/releases )
- [Changelog](https://github.com/eventmachine/eventmachine/blob/master/CHANGELOG.md )
- [Commits](https://github.com/eventmachine/eventmachine/compare/v1.2.3...v1.2.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-30 19:19:08 +00:00
dependabot[bot]
287b21b0cf
Bump foreigner from 1.6.1 to 1.7.4
...
Bumps [foreigner](https://github.com/matthuhiggins/foreigner ) from 1.6.1 to 1.7.4.
- [Release notes](https://github.com/matthuhiggins/foreigner/releases )
- [Changelog](https://github.com/matthuhiggins/foreigner/blob/master/CHANGELOG.md )
- [Commits](https://github.com/matthuhiggins/foreigner/commits )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-30 19:16:41 +00:00
Pau Perez
1de13a5049
Favor #public_send over #send using Rubocop's cop
...
Devs keep using `#send` although that method does not preserve
private/protected visibility. Watching after this turned out to be quite
time-consuming while doing code review.
Currently, the Style/Send cop doesn't enforce `#public_send` however
(that's what we want). It simply discourages the use of #send. See
https://github.com/rubocop-hq/rubocop/pull/2081#issuecomment-292251650
for details. So a new entry on the Code Conventions doc has been added
to overcome this limitation:
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-public_send-over-send
2018-08-30 18:48:45 +02:00
Pau Pérez Fabregat
b4bfa3ff2d
Merge pull request #2591 from mkllnk/remove-rack-livereload
...
Remove gem rack-livereload
2018-08-30 13:50:57 +02:00
Maikel
1b88edea1f
Merge pull request #2420 from stveep/stripe-admin-2
...
Stripe admin 2
2018-08-30 15:48:49 +10:00
Maikel Linke
d1f7828432
Fix pending spec
...
The link from the enterprise page was missing the enterprise id. So the
bulk edit page for fees was showing fees for all enterprises.
2018-08-30 14:50:41 +10:00
Maikel Linke
429bf132da
Test creating a fee, not updating
...
The spec for creating an enterprise fee didn't actually create a new
fee. Because all enterprise fees are displayed, it changed an existing
fee.
2018-08-30 14:50:41 +10:00
Maikel Linke
297ea830dc
Further style spec
2018-08-30 14:50:41 +10:00
Maikel Linke
bc1e8bfde6
Convert specs to RSpec 3.7.0 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/features/admin/enterprise_fees_spec.rb
* 27 conversions
from: obj.should
to: expect(obj).to
* 8 conversions
from: == expected
to: eq(expected)
* 4 conversions
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-08-30 14:50:41 +10:00
Maikel Linke
a789aeb30a
Speed up enterprise fee spec
2018-08-30 14:50:41 +10:00
Maikel Linke
0174b84254
Remove old deactivated code
2018-08-30 14:50:41 +10:00
Maikel
174bc15ac9
Merge pull request #2607 from openfoodfoundation/dependabot/bundler/pg-0.21.0
...
Bump pg from 0.13.2 to 0.21.0
2018-08-30 13:37:25 +10:00
dependabot[bot]
664db1b0c2
Bump pg from 0.13.2 to 0.21.0
...
Bumps [pg](https://bitbucket.org/ged/ruby-pg ) from 0.13.2 to 0.21.0.
- [Changelog](https://bitbucket.org/ged/ruby-pg/src/master/History.rdoc )
- [Commits](https://bitbucket.org/ged/ruby-pg/branches/compare/v0.21.0..v0.13.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-30 03:19:13 +00:00
Maikel
8a97088bb6
Merge pull request #2606 from openfoodfoundation/dependabot/bundler/poltergeist-1.18.1
...
Bump poltergeist from 1.16.0 to 1.18.1
2018-08-30 13:16:47 +10:00
Maikel
1c61539119
Merge pull request #2585 from greysteil/bump-ams
...
Bump active_model_serializer to 0.8.4, and pin it
2018-08-30 10:00:22 +10:00
Maikel
fac29ebb96
Merge pull request #2595 from openfoodfoundation/dependabot/bundler/immigrant-0.3.6
...
Bump immigrant from 0.1.6 to 0.3.6
2018-08-30 09:56:37 +10:00
luisramos0
02b968b312
Cookies policy page table has a single column now. Also made small updates to the page text, migrated translations to ruby translations and extracted repeated partial from cookies policy page view
2018-08-30 00:27:35 +01:00
luisramos0
53e7fcb019
Imcreased cookies banner font size for med/large screens to improve readability
2018-08-30 00:21:00 +01:00
luisramos0
8dc10ffc6e
Added new test to cookies spec to cover bug on cookies banner and fixed it. See issue #2599 .
...
Also, improved readability on cookies spec with some extracted methods.
2018-08-28 23:48:22 +01:00
dependabot[bot]
3d8c4c69a7
Bump poltergeist from 1.16.0 to 1.18.1
...
Bumps [poltergeist](https://github.com/teampoltergeist/poltergeist ) from 1.16.0 to 1.18.1.
- [Release notes](https://github.com/teampoltergeist/poltergeist/releases )
- [Changelog](https://github.com/teampoltergeist/poltergeist/blob/master/CHANGELOG.md )
- [Commits](https://github.com/teampoltergeist/poltergeist/compare/v1.16.0...v1.18.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-28 19:15:06 +00:00
Matt-Yorkley
8de0355dc7
Add spec for multiple stages during import
2018-08-28 14:05:57 +01:00
Matt-Yorkley
f905284f7a
Add spec for edge case
2018-08-28 12:45:04 +01:00
Maikel
79f50e0b7b
Merge pull request #2353 from luisramos0/customers_admin_country_state
...
fixed UX problem in the state selector in customers admin
2018-08-28 16:46:00 +10:00
Maikel
b4bea59bb0
Merge pull request #2567 from greysteil/better-feater-matchers
...
Switch feature matcher style from `to_not have` to `to have_no`
2018-08-28 16:44:57 +10:00
Matt-Yorkley
6b9b8d8b73
Match multiple product names
2018-08-28 03:26:17 +01:00
Grey Baker
562a7936d9
Bump active_model_serializer to 0.8.4
2018-08-28 01:00:06 +01:00
Maikel
c39ac26f57
Merge pull request #2580 from openfoodfoundation/dependabot/bundler/stripe-3.3.2
...
Bump stripe from 3.3.1 to 3.3.2
2018-08-28 09:42:38 +10:00
Matt-Yorkley
8c2a49a57c
Update PI model spec
2018-08-27 23:08:19 +01:00
Matt-Yorkley
1df1ddcf66
Add spec for saving product and variant simultaneously
2018-08-27 23:06:54 +01:00
dependabot[bot]
61097c3bf9
Bump immigrant from 0.1.6 to 0.3.6
...
Bumps [immigrant](https://github.com/jenseng/immigrant ) from 0.1.6 to 0.3.6.
- [Release notes](https://github.com/jenseng/immigrant/releases )
- [Changelog](https://github.com/jenseng/immigrant/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jenseng/immigrant/compare/v0.1.6...v0.3.6 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-27 19:18:13 +00:00
dependabot[bot]
67802cd4ee
Bump compass-rails from 2.0.4 to 3.1.0
...
Bumps [compass-rails](https://github.com/Compass/compass-rails ) from 2.0.4 to 3.1.0.
- [Release notes](https://github.com/Compass/compass-rails/releases )
- [Changelog](https://github.com/Compass/compass-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Compass/compass-rails/compare/2.0.4...3.1.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-27 19:17:55 +00:00
Maikel Linke
58cbe492d4
Remove gem rack-livereload
...
I don't think that anybody is using it. I asked on Slack and people
didn't know what it was. I kept guard-livereload which is probably
offering the same, maybe even better.
2018-08-27 16:34:50 +10:00
Maikel
44faa116db
Merge pull request #2583 from mkllnk/seed-mail-connection-type
...
Configure mail TLS or SSL connection when seeding
2018-08-27 09:52:56 +10:00
Kristina Lim
28792fc895
Add tests for adding/updating enterprise images
2018-08-26 03:58:19 +08:00
Maikel
8eee8f96ed
Merge pull request #2557 from Matt-Yorkley/pi/class_descriptions
...
Class descriptions for Product Import
2018-08-24 18:14:12 +10:00
Matt-Yorkley
717f626dfe
Refactor enterprise validation
2018-08-24 15:51:37 +10:00
Matt-Yorkley
2b057a26d5
Add primary_producer to index to reduce queries
2018-08-24 15:51:37 +10:00
Matt-Yorkley
666fbf53bf
Validate enterprise.is_primary_producer?
2018-08-24 15:51:37 +10:00
Maikel
616b42a14d
Merge pull request #2555 from luisramos0/cookie_http_only
...
Added httponly to cookieConsent cookie, this makes this cookie secure…
2018-08-24 15:50:13 +10:00
Maikel
a37931afda
Merge pull request #2542 from luisramos0/add_to_cart
...
Extract OrderController.populate to new CartController and OrderPopulator to new CartService
2018-08-24 14:43:33 +10:00
Maikel
bf55190136
Merge pull request #2546 from Matt-Yorkley/pi/sku_validation
...
Remove empty SKU values if empty
2018-08-24 14:32:00 +10:00
Maikel Linke
b158c92998
Configure mail TLS or SSL connection when seeding
...
This allows to seed the secure connection type of the default mail
method.
2018-08-24 14:03:21 +10:00
Maikel
871e423e12
Merge pull request #2548 from kristinalim/feature-bulk_update_of_order_cycle_name
...
Make OC name editable from the OC index
2018-08-24 11:38:31 +10:00
Maikel
c4c4547338
Merge pull request #2572 from greysteil/bump-webmock
...
Bump webmock
2018-08-24 08:49:11 +10:00
dependabot[bot]
358bb3030a
Bump stripe from 3.3.1 to 3.3.2
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v3.3.1...v3.3.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-23 19:16:15 +00:00
dependabot[bot]
2e4a8d6318
Bump angular-rails-templates from 0.2.0 to 0.3.0
...
Bumps [angular-rails-templates](https://github.com/pitr/angular-rails-templates ) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/pitr/angular-rails-templates/releases )
- [Changelog](https://github.com/pitr/angular-rails-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pitr/angular-rails-templates/compare/v0.2.0...v0.3.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-23 19:15:48 +00:00
luisramos0
910297572e
Removed unnecessary currency from CartService constructor, using order.currency instead
2018-08-23 12:40:18 +01:00
luisramos0
ec069b1e3e
Converted specs to latest rspec syntax
2018-08-23 12:39:58 +01:00
luisramos0
c7b202f932
Fixed CodeClimate warnings on services/cart_services.rb
2018-08-23 12:39:58 +01:00
luisramos0
05bfc098ff
/controllers/spree/order_populator_decorator (with a class_eval) is now /services/CartService with no dependency to Spree::OrderPopulator.
2018-08-23 12:39:55 +01:00
luisramos0
6caa361354
Moved Spree::OrderController.populate to new CartController.
...
This was done to make order populate independent of Spree::OrdersController
2018-08-23 12:37:52 +01:00
Maikel
0312bf93dd
Merge pull request #2556 from luisramos0/cookies_failing_tests
...
Make cookies tests more stable
2018-08-23 13:29:02 +10:00
Maikel Linke
00b8b0a36c
Sleep to avoid race conditions in cookie spec
...
We tried a lot to avoid these sleep commands, but nothing worked. So
it's better to have reliable specs than fast specs.
2018-08-23 13:13:05 +10:00
Maikel
0c35d1bade
Merge pull request #2570 from openfoodfoundation/dependabot/bundler/atomic-1.1.101
...
Bump atomic from 1.1.99 to 1.1.101
2018-08-23 11:05:46 +10:00
Maikel
5dd0aed1c0
Merge pull request #2569 from openfoodfoundation/dependabot/bundler/rack-livereload-0.3.17
...
Bump rack-livereload from 0.3.16 to 0.3.17
2018-08-23 10:56:00 +10:00
Maikel
bc192dabbc
Merge pull request #2564 from openfoodfoundation/dependabot/bundler/fuubar-2.3.2
...
Bump fuubar from 2.2.0 to 2.3.2
2018-08-23 10:10:07 +10:00
Maikel
7d40e960f4
Merge pull request #2563 from openfoodfoundation/transifex
...
Transifex
2018-08-23 10:06:16 +10:00
Maikel
92e9392bc5
Merge pull request #2561 from mkllnk/2233-enable-embedded-shopping-spec
...
Enable embedded shopping spec
2018-08-23 09:23:12 +10:00
Grey Baker
468c29b8c1
Use new basic auth stub style
2018-08-22 21:35:56 +01:00
dependabot[bot]
b459ed7122
Bump webmock from 1.8.11 to 3.4.2
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 1.8.11 to 3.4.2.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v1.8.11...v3.4.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-22 21:26:05 +01:00
dependabot[bot]
f35e24d5ce
Bump atomic from 1.1.99 to 1.1.101
...
Bumps [atomic](https://github.com/ruby-concurrency/atomic ) from 1.1.99 to 1.1.101.
- [Release notes](https://github.com/ruby-concurrency/atomic/releases )
- [Commits](https://github.com/ruby-concurrency/atomic/compare/1.1.99...1.1.101 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-22 19:18:33 +00:00
dependabot[bot]
c5b426fded
Bump rack-livereload from 0.3.16 to 0.3.17
...
Bumps [rack-livereload](https://github.com/onesupercoder/rack-livereload ) from 0.3.16 to 0.3.17.
- [Release notes](https://github.com/onesupercoder/rack-livereload/releases )
- [Commits](https://github.com/onesupercoder/rack-livereload/commits )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-22 19:17:49 +00:00
Grey Baker
a747561e77
Switch feature matcher style from to_not have to to have_no
2018-08-22 09:29:48 +01:00
dependabot[bot]
8fb5625f1d
Bump daemons from 1.2.2 to 1.2.6
...
Bumps [daemons](https://github.com/thuehlinger/daemons ) from 1.2.2 to 1.2.6.
- [Release notes](https://github.com/thuehlinger/daemons/releases )
- [Changelog](https://github.com/thuehlinger/daemons/blob/master/Releases )
- [Commits](https://github.com/thuehlinger/daemons/compare/v1.2.2...v1.2.6 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-22 07:48:28 +00:00
dependabot[bot]
ade005bb2c
Bump fuubar from 2.2.0 to 2.3.2
...
Bumps [fuubar](https://github.com/thekompanee/fuubar ) from 2.2.0 to 2.3.2.
- [Release notes](https://github.com/thekompanee/fuubar/releases )
- [Changelog](https://github.com/thekompanee/fuubar/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thekompanee/fuubar/compare/releases/v2.2.0...releases/v2.3.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-08-22 07:47:04 +00:00
Maikel
4417a8f156
Merge pull request #2539 from luisramos0/delete_dead_cart
...
removed Cart route, controller, model and specs: dead code
2018-08-22 17:35:58 +10:00
Transifex-Openfoodnetwork
1bbc615496
Updating translations for config/locales/fr_CA.yml
2018-08-22 08:37:41 +10:00
Transifex-Openfoodnetwork
39b3a964dd
Updating translations for config/locales/fr.yml
2018-08-22 04:25:59 +10:00
luisramos0
653804d14c
Make cookies test more stable
2018-08-20 21:08:09 +01:00
luisramos0
61f69905f8
fixed UX problem in the state selector in customers admin
2018-08-20 20:51:22 +01:00
stveep
17f2ba47ca
Add label for card field
2018-08-19 12:00:31 +01:00
stveep
8c6b8d5e84
Move injectors outside Stripe partial to satisfy dependencies
2018-08-19 11:50:34 +01:00
stveep
286101c934
PR changes: switch syntax for mapCC, remove ng-init
2018-08-19 10:43:53 +01:00
stveep
c0f41b6833
PR changes - erb to haml, don't update en_GB translations
2018-08-19 10:43:53 +01:00
stveep
b3da7049c6
Should not hide post code on admin side as no billing address otherwise
2018-08-19 10:43:53 +01:00
stveep
ff7dc811e9
Add translations for messages and remove old placeholder translation
2018-08-19 10:43:53 +01:00
stveep
f9a221e2ff
add to manifest, tidy up requirements, hide postcode similar to frontend
2018-08-19 10:43:53 +01:00
stveep
a848b9172e
Change name to AdminStripeElements to avoid confusion; add status bar for StatusMessages
2018-08-19 10:43:53 +01:00
stveep
8272aebe29
Add Stripe form and duplicate Stripe Elements in backend Angular app
2018-08-19 10:43:53 +01:00
Matt-Yorkley
fbbbc93aba
Class descriptions for Product Import
2018-08-18 11:42:02 +01:00
luisramos0
56879377d5
Added httponly to cookieConsent cookie, this makes this cookie secure, cannot be altered by javascript
2018-08-17 22:57:57 +01:00
Maikel
e0d13010bb
Merge pull request #2543 from openfoodfoundation/transifex
...
Transifex
2018-08-17 17:36:22 +10:00
Maikel Linke
7dccbb5213
Enable embedded shopping spec
...
It was disabled in
https://github.com/openfoodfoundation/openfoodnetwork/pull/2232 , because
it was very unreliable. But it seems stable again since
https://github.com/openfoodfoundation/openfoodnetwork/pull/2468 .
2018-08-17 17:00:15 +10:00
Matt-Yorkley
28b1fc076a
Remove empty SKU values if empty
2018-08-16 14:29:50 +01:00
Kristina Lim
c14e7ea8d5
Allow bulk update of order cycle name
2018-08-16 21:18:24 +08:00
luisramos0
91e57cb893
Removed Cart table, its dependency on spree orders table and removed some more dead code related to this
2018-08-15 23:29:28 +01:00
Transifex-Openfoodnetwork
d76112e072
Updating translations for config/locales/de_DE.yml
2018-08-14 17:18:51 +10:00
Maikel Linke
c9862535f8
Import required colour definitions in SCSS
...
This avoids asset compile errors like this one:
Sass::SyntaxError: Undefined variable: "$disabled-light".
2018-08-14 10:01:48 +10:00
luisramos0
8681618490
Fixed CodeClimate scss feedback on cookies banner and policy page css
2018-08-14 10:01:48 +10:00
luisramos0
ccd5147b11
Added angular templates route and controller to serve angular templates from the server, instead of precompiled assets. This was used to fix a problem with the cookies policy page template that was using a Spree configuration
2018-08-14 10:01:48 +10:00
luisramos0
1c20967ca4
Added a button to close the cookies policy page at the bottom of the page to improve UX on mobile
2018-08-14 10:01:48 +10:00
luisramos0
bff5581a42
Added functional tests for cookies related features: cookies policy page, cookies banner and privacy policy link
2018-08-14 10:01:48 +10:00
luisramos0
4b64369ddb
Added GA and Matomo toggle in Legal Settings in the global settings in the BO and added GA and Matomo cookies details to the cookies policy page (according to what is configured in the BO)
2018-08-14 10:01:48 +10:00
luisramos0
ca35c59e52
Moved the footer TOS URL from the content settings to the new section legal settings in the global settings
2018-08-14 10:01:48 +10:00
luisramos0
d920c32376
Added cookies banner toggle and privacy URL to a new section called Legal Settings in the global settings in the BO
2018-08-14 10:01:48 +10:00
luisramos0
92f9cbd00a
Added new cookies banner (with link to cookie policy page and the accept cookies button)
2018-08-14 10:01:48 +10:00
luisramos0
08c5d8f3ab
Added new cookies policy page and added a link to it in the footer (cookies policy link)
2018-08-14 10:01:48 +10:00
luisramos0
362ed8ed08
Changed modals max height from 120% to 100% so that the content in the modal is never outside the viewport
2018-08-14 10:01:48 +10:00
Transifex-Openfoodnetwork
4f751eb3e3
Updating translations for config/locales/nb.yml
2018-08-13 17:08:33 +10:00
Maikel
910c1d437d
Merge pull request #2536 from openfoodfoundation/transifex
...
Transifex
2018-08-13 15:48:11 +10:00
luisramos0
0b9061df28
removed Cart route, controller, model and specs: dead code
2018-08-11 22:17:12 +01:00
Transifex-Openfoodnetwork
6c306aa1dd
Updating translations for config/locales/fr.yml
2018-08-10 21:09:21 +10:00
luisramos0
3b1bd53d3a
Added basic integration with Matomo
...
Added matomo script and added a new matomo settings menu entry under configuration. Improved organization of en.yml by grouping configuration screens.
2018-08-10 16:12:58 +10:00
Kristina Lim
6251c72921
Add divider between admin enterprise index actions
2018-08-10 12:17:31 +10:00
Kristina Lim
17978f58c7
Rename edit link in admin enterprise index
...
Change "Edit Profile" link to "Settings".
2018-08-10 12:17:31 +10:00
Kristina Lim
295604b689
Change heading for edit enterprise page
...
Change the start of the heading from "Editing:" to "Settings:".
2018-08-10 12:17:31 +10:00
Kristina Lim
0b4fcf8a14
Change enterprise "Manage" button to "Settings"
2018-08-10 12:17:30 +10:00
Kristina Lim
b91019ad64
Split translation key for enterprise manage button
...
The ".manage" key is still used by the column header for the "Manage"
buttons.
2018-08-10 12:12:26 +10:00
Maikel Linke
9dcbd9076e
Override in_stock? to prepare for Spree 2.0
2018-08-09 14:22:43 +10:00
Maikel Linke
b84e524f2d
Prepare inventory report for Spree upgrade
...
This change could impact the performance of the report. But therefore it
takes VariantOverrides into consideration. The old code ignored the
distributor for this filter. It also ignored the `on_demand` flag.
2018-08-09 14:22:43 +10:00
Maikel Linke
289d0b937f
Style ScopeVariantToHub
2018-08-09 14:22:43 +10:00
Maikel Linke
27ddb712c1
Remove unused scope Spree::Variant.in_stock
...
Our added scope is not used anywhere and conflicts with the Spree
upgrade.
https://github.com/openfoodfoundation/openfoodnetwork/issues/2014
2018-08-09 14:22:43 +10:00
Maikel
33f6dc21e7
Merge pull request #2516 from kristinalim/cleanup-move_admin_and_spree_from_routes
...
Separate admin and Spree routes from main file
2018-08-09 10:10:49 +10:00
Maikel
f93ed0de85
Merge pull request #2519 from mkllnk/more-efficient-login-in-specs
...
More efficient login in specs
2018-08-09 10:05:54 +10:00
Maikel
03468efa7e
Merge pull request #2346 from oeoeaio/subs-totals
...
Subs: totals in backend are consistent and include fee breakdown
2018-08-07 18:17:13 +10:00
Maikel Linke
9aff9fbce2
Remove empty spec
2018-08-07 16:01:38 +10:00
Maikel Linke
b628ead525
Speed up shipping methods spec
2018-08-07 16:01:38 +10:00
Maikel Linke
54552f2be7
Speed up admin schedules spec
2018-08-07 16:01:37 +10:00
Maikel Linke
819a173167
Speed up reports spec
2018-08-07 16:01:37 +10:00
Maikel Linke
aa677a117b
Speed up admin products spec
2018-08-07 16:01:37 +10:00
Maikel Linke
eb550505ae
Speed up admin payment method spec
2018-08-07 16:01:37 +10:00
Maikel Linke
9023b16395
Speed up admin orders spec
...
From 80s to 74s.
2018-08-07 16:01:37 +10:00
Maikel Linke
71a381e48e
Speed up order cycles spec
...
From 68 to 63 seconds.
2018-08-07 16:01:37 +10:00
Maikel Linke
f4cd5a7e4b
Speed up admin enterprise spec
...
From 40s to 36s.
2018-08-07 16:01:37 +10:00
Maikel Linke
121bc51feb
Speed up admin enterprises spec
...
From 6.5s to 5.3s.
2018-08-07 16:01:37 +10:00
Maikel Linke
f0da823445
Speed up enterprise user spec
...
From 1.9s to 1.7s.
2018-08-07 12:41:07 +10:00
Maikel Linke
e4ebeb8a29
Remove dead spec code
...
The code has been inactive since 2015 and was probably obsolete anyway.
2018-08-07 12:37:49 +10:00
Maikel Linke
0b39054954
Speed up relationships spec
...
From 18s to 12s: 33% speed up
2018-08-07 12:33:26 +10:00
Maikel Linke
126f312c6b
Make spec more robust not relying on order
...
Enterprises can be in different order. Using `with_options` doesn't
care about the order.
2018-08-07 12:30:59 +10:00
Maikel Linke
edb32218b0
Use quick login to speed up product edit spec
...
From 48s to 44s: 8% speed up
2018-08-07 12:11:15 +10:00
Maikel Linke
0edf393c12
Use quick login to speed up spec
...
We don't need to visit the admin dashboard before each spec.
On my machine:
54 seconds before
47 seconds after
speed up by 13%
2018-08-07 10:56:42 +10:00
Maikel Linke
30fad228c5
Remove code duplication in spec helper
2018-08-07 09:24:31 +10:00
Maikel
32846af230
Merge pull request #2517 from kristinalim/cleanup-disable_rubocop_cop_rails_activerecordaliases
...
Disable rubocop cop "Rails/ActiveRecordAliases"
2018-08-07 09:11:00 +10:00
Kristina Lim
d77a94335b
Update .rubocop_todo.yml
2018-08-06 18:45:52 +08:00
Kristina Lim
a494fb274e
Disable rubocop cop Rails/ActiveRecordAliases
...
The methods :update! and :update (to replace :update_attributes! and
:update_attributes) were not added until Rails 4.
See this for more information:
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/ActiveRecordAliases
2018-08-06 18:12:43 +08:00
Kristina Lim
b67c8cc9f1
Improve requiring of additional routes
...
This is more appropriate, and allows changes the separate route files to
be loaded automatically in the development environment.
2018-08-06 17:04:03 +08:00
Kristina Lim
4d34693c05
Move Spree route customizations from main file
2018-08-06 09:57:29 +08:00
Kristina Lim
72036a4993
Move admin routes from main file
2018-08-06 09:57:24 +08:00
Maikel Linke
f0be8ff290
Style proxy order serializer
2018-08-03 15:07:22 +10:00
Maikel Linke
b736560d63
Inform about inaccurate subscription totals
...
https://github.com/openfoodfoundation/openfoodnetwork/pull/2346#issuecomment-409822038
2018-08-03 14:59:27 +10:00
Matt-Yorkley
c8397024e4
Streamline Product Import UX flow
2018-08-03 14:33:35 +10:00
Maikel Linke
d5fdda1c46
Fix typo translating Enterprises
2018-08-03 12:15:50 +10:00
Maikel Linke
c48889f368
Remove duplicate translation key
2018-08-03 12:15:50 +10:00
Rob Harrington
cead905d05
Use estimated subscription total for proxy orders if order has not been initialized
2018-08-03 12:14:25 +10:00
Rob Harrington
fb93351386
Show fee breakdown in line items panel if present
2018-08-03 12:14:25 +10:00
Maikel
d726b0a851
Merge pull request #2509 from coopdevs/update-spree-fork-version
...
Update Spree's fork revision in Gemfile
2018-07-31 09:26:00 +10:00
Pau Perez
c4b23b62d0
Update Spree's fork revision in Gemfile
2018-07-30 18:11:02 +10:00
Maikel
915531acc4
Add section about documentation updates
...
This should prevent issues like https://github.com/openfoodfoundation/openfoodnetwork/issues/2427 .
Also converted comments into HTML syntax so that you don't have to delete them when creating a PR.
2018-07-30 14:44:07 +10:00
Maikel
8ecc786b99
Include bug severity in issue template
...
And formatted for easier reading and writing.
2018-07-30 14:28:01 +10:00
Rob H
7f26b1494b
Fix syntax error in GETTING_STARTED.md
2018-07-27 12:49:18 +10:00
Rob H
eb89b74022
Fix syntax error in README.md
2018-07-27 12:48:37 +10:00
Maikel
933ff63de2
Merge pull request #2389 from luisramos0/bulk_prod_edit_fix
...
admin page fetcher is now synchronously fetching all pages before reso…
2018-07-26 14:09:21 +10:00
Maikel
3f91850301
Merge pull request #2499 from mkllnk/update-com-links-in-readme
...
Add communications links to README
2018-07-26 11:39:29 +10:00
Rob Harrington
a16058f52a
Fix link syntax errors in REAME.md and GETTING_STARTED.md
2018-07-26 11:38:39 +10:00
Maikel
02331221ef
Merge pull request #2471 from Matt-Yorkley/pi/post_save
...
PI: post-save UI changes
2018-07-26 11:26:51 +10:00
Maikel Linke
2ceb969925
Style recently merged code
...
We enabled more Rubocop checks and code that was merged around the same
time, didn't comply with the new checks.
2018-07-26 10:52:56 +10:00
Maikel Linke
f0f9662957
Update gem i18n-js to pick up locale changes
...
We had some problems recently with changes in en.yml not being picked up
by i18n-js to be included in all.js. There have been some patches for
the current version that have an impact on that:
578555f57e
db3cdf82aa
a88b206644
Trying it out locally, the updated i18n-js gem works while the old
version doesn't update the Javascript translations when new keys are
added. To reproduce the issue, you can add a new key in `en.yml` and
reference it from an Angular template in `app/assets/javascripts/`. The
old version complained about a missing translation until you ran:
```
bundle exec rake tmp:cache:clear
```
We don't need to do that any more.
2018-07-26 10:45:35 +10:00
Pau Pérez Fabregat
97e61dc6f9
Merge pull request #2498 from Matt-Yorkley/embedded_mobile
...
Fix embedded shopfront menu responsiveness
2018-07-25 15:10:46 +02:00
Matt-Yorkley
ae5fd864d1
Fix embedded shopfront menu responsiveness
2018-07-25 17:41:26 +10:00
Maikel Linke
5db5bc65c0
Add communications links to README
...
This was originally proposed by Kirsten in:
https://github.com/openfoodfoundation/openfoodnetwork/pull/2478
2018-07-24 11:18:54 +10:00
Maikel
ffd3d28889
Merge pull request #2474 from Matt-Yorkley/pi/import_options
...
PI: import options UI
2018-07-24 10:34:14 +10:00
Maikel
30be40ebd9
Merge pull request #2441 from kristinalim/fix-scoping_issue_in_sorting_of_tables
...
Fix front-end sorting in "Customers" index and "Bulk Order Management" page
2018-07-24 10:31:13 +10:00
Pau Pérez Fabregat
26d6ca4a54
Merge pull request #2487 from coopdevs/stricter-code-climate
...
Make CodeClimate config more strict
2018-07-23 12:42:06 +02:00
Pau Pérez Fabregat
687d7c5f38
Merge pull request #2483 from coopdevs/fix-setup-script
...
Fix script/setup by making it less clever
2018-07-23 12:31:50 +02:00
Pau Pérez Fabregat
b60bada542
Merge pull request #2495 from mkllnk/remove-newrelic
...
Remove unused gem newrelic-rpm
2018-07-23 11:19:27 +02:00
Pau Perez
14480b920e
Fix script/setup by making it less clever
...
Now we ask the dev to create the "ofn" user as precondition. This is
way easier than developing a script that fits all possible setups.
It also stops requiring a particlar Postgres version. Although in
production we use 9.5 it is very unlikely we will use any
version-specific feature in the near future. This should make it a bit
easier for new devs to set up their environment.
2018-07-23 10:59:32 +02:00
Matt-Yorkley
67767f86eb
Change import and reset logic to work with first page
2018-07-23 02:07:00 +01:00
Matt-Yorkley
bd200c885b
Move options to first page
2018-07-23 01:46:32 +01:00
Kristina Lim
89ac558f37
Fix wrong sort predicates in customer index
2018-07-23 10:33:40 +10:00
Kristina Lim
47608525c6
Reset reverse when clicking another column to sort
2018-07-23 10:33:40 +10:00
Kristina Lim
5179f7fd63
Move logic for toggling by column into SortOptions
2018-07-23 10:33:40 +10:00
Kristina Lim
55d0b1dfc5
Generalize sorting through SortOptions service
2018-07-23 10:33:40 +10:00
Kristina Lim
8b6b694244
Remove unused sorting preferences in ColumnsCtrl
2018-07-23 10:33:40 +10:00
Kristina Lim
2bba72c5a9
Fix frontend sorting in "Bulk Order Management"
2018-07-23 10:33:40 +10:00
Kristina Lim
822b2c929a
Fix frontend sorting in "Customers" index
...
The scope for customersCtrl did not have access to the sorting
preferences stored in the nested ColumnsCtrl scope. To address this,
the page has been changed to use a new set of sorting preferences
declared in the customersCtrl scope itself.
Also, these sorting preferences are now stored in an object. This
enables the parent scope to see changes to the sorting preferences which
are done via the nested ColumnsCtrl scope,
The "Bulk Order Management" page is also affected by the same scoping
issue. Once this page is fixed, we can remove remnants of the sorting
preferences initialized in ColumnsCtrl.
2018-07-23 10:33:39 +10:00
Kristina Lim
9f09861d8b
Change sorting to be done in ascending order first
...
Currently, we always toggle "reverse" when triggering a sort.
If "reverse" is initially set to false, triggering a sort for the first
time then toggles this to true. The effect is that, the first time that
sorting is done, the rows are sorted in reverse order.
This is not intuitive - they should be sorted in ascending order first.
2018-07-23 10:33:39 +10:00
Kristina Lim
745390dcd5
Wrap rows in customer index with TBODY tag
2018-07-23 10:33:39 +10:00
Maikel
12838ba61e
Merge pull request #2468 from mkllnk/improve-testing-embedded-pages
...
Improve testing embedded pages
2018-07-23 08:59:11 +10:00
Maikel
add250b30f
Merge pull request #2473 from Matt-Yorkley/pi/stop_if_invalid
...
PI: Don't allow save if invalid entries are present
2018-07-23 08:54:01 +10:00
Maikel
df29d4d611
Merge pull request #2472 from lilwillifo/logo-sizing-to-css
...
Logo sizing to css
2018-07-23 08:47:45 +10:00
Pau Perez
7d790a7d59
Update .rubocop_todo.yml
2018-07-20 18:58:37 +02:00
Pau Perez
44fe3de732
Make CodeClimate config more strict
...
There's no point of using Code Climate if most of its checks are
disabled. Now it scores our codebase with an A and reports just 2 code
smells, 64 duplications and 14 other issues. That couldn't farther from
reality. If we care about the architecture and maintainability of our
app, this is a must.
To transition towards enabling all default checks, I started with
scss-lint, duplication and method-complexity. This doesn't mean will
have to fix them all straight away as we'll add the current violations
to the `.rubocop_todo.yml` but it'll point us the parts where we should
focus our efforts.
2018-07-20 09:08:03 +02:00
Maikel Linke
5f4115fbd9
Remove unused gem newrelic-rpm
2018-07-20 16:56:12 +10:00
Margaret Williford
512e974672
move width setting for tagline logo image from HTML to CSS
2018-07-20 14:00:06 +10:00
Margaret Williford
d952276e2a
move footer logo sizing from html to css
2018-07-20 14:00:06 +10:00
Maikel
23964b2542
Merge pull request #2422 from luisramos0/1667_email_validation_fix
...
1667 manage validations emails
2018-07-20 12:19:23 +10:00
Maikel
1b571e9835
Merge pull request #2379 from Matt-Yorkley/uk/guest_label
...
Add guest label to admin customers index
2018-07-20 08:53:26 +10:00
Maikel Linke
962c54b606
Remove unnecessary expectation
...
The `iframe` is rendered in pure HTML and should always be there.
2018-07-19 10:45:33 +10:00
Maikel Linke
8a3a617870
DRY specs with new EmbeddedPagesHelper
2018-07-19 10:44:43 +10:00
luisramos0
8246893652
Added notice for unexpected mail in confirmation instructions mail (HugsDaniel)
2018-07-19 09:26:29 +10:00
Maikel
1dbd265b30
Merge pull request #2384 from luisramos0/open_new_tab
...
added directive to make links open in new tab by default in textangul…
2018-07-19 09:17:09 +10:00
Matt-Yorkley
e3162b0a14
Change import method to fix missing variable error on asset precompilation
2018-07-18 23:00:50 +01:00
Matt-Yorkley
456e05d5d2
Include subfolders in scss import
2018-07-18 22:56:10 +01:00
Matt-Yorkley
24ff5555be
Create admin SCSS colour palette
2018-07-18 22:56:10 +01:00
Matt-Yorkley
75e52a7a91
CSS tweaks fo guest flag
2018-07-18 22:56:10 +01:00
Matt-Yorkley
583f16b38d
Add guest label to admin customers index
2018-07-18 22:56:10 +01:00
Pau Pérez Fabregat
4fe1e1fc9f
Merge pull request #2482 from Matt-Yorkley/uk/mail_config
...
Allow preferred_mails_from and preferred_mail_bcc to be set from configs
2018-07-18 19:20:55 +02:00
Pau Pérez Fabregat
4f215da735
Merge pull request #2467 from mkllnk/ci-output-test
...
Use progress formatter on Travis to avoid timeout
2018-07-18 19:19:40 +02:00
Pau Pérez Fabregat
37e2d76a39
Merge pull request #2477 from mkllnk/2465-use-right-subscriptions-translation
...
Reference existing translation: closed order cycle
2018-07-18 16:47:35 +02:00
Pau Pérez Fabregat
fac8e26d8b
Merge pull request #2475 from Matt-Yorkley/pi/landing_page
...
PI: landing page
2018-07-18 16:47:17 +02:00
Matt-Yorkley
23cbcda0c3
Allow preferred_mails_from and preferred_mail_bcc to be set from configs
2018-07-18 15:43:02 +01:00
Matt-Yorkley
5e142205bd
Use relative translation keys
2018-07-18 13:35:23 +01:00
Matt-Yorkley
5737c9803d
Add unit_type field to inventory template
2018-07-18 12:59:52 +01:00
Matt-Yorkley
c7deae4253
Remove category field from inventory specs
2018-07-18 12:59:19 +01:00
Matt-Yorkley
b37bea35fa
Use relative translation keys
2018-07-18 11:43:31 +01:00
Matt-Yorkley
18206c9369
Remove old view file
2018-07-18 11:42:07 +01:00
Pau Pérez Fabregat
8ae5d5f52e
Merge pull request #2415 from oeoeaio/update-readme
...
Update README.md and add GETTING_STARTED.md
2018-07-18 11:19:33 +02:00
Pau Pérez Fabregat
d56698e4a6
Merge branch 'master' into update-readme
2018-07-18 10:59:20 +02:00
Pau Pérez Fabregat
7bf27ec6b3
Merge pull request #2409 from mkllnk/2013-remove-scope-active_distributors
...
2013 Remove dead code for Spree upgrade
2018-07-18 10:38:19 +02:00
Pau Pérez Fabregat
bd05af5a29
Merge pull request #2442 from kristinalim/translations-enterprise_relationships_to_enterprise_permissions
...
Change "Enterprise Relationships" to "Enterprise Permissions"
2018-07-17 14:48:08 +02:00
Kristina Lim
c16f4203f9
Rename enterprise "Relationships" to "Permissions"
...
This only updates en* translations, and does not affect URLs and other
back-end references.
2018-07-17 16:03:48 +10:00
Pau Pérez Fabregat
0fd57ee7bd
Merge pull request #2390 from luisramos0/buk_prod_edit_rounding_issue
...
fixed number rounding issue in product bulk edit
2018-07-16 16:44:59 +02:00
luisramos0
4a44454210
fixed number rounding issue in product bulk edit
2018-07-16 13:13:58 +10:00
Maikel Linke
4d68723fe3
Reference existing translation: closed order cycle
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/2465
Viewing a customers subscription could display a translation missing
error.
2018-07-16 09:24:32 +10:00
Matt-Yorkley
c4af50e95c
Add sidebar to Import index page
2018-07-15 23:12:26 +01:00
Matt-Yorkley
632b991952
Add downloadable templates
2018-07-15 21:25:42 +01:00
Matt-Yorkley
f344b7893d
Remove Product Import guide page
2018-07-15 20:49:55 +01:00
Matt-Yorkley
8aed78b0e6
Don't allow save if invalid entries are present
2018-07-15 10:21:36 +01:00
Matt-Yorkley
a4210a1cab
PI post-save UI changes
2018-07-15 00:27:21 +01:00
Pau Pérez Fabregat
da344adbcd
Merge pull request #2466 from kristinalim/doc-notes_about_i18n_in_contributing
...
Add section about internationalisation to CONTRIBUTING.md
2018-07-13 19:43:52 +02:00
Pau Pérez Fabregat
c2d9b094d3
Merge pull request #2419 from frank-west-iii/issue-2412-duplicate-menu
...
Remove spree product navigation override
2018-07-13 19:43:07 +02:00
Maikel Linke
622517501c
Make spec robust on slow computers
...
This spec just failed in an unrelated pull request.
https://travis-ci.org/openfoodfoundation/openfoodnetwork/jobs/403435522
This change should fix it even on very slow computers.
2018-07-13 19:10:06 +10:00
Frank West
e3b7e050a0
Remove spree product navigation override
...
This was here to override the original spree products navigation link,
but since moving back to the index action this had the side effect of
adding an additional navigation item instead. We can simply remove this
override to get rid of the additional menu item.
2018-07-13 16:58:57 +10:00
Maikel Linke
8e90488117
Use progress formatter on Travis to avoid timeout
...
We had a few Travis builds lately that timed out, because no output was
received. Even though our standard formatter Fuubar should detect Travis
and print the right output, nothing was visible in our builds.
https://github.com/travis-ci/travis-ci/issues/1337
In this patch, I tell Travis to use Rspec's default formatter to print
dots for every passed test.
2018-07-13 16:51:56 +10:00
Maikel Linke
599f1a966b
Use embedded shops example for tests
2018-07-13 16:36:19 +10:00
Kristina Lim
4ebcf4e3c3
Add internationalisation info to CONTRIBUTING.md
2018-07-13 14:26:27 +08:00
Maikel Linke
66980b247a
Fix test of opening shops in new windows
...
The test case had some hard-coded enterprise name that didn't match
anything. It then confirmed that all found links (none) would open a new
window. So it wasn't confirming anything.
2018-07-13 15:37:19 +10:00
Maikel Linke
6f737d8d1e
Unclutter spec setup
2018-07-13 15:37:19 +10:00
Maikel Linke
ed747ec612
Use embedded groups example for tests
2018-07-13 15:37:19 +10:00
Maikel Linke
185cf9a312
Remove code duplication
2018-07-13 15:37:18 +10:00
luisramos0
dfb510debe
admin page fetcher is now receiving a onLastPageComplete function that is used to show "no results" messages only after the last page is fetched
2018-07-13 15:01:43 +10:00
Maikel Linke
d5d1eae715
Improve spec description
2018-07-13 09:04:42 +10:00
Maikel Linke
43883d1ab4
Simplify email confirmation directive
...
Making better use of Angular features.
Adding a spec for this functionality.
2018-07-13 09:04:42 +10:00
Maikel Linke
fbe2f7ab4c
Remove unused variable from mailer
...
The second variable passed by Devise is actually a hash, not a token.
2018-07-13 09:04:41 +10:00
Maikel Linke
a531135804
Remove unused data-hooks
2018-07-13 09:04:41 +10:00
Maikel Linke
e37213f6a5
Remove redundant edit action
2018-07-13 09:04:41 +10:00
Maikel Linke
28c2ad7160
Move override into view
2018-07-13 09:04:41 +10:00
Maikel Linke
a347837044
Move override into view
2018-07-13 09:04:41 +10:00
Maikel Linke
ab9975cb6c
Move override into view
2018-07-13 09:04:41 +10:00
Maikel Linke
339b04a044
Convert spree admin user list to haml
2018-07-13 09:04:41 +10:00
Maikel Linke
9020e7ddd9
Import admin user list from Spree
2018-07-13 09:04:41 +10:00
Maikel Linke
60b66540df
Add resend email button to admin user form
...
Fixes https://github.com/openfoodfoundation/openfoodnetwork/issues/1589
2018-07-13 09:04:41 +10:00
Maikel Linke
6a58deb436
Add message about unconfirmed email to user form
2018-07-13 09:04:41 +10:00
Maikel Linke
8157897f76
Remove unused data hooks
2018-07-13 09:04:41 +10:00
Maikel Linke
9050a52cc2
Move admin user form override into view
2018-07-13 09:04:41 +10:00
Maikel Linke
2032ed6328
Convert admin user edit form to haml
2018-07-13 09:04:41 +10:00
Maikel Linke
cb1dc6e657
Import admin user edit form from spree_auth_devise
2018-07-13 09:04:41 +10:00
Maikel Linke
23dd09a8fa
Convert Spree view from erb to haml
2018-07-13 09:04:41 +10:00
Maikel Linke
652cc6e677
Import admin user edit view from spree_auth_devise
...
We would like to do some customisations and importing the whole file is
simpler and less error prone than using Spree's overrides.
2018-07-13 09:04:40 +10:00
Maikel Linke
97d1b5d7fe
Add spec for creating users
2018-07-13 09:04:40 +10:00
Maikel
b65578fdc5
Merge pull request #2408 from mkllnk/cleanup-route
...
Remove impossible route
2018-07-13 09:01:33 +10:00
Maikel
0bd40f498a
Merge pull request #2447 from mkllnk/update-translation-documentation
...
Move i18n locale doc to wiki and reference that
2018-07-12 10:07:39 +10:00
Maikel Linke
86f2d7a344
Remove impossible route
...
Hash fragments are not part of the http request and not sent to the
server. So the routes will never see a hash fragment which means that
this route is never used.
2018-07-12 10:05:08 +10:00
luisramos0
b302a1d03d
added Enterprise registration exit message and moved step TYPE translations to a new structure on en.yml (test if transifex picks up the existing translations)
2018-07-12 08:53:06 +10:00
Pau Pérez Fabregat
8cec9d5723
Merge pull request #2451 from Matt-Yorkley/pr_categories
...
Add changelog category to PR template
2018-07-11 22:40:52 +02:00
Matt-Yorkley
056df62359
Add changelog category to PR template
2018-07-11 18:03:45 +01:00
Pau Pérez Fabregat
79b86a4885
Merge pull request #2448 from kristinalim/fix-broken_great_pr_link_in_contributing
...
Fix broken "making a great pull request" link in CONTRIBUTING.md
2018-07-11 13:19:17 +02:00
Kristina Lim
5508c6741f
Fix broken "great-pr" link in CONTRIBUTING.md
2018-07-11 14:10:20 +08:00
Maikel Linke
24f77184cf
Move i18n locale doc to wiki and reference that
2018-07-11 11:31:27 +10:00
Pau Pérez Fabregat
deb04c3075
Merge pull request #2444 from openfoodfoundation/transifex
...
Transifex
2018-07-10 12:12:05 +02:00
Maikel Linke
459057a7db
Revert accidental copy and paste
2018-07-10 10:31:51 +10:00
Maikel
26c23887e2
Merge pull request #2276 from oeoeaio/subs-use-default-card
...
Subs: Use Default Card for Subscriptions
2018-07-10 10:22:58 +10:00
Maikel Linke
f9a3338755
Simplify serialiser with delegate
2018-07-10 10:01:18 +10:00
Maikel Linke
b478ef9fd0
Make admin serialiser specs runnable on their own
2018-07-10 09:59:00 +10:00
Transifex-Openfoodnetwork
15db5e1d50
Updating translations for config/locales/en_GB.yml
2018-07-09 20:23:01 +10:00
Rob Harrington
3dacd06b6b
Reload order before sending emails to ensure state is up to date
2018-07-05 19:26:12 +10:00
Rob Harrington
0afa9fae8e
Check authorisation before attempting to charge credit cards on order cycle close
2018-07-05 19:26:12 +10:00
Rob Harrington
4fd333bbaf
Remove obsolete reference to credit_card from subscription serializer
2018-07-05 19:26:12 +10:00
Rob Harrington
a902af42a3
Update attribute that errors are added to from credit_card to payment_method
2018-07-05 19:26:12 +10:00
Rob Harrington
edde929ced
Replace uses of #stub with #allow in Admin::CustomersController
2018-07-05 19:26:12 +10:00
Rob Harrington
4863f2b5b4
Remove unrequired credit_card_id field from subscriptions table
2018-07-05 19:26:12 +10:00
Rob Harrington
21c3f7d21c
Remove unrequired #cards and #addresses actions from Admin::CustomerController
2018-07-05 19:26:12 +10:00
Rob Harrington
e0d46aa105
Add new serializer to allow search for customer addresses
2018-07-05 19:26:12 +10:00
Rob Harrington
c71a5ec0df
Update subscription form to use new card validations for Stripe payment method
2018-07-05 19:26:11 +10:00
Rob Harrington
a03dd1e10c
Serialize default card auth and presence for Customers
2018-07-05 19:26:11 +10:00
Rob Harrington
21c24eb69b
Validate presence and auth of default card for customer
2018-07-05 19:26:11 +10:00
Rob Harrington
cf8ca1f8c1
Add show action to Admin::CustomersController
2018-07-05 19:26:11 +10:00
Rob Harrington
45895e9924
Use the user's default card to pay for subcriptions
2018-07-05 19:26:11 +10:00
Rob Harrington
fc2844a3d5
Add default_card method to user model
2018-07-05 19:26:11 +10:00
Frank West
09534b41e9
Remove taxon when primary taxon is changed
...
We are adding taxons to the product as you change the primary taxon.
However we never remove the previous primary taxon so it forces the user
to update the taxons manually. This can be a big problem if you are bulk
updating products.
We now remove the taxon that matches the previously set primary taxon.
2018-07-04 09:16:50 +10:00
Rob Harrington
82e3016a26
Add comment to StripeGateway wrapper methods indicating that they are named by Spree
2018-07-03 14:21:58 +10:00
Rob Harrington
2da6234362
Add spec for StripeGateway#refund
2018-07-03 14:21:58 +10:00
Rob Harrington
c496d0f14d
Allow credit owed on payments made via stripe to be refunded via the admin section
2018-07-03 14:21:58 +10:00
Rob Harrington
108c4a7abb
Add GETTING_STARTED.md and update README.md
2018-06-28 22:11:33 +10:00
Maikel
687612dba8
Merge pull request #2403 from luisramos0/hide-stripe-postcode
...
Hide postcode - not necessary as passed from billing address and wrec…
2018-06-28 08:55:42 +10:00
Maikel Linke
b7de80dd7f
Remove unused count_on_hand setting from spec
...
This spec doesn't need to set the product's `count_on_hand`. The product
comes with a count of 3, but what matters is the count of variants.
2018-06-27 11:41:55 +10:00
Maikel Linke
306bfa1944
Remove unused method enterprise method
...
`Enterprise.has_supplied_products_on_hand?` is not used anywhere.
2018-06-27 11:25:44 +10:00
Maikel Linke
792701297b
Remove unused scope Enterprise.active_distributors
...
Working on the Spree upgrade, we found that this scope is using the soon
obsolete column `spree_products.count_on_hand`. Trying to measure the
impact of changing this scope, I couldn't find any use of it.
There is a variable called `active_distributors` used when serialising
enterprises, but that variable is initialised with
`Enterprise.distributors_with_active_order_cycles.ready_for_checkout`,
not using the `active_distributors` scope.
See also:
https://github.com/openfoodfoundation/openfoodnetwork/issues/2013
2018-06-27 11:12:54 +10:00
Maikel
eb9064f5be
Merge pull request #2383 from frank-west-iii/issue-2271-prepend-load
...
Fix NoMethodError in order cycles index
2018-06-27 09:12:18 +10:00
Maikel
f5346289c7
Merge pull request #2388 from Matt-Yorkley/uk/pi_available_on
...
Add available_on notes to PI guide
2018-06-26 17:58:39 +10:00
Maikel
3f334855d1
Merge pull request #2360 from oeoeaio/faster-stats
...
Rewrite user stat query for improved performance of homepage
2018-06-26 17:58:23 +10:00
Maikel
e9fad741e6
Merge pull request #2387 from Matt-Yorkley/embedded_referrers
...
Embedded response headers
2018-06-26 17:57:48 +10:00
Rob Harrington
ddb9ae1140
Load all shops that a user is associated with as a customer
...
Regardless of the presence of an order
2018-06-24 16:28:47 +10:00
luisramos0
0d9b03b066
Hide postcode - not necessary as passed from billing address and wrecks mobile UX
2018-06-22 11:42:50 +01:00
Rob Harrington
5e6291bce3
Don't request customers if list is already populated
2018-06-22 15:39:47 +10:00
Rob Harrington
d1d9c5a092
Add help button to saved cards list on account page
...
Describes the purpose of the default card
2018-06-22 15:39:47 +10:00
Rob Harrington
7db7084008
Use help-modal to display help text for authorised shops
...
Also updated the text slightly to make it more clear when the purpose of authorised shops are
2018-06-22 15:39:47 +10:00
Rob Harrington
32622c77bc
Add basic help modal directive
...
Useful for showing help text that is too long for a tool tip
2018-06-22 15:39:47 +10:00
Rob Harrington
6457a17fde
Add basic view allowing customers to authorise shop use of their credit cards
2018-06-22 15:39:47 +10:00
Rob Harrington
ffa8a8c7d6
Create Api::BaseController to allow use of ActiveModelSerializers
...
Also add index action to Api::CustomersController
2018-06-22 15:39:47 +10:00
Rob Harrington
29922d4be9
Add allow_charges field to Customer model
2018-06-22 15:39:46 +10:00
Rob Harrington
6e76fd8164
Add Api::CustomersController with update action
2018-06-22 15:39:46 +10:00
Rob Harrington
e25574790b
Split out float: right css from .help-btn.tiny selector
2018-06-22 15:39:46 +10:00
Keir Osborn
bd7e072938
embedded groups layout changes
2018-06-22 14:03:00 +10:00
Keir Osborn
f626a21c5e
embedded groups initial test
2018-06-22 14:03:00 +10:00
Buildkite
964059f25b
Merge remote-tracking branch 'origin/master' into HEAD
2018-06-22 02:41:15 +00:00
Buildkite
57dbf2e770
Merge remote-tracking branch 'origin/master' into HEAD
2018-06-22 00:59:28 +00:00
Rob Harrington
cf9f8edcce
Allow html requests for OrderCycleController#update
...
This is still used from the Advanced Settings page, to update the order_cycle
2018-06-22 09:46:08 +10:00
Rob Harrington
25525ae30b
Move applicator calls to OrderCycleForm
2018-06-22 09:46:08 +10:00
Rob Harrington
f88f4a5791
Refactor OrderCycleForm to make logic clearer
2018-06-22 09:46:08 +10:00
Rob Harrington
d9830749f1
Extract schedule syncing logic into OrderCycleForm
2018-06-22 09:46:08 +10:00
Rob Harrington
21bd9d2e10
Add basic specs for OrderCyclesController#create
2018-06-22 09:46:08 +10:00
Rob Harrington
ab9c06837b
Add basic OrderCycleForm to handle create/update logic
2018-06-22 09:46:08 +10:00
Rob Harrington
3f5b6be5b6
Remove unnecessary respond_to blocks from OrderCyclesController
2018-06-22 09:46:08 +10:00
Matt-Yorkley
172fa168ea
Change layout attribute to method with question mark
2018-06-21 15:19:40 +01:00
Matt-Yorkley
aaba6da162
Add available_on notes to PI guide
2018-06-21 14:20:59 +10:00
Matt-Yorkley
d9623176fb
Include admin users as managers on new enterprises
2018-06-21 13:21:08 +10:00
Maikel Linke
d510df5236
Remove obsolete goWithoutHashFragments
...
It was introduced, because `Navigation.go` perserved hash fragments. We
actually don't need that behaviour and it has been corrected.
`goWithoutHashFragments` also didn't deal with absolute URLs. And it used
`location.origin` which is not supported by Internet Explorer. That is
fixed by our use of Modernizr though.
2018-06-21 10:29:32 +10:00
Maikel Linke
fb02bdd25a
Simplify Navigation.go, not preserving hash fragments
...
I looked through the history and it looks like this function was a bit
flawed (preserving hash fragments) from the beginning. It has been
patched a few times without addressing the underlying issue that we want
more than just replacing the pathname. We want to go somewhere else.
2018-06-21 10:29:32 +10:00
Pau Pérez Fabregat
6cf09c936b
Merge pull request #2345 from luisramos0/do-not-upcase-state
...
removed uppercase from state on shops and producers lists in the frontoffice
2018-06-20 21:30:10 +02:00
Matt-Yorkley
6e81871459
Specs for new EmbeddedPageService
2018-06-20 15:14:56 +01:00
Maikel
3399eba428
Merge pull request #2367 from frank-west-iii/issue-2297-edit-product-cancel
...
Move product bulk edit to product index route
2018-06-20 17:53:57 +10:00
Rob Harrington
a29a1bd047
Only show change warning for open order cycles
2018-06-20 16:28:36 +10:00
Rob Harrington
7af11da901
Use a SubscriptionsCount query object to provide counts to IndexOrderCycleSerializer
2018-06-20 13:06:06 +10:00
Rob Harrington
d5b1041481
Preload subscription counts for serialization in order cycle collection actions
2018-06-20 13:06:06 +10:00
Rob Harrington
8770122eae
Request the subscription count for change warning each time, don't cache
2018-06-20 13:06:05 +10:00
Rob Harrington
86d7453d26
Ask user to confirm oc date change for open order cycles with subsciptions
2018-06-20 13:06:05 +10:00
Maikel Linke
bbe21b7804
Merge branch 'master' of github.com:openfoodfoundation/openfoodnetwork into issue-2297-edit-product-cancel
2018-06-20 10:31:17 +10:00
Matt-Yorkley
ff0e0d9f3d
Move logic from ApplicationController to service and improve clarity
2018-06-20 01:28:35 +01:00
Matt-Yorkley
e73b378201
Adjust embedded response headers
2018-06-20 01:28:35 +01:00
luisramos0
b8f1571282
added directive to make links open in new tab by default in textangular text areas in enterprise description, enterprise group description and in shopfront open and closed messages
2018-06-19 16:53:21 +01:00
Pau Pérez Fabregat
8da8a5a086
Merge pull request #2392 from openfoodfoundation/transifex
...
Transifex
2018-06-19 13:37:38 +02:00
Pau Pérez Fabregat
20c25cd030
Merge pull request #2368 from Matt-Yorkley/uk/admin_orders
...
Uk/admin orders
2018-06-19 11:00:35 +02:00
Frank West
3821b9e0da
Fix ordering of Gemfile.lock
...
When we run bundle the gems are being reordered to be alphabetical.
Seems to have been committed on 26/05/2018 here:
7a64ad1cc1
2018-06-19 17:51:24 +10:00
Frank West
f7848b025f
Add rack-rewrite to handle redirects
...
We are moving bulk edit to a different route and we want to be able to
handle redirects on this route. Handling this at the rack level before
the rails stack is the most performant way outside of rewrites on the
web server itself.
2018-06-19 17:51:23 +10:00
Frank West
8324b00999
Renames product bulk edit action to index
...
When a user hit cancel while editing a product it took them to the spree
products index page instead of the bulk edit page. The button was part
of a shared view for all resources so changing it's actions were not
readily available.
It was suggested that instead of carrying our own separate controller
action we could just override the index action of the products
controller with the bulk edit functionality instead. This has the
advantage of removing some overrides and allows us to not add
additional overrides in the future.
2018-06-19 17:51:23 +10:00
Pau Pérez Fabregat
3484996dbd
Merge pull request #2335 from luisramos0/issue2334
...
Fixed missing translations on shops filter - delivery option
2018-06-19 09:34:13 +02:00
Pau Pérez Fabregat
236920d28f
Merge pull request #2357 from luisramos0/enterprises_country_state
...
changed the country and state selectors to angular on enterprises admin
2018-06-19 09:30:24 +02:00
Pau Pérez Fabregat
b1bccb07f2
Merge pull request #2369 from coopdevs/product-import-for-superadmins-only
...
Show product import's UI only to superadmins
2018-06-19 09:23:58 +02:00
Transifex-Openfoodnetwork
55e619af8d
Updating translations for config/locales/de_DE.yml
2018-06-19 10:59:37 +10:00
Rob Harrington
dabef16606
Use ofn-select2 directive for country and state selectors on enterprise forms
2018-06-19 10:34:02 +10:00
luisramos0
d1019fcc5e
changed the country and state selectors to angular on enterprises admin (new and edit screens) so that states are dynamically updated when country is changed
2018-06-19 10:34:02 +10:00
Maikel
2bfb635bcc
Merge pull request #2341 from luisramos0/checkout_country_state
...
fixed country_state selectors on checkout
2018-06-19 09:34:21 +10:00
Transifex-Openfoodnetwork
fe39d96e7f
Updating translations for config/locales/fr_CA.yml
2018-06-19 05:48:59 +10:00
Frank West
f2e1caabff
Fix NoMethodError in order cycles index
...
When a user's session has timed out and they try to load new data on the
order cycles page by changing filters, the application throws a
`NoMethodError` because we are prepending the load data method before
checking the user's session.
We can fix this by removing the prepend on this action.
2018-06-18 06:36:55 -07:00
Maikel
f272a7b604
Merge pull request #2361 from mkllnk/2356-report-search-hint
...
2356 report search hint
2018-06-18 14:51:48 +10:00
luisramos0
ea9ea83fee
improved checkout country and state selectors code
2018-06-18 14:50:03 +10:00
luisramos0
3cb0b76d21
fixed checkout tests by replacing state abbr with name in address selector boxes
2018-06-18 14:50:03 +10:00
luisramos0
836a5836d9
fixed country_state selectors on checkout
2018-06-18 14:50:03 +10:00
Maikel Linke
b7770510a7
Use CSS for layout
2018-06-18 11:08:58 +10:00
Maikel Linke
67c2574b0b
Show report search instructions
...
Solves: https://github.com/openfoodfoundation/openfoodnetwork/issues/2356
2018-06-18 11:08:58 +10:00
Maikel Linke
7a2218fe26
Style the reports controller
2018-06-18 11:08:58 +10:00
Maikel Linke
6243640bca
Unify sales tax report rendering with others
2018-06-18 11:08:58 +10:00
Maikel Linke
66567fd9e6
Unify report table rendering
...
There is a lot of code duplication in the report views and we would like
to change that code. So we move it into one file first.
2018-06-18 11:08:58 +10:00
Maikel
86ff24b43c
Merge pull request #2386 from frank-west-iii/fix-ssl-errors-specs
...
Set the SSL protocol for secure connections
2018-06-18 08:45:31 +10:00
Frank West
0d7352813c
Set the SSL protocol for secure connections
...
There are ssl errors when using stripe through phantom js. This allows
other SSL protocols now.
2018-06-15 11:43:26 -07:00
Rob H
61f303ced2
Merge pull request #2373 from oeoeaio/fix-import-date-filter
...
Reimplement import date filter as an actual Filter
2018-06-15 16:53:22 +10:00
Rob Harrington
d0f8e9fba6
Reimplement import date filter as an actual Filter
2018-06-15 11:31:47 +10:00
Maikel
46f5f5061a
Merge pull request #2377 from mkllnk/2376-fix-paypal-redirects
...
Pass on redirect path instead of URL
2018-06-15 10:16:31 +10:00
Maikel Linke
561a73e911
Pass on redirect path instead of URL
...
Fixes https://github.com/openfoodfoundation/openfoodnetwork/issues/2376
The checkout doesn't deal with absolute URLs since
fc2cc09ea5 .
2018-06-14 16:49:52 +10:00
Pau Pérez Fabregat
24c6b940f6
Merge pull request #2370 from openfoodfoundation/transifex
...
Transifex
2018-06-13 12:03:34 +02:00
Rob Harrington
c72a2fda91
Use placed_at state to determine whether to remove orphaned proxy orders
2018-06-13 13:46:11 +10:00
Rob Harrington
d9ddad554e
Prevent proxy_orders for active or complete order cycles from being removed automatically by ProxyOrderSyncer
2018-06-13 13:46:11 +10:00
Rob Harrington
ac309ffaf5
Rename obsolete_proxy_orders to orphaned_proxy_orders
2018-06-13 13:46:11 +10:00
Maikel
51bbf64b10
Merge pull request #2363 from oeoeaio/update-contributors
...
Update contributors list in the README
2018-06-13 11:11:29 +10:00
Matt-Yorkley
ea0d24a5bf
Re-word test names for clarity
2018-06-12 13:20:00 +01:00
Transifex-Openfoodnetwork
644c2e8788
Updating translations for config/locales/nb.yml
2018-06-12 20:33:43 +10:00
Transifex-Openfoodnetwork
03fb5e7ccf
Updating translations for config/locales/fr.yml
2018-06-12 20:03:03 +10:00
Transifex-Openfoodnetwork
6908635822
Updating translations for config/locales/pt.yml
2018-06-12 19:36:28 +10:00
Pau Perez
78e59d059a
Show product import's UI only to superadmins
...
We still need to iterate on its implementation and it's too early to
make it publicly available.
2018-06-11 19:50:53 +02:00
Rob Harrington
56040685a0
Add Matt, Pau and Enrico to the contributors list on the README
2018-06-10 18:26:50 +10:00
Matt-Yorkley
c7f7541e2d
Admin order customer details spec
2018-06-10 02:32:59 +01:00
Matt-Yorkley
d90e362e6f
Remove guest checkout radio buttons from admin order view
2018-06-09 02:43:42 +01:00
Matt-Yorkley
7bef474efd
Admin Order guest checkout status
2018-06-09 02:43:42 +01:00
Pau Pérez Fabregat
4c9dd4e8a1
Merge pull request #2349 from robotscissors/issue-2278-add-missing-image
...
Add image back into server for background
2018-06-08 19:12:01 +02:00
luisramos0
9e0732ceae
removed uppercase from state on shops and producers lists in the frontoffice
2018-06-08 14:11:53 +01:00
Pau Pérez Fabregat
bb3ae976c6
Merge pull request #2364 from coopdevs/update-template
...
Ask devs to tell whether we should test on mobile
2018-06-08 14:37:16 +02:00
Pau Perez
fed60cf961
Ask devs to tell whether we should test on mobile
2018-06-08 10:01:04 +02:00
Pau Pérez Fabregat
b77091f87d
Merge pull request #1969 from coopdevs/feature/do-not-upcase-state-abbr
...
Do not upcase State abbreviation
2018-06-08 08:36:55 +02:00
Rob Harrington
5cbc4cbf30
Use scoped keys for table headers in saved card partial
2018-06-08 15:30:08 +10:00
Rob Harrington
18c211e97c
Ensure that savedCreditCards always exists
2018-06-08 15:30:08 +10:00
Rob Harrington
6a202d9446
Use more descriptive name for after_save callback method: :ensure_single_default_card
2018-06-08 15:30:08 +10:00
Rob Harrington
5dbf98f39b
Use exists? method to avoid unnecesary loading of credit card array
2018-06-08 15:30:07 +10:00
Rob Harrington
05e4d9007e
Update card spec to make the initial roles of cards clearer
2018-06-08 15:30:07 +10:00
Rob Harrington
254f0db97c
Automatically select the customer's default card in the checkout
2018-06-08 15:30:07 +10:00
Rob Harrington
e88e963b4c
Alter cards interface to allow updating of default card
2018-06-08 15:30:07 +10:00
Rob Harrington
1327b9dc2c
Add update method to CreditCardsController
2018-06-08 15:30:07 +10:00
Rob Harrington
d146d3714f
Add callbacks to ensure a user always has a default credit card
...
(if any exist)
2018-06-08 15:30:01 +10:00
robotscissors
5c25e85d92
Create dark background on load
2018-06-07 21:53:17 -07:00
Rob Harrington
3619ec0dc8
Add is_default attribute to Spree::CreditCard model
2018-06-08 12:01:10 +10:00
Pau Pérez Fabregat
d4e0d14fe1
Merge pull request #2342 from openfoodfoundation/transifex
...
Transifex
2018-06-06 09:05:29 +02:00
Rob Harrington
4fa09639cb
Rewrite user stat query for improved performance of homepage
2018-06-06 16:27:23 +10:00
Pau Pérez Fabregat
7ff7fe4891
Merge pull request #2122 from oeoeaio/subs-unplaced-fees
...
Subs: prevent fees from displaying in email when subscription order cannot be fulfilled
2018-06-06 07:57:18 +02:00
Maikel
9d2c1976e0
Merge pull request #2343 from mkllnk/2212-remove-report-default-filters
...
2212 remove report default filters
2018-06-06 12:19:47 +10:00
Maikel
494aeb9a14
Merge pull request #2348 from oeoeaio/fix-tabs
...
Provide specific tab widths for shop tabs when screen width > medium
2018-06-05 15:27:40 +10:00
Pau Pérez Fabregat
3283c5158b
Merge pull request #1492 from Matt-Yorkley/uk/import2
...
Uk/import2
2018-06-04 09:56:36 +02:00
Pau Pérez Fabregat
cf77bb439a
Merge pull request #2337 from Matt-Yorkley/uk/modal_fix
...
Fix guest checkout login modal
2018-06-04 09:56:00 +02:00
Pau Pérez Fabregat
ed116867d4
Merge pull request #2322 from luisramos0/issue1913
...
Fixed issue #1913 with expand/collapse of list of producers of a shop
2018-06-04 09:55:40 +02:00
Rob Harrington
fed0a81159
Add an optional link to Skylight dashboard to footer
2018-06-02 11:55:28 +10:00
Rob Harrington
e3ea60fda5
Process proxy orders even if underlying subscription has been paused or cancelled
2018-06-01 16:57:56 +10:00
robotscissors
65e13c2a2d
add image back into server for background
2018-05-30 20:42:31 -07:00
Rob Harrington
8201da9fab
Prodide specific tab widths for shop tabs when screen width > medium
2018-05-30 17:05:31 +10:00
Rob Harrington
184bf9ce36
Allow super admin users to enable subscriptions for enterprises
2018-05-30 09:42:03 +10:00
Rob Harrington
16211da5f6
Reimplement tabs on shopfront using our custom tab directive
2018-05-30 08:35:21 +10:00
Maikel
cb19643b3a
Merge pull request #2332 from oeoeaio/1938-oc-switch
...
Correct 'Next Order Closing' text in shopfront when switching OCs
2018-05-30 08:28:23 +10:00
Maikel
cee2f76406
Merge pull request #2299 from frank-west-iii/issue-1832-phone-shopfront
...
Add phone number to shopfront contact info
2018-05-30 08:27:07 +10:00
Maikel
32ef507221
Merge pull request #2318 from luisramos0/issue2307
...
Fixed broken translation keys in "new order cycle" screen
2018-05-29 17:38:04 +10:00
Maikel
603c88a93c
Merge pull request #2317 from luisramos0/issue2308
...
Added missing translation key for no results in admin orders page
2018-05-29 17:37:26 +10:00
Maikel
307132d1f7
Merge pull request #2298 from frank-west-iii/issue-953-ent-description-formatting
...
Fix enterprise description display formatting
2018-05-29 17:36:47 +10:00
Maikel Linke
e6ef43c91d
Give a spec some style
2018-05-29 16:55:30 +10:00
Maikel Linke
54bdcf7679
Convert specs to RSpec 3.7.0 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/lib/open_food_network/xero_invoices_report_spec.rb
* 15 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 10 conversions
from: obj.should
to: expect(obj).to
* 4 conversions
from: == expected
to: eq(expected)
* 3 conversions
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-05-29 16:53:18 +10:00
Maikel Linke
72ae6f2af6
Add spec helper to make spec run on its own
2018-05-29 16:49:00 +10:00
Maikel Linke
02c4795640
Remove default dates from reports
...
Closes https://github.com/openfoodfoundation/openfoodnetwork/issues/2212
2018-05-29 16:47:23 +10:00
Transifex-Openfoodnetwork
6d450aeae2
Updating translations for config/locales/pt.yml
2018-05-29 14:53:01 +10:00
Transifex-Openfoodnetwork
d1e9d52acd
Updating translations for config/locales/fr.yml
2018-05-29 14:51:07 +10:00
Matt-Yorkley
b440d05205
Tidy up unnecessary PI code
2018-05-26 19:34:20 +01:00
Matt-Yorkley
a4a2bc438a
Import settings spec
2018-05-26 19:34:20 +01:00
Matt-Yorkley
a503b5e2d0
Add not_master scope to Spree::Variant
2018-05-26 19:34:20 +01:00
Matt-Yorkley
91521dc2b0
Improve import_date queries
2018-05-26 19:34:20 +01:00
Matt-Yorkley
6f6db9384f
Tidy up SCSS and coffeescript
2018-05-26 19:34:20 +01:00
Matt-Yorkley
d9c720e89a
Tidy up import_date
2018-05-26 19:34:20 +01:00
Matt-Yorkley
73f7bc3db0
Remove use of before_filter
2018-05-26 19:34:20 +01:00
Matt-Yorkley
e65bdf35fa
Change wording on default import settings text
2018-05-26 19:34:20 +01:00
Matt-Yorkley
c5b7cec19f
Change checkbox confirmation behaviour
2018-05-26 19:34:20 +01:00
Matt-Yorkley
58e9f0266a
User guide check
2018-05-26 19:34:20 +01:00
Matt-Yorkley
b42e3eb2c9
Product Import Guide WIP
2018-05-26 19:34:20 +01:00
Matt-Yorkley
7da97be7d2
Create separate angular module
2018-05-26 19:34:20 +01:00
Matt-Yorkley
c2c42e1d9a
Product Import refactor
2018-05-26 19:34:20 +01:00
Matt-Yorkley
11908f125e
Fix flaky spec
2018-05-26 19:34:20 +01:00
Matt-Yorkley
1ed49d397e
Refactor PI
2018-05-26 19:34:20 +01:00
Matt-Yorkley
1ff39b8df5
Fix altered translation key
2018-05-26 19:34:20 +01:00
Matt-Yorkley
7a64ad1cc1
Fix roo-xls version in Gemfile
2018-05-26 19:34:20 +01:00
Matt-Yorkley
3a6f316ede
Codeclimate refactor
2018-05-26 19:34:20 +01:00
Matt-Yorkley
7c283d90db
Spec adjustments
2018-05-26 19:34:19 +01:00
Matt-Yorkley
1c34ce6162
PI exception handling
2018-05-26 19:34:19 +01:00
Matt-Yorkley
b26bec45d6
Expanding PI specs
...
squash
2018-05-26 19:34:19 +01:00
Matt-Yorkley
6efd167400
PI inventories UX
...
Minor tweaks
2018-05-26 19:34:19 +01:00
Matt-Yorkley
678a2a365d
Fix spec date to string issue
2018-05-26 19:34:19 +01:00
Matt-Yorkley
2ef63efe28
Tax and Shipping adjustments
2018-05-26 19:34:19 +01:00
Matt-Yorkley
fe01e8ede3
PI human-readable unit fields
...
Enhanced unit specs
2018-05-26 19:34:19 +01:00
Matt-Yorkley
02661d5c23
PI unit_value typecasting
2018-05-26 19:34:19 +01:00
Matt-Yorkley
e848957712
Clean up PI controller
...
Remove assignment
Tweak
2018-05-26 19:34:19 +01:00
Matt-Yorkley
b3c906b3a4
Product Import v3 with asynchronous processing
...
Fixed spec
Quick spec tweak
2018-05-26 19:34:19 +01:00
Matt-Yorkley
3a650dd8b3
Add roo-xls gem for Excel support
2018-05-26 19:34:19 +01:00
Matt-Yorkley
684b493fb3
PI translations
2018-05-26 19:34:19 +01:00
Matt-Yorkley
6e2de0d6ac
PI refactoring
2018-05-26 19:34:19 +01:00
Matt-Yorkley
e76a818fde
Update PI spec
2018-05-26 19:34:19 +01:00
Matt-Yorkley
ffbb67d480
PI inventories additions
2018-05-26 19:34:19 +01:00
Matt-Yorkley
4e97445655
PI inventories timestamps
2018-05-26 19:34:19 +01:00
Matt-Yorkley
a2a65a8900
PI inventories and overhaul
2018-05-26 19:34:19 +01:00
Matt-Yorkley
e362c2d867
PI timestamps
2018-05-26 19:34:19 +01:00
Matt-Yorkley
fc2cc09ea5
checkout redirect excludes angular path variables
2018-05-26 18:13:35 +01:00
luisramos0
533ae77234
Fixed missing translations on shops filter - delivery option
2018-05-25 23:46:44 +01:00
Pau Pérez Fabregat
e04141d797
Merge pull request #2291 from coopdevs/remove-producers-tab-from-dashboard
...
Remove producers tab from dashboard
2018-05-25 19:24:29 +02:00
Rob Harrington
17259b3269
Overwrite cached value for current_order_cycle when updating it
...
This ensures that the correct order cycle is rendered in the json response
2018-05-25 17:28:54 +10:00
Pau Pérez Fabregat
9d57beb33f
Merge pull request #2305 from Matt-Yorkley/uk/domain_headers
...
Ensure domain in SSL header matches request with or without www prefix
2018-05-23 20:08:56 +02:00
luisramos0
d821664ee3
Fixed issue #1913 with expand/collapse of list of producers of a shop
2018-05-23 17:32:38 +01:00
luisramos0
a59d9cb670
Fixed broken translation keys in new order cycle screen
2018-05-23 13:12:56 +01:00
Luis Ramos
12232f552c
Added missing translation key for no results in admin orders page
2018-05-22 21:00:03 +01:00
Pau Perez
2a3772dba0
Do not show icons for producer-enterprises
...
Payment and shipping methods don't apply to them.
2018-05-22 16:50:27 +02:00
Pau Perez
208e3bbadd
Ensure non-distributors are listed in dashboard
...
We want to show all enterprises in a single list regardless of their
type.
2018-05-22 10:21:35 +02:00
Pau Perez
bd34f27ace
Inline partials into enterprises view
...
Now there are no tabs in the dashboard so is pointless to refer to them
and to split in multiple partials.
2018-05-22 10:21:35 +02:00
Pau Perez
889199a525
Refactor Overview Controller to make it more clear
...
Assigns meaningful names to the boolean conditions to make it easier
to understand, breaks down the big and nested if/else and converts the
specs to RSpec 3.
Note the check `!spree_current_user.admin?` has been removed because
in admin/base_controller_decorator.rb `#authorize_admin` is already
called.
2018-05-22 10:21:35 +02:00
Pau Perez
51f3542a92
Remove no longer used Angular controller
...
There are no tabs to keep track of now.
2018-05-22 10:21:35 +02:00
Pau Perez
5a182e8e88
Remove enterprises producers tab from dashboard
2018-05-22 10:21:35 +02:00
Matt-Yorkley
c2934d3570
Ensure domain in SSL header matches request with or without www prefix
2018-05-21 17:50:34 +01:00
Frank West
f995a04ebf
Add phone number to shopfront contact info
2018-05-18 14:05:28 -07:00
Frank West
b05b9747b8
Fix enterprise description display formatting
...
Removes `text-small` class from container and change container to `div`
instead of `p` for semantic differentiation.
2018-05-18 07:20:56 -07:00
Maikel Linke
d218a51d96
Test public instead of private method
...
Refactoring and styling the whole thing, possibly causing conflicts with
other pull requests.
2018-05-18 11:27:48 +10:00
Maikel Linke
57dd984512
Convert specs to RSpec 3.7.0 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/lib/open_food_network/order_and_distributor_report_spec.rb
* 2 conversions
from: == expected
to: eq(expected)
* 2 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-05-18 11:27:48 +10:00
Maikel Linke
7f8f935017
Shorten module referencing
2018-05-18 11:27:48 +10:00
Maikel Linke
0fa9ca653e
Move duplicate code into its own module
2018-05-18 11:27:48 +10:00
Maikel Linke
40b0a0bd5a
Determine searching state by params, not request
...
We may want to use GET for searching or POST to display a certain report
type.
2018-05-18 11:27:48 +10:00
Maikel Linke
8a1a540f3d
Clarify creating objects for test context
2018-05-18 11:27:48 +10:00
Maikel Linke
acee5da31b
Remove unnecessary whitespace
2018-05-18 11:27:48 +10:00
Maikel Linke
8a4457e8e4
Give better names
2018-05-18 11:27:48 +10:00
Maikel Linke
63799b2cb1
Remove outdated comment
2018-05-18 11:27:48 +10:00
Maikel Linke
8e2aee71da
Compile Order Cycle Management only on search
2018-05-18 11:27:48 +10:00
Maikel Linke
7a546087b2
Compile Packing report data only on search
2018-05-18 11:27:47 +10:00
Maikel Linke
1e80487afc
Compile Order And Distributors only on search
...
And move most logic into the report class like the others.
2018-05-18 11:27:47 +10:00
Maikel Linke
53436024e2
Compile Orders & Fulfillment report only on search
2018-05-18 11:27:47 +10:00
Maikel Linke
feb33c3ca5
Compile Payments report only on search
2018-05-18 11:27:47 +10:00
Maikel Linke
bf74282e5f
Compile Bulk Co-Op report only on search
2018-05-18 11:27:47 +10:00
Maikel Linke
5f9d239f19
Compile Products & Inventory report only on search
2018-05-18 11:27:47 +10:00
Maikel Linke
d464216027
Don't compile Sales Tax report data before search
2018-05-18 11:27:47 +10:00
Maikel Linke
983e128d90
Half test run time by loading less data
...
On my computer it took 3 seconds to load all four orders with all the
attached order cycles and enterprises.
Runtime before: 56.38 seconds
Runtime after: 25.14 seconds
This really speeds up developing reports.
2018-05-18 11:27:47 +10:00
Maikel Linke
b8ca37e9d2
Don't compile xero report data before search
2018-05-18 11:27:47 +10:00
Maikel Linke
14e7cdd138
Don't compile customers report data before search
...
Distributors, suppliers and order cycles are still loaded for the search
form.
2018-05-18 11:27:47 +10:00
Maikel Linke
8393b1d4c0
Don't compile user-enterprises report before search
2018-05-18 11:27:47 +10:00
Maikel Linke
fcd41c67fa
Add logic for showing empty reports initially
2018-05-18 11:27:47 +10:00
Maikel Linke
031c4d417e
Simplify report rendering
2018-05-18 11:27:47 +10:00
Maikel Linke
41bb5e4e96
Unify report rendering
2018-05-18 11:27:47 +10:00
Maikel Linke
28d66ad3e0
Activate dormant specs
...
It looks like a typo prevented a bunch of specs from being run.
2018-05-18 11:27:47 +10:00
Maikel Linke
5aef7031d2
Convert specs to RSpec 3.7.0 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/features/admin/reports_spec.rb
* 40 conversions
from: obj.should
to: expect(obj).to
* 10 conversions
from: == expected
to: eq(expected)
* 3 conversions
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-05-18 11:27:46 +10:00
Maikel Linke
682b92e617
Avoid deprication warning for using stub
2018-05-18 11:27:46 +10:00
Maikel Linke
99a6afd9cd
Convert specs to RSpec 3.7.0 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/controllers/spree/admin/reports_controller_spec.rb
* 20 conversions
from: obj.should
to: expect(obj).to
* 14 conversions
from: obj.should_not
to: expect(obj).not_to
* 5 conversions
from: == expected
to: eq(expected)
* 4 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 2 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-05-18 11:27:46 +10:00
Maikel Linke
f3d542a3ec
Fix style and spelling
2018-05-18 11:27:46 +10:00
Maikel Linke
36b5f0eea7
Render only displayed report options
2018-05-18 11:27:46 +10:00
Maikel Linke
742e9d2a5f
Remove more code duplication
2018-05-18 11:27:46 +10:00
Maikel Linke
6a52ca8113
Remove code duplication
2018-05-18 11:27:46 +10:00
Maikel
4df9a0afa2
Merge pull request #2272 from rtrunkhill/620-error-message-tweak
...
changed error message in en.yml line 2207
2018-05-18 11:19:45 +10:00
Maikel
48b9536621
Merge pull request #2268 from stveep/1213-back-empties-cart
...
Set response headers to disable cache - to avoid back button emptying…
2018-05-18 10:54:05 +10:00
stveep
6efc0ab802
Set response headers to disable cache - to avoid back button emptying cart ( #1213 )
2018-05-18 09:57:32 +10:00
Maikel
b15f4de921
Merge pull request #2270 from mkllnk/2265-update-active-merchant
...
Update activemerchant to v1.78 with new root cert
2018-05-18 09:54:15 +10:00
Rory Trunkhill
5706cecf26
modify enterprise eror name message #620
2018-05-17 18:10:35 +00:00
Pau Pérez Fabregat
e356d712c4
Merge pull request #2288 from frank-west-iii/issue-2182-confirm-first-user
...
Confirm first user when seeding database
2018-05-16 08:51:12 +02:00
Maikel Linke
585bba0e23
Update activemerchant to v1.78 with new root cert
...
Fixes https://github.com/openfoodfoundation/openfoodnetwork/issues/2265 .
Most changes are in gateways we don't use, I believe. There has been a
change in Stripe, but we use another implementation, I guess.
2018-05-15 16:48:03 +10:00
Pau Pérez Fabregat
a28fa441c5
Merge pull request #2282 from openfoodfoundation/transifex
...
Transifex
2018-05-15 08:24:39 +02:00
Maikel
1b371e6388
Merge pull request #2249 from mkllnk/upgrade-rubocop-config
...
Upgrade Rubocop config to be compatible with 0.55
2018-05-15 16:19:38 +10:00
Maikel Linke
7c68ac9d0c
Wait for dialog to appear before using it
...
Travis was failing a few times. This should make the spec more robust.
2018-05-15 15:00:18 +10:00
Frank West
91351c3f78
Confirm first user when seeding database
...
Currently the first user is not confirmed until running the task
`openfoodnetwork:dev:load_sample_data`. This task does not need to be
run on a minimum implementation of a new server or development setup.
We now confirm the first user during seeding. This could be the default
email address or the user entered email address entered during seeding.
2018-05-14 15:30:04 -07:00
Buildkite
f2e07419a8
Merge remote-tracking branch 'origin/master' into HEAD
2018-05-11 03:37:13 +00:00
Matt-Yorkley
495f932069
Authentication service class description
2018-05-11 12:05:27 +10:00
Matt-Yorkley
74689afb8a
Unregistered user checkout issue
2018-05-11 12:05:27 +10:00
Matt-Yorkley
d3344973b7
checkout_controller clarity
2018-05-11 12:05:27 +10:00
Matt-Yorkley
9841f27f92
Add missing key for devise message
2018-05-11 12:05:27 +10:00
Matt-Yorkley
0741b5fa58
Ensure checkout modal opens at correct height
2018-05-11 12:05:27 +10:00
Maikel Linke
45fc42723c
Simplify query for existing email
...
It should be easier to read and more efficient now.
2018-05-11 12:05:27 +10:00
Maikel Linke
fe979b801f
Improve readability by grouping depending logic
2018-05-11 12:05:27 +10:00
Matt-Yorkley
358edb4727
Disable guest checkout in model
2018-05-11 12:05:27 +10:00
Matt-Yorkley
6b2c4de20f
Tidy up checkout spec
2018-05-11 12:05:27 +10:00
Matt-Yorkley
94b90b4a73
Registered user controller method spec
2018-05-11 12:05:27 +10:00
Matt-Yorkley
598677be3f
Disable guest checkout for registered users
2018-05-11 12:05:26 +10:00
Daniel Dominguez
4551fa60c5
Lowercase tag when adding a tag to the array, as they are lowercased after at the database level,
...
there is no point to display them with uppercase letters on the view.
2018-05-11 11:16:58 +10:00
Maikel Linke
7caf166768
Updates pulled from Transifex
2018-05-10 09:42:34 +10:00
Transifex-Openfoodnetwork
48217a54b9
Updating translations for config/locales/es.yml
2018-05-09 22:58:59 +10:00
Maikel Linke
8a3244513f
Run Codeclimate with new rubocop
2018-05-08 15:29:04 +10:00
Maikel Linke
fcb9d1411f
Exclude file that rubocop fails to parse
2018-05-08 15:19:44 +10:00
Maikel Linke
21b96c63af
Update cop naming
2018-05-08 14:52:13 +10:00
Maikel Linke
10d3abeaac
Upgrade Rubocop to the latest version
2018-05-08 14:46:57 +10:00
Steven Lawson
fd3e0d885b
Closes issue 1926, Changed package screen text from choose your starting point to choose your package
2018-05-07 17:15:55 -06:00
Pau Pérez Fabregat
98985d7211
Merge pull request #2266 from dan1d/upgrade-to-factory-bot
...
Switched gem FactoryGirl to FactoryBot as FactoryGirl is deprecated.
2018-05-07 15:22:12 +02:00
Daniel Dominguez
9d9a974295
Switched gem FactoryGirl to FactoryBot as FactoryGirl is deprecated.
...
- Change FactoryGirl to FactoryBot everywhere on code.
2018-05-04 11:52:08 -03:00
Pau Pérez Fabregat
501ad8107d
Merge pull request #2264 from coopdevs/exclude-js-libs-from-codeclimate
...
Exclude shared JS libs from CodeClimate
2018-05-03 16:53:45 +02:00
Pau Pérez Fabregat
8713bacfab
Merge pull request #2260 from coopdevs/improve-report
...
Improve order_and_distributor report's readability
2018-05-03 16:52:16 +02:00
Pau Perez
dd14915209
Exclude shared JS libs from CodeClimate
...
CodeClimate is raising issues from code that we don't own and won't
touch thus, causing false negatives.
2018-05-03 13:56:19 +02:00
Pau Perez
5da9b55cdd
Improve order_and_distributor report's readability
2018-05-02 12:26:42 +02:00
Pau Pérez Fabregat
21ebb5849c
Merge pull request #2258 from mkllnk/2254-invite-manager-flow
...
Fix initial password setting
2018-05-02 08:48:36 +02:00
Pau Pérez Fabregat
b2301190af
Merge pull request #2259 from mkllnk/remove-heroku
...
Remove Heroku references since nobody is using it
2018-05-02 08:43:51 +02:00
Maikel Linke
c597b3c377
Speed-up spec
2018-05-01 14:40:05 +10:00
Maikel Linke
7b06abd4c2
Fix initial password setting
2018-05-01 14:18:56 +10:00
Maikel Linke
de5124f90c
Remove Heroku references since nobody is using it
2018-05-01 10:20:21 +10:00
Pau Pérez Fabregat
d238aedb21
Merge pull request #2224 from coopdevs/minor-upgrade-rails
...
Upgrade Rails to 3.2.22.5 to get security fixes
2018-04-27 12:46:26 +02:00
Matt-Yorkley
a08b095547
Extract json render from :user_confirmed? method
2018-04-27 12:37:42 +10:00
Matt-Yorkley
1c57f0f241
Update :return_url value when re-sending email confirmations
2018-04-27 12:37:42 +10:00
Matt-Yorkley
1f23402912
Disable password reset for unconfirmed users
2018-04-27 12:37:42 +10:00
Matt-Yorkley
1782a8c700
manager invite permissions spec
2018-04-27 10:13:54 +10:00
Matt-Yorkley
b431a7417a
Add cancan permissions for Admin::ManagerInvitationsController
2018-04-27 10:13:54 +10:00
Enrico Stano
6ae1780180
Merge pull request #2248 from coopdevs/upgrade-rubyzip
...
Update rubyzip to fix security issue
2018-04-26 14:50:10 +02:00
Pau Pérez Fabregat
1abf56efd5
Merge pull request #2246 from coopdevs/autofix-comment-indentation
...
Autofix comment indentation
2018-04-25 15:39:34 +02:00
Pau Perez
c12ac91371
Update rubyzip to fix security issue
...
Github reported us about CVE-2017-5946 which is a high severity issue.
This gem is used by Roo which already supports the Rubyzip version that
contains the fix (version 1.2.1). Check
872bb3a0b6
for further details.
Rubyzip's changelog for the version 1.2.1 can be found in
https://github.com/rubyzip/rubyzip/blob/master/Changelog.md#121 .
2018-04-24 16:08:34 +02:00
Pau Perez
25ad9b22aa
Update .rubocop_todo.yml
2018-04-23 13:03:05 +02:00
Pau Perez
11081ab1d6
Autocorrect Rubocop's Layout/CommentIndentation cop
2018-04-23 12:51:09 +02:00
Maikel Linke
3fc49d5935
Simplify code
2018-04-23 12:55:49 +10:00
Matt-Yorkley
cd4268d219
Add manager dropdown UX
2018-04-23 12:55:49 +10:00
Rob Harrington
c77a01815c
Copy datepicker directive to utils module
...
Ensures that datepicker is available for subscriptions
2018-04-23 11:05:22 +10:00
Pau Pérez Fabregat
386716088a
Merge pull request #2190 from Matt-Yorkley/uk/bep_images_modal
...
Use angular translation filter on image upload modal
2018-04-20 16:22:53 +02:00
Pau Pérez Fabregat
9a75728b6e
Merge pull request #2231 from coopdevs/add-image-for-wiki
...
Add image to be used in Spree upgrade wiki page
2018-04-20 09:26:17 +02:00
Pau Perez
ef3ef2d4f3
Upgrade Rails to 3.2.22.5 to get security fixes
...
This will fix reported vulnerabilities CVE-2015-7576, CVE-2016-2098
(reported as high severity), CVE-2016-0751 and CVE-2015-7577.
2018-04-17 20:56:51 +02:00
Pau Perez
cd9d13cb2a
Add images to be used in Spree upgrade wiki page
2018-04-17 20:55:42 +02:00
Pau Pérez Fabregat
89bc9380eb
Merge pull request #2232 from coopdevs/skip-feature-spec-until-fixed
...
Disable totally unreliable feature test
2018-04-17 20:54:20 +02:00
Pau Perez
9f06d1f809
Disable totally unreliable feature
...
We need to investigate why it fails so many times fix it and then enable it
back. As it is, it brings cons than pros preventing even PRs that don't
touch code from being merged.
2018-04-17 19:22:03 +02:00
Pau Pérez Fabregat
ac37b0fc7e
Merge pull request #2221 from Matt-Yorkley/uk/bep_images_ux
...
Close modal when image updated successfully
2018-04-17 18:05:20 +02:00
Pau Pérez Fabregat
1abfe2ab8c
Merge pull request #2199 from coopdevs/auto-correct-cops
...
Auto correct cops
2018-04-16 14:58:28 +02:00
Pau Pérez Fabregat
b1fc15f242
Merge pull request #2223 from openfoodfoundation/transifex
...
Transifex
2018-04-16 13:43:40 +02:00
Pau Pérez Fabregat
fc7dd5d081
Merge pull request #2222 from coopdevs/upgrade-skylight
...
Upgrade to latest Skylight from 1.6.0 to 1.6.1
2018-04-16 11:38:23 +02:00
Pau Perez
2aea612f10
Upgrade to latest Skylight from 1.6.0 to 1.6.1
2018-04-16 10:52:15 +02:00
Pau Perez
147a74f005
Fix Rubocop violations reported by Code Climate
2018-04-16 10:27:44 +02:00
Rob Harrington
6a71aafce1
Update totals for empty order before sending email
2018-04-16 17:07:07 +10:00
Rob Harrington
f5e77cdcec
Ensure order total for uplaced subscription orders is zero
2018-04-16 17:07:07 +10:00
Rob Harrington
50ffd7ca01
Clear adjustments on subs orders when no items are able to be fulfilled
...
This prevents shipping and payment fees from being displayed in the notification email
2018-04-16 17:07:07 +10:00
Matt-Yorkley
37ba1e6c83
Close modal when image updated successfully
2018-04-15 20:52:25 +01:00
Matt-Yorkley
5777d04821
Use angular translation filter on image upload modal
2018-04-15 17:08:16 +01:00
Pau Pérez Fabregat
514ad5d898
Merge pull request #2208 from coopdevs/performance-monitoring-badge
...
Add Skylight's performance monitoring badge
2018-04-13 08:45:30 +02:00
Pau Perez
5822e60a66
Add Skylight's performance monitoring badge
...
Adding the badge, which points now to Katuma's performance monitoring
information, is required for Skylight to showcase OFN on their website.
2018-04-12 09:29:40 +02:00
Transifex-Openfoodnetwork
ce2a7a510f
Updating translations for config/locales/en_US.yml
2018-04-11 00:06:55 +10:00
Pau Perez
394fb91dd5
Auto correct Rubocop's Layout/MultilineArrayBraceLayout cop
2018-04-09 18:47:18 +02:00
Pau Perez
1640d5ad0b
Auto correct Rubocop's Layout/IndentHeredoc cop
2018-04-09 18:47:18 +02:00
Pau Perez
76fe1c7ee9
Auto correct Rubocop's Layout/IndentAssignment cop
2018-04-09 18:47:18 +02:00
Pau Perez
33ea2c0b07
Auto correct Rubocop's Layout/FirstParameterIndentation cop
2018-04-09 18:47:18 +02:00
Pau Perez
f5a5d735fd
Auto correct Rubocop's Layout/EmptyLinesAroundModuleBody cop
2018-04-09 18:47:18 +02:00
Pau Perez
6593dea4f6
Auto correct Rubocop's Layout/EmptyLinesAroundMethodBody cop
2018-04-09 18:47:17 +02:00
Pau Perez
3161fa3801
Auto correct Rubocop's Layout/EmptyLinesAroundExceptionHandlingKeywords cop
2018-04-09 18:47:17 +02:00
Pau Perez
746fcd5802
Auto correct Rubocop's Layout/EmptyLinesAroundAccessModifier cop
2018-04-09 18:47:17 +02:00
Pau Perez
9da33b4e82
Auto correct Rubocop's Layout/EmptyLinesAroundAccessModifier cop
...
This also `script/rubocop_autocorrect` to automate the process of fixing
a cop and comitting the changes.
2018-04-09 18:46:11 +02:00
Pau Perez
e876ef7df1
Auto correct Rubocop's Layout/ClosingParenthesisIndentation cop
2018-04-09 17:22:52 +02:00
Pau Perez
e4c86df7b2
Auto correct Rubocop's Layout/CaseIndentation cop
2018-04-09 17:19:47 +02:00
Transifex-Openfoodnetwork
15945fa1e0
Updating translations for config/locales/fr.yml
2018-04-05 04:48:54 +10:00
Transifex-Openfoodnetwork
ad898848f8
Updating translations for config/locales/pt.yml
2018-04-05 04:29:49 +10:00
Rob Harrington
236ba9328d
Order cycles in specs comply with new date validations
2018-04-04 17:18:33 +10:00
Rob Harrington
ce56e667a4
Use union operator instead of concatenate to load order cycle collection
2018-04-04 17:18:33 +10:00
Rob Harrington
b17d8c2fe3
Add validation of open and close dates for order cycles
2018-04-04 17:18:32 +10:00
Rob Harrington
b14f27f956
Return an error if no order_cycle_set params are submitted to #bulk_update action
2018-04-04 17:17:36 +10:00
Rob Harrington
18f7ec992d
Refactor loading of OrderCycleSet in OrderCyclesController
...
This should result in a significant speed bump in saving order cycles in bulk, because only referenced OCs are loaded into the set, rather than OrderCycle.all
2018-04-04 17:17:36 +10:00
stveep
46d2d6cb8a
Include option text in dropdown cart even if the variant and product have the same name
2018-04-04 16:40:18 +10:00
Maikel Linke
a2e4c33922
Remove old and useless sentence from welcome email
...
The sentence made assumptions of the availability of FAQs and support
forums without linking to them. So it didn't really help. It also
promised that someone would monitor the support page in the forum which
nobody seems to do.
2018-04-04 16:21:39 +10:00
Matt-Yorkley
101269a487
Adjust wording on manager invite email
2018-04-04 15:49:04 +10:00
Maikel
61fbdfcefc
Merge pull request #2178 from HugsDaniel/2172_flexi_rate_miscalculated
...
Fixing flexible rate miscalculation
2018-04-04 15:47:33 +10:00
Hugo Daniel
2a942da160
Use rspec context
2018-04-04 14:58:48 +10:00
Hugo Daniel
bd97d08653
Remove stub after test and create two distinct calculators
2018-04-04 14:58:47 +10:00
Hugo Daniel
68ca352510
Use rspec expect syntax
2018-04-04 14:58:47 +10:00
Hugo Daniel
a71b650f89
Added tests
2018-04-04 14:58:47 +10:00
Hugo Daniel
f40bd9cfcb
Fixing wrong incrementation
2018-04-04 14:58:47 +10:00
Hugo Daniel
843bca9ea3
Updated calculation for flexible rate
2018-04-04 14:58:46 +10:00
Maikel Linke
80da0d5330
Set enterprise form dirty on any change
...
Commit 4953c69123 introduced a bug that
the save button is not activated when changing enterprise fields.
https://github.com/openfoodfoundation/openfoodnetwork/issues/2195
This is reverting the change and fixes #2195 .
Sadly, it re-opens
https://github.com/openfoodfoundation/openfoodnetwork/issues/1216 .
But that one is not as severe as the current bug.
2018-04-04 13:36:03 +10:00
Hugo Daniel
5ec89dde42
Update test sentences to fit new PriceSack behavior
2018-04-04 11:25:26 +10:00
Hugo Daniel
213456f4d9
Moved PriceSack tests from per item list to per order
2018-04-04 11:25:26 +10:00
Hugo Daniel
14ea591c7d
Removed redundant self
2018-04-04 11:25:25 +10:00
Hugo Daniel
28009afbea
Calculate price sack fees and tests
2018-04-04 11:25:25 +10:00
Matt-Yorkley
357ff5fb7d
Improve associating customer specs
2018-04-04 10:14:55 +10:00
Matt-Yorkley
5f2e72e3d4
Private shop spec
2018-04-04 10:14:55 +10:00
Em-AK
3b5c3f41a2
Ensure created users are associated with customers
...
When a user is created with the same email as existing customers
Then the user is associated with these customers
So that the user can access the private shops where he has been invited
to before signup
2018-04-04 10:14:55 +10:00
Rob Harrington
a83bdf16c9
Add error message for case when schedule cannot be deleted
2018-04-04 09:21:52 +10:00
Maikel
f9dbf61afc
Merge pull request #2176 from HugsDaniel/2002_calculator_options_not_translated
...
Overwrites spree_i18n translations for calculator's options
2018-04-04 08:17:18 +10:00
Pau Pérez Fabregat
15bd0de971
Merge pull request #2194 from wrycoder/spec-deprecation-fix
...
Replacing deprecated #ignore with #transient
2018-04-03 18:53:04 +02:00
Pau Pérez Fabregat
87329ad729
Merge pull request #2092 from ltrls/fix-tax-admin-order-show
...
Fix incorrect tax on Admin Order Show
2018-04-03 08:36:10 +02:00
Hugo Daniel
6731dd0b64
Overwrites spree_i18n translations for entreprise fees calculator's options
2018-04-03 08:38:00 +10:00
Michael Toulouse
0519269a53
Replacing deprecated #ignore with #transient
2018-04-02 06:40:12 -04:00
Pau Pérez Fabregat
1357c7c3b5
Merge pull request #2185 from coopdevs/remove-in-stock-dead-scope
...
Remove in_stock dead scope
2018-03-28 13:16:02 +02:00
Pau Perez
0cbd967007
Remove in_stock dead scope
...
This makes the upgrade to Spree 2.0 a bit easier.
`spree_variants.count_on_hand` is removed in that version and this
column was used in the `in_stock` scope that we no longer use.
2018-03-28 12:13:34 +02:00
Pau Pérez Fabregat
7fbaff71c7
Merge pull request #2179 from coopdevs/ignore-vendor-bundle
...
Ignore Bundler's vendor/bundle
2018-03-28 11:29:56 +02:00
Pau Pérez Fabregat
9f6b3498bd
Merge pull request #2177 from coopdevs/upgrade-delayed-job
...
Upgrade delayed_job_active_record from 4.0.2 to 4.1.2
2018-03-27 17:45:33 +02:00
Pau Pérez Fabregat
0b9881b9d3
Merge pull request #2168 from openfoodfoundation/transifex
...
Update translations with current Transifex version
2018-03-27 17:16:10 +02:00
Transifex-Openfoodnetwork
348364814d
Updating translations for config/locales/es.yml
2018-03-28 02:11:09 +11:00
Pau Perez
e8d8d5b0e6
Ignore Bundler's vendor/bundle
2018-03-27 16:56:58 +02:00
Pau Pérez Fabregat
dbf647f700
Merge pull request #1981 from Duende13/su_issue_1936
...
Added 'meta_keywords' to search of products
2018-03-27 14:27:40 +02:00
Hugo Daniel
ef2b0b8383
Added tooltips and locale
2018-03-27 15:21:12 +11:00
duende13
f75b865be8
Made changes requested by reviewer, in labels and tests.
2018-03-27 15:21:11 +11:00
duende13
7670d01c6d
Changing SEO tab to 'Search' tab
2018-03-27 15:21:11 +11:00
duende13
61300a62c2
Added 'meta_keywords' to search of products in shop page. Changed labels
...
on SEO tab and SEO form (edit product Screen) and added in en.yml file.
2018-03-27 15:21:11 +11:00
Transifex-Openfoodnetwork
a3fa6db5a9
Updating translations for config/locales/de_DE.yml
2018-03-26 21:38:21 +11:00
Pau Perez
dae883c68d
Upgrade dj_active_record from 4.0.2 to 4.1.2
...
This brings few styling improvements on dlayed_job_active_record but
also upgrades delayed_job from 4.0.4 to 4.1.4, which includes some fixes
and improved error messages.
2018-03-26 12:32:25 +02:00
Pau Pérez Fabregat
808f7b12c7
Merge pull request #2175 from coopdevs/upgrade-skylight
...
Upgrade Skylight from 1.5.1 to 1.6.0
2018-03-26 12:12:46 +02:00
Pau Perez
82c9cdd874
Upgrade Skylight from 1.5.1 to 1.6.0
2018-03-26 11:13:29 +02:00
Transifex-Openfoodnetwork
a257febc79
Updating translations for config/locales/fr.yml
2018-03-26 20:06:24 +11:00
Pau Pérez Fabregat
17b129ff4f
Merge pull request #2079 from mjal/424cart-page-shouldnt-show-admin-handling-if-it-is-zero
...
Cart page shouldnt show admin handling if it is zero
2018-03-23 18:01:09 +01:00
Pau Pérez Fabregat
6ce552727b
Merge pull request #2118 from oeoeaio/payment-summary-for-emails
...
Show payment summary in confirmation email regardless of payment method
2018-03-23 15:30:44 +01:00
Pau Pérez Fabregat
dadc02fb11
Merge pull request #2030 from lin-d-hop/uk/1663variant-order-emails
...
Uk/1663variant order emails
2018-03-23 15:29:05 +01:00
Pau Pérez Fabregat
bbd2427493
Merge pull request #2075 from mjal/2001translations-missing-in-order-management-pages
...
i18n for admin/orders
2018-03-23 15:27:55 +01:00
Pau Pérez Fabregat
82457d2b63
Merge pull request #2138 from Matt-Yorkley/email/manager_invite
...
Email/manager invite
2018-03-23 15:27:14 +01:00
Pau Pérez Fabregat
9e14186431
Merge pull request #2149 from oeoeaio/subs-remove-fields
...
Subs: Remove obsolete subscription fields from order cycles table
2018-03-23 15:12:32 +01:00
Pau Pérez Fabregat
d422283b76
Merge pull request #2128 from mkllnk/2113-i18n-config
...
2113 Display only selected languages in switcher
2018-03-23 15:06:47 +01:00
Pau Pérez Fabregat
13115d4a2d
Merge branch 'master' into email/manager_invite
2018-03-23 12:56:10 +01:00
Pau Pérez Fabregat
1005c299a2
Merge pull request #1464 from Matt-Yorkley/uk/bep_images
...
Uk/bep_images
2018-03-23 12:40:16 +01:00
Pau Pérez Fabregat
3788ec590f
Merge pull request #2166 from coopdevs/configure-mails-from
...
Configure mails_from
2018-03-23 12:19:31 +01:00
Pau Pérez Fabregat
7dd23d20c8
Merge pull request #2160 from coopdevs/fix-enterprise-filter-in-customers
...
Fix enterprise filter in customers
2018-03-23 08:25:21 +01:00
stveep
231dd7b6a2
Add some rubocop spaces
2018-03-23 17:37:50 +11:00
stveep
8a783bbb7d
PR changes: extract SQL in methods to scopes, add case insensitivity to test for sorting
2018-03-23 17:37:50 +11:00
stveep
9375318c4b
Codeclimate: remove empty line
2018-03-23 17:37:50 +11:00
stveep
dc76b3922b
Add sorting to query for producer mailer
2018-03-23 17:37:50 +11:00
stveep
40506685ef
Adding extra sort step for variant name; ignore case in sorting line items by name
2018-03-23 17:37:50 +11:00
Duende13
f5ad950bc3
Change Syntax from :variant => :product to variant: :product
2018-03-23 17:37:50 +11:00
Duende13
ba37db7ccc
Refactoring test to adopt most Rspec syntax (expect instead of should)
2018-03-23 17:37:50 +11:00
Duende13
401052be68
Fix Robcop issues (blank spaces and indentation)
2018-03-23 17:37:50 +11:00
Duende13
330e7d71af
Sort line items by name and unit_value for confirmation email and summary screen
2018-03-23 17:37:50 +11:00
Maikel Linke
94cc8bb980
Update translations with current Transifex version
...
Since our Transifex integration has a few flaws, there are many
translations that are not in the code yet. This imports everything, even
translation files that are not at 100%.
2018-03-23 12:55:29 +11:00
Pau Perez
2c588847df
Pick from_address from MailMethod as in Spree
...
Spree::Config[] picks it up from AppConfiguration rather than MailMethod
and so, gets a value different from the one configured.
2018-03-22 18:36:41 +01:00
Pau Perez
3c36d2d1a6
Remove failing mails_from default
...
As example.com is not a verified domain, Mandrill rejects the email
giving "reject_reason": "unsigned". Also, the mails_from setting is
already defined as a MailMethod preference.
2018-03-22 13:02:57 +01:00
Pau Pérez Fabregat
fa9d61c7fd
Merge pull request #2165 from coopdevs/upgrade-skylight
...
Upgrade Skylight from 1.5.0 to 1.5.1
2018-03-22 09:56:35 +01:00
Pau Pérez Fabregat
92b5f9a313
Merge pull request #2127 from mkllnk/fix-scss
...
Remove typo from SCSS
2018-03-22 09:41:11 +01:00
Maikel Linke
9588138eb0
Remove typo
...
Accidentally introduced in febe66b7b0 .
2018-03-22 14:18:55 +11:00
Pau Perez
d8dd84e64e
Fix enterprise filter in customers page
...
Angular's filter function uses a pattern object to filter specific
properties on objects contained by the array. We want an exact match
instead, which has to be done by means of a function.
2018-03-21 19:16:14 +01:00
Pau Perez
ae1831241b
Upgrade SKylight from 1.5.0 to 1.5.1
2018-03-21 18:41:21 +01:00
Pau Pérez Fabregat
91f30d5427
Merge pull request #2148 from coopdevs/sample-mail-method
...
Setup mail method automatically
2018-03-21 15:10:56 +01:00
Enrico Stano
3ce7bc54e3
Merge pull request #2143 from Matt-Yorkley/email/enterprise_user_ui
...
Fix enterprise user unsaved changes
2018-03-20 16:43:40 +01:00
Pierre de Lacroix
28bb15f4a9
Fix old rspec syntax
2018-03-20 12:21:27 +01:00
Pierre de Lacroix
e0b12b1332
Remove dependency on model method in feature test
2018-03-20 12:18:54 +01:00
Pierre de Lacroix
2ceecc3d6e
Test Order#tax_adjustment_totals with taxed adjustment on order
2018-03-20 12:18:51 +01:00
Pierre de Lacroix
03de6c690c
Fix incorrect tax amount on Admin Order #show
...
by calling Order#tax_adjustment_totals from
Order#price_adjustment_totals
2018-03-20 12:18:09 +01:00
Pau Perez
977c8f6203
Stick to setup+execution+assertion order in tests
2018-03-20 12:07:10 +01:00
Pau Pérez Fabregat
e23d714e83
Merge pull request #2154 from openfoodfoundation/transifex
...
Transifex
2018-03-19 10:29:48 +01:00
Transifex-Openfoodnetwork
ec01e55707
Updating translations for config/locales/es.yml
2018-03-19 19:56:02 +11:00
Pau Pérez Fabregat
c18b996a1b
Merge pull request #2098 from Matt-Yorkley/uk/font-caching
...
Fix browser caching of updated icon font
2018-03-17 11:10:04 +01:00
Matt-Yorkley
1600067383
Redirect to set password page after invite
2018-03-16 17:32:40 +00:00
Matt-Yorkley
3fad51d271
Clearer angular method naming
2018-03-16 17:32:40 +00:00
Matt-Yorkley
5f0075f8b7
Refactor to use new REST resource
2018-03-16 17:32:38 +00:00
Pau Perez
716e952117
Add mail setting's env vars for development
2018-03-16 13:33:55 +01:00
Pau Perez
092122969c
Make mail env vars mandatory
2018-03-16 13:33:21 +01:00
Pau Perez
f27a624687
Create the mail method from db:seed
...
As opposed the to sample users and enterprises that ease testing and
development, the mail method is needed for the app to function in any
environment.
2018-03-16 13:33:21 +01:00
Pau Perez
7afc999689
Differentiate MAIL_DOMAIN from plain DOMAIN
...
This way we can have katuma.org as the mail domain and
staging.katuma.org as web domain.
2018-03-16 13:33:20 +01:00
Pau Perez
4fc66356cb
Create always a mail method from sample_data
...
This sets the email config so that mails can be sent right away.
2018-03-16 13:33:20 +01:00
Pau Perez
a7f1ed660b
Add service to create a mail method
...
This will make loading sample data into staging environments easier.
2018-03-16 13:33:20 +01:00
Rob Harrington
9840467b8a
Remove obsolete subscription fields from order cycles table
2018-03-16 14:55:22 +11:00
Maxime Lalisse
fa68dd0bcc
refactor spec and check price
2018-03-16 01:18:21 +01:00
Rob Harrington
4d757dde78
Show payment summary in confirmation email regardless of payment method
2018-03-16 10:55:56 +11:00
Matt-Yorkley
f3f18d8338
Cleaner routes.rb entry
2018-03-15 18:48:47 +00:00
Matt-Yorkley
128ca3b1ef
Invite manager specs
2018-03-15 18:48:47 +00:00
Matt-Yorkley
b64327fbb3
Invite enterprise manager functionality
2018-03-15 18:48:47 +00:00
Matt-Yorkley
5c6624e1d1
Tidy up setDirty() calls in enterprise_controller.js
2018-03-15 12:58:05 +00:00
Enrico Stano
98ea82462d
Merge pull request #2136 from coopdevs/upgrade-test-dependencies
...
Upgrade test dependencies
2018-03-15 12:21:49 +01:00
Matt-Yorkley
4953c69123
Fix enterprise user unsaved changes
2018-03-14 23:04:54 +00:00
Pau Pérez Fabregat
586a9afaae
Merge pull request #2125 from KeirOsborn/order_order_cycle_list_#1884
...
Order order cycle list #1884
2018-03-14 19:08:28 +01:00
Pau Pérez Fabregat
f116ee156f
Merge pull request #1951 from JF-Lalonde/remove_duplicate_datepicker_1947
...
Remove duplicated directive datepicker from index_utils directory
2018-03-14 19:08:06 +01:00
JF-Lalonde
7a9f341363
Remove duplicated directive datepicker from index_utils directory
2018-03-14 17:01:54 +11:00
Maikel Linke
ada0fa50fc
Replace Rohan's email address by optional config
...
Rohan's email address is hard-coded, but he doesn't want to receive
these emails any more.
2018-03-14 15:30:53 +11:00
HugsDaniel
451c57da40
Changed i18n t() path to get content from locales
2018-03-14 15:01:01 +11:00
Hugo Daniel
82a752de46
Added margin bottom on table#listing_products to display a bit above the save bar
2018-03-14 13:16:31 +11:00
Matt-Yorkley
e2f3feccf0
Add comments to authentication_service.js
2018-03-14 12:13:45 +11:00
Matt-Yorkley
e6bdbccffa
Ensure email links return to proper path on private shops, refactor modal logic
2018-03-14 12:13:45 +11:00
Matt-Yorkley
ea9b0eca48
Adjust wording on validation modal message
2018-03-14 12:13:45 +11:00
Matt-Yorkley
e8bc87e62b
Ensure email validation link returns to /register paths properly
2018-03-14 12:13:45 +11:00
Matt-Yorkley
d7a3c50bd5
Remove underscore from resource
2018-03-14 12:13:45 +11:00
Matt-Yorkley
f5a0862655
Email confirmation modal specs
2018-03-14 12:13:45 +11:00
Matt-Yorkley
595bc5d1a5
Show confirmation message in modal
2018-03-14 12:13:45 +11:00
Matt-Yorkley
bc621a3c43
Return user to same URL from confirmation link
2018-03-14 12:13:45 +11:00
Hugs
7ebf5db1f2
Added img tag when producer.description.length==0 to display logo even when no About Us
2018-03-14 11:44:04 +11:00
Maxime Lalisse
e806f38142
Fix translation keys
2018-03-14 10:13:40 +11:00
Pau Perez
d980809a19
Upgrade shoulda-matchers from 1.1.0 to 2.8.0
2018-03-13 17:46:59 +01:00
Pau Perez
e6f6232607
Upgrade letter_opener from 1.4.1 to 1.6.0
2018-03-13 14:21:54 +01:00
Pau Perez
cce30d5762
Upgrade Knapsack from 1.5.1 to 1.16.0
2018-03-13 14:11:00 +01:00
Pau Perez
47a6ffbf66
Upgrade Capybara from 2.15.4 to 2.18.0
2018-03-13 13:58:06 +01:00
HugsDaniel
7e5eae1b8d
Added testing on statusMessage display for pending changes
2018-03-13 21:03:54 +11:00
HugsDaniel
8c4d0f11d7
Changed status message with i18n t() filter to displau unsaved changes status for customers edition in admin dashboard
2018-03-13 21:03:54 +11:00
Pau Perez
d96c1fc165
Upgrade factory_girl_rails from 3.3.0 to 4.9.0
...
This is the last version before moving to factory_bot_rails.
2018-03-13 10:01:14 +01:00
Pau Perez
6f879cd5d9
Remove unused gem Turn
...
It provides runners for MiniTest and we use RSpec.
2018-03-13 09:54:26 +01:00
Pau Perez
1d75e5a671
Upgrade rspec-retry from 0.4.2 to 0.5.6
2018-03-13 09:53:20 +01:00
Pau Perez
bdd58dccf0
Upgrade Timecop from 0.8.1 to 0.9.1
2018-03-13 09:34:09 +01:00
Pau Perez
aaf5bcbb12
Upgrade rspec-rails from 3.7.1 to 3.7.2
2018-03-13 09:32:12 +01:00
Pau Pérez Fabregat
976bbd8725
Merge pull request #2124 from coopdevs/replace-mail-method-in-base-mailer-decorator
...
Remove deprecated reference to Spree::MailMethod
2018-03-13 08:51:11 +01:00
Enrico Stano
341604be8a
Merge pull request #2094 from openfoodfoundation/transifex
...
Transifex
2018-03-13 08:39:11 +01:00
Maikel Linke
01dc51c84b
Consistent reference of the source locale
2018-03-13 10:25:31 +11:00
Maikel Linke
64063f305b
Describe methods of I18nConfig
2018-03-13 10:24:42 +11:00
Enrico Stano
5ce320f8a2
Merge pull request #2133 from coopdevs/fix-sample-data
...
Fix shipping method creation in sample data
2018-03-12 18:39:34 +01:00
Pau Perez
6598c80f6e
Fix shipping method creation in sample data
2018-03-12 16:52:56 +01:00
Keir Osborn
d4b84e55c2
order order cycle list from most lates close date to earliest on /orders page #1884
2018-03-12 11:04:50 +00:00
Pau Pérez Fabregat
6f5080923f
Merge pull request #2123 from coopdevs/bring-seeds-from-ofn-install
...
Bring seeds from ofn install
2018-03-12 11:43:14 +01:00
Pau Pérez Fabregat
afda5cc04e
Merge pull request #2115 from coopdevs/localize-sample-data
...
Localize sample data
2018-03-09 16:18:18 +01:00
Pau Perez
12e225e7c0
Add sample addresses in the instance's country
...
This ensures the address country and state are valid, meaning the state
belongs to the provided country. We use the instance's to do that.
2018-03-09 13:33:05 +01:00
Pau Perez
c19c22cb17
Apply couple simple tweaks to seeds.rb
2018-03-09 13:20:35 +01:00
Maikel Linke
db61a2bb17
Parse available language string more relaxed
...
Splitting the string with any whitespace makes it more likely the code
knows what the human meant. It also makes `strip` obsolete, since there
can't be any whitespace within the splitted strings.
2018-03-09 19:41:49 +11:00
Maikel Linke
8017921e89
Use I18nConfig in views
2018-03-09 17:45:04 +11:00
Maikel Linke
3743cf1bc3
Use I18nConfig for application defaults
2018-03-09 17:45:03 +11:00
Maikel Linke
7a34c6e3f0
Introduce I18nConfig as single point of truth
...
It will be used in application.rb and views.
See https://github.com/openfoodfoundation/openfoodnetwork/issues/2113
2018-03-09 17:45:03 +11:00
Pau Pérez Fabregat
b5a8df00dd
Merge pull request #2117 from coopdevs/confirm-example-user
...
Automatically confirm the spree@example.com user
2018-03-09 07:24:40 +01:00
Enrico Stano
0aacb91f50
Merge pull request #2116 from coopdevs/clean-sample-data
...
Clean sample data
2018-03-07 20:58:30 +01:00
Pau Perez
1b39d57800
Remove deprecated reference to Spree::MailMethod
...
Said class is removed in https://github.com/spree/spree/pull/2643 in
Spree.
2018-03-07 16:24:39 +01:00
Pau Perez
5eb3dc4beb
Bring states.yml from l10n_au
...
The states.yml present in this repo had a different format which doesn't
work with the current seeds.rb that we brought from ofn-install.
2018-03-07 10:30:12 +01:00
Pau Perez
9849f76c1c
Bring seeds.rb from ofn-install
2018-03-07 10:28:34 +01:00
Pau Perez
ae2eba89ca
Automatically confirm the spree@example.com user
...
This allows you to log in with it after you run `bundle exec
openfoodnetwork:dev:load_sample_data` rake task right away.
2018-03-07 10:10:38 +01:00
Rob H
dadbb7445b
Merge pull request #2110 from oeoeaio/subs-summary-hash
...
Subs: Fix summary emails for shop owners
2018-03-07 16:41:38 +11:00
Rob H
4fd307832e
Merge pull request #2120 from oeoeaio/subs-unpause-messaging
...
Subs: messaging around unpausing a subscription
2018-03-07 16:41:00 +11:00
Rob Harrington
09ca9ac2dd
Alter scope to return both completed and resumed orders
2018-03-07 14:24:59 +11:00
Rob Harrington
b98afc00ba
Show message about resumable orders when unpausing a subscription
2018-03-07 14:24:59 +11:00
Rob Harrington
7332e21013
Make InfoDialog more flexible (can show information as well as errors)
2018-03-07 14:24:58 +11:00
Rob Harrington
5cb0a1c371
Fix position of jQuery dialogs in admin section
2018-03-07 14:24:58 +11:00
Pau Perez
10d6a29503
Move service class to its own file
2018-03-06 15:30:25 +01:00
Pau Perez
e06af77420
Move from hash rocket to symbol syntax
2018-03-06 13:46:32 +01:00
Pau Pérez Fabregat
392d0de6c5
Merge pull request #2055 from HugsDaniel/1766_entreprise_registration_scroll_on_first_step
...
Changed bootstrap grid for medium size and above to have text and but…
2018-03-06 11:39:35 +01:00
Pau Pérez Fabregat
0fdd7dabd4
Merge pull request #2026 from Matt-Yorkley/uk/embedded_headers
...
Only include one host in embedded shopfront headers
2018-03-06 11:07:32 +01:00
Pau Pérez Fabregat
c999627d28
Merge pull request #2114 from ltrls/fix-old-rspec-syntax
...
Fix old rspec syntax
2018-03-06 11:04:21 +01:00
Hugo Daniel
f2eee77a15
fixed modal height and change grid to have button and text side by side
2018-03-06 16:21:35 +11:00
Pierre de Lacroix
040c292a76
Fix some more old rspec syntax
2018-03-06 01:29:54 +01:00
Pierre de Lacroix
12e3b88b71
Fix some old Rspec syntax
2018-03-06 01:24:54 +01:00
Rob Harrington
2bfa923fe1
Use a hash instead of an array :face_palm:
2018-03-02 15:50:10 +11:00
Rob H
d30362b78c
Merge pull request #2108 from oeoeaio/subs-neg-stock
...
Subs: handle negative stock for subscriptions
2018-03-02 15:47:12 +11:00
Rob Harrington
28491ee948
Skip stock check when requested quantity is zero
...
This prevents an error being raised when available stock is negative
2018-03-02 14:53:24 +11:00
Rob Harrington
fe4145d9d5
Use expect syntax
2018-03-02 14:53:24 +11:00
Rob H
3ef29fde2c
Merge pull request #2107 from oeoeaio/subs-missing-close
...
Subs: Add message to indicate OC has no close date
2018-03-02 14:52:54 +11:00
Rob Harrington
05e6c3daa6
Add message to indicate missing orders_close_at date
2018-03-02 13:28:34 +11:00
Rob H
9d8456cbf3
Merge pull request #2090 from oeoeaio/subs-styling
...
Subs: Make checklist more legible
2018-03-02 13:24:05 +11:00
Rob H
1d8f332cc6
Merge pull request #2096 from oeoeaio/subs-estimates
...
Subs: Improve estimates of item prices and fees
2018-03-02 13:22:27 +11:00
Rob Harrington
6f554814ce
Add class documentation for SubscriptionEstimator
2018-03-02 10:11:26 +11:00
Rob Harrington
f1545a4ab6
Show fee estimates in subscription totals in UI
2018-03-02 10:11:26 +11:00
Rob Harrington
31750a7bba
Add logic for calculator of fee estimates to SubscriptionEstimator
2018-03-02 10:11:26 +11:00
Rob Harrington
ad391c73ab
Add migration to add fee estimate fields to subscriptions table
2018-03-02 10:11:26 +11:00
Rob Harrington
014283447d
Use delegate to access subscription shop
2018-03-02 10:11:26 +11:00
Rob Harrington
3b2d4ae2d4
Estimator take variant overrides into account
2018-03-02 10:11:26 +11:00
Rob Harrington
14a03aab35
Fallback to previous saved estimate if calculator not available
2018-03-02 10:11:26 +11:00
Rob Harrington
904a364bf1
Stop unnecessarily passing fee_calculators around
2018-03-02 10:11:26 +11:00
Rob Harrington
30df1d4345
Refector controller to allow price_estimate calculation
2018-03-02 10:11:26 +11:00
Rob Harrington
b85e38010f
Delegate responsibility to estimating prices for subscriptions to dedicated service object
2018-03-02 10:11:26 +11:00
Transifex-Openfoodnetwork
7a411b0452
Updating translations for config/locales/de_DE.yml
2018-03-02 03:48:06 +11:00
Transifex-Openfoodnetwork
ecbd1fe93d
Updating translations for config/locales/pt.yml
2018-03-02 02:15:53 +11:00
Enrico Stano
14caac0212
Merge pull request #2074 from mjal/2057states-are-not-displayed-in-modify-address-pop-in-and-prevent-saving-2
...
Bug fix in customers edit address
2018-03-01 14:59:02 +01:00
Enrico Stano
6e9efe79b7
Merge pull request #2053 from Matt-Yorkley/uk/enterprise_limit
...
Increase default enterprise limit
2018-03-01 14:40:24 +01:00
Maxime Lalisse
cff1d7224d
Bug fix in customers edit address
2018-03-01 22:02:39 +11:00
Matt-Yorkley
86a500bcdf
Fix browser caching of updated icon font
2018-02-23 20:49:42 +00:00
Matt-Yorkley
7bd0de99ac
Adjust brittle referer header check
2018-02-23 16:35:46 +00:00
Matt-Yorkley
9506ea456e
Stub the request object instead of controller method
2018-02-23 15:57:28 +00:00
Matt-Yorkley
e173f823c8
Refactor embedded logic
2018-02-23 15:57:28 +00:00
Matt-Yorkley
4a818c07bb
Only include one host in embedded shopfornt headers
2018-02-23 15:57:28 +00:00
Rob Harrington
1ac9417a20
Add class description for ProxyOrder
2018-02-22 16:23:10 +11:00
Rob Harrington
ae1c8344d1
Ensure price estimates generated for subscriptions take overrides into account
2018-02-22 16:16:49 +11:00
Rob Harrington
add9c83812
Ensure correct price is used by OrderFactory when building line items
2018-02-22 16:16:49 +11:00
Rob Harrington
993f02a989
Add knowledge of variant overrides to OrderFactory
2018-02-22 16:16:49 +11:00
Rob Harrington
d7d40a4a0f
Create new OrderFactory service object for initializing order from attr hash
2018-02-22 16:16:49 +11:00
Rob Harrington
6bf4ed1ac5
Add new review view to subscription wizard
2018-02-22 16:13:29 +11:00
Rob Harrington
6bdbdc06e7
Use select2_search instead of targetted_select2_search
2018-02-22 16:13:29 +11:00
Rob Harrington
2e94654f91
Create factory to hold auxillary functions for subscriptions
...
NOTE: Moved estimatedSubtotal and estimatedTotal functions to the new factory from the subscription line items controller
2018-02-22 16:13:29 +11:00
Rob Harrington
2a731b2db5
Rename SubscriptionPrototype to SubscriptionActions
2018-02-22 16:13:29 +11:00
Rob Harrington
dcfa5fa42d
Use services to access injected data arrays
2018-02-22 16:13:29 +11:00
Rob Harrington
ad62b258ac
Populate 'all' array from Schedules#load
2018-02-22 16:13:29 +11:00
Rob Harrington
95f70409ee
Auto-load customers into service when present
2018-02-22 16:13:29 +11:00
Rob Harrington
3ac57269ed
Use .all convention for shipping and payment methods resource services
2018-02-22 16:13:29 +11:00
Rob Harrington
8951c79f71
Only count future orders in subs index order count
2018-02-22 15:09:33 +11:00
Rob Harrington
b3e7badd37
Fix incorrect translation key
2018-02-22 14:33:25 +11:00
Rob Harrington
cec5fddf6a
Add missing translation
2018-02-22 14:33:25 +11:00
Rob Harrington
c4a81bdc48
Translate subscriptions loading flash
2018-02-22 14:33:25 +11:00
Rob Harrington
9887819c16
Update ref for ofn-qz
2018-02-22 13:56:10 +11:00
Pau Pérez Fabregat
c1b7e9f79e
Merge pull request #2069 from HugsDaniel/1889_bug_in_order_cycles_filter_on_customer_admin_reports
...
Loads all order cycles for current user whether he is producer, distributor or coordinator
2018-02-21 17:11:52 +01:00
Hugo Daniel
3fa5ca7eae
Use accessible_by method instead of involving_managed_distributors method to fetch all order cycles
2018-02-21 17:33:28 +11:00
Hugo Daniel
65fea6291e
CodeClimate requested changes
2018-02-21 17:33:28 +11:00
Hugo Daniel
64c2bdda1c
Added loading of all active or complete order cycles concerned by the current user to the reports form collection
...
User will see all order cycles he is concerned by as producer, distributor or coordinator
2018-02-21 17:33:28 +11:00
Maikel Linke
de8df4b3e9
Manual update from transifex
2018-02-21 14:25:19 +11:00
Maikel Linke
70bb64d58d
Manual update from transifex
2018-02-21 14:24:45 +11:00
Maikel Linke
a529525a63
Manual update from transifex
2018-02-21 14:24:28 +11:00
Transifex-Openfoodnetwork
50c1224139
Updating translations for config/locales/de_DE.yml
2018-02-21 10:59:20 +11:00
Rob Harrington
927ab3a23a
Make subscriptions setup checklist more legible
2018-02-19 11:11:10 +11:00
Pau Pérez Fabregat
183621f90b
Merge pull request #2080 from coopdevs/add-skylight-staging
...
Enable Skylight in staging
2018-02-15 11:26:16 +01:00
Matt-Yorkley
fdc14ab44e
Add controller specs
2018-02-14 15:37:22 +00:00
Pau Perez
a7dcaf15fa
Enable Skylight in staging
...
This is a follow-up of
https://github.com/openfoodfoundation/openfoodnetwork/pull/2070 .
When running the production API key in staging, the `log/skylight.log`
showed:
```
[SKYLIGHT] [1.5.0] You are running in the staging environment but
haven't added it to config.skylight.environments, so no data will be
sent to skylight.io.
```
According to
https://www.skylight.io/support/advanced-setup#setting-up-multiple-environments
it turns out we need to create a new app for staging and use its API
key.
2018-02-14 14:46:10 +01:00
Matt-Yorkley
8a11dc3c33
Decouple image upload from Spree
2018-02-14 13:46:05 +00:00
Matt-Yorkley
23deb37876
Save/Update product image test
2018-02-14 13:46:05 +00:00
Matt-Yorkley
526317c373
BEP Image upload specs
2018-02-14 13:46:05 +00:00
Matt-Yorkley
7d27d1325e
Bulk Edit image upload
...
Image Upload Translations
Squashme
Squashme
Squashme
Code review tweaks
2018-02-14 13:46:05 +00:00
Matt-Yorkley
24dca5e51f
Add image column to product bulk edit
2018-02-14 13:46:05 +00:00
Matt-Yorkley
237854c781
Update enterprise limit error text and use expect sytnax
2018-02-13 14:05:18 +00:00
Matt-Yorkley
3c5b01ece0
Update enterprise limit spec
2018-02-13 14:05:18 +00:00
Matt-Yorkley
d52f9fd43f
Add enterprise limit modal
2018-02-13 14:05:18 +00:00
Pierre de Lacroix
5c046b76f0
Fix failing tests
2018-02-13 14:05:17 +00:00
Pierre de Lacroix
ab1ed16435
Add a migration to change Spree::Users enterprise_limit default value from 1 to 5
2018-02-13 14:05:17 +00:00
jtruong2
689aed7080
Add spec for admin & handling
2018-02-12 15:53:28 +01:00
jtruong2
6c92fdf167
fixes issue if admin and handling == 0 then do not render row
2018-02-12 15:53:19 +01:00
Maxime Lalisse
aef73aef38
Add translation keys
2018-02-09 22:15:02 +01:00
Maxime Lalisse
11eda94949
Add i18n for admin/orders
2018-02-09 17:40:31 +01:00
Pau Pérez Fabregat
23d36e3898
Merge pull request #2058 from coopdevs/improve-order-cycle-notification
...
Improve code style and docs of job
2018-02-09 13:19:32 +01:00
Pau Perez
c79641c77c
Fix typos in documentation
2018-02-09 09:53:40 +01:00
Pau Perez
aa4bd7f397
Improve code style and docs of job
2018-02-09 09:53:39 +01:00
Pau Pérez Fabregat
be07996656
Merge pull request #2070 from chancancode/skylight
...
Add Skylight instrumentation
2018-02-09 08:55:30 +01:00
Rob Harrington
e12207f3de
Use shop contact email and contact name for subscription emails
2018-02-09 14:44:15 +11:00
Rob Harrington
09b800672d
Fix specs to handle non-deterministic ordering
2018-02-09 14:44:15 +11:00
Rob Harrington
c59b172348
Fix typo
2018-02-09 14:44:15 +11:00
Rob Harrington
7017c8540c
Replace references to 'standing line item' with 'subscription line item'
2018-02-09 14:44:15 +11:00
Rob Harrington
ae4420d9ba
Rename standing line item files
2018-02-09 14:44:14 +11:00
Rob Harrington
eb53df8238
Rename 'standing_line_items' table to 'subscription_line_items'
2018-02-09 14:44:14 +11:00
Rob Harrington
71370e0bce
Replace references to 'standing order' with 'subscription' (cleanup)
2018-02-09 14:44:14 +11:00
Rob Harrington
ba66c0e862
Replace references to 'standing order' with 'subscription' (schedule)
2018-02-09 14:44:14 +11:00
Rob Harrington
c605742671
Replace references to 'standing order' with 'subscription' (routes)
2018-02-09 14:44:14 +11:00
Rob Harrington
720628e49e
Replace references to 'standing order' with 'subscription' (translations)
2018-02-09 14:44:14 +11:00
Rob Harrington
501fa4c901
Replace references to 'standing order' with 'subscription' (erb)
2018-02-09 14:44:14 +11:00
Rob Harrington
532f998b24
Replace references to 'standing order' with 'subscription' (js: spec)
2018-02-09 14:44:14 +11:00
Rob Harrington
b7876ebfbf
Replace references to 'standing order' with 'subscription' (spec)
2018-02-09 14:44:14 +11:00
Rob Harrington
04e48989c9
Replace references to 'standing order' with 'subscription' (lib)
2018-02-09 14:44:13 +11:00
Rob Harrington
094c3e70f7
Replace references to 'standing order' with 'subscription' (HAML)
2018-02-09 14:44:13 +11:00
Rob Harrington
b3eaa30f3d
Replace references to 'standing order' with 'subscription' (JS)
2018-02-09 14:44:13 +11:00
Rob Harrington
672f96b85b
Replace references to 'standing order' with 'subscription'
2018-02-09 14:44:13 +11:00
Rob Harrington
902802594f
Renaming standing order files (lib, spec)
2018-02-09 14:44:13 +11:00
Rob Harrington
a9b5fd69d8
Renaming standing order files
2018-02-09 14:44:13 +11:00
Rob Harrington
b258c032cc
Rename 'standing_orders' table to 'subscriptions'
2018-02-09 14:44:12 +11:00
Rob Harrington
fe7b86ff60
Fix broken call to log_order which should have been record_order
2018-02-09 14:44:12 +11:00
Rob Harrington
17950ba498
Lazy load summarizers for standing order jobs outside of initializer
...
The enqueue script seems to causes delayed job to skip initialization of the job class, meaning that the summarizers were missing
2018-02-09 14:44:12 +11:00
Rob Harrington
ccbe33001f
Add missing interpolation for shop name
2018-02-09 14:44:12 +11:00
Rob Harrington
c5f3249172
Fix rubocop issues
2018-02-09 14:44:12 +11:00
Rob Harrington
e7eb02dfe3
Reduce cognitive complexity of VariantsController#search
2018-02-09 14:44:12 +11:00
Rob Harrington
17a0b18e50
Reduce cognitive complexity of StandingLineItemsController#build
2018-02-09 14:44:12 +11:00
Rob Harrington
2012c23956
Reduce cognitive complexity of ProxyOrder#state
2018-02-09 14:44:12 +11:00
Rob Harrington
88a5d4be47
Reduce cognitive complexity of LineItemSyncer#update_item_quantities
2018-02-09 14:44:12 +11:00
Rob Harrington
224249d66b
Reduce cognitive complexity of OrderSyncer
2018-02-09 14:44:11 +11:00
Rob Harrington
ceab1fe16a
Reduce cognitive complexity of StandingOrderPaymentUpdater
2018-02-09 14:44:11 +11:00
Rob Harrington
c1f0a0b514
Reduce congnitive complexity of AddressFinder
2018-02-09 14:44:11 +11:00
Rob Harrington
ce09a8dad6
Reduce cognitive complexity of StandingOrder#state
2018-02-09 14:44:11 +11:00
Rob Harrington
99db6f8e14
Fix translation key for StandingOrderValidator errors
2018-02-09 14:44:11 +11:00
Rob Harrington
d6924d2866
Add comment to OrderUpdateIssues
2018-02-09 14:44:11 +11:00
Rob Harrington
3e68973812
Rename StandingOrderUpdater to OrderSyncer
2018-02-09 14:44:11 +11:00
Rob Harrington
bbc3cad67d
Refactor large StandingOrderUpdater#update! method
...
Note: extracted line items logic into separate class
2018-02-09 14:44:11 +11:00
Rob Harrington
50d3522b2c
Extract logic for recording issues with updating orders to separate class
2018-02-09 14:44:11 +11:00
Rob Harrington
2c5bfab29f
Refactoring price estimation logic for StandingOrderForm
2018-02-09 14:44:11 +11:00
Rob Harrington
844cd79270
Clean-up of standing order form and spec
2018-02-09 14:44:10 +11:00
Rob Harrington
8ae4307a69
Move logic for updating orders to dedicated class
2018-02-09 14:44:09 +11:00
Rob Harrington
2c40252edb
Extract validation logic for standing orders into service object
2018-02-09 14:44:09 +11:00
Rob Harrington
0c302b022a
Move StandingOrderForm to app/services folder
2018-02-09 14:44:09 +11:00
Rob Harrington
7581779a0d
Remove weird escape characters
2018-02-09 14:44:09 +11:00
Rob Harrington
f9727de206
Comment out interface for turning standing orders ON for an enterprise
2018-02-09 14:44:09 +11:00
Rob Harrington
76daa183d5
Add orders sub-menu to standing-order index page
2018-02-09 14:44:09 +11:00
Rob Harrington
981b874263
Remove unused method active? for order cycles
2018-02-09 14:44:09 +11:00
Rob Harrington
4362ef2cea
Properly translate all error messages for StandingOrderForm
2018-02-09 14:44:09 +11:00
Rob Harrington
7ca60e1990
Use activerecord error translations properly
2018-02-09 14:44:09 +11:00
Rob Harrington
1bf2f7ad03
Fix a couple of offences pickup up by rubocop
2018-02-09 14:44:09 +11:00
Rob Harrington
8ba1a909ca
Use summarizer for standing order confirm job
2018-02-09 14:44:08 +11:00
Rob Harrington
c86207212f
Add confirmation summary email
2018-02-09 14:44:08 +11:00
Rob Harrington
86cddb1cc4
Capitalise translated strings
2018-02-09 14:44:08 +11:00
Rob Harrington
b49c44f7ce
Generalise record_failure method to record_and_log_error
2018-02-09 14:44:08 +11:00
Rob Harrington
818af47613
Move rescue clause to process method
...
This prevents a placement email from being sent unless the order is processed successfully
2018-02-09 14:44:08 +11:00
Rob Harrington
ef6c9ec0f0
Integrate standing order summarizer into placement job
2018-02-09 14:44:08 +11:00
Rob Harrington
13d01df4d8
Add mail method and template for sending placement summary emails to shop owners
2018-02-09 14:44:08 +11:00
Rob Harrington
cf30b7c883
Add service objects for summarizing outcomes of standing order processing jobs
2018-02-09 14:44:08 +11:00
Rob Harrington
0c0e12e165
Show edit link in placement email if changes are allowed by shop
2018-02-09 14:44:08 +11:00
Rob Harrington
f9af8edf27
Ignore Metrics/BlockLength for specs and Rails/HasAndBelongsToMany
2018-02-09 14:44:08 +11:00
Rob Harrington
8bf460c93a
Manually fix remaining rubocop offences
2018-02-09 14:44:08 +11:00
Rob Harrington
f902b8cef0
Fix rubocop Style/ClassAndModuleChildren offences
2018-02-09 14:44:07 +11:00
Rob Harrington
84ad996ef8
Use guard clauses
2018-02-09 14:44:07 +11:00
Rob Harrington
fb28940952
Use Time.zone.now instead of Time.now
2018-02-09 14:44:07 +11:00
Rob Harrington
03f1980b1b
Auto-correct rubocop offences for standing-orders
2018-02-09 14:44:07 +11:00
Rob Harrington
26a325e6e0
Handle payment processing errors for standing orders
2018-02-09 14:44:07 +11:00
Rob Harrington
2576d10e49
Create a new payment when none is present
2018-02-09 14:44:07 +11:00
Rob Harrington
67e05cea9c
Add failed payment email to StandingOrderMailer
2018-02-09 14:44:07 +11:00
Rob Harrington
0ccb0ce0e4
Make standing order header partial more generic
2018-02-09 14:44:07 +11:00
Rob Harrington
8c96a19e3e
Specify minimum postgresql version for travis
2018-02-09 14:44:07 +11:00
Rob Harrington
6e83c6dc86
Move standing order emails to a dedicated StandingOrderMailer
2018-02-09 14:44:07 +11:00
Rob Harrington
d6a9d63de5
Replace StandingOrderSyncJob with ProxyOrderSyncer service object
2018-02-09 14:44:06 +11:00
Rob Harrington
6ea343f26e
Clean up proxy order performance specs
2018-02-09 14:44:06 +11:00
Rob Harrington
43c2aca208
Use delete_all instead of destroy_all for increased speed
2018-02-09 14:44:06 +11:00
Rob Harrington
8a498391ca
Add performance spec for removal of proxy orders
2018-02-09 14:44:06 +11:00
Rob Harrington
146348a4fe
Refactor proxy order syncer using direct sql query for increased speed
2018-02-09 14:44:06 +11:00
Rob Harrington
48b39f4712
Add performance spec for proxy order syncer
2018-02-09 14:44:06 +11:00
Rob Harrington
3aee0b5e70
Allow proxy order syncer to accept both ActiveRecord::Relation or StandingOrder
2018-02-09 14:44:06 +11:00
Rob Harrington
6d5c920a95
Split proxy order sync logic out into dedicated service object
2018-02-09 14:44:06 +11:00
Rob Harrington
cdf04323a9
Serialize standing order credit_card_id to enable selection in edit form
2018-02-09 14:44:06 +11:00
Rob Harrington
bdac68900f
Move address and card loading logic down into DetailsController
...
Also switch to using CreditCardResource to load the card
2018-02-09 14:44:05 +11:00
Rob Harrington
a5ae4c801c
Initialize ofn-select2 with empty array when data is a promise
2018-02-09 14:44:05 +11:00
Rob Harrington
404913dcfa
Move form-saving logic into dedicated StandingOrderForm service
2018-02-09 14:44:05 +11:00
Rob Harrington
c94badbf36
Stub or provide mailer as appropriate
2018-02-09 14:44:04 +11:00
Rob Harrington
ca1485f121
Add missing translations for proxy order controller error messages
2018-02-09 14:44:04 +11:00
Rob Harrington
dfe874cf3f
Attempt to add a credit card before processing payment
2018-02-09 14:44:04 +11:00
Rob Harrington
c20c9e2e78
Use the rails logger instead of Bugsnag
2018-02-09 14:44:04 +11:00
Rob Harrington
f4f6fb6a7a
Update and process standing order payments prior to confirmation
2018-02-09 14:44:04 +11:00
Rob Harrington
ac8e09bc11
Add credit card validation to StandingOrderForm
2018-02-09 14:44:04 +11:00
Rob Harrington
183ad87d07
Fix mislabeled StandingOrderForm specs
2018-02-09 14:44:04 +11:00
Rob Harrington
f95d1ef058
Show message when no credit cards available for a customer
2018-02-09 14:44:04 +11:00
Rob Harrington
61b64a7516
Add credit card selection element to standing orders form
2018-02-09 14:44:04 +11:00
Rob Harrington
494f2f4821
Add cards lookup action to CustomersController
2018-02-09 14:44:04 +11:00
Rob Harrington
d3937e5c80
Move customer address lookup action to CustomersController
2018-02-09 14:44:03 +11:00
Rob Harrington
3ac2ac34ed
Add credit_card_id to StandingOrder model
2018-02-09 14:44:03 +11:00
Rob Harrington
25907d8969
Prevent standing order form from accepting non cash/stripe payment methods
2018-02-09 14:44:03 +11:00
Rob Harrington
26b85052e1
Load only Cash and Stripe payment methods into standing order form actions
2018-02-09 14:44:03 +11:00
Rob Harrington
07a7993109
Require a Cash or Stripe payment method in standing order setup process
2018-02-09 14:44:03 +11:00
Rob Harrington
7798b12086
Replace translation key for yes_i_am_sure
2018-02-09 14:44:03 +11:00
Rob Harrington
be11a1a2f9
Fix memoization issue with line item unit specs
2018-02-09 14:44:03 +11:00
Rob Harrington
86d8133f82
Stop setting host for url helpers in specs
...
All configuration is now happening in test.rb or spec_helper.rb
2018-02-09 14:44:03 +11:00
Rob Harrington
6081db382c
Updating addresses on standing order updates addresses on any initialised orders
2018-02-09 14:44:03 +11:00
Rob Harrington
b89ab2c407
Adding link to view/edit the order from Standing Order placement and confirmation emails
2018-02-09 14:44:02 +11:00
Rob Harrington
fce2d743e5
Adding proxy-order state to specs
2018-02-09 14:44:02 +11:00
Rob Harrington
2a3fc8cfec
Automatically copy shipping address from billing if none present
2018-02-09 14:44:02 +11:00
Rob Harrington
7d1fc8cbe1
Make sure correct intro message is used for empty standing order notification
2018-02-09 14:44:02 +11:00
Rob Harrington
f969caa2d1
Do not place standing order when no items are available
...
Send notification to customer informing them that an order was not placed...
2018-02-09 14:44:02 +11:00
Rob Harrington
0fd86a6cc7
Adding UI to require action from user when pausing/cancelling standing order with open orders
2018-02-09 14:44:02 +11:00
Rob Harrington
ab5dc7ddd5
Require action from user when pausing/cancelling standing order with open orders
2018-02-09 14:44:02 +11:00
Rob Harrington
3ce8a1abba
Tweaking proxy order state logic
...
Inherits 'paused' state from standing order if present
2018-02-09 14:44:02 +11:00
Rob Harrington
834e5b702e
Using standing_order_form.$submitted for show/hide logic for angularjs form errors
2018-02-09 14:44:02 +11:00
Rob Harrington
001f329393
Refactoring StandingOrderPrototype
...
Allow handling of create/update responses from downstream controllers using promise chaining
2018-02-09 14:44:01 +11:00
Rob Harrington
72549697a3
Redirecting to standing orders index on successful standing order save
2018-02-09 14:44:01 +11:00
Rob Harrington
1e0356a74b
StatusMessages can be shown on StandingOrder index
2018-02-09 14:44:01 +11:00
Rob Harrington
42266397aa
Improving performance of available variant lookup for standing orders
...
Only search the DB for available variants once
2018-02-09 14:44:01 +11:00
Rob Harrington
846cccf373
Showing StandingOrder error messages in status bar when save fails
2018-02-09 14:44:01 +11:00
Rob Harrington
ad2506fe75
Require StandingOrders to have at least one product (StandingLineItem)
2018-02-09 14:44:01 +11:00
Rob Harrington
7dcd39986f
Refactoring StandingOrder validations and errors
...
Moving validations to StandingOrderForm
2018-02-09 14:44:01 +11:00
Rob Harrington
b28f2908a6
Fix 'postcode' typo in standing order form
2018-02-09 14:44:01 +11:00
Rob Harrington
7d9d510c0f
Adding a comma after each schedule listed on OC index
2018-02-09 14:44:01 +11:00
Rob Harrington
c64f3590ad
Using placeholder attribute to show prompt text for schedule dropdown
2018-02-09 14:44:01 +11:00
Rob Harrington
f0f478dfa0
Adding placeholder field with default to ofn-select2 component
2018-02-09 14:44:00 +11:00
Rob Harrington
ceaae89dee
Prevent order cycles that are linked to schedules from being destroyed
2018-02-09 14:44:00 +11:00
Rob Harrington
77a50eac42
Show confirmation message when creating/updating/deleting Schedules
2018-02-09 14:44:00 +11:00
Rob Harrington
877a5f27d1
ProxyOrder state is 'pending' until OC opens, then 'cart' until OC closes
2018-02-09 14:44:00 +11:00
Rob Harrington
2c0928ca20
Automatically show 'Schedules' column on OC index when Standing Orders are enabled
2018-02-09 14:44:00 +11:00
Rob Harrington
4e686ecfcc
Debouncing admin variant search requests by 300ms
2018-02-09 14:44:00 +11:00
Rob Harrington
35e42b28fe
Using customer selection to search for addresses on standing order creation
...
Can also copy copy address from billing to shipping
2018-02-09 14:44:00 +11:00
Rob Harrington
9137f68a57
Adding logic to SearchController#customer_addresses for case when customer is not found
2018-02-09 14:44:00 +11:00
Rob Harrington
6ac49a7694
Adding route and controller action for searching for customer addresses using AddressFinder
2018-02-09 14:44:00 +11:00
Rob Harrington
c5066bb613
Making AddressFinder a little more secure
...
Only allow search by email when a customer or user with matching email is also provided
2018-02-09 14:43:59 +11:00
Rob Harrington
4a0dab3608
Renaming LastUsedAddress as AddressFinder
2018-02-09 14:43:59 +11:00
Rob Harrington
1b72b7258d
Refactoring LastUsedAddress to take customers or users
2018-02-09 14:43:58 +11:00
Rob Harrington
58070a8b3e
Adding loading flash and no-results messaging to standing orders index
2018-02-09 14:43:58 +11:00
Rob Harrington
57653cb911
Displaying setup instructions on Standing Orders index
2018-02-09 14:43:58 +11:00
Rob Harrington
ae209f72b9
Removing unrequired OrderCycleOpenCloseJob
2018-02-09 14:43:58 +11:00
Rob Harrington
2859075e43
WIP: StandingOrderConfirmJob no longer scoped to an order cycle
2018-02-09 14:43:58 +11:00
Rob Harrington
0e50009875
WIP: StandingOrderPlacementJob no longer scoped to an order cycle
2018-02-09 14:43:58 +11:00
Rob Harrington
514a462f7b
WIP: Refactor, of standing order placement and confirmation jobs
...
ie. Transfering responsibility for tracking standing order placement and confirmation to proxy orders
2018-02-09 14:43:58 +11:00
Rob Harrington
01cbd7ae9d
WIP: Adding flags for standing order placement and confirmation to proxy_orders table
2018-02-09 14:43:58 +11:00
Rob Harrington
f92b824f52
User is warned about initialising standing order orders
2018-02-09 14:43:58 +11:00
Rob Harrington
3adfb0db3f
Issues with updating orders are reported when saving standing orders
2018-02-09 14:43:58 +11:00
Rob Harrington
fd07830c02
Adding order_update_issues to serialized proxy orders
2018-02-09 14:43:57 +11:00
Rob Harrington
9e986f25f1
Orders are not marked as problematic if the changed value matches the new value
2018-02-09 14:43:57 +11:00
Rob Harrington
e357a7b401
StandingOrderForm: Storing problematic orders for reporting to user
2018-02-09 14:43:57 +11:00
Rob Harrington
9f50253537
StandingOrderForm: Rescuing from RecordInvalid when saving
2018-02-09 14:43:57 +11:00
Rob Harrington
1e8767e8b5
StandingOrderForm: Small refactor, update initialised orders one-by-one
2018-02-09 14:43:57 +11:00
Rob Harrington
a6add2eff6
Limiting shops loaded onto standing orders index to those with standing orders enabled
2018-02-09 14:43:57 +11:00
Rob Harrington
25639a822a
Implementing standing order feature toggle on back-end interface
2018-02-09 14:43:57 +11:00
Rob Harrington
e1f8af6d5b
Adding standing orders feature toggle to enterprise form
2018-02-09 14:43:57 +11:00
Rob Harrington
e7b8648792
Adding standing orders feature toggle column to enterprises table
2018-02-09 14:43:57 +11:00
Rob Harrington
c819197d07
BasicOrderCycleSerializer serialises open and closes dates with time and zone
2018-02-09 14:43:57 +11:00
Rob Harrington
15fb493d9a
StandingOrderPlacementJob: cap quantity at 0 for items not available through OC
2018-02-09 14:43:56 +11:00
Rob Harrington
cd6394987d
StandingOrderPlacementJob: Moving logic for processing an order to completion to separate method
2018-02-09 14:43:56 +11:00
Rob Harrington
0cf7d1a63d
Link standing order orders to user on initialisation if customer user exists
2018-02-09 14:43:56 +11:00
Rob Harrington
439c81d836
Format of hours in standing order placement email without leading zero
2018-02-09 14:43:56 +11:00
Rob Harrington
1e0d43e975
Changing explain text on confirm email
...
Removing mention of making changes
2018-02-09 14:43:56 +11:00
Rob Harrington
994baf12c4
Adding specs to ensure placement emails are sent
2018-02-09 14:43:56 +11:00
Rob Harrington
d12a1371c2
Assigning a priority to OrderCycleOpenCloseJob
2018-02-09 14:43:56 +11:00
Rob Harrington
f9e40ba586
Fixing typos in standing order placement job
2018-02-09 14:43:56 +11:00
Rob Harrington
a32fb752dd
Removing number column from orders panel, adding edit action
2018-02-09 14:43:56 +11:00
Rob Harrington
e4f30cea57
Fixing styling for table rows within index panels
2018-02-09 14:43:56 +11:00
Rob Harrington
d0f4cc2ee2
PlacementJob loads ProxyOrders based on order cycle close date
2018-02-09 14:43:55 +11:00
Rob Harrington
c4c9c92d7e
Refactoring StandingOrderPlacementJob, loading ProxyOrders and initialsing where necessary
2018-02-09 14:43:55 +11:00
Rob Harrington
e6fbdb17e8
Only initialise a proxy order once
2018-02-09 14:43:55 +11:00
Rob Harrington
02f474e16a
Fixing up spec data for orders spec
2018-02-09 14:43:55 +11:00
Rob Harrington
0861a4391e
Removing ui-sortable library (no longer required)
2018-02-09 14:43:55 +11:00
Rob Harrington
1731d4daa7
Rejigging schedule dialog, limit options to coordinated order cycles, with same coordinator as selected OCs
2018-02-09 14:43:55 +11:00
Rob Harrington
875557dc9d
WIP: ProxyOrders don't require an order, fixing remainder of specs
2018-02-09 14:43:55 +11:00
Rob Harrington
be8fa1f4e4
WIP: ProxyOrders don't require an order, calculating total for serialized proxy orders from standing order where order does not exist
2018-02-09 14:43:55 +11:00
Rob Harrington
3d3013a592
WIP: ProxyOrders don't require an order, adding an edit path for proxy orders
...
initialises an order if one does not exist and redirects to its edit path
2018-02-09 14:43:55 +11:00
Rob Harrington
4b440c83a4
WIP: ProxyOrders don't require an order, StandingOrderForm changes
2018-02-09 14:43:55 +11:00
Rob Harrington
f57cae9124
Removing null: false contraint on order_id for ProxyOrder
2018-02-09 14:43:55 +11:00
Rob Harrington
2231d4c6cf
Using factories to build spec data rather than StandingOrderForm
2018-02-09 14:43:54 +11:00
Rob Harrington
e29a4f9a8a
Moving order initialisation logic from StandingOrderForm to ProxyOrder model
2018-02-09 14:43:54 +11:00
Rob Harrington
64206bc35b
ProxyOrders belong to order cycles
2018-02-09 14:43:54 +11:00
Rob Harrington
e351c3e355
Renaming StandingOrderOrder to ProxyOrder
2018-02-09 14:43:54 +11:00
Rob Harrington
fc845a36f1
Fix weird spec failure cause by a Rails.cache.clear call resetting the currency to USD on CI only
2018-02-09 14:43:54 +11:00
Rob Harrington
9bf3767093
Preventing line item stock level checks when updating standing orders
2018-02-09 14:43:54 +11:00
Rob Harrington
8e0f2fcb35
Adding optional manual override of line item stock level check
2018-02-09 14:43:54 +11:00
Rob Harrington
00ee5a63df
Removing incorrect namespacing from StandingOrderForm spec
2018-02-09 14:43:54 +11:00
Rob Harrington
e068c4831b
Adding job to send confirm emails for standing orders on order cycle close
2018-02-09 14:43:54 +11:00
Rob Harrington
2a03477597
Adding standing_orders_confirmed_at flag to order_cycles
2018-02-09 14:43:54 +11:00
Rob Harrington
deebc31c34
DRYing out standing order email template
2018-02-09 14:43:53 +11:00
Rob Harrington
9f1ff1fd01
Adding OrderCycleOpenCloseJob to the whenever schedule
2018-02-09 14:43:53 +11:00
Rob Harrington
f7229ab229
Uninitialised but recently updated order_cycles also trigger StandingOrderPlacementJob
2018-02-09 14:43:53 +11:00
Rob Harrington
c2b68ed6b5
Running StandingOrderSyncJob when order cycles added to a schedule via OrderCyclesController
2018-02-09 14:43:53 +11:00
Rob Harrington
0a74bb8373
Running StandingOrderSyncJob when order cycles added to a schedule via SchedulesController
2018-02-09 14:43:53 +11:00
Rob Harrington
ef5ff3a663
Adding job to re-sync standing orders when order cycles are added to or removed from schedules
2018-02-09 14:43:53 +11:00
Rob Harrington
d6e5c0b346
Adding extra scopes to StandingOrder model
2018-02-09 14:43:53 +11:00
Rob Harrington
107474fc74
Fixing standing_order_with_items factory
2018-02-09 14:43:53 +11:00
Rob Harrington
9a984963a7
Ensuring that only active standing orders are processed when order cycle opens
2018-02-09 14:43:53 +11:00
Rob Harrington
805baa18a9
Adding cancel/close button to standing order form
2018-02-09 14:43:53 +11:00
Rob Harrington
533b05384c
Refactoring save bar on standing order create/edit form
2018-02-09 14:43:52 +11:00
Rob Harrington
9c2e67e953
Cancelling a standing order just changes the state, does not remove it from the page
2018-02-09 14:43:52 +11:00
Rob Harrington
522e646b36
Adding tooltips to standing order index actions
2018-02-09 14:43:52 +11:00
Rob Harrington
3d8dceb76a
Displaying state of standing orders on index
2018-02-09 14:43:52 +11:00
Rob Harrington
b9316422d2
Adding method to determine state of standing orders
2018-02-09 14:43:52 +11:00
Rob Harrington
8d1899b13d
Adding pause and unpause actions to standing orders
2018-02-09 14:43:52 +11:00
Rob Harrington
8ff9ffbc38
Adding controller actions and routes for pausing and unpausing a standing order
2018-02-09 14:43:52 +11:00
Rob Harrington
961df756c5
Adding paused_at column to standing orders
2018-02-09 14:43:52 +11:00
Rob Harrington
736de4826f
Renaming cancelled_at column to canceled_at, for consistency
2018-02-09 14:43:52 +11:00
Rob Harrington
774245f540
Adding cancel button to standing orders index
2018-02-09 14:43:51 +11:00
Rob Harrington
a2ddf78842
Ensure red buttons have white text
2018-02-09 14:43:51 +11:00
Rob Harrington
f4ce0a4b81
Adding ConfirmDialog service
2018-02-09 14:43:51 +11:00
Rob Harrington
a23a0a233e
Renaming info dialog stylesheet to more general dialogs.css
2018-02-09 14:43:51 +11:00
Rob Harrington
7dcf7ec5b0
Adding controller action and route for cancelling a standing order
2018-02-09 14:43:51 +11:00
Rob Harrington
b643829fe2
Standing Orders can be marked as cancelled
2018-02-09 14:43:51 +11:00
Rob Harrington
076a05f8a9
Adding spec for case when standing_order_orders aren't linked to an order cycle
...
This should never happen, but came up in specs
2018-02-09 14:43:50 +11:00
Rob Harrington
284103b6b6
Adding canceled_at column to standing_orders table
2018-02-09 14:43:50 +11:00
Rob Harrington
dd099eae54
Visualising standing order order state, still some spec failures
2018-02-09 14:43:50 +11:00
Rob Harrington
309781d5b1
Individual StandingOrder orders can be resumed from Standing Order index
2018-02-09 14:43:50 +11:00
Rob Harrington
2023a1a2fc
Adding translations for StandingOrderOrder resume/cancel errors
2018-02-09 14:43:50 +11:00
Rob Harrington
d1ca9a6e14
Adding a #resume action to StandingOrderOrdersController
2018-02-09 14:43:49 +11:00
Rob Harrington
fc463fd608
Adding resume logic to StandingOrderOrder model
2018-02-09 14:43:49 +11:00
Rob Harrington
d89a05aec8
Adding an error message when cancellation of standing order order fails
2018-02-09 14:43:49 +11:00
Rob Harrington
6dd31a947e
Show closing times for orders in standing order orders panel
2018-02-09 14:43:49 +11:00
Rob Harrington
5191877fbe
BasicOrderCycleSerializer renders order open and close times
2018-02-09 14:43:49 +11:00
Rob Harrington
f6af5098b0
Using MomentJS to handle dates on bulk order management
2018-02-09 14:43:48 +11:00
Rob Harrington
7644f08d5c
Individual StandingOrder orders can be cancelled from Standing Order index
2018-02-09 14:43:48 +11:00
Rob Harrington
27b22acd37
Fixing bug that caused references to stale DOM objects to be kept and used by Panels service
...
Was causing panels to break when used in conjuction with ng-repeat + filters
2018-02-09 14:43:48 +11:00
Rob Harrington
50b84c4ced
Fixing typo in SO spec description
2018-02-09 14:43:48 +11:00
Rob Harrington
9160a3ff6b
Displaying Order Cycle names in orders panel on standing orders index
2018-02-09 14:43:48 +11:00
Rob Harrington
a57815edbb
Refactoring standing line item delete logic
...
Using StandingOrderForm rather than separate endpoint
2018-02-09 14:43:47 +11:00
Rob Harrington
4c754e2cdb
Ensuring that new standing_line_items are added to orders and totals are updated
2018-02-09 14:43:47 +11:00
Rob Harrington
fcf2681abc
WIP: Adding basic order panel to standing order index
2018-02-09 14:43:47 +11:00
Rob Harrington
ffcffb30ca
Moving standing orders products panel template into separate partial
2018-02-09 14:43:47 +11:00
Rob Harrington
cdff1ef7b6
TEMP: Adding scopes for standing_order_orders
2018-02-09 14:43:47 +11:00
Rob Harrington
d95d9df0f1
Standing Order Orders can be cancelled
2018-02-09 14:43:47 +11:00
Rob Harrington
56fb50f644
Refactoring customer_search_override directive
...
Passing distributor_id into isolate scope, rather than pulling from separate element
2018-02-09 14:43:47 +11:00
Rob Harrington
f4cbd90400
Storing estimated prices for standing line items in the database
2018-02-09 14:43:46 +11:00
Rob Harrington
9baaf1efc9
Only running StandingOrder service 'after' callbacks for known standing orders
...
ie. those in byID or pristineByID
2018-02-09 14:43:46 +11:00
Rob Harrington
0196218d06
Conditionally loading an edit path for standing orders
...
ie. only if they have an id
2018-02-09 14:43:46 +11:00
Rob Harrington
b253373d4d
Styling save button for standing order panels, and updating pristineByID array on update/save
2018-02-09 14:43:46 +11:00
Rob Harrington
8f71b56c26
Using same serializer for standing order index and edit pages
2018-02-09 14:43:46 +11:00
Rob Harrington
e8ee1dad04
Building params for adding new customer in the dialog directive, rather than generic Customers service
2018-02-09 14:43:45 +11:00
Rob Harrington
dc2551d881
Moving Schedules and ScheduleResource services to admin.resources module
2018-02-09 14:43:45 +11:00
Rob Harrington
c167780cad
Adding auto-loading of schedules to Schedules service via constructor
2018-02-09 14:43:45 +11:00
Rob Harrington
534e69fde5
Including errors attribute from StandingOrderPrototype in spec
2018-02-09 14:43:45 +11:00
Rob Harrington
e92b17a341
Adding an error message when attempting to add duplicate variant to a standing order
2018-02-09 14:43:45 +11:00
Rob Harrington
1bd01c83a7
WIP: Adding panel for editing items to standing order index
2018-02-09 14:43:44 +11:00
Rob Harrington
05bc2bd293
All methods on StandingOrder service are instance methods, StandingOrders service loads instances of StandingOrder
2018-02-09 14:43:44 +11:00
Rob Harrington
6f4c9070f6
Adding StandingLineItemsController to handle addition and removal of SLIs from standing orders
2018-02-09 14:43:44 +11:00
Rob Harrington
198f63d0b3
Removing unrequired StatusMessage injection
2018-02-09 14:43:44 +11:00
Rob Harrington
a72da7036b
buildItem and removeItem are instanceMethods standingOrder objects
2018-02-09 14:43:44 +11:00
Rob Harrington
3571b8c5fa
Fixing date specification for order cycle spec
2018-02-09 14:43:43 +11:00
Rob Harrington
91a2274fe5
Adding link and dialog for creating a new standing order
2018-02-09 14:43:43 +11:00
Rob Harrington
0f2adaa8d2
Adding link to standing orders index to orders sub-menu
2018-02-09 14:43:43 +11:00
Rob Harrington
c3e071b0d1
Removing retry from stabilised customers codes feature spec
2018-02-09 14:43:43 +11:00
Rob Harrington
8c9765749e
Ensuring that backorders are disabled when testing quantity capping for standing orders
2018-02-09 14:43:43 +11:00
Rob Harrington
6cf23b46c5
Fixing broken country and state selection for customer addresses
2018-02-09 14:43:42 +11:00
Rob Harrington
7fa55fe5c6
Adding spec to ensure that invalid changes to standing orders are not propagated to associated orders
2018-02-09 14:43:42 +11:00
Rob Harrington
21d8aafd97
Using numbers for state and countries ids in AddressSerializer
2018-02-09 14:43:42 +11:00
Rob Harrington
fbd3d99b1b
OC feature spec: Using find for columns dropdown instead of first
2018-02-09 14:43:42 +11:00
Rob Harrington
f14c36ed6b
Sending placement email when standing order order in placed on OC open
2018-02-09 14:43:42 +11:00
Rob Harrington
65db856054
Order confirmation emails are not sent for standing order orders.
2018-02-09 14:43:42 +11:00
Rob Harrington
8ab698d4dc
Generating orders for standing orders ignores stock on hand at initialisation
2018-02-09 14:43:42 +11:00
Rob Harrington
5598a0d24f
line_item.unit_value delegates to variant when quantity is 0 or final_weight_volume is missing
2018-02-09 14:43:41 +11:00
Rob Harrington
ef00dca5a0
Changing format of changes object in standing order placement job
2018-02-09 14:43:41 +11:00
Rob Harrington
7a308f1651
Updating letter_opener gem
2018-02-09 14:43:41 +11:00
Rob Harrington
3edfd07a40
WIP: adding method to StandingOrderPlacementJob to send emails
2018-02-09 14:43:41 +11:00
Rob Harrington
5e0186fa1f
Standing Order Placement Job: capping line items quantities to available stock level
2018-02-09 14:43:41 +11:00
Rob Harrington
1c7e9923f9
Checking for sufficient stock takes variant overrides into account
2018-02-09 14:43:41 +11:00
Rob Harrington
a8928a0ccc
Capping line item quantity at stock takes overrides into account
2018-02-09 14:43:40 +11:00
Rob Harrington
2aad722b4b
WIP, SO placement job: preventing payments on standing orders from being processed when OC opens
2018-02-09 14:43:40 +11:00
Rob Harrington
9ad6dce2d6
WIP, SO placement job: processing orders to completion
2018-02-09 14:43:39 +11:00
Rob Harrington
178aadb311
WIP, SO placement job: Finding orders to be placed
2018-02-09 14:43:39 +11:00
Rob Harrington
6f629e112a
WIP, OC open-close job: performing the job spawns StandingOrderPlacementJobs for each recently opened OC
2018-02-09 14:43:39 +11:00
Rob Harrington
5b25f63e44
WIP, OC open-close job: finding recently opened order cycles
2018-02-09 14:43:39 +11:00
Rob Harrington
140d62939a
Adding processing marker column standing_orders_placed_at to order cycles
2018-02-09 14:43:39 +11:00
Rob Harrington
95a7fc8ef5
Initialisation and removal of standing order orders respects begins_at and ends_at contraints
2018-02-09 14:43:39 +11:00
Rob Harrington
3eff65f1f5
Finish refactoring of Standing Order Updaters, replacing with form class used by controller
2018-02-09 14:43:38 +11:00
Rob Harrington
2a3dc33f86
WIP: Pushing shipment and payment update logic down into separate methods
2018-02-09 14:43:38 +11:00
Rob Harrington
6ea4aac361
WIP: Refactoring StandingOrderUpdater into StandingOrderForm
...
Update logic coupled to update action on controller rather than changes to the model
2018-02-09 14:43:38 +11:00
Rob Harrington
0b35cb6619
Standing Order Updater handles changes to line item quantities
2018-02-09 14:43:38 +11:00
Rob Harrington
9468dcb406
Adding lib class to maintain standing order orders
2018-02-09 14:43:38 +11:00
Rob Harrington
d5349e7ad0
Standing Orders: adding association between orders and standing orders
2018-02-09 14:43:38 +11:00
Rob Harrington
a7132684e5
Standing Orders: create join table for linking orders with standing orders
2018-02-09 14:43:37 +11:00
Rob Harrington
7eac6e725a
Standing Orders: adding order_cycles association to StandingOrder model
2018-02-09 14:43:37 +11:00
Rob Harrington
aeae0f245e
Standing Orders: standing line items can be deleted from existing standing order
2018-02-09 14:43:37 +11:00
Rob Harrington
38d75d2b1c
Standing Orders: adding routing and controller action for deleting standing line items
2018-02-09 14:43:37 +11:00
Rob Harrington
594bec1b37
StandingLineItems can be removed when creating a StandingOrder
2018-02-09 14:43:37 +11:00
Rob Harrington
1b711bcd46
Standing Orders can be edited
2018-02-09 14:43:37 +11:00
Rob Harrington
4ad6b1a65e
Billing and Shipping addresses can be set on new standing orders
2018-02-09 14:43:37 +11:00
Rob Harrington
b701ca43f4
WIP: adding shiping and billing address to StandingOrder model
2018-02-09 14:43:37 +11:00
Rob Harrington
88563431b8
Module arguments passed to injection functions in consistent way
2018-02-09 14:43:36 +11:00
Rob Harrington
06fffb9ef7
SO Index: centering data in some columns
2018-02-09 14:43:35 +11:00
Rob Harrington
ab0728cd0b
SO Index: Adding day to standing order dates
2018-02-09 14:43:35 +11:00
Rob Harrington
44d7537744
SO Index: Adding items column
2018-02-09 14:43:34 +11:00
Rob Harrington
6fadeacf0e
SO Index: Adding begins_on and ends_on columns
2018-02-09 14:43:34 +11:00
Rob Harrington
af9376b60c
SO Index: Adding column dropdown
2018-02-09 14:43:34 +11:00
Rob Harrington
a395f183f9
SO Index: adding spec for changing shops
2018-02-09 14:43:34 +11:00
Rob Harrington
7c57d3d4c6
SO Index: standing orders can be filtered using quick search
2018-02-09 14:43:34 +11:00
Rob Harrington
bbd43f7026
SO Index: User must select a shop first in order to load relevant standing orders
2018-02-09 14:43:34 +11:00
Rob Harrington
a94742e4db
Ensuring ransack restrictions are applied in StandingOrderController#collection
2018-02-09 14:43:33 +11:00
Rob Harrington
24cb823c90
Loading managed shops into standing orders index, to be used for filtering
2018-02-09 14:43:33 +11:00
Rob Harrington
8372317a8f
Enterprise User can view basic listing of standing orders
2018-02-09 14:43:33 +11:00
Rob Harrington
ef08fd4bb3
Adding dedicated standing order serializer for index
2018-02-09 14:43:33 +11:00
Rob Harrington
1d58ef55f7
Calling Standing Orders index controller action using json returns serialized data
2018-02-09 14:43:33 +11:00
Rob Harrington
a1ccf8a28e
Adding initial defaults for standing orders index column visibility
2018-02-09 14:43:32 +11:00
Rob Harrington
7ab05cf857
Basic AngularJS controller and service for loading StandingOrders
2018-02-09 14:43:32 +11:00
Rob Harrington
c18c1c67d1
Adding visibility permissions for standing orders
2018-02-09 14:43:32 +11:00
Rob Harrington
cd2d73810d
StandingOrderResource can handle index action
2018-02-09 14:43:32 +11:00
Rob Harrington
91917886a8
Adding basic routing and templates for standing orders index
2018-02-09 14:43:32 +11:00
Rob Harrington
8bbc0b7790
Adding translations to standing order form
2018-02-09 14:43:32 +11:00
Rob Harrington
2e83ab80cf
Tweaking layout of details section of standing order creation form
2018-02-09 14:43:32 +11:00
Rob Harrington
bba4b54f9b
Adding a wizard progress indicator to standing order creation form
2018-02-09 14:43:31 +11:00
Rob Harrington
897eb11512
Standing Orders: form split into ngForm elements with staggered validation
2018-02-09 14:43:31 +11:00
Rob Harrington
ac5fe6a9fb
Each section of standing order form has a title
2018-02-09 14:43:31 +11:00
Rob Harrington
29760d6419
Renaming 'items' partial as 'products'
2018-02-09 14:43:31 +11:00
Rob Harrington
1808e3881f
Making standing order creation more like a wizard
2018-02-09 14:43:31 +11:00
Rob Harrington
a9ea042791
Splitting details section of standing order form out into partial
2018-02-09 14:43:31 +11:00
Rob Harrington
6d5ca1501c
Moving standing order form into separate partial
2018-02-09 14:43:31 +11:00
Rob Harrington
946046e53b
Moving action for estimating standing_line_item prices into StandingLineItemController#build
2018-02-09 14:43:31 +11:00
Rob Harrington
71b84d490e
Adding validation contraints to standing order associations
2018-02-09 14:43:30 +11:00
Rob Harrington
6bd5a895b3
Moving InfoDialog into admin.utils module
2018-02-09 14:43:30 +11:00
Rob Harrington
e661430cc9
StandingLineItems added to StandingOrder are saved
...
Adding some additional validation
2018-02-09 14:43:30 +11:00
Rob Harrington
415955e7b3
SO: Adding variants to a new standing order, price estimate provided
2018-02-09 14:43:30 +11:00
Rob Harrington
5aa993f5b4
Moving select2 config for variant-autocomplete into a directive
2018-02-09 14:43:30 +11:00
Rob Harrington
6934b87816
SO: Adding basic interface for Standing Order creation
2018-02-09 14:43:29 +11:00
Rob Harrington
e4de7e262d
SO: Adding StandingLineItem model
2018-02-09 14:43:29 +11:00
Rob Harrington
d711c321b6
SO: Adding Standing Order Model
2018-02-09 14:43:29 +11:00
Rob Harrington
733dc76c6c
Order Cycles can be assigned to schedules via new/edit form
2018-02-09 14:43:29 +11:00
Rob Harrington
4195bd6cd8
Order Cycles can be filtered by Schedule
2018-02-09 14:43:29 +11:00
Rob Harrington
8c0bad3115
Schedules can be deleted from OC index
2018-02-09 14:43:28 +11:00
Rob Harrington
a9b9cbf4bd
Restoring 'Loading' flash to order cycle index
2018-02-09 14:43:28 +11:00
Rob Harrington
33e5601658
Adding translation for schedule without OCs error
2018-02-09 14:43:28 +11:00
Rob Harrington
2a1ca1c206
Using angular-ui sortable instead of pure jQuery, refactoring logic around including blanks in select2s
2018-02-09 14:43:28 +11:00
Rob Harrington
357040f67a
Enterprise User can create and update schedules via OC index
2018-02-09 14:43:28 +11:00
Rob Harrington
920f52e112
Adding schedules to Order Cycles interface
2018-02-09 14:43:28 +11:00
Rob Harrington
a25f2141a5
Adding Order Cycle Schedules join table
2018-02-09 14:43:27 +11:00
Rob Harrington
c51b956b01
Adding Schedule model
2018-02-09 14:43:27 +11:00
Rob Harrington
0d845b0fd6
Adding column toggling interface to Order Cycles index
2018-02-09 14:43:27 +11:00
Rob Harrington
fe9f147ff0
Adding ability to filter OC index by OC name or 'involved' enterprise
2018-02-09 14:43:27 +11:00
Rob Harrington
2a5f598fb0
Angularising Order Cycles Index
2018-02-09 14:43:20 +11:00
Maxime Lalisse
bf69ed0008
Add and namespace a missing translation key
2018-02-09 11:57:44 +11:00
Maxime Lalisse
8bd952ed56
Add i18n for defaced elements in admin_product_tabs
2018-02-09 11:57:44 +11:00
Maxime Lalisse
9a3f61904b
Add translation keys for admin_product_tabs
2018-02-09 11:57:44 +11:00
Godfrey Chan
fbc5318a7b
Add Skylight instrumentation
...
If you’re not already familiar with [Skylight](https://www.skylight.io ),
it is a smart profiler for Rails apps. Skylight makes it easy to
pinpoint performance issues in Rails applications.
We work on a lot of open source projects ourselves, and in our
experience it can be pretty hard to get contributors to work on
application performance issues. Few contributors consider working
on performance problems, and the ones that might be interested may
not even know where to start.
By making performance information more accessible, we hope to
inspire potential contributors to tackle slow parts of your app,
and have a good way to see if their contributions helped.
Local deployments that are interested in this can request an API
token from https://www.skylight.io/oss and set it in
`config/application.yml` (if no token is set, it will log a message to
`log/skylight.log` but won't otherwise prevent the app from working
normally).
2018-02-07 11:37:30 -08:00
Matt-Yorkley
41ce7047cc
Tidy up order cycle spec
2018-02-07 17:48:16 +11:00
Matt-Yorkley
f28471e456
Fixed datepicker button intermittent failure
2018-02-07 17:48:16 +11:00
Matt-Yorkley
4cb9e3a3f1
Datepicker CSS tweaks
2018-02-07 17:48:16 +11:00
Matt-Yorkley
2f6a249b5f
Fix missing datepicker icon
2018-02-07 17:48:16 +11:00
Pau Perez
0634735288
Adjust Codeclimate config to ignore Rails patch
...
Since it is a file copied from Rails 4, we want to keep it in its
original state and not refactor it.
2018-02-07 16:21:16 +11:00
Pau Perez
719c45b408
Apply Rails 4 patch at boot time not only specs
...
This makes this patch available also for things like database-related
rake tasks. It moves the patch to an initializer.
2018-02-07 16:21:16 +11:00
Maikel Linke
b70edd5424
Enabling non-privileged postgres users to run specs
...
Addressing issue #245 .
A combination of fixtures and foreign key constraints requires the postgres
user to be superuser. Otherwise an attempt to disable constraints fails.
This got fixed in Rails 4 and this patch brings the same behaviour back to
Rails 3. It will allow us to run the specs with a nosuperuser postgres user.
See:
- https://github.com/matthuhiggins/foreigner/issues/61
- 9bb27f7ffe
2018-02-07 16:21:16 +11:00
Aaron Hursh
a6498c2f96
Removed ng-disabled conditional from submit button on admin customers index.
2018-02-07 15:09:07 +11:00
Maxim Colls
5db1559f28
Fixed spec to use unuppercased states
2018-02-07 13:35:50 +11:00
Maxim Colls
09f98307f4
Do not upcase State abbreviation
2018-02-07 13:35:50 +11:00
Rob Harrington
56be7b1d46
Fix spec to handle non-deterministic ordering
2018-02-07 11:45:48 +11:00
Rob Harrington
b2f3477261
Change unused creation_date translation key back to confirmation_date
...
See 22eae753fe for original change
2018-02-07 11:42:38 +11:00
Matt-Yorkley
14b73149be
Remove stale form validation messages when showing new confirmation sent message
2018-02-07 10:41:54 +11:00
Matt-Yorkley
0ab7d95607
Remove mention of confirmation email from enterprise creation wizard
2018-02-07 10:41:53 +11:00
Matt-Yorkley
ee08dcfeb4
Use owner as contact if user record doesn't exist
2018-02-07 10:41:53 +11:00
Matt-Yorkley
b893dea810
Make sure userSelect directive uses our Admin::UserSerializer instead of base Spree api view
2018-02-07 10:41:53 +11:00
Matt-Yorkley
ec5ce45850
Change confirmation email wording
2018-02-07 10:41:53 +11:00
Matt-Yorkley
9afb97fa0f
Show contact email without full permissions
2018-02-07 10:41:53 +11:00
Matt-Yorkley
676abe0ced
Remove serialized contact attributes
2018-02-07 10:41:53 +11:00
Matt-Yorkley
73d38cb91b
Re-add text version of confirmation email for accessibility
2018-02-07 10:41:53 +11:00
Matt-Yorkley
fffae46a63
Remove enterpriseRoles from enterprsies controller
2018-02-07 10:41:53 +11:00
Matt-Yorkley
6ed91cab1f
Remove old translation keys
2018-02-07 10:41:53 +11:00
Matt-Yorkley
cc5d0c35dd
Refactor enterprise contact user assignment
2018-02-07 10:41:53 +11:00
Matt-Yorkley
c34570154c
Use contact model in printed tickets
2018-02-07 10:41:53 +11:00
Matt-Yorkley
a5940e1641
Fix user controller spec
2018-02-07 10:41:53 +11:00
Matt-Yorkley
39f0c5b5b0
Rename contact name field and revert contact name specs
2018-02-07 10:41:53 +11:00
Matt-Yorkley
abb5adec43
Enterprise managers UI specs
2018-02-07 10:41:53 +11:00
Matt-Yorkley
525cb4826f
Code review refactoring
2018-02-07 10:41:53 +11:00
Matt-Yorkley
fde0aba96c
Feedback when user changes email addess
2018-02-07 10:41:53 +11:00
Matt-Yorkley
ff18fd25f1
Adjust Discourse login for user confirmations
2018-02-07 10:41:53 +11:00
Matt-Yorkley
9248ac05ac
Adjustments for failing specs
2018-02-07 10:41:53 +11:00
Matt-Yorkley
a066c6391d
Adjust injection data namespacing
2018-02-07 10:41:53 +11:00
Matt-Yorkley
4d11485283
Use receives_notifications flag for enterprise contact
2018-02-07 10:41:53 +11:00
Matt-Yorkley
9e270690ef
Remove enterprise email
...
A user with the same email address is receiving notifications now.
If the email address is invalid, the owner receives notifications.
2018-02-07 10:41:53 +11:00
Matt-Yorkley
15b781b271
Update enterprise managers and contact role
2018-02-07 10:41:52 +11:00
Matt-Yorkley
5dc8f21b7b
Show confirmed status in enterprise managers UI
2018-02-07 10:41:52 +11:00
Matt-Yorkley
9ccb3ee80b
Add receives_notifications flag to enterprise_roles
2018-02-07 10:41:52 +11:00
Matt-Yorkley
27de66b055
Owner's permissions can't be deleted
2018-02-07 10:41:52 +11:00
Matt-Yorkley
ba98c7e2c5
Rewrite enterprise contact functionality
2018-02-07 10:41:52 +11:00
Matt-Yorkley
22eae753fe
Remove enterprise confirmations
2018-02-07 10:41:52 +11:00
Pierre de Lacroix
d832d850fe
Revert removed translations for Enterprise mails
2018-02-07 10:41:52 +11:00
Matt-Yorkley
aead867ea0
Set all current users to confirmed
2018-02-07 10:41:51 +11:00
Matt-Yorkley
97f5022bdd
Show signup message in modal wihout redirect
2018-02-07 10:41:51 +11:00
Matt-Yorkley
0cb7a555d3
Adjust confirmation template
2018-02-07 10:41:51 +11:00
Maikel Linke
52b7872a55
Simplify conditionals
2018-02-07 10:41:51 +11:00
Matt-Yorkley
522aaee1a3
Update login modal for resending confirmations
2018-02-07 10:41:51 +11:00
Matt-Yorkley
179cf6e484
Tidy up confirmation migrations
2018-02-07 10:41:51 +11:00
Matt-Yorkley
28ded1f0c2
Adjust user signup feedback
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
7d971fc39d
Add UserConfirmationsController spec
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
4f0b20e8ad
Better tests
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
a6f2ee1367
Add migration to confirm already confirmed email addresses
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
eb1c598a6c
Fix tests
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
4706bf0528
Remove changes on FR locale file
2018-02-07 10:41:51 +11:00
Matt-Yorkley
969b6caa96
Code cleanup
2018-02-07 10:41:51 +11:00
Matt-Yorkley
69ea1e6d26
Set test users to confirmed by default
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
91704d9df7
Create user confirmation email
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
dbbc2ddb1c
Add confirmable email to user model
2018-02-07 10:41:51 +11:00
Pau Pérez Fabregat
99729457cc
Merge pull request #2063 from coopdevs/autocorrect-cop
...
Autocorrect rubocop Layout/BlockEndNewline cop
2018-02-05 08:50:58 +01:00
Pau Pérez Fabregat
5a58294bc6
Merge pull request #2042 from erose357/master
...
addresses issue #1275
2018-02-02 13:41:23 +01:00
Enrico Stano
398b3bbd8b
Merge pull request #1960 from coopdevs/remove-warning
...
Fix payment_method_decorator boot-time warning
2018-02-02 10:43:51 +01:00
Pau Perez
6cb038c362
Autocorrect rubocop Layout/BlockEndNewline cop
2018-02-01 09:52:53 +01:00
Pau Pérez Fabregat
cc40948783
Merge pull request #2051 from coopdevs/regenerate-knapsack-report
...
Regenerate Knapsack report
2018-01-31 15:04:30 +01:00
Enrico Stano
00bdcd3948
Merge pull request #2045 from coopdevs/use-symbol-hash-syntax
...
Enable HashSyntax rubocop cop with symbol style
2018-01-31 09:30:06 +01:00
Matt-Yorkley
c860ffc176
Adjust use of non-translatable open/closed icons
2018-01-24 15:33:26 +11:00
Pau Perez
8664411880
Disable knapsack report generation again
...
No need to enable it to regenerate the report again until Knapsack
itself tells us.
2018-01-23 09:21:56 +01:00
Pau Perez
f17f1008e3
Update knapsack report file with latest CI values
2018-01-23 09:21:10 +01:00
Pau Perez
a2828f3b9a
Regenerate Knapsack report
...
It's already asking for it in the CI output
2018-01-23 08:06:53 +01:00
Pau Perez
cbfdfb43e3
Enable HashSyntax rubocop cop with symbol style
...
This enforces the ruby 1.9 symbol hash syntax and consistency among the
style of the keys.
# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets
# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}
The .rubocop-todo.yml is also updated to keep track of the existing
violations.
2018-01-20 12:50:50 +01:00
Matt-Yorkley
23e672aef9
Add updated globe icon to mobile view
2018-01-19 10:56:11 +00:00
Matt-Yorkley
6d9cc7e29d
Fix account page locale
2018-01-18 10:22:40 +11:00
Matt-Yorkley
8a47788a09
Remake OFN icon font
2018-01-18 10:22:40 +11:00
Matt-Yorkley
afed5ab666
Refector spec
2018-01-18 10:22:40 +11:00
Matt-Yorkley
357eda8c19
Adjustments for failing specs
2018-01-18 10:22:40 +11:00
Matt-Yorkley
f18401d183
Language switcher frontend
2018-01-18 10:22:40 +11:00
Matt-Yorkley
4ea91d14f9
Template I18n changes
2018-01-17 12:03:27 +11:00
Pau Perez
f57661b13f
Fix payment_method_decorator boot-time warning
...
Removes the annoying message "warning: already initialized constant
Spree::PaymentMethod::DISPLAY" that appears 4 times when booting the
app.
We are declaring said constant exactly as our Spree version does so
there's no point on repeating work.
2018-01-15 12:50:05 +01:00
Pau Pérez Fabregat
ad25c1d1b2
Merge pull request #2033 from coopdevs/add-setup-script
...
Add setup script
2018-01-15 12:05:19 +01:00
Pau Perez
87af5dcee5
Point to rbenv and nodenv from setup script
...
Show the appropriate links when the Ruby and Node dependencies are not
met. This will make it easier for newcomers to install them.
2018-01-12 08:22:50 +01:00
Pau Perez
106871b956
Check node version and install npm packages
2018-01-11 14:14:08 +01:00
Pau Perez
4d25abcfce
Add setup script
...
It aims to aid new open source contributors on setting up their dev
env by means of a single command with meaningful output.
Although ofn-install ansible scripts also work for development we don't
want to add too much burden to those single-time beginner contributions.
2018-01-11 14:14:08 +01:00
Rob Harrington
2ccdf3c97a
Use upstream and origin as remote names
...
Also fixed a couple of typos
2018-01-11 14:30:08 +11:00
Rob Harrington
89bd9c8038
Update CONTRIBUTIONS.md to reflect current processes
2018-01-11 14:30:08 +11:00
Enrico Stano
88627dc837
Merge pull request #2038 from boveus/master
...
Update README.md
2018-01-10 12:17:21 +01:00
Brandon Stewart
8ca57b0705
Update README.md
2018-01-09 14:02:27 -07:00
Brandon Stewart
c7db283e8c
Update README.md
2018-01-09 14:00:07 -07:00
erose357
83ca3b7b8b
Adds a css rule to target the logo in .footer-local and padding between the logo and open source info at the bottom
2018-01-09 12:54:41 -07:00
Brandon Stewart
830699d2b8
Update README.md
2018-01-09 10:29:02 -07:00
Brandon Stewart
f822e658c4
Update README.md
2018-01-09 10:23:51 -07:00
Brandon Stewart
8817a1afb7
Update README.md
2018-01-09 10:23:30 -07:00
Brandon Stewart
693adf181e
Update README.md
2018-01-09 10:21:24 -07:00
Brandon Stewart
f269f13b09
Update README.md
2018-01-08 11:50:44 -07:00
Matt-Yorkley
9845258a25
Merge pull request #2035 from Matt-Yorkley/uk/rubocop_fix
...
Update rubocop.yml
2018-01-05 20:16:44 +00:00
Enrico Stano
edbed2c8d3
Merge pull request #1984 from coopdevs/fix/api-key-taxons
...
Disable api auth as there is no Spree api key set
2018-01-05 10:31:36 +01:00
Matt-Yorkley
8e0f2d2500
Merge pull request #2037 from Matt-Yorkley/uk/codeclimate_checks
...
Codeclimate yml update
2018-01-05 01:37:06 +00:00
Matt-Yorkley
e022504c26
Codeclimate yml update
2018-01-04 17:10:55 +00:00
Matt-Yorkley
62e4cbd052
Update rubocop.yml
2018-01-04 16:01:06 +00:00
Enrico Stano
70ae59550d
Merge pull request #2032 from Matt-Yorkley/uk/codeclimate_migrations
...
Adjust codeclimate engine for migrations folder
2018-01-03 13:48:47 +01:00
Lynne
f74af8fa2d
Merge pull request #2034 from lin-d-hop/translations-uk
...
Manual uk translation update
2018-01-03 06:00:07 +01:00
lin-d-hop
82d1b57005
Not updated from transifex so manually commiting
2018-01-03 03:40:04 +00:00
Lynne
c32aacc1b3
Delete en-GB.yml
...
Superseded by en_GB.yml
2018-01-03 03:29:52 +00:00
Matt-Yorkley
523b4045bf
Adjust codeclimate engine for migrations folder
2018-01-02 13:54:41 +00:00
Enrico Stano
8e4e273b7c
Merge pull request #1994 from openfoodfoundation/transifex
...
Transifex
2017-12-22 16:36:44 +11:00
Enrico Stano
816297e22f
Merge pull request #2022 from ltrls/add-order-print-ticket-feature-test
...
Add feature test for the Spree::Admin::OrdersController print_ticket action
2017-12-22 15:07:17 +11:00
Pau Perez
72889b5c36
Stub current_user instead of api key's user
2017-12-21 10:24:29 +11:00
Pau Perez
0f0216fe79
Upgrade spree to get our latest patch
2017-12-21 10:24:29 +11:00
Pierre de Lacroix
42433d1ad4
Add feature test for the Spree::Admin::OrdersController print_ticket action
2017-12-20 23:01:18 +01:00
Pau Perez
52533fc04c
Rely on Spree's default value for requires_auth
2017-12-20 17:25:23 +11:00
Pau Perez
bb0223877c
Remove unused arguments and reduce object creation
2017-12-20 17:25:23 +11:00
Pau Perez
5eb1fcddbb
Remove dependency on TestingSupport by inlining
2017-12-20 17:25:23 +11:00
Pau Perez
c646eb3939
Disable api auth as there is no Spree api key set
...
Although Spree::Api::Config[:requires_authentication] is set to false by
default for some unknown reason if not done explicitly Spree still
returns it as false.
This amends the change done in a87c89c83d ,
which introduced the bug. As there is no Spree api key set the auth
fails when getting taxons.
2017-12-20 17:25:23 +11:00
Enrico Stano
a313c99370
Merge pull request #2005 from coopdevs/upgrade-spree-fork-version
...
Upgrade spree's fork to latest commit
2017-12-20 17:23:48 +11:00
Enrico Stano
0f84d9f02e
Merge pull request #2004 from coopdevs/is-this-needed
...
Remove unused Enterprise scopes
2017-12-20 16:59:15 +11:00
Enrico Stano
900a9c6145
Merge pull request #2000 from coopdevs/issue-template-improvement
...
Mention screenshot in the issue template
2017-12-20 16:48:54 +11:00
Pau Perez
5b33cbe9aa
Upgrade spree's fork to latest commit
...
Needed to get
3289b5e31c
2017-12-20 16:37:14 +11:00
Enrico Stano
114ce3b764
Merge pull request #1940 from coopdevs/improve-readability-shop
...
Improve readability of shop's code
2017-12-20 16:28:53 +11:00
Enrico Stano
660d3f326f
Remove unused Enterprise scopes
2017-12-20 16:00:35 +11:00
Pau Perez
b8d51ae0de
Mention screenshot in the issue template
...
For things like translations it's enough sharing a screenshot when
reporting a bug. See
https://github.com/openfoodfoundation/openfoodnetwork/issues/1999
2017-12-20 10:16:53 +11:00
Enrico Stano
0bdda6387a
Merge pull request #1996 from coopdevs/add-issue-template
...
Create issue template
2017-12-19 18:00:04 +11:00
Pau Perez
4fbdbb1aa2
Link to placeholder feature template
...
We'll write the template later on
2017-12-19 15:26:21 +11:00
Pau Perez
72ddcb4fff
Create issue template
...
It assumes most of the times issues will be reported to keep track of
bugs.
2017-12-19 11:07:29 +11:00
Transifex-Openfoodnetwork
50ef2de5f9
Updating translations for config/locales/fr.yml
2017-12-15 20:06:43 +11:00
Transifex-Openfoodnetwork
55d3ee1af0
Updating translations for config/locales/pt.yml
2017-12-13 21:19:42 +11:00
Transifex-Openfoodnetwork
422166441e
Updating translations for config/locales/en_US.yml
2017-12-09 02:29:48 +11:00
Transifex-Openfoodnetwork
9d3f85628c
Updating translations for config/locales/nb.yml
2017-12-08 18:44:22 +11:00
Pierre de Lacroix
669d9c3c66
Fix translations on account page
2017-12-06 15:21:19 +11:00
Enrico Stano
dcb406d246
Merge pull request #1986 from andypalmer/github_protocol_warning
...
Change github definition to remove insecure protocol warning.
2017-12-04 21:49:05 +11:00
Andy Palmer
cadad28b0c
Change github definition to remove insecure protocol warning. Consistently use 1.9.3 hash syntax
2017-12-04 16:50:36 +11:00
Enrico Stano
01b0a033fd
Merge pull request #1904 from oeoeaio/spree-test-config
...
Use Spree's approach for preventing config caching when testing
2017-12-04 15:57:11 +11:00
Pierre de Lacroix
0fb66ab258
Fix CodeClimate issues
2017-12-01 13:37:30 +11:00
Pierre de Lacroix
a49c21cfd1
Add instance switch to enable number localization
2017-12-01 13:37:24 +11:00
Pierre de Lacroix
f67a8c1f2d
Add tests
2017-12-01 13:37:24 +11:00
Pierre de Lacroix
f4624ead42
Make all products reload when updating in bulk edit
2017-12-01 13:37:24 +11:00
Pierre de Lacroix
2cd570383f
Use localize_number in models
2017-12-01 13:37:24 +11:00
Pierre de Lacroix
920900b619
Add Spree::LocalizedNumber module
2017-12-01 13:37:24 +11:00
Pau Perez
e98d934a67
Include localization files as documented in gem
...
I followed the Usage help in
https://github.com/derekprior/momentjs-rails .
2017-11-29 10:13:05 +11:00
leandroalemao
31a846b9c3
Refactor _i18n_script.html.haml file and add new momentjs internationalisation files
2017-11-29 10:13:05 +11:00
leandroalemao
5eaea28401
Switch momentjs internationalisation according to I18n locale
2017-11-29 10:13:05 +11:00
Pierre de Lacroix
50ef902adb
Add missing tooltip in products' bulk edit page
2017-11-23 11:31:41 +11:00
Pierre de Lacroix
75b6a078c6
Add missing translation
2017-11-23 11:31:41 +11:00
Pierre de Lacroix
c0c93c172e
Add tooltips in products bulk edit page
2017-11-23 11:31:41 +11:00
Pau Perez
ed18244070
Remove TODO in favour of an issue in Github
...
It has become the issue
https://github.com/openfoodfoundation/openfoodnetwork/issues/1961
2017-11-23 11:12:17 +11:00
Pierre de Lacroix
e13063e0c6
Fix before_filter for Spree::Admin::OrdersController#print_ticket
2017-11-23 11:01:41 +11:00
Rob Harrington
6c38997010
Fix 1664: product tag rules not working
...
Caused by a combination of: fe7bd5e2cd and 38d3b446cc
Have added/tweaked specs to prevent this from happening again
2017-11-15 10:26:24 +11:00
Pau Perez
0e01c0d69b
Turn TODO into issue #1957
...
TODOs that live in the code can't be prioritized and tend to be
forgotten.
2017-11-15 09:44:11 +11:00
Pau Perez
caab3ea74d
Add spree user as admin of Enterprise 2 in seed
2017-11-15 09:42:21 +11:00
Lynne
c543dff2e1
Merge pull request #1956 from coopdevs/improve-pr-template
...
Add special keyword syntax to close issue from PR
2017-11-14 14:16:08 +01:00
Pau Perez
92badfd88c
Add special keyword syntax to close issue from PR
...
We want the issue to be closed when the PR gets merged but we always
forget to add the "magic" comment as described in
https://help.github.com/articles/closing-issues-using-keywords/ .
2017-11-14 09:02:52 +01:00
Lynne
dca64e6939
Merge pull request #1944 from lin-d-hop/master
...
Adding UK About pages to menus
2017-11-10 16:33:58 +01:00
Saimon Moore
a9c4d27d5e
Undo i18n_fallbacks change to production.rb
2017-11-10 12:30:24 +11:00
Saimon Moore
610c2f9519
Ensure en is an I18n fallback in all environments
...
Since `en` is considered as the main fallback for all locales
ensure that it is present in all environments.
Note: Setting `config.i18n.fallbacks` to `true` means use the default locale
which means that if a particular instance is not using an `en` based locale
(the parent `en` locale is automatically derived as a fallback) then `en` will
not be available as a fallback.
2017-11-10 12:30:24 +11:00
Saimon Moore
05d757e7c4
Ensure we have min i18n fallbacks
...
This setting defines which locales will be exported to the frontend.
In general, ofn currently functions under a single locale
(which is also the default locale) but all translations are made from
the `en` locale.
The current process of ensuring translations are translated and make
their way into code is manual and prone to issues so occasionally
translations for keys in the default locale of a particular instance
are not deployed and the UI displays `missing translation` messages.
In these cases, it is far friendlier for the user to see fallbacks to
`en` rather than these errors so this commit ensure that at the very
least apart from the current default locale, `en` is also made available
and as such will be exported to the frontend so that it's translations
are available as a fallback in JS land.
I18n fallback config was already enabled in both frontend and backend.
Until now, available locales may not have been set (determined by the
`AVAILABLE_LOCALES` env var) and the translations for `en` not therefore
be present in the frontend for fallback to actually work.
This commit will ensure that a fallback to `en` is always possible in the
case of missing translations.
2017-11-10 12:30:24 +11:00
Maxim Colls
31a2453882
Bootstrap angular module in new_variant form
2017-11-10 09:37:36 +11:00
Rob Harrington
5febd0a0d6
Restructure flaky customer spec
2017-11-10 08:47:12 +11:00
Rob Harrington
694f1e9b25
Update knapsack report
2017-11-10 08:47:12 +11:00
Andy Palmer
131bf842a9
Update matchers to non-deprecated protocol
2017-11-10 08:47:12 +11:00
Andy Palmer
8ec1c2e04a
No longer use expensive page.evaluate_script for imperative methods
2017-11-10 08:47:12 +11:00
Andy Palmer
e94dc257a1
We actually need to restart the driver, not the session
2017-11-10 08:47:12 +11:00
Andy Palmer
3bd4fc59d4
We reset the phantom js driver after each context to prevent it memory leaking and dying
2017-11-10 08:47:12 +11:00
Andy Palmer
7b8463b03a
PhantomJS no longer crashes due to too specific selector
2017-11-10 08:47:12 +11:00
Rob Harrington
00e7fc1c0d
Bump capybara version
2017-11-10 08:47:12 +11:00
Rob Harrington
2ca20ad701
Bump poltergeist version to 1.16.0
2017-11-10 08:47:12 +11:00
Maikel Linke
775da82072
Add waiting conditions to spec
2017-11-10 08:47:12 +11:00
Maikel Linke
162b392004
Use expect syntax, correct spec description
2017-11-10 08:47:12 +11:00
Maikel Linke
26bedf0523
Make title matcher more robust
2017-11-10 08:47:12 +11:00
Maikel Linke
ff3ee62509
Remove old comment
2017-11-10 08:47:12 +11:00
Maikel Linke
9c2a78adf2
Avoid warnings, use expect syntax
2017-11-10 08:47:12 +11:00
Maikel Linke
5a767ba3ef
Avoid warning, use new syntax
2017-11-10 08:47:12 +11:00
Rob Harrington
691d642721
Use url helper instead of string to define expected url
2017-11-10 08:47:12 +11:00
Rob Harrington
7dbfc3740d
Revert "Add workaround to pass Spree core tests in Travis"
...
This reverts commit 9cdec737078caa6eb5a90480cabb6ca477ab597b.
2017-11-10 08:47:12 +11:00
Rob Harrington
b2897d7feb
Reset Spree::Config.allow_backorders to original value in spec
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
b18177c215
Add workaround to pass Spree core tests in Travis
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
cec0a8c2e7
Specify page object for Capybara#find methods
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
412de318ed
Manually disable backorders in failing features
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
92cc7a4648
Another try for failing feature
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
96c0481e17
Fix intermittently failing product distribution feature
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
5dd7ddc288
Refactor base controller with new rspec syntax
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
ea91a82f30
Try to fix shopping cart failing feauture in Travis
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
8e10269b50
Try to fix intermittently failing test for product distribution
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
dae74666c5
Add missing 'type: :request' for request spec
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
94e31e35ba
Fix Spree::Admin::BaseController related issues
2017-11-10 08:47:12 +11:00
Rob Harrington
c835b4eb1a
Replacing stub_model objects with actual factory generated instances
2017-11-10 08:47:12 +11:00
Rob Harrington
ef9e43fbd3
Replacing mock_model objects with instance_doubles
2017-11-10 08:47:12 +11:00
Rob Harrington
f083433854
Explicitly specifying 'type: :helper' for all helper specs
2017-11-10 08:47:12 +11:00
Rob Harrington
9052b1c3db
A few updates to spec where 'be true' and 'be false' didn't cut it
2017-11-10 08:47:12 +11:00
Rob Harrington
59578a73af
Changing all references to 'be_true' and 'be_false' to 'be true' and 'be false'
...
See next commit for changes where this substitution was broken
2017-11-10 08:47:12 +11:00
Rob Harrington
c691e260cf
Rspec matcher enqueue_job for Delayed::Job supports block expectations
2017-11-10 08:47:12 +11:00
Rob Harrington
82072c8970
Explicitly specifying 'type: :controller' for all controller specs
2017-11-10 08:47:12 +11:00
Rob Harrington
d0c52ac176
Updating outdated guard gems
2017-11-10 08:47:12 +11:00
Rob Harrington
6811a62568
Updating RSpec Gems
2017-11-10 08:47:12 +11:00
Buildkite
8653d03969
Merge remote-tracking branch 'origin/master' into HEAD
2017-11-09 13:49:39 +00:00
lin-d-hop
90d5a04368
Adding UK About pages to menus
2017-11-09 11:06:58 +00:00
Pau Perez
84e4ebef08
Do not notify Bugsnag of a cache miss
...
It's not the responsibility of a error tracking software to track
neither cache misses nor logs. That is what log monitoring is for.
2017-11-09 10:22:31 +01:00
Pau Perez
98603c4042
Do not test private methods
2017-11-09 10:22:31 +01:00
Pau Perez
26a4ee0171
Do not stub object under test
2017-11-09 10:22:31 +01:00
Pau Perez
4f03a2d25c
Remove unnecessary require
2017-11-09 10:22:31 +01:00
Pau Perez
6a830a3843
Isolate ArraySerializer case in injection helper
...
This makes this special case with the ArraySerializer stand out so that
the reader notices it.
2017-11-09 10:22:30 +01:00
Pau Perez
3ffd049135
Remove commented out code
2017-11-09 10:22:30 +01:00
Rob Harrington
e6d1b38b82
Remove upgrade_bundler script by reverting 250062bd2, 3f2299e52 and 5dfac10599
2017-11-09 19:46:41 +11:00
Rob Harrington
f8a892faf2
Remove upgrade_bundler script by reverting 250062bd2, 3f2299e52 and 5dfac10599
2017-11-09 18:24:22 +11:00
Pierre de Lacroix
54e141489a
Add noindex meta tag for invisible shops and staging environment
2017-11-09 12:04:27 +11:00
Pau Perez
e64fd1d308
Lower log level in prod to :info so we can debug
...
Otherwise, there are no log lines for any request, which makes it
impossible to find out anything about the app in production.
Obviously this increases the size of the log files but this has to be
dealt with log rotation. The data is our most important asset.
2017-11-09 11:13:32 +11:00
Matt-Yorkley
01647c3df9
Disable allow_backorders by default in test environment
2017-11-02 17:43:46 +11:00
Rob Harrington
cd6d7c76f6
Fix spec that requires preference persistence
2017-11-02 17:43:04 +11:00
Rob Harrington
efa71c4ac8
Use Spree's approach for handling config when testing
2017-11-02 17:43:04 +11:00
Rob Harrington
d4eb27a4ed
Fix race condition in shipping method order spec
2017-11-01 16:37:12 +11:00
Duende13
eca18ba6ee
Test to control order of shipping methods by name
2017-11-01 15:30:42 +11:00
Duende13
31fa49feed
Added orderBy 'name' to the list of shipping methods offered.
2017-11-01 15:30:42 +11:00
yasirazgar
b68aafdb72
1799 - adding missing translations in new shipping methods page
2017-11-01 10:50:21 +11:00
Andy Palmer
fd09a63e48
Imperative specs as per review comments
2017-10-24 17:56:04 +11:00
Andy Palmer
afc50863cd
Replace Deface with update to overridden template
2017-10-24 17:39:34 +11:00
Andy Palmer
fea2240c39
Disabled product links in cart for openfoodfoundation/openfoodnetwork#1075
2017-10-24 14:56:35 +11:00
Rob H
9642e8295e
Merge transifex translations
2017-10-21 00:23:40 +11:00
Enrico Stano
1424d44eab
Merge pull request #1919 from nicolauduran/add-dev-doc
...
Add more development documentation
2017-10-20 14:31:43 +02:00
Nicolau Duran
0a5f0a518d
Add development doc
2017-10-20 13:18:21 +02:00
Transifex-Openfoodnetwork
ff1672e411
Updating translations for config/locales/nb.yml [skip ci]
2017-10-20 19:50:21 +11:00
Transifex-Openfoodnetwork
32d8368990
Updating translations for config/locales/fr.yml [skip ci]
2017-10-20 19:42:24 +11:00
Lynne
e7f8102eb9
Update en-GB.yml
2017-10-20 08:29:18 +01:00
Rob Harrington
24e1d0b775
Fix mistyped translation key for 'dashboard'
2017-10-20 16:26:08 +11:00
Rob Harrington
ceadd386aa
Update order spec to test an order with a total > 0
...
This is necessary because the previous commit changed the logic
around payment state, meaning that a complete order with a total
of 0 and no complete paymnents is considered to have a payment
state of 'paid'. I don't think this is problematic, since it is
not possible to check out an order without line items.
This way the spec tests an order modelled on the real world.
2017-10-20 15:21:59 +11:00
Rob Harrington
d42dc2b286
Fix #1902 : ensure correct payment state when failed payments are present
...
Problem: order payments didn't seem to be loaded in any particular order,
and OrderUpdater#update_payment_state was relying on payment order to de-
termine payment state.
Strategy: Adapt a version of this method from a future version of Spree.
I tried to select a version where I would have to make the absolute mini-
mum number of changes to get it to work. See comments in code for justif-
ications of the changes that I did make.
2017-10-20 15:21:59 +11:00
Continuous Integration
e9c8e17710
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-19 20:42:35 +11:00
Lynne
bfd845915c
Update en-GB.yml
2017-10-19 10:41:21 +01:00
Rob Harrington
b7976a2356
Do not update finalized fee adjustments
2017-10-19 16:54:39 +11:00
Rob Harrington
cd744dab68
Ignore .byebug_history after recent update of byebug gem
2017-10-19 10:45:24 +11:00
Transifex-Openfoodnetwork
02e3aac3f0
Updating translations for config/locales/fr.yml [skip ci]
2017-10-19 04:38:24 +11:00
Transifex-Openfoodnetwork
50075f02a0
Updating translations for config/locales/es.yml [skip ci]
2017-10-18 19:29:14 +11:00
Enrico Stano
05d8cd09e3
Merge pull request #1890 from coopdevs/add-node-version
...
Track node version in .node-version
2017-10-18 09:24:06 +02:00
Justyna Field
02fd87158e
Add display flex on active table row to fix misalignment
2017-10-18 15:05:55 +11:00
Pierre de Lacroix
165af4b812
Use I18n "lazy" lookup
2017-10-18 14:38:40 +11:00
Pierre de Lacroix
dba8e36752
Change key for uncapitalized "items" translation
2017-10-18 14:38:40 +11:00
Pierre de Lacroix
a245590114
Fix some translations
2017-10-18 14:38:40 +11:00
Continuous Integration
5ecae39051
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-17 19:36:45 +11:00
Transifex-Openfoodnetwork
2508234a7c
Updating translations for config/locales/en_GB.yml [skip ci]
2017-10-17 19:23:35 +11:00
Transifex-Openfoodnetwork
da5f9e7ebc
Updating translations for config/locales/nb.yml [skip ci]
2017-10-16 20:00:37 +11:00
Rob Harrington
0d483882de
Update helper messages in Stripe Connect config UI
2017-10-16 10:37:04 +11:00
Rob Harrington
9e40502876
Update stripe controller routing comments
2017-10-16 09:39:15 +11:00
Continuous Integration
c38e58159f
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-13 18:57:25 +11:00
Transifex-Openfoodnetwork
acf0919bfa
Updating translations for config/locales/en_GB.yml [skip ci]
2017-10-13 18:33:41 +11:00
Rob Harrington
bca409bfe4
Bumping very outdated versions of pry and byebug
2017-10-13 15:47:59 +11:00
Pierre de Lacroix
1fe10b4b25
Add pointer cursor to other links in products bulk edit
2017-10-13 15:33:30 +11:00
Pierre de Lacroix
768378b147
Add pointer cursor to EXPAND ALL link in products bulk edit
2017-10-13 15:33:30 +11:00
Rob Harrington
1fcbf6b44d
Clear shipping_method_id from order when restarting checkout
...
If the order is allowed to retain a shipping_method_id, then subsequent
saves of the order will cause a new shipment to be initialised. Seems to
only happen for delivery shipping methods. This is undesirable because
fees for the new shipment will appear in the checkout summary, which is
not smart enough to recognise existing shipment fees and adjust the order
total accordingly.
2017-10-13 12:53:35 +11:00
Rob Harrington
f96502c369
Add unit specs for CheckoutController#restart_checkout
2017-10-13 12:53:35 +11:00
Rob Harrington
c031b0e52b
Clear shipments and payments after failed payment at checkout
2017-10-13 12:53:35 +11:00
Rob Harrington
6006952603
Moving checkout request specs into their own folder
2017-10-13 12:53:35 +11:00
Duende13
e5fb8712d7
Simplify Product Edit Screen removing fields and adding 2 new menu options for seo and group buy ( #1741 )
2017-10-13 11:37:57 +11:00
Pierre de Lacroix
508dfa4f23
Fix failing tests assuming localizeCurrency has no "delimiter"
2017-10-13 10:26:13 +11:00
Pierre de Lacroix
65d176f533
Fix wrong way to force currency symbol after the amount
2017-10-13 10:26:13 +11:00
Pierre de Lacroix
089c754f62
Remove conversion of amounts to currency strings via Money in serializers as it's better done in JS
2017-10-13 10:26:13 +11:00
Pierre de Lacroix
aae8f1cbc4
Change localizeCurrency filter to use I18n.toCurrency
2017-10-13 10:26:12 +11:00
Matt-Yorkley
7194db40ee
Merge pull request #1895 from Matt-Yorkley/codeclimate-symbol-arrays
...
Relax rubocop Style/SymbolArray rule
2017-10-13 00:06:32 +01:00
Rob Harrington
f2ad087be5
Change inheritance of StripeAccountsController
2017-10-13 07:57:16 +11:00
Rob Harrington
0b8b5e694e
Move Stripe Connect callback action to dedicated controller
2017-10-12 22:47:51 +11:00
Rob Harrington
01f9fd3232
Rename webhook handler status mappings
2017-10-12 22:47:51 +11:00
Rob Harrington
99cac20725
Fall back to 200 when handler returns an unknown result
2017-10-12 22:47:51 +11:00
Rob Harrington
068dbe5013
Add verification to Stripe webhook endpoint
2017-10-12 22:47:45 +11:00
Rob Harrington
ed375a1e2c
Build Event object in controller instead of service object
2017-10-12 20:51:17 +11:00
Rob Harrington
4345285164
Allow more granularity in Stripe WebhookHandler responses
2017-10-12 20:51:17 +11:00
Rob Harrington
eb7cb02f33
Namespace stripe webhook controller in Stripe module
2017-10-12 20:50:29 +11:00
Rob Harrington
f22dd7513d
Add a service object for handling Stripe webhooks
2017-10-11 17:50:46 +11:00
Rob Harrington
c54119f482
Rename stripe controller action from 'deauthorize' to 'webhook'
2017-10-11 17:11:02 +11:00
Rob Harrington
23d2b3a664
Move Stripe webhook logic into dedicated frontend controller
2017-10-11 16:38:19 +11:00
Rob Harrington
c747bb5305
Remove improper use of quick_login_as_admin from unit spec
2017-10-11 16:10:08 +11:00
Matt-Yorkley
d147d2035d
Disable symbol array cop
2017-10-07 11:50:59 +01:00
Maikel Linke
4dd71c1240
Add CSS workaround to display repeated table head
...
Fixes https://github.com/openfoodfoundation/openfoodnetwork/issues/1738
2017-10-06 16:51:19 +11:00
Maikel Linke
6ad7c7b835
Tidy up HTML indent
2017-10-06 14:24:28 +11:00
Maikel Linke
10bbc5f9ef
Hide the menu on embedded group pages
2017-10-06 14:24:28 +11:00
Maikel Linke
b8a124b99e
Add preview page for embedded groups
2017-10-06 14:24:28 +11:00
Maikel Linke
28b1ea2d9f
Allow group pages to be in iframes
2017-10-06 14:24:28 +11:00
Maikel Linke
2b989f49ea
Enable iframes in development environment
2017-10-06 14:24:28 +11:00
Enrico Stano
bdc701f880
Merge pull request #1816 from coopdevs/disable-create-profile-on-submit
...
Disable create profile on submit
2017-10-05 15:25:37 +02:00
Enrico Stano
7af154d675
Merge pull request #1820 from coopdevs/missing-translations-register
...
Missing translations in Enterprise Registration
2017-10-05 13:12:09 +02:00
Pau Perez
2552b5faac
Track node version in .node-version
...
This is used by https://github.com/nodenv/nodenv
2017-09-29 16:11:22 +02:00
Pau Perez
d8e3052575
Ensure a callback function is provided
2017-09-29 16:10:11 +02:00
Transifex-Openfoodnetwork
3c797d3b86
Updating translations for config/locales/es.yml [skip ci]
2017-09-27 00:23:20 +10:00
Transifex-Openfoodnetwork
46ca3bc950
Updating translations for config/locales/fr.yml [skip ci]
2017-09-26 19:51:50 +10:00
Rob Harrington
75ec77dc31
Remove the 'confirm' step from the order checkout flow
...
This step is not being responded to anyway, since we are not rending a page for each checkout step
It was causing an issue whereby an order in the 'confirm' state was not able to progress through the
checkout controller because it was expecting to only redirect to paypal from the 'payment' state.
figured it was easiest to just remove the step, seeing as it wasn't being used in any meaningful way.
It should be fine to bring the 'confirm' step back in the future if we need it, we will just have to
make sure paypal the paypal issue is resolved.
2017-09-23 15:15:06 +10:00
Rob Harrington
a09a54e4cb
Set transaction fee adjustments to ineligible if payment is invalid or failed
2017-09-23 15:15:06 +10:00
Rob Harrington
e486dbd4f8
Respond to Stripe webhook with status of 204 if specified account is not found
2017-09-23 14:58:35 +10:00
Rob Harrington
db5503dd80
Allow destruction of StripeAccounts even if deauthorise request fails
...
Log deauthorise failures to Bugsnag
2017-09-23 14:58:35 +10:00
Rob Harrington
dd3d205536
Update deauthorize webhook to latest version of API (again)
2017-09-23 14:58:35 +10:00
Rob Harrington
90007d7114
Prevent Stripe-based payment methods that are not linked to a StripeAccount from displaying in the checkout
2017-09-23 14:58:35 +10:00
Rob Harrington
7ba99c0fe0
Update Bogus Gateway error message in checkout spec
2017-09-23 14:58:35 +10:00
Rob Harrington
ba61f94906
Expose Stripe token creation error messages in Checkout
2017-09-23 14:58:35 +10:00
Rob Harrington
7c82fa3d44
Show more helpful payment processing error in checkout
2017-09-23 14:58:35 +10:00
Rob Harrington
665749d0c5
Refactor Stripe::AccountConnector
...
Connector now handles cancellation of the connection wizard by the user more elegantly
2017-09-23 14:58:35 +10:00
Rob Harrington
d3566f9303
Update deauthorize webhook to latest version of API
2017-09-23 14:58:35 +10:00
Rob Harrington
7d2deca969
Ensure cart_spec runs in context where backorders are disabled
2017-09-23 14:58:35 +10:00
Rob Harrington
0f19be4db4
Configure StripeElements service to map cc_type to that used by activemerchant
2017-09-23 14:58:35 +10:00
Rob Harrington
393a4efbf6
Fix flaky OrderSerializer spec
...
Make sure that completed payment is for an amount less that the order total
2017-09-23 14:58:35 +10:00
Rob Harrington
34b109cbb7
Add basic validation to credit card form on account page
2017-09-23 14:58:35 +10:00
Rob Harrington
4785f3eacc
Use lowercased cc_type in CreditCard service
2017-09-23 14:58:34 +10:00
Rob Harrington
e14b017f1f
Fix broken Stripe checkout spec
2017-09-23 14:58:34 +10:00
Rob Harrington
d2096cf6d1
Make request stubs less brittle by using regex
2017-09-23 14:58:34 +10:00
Rob Harrington
fbda1a27ad
Add missing translation referenced from spree_auth_devise
2017-09-23 14:58:34 +10:00
Rob Harrington
098afc62c1
Fix rubocop issues
2017-09-23 14:58:34 +10:00
Rob Harrington
1cd1e9dc37
Extract filters for available PMs into service object
2017-09-23 14:58:34 +10:00
Rob Harrington
0bbaafbd41
Use guard clause
2017-09-23 14:58:34 +10:00
Rob Harrington
0e42c1cf30
Refactor ProfileStorer, call options as a separate method
2017-09-23 14:58:34 +10:00
Rob Harrington
620721c8cb
Use find_by_id instead of find in EnterpriseController
2017-09-23 14:58:34 +10:00
Rob Harrington
5cba635783
Add documentation to StripeConnectSettings controller
2017-09-23 14:58:34 +10:00
Rob Harrington
08c723b10f
Use expect syntax instead of should
2017-09-23 14:58:34 +10:00
Rob Harrington
61feb2b27d
Rename Stripe existing_card param key to existing_card_id
2017-09-23 14:58:34 +10:00
Rob Harrington
a2dee8d3d8
Create a Struct for Stripe Connect settings once rather than on each request
2017-09-23 14:58:34 +10:00
Rob Harrington
a74c502fd9
Refactor logic for creating a payment profile from a Stripe token into a service object
2017-09-23 14:58:34 +10:00
Rob Harrington
f6c3a2a46e
Remove new credit card initialisation logic from Spree::UsersController#show
2017-09-23 14:58:34 +10:00
Rob Harrington
4464a85a74
Add missing controller specs for CreditCardController #destroy
2017-09-23 14:58:34 +10:00
Rob Harrington
22bbe29f3d
Call single-use before_filters from actions instead
2017-09-23 14:58:34 +10:00
Rob Harrington
9832966b77
Fix Admin::PaymentsController spec
2017-09-23 14:58:34 +10:00
Rob Harrington
19213a5ca8
Rearrange new card inputs on account page
2017-09-23 14:58:34 +10:00
Rob Harrington
3a0b47c451
Add border to Stripe Elements input, make text larger
2017-09-23 14:58:34 +10:00
Rob Harrington
0cd43987de
Hide Stripe payment methods without a preferred_enterprise_id from the front-end
2017-09-23 14:58:34 +10:00
Rob Harrington
ca1987fc87
Prevent Stripe payment methods without account owners from being saved
2017-09-23 14:58:34 +10:00
Rob Harrington
2f153d799b
Hide 'save credit card' checkbox for guests
2017-09-23 14:58:34 +10:00
Rob Harrington
742dd0b5dd
Clean up jquery dialog styling
2017-09-23 14:58:34 +10:00
Rob Harrington
ecef905444
Allow Stripe-based payments to be voided (refunded)
2017-09-23 14:58:34 +10:00
Rob Harrington
dd56e03be1
Stop setting host for url helpers in specs
2017-09-23 14:58:34 +10:00
Rob Harrington
7b456461f3
Add ng-model directive to save credit card checkbox
...
I have no idea how this was working before\?!\?!\?!
2017-09-23 14:58:34 +10:00
Rob Harrington
e4872172c8
Move PaymentMethodSerializer to correct path
2017-09-23 14:58:34 +10:00
Rob Harrington
2ed5e144ca
Convert problematic embedded shopfronts feature spec into request spec
2017-09-23 14:58:34 +10:00
Rob Harrington
f9df4d4c93
Rewrite js unit specs for Stripe Elements service
2017-09-23 14:58:34 +10:00
Rob Harrington
1aa477c57c
Update feature specs to look for Stripe Elements element
2017-09-23 14:58:34 +10:00
Rob Harrington
69385370ee
Initialize Stripe object only if a publishable_key has been defined
2017-09-23 14:58:34 +10:00
Rob Harrington
65ab83a9a5
Move StripeElements element to an AngularJS directive, mount from there
2017-09-23 14:58:34 +10:00
Rob Harrington
746c2ffef9
Add 'publishable_key' property to Stripe module (enables stubbing)
2017-09-23 14:58:34 +10:00
stveep
6690f2e9e7
Restyle add card form
2017-09-23 14:58:34 +10:00
stveep
74a7cb82bc
Modify to use Stripe Elements to manually add cards in Account page. Remove StripeJS service
2017-09-23 14:58:34 +10:00
stveep
15ed4c32d9
Checkout switched to Stripe Elements from StripeJS
2017-09-23 14:58:34 +10:00
stveep
56ff877b25
Use Stripe Elements instead of StripeJS: https://stripe.com/docs/elements
2017-09-23 14:58:34 +10:00
Maikel Linke
926f196b96
Re-generate rubocop_todo
2017-09-23 14:58:34 +10:00
Maikel Linke
5b7e2f7ca8
Apply style guide
2017-09-23 14:58:34 +10:00
stveep
0a12f78444
Separate files for Payment Method serializers
2017-09-23 14:58:33 +10:00
stveep
da5c907e0f
Add/remove comments from PR feedback
2017-09-23 14:58:33 +10:00
stveep
f065cbe251
Fix specs for saved credit cards: Add payment profile ID to fixture (now denotes that a card has been saved), check for current user to avoid error attempting to inject saved cards as a guest
2017-09-23 14:58:33 +10:00
stveep
511afa0ddc
Bump Stripe gem version
2017-09-23 14:58:33 +10:00
Rob Harrington
d5ab9eb675
Hide option to 'Remember this card' when an existing card is selected
2017-09-23 14:58:33 +10:00
Rob Harrington
cb08011450
Fix typo in Stripe confirm modal
2017-09-23 14:58:33 +10:00
Rob Harrington
41b7be900c
Restrict the meaning of 'Saved Cards' to mean those with a payment profile
2017-09-23 14:58:33 +10:00
Rob Harrington
6133b302af
Use guard clause in PaymentMethodsController#restrict_stripe_account_change
2017-09-23 14:58:33 +10:00
Rob Harrington
4fb1c7fd92
Add 'Stripe is in Beta' warning
2017-09-23 14:58:33 +10:00
Rob Harrington
b31881baa5
Add explanation about configuring Stripe API keys
2017-09-23 14:58:33 +10:00
Rob Harrington
4e96487da9
Redirect to #/payment methods from stripe connect callback
2017-09-23 14:58:33 +10:00
Rob Harrington
98317e96d0
Remove unused stripe action abilities
2017-09-23 14:58:33 +10:00
Rob Harrington
4865533f26
Restrict edit permissions on Stripe payment methods
2017-09-23 14:58:33 +10:00
Rob Harrington
1f8890b430
Use an explicit date format for PaymentsSerializer#updated_at
2017-09-23 14:58:33 +10:00
Rob Harrington
11daf89005
Add admin views for Stripe payment methods
...
These views were pretty much just copied from https://github.com/spree/spree_gateway
2017-09-23 14:58:33 +10:00
Rob Harrington
fab893e60b
Fix paypal source_form view
...
The previous commit broke the selectors used by app/assets/javascripts/spree/backend/paypal_express.js
in the better_spree_paypal_express gem.
We can remove this override of the paypal source_form view when we update better_spree_paypal_express
to a version that includes the following commit:
4360a1fb82
2017-09-23 14:58:33 +10:00
Rob Harrington
a04116466e
Fix js for switching form partial for new admin payments
...
All of the functional changes made in this commit came from a future version of Spree:
8a3a80b08a
2017-09-23 14:58:33 +10:00
Rob Harrington
2f6493bb86
Use ng-cloak for admin/enterprises/edit form
2017-09-23 14:58:33 +10:00
Rob Harrington
589c2a1500
Add a modal to handle explanation of user's responsibilities before redirecting to Stripe
2017-09-23 14:58:33 +10:00
Rob Harrington
8cae874109
Fix styling on jquery dialogs
2017-09-23 14:58:33 +10:00
Rob Harrington
7c406f7c3a
Use hash navigation to direct users to #/payment_methods from Stripe PM
2017-09-23 14:58:33 +10:00
Rob Harrington
862443ed6d
Add hash navigation to admin Enterprise edit view
2017-09-23 14:58:33 +10:00
Rob Harrington
3b78179dea
Ask customer about saving card details used in checkout
2017-09-23 14:58:33 +10:00
Rob Harrington
f317cee9e9
Tweak UI for selecting an existing card at Checkout
2017-09-23 14:58:33 +10:00
Rob Harrington
35912605c3
Include customer name in source attrs for Stripe checkout requests
2017-09-23 14:58:33 +10:00
Rob Harrington
8901af897a
Store card details submitted via checkout
2017-09-23 14:58:33 +10:00
Rob Harrington
ee92f46bd5
Fix stripe request spec by providing en enterprise_id
...
The enterprise_id is used to lookup a StripeAccount which is provided to the Spree::Token#create call in the StripeConnect gateway
2017-09-23 14:58:33 +10:00
Rob Harrington
44ba499ad9
Stub rather than set Stripe api_key in specs
2017-09-23 14:58:33 +10:00
Rob Harrington
44d172f3b4
Mock stripe_account_id for StripeAccount gateway specs
2017-09-23 14:58:33 +10:00
Rob Harrington
d2b6ba4330
Provide a Stripe client_id for StripeAccountsController spec
2017-09-23 14:58:33 +10:00
Rob Harrington
576e4db9be
Authorize StripeAccount#status using the account object
...
Rather than the enterprise
2017-09-23 14:58:33 +10:00
Rob Harrington
692ccf0598
Cleaning up oauth2 extension that is no longer required
...
(We're using Stripes built-in OAuth Libraries instead)
2017-09-23 14:58:33 +10:00
Rob Harrington
ce65a9d063
Bump stripe gem version to 3.0.1
...
Allows us to use the stripe gem's built-in OAuth wrappers, rather than our own
2017-09-23 14:58:33 +10:00
Rob Harrington
ffc99df373
Consolidate Stripe routes/actions into StripeAccountsController
2017-09-23 14:58:33 +10:00
Rob Harrington
5c58d30ca7
Create payment from user-specified payment method when using existing card
2017-09-23 14:58:33 +10:00
Rob Harrington
3efabf5c50
Add translations for Stripe connection flashes
2017-09-23 14:58:33 +10:00
Rob Harrington
919e39f950
Provide a valid enterprise for building redirect path for Stripe Connect callback
2017-09-23 14:58:33 +10:00
Rob Harrington
0e14704572
Kill empty space
2017-09-23 14:58:33 +10:00
Rob Harrington
e9d062a8c2
Use nested module/class definitions instead of compact style
2017-09-23 14:58:33 +10:00
Rob Harrington
f3af36deca
Disable rubocop Style/PredicateName check against override of Spree method
2017-09-23 14:58:32 +10:00
Rob Harrington
ecb78233d9
Use guard clauses where possible
2017-09-23 14:58:32 +10:00
Rob Harrington
a68ae1fe2d
Provide a sensible flash message when CreditCard#destroy action fails
2017-09-23 14:58:32 +10:00
Rob Harrington
28ba05ec6b
Fix Lint/UselessAssignment offences for stripe-connect
2017-09-23 14:58:32 +10:00
Rob Harrington
5b675cbaba
Make OAuth private methods actually private
2017-09-23 14:58:32 +10:00
Rob Harrington
42dd58426e
Auto-correct rubocop offences for stripe-connect
2017-09-23 14:58:32 +10:00
Rob Harrington
c83755f901
Clean up StripeConnect gateway
2017-09-23 14:58:32 +10:00
Rob Harrington
ae2d3d3fd9
Refactoring StripeHelper into service objects
2017-09-23 14:58:32 +10:00
Rob Harrington
e6eb45b453
Name StripeAccountController spec file correctly
2017-09-23 14:58:32 +10:00
Rob Harrington
01ce092ebc
Handle Stripe token creation request failure
2017-09-23 14:58:32 +10:00
Rob Harrington
5d77ef52c5
Replace text strings with variables in stripe request spec
2017-09-23 14:58:32 +10:00
Rob Harrington
e8636c0cbf
Set dummy Stripe API key for front-end credits cards feature spec
2017-09-23 14:58:32 +10:00
Rob Harrington
f890927423
Implementing the Stripe Connect feature toggle
2017-09-23 14:58:32 +10:00
Rob Harrington
6499d17cb1
Adding feature toggle config variable for Stripe Connect
2017-09-23 14:58:32 +10:00
Rob Harrington
1d1e581c85
Refactoring CreditCardController, rendering card processing errors as json
2017-09-23 14:58:32 +10:00
Rob Harrington
64009a2c9e
CheckoutController can render payment gateway error messages as json
2017-09-23 14:58:32 +10:00
Rob Harrington
14f6ea4c01
Adding required Stripe config variables to application.yml.example
2017-09-23 14:58:32 +10:00
Rob Harrington
fdca1f6606
Adding message about having no saved cards to account/cards UI
2017-09-23 14:58:32 +10:00
Rob Harrington
63a15ec392
CreditCardController#destroy redirects to account#/cards
2017-09-23 14:58:32 +10:00
Rob Harrington
356dad73ba
Ensure spec has Stripe.api_key set
2017-09-23 14:58:32 +10:00
Rob Harrington
fb5784fbda
Allow updating of account settings from account tabs interface
2017-09-23 14:58:32 +10:00
Rob Harrington
4ef97aa418
Showing past orders under the orders tab
2017-09-23 14:58:32 +10:00
Rob Harrington
b9d72ce4cf
Refactoring logic for displaying orders on the front-end account page
2017-09-23 14:58:32 +10:00
Rob Harrington
9733bb3a77
Renaming account#history to account#transactions
2017-09-23 14:58:32 +10:00
Rob Harrington
532dc57725
Adding translations for /account tabs
2017-09-23 14:58:32 +10:00
Rob Harrington
f4c3fbf8bc
Refactoring credit cards interface, and backend logic
2017-09-23 14:58:32 +10:00
Rob Harrington
778526af2e
Rewriting styling for new tabs components
2017-09-23 14:58:32 +10:00
Rob Harrington
1aebee0583
WIP: rebuilding accounts page using tabs infrastructure
2017-09-23 14:58:32 +10:00
Rob Harrington
ed5c650456
Writing a new tabset component for front-end tabs
...
Modeled on back-end 'panels' infrastructure
2017-09-23 14:58:32 +10:00
Rob Harrington
b8c6da301c
Removing unnecessary dependencies from OrdersCtrl
2017-09-23 14:58:32 +10:00
Rob Harrington
269a60b36f
Adding request specs for case when using an existing card stored by Stripe for payment
2017-09-23 14:58:32 +10:00
Rob Harrington
25907f97a8
Cleaning up Stripe Connect request spec
2017-09-23 14:58:32 +10:00
Rob Harrington
d1779b9457
Keep timestamps as :null => false in schema
2017-09-23 14:58:32 +10:00
stveep
ddac179f9b
Add translations
2017-09-23 14:58:31 +10:00
stveep
25f48d944c
Add delete links, tidy up UI a bit (WIP), page refresh after adding still doesn't work
2017-09-23 14:58:31 +10:00
stveep
c9c4680ef6
Backend code to create Stripe customers and store their IDs in CreditCards. Page refresh not working
2017-09-23 14:58:31 +10:00
stveep
1449169b16
Basic UI for adding credit card details and getting a Stripe token without making a payment
2017-09-23 14:58:31 +10:00
stveep
c6e50a3f7f
Stub Stripe requests in feature spec
2017-09-23 14:58:31 +10:00
stveep
56295e5ffb
Fix request and feature specs
2017-09-23 14:58:31 +10:00
Rob Harrington
33a3db8698
Making :source attr_accessible for Spree::Payment
2017-09-23 14:58:31 +10:00
stveep
c4f9a5a234
Add code to CheckoutController to construct card attributes when using an existing card (via a818fbbecd/core/app/models/spree/order/checkout.rb:212)
2017-09-23 14:58:31 +10:00
stveep
627899bbd4
spec for source attributes to pass for saved card
2017-09-23 14:58:31 +10:00
stveep
12f4f2d17a
Add some logic to check whether a saved card has been selected before making a request from Stripe
2017-09-23 14:58:31 +10:00
stveep
300dc3084c
Add default card, disable inputs when a card is selected
2017-09-23 14:58:31 +10:00
stveep
50c3d1367d
Tidy up comment
2017-09-23 14:58:31 +10:00
stveep
a1cad82564
Only show credit cards if previously saved, split credit card db migrations and tidy up serializer
2017-09-23 14:58:31 +10:00
stveep
298fd057f5
Check for current user before injecting credit cards
2017-09-23 14:58:31 +10:00
stveep
33b570b117
Inject cards for current user into checkout and add selector dropdown to gateway partial.
2017-09-23 14:58:31 +10:00
stveep
3b05b76b80
Bring in ability to store CreditCards against Users from Spree 2.3 (spree commit d470b31798f3).
2017-09-23 14:58:31 +10:00
Rob Harrington
c97a140471
WIP: Storing Stripe card details for later use
...
NOTE: No interface for actually selecting a stored card to use yet
2017-09-23 14:58:31 +10:00
Rob Harrington
7c831c9844
Adding StripeJS to checkout page
...
Allow tokens to be request and passed through as payment source_attributes
2017-09-23 14:57:02 +10:00
Rob Harrington
5c16fefe41
Creating basic angular StripeJS wrapper service for requesting tokens
2017-09-23 14:57:02 +10:00
Rob Harrington
5ad88f992c
Adding live stripe account status display to payment method create/edit interface
2017-09-23 14:57:02 +10:00
Rob Harrington
f87f4310f0
Adding #status controller action for stripe accounts to fetch current info direct from Stripe
2017-09-23 14:57:02 +10:00
Rob Harrington
987ad0df6c
Very basic Stripe Connect payment method interface
2017-09-23 14:57:02 +10:00
Rob Harrington
d500c20d3f
Adding new StripeConnect payment gateway
2017-09-23 14:57:02 +10:00
Rob Harrington
99a7665edc
Requesting read_write permission when authorizing Stripe standalone account
2017-09-23 14:57:02 +10:00
Rob Harrington
37f60bf7a1
Setting Stripe.api_key in an initializer rather than helper
2017-09-23 14:57:02 +10:00
Rob Harrington
b5a6bcdf9d
Opening up restriction on activemerchant version by updating Spree ref
...
Allows use of v > 1.57 which includes support for Stripe Connect
2017-09-23 14:57:02 +10:00
stveep
858852123d
Add configuration example
2017-09-23 14:57:02 +10:00
stveep
ae72ebef5e
Fix disconnect button formatting
2017-09-23 14:57:02 +10:00
stveep
1450bfd726
Don't retrieve event from Stripe for a deauthorisation
2017-09-23 14:57:02 +10:00
stveep
22e4a50807
Change Stripe webhook handling to post request
2017-09-23 14:57:02 +10:00
stveep
a039286240
Webhook processing changes: fix expected request data formatting
2017-09-23 14:57:02 +10:00
stveep
9ac638f8ba
Fix some leftover refactoring from an earlier modification to enterprises controller (now not needed as moved to admin/enterprises)
2017-09-23 14:57:02 +10:00
stveep
da335703b4
Fix specs for travis
2017-09-23 14:57:02 +10:00
stveep
d374ab569d
Undo dodgy redirect changes and set spec to pending
2017-09-23 14:57:02 +10:00
stveep
47df2dc20b
Tweaking redirects and links
2017-09-23 14:57:02 +10:00
stveep
5c43c75b00
Specify SHA-256 algorithm for JWT in spec fixture
2017-09-23 14:57:02 +10:00
stveep
f83c7a88df
Specify SHA-256 algorithm for JWT
2017-09-23 14:57:02 +10:00
stveep
5ae473e07f
Add specs, fix redirect after requring relogin
2017-09-23 14:57:02 +10:00
stveep
e69b27a3c4
Tidy up (temp) UI a bit
2017-09-23 14:57:02 +10:00
stveep
e52e04ba29
Adding Stripe Connect information so we don't forget it later
2017-09-23 14:57:02 +10:00
stveep
1dcffa790d
Add JWT encoding to state param
2017-09-23 14:57:02 +10:00
stveep
f22278db51
Don't disconnect if the same Stripe account is connected to multiple Enterprises
2017-09-23 14:57:02 +10:00
stveep
0280e04008
Move OAuth2 patching to an initializer
2017-09-23 14:57:02 +10:00
Steve Pettitt
41607c5846
De-associate accounts in response to webhook (not tested with a real deauth request yet)
2017-09-23 14:57:02 +10:00
Steve Pettitt
1c69f2c670
Stripe Helper specs
2017-09-23 14:57:02 +10:00
Steve Pettitt
05a69ff0c6
Worklow to disconnect Stripe from OFN admin interface
2017-09-23 14:57:02 +10:00
Steve Pettitt
758f57a889
Remove CSRF check - doesn't work properly as implemented, but connect request should probably be changed to POST
2017-09-23 14:57:02 +10:00
Steve Pettitt
eed11faa62
Monkey patching OAuth2 gem to include Stripe disconnection method
2017-09-23 14:57:02 +10:00
Steve Pettitt
7fd8c5956d
Check CSRF, allow a Stripe account to be connected to more than one enterprise (but not vice versa)
2017-09-23 14:57:02 +10:00
Steve Pettitt
8ed983cf03
Correct spelling :)
2017-09-23 14:57:02 +10:00
Steve Pettitt
b6292e2723
Add some logic to check for a connected Stripe Account in form
2017-09-23 14:57:02 +10:00
Steve Pettitt
8bdf57d0d9
Add Stripe Connect button (CSS) in admin/enterprises/:id/edit#payment_methods
2017-09-23 14:57:02 +10:00
Steve Pettitt
03f590ccc4
Callback creates a new StripeAccount with id and publishable key.
2017-09-23 14:57:02 +10:00
Steve Pettitt
06279848c6
Stripe auth and callback working. Still need to process callback.
2017-09-23 14:57:02 +10:00
Steve Pettitt
3623325cab
Add missing files
2017-09-23 14:57:01 +10:00
Steve Pettitt
df18329233
Starting Stripe integration
2017-09-23 14:57:01 +10:00
Steve Pettitt
1db0bbef09
Create table for stripe accounts
2017-09-23 14:57:01 +10:00
Rob Harrington
f3322dd82e
Transfer responsibility for checking for orphaned PayPal payments from Payment model to Spree::PayPalController
2017-09-23 14:26:03 +10:00
Rob Harrington
d2d07f0362
Update translation scope for PayPal checkout cancellation message
2017-09-23 14:26:03 +10:00
Rob Harrington
131d9384c2
Use flash.notice instead of flash.success to display order confirmation message
...
This way it overwrites any message that is set from spree, rather than displaying duplicate messages
2017-09-23 14:25:55 +10:00
Rob Harrington
7beb6e624c
Darkswarm flash loader works with :notice flash messages
2017-09-23 14:09:13 +10:00
Maikel Linke
73041e9263
Show shop profiles without closed shops
...
The filter for closed shops was filtering profiles as well. That made it
impossible to show profiles without showing closed shops as well.
Replacing the filter for closed shops fixes the "show profiles" feature.
Fixes https://github.com/openfoodfoundation/openfoodnetwork/issues/1718
2017-09-22 12:53:21 +10:00
Maikel Linke
e600621883
Spec issue 1718
2017-09-22 12:53:21 +10:00
Maikel Linke
0f1fb68ee8
Simplify specs
2017-09-22 12:53:21 +10:00
Maikel Linke
20b2e831e9
Convert specs to RSpec 2.14.4 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/features/consumer/shops_spec.rb
* 6 conversions
from: obj.should
to: expect(obj).to
* 3 conversions
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2017-09-22 12:53:21 +10:00
Rob Harrington
11ccb9a6d2
Revert "Fix for #1826 , ensure that adjustment states are initialized prior to validation"
...
This reverts commit d7de7d462f .
No longer required after we pulled in the correct migrations from Spree
2017-09-22 11:16:29 +10:00
Rob Harrington
074018d2a6
Copy and run adjustment states migration from updated version of spree
...
Note: this migration took 28.7571s to run against Aus production data on my local machine
2017-09-22 11:16:29 +10:00
Rob Harrington
386972db3b
Update spree gem reference
2017-09-22 11:15:59 +10:00
Continuous Integration
4cec7213b5
Merge remote-tracking branch 'origin/master' into HEAD
2017-09-22 10:07:55 +10:00
Rob Harrington
3f3085c66b
Add detailed explanation of why #destroy_orphaned_paypal_payments is required
2017-09-21 12:11:46 +10:00
Rob Harrington
f4b1c5de9c
Remove orphaned PayPalExpress payments when processing actual PayPalExpress payment
...
Fixes both #1074 and #1837
2017-09-21 12:11:39 +10:00
Maikel Linke
ca677a3ccd
Reset I18n.locale to not affect other specs
...
Otherwise spec/models/enterprise_spec.rb fails if run after this.
2017-09-20 13:23:16 +10:00
Maikel Linke
4cdd0831e8
Spec the I18n helper on its own
2017-09-20 13:23:16 +10:00
Maikel Linke
39dc765c63
Add/replace comments and remove useless
2017-09-20 13:23:16 +10:00
Julius Pabrinkis
1fe20eba45
Add backend to be able to switch language by param and persist in cookies and user db
2017-09-20 13:23:15 +10:00
Pierre de Lacroix
72d264fab9
Make "on demand" columns visible by default
...
on admin "bulk product edit" and "inventory" (variant overrides) tables
2017-09-15 16:09:26 +10:00
Pau Perez
f50e745826
Change title when navigating to new product page
...
We navigate to it by replacing the content of the page through an ajax
call, so we also need change the section title with JS.
2017-09-15 10:09:25 +10:00
Maikel
949faa7fde
Merge pull request #1789 from coopdevs/missing-translations-order-cycle-page
...
Missing translations order cycle page
2017-09-14 18:12:28 +10:00
Pau Perez
96e31235da
Replace hardcoded strings with i18n keys
2017-09-14 17:31:52 +10:00
Pau Perez
e217f96454
Use Rails lazy lookup for translation keys
...
See "lazy" lookup in
http://guides.rubyonrails.org/i18n.html#abstracting-localized-code
2017-09-14 17:31:52 +10:00
Rob Harrington
3aa50ed38f
Attempt to fix intermittent fail in product_import_spec
2017-09-14 14:02:09 +10:00
Rob Harrington
d7de7d462f
Fix for #1826 , ensure that adjustment states are initialized prior to validation
2017-09-14 13:39:22 +10:00
Rob Harrington
4c238748c6
Prevent accordion controllers from showing missing nextPanel
...
Resolves this issue:
https://travis-ci.org/oeoeaio/openfoodnetwork/jobs/273323915
2017-09-11 11:07:31 +10:00
Rob Harrington
2c65218ce3
Bumping spree version to remove kaminari duplicate from gemspec
2017-09-09 00:40:15 +10:00
Pau Perez
613016a6cf
Refactor spec using expect_any_instance
2017-09-08 23:55:51 +10:00
Pau Perez
1899e2fa98
Fix rubocop failures
2017-09-08 23:55:51 +10:00
Pau Perez
c7608c6f44
Fix flaky integration test
...
This removes a pointless expectation in a before block and refactors the
test in expect-style.
2017-09-08 23:55:51 +10:00
Pau Perez
0349e2026b
Upgrade spree sha
2017-09-08 23:55:51 +10:00
Pau Perez
a763c24f3c
Doc what with_lock does
2017-09-08 23:55:51 +10:00
Pau Perez
1faa1579f3
Update enterprise fees while locking the order
2017-09-08 23:55:51 +10:00
Pau Perez
630e61ee5a
Go back to the Spree's branch we use for step6
...
The fix introduced with https://github.com/coopdevs/spree/pull/2 was
already merged so we can point back to the `spree-upgrade-step-6`
branch.
2017-09-08 23:55:51 +10:00
Pau Perez
47468df2a5
Fix js unit tests
2017-09-08 23:55:51 +10:00
Pau Perez
5b1947429e
Fix odd-even background by relying on Spree
...
This removes unnecessary duplication of #destroy. We can make it work by
adding a simple fix in Spree.
2017-09-08 23:55:50 +10:00
Pau Perez
8db1fa4e77
Move JSON line items responses to a new controller
...
Extracts the JSON response from the admin's line item controller which
are only used by the bulk management feature into its own controller.
This decouples spree from an OFN-only feature and allows to remove
unnecessary code. Furthermore, Admin::LineItemsController is gone in
Spree 2.4.0.beta. See: https://github.com/spree/spree/pull/5280
2017-09-08 23:55:50 +10:00
Pau Perez
b3c94fd688
Revert "Load order also on open and close adjustments"
...
This reverts commit d77588431aa26422e2956fd3510a20b35dab1b1c.
2017-09-08 23:55:50 +10:00
Enrico Stano
7a33b9cea7
Backport latest Spree changes from coopdevs/spree
2017-09-08 23:55:50 +10:00
Pau Perez
4d94b65d25
Load order also on open and close adjustments
...
@order is not loaded by Spree because we overrode the :before_filter in
spree/admin/orders_controller_decorator.rb. We need to also specify so in the
decorator.
2017-09-08 23:55:50 +10:00
Enrico Stano
d27b8f8fcb
Add spree_auth_devise initializer
2017-09-08 23:55:50 +10:00
Enrico Stano
fe7d3b0d58
Revert "Use older spree_auth_devise"
...
This reverts commit 2f63fb16f36c96c793d5aba1889a274315ccdf00.
2017-09-08 23:55:50 +10:00
Enrico Stano
318f89f9a2
Use older spree_auth_devise
2017-09-08 23:55:50 +10:00
Pau Perez
7e5e167215
Create a mail method when inserting seed data
2017-09-08 23:55:50 +10:00
Enrico Stano
665acdef8f
Backport fix for hidden input tag
...
https://github.com/coopdevs/spree/pull/1
2017-09-08 23:55:50 +10:00
Enrico Stano
d8e17231ec
Revert "Order email translation keys"
...
This reverts commit dc30e0b1042602ed8f03fe97444ccce8526e51b3.
2017-09-08 23:55:50 +10:00
Enrico Stano
ff2b2e17d9
Order email translation keys
2017-09-08 23:55:50 +10:00
Rob Harrington
4b89a1d736
Fix Layout/EmptyLinesAroundClassBody offence in ResetOrderService
2017-09-08 23:55:50 +10:00
Rob Harrington
595d7b5594
Remove conditional assignment from PaymentsController#fire decorator
2017-09-08 23:55:50 +10:00
Enrico Stano
bc62ad5797
Fix spec
2017-09-08 23:55:50 +10:00
Enrico Stano
3b8cab9392
Revert "Fix removal of producer properties - remove href attr so Spree doesn't attempt an XHR"
...
This reverts commit 8126161df2b96f9cec5c34ffaefa093fe5aed858.
2017-09-08 23:55:50 +10:00
Enrico Stano
9aca5459b7
Revert "Fix removal of product properties"
...
This reverts commit 3b94e12f8db0d4d2b2e48c085fab8231ec8e86e8.
2017-09-08 23:55:50 +10:00
Enrico Stano
819a003f26
Backport Spree fix for product properties delete icon
...
fea76b907b
2017-09-08 23:55:50 +10:00
Pau Perez
3a9b71bd1f
Add doc to methods and classes [skip ci]
2017-09-08 23:55:50 +10:00
Enrico Stano
62c5ccf904
Address CodeClimate complains
2017-09-08 23:55:50 +10:00
Enrico Stano
2f3f20e433
Remove html_safe and add spec
2017-09-08 23:55:50 +10:00
Pau Perez
85fefcd946
Replace helper with service object
2017-09-08 23:55:50 +10:00
Pau Perez
e087a008c2
Reduce coupling from controller
2017-09-08 23:55:50 +10:00
Pau Perez
4c4969e86b
Do not couple with controller's ivar and session
2017-09-08 23:55:50 +10:00
Pau Perez
f6c8a11b7b
Move ResetOrderService to new app/services
2017-09-08 23:55:50 +10:00
Pau Perez
1ef4bf5da0
Refactor tests and remove duplicated ones
2017-09-08 23:55:50 +10:00
Pau Perez
a18bf4b666
Add unit tests for service object
2017-09-08 23:55:50 +10:00
Pau Perez
bdfd718c51
Use service object directly from controller
2017-09-08 23:55:50 +10:00
Pau Perez
3c73282d57
Manually reset the order once completed
...
Spree does not call after_<order.state> methods any more as of
https://github.com/spree/spree/pull/2557 , so our #after_complete method
is never triggered and thus the order never reset.
This makes the condition:
```ruby
if current_order.andand.distributor == @order.distributor
```
in app/views/spree/orders/form/_update_buttons.html.haml return false
and as a result the "Back To Cart" button is not shown.
This commit resets the order (emptying the session[:order_id] and
creating a new order, aka. cart) right from the
CheckoutController#update rather than relying on infernal callbacks (of
what the Spree core team itself was unhappy about since long ago
https://github.com/spree/spree/issues/2488 ). There is the first place
where we know the order has been successfully completed.
2017-09-08 23:55:50 +10:00
Enrico Stano
d09e0cd44a
Deal with both JS and JSON format
2017-09-08 23:55:50 +10:00
Enrico Stano
d581fc4863
Fix specs to contemplate XHR requests and more coverage
2017-09-08 23:55:50 +10:00
Enrico Stano
790bc5b187
Use JS format for #update
2017-09-08 23:55:50 +10:00
Pau Perez
f0e2d426c3
Fix getting HTML when deleting line item in admin
...
In the step 6 of the spree upgrade, when deleting an order's line item
from /admin we get an HTML response (the whole edit form) that gets
inserted into the flash error.
It's not 100% clear why we added a respond_to block for JSON but since
juery-rails sends ajax requests with application/javascript, */* in
the ACCEPTS request header, Rails falls back to the first specified respond_to
block, which is HTML. We don't hit the JSON block.
In order for this to work, this commit replaces the JSON respond_to
block with one for JS with the exact same behaviour; returning a 204.
This is also the format the spree controller action we duplicated originally
has besides HTML.
2017-09-08 23:55:50 +10:00
Pau Perez
8c56bd23fc
Add missing translation
2017-09-08 23:55:50 +10:00
Enrico Stano
6254dfde11
Backport Spree commit to fix PaymentMethodsController #create
2017-09-08 23:55:50 +10:00
Enrico Stano
49d96206e1
Add missing email i18n key
2017-09-08 23:55:50 +10:00
Enrico Stano
ce562889a9
Update js and css assets
2017-09-08 23:55:50 +10:00
Enrico Stano
5a2c3f5c5c
Set Spree configuration related to locales before the promo environment gets initialized
2017-09-08 23:55:50 +10:00
Enrico Stano
7874d96003
Set MailMethod for test environment when needed
2017-09-08 23:55:50 +10:00
Enrico Stano
8e5b94b5ca
Fixing orders controller issue by setting data up correctly
2017-09-08 23:55:49 +10:00
Enrico Stano
4a989f705b
No more order.payment
2017-09-08 23:55:49 +10:00
Rob Harrington
3e6e3173ee
Fixing line item controller issue by setting data up correctly
2017-09-08 23:55:49 +10:00
Enrico Stano
72292b1dd3
Use new state API instead of locked
...
be554fde9f
2017-09-08 23:55:49 +10:00
enricostano
6816061915
Fix confirmation email subject
...
c38537173f
2017-09-08 23:55:49 +10:00
enricostano
23585e6ea8
Initialize custom calculators using Spree API
...
Freely inspired by https://github.com/coopdevs/spree/blob/2-0-stable/core/lib/spree/core/engine.rb#L78
2017-09-08 23:55:49 +10:00
enricostano
cf4bd8d755
WIP Preparing to get rid of MailMethod model
...
Please give a look at the following links:
- http://guides.spreecommerce.org/release_notes/spree_2_0_0.html#mailmethod-model-no-longer-exists
- https://github.com/spree/spree/pull/2643
2017-09-08 23:55:49 +10:00
enricostano
22b5431279
Start spree upgrade step 6
2017-09-08 23:55:49 +10:00
enricostano
4e35c0448b
Use the state machine API to add state transition callbacks
...
See the following links for more context:
http://guides.spreecommerce.org/release_notes/spree_2_0_0.html#removal-of-checkoutcontrollerstatecallback
1d9581c884
2017-09-08 23:55:49 +10:00
enricostano
fd259e0a63
Use cherry-picked commit in spree fork from the future 🚀
...
2aee282d6d
2017-09-08 23:55:49 +10:00
enricostano
e7ecdcc251
Import schema migration for spree gem upgrade step 5
2017-09-08 23:55:49 +10:00
Em-AK
a70cdaadb6
Start spree upgrade step 5
2017-09-08 23:55:49 +10:00
enricostano
d8c227c43f
Import data migration from latest spree_paypal_express gem
2017-09-08 23:55:49 +10:00
enricostano
a87c89c83d
Require authentication for API endpoints
...
Authentication and authorization layers (cancan) should not be mixed
c594d6111b
2017-09-08 23:55:49 +10:00
Em-AK
6817ac0d79
Regenerate knapsack report on my slow machine
2017-09-08 23:55:49 +10:00
enricostano
c439a23ef9
Adapt CheckoutController to new Spree changes
...
Freely inspired by ad5551bf84
2017-09-08 23:55:49 +10:00
enricostano
a80d75e7e2
Fix Spree taxons route reference
2017-09-08 23:55:49 +10:00
enricostano
d2b6a47ae4
Use new #available_to_order API
2017-09-08 23:55:49 +10:00
enricostano
5ad0f8bb2e
Fix module namespace
2017-09-08 23:55:49 +10:00
enricostano
a9966f48af
Use new product_search method
2017-09-08 23:55:49 +10:00
Em-AK
b5bac722ca
Fix: make rspec run
2017-09-08 23:55:49 +10:00
Em-AK
8a42b606eb
Start spree upgrade step 4
2017-09-08 23:55:49 +10:00
Em-AK
31f2551116
Update the JS unit spec to the new endpoint
2017-09-08 23:55:49 +10:00
enricostano
c992095959
Use new /clone JSON endpoint
2017-09-08 23:55:49 +10:00
enricostano
513330cfff
Add JSON api for products clone
2017-09-08 23:55:49 +10:00
Em-AK
1136cb40a9
Revert to OFN spree fork
...
This reverts commit 92f50d96803f9d0f302be51aad085c9a68ec4c32.
And bundle update to the last commit of openfoodfoundation/spree, branch: spree-upgrade-step-3
2017-09-08 23:55:49 +10:00
Em-AK
e73330d597
Fix removal of product properties
...
Prevent spree to make a post request on deletion of a property
The data should be updated on the server by clicking on the Update
button
2017-09-08 23:55:49 +10:00
Em-AK
f22a12d657
Revert later: depend on our spree fork
2017-09-08 23:55:49 +10:00
Em-AK
d68104cecb
Update a dependency to run the specs
2017-09-08 23:55:49 +10:00
Em-AK
5eb42eac3c
Delete the override of a deleted field
...
https://github.com/openfoodfoundation/spree/compare/spree-upgrade-step1c...spree-upgrade-step-3#diff-a63d9d7f4c1375ca141931651f799956
2017-09-08 23:55:49 +10:00
Rohan Mitchell
ac8cfe24e6
Fix removal of producer properties - remove href attr so Spree doesn't attempt an XHR
2017-09-08 23:55:49 +10:00
Rohan Mitchell
bfaaf16030
Fix spree adjustments fix that maybe never worked?
2017-09-08 23:55:49 +10:00
Rohan Mitchell
c47af55bb9
Fix: When a user fires an event (eg. capture payment), take them back to where they came from
2017-09-08 23:55:49 +10:00
Rohan Mitchell
3ff051f238
Restore route for variant search. Fixes admin order product selection.
2017-09-08 23:55:49 +10:00
Rohan Mitchell
0a8e8dfbbb
Add specs and fix line items HTML response
2017-09-08 23:55:49 +10:00
Rohan Mitchell
1170897587
Add our own JSON handling actions for update and delete. Spree no longer does this for us.
2017-09-08 23:55:48 +10:00
Rohan Mitchell
73abb93737
Update Spree: Bring forward simplified version of Spree.t for spree_auth_devise
2017-09-08 23:55:48 +10:00
Rohan Mitchell
0a043a6919
Add permissions to :line_item resource, now called by Spree
2017-09-08 23:55:48 +10:00
Rohan Mitchell
2c374b448a
check_authorization removed in Spree. Add load_order before_filter to cover our custom actions.
2017-09-08 23:55:48 +10:00
Rohan Mitchell
2a44b190fe
Use spree_paypal_express 2-0-stable pretending to be 1.3
2017-09-08 23:55:48 +10:00
Rohan Mitchell
3605b610fe
Use spree_auth_devise 2-0-stable pretending to be 1.3
2017-09-08 23:55:48 +10:00
Rohan Mitchell
0219118e19
Admin JS/CSS now in spree_backend
2017-09-08 23:55:48 +10:00
Rohan Mitchell
5ad197278c
Fix rendering of order form for JSON requests
2017-09-08 23:55:48 +10:00
Rohan Mitchell
3135ef6b7f
Reinstate explicit class name Spree::Calculator on calculated_adjustments association
2017-09-08 23:55:48 +10:00
Rohan Mitchell
0446b8d72f
TestingSupport moved out of Core namespace
2017-09-08 23:55:48 +10:00
Rohan Mitchell
858576d870
CalculatedAdjustments requires include first
2017-09-08 23:55:48 +10:00
Rohan Mitchell
48e50540db
Start Spree upgrade step 3
2017-09-08 23:55:48 +10:00
Rohan Mitchell
8eca260297
Update Spree: Prevent duplicate copies of images appearing
2017-09-08 23:55:48 +10:00
Rohan Mitchell
017b63fa71
Update Spree: Fix further admin authorization errors
2017-09-08 23:55:48 +10:00
Rohan Mitchell
efe0d3ab22
Update spree, upgrading jquery-rails to provide jquery 1.9. Fixes ng-tags-input.
2017-09-08 23:55:48 +10:00
Rohan Mitchell
bfd54ef621
Update Spree: Fix admin authorization errors
2017-09-08 23:55:48 +10:00
Rohan Mitchell
38da4c8e12
Adjustments now have state instead of locked/unlocked
2017-09-08 23:55:48 +10:00
Rohan Mitchell
b5d33fc4b5
Add migrations from Spree
2017-09-08 23:55:48 +10:00
Rohan Mitchell
f5c4537afa
Start Spree upgrade step 2
2017-09-08 23:55:48 +10:00
Saimon Moore
09aed63cd4
Add todos to remove redundant i18n keys
2017-09-08 13:57:50 +02:00
Saimon Moore
757f886af5
Use proper namespaced translations
...
... in enterprise registration wizard Type step
2017-09-08 13:35:19 +02:00
Saimon Moore
f73f0d4bf9
Use proper namespaced translations
...
... in enterprise registration wizard Details step
2017-09-08 12:50:54 +02:00
Saimon Moore
d4f7efd08a
Use proper namespaced translations
...
... in enterprise registration wizard Contact step
2017-09-08 12:49:08 +02:00
Saimon Moore
a1aac7643a
Translate Entp registration modal tab titles
...
- Add proper namespaced translations for Details and Contact tabs
2017-09-08 12:47:53 +02:00
Enrico Stano
36022fb143
Merge pull request #1815 from leandroalemao/missing-translations-edit-product-page
...
Fix i18n translation keys for Edit Product Page
2017-09-08 10:57:25 +02:00
leandroalemao
c70de9f73c
Fix i18n translation keys for Edit Product Page
2017-09-08 09:27:20 +01:00
Pau Perez
d3d4628e29
Add doc
2017-09-08 09:51:06 +02:00
Pau Perez
942ab55ddc
Disable create profile from signup when submitting
...
This prevents people re-submitting the form multiple times. Although the
backend validates it, we show an ugly alert message that is hard for
users to understand.
2017-09-07 16:02:06 +02:00
Enrico Stano
86460ffbde
Merge pull request #1792 from leandroalemao/missing-translations-new-product-page
...
Fix i18n translation keys for New Product Page
2017-09-04 16:07:15 +02:00
Leandro C
90d1d5400a
Fix i18n translation keys for New Product Page
2017-09-04 13:38:33 +01:00
Pau Perez
1b151ee015
Add missing translations in registration wizard
2017-09-01 14:57:16 +02:00
Enrico Stano
3a04136705
Merge pull request #1758 from coopdevs/simplify-karma-rake-task
...
Always execute local karma
2017-08-28 10:21:41 +02:00
Maikel
880fda7b40
Merge pull request #1775 from openfoodfoundation/transifex
...
Transifex
2017-08-25 16:48:51 +10:00
Enrico Stano
67b992cf44
Merge pull request #1771 from coopdevs/feature/add-enterprise-relationhips-tab-name
...
Translate Enterprise Relationships tab name
2017-08-23 17:40:37 +02:00
Transifex-Openfoodnetwork
a1a2a66d21
Updating translations for config/locales/fr.yml [skip ci]
2017-08-21 06:20:59 +10:00
Transifex-Openfoodnetwork
0117e2e8b5
Updating translations for config/locales/es.yml [skip ci]
2017-08-19 02:22:36 +10:00
Enrico Stano
8645b4a7f6
Translate Enterprise Relationships tab name
2017-08-18 16:40:32 +02:00
Matt-Yorkley
a76b64b80b
Spec for missing password confirmation
2017-08-18 13:59:54 +10:00
Matt-Yorkley
483db2bc29
Fix signup password confirmation
2017-08-18 13:59:54 +10:00
stveep
bd3f626872
Call toScroll after any new panel is . Also added an actual delay as it still scrolled to the 'old' location.. 10 ms was too short to allow the location to update after the old panel closes (on Chrome), 50 ms seems ok.
2017-08-18 10:51:48 +10:00
Continuous Integration
2650dc209e
Merge remote-tracking branch 'origin/master' into HEAD
2017-08-12 20:52:20 +10:00
Julius Pabrinkis
efd3c34a0c
Change JS I18n.fallbacks to be less confusing
2017-08-12 11:21:47 +01:00
Julius Pabrinkis
3e01636f77
Add missing i18n-js partial to registration layout
2017-08-12 11:20:58 +01:00
Pau Perez
f9c0edf4b9
Always execute local karma
...
This ensure the dev will run the version specified in the package.json.
Besides, makes the rake task work as all rails tests, allowing you to
pass a RAILS_ENV.
2017-08-11 16:48:24 +02:00
Enrico Stano
58d7d8f016
Merge pull request #1753 from coopdevs/complete-seed-data
...
Complete seed data to purchase to Enterprise 2
2017-08-11 15:42:03 +02:00
Enrico Stano
1fbb4b25d1
Merge pull request #1746 from oeoeaio/fix-flash-error-color
...
Fix styling of error flash in admin section
2017-08-11 11:45:31 +02:00
Continuous Integration
b43b92dcfd
Merge remote-tracking branch 'origin/master' into HEAD
2017-08-11 18:16:25 +10:00
Pau Perez
649c25622a
Add doc to method
2017-08-11 14:41:02 +10:00
Pau Perez
1f2820f6d4
Add #delivery? in ShippingMethod
2017-08-11 14:41:02 +10:00
Pau Perez
22f018f2bc
Fix all specs of LastUsedAddress
2017-08-11 14:41:02 +10:00
Pau Perez
8c5ac4cb23
Fix extra empty line reported by rubocop
2017-08-10 11:35:26 +02:00
Lynne
b9ff5674af
Correction for Transifex name mismatch
2017-08-04 16:18:57 +01:00
Lynne
f0968109c6
Copy transifex updates to en-GB
2017-08-03 20:33:26 +01:00
Transifex-Openfoodnetwork
eeb41ccfdd
Updating translations for config/locales/en_GB.yml [skip ci]
2017-08-04 04:30:40 +10:00
Continuous Integration
587a53d36d
Merge remote-tracking branch 'origin/master' into HEAD
2017-08-04 03:56:40 +10:00
Transifex-Openfoodnetwork
ec7b7e0391
Updating translations for config/locales/sv.yml [skip ci]
2017-08-03 17:43:53 +10:00
Pau Perez
7f982c0c90
Complete seed data to purchase to Enterprise 2
2017-08-02 13:11:41 +02:00
Rob Harrington
6c71ef8760
Fix styling of error flash in admin section
2017-08-02 19:50:18 +10:00
Enrico Stano
936355d54b
Merge pull request #1681 from coopdevs/release-notes-in-template
...
Add release notes section in github template
2017-08-02 10:59:30 +02:00
Enrico Stano
07620c2e62
Merge pull request #1707 from oeoeaio/mirror-db-session-data
...
Exclude session data when mirroring data
2017-08-02 10:45:46 +02:00
Maikel Linke
686a8f3af9
Add legacy and default values for LOCALE
...
This makes sure there is a value in `config.i18n.available_locales` so
that i18n-js doesn't crash.
2017-08-02 10:44:55 +10:00
Maikel Linke
199bfe531e
Correct typo in comment
2017-08-02 10:01:12 +10:00
Julius Pabrinkis
e4627fe0d0
Update README
2017-08-02 09:57:33 +10:00
Julius Pabrinkis
ec6a365227
Add test coverage for switching language in darkswarm and admin
2017-08-02 09:57:33 +10:00
Julius Pabrinkis
c6f6f5bc55
Adapt karma js tests for i18n-js
2017-08-02 09:57:33 +10:00
Julius Pabrinkis
5166a3d958
Add available_locales config feature
2017-08-02 09:57:33 +10:00
Julius Pabrinkis
9429695e15
Add i18n helper for controllers to switch language by params
2017-08-02 09:57:32 +10:00
Julius Pabrinkis
f396d30747
Render i18n-js config inside darkswarm and admin layouts
2017-08-02 09:57:32 +10:00
Julius Pabrinkis
2637574c93
Require new i18n-js translations in darkswarm and admin
2017-08-02 09:57:32 +10:00
Julius Pabrinkis
d2ba4650e5
Add temporary i18n-js workaround for Spree translations until upgrade
2017-08-02 09:57:32 +10:00
Julius Pabrinkis
3adb13e62c
Add i18n-js gem
2017-08-02 09:57:32 +10:00
Transifex-Openfoodnetwork
f69d86ab8f
Updating translations for config/locales/nb.yml [skip ci]
2017-07-31 20:50:37 +10:00
Rob Harrington
7c0feab08f
Fix #1526 : add descriptions for reports *before* they are filtered
2017-07-28 17:15:57 +10:00
Matt-Yorkley
ea784d6362
Invoice date and translation adjustments
2017-07-28 16:34:43 +10:00
Maikel
6e57f917d2
Merge pull request #1736 from oeoeaio/fix-zeus-crash
...
Fix zeus issue caused by location of iframe_test.html
2017-07-28 16:31:41 +10:00
Maikel Linke
ba97f61c9e
Move translations into right scope
2017-07-28 15:23:18 +10:00
Maikel Linke
c5eca68d79
Remove unused translation
2017-07-28 15:23:18 +10:00
Maikel Linke
92814162dc
Remove unused translation
2017-07-28 15:23:18 +10:00
Maikel Linke
44374e8499
Display "+1 More" correctly
2017-07-28 15:23:18 +10:00
Rob Harrington
2ca04bb84e
Revert translations of LettuceShare report headers
2017-07-28 12:07:58 +10:00
Rob Harrington
66a85bb99f
Revert translations of Xero report headers
2017-07-28 12:07:52 +10:00
Rob Harrington
9f6931ba18
Move embedded shopfronts iframe view into spec/support/views
...
Was causing issues with zeus where it was (in spec/dummy)
Didn't get to the bottom of what was happening, this was
just a quick, simple and zero-cost solution
2017-07-28 11:54:48 +10:00
Rob Harrington
8fe6800151
Add documentation to the top of mirror_db script
2017-07-27 12:58:54 +10:00
Rob Harrington
e86122cb3e
Exclude session data when mirroring data
...
Probably a better long term solution would be to add a job to clean
up old session data on the server, but this is a quick & dirty fix
to speed mirroring up on a slow connection.
2017-07-27 12:58:54 +10:00
Laura Turk
7641dcc1be
Add media query to panepadding mixin
2017-07-26 16:29:44 +10:00
Leta Keane
8648070a05
Add disabled class to shopfront property selectors
2017-07-26 15:46:00 +10:00
Matt-Yorkley
5200937165
Safari/iOS iframe issue fix
2017-07-26 13:56:36 +10:00
Matt-Yorkley
6215777986
Shopfront review adjustments
2017-07-26 13:56:36 +10:00
Matt-Yorkley
0eb4c7f7ba
Require https for embedding sites
2017-07-26 13:56:36 +10:00
Matt-Yorkley
782a812596
Basic Embedded Shopfronts
2017-07-26 13:56:36 +10:00
Matt-Yorkley
113f6565be
Enable iframes for embedded shopfronts
2017-07-26 13:56:36 +10:00
Maikel Linke
b1452f097d
Add spanish translations manually
...
A change in the Transifex API made the automated commit fail. Hence
doing it manually here.
2017-07-26 13:38:35 +10:00
Transifex-Openfoodnetwork
6384b5abb3
Updating translations for config/locales/fr.yml [skip ci]
2017-07-26 13:38:35 +10:00
Transifex-Openfoodnetwork
2c14ed848f
Updating translations for config/locales/nb.yml [skip ci]
2017-07-26 13:38:35 +10:00
Maikel Linke
5dfac10599
Mention upgrade_bundler.sh in README
2017-07-26 13:37:42 +10:00
Maikel Linke
250062bd2f
Upgrade bundler according to Gemfile.lock on CI
2017-07-26 13:37:42 +10:00
Maikel Linke
3f2299e52e
Add script to upgrade bundler to Gemfile version
...
Useful to sync your bundler version or the CI bundler version with the
rest of the team.
2017-07-26 13:37:42 +10:00
Rob Harrington
327753b7ca
Remove zeus and guard-zeus from the bundle
...
Having guard-zeus specified as a dependency is problematic because
it also pulls in the zeus gem as a dependency. This makes it impo-
ssible to update or switch zeus versions locally without affecting
other developers.
The maintainers of zeus say that it is designed to be installed and
run outside of the bundle: https://github.com/burke/zeus
2017-07-26 13:36:58 +10:00
Matt-Yorkley
ba447b547d
Order tooltip localisation
2017-07-26 13:36:16 +10:00
Matt-Yorkley
8ebd49ec0f
Company number localisation
2017-07-26 13:35:46 +10:00
Maikel Linke
155a2574bb
Fix typo to display email address
2017-07-21 12:17:14 +10:00
Maikel Linke
b8c2e54194
Fix i18n key and spec
2017-07-21 12:17:14 +10:00
Maikel Linke
9f243e6d3c
Fix title of /admin/content/edit
...
Spree uses the global i18n key `contents` to print the title. A previous
change made that an object containing other i18n keys which was then
displayed as title.
This change moves the i18n content to the scope of the view where they
are displayed.
2017-07-21 12:17:13 +10:00
Maikel Linke
ece8d8b518
Fix typo to display "Producer signup page"
2017-07-21 12:17:13 +10:00
Maikel Linke
0624c49a4f
Fix typo to display "Tax Rates" report
2017-07-21 12:17:13 +10:00
Maikel Linke
71742a80b5
Make two more strings translatable
2017-07-21 12:17:13 +10:00
Maikel Linke
f4b1667005
Replace global translations by local ones
2017-07-21 12:17:13 +10:00
Maikel Linke
e5c9845b10
Remove duplicate haml code
2017-07-21 12:17:13 +10:00
Maikel Linke
d3fc89f42a
Unify haml code for colouring
2017-07-21 12:17:13 +10:00
Maikel Linke
9c6454b47a
Remove duplicated code
...
A label was accidentally inserted twice. Also removed some duplicate
translation.
2017-07-21 12:17:13 +10:00
Maikel Linke
7d2484c8bf
Remove superfluous string interpolation
2017-07-21 12:17:13 +10:00
Maikel Linke
9723c8b82b
Move translation into the right place
...
The dashboard couldn't find a translation, because it is in the spree
namespace.
Also simplified the translation using the `count` feature.
2017-07-21 12:17:13 +10:00
Julius Pabrinkis
8b2b51d511
Fix code style for Rubocop
2017-07-21 12:17:13 +10:00
Julius Pabrinkis
872a150c7d
Refactor some translations to use interpolation
2017-07-21 12:17:13 +10:00
Julius Pabrinkis
3a0c0fd638
Fix failing tests
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
739d06cf03
Extract translations from javascript
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
9fa7a30c7e
Fix failing tests and extract validation message Procs into methods
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
ba0b17e168
Extract translations from controllers
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
5caaec8ef3
Extract translations from mailers and helpers
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
9971c9f923
Extract translations from models
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
974099747b
Fix failing specs after text extraction
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
1920ee7e88
Extract translations from serializers and overrides
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
55b2c19b64
Extract translations from lib folder
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
60060a7017
Start admin/reports extract translations
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
ef488133e8
Add missing translations from files list.
2017-07-21 12:17:12 +10:00
clairezed
5c66a2fc9d
Fix wrong key replacement for producer_shop_description_text
2017-07-21 11:15:03 +10:00
clairezed
5f8890e963
update producers pack translation key from sell_description_text to producer_shop_description_text
2017-07-21 11:15:03 +10:00
clairezed
58c463497a
#1541 fixing wrong translation key in producers packs
2017-07-21 11:15:03 +10:00
Rob Harrington
3bb6d68adf
Exclude node_modules from rubocop analysis
...
I don't need to see offences for node modules when I run rubocop locally
2017-07-21 11:06:16 +10:00
Duende13
705295049e
Improved test for variant serializer
2017-07-21 10:18:55 +10:00
Duende13
a07fd854f6
New test for variant serializer
2017-07-21 10:18:55 +10:00
Duende13
b2bae242d9
Sorting variants by name_to_display and unit_value. Issue 1604.
2017-07-21 10:18:55 +10:00
Maikel Linke
1a57a0b3ca
Revert changes in fr.yml
2017-07-19 09:46:23 +10:00
François Turbelin
a0595bc45a
Add missing translations on views
2017-07-19 09:45:11 +10:00
Enrico Stano
8853340fa1
Merge pull request #1655 from oeoeaio/update-eventmachine
...
Bump eventmachine version to resolve openssl issue on macOS
2017-07-13 13:04:28 +02:00
Enrico Stano
bde3fa4ce6
Merge pull request #1671 from coopdevs/multiline-method-calls
...
Use indented style for multiline method calls
2017-07-12 18:40:34 +02:00
Pau Perez
cee24dcca7
Use indented style for multiline method calls
...
This enables the Rubocop's Style/MultilineMethodCallIndentation cop with
indentend enforced style. Which makes you split multiline method calls like:
orders = Spree::Order
.an_scope
.another_scope
.where(id: list_of_ids)
It also autofixes the current violations and updates the
rubocop_todo.yml
2017-07-12 10:40:53 +02:00
Pau Perez
c1789c4833
Add release notes section in github template
...
Hopefully, this will make it easier for Kirsten to fill in the release
notes from all the pull requests included in a release.
2017-07-12 08:26:45 +02:00
Maikel
6fbf902562
Merge pull request #1680 from mkllnk/entreprise-typo
...
Correct typo raised by Sergi
2017-07-12 15:14:06 +10:00
Maikel Linke
dc0da6f7b7
Correct typo raised by Sergi
2017-07-12 14:40:44 +10:00
Pau Perez
385847d7da
Doc why FinalizeAccount uses order objects
...
Read the top-level class documentation for the details.
2017-07-12 11:49:04 +10:00
Rob Harrington
9d7f63db42
Bump eventmachine version to resolve openssl issue on macOS
2017-07-12 11:42:15 +10:00
Pau Perez
d0c6292e9d
Add github template for pull requests
2017-07-07 13:56:12 +10:00
Matt-Yorkley
994023ec10
Update codeclimate version
2017-07-06 18:15:24 +10:00
Pau Perez
1028b49719
Stop using Order#shipment as it will be deprecated
...
Spree 2.0 adds a deprecation warning to it and Spree 2.1 removes it.
2017-07-05 16:33:04 +10:00
Maikel Linke
b7f99c3185
Merge branch 'transifex'
2017-06-30 16:28:08 +10:00
Rob Harrington
ce85027b79
Update rubocop_todo.yml using rubocop 0.49.1
2017-06-29 10:47:56 +10:00
Rob Harrington
94b6a61665
Bump rubocop to latest version (0.49.1)
2017-06-29 10:47:56 +10:00
Rob Harrington
f84acf44f3
Disable scss-lint for CodeClimate
...
Until we can tweak #1393 to work with CodeClimate
2017-06-28 18:09:03 +10:00
Diogo Matsubara
386d651678
Fix #1611 (Rephrase error message for people logging in with an existing user email)
...
update test to use new rspec syntax
2017-06-28 15:35:21 +10:00
Matt-Yorkley
23a6e2dd8f
Changed modal redirect behaviour
2017-06-28 14:35:17 +10:00
Transifex-Openfoodnetwork
6c69eebcbf
Updating translations for config/locales/nb.yml [skip ci]
2017-06-27 05:41:31 +10:00
Rob Harrington
d8a158c56d
Rubocop: Update comment on Rails/DynamicFindBy, justifying Enabled: false
2017-06-24 13:37:47 +10:00
Rob Harrington
dfda30f4cb
Rubocop: Regenerate rubocop_todo.yml using --exclude-limit 100
2017-06-24 13:33:57 +10:00
Rob Harrington
d26970d04c
Rubocop: Move Style/ClassAndModuleChildren back to rubocop_todo.yml
2017-06-24 12:59:03 +10:00
Transifex-Openfoodnetwork
63e453e2c7
Updating translations for config/locales/fr.yml [skip ci]
2017-06-23 18:09:39 +10:00
Rob Harrington
c7ed27286a
Rubocop: Correct Lint/ParenthesesAsGroupedExpression offences
2017-06-23 17:02:20 +10:00
Rob Harrington
e5340cb53a
Rubocop: Correct Lint/UselessAssignment offences, disable for /spec in main config
2017-06-23 16:49:08 +10:00
Rob Harrington
7079952f6b
Add rubocop to development group in gemfile
2017-06-23 16:49:08 +10:00
Rob Harrington
f79dcaba15
Rubocop: Add Rails cops to config and todo
2017-06-23 16:49:08 +10:00
Rob Harrington
33a1d97d5e
Rubocop: Disable Style/ClassAndModuleChildren in main config
2017-06-23 16:49:08 +10:00
Rob Harrington
28ea23965b
Rubocop: Correct Lint/AmbiguousOperator offences
2017-06-23 16:49:08 +10:00
Rob Harrington
fbdbbb980f
Rubocop: Disable Lint/AmbiguousBlockAssociation in main config
2017-06-23 16:49:08 +10:00
Rob Harrington
fc5b339e2a
Rubocop: Correct Lint/DuplicateMethods offences
2017-06-23 16:49:08 +10:00
Rob Harrington
4acb3f1962
Rubocop: Use Relaxed.Ruby.Style as starting point for settings
...
Updated .rubocop_todo.yml
2017-06-23 16:49:08 +10:00
Rob Harrington
7bb58342fc
Rubocop: Auto-correct Style/EmptyLineBetweenDefs offences
2017-06-23 16:49:08 +10:00
Rob Harrington
b277ff03ea
Rubocop: Auto-correct Style/TrailingBlankLines offences
2017-06-23 16:49:07 +10:00
Rob Harrington
5061d0c4cd
Rubocop: Tweak config, and add todo file
2017-06-23 16:49:07 +10:00
Continuous Integration
931a5be162
Merge remote-tracking branch 'origin/master' into HEAD
2017-06-22 13:19:25 +10:00
Maikel Linke
e437cba155
Make style flexible for all sizes of logos
...
Trying to support logos that are big. But logos that are too small
should not be stretched either, better small than ugly.
Remove static size declaration from HTML template since it doesn't
reflect the logo size.
Unfortunately, there are other CSS files that are in conflict. The file
mail/email.css.scss defines this globally:
img {
max-width: 100%;
}
2017-06-16 16:49:43 +10:00
Maikel Linke
ec53d9df7a
Merge tag 'v1.8.11' into transifex
2017-06-15 09:59:59 +10:00
Maikel Linke
3330e9b219
Init registration form with default country
2017-06-14 16:47:02 +10:00
Maikel Linke
884743ce97
Filter countries without states for registration
2017-06-14 16:47:01 +10:00
Maikel Linke
b482d1e57c
Spec current behaviour of country selector
...
The enterprise sign-up form shows invalid countries without states and
does not choose the default country. See:
https://github.com/openfoodfoundation/openfoodnetwork/issues/1330
2017-06-14 16:47:01 +10:00
Maikel Linke
78f5002be5
Separate variant names by spaces
...
To enable the search for the beginning of a variant name, they need to
be separated.
See: https://github.com/openfoodfoundation/openfoodnetwork/pull/1545
2017-06-14 16:37:46 +10:00
Maikel Linke
a42799dff4
Initialise product.variant_names
...
Not initialising `product.variant_names` causes it to become the string
"undefinedVariant1Variant2" while it should just be "Variant1Variant2".
This mistake did not matter when `variant_names` was just used to search
for a sub-string. A recent change to search only for the beginning of a
word, caused this to fail.
See: https://github.com/openfoodfoundation/openfoodnetwork/pull/1545
2017-06-14 16:28:55 +10:00
Maikel Linke
1196cd7df4
Add style guide to the source locale
...
There has been a lack of rules how to structure our locale en.yml. This
is a start to document some guidelines which can evolve over time.
Rules can be discussed in the community forum or in pull requests. Once
there is a strong agreement, we should add it to this guide.
2017-06-14 15:20:01 +10:00
Enrico Stano
3c1eae1f47
Do not blindly clear the whole Rails cache
2017-06-09 10:32:57 +10:00
Matt-Yorkley
ba27d63f9c
Fix logo sizing
2017-06-06 13:59:42 +01:00
Julius Pabrinkis
0083733c4c
#1471 Do no let long producers' name go under icon
2017-06-02 16:29:43 +10:00
Julius Pabrinkis
a1ffc869f3
Refactor code by suggestion to use RegExp and add tests coverage
2017-06-02 15:42:35 +10:00
Rhodri Karim
7a07e8fa16
Issue 1233: product filter should only match if name begins withs search term
2017-06-02 15:42:35 +10:00
enricostano
699da16049
Remove unused spec support method
2017-05-31 15:22:30 +10:00
sseerrggii
18c7b03f3d
Add plurals
2017-05-26 16:51:29 +10:00
Rob Harrington
8b560e6cee
Cleaning up angular variant units controllers a little bit
2017-05-24 15:05:33 +10:00
Matt-Yorkley
7974ac45f2
Add unit description placeholder
2017-05-24 15:05:33 +10:00
Matt-Yorkley
41b5cf10dd
Quick testing update
2017-05-24 15:05:33 +10:00
Matt-Yorkley
b6955cb98c
Updated variant feature spec
2017-05-24 15:05:33 +10:00
Matt-Yorkley
6c36c269c8
Product Edit UX adjustments
2017-05-24 15:05:33 +10:00
Pierre de Lacroix
b879ea5a96
add comments
2017-05-24 14:37:54 +10:00
Pierre de Lacroix
a6ed4a2c6a
fix bad return value
...
in method Spree::Adjustment#find_closest_tax_rates_from_included_tax
2017-05-24 14:37:54 +10:00
Pierre de Lacroix
6972822c49
fix escaping problems on ticket view
2017-05-24 13:35:59 +10:00
Pierre de Lacroix
db63f30a76
cosmetic fixes to the ticket view
2017-05-24 13:35:59 +10:00
Rob Harrington
848193434b
Show item single_display_amount instead of variant price in order details table
...
Also has the effect of taking the inventory price into account (since it is stored against the line item price)
2017-05-19 17:27:04 +10:00
stveep
570f0344da
Remove unused method in wrong controller ^_^
2017-05-19 16:14:22 +10:00
stveep
38c25c412f
Remove duplicated spec, better error message suppression, fix shipping test to wait correctly
2017-05-19 16:14:22 +10:00
stveep
3b4ffe1f70
Suppress line item validation error for newly-created orders
2017-05-19 16:10:06 +10:00
stveep
4699c654fc
Fix feature specs for new 'new admin order' flow
2017-05-19 16:10:06 +10:00
stveep
c1c5d00f45
Add new view to set distribution, ensure the scoped variant single item price is used.
2017-05-19 16:10:06 +10:00
stveep
220693f4e3
Starting alternative flow for new manual order
2017-05-19 16:06:43 +10:00
stveep
fcce858ea4
Fix OC with override factory
2017-05-19 16:06:43 +10:00
stveep
1f9698f7a2
Test to reproduce bug with overridden price not being displayed when an order is added manually
2017-05-19 16:06:43 +10:00
Rob Harrington
1766da9d60
Adding ng-cloak directive to changeable orders banner
2017-05-19 15:54:55 +10:00
Rob Harrington
15ee62aaa8
Fixing race condition on link click in spec/features/consumer/shops_spec.rb
2017-05-19 13:29:47 +10:00
Rob Harrington
6fc4a297a0
Fixing race condition on link click in spec/features/consumer/shopping/products_spec.rb
2017-05-19 13:15:30 +10:00
Rob Harrington
74d8dc48b4
Rewriting shopfront alert regarding changeable orders to be dynamic
2017-05-18 15:35:07 +10:00
Rob Harrington
b6f4ce373e
Preloading variants for VariantOverride.indexed
2017-05-18 15:34:22 +10:00
Rob Harrington
c9f186f48f
Fixing SlideOutUp animation for darkswarm
2017-05-18 15:33:14 +10:00
Rob Harrington
daab0dfd7a
Refactor: Splitting changeable_order_from_number out into separate method
2017-05-17 12:38:17 +10:00
Rob Harrington
22b5dafad2
Further tweaks to LineItemsController
2017-05-17 12:27:29 +10:00
Transifex-Openfoodnetwork
110f74eee8
Updating translations for config/locales/es.yml [skip ci]
2017-05-12 20:49:15 +10:00
Rob Harrington
61cb78fc93
Tweaks to LineItemsController, renaming #index to #bought
2017-05-12 16:29:15 +10:00
Rob Harrington
38d3b446cc
Removing unused #tag_list method on VariantSerializer
2017-05-12 16:11:16 +10:00
Rob Harrington
e47e10d267
Removing n+1 query from #items_bought_by_user
2017-05-12 16:11:16 +10:00
Rob Harrington
77c8c85775
Memoizing the result of OrdersController#order_to_update
2017-05-12 16:11:16 +10:00
Rob Harrington
fab6d70832
Changeable orders only returns orders if the shop allows changes
2017-05-12 16:11:16 +10:00
Rob Harrington
9586666248
Updating translation for allow_changes option
2017-05-12 16:11:16 +10:00
Continuous Integration
f5ab9a3445
Merge remote-tracking branch 'origin/master' into HEAD
2017-05-12 10:39:06 +10:00
Continuous Integration
1ac8c85113
Merge remote-tracking branch 'origin/master' into HEAD
2017-05-12 09:55:25 +10:00
Rob Harrington
56c2350d36
Updating enterprise fees on completed order from OrdersController#update
2017-05-10 12:04:32 +10:00
Transifex-Openfoodnetwork
6eafed00f5
Updating translations for config/locales/fr.yml [skip ci]
2017-05-05 21:35:28 +10:00
Transifex-Openfoodnetwork
74661c0b77
Updating translations for config/locales/nb.yml [skip ci]
2017-05-05 18:10:25 +10:00
Rob Harrington
c4fbcb19d0
Only show Admin & Handling fees once on completed order form
2017-05-05 15:28:01 +10:00
Rob Harrington
08e391856c
Ask user to confirm cancellation of order
2017-05-05 15:17:14 +10:00
Rob Harrington
8c8b40c5a8
Showing order cycle close time on banner when multiple open orders are present
2017-05-05 14:20:57 +10:00
Rob Harrington
c3eda435eb
Hiding 'Back to Cart' and 'Back to Store' buttons on completed orders when distributor does not match cart
2017-05-05 14:20:57 +10:00
Rob Harrington
5eadb33db9
Using changes_allowed? to authorize cancellation of line_items
2017-05-05 14:20:57 +10:00
Rob Harrington
f977a05b08
Fixing broken spec for fetching list of bought items as json
2017-05-05 14:20:57 +10:00
Rob Harrington
217eda8362
Shipping and payment fees are updated for completed orders when the order changes
2017-05-05 14:20:57 +10:00
Rob Harrington
579f3bf90a
Changing quantity and deleting line_items of completed orders works with inventory where present
2017-05-05 14:20:57 +10:00
Rob Harrington
348ab81c42
Overriding #increment! using variant overrides
2017-05-05 14:20:57 +10:00
Rob Harrington
3df629bc6e
Prevent users from removing the final line item of an order, suggest cancelling instead
2017-05-05 14:20:57 +10:00
Rob Harrington
07b2f0a7c2
Showing banner for distributor of order on order summary, regardless of current_distributor
2017-05-05 14:20:57 +10:00
Rob Harrington
c0445d46f3
Changeable orders ignores cancelled orders
2017-05-05 14:20:57 +10:00
Rob Harrington
6c90b4e6d0
Adding alert to order summary, notifying user of remaining time to make changes
2017-05-05 14:20:57 +10:00
Rob Harrington
e79a23a554
Disabling save button on order page until changes are made to the order
2017-05-05 14:20:57 +10:00
Rob Harrington
314ccc2f27
Ensuring that #items_bought_by_user doesn't return items from cancelled orders
2017-05-05 14:20:57 +10:00
Rob Harrington
68c8759af1
Count of items in cart form looks is consistent with rest of UI (ie. uses quantities)
2017-05-05 14:20:57 +10:00
Rob Harrington
314e9a4f15
Open shopfront existing orders flash link in a new window
2017-05-05 14:20:57 +10:00
Rob Harrington
0029a1b6cf
Ensure order adjustments are displayed in edit form for customers
2017-05-05 14:20:57 +10:00
Rob Harrington
bfcde72855
Use explicit format for dates on front-end account page
2017-05-05 14:20:57 +10:00
Rob Harrington
3d0ada803f
Test presence of 'Edit' link for previous orders in cart
2017-05-05 14:20:57 +10:00
Rob Harrington
840c936a6f
OrderSerializer#changes_allowed_until returns 'Not allowed' unless changes are allowed
2017-05-05 14:20:57 +10:00
Rob Harrington
7ea74ccf4a
Order confirmation redirects 'Back to Cart' if cart is non-empty
2017-05-05 14:20:57 +10:00
Rob Harrington
b55036e165
Adding alert to shopfront to alert user to presence of orders open for editing
2017-05-05 14:20:57 +10:00
Rob Harrington
47011e11ff
order_cycle.items_bought_by_user actually scopes to the current distributor
2017-05-05 14:20:57 +10:00
Rob Harrington
ae28d7a96b
Adding a link in cart to allow user to edit existing + open orders for same OC
2017-05-05 14:20:57 +10:00
Rob Harrington
0dd8959bf7
Use an actual completed order for OrdersController#order_to_update spec
2017-05-05 14:20:57 +10:00
Rob Harrington
316b0915e4
Just display the date that orders can be changed until
...
No fancy moment.js stuff
2017-05-05 14:20:57 +10:00
Rob Harrington
e21bfd95f4
Renaming order.editable? to order.changes_allowed?
2017-05-05 14:20:57 +10:00
Rob Harrington
893331c7bb
Adding 'Open Orders' section to the top of customer accounts page
2017-05-05 14:20:57 +10:00
Rob Harrington
b94bcd697f
Restructuring customer accounts spec
2017-05-05 14:19:32 +10:00
Rob Harrington
b0ff7ca767
Making accounts page orders listing full-width
2017-05-05 14:19:32 +10:00
Rob Harrington
493a537f2c
Making out-of-stock products in the cart more visible
2017-05-05 14:19:32 +10:00
Rob Harrington
cda43f075b
Moving bought items listing up into main section of cart
2017-05-05 14:19:32 +10:00
Rob Harrington
5d9f92eaa7
Adding 'Cancel Order' button to order confimation interface
2017-05-05 14:19:32 +10:00
Rob Harrington
c6afa1849c
Basic routing for front-end OrdersController#cancel action
2017-05-05 14:19:32 +10:00
Rob Harrington
eec3a21c89
Allow editing of completed orders from confirmation page where distributor allows it
2017-05-05 14:19:32 +10:00
Rob Harrington
768240a5ba
Reorganising darkswarm order views into partials
2017-05-05 14:19:32 +10:00
Rob Harrington
5af8668560
Rewriting Spree::Taxons.distributed_taxons for better performance
2017-05-05 14:19:32 +10:00
Rob Harrington
630b8a2577
Add OrdersController#order_to_update method, to allow updating a complete order where appropriate
2017-05-05 14:19:32 +10:00
Maikel Linke
12a6f652ad
Warn when allowing guest orders and order changes
2017-05-05 14:19:32 +10:00
Maikel Linke
db4a528ba3
Update shipment to re-calculate included tax
...
And re-create tax charges on the order. (untested)
2017-05-05 14:19:32 +10:00
Maikel Linke
479c7ba24b
Update transaction fees of completed orders
...
The adjustments associated to incomplete payments are re-calculated when
a line item is removed from a completed order.
2017-05-05 14:19:32 +10:00
Maikel Linke
1f08729df3
Update shipping fees after removing item
...
After removing an item from a completed order, update the shipping fees
of all shipments that are pending or ready (not completed).
2017-05-05 14:19:32 +10:00
Maikel Linke
811671661e
Remove item from dropdown cart after deletion
2017-05-05 14:19:32 +10:00
Maikel Linke
936df71d0d
Link to bought products on cart page
...
The checkout page was just linking to the cart page, but not scrolling
down.
2017-05-05 14:19:32 +10:00
Maikel Linke
f3f6714472
Add message about previous orders on checkout page
...
The message appears if the user ordered before within the same order
cycle and the shop allows to change previous orders.
2017-05-05 14:19:32 +10:00
Maikel Linke
3bce2eb7b5
Rename translation key checkout to avoid conflicts
...
A top-level translation key `checkout` can't co-exist with translation
keys in the path `checkout`. Moving the old key to
`shared.menu.cart.checkout` avoids conflicts. It also structures the
locale better by view.
2017-05-05 14:19:32 +10:00
Maikel Linke
bf05866f92
Change headline of already ordered items
2017-05-05 14:19:32 +10:00
Maikel Linke
219ad4a3a7
Reload bought products after choosing order cycle
2017-05-05 14:19:32 +10:00
Maikel Linke
a7d8028d5a
Add retry: 3 to intermittently failing spec
2017-05-05 14:19:32 +10:00
Maikel Linke
d49469a3e6
Show bought items only if changes are allowed
...
An enterprise can decide to allow changes to orders in open order
cycles. The items of these orders are then displayed in the shopping
cart and can be removed on the cart edit page.
2017-05-05 14:19:32 +10:00
Maikel Linke
4835ef067f
Add feature to remove line items from open order cycle
...
- Add JS controller to send delete requests.
- Add resource controller to destroy items.
- Add authorisation check to abilities.
- Update fees after removing line item.
2017-05-05 14:19:32 +10:00
Maikel Linke
4112c3cc75
Set auth token for all JS HTTP requests
2017-05-05 14:19:32 +10:00
Maikel Linke
0fe4030d71
Display bought items only if present
2017-05-05 14:19:32 +10:00
Maikel Linke
e8d2d4d96f
Display already bought items in edit cart view
2017-05-05 14:19:32 +10:00
Maikel Linke
88c3f414fb
Handle missing order in cart
2017-05-05 14:18:20 +10:00
Maikel Linke
c0d6b68233
Apply some style guidelines to older code
2017-05-05 14:18:20 +10:00
Maikel Linke
65f62c42b9
Display products already ordered in this oc
...
Github issue #1083 , part of standing orders.
For now, just display already bought products within the same order
cycle in the popup cart view. The edit cart view should follow. Later,
it should be possible to remove items as well.
2017-05-05 14:18:20 +10:00
Maikel Linke
fe7bd5e2cd
Serialise tag_list only for variant overrides
...
Don't try to call tag_list on just variants since that will fail.
Normally, all variants of `current_order` should be extended to
VariantOverrides of the current order cycle. But in development
environment, it can happen that the variants are reloaded without being
extended again.
2017-05-05 14:18:20 +10:00
Maikel Linke
e1b40142b8
Remove unused translations
2017-05-05 14:18:20 +10:00
Maikel Linke
963b4617a9
Add allow-order-changes option to enterprise
2017-05-05 14:18:20 +10:00
Maikel Linke
95ddfc4e40
Merge tag 'v1.8.10' into transifex
2017-05-05 12:28:16 +10:00
François Turbelin
01746ed470
Add missing translations on views
2017-05-04 21:33:17 +02:00
Julius Pabrinkis
f25e3bc6f7
Implement with_currency rspec helper for money amounts
2017-05-04 18:02:38 +01:00
Julius Pabrinkis
e63f1c2991
Refactor time and currency symbol getters
2017-05-03 12:59:16 +01:00
Lynne
29e2886b05
Update contributing.md
...
Include link to discourse post: How to raise a github issue
2017-05-03 11:50:07 +01:00
Julius Pabrinkis
a97bcf74de
Use more simple getter to retrieve currency symbol
2017-05-03 11:25:37 +01:00
Julius Pabrinkis
1e6f4aa73d
Restore bundler version
2017-05-03 11:25:37 +01:00
Julius Pabrinkis
7c7933f8bb
Use local time zone in tests instead of hardcoded
2017-05-03 11:25:37 +01:00
Julius Pabrinkis
dc69c6e825
Use currency symbol from config in tests
2017-05-03 11:25:37 +01:00
Julius Pabrinkis
41e91765ca
Add capybara-screenshot gem for integration tests debugging
2017-05-03 11:25:37 +01:00
Julius Pabrinkis
19569f9316
#1291 Fix dropdown font-size not to zoom in iOS
2017-05-03 10:57:23 +01:00
Maikel Linke
d91c3d1241
Format reset password instructions like Spree
2017-05-03 11:06:48 +10:00
Maikel Linke
b302deb7a3
Add UserMailer specs adapted from Spree code
2017-05-03 11:06:48 +10:00
François Turbelin
2fae467e9a
Translate ResetPasswordConfirmation mail
2017-05-03 11:06:48 +10:00
Em-AK
c72d17dc83
Run karma task only in test environment
...
and fails otherwise, as it needs the defaults defined in test environment
2017-04-28 11:28:24 +10:00
Em-AK
78ffdec693
Force english locale in test environment
2017-04-28 11:28:24 +10:00
Pierre de Lacroix
49c19a1d6a
update wkhtmltopdf-binary and wicked_pdf
2017-04-27 18:38:47 +10:00
Pierre de Lacroix
e854eb0426
add tests
...
for methods Spree::Order#tax_adjustment_totals
and Spree::Adjustment#find_closest_tax_rate_from_included_tax
2017-04-27 17:32:36 +10:00
Pierre de Lacroix
4a9c17cb28
better tax aggregation
2017-04-27 17:32:36 +10:00
Matt-Yorkley
0d1547f439
Require OC ready_for in simple OC UI
2017-04-21 09:34:50 +10:00
Matt-Yorkley
fa5ed529cb
Added OC form validation
2017-04-21 09:32:49 +10:00
Matt-Yorkley
accb3076e9
Updated translations
2017-04-21 09:32:49 +10:00
Matt-Yorkley
a4e4e1ec68
Require OC name
2017-04-21 09:32:49 +10:00
Maikel Linke
4809237ecc
Fast fail set_order_cycles if distributor not ready
2017-04-19 14:28:17 +10:00
Maikel Linke
81877fedb6
Remove useless andand called on scope
2017-04-19 14:28:17 +10:00
Matt-Yorkley
1f2c6f2a85
Ensure shops display as closed when not configured for sales
...
squashme
squashme
squash
squash
squash
2017-04-19 14:28:17 +10:00
Matt-Yorkley
4fe5e60967
Updated controller stub to pass test
2017-04-19 14:28:17 +10:00
Matt-Yorkley
f4eb9cb790
Hubs display as closed when not configured for payment or shipping
2017-04-19 14:28:16 +10:00
Maikel Linke
775f9b3ada
Move text from view to locale (i18n)
2017-04-12 10:06:53 +10:00
Maikel Linke
188b33921c
Remove test entry in locale
2017-04-12 09:56:24 +10:00
Maikel Linke
20c033317f
Remove unnecessary string interpolation from view
2017-04-12 09:49:24 +10:00
Matt-Yorkley
e7a5d063ac
Update simple OC form
2017-04-12 09:41:40 +10:00
Matt-Yorkley
1fda781d7e
Set maxlength on OC displayname field
2017-04-12 09:41:39 +10:00
Matt-Yorkley
45fc801a08
Added tooltips to OC form
2017-04-12 09:41:39 +10:00