raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce cognitive complexity of LineItemSyncer#update_item_quantities

Browse Source
This commit is contained in:
Rob Harrington
2018-02-01 15:07:39 +11:00
parent 224249d66b
commit 88a5d4be47
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/services/line_item_syncer.rb
View File

@@ -22,10 +22,7 @@ class LineItemSyncer
def update_item_quantities(order)
changed_standing_line_items.each do |sli|
line_item = order.line_items.find_by_variant_id(sli.variant_id)
next update_quantity(line_item, sli.quantity) if line_item.quantity == sli.quantity_was
next if line_item.quantity == sli.quantity
next if update_quantity(line_item, sli)
product_name = "#{line_item.product.name} - #{line_item.full_name}"
order_update_issues.add(order, product_name)
end
@@ -49,7 +46,10 @@ class LineItemSyncer
standing_line_items.select(&:new_record?)
end
def update_quantity(line_item, quantity)
line_item.update_attributes(quantity: quantity, skip_stock_check: true)
def update_quantity(line_item, sli)
if line_item.quantity == sli.quantity_was
return line_item.update_attributes(quantity: sli.quantity, skip_stock_check: true)
end
line_item.quantity == sli.quantity
end
end