raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

No longer use expensive page.evaluate_script for imperative methods

Browse Source
This commit is contained in:
Andy Palmer
2017-11-02 15:19:50 +11:00
committed by Rob H
parent e94dc257a1
commit 8ec1c2e04a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/support/request/web_helper.rb
View File

@@ -92,7 +92,7 @@ module WebHelper
end
def handle_js_confirm(accept=true)
page.evaluate_script "window.confirm = function(msg) { return #{!!accept }; }"
page.execute_script "window.confirm = function(msg) { return #{!!accept }; }"
yield
end
@@ -114,7 +114,7 @@ module WebHelper
end
def set_i18n_locale(locale = 'en')
page.evaluate_script("I18n.locale = '#{locale}'")
page.execute_script("I18n.locale = '#{locale}'")
end
def get_i18n_locale
@@ -173,11 +173,11 @@ module WebHelper
end
def open_select2(selector)
page.evaluate_script "jQuery('#{selector}').select2('open');"
page.execute_script "jQuery('#{selector}').select2('open');"
end
def close_select2(selector)
page.evaluate_script "jQuery('#{selector}').select2('close');"
page.execute_script "jQuery('#{selector}').select2('close');"
end
def perform_and_ensure(action, *args, assertion)