Replacing stub_model objects with actual factory generated instances

This commit is contained in:
Rob Harrington
2017-04-05 12:18:38 +10:00
committed by Rob H
parent ef9e43fbd3
commit c835b4eb1a
4 changed files with 5 additions and 5 deletions

View File

@@ -2,6 +2,6 @@ require 'spree/api/testing_support/helpers'
Spree::Api::TestingSupport::Helpers.class_eval do
def current_api_user
@current_api_user ||= stub_model(Spree::LegacyUser, :email => "spree@example.com", :enterprises => [])
@current_api_user ||= Spree::LegacyUser.new(:email => "spree@example.com", :enterprises => [])
end
end

View File

@@ -4,7 +4,7 @@ module Spree
module Setup
def sign_in_as_user!
let!(:current_api_user) do
user = stub_model(Spree::LegacyUser)
user = Spree::LegacyUser.new(:email => "spree@example.com")
user.stub(:has_spree_role?).with("admin").and_return(false)
user.stub(:enterprises) { [] }
user.stub(:owned_groups) { [] }
@@ -28,7 +28,7 @@ module Spree
def sign_in_as_admin!
let!(:current_api_user) do
user = stub_model(Spree::LegacyUser)
user = Spree::LegacyUser.new(:email => "spree@example.com")
user.stub(:has_spree_role?).with("admin").and_return(true)
# Stub enterprises, needed for cancan ability checks

View File

@@ -166,7 +166,7 @@ describe EnterpriseFee do
it "does not clear adjustments from another originator" do
order = create(:order)
tax_rate = create(:tax_rate, calculator: stub_model(Spree::Calculator))
tax_rate = create(:tax_rate, calculator: build(:calculator))
order.adjustments.create({:amount => 12.34,
:source => order,
:originator => tax_rate,

View File

@@ -9,7 +9,7 @@ describe Spree::Calculator::PriceSack do
calculator
end
let(:line_item) { stub_model(Spree::LineItem, price: 1, quantity: 2) }
let(:line_item) { build(:line_item, price: 1, quantity: 2) }
it "computes with a line item object" do
calculator.compute(line_item)