Give a spec some style

.rubocop_todo.yml

@@ -193,7 +193,6 @@ Layout/EmptyLines:
     - 'lib/open_food_network/sales_tax_report.rb'
     - 'lib/open_food_network/scope_product_to_hub.rb'
     - 'lib/open_food_network/scope_variant_to_hub.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'lib/spree/core/controller_helpers/order_decorator.rb'
     - 'lib/tasks/cache.rake'
     - 'lib/tasks/dev.rake'
@@ -395,7 +394,6 @@ Layout/ExtraSpacing:
     - 'spec/features/consumer/shopping/shopping_spec.rb'
     - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb'
     - 'spec/lib/open_food_network/reports/rule_spec.rb'
-    - 'spec/lib/open_food_network/xero_invoices_report_spec.rb'
     - 'spec/models/enterprise_fee_spec.rb'
     - 'spec/models/enterprise_spec.rb'
     - 'spec/models/order_cycle_spec.rb'
@@ -669,7 +667,6 @@ Layout/SpaceAroundEqualsInParameterDefault:
     - 'lib/open_food_network/permissions.rb'
     - 'lib/open_food_network/scope_variant_to_hub.rb'
     - 'lib/open_food_network/tag_rule_applicator.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'lib/spree/money_decorator.rb'
     - 'spec/features/admin/enterprise_relationships_spec.rb'
     - 'spec/features/admin/reports_spec.rb'
@@ -693,7 +690,6 @@ Layout/SpaceAroundOperators:
     - 'app/overrides/remove_side_bar.rb'
     - 'app/overrides/replace_shipping_address_form_with_distributor_details.rb'
     - 'app/serializers/api/enterprise_serializer.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'lib/spree/product_filters.rb'
     - 'spec/controllers/admin/enterprises_controller_spec.rb'
     - 'spec/controllers/cart_controller_spec.rb'
@@ -862,7 +858,6 @@ Layout/SpaceInsideHashLiteralBraces:
     - 'lib/open_food_network/reports/rule.rb'
     - 'lib/open_food_network/sales_tax_report.rb'
     - 'lib/open_food_network/variant_and_line_item_naming.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'lib/tasks/users.rake'
     - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb'
     - 'spec/controllers/admin/business_model_configuration_controller_spec.rb'
@@ -901,7 +896,6 @@ Layout/SpaceInsideHashLiteralBraces:
     - 'spec/lib/open_food_network/reports/report_spec.rb'
     - 'spec/lib/open_food_network/reports/rule_spec.rb'
     - 'spec/lib/open_food_network/tag_rule_applicator_spec.rb'
-    - 'spec/lib/open_food_network/xero_invoices_report_spec.rb'
     - 'spec/lib/stripe/account_connector_spec.rb'
     - 'spec/models/customer_spec.rb'
     - 'spec/models/enterprise_fee_spec.rb'
@@ -1089,7 +1083,6 @@ Lint/UnusedBlockArgument:
     - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb'
     - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb'
     - 'lib/open_food_network/sales_tax_report.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'spec/lib/open_food_network/order_grouper_spec.rb'
     - 'spec/support/cancan_helper.rb'
     - 'spec/support/delayed_job_helper.rb'
@@ -1273,7 +1266,6 @@ Naming/UncommunicativeMethodParamName:
     - 'app/services/subscription_validator.rb'
     - 'lib/open_food_network/property_merge.rb'
     - 'lib/open_food_network/reports/bulk_coop_report.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'spec/lib/open_food_network/reports/report_spec.rb'
     - 'spec/mailers/producer_mailer_spec.rb'
 
@@ -1695,7 +1687,6 @@ Style/BracesAroundHashParameters:
     - 'lib/open_food_network/order_cycle_form_applicator.rb'
     - 'lib/open_food_network/reports/rule.rb'
     - 'lib/open_food_network/variant_and_line_item_naming.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb'
     - 'spec/controllers/admin/business_model_configuration_controller_spec.rb'
     - 'spec/controllers/admin/enterprises_controller_spec.rb'
@@ -1727,7 +1718,6 @@ Style/BracesAroundHashParameters:
     - 'spec/lib/open_food_network/feature_toggle_spec.rb'
     - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb'
     - 'spec/lib/open_food_network/subscription_summarizer_spec.rb'
-    - 'spec/lib/open_food_network/xero_invoices_report_spec.rb'
     - 'spec/models/billable_period_spec.rb'
     - 'spec/models/product_distribution_spec.rb'
     - 'spec/models/spree/ability_spec.rb'
@@ -2308,7 +2298,6 @@ Style/NumericPredicate:
     - 'app/models/spree/order_decorator.rb'
     - 'lib/open_food_network/integrity_checker.rb'
     - 'lib/open_food_network/rack_request_blocker.rb'
-    - 'lib/open_food_network/xero_invoices_report.rb'
     - 'lib/spree/money_decorator.rb'
 
 # Offense count: 2

spec/lib/open_food_network/xero_invoices_report_spec.rb

@@ -8,20 +8,20 @@ module OpenFoodNetwork
     let(:user) { create(:user) }
 
     describe "option defaults" do
-      let(:report) { XeroInvoicesReport.new user, {initial_invoice_number: '', invoice_date: '', due_date: '', account_code: ''} }
+      let(:report) { XeroInvoicesReport.new user, initial_invoice_number: '', invoice_date: '', due_date: '', account_code: '' }
 
       around { |example| Timecop.travel(Time.zone.local(2015, 5, 5, 14, 0, 0)) { example.run } }
 
       it "uses defaults when blank params are passed" do
-        expect(report.instance_variable_get(:@opts)).to eq({invoice_date: Date.civil(2015, 5, 5),
-                                                        due_date: Date.civil(2015, 6, 5),
-                                                        account_code: 'food sales',
-                                                        report_type: 'summary'})
+        expect(report.instance_variable_get(:@opts)).to eq( invoice_date: Date.civil(2015, 5, 5),
+                                                            due_date: Date.civil(2015, 6, 5),
+                                                            account_code: 'food sales',
+                                                            report_type: 'summary' )
       end
     end
 
     describe "summary rows" do
-      let(:report) { XeroInvoicesReport.new user, {initial_invoice_number: '', invoice_date: '', due_date: '', account_code: ''} }
+      let(:report) { XeroInvoicesReport.new user, initial_invoice_number: '', invoice_date: '', due_date: '', account_code: '' }
       let(:order) { double(:order) }
       let(:summary_rows) { report.send(:summary_rows_for_order, order, 1, {}) }
 
@@ -31,7 +31,7 @@ module OpenFoodNetwork
         allow(report).to receive(:shipping_summary_rows) { ['shipping'] }
         allow(report).to receive(:payment_summary_rows)  { ['payment'] }
         allow(report).to receive(:admin_adjustment_summary_rows) { ['admin'] }
-        allow(order).to receive(:account_invoice?)       { false }
+        allow(order).to receive(:account_invoice?) { false }
       end
 
       it "displays produce summary rows when summary report" do
@@ -77,7 +77,7 @@ module OpenFoodNetwork
     end
 
     describe "finding account invoice adjustments" do
-      let(:report) { XeroInvoicesReport.new user, {initial_invoice_number: '', invoice_date: '', due_date: '', account_code: ''} }
+      let(:report) { XeroInvoicesReport.new user, initial_invoice_number: '', invoice_date: '', due_date: '', account_code: '' }
       let!(:order) { create(:order) }
       let(:billable_period) { create(:billable_period) }
       let(:shipping_method) { create(:shipping_method) }
@@ -104,7 +104,7 @@ module OpenFoodNetwork
       end
 
       describe "when an initial invoice number is given" do
-        subject { XeroInvoicesReport.new user, {initial_invoice_number: '123'} }
+        subject { XeroInvoicesReport.new user, initial_invoice_number: '123' }
 
         it "increments the number by the index" do
           expect(subject.send(:invoice_number_for, order, 456)).to eq(579)