Make strategies class names more explicit

This commit is contained in:
Pau Perez
2018-10-01 16:00:42 +02:00
parent af93af1a64
commit 148321f7b7
7 changed files with 14 additions and 14 deletions

View File

@@ -74,9 +74,9 @@ module ProductImport
def reset_stock_strategy_factory
if settings.importing_into_inventory?
InventoryReset
InventoryResetStrategy
else
ProductsReset
ProductsResetStrategy
end
end

View File

@@ -1,5 +1,5 @@
module ProductImport
class InventoryReset
class InventoryResetStrategy
attr_reader :supplier_ids
def initialize(excluded_items_ids)

View File

@@ -1,5 +1,5 @@
module ProductImport
class ProductsReset
class ProductsResetStrategy
attr_reader :supplier_ids
def initialize(excluded_items_ids)

View File

@@ -73,13 +73,13 @@ describe ProductImport::EntryProcessor do
context 'when importing into inventory' do
let(:reset_stock_strategy) do
instance_double(ProductImport::InventoryReset)
instance_double(ProductImport::InventoryResetStrategy)
end
before do
allow(settings).to receive(:importing_into_inventory?) { true }
allow(ProductImport::InventoryReset)
allow(ProductImport::InventoryResetStrategy)
.to receive(:new).with([1]) { reset_stock_strategy }
end
@@ -94,13 +94,13 @@ describe ProductImport::EntryProcessor do
context 'when not importing into inventory' do
let(:reset_stock_strategy) do
instance_double(ProductImport::ProductsReset)
instance_double(ProductImport::ProductsResetStrategy)
end
before do
allow(settings).to receive(:importing_into_inventory?) { false }
allow(ProductImport::ProductsReset)
allow(ProductImport::ProductsResetStrategy)
.to receive(:new).with([1]) { reset_stock_strategy }
end

View File

@@ -1,6 +1,6 @@
require 'spec_helper'
describe ProductImport::InventoryReset do
describe ProductImport::InventoryResetStrategy do
let(:inventory_reset) { described_class.new(excluded_items_ids) }
describe '#<<' do

View File

@@ -1,6 +1,6 @@
require 'spec_helper'
describe ProductImport::ProductsReset do
describe ProductImport::ProductsResetStrategy do
let(:products_reset) { described_class.new(excluded_items_ids) }
describe '#<<' do

View File

@@ -18,7 +18,7 @@ module ProductImport
end
let(:reset_stock_strategy) do
instance_double(InventoryReset, supplier_ids: [])
instance_double(InventoryResetStrategy, supplier_ids: [])
end
it 'returns nil' do
@@ -36,7 +36,7 @@ module ProductImport
)
end
let(:reset_stock_strategy) { instance_double(ProductsReset) }
let(:reset_stock_strategy) { instance_double(ProductsResetStrategy) }
before do
allow(entry_processor)
@@ -68,7 +68,7 @@ module ProductImport
)
end
let(:reset_stock_strategy) { instance_double(InventoryReset) }
let(:reset_stock_strategy) { instance_double(InventoryResetStrategy) }
before do
allow(entry_processor)
@@ -94,7 +94,7 @@ module ProductImport
)
end
let(:reset_stock_strategy) { instance_double(InventoryReset) }
let(:reset_stock_strategy) { instance_double(InventoryResetStrategy) }
before do
allow(entry_processor)