raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-06 02:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce cognitive complexity of ProxyOrder#state

Browse Source
This commit is contained in:
Rob Harrington
2018-02-01 16:09:42 +11:00
parent 88a5d4be47
commit 2012c23956
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/models/proxy_order.rb
View File

@@ -11,13 +11,11 @@ class ProxyOrder < ActiveRecord::Base
scope :placed_and_open, -> { joins(:order).not_closed.where(spree_orders: { state: 'complete' }) }
def state
return 'canceled' if canceled?
if !order || order_cycle.orders_open_at > Time.zone.now
standing_order.paused? ? 'paused' : 'pending'
else
return 'cart' if placed_and_open?
order.state
# NOTE: the order is important here
%w(canceled paused pending cart).each do |state|
return state if send("#{state}?")
end
order.state
end
def canceled?
@@ -65,7 +63,15 @@ class ProxyOrder < ActiveRecord::Base
private
def placed_and_open?
def paused?
pending? && standing_order.paused?
end
def pending?
!order || order_cycle.orders_open_at > Time.zone.now
end
def cart?
order.andand.state == 'complete' &&
order_cycle.orders_close_at > Time.zone.now
end