raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing line item controller issue by setting data up correctly

Browse Source
This commit is contained in:
Rob Harrington
2017-05-25 21:48:43 +10:00
parent 72292b1dd3
commit 3e6e3173ee
1 changed files with 14 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
spec/controllers/line_items_controller_spec.rb
View File

@@ -35,6 +35,9 @@ describe LineItemsController do
item
end
let(:order) { item.order }
let(:order_cycle) { create(:simple_order_cycle, distributors: [distributor], variants: [order.line_item_variants]) }
before { controller.stub spree_current_user: item.order.user }
context "without a line item id" do
@@ -55,42 +58,32 @@ describe LineItemsController do
end
context "where the item's order is associated with the current user" do
before { item.order.update_attributes(user_id: user.id) }
before { order.update_attributes!(user_id: user.id) }
context "without an order cycle" do
context "without an order cycle or distributor" do
it "denies deletion" do
delete :destroy, params
expect(response.status).to eq 403
end
end
context "with an order cycle" do
before { item.order.update_attributes(order_cycle_id: order_cycle.id) }
context "with an order cycle and distributor" do
before { order.update_attributes!(order_cycle_id: order_cycle.id, distributor_id: distributor.id) }
context "without a distributor" do
context "where changes are not allowed" do
it "denies deletion" do
delete :destroy, params
expect(response.status).to eq 403
end
end
context "where the item's order has a distributor" do
before { item.order.update_attributes(distributor_id: distributor.id) }
context "where changes are not allowed" do
it "denies deletion" do
delete :destroy, params
expect(response.status).to eq 403
end
end
context "where changes are allowed" do
before { distributor.update_attributes!(allow_order_changes: true) }
context "where changes are allowed" do
before { distributor.update_attributes(allow_order_changes: true) }
it "deletes the line item" do
delete :destroy, params
expect(response.status).to eq 204
expect { item.reload }.to raise_error ActiveRecord::RecordNotFound
end
it "deletes the line item" do
delete :destroy, params
expect(response.status).to eq 204
expect { item.reload }.to raise_error ActiveRecord::RecordNotFound
end
end
end