Made changes requested by reviewer, in labels and tests.

This commit is contained in:
duende13
2017-12-01 23:17:29 +00:00
committed by Maikel Linke
parent 7670d01c6d
commit f75b865be8
6 changed files with 9 additions and 8 deletions

View File

@@ -1,5 +1,5 @@
/ insert_bottom "[data-hook='admin_product_tabs']"
- klass = current == 'Search' ? 'active' : ''
- klass = current == t(:Search) ? 'active' : ''
%li{:class => klass}
= link_to_with_icon 'icon-tasks', t(:Search), seo_admin_product_url(@product)

View File

@@ -1,6 +1,6 @@
.row{"data-hook" => "admin_product_meta_form"}
.alpha.eleven.columns
= f.field_container :meta_description do
= f.field_container :meta_keywords do
= f.label :meta_keywords, t(:product_search_keywords)
%br/
= f.text_field :meta_keywords, :class => 'fullwidth', :rows => 6

View File

@@ -1,5 +1,5 @@
= render :partial => 'spree/admin/shared/product_sub_menu'
= render :partial => 'spree/admin/shared/product_tabs', :locals => { :current => 'Search' }
= render :partial => 'spree/admin/shared/product_tabs', :locals => { :current => t(:Search) }
= render :partial => 'spree/shared/error_messages', :locals => { :target => @product }
= form_for [:admin, @product], :method => :put, :html => { :multipart => true } do |f|

View File

@@ -452,6 +452,7 @@ en:
upload_an_image: Upload an image
product_search_keywords: Product Search Keywords
SEO_keywords: SEO Keywords
Search: Search
properties:
property_name: Property Name
inherited_property: Inherited Property

View File

@@ -191,10 +191,10 @@ feature %q{
fill_in 'Product Search Keywords', :with => 'Product Search Keywords'
fill_in 'Notes', :with => 'Just testing Notes'
click_button 'Update'
flash_message.should == "Product \"#{product.name}\" has been successfully updated!"
expect(flash_message).to eq("Product \"#{product.name}\" has been successfully updated!")
product.reload
product.notes.should == 'Just testing Notes'
product.meta_keywords.should == 'Product Search Keywords'
expect(product.notes).to eq('Just testing Notes')
expect(product.meta_keywords).to eq('Product Search Keywords')
end
scenario "deleting product properties", js: true do

View File

@@ -214,8 +214,8 @@ feature "As a consumer I want to shop with a distributor", js: true do
page.should_not have_content product.name
fill_in "search", with: "Dome" # For product with meta_keywords "Domestic"
page.should have_content product.name
page.should_not have_content product2.name
expect(page).to have_content product.name
expect(page).not_to have_content product2.name
end
it "returns search results for products where the search term matches one of the product's variant names" do