raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer .flat_map(&foo) over .map(&foo).flatten

Browse Source
This commit is contained in:
Matt-Yorkley
2018-08-31 15:38:38 +01:00
parent 04d50d4555
commit 75a9ea5bfa
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/product_import/entry_validator.rb
View File

@@ -131,7 +131,7 @@ module ProductImport
return
end
products.map(&:variants).flatten.each do |existing_variant|
products.flat_map(&:variants).each do |existing_variant|
unit_scale = existing_variant.product.variant_unit_scale
unscaled_units = entry.unscaled_units || 0
entry.unit_value = unscaled_units * unit_scale
@@ -182,7 +182,7 @@ module ProductImport
return
end
products.map(&:variants).flatten.each do |existing_variant|
products.flat_map(&:variants).each do |existing_variant|
if entry_matches_existing_variant?(entry, existing_variant) && existing_variant.deleted_at.nil?
return mark_as_existing_variant(entry, existing_variant)
end