From 75a9ea5bfa79431bf039be30d3a942c0f7c849b1 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 31 Aug 2018 15:38:38 +0100
Subject: [PATCH] Prefer .flat_map(&foo) over .map(&foo).flatten

---
 app/models/product_import/entry_validator.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/models/product_import/entry_validator.rb b/app/models/product_import/entry_validator.rb
index 873e1478e0..33a7932f4f 100644
--- a/app/models/product_import/entry_validator.rb
+++ b/app/models/product_import/entry_validator.rb
@@ -131,7 +131,7 @@ module ProductImport
         return
       end
 
-      products.map(&:variants).flatten.each do |existing_variant|
+      products.flat_map(&:variants).each do |existing_variant|
         unit_scale = existing_variant.product.variant_unit_scale
         unscaled_units = entry.unscaled_units || 0
         entry.unit_value = unscaled_units * unit_scale
@@ -182,7 +182,7 @@ module ProductImport
         return
       end
 
-      products.map(&:variants).flatten.each do |existing_variant|
+      products.flat_map(&:variants).each do |existing_variant|
         if entry_matches_existing_variant?(entry, existing_variant) && existing_variant.deleted_at.nil?
           return mark_as_existing_variant(entry, existing_variant)
         end