raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-08 22:56:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor spec to not stub the class under test

Browse Source 
This also relies on ActiveRecord which will come in handy as we move on
the refactor.
This commit is contained in:
Pau Perez
2018-11-26 17:32:32 +01:00
parent 149fc1ac6f
commit e40c1c08ca
1 changed files with 9 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spec/serializers/api/cached_enterprise_serializer_spec.rb
View File

@@ -32,32 +32,18 @@ describe Api::CachedEnterpriseSerializer do
let(:duplicate_property) { create(:property, presentation: 'One') }
let(:different_property) { create(:property, presentation: 'Two') }
describe "merging Spree::Properties" do
it "merges properties" do
allow(cached_enterprise_serializer)
.to receive(:product_properties) { [property] }
allow(cached_enterprise_serializer)
.to receive(:producer_properties) { [duplicate_property, different_property] }
merge = cached_enterprise_serializer.supplied_properties
expect(merge).to eq([property, different_property])
end
let(:enterprise) do
create(:enterprise, properties: [duplicate_property, different_property])
end
describe "merging ProducerProperties and Spree::ProductProperties" do
let(:product_property) { create(:product_property, property: property) }
let(:duplicate_product_property) { create(:producer_property, property: duplicate_property) }
let(:producer_property) { create(:producer_property, property: different_property) }
before do
product = create(:product, properties: [property])
enterprise.supplied_products << product
end
it "merges properties" do
allow(cached_enterprise_serializer)
.to receive(:product_properties) { [product_property] }
allow(cached_enterprise_serializer)
.to receive(:producer_properties) { [duplicate_product_property, producer_property] }
merge = cached_enterprise_serializer.supplied_properties
expect(merge).to eq([product_property, producer_property])
end
it "removes duplicate product and producer properties" do
merge = cached_enterprise_serializer.supplied_properties
expect(merge).to eq([property, different_property])
end
end
end