raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-04-03 06:59:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make request stubs less brittle by using regex

Browse Source
This commit is contained in:
Rob Harrington
2017-09-13 23:52:42 +10:00
parent fbda1a27ad
commit d2096cf6d1
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/requests/stripe_connect_checkout_spec.rb
View File

@@ -42,8 +42,7 @@ describe "Submitting Stripe Connect charge requests", type: :request do
before do
# Charges the card
stub_request(:post, "https://sk_test_12345:@api.stripe.com/v1/charges")
.with(:body => {"amount" => "1234", "card" => token, "currency" => "aud", "description" => "Spree Order ID: #{order.number}", "payment_user_agent" => "Stripe/v1 ActiveMerchantBindings/1.63.0"})
.to_return(charge_response_mock)
.with(body: /#{token}.*#{order.number}/).to_return(charge_response_mock)
end
context "and the charge request is successful" do
@@ -91,8 +90,7 @@ describe "Submitting Stripe Connect charge requests", type: :request do
# Charges the card
stub_request(:post, "https://sk_test_12345:@api.stripe.com/v1/charges")
.with(:body => {"amount" => "1234", "card" => new_token, "currency" => "aud", "description" => "Spree Order ID: #{order.number}", "payment_user_agent" => "Stripe/v1 ActiveMerchantBindings/1.63.0"})
.to_return(charge_response_mock)
.with(body: /#{token}.*#{order.number}/).to_return(charge_response_mock)
end
context "and the store, token and charge requests are successful" do
@@ -142,8 +140,7 @@ describe "Submitting Stripe Connect charge requests", type: :request do
before do
# Attempts to charge the card without a token, which will return an error
stub_request(:post, "https://sk_test_12345:@api.stripe.com/v1/charges")
.with(:body => {"amount" => "1234", "currency" => "aud", "description" => "Spree Order ID: #{order.number}", "payment_user_agent" => "Stripe/v1 ActiveMerchantBindings/1.63.0"})
.to_return(charge_response_mock)
.with(body: /#{order.number}/).to_return(charge_response_mock)
end
it "should not process the payment" do
@@ -186,8 +183,7 @@ describe "Submitting Stripe Connect charge requests", type: :request do
# Charges the card
stub_request(:post, "https://sk_test_12345:@api.stripe.com/v1/charges")
.with(:body => {"amount" => "1234", "card" => new_token, "currency" => "aud", "description" => "Spree Order ID: #{order.number}", "payment_user_agent" => "Stripe/v1 ActiveMerchantBindings/1.63.0"} )
.to_return(charge_response_mock)
.with(body: /#{token}.*#{order.number}/).to_return(charge_response_mock)
end
context "and the charge and token requests are accepted" do
@@ -225,8 +221,7 @@ describe "Submitting Stripe Connect charge requests", type: :request do
before do
# Attempts to charge the card without a token, which will return an error
stub_request(:post, "https://sk_test_12345:@api.stripe.com/v1/charges")
.with(:body => {"amount" => "1234", "currency" => "aud", "description" => "Spree Order ID: #{order.number}", "payment_user_agent" => "Stripe/v1 ActiveMerchantBindings/1.63.0"})
.to_return(charge_response_mock)
.with(body: /#{order.number}/).to_return(charge_response_mock)
end
it "should not process the payment" do