Maikel Linke
d64b311230
Update all locales with the latest Transifex translations
2023-11-03 12:56:16 +11:00
Filipe
771bd93f5f
Merge pull request #11677 from rioug/11359-vouchers-fix-tax-moving-back-in-checkout
...
[vouchers] fix tax calculation when moving back in the checkout process
2023-11-02 17:02:08 +00:00
Maikel
eea08ac0a1
Merge pull request #11745 from openfoodfoundation/dependabot/bundler/sidekiq-7.2.0
...
chore(deps): bump sidekiq from 7.1.6 to 7.2.0
2023-11-02 15:33:53 +11:00
dependabot[bot]
744b0799a6
chore(deps): bump sidekiq from 7.1.6 to 7.2.0
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.6 to 7.2.0.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.6...v7.2.0 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-01 09:26:51 +00:00
David Cook
d8cc45c5c3
Merge pull request #11742 from filipefurtad0/vcr_payment_intent_validator_spec
...
Replaces mocks with VCR calls
2023-11-01 17:04:00 +11:00
David Cook
031abd6546
Merge pull request #11743 from openfoodfoundation/revert-11708-test-redis-5
...
Revert "replace hiredis gem with hiredis-client"
2023-11-01 16:08:49 +11:00
Maikel
6a236a8678
Revert "replace hiredis gem with hiredis-client"
2023-11-01 15:16:57 +11:00
Maikel
8e88ef021f
Merge pull request #11738 from openfoodfoundation/dependabot/bundler/bootsnap-1.17.0
...
chore(deps): bump bootsnap from 1.16.0 to 1.17.0
2023-11-01 14:40:29 +11:00
Maikel
a1c6a43954
Merge pull request #11740 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.6.0
...
chore(deps): bump newrelic_rpm from 9.5.0 to 9.6.0
2023-11-01 14:00:16 +11:00
Maikel
512fee2a9b
Merge pull request #11739 from openfoodfoundation/dependabot/bundler/view_component-3.7.0
...
chore(deps): bump view_component from 3.6.0 to 3.7.0
2023-11-01 13:59:02 +11:00
Maikel
e6e2f27ed4
Merge pull request #11736 from dacook/registration-noindex
...
Print robots tag for registration layout
2023-11-01 13:53:07 +11:00
Maikel
fb732e55bc
Merge pull request #11734 from openfoodfoundation/dependabot/bundler/angular-rails-templates-1.2.1
...
chore(deps): bump angular-rails-templates from 1.2.0 to 1.2.1
2023-11-01 13:46:32 +11:00
Maikel
8f4f691cb2
Merge pull request #11735 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.22.1
...
chore(deps-dev): bump rubocop-rails from 2.21.2 to 2.22.1
2023-11-01 13:40:52 +11:00
Maikel
25a3149f48
Merge pull request #11702 from dacook/buu-editing-part5b-11059
...
[BUU] Mark changed fields, when error
2023-11-01 13:01:08 +11:00
Maikel
ddd410ceb5
Merge pull request #11729 from openfoodfoundation/dependabot/npm_and_yarn/browserify-sign-4.2.2
...
chore(deps): bump browserify-sign from 4.2.1 to 4.2.2
2023-11-01 12:50:20 +11:00
Maikel
e85a1cef7e
Merge pull request #11708 from abdellani/test-redis-5
...
replace hiredis gem with hiredis-client
2023-11-01 10:02:25 +11:00
filipefurtad0
a88919299f
Replaces mocks with VCR calls
2023-10-31 19:06:40 +00:00
dependabot[bot]
1134c9c07a
chore(deps): bump newrelic_rpm from 9.5.0 to 9.6.0
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.5.0 to 9.6.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.5.0...9.6.0 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-31 09:44:29 +00:00
dependabot[bot]
d3883c7302
chore(deps): bump view_component from 3.6.0 to 3.7.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.6.0...v3.7.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-31 09:44:08 +00:00
dependabot[bot]
a8de70c79e
chore(deps): bump bootsnap from 1.16.0 to 1.17.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.16.0 to 1.17.0.
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.16.0...v1.17.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-31 09:42:54 +00:00
David Cook
18b79668a5
Merge pull request #11727 from openfoodfoundation/dependabot/bundler/valid_email2-5.1.1
...
chore(deps): bump valid_email2 from 5.1.0 to 5.1.1
2023-10-31 14:32:44 +11:00
David Cook
d79c5c39cf
Merge pull request #11723 from openfoodfoundation/dependabot/bundler/rubocop-1.57.2
...
chore(deps-dev): bump rubocop from 1.57.1 to 1.57.2
2023-10-31 14:31:01 +11:00
David Cook
1d96747570
Merge pull request #11716 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.1.1
...
chore(deps): bump active_storage_validations from 1.0.4 to 1.1.1
2023-10-31 14:29:42 +11:00
David Cook
435bf6e6b0
Print robots tag for registration layout
...
This is copied from the darkswarm layout.
2023-10-31 14:03:32 +11:00
dependabot[bot]
c27f616ac0
chore(deps-dev): bump rubocop-rails from 2.21.2 to 2.22.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.21.2 to 2.22.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.21.2...v2.22.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-30 09:10:27 +00:00
dependabot[bot]
16ff608e33
chore(deps): bump angular-rails-templates from 1.2.0 to 1.2.1
...
Bumps [angular-rails-templates](https://github.com/pitr/angular-rails-templates ) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/pitr/angular-rails-templates/releases )
- [Changelog](https://github.com/pitr/angular-rails-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pitr/angular-rails-templates/compare/v1.2.0...v1.2.1 )
---
updated-dependencies:
- dependency-name: angular-rails-templates
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-30 09:08:50 +00:00
Maikel Linke
7f7f6f5c96
Remove unneeded require of hiredis-client
2023-10-30 16:28:18 +11:00
dependabot[bot]
743a5e1a3c
chore(deps): bump browserify-sign from 4.2.1 to 4.2.2
...
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign ) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md )
- [Commits](https://github.com/crypto-browserify/browserify-sign/compare/v4.2.1...v4.2.2 )
---
updated-dependencies:
- dependency-name: browserify-sign
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-27 16:23:32 +00:00
dependabot[bot]
255872ebe3
chore(deps): bump valid_email2 from 5.1.0 to 5.1.1
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.1.0 to 5.1.1.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-27 09:45:13 +00:00
Gaetan Craig-Riou
33de80f13c
Fix checking if shipping method changed
...
We now check if the shipping method changed before we actually select
it. Fix the related spec.The spec was wrong because order.select_shipping_method
fails silently. That means the shipping method wasn't getting
updated on the order, thus the test was passing.
2023-10-27 14:20:31 +11:00
Gaetan Craig-Riou
4f961098c4
Update all locales with the latest Transifex translations
2023-10-27 11:36:13 +11:00
Filipe
f1d4ec9fe7
Merge pull request #11684 from ccozkan/issue-11609
...
Fix content aligning in subscriptions table
2023-10-26 16:20:33 +01:00
Filipe
aa9cacada8
Merge pull request #11676 from openfoodfoundation/dependabot/bundler/stripe-10.0.0
...
chore(deps): bump stripe from 9.4.0 to 10.0.0
2023-10-26 15:41:49 +01:00
dependabot[bot]
0919b2bc6c
chore(deps-dev): bump rubocop from 1.57.1 to 1.57.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.57.1 to 1.57.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.1...v1.57.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-26 12:57:54 +00:00
Filipe
a54de4b522
Merge pull request #11691 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.24
...
chore(deps): bump combine_pdf from 1.0.23 to 1.0.24
2023-10-26 13:56:44 +01:00
Filipe
b67acaae21
Merge pull request #11694 from prateek0411999/bugfix/11666-warning_forfeit_remaining_amount
...
add condition on warning_forfeit_remaining_amount note
2023-10-26 13:44:22 +01:00
Filipe
3da8341946
Merge pull request #11695 from ccozkan/issue-8943
...
Make update button on enterprises primary details form clickable upon input to name field
2023-10-26 13:12:27 +01:00
Filipe
7b3c6e9f58
Merge pull request #11688 from mkllnk/enterprise-fee-report
...
Avoid error when generating Enterprise fees w/ Tax Report by Producer
2023-10-26 12:43:19 +01:00
Mohamed ABDELLANI
d6890e9828
check key class before call Rails.cache.delete
2023-10-26 10:27:00 +01:00
dependabot[bot]
38485a8010
chore(deps): bump active_storage_validations from 1.0.4 to 1.1.1
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.4 to 1.1.1.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.4...1.1.1 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-26 09:25:54 +00:00
Mohamed ABDELLANI
5360df6cee
replace hiredis gem with hiredis-client
2023-10-26 10:10:51 +01:00
David Cook
ed520ea679
Merge pull request #11703 from abdellani/remove-mini-portile2
...
removes mini_portile2
2023-10-26 09:40:38 +11:00
David Cook
7195314dc6
Merge pull request #11697 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.5
...
chore(deps): bump mini_portile2 from 2.8.4 to 2.8.5
2023-10-26 09:23:06 +11:00
Çağrı Özkan
924cee0876
Trigger build (empty commit)
2023-10-25 18:21:39 +03:00
Çağrı Özkan
7b21126a9c
Use both onchange and oninput on ng_form.html.haml
2023-10-25 17:32:25 +03:00
Filipe
6280bfcebe
Merge pull request #11706 from yasirazgar/11318_flaky_packing_report_spec
...
11318 - Fix flaky packing_report_spec.rb
2023-10-25 15:22:04 +01:00
Çağrı Özkan
38d1de896c
Use oninput on ng_form.html.haml instead of onchange
2023-10-25 17:11:30 +03:00
dependabot[bot]
8fc4d6cd4d
chore(deps): bump mini_portile2 from 2.8.4 to 2.8.5
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.4 to 2.8.5.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.4...v2.8.5 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-25 08:20:25 +00:00
Mohamed ABDELLANI
d77a94d377
add comment about mini_protile2 gem
2023-10-25 09:17:21 +01:00
David Cook
fac354e678
Merge pull request #11700 from macanudo527/fix_stylehash_12
...
Fix Style/HashSyntax 13/13
2023-10-25 10:40:52 +11:00
yasir azgar
3ba208e3d3
11318 - fix flaky packing_report_spec
...
fix rubocop DurationArithmetic
2023-10-24 22:21:42 +05:30
David Cook
08ac46fd91
Refactor spec: Only create necessary records
...
This was creating a lot of records for every single test. Now it's much more efficient and spec conditions are clearer.
2023-10-24 16:44:34 +11:00
David Cook
671dc570ec
Refactor: with form builder
2023-10-24 15:21:14 +11:00
David Cook
aa4630d74c
Mark fields as changed if they contain unsaved values.
...
This can happen when there's a validation error. The field with error will also be marked changed, but the error style will override it.
I'd like to move this into a FormBuilder. Existing formbuilder gems don't seem to support it (though I didn't look very hard).
2023-10-24 15:21:14 +11:00
David Cook
04032e61e2
Prettier
2023-10-24 15:21:13 +11:00
David Cook
fdad45bb46
Rename 'modified' state to 'changed'
...
This conveniently matches the terminology used in both JavaScript and ActiveModel::Dirty.
2023-10-24 15:21:13 +11:00
David Cook
ceb9d9af92
Add comment
...
I decided to look into why this is so complicated, in case some of the complexity can be removed. It can't :(
2023-10-24 15:21:13 +11:00
David Cook
1534908895
Move generic method to base class
...
Because rubocop complained about the size of ProductSet.
2023-10-24 15:21:13 +11:00
David Cook
89e53c88f3
Move context up a level
...
Best viewed with whitespace ignored.
2023-10-24 15:21:13 +11:00
David Cook
8293f24ed3
Remove redundant context
...
Best viewed with whitespace ignored.
2023-10-24 15:21:13 +11:00
David Cook
224b6f514b
Remove concept of master variant
...
from old bulk product screen. Hmm I just realised we're deleting that screen soon anyway.
But this helps clean up the spec before I refactor it further.
2023-10-24 15:21:13 +11:00
David Cook
be6481dac3
Refactor spec: combine expectations
...
These expectations have the same conditions, so why set it up three times?
2023-10-24 15:21:13 +11:00
David Cook
3710aa2149
Refactor spec
...
Better to explicitly test for the change, and specify expected values.
2023-10-24 15:21:13 +11:00
Neal Chambers
cf072fb56f
Update .rubocop_todo.yml
2023-10-24 08:49:48 +09:00
Neal Chambers
dc607b654d
Fix Style/HashSyntax
2023-10-24 08:49:34 +09:00
David Cook
a2f8b0db16
Update ansible group name
2023-10-24 10:37:32 +11:00
Maikel
42f5469de5
Merge pull request #11674 from mkllnk/money
...
Format money amounts according to locale, not currency
2023-10-24 09:47:37 +11:00
Sigmund Petersen
0d557eb0f2
Merge branch 'master' into dependabot/bundler/combine_pdf-1.0.24
2023-10-23 09:38:02 +02:00
prateek0411999
a113b5ba01
add condition on warning_forfeit_remaining_amount note
2023-10-23 10:45:35 +05:30
Gaetan Craig-Riou
d5d043880a
Fix scenario when no shipment available
...
I though that once the shipping method was set it's available on the
order, but apparently it's not always the case. At least some of the
test scenario have order with no shipment, thus no shipping method set.
2023-10-23 15:38:01 +11:00
Gaetan Craig-Riou
25af178011
Refactor updating order state
...
It makes the code a bit easier to read
2023-10-23 15:37:53 +11:00
Gaetan Craig-Riou
9f426add8d
Merge pull request #11690 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.2.3
...
chore(deps): bump tom-select from 2.2.2 to 2.2.3
2023-10-23 09:48:48 +11:00
Çağrı Özkan
e465015184
Add oninput:"make form dirty" to enterprise_form/name text field
2023-10-21 01:19:41 +03:00
Filipe
44a675bcda
Merge branch 'master' into dependabot/bundler/combine_pdf-1.0.24
2023-10-20 16:44:08 +01:00
filipefurtad0
e645ef72a7
Update all locales with the latest Transifex translations
2023-10-20 12:27:28 +01:00
Konrad
2ba5ab7dc1
Merge pull request #11577 from jibees/10956-use-cable_ready-instead-of-morph
...
Admin, Orders list: when capturing an order, fix an issue that makes the tooltip invisible (+ errors in the console)
2023-10-20 11:56:53 +02:00
dependabot[bot]
06eac95a48
chore(deps): bump combine_pdf from 1.0.23 to 1.0.24
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.23 to 1.0.24.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.23...v1.0.24 )
---
updated-dependencies:
- dependency-name: combine_pdf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-20 09:20:47 +00:00
dependabot[bot]
c734f982a1
chore(deps): bump tom-select from 2.2.2 to 2.2.3
...
Bumps [tom-select](https://github.com/orchidjs/tom-select ) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/orchidjs/tom-select/releases )
- [Commits](https://github.com/orchidjs/tom-select/compare/v2.2.2...v2.2.3 )
---
updated-dependencies:
- dependency-name: tom-select
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-20 09:06:10 +00:00
Gaetan Craig-Riou
5ba21e486a
Recalculate voucher voucher adjusment when needed
...
We need to recalculate the voucher adjustment(s) in the following
scenarii :
When a voucher as been added to the order and :
* Moving to the payment step from details step, to take into account
potential change in shipment fees. (this happen if we return to the
details step after reaching the summary step)
* Moving to the summary step from payment step, to take into account
payment fees
2023-10-20 16:49:21 +11:00
Maikel Linke
b83651a7ae
Avoid error when generating fee report
...
Instead some data is missing from the report. A slightly better outcome
but still wrong. This is tracked in another issue though.
2023-10-20 15:45:32 +11:00
Maikel Linke
4fc66f6585
Spec fee report failing on removed variant
...
Well, creating a unit test level spec in the first place. Edge cases
like this don't need to be tested in slow system specs.
2023-10-20 15:35:17 +11:00
Gaetan Craig-Riou
f9d2deeb17
Small clean up
2023-10-20 15:28:26 +11:00
Maikel Linke
43b1eca026
Remove unneeded report spec
...
Testing for the absence of behaviour is useful when changing code to
assert that the change is successful but in the long term, it doesn't
add any value. If you don't have any reason to believe that the report
may delete parameters then we don't need to test for that.
2023-10-20 14:22:43 +11:00
Maikel
d45fe44c9f
Remove unused Code Climate badge
...
It always gave us a good score anyway because we ignored the bad code.
2023-10-20 10:22:42 +11:00
David Cook
8fad8b9f80
Merge pull request #11687 from filipefurtad0/fix_flaky_spec_#11686
...
Moves assertions within before do block
2023-10-20 09:57:41 +11:00
David Cook
801c30f4d5
Merge pull request #11685 from openfoodfoundation/dependabot/bundler/roadie-rails-3.1.0
...
chore(deps): bump roadie-rails from 3.0.0 to 3.1.0
2023-10-20 09:55:42 +11:00
David Cook
2d68d49c1f
Merge pull request #11683 from openfoodfoundation/dependabot/npm_and_yarn/babel/traverse-7.23.2
...
chore(deps): bump @babel/traverse from 7.21.5 to 7.23.2
2023-10-20 09:51:32 +11:00
David Cook
3805988c6e
Merge pull request #11682 from filipefurtad0/assert_status_on_order_confirmation_screen
...
Adds coverage on order confirmation page
2023-10-20 09:49:10 +11:00
Maikel
5d2d925eb6
Merge pull request #11547 from filipefurtad0/legal_invoices_associations_comparator_spec
...
Adds coverage on order-associated attributes
2023-10-20 08:52:27 +11:00
filipefurtad0
8d6ed5ec23
Moves assertions within before do block
...
Doing so, assures the removal of the invoice is finished, before clicking the 'Next - Order summary' button
2023-10-19 17:38:27 +01:00
filipefurtad0
c05716cea9
Addresses review suggestions from @dacook
...
I've noticed that it was necessary to include a reference to the order like 'order.adjustments << create(:adjustment, order:)' for the tests to pass
Updates test case description
2023-10-19 15:49:28 +01:00
dependabot[bot]
91f94505c2
chore(deps): bump roadie-rails from 3.0.0 to 3.1.0
...
Bumps [roadie-rails](https://github.com/Mange/roadie-rails ) from 3.0.0 to 3.1.0.
- [Changelog](https://github.com/Mange/roadie-rails/blob/master/Changelog.md )
- [Commits](https://github.com/Mange/roadie-rails/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: roadie-rails
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-19 09:22:55 +00:00
dependabot[bot]
f35388ef3a
chore(deps): bump @babel/traverse from 7.21.5 to 7.23.2
...
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse ) from 7.21.5 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse )
---
updated-dependencies:
- dependency-name: "@babel/traverse"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-19 02:28:53 +00:00
Çağrı Özkan
a6bcac8a7d
Remove text-center from subscription table td's
2023-10-19 05:16:20 +03:00
filipefurtad0
27ecd4224e
Sets tests as shared example (further DRYes spec)
2023-10-18 19:12:58 +01:00
filipefurtad0
461ef48c3a
DRYes spec
2023-10-18 18:26:42 +01:00
filipefurtad0
80f0b30e5c
Adds coverage on order confirmation page
...
Related to the changes from PRs #11668 and #11114 .
2023-10-18 16:02:31 +01:00
Filipe
caa655f500
Merge pull request #11668 from drummer83/master
...
Don't show credit owed when = 0 in order confirmation
2023-10-18 12:16:54 +01:00
Konrad
448eb8b3b1
Merge branch 'openfoodfoundation:master' into master
2023-10-18 12:41:12 +02:00
filipefurtad0
2004abc8be
Sets pending test - issue #11350
...
changing the payment_total should not generate a new invoice; rather, it should update the current invoice
2023-10-18 11:20:48 +01:00
filipefurtad0
530cdacc77
Restructures tests as shared examples
...
Merges test files
2023-10-18 11:20:06 +01:00
filipefurtad0
8a1a14112b
Moves tests to shared examples file
2023-10-18 11:20:05 +01:00
filipefurtad0
8b249ee050
Adds unit tests for different attributes
2023-10-18 11:19:03 +01:00
Maikel
0477bef53a
Merge pull request #11657 from mkllnk/report-job-retries
...
Notify user about errors raised in reports
2023-10-18 15:38:34 +11:00
Gaetan Craig-Riou
b09054a76a
Update order state when moving back through checkout step
...
Some important logic happens after the order transition from one state
to another. In particular, voucher are recalculated. To fix any
inconsistency, we make sure the order is the state matching the checkout
step we are on.
2023-10-18 09:45:05 +11:00
Gaetan Craig-Riou
d0e38c8d10
Add order event back_to_payment and back_to_address
...
It gives the possibility to move an order back to payment state or
address state when going through the checkout steps
2023-10-18 09:36:37 +11:00
dependabot[bot]
83269af410
chore(deps): bump stripe from 9.4.0 to 10.0.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 9.4.0 to 10.0.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v9.4.0...v10.0.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-17 09:19:18 +00:00
Rachel Arnould
aecb55beb3
Merge pull request #11660 from dacook/products_v3_path
...
Hide old products screen when admin_style_v3 enabled
2023-10-17 10:45:01 +02:00
Gaetan Craig-Riou
d2952d46a6
Add the highlighted version of the "ship" icon
2023-10-17 13:35:01 +11:00
Gaetan Craig-Riou
7ce3fea7d5
Refactor tooltip on the backoffice orders page
2023-10-17 13:35:01 +11:00
Gaetan Craig-Riou
6a1664d2fd
Refactor "What's this" tooltip
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
01a13a814a
Improve tooltip partial
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
4639e53673
Remove insertToolTipMarkup
...
It's not great to have Stimulus controller rendering markup on `connect`
Stimulus is intended to add behavior to existing markup.
Plus add some documentation
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
31c537c5e0
Revert to using morph instead of cable_ready
...
The issue is with with the stimilus tooltip controller, it add some
element to the DOM which create issue when it's modified by
StimulusReflex. See here for a more detailed explanation:
https://github.com/stimulusreflex/stimulus_reflex/issues/314#issuecomment-702479357
2023-10-17 13:33:15 +11:00
Jean-Baptiste Bellet
3525320590
We should use cable_ready.inner_html instead of morph
...
To be sure that every stimulus controllers attached to the DOM that is replaced is will connected.
What I saw is that when using `morph`, the stimulus controller (specially `tooltip_controller`) were not attached to the DOM (and not disconnected as well) that triggered some errors in the console.
Adds test case for payment capture thanks to @filipefurtad0
2023-10-17 13:33:15 +11:00
David Cook
ad9048c595
Merge pull request #11627 from dacook/reflex-locale
...
Ensure dynamic modals always use selected locale
2023-10-17 10:23:58 +11:00
Maikel Linke
c0938d1607
Simplify view with number helpers
2023-10-16 16:37:47 +11:00
Maikel Linke
fcb6e36480
Format money amounts according to locale
...
It used to be formatted according to the currency. So even if the
default currency is USD but your locale is French then you should see it
formatted as $10.000,00 instead of the US formatting of $10,000.00.
2023-10-16 11:19:11 +11:00
Maikel
c87a10a855
Merge pull request #11672 from openfoodfoundation/dependabot/bundler/bullet-7.1.2
...
chore(deps-dev): bump bullet from 7.1.1 to 7.1.2
2023-10-16 10:54:38 +11:00
Maikel
ba00106e38
Merge pull request #11671 from openfoodfoundation/dependabot/bundler/acts-as-taggable-on-10.0.0
...
chore(deps): bump acts-as-taggable-on from 9.0.1 to 10.0.0
2023-10-16 10:54:12 +11:00
dependabot[bot]
d76dbb3592
chore(deps-dev): bump bullet from 7.1.1 to 7.1.2
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.1.1 to 7.1.2.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.1.1...7.1.2 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-15 23:24:48 +00:00
dependabot[bot]
c4adcf93c0
chore(deps): bump acts-as-taggable-on from 9.0.1 to 10.0.0
...
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on ) from 9.0.1 to 10.0.0.
- [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases )
- [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v9.0.1...v10.0.0 )
---
updated-dependencies:
- dependency-name: acts-as-taggable-on
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-15 23:23:51 +00:00
Maikel
9c5b986ab6
Merge pull request #11664 from openfoodfoundation/dependabot/bundler/rubocop-1.57.1
...
chore(deps-dev): bump rubocop from 1.57.0 to 1.57.1
2023-10-16 10:05:14 +11:00
Maikel
08e799c5fa
Merge pull request #11663 from dacook/tag_release
...
Update tag_release script
2023-10-16 10:02:41 +11:00
drummer83
c2b82651ee
Don't show credit owed when = 0
2023-10-13 20:51:12 +02:00
Konrad
246fceb214
Merge pull request #11634 from lauriejefferson/11610-left-align-all-table-content
...
[BUU] Left-align headers of new orders table
2023-10-13 19:58:09 +02:00
David Cook
6e6854f564
Fix payment state indicator
...
Now the correct class is added, we can see the little coloured circles again.
2023-10-13 19:25:12 +02:00
lauriejefferson
e234b71b25
removed empty spaces
2023-10-13 19:25:12 +02:00
lauriejefferson
2020a9fa76
changed table row alignment to align-left and removed padding from table header
2023-10-13 19:25:12 +02:00
Konrad
5859d2ff78
Merge pull request #11114 from lauriejefferson/not-paid-order-confirmations-resemble-paid-orders-7603
...
Not paid order confirmations resemble paid orders 7603
2023-10-13 18:52:10 +02:00
Konrad
d7b234c062
Merge pull request #11593 from rioug/11363-vouchers-fix-tax-included-in-price-amount
...
[Vouchers] Fix tax included in price amount
2023-10-13 18:22:11 +02:00
David Cook
8f30b27b58
Guard against nil values
...
These are validated and shouldn't be nil, but I suspect we have corrupt data causing problems here.
2023-10-13 15:54:24 +02:00
David Cook
a0b64cb58a
Remove unnecessary set_locale calls
...
The locale is now set in ApplicationReflex
2023-10-13 15:54:24 +02:00
David Cook
2915048afa
Always set locale for reflexes
...
I considered using I18nHelper like we do in controllers, but that is for choosing a locale, which we don't need to do for reflexes.
2023-10-13 15:54:24 +02:00
dependabot[bot]
52498b6bf4
chore(deps-dev): bump rubocop from 1.57.0 to 1.57.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.57.0 to 1.57.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.0...v1.57.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-13 09:58:15 +00:00
David Cook
9276469c53
Update checklist
2023-10-13 11:56:21 +11:00
David Cook
4eb169ea0d
Add a shortcut to draft new release
...
Next time, we can add a script to randomly choose a food-related release name ;)
2023-10-13 11:30:25 +11:00
David Cook
a13c95433e
Merge pull request #11548 from macanudo527/add_foreign_key_script
...
Add Spec that Generates Migrations for Missing Foreign Keys
2023-10-13 11:20:47 +11:00
David Cook
0b2a0d9e58
Update all locales with the latest Transifex translations
2023-10-13 11:15:45 +11:00
David Cook
655c16cca0
New bulk products screen shares path with old
...
The feature toggle will determine which bulk products screen shows. An additional products_old path is also temporarily added for easy reference.
Later, when the old screen is full removed, we'll probably rename the _v3 classes to tidy up.
2023-10-13 10:39:45 +11:00
Maikel
45db61be53
Merge pull request #11655 from openfoodfoundation/dependabot/bundler/devise-4.9.3
...
chore(deps): bump devise from 4.9.2 to 4.9.3
2023-10-13 08:30:08 +11:00
Maikel
604cc10c3f
Merge pull request #11654 from openfoodfoundation/dependabot/bundler/rubocop-1.57.0
...
chore(deps-dev): bump rubocop from 1.56.4 to 1.57.0
2023-10-13 08:29:29 +11:00
lauriejefferson
43232a5d63
removed not-paid styling for credit owed
2023-10-12 11:50:30 -04:00
Konrad
cc8898e074
Merge pull request #11219 from abdellani/fix-tax-rates-rendering-when-invoice-enabled
...
fix Viewing an invoice with the instance's invoice setting set to alternative model leads to an error 500
2023-10-12 17:47:27 +02:00
Konrad
26fa85d89b
Merge pull request #11651 from HillaryOkello/master
...
Display ordered lists uniform with unordered lists in Trix editor
2023-10-12 17:00:43 +02:00
Konrad
f87186373c
Merge pull request #11647 from dacook/image-validation
...
Only validate image when changed
2023-10-12 15:42:22 +02:00
Maikel Linke
702f3b7784
Notify user about errors raised in reports
2023-10-12 16:31:13 +11:00
Maikel Linke
f61a2fa2bf
Rescue errors in report generation
...
So we can report them to Bugsnag and the job isn't marked as failed and
therefore won't repeat.
2023-10-12 16:01:52 +11:00
Maikel Linke
477ca39e58
Update spec
2023-10-12 15:40:06 +11:00
Maikel Linke
f4fde0a42c
Trying to clarify voucher tax amount
...
The whole concept is confusing. Maybe translators will find better
versions.
2023-10-12 15:20:17 +11:00
Maikel Linke
f83e78a5b8
Clarify adjustment data only for display
...
We are not creating a new adjustment here.
2023-10-12 15:16:38 +11:00
Maikel Linke
74c8f06e80
Simplify helper with extracted method
2023-10-12 14:17:41 +11:00
Maikel Linke
45dd5cc40a
Style/SingleLineDoEndBlock: Prefer multiline do...end block
2023-10-12 10:10:42 +11:00
dependabot[bot]
4b38817aff
chore(deps-dev): bump rubocop from 1.56.4 to 1.57.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.4 to 1.57.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.4...v1.57.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 22:55:03 +00:00
Maikel
17c1ccc509
Merge pull request #11653 from openfoodfoundation/dependabot/bundler/paranoia-2.6.3
...
chore(deps): bump paranoia from 2.6.2 to 2.6.3
2023-10-12 09:52:39 +11:00
Maikel
e3e7031a91
Merge pull request #11649 from openfoodfoundation/dependabot/bundler/rswag-specs-2.11.0
...
chore(deps-dev): bump rswag-specs from 2.10.1 to 2.11.0
2023-10-12 09:51:41 +11:00
Maikel
5526006add
Merge pull request #11652 from openfoodfoundation/dependabot/bundler/responders-3.1.1
...
chore(deps): bump responders from 3.1.0 to 3.1.1
2023-10-12 09:27:56 +11:00
dependabot[bot]
1efff07953
chore(deps): bump devise from 4.9.2 to 4.9.3
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.2 to 4.9.3.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.2...v4.9.3 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 22:18:53 +00:00
dependabot[bot]
a8b4e9b070
chore(deps-dev): bump rswag-specs from 2.10.1 to 2.11.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.10.1 to 2.11.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.10.1...2.11.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 22:12:51 +00:00
Maikel
903bf8a725
Merge pull request #11650 from openfoodfoundation/dependabot/bundler/rswag-api-2.11.0
...
chore(deps): bump rswag-api from 2.10.1 to 2.11.0
2023-10-12 09:11:17 +11:00
dependabot[bot]
b8b6641a05
chore(deps): bump paranoia from 2.6.2 to 2.6.3
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.2...v2.6.3 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 22:07:31 +00:00
dependabot[bot]
0d3a1417d6
chore(deps): bump responders from 3.1.0 to 3.1.1
...
Bumps [responders](https://github.com/heartcombo/responders ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/heartcombo/responders/releases )
- [Changelog](https://github.com/heartcombo/responders/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/responders/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: responders
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 22:06:10 +00:00
Maikel
c047a2c70c
Merge pull request #11648 from openfoodfoundation/dependabot/bundler/rswag-ui-2.11.0
...
chore(deps): bump rswag-ui from 2.10.1 to 2.11.0
2023-10-12 09:03:14 +11:00
Konrad
047360e839
Merge pull request #11646 from dacook/buu-products-menu
...
Show only the new products page in the menu
2023-10-11 21:31:38 +02:00
HillaryOkello
d8e5f7ae4c
Remove padding-top for the ordered lists
2023-10-11 15:55:52 +03:00
Mohamed ABDELLANI
1c2aa1c370
fix linter issue
2023-10-11 11:00:37 +01:00
Mohamed ABDELLANI
c750602b52
remove duplicated code
2023-10-11 10:38:45 +01:00
dependabot[bot]
54d3b39b2e
chore(deps): bump rswag-api from 2.10.1 to 2.11.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.10.1 to 2.11.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.10.1...2.11.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 09:27:01 +00:00
dependabot[bot]
61bfde4e80
chore(deps): bump rswag-ui from 2.10.1 to 2.11.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.10.1 to 2.11.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.10.1...2.11.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 09:24:44 +00:00
Mohamed ABDELLANI
7cb200e21e
fix linting errors
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
4a74396bcc
add 'app/models/invoice/data_presenter.rb' to Metrics/ClassLength:Exclude
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
9950dd90f7
fix display_checkout_taxes_hash
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
7eabb9a170
move include ::ActionView::Helpers::NumberHelper to Invoice::DataPresenter::Base
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
aa4798d35c
add adjustables to the list of objects to serialize when creating an invoice
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
fc519da83b
update the invoice system tests to run with invoice feature (enabled/disabled)
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
d40338bed5
add adjustment originators to the order serialization
...
for some helpers like display_checkout_taxes_hash, it's needed to access the tax rates through the adjument's originator.
The adjustment's originator will store the minimal details: id, type and amount
2023-10-11 09:26:50 +01:00
Mohamed ABDELLANI
a2b06fa200
fix cloning all_eligible_adjustments array on DataPresenter#checkout_adjustments
2023-10-11 09:26:50 +01:00
Mohamed ABDELLANI
b027387bee
add :originator_type to Invoice::AdjustmentSerializer
2023-10-11 09:26:50 +01:00
Mohamed ABDELLANI
68a6fb132a
implement display_adjustment_tax_rates helper on the adjustment presenter
...
For every adjustment a list of tax rates will be created using TaxRateFinder.tax_rates_of.
This will prevent running the queries to find the tax rates during the invoice generation.
2023-10-11 09:26:50 +01:00
Mohamed ABDELLANI
33826631a3
reimplement the display_line_item_tax_rates helper on the line item presenter
...
1. reimplment the helper on the LintItem presenter
2. add the tax rate associated to the line items to the list of objects to serialize during the order serialization.
3. implement a presenter for the introducer tax rates.
2023-10-11 09:26:49 +01:00
Maikel
7fe7176e5d
Merge pull request #11641 from dacook/release-template
...
Update feature toggle title
2023-10-11 16:56:56 +11:00
David Cook
472cd9b55c
Merge pull request #11639 from openfoodfoundation/dependabot/bundler/bullet-7.1.1
...
chore(deps-dev): bump bullet from 7.1.0 to 7.1.1
2023-10-11 14:14:27 +11:00
David Cook
32b2e572b3
Merge pull request #11643 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.6
...
chore(deps): bump sidekiq from 7.1.5 to 7.1.6
2023-10-11 14:01:13 +11:00
dependabot[bot]
ca2d175650
chore(deps-dev): bump bullet from 7.1.0 to 7.1.1
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.1.0 to 7.1.1.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.1.0...7.1.1 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-11 02:52:50 +00:00
David Cook
64ba01a55c
Merge pull request #11637 from mkllnk/spec-report-order
...
Test customer report filtering without sorting
2023-10-11 13:49:25 +11:00
David Cook
69b2386c52
Merge pull request #11631 from openfoodfoundation/dependabot/bundler/awesome_nested_set-3.6.0
...
chore(deps): bump awesome_nested_set from 3.5.0 to 3.6.0
2023-10-11 13:47:55 +11:00
David Cook
fd6bd72e7a
Merge pull request #11630 from openfoodfoundation/dependabot/bundler/stripe-9.4.0
...
chore(deps): bump stripe from 9.3.0 to 9.4.0
2023-10-11 13:46:49 +11:00
David Cook
b42cf9735f
Only validate an image if it has been changed
...
Best viewed with whitespace ignored.
2023-10-11 10:12:52 +11:00
David Cook
31b5be73f9
Add spec
2023-10-11 10:12:52 +11:00
lauriejefferson
e056ba42db
added 'credit owed' label and removed red styling when balance <= 0
2023-10-10 17:14:16 -04:00
David Cook
99205e435c
Show only the new products page in the menu
...
When the feature toggle is enabled, we don't want to see the old products page. It's a bit broken and causes confusion. But we still want to be able to access it by the URL for now.
2023-10-10 22:09:26 +11:00
Konrad
0bd4fe315c
Merge pull request #11620 from openfoodfoundation/dependabot/bundler/devise-i18n-1.12.0
...
chore(deps): bump devise-i18n from 1.11.0 to 1.12.0
2023-10-10 12:36:42 +02:00
dependabot[bot]
f57d139909
chore(deps): bump sidekiq from 7.1.5 to 7.1.6
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.5 to 7.1.6.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.5...v7.1.6 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-10 10:05:08 +00:00
David Cook
3d821722e1
Update feature toggle title
...
[skip ci] because this isn't covered (and doesn't need to be).
2023-10-10 16:30:49 +11:00
Maikel Linke
228f69f13e
Test customer report filtering without sorting
...
The report doesn't seem to sort. So the specs don't expect that either
now. These specs were flaky before, depending on the random order in the
database query result.
2023-10-09 12:05:24 +11:00
Maikel
90c25d604b
Merge pull request #11441 from macanudo527/fix_rails_HasManyOrHasOneDependent
...
Fix Rails/HasManyOrHasOneDependent
2023-10-09 11:44:23 +11:00
Maikel
b8f15ca52f
Merge pull request #11632 from openfoodfoundation/dependabot/bundler/bullet-7.1.0
...
chore(deps-dev): bump bullet from 7.0.7 to 7.1.0
2023-10-09 10:56:00 +11:00
Konrad
6cfc20fcaa
Merge pull request #11345 from abdellani/support-enabling-invoices-to-individual-users
...
Support enabling invoices to individual users
2023-10-08 22:22:33 +02:00
David Cook
1c0ebfe61e
Add comment
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
95e7900585
test print invoice button under ACTIONS
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
13b366e7ff
list send invoice and print invoice under actions even when the invoice feature is enabled
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
a9719a798f
fix order mailer tests
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
f047deaf12
load the latest invoice when user tries to print an order
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
3f4eab2a0a
update the invoice renderer to check if the feature is enable for individual user
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
dce096a56e
check if invoices feature is enabled for the current user before showing invoices tab
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
614c8a5060
update order mailer to check if invoices feature is enabled for the current user
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
adecf64cf3
update bulk invoice job to check if the invoices feature is enabled for the current user
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
bd2a1b3e22
check if invoices feature is enabled for the current user before printing a single invoice
2023-10-08 21:47:17 +02:00
Konrad
944925eb06
Merge pull request #11603 from murjax/prevent-customer-edit-shipped-9235
...
Prevent customers from editing shipped orders
2023-10-08 21:42:18 +02:00
Konrad
0a36f7983f
Merge pull request #11623 from ccozkan/issue-11607-timeshift-in-customers-report
...
Fix occurring time shift in customers report results
2023-10-08 19:02:02 +02:00
Çağrı Özkan
877ea12645
Call in_time_zone on boundary parameters
2023-10-08 17:44:24 +02:00
Konrad
eb9c8bd678
Merge pull request #11618 from openfoodfoundation/dependabot/npm_and_yarn/trix-2.0.7
...
chore(deps): bump trix from 2.0.6 to 2.0.7
2023-10-08 17:34:41 +02:00
Konrad
ef855e8887
Merge pull request #11619 from ccozkan/issue-11611
...
Add ability to customers report to filter with open ended boundaries
2023-10-08 16:28:52 +02:00
dependabot[bot]
ebfacea17b
chore(deps): bump stripe from 9.3.0 to 9.4.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 9.3.0 to 9.4.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v9.3.0...v9.4.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-06 12:25:38 +00:00
Rachel Arnould
abfd316b3d
Merge pull request #11565 from dacook/buu-editing-part4-11059
...
[BUU] Inline error messages and validation
2023-10-06 14:23:58 +02:00
David Cook
117085aeba
Transform weight before validation
...
I guess validates_length_from_database also validates numbers. That's not a bad thing.
So now it's being validated, we should validate the transformed value that will be saved to the database.
2023-10-06 14:15:07 +02:00
David Cook
9a9be8dacd
Validate length of variant fields
2023-10-06 14:15:07 +02:00
David Cook
875d083a1d
There's a gem for that [add gem]
2023-10-06 14:15:07 +02:00
David Cook
3ec6386e1c
Validate length of some product fields
...
We know if the values are too long, so let's provide a useful message rather than generating an unhandled database error.
This code seems rather repetetive, it would be good to use a shared module. I wonder if there's a gem for that.
Note that the existing /products/*/edit screen doesn't even handle validation errors yet, but that's something for another day..
2023-10-06 14:15:07 +02:00
David Cook
fee126d6e1
Style form error messages
...
With an icon, and sentence case (upcase_first is similar to humanize, but simpler (https://dev.to/junko911/rails-helper-methods-to-change-the-form-of-strings-1h9c#upcase-first ))
2023-10-06 14:15:07 +02:00
David Cook
3b19a19776
Show inline errors for product fields
...
The form helper () doesn't work for this case, but it seems we can call it directly like this instead. I'd like to fix the helper, but got stuck this time.
2023-10-06 14:15:07 +02:00
David Cook
5e478b8a76
Vertically align non-input content in table rows
2023-10-06 14:15:07 +02:00
David Cook
836f5a1fb3
Remove unused withError class
...
It added specificity but had no use.
I reviewed a couple of screens to make sure:
- /admin/orders/Rx/customer
- /admin/properties/new
I have to confess I don't know how Spree::Admin::BaseHelper is included, or where it's used.
Best viewed with whitespace ignored.
2023-10-06 14:15:07 +02:00
dependabot[bot]
734e80880b
chore(deps-dev): bump bullet from 7.0.7 to 7.1.0
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.0.7 to 7.1.0.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.7...7.1.0 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-06 09:23:35 +00:00
dependabot[bot]
0adf44e525
chore(deps): bump awesome_nested_set from 3.5.0 to 3.6.0
...
Bumps [awesome_nested_set](https://github.com/collectiveidea/awesome_nested_set ) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/collectiveidea/awesome_nested_set/releases )
- [Changelog](https://github.com/collectiveidea/awesome_nested_set/blob/master/CHANGELOG )
- [Commits](https://github.com/collectiveidea/awesome_nested_set/compare/v3.5.0...v3.6.0 )
---
updated-dependencies:
- dependency-name: awesome_nested_set
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-06 09:16:36 +00:00
David Cook
9e04dc36d1
Merge pull request #11629 from mkllnk/tag-release
...
Add script to create patch release tags
2023-10-06 15:16:45 +11:00
Maikel Linke
74a8b1e721
Add script to create patch release tags
2023-10-06 13:58:37 +11:00
Neal Chambers
085d0f27f7
Move Timestamp Generation into its own Method
2023-10-06 11:19:31 +09:00
Neal Chambers
aaa42ce410
Add Filtering for Optional Relationships
2023-10-06 11:06:54 +09:00
Neal Chambers
3c51b48225
Fix Formatting and Bugs
2023-10-06 11:06:54 +09:00
Neal Chambers
6d22ec5605
Improve Migration Timestamping
2023-10-06 11:06:54 +09:00
Neal Chambers
2b4bf185d6
Replace Duplicate Model Detection with Column Specific Foreign Key Check
2023-10-06 11:06:54 +09:00
Neal Chambers
f02da9f59e
Update schema.rb with new Foreign Keys
2023-10-06 11:06:54 +09:00
Neal Chambers
f1c61fa3aa
Add Option to Write Migrations to Disk
2023-10-06 11:06:54 +09:00
Neal Chambers
fd8e94cb50
Update Migrations to Include Commented-Out Orphaned Record Query
2023-10-06 11:06:54 +09:00
Neal Chambers
2d6784b88d
Allow Full Modulized Class Name to be Used for TODOs
2023-10-06 11:06:54 +09:00
Neal Chambers
d4c363ac39
Reduce Cyclomatic Complexity
2023-10-06 11:06:54 +09:00
Neal Chambers
099b2f455f
Remove Unified Orphaned Records SQLs
2023-10-06 11:06:54 +09:00
Neal Chambers
9df42f596c
Add SQL to Migration Files
2023-10-06 11:06:54 +09:00
Neal Chambers
7ec1f69e2a
Create Foreign Key TODO
2023-10-06 11:06:54 +09:00
Neal Chambers
800d50d732
Add Foreign Key Column to Migrations
2023-10-06 11:06:54 +09:00
Neal Chambers
816ffe6e32
Convert rake task to spec
2023-10-06 11:06:54 +09:00
Neal Chambers
6729218846
Improve SQL query to Allow for Optional Relationships
2023-10-06 11:06:54 +09:00
Neal Chambers
72e75c0e2d
Remove Delete on Cascade from Migrations
2023-10-06 11:06:54 +09:00
Neal Chambers
3590da6106
Remove Old Migrations
2023-10-06 11:06:54 +09:00
Neal Chambers
bf2c6128a7
Add Foreign Key Column
2023-10-06 11:06:54 +09:00
Neal Chambers
78cb4c6adc
Add migrations to add foreign keys to database
2023-10-06 11:06:54 +09:00
Neal Chambers
5b87890141
Add SQL script to check for Orphaned Records
2023-10-06 11:06:54 +09:00
Neal Chambers
cb864411ee
Add Rake Task that Generates Migrations for Missing Foreign Keys
2023-10-06 11:06:50 +09:00
David Cook
cd34e160bf
Fix deleting of return_authorizations
...
return_authorizations have a stock_location_id, not the other way round. So there's no dependent field to nullify.
2023-10-06 10:58:49 +09:00
Neal Chambers
fec59e5ae2
Apply Changes Suggested by Code Review
2023-10-06 10:58:49 +09:00
Neal Chambers
cf07a055d0
Fix Rails/HasManyOrHasOneDependent with nil
2023-10-06 10:58:49 +09:00
Neal Chambers
e49489cd1c
Fix invoices dependent relationship
2023-10-06 10:58:49 +09:00
Neal Chambers
d295a3bdae
Update .rubocop_todo.yml for Reversions
2023-10-06 10:58:49 +09:00
Neal Chambers
2520d222bb
Fix Rails/HasManyOrHasDependent with restrict_with_exception
2023-10-06 10:58:49 +09:00
Neal Chambers
180cd4abe6
Revert Complicated Rails/HasManyOrHasOneDependent Errors
2023-10-06 10:58:49 +09:00
Neal Chambers
e22e08e666
Change destroy to nullify
2023-10-06 10:58:49 +09:00
Neal Chambers
7c9bc58a4b
Add nullify to orders relationship, instead of manually nullifying
2023-10-06 10:58:49 +09:00
Neal Chambers
921347f0f2
Update .rubocop_todo.yml
2023-10-06 10:58:49 +09:00
Neal Chambers
7f8ac94933
Fix Rails/HasManyOrHasOneDependent with nil
2023-10-06 10:58:49 +09:00
Neal Chambers
019b54ea95
Fix Rails/HasManyOrHasOneDependent with delete_all
2023-10-06 10:58:49 +09:00
Neal Chambers
070d2cb855
Fix stock_movements relation in variant
2023-10-06 10:58:49 +09:00
Neal Chambers
825342914d
Fix Rails/HasManyOrHasOneDependent with nullify
2023-10-06 10:58:49 +09:00
Neal Chambers
b76fb10d46
Fix Rails/HasManyOrHasOneDependent with Destroy
2023-10-06 10:58:49 +09:00
Neal Chambers
53f5d63e4a
Delete Rails/HasManyOrHasOneDependent TODOs
2023-10-06 10:58:49 +09:00
Maikel Linke
ff60dacebd
Update all locales with the latest Transifex translations
2023-10-06 11:23:43 +11:00
David Cook
3f27fb69b3
Merge pull request #11625 from aisayo/patch-1
...
Update README.md
2023-10-05 09:52:03 +11:00
David Cook
ee13d1072c
Merge pull request #11624 from filipefurtad0/make_seed_data_enteprise_visible
...
[dev ENV only] Adds attribute to enterprise factory
2023-10-05 09:10:23 +11:00
aisayo
97f315b363
Update README.md
...
Outdated instructions
2023-10-04 15:34:37 -04:00
filipefurtad0
0e699e9cee
Adds attribute to enterprise factory
...
so that sample data rake task creates visible enterprises by default
2023-10-04 18:00:36 +01:00
lauriejefferson
0cda8d7d4c
removed paid styling and added currency formatter to payment_total
2023-10-04 09:30:05 -04:00
Sigmund Petersen
4e8cd330b3
Merge pull request #11571 from dacook/buu-editing-fixups
...
[BUU] editing fixups
2023-10-04 13:48:31 +02:00
David Cook
6f43165006
Show generic error message when StimulusReflex fails
...
I decided not to invest the time to figure out how to test this..
The messages should have the same effect as the 500 error, but not technically a 500 because it's not handling a HTTP response. The documentation seems to state this covers server-side errors only (not network errors for example). I couldn't find any way to handle network errors with action cable.
2023-10-04 13:40:36 +02:00
David Cook
6d35b1ac71
Fix bulk form input styles
...
'header' fields are meant to be bold, and the field backgrounds are meant to match the cell background colour.
2023-10-04 13:40:36 +02:00
David Cook
cd63ab63d8
Refactor form code
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-10-04 13:40:36 +02:00
David Cook
ed207e3df6
DRY up code
2023-10-04 13:40:36 +02:00
David Cook
4467758a9f
Apply code suggestion
...
Co-authored-by: Jean-Baptiste Bellet <jb.bellet@gmail.com >
2023-10-04 13:40:36 +02:00
David Cook
136b370de1
Merge pull request #11621 from openfoodfoundation/dependabot/bundler/valid_email2-5.1.0
...
chore(deps): bump valid_email2 from 5.0.5 to 5.1.0
2023-10-04 15:33:26 +11:00
David Cook
7ffe318352
Merge pull request #11616 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.5
...
chore(deps): bump sidekiq from 7.1.4 to 7.1.5
2023-10-04 15:21:03 +11:00
dependabot[bot]
2b2bb6d46b
chore(deps): bump valid_email2 from 5.0.5 to 5.1.0
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.0.5 to 5.1.0.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.0.5...v5.1.0 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-04 03:50:57 +00:00
dependabot[bot]
34829ea53e
chore(deps): bump devise-i18n from 1.11.0 to 1.12.0
...
Bumps [devise-i18n](https://github.com/tigrish/devise-i18n ) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/tigrish/devise-i18n/releases )
- [Changelog](https://github.com/tigrish/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tigrish/devise-i18n/compare/v1.11.0...v1.12.0 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-04 03:49:24 +00:00
David Cook
057a9f73ed
Merge pull request #11605 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.21.2
...
chore(deps-dev): bump rubocop-rails from 2.21.1 to 2.21.2
2023-10-04 14:49:03 +11:00
Maikel
05b30a72e5
Merge pull request #11604 from openfoodfoundation/dependabot/bundler/valid_email2-5.0.5
...
chore(deps): bump valid_email2 from 5.0.3 to 5.0.5
2023-10-04 14:45:45 +11:00
Maikel
2ac2b30b14
Merge pull request #11588 from filipefurtad0/split_subscription_spec
...
Splits bottleneck system/admin/subscriptions_spec.rb
2023-10-04 13:33:20 +11:00
Çağrı Özkan
f93fcd347b
Rubocop fix
2023-10-04 02:00:21 +03:00
Çağrı Özkan
a5a13761a8
Filter with open ended boundaries upon missing params
2023-10-04 01:05:41 +03:00
Ryan Murphy
4db6570039
9235: Prevent customers from editing shipped orders
2023-10-03 08:36:57 -04:00
dependabot[bot]
f4fce6e69c
chore(deps): bump trix from 2.0.6 to 2.0.7
...
Bumps [trix](https://github.com/basecamp/trix ) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/basecamp/trix/releases )
- [Commits](https://github.com/basecamp/trix/compare/v2.0.6...v2.0.7 )
---
updated-dependencies:
- dependency-name: trix
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-03 09:52:21 +00:00
filipefurtad0
14caf3b25c
Moves helper into support folder
...
Wraps SubscripionHelper module around definitions
2023-10-03 09:49:26 +01:00
filipefurtad0
181ddcefbc
Updates rubocop_todo file
...
Removes local untracked files
2023-10-03 09:49:26 +01:00
filipefurtad0
bc73d09438
Declares enable_subscriptions separately
2023-10-03 09:49:26 +01:00
filipefurtad0
96432ebec2
Splits files into new folder
...
Creates helper file for existing methods
2023-10-03 09:49:26 +01:00
filipefurtad0
8bc2feda23
Asserts for subscription instructions and tab
2023-10-03 09:49:26 +01:00
filipefurtad0
b554308f10
Sets correct context
2023-10-03 09:49:26 +01:00
dependabot[bot]
db3cdd95a3
chore(deps): bump sidekiq from 7.1.4 to 7.1.5
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.4 to 7.1.5.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.4...v7.1.5 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-03 05:28:17 +00:00
David Cook
2558855ad5
Merge pull request #11595 from openfoodfoundation/dependabot/bundler/rubocop-1.56.4
...
chore(deps-dev): bump rubocop from 1.56.3 to 1.56.4
2023-10-03 16:26:21 +11:00
dependabot[bot]
372defe20f
chore(deps-dev): bump rubocop-rails from 2.21.1 to 2.21.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.21.1 to 2.21.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.21.1...v2.21.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-02 09:18:16 +00:00
dependabot[bot]
0cd87a7bbf
chore(deps): bump valid_email2 from 5.0.3 to 5.0.5
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.0.3 to 5.0.5.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.0.3...v5.0.5 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-02 09:06:58 +00:00
Maikel
b122c93055
Merge pull request #11586 from macanudo527/fix_stylehash_11
...
Fix Style/HashSyntax 12/13
2023-10-02 16:25:21 +11:00
Maikel Linke
fec6caf576
Remove unnecessary Rubocop disable
2023-10-02 16:18:51 +11:00
Gaetan Craig-Riou
7f2c1feaf8
Fix rubocop warning
2023-10-02 15:58:13 +11:00
Gaetan Craig-Riou
1a66f3d94f
Fix system spec to take into account discounted tax
2023-10-02 15:58:13 +11:00
Gaetan Craig-Riou
8d639c14cb
Add a fake adjustment voucher tax on admin order page
...
When tax are included in price, voucher tax is stored in the voucher
adjustment and not as its own adjustment. So we add a "fake adjustment"
for display purposes.
2023-10-02 15:58:12 +11:00
Gaetan Craig-Riou
8254bd9625
Take into account voucher tax part when displaying tax included in price
2023-10-02 15:58:12 +11:00
Maikel
350ca3b778
Merge pull request #11479 from filipefurtad0/split_split_checkout
...
Splits checkout files
2023-10-02 12:01:20 +11:00
Konrad
8150a8b04a
Merge pull request #11579 from macanudo527/remove_delegate_belongs_to
...
Remove Deprecated delegate_belongs_to
2023-10-01 13:19:22 +02:00
Konrad
11ea4d93a9
Merge pull request #11584 from openfoodfoundation/dependabot/npm_and_yarn/trix-2.0.6
...
chore(deps): bump trix from 2.0.5 to 2.0.6
2023-10-01 12:49:32 +02:00
Konrad
33d9ed4000
Merge pull request #11591 from dacook/admin-users-api-key-9833
...
Redirect to admin users edit path on success
2023-10-01 12:20:46 +02:00
Konrad
06ebeeac0f
Merge pull request #11543 from rioug/11364-Voucher-fix-tax-report
...
[Vouchers] Fix Sales Tax Totals By Order report
2023-10-01 02:09:33 +02:00
dependabot[bot]
89414ba821
chore(deps-dev): bump rubocop from 1.56.3 to 1.56.4
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.3 to 1.56.4.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.3...v1.56.4 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-29 09:53:53 +00:00
lauriejefferson
7320bb5af1
removed styling for paid orders and removed row for non oustanding balance
2023-09-28 20:02:58 -04:00
Neal Chambers
f3382d78c4
Update .rubocop_todo.yml
2023-09-29 08:51:48 +09:00
Neal Chambers
57d2f04330
Fix Style/HashSyntax
2023-09-29 08:51:48 +09:00
Gaetan Craig-Riou
dd0279c983
Update all locales with the latest Transifex translations
2023-09-28 11:52:49 +02:00
David Cook
e844d71abc
Redirect to edit path on success
...
Simply rendering the edit form on the posted path is problematic. For example if you refresh the path you get a 404.
But if there's errors, we want to render the form with unsaved values so you can see the errors and try again.
2023-09-28 09:41:44 +10:00
Maikel
c1587b689a
Merge pull request #11589 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.136.0
...
chore(deps): bump aws-sdk-s3 from 1.135.0 to 1.136.0
2023-09-28 09:20:36 +10:00
Maikel Linke
3fc78e1f7f
Update Rubocop todo file
2023-09-28 08:26:35 +10:00
filipefurtad0
a634283ec5
Removes unecessary shipping method setup - guest
2023-09-27 22:20:31 +01:00
filipefurtad0
adede9df03
Removes unecessary shipping method setup - details
2023-09-27 22:19:37 +01:00
filipefurtad0
6763095f26
Removes unecessary shipping method setup - payment
2023-09-27 22:19:37 +01:00
filipefurtad0
3702a2e7b1
Removes unecessary shipping method setup - summary
2023-09-27 22:19:31 +01:00
filipefurtad0
25c58426db
Moves split-checkout files to own folder
...
Removes split_ prefix
2023-09-27 21:45:03 +01:00
dependabot[bot]
4d7f21eec4
chore(deps): bump aws-sdk-s3 from 1.135.0 to 1.136.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.135.0 to 1.136.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-27 09:05:00 +00:00
Gaetan Craig-Riou
33f3c660a4
Fix rubocop warning
2023-09-26 11:21:05 +02:00
filipefurtad0
a4abedf3e3
Fixes rubocop issues
2023-09-26 10:18:28 +01:00
filipefurtad0
d3f9f989f6
Moves summary-step scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
67793c78ad
Moves payment-step scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
a0611057f0
Moves details-step/not selecting shipping method scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
b8f7d6102e
Moves guest/out of stock scenarios into dedicated file
2023-09-26 10:18:28 +01:00
Gaetan Craig-Riou
b129b9f1d0
DRY up specs
2023-09-26 10:50:58 +02:00
Gaetan Craig-Riou
e9051f5c58
As per review comment, clarify specs
...
And some DRYing
2023-09-26 10:26:06 +02:00
David Cook
91b251acd4
Refactor
2023-09-26 10:56:44 +10:00
Neal Chambers
50eb8f31f2
Remove Deprecated delegate_belongs_to
2023-09-26 09:50:08 +09:00
David Cook
4e05047cc6
Merge pull request #11583 from macanudo527/fix_stylehash_10
...
Fix Style/HashSyntax 11/13
2023-09-26 10:38:54 +10:00
dependabot[bot]
8797132117
chore(deps): bump trix from 2.0.5 to 2.0.6
...
Bumps [trix](https://github.com/basecamp/trix ) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/basecamp/trix/releases )
- [Commits](https://github.com/basecamp/trix/compare/v2.0.5...v2.0.6 )
---
updated-dependencies:
- dependency-name: trix
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-25 09:14:02 +00:00
Gaetan Craig-Riou
02aaf6f692
Remove voucher validation on code format
...
The code doesn't rely on label match any more so this restriction
is not necessary anymore
2023-09-25 09:49:55 +02:00
Gaetan Craig-Riou
097b775fa0
Add metadata before saving adjustment
...
Rails may put it all in one transaction
Co-authored-by: Maikel <maikel@email.org.au >
2023-09-25 17:44:16 +10:00
Neal Chambers
48132b055f
Update .rubocop_todo.yml
2023-09-25 13:15:54 +09:00
Neal Chambers
70e218d2e9
Fix Style/HashSyntax
2023-09-25 13:15:38 +09:00
Maikel
51f125e301
Merge pull request #11582 from macanudo527/fix_stylehash_9
...
Fix Style/HashSyntax 10/13
2023-09-25 13:43:38 +10:00
Neal Chambers
232ffb1eb8
Update .rubocop_todo.yml
2023-09-24 22:41:48 +09:00
Neal Chambers
35e8f88943
Fix Style/HashSyntax
2023-09-24 22:41:27 +09:00
Rachel Arnould
aa489d4cd6
Merge pull request #11185 from jibees/11155-improve-customer-addresses-report
...
Admin, reports: improve customer addresses report
2023-09-22 18:06:47 +02:00
Jean-Baptiste Bellet
2803f1c6b2
Group all orders by customer_id, email and distributor_id
...
Therefore have one (and only) row per customer
Co-Authored-By: Maikel <maikel@email.org.au >
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
9ce89125a4
Fix linter error: line is too long
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d6c10170da
Use plain text instead of computed date in specs
...
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-plain-text-over-method-calls-in-expected-values
2023-09-22 16:44:33 +01:00
jibees
5eab033a80
Improve indentation
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-09-22 16:44:33 +01:00
Maikel Linke
adc5bf6e93
Simplify date filter in customers report
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
82ccdcca70
Customers report has only one report: Customers
...
No more `addresses` report
+ Fix pre-existing rubocop issues
+ Create method to simplify and remove CyclomaticComplexity error
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
5edc8d8ce1
Delete Mailing List report
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
c6c9cdca65
Add last completed order date
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d2fbaa7cfd
Add total amount spent at the shop for the customer
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d55098f94f
Add the number of orders for the customer
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
1378202732
Disable rubocop warning. Not sure how to handle it actually
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
cc26da6560
We'll need to get all the orders per line to count and sum them; prepare it
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
c134de850c
Add filter on completed_at of an order
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
4f332504af
Add new line at the end of file
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
9e295146cb
Remove supplier filter
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
baff4b5399
Rename 'distributor' to 'hub'
2023-09-22 16:44:33 +01:00
Gaetan Craig-Riou
19fc1fab8c
As per review, visit page directly to save time
...
We still visit the page as user would do once to make sure it is
working.
2023-09-22 11:35:56 +02:00
filipefurtad0
b913e5c851
Update all locales with the latest Transifex translations
2023-09-22 10:29:52 +01:00
Gaetan Craig-Riou
03ce39d5c5
Add metadata to tax related voucher adjustment
...
In the scenario where you have tax excluded from price, when adding
a voucher to an order, we create 2 voucher adjusments. One of them
represent the tax part of the voucher, and has a label starting with
"Tax". To better differentiate them and allow a reliable way to
query it, we add a metadata entry.
2023-09-22 11:16:21 +02:00
Rachel Arnould
a3ca7e9032
Merge pull request #11568 from jibees/11069-buu-fully-update-the-details-of-my-products-and-variants-1
...
🚧 [BUU] Add `Edit` link into a small menu on the last Actions column to the right of the table
2023-09-22 10:30:01 +02:00
Gaetan Craig-Riou
0a68300e40
Remove Voucher scenario
...
It is now covered by unit test
2023-09-22 10:22:47 +02:00
Gaetan Craig-Riou
25adaaa6ea
Simplify test set up
2023-09-22 10:17:50 +02:00
Gaetan Craig-Riou
f54846829d
Add test for #voucher_tax_adjustment
...
And mock calls to VoucherAdjustmentsService
2023-09-22 10:17:50 +02:00
Gaetan Craig-Riou
9e49da8fae
Add unit test for Reporting::Reports::SalesTax::SalesTaxTotalsByOrder
...
And a small refactoring.
Currently it only covers tax excluded from price
2023-09-22 10:17:50 +02:00
Gaetan Craig-Riou
3197480121
Prevent voucher from starting with "Tax"
...
Plus spec
2023-09-22 10:17:50 +02:00
Gaetan Craig-Riou
bec5ad55dd
Use VoucherAdjustmentsService to retrieve tax part of the voucher
2023-09-22 10:17:50 +02:00
Gaetan Craig-Riou
7c34145ed7
Add voucher_included_tax and voucher_excluded_tax
...
It retrieves the tax part of the voucher adjustment for tax included
in price and tax excluded from price respectively.
2023-09-22 10:17:40 +02:00
Gaetan Craig-Riou
b620e413f4
Merge pull request #11378 from mkllnk/dfc-ofn-product-group-id
...
[DFC API] Add custom OFN product id to DFC SuppliedProduct
2023-09-22 17:57:11 +10:00
Jean-Baptiste Bellet
b9cd8ee462
Factorize elements into beforeEach block
2023-09-22 09:34:36 +02:00
Jean-Baptiste Bellet
458a031558
Create a private function for event listener
2023-09-22 09:30:40 +02:00
Maikel Linke
847ddab4e6
Improve readability of assignment without blank lines
2023-09-22 17:18:49 +10:00
Maikel
886988e24a
Merge pull request #11578 from macanudo527/fix_stylehash_8
...
Fix Style/HashSyntax 9/13
2023-09-22 15:09:46 +10:00
Neal Chambers
4a3a246e7a
Update .rubocop_todo.yml
2023-09-22 09:08:50 +09:00
Neal Chambers
fe88a88206
Fix Style/HashSyntax
2023-09-22 09:08:50 +09:00
Maikel
3ed92312dd
Merge pull request #11576 from openfoodfoundation/dependabot/bundler/puma-6.4.0
...
chore(deps): bump puma from 6.3.1 to 6.4.0
2023-09-22 09:57:07 +10:00
Maikel
998370163c
Merge pull request #11575 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.135.0
...
chore(deps): bump aws-sdk-s3 from 1.134.0 to 1.135.0
2023-09-22 09:55:32 +10:00
Maikel
a2f9289031
Merge pull request #11570 from macanudo527/fix_stylehash_7
...
Fix Style/HashSyntax 8/13
2023-09-22 09:54:46 +10:00
Neal Chambers
22e3542de3
Update .rubocop_todo.yml
2023-09-21 22:58:42 +09:00
Neal Chambers
7ecd4a149b
Fix Style/HashSyntax
2023-09-21 22:58:42 +09:00
Konrad
a55797d727
Merge pull request #11510 from rioug/11421-deactivate-voucher
...
[Vouchers] add activate/deactivate feature
2023-09-21 15:03:47 +02:00
Konrad
1e877f4183
Merge pull request #11555 from mkllnk/spree-orders
...
Remove duplicate association from Spree::User
2023-09-21 13:23:51 +02:00
Filipe
a587a10dfe
Merge pull request #11573 from mkllnk/flaky-invoice-spec
...
Compare adjustments in deterministic order for invoices
2023-09-21 11:34:29 +01:00
jibees
4c82d27a7d
Merge pull request #11574 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.7.0
...
chore(deps-dev): bump knapsack_pro from 5.6.0 to 5.7.0
2023-09-21 11:34:01 +02:00
dependabot[bot]
252c86ccc0
chore(deps): bump puma from 6.3.1 to 6.4.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.3.1 to 6.4.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.3.1...v6.4.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 09:31:34 +00:00
dependabot[bot]
d54a09f26a
chore(deps): bump aws-sdk-s3 from 1.134.0 to 1.135.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.134.0 to 1.135.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 09:20:35 +00:00
dependabot[bot]
f44eae2d6b
chore(deps-dev): bump knapsack_pro from 5.6.0 to 5.7.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.6.0 to 5.7.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.6.0...v5.7.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 09:16:47 +00:00
David Cook
52fb4f5287
Remove unused workflow
...
Sadly this one can't work for PRs created from forks.
2023-09-21 16:42:27 +10:00
Maikel Linke
6386a997d3
Compare adjustments in deterministic order for invoices
...
The comparator would sometimes compare two different adjustments when it
should have compared two versions of the same adjustment.
2023-09-21 16:37:07 +10:00
Maikel Linke
ee1611904b
Fix typos in spec description
2023-09-21 16:37:07 +10:00
David Cook
f2e8063a22
Merge pull request #11572 from dacook/test-api-changes
...
Remove unnecessary space
2023-09-21 15:57:42 +10:00
David Cook
ec29038372
Remove unnecessary space
2023-09-21 15:54:40 +10:00
David Cook
23959c96bc
Send a Slack notification when api-changes PRs are merged
2023-09-21 15:53:34 +10:00
Maikel Linke
07ac381a97
Ignore block length of response blocks
...
In Rswag request specs, the `response` block is like `describe` and is
just used to group several other blocks. It can be long and that's okay.
2023-09-21 09:19:21 +10:00
Maikel Linke
02f251c900
Import DFC SuppliedProduct as new variant of existing product
2023-09-21 09:04:57 +10:00
Maikel Linke
db5b6e5406
Enable DFC importer to import OFN objects
2023-09-21 09:04:28 +10:00
Maikel Linke
fcf7b94278
Add our own SuppliedProduct with custom property
2023-09-21 09:02:20 +10:00
Maikel Linke
c42f62e09f
Add custom OFN product id to DFC SuppliedProduct
...
The Spree::Variant in OFN corresponds to a DFC SuppliedProduct. But
several Spree::Variant can be grouped under one Spree::Product which
wasn't exposed on the DFC API.
I'm adding a custom property here which can be used internally and
shouldn't break any other DFC tools.
A gotcha of this first test implementation:
The `ofn:` prefix has not been defined in the context. Software needs
to know that this is an Open Food Network attribute or ignore it.
We could define our own context and ontology and publish it on our
website but I don't see any benefit of that at this point.
2023-09-21 08:54:32 +10:00
Maikel Linke
2175c59a6b
Load spec helper not knowing Rails
...
When the application is not preloaded then running Rspec doesn't know
Rails until the spec helper is loaded. So we can't use Rails to find the
path of the spec helper. This has been fixed before but the DFC Address
code was developed at the same time and missed.
2023-09-21 08:54:32 +10:00
Maikel
458767fe13
Merge pull request #11569 from macanudo527/fix_stylehash_6
...
Fix Style/HashSyntax 7/13
2023-09-21 08:35:39 +10:00
Rachel Arnould
15137caed2
Merge pull request #11509 from dacook/buu-editing-part3-11059
...
[BUU] Bulk form editing features
2023-09-20 19:27:05 +02:00
Neal Chambers
bad1f55cdd
Update .rubocop_todo.yml
2023-09-20 23:47:52 +09:00
Neal Chambers
29df80945d
Fix Style/HashSyntax
2023-09-20 23:46:26 +09:00
Maikel
d216b68993
Merge pull request #11562 from macanudo527/fix_stylehash_5
...
Fix Style/HashSyntax 6/13
2023-09-20 12:00:30 +10:00
jibees
964373ce2b
Merge pull request #11566 from openfoodfoundation/dependabot/bundler/valid_email2-5.0.3
...
chore(deps): bump valid_email2 from 5.0.2 to 5.0.3
2023-09-19 16:25:46 +02:00
jibees
34d605111a
Merge pull request #11567 from openfoodfoundation/dependabot/bundler/ffaker-2.23.0
...
chore(deps): bump ffaker from 2.22.0 to 2.23.0
2023-09-19 16:25:01 +02:00
Jean-Baptiste Bellet
2a98789571
Add vertical-ellipsis-menu as product/variant actions menu in products table
...
+ add specs
2023-09-19 16:08:27 +02:00
Jean-Baptiste Bellet
c76bc07f7f
Creates a vertical-ellipsis-menu component
2023-09-19 15:32:50 +02:00
Jean-Baptiste Bellet
2c478f1d8e
Link to product/variant edit page
2023-09-19 14:26:14 +02:00
Jean-Baptiste Bellet
0847f6b0f6
Create a new column actions for each rows (product+variant)
2023-09-19 14:25:55 +02:00
dependabot[bot]
f9aa4a9d67
chore(deps): bump ffaker from 2.22.0 to 2.23.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 2.22.0 to 2.23.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/main/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/compare/v2.22.0...v2.23.0 )
---
updated-dependencies:
- dependency-name: ffaker
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-19 09:56:46 +00:00
dependabot[bot]
5eeb45ed25
chore(deps): bump valid_email2 from 5.0.2 to 5.0.3
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.0.2 to 5.0.3.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-19 09:46:32 +00:00
David Cook
759705efcf
Add spec for onKeyup
2023-09-19 14:48:39 +10:00
David Cook
6bfdd1bc12
Split spec into multiple examples
2023-09-19 14:48:34 +10:00
David Cook
693d5bad4a
Merge pull request #11551 from mkllnk/setup-node-version
...
Install the current node version in setup
2023-09-19 13:49:43 +10:00
David Cook
0af497ab23
Merge pull request #11539 from filipefurtad0/improve_tests_around_bulk_invoice_printing
...
[Release test automation] Adds assertions on bulk invoice creation
2023-09-19 13:49:19 +10:00
David Cook
fb93aeb195
Optimise spec
2023-09-19 13:39:36 +10:00
Neal Chambers
d1b8edaa94
Update .rubocop_todo.yml
2023-09-19 08:26:15 +09:00
Neal Chambers
42a6a02353
Fix Style/HashSyntax
2023-09-19 08:25:56 +09:00
filipefurtad0
6a31849fb4
Asserts on url from View File link
2023-09-18 10:43:13 +01:00
Gaetan Craig-Riou
c6e9a84633
Merge pull request #11557 from openfoodfoundation/dependabot/bundler/valid_email2-5.0.2
...
chore(deps): bump valid_email2 from 5.0.0 to 5.0.2
2023-09-18 19:29:08 +10:00
Rachel Arnould
00b7ae9600
Merge pull request #11496 from jibees/buu-css/ui-tweaks-on-legacy-backoffice-to-be-consitent-and-usable
...
🚧 BUU: update and tweak UI and CSS to fit V3 style to legacy
2023-09-18 10:53:28 +02:00
filipefurtad0
06ca2979dd
Adds assertions on bulk invoice creation
2023-09-18 09:29:44 +01:00
Maikel
2c3561d47f
Merge pull request #11554 from macanudo527/fix_stylehash_4
...
Fix Style/HashSyntax 5/13
2023-09-18 15:34:06 +10:00
Maikel
a1e3bae9b6
Merge pull request #11550 from openfoodfoundation/dependabot/bundler/stripe-9.3.0
...
chore(deps): bump stripe from 9.2.0 to 9.3.0
2023-09-18 15:31:42 +10:00
dependabot[bot]
6cf46c9bdc
chore(deps): bump valid_email2 from 5.0.0 to 5.0.2
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.0.0 to 5.0.2.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.0.0...v5.0.2 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-18 04:21:35 +00:00
Maikel
e2783cda05
Merge pull request #11549 from openfoodfoundation/dependabot/bundler/view_component-3.6.0
...
chore(deps): bump view_component from 3.5.0 to 3.6.0
2023-09-18 14:14:35 +10:00
Maikel Linke
4ebfe73f60
Remove duplicate association
...
Probably a relict from a Spree upgrade.
2023-09-18 12:38:01 +10:00
Neal Chambers
4beacfb970
Update .rubocop_todo.yml
2023-09-16 09:07:22 +09:00
Neal Chambers
4596997547
Fix Style/HashSyntax
2023-09-16 09:05:31 +09:00
Gaetan Craig-Riou
776f478038
Make update the only public method
...
I think this got lost when refactoring, but only `update` is meant
to be a public method, other than `new`.
2023-09-15 11:42:04 +02:00
jibees
0b4d0a1438
Merge pull request #11552 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.5.3
...
chore(deps): bump @floating-ui/dom from 1.5.2 to 1.5.3
2023-09-15 11:28:38 +02:00
dependabot[bot]
727afbc115
chore(deps): bump @floating-ui/dom from 1.5.2 to 1.5.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/dom/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.5.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-15 09:14:48 +00:00
Jean-Baptiste Bellet
02bbd9a9ba
Adjust colors and height for sidebar-item component
2023-09-15 11:05:59 +02:00
Jean-Baptiste Bellet
657f4d95d7
move sidebar-item into admin v3 context
2023-09-15 11:02:45 +02:00
Jean-Baptiste Bellet
fe81900639
Update select2.scss
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
10b6df6bd7
Tweak dashboard for a hub manager
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
7326241c70
Move pages/changetypeform to admin v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
ae04063643
Create and adjust big button
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
4aaf0ddc18
Move dashboard-single-ent into admin v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
a59c8adbbf
Adjust color for edit action to $teal
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
241dbd1ded
move plugins/powertip into admin v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
62465b9bbc
Move components/actions into admin_v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
dfe79396f6
Use $teal color for some info in the order page
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
f71ace1d39
Move sections/orders scss file into admin v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
f110c55531
Add product_import into admin_v3 context and adjust some colors
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
8ae68b15a0
Adjust select2 multiple choices colors
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
beba709827
Move buttons/input stuff into related file
...
And adjust design for v3 style
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
371e064f82
Adjust padding left right size for text-angular component in v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
6a771ad09c
Move text-angular component rules to admin_style_v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
e3359dd240
Move text-angular rules into its own file
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
351fe1b430
Date / date range (flatpickr) colors customization
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
7e1c2dac45
Move flatpickr customization into admin_v3 context
2023-09-15 10:47:44 +02:00
Jean-Baptiste Bellet
4b3688f878
Move date picker into admin_v3 context
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
d72a4a758b
Add border to table
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
705ec5e5f8
Change color of tagging component in admin/customers page
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
2fd5390374
Design background color of dropdown component
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
102f20ad9e
Add enterprise_index_panels into admin_v3 context
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
3cfd4cdc9b
No need to have light in v3
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
0d410d27ae
No more green but $red (which is almost orange btw) for navigation
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
e434f7112a
Add sidebar to admin_v3 context
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
8b0fc875da
Use the same arrow
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
b355d8beb3
Change colors for dropdown components
...
It's a bit annoying: we do have several "selector" components.
- built-in select
- dropdown directive
- select2 component
- tom-select component
Each has its own design, and having common design a loooong time job ;)
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
db4d6c8010
Don't need to change background color hovering
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
b0e6062bec
Create a arrowDown mixin in order to display arrow for select compoentns
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
aacdeac1e5
Move dropdown into admin_v3 context
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
99d0b3f092
Prefer to use color-btn-hover-bg var instead of color-10
...
The variable name is easier to understand.
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
549e9259d9
Fix comment
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
6ee48a04fc
Remove file admin/plugins/select2 for adminV3 and copy content into
...
already used file: `components/select2`
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
ccc59926f1
Update button background color when hovering on dashboard
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
5df211137e
Tweak stimulus pagination (used on orders) to be up to date
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
f2941f9275
form legend are red
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
1b9a7aa81e
Adjust height, border and background colors for inputs
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
98f9303c99
Tweak colors, size, ... for select2 to looks like tom-select
...
One day, we'll remplace select2 by tom-select
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
e5086ce057
Adjust colors for select2 and remove useless ones
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
3a67f5c9d7
Integrate select2 to admin_v3
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
b8406be4b9
Add trix editor to admin_v3 css
...
That was an omission when installing trix
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
03d5f8acc4
No need to specify padding when having a line height
2023-09-15 10:47:43 +02:00
Jean-Baptiste Bellet
48f1c65a91
Include dashboard_item into admin_v3
2023-09-15 10:47:43 +02:00
David Cook
e075d40525
Prevent accidentally leaving the page
2023-09-15 16:00:41 +10:00
David Cook
99ac48a258
Discarding changes reloads from DB
...
But it also clears any search filters. To confirm exactly what behaviour is desired before fixing...
2023-09-15 15:46:02 +10:00
David Cook
8ff67aca41
Disable filters and sorting when form is modified
...
Stimulus controllers aren't supposed to reach outside their own element (so we can't do this with targets). Perhaps the controller should be bigger to encompass more, but I wanted to see if I could avoid making a mega component that does everything. For now it seems appropriate just to pass a selector in.
Another option is to publish events on other controllers using Outlets, but I don't know if we need to go there just yet.
2023-09-15 15:45:48 +10:00
David Cook
e047f49998
Make form actions float over sort controls.
2023-09-15 15:45:48 +10:00
David Cook
15f7a8299b
Show form actions only when modified
2023-09-15 15:45:48 +10:00
David Cook
daefada5a9
Show summary of modified records
...
I found myself trying to write Ruby in Javascript, and it's not nearly as pretty..
Javascript now has more advanced data structures like Map, but it's rather useless because it doesn't have the usual iterator methods (such as filter, map, reduce etc).
Also for the spec I wasn't sure of the best approach, so will gladly recieve feedback.
2023-09-15 15:45:48 +10:00
David Cook
18e40bebd0
Mark modified fields
2023-09-15 15:45:45 +10:00
Maikel Linke
ab157246df
Install the current node version in setup
2023-09-15 15:25:16 +10:00
dependabot[bot]
b1f42c14ee
chore(deps): bump stripe from 9.2.0 to 9.3.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 9.2.0 to 9.3.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v9.2.0...v9.3.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-15 03:07:27 +00:00
dependabot[bot]
86b5791268
chore(deps): bump view_component from 3.5.0 to 3.6.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.5.0...v3.6.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-15 03:02:49 +00:00
Maikel
aad58f1c8b
Merge pull request #11546 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.21.1
...
chore(deps-dev): bump rubocop-rails from 2.21.0 to 2.21.1
2023-09-15 12:59:54 +10:00
Maikel
2994227c35
Merge pull request #11542 from dacook/update-templates
...
Update templates
2023-09-15 11:42:12 +10:00
Maikel
0c87c16847
Merge pull request #11540 from macanudo527/fix_stylehash_3
...
Fix Style/HashSyntax 4/13
2023-09-15 11:32:03 +10:00
dependabot[bot]
f9aab96332
chore(deps-dev): bump rubocop-rails from 2.21.0 to 2.21.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.21.0 to 2.21.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.21.0...v2.21.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-14 09:48:33 +00:00
Gaetan Craig-Riou
0c005ad734
Sales Tax Totals by order included tax, fix tax amount when voucher applied
...
Plus specs
2023-09-14 10:21:50 +02:00
Gaetan Craig-Riou
e7a52e4733
Update app/controllers/admin/enterprises_controller.rb
...
Simplify code
Co-authored-by: Maikel <maikel@email.org.au >
2023-09-14 17:57:31 +10:00
Neal Chambers
0c1cb5282c
Update .rubocop_todo.yml
2023-09-14 16:25:49 +09:00
Neal Chambers
bf9db13bb3
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
David Cook
814144d77d
Remember to mention API changes
...
[skip ci]
2023-09-14 15:04:01 +10:00
David Cook
00b2c70239
Release categories are now automatically generated.
2023-09-14 15:03:56 +10:00
David Cook
b0c822c63b
Remember to consider webhook changes as API changes too
2023-09-14 15:03:54 +10:00
David Cook
7ef4df0087
Update all locales with the latest Transifex translations
2023-09-14 13:47:58 +10:00
David Cook
0966864589
Merge pull request #11511 from dacook/fix-update-button-11349
...
Fix Update button sizing
2023-09-14 13:37:19 +10:00
David Cook
2e6e083667
[fixup] Fix Update button sizing
...
By disabling line wrap we can consistently predict how it will appear. The longest translation we currently have is 14 characters so this should be fine.
2023-09-14 09:37:10 +10:00
Maikel
8e226bc473
Merge pull request #11537 from filipefurtad0/fix_flaky_orders_cycle_supplier_totals_report_spec.rb
...
Renames product so it always appears first on the report results
2023-09-14 09:08:16 +10:00
Maikel
758c6e033f
Merge pull request #11533 from macanudo527/fix_stylehash_2
...
Fix Style/HashSyntax 3/13
2023-09-14 09:04:03 +10:00
Maikel
0382b4c80a
Merge pull request #11535 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.5.0
...
chore(deps): bump newrelic_rpm from 9.4.2 to 9.5.0
2023-09-14 08:45:44 +10:00
Konrad
c36c5be2c9
Merge pull request #11497 from Matt-Yorkley/import-tax-category
...
Fix error when importing entries with a tax category
2023-09-13 23:28:16 +02:00
Konrad
29a12c7235
Merge pull request #11013 from filipefurtad0/add_enterprise_fees_w_tax_report_by_producer
...
Adds enterprise fees w tax report by producer
2023-09-13 21:55:59 +02:00
David Cook
ee2520a1f6
Visit page directly to save time
...
Shaved a couple of seconds off, 35->33 sec.
And make it easier to hide from the list.
2023-09-13 19:09:55 +02:00
David Cook
b27f63fa60
Refactor: DRY up init code
2023-09-13 19:09:55 +02:00
David Cook
ef1ccca4fa
Temporarily 'hide' report
...
The reports framework doesn't currently support hidden reports, but we can mark it with a strike-through at least.
2023-09-13 19:09:55 +02:00
David Cook
db8392ce81
Temporarily hide report
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
4cb91da8b2
load only enterprise fees connected to incoming exchanges on the OC
2023-09-13 19:09:55 +02:00
filipefurtad0
af525f9f7f
Fixes rubocop issues
2023-09-13 19:09:55 +02:00
filipefurtad0
131474e91d
Updates test case
...
should list all the tax rates (2)
2023-09-13 19:09:55 +02:00
filipefurtad0
57f058eeb2
Updates test case
...
should list all the tax rates
2023-09-13 19:09:55 +02:00
filipefurtad0
fc9826b44a
Updates test case
...
should filter by fee name
2023-09-13 19:09:55 +02:00
filipefurtad0
86e6697723
Updates test case
...
should filter by producer
2023-09-13 19:09:55 +02:00
filipefurtad0
7734b0417d
Updates test case
...
should filter by distributor and order cycle (2)
2023-09-13 19:09:55 +02:00
filipefurtad0
d7a6db3eb0
Updates test case
...
should filter by distributor and order cycle
2023-09-13 19:09:55 +02:00
filipefurtad0
d8501e7d83
Updates test case
...
generates the report and displays fees for the respective suppliers
2023-09-13 19:09:55 +02:00
David Cook
47d5fe909e
Deduplicate order2 setup
2023-09-13 19:09:55 +02:00
David Cook
8c514b2fe9
Deduplicate order setup
2023-09-13 19:09:55 +02:00
David Cook
b574e71fc9
Refactor: set included_in_price once
...
This saves the need for an update, and more importantly moves setup out of the before block which means we can finally deduplicate order setup.
2023-09-13 19:09:55 +02:00
David Cook
6e15049728
Refactor distributor
2023-09-13 19:09:55 +02:00
David Cook
bf2298829f
Refactor order cycle setup more
...
Moving more code out of before blocks which will help us reduce duplication in following commits.
2023-09-13 19:09:55 +02:00
David Cook
ce57ac65f3
Refactor order cycle lets
...
It turns out the outgoing exchanges were never even used.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
9a22cdc5e7
test scenario: 'multiple orders, same enterprise fee, different tax rates'
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
624b4c8ad2
fix calculation of the summary row's total excl tax
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
a3f012c9fe
calculate tax total using existing rows
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
f0c3d7685e
replace string reference with the translated string
2023-09-13 19:09:55 +02:00
David Cook
420494715f
Tighten up spec
...
I noticed that the tests don't check if the right totals are shown for each section. Now we can be certain.
2023-09-13 19:09:55 +02:00
David Cook
b7e1a660c3
Rename supplier to be more specific
...
To ensure specs are matching the right supplier.
2023-09-13 19:09:55 +02:00
David Cook
e934bc7cb9
Ignore ClassLength
...
I'm never quite sure the best way to deal with these, so I added a comment to at least explain my justification.
2023-09-13 19:09:55 +02:00
David Cook
93cca56e68
Style/HashSyntax
2023-09-13 19:09:55 +02:00
filipefurtad0
019c7b3e71
Splits filtering tests between orders
...
Sets pending test case for orders with more than one supplier
2023-09-13 19:09:55 +02:00
filipefurtad0
e43661fd3c
Adds/corrects comments around Added tax section
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
080e81e0fe
optimize join_supplier
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
44e8d2d735
fix pending lint issues
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
219c581f9a
remove pending from "should filter by producer"
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
6dd70d310c
fix the calculation of the cost of produce
...
we want the cost of produce to only include the items produced by the supplier used to group the rows.
2023-09-13 19:09:55 +02:00
filipefurtad0
9837a4fcf2
Removes pending (3)
...
Reverts Included Tax values
2023-09-13 19:09:55 +02:00
filipefurtad0
1b4235eb1d
Extends tests to inclusive tax scenario
2023-09-13 19:09:55 +02:00
filipefurtad0
bb0f9a6758
Adds pending test
...
on fees from order with line items from different suppliers
Adds pending test on producer filter
2023-09-13 19:09:55 +02:00
filipefurtad0
928337c3fd
Adds a second supplier and product to the setup
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
7a875723ca
fix order_cycle summary row.
...
the summary row has to only include the line items coming from the supplier used in the grouping key
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
7b0a99c652
fix enterprise fees listing
...
For every producer, we want to only show the enterprise fees that are applied to at lease one of his products.
To do that, we use the order cycle to build a list of the enterprise fees for every variant.
Every variant will have coordinator fee + additional fees coming from incoming/outgoing exchanges.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
1cd0f88c1e
fix supplier filter
2023-09-13 19:09:55 +02:00
David Cook
9ae65e135b
Rails/Pick
...
Prefer pick("sum(amount)") over pluck("sum(amount)").first
2023-09-13 19:09:55 +02:00
David Cook
55742f40d1
Show a line for cost of produce
...
Utilising a second group_by rule, we can add a second summary_row. The cost of produce is also inserted into the TOTALS row as per requirements.
2023-09-13 19:09:55 +02:00
David Cook
cc54e2e6c7
Add long report class to .rubocop_todo.yml
...
Long classes are a problem that would be good to resolve one day. But it's hard to resolve with the current reports framework.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
ee7668e713
implement enterprise fee report filters
...
squash Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
481b09edda
test enterprise summary fee with tax report by producer
...
Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
2880fd5a87
implement EnterpriseFeesWithTaxReportByProducer
...
squash Re-format code
squash Apply suggestions from code review
Co-authored-by: Maikel <maikel@email.org.au >
squash More refactor
squash Update lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_producer.rb
2023-09-13 19:09:55 +02:00
Filipe
0f47ec0094
Merge pull request #11525 from jibees/11524-enlarged-unit-price-tooltip-image-on-variant-edit-page
...
BUU: Fix question mark icon for tooltip
2023-09-13 16:52:15 +01:00
Filipe
dae05e31ab
Merge pull request #11501 from jibees/9146-improve-user-feedback-in-oc-edit-page-for-hidden-inventory
...
Improve user feedback in oc edit page for hidden inventory
2023-09-13 16:26:39 +01:00
jibees
9f675fed32
Merge pull request #11534 from openfoodfoundation/dependabot/bundler/faraday-2.7.11
...
chore(deps): bump faraday from 2.7.10 to 2.7.11
2023-09-13 15:02:29 +02:00
jibees
f7dd94268e
Merge pull request #11536 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.4
...
chore(deps): bump sidekiq from 7.1.3 to 7.1.4
2023-09-13 14:59:06 +02:00
filipefurtad0
263b5e280e
Renames product so it always appears first on the report results
2023-09-13 11:33:58 +01:00
dependabot[bot]
2c79a8be3c
chore(deps): bump sidekiq from 7.1.3 to 7.1.4
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.3 to 7.1.4.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.3...v7.1.4 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-13 10:02:05 +00:00
dependabot[bot]
866f9b9d9d
chore(deps): bump newrelic_rpm from 9.4.2 to 9.5.0
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.4.2 to 9.5.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.4.2...9.5.0 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-13 10:00:35 +00:00
dependabot[bot]
8adc0a9144
chore(deps): bump faraday from 2.7.10 to 2.7.11
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.10 to 2.7.11.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.10...v2.7.11 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-13 09:59:46 +00:00
Neal Chambers
1fa0dc99fe
Update .rubocop_todo.yml
2023-09-13 16:45:00 +09:00
Neal Chambers
ed06edda3f
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
Maikel
ead4f784ba
Merge pull request #11528 from macanudo527/fix_stylehash_1
...
Fix Style/HashSyntax 2/13
2023-09-13 17:17:26 +10:00
Maikel
463ecf2880
Merge pull request #11508 from mkllnk/dfc-enterprise-groups
...
[DFC API] Add endpoint for enterprise groups
2023-09-13 16:50:05 +10:00
Maikel Linke
7e222ad83e
Include address when showing group
...
It may be nice to show more data like social media URLs but the DFC
Connector hasn't implemented that yet and it's not specified in the
current issue.
2023-09-13 16:36:36 +10:00
Maikel Linke
88a3615de7
List groups when showing DFC Enterprise
2023-09-13 16:36:36 +10:00
Maikel Linke
cf18229e5b
Avoid loading DFC catalog for Person or Groups endpoint
2023-09-13 16:36:36 +10:00
Maikel Linke
95d3987752
List enterprise groups on DFC API
2023-09-13 16:36:36 +10:00
Maikel Linke
a03fb01a8c
List enterprises within groups on DFC API
2023-09-13 16:36:36 +10:00
Maikel Linke
2d91a61dcb
Add DFC API EnterpriseGroups#show
2023-09-13 16:36:36 +10:00
David Cook
ae72158e87
Merge pull request #11494 from mkllnk/dfc-swagger-config
...
Group DFC API operations by endpoint in documentation
2023-09-13 14:57:14 +10:00
Neal Chambers
7c3e61104a
Update .rubocop_todo.yml
2023-09-12 23:19:25 +09:00
Neal Chambers
4ffd3759cc
Fix Style/HashSyntax
2023-09-12 23:19:05 +09:00
jibees
0ebdc8abca
Merge pull request #11526 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.3
...
chore(deps): bump sidekiq from 7.1.2 to 7.1.3
2023-09-12 15:54:25 +02:00
Gaetan Craig-Riou
9925399292
Sales Tax Totals by order, fix tax amount when voucher applied
...
Apply the tax discount to the tax collumn when a voucher is added
to the order, and update total excluding tax accordingly.
2023-09-12 14:36:28 +02:00
Gaetan Craig-Riou
a7bceb0b28
Add spec scenario where a voucher is added to the order
...
Voucher tax portion needs to be removed from the tax amount so we
can display the correct tax in the report.
2023-09-12 14:14:01 +02:00
Gaetan Craig-Riou
29a4bf88d7
DRY up specs
2023-09-12 14:13:04 +02:00
dependabot[bot]
1d430265a2
chore(deps): bump sidekiq from 7.1.2 to 7.1.3
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.2 to 7.1.3.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.2...v7.1.3 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-12 09:32:05 +00:00
Gaetan Craig-Riou
57f563f4bc
Merge pull request #11516 from macanudo527/fix_rubocop_9
...
Fix Style/HashSyntax 1
2023-09-12 18:56:47 +10:00
Jean-Baptiste Bellet
637096534f
Implement spec for #9146 issue
2023-09-12 10:20:26 +02:00
Jean-Baptiste Bellet
ff8b9465c7
Display info on outgoing products panel when some variants hidden
2023-09-12 10:20:26 +02:00
Jean-Baptiste Bellet
ff7629ba2c
Display information on outgoing product when variant aren't available
...
Update en.yml
2023-09-12 10:20:26 +02:00
jibees
eecc0d5772
Merge pull request #11519 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.21.0
...
chore(deps-dev): bump rubocop-rails from 2.20.2 to 2.21.0
2023-09-11 16:31:03 +02:00
jibees
a08d9e5a3c
Merge pull request #11523 from openfoodfoundation/dependabot/bundler/rubocop-1.56.3
...
chore(deps-dev): bump rubocop from 1.56.2 to 1.56.3
2023-09-11 16:30:23 +02:00
Jean-Baptiste Bellet
edc6ac801d
Use the right colors for the question mark icon tooltip in admin style v3
2023-09-11 15:44:08 +02:00
Jean-Baptiste Bellet
75751f07b8
Move question-mark-icon into admin_style_v3 context
2023-09-11 15:31:30 +02:00
Jean-Baptiste Bellet
99ea4a63e0
No need to have a button: not conflicting with button styles
2023-09-11 15:29:09 +02:00
jibees
f05ed020f3
Merge pull request #11522 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.5.2
...
chore(deps): bump @floating-ui/dom from 1.5.1 to 1.5.2
2023-09-11 15:03:16 +02:00
Gaetan Craig-Riou
e44a0092ea
Fix edge case when trying to deactivate the only availabe voucher
...
Plus spec
2023-09-11 12:00:48 +02:00
Gaetan Craig-Riou
48956b9bd1
As per review comment, simplify voucher view a little
2023-09-11 11:59:34 +02:00
dependabot[bot]
fe83be1853
chore(deps-dev): bump rubocop from 1.56.2 to 1.56.3
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.2 to 1.56.3.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.2...v1.56.3 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 09:18:20 +00:00
dependabot[bot]
5b0b03dc5d
chore(deps): bump @floating-ui/dom from 1.5.1 to 1.5.2
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/dom/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.5.2/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 09:17:54 +00:00
Maikel
f885e80413
Merge pull request #11520 from openfoodfoundation/dependabot/bundler/rails-7.0.8
...
chore(deps): bump rails from 7.0.7.2 to 7.0.8
2023-09-11 15:48:37 +10:00
Maikel Linke
99529ff599
Put new rubocop violations on todo list
2023-09-11 15:44:15 +10:00
Maikel Linke
df3fc83c8e
Remove version from DFC API URL in specs
...
We were aiming to use stable URLs to identify resources but the URL
helpers were still using dfc-v1.7 because that was the last and
overriding path of the mounted DFC Provider engine.
2023-09-11 15:00:08 +10:00
Maikel Linke
7654d37fc3
DRY, shorten swagger file names
2023-09-11 14:57:39 +10:00
Maikel Linke
fe2eecb69e
DRY swagger-ui config with relative path
2023-09-11 14:57:38 +10:00
Maikel Linke
fc7c8757d9
Move DFC patches into our DFC engine
...
It seems to belong there and it's avoiding some loading issues with
Spring.
2023-09-11 14:57:38 +10:00
Maikel Linke
73193fbfd0
Explicitely load our DFC Connector patches
...
It makes sure we can extend functionality without conflicts.
2023-09-11 14:57:38 +10:00
Maikel Linke
191c4a79db
Load spec helpers before Rails is loaded
...
Using Spring was hiding an loading error. When you start Rspec, Rails
and its engines are not loaded yet. So our way to load the spec helper
via `Rails.root` did not work when you ran specs on their own without
loading Rails with Spring first.
2023-09-11 14:57:38 +10:00
Maikel Linke
6316974146
Group DFC API operations by endpoint
...
Previously they were all in one long list called "default".
2023-09-11 14:57:38 +10:00
dependabot[bot]
ce7c9f0895
chore(deps): bump rails from 7.0.7.2 to 7.0.8
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.7.2 to 7.0.8.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.7.2...v7.0.8 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 04:05:35 +00:00
dependabot[bot]
29f476e559
chore(deps-dev): bump rubocop-rails from 2.20.2 to 2.21.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.20.2 to 2.21.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.20.2...v2.21.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 04:01:42 +00:00
Maikel
ecc04b05e3
Merge pull request #11512 from openfoodfoundation/dependabot/bundler/stripe-9.2.0
...
chore(deps): bump stripe from 9.1.0 to 9.2.0
2023-09-11 14:00:15 +10:00
Neal Chambers
e69e5eb0ec
Update .rubocop_todo.yml
2023-09-09 09:02:14 +09:00
Neal Chambers
416d6e538a
Fix Style/HashSyntax
2023-09-09 09:00:38 +09:00
Matt-Yorkley
839e580878
Fix error when importing entries with a tax category
2023-09-08 19:24:50 +01:00
Gaetan Craig-Riou
8face3d182
Merge pull request #11488 from macanudo527/fix_helperinstancevariable_2
...
Fix Rails/HelperInstanceVariable 2
2023-09-08 19:51:39 +10:00
dependabot[bot]
eb4517cf0b
chore(deps): bump stripe from 9.1.0 to 9.2.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 9.1.0 to 9.2.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v9.1.0...v9.2.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-08 09:15:23 +00:00
David Cook
99da60921f
Fix Update button sizing
...
This was broken when upgrading [Foundation](https://github.com/openfoodfoundation/openfoodnetwork/pull/11349 ). For some reason the button.expand class now sets larger font size and padding, which overrides the button.small class. It's probably a bug but we'll have to work around it.
2023-09-08 10:20:26 +10:00
Maikel
1991970185
Merge pull request #11377 from mkllnk/dfc-update-request
...
[DFC API] Import known units when creating new products
2023-09-08 09:05:26 +10:00
Filipe
b64c1c2675
Merge pull request #11349 from dacook/foundation-sites-5.5.3
...
chore(deps): bump foundation-sites from 5.5.2 to 5.5.3
2023-09-07 18:33:43 +01:00
Filipe
ccabf5936d
Merge pull request #11505 from drummer83/master
...
[Super admin] Highlight 'Configuration' tab on 'Terms of Service' page
2023-09-07 18:00:18 +01:00
Konrad
ea622cd2d7
Merge pull request #11487 from pedrocarmona/feature/invitation-email-locale
...
Send translated email when creating users via super admin interface
2023-09-07 16:41:59 +02:00
Gaetan Craig-Riou
f225cd78df
Handle unique voucher code exception
...
Rails validation doesn't handle unique validation for soft deleted
object. So we rescue the exception raise by the database and display
a nice error message. We don't want an enterprise to be able to reuse
a code in case the voucher get reactivated.
2023-09-07 15:13:47 +02:00
Gaetan Craig-Riou
63cd8ccf28
Test scenario where a voucher is deactivated before end of checkout
...
A customer should be able to complete the checkout even if the voucher
has been deactivated after being added to the order.
2023-09-07 14:00:26 +02:00
Gaetan Craig-Riou
b955e0b25d
Use depedend: nil on adjustment association
...
We want to keep the voucher adjustment associated with the Voucher
event when the voucher as been soft deleted, as we use this
functionality as activate/deactivate feature
2023-09-07 13:58:07 +02:00
David Cook
ab5e16effb
chore(deps): bump foundation-sites from 5.5.2 to 5.5.3
...
Better 7 years late than never...
This resolves CWE-79: https://security.snyk.io/vuln/npm:foundation-sites:20150619
2023-09-07 11:45:37 +10:00
drummer83
a7ddf99ee4
Fix typo
2023-09-06 23:20:12 +02:00
drummer83
13d5b954e6
Add 'Terms of Service' to the tabs
2023-09-06 23:18:00 +02:00
Konrad
3b9ebf4e07
Merge pull request #11396 from abdellani/fix-if-tos-is-not-set
...
fix If ToS file is not set, customer needs to accept Terms on each checkout
2023-09-06 16:56:21 +02:00
Neal Chambers
dbb758b73a
Update .rubocop_todo.yml
2023-09-06 22:36:51 +09:00
Neal Chambers
2da9ffd3cb
Delete Unused Helper Functions
2023-09-06 22:36:51 +09:00
Neal Chambers
b1e40ed605
Fix Rails/HelperInstanceVariable
2023-09-06 22:36:46 +09:00
jibees
d8f4f58c77
Merge pull request #11499 from openfoodfoundation/dependabot/bundler/web-console-4.2.1
...
chore(deps-dev): bump web-console from 4.2.0 to 4.2.1
2023-09-06 08:52:58 +02:00
dependabot[bot]
954e080cbf
chore(deps-dev): bump web-console from 4.2.0 to 4.2.1
...
Bumps [web-console](https://github.com/rails/web-console ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/rails/web-console/releases )
- [Changelog](https://github.com/rails/web-console/blob/main/CHANGELOG.markdown )
- [Commits](https://github.com/rails/web-console/compare/v4.2.0...v4.2.1 )
---
updated-dependencies:
- dependency-name: web-console
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-06 01:44:08 +00:00
David Cook
aaa3bebb93
Merge pull request #11495 from openfoodfoundation/dependabot/bundler/valid_email2-5.0.0
...
chore(deps): bump valid_email2 from 4.0.6 to 5.0.0
2023-09-06 11:39:26 +10:00
Gaetan Craig-Riou
d1b5dcab88
Add ability to activate deactivate a voucher
...
Plus controller specs
2023-09-05 15:48:59 +02:00
Gaetan Craig-Riou
79f4caaee2
Clean up spec
2023-09-05 15:48:30 +02:00
dependabot[bot]
3405865c0f
chore(deps): bump valid_email2 from 4.0.6 to 5.0.0
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.6 to 5.0.0.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.6...v5.0.0 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-05 09:48:34 +00:00
David Cook
a096c56658
Merge pull request #11484 from openfoodfoundation/mkllnk-patch-1
...
Add release note category "API changes"
2023-09-05 13:29:55 +10:00
Maikel Linke
997c8a49ca
Combine system specs for efficiency
2023-09-05 10:51:38 +10:00
Pedro Carmona
51050036d4
Use instance default locale as the default locale for a new user
2023-09-05 01:00:35 +01:00
Pedro Carmona
c4830e3baa
Send localized email when creating users via admin interface
...
Based on the current user locale
2023-09-05 01:00:35 +01:00
David Cook
0874c7ddb8
Merge pull request #11309 from filipefurtad0/legal_invoices_spec_comparator
...
[Invoices] Adds unit level test coverage order model attributes
2023-09-05 09:45:00 +10:00
Maikel
b1a88ab7a9
Merge pull request #11490 from mkllnk/sample-data-validation
...
Skip online validation of sample emails
2023-09-05 09:28:16 +10:00
Konrad
c50a3b4f86
Merge pull request #11489 from mkllnk/order_cycle_schedule
...
Require associations on join model
2023-09-04 21:37:30 +02:00
Konrad
fd6f2338e5
Merge pull request #11450 from mkllnk/feature-toggle-enterprise
...
Activate vouchers feature per user or enterprise
2023-09-04 21:30:41 +02:00
filipefurtad0
82ca115931
Removes unnecessary && operator
...
reloads instead of saving order again
2023-09-04 19:35:28 +01:00
filipefurtad0
4e54279b05
Rearranges relevant and non-relevant test cases
2023-09-04 19:32:06 +01:00
Konrad
406577ed2a
Merge pull request #11140 from jibees/11129-add-trix-editor-to-product-description-editor
...
Admin, add trix editor to product description editor (both new and edit)
2023-09-04 20:22:14 +02:00
Gaetan Craig-Riou
08c131680d
Merge pull request #11471 from mkllnk/variant-supplier
...
[DFC API] Replace service class with simple AR association
2023-09-04 23:59:37 +10:00
Jean-Baptiste Bellet
b6b64e9439
Add trix editor to new product form
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
1d5d1c5405
Include trix-styles mixin in where content from trix is displayed
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
34dab4003d
Create a mixin that include list of styles for trix editor + content
...
Will be used elsewhere (in shopfront in particular)
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
c402093081
Special case for unordered list in trix editor: should be overwritten
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
ca6d12e8ed
Actually, used in the shopfront context, links are orange
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
3225c52898
Actually, this should not be sanitize before going through trix editor
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
a8a35318f5
Add horizontal rule to trix editor
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
4c27e79519
Sanitize content when display it on shop
...
Use the TrixSanitizer | TrixScrubber
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
f9bc00e5cd
We used to use <p> to seperate block between them. now use <div>
...
trix doesn't allow the use of `<p>` as block separator since it can not contain `<figure>`: use `<div>` and _emulate_ as `<p>` with margin bottom
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
b6e047086a
Update trixEditor rendering <a /> element: should be green
2023-09-04 15:46:54 +02:00
Jean-Baptiste Bellet
e200eccc42
Replace angular editor by trix editor
2023-09-04 15:46:54 +02:00
Gaetan Craig-Riou
50693dd5d2
Merge pull request #11468 from dacook/buu-editing-part2-11059
...
[BUU] Editing - part 2 (product and variant text fields) 🚧
2023-09-04 23:41:44 +10:00
Gaetan Craig-Riou
db52b29b8f
Merge pull request #11476 from macanudo527/fix_rails_helperinstancevariable
...
Fix Rails/HelperInstanceVariable in injection_helper.rb
2023-09-04 22:30:14 +10:00
Maikel Linke
ae63a50719
Skip online validation of sample emails
2023-09-04 17:15:52 +10:00
Maikel Linke
38869cba2f
Require associations on join model
...
It's actually required in the database already. This just simplifies the
code.
2023-09-04 17:07:07 +10:00
Maikel
8b9425a206
Merge pull request #11486 from openfoodfoundation/dependabot/bundler/activerecord-session_store-2.1.0
...
chore(deps): bump activerecord-session_store from 2.0.0 to 2.1.0
2023-09-04 13:16:11 +10:00
Maikel
2d090042a3
Merge pull request #11485 from openfoodfoundation/dependabot/bundler/stripe-9.1.0
...
chore(deps): bump stripe from 9.0.0 to 9.1.0
2023-09-04 12:49:26 +10:00
Maikel
4f981417a9
Merge pull request #11477 from mkllnk/flaky-enterprise-fee
...
Stabilise flaky enterprise fee spec
2023-09-04 12:45:46 +10:00
dependabot[bot]
8bd749301e
chore(deps): bump activerecord-session_store from 2.0.0 to 2.1.0
...
Bumps [activerecord-session_store](https://github.com/rails/activerecord-session_store ) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/rails/activerecord-session_store/releases )
- [Commits](https://github.com/rails/activerecord-session_store/compare/v2.0.0...v2.1.0 )
---
updated-dependencies:
- dependency-name: activerecord-session_store
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-01 09:28:13 +00:00
dependabot[bot]
34fa41dac2
chore(deps): bump stripe from 9.0.0 to 9.1.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v9.0.0...v9.1.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-01 09:26:36 +00:00
Maikel
f27ecb6bcd
Add release note category "API changes"
...
[skip ci]
2023-09-01 14:14:47 +10:00
Maikel
bcfc15f102
Enable copy of translation update commands
...
The added `code` tag makes Github add the copy button.
2023-09-01 13:53:20 +10:00
Maikel Linke
ee3fe08378
Update all locales with the latest Transifex translations
2023-09-01 13:51:29 +10:00
David Cook
441b9febc8
Merge pull request #11454 from macanudo527/fix_rubocop_8
...
Fix Rubocop Style Errors
2023-09-01 13:22:38 +10:00
David Cook
32c0b5a3e2
Remove unnecessary details
...
As far as I can tell we didn't need to specify these for the tests.
2023-09-01 12:04:27 +10:00
Neal Chambers
4feb8f922e
Fix Rails/HelperInstanceVariable in injection_helper.rb
2023-09-01 11:03:26 +09:00
David Cook
381ce1c2b9
Simplify order definition
...
There only needs to be one order at a time, and it can be created on-demand. We can simply override it in the specs that need to.
2023-09-01 12:00:29 +10:00
Maikel Linke
c439aaf32f
Spec trying to ready a shipment twice
2023-09-01 08:55:56 +09:00
Neal Chambers
b0bb97a22f
Fix ready to execute only if it isn't ready
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-09-01 08:55:56 +09:00
Neal Chambers
819fa611e8
Fix Rails/Blank
2023-09-01 08:55:56 +09:00
Neal Chambers
8ae5b61252
Manually Fix Style/GuardClause
2023-09-01 08:55:56 +09:00
Neal Chambers
70e765bff6
Safely autocorrect Style/GuardClause
...
Inspecting 1488 files
......................C....C.C..........................C.........C.........................C............................................C..............................................................................................................C.C........................................CC..............................C...........C...........................................................................................................................................................................................................C........................................................................................................C.......................................................C.............C...........................................................................................C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...C....................................................................................................................C.............
Offenses:
app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless params[:stimulus]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:stimulus]) instead of wrapping the code inside a conditional expression.
if params[:stimulus]
^^
app/controllers/admin/enterprises_controller.rb:51:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.is_primary_producer = params[:is_primary_producer]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:52:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.sells = params[:enterprise_sells]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:53:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
render cable_ready: cable_car.morph("#side_menu", partial("admin/shared/side_menu")) ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:55:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:56:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless user_id.positive? && @enterprise.user_ids.include?(user_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless user_id.positive? && @enterprise.user_ids.include?(user_id)) instead of wrapping the code inside a conditional expression.
if user_id.positive? && @enterprise.user_ids.include?(user_id)
^^
app/controllers/admin/enterprises_controller.rb:267:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.update_contact(user_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:268:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:270:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present?) instead of wrapping the code inside a conditional expression.
if attrs[:calculator_type].present? && attrs[:calculator_attributes].present?
^^
app/controllers/admin/enterprises_controller.rb:273:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
rule.update(calculator_type: attrs[:calculator_type])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:274:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
attrs[:calculator_attributes].merge!( id: rule.calculator.id )
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:275:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:278:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:280:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
params[:sets_enterprise_set][:collection_attributes].each do |_i, enterprise_params| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:285:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:289:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin? || spree_current_user == @enterprise.owner
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin? || spree_current_user == @enterprise.owner) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin? || spree_current_user == @enterprise.owner
^^^^^^
app/controllers/admin/enterprises_controller.rb:290:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :sells
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:291:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:296:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:300:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
has_hub = spree_current_user.owned_enterprises.is_hub.any?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:301:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
new_enterprise_is_producer = Enterprise.new(enterprise_params).is_primary_producer
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:302:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params[:sells] = has_hub && !new_enterprise_is_producer ? 'any' : 'none'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:303:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:308:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :owner_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:314:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
bulk_params[:collection_attributes].each do |_i, enterprise_params| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:316:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:317:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:322:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :user_ids
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:323:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:325:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:332:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless json_request?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless json_request?) instead of wrapping the code inside a conditional expression.
if json_request?
^^
app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 8 instead of 6).
# to limit returned ocs to recent or undated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
orders_close_at_gt = raw_params[:q]&.delete(:orders_close_at_gt) || 31.days.ago
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:189:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
raw_params[:q] = { ...
^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:194:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@collection = collection
^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:195:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/order_cycles_controller.rb:196:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)) instead of wrapping the code inside a conditional expression.
unless Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)
^^^^^^
app/controllers/admin/order_cycles_controller.rb:249:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
order_cycle_params.delete_if do |k, _v| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:252:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/order_cycles_controller.rb:254:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if params[:file] || (params[:filepath] && File.exist?(params[:filepath]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if params[:file] || (params[:filepath] && File.exist?(params[:filepath]))) instead of wrapping the code inside a conditional expression.
unless params[:file] || (params[:filepath] && File.exist?(params[:filepath]))
^^^^^^
app/controllers/admin/product_import_controller.rb:60:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to '/admin/product_import', notice: I18n.t(:product_import_file_not_found_notice)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:61:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/product_import_controller.rb:62:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if importer.item_count
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if importer.item_count) instead of wrapping the code inside a conditional expression.
unless importer.item_count
^^^^^^
app/controllers/admin/product_import_controller.rb:94:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to '/admin/product_import', ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:96:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
true
^^^^
app/controllers/admin/product_import_controller.rb:97:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/product_import_controller.rb:99:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/api/v0/shipments_controller.rb:48:11: C: Style/GuardClause: Use a guard clause (unless @shipment.can_ready?; render(json: { error: I18n.t(:cannot_ready, scope: "spree.api.shipment") },
status: :unprocessable_entity) && return; end) instead of wrapping the code inside a conditional expression.
if @shipment.can_ready?
^^
app/controllers/application_controller.rb:118:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if (@distributor = current_distributor)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:118:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if (@distributor = current_distributor)) instead of wrapping the code inside a conditional expression.
unless (@distributor = current_distributor)
^^^^^^
app/controllers/application_controller.rb:119:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.root_path
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:120:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
false
^^^^^
app/controllers/application_controller.rb:121:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:122:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/application_controller.rb:125:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if current_order_cycle
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:125:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if current_order_cycle) instead of wrapping the code inside a conditional expression.
unless current_order_cycle
^^^^^^
app/controllers/application_controller.rb:126:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.shop_path
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:127:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:129:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/application_controller.rb:131:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless current_distributor_closed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:131:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless current_distributor_closed?) instead of wrapping the code inside a conditional expression.
if current_distributor_closed?
^^
app/controllers/application_controller.rb:132:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
current_order.empty!
^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:133:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
current_order.set_distribution! nil, nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:134:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
flash[:info] = I18n.t('order_cycles_closed_for_hub')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:135:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.root_url
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:136:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:139:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/home_controller.rb:7:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless ContentConfig.home_show_stats
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:7:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless ContentConfig.home_show_stats) instead of wrapping the code inside a conditional expression.
if ContentConfig.home_show_stats
^^
app/controllers/home_controller.rb:8:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_distributors = cached_count('distributors', Enterprise.is_distributor.activated.visible)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:9:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_producers = cached_count('producers', Enterprise.is_primary_producer.activated.visible)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:10:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_orders = cached_count('orders', Spree::Order.complete)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:11:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_users = cached_count( ...
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:14:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/home_controller.rb:15:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless params[:order] && params[:order][:line_items_attributes]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:order] && params[:order][:line_items_attributes]) instead of wrapping the code inside a conditional expression.
if params[:order] && params[:order][:line_items_attributes]
^^
app/controllers/spree/orders_controller.rb:137:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
params[:order][:line_items_attributes] = ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:139:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/spree/orders_controller.rb:140:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless items.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless items.empty?) instead of wrapping the code inside a conditional expression.
if items.empty?
^^
app/controllers/spree/orders_controller.rb:184:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
flash[:error] = I18n.t(:orders_cannot_remove_the_final_item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:185:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.order_path(order_to_update)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:186:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/spree/orders_controller.rb:188:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:518:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if owner.can_own_more_enterprises?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:518:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if owner.can_own_more_enterprises?) instead of wrapping the code inside a conditional expression.
unless owner.can_own_more_enterprises?
^^^^^^
app/models/enterprise.rb:519:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:owner, I18n.t(:enterprise_owner_error, email: owner.email, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:521:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:522:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:546:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless is_hub
^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:546:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless is_hub) instead of wrapping the code inside a conditional expression.
if is_hub
^^
app/models/enterprise.rb:547:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprises.is_primary_producer.each do |enterprise| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:553:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:555:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:557:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:557:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression.
unless preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^
app/models/enterprise.rb:558:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:shopfront_category_ordering, "must contain a list of taxons.")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:559:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:562:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:563:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:563:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression.
unless preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^
app/models/enterprise.rb:564:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:shopfront_category_ordering, "must contain a list of producers.")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:565:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:569:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise_group.rb:80:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless permalink.blank? || permalink_changed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:80:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless permalink.blank? || permalink_changed?) instead of wrapping the code inside a conditional expression.
if permalink.blank? || permalink_changed?
^^
app/models/enterprise_group.rb:81:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
requested = permalink.presence || permalink_was.presence || name.presence || 'group'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:82:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
self.permalink = create_unique_permalink(requested.parameterize)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:83:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise_group.rb:84:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/producer_property.rb:16:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless name.present?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:16:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless name.present?) instead of wrapping the code inside a conditional expression.
if name.present?
^^
app/models/producer_property.rb:16:12: C: [Correctable] Rails/Blank: Use if name.blank? instead of unless name.present?.
return unless name.present?
^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:17:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
self.property = Spree::Property.find_by(name: name) || ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/producer_property.rb:20:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless total_saved_count.zero?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless total_saved_count.zero?) instead of wrapping the code inside a conditional expression.
if total_saved_count.zero?
^^
app/models/product_import/entry_processor.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@importer.errors.add(:importer, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/entry_processor.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/product_import/entry_processor.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/spree/order.rb:506:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless !completed? && shipments.any?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:506:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !completed? && shipments.any?) instead of wrapping the code inside a conditional expression.
if !completed? && shipments.any?
^^
app/models/spree/order.rb:507:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
shipments.destroy_all
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:508:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
restart_checkout_flow
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:509:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/spree/order.rb:510:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless method_defined? preference_description_getter_method(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless method_defined? preference_description_getter_method(name)) instead of wrapping the code inside a conditional expression.
if method_defined? preference_description_getter_method(name)
^^
app/models/spree/preferences/preferable_class_methods.rb:68:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
remove_method preference_description_getter_method(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:69:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/spree/preferences/preferable_class_methods.rb:70:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/services/order_syncer.rb:90:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless !pickup_to_delivery || order.shipment.blank?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/order_syncer.rb:90:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !pickup_to_delivery || order.shipment.blank?) instead of wrapping the code inside a conditional expression.
if !pickup_to_delivery || order.shipment.blank?
^^
app/services/order_syncer.rb:91:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
order.updater.shipping_address_from_distributor
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/order_syncer.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/services/order_syncer.rb:93:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless payment.completed? || order.completed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless payment.completed? || order.completed?) instead of wrapping the code inside a conditional expression.
if payment.completed? || order.completed?
^^
engines/order_management/app/services/order_management/order/updater.rb:167:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
persist_totals
^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/order/updater.rb:168:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
engines/order_management/app/services/order_management/order/updater.rb:169:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Style/GuardClause: Use a guard clause (raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m) instead of wrapping the code inside a conditional expression.
if parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m
^^
lib/discourse/single_sign_on.rb:34:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
raise "The SSO field should be Base64 encoded, using only A-Z, a-z, 0-9, +, /, " \ ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/discourse/single_sign_on.rb:37:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:38:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless manages_coordinator?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression.
if manages_coordinator?
^^
lib/open_food_network/order_cycle_form_applicator.rb:77:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
exchange.save!
^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:78:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
ExchangeVariantBulkUpdater.new(exchange).update!(variant_ids) unless variant_ids.nil?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:80:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@touched_exchanges << exchange
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:81:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/open_food_network/order_cycle_form_applicator.rb:82:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless manages_coordinator?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression.
if manages_coordinator?
^^
lib/open_food_network/order_cycle_form_applicator.rb:108:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
untouched_exchanges.each(&:destroy)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:109:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/open_food_network/order_cycle_form_applicator.rb:111:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
raise ActionController::UnknownFormat unless format
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (raise ActionController::UnknownFormat unless format) instead of wrapping the code inside a conditional expression.
if format
^^
lib/spree/core/controller_helpers/respond_with.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
_process_format(format)
^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:44:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
collector
^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless order_cycle && page.has_select?('order_order_cycle_id')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless order_cycle && page.has_select?('order_order_cycle_id')) instead of wrapping the code inside a conditional expression.
if order_cycle && page.has_select?('order_order_cycle_id')
^^
spec/support/request/distribution_helper.rb:11:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
select_by_value order_cycle.id, from: 'order_order_cycle_id'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/distribution_helper.rb:12:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/support/request/distribution_helper.rb:13:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless oc.exchanges.from_enterprise(supplier).incoming.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless oc.exchanges.from_enterprise(supplier).incoming.empty?) instead of wrapping the code inside a conditional expression.
if oc.exchanges.from_enterprise(supplier).incoming.empty?
^^
spec/support/request/shop_workflow.rb:128:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
create(:exchange, order_cycle: oc, incoming: true, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:130:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/support/request/shop_workflow.rb:131:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/system/support/precompile_assets.rb:18:5: C: [Corrected] Style/GuardClause: Use a guard clause (next if Webpacker.dev_server.running?) instead of wrapping the code inside a conditional expression.
if Webpacker.dev_server.running?
^^
spec/system/support/precompile_assets.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/support/precompile_assets.rb:21:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
$stdout.puts "\n Precompiling assets.\n"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/support/precompile_assets.rb:23:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
Webpacker.compile
^^^^^^^^^^^^^^^^^
spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1488 files inspected, 220 offenses detected, 218 offenses corrected, 1 more offense can be corrected with `rubocop -A`
2023-09-01 08:55:56 +09:00
Neal Chambers
afdddc9237
Safely autocorrect Style/FileRead
...
Inspecting 1488 files
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................
Offenses:
lib/tasks/karma.rake:33:15: C: [Corrected] Style/FileRead: Use File.read.
unit_js = File.open('config/ng-test.conf.js', 'r').read
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/upload_sanitizer_spec.rb:13:41: C: [Corrected] Style/FileRead: Use File.read.
let(:service) { UploadSanitizer.new(File.open(upload).read) }
^^^^^^^^^^^^^^^^^^^^^^
1488 files inspected, 2 offenses detected, 2 offenses corrected
2023-09-01 08:55:56 +09:00
Neal Chambers
4cce85378c
Safely autocorrect Rails/WhereNot
...
Inspecting 1488 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
lib/reporting/reports/users_and_enterprises/base.rb:27:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: nil }) instead of manually constructing negated SQL in where.
.where("enterprises.id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:39:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprise_id: nil) instead of manually constructing negated SQL in where.
.where("enterprise_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:40:14: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1488 files inspected, 3 offenses detected, 3 offenses corrected
2023-09-01 08:55:56 +09:00
Neal Chambers
f71ee22d2f
Regenerate Rubocop's TODO file
2023-09-01 08:55:56 +09:00
filipefurtad0
e0031225d1
Covers order special instruction
2023-08-31 14:25:18 +01:00
filipefurtad0
3374c38d5c
Covers order state - cancelled, resumed - changes
2023-08-31 14:25:18 +01:00
filipefurtad0
301c070fc3
Covers order currency change
2023-08-31 14:25:18 +01:00
filipefurtad0
2e72fe1bce
Covers order number change
2023-08-31 14:25:18 +01:00
filipefurtad0
38eb84b1d8
Covers order total change
2023-08-31 14:25:18 +01:00
filipefurtad0
b0c362f75e
Corrects description, if the order didn't change
2023-08-31 14:25:18 +01:00
filipefurtad0
79a38345e9
Passes order as argument
...
to invoice comparator
2023-08-31 14:25:18 +01:00
filipefurtad0
a223675e74
Covers shipping method change
2023-08-31 14:25:18 +01:00
filipefurtad0
0540548893
Adds coverage for included/added taxes
...
at the order-object level
2023-08-31 14:25:18 +01:00
filipefurtad0
8d382f3de4
Corrects description
...
for order-level, non-relevant attribute change
2023-08-31 14:25:18 +01:00
Maikel
67d5ffdc54
Merge pull request #11475 from filipefurtad0/uncomment_i18n_inflections_spec
...
Uncomments pluralize test
2023-08-31 17:20:35 +10:00
Maikel Linke
57b4f615e8
Fix DFC context in spec example
2023-08-31 17:06:20 +10:00
David Cook
63383e8ea1
Enable editing of variant price
...
Formatting of the price was copied from the existing bulk product screen.
2023-08-31 16:41:41 +10:00
David Cook
26d6dedd4d
Fix FrozenString error
...
An error was apparent in specs when trying to assign a string as the price. It's not a problem when submitting the form in the browser, I don't know why.
But in any case, it shouldn't be trying to modify a variable passed as a parameter.
2023-08-31 16:41:41 +10:00
David Cook
b955cd8fee
Enable editing of variant SKU
...
I'm not sure what the point of the product SKU was to be honest.. it will probably be removed in the product refactor.
2023-08-31 16:41:41 +10:00
David Cook
f69fc67d5e
Refactor: using Rails form magic
...
Now we don't have to specify the field names on products, yay!
I tried desparately to get it working for the nested variant forms too, but sadly the form builder refuses to acknowledge the relationship. The form builder simply doesn't support a collection of objects in this way.
We could try creating a fake model similar to ProductSet that accepts_nested_attributes_for :products. But it woudl be better to create a custom form builder to do it.
Or, just manually specify field names for now!
2023-08-31 16:41:41 +10:00
David Cook
7f05a4913c
Remove explicit index numbers from form names
...
I have to admit I don't fully understand why, but it seems to work, even though the rails guide says "only one level of arrayness is allowed (https://guides.rubyonrails.org/form_helpers.html#combining-them ). Maybe it's ok here because it's not an array of arrays.
(I think this format is what the reflex spec was already testing).
2023-08-31 16:41:41 +10:00
David Cook
e17d16cb52
Enable editing of variant display_name
...
Best viewed with whitespace ignored.
Using Rails' nested attributes feature, which ModelSet already supports.
2023-08-31 16:41:41 +10:00
David Cook
5356e42efc
Enable editing of product SKU
2023-08-31 16:41:41 +10:00
David Cook
9fe9d8557c
Remove line-clamp for inputs
...
It doesn't work and we don't currently have a better solution for that.
2023-08-31 16:41:41 +10:00
David Cook
aff33b79ae
Simplify form code
...
The form elements shouldn't need an `id` attribute.
2023-08-31 16:41:36 +10:00
Maikel Linke
514b8fa6ab
Import DFC unit labels like bunch and jar
2023-08-31 16:27:55 +10:00
Maikel Linke
427d806b13
Remove ambiguous unit "cup"
...
The DFC doesn't actually specify which cup it means. I don't expect
anyone providing "cup" as unit to measure their produce and expect it to
calculate as a regular volume. It can just be seen as items.
2023-08-31 16:11:50 +10:00
Maikel Linke
5bfbf43a38
Spec bulk enterprise fee edit without row ids
...
It makes the spec robust to different sorting of the rows. It also hides
the knowledge of the full element ids.
2023-08-31 16:03:46 +10:00
Maikel Linke
bb336ff9c4
Avoid unnecessary requests in system specs
...
This spec was nested within another block that executed a form submit
which we don't actually need here. So I flattened the structure and
repeated the few missing lines of code. This speeds up the execution.
The fee type is important in the setup because it determines the order
of the fees on the page and we access the rows by their row index.
This commit is best viewed without whitespace changes.
2023-08-31 13:44:33 +10:00
Maikel Linke
1abbfc01d2
Stabilise enterprise fee spec
...
The problem here was that the second fee was created in a `let!` block
that came after a `before` block which visited the page. In some cases
it worked but sometimes the fee wasn't created yet when the page was
loaded. Form changes in the second row were not affecting the second fee
as intended.
2023-08-31 10:02:06 +10:00
Maikel Linke
50f7177a38
Use existing service to label weight&volume units
...
We still have the scale stored in two places but in our current system
that's part of a unit's "id".
If the DFC adds that value to its standard then we can use it for lookup
and don't need to repeat it.
* https://github.com/datafoodconsortium/taxonomies/issues/7
2023-08-31 09:48:24 +10:00
filipefurtad0
6bc8a1a850
Uncomments pluralize test
2023-08-30 22:57:46 +01:00
Maikel Linke
0da1b27795
Simplify code with association #supplied_variants
...
Rails makes it so easy.
2023-08-30 15:55:10 +10:00
Maikel Linke
01e1dc137e
Simplify access of an enterprise's variants
2023-08-30 15:47:03 +10:00
Maikel
dea96fd3ab
Merge pull request #11469 from openfoodfoundation/dependabot/bundler/rubocop-1.56.2
...
chore(deps-dev): bump rubocop from 1.56.1 to 1.56.2
2023-08-30 12:14:36 +10:00
Konrad
077bb41412
Merge pull request #11348 from abdellani/fix-non-empty-orders-in-cart-state-not-appearing
...
fix Non-empty orders in the cart state do not appear in orders page
2023-08-29 15:33:49 +02:00
David Cook
ff3802fe69
Merge pull request #11457 from filipefurtad0/renames_knapsack_nodes
...
Renames Knapsack nodes
2023-08-29 21:04:43 +10:00
dependabot[bot]
091544583f
chore(deps-dev): bump rubocop from 1.56.1 to 1.56.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.1 to 1.56.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.56.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-29 09:38:31 +00:00
David Cook
78585afc9c
Fix format
2023-08-29 16:00:26 +10:00
filipefurtad0
0d1f3f82fd
Balances build time
...
Two nodes were removed from models and three engines; these were and added to system_consumer and system_admin, respectively
2023-08-28 10:28:14 +01:00
filipefurtad0
3a6ca38432
Renames Knapsack nodes
2023-08-28 10:28:14 +01:00
Filipe
67fdc56270
Merge pull request #11427 from mkllnk/release-template
...
Generate all release note categories with labels
2023-08-28 10:04:57 +01:00
Maikel Linke
8114430248
Refactor DFC unit mapping for easier reading
...
I also updated the comments.
2023-08-28 17:13:04 +10:00
Maikel Linke
f96ab7c432
Import DFC bundle units like dozen or 6 pack
2023-08-28 17:13:04 +10:00
Maikel Linke
f096783098
Import all metric DFC units
2023-08-28 17:13:04 +10:00
Maikel Linke
43346e2671
Import imperial DFC units
2023-08-28 17:13:04 +10:00
Maikel Linke
9ddf536fa3
Import DFC milligram
2023-08-28 17:13:04 +10:00
Maikel Linke
5a8d95c443
Import DFC kilogram
2023-08-28 17:13:04 +10:00
Maikel Linke
996f3bb235
Spec current quantity unit conversion
2023-08-28 17:13:04 +10:00
Maikel Linke
96b79bce2d
Encapsulate DFC-OFN data model bridge
...
Re-uses existing code and takes knowledge out of the controller.
2023-08-28 17:13:04 +10:00
Maikel Linke
9ab75e086a
Use DFC Connector for SuppliedProduct update
2023-08-28 17:13:04 +10:00
Maikel Linke
faa112c3ae
Spec DFC SuppliedProduct#update with new Prototype
...
I observed new data from the DFC Prototype. It now uses the DFC 1.8
ontology with the hasQuantity object.
It now also uses PUT requests for updates because PATCH is not as well
supported. Rails doesn't care though.
I couldn't observe a request for the CatalogItem yet because the
Prototype failed to send it.
2023-08-28 17:13:04 +10:00
Maikel
cf8d5a584e
Merge pull request #11455 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.1.1
...
chore(deps-dev): bump jasmine-core from 5.1.0 to 5.1.1
2023-08-28 11:51:36 +10:00
Maikel
7e44c75456
Merge pull request #11453 from dacook/buu-labels
...
Buu labels
2023-08-28 11:50:35 +10:00
Maikel
86842847ad
Merge pull request #11452 from dacook/flaky-spec-products_v3-11328
...
[Flaky] spec/system/admin/products_v3/products_spec.rb
2023-08-28 11:45:12 +10:00
Maikel
dd79761186
Merge pull request #11448 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.134.0
...
chore(deps): bump aws-sdk-s3 from 1.133.0 to 1.134.0
2023-08-28 11:43:31 +10:00
Maikel
0b869f2abe
Merge pull request #11451 from mkllnk/flaky-voucher-specs
...
De-flake voucher specs by checking success
2023-08-28 11:16:43 +10:00
dependabot[bot]
00ea2e5b07
chore(deps-dev): bump jasmine-core from 5.1.0 to 5.1.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-25 09:09:08 +00:00
David Cook
7d6ba2d31f
Clean up unneeded override
2023-08-25 17:23:05 +10:00
David Cook
451513ad04
Markup labels as.. labels
...
This means you can click on the label name to select the field, and accessibility software can read the label name. I was motivated to do this so that we could update the spec to use label text rather than IDs. But it seems we can't do that with tom-select.
I've updated the styles for all form labels (in admin_style_v3 toggle) to match the design.
2023-08-25 17:19:46 +10:00
Maikel Linke
200729f198
Show incomplete orders when sorting by name
...
An inner join with the billing address was hiding some orders when
sorting by billing address name. Telling Rails that those fields are
referenced triggers an outer left join including orders without billing
address.
But when the Bulk Order Management page sorts by `bill_address_lastname`
then Ransack does most of the magic, except that we need to override the
select in combination with distinct results.
2023-08-25 16:15:11 +10:00
David Cook
4d79cdb0ea
Ensure records are created before visiting the page
...
'let!' is executed in the same way as 'before', so it matters which order they are defined in.
For contexts with a single example, I just put it straight into the example.
2023-08-25 16:09:52 +10:00
Maikel Linke
d8da808901
Resolve pending spec, reported issue is fixed
2023-08-25 15:48:31 +10:00
David Cook
ccafdc4494
Remove redundant code
...
bill_address is already joined in this query.
The class variable isn't needed outside this scope.
Arguably I think the condition on the select isn't needed; it wouldn't hurt to always select spree_addresses. But I'll try to avoid changing too much..
2023-08-25 15:48:31 +10:00
Mohamed ABDELLANI
04312b05c6
add orders without billing address to SearchOrders#fetch_orders' results
2023-08-25 15:48:31 +10:00
David Cook
4f9651f5c9
Wait for pagination message to update
...
Hopefully this fixes openfoodfoundation/openfoodnetwork#11328
2023-08-25 14:52:50 +10:00
Maikel Linke
1a95476634
Combine some voucher system specs to save time
...
It also simplifies the spec code a bit not having a shared example.
2023-08-25 13:56:41 +10:00
Maikel Linke
233171a9ce
De-flake voucher specs by checking success
...
Vouchers are applied via a reflex and we need to check for success
before trying to navigate further. The new helper does this in a
consistent way.
2023-08-25 13:56:41 +10:00
Maikel Linke
4be38ba8da
Remove redundant system spec
...
System specs are expensive. And this spec just looked for the visibility
of certain elements while other tests actually use them and therefore
verify their function much more thoroughly.
2023-08-25 13:56:41 +10:00
Maikel
7414b5cbc9
Merge pull request #11397 from rioug/11331-add-required-field-dcf-enterprise
...
Add required enterprise fields to DFC API
2023-08-25 11:44:49 +10:00
Maikel
56f4eca79e
Update engines/dfc_provider/app/controllers/dfc_provider/addresses_controller.rb
...
Fix type in comment
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-25 11:31:00 +10:00
Maikel
a7e2d23e3b
Merge pull request #11449 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.6.0
...
chore(deps-dev): bump knapsack_pro from 5.4.1 to 5.6.0
2023-08-25 10:50:32 +10:00
Maikel Linke
467d72dc31
Test voucher UI with most common feature toggle
...
People want to test vouchers mainly on a per-enterprise basis.
Replicating this in the system spec makes sure that we are testing the
conditionals in views.
2023-08-25 10:19:17 +10:00
Maikel Linke
e12cf2aa4c
Simplify feature check for multiple actors at once
...
I think that it's a valid case to check a feature toggle against the
user and an enterprise. You may want to check with only one user first,
then activate it for a whole enterprise and lastly activate the feature
globally.
2023-08-25 10:19:17 +10:00
Maikel Linke
0cc450e815
Allow Vouchers feature per enterprise
...
I also kept the per-user check to be backwards-compatible. Some
instances have that enabled already. And for early testing, you may want
to test with only one user first before all customer see it.
2023-08-25 10:19:17 +10:00
Maikel Linke
02edd829b9
Allow to admin vouchers if you know the URL
...
The generic FeatureToggleConstraint in routing knows about the current
user but not about the enterprise to edit. We could create a new custom
constraint for routing but it's much easier to handle permissions in the
controller. Let's keep routes simple.
2023-08-25 10:19:17 +10:00
David Cook
aea0a629ee
Merge pull request #11425 from macanudo527/fix_rails_activerecordoverride
...
Fix Rails/ActiveRecordOverride
2023-08-25 09:22:05 +10:00
dependabot[bot]
5b25fa80a2
chore(deps-dev): bump knapsack_pro from 5.4.1 to 5.6.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.4.1 to 5.6.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.4.1...v5.6.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 23:01:05 +00:00
dependabot[bot]
61109259e4
chore(deps): bump aws-sdk-s3 from 1.133.0 to 1.134.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.133.0 to 1.134.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 23:00:22 +00:00
Maikel
54e8df7c88
Merge pull request #11443 from openfoodfoundation/dependabot/bundler/ffaker-2.22.0
...
chore(deps): bump ffaker from 2.21.0 to 2.22.0
2023-08-25 08:56:34 +10:00
Maikel
0441453469
Merge pull request #11439 from mkllnk/unflake-customer-report-spec
...
Report customers in deterministic order
2023-08-25 08:54:21 +10:00
Neal Chambers
2bfa51cbb1
Fix Rails/ActiveRecordOverride
2023-08-25 08:51:27 +10:00
filipefurtad0
a39c465692
Update all locales with the latest Transifex translations
2023-08-24 21:36:53 +01:00
Filipe
cc3b7c68ae
Merge pull request #11208 from dacook/buu-editing-11059
...
[BUU] Change name of my products 🚧
2023-08-24 21:19:52 +01:00
Filipe
10bc2a3ee6
Merge pull request #11430 from abdellani/fix-updating-invoices-data
...
fix order invoice generator must update the latest invoice
2023-08-24 20:58:37 +01:00
dependabot[bot]
221eea227f
chore(deps): bump ffaker from 2.21.0 to 2.22.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 2.21.0 to 2.22.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/main/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/compare/v2.21.0...v2.22.0 )
---
updated-dependencies:
- dependency-name: ffaker
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 09:58:42 +00:00
Filipe
020276a248
Merge pull request #11418 from macanudo527/fix_rubocop_7
...
Fix Rails and Style Autocorrect Rubocop Errors
2023-08-24 10:29:45 +01:00
Filipe
c5e1444613
Merge pull request #11206 from macanudo527/fix_class_length
...
Add Form Object to Schedules Controller
2023-08-24 09:28:50 +01:00
Konrad
c90b244a96
Merge pull request #11415 from abdellani/snail-when-setting-unit-value-to-0
...
fix Snail when setting "0" in the unit value field
2023-08-24 10:04:26 +02:00
Konrad
6ec022b731
Merge pull request #11391 from rioug/11362-fix-error-creating-percentage-voucher
...
[Vouchers] fix error when creating a percentage voucher
2023-08-24 09:09:30 +02:00
Maikel Linke
1c3574ce79
Include address in DFC Enterprise endpoint
2023-08-24 16:51:36 +10:00
Maikel Linke
20b09b5352
Add DFC Address API endpoint
2023-08-24 16:20:13 +10:00
Gaetan Craig-Riou
a8d15154a2
Link address to enterprise
...
+ spec
2023-08-24 15:55:15 +10:00
Gaetan Craig-Riou
86bb77ab9f
Add AddressBuilder
...
It will let us include address in the various DFC API endpoint
2023-08-24 15:55:15 +10:00
Gaetan Craig-Riou
f5fb760128
Update Enterprise request spec
...
Check all the attributes supported by the DFC connector
2023-08-24 15:55:14 +10:00
Maikel Linke
244b9abd21
Spec with given data included in examples
...
And use in-memory data where possible to speed up specs.
2023-08-24 15:55:14 +10:00
Maikel Linke
5d05c3c0f1
DRY DFC enterprise spec
2023-08-24 15:55:14 +10:00
Gaetan Craig-Riou
18565f4a85
Add all the enterpise attributes supported by DFC connector
2023-08-24 15:55:14 +10:00
David Cook
3c617a51e0
Merge pull request #11433 from openfoodfoundation/dependabot/bundler/mime-types-3.5.1
...
chore(deps): bump mime-types from 3.5.0 to 3.5.1
2023-08-24 15:11:09 +10:00
David Cook
a96b712eb2
Merge pull request #11432 from openfoodfoundation/dependabot/bundler/activerecord-import-1.5.0
...
chore(deps): bump activerecord-import from 1.4.1 to 1.5.0
2023-08-24 15:10:02 +10:00
David Cook
4a877fe019
Merge pull request #11426 from mkllnk/style-has-many
...
Allow has_and_belongs_to_many to reduce code
2023-08-24 15:03:17 +10:00
dependabot[bot]
f0dce7765c
chore(deps): bump activerecord-import from 1.4.1 to 1.5.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.4.1 to 1.5.0.
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.4.1...v1.5.0 )
---
updated-dependencies:
- dependency-name: activerecord-import
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 02:54:17 +00:00
Maikel
79211bd856
Merge pull request #11438 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.133.0
...
chore(deps): bump aws-sdk-s3 from 1.132.1 to 1.133.0
2023-08-24 12:52:39 +10:00
Maikel
fba55fe9fd
Merge pull request #11437 from openfoodfoundation/dependabot/bundler/rails-7.0.7.2
...
chore(deps): bump rails from 7.0.7 to 7.0.7.2
2023-08-24 12:51:08 +10:00
Maikel
d6572d9fde
Merge pull request #11434 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.4.1
...
chore(deps-dev): bump knapsack_pro from 5.3.5 to 5.4.1
2023-08-24 12:46:33 +10:00
Neal Chambers
a363f88f2c
Put Subscriptions back into Schedules Controller
2023-08-24 09:18:35 +09:00
Neal Chambers
7eab4d64ba
Update .rubocop_todo.yml
2023-08-24 09:17:55 +09:00
Neal Chambers
134cbb4f04
Add Form Object to Fix Metrics/ClassLength
2023-08-24 09:17:53 +09:00
David Cook
a8d37d0899
Apply suggestions from code review
...
Rails is clever enough to not query the database without ids
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-24 08:48:27 +10:00
Filipe
1021fd94b5
Merge pull request #11419 from openfoodfoundation/dependabot/bundler/stripe-9.0.0
...
chore(deps): bump stripe from 8.6.0 to 9.0.0
2023-08-23 17:35:29 +01:00
Mohamed ABDELLANI
928494af23
use Invoice#latest to fetch the most recent invoice
2023-08-23 11:57:30 +01:00
Mohamed ABDELLANI
f9e6f8bfa5
fix existing tests
2023-08-23 11:50:33 +01:00
dependabot[bot]
cd9bf6a62e
chore(deps): bump stripe from 8.6.0 to 9.0.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.6.0 to 9.0.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.6.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 11:42:43 +01:00
Maikel Linke
4c3d619260
Report customers in deterministic order
...
The result could be random before which led to a flaky spec. I could
have adjusted the spec but I thought that it may be better UX as well to
be deterministic, especially when exporting into spreadsheets.
2023-08-23 17:03:30 +10:00
Maikel Linke
226d270cc1
Remove now obsolete comment
2023-08-23 14:30:46 +10:00
Maikel Linke
58fc9fc8bb
Update symbol for technical changes
2023-08-23 14:29:52 +10:00
Maikel
7e55421ab8
Convey feature toggle release category more clearly
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-23 12:38:49 +10:00
dependabot[bot]
ea46d15ad4
chore(deps): bump aws-sdk-s3 from 1.132.1 to 1.133.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.132.1 to 1.133.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 02:28:35 +00:00
dependabot[bot]
752d77110d
chore(deps): bump rails from 7.0.7 to 7.0.7.2
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.7 to 7.0.7.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.7...v7.0.7.2 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 02:28:07 +00:00
Maikel
57c44ffc72
Merge pull request #11429 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.2
...
chore(deps): bump newrelic_rpm from 9.4.1 to 9.4.2
2023-08-23 12:24:53 +10:00
Maikel
9bfb59d45f
Merge pull request #11428 from openfoodfoundation/dependabot/bundler/rubocop-1.56.1
...
chore(deps-dev): bump rubocop from 1.56.0 to 1.56.1
2023-08-23 12:23:43 +10:00
Mohamed ABDELLANI
c689e2da8b
remove ToS link on mails if ToS file is not set
2023-08-22 11:33:04 +01:00
Mohamed ABDELLANI
93c2cfd6c0
hide ToS from footer if the file is not set
2023-08-22 11:27:20 +01:00
Konrad
3aca33b8a6
Merge pull request #11230 from macanudo527/fix_products_controller
...
Add Query Object to Product Model to Fix Metrics/ClassLength
2023-08-22 11:38:09 +02:00
Mohamed ABDELLANI
b082475c35
update product's unit_value validation
2023-08-22 10:28:27 +01:00
Mohamed ABDELLANI
423163c4e9
hide agree to the ToS when not ToS file is set
2023-08-22 10:22:26 +01:00
Mohamed ABDELLANI
d47b47627c
tos_accepted? returns true if the ToS file is not set
2023-08-22 10:22:26 +01:00
dependabot[bot]
067ddb7bcd
chore(deps-dev): bump knapsack_pro from 5.3.5 to 5.4.1
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.5 to 5.4.1.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.5...v5.4.1 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-22 09:04:55 +00:00
dependabot[bot]
238249e8ec
chore(deps): bump mime-types from 3.5.0 to 3.5.1
...
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types ) from 3.5.0 to 3.5.1.
- [Changelog](https://github.com/mime-types/ruby-mime-types/blob/main/History.md )
- [Commits](https://github.com/mime-types/ruby-mime-types/compare/v3.5.0...v3.5.1 )
---
updated-dependencies:
- dependency-name: mime-types
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-22 09:03:13 +00:00
Mohamed ABDELLANI
a896d414c2
optimize system test
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
3ab288f435
fix product's unit value validation
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
d4dbc0adb5
fix unit_value initialization on the product duplicator
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
a9e4159839
validate unit_value > 0 on product model
2023-08-22 09:16:47 +01:00
David Cook
2edf504d65
Ignore long classes for now
...
As much as I hate to add to this list, this is still a work in progress so it's not worth refactoring at this point.
2023-08-22 11:51:05 +10:00
David Cook
b0e77df226
Style form actions area
2023-08-22 11:51:05 +10:00
David Cook
fccde964bf
Enable 'medium' style for reset buttons
2023-08-22 11:46:56 +10:00
David Cook
7bf79441c8
Update link colours to match new design
2023-08-22 11:40:58 +10:00
David Cook
3cc5d7ba1d
Copy form styles to v3
2023-08-22 11:40:58 +10:00
David Cook
37d1113e4c
Align row headers with input contents
...
Inputs add extra padding, so we add the same padding to the header. Using an opt-in class, because I think we won't want this on all columns.
2023-08-22 11:40:58 +10:00
David Cook
8440c44a6f
Remove unused style
2023-08-22 11:40:58 +10:00
David Cook
2b09ec7c21
[fixup] Left line for row hover
2023-08-22 11:40:58 +10:00
David Cook
be24247df2
[wip] Left line for row hover
...
But it's not perfect. Can we use a pseudo element instead?
2023-08-22 11:40:58 +10:00
David Cook
565ea23175
Hide borders from inputs until hover
2023-08-22 11:40:58 +10:00
David Cook
ef63c520c0
Aggregate errors
2023-08-22 11:40:58 +10:00
David Cook
a70f392654
Show error messages
...
It's kinda hard to test reflexes..
2023-08-22 11:40:58 +10:00
David Cook
a0dba001bc
Attempt to save all records in bulk update
...
Before, it would abort after the first invalid record, and it doesn't tell you about the others. This way you find out about all at once.
This affects the existing Bulk Edit Products screen, and can result in longer error messages than before. But I would argue that's a good thing.
I think this is technically optional for BUU at this point, but a helpful improvement.
2023-08-22 11:40:58 +10:00
David Cook
71c36585bc
Retain order when saving.
...
Perhaps this should be tested in the system spec too ("I can rename a product and still see it after saving"). But I'd like to find the compromise to avoid bulking up system specs too much. I think it's covered well enough by the reflex spec?
2023-08-22 11:40:58 +10:00
David Cook
6ffe1ec1ad
Retain the order of products in the collection
2023-08-22 11:40:58 +10:00
David Cook
ae3cd6f7e0
Add bulk_update product form for product name
...
(For now at least,) we use one big standard Rails form, and ModelSet to update each record.
Submitting with Reflex allows us to manage the loading state along with the rest of the page (although I would rather use the built in HTTP POST standard).
Aria-label makes it a bit easier for testing (and accessibility software of course!). Technically it should have been aria-labelledby="id_of_column_header" but that would have resulted in more HTML and processing, which seemed silly.
Best viewed with whitespace ignored.
2023-08-22 11:40:58 +10:00
David Cook
a98242e5b4
Capybara: enable_aria_label
2023-08-22 11:40:58 +10:00
David Cook
e37a499125
Merge pull request #11383 from jibees/11274-buu-as-a-single-producer-i-should-not-be-able-to-see-the-producer-dropdown
...
🚧 Products V3: Do not display "Producers" selector if only one is possible
2023-08-22 11:33:12 +10:00
Maikel Linke
31d87ca087
Show producer filter only when multiple options
...
Also introducing a view spec here because the code was incorrectly
refactored before. The execution of the view spec takes only 100ms
which is much faster than a system spec.
2023-08-22 10:00:06 +10:00
Jean-Baptiste Bellet
6582a875c6
Do not display "Producers" selector if only one is possible
...
Fix #11274
Co-Authored-By: David Cook <david@redcliffs.net >
2023-08-22 10:00:06 +10:00
David Cook
71b297b5b5
Merge pull request #11417 from jibees/11410-go-back-to-top-after-selecting-a-page-in-pagination
...
🚧 BUU: Once products are loaded, scroll higher, ie. just above filters
2023-08-22 09:20:31 +10:00
Konrad
391d06130d
Merge pull request #11395 from duleorlovic/google-map-region
...
Add Google map region parameter
2023-08-21 18:14:56 +02:00
Mohamed ABDELLANI
aaf1d22ccc
fix order invoice generator must update the latest invoice
2023-08-21 16:10:05 +01:00
dependabot[bot]
397f365fe6
chore(deps): bump newrelic_rpm from 9.4.1 to 9.4.2
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.4.1 to 9.4.2.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.4.1...9.4.2 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-21 09:28:35 +00:00
dependabot[bot]
c97b5b3693
chore(deps-dev): bump rubocop from 1.56.0 to 1.56.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.0 to 1.56.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.0...v1.56.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-21 09:27:48 +00:00
Maikel
af73720157
Merge pull request #11423 from openfoodfoundation/dependabot/bundler/puma-6.3.1
...
chore(deps): bump puma from 6.3.0 to 6.3.1
2023-08-21 14:04:20 +10:00
Maikel Linke
2917e2f849
Generate all release note categories with labels
...
If reviewers add the right labels to pull requests then the release
note categories can be generated automatically.
2023-08-21 10:39:52 +10:00
Maikel Linke
ff18270898
Allow has_and_belongs_to_many to reduce code
...
The Rails/HasAndBelongsToMany rule wants model classes for all
many-to-many relationship tables in the database. But our team thinks
that it's useful to declare has_and_belongs_to_many relationships which
don't require an additional model.
2023-08-21 10:12:33 +10:00
Neal Chambers
0b6b750706
Clarify Product Scope Query Spec
2023-08-20 13:01:34 +09:00
Neal Chambers
fc47c57603
Add helper method to products controller and Use query object
2023-08-20 13:00:39 +09:00
Neal Chambers
9e82ab8a0f
Remove query scopes from product model
2023-08-20 13:00:39 +09:00
Neal Chambers
c125c42a6d
Add Tests for Product Scope Query
2023-08-20 13:00:39 +09:00
Neal Chambers
a867f7c543
Add Product Scope Query
2023-08-20 13:00:36 +09:00
Maikel Linke
eb204c9e5b
Style HashSyntax and reduce line length
2023-08-20 12:33:43 +09:00
Maikel Linke
e0acc25808
Fix subscription spec and add more coverage
...
One spec was only passing due to a bug. The setup wasn't complete and
despite the variant being unavailable in the order cycle it was reported
as being available. The order cycle has now been set up correctly.
Another spec was added to cover an edge case lead to a bug before this
pull request. When all subscription items where unavailable, all were
marked as available.
2023-08-20 12:33:43 +09:00
Neal Chambers
bc559b966c
Safely autocorrect Style/FetchEnvVar
...
Inspecting 1483 files
..............................................................................................................................................................C.............................................................................................................................................................................CC.............................................................................................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................C.................................................................................C..............................................................................................................................................................................................C.....................................................................................................................................................................................................................................C......................................................................................................................
Offenses:
app/helpers/discourse_helper.rb:9:5: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('DISCOURSE_URL') or ENV.fetch('DISCOURSE_URL', nil) instead of ENV['DISCOURSE_URL'].
ENV['DISCOURSE_URL']
^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/configuration.rb:35:10: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('RAILS_CACHE_ID') or ENV.fetch('RAILS_CACHE_ID', nil) instead of ENV['RAILS_CACHE_ID'].
[ENV['RAILS_CACHE_ID'], self.class.name, name].flatten.join('::').underscore
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable.rb:84:10: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("RAILS_CACHE_ID") or ENV.fetch("RAILS_CACHE_ID", nil) instead of ENV["RAILS_CACHE_ID"].
[ENV["RAILS_CACHE_ID"], self.class.name, name, id].join('::').underscore
^^^^^^^^^^^^^^^^^^^^^
app/services/default_country.rb:13:40: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("DEFAULT_COUNTRY_CODE") or ENV.fetch("DEFAULT_COUNTRY_CODE", nil) instead of ENV["DEFAULT_COUNTRY_CODE"].
Spree::Country.cached_find_by(iso: ENV["DEFAULT_COUNTRY_CODE"]) || Spree::Country.first
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/default_country.rb:13:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
Spree::Country.cached_find_by(iso: ENV.fetch("DEFAULT_COUNTRY_CODE",
^
app/services/default_country.rb:13:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
Spree::Country.cached_find_by(iso: ENV.fetch("DEFAULT_COUNTRY_CODE", nil)) || Spree::Country.first
^^
app/services/default_country.rb:14:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
nil)) || Spree::Country.first
^^^
spec/base_spec_helper.rb:51:49: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("SITE_URL") or ENV.fetch("SITE_URL", nil) instead of ENV["SITE_URL"].
ActionMailer::Base.default_url_options[:host] = ENV["SITE_URL"]
^^^^^^^^^^^^^^^
spec/controllers/spree/credit_cards_controller_spec.rb:8:20: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_SECRET_TEST_API_KEY') or ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) instead of ENV['STRIPE_SECRET_TEST_API_KEY'].
let(:secret) { ENV['STRIPE_SECRET_TEST_API_KEY'] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:48:70: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(order_balance.display_amount).to eq(Spree::Money.new(20,
^
spec/models/order_balance_spec.rb:48:81: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('currency') or ENV.fetch('currency', nil) instead of ENV['currency'].
expect(order_balance.display_amount).to eq(Spree::Money.new(20, currency: ENV['currency']))
^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:48:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100]
expect(order_balance.display_amount).to eq(Spree::Money.new(20, currency: ENV.fetch('currency', nil)))
^^^^^^^^
spec/models/order_balance_spec.rb:49:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
currency: ENV.fetch('currency', nil)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:49:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
currency: ENV.fetch('currency',
^
spec/models/order_balance_spec.rb:49:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
currency: ENV.fetch('currency', nil)))
^^^^
spec/models/order_balance_spec.rb:50:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
nil)))
^^^
spec/support/vcr_setup.rb:10:50: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_SECRET_TEST_API_KEY') or ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) instead of ENV['STRIPE_SECRET_TEST_API_KEY'].
config.filter_sensitive_data('<HIDDEN_KEY>') { ENV['STRIPE_SECRET_TEST_API_KEY'] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/vcr_setup.rb:11:55: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_CUSTOMER') or ENV.fetch('STRIPE_CUSTOMER', nil) instead of ENV['STRIPE_CUSTOMER'].
config.filter_sensitive_data('<HIDDEN_CUSTOMER>') { ENV['STRIPE_CUSTOMER'] }
^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 18 offenses detected, 18 offenses corrected
2023-08-20 12:33:43 +09:00
Neal Chambers
fd795d8513
Safely autocorrect Style/BlockComments
...
Inspecting 1483 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................
Offenses:
spec/system/admin/tag_rules_spec.rb:209:1: C: [Corrected] Style/BlockComments: Do not use block comments.
=begin ...
^^^^^^
spec/system/admin/tag_rules_spec.rb:217:101: C: Layout/LineLength: Line is too long. [103/100]
# expect(default_fsm_tag_rule.preferred_matched_shipping_methods_visibility).to eq "hidden"
^^^
spec/system/admin/tag_rules_spec.rb:241:1: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 6).
# expect(foc_tag_rule.preferred_matched_order_cycles_visibility).to eq "hidden"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 3 offenses detected, 2 offenses corrected
2023-08-20 12:33:43 +09:00
Neal Chambers
06e217c527
Safely autocorrect Rails/WhereNot
...
Inspecting 1483 files
........................................................................................................................C..................................................................................................................C...........CC.C..........................................C......C..........C.........................C......................CC..........C........................................................................................................................C.......................................................................................................C........................................................C...........................................................................................................................................C......................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/spree/admin/products_controller.rb:183:11: C: [Corrected] Rails/WhereNot: Use where.not(spree_variants: { import_date: nil }) instead of manually constructing negated SQL in where.
where('spree_variants.import_date IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/concerns/permalink_generator.rb:37:26: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
scope_with_deleted.where('id != ?', id)
^^^^^^^^^^^^^^^^^^^^
app/models/concerns/permalink_generator.rb:37:40: C: [Corrected] Style/HashSyntax: Omit the hash value.
scope_with_deleted.where.not(id: id)
^^
app/models/enterprise.rb:152:7: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: ready_enterprises }) instead of manually constructing negated SQL in where.
where("enterprises.id NOT IN (?)", ready_enterprises)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:158:31: C: [Corrected] Rails/WhereNot: Use where.not(sells: 'none') instead of manually constructing negated SQL in where.
scope :is_distributor, -> { where('sells != ?', 'none') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:479:17: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
dups = dups.where('id != ?', id) unless new_record?
^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:534:43: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: self }) instead of manually constructing negated SQL in where.
enterprises = owner.owned_enterprises.where('enterprises.id != ?', self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:583:7: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: id }) instead of manually constructing negated SQL in where.
where('enterprises.id != ?', id).
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_fee.rb:40:24: C: [Corrected] Rails/WhereNot: Use where.not(spree_calculators: { type: PER_ORDER_CALCULATORS }) instead of manually constructing negated SQL in where.
joins(:calculator).where('spree_calculators.type NOT IN (?)', PER_ORDER_CALCULATORS)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:78:19: C: [Corrected] Rails/WhereNot: Use where.not(name: perms) instead of manually constructing negated SQL in where.
permissions.where('name NOT IN (?)', perms).destroy_all
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/inventory_reset_strategy.rb:27:16: C: [Corrected] Rails/WhereNot: Use where.not(id: excluded_items_ids) instead of manually constructing negated SQL in where.
relation.where('id NOT IN (?)', excluded_items_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/proxy_order.rb:19:25: C: [Corrected] Rails/WhereNot: Use where.not(proxy_orders: { canceled_at: nil }) instead of manually constructing negated SQL in where.
scope :canceled, -> { where('proxy_orders.canceled_at IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/credit_card.rb:26:39: C: [Corrected] Rails/WhereNot: Use where.not(gateway_customer_profile_id: nil) instead of manually constructing negated SQL in where.
scope :with_payment_profile, -> { where('gateway_customer_profile_id IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/product.rb:166:9: C: [Corrected] Rails/WhereNot: Use where.not(order_cycles: { id: nil }) instead of manually constructing negated SQL in where.
where('order_cycles.id IS NOT NULL')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:94:30: C: [Corrected] Rails/WhereNot: Use where.not(deleted_at: nil) instead of manually constructing negated SQL in where.
scope :deleted, lambda { where('deleted_at IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:165:43: C: [Corrected] Rails/WhereNot: Use where.not(spree_prices: { amount: nil }) instead of manually constructing negated SQL in where.
where('spree_prices.amount IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/zone.rb:141:19: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
Spree::Zone.where('id != ?', id).update_all(default_tax: false) if default_tax
^^^^^^^^^^^^^^^^^^^^
app/models/spree/zone.rb:141:33: C: [Corrected] Style/HashSyntax: Omit the hash value.
Spree::Zone.where.not(id: id).update_all(default_tax: false) if default_tax
^^
app/models/variant_override.rb:32:7: C: [Corrected] Rails/WhereNot: Use where.not(variant_overrides: { import_date: nil }) instead of manually constructing negated SQL in where.
where('variant_overrides.import_date IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/cap_quantity.rb:45:22: C: [Corrected] Rails/WhereNot: Use where.not(variant_id: available_variants_for.select(&:id)) instead of manually constructing negated SQL in where.
order.line_items.where('variant_id NOT IN (?)', available_variants_for.select(&:id))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/app/services/catalog/product_import/products_reset_strategy.rb:32:18: C: [Corrected] Rails/WhereNot: Use where.not(spree_variants: { id: excluded_items_ids }) instead of manually constructing negated SQL in where.
relation.where('spree_variants.id NOT IN (?)', excluded_items_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/subscriptions/proxy_order_syncer.rb:78:18: C: [Corrected] Rails/WhereNot: Use where.not(order_cycle_id: order_cycle_ids) instead of manually constructing negated SQL in where.
orphaned.where('order_cycle_id NOT IN (?)', order_cycle_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:27:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: nil }) instead of manually constructing negated SQL in where.
.where("enterprises.id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:39:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprise_id: nil) instead of manually constructing negated SQL in where.
.where("enterprise_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:40:14: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/anonymize_data.rake:50:16: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
Customer.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 26 offenses detected, 26 offenses corrected
2023-08-20 12:33:43 +09:00
Konrad
241239ac68
Merge pull request #11379 from dacook/respond_to-not_found
...
Respond to all formats for "not found" error
2023-08-18 18:47:09 +02:00
Konrad
0dc8996701
Merge pull request #11295 from Matt-Yorkley/scope-error
...
Remove product display_as cell
2023-08-18 18:16:16 +02:00
Konrad
df7d42a420
Merge pull request #11352 from abdellani/remove-dead-code-bulk-invoice
...
Remove dead code related to bulk invoice printing
2023-08-18 18:14:01 +02:00
Matt-Yorkley
2b9b79c828
Remove product display_as cell
...
This was attempting to reference the master variant, which is now gone. Fixes an Angular scope error.
2023-08-18 17:38:36 +02:00
Konrad
f3b09508ff
Merge pull request #11347 from abdellani/fix-edit-order-button
...
fix cancel order button
2023-08-18 17:07:42 +02:00
Konrad
d8bc479a70
Merge pull request #11387 from jibees/10957-missing-translation-invalid-url
...
Admin, White Label: add translation for invalid URL in white label context
2023-08-18 15:59:39 +02:00
dependabot[bot]
fcb3a74b64
chore(deps): bump puma from 6.3.0 to 6.3.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.3.0...v6.3.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-18 09:10:32 +00:00
Jean-Baptiste Bellet
2abfa623f0
Once products start loading, scroll higher, ie. just above filters
...
can see the loading spinner then
2023-08-18 10:20:10 +02:00
jibees
5395bc56f8
Merge pull request #11416 from jibees/11197-buu-no-results-page-and-number-of-results-tweaks
...
🚧 BUU: No results page and number of results tweaks
2023-08-18 10:14:09 +02:00
Jean-Baptiste Bellet
06fccd8618
Totally hide input above its container
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
47115a0daf
Change default label for searched products
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
721baa4d3f
Increase button size
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
117c373985
Add "remove-sign" icon before text in disruptive button
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
d27b2084ed
Do not underline text when it's a button
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
e4479e7935
Increase button height when no result
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
f5e7738c78
Introduce relaxed, regular and condensed button for specify height
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
5de0d79ca2
Increase distance from search container to 136px
...
116px + 20px (gap) = 136px
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
4219d0aa08
Change font size and weight
2023-08-18 09:46:56 +02:00
Maikel Linke
0acdf5833f
Update all locales with the latest Transifex translations
2023-08-18 15:54:00 +10:00
David Cook
01f0de2f4e
Merge pull request #11405 from macanudo527/fix_rubocop_rails_errors
...
Fix rubocop rails errors
2023-08-18 11:54:17 +10:00
David Cook
7a04f63d62
Merge pull request #11407 from jibees/10878-buu-pagination-tweaks
...
🚧 BUU: Pagination tweaks
2023-08-18 09:25:55 +10:00
jibees
e82ff80582
Merge pull request #11420 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.1
...
chore(deps): bump newrelic_rpm from 9.4.0 to 9.4.1
2023-08-17 13:46:47 +02:00
dependabot[bot]
47ca35c38e
chore(deps): bump newrelic_rpm from 9.4.0 to 9.4.1
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.4.0 to 9.4.1.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.4.0...9.4.1 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-17 09:28:40 +00:00
Neal Chambers
fe5288c015
Update .rubocop_todo.yml
2023-08-17 16:45:52 +09:00
Neal Chambers
3c9afcf360
Fix Rails/CompactBlank
2023-08-17 16:43:13 +09:00
Neal Chambers
871a8e6f2c
Fix Rails/Blank
2023-08-17 16:42:46 +09:00
Neal Chambers
b78bbd2629
Fix Rails/ApplicationController
2023-08-17 16:42:41 +09:00
Jean-Baptiste Bellet
fa4dda9976
Finally, remove disabled rule that is unused
...
We only display active link
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
394e964b91
Specify for element that have href attr: the ones we want to hover
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
e7d36ed772
Let link have the cursor: pointer by default, and specify only for current
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
2405dfdaa3
Refine and adjust position of icon in button
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
1a8a4ee72b
Change size of pagination
...
"it becomes extremely long for big catalogues"
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
66a106b1c9
hide pagination for single page catalogue
...
+ update specs then
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
3fb8726c6a
Do not display arrows if they're disabled
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
b1ea77e611
Remove white background from dots
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
c252de87b6
Specify cursor in order to not be text
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
5fc4f7bdaf
Design hover (like current)
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
9d8325c0d9
font weight to be 600
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
d914644c35
change not selected font color to $near-black, also for arrows
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
06af58e923
increase distance between arrows and numbers to be 36px
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
6e29dd95ef
Increase distance between numbers to be 8px
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
a2da3c2f61
Better management of margin/gap between each button with flex display
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
9396e75806
Increase padding top and padding bottom
2023-08-17 09:06:26 +02:00
Maikel
5762492511
Merge pull request #11392 from dacook/release-template
...
Release template
2023-08-17 16:47:49 +10:00
Maikel
6377149e18
Merge pull request #11400 from jibees/buu-update/refactor-tests
...
🚧 BUU: refactor/improve testing
2023-08-17 16:32:00 +10:00
David Cook
a854dccf04
Simplify tag steps
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-17 16:09:06 +10:00
Maikel
d0559d2a6c
Merge pull request #11413 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.0
...
chore(deps): bump newrelic_rpm from 9.3.1 to 9.4.0
2023-08-17 15:36:28 +10:00
Maikel
27dcad205e
Merge pull request #11337 from macanudo527/fix_rubocop_6
...
Fix autocorrect Rails Cops 2
2023-08-17 10:39:34 +10:00
jibees
132d2e792e
Merge pull request #11406 from openfoodfoundation/dependabot/bundler/timecop-0.9.8
...
chore(deps-dev): bump timecop from 0.9.6 to 0.9.8
2023-08-16 17:07:56 +02:00
dependabot[bot]
21e38c424f
chore(deps): bump newrelic_rpm from 9.3.1 to 9.4.0
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.3.1 to 9.4.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.3.1...9.4.0 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-16 14:41:10 +00:00
jibees
afe05f1932
Merge pull request #11414 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.8
...
chore(deps): bump rails-i18n from 7.0.7 to 7.0.8
2023-08-16 16:40:05 +02:00
dependabot[bot]
33d5e8436f
chore(deps): bump rails-i18n from 7.0.7 to 7.0.8
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.7 to 7.0.8.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.7...v7.0.8 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-16 09:49:57 +00:00
jibees
33fc5bd409
Merge pull request #11409 from dacook/script-update
...
Don't show extra red messages when gems missing
2023-08-16 09:01:20 +02:00
David Cook
9bef8b74f8
Merge pull request #11401 from jibees/some-buu-design-updates
...
🚧 BUU: some design updates + one small code fix
2023-08-16 11:41:33 +10:00
Maikel
fd7b00ac7f
Merge pull request #11323 from mkllnk/dfc-import-context
...
Use known, statically cached DFC context
2023-08-16 11:35:57 +10:00
David Cook
b49de7d49e
Simplify spec
...
What if Zucchini didn't appear at all? Better to test that the two products appear on the same page, in the correct order.
2023-08-16 11:13:54 +10:00
David Cook
412dac7556
Don't show extra red messages when gems missing
...
When a gem is missing, it looks like a big ugly error. But we don't need to see this, because bundle install will run next and tell us which gems its installing.
Bundle check isn't actually necessary because bundle install will handle this, but for some reason it's 300ms slower. So I chose to keep 'check' to help keep this script nice and quick.
2023-08-16 09:56:24 +10:00
David Cook
b320a1d289
Create release tag early for greater clarity
...
This way, it's clearer in the repo what is going to be released, and we don't need to copy/paste commit IDs.
([skip ci] because this branch only touches .md file)
2023-08-15 21:47:32 +10:00
David Cook
1cd87c170b
Use new staging deployment method
2023-08-15 21:35:12 +10:00
David Cook
8b9d483227
Add more detailed notes for current process
2023-08-15 21:35:10 +10:00
Matt-Yorkley
70ba027603
Merge pull request #11221 from Matt-Yorkley/product-shipping-category
...
[Product Refactor] Shipping Category
2023-08-15 11:12:56 +01:00
dependabot[bot]
cd5c7e8fc7
chore(deps-dev): bump timecop from 0.9.6 to 0.9.8
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.6 to 0.9.8.
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.6...v0.9.8 )
---
updated-dependencies:
- dependency-name: timecop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-15 09:18:16 +00:00
David Cook
f4a6bec25d
Code fix
...
Cache result.
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
200550588a
Be as clause as possible from native <select />
...
Still need to wrap/ellipsis selected item...
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
0c11ea5868
Use tom-select to have a designed dropdown
...
Not sure this is the best solution, since it's not exactly the right usage of tom-select
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
6fe069608c
Re-adjust tom-select to match admin v3 style
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
223d350b43
Use grid instead of flex in order to be more fixed and less flexible ;)
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
2814368670
Adjust inside container to content without any padding
2023-08-15 08:36:50 +02:00
David Cook
1155bd42ea
Reflex test to reveal collation sorting varies on different OS...
...
https://dba.stackexchange.com/questions/106964/why-is-my-postgresql-order-by-case-insensitive
Uncommented, the spec fails on macOS (BSD).. but succeeds in Ubuntu (Linux). Weird.
2023-08-15 08:36:22 +02:00
David Cook
0f086df12b
Setup StimulusReflex testing [add gem]
...
Surprisingly, the StimulusReflex framework [doesn't have many resources for testing](https://docs.stimulusreflex.com/appendices/testing.html ), but thankfully someone's made a gem.
2023-08-15 08:36:22 +02:00
David Cook
e816228959
Sort products by name in ascending order
...
The order is specified above in fetch_products. I'm guessing this line was unintentional?
Original requirment doesn't say ascending but I think it's safe to assume (issue#10694).
2023-08-15 08:36:22 +02:00
David Cook
6dbfb36e52
Spec: use url helpers
...
To be consistent with other specs.
2023-08-15 08:36:22 +02:00
David Cook
9a3820db4f
Tidy up spec
...
Although 'describe' and 'context' are the same simple constructs to label groups of examples, to humans they mean:
* Describe a particular domain of functionality
* Context means a different environment, IE something has been set up differently (generally with before and/or let blocks)
Also the default 'before' is :each, so we don't need to specify it.
2023-08-15 08:36:22 +02:00
David Cook
757ba27908
Optimise spec: only create objects when needed
...
Moving the 'clear filters' and 'no results' tests up into the first context.
2023-08-15 08:36:22 +02:00
David Cook
2a4d5af552
Remove redundant test
...
This is already covered in the following test.
2023-08-15 08:36:21 +02:00
David Cook
8949f1dc2e
Convert route to resource
...
I don't know why the route helper now has "index" in the name.
2023-08-15 08:36:21 +02:00
jibees
364ae5c0c6
Merge pull request #11404 from rioug/11402-invoice-data-generator-fix-flacky-test
...
Invoice data generator, fix flaky test
2023-08-15 08:34:53 +02:00
Gaetan Craig-Riou
5a2155aeb7
Use the same sorting when choosing a line item to update
...
The presenter uses order.sorted_line_items, so use the same method
when picking up the line item to update.
2023-08-15 11:33:02 +10:00
David Cook
2196cd5be8
Merge pull request #11381 from openfoodfoundation/release_v4.4.7
...
Update translations for release v4.4.7
2023-08-15 10:21:34 +10:00
David Cook
8b666c67d6
Fix typo
...
🤦 Always, always preview changes before committing.
2023-08-15 09:54:42 +10:00
David Cook
54328d7b98
Mention browser limitations
2023-08-15 09:53:39 +10:00
Matt-Yorkley
75f246109f
Fix assignment of default shipping category in variant new/edit pages
2023-08-14 21:02:48 +01:00
Matt-Yorkley
811a8cde7f
Use optional: false instead of validates: presence
2023-08-14 21:02:48 +01:00
Matt-Yorkley
97d9aadb69
Update specs
2023-08-14 21:02:48 +01:00
Matt-Yorkley
dea2adc3d6
Update EntryValidator
2023-08-14 21:02:48 +01:00
Matt-Yorkley
42d04b6581
Update OrderAvailableShippingMethods service
2023-08-14 21:02:47 +01:00
Matt-Yorkley
a712eac333
Update shipping_category in /lib and /engines
2023-08-14 21:02:47 +01:00
Matt-Yorkley
5e0e60dfd6
Update reports
2023-08-14 21:02:47 +01:00
Matt-Yorkley
724c08c94d
Set default shipping_category if absent
2023-08-14 21:02:47 +01:00
Matt-Yorkley
c18c525d9f
Save shipping category selection to new variant when creating a new product
2023-08-14 21:02:47 +01:00
Matt-Yorkley
e3c488306c
Migrate data for shipping_category_id
2023-08-14 21:02:47 +01:00
Matt-Yorkley
eefc356472
Update shipping_category usage in admin pages
2023-08-14 21:02:47 +01:00
Matt-Yorkley
0c634cf04f
Update shipping_category permitted attributes
2023-08-14 21:02:47 +01:00
Matt-Yorkley
57d6fa006c
Update shipping_category association in models
2023-08-14 21:02:47 +01:00
Matt-Yorkley
e2caebc374
Add shipping_category to variants table
2023-08-14 21:00:02 +01:00
Neal Chambers
ec49065739
Reword image_exists? to use Rails.public_path
2023-08-14 17:29:11 +09:00
Neal Chambers
e5740a82bd
Safely autocorrect Rails/StripHeredoc
...
Inspecting 1484 files
........................................................................................................................................................................................................................................................C.........................................................................................................................................CC...........................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/content_configuration.rb:74:48: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
preference :footer_links_md, :text, default: <<-EOS.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
app/queries/customers_with_balance.rb:23:5: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-SQL.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
app/queries/outstanding_balance.rb:32:5: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-SQL.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:71:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:84:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:96:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:109:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:119:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:135:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:151:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:161:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:168:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:182:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:192:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:208:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:218:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:228:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:235:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:253:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:274:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:289:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:310:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:369:15: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/truncate_data.rake:35:17: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
message = <<-MSG.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/truncate_data.rake:36:1: C: [Corrected] Layout/HeredocIndentation: Use 2 spaces for indentation in a heredoc.
\n ...
^^^^^^^^
1484 files inspected, 25 offenses detected, 25 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
94f1b89a9f
Safely autocorrect Rails/RootPublicPath
...
Inspecting 1484 files
.............................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................C..........C..........................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................C...................C.............................................................C.C.......C....................
Offenses:
app/controllers/concerns/request_timeouts.rb:19:22: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
file: Rails.root.join("public/500.html"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/common.rb:45:30: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
file: Rails.root.join("public/404.html"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/product_images_controller_spec.rb:13:22: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:pdf_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/terms_and_conditions_controller_spec.rb:15:31: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:terms_file_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/terms_of_service_file_spec.rb:6:25: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:pdf) { File.open(Rails.root.join("public/Terms-of-service.pdf")) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_product_update_spec.rb:907:37: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
attach_file 'image-upload', Rails.root.join("public/500.jpg"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprises/terms_and_conditions_spec.rb:27:30: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:original_terms) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprises/terms_and_conditions_spec.rb:28:29: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:updated_terms) { Rails.root.join("public/Terms-of-ServiceUK.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/checkout_spec.rb:94:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/Terms-of-service.pdf"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/embedded_groups_spec.rb:18:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/embedded-group-preview.html")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/embedded_groups_spec.rb:26:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/embedded-group-preview.html")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/split_checkout_spec.rb:986:35: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:system_terms_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/split_checkout_spec.rb:987:33: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:shop_terms_path) { Rails.root.join("public/Terms-of-ServiceUK.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 13 offenses detected, 13 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
b60fd6b572
Safely autocorrect Rails/I18nLazyLookup
...
Inspecting 1484 files
.......................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/admin/proxy_orders_controller.rb:16:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers.
render json: { errors: [t('admin.proxy_orders.cancel.could_not_cancel_the_order')] },
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/proxy_orders_controller.rb:25:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers.
render json: { errors: [t('admin.proxy_orders.resume.could_not_resume_the_order')] },
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 2 offenses detected, 2 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
aaf2181768
Safely autocorrect Rails/FilePath
...
Inspecting 1484 files
.............................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C....................C.....................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................C...........................................................................................................................................................
Offenses:
app/models/product_import/product_importer.rb:290:35: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
return unless @file.path == Rails.root.join('tmp', 'product_import').to_s
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:5: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH)}/translations.js"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:5: C: [Correctable] Style/RedundantInterpolation: Prefer to_s over string interpolation.
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH, 'translations.js')}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:59: C: [Corrected] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH, "translations.js")}"
^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:25: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
config.fixture_path = "#{::Rails.root}/spec/fixtures"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:25: C: [Correctable] Style/RedundantInterpolation: Prefer to_s over string interpolation.
config.fixture_path = "#{Rails.root.join('spec/fixtures')}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:44: C: [Corrected] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
config.fixture_path = "#{Rails.root.join("spec/fixtures")}"
^^^^^^^^^^^^^^^
spec/models/content_configuration_spec.rb:15:19: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').to_s.
File.exist?(File.join(Rails.root, 'public', default_url))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/content_configuration_spec.rb:15:19: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
File.exist?(Rails.root.join('public', default_url).to_s)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/downloads_helper.rb:7:5: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
Rails.root.join("tmp", "capybara")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 10 offenses detected, 8 offenses corrected, 2 more offenses can be corrected with `rubocop -A`
2023-08-14 17:29:11 +09:00
Neal Chambers
c36728625d
Regenerate Rubocop's TODO file
2023-08-14 17:29:08 +09:00
Maikel Linke
91e4fb18ed
Use input labels in Voucher system spec
...
It's more robust, and closer to what the user sees and does. It's also
verifying that the labels are correctly connected to the inputs.
2023-08-14 12:46:13 +10:00
Maikel Linke
ba53f31309
Use new hash syntax in Voucher spec
2023-08-14 12:40:54 +10:00
Maikel Linke
160cdc7f8e
Clarify Voucher request spec not a controller spec
2023-08-14 12:25:56 +10:00
Maikel Linke
4b0e910dff
Simplify default values in Voucher form
2023-08-14 12:23:00 +10:00
Maikel Linke
efe2dfff8e
Let Rails handle Voucher type building
2023-08-14 11:51:34 +10:00
Maikel Linke
4d5e1ffb3b
Simplify VouchersController with single param name
...
The Voucher form now deals with a generic Voucher instead of a subclass
which makes the naming easier and is less confusing when changing types.
2023-08-14 11:39:59 +10:00
Mohamed ABDELLANI
8370d7ce83
Update app/views/spree/admin/shared/_order_links.html.haml
...
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-08-13 13:12:56 +01:00
Dusan Orlovic
b360e2ffaa
Add Google map region parameter
2023-08-13 08:56:04 +02:00
Konrad
99daab07b7
Merge pull request #11297 from mkllnk/require-belongs-to--part2
...
Require belongs_to associations by default
2023-08-12 17:09:03 +02:00
Matt-Yorkley
613802f477
Update stage.yml
2023-08-11 13:50:34 +01:00
Matt-Yorkley
99907dc3a6
Update stage.yml
2023-08-11 13:48:31 +01:00
Matt-Yorkley
7084d0cb40
Update stage.yml
2023-08-11 13:44:38 +01:00
Matt-Yorkley
e33b0af6fe
Update stage.yml
2023-08-11 13:42:14 +01:00
Matt-Yorkley
6dfeecead1
Update stage.yml
2023-08-11 13:30:35 +01:00
Rachel Arnould
5afe45d922
Merge pull request #11382 from jibees/11273-buu-remove-new_products_page-feature-toggle
...
🔧 Remove `new_products_page` and all associated controllers/components/...
2023-08-11 11:43:49 +02:00
David Cook
5a96f285c1
Update release title
2023-08-11 16:24:11 +10:00
David Cook
1a58914e43
Categories release notes by dependencies label
...
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
2023-08-11 16:13:22 +10:00
Gaetan Craig-Riou
06f986ff52
Allow for creating a voucher with either flat or percentage rate
...
In the scenario when you get an error when trying to create a
percentage voucher, on the subsequent try we would be dealing with
a "percentage rate voucher". The code now handle any type of voucher
2023-08-11 16:09:48 +10:00
Gaetan Craig-Riou
61e6d55872
Merge pull request #10821 from rioug/10727-vouchers-percentage-rate
...
[Vouchers] Percentage rate
2023-08-11 16:06:09 +10:00
Gaetan Craig-Riou
a2def2424c
Add a comment around the use of safe_constantize
...
It triggers a Brakeman error that can be safely ignored
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
9c9a6234e1
Per review, clean up voucher specs
...
Add explicit 'order.item_total' to make specs more readable
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
054eac0822
Use a better describe
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
e6b53c0a42
Per review , Simplify creation of Voucher
...
We now check against known type to instanciate the correct voucher
instead of using a case
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
3f63cfbc27
Fix Rubocop warning
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
e8b374d0f2
Remove left over comment
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
2828bd098d
Refactor VoucherAdjustment service
...
We are taking advantage of having a FlatRate and a PercentageRate
model to simplify the code a little
2023-08-11 15:41:34 +10:00
Gaetan Craig-Riou
29a38467d2
Fix admin pages to work with refactored vouchers
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
46e04ca7ee
Refactor voucher: 3 percentage rate voucher
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
def594ab81
Refactor voucher: 2 FlatRate voucher
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
204f3933d0
Refactor voucher: 1 base voucher class
...
Refactor voucher to use a single table inheritance. It will simplify the
code and remove a bunch of conditional
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
959e2308dd
Add system specs for percentage based voucher
...
Similar to tax included in price scenario, adds a test for percentage
based voucher to check the adjustments are recalculated when needed.
Plus fix tax incluced in price specs to use new factory
2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou
70bd714369
Finish calculation for percentage voucher
...
Add calculation when tax is not included in price
2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou
cdb33aa0d0
Add calculation for percentage voucher
...
It include calculation for order with taxes included in the price
2023-08-11 14:30:48 +10:00
David Cook
e536393f02
Merge pull request #11389 from mkllnk/session_store
...
Remove ignored session store config
2023-08-11 14:27:44 +10:00
Gaetan Craig-Riou
cc9069e9c6
Add voucher type to admin screen
...
Plus specs
2023-08-11 14:19:26 +10:00
Gaetan Craig-Riou
619285ad4a
Add voucher_type to voucher
...
And update related specs
voucher_type doesn't do anything for now.
2023-08-11 14:19:25 +10:00
Gaetan Craig-Riou
1be8daaf86
Add specs to cover re calculation
...
It is important that the calculated voucher adjustments don't change
if they are recalculated and it is equally important that they are
updated if the order has changed
2023-08-11 14:19:25 +10:00
David Cook
6ee6ad2b86
[fixup] Remove unnecessary template name
...
This was left over after trying different things to get this working.
2023-08-11 14:14:32 +10:00
Maikel
fc8e39987a
Merge pull request #11385 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.132.1
...
chore(deps): bump aws-sdk-s3 from 1.132.0 to 1.132.1
2023-08-11 11:39:14 +10:00
Maikel Linke
7fe74e811e
Remove ignored session store config
...
We set the session store in an initializer and therefore the development
config was overridden without having any effect.
2023-08-11 10:27:37 +10:00
Maikel Linke
a34a351cee
Stabilise flaky spec with deterministic row order
2023-08-11 10:14:47 +10:00
Maikel
146b09dc57
Spec EnterpriseFee tax_category association
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-11 10:14:47 +10:00
Maikel Linke
efbf1d6b8f
Stabilise flaky assertion on PDF text
...
The PDF reader can't always place text elements in the right place. So
something that should be in one line can be in multiple lines and those
lines can be in a different order. I'm asserting the moving parts
separately as done in other places of this spec.
2023-08-11 10:14:47 +10:00
Maikel Linke
1b6eeb0928
Reduce line length of PaymentMethod class
...
Rubocop was complaining. So I found code that could be simplified and
specced it before refactoring.
2023-08-11 10:14:47 +10:00
Maikel Linke
faeb8ae8f8
Fix Exchange clone tagging
...
The validation of ActsAsTaggableOn::Taggable failed when trying to copy
tag ids during cloning. But I found that it's totally unnecessary
because `Exchange.dup` copies the `tag_list` attribute already and it
gets saved correctly. There's an existing spec for this.
2023-08-11 10:14:47 +10:00
Maikel Linke
4a13576f78
Remove now superfluous belongs_to default declaration
2023-08-11 10:14:47 +10:00
Maikel Linke
e6c679cb34
Apply belongs_to_required_by_default to all models
...
Unless they state otherwise.
The new standard also changes the default behaviour of the Shoulda
matcher in Rspec. It now defaults to asserting that an association is
required. That needed some spec updates.
In one case, Spree::Product, I also had to update the model because the
presence validation was somehow not recognised by the Shoulda matcher.
The error message may change slightly but the outcome should be the
same.
2023-08-11 10:14:47 +10:00
Maikel Linke
8ef6966891
Declare old belongs_to default on remaining models
...
It would take ages to go through all files now and assess all belongs_to
associations. So I just declare the old default and then we can move on
and apply the new default for the application while these classes still
use the old one. All new models will then use the new default which is
the goal of this excercise and we can refactor old classes when we touch
them anyway.
2023-08-11 10:14:43 +10:00
Maikel Linke
252f809463
Require CustomTab.belongs_to by default
2023-08-11 10:14:15 +10:00
Maikel Linke
070d1e722e
Require EnterpriseRole.belongs_to by default
2023-08-11 10:14:14 +10:00
Maikel Linke
4dd2955400
Require EnterpriseRelationshipPermission.belongs_to by default
...
I had to change some specs to keep them simple but I don't think
anything is broken. In one case, it would have needed a lot more setup
to make the spec work. But in production, the permissions are never used
with ModelSet, for example.
2023-08-11 10:13:48 +10:00
Maikel Linke
cb494b84f2
Require EnterpriseRelationship.belongs_to by default
2023-08-11 10:13:29 +10:00
Maikel Linke
4b630f187b
Require EnterpriseGroup.belongs_to by default
2023-08-11 10:13:10 +10:00
Maikel Linke
13b2f37884
Require EnterpriseFee.belongs_to by default
2023-08-11 10:13:09 +10:00
Maikel Linke
87ccfc94ef
Require Enterprise.belongs_to by default
...
And remove a duplicate spec.
2023-08-11 10:13:09 +10:00
Konrad
60212f92c3
Merge pull request #11270 from rioug/9553-removing-cutomer-tag-when-search-for-tag
...
Fix removing customer tag when using search bar for said tag
2023-08-11 00:11:55 +02:00
Konrad
c3414143e6
Merge pull request #11222 from Matt-Yorkley/checkout-controller
...
Reduce controller size
2023-08-10 23:28:57 +02:00
Konrad
f59e681826
Merge pull request #11259 from cillian/single-line-voucher-code
...
Don't allow multi-line voucher codes
2023-08-10 23:09:55 +02:00
Jean-Baptiste Bellet
5b4b37032c
Add translation for invalid URL in white label context
2023-08-10 15:22:35 +02:00
Matt-Yorkley
df077caafa
Merge pull request #11375 from Matt-Yorkley/drop-unused-tables
...
Drop unused tables
2023-08-10 12:28:14 +01:00
Matt-Yorkley
f19d66f4d6
Drop unused tables
2023-08-10 12:27:31 +01:00
Matt-Yorkley
688b411e97
Merge pull request #11374 from Matt-Yorkley/drop-variant-master-column
...
Drop :is_master column from variants table
2023-08-10 12:25:59 +01:00
Matt-Yorkley
b82f368bec
Drop :is_master column from variants table
2023-08-10 12:25:18 +01:00
Matt-Yorkley
128d5c29bd
Merge pull request #11373 from Matt-Yorkley/drop-options-tables
...
Drop option_types and option_values tables
2023-08-10 12:21:39 +01:00
jibees
95612a8cb6
Merge pull request #11384 from openfoodfoundation/dependabot/bundler/rails-7.0.7
...
chore(deps): bump rails from 7.0.6 to 7.0.7
2023-08-10 12:13:07 +02:00
dependabot[bot]
4bbd9e9d49
chore(deps): bump aws-sdk-s3 from 1.132.0 to 1.132.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.132.0 to 1.132.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 09:55:40 +00:00
dependabot[bot]
f08a7ea254
chore(deps): bump rails from 7.0.6 to 7.0.7
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 09:53:38 +00:00
Jean-Baptiste Bellet
3b68674896
Remove new_products_page and all associated controller/components/
...
new_products_page` is dead, long live `admin_style_v3` !
2023-08-10 10:02:45 +02:00
jibees
f58fedfc86
Merge pull request #11376 from mkllnk/flaky-voucher-spec
...
Stabilise flaky checkout spec with voucher
2023-08-10 09:10:59 +02:00
David Cook
b58d15b5ed
Update all locales with the latest Transifex translations
2023-08-10 16:54:26 +10:00
David Cook
f64a24a5bb
Respond to all formats with html
2023-08-10 16:14:08 +10:00
David Cook
c191158a97
Use the newer syntax
2023-08-10 14:52:04 +10:00
Matt-Yorkley
5c0329ce17
Drop option_types and option_values tables
2023-08-10 11:52:10 +10:00
Maikel
8db8d6de8d
Merge pull request #11372 from Matt-Yorkley/remove-variant-position
...
Remove unused variant :position attribute
2023-08-10 11:48:55 +10:00
Maikel
507803c2dc
Merge pull request #11371 from jibees/8443-missing-translation-passwords-not-matching-or-too-short
...
Account creation: translate some messages around password creation
2023-08-10 11:40:56 +10:00
Maikel Linke
04bba2adf1
Stabilise flaky checkout spec with voucher
...
While applying a voucher the spec tried to proceed the checkout before
the voucher update completed rendering. It failed when the machine was
slow.
With rspec-slow-repeate I got 100% fail rate before and 100% pass after
this change.
2023-08-10 10:05:01 +10:00
Maikel
926c8aed94
Merge pull request #11354 from abdellani/fix-rename-invoice-generate-update-button
...
rename 'new invoice' button to 'create or update invoice'
2023-08-10 09:59:11 +10:00
Mohamed ABDELLANI
620dd70dd7
rename 'new invoice' button to 'create or update invoice'
2023-08-10 09:35:13 +10:00
Matt-Yorkley
a33b6e0ec9
Update variant sorting
2023-08-09 18:30:56 +01:00
Matt-Yorkley
e65efe0f85
Remove unused variant :position attribute
2023-08-09 18:24:46 +01:00
Rachel Arnould
4505beff98
Merge pull request #11327 from bouaik/fix-display-invoice-tab-for-completed-resumed-canceled-only
...
Fix display invoice tab for completed, resumed and canceled orders only
2023-08-09 18:37:02 +02:00
Jean-Baptiste Bellet
1f5dc1f864
Add ActiveRecords messages for translation in account creation
2023-08-09 16:58:08 +02:00
Rachel Arnould
2b108dfeee
Merge pull request #11116 from abdellani/fix-show-date-only-on-invoices-list
...
render date without time on invoices list
2023-08-09 14:33:40 +02:00
jibees
249dea56f3
Merge pull request #11366 from openfoodfoundation/dependabot/bundler/rubocop-1.56.0
...
chore(deps-dev): bump rubocop from 1.55.1 to 1.56.0
2023-08-09 11:35:25 +02:00
dependabot[bot]
467a63cf12
chore(deps-dev): bump rubocop from 1.55.1 to 1.56.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.55.1 to 1.56.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.55.1...v1.56.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-09 09:20:52 +00:00
Konrad
89d8fa0306
Merge pull request #11346 from Matt-Yorkley/remove-multiple-taxons
...
[Product Refactor] Remove multiple taxons
2023-08-09 11:19:11 +02:00
Maikel
655fdf3fff
Merge pull request #11353 from abdellani/remove-duplicated-keys-in-en-yml
...
Remove duplicated keys in en yml
2023-08-09 13:42:01 +10:00
Maikel
d149f71199
Merge pull request #11365 from dacook/setup-reduce-output
...
Setup script tweaks
2023-08-09 11:45:47 +10:00
Maikel
b50fa216eb
Merge pull request #11117 from rioug/10857-voucher-error-moving-between-summary-and-cart-take2
...
[vouchers] error moving between summary and cart pages
2023-08-09 11:14:52 +10:00
David Cook
91c874737a
Combine rake tasks to save time
...
The log:clear task seems to take quite a bit of time. At least we can speed up a bit by only booting up Rails once.
I'm more likely to run the script if it's quick ;)
2023-08-09 10:28:41 +10:00
David Cook
9d79c7cda7
Reduce bundler install output
...
bundle install always shows a very long list of all gems. But we really only want to know about the new gems being installed. Thankfully there's an option for that.
2023-08-09 10:26:11 +10:00
Matt-Yorkley
6fee1d2dde
Use dependent: :restrict_with_error on Taxon/Product association
2023-08-08 11:36:31 +01:00
David Cook
1706b8b4bc
fixup: Drop spree_products_taxons join table
...
Make it reversible for dev or staging.
2023-08-08 11:36:31 +01:00
David Cook
a9ca07f4fb
fixup Update specs
...
Delete empty describe block
2023-08-08 11:36:31 +01:00
Matt-Yorkley
321047d663
Update specs
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3d83ca01f7
Drop spree_products_taxons join table
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3655f3019d
Update products and inventory report
2023-08-08 11:36:31 +01:00
Matt-Yorkley
38d9f4f1da
Update product v3 table
2023-08-08 11:36:31 +01:00
Matt-Yorkley
e4a49f5d02
Update product duplication
2023-08-08 11:36:31 +01:00
Matt-Yorkley
820f9530b2
Update product serializer
2023-08-08 11:36:31 +01:00
Matt-Yorkley
8d01e1f024
Update taxon specs
2023-08-08 11:36:31 +01:00
Matt-Yorkley
33d40ed750
Update association
2023-08-08 11:36:31 +01:00
Matt-Yorkley
cffd7073e2
Delete unused method
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3898af2c37
Update factories and tests
2023-08-08 11:36:31 +01:00
Matt-Yorkley
a93809b75f
Remove associated abilities
2023-08-08 11:36:31 +01:00
Matt-Yorkley
a69ab2ef71
Remove multiple taxons on products functionality
2023-08-08 11:36:31 +01:00
Mohamed ABDELLANI
982f30399f
merge :errors values under one key
2023-08-08 10:34:11 +01:00
Mohamed ABDELLANI
024a01ba94
remove duplicated keys on en.yml
2023-08-08 10:34:05 +01:00
Mohamed ABDELLANI
70b61eb481
remove bulk invoice service
2023-08-08 08:41:33 +01:00
Mohamed ABDELLANI
fc01ffc509
remove InvoicesController#create
2023-08-08 08:38:32 +01:00
Gaetan Craig-Riou
fe6075319e
Merge pull request #11344 from openfoodfoundation/dependabot/bundler/mime-types-3.5.0
...
chore(deps): bump mime-types from 3.4.1 to 3.5.0
2023-08-08 16:43:47 +10:00
Gaetan Craig-Riou
bb375ccee5
Merge pull request #11343 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.2.2
...
chore(deps): bump stimulus from 3.2.1 to 3.2.2
2023-08-08 16:41:45 +10:00
Mohamed ABDELLANI
c185a47592
render the confirm model on the same component that includes the action on the order.
2023-08-08 07:32:20 +01:00
Gaetan Craig-Riou
6f10907555
Fix rubocop warnings
2023-08-08 15:37:05 +10:00
Gaetan Craig-Riou
a64023c3df
Apply review suggestion, simplify code slightly
2023-08-08 15:29:23 +10:00
Gaetan Craig-Riou
4e468c81f9
Handle updating customer attribute when directive is destroyed
...
Handle any customer attribute not just tags
2023-08-08 15:29:22 +10:00
Gaetan Craig-Riou
41dbad629b
Add system spec to cover deleting data when filtering
...
covers tag scenario and code scenario
2023-08-08 15:29:22 +10:00
Gaetan Craig-Riou
f96bd51344
Rework form to allow displaying the save bar when no result
...
When filtering by a tag, and then removing the tag on the filtered
customers, it let us show the save bar once the last customer has been
removed from the filtered list.
2023-08-08 15:28:13 +10:00
Gaetan Craig-Riou
dba8809057
Handle deleting tag when directive destroyed
2023-08-08 15:28:13 +10:00
dependabot[bot]
df76710ae8
chore(deps): bump mime-types from 3.4.1 to 3.5.0
...
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types ) from 3.4.1 to 3.5.0.
- [Changelog](https://github.com/mime-types/ruby-mime-types/blob/main/History.md )
- [Commits](https://github.com/mime-types/ruby-mime-types/compare/v3.4.1...v3.5.0 )
---
updated-dependencies:
- dependency-name: mime-types
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-07 09:56:54 +00:00
dependabot[bot]
1af30bdff4
chore(deps): bump stimulus from 3.2.1 to 3.2.2
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.2.1...v3.2.2 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-07 09:52:05 +00:00
Gaetan Craig-Riou
b731e8319b
Merge pull request #11339 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-2.0.4
...
chore(deps): bump js-big-decimal from 2.0.1 to 2.0.4
2023-08-07 11:46:10 +10:00
Gaetan Craig-Riou
430aa685ce
Merge pull request #11321 from mkllnk/dev-user-valid
...
Skip online domain validation of dev user email
2023-08-07 11:27:31 +10:00
Maikel
ccc5975517
Merge pull request #11320 from dacook/css-cleanup
...
SCSS cleanup
2023-08-07 10:23:49 +10:00
Maikel
4b0bffa095
Merge pull request #11256 from rioug/10997-add-new-relic-gem
...
Add new relic gem
2023-08-07 10:17:59 +10:00
Gaetan Craig-Riou
0103942dcb
Disable new relic agent by default
...
It can be enable as needed by setting NEW_RELIC_AGENT_ENABLED env
variable to true and setting a license key
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
de52ff4abf
Move New Relic out of production, staging group
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
5793cb14ee
Add generated configuration
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
c3d26b1900
Add the New Relic gem
2023-08-07 09:37:36 +10:00
Rachel Arnould
1b1279aa56
Merge pull request #11192 from abdellani/bulk-invoice-printing
...
fix Bulk invoice printing/sending
2023-08-04 12:02:43 +02:00
dependabot[bot]
760d237288
chore(deps): bump js-big-decimal from 2.0.1 to 2.0.4
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 2.0.1 to 2.0.4.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v2.0.1...v2.0.4 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-04 09:24:25 +00:00
Cillian O'Ruanaidh
d026438edc
Revert "Validate voucher code length doesn't exceed the database column length i.e. 255 characters"
...
This reverts commit 0d0df82522 .
2023-08-04 10:24:21 +01:00
Cillian O'Ruanaidh
9eba266efc
Strip leading and trailing whitespace from code on assignment instead of before validation
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-04 10:15:22 +01:00
Cillian O'Ruanaidh
ab0d899a17
Revert "Validate voucher code doesn't contain new line characters"
...
This reverts commit 0c0b85f4c4 .
2023-08-04 10:04:14 +01:00
Gaetan Craig-Riou
6ed35f4cc1
Per review, delete only incomplete payments
...
Use destroy_all so we don't have to manually delete the payment fees
adjustment
2023-08-04 17:03:31 +10:00
Maikel Linke
ad37c401e5
Update translations
2023-08-04 13:48:29 +10:00
David Cook
42230c07b2
Merge pull request #11312 from macanudo527/fix_rubocop_5
...
Fix autocorrect Rails Cops
2023-08-04 11:13:52 +10:00
bouaik
41d649404f
make suggested changes
2023-08-04 00:55:35 +01:00
Maikel
2b18effe6d
Merge pull request #11322 from macanudo527/fix_remaining_line_length
...
Fix remaining Layout/LineLength Rubocop Errors
2023-08-04 09:34:00 +10:00
Maikel
64398066ce
Merge pull request #11324 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-2.0.1
...
chore(deps): bump js-big-decimal from 1.4.1 to 2.0.1
2023-08-04 09:20:30 +10:00
Matt-Yorkley
dd9bdd9c0e
Move address params handling into Checkout::Params
2023-08-04 08:43:15 +10:00
Matt-Yorkley
13a7c19a06
Extract checkout step(s) validation to a service
2023-08-04 08:43:15 +10:00
Matt-Yorkley
82b8bb74a1
Remove #before_save_hook method and clarify it's intention
2023-08-04 08:43:15 +10:00
Matt-Yorkley
f3899ee251
Extract some related methods to CheckoutSteps concern
2023-08-04 08:43:15 +10:00
Matt-Yorkley
d1bcdde49f
Simplify split checkout errors
2023-08-04 08:43:15 +10:00
Filipe
69dfd53658
Merge pull request #11254 from rioug/11130-add-product-filter-order-report
...
11130 add product filter order report
2023-08-03 16:08:44 +01:00
Filipe
5c67d522b8
Merge pull request #11209 from openfoodfoundation/dependabot/npm_and_yarn/stimulus_reflex-3.5.0-rc3
...
chore(deps): bump stimulus_reflex from 3.5.0-rc2 to 3.5.0-rc3 + cable_ready from 5.0.0.rc2 to 5.0.1
2023-08-03 16:01:40 +01:00
Mohamed ABDELLANI
6c53f3b8b0
move pretty_date helper into invoice presenter
2023-08-03 15:12:02 +01:00
Mohamed ABDELLANI
c21ffd338b
fix only date is expected on the invoices list table.
...
time is not supposed to be rendered on the invoices list table (only date)
2023-08-03 15:12:02 +01:00
Mohamed ABDELLANI
5358802ab5
replace Presenter#invoice_date with a delagator
2023-08-03 15:11:58 +01:00
Mohamed ABDELLANI
9a3aef525a
add distributor's phone number to list of attributes to serialize
2023-08-03 15:06:04 +01:00
Mohamed ABDELLANI
d044959cec
fix date formatting
...
implement a new helper `pretty_date`
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
1a8c0f18b7
order invoices by "created_at desc" on the default scope
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
8fecc9db4b
render date without time on invoices list
...
+ sort invoices in the reverse order of the creation time
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
24b1918df5
implment blank? on Address presenter
...
To keep the same method calls that are used on the legacy invoice template. I needed to redefine blank? on the address presenter.
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
4449484402
replace double with instance_double
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
2fb112aecd
import BulkInvoiceJob#perform spec
...
1. remove the mocks
2. test the content of the generated pdf
3. remove the test of private methods
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
c89c8a69bc
optimize OrderMailer#invoice_email spec
...
Check if the email was sent without raising an error
Check if the email has an attached pdf
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
9b80676d7d
update the logic to send invoice
...
When the invoices feature is enabled, for every order, we check if
1. a new invoice must be generated
2. or, the latest invoice needs to be updated
the invoice rendrer input depends on the invoices flag.
if the feature is enabled, the input is supposed to be an invoice presenter
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
7daa4d3a63
simplify filtering condition to select only invoiceable orders on OrdersReflex
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
5ae2545918
Update app/jobs/bulk_invoice_job.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
687760046b
update the bulk invoice job to print invoiceable orders
...
the invoices feature is enabled:
1. we filter non-invoiceable order
2. for each invoiceable order, we check if we need to generate a new invoice or update the latest invoice
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
c921250d68
implement Spree::Order#invoiceable?
...
This will be used to filter the orders when running bulk print
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
4f6ab69add
implement OrderInvoiceGenerator service
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
f24af3feb0
extract invoice printing logic into a seperated method
2023-08-03 14:52:45 +01:00
bouaik
0c849f08fd
fix tests
2023-08-03 13:04:16 +01:00
bouaik
2c08602664
fix display invoice tab
2023-08-03 11:25:31 +01:00
Filipe
46cb1add63
Merge pull request #11126 from abdellani/show-invoice-number-on-invoices
...
Show invoice number on invoices
2023-08-03 10:48:34 +01:00
Filipe
c0a4bccb3e
Merge pull request #11156 from Matt-Yorkley/product-tax-category
...
[Product Refactor] Tax category
2023-08-03 10:29:40 +01:00
dependabot[bot]
106938ddbf
chore(deps): bump js-big-decimal from 1.4.1 to 2.0.1
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.4.1 to 2.0.1.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.4.1...v2.0.1 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-03 09:19:52 +00:00
Maikel Linke
f96636072e
Use original DFC Connector.export implementation
...
We wanted to use our own context before but now I found a better way for
the connector to cache the context and therfore we can use the original
implementation again.
2023-08-03 16:45:31 +10:00
Maikel Linke
1daed8c29c
Always load our DFC Connector patches
...
We want to use the preloaded context when exporting documents as well.
2023-08-03 16:45:30 +10:00
Maikel Linke
ff359664a9
Use cached DFC context
2023-08-03 16:45:30 +10:00
Neal Chambers
f5f9b80de7
Update .rubocop_todo.yml
2023-08-03 09:49:51 +09:00
Neal Chambers
a4f270bdec
Fix Layout/LineLength
2023-08-03 09:49:47 +09:00
David Cook
32cc776725
Merge pull request #11177 from cyrillefr/Registration_of_an_enterprise_name_already_taken_stops_registration_process
...
Registration of an enterprise name already taken stops registration process
2023-08-03 10:37:47 +10:00
Maikel Linke
c8511ecd0d
Remove superfluous line
...
The `<<` operation saves the association already.
2023-08-03 10:26:59 +10:00
Maikel Linke
6056c59301
Skip online domain validation of dev user email
...
We improved the email address validation to check the domain for
existing DNS entries. But our default user has the example.com domain
which is not resolved by my internet service provider.
I couldn't find a better way to deactivate this one check than
overriding the method in the validator. The code does not affect other
parts of the app unless you run multiple rake tasks in the same command
line with the database setup.
2023-08-03 10:22:00 +10:00
Maikel
76b7a9ea14
Merge pull request #11307 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.5.1
...
chore(deps): bump @floating-ui/dom from 1.4.5 to 1.5.1
2023-08-03 10:04:31 +10:00
David Cook
293e135a45
Move variables to one variables file
...
Note that color-tbl-border is not needed in the new admin_v3 styles.
2023-08-03 09:49:29 +10:00
David Cook
0aa4c144b9
Rename disabled button variable
...
TIL that underscores and dashes are treated the same in SCSS variables.
2023-08-03 09:49:29 +10:00
David Cook
1a02e108a5
Use red colour from the palette
...
It's very similar.
2023-08-03 09:49:29 +10:00
David Cook
9610281ed3
Rename variables
2023-08-03 09:49:29 +10:00
David Cook
b46e6c462d
Rename table border variable
...
There are other vars named brd, but I think border is clearer and doesn't need to be abreviated here.
2023-08-03 09:49:29 +10:00
David Cook
c4a335548a
Rename warning color variable
...
To match the others in the variables file.
Also `warning-orange` was unused.
2023-08-03 09:49:29 +10:00
David Cook
01a9095121
Move some variables to the palette
2023-08-03 09:49:29 +10:00
David Cook
2f801d346d
Prettify some more css files
2023-08-03 09:49:29 +10:00
David Cook
14e07e38d3
Remove depdenency on darkswarm/mixins
2023-08-03 09:49:29 +10:00
David Cook
bf9cd09462
Remove dependence on darkswarm variables
...
There were all sorts of dependencies hiding in there, and it was overwriting some of the admin variables. Better to keep things separate and simple.
I discovered that there was one legitimate reason for importing them though: for styling the trix editor. I can't think of a good way to safely import them without affecting the other variables, so I just hardcoded the colours for now.
2023-08-03 09:47:44 +10:00
David Cook
9207724779
Copy legacy variables
...
I'd like to go through and remove these, but it will have to happen another day.
2023-08-03 09:47:44 +10:00
David Cook
828df3ed82
Consistently use red in forms
...
Errors and required fields now use the colour from the palette. The error messages in the old design are a bit darker now, but I think it's clearer. And it makes the new design look way better.
Also snuck in a tiny padding tweak.
2023-08-03 09:47:44 +10:00
Maikel
9c6e0418cb
Merge pull request #11317 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.5
...
chore(deps-dev): bump knapsack_pro from 5.3.4 to 5.3.5
2023-08-03 08:18:52 +10:00
Filipe
f816d4b2d6
Merge pull request #11235 from jibees/11223-notices-tab-on-shopfront-persisting-after-selecting-an-order-cycle
...
Shopfront: On non-shop tab, when changing OC, switch to shop tab and hides non-shop tab content
2023-08-02 16:02:23 +01:00
Konrad
27e3a65440
Merge pull request #11234 from jibees/10867-vouchers-vouchers-page-is-shown-for-profile-enterprises
...
Show vouchers panel only if enterprise sells products (own or any)
2023-08-02 13:11:29 +02:00
Konrad
44d25dbb6a
Merge pull request #11299 from cillian/order-name-sorting
...
Sort orders by last name, then first name i.e. the same way bulk order management works
2023-08-02 11:30:25 +02:00
Konrad
12f6457ab2
Merge pull request #11302 from bouaik/margin-guest-checkout
...
fix margin in guest checkout
2023-08-02 10:57:12 +02:00
Maikel
b73dfed4e9
Merge pull request #11308 from openfoodfoundation/dependabot/bundler/rubocop-1.55.1
...
chore(deps-dev): bump rubocop from 1.55.0 to 1.55.1
2023-08-02 16:29:36 +10:00
Maikel
7886e25f83
Merge pull request #11303 from macanudo527/fix_rubocop_script
...
Add file limit to Rubocop Autocorrect Script
2023-08-02 14:36:20 +10:00
dependabot[bot]
bff74e9472
chore(deps-dev): bump knapsack_pro from 5.3.4 to 5.3.5
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.4 to 5.3.5.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.4...v5.3.5 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-02 03:17:45 +00:00
David Cook
ff76e3afa1
Merge pull request #11263 from mkllnk/dfc-connector-context
...
Dfc connector context
2023-08-02 13:16:28 +10:00
David Cook
44d1066e5c
Merge pull request #11310 from Matt-Yorkley/image-magick
...
Rescue ImageMagick errors
2023-08-02 10:26:46 +10:00
Neal Chambers
0d2e2fa42c
Add skip for cops that couldn't be autocorrected
2023-08-02 09:11:00 +09:00
Konrad
bc01207fec
Merge pull request #11281 from jibees/11205-white-label-logo-image-not-displaying-correctly-on-mobile
...
White label: Update mobile variant size for white label logo to fit the same ratio
2023-08-02 00:10:14 +02:00
bouaik
5681c45a9e
use classes like logged in checkout
2023-08-01 22:08:56 +01:00
Maikel Linke
bebdaace4b
Prefer plain text in spec expectations
2023-08-01 23:06:26 +02:00
cyrillefr
d4c864a118
Add testing for modal warning that name is already in use
2023-08-01 23:06:26 +02:00
cyrillefr
057754305d
Useless 'end' at end of coffeescript block
2023-08-01 23:06:26 +02:00
cyrillefr
05d610e598
Spec for (re)enabling 'Create Profile' button if not returning promise
2023-08-01 23:06:26 +02:00
cyrillefr
ae1e6032f6
Enable 'Create Profile' button via callback in case of not returning promise
2023-08-01 23:06:26 +02:00
Neal Chambers
f47f6efcd0
Safely autocorrect Rails/DurationArithmetic
...
Inspecting 1481 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.................................................................................................................................................................................................................................................................................C..............C..........................................................C...............................C....C..........CC................................................................
Offenses:
app/services/create_order_cycle.rb:41:24: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
orders_close_at: Time.zone.now + 1.month
^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:7:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now - 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:10:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now + 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:13:75: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: false, orders_close_at: Time.zone.now - 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_opened_job_spec.rb:7:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, orders_open_at: Time.zone.now - 1.hour)
^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_opened_job_spec.rb:13:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, orders_open_at: Time.zone.now + 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/permissions/order_spec.rb:26:58: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now - 1.year)
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:21:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week }
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:22:59: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(TermsOfServiceFile).to receive(:updated_at) { Time.zone.now - 2.weeks }
^^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:36:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week }
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:38:45: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
ActiveStorage::Blob.new(created_at: Time.zone.now - 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:647:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now + 1.week,
^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:652:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now + 2.weeks,
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:661:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc3.update!(orders_close_at: Time.zone.now + 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:662:39: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc3.update!(orders_open_at: Time.zone.now + 1.week)
^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:128:18: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc_open_at = Time.zone.now - 2.weeks
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:129:19: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc_close_at = Time.zone.now + 2.weeks
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:289:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order2.update!(completed_at: Time.zone.now - 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:290:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order3.update!(completed_at: Time.zone.now - 3.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:291:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order4.update!(completed_at: Time.zone.now - 4.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:292:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order5.update!(completed_at: Time.zone.now - 5.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:113:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:completed_at1) { Time.zone.now - 1500.hours } # 1500 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:114:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:completed_at2) { Time.zone.now - 1700.hours } # 1700 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:115:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_start1) { Time.zone.now - 1600.hours } # 1600 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:116:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_start2) { Time.zone.now - 1800.hours } # 1600 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:117:30: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_end) { Time.zone.now - 1400.hours } # 1400 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/packing_report_spec.rb:13:26: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a method call.
let!(:open_datetime) { (1.month.ago).strftime("%Y-%m-%d 00:00") }
^^^^^^^^^^^^^
spec/system/admin/reports/packing_report_spec.rb:13:27: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let!(:open_datetime) { (Time.zone.now - 1.month).strftime("%Y-%m-%d 00:00") }
^^^^^^^^^^^^^^^^^^^^^^^
1481 files inspected, 28 offenses detected, 28 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
a263110799
Safely autocorrect Rails/DotSeparatedKeys
...
Inspecting 1481 files
........................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/api/v1/base_controller.rb:72:66: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option.
message = I18n.t(:missing_parameter, param: error.param, scope: :api)
^^^^^^^^^^^
app/controllers/api/v1/base_controller.rb:79:84: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option.
message = I18n.t(:unpermitted_parameters, params: error.params.join(", "), scope: :api)
^^^^^^^^^^^
1481 files inspected, 2 offenses detected, 2 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
44cf2faa1e
Safely autocorrect Rails/ActiveRecordCallbacksOrder
...
Inspecting 1481 files
...........................................................................................................................................................................................................................................................C..C.CC........................................................................C...C..........C..C..................CC........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/customer.rb:32:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy.
before_validation :downcase_email
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:33:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy.
before_validation :empty_code
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/customer.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/customer.rb:49:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_create is supposed to appear before before_destroy.
before_create :associate_user
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:129:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch.
after_create :set_default_contact
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:130:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch.
after_create :relate_to_owners_enterprises
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:133:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_rollback is supposed to appear before after_touch.
after_rollback :restore_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:134:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_save is supposed to appear before after_find.
after_save :unset_undefined_address_fields
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:19:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_find.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:23:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:15:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save.
before_destroy :revoke_all_child_variant_overrides
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:16:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save.
before_destroy :destroy_related_exchanges
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:108:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :update_shipping_fees!, if: :complete?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:109:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :update_payment_fees!, if: :complete?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:30:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before before_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:32:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:33:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :invalidate_old_payments
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:34:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:35:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :invalidate_old_payments
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:36:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:46:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/product.rb:87:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :ensure_standard_variant
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/return_authorization.rb:12:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :force_positive_amount
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/user.rb:49:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before before_destroy.
after_create :associate_customers, :associate_orders
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/user.rb:50:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:88:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :create_stock_items
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:89:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :set_position
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:90:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:91:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:91:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: around_destroy is supposed to appear before after_save.
around_destroy :destruction
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:92:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1481 files inspected, 35 offenses detected, 35 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
a1560263a1
Safely autocorrect Rails/ActionOrder
...
Inspecting 1481 files
.........................................C.................C.........................................................CC........C..........C.C.........C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Rails/ActionOrder: Action create should appear before update.
def create ...
^^^^^^^^^^
app/controllers/admin/resource_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/admin/resource_controller.rb:52:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update_positions
^^^^^^^^^^^^^^^^^^^^
app/controllers/api/v0/orders_controller.rb:13:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/api/v0/orders_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def show
^^^^^^^^
app/controllers/api/v0/orders_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/api/v0/orders_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/images_controller.rb:26:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/images_controller.rb:37:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/images_controller.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/images_controller.rb:41:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:19:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/invoices_controller.rb:50:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def poll
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Rails/ActionOrder: Action show should appear before new.
def show ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:24:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:27:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:27:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def index
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Rails/ActionOrder: Action index should appear before new.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:32:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:32:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:33:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def edit
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:36:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:38:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:42:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def edit
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:52:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:13:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:29:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/taxons_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:17:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def edit
^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:18:7: C: [Corrected] Rails/ActionOrder: Action new should appear before edit.
def new ...
^^^^^^^
app/controllers/spree/admin/variants_controller.rb:21:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:21:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:22:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:31:7: C: [Corrected] Rails/ActionOrder: Action new should appear before update.
def new ...
^^^^^^^
app/controllers/spree/admin/variants_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Rails/ActionOrder: Action create should appear before update.
def create ...
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:42:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:55:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:56:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def search
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:14:3: C: [Corrected] Rails/ActionOrder: Action show should appear before new.
def show ...
^^^^^^^^
app/controllers/user_confirmations_controller.rb:15:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/user_confirmations_controller.rb:19:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/user_confirmations_controller.rb:20:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:21:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:37:3: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/user_confirmations_controller.rb:42:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/user_confirmations_controller.rb:43:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1481 files inspected, 63 offenses detected, 63 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
e49c9e9061
Regenerate Rubocop's TODO file
2023-08-01 22:50:21 +09:00
Matt-Yorkley
885bc46d88
Update tax_category in product v3 table
2023-08-01 11:49:04 +01:00
David Cook
f7a137049f
Merge pull request #11296 from dacook/hide-git-errors
...
Prevent git errors from showing in command output
2023-08-01 12:16:53 +10:00
Matt-Yorkley
91fc4b51b4
Rescue ImageMagick errors
2023-07-31 17:21:49 +01:00
Mohamed ABDELLANI
7d38a7b381
remove order number next to Tax Invoice
2023-07-31 17:01:36 +01:00
Mohamed ABDELLANI
760b17042b
fix existing tests
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
0ce8fae7c9
replace invoice_number method with delegate
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
8abb9d2ecf
add invoice number to alternative invoices
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
e66cd5aaa3
add order number & invoice number to invoices
2023-07-31 16:31:24 +01:00
dependabot[bot]
8dcaba695e
chore(deps-dev): bump rubocop from 1.55.0 to 1.55.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.55.0 to 1.55.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.55.0...v1.55.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-31 09:50:50 +00:00
dependabot[bot]
c885b42df1
chore(deps): bump @floating-ui/dom from 1.4.5 to 1.5.1
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.5.1/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-31 09:44:08 +00:00
Gaetan Craig-Riou
85adb9f345
Fix rubocop warning
2023-07-31 15:19:04 +10:00
Gaetan Craig-Riou
2857930263
Fix voucher adjustment request spec
...
Error messages have been updated to be more user friendly. This spec
was missed somehow.
2023-07-31 14:06:36 +10:00
Gaetan Craig-Riou
089d2b9c84
Clear any existing payment and payment fees when adding a voucher
...
If a user come back to checkout step 2 from step 3, the order
will have payment and possibly payment fee existing. This can
interfere with voucher calculation, so we clear them.
The user can then select a payment method again if needed
2023-07-31 12:05:52 +10:00
Maikel
c8ad6d7d1c
Merge pull request #11300 from macanudo527/fix_rubocop_layout_3
...
Fix rubocop layout 4
2023-07-31 11:26:53 +10:00
Maikel
aa92aac5a9
Style FrozenStringLiteralComment
...
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-07-31 11:19:10 +10:00
Matt-Yorkley
64b29d40a8
Migrate data for tax_category_id from products to variants
2023-07-31 09:23:40 +10:00
Matt-Yorkley
e2094665c5
Update enterprise fee report tax_category fetching
2023-07-31 09:23:20 +10:00
Matt-Yorkley
07774c4572
Update tax category specs
2023-07-31 09:23:20 +10:00
Matt-Yorkley
d1209dd49b
Update order_with_taxes factory
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b593e356b0
Update product factories
2023-07-31 09:23:20 +10:00
Matt-Yorkley
a84f9ebd2e
Allow passing tax_category to new variant when creating a new product
2023-07-31 09:23:20 +10:00
Matt-Yorkley
0df121bcc8
Move tax_category validations test
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b2a7a931f3
Update tax_category tests
2023-07-31 09:23:20 +10:00
Matt-Yorkley
4cb291290b
Update product factory
2023-07-31 09:23:20 +10:00
Matt-Yorkley
5a48721af4
Update serializers, views, and JS for bulk products edit
2023-07-31 09:23:20 +10:00
Matt-Yorkley
363bbded43
Update permitted attributes
2023-07-31 09:23:20 +10:00
Matt-Yorkley
a52516bcbf
Move tax_category dropdown in edit pages
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b12c130e02
Add tax_category column to variants table
2023-07-31 09:23:20 +10:00
Matt-Yorkley
4934d09a4c
Update delegation and method chaining between product and tax_category
2023-07-31 09:23:20 +10:00
Matt-Yorkley
d33e780411
Move tax_category association from product to variant
2023-07-31 09:23:19 +10:00
Neal Chambers
60cd84d565
Safely autocorrect Naming/BlockForwarding
...
Inspecting 1480 files
...................................................................................................................................................................C.......C..........C...............................................................................................................................................................................................................C...........................................................................................................C.........C...............................................................................................................................................................................................................................................................C........................................CC...C............................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................C..............C.........C..CC.......C.....................................................................................................C...............
Offenses:
app/helpers/application_helper.rb:41:32: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def ng_form_for(name, *args, &block)
^^^^^^
app/helpers/application_helper.rb:44:75: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
form_for(name, *(args << options.merge(builder: AngularFormBuilder)), &block)
^^^^^^
app/helpers/application_helper.rb:49:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def method_missing(method, *args, &block)
^^^^^^
app/helpers/link_helper.rb:4:57: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def link_to_service(baseurl, name, html_options = {}, &block)
^^^^^^
app/helpers/link_helper.rb:8:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
link_to ext_url(baseurl, name), html_options, &block
^^^^^^
app/helpers/spree/admin/base_helper.rb:6:56: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def field_container(model, method, options = {}, &block)
^^^^^^
app/helpers/spree/admin/base_helper.rb:13:29: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
capture(&block),
^^^^^^
app/reflexes/application_reflex.rb:29:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def with_locale(&block)
^^^^^^
app/reflexes/application_reflex.rb:30:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
I18n.with_locale(current_user.locale, &block)
^^^^^^
app/services/cache_service.rb:8:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.cache(cache_key, options = {}, &block)
^^^^^^
app/services/cache_service.rb:9:48: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
Rails.cache.fetch cache_key.to_s, options, &block
^^^^^^
app/services/cache_service.rb:14:58: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.cached_data_by_class(cache_key, cached_class, &block)
^^^^^^
app/services/cache_service.rb:16:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
&block
^^^^^^
app/services/cache_service.rb:25:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.home_stats(statistic, &block)
^^^^^^
app/services/cache_service.rb:28:47: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
race_condition_ttl: 10, &block)
^^^^^^
app/services/current_order_locker.rb:12:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.around(controller, &block)
^^^^^^
app/services/current_order_locker.rb:13:55: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
lock_order_and_variants(controller.current_order, &block)
^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:392:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def chain_to_scope(&block)
^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:393:41: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
@scope = @scope.instance_eval(&block)
^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:7:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def respond_with(*resources, &block)
^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:13:64: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
return unless (collector = retrieve_collector_from_mimes(&block))
^^^^^^
lib/spree/core/delegate_belongs_to.rb:80:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def class_def(name, method = nil, &blk)
^^^^
lib/spree/core/delegate_belongs_to.rb:81:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
class_eval { method.nil? ? define_method(name, &blk) : define_method(name, method) }
^^^^
lib/spree/core/environment_extension.rb:22:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def create_method(name, &block)
^^^^^^
lib/spree/core/environment_extension.rb:23:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
self.class.__send__(:define_method, name, &block)
^^^^^^
spec/models/enterprise_caching_spec.rb:144:13: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def later(&block)
^^^^^^
spec/models/enterprise_caching_spec.rb:145:36: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
Timecop.travel(1.day.from_now, &block)
^^^^^^
spec/support/embedded_pages_helper.rb:5:26: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def on_embedded_page(&block)
^^^^^^
spec/support/embedded_pages_helper.rb:6:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within_frame :frame, &block
^^^^^^
spec/support/preferences_helper.rb:11:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def reset_spree_preferences(&config_block)
^^^^^^^^^^^^^
spec/support/preferences_helper.rb:16:33: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
configure_spree_preferences(&config_block) if block_given?
^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:87:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def within_variant(variant = nil, &block)
^^^^^^
spec/support/request/shop_workflow.rb:90:22: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within(selector, &block)
^^^^^^
spec/support/request/ui_component_helper.rb:4:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def browse_as_small(&block)
^^^^^^
spec/support/request/ui_component_helper.rb:5:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
browse_with_window_size(640, 480, &block)
^^^^^^
spec/support/request/ui_component_helper.rb:8:24: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def browse_as_medium(&block)
^^^^^^
spec/support/request/ui_component_helper.rb:9:40: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
browse_with_window_size(1024, 768, &block)
^^^^^^
spec/support/request/web_helper.rb:52:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def within_row(num, &block)
^^^^^^
spec/support/request/web_helper.rb:53:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within("table.index tbody tr:nth-child(#{num})", &block)
^^^^^^
spec/swagger_helper.rb:77:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def param(args, &block)
^^^^^^
spec/swagger_helper.rb:78:45: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
public_send(:let, args) { instance_eval(&block) }
^^^^^^
spec/system/support/capybara_setup.rb:20:27: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def using_session(name, &block)
^^^^^^
1480 files inspected, 42 offenses detected, 42 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
ae8a5b7f93
Safely autocorrect Lint/UnusedMethodArgument
...
Inspecting 1480 files
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
lib/reporting/queries/query_interface.rb:18:30: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it.
def sum_grouped(field, default = 0)
^^^^^^^
lib/reporting/queries/query_interface.rb:22:26: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it.
def sum_new(field, default = 0)
^^^^^^^
1480 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
2a76b1972f
Safely autocorrect Lint/SafeNavigationChain
...
Inspecting 1480 files
........................................................................................................................................................................................................................................................................................................................................W............................W..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/spree/line_item.rb:283:55: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
self.final_weight_volume = variant&.unit_value * quantity
^^^^^^^^^^^
app/models/spree/line_item.rb:283:57: C: [Corrected] Layout/SpaceAroundMethodCallOperator: Avoid using spaces around a method call operator.
self.final_weight_volume = variant&.unit_value&. * quantity
^
app/models/spree/stock/availability_validator.rb:31:77: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
return line_item.order.shipments.first if line_item.order&.shipments.any?
^^^^^
1480 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
e7d53753e4
Safely autocorrect Lint/RedundantCopDisableDirective
...
Inspecting 1480 files
..............W.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/components/product_component.rb:23:51: W: [Corrected] Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/MethodLength.
# rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
^^^^^^^^^^^^^^^^^^^^
app/components/product_component.rb:50:50: W: [Corrected] Lint/RedundantCopEnableDirective: Unnecessary enabling of Metrics/MethodLength.
# rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength
^^^^^^^^^^^^^^^^^^^^
1480 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
e9f448fad9
Safely autocorrect Lint/AmbiguousOperatorPrecedence
...
Inspecting 1480 files
...................................................................................................................................................................................................................................W..........................W........................................................W................W..............W................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/calculator/flexi_rate.rb:38:7: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
count * preferred_additional_item.to_f + preferred_first_item.to_f
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:362:12: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
cat << "sells_" + sells
^^^^^^^^^^^^^^^^
app/models/enterprise.rb:496:21: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
phone_number && "https://wa.me/ " + phone_number.tr('+ ', '')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/ability.rb:27:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
order.user == user || order.token && token == order.token
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/ability.rb:30:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
order.user == user || order.token && token == order.token
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/line_item.rb:205:16: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
(price + fees / quantity).round(2)
^^^^^^^^^^^^^^^
app/models/spree/preferences/store.rb:28:11: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
should_persist? && Spree::Preference.where(key: key).exists?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1480 files inspected, 7 offenses detected, 7 offenses corrected
2023-07-30 21:29:19 +09:00
bouaik
addbbc4006
fix margin in guest checkout
2023-07-29 07:52:55 -04:00
filipefurtad0
0bcde2dbda
Update all locales with the latest Transifex translations
2023-07-28 16:33:49 +01:00
Filipe
5d624ef4be
Merge pull request #11278 from mkllnk/swagger-fix
...
Fix swagger-api integration after last update
2023-07-28 16:27:32 +01:00
Filipe
1ddbb1c4e1
Merge pull request #11294 from Matt-Yorkley/connect-src
...
Update CSP configuration for Safari
2023-07-28 16:16:02 +01:00
Cillian O'Ruanaidh
8039c0106a
Set firstname correctly in spec/system/admin/orders_spec.rb
2023-07-28 15:04:47 +01:00
Cillian O'Ruanaidh
276b94de5b
Sort orders by last name, then first name i.e. the same way bulk order management works
2023-07-28 14:20:29 +01:00
Filipe
a975e2bd93
Merge pull request #11247 from jibees/9123-inconsistent-default-visibility-setting-for-newly-created-enterprises
...
Admin, Enterprise creation : set visibility to "Hidden" by default
2023-07-28 12:15:32 +01:00
Filipe
ef947f8749
Merge pull request #11282 from jibees/11025-white-label-trix-quotes-code-and-links-cant-be-identified-in-the-editor
...
White label: Customize rendering inside the trix-editor, to match the shopfront rendering
2023-07-28 11:23:50 +01:00
Filipe
21690670f5
Merge pull request #11292 from jibees/11108-dashboard-supplier-profile-inconsistent-indentation-on-deployed-version
...
Admin: improve platform version displaying on admin homepage
2023-07-28 11:01:07 +01:00
Gaetan Craig-Riou
33ef8def08
Update order total after removing a voucher
...
We need to do this to make sure when display the payment method
again.
Plus spec
2023-07-28 14:52:25 +10:00
Gaetan Craig-Riou
f35001dacc
Update voucher adjustment and order total when adding a voucher
...
This is needed so we can check if payment is needed and display
no payment required when no payment needed
2023-07-28 14:27:27 +10:00
David Cook
ef62fb885d
Check if record actually saved
...
I'm not sure if it will ever make a difference, but I think this makes more sense.
2023-07-28 14:11:45 +10:00
David Cook
be1a72743a
Pending spec: vouchers should not require payment
2023-07-28 14:11:31 +10:00
David Cook
895f534afa
Remove unnecessary extra page load
2023-07-28 14:11:19 +10:00
David Cook
febe6501c0
Prevent git errors from showing in command output
...
This would be a very rare case, but one time the git command failed, printing out an obscure "fatal" message to stderr which caused confusion.
2023-07-28 12:07:52 +10:00
Maikel
774bb7a607
Merge pull request #11238 from filipefurtad0/legal_invoices_spec
...
Adds coverage to Invoices (system specs)
2023-07-28 08:41:01 +10:00
filipefurtad0
98f29dcd9b
Adds coverage on invoices section/table
2023-07-27 17:27:41 +01:00
Matt-Yorkley
dd9b28787c
Update CSP configuration for Safari
...
Apparently some versions of Safari have issues with Websockets if the CSP doesn't explicitly define the `connect_src` in a certain way (including specifying the host). This issue is fixed in later versions of Safari and doesn't affect other browsers, for which the `default_src` with `:self` is sufficient.
2023-07-27 16:20:42 +01:00
filipefurtad0
35dfdc8bdc
Adds coverage on Invoice tab
...
which should be visible as a function of the order state
Corrects cancelled case
2023-07-27 15:47:40 +01:00
Jean-Baptiste Bellet
8b4de3ddc7
Add version into its own .row .columns with centered text
2023-07-27 15:41:54 +02:00
jibees
55fbab4c0d
Merge pull request #11287 from openfoodfoundation/dependabot/bundler/rexml-3.2.6
...
chore(deps): bump rexml from 3.2.5 to 3.2.6
2023-07-27 12:00:28 +02:00
Jean-Baptiste Bellet
a179c006fc
Default design for ul and ol into the custom tab
...
`ul` and `old` default design already been reset, reactivate default design only for `.custom-tab`
2023-07-27 11:53:47 +02:00
Jean-Baptiste Bellet
4485490b0b
Customize rendering inside the trix-editor, to match the shopfront rendering
2023-07-27 11:53:47 +02:00
jibees
b3949965fc
Merge pull request #11288 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.4
...
chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4
2023-07-27 11:34:37 +02:00
dependabot[bot]
79d0728fdd
chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.3 to 5.3.4.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.3...v5.3.4 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 09:25:02 +00:00
dependabot[bot]
4e9dae6817
chore(deps): bump rexml from 3.2.5 to 3.2.6
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.6 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 09:21:38 +00:00
jibees
96418dcde6
Merge pull request #11284 from mkllnk/caching-spec
...
Compile JS before testing caching
2023-07-27 09:41:22 +02:00
Maikel Linke
b9ebcc9b1b
Remove version number from DFC API URLs
...
While it's quite common to version APIs it's not possible with current
DFC tools. The architecture also uses URLs as identifiers for objects
like products. Having the id of an object change just because the format
of its description changes doesn't make sense. The DFC may solve this by
adding a version number in a different way.
By removing the version from our API URL, all object ids (URIs) should
be stable from now on.
2023-07-27 15:38:36 +10:00
Maikel Linke
4872855471
Update DFC context to newest version
...
The new DFC Connector is based on the new DFC context which changed all
URLs of all data types.
There's also a better way to access semantic properties now.
2023-07-27 15:38:36 +10:00
dependabot[bot]
34fbcb0e02
chore(deps): bump datafoodconsortium-connector
...
Bumps datafoodconsortium-connector from 1.0.0.pre.alpha.6 to 1.0.0.pre.alpha.8.
---
updated-dependencies:
- dependency-name: datafoodconsortium-connector
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 15:38:36 +10:00
Maikel Linke
3b5b9ec54d
Avoid network request to DFC context on export
...
This protects us from the DFC website going down or the DFC updating
the context with breaking changes. We are in control of updating the
context now (opt-in to newer versions).
2023-07-27 15:38:36 +10:00
David Cook
fdb80fe87c
Merge pull request #11283 from macanudo527/fix_rubocop_layout_2
...
Fix rubocop layout 3
2023-07-27 10:29:29 +10:00
Neal Chambers
e923defd55
Safely autocorrect Layout/TrailingWhitespace
...
Inspecting 1479 files
...................................................................................................................................................C..C.......................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................C.............................................................................................C...................................................................C.......................................................................................................................................................................C....................................................C.............C...........CC.........C......C.CC.C....................C........................................................
Offenses:
app/controllers/spree/users_controller.rb:36:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/spree/users_controller.rb:51:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/user_confirmations_controller.rb:27:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/models/enterprise.rb:117:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
validates :instagram,
^
spec/controllers/spree/credit_cards_controller_spec.rb:250:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:stored_credit_card, user_id: user.id,
^
spec/controllers/user_confirmations_controller_spec.rb:45:44: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
session[:confirmation_return_url] =
^
spec/factories/order_factory.rb:40:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
order.payments << build(:payment, amount: order.total,
^
spec/lib/reports/packing/packing_report_spec.rb:59:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/lib/reports/packing/packing_report_spec.rb:63:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/models/enterprise_spec.rb:521:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(Enterprise.supplying_variant_in([p1.variants.first,
^
spec/models/enterprise_spec.rb:906:77: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:enterprise_relationship, parent: distributor, child: supplier,
^
spec/services/products_renderer_spec.rb:22:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:product, name: "banana bread", primary_taxon_id: cakes.id,
^
spec/services/products_renderer_spec.rb:88:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:90:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:97:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
fruits_supplier.producer_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:99:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:109:93: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_conventional.id,
^
spec/services/products_renderer_spec.rb:111:94: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_banana_bread.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:113:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_cherries.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:115:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_doughnuts.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:117:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/support/request/stripe_stubs.rb:17:81: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def stub_payment_intent_get_request(response: {}, stripe_account_header: true,
^
spec/support/request/stripe_stubs.rb:172:6: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
{
^
spec/support/request/stripe_stubs.rb:175:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
object: "list",
^
spec/support/request/stripe_stubs.rb:176:25: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
has_more: false,
^
spec/system/admin/bulk_order_management_spec.rb:792:99: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it "displays only line items whose orders meet the date restriction criteria, when changed",
^
spec/system/admin/bulk_order_management_spec.rb:1071:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1121:82: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
shared_examples "display only group by information for selected variant" do
^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1143:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1166:12: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^
spec/system/admin/customers_spec.rb:18:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:customer, first_name: 'John', last_name: 'Doe', enterprise: managed_distributor1,
^
spec/system/admin/enterprise_fees_spec.rb:102:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Inherit From Product',
^
spec/system/admin/enterprise_fees_spec.rb:128:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Weight (per kg or lb)',
^
spec/system/admin/enterprise_fees_spec.rb:132:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per item)',
^
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:157:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:159:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per order)',
^
spec/system/admin/enterprise_fees_spec.rb:222:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:22:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:27:32: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("#admin-menu").click
^^^^^^^
spec/system/admin/flatpickr_spec.rb:32:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:34:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:41:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_cycles/complex_editing_spec.rb:74:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/complex_editing_spec.rb:110:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/list_spec.rb:147:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:160:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:188:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/simple_spec.rb:447:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).not_to have_selector(
^
spec/system/admin/order_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:207:30: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within(".modal") do
^
spec/system/admin/order_spec.rb:235:21: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
login_as_admin
^^
spec/system/admin/order_spec.rb:240:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:247:62: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
context "when using the cancel option in the dropdown" do
^^
spec/system/admin/order_spec.rb:248:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:299:53: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_content "Are you sure?"
^^^^^^^^
spec/system/admin/order_spec.rb:327:36: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("a.delete-item").click
^
spec/system/admin/order_spec.rb:401:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:405:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:598:59: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Resend Confirmation",
^
spec/system/admin/order_spec.rb:617:52: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Cancel Order",
^
spec/system/admin/order_spec.rb:633:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:674:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:735:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:762:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:778:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:780:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:796:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:807:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
# Since the order is completed, the price is not supposed to be updated
^
spec/system/admin/order_spec.rb:813:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:815:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:924:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:959:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:981:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^^
spec/system/admin/order_spec.rb:992:8: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:1002:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1479 files inspected, 81 offenses detected, 81 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
e0206a0be6
Safely autocorrect Layout/TrailingEmptyLines
...
Inspecting 1479 files
..C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Rakefile:10:1: C: [Corrected] Layout/TrailingEmptyLines: 1 trailing blank lines detected.
1479 files inspected, 1 offense detected, 1 offense corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
2dbaa7f89d
Safely autocorrect Layout/MultilineMethodCallIndentation
...
Inspecting 1479 files
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......CC......................C..................................................
Offenses:
spec/controllers/api/v0/orders_controller_spec.rb:150:13: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
.map{ |o| o["id"] }
^^^^
spec/system/admin/order_cycles/complex_editing_spec.rb:30:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
.to eq(oc.orders_open_at.strftime("%Y-%m-%d %H:%M"))
^^^
spec/system/admin/order_cycles/complex_editing_spec.rb:32:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
.to eq(oc.orders_close_at.strftime("%Y-%m-%d %H:%M"))
^^^
spec/system/admin/overview_spec.rb:16:62: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 55) spaces for indenting an expression spanning multiple lines.
.and_return @enterprise_user
^^^^^^^^^^^
spec/system/admin/payment_method_spec.rb:62:22: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
.to_return(body: JSON.generate(stripe_account_mock))
^^^^^^^^^^
spec/system/admin/variant_overrides_spec.rb:214:64: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 51) spaces for indenting an expression spanning multiple lines.
.and_return(build(:user))
^^^^^^^^^^^
1479 files inspected, 6 offenses detected, 6 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
164385ad13
Safely autocorrect Layout/MultilineMethodCallBraceLayout
...
Inspecting 1479 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C.....................................................................
Offenses:
spec/system/admin/orders_spec.rb:485:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^
spec/system/admin/orders_spec.rb:486:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0)
)).to be_checked
^
spec/system/admin/orders_spec.rb:486:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
).to be_checked
^
spec/system/admin/orders_spec.rb:493:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^
spec/system/admin/orders_spec.rb:494:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0)
)).to_not be_checked
^
spec/system/admin/orders_spec.rb:494:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
).to_not be_checked
^
spec/system/admin/products_spec.rb:346:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
product.id, filter)))
^
spec/system/admin/products_spec.rb:347:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0)
)))
^
spec/system/admin/products_spec.rb:352:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
product.id, filter)))
^
spec/system/admin/products_spec.rb:354:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0)
)))
^
1479 files inspected, 10 offenses detected, 10 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
a97e208881
Safely autocorrect Layout/MultilineBlockLayout
...
Inspecting 1479 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/order_management/app/services/order_management/subscriptions/validator.rb:101:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 12) spaces for indentation.
sli.quantity > 0 && !sli.marked_for_destruction?
^^^^^^^^^^^^
engines/order_management/app/services/order_management/subscriptions/validator.rb:101:11: C: [Corrected] Layout/MultilineBlockLayout: Block argument expression is not on the same line as the block start.
|sli| sli.quantity > 0 && !sli.marked_for_destruction?
^^^^^
1479 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-27 09:58:05 +10:00
Maikel Linke
f7d5217ef6
Compile JS before testing caching
...
That avoids flakiness.
2023-07-27 09:40:08 +10:00
Neal Chambers
ffda639629
Regenerate Rubocop's TODO file
2023-07-27 08:35:27 +09:00
Maikel
f9589b8b23
Merge pull request #11280 from filipefurtad0/fix_flaky_caching_spec
...
Comments out flaky caching example
2023-07-27 08:50:06 +10:00
Maikel
5e94c038dc
Merge pull request #11227 from filipefurtad0/update_several_enterprise_fees
...
Updates spec to cover #11150 (regression spec)
2023-07-27 08:45:27 +10:00
Maikel
16d28ab797
Merge pull request #11277 from mkllnk/greek
...
Add greek locale
2023-07-27 08:38:51 +10:00
filipefurtad0
5ed9583048
Rubocop fixes - not seen locally
...
Not sure why these were triggered remotly, but not locally - even after making sure I'm up-to-date with master?
2023-07-26 18:35:12 +01:00
filipefurtad0
f7301b72aa
Adds test case for updating multiple fees
...
Adds values, updates and asserts these are saved correctly
2023-07-26 18:35:09 +01:00
Jean-Baptiste Bellet
1a7e99143b
Update mobile variant size for white label logo to fit the same ratio
...
Default size is 217*44. On mobile, we used to use 75*26, but with a different image.
With the white label, using the same image, we should have the same ratio between default and mobile ; that's why I've updated the width of the variant to 128.
2023-07-26 14:43:06 +02:00
filipefurtad0
83f1266b8a
Comments out flaky example
...
Sets example to xit
pending is not suitable for flaky specs, as we'll get a red build anyway, each time the spec passes; commenting out should be the right approach till we fix this one
2023-07-26 12:05:06 +01:00
jibees
f5564a5947
Merge pull request #11279 from openfoodfoundation/dependabot/bundler/rubocop-1.55.0
...
chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0
2023-07-26 12:56:01 +02:00
filipefurtad0
d4d8941117
Reverts #11019
...
As discussed here (https://github.com/openfoodfoundation/openfoodnetwork/issues/11010#issuecomment-1594153860 ), reset_spree_preferences already does Rails.cache.clear
2023-07-26 11:49:41 +01:00
dependabot[bot]
45edda9bf6
chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.54.2 to 1.55.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.54.2...v1.55.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-26 08:43:15 +00:00
jibees
ad7ec1e6d0
Merge pull request #11271 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.132.0
...
chore(deps): bump aws-sdk-s3 from 1.131.0 to 1.132.0
2023-07-26 10:41:38 +02:00
jibees
b9871933e3
Merge pull request #11272 from openfoodfoundation/dependabot/bundler/view_component-3.5.0
...
chore(deps): bump view_component from 3.4.0 to 3.5.0
2023-07-26 10:40:55 +02:00
Maikel Linke
627e689757
Fix swagger-api integration after last update
...
See also:
* https://github.com/rswag/rswag/pull/668
2023-07-26 15:52:48 +10:00
Maikel Linke
cea44c1a78
Add greek locale
2023-07-26 14:45:35 +10:00
jibees
a832562d1f
Merge pull request #11198 from dacook/admin_v3-table-tweaks
...
🚧 Products v3: table and menu tweaks
2023-07-25 16:00:24 +02:00
David Cook
8ef73906db
Show products_v3 in the submenu
...
It's not translated, but that doesn't matter, it's just a shortcut while we're developing it.
2023-07-25 15:31:57 +02:00
David Cook
439c0a8e18
Remove unnecessary match_path options
...
Spree::Tab already knows when to highlight these, based on the controller name. It even handles sub-paths like '/admin/products/garlic/edit'.
2023-07-25 15:31:57 +02:00
David Cook
ea93800ee6
[table] Tax category: display None instead of blank
2023-07-25 15:31:57 +02:00
David Cook
51189a3138
[table] Hide properties for variant row
...
These were a duplicate of the product.
2023-07-25 15:31:57 +02:00
jibees
605cb730f7
Merge pull request #11163 from jibees/productsV3-searching-filtering-pagination
...
🚧 Products v3: viewing, searching, filtering & pagination
2023-07-25 15:22:42 +02:00
Jean-Baptiste Bellet
352cf2ff71
Import typography.scss for admin_v3
...
And do not apply `a` style to `.button` element.
ie.
```
a:not(.button)
```
2023-07-25 14:29:00 +02:00
dependabot[bot]
e816629038
chore(deps): bump view_component from 3.4.0 to 3.5.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-25 10:10:33 +00:00
dependabot[bot]
789fde3c89
chore(deps): bump aws-sdk-s3 from 1.131.0 to 1.132.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.131.0 to 1.132.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-25 10:03:30 +00:00
filipefurtad0
04f83fbcce
Finally, update system test for an end-to-end testing
2023-07-25 10:57:27 +02:00
Jean-Baptiste Bellet
d22566aa50
Set visible to only_through_links on enterprise creation
2023-07-25 10:57:27 +02:00
Jean-Baptiste Bellet
5a0d4d2a93
Set visible to only_through_links on enterprise registration
2023-07-25 10:57:26 +02:00
Jean-Baptiste Bellet
7aed068bb7
Enterprises.visible attribute is set to only_through_links by default
...
+ update enterprise_factory.rb to create "public" enterprise through specs via its factory
2023-07-25 10:57:26 +02:00
Jean-Baptiste Bellet
2a81a9acfb
Add ability for non super-admin user to see products_v3 page
2023-07-25 09:20:25 +02:00
jibees
6f83d5b316
Merge pull request #11264 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.3
...
chore(deps-dev): bump knapsack_pro from 5.3.2 to 5.3.3
2023-07-24 15:19:57 +02:00
jibees
af086253de
Merge pull request #11265 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.1.0
...
chore(deps-dev): bump jasmine-core from 5.0.1 to 5.1.0
2023-07-24 15:11:45 +02:00
Filipe
8ff877b865
Merge pull request #11258 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.131.0
...
chore(deps): bump aws-sdk-s3 from 1.126.0 to 1.131.0
2023-07-24 13:30:42 +01:00
Filipe
1e2fb077cd
Merge pull request #11261 from macanudo527/fix_rubocop_layout_1
...
Fix Rubocop Layout violations - 2
2023-07-24 13:05:46 +01:00
dependabot[bot]
f5c326f1b0
chore(deps-dev): bump jasmine-core from 5.0.1 to 5.1.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.0.1 to 5.1.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.0.1...v5.1.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-24 09:36:51 +00:00
dependabot[bot]
bf010d273a
chore(deps-dev): bump knapsack_pro from 5.3.2 to 5.3.3
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.2 to 5.3.3.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.2...v5.3.3 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-24 09:17:36 +00:00
Maikel Linke
f36ca77f5f
Ease reading with related spec values on one line
2023-07-24 13:31:09 +10:00
Maikel Linke
a677444a97
Fix specs with missign parenthesis
2023-07-24 13:23:54 +10:00
Neal Chambers
bede52bdae
Safely autocorrect Layout/LineLength
...
Inspecting 1478 files
.......C............................C..............................................................................................................C.......................................................................................................C............................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.................C......................................C...................................................................................................................C...........................................................C........................C...C.....C..C..C..........C..................C...............C.....................C...................................................................................C......................................................C........C..C...........C....................C.CC....C....................................C......C..........................
Offenses:
app/components/confirm_modal_component.rb:4:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil,
^
app/components/confirm_modal_component.rb:4:101: C: [Corrected] Layout/LineLength: Line is too long. [110/100]
def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, confirm_reflexes: nil)
^^^^^^^^^^
app/components/confirm_modal_component.rb:5:1: C: [Corrected] Layout/ParameterAlignment: Align the parameters of a method definition if they span more than one line.
confirm_reflexes: nil)
^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:142:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
redirect_to '/admin/product_import',
^
app/controllers/admin/product_import_controller.rb:142:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
redirect_to '/admin/product_import', notice: I18n.t(:product_import_no_data_in_spreadsheet_notice)
^^^^
app/controllers/admin/product_import_controller.rb:143:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
notice: I18n.t(:product_import_no_data_in_spreadsheet_notice)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100]
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^
app/models/customer.rb:43:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
scope :managed_by, ->(user) { user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none }
^^^^^^^^^^^^^
app/models/customer.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^
app/models/customer.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -19) spaces for indentation.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:44:82: C: [Corrected] Layout/BlockEndNewline: Expression at 44, 82 should be on its own line.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none }
^
app/models/customer.rb:44:101: C: Layout/LineLength: Line is too long. [102/100]
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^^
app/models/customer.rb:45:1: C: [Corrected] Layout/BlockAlignment: } at 45, 0 is not aligned with ->(user) { at 43, 21 or scope :managed_by, ->(user) { at 43, 2.
}
^
app/models/spree/line_item.rb:53:101: C: Layout/LineLength: Line is too long. [110/100]
attr_accessor :skip_stock_check, :target_shipment # Allows manual skipping of Stock::AvailabilityValidator
^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:38:101: C: Layout/LineLength: Line is too long. [108/100]
it "loads order cycles that closed within the past month, and orders without a close_at date" do
^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:48:101: C: Layout/LineLength: Line is too long. [111/100]
it "loads order cycles that closed after the specified date, and orders without a close_at date" do
^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:100:101: C: Layout/LineLength: Line is too long. [125/100]
expect(flash[:error]).to eq "You don't have permission to create an order cycle coordinated by that enterprise"
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:125:101: C: Layout/LineLength: Line is too long. [101/100]
order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: true,
^
spec/controllers/admin/order_cycles_controller_spec.rb:127:101: C: Layout/LineLength: Line is too long. [102/100]
order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: false,
^^
spec/controllers/admin/order_cycles_controller_spec.rb:284:101: C: Layout/LineLength: Line is too long. [101/100]
merge(order_cycle: { preferred_product_selection_from_coordinator_inventory_only: true })
^
spec/controllers/admin/order_cycles_controller_spec.rb:311:101: C: Layout/LineLength: Line is too long. [104/100]
create(:exchange, order_cycle: order_cycle, sender: coordinator, receiver: hub, incoming: false,
^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:374:101: C: Layout/LineLength: Line is too long. [102/100]
expect(json_response['errors']).to eq 'Hm, something went wrong. No order cycle data found.'
^^
spec/controllers/admin/order_cycles_controller_spec.rb:460:101: C: Layout/LineLength: Line is too long. [176/100]
expect(flash[:error]).to eq 'That order cycle has been selected by a customer and cannot be deleted. To prevent customers from accessing it, please close it instead.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:470:101: C: Layout/LineLength: Line is too long. [147/100]
expect(flash[:error]).to eq 'That order cycle is linked to a schedule and cannot be deleted. Please unlink or delete the schedule first.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:16:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100]
let!(:product1) { create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) }
^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1])
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1])
^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:85: C: [Corrected] Layout/BlockEndNewline: Expression at 17, 85 should be on its own line.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) }
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100]
let!(:product2) { create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) }
^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:18:1: C: [Corrected] Layout/BlockAlignment: } at 18, 0 is not aligned with let!(:product1) { at 16, 4.
}
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:19:85: C: [Corrected] Layout/BlockEndNewline: Expression at 19, 85 should be on its own line.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) }
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:20:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2])
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:20:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2])
^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:21:1: C: [Corrected] Layout/BlockAlignment: } at 21, 0 is not aligned with let!(:product2) { at 19, 4.
}
^
spec/controllers/spree/admin/orders_controller_spec.rb:232:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
let!(:order_cycle){ create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) }
^^^^^^^^^^^^^^^^^
spec/controllers/spree/admin/orders_controller_spec.rb:233:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant])
^
spec/controllers/spree/admin/orders_controller_spec.rb:233:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant])
^^^^^^
spec/controllers/spree/admin/orders_controller_spec.rb:233:90: C: [Corrected] Layout/BlockEndNewline: Expression at 233, 90 should be on its own line.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) }
^
spec/controllers/spree/admin/orders_controller_spec.rb:234:1: C: [Corrected] Layout/BlockAlignment: } at 234, 0 is not aligned with let!(:order_cycle){ at 232, 8.
}
^
spec/controllers/spree/admin/orders_controller_spec.rb:252:101: C: Layout/LineLength: Line is too long. [109/100]
allow_any_instance_of(Spree::Order).to receive(:ensure_available_shipping_rates).and_return(true)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:93:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:94:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:94:101: C: Layout/LineLength: Line is too long. [109/100]
bill_address: a, shipping_method: sm)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:97:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:98:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:98:101: C: Layout/LineLength: Line is too long. [109/100]
bill_address: a, shipping_method: sm)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:113:101: C: Layout/LineLength: Line is too long. [118/100]
[d.address.address1, d.address.address2, d.address.city].join(" "),
^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:120:101: C: [Corrected] Layout/LineLength: Line is too long. [129/100]
create(:order_with_totals_and_distribution, :completed, distributor: d2, bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:122:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d2,
^
spec/lib/reports/customers_report_spec.rb:123:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:123:101: C: Layout/LineLength: Line is too long. [112/100]
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:133:101: C: Layout/LineLength: Line is too long. [120/100]
[d.address.address1, d.address.address2, d.address.city].join(" "),
^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:139:101: C: Layout/LineLength: Line is too long. [123/100]
[d2.address.address1, d2.address.address2, d2.address.city].join(" "),
^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:145:101: C: [Corrected] Layout/LineLength: Line is too long. [128/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:148:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:149:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:149:101: C: Layout/LineLength: Line is too long. [112/100]
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/models/enterprise_spec.rb:521:101: C: [Corrected] Layout/LineLength: Line is too long. [111/100]
expect(Enterprise.supplying_variant_in([p1.variants.first, p2.variants.first])).to match_array [s1, s2]
^^^^^^^^^^^
spec/models/enterprise_spec.rb:522:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
p2.variants.first])).to match_array [s1, s2]
^^^^^^^^^^^^^^^^^
spec/models/order_cycle_spec.rb:207:101: C: Layout/LineLength: Line is too long. [118/100]
expect(oc.variants).to match_array [p0.variants.first, p1.variants.first, p2.variants.first, p2_v, p1_v_visible,
^^^^^^^^^^^^^^^^^^
spec/models/order_cycle_spec.rb:220:101: C: Layout/LineLength: Line is too long. [111/100]
expect(oc.distributed_variants).to match_array [p1.variants.first, p2.variants.first, p2_v, p1_v_visible,
^^^^^^^^^^^
spec/models/product_importer_spec.rb:782:101: C: Layout/LineLength: Line is too long. [101/100]
csv << [" Oats ", "\nPorridge Oats\n", "\r#{enterprise2.name}\r", "\t#{enterprise.name}\t",
^
spec/models/spree/ability_spec.rb:340:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :edit, :update, :search, :destroy,
^
spec/models/spree/ability_spec.rb:340:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
[:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p1.variants.first
^
spec/models/spree/ability_spec.rb:341:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:delete], for: p1.variants.first
^^^^^^^
spec/models/spree/ability_spec.rb:350:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100]
[:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p_related.variants.first
^^^^^^^^
spec/models/spree/ability_spec.rb:351:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :edit, :update, :search, :destroy,
^
spec/models/spree/ability_spec.rb:352:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:delete], for: p_related.variants.first
^^^^^^^
spec/models/spree/ability_spec.rb:379:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
[:admin, :index, :read, :create, :edit, :search, :update, :destroy], for: p2.variants.first
^
spec/models/spree/ability_spec.rb:381:68: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :create, :edit, :search, :update,
^
spec/models/spree/ability_spec.rb:382:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:destroy], for: p2.variants.first
^^^^^^^^
spec/models/spree/adjustment_spec.rb:339:101: C: Layout/LineLength: Line is too long. [106/100]
create(:tax_rate, included_in_price: true, calculator: ::Calculator::DefaultTax.new, zone: zone,
^^^^^^
spec/models/spree/adjustment_spec.rb:367:101: C: Layout/LineLength: Line is too long. [101/100]
calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0))
^
spec/models/spree/adjustment_spec.rb:428:101: C: Layout/LineLength: Line is too long. [105/100]
context "when enterprise fees inherit their tax_category from the product they are applied to" do
^^^^^
spec/models/spree/adjustment_spec.rb:443:101: C: Layout/LineLength: Line is too long. [101/100]
calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0))
^
spec/models/spree/line_item_spec.rb:208:101: C: Layout/LineLength: Line is too long. [107/100]
expect(LineItem.from_order_cycle(oc_order.order_cycle).first.id).to eq oc_order.line_items.first.id
^^^^^^^
spec/models/spree/line_item_spec.rb:342:101: C: Layout/LineLength: Line is too long. [102/100]
Spree::Variant.find(variant.id).on_hand
^^
spec/models/spree/product_spec.rb:409:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d1],
^
spec/models/spree/product_spec.rb:409:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first])
^^^^
spec/models/spree/product_spec.rb:410:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p1.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:410:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first])
^^^^
spec/models/spree/product_spec.rb:411:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d2],
^
spec/models/spree/product_spec.rb:412:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p2.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:486:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first])
^^^^
spec/models/spree/product_spec.rb:487:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first])
^^^^
spec/models/spree/product_spec.rb:488:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d1],
^
spec/models/spree/product_spec.rb:489:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p1.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:490:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d2],
^
spec/models/spree/product_spec.rb:491:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p2.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:495:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d], variants: [p.variants.first])
^^
spec/models/spree/product_spec.rb:499:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d],
^
spec/models/spree/product_spec.rb:500:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/variant_spec.rb:356:101: C: Layout/LineLength: Line is too long. [108/100]
it "lists any variants that are not listed as visible=false only for the relevant enterprise" do
^^^^^^^^
spec/models/spree/variant_spec.rb:479:101: C: Layout/LineLength: Line is too long. [108/100]
expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_for).with(variant) {
^^^^^^^^
spec/models/spree/variant_spec.rb:494:101: C: Layout/LineLength: Line is too long. [116/100]
expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_by_type_for).with(variant) {
^^^^^^^^^^^^^^^^
spec/models/spree/variant_spec.rb:704:101: C: Layout/LineLength: Line is too long. [115/100]
expect_any_instance_of(VariantUnits::OptionValueNamer).to receive(:name).exactly(1).times.and_call_original
^^^^^^^^^^^^^^^
spec/requests/api/orders_spec.rb:167:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_line_items, line_items_count: 1, bill_address_id: nil,
^
spec/requests/api/orders_spec.rb:167:101: C: [Corrected] Layout/LineLength: Line is too long. [109/100]
create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/requests/api/orders_spec.rb:168:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
ship_address_id: nil)
^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/support/request/web_helper.rb:96:84: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option',
^
spec/support/request/web_helper.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', text: value).click
^^
spec/support/request/web_helper.rb:97:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
text: value).click
^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:29:101: C: [Corrected] Layout/LineLength: Line is too long. [197/100]
let!(:tax_rate2) { create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:30:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
^
spec/system/admin/adjustments_spec.rb:30:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
spec/system/admin/adjustments_spec.rb:30:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
^
spec/system/admin/adjustments_spec.rb:30:101: C: [Corrected] Layout/LineLength: Line is too long. [177/100]
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:30:177: C: [Corrected] Layout/BlockEndNewline: Expression at 30, 177 should be on its own line.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^
spec/system/admin/adjustments_spec.rb:31:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
tax_category: tax_category_included, calculator: Calculator::DefaultTax.new )
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:32:1: C: [Corrected] Layout/BlockAlignment: } at 32, 0 is not aligned with let!(:tax_rate2) { at 29, 2.
}
^
spec/system/admin/adjustments_spec.rb:41:101: C: Layout/LineLength: Line is too long. [134/100]
shared_examples "when the enable_localized_number preference" do |adjustment_label, adjustment_amount, tax_category, tax, tax_total|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:67:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67"
^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:68:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
^
spec/system/admin/adjustments_spec.rb:69:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$0.33", "$-1.67"
^^^^^^^
spec/system/admin/adjustments_spec.rb:71:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:73:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "100",
^
spec/system/admin/adjustments_spec.rb:74:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^
spec/system/admin/adjustments_spec.rb:77:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:80:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST",
^
spec/system/admin/adjustments_spec.rb:81:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$8.00"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:81:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:85:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST",
^
spec/system/admin/adjustments_spec.rb:86:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$120"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67"
^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:97:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:98:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
^
spec/system/admin/adjustments_spec.rb:99:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$0.33", "$-1.67"
^^^^^^^
spec/system/admin/adjustments_spec.rb:103:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "100",
^
spec/system/admin/adjustments_spec.rb:103:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:104:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^
spec/system/admin/adjustments_spec.rb:107:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:110:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST",
^
spec/system/admin/adjustments_spec.rb:111:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$8.00"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:115:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST",
^
spec/system/admin/adjustments_spec.rb:116:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$120"
^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:268:101: C: Layout/LineLength: Line is too long. [105/100]
text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}"
^^^^^
spec/system/admin/bulk_order_management_spec.rb:1036:101: C: Layout/LineLength: Line is too long. [147/100]
expect(page).to have_content "This operation will result in one or more empty orders, which will be cancelled. Do you wish to proceed?"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1060:101: C: Layout/LineLength: Line is too long. [138/100]
it "the user can confirm + wants to send email confirmation : line item is then deleted, order is canceled and email is sent" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1072:101: C: Layout/LineLength: Line is too long. [134/100]
it "the user can confirm + uncheck the restock option: line item is then deleted and order is canceled without retocking" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100]
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100]
with_options: [schedule_of_other_managed_distributor.name]
^
spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:598:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
expect(page).to have_link "Resend Confirmation", href: spree.resend_admin_order_path(order)
^
spec/system/admin/order_spec.rb:599:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
href: spree.resend_admin_order_path(order)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:616:101: C: [Corrected] Layout/LineLength: Line is too long. [105/100]
expect(page).to have_link "Cancel Order", href: spree.fire_admin_order_path(order, e: 'cancel')
^^^^^
spec/system/admin/order_spec.rb:618:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
href: spree.fire_admin_order_path(order, e: 'cancel')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100]
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/system/admin/product_import_spec.rb:573:101: C: Layout/LineLength: Line is too long. [106/100]
expect(page).to have_content "line 4: Cabbage - On_hand incorrect value - On_demand incorrect value"
^^^^^^
spec/system/admin/product_import_spec.rb:574:101: C: Layout/LineLength: Line is too long. [108/100]
expect(page).to have_content "line 5: Aubergine - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^
spec/system/admin/product_import_spec.rb:583:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type",
^^
spec/system/admin/product_import_spec.rb:585:101: C: Layout/LineLength: Line is too long. [106/100]
csv << ["Beans", "User Enterprise", "Vegetables", "invalid", "3.50", "1", "0.5", "g", "Small Bag",
^^^^^^
spec/system/admin/product_import_spec.rb:587:101: C: Layout/LineLength: Line is too long. [103/100]
csv << ["Potatoes", "User Enterprise", "Vegetables", "6", "6", "invalid", "5", "kg", "Big Bag",
^^^
spec/system/admin/product_import_spec.rb:589:101: C: Layout/LineLength: Line is too long. [106/100]
csv << ["Cabbage", "User Enterprise", "Vegetables", "invalid", "1.5", "invalid", "1", "kg", "Bag",
^^^^^^
spec/system/admin/product_import_spec.rb:591:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["Aubergine", "User Enterprise", "Vegetables", nil, "1.5", "invalid", "1", "kg", "Bag",
^^
spec/system/admin/product_import_spec.rb:607:101: C: Layout/LineLength: Line is too long. [114/100]
expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:608:101: C: Layout/LineLength: Line is too long. [116/100]
expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:617:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type",
^^
spec/system/admin/product_import_spec.rb:619:101: C: Layout/LineLength: Line is too long. [101/100]
csv << ["Beans", "User Enterprise", "Vegetables", "-1", "3.50", "1", "500", "g", "Small Bag",
^
spec/system/admin/product_import_spec.rb:641:101: C: Layout/LineLength: Line is too long. [114/100]
expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:642:101: C: Layout/LineLength: Line is too long. [116/100]
expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100]
preferred_unit_from_list: "kg"),
^
spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100]
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^
1478 files inspected, 173 offenses detected, 106 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
e546a6b583
Safely autocorrect Layout/LineContinuationSpacing
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................C............................................................................
Offenses:
spec/system/admin/enterprise_fees_spec.rb:52:46: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
fill_in "#{prefix}_calculator_attributes"\
^
spec/system/admin/enterprise_fees_spec.rb:57:58: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
expect(page).to have_selector("##{prefix}_calculator"\
^
spec/system/admin/enterprise_fees_spec.rb:142:43: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
"#{prefix}_calculator_attributes_"\
^
spec/system/admin/order_spec.rb:646:84: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
accept_alert "An invoice for this order will be sent to the customer. "\
^
1478 files inspected, 4 offenses detected, 4 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
948b287fd6
Safely autocorrect Layout/LeadingCommentSpace
...
Inspecting 1478 files
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................
Offenses:
spec/system/admin/enterprises_spec.rb:204:5: C: [Corrected] Layout/LeadingCommentSpace: Missing space after #.
#using "find" as fields outside of the screen and are not visible
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
9155614501
Safely autocorrect Layout/IndentationConsistency
...
Inspecting 1478 files
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.......C......................................................................
Offenses:
spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb:84:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"#order_cycle_incoming_exchange_1_variants_#{initial_variants.last.id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:784:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method_id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:791:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"order_cycle_selected_distributor_shipping_method_ids_#{distributor_shipping_method_id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:818:15: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
I18n.t("admin.product_import.product_headings.#{heading}").upcase
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 4 offenses detected, 4 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
dce02160d4
Safely autocorrect Layout/HashAlignment
...
Inspecting 1478 files
...................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................................................................................................................................................................................................................C......................CC....................C......................................................
Offenses:
app/controllers/spree/users_controller.rb:53:19: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100]
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^
spec/models/enterprise_spec.rb:906:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
permissions: [permission])
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:19:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
code: nil, created_manually: true)
^^^^^^^^^
spec/system/admin/order_spec.rb:708:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributors: [distributor1])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:45:4: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributors: [distributor4, distributor5])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:249:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
line_items_count: 0)
^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:254:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
line_items_count: 1)
^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100]
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/system/admin/tag_rules_spec.rb:145:37: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
count: 4
^^^^^^^^
1478 files inspected, 11 offenses detected, 9 offenses corrected
2023-07-24 09:14:13 +09:00
Filipe
8bd25f9711
Merge pull request #11251 from jibees/11207-update-all-products-report-to-include-stock
...
Admin, Products & Inventory reports: add `on_hand` and `on_demand?` columns by default ; mark `Inventory (on hand)` report as deprecated
2023-07-21 17:07:00 +01:00
Filipe
0d0beda887
Merge pull request #11084 from abdellani/update_invoice_status_automatically
...
set invoice status automatically after creation
2023-07-21 16:21:05 +01:00
jibees
5142efc86e
Merge pull request #11257 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.2
...
chore(deps-dev): bump knapsack_pro from 5.3.1 to 5.3.2
2023-07-21 14:36:46 +02:00
Cillian O'Ruanaidh
0c0b85f4c4
Validate voucher code doesn't contain new line characters
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
0d0df82522
Validate voucher code length doesn't exceed the database column length i.e. 255 characters
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
5d66c8a578
Strip leading and trailing whitespace from voucher codes before validation
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
535ca954de
Voucher codes should only be a single line so use a text field instead of a textarea
2023-07-21 12:12:36 +01:00
dependabot[bot]
df633f7855
chore(deps): bump aws-sdk-s3 from 1.126.0 to 1.131.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.126.0 to 1.131.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-21 09:17:05 +00:00
dependabot[bot]
44551766c5
chore(deps-dev): bump knapsack_pro from 5.3.1 to 5.3.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.1 to 5.3.2.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.1...v5.3.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-21 09:15:41 +00:00
jibees
6ddb3cd644
Merge pull request #11252 from filipefurtad0/invoices_missing_translations
...
Adds missing key
2023-07-21 10:42:35 +02:00
Jean-Baptiste Bellet
a094a89c09
Mark "Inventory (on hand)" report as deprecated
...
Co-Authored-By: Maikel <maikel@email.org.au >, @dacook
2023-07-21 09:27:07 +02:00
Jean-Baptiste Bellet
28fe479f53
Unhide on_demand & on_hand columns by default
...
+ update specs as well
2023-07-21 09:27:07 +02:00
David Cook
b464e51ba4
Merge pull request #11246 from mkllnk/engine-ruby-version
...
Add Ruby version to engines for Rubocop
2023-07-21 15:03:01 +10:00
Gaetan Craig-Riou
f9afc0ba96
Fix rubocop warning
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
196b674bf1
Add system spec to test filtering by product
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
2fff77b2ee
Report, add filtering by product for line items
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
ec78de7cea
Add product dropdown on Order and Fulfillment reports
...
It includes loading the selected product to populate the dropdown
when needed.
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
b4a3aaab19
Add select variant stimulus controller
...
This is similar to variantAutocomplete directive used on the
new order page. It doesn't have all the same feature, but it's a
start
2023-07-21 14:51:40 +10:00
Maikel Linke
54f39668ba
Remove unused, outdated dependency declarations
...
The Gemfile of the main app is used.
2023-07-21 14:13:27 +10:00
Maikel Linke
a01aa8849c
Add Ruby version to engines for Rubocop
...
> This ensures that RuboCop is using the same Ruby version as the gem.
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
2023-07-21 14:13:26 +10:00
Maikel
022225581f
Merge pull request #11249 from openfoodfoundation/dependabot/bundler/bugsnag-6.26.0
...
chore(deps): bump bugsnag from 6.25.2 to 6.26.0
2023-07-21 09:58:56 +10:00
Maikel
5c8939fb69
Merge pull request #11248 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.1
...
chore(deps-dev): bump knapsack_pro from 5.3.0 to 5.3.1
2023-07-21 09:58:07 +10:00
Maikel
9ba9519622
Merge pull request #11241 from dacook/rubocop-layout-1
...
Fix Rubocop Layout violations - 1
2023-07-21 09:57:12 +10:00
filipefurtad0
4b64b9085c
Adds missing keys
2023-07-20 19:18:27 +01:00
Filipe
6199d2c957
Merge pull request #11218 from openfoodfoundation/dependabot/bundler/stripe-8.6.0
...
chore(deps): bump stripe from 8.5.0 to 8.6.0
2023-07-20 12:56:42 +01:00
dependabot[bot]
a0cc07dc35
chore(deps): bump bugsnag from 6.25.2 to 6.26.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.25.2 to 6.26.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/commits )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-20 09:41:23 +00:00
dependabot[bot]
afd854d32a
chore(deps-dev): bump knapsack_pro from 5.3.0 to 5.3.1
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.0 to 5.3.1.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.0...v5.3.1 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-20 09:39:40 +00:00
David Cook
c112fad4b2
Update all locales with the latest Transifex translations
2023-07-20 14:11:16 +10:00
David Cook
19ee2b50c2
Safely autocorrect Layout/FirstHashElementIndentation
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................
Offenses:
spec/services/products_renderer_spec.rb:73:11: C: [Corrected] Layout/FirstHashElementIndentation: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
"#{[:name, :meta_keywords, :variants_display_as, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:76:9: C: [Corrected] Layout/FirstHashElementIndentation: Indent the right brace the same as the first position after the preceding left parenthesis.
} })
^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 14:05:16 +10:00
David Cook
aa124511de
Safely autocorrect Layout/FirstArgumentIndentation
...
Inspecting 1478 files
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/system/admin/orders_spec.rb:485:11: C: [Corrected] Layout/FirstArgumentIndentation: Indent the first argument one step more than page.find(.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:493:11: C: [Corrected] Layout/FirstArgumentIndentation: Indent the first argument one step more than page.find(.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 14:03:31 +10:00
David Cook
6859200339
Safely autocorrect Layout/ExtraSpacing
...
Inspecting 1478 files
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C......................
Offenses:
spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
let(:product_property) { create(:product_property, property: property) }
^
spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
^
spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
expect(page).to have_no_selector 'hub', text: d2.name
^^
1478 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-20 14:01:44 +10:00
David Cook
bc330b69a5
Safely autocorrect Layout/EmptyLinesAroundBlockBody
...
Inspecting 1478 files
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...............................................................................
Offenses:
spec/system/admin/order_cycles/list_spec.rb:191:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:59:53 +10:00
David Cook
6fa9165cc2
Safely autocorrect Layout/EmptyLines
...
Inspecting 1478 files
..............................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/spree/payment.rb:100:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:58:00 +10:00
David Cook
159a0d391c
Safely autocorrect Layout/ClosingParenthesisIndentation
...
Inspecting 1478 files
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/system/admin/orders_spec.rb:486:9: C: [Corrected] Layout/ClosingParenthesisIndentation: Align ) with (.
).to be_checked
^
spec/system/admin/orders_spec.rb:494:9: C: [Corrected] Layout/ClosingParenthesisIndentation: Align ) with (.
).to_not be_checked
^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 13:56:13 +10:00
David Cook
0030343897
Safely autocorrect Layout/BlockEndNewline
...
Inspecting 1478 files
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:87: C: [Corrected] Layout/BlockEndNewline: Expression at 127, 87 should be on its own line.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:128:1: C: [Corrected] Layout/BlockAlignment: } at 128, 0 is not aligned with let!(:ef_packing) { at 126, 8.
}
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:129:91: C: [Corrected] Layout/BlockEndNewline: Expression at 129, 91 should be on its own line.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:130:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:130:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:131:1: C: [Corrected] Layout/BlockAlignment: } at 131, 0 is not aligned with let!(:ef_transport) { at 129, 8.
}
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:131:95: C: [Corrected] Layout/BlockEndNewline: Expression at 131, 95 should be on its own line.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:133:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:133:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:134:1: C: [Corrected] Layout/BlockAlignment: } at 134, 0 is not aligned with let!(:ef_fundraising) { at 132, 8.
}
^
spec/system/admin/orders_spec.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:shipping_method_with, :pickup, name: "delivery",
^
spec/system/admin/orders_spec.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
create(:shipping_method_with, :pickup, name: "delivery",
spec/system/admin/orders_spec.rb:45:45: C: [Corrected] Layout/BlockEndNewline: Expression at 45, 45 should be on its own line.
distributors: [distributor4, distributor5]) }
^
spec/system/admin/orders_spec.rb:46:1: C: [Corrected] Layout/BlockAlignment: } at 46, 0 is not aligned with let!(:shipping_method2) { at 43, 2.
}
^
1478 files inspected, 16 offenses detected, 16 offenses corrected
2023-07-20 13:54:30 +10:00
David Cook
7cbe1d94ad
Safely autocorrect Layout/BlockAlignment
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................
Offenses:
spec/services/products_renderer_spec.rb:28:7: C: [Corrected] Layout/BlockAlignment: } at 28, 6 is not aligned with let!(:product_cherries) { at 25, 4.
}
^
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:52:44 +10:00
David Cook
5a3a4a041f
Safely autocorrect Layout/ArrayAlignment
...
Inspecting 1478 files
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................CC.........................................C.................................
Offenses:
spec/system/admin/customers_spec.rb:40:13: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100]
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:742:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
different_shipping_method_for_distributor1]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:48:33: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
distributor3, distributor4],
^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:21:37: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
product_with_fee.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 5 offenses detected, 4 offenses corrected
2023-07-20 13:50:55 +10:00
David Cook
bcfa70af4e
Safely autocorrect Layout/ArgumentAlignment
...
Inspecting 1478 files
...................................................................................................................................................C..C.......................................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..........................................C................................................................................................................................................................................................C..................................................................C............C..................CC............................................C......C..........................
Offenses:
app/controllers/spree/users_controller.rb:37:15: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "alert", message: t('devise.failure.already_registered') })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:52:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "success", ...
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:28:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "success", message: t("devise.confirmations.send_instructions") })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:54:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
inverse_of: :distributor, foreign_key: :distributor_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:56:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
inverse_of: :distributor, foreign_key: :distributor_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:118:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
format: { ...
^^^^^^^^^
spec/lib/reports/packing/packing_report_spec.rb:60:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
product: create(:simple_product, name: "visible", supplier: supplier1))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/packing/packing_report_spec.rb:64:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
product: create(:simple_product, name: "not visible", supplier: supplier2))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:100:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:118:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/system/admin/bulk_order_management_spec.rb:268:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:793:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
retry: 3 do
^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:103:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_tax_category_id"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:129:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:133:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:160:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:221:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
selected: 'Second Distributor'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:232:43: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
'Flat Rate (per order)', message, 0
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:148:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to start_with oc_open_at.strftime("%Y-%m-%d %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:161:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to eq oc_open_at.strftime("%Y-%m-13 %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:189:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to eq test_value.to_datetime.strftime("%Y-%m-%d %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
with_options: [schedule_of_other_managed_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100]
with_options: [schedule_of_other_managed_distributor.name]
^
spec/system/admin/order_cycles/simple_spec.rb:623:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:35: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
preferred_unit_from_list: "kg"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100]
preferred_unit_from_list: "kg"),
^
spec/system/consumer/shopping/products_spec.rb:98:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100]
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^
1478 files inspected, 45 offenses detected, 32 offenses corrected
2023-07-20 13:48:51 +10:00
David Cook
bb728d97fd
Regenerate Rubocop's TODO file
2023-07-20 13:46:52 +10:00
Maikel
fd05f41349
Merge pull request #11236 from filipefurtad0/BO_out_of_stock_warning
...
Adds assertion on the Out of Stock message
2023-07-20 10:19:41 +10:00
David Cook
cdffeea5cb
Merge pull request #10966 from macanudo527/fix_linelength_bundle3
...
Fix Layout/LineLength - Bundle 3
2023-07-20 10:04:24 +10:00
Maikel
f82222d97c
Merge pull request #11239 from filipefurtad0/missing_translation_on_invoices_tab
...
Fixes missing translation on Invoices tab
2023-07-20 08:42:36 +10:00
filipefurtad0
8f8e28f816
Fixes missing translation on Invoices tab
...
Adds invoices to en.yml, fixing #11237
2023-07-19 18:11:45 +01:00
filipefurtad0
537e225c84
Adds assertion on the Out of Stock message
2023-07-19 16:28:06 +01:00
Jean-Baptiste Bellet
1750575f8c
Need to update tab before updating panel since we retrieve panel from tab
2023-07-19 16:28:10 +02:00
Jean-Baptiste Bellet
695f76d3b6
Update format to be solve prettier warnings
2023-07-19 16:28:03 +02:00
Jean-Baptiste Bellet
0065ece6a6
Show vouchers panel only if enterprise sells products (own or any)
2023-07-19 16:02:16 +02:00
jibees
49a192eacc
Merge pull request #11231 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.4
...
chore(deps): bump mini_portile2 from 2.8.2 to 2.8.4
2023-07-19 15:13:50 +02:00
jibees
821e5226fa
Merge pull request #11232 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.0
...
chore(deps-dev): bump knapsack_pro from 5.2.0 to 5.3.0
2023-07-19 15:11:27 +02:00
Jean-Baptiste Bellet
5d4ef5b52c
To test the search by category, we need to use set primary_taxon attr
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
bada2ef4a7
Remove useless spec (will be tested right after)
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
62eaf4a1a9
This spec is not flaky anymore
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
55cad3659f
Simplify products creation
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
6f6de00919
Better naming of argument to not override existing variable...
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
3fab9714f5
Use a constant as the search_key
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
79421f2265
Expect to found the product
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
2697a637a9
Use the OpenFoodNetwork::Permissions helper
...
To retrieve only primary producers
2023-07-19 14:58:40 +02:00
jibees
3245f7ff99
Update app/reflexes/products_reflex.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
b42dfb574b
Delete already imported (and modified) file
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
90c6398197
Simplify and call methods directly via before_reflex
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
b3bdba3a9b
Better use merge! instead of q = q.merge
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
755a1842c2
Simplify to save execution time
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
037589ecda
Add columns translation
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
dec779a357
available_on column has been deleted
...
https://github.com/openfoodfoundation/openfoodnetwork/pull/11136
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
fac02c794c
Search through more attributes than only name
...
Copy/paste from `app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee`
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
010f19cb83
Create a medium height button, and adjust #sort row
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
c378ad1d88
Add "no results found" container
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
5a8a187f54
Add clear search button and action
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
904c7bfacf
Buttons design
...
Remove already defined `$border-radius`
Defined `app/webpacker/css/admin/globals/variables.scss`
Adjust height
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
7b56cbf3d4
Add labels to selectors, and adjust css
...
+ Adjusting filter elements with flex-grow properties
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
333dc11fc1
Manage form params vs. URL params. And replace state with params.
...
"One needs to understand what the source of the params in a reflex is. And there are two sources:
the closest form
the url of the currently displayed page"
Source: https://github.com/stimulusreflex/stimulus_reflex/issues/290#issuecomment-683334963
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
bfe1884ab5
Can filter by categories
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
ef1702188f
Extract filters from 'no products found' logic
...
We still want to display filters if no products found
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
f58cf2d3b2
Can filter by producer
...
Not sur the request nor the `producers` in the reflex should be like this. This is a proof of concept, and should probably be reviewed
Fix linter issues
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
ddfc60c85e
Don't use events, but call the loading controller itself
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
762b777995
Design of the search button
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
51e139b6f1
Create first spec for the new products page
...
Modify comment, and contextualize search (inside search term)
Extract creation of products outside a before block
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
38d0af8ec0
Simplify: don't need to pass through the js controller
...
Use the reflex itself
+ Don't need to create a method that will be called only in the connect
+ Simply code by adding only two lifecycle methods
Actually it seems that all reflex related to products controller should show/hide loading
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9d52f0b20a
Loading spinner should be above content (filters, sort, ...)
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
643897abb2
Add search functionnality
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
c786f300ca
Have a tiny url state management by using replace_state of cable_ready
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
0fd4d892d9
This is now unused: through the js controller only at startup
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
3da6e02192
Call pagination via perPage param: no state to manage, use param
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
61d1f30e04
Rename productsV3 to products: avoid upper|lower case issues
...
This is causing some issues, misunderstandings around case.
Therefore, directly use the Reflex, and lifecycle methods `beforeFetch` and `afterFetch` are called, even if we use the Reflex (and not the js controller methods). This is pretty handy.
+ adds some id to pagination element (https://docs.stimulusreflex.com/guide/reflexes.html#declaring-a-reflex-in-html-with-data-attributes )
Global documentation: https://docs.stimulusreflex.com/guide/reflexes.html
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
574adb88d2
Add a per page component
...
This is still a WIP.
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
0b83dc088d
Separation of concerns: use a loading controller
...
Two different events can be used: `show-loading` and `hide-loading`.
I'm not 100% sure this is the right way to go, but let's try!
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
5aebbe4102
use beforeFetch and afterFetch lifecycle methods
...
+ Move outside `Admin` module the reflex
Therefore, this reflex should be _equivalent_ to its javascript controller: `ProductsV3` (relation is made through names)
Remove unwanted line
Actually call StimulusJS controller instead of calling the reflex itself
In order to have this "showLoading", "hideLoading" behavior.
It seems to be possible to directly use the Reflex itself (use `data-reflex` instead of `data-action`) but I can't make it work: the `stimulus-controller:after` event is never broadcasted/catched (but `stimulus-controller:before` yes...)
Documentation:
https://docs.stimulusreflex.com/guide/reflexes.html#understanding-stimulusreflex-controllers
https://docs.stimulusreflex.com/guide/lifecycle.html#generic-life-cycle-methods
Maybe @dacook if you want to have a look...
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
3b61508652
Be more specific to only apply to the first container, ie. the root one
...
+ Override default position (relative) in order to have loading above
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
47f21cb59e
Add pagination with pagy
...
For `admin_style_v3` use `<` and `>` for next and previous link
instead of `next` and `previous` string
Extract a mixin for a default box-shadow
Maybe this needs to be redefined. Let's see how next things goes.
When a table is followed by a pagination, remove its margin-bottom + border
Finally, design the pagination component
Add sorting/pagination module, on top of table
We use `cablea_ready.replace`, so need to add `#products-content` id
Use a `pagy` partial with reflex action, instead of the legacy one
- revert the legacy one to its previous state
- in reflex, fetch product with page attribute, 1 by default
Move `pagy` into `admin/shared/v3/` to be reusable
+ use fontawesome icons for next and previous page
Remove useless line
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
69cff85577
Change color to EFF1F2
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9b92c25879
Add a section for specific rules for both admin-menu and sub-menu
...
+ change height for border bottom on selected/hovered menu
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9762819aa8
Use the right color
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
1f3d41972f
Add same padding than #admin-menu,#sub-menu li a in order to align
...
content (header, navigation, content) on both left and right
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
2892301336
Factorize menu and submenu into same definition
...
as they are the same, expect the font-size
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
24c045a09c
Reduce padding
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
a8088ae231
Create a pseudo element to add a line under the menu item
...
- Increase top menu underline height to 3px
- reduce underline width to same width of label
2023-07-19 14:58:39 +02:00
Konrad
d99ac35824
Merge pull request #11105 from jibees/11098-summary-step-order-details-line-break-on-currency-symbol-and-lettering
...
Checkout summary: avoid carriage return on price
2023-07-19 13:00:08 +02:00
Filipe
91e2e447c0
Merge pull request #11175 from jibees/11171-checkout-step-3-delivery-details-are-showing-bill-address-instead-of-delivery-address
...
Checkout, Summary step: Display the ship/delivery address (instead of the billing one)
2023-07-19 11:36:19 +01:00
Filipe
843bcaa500
Merge pull request #11184 from rioug/11183-fix-delete-voucher-tax-excl-price
...
[vouchers] fix delete voucher when tax excluded from price
2023-07-19 11:24:25 +01:00
dependabot[bot]
314c02a92b
chore(deps-dev): bump knapsack_pro from 5.2.0 to 5.3.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.2.0 to 5.3.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.2.0...v5.3.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:31:24 +00:00
dependabot[bot]
6c323c82d5
chore(deps): bump mini_portile2 from 2.8.2 to 2.8.4
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.2 to 2.8.4.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.2...v2.8.4 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:27:32 +00:00
Jean-Baptiste Bellet
731fb3c0b3
Update cable_ready and stimulus_reflex as well
...
In order to reflect the one used in package.json
2023-07-19 09:05:31 +02:00
dependabot[bot]
385f3964ad
chore(deps): bump stimulus_reflex from 3.5.0-rc2 to 3.5.0-rc3
...
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex ) from 3.5.0-rc2 to 3.5.0-rc3.
- [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases )
- [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits )
---
updated-dependencies:
- dependency-name: stimulus_reflex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:05:31 +02:00
jibees
8475a31ebb
Merge pull request #11228 from openfoodfoundation/dependabot/npm_and_yarn/word-wrap-1.2.4
...
chore(deps): bump word-wrap from 1.2.3 to 1.2.4
2023-07-19 08:51:34 +02:00
dependabot[bot]
dd7e6d1a19
chore(deps): bump word-wrap from 1.2.3 to 1.2.4
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 02:14:43 +00:00
Neal Chambers
c1095c3616
Update .rubocop_todo.yml
2023-07-19 08:43:36 +09:00
Neal Chambers
728926cc9a
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
Filipe
40db81f056
Merge pull request #11150 from macanudo527/fix_admin_class_size
...
Fix Metrics/ClassSize
2023-07-18 19:10:03 +01:00
Filipe
15282f9738
Merge pull request #11115 from abdellani/fix-enterprise-users-should-have-access-to-invoices
...
authorize enterprise users to access invoices page
2023-07-18 16:42:00 +01:00
jibees
11b2d911d2
Merge pull request #11217 from openfoodfoundation/dependabot/bundler/rubocop-1.54.2
...
chore(deps-dev): bump rubocop from 1.54.1 to 1.54.2
2023-07-18 17:31:17 +02:00
jibees
bbdeb0c9ab
Merge pull request #11213 from openfoodfoundation/dependabot/bundler/rswag-specs-2.10.1
...
chore(deps-dev): bump rswag-specs from 2.9.0 to 2.10.1
2023-07-18 17:29:37 +02:00
jibees
4e29fcba64
Merge pull request #11210 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.5
...
chore(deps): bump @floating-ui/dom from 1.4.4 to 1.4.5
2023-07-18 17:14:41 +02:00
dependabot[bot]
a975b78816
chore(deps-dev): bump rubocop from 1.54.1 to 1.54.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.54.1 to 1.54.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.54.1...v1.54.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 15:08:00 +00:00
dependabot[bot]
02b1c6dd2d
chore(deps-dev): bump rswag-specs from 2.9.0 to 2.10.1
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 15:07:21 +00:00
jibees
af365c6b79
Merge pull request #11215 from openfoodfoundation/dependabot/bundler/rswag-api-2.10.1
...
chore(deps): bump rswag-api from 2.9.0 to 2.10.1
2023-07-18 17:06:07 +02:00
jibees
f054b74c7d
Merge pull request #11216 from openfoodfoundation/dependabot/bundler/rswag-ui-2.10.1
...
chore(deps): bump rswag-ui from 2.9.0 to 2.10.1
2023-07-18 17:05:15 +02:00
Filipe
adc5692bc5
Merge pull request #11182 from filipefurtad0/profile_change_spec
...
Adds spec for profile change
2023-07-18 16:02:39 +01:00
jibees
1d03f7a009
Merge pull request #11224 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.2.0
...
chore(deps-dev): bump knapsack_pro from 5.1.2 to 5.2.0
2023-07-18 16:30:45 +02:00
dependabot[bot]
74f8f9dd52
chore(deps): bump rswag-api from 2.9.0 to 2.10.1
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:58 +00:00
dependabot[bot]
dae690ae5c
chore(deps): bump rswag-ui from 2.9.0 to 2.10.1
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:55 +00:00
dependabot[bot]
53b1188a43
chore(deps): bump @floating-ui/dom from 1.4.4 to 1.4.5
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.4 to 1.4.5.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.5/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:47 +00:00
dependabot[bot]
6c02e1c05d
chore(deps-dev): bump knapsack_pro from 5.1.2 to 5.2.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.1.2 to 5.2.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.2...v5.2.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 09:18:55 +00:00
Gaetan Craig-Riou
a5b2bc6293
Per review, Refactor VoucherAdjustmentsService
...
Change #calculate to #update and clean up internal code
2023-07-18 15:16:21 +10:00
Gaetan Craig-Riou
a584f9aaec
Refactor VoucherAdjustmentsService
...
It's more inline with existing coding style
2023-07-18 14:39:01 +10:00
David Cook
46b27b2d9d
Number release steps
...
There are three distinct parts to the process, so I thought it worth giving them an identifying number.
2023-07-18 09:34:28 +10:00
Neal Chambers
8fc0a20249
Add Additional Test for Model Creation
2023-07-18 08:17:34 +09:00
Neal Chambers
ba862bc4b7
Add tests for Enterprise Fees Bulk Update
2023-07-18 08:17:34 +09:00
Neal Chambers
186d7a2f54
Move and Rename BulkUpdateForm
2023-07-18 08:17:34 +09:00
David Cook
9b16c1171f
Remove redundant returns
...
The return value of active record validations doesn't actually do anything. A record is 'valid?' if @errors is empty.
2023-07-18 08:17:34 +09:00
Neal Chambers
521af70959
Add Strong Params to Enterprise Fees Form
2023-07-18 08:17:34 +09:00
Neal Chambers
9e17b80ea9
Update .rubocop_todo.yml
2023-07-18 08:17:34 +09:00
Neal Chambers
fb1ae855c2
Fix Metrics/ClassLength
2023-07-18 08:17:34 +09:00
filipefurtad0
e14bc5e642
Adds comments on producer_profile_only attribute
...
Fixing typo
2023-07-17 15:06:02 +01:00
filipefurtad0
16477cad51
Adds spec for profile change (2)
...
via enterprises path
2023-07-17 15:06:02 +01:00
filipefurtad0
e0be25f927
Adds spec for profile change
...
via admin path
2023-07-17 15:06:02 +01:00
Jean-Baptiste Bellet
1cf647e04b
Avoid line-break by wrapping into nowrap element
2023-07-17 14:00:48 +02:00
Jean-Baptiste Bellet
776b9adc72
Display shipping address in summary step, instead of the billing one
...
+ update specs accordingly
2023-07-17 09:37:05 +02:00
Jean-Baptiste Bellet
f177258444
Randomize also city and zipcode for randomized address
2023-07-17 09:33:29 +02:00
filipefurtad0
bfb2fc528e
Update all locales with the latest Transifex translations
2023-07-14 17:37:22 +01:00
dependabot[bot]
654601f4b2
chore(deps): bump stripe from 8.5.0 to 8.6.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.5.0 to 8.6.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.5.0...v8.6.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-14 09:09:19 +00:00
Gaetan Craig-Riou
0e0850ef49
Add specs to cover re calculation
...
It is important that the calculated voucher adjustments don't change
if they are recalculated and it is equally important that they are
updated if the order has changed
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
5a59396a41
Remove call to VoucherAdjustmentService when creating a voucher
...
Voucher will be automatically applied when the order transition to
the confirmation step. No need to do the work twice.
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
3d9542fec2
Per review, rename amount to adjustment_amount
...
It was confusing as I was re assigning a variable given as a parameter
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
41271192e1
Per review, Makes quantity change more explicit
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
751056ba39
As per review comment, spell out voucher code when entering a voucher
...
Plus, update other related spec to be consistent
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
789ce39ff4
Fixing Rubocop errors
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
a8062e951a
Add a scenario to make sure voucher adjustment a recalculated
...
This is specificly for voucher with a tax component, but it will
also become relevant for percentage based voucher.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
edabc56b5c
Add voucher calculation after updating an order
...
This is to make sure the voucher are recalculated when a customer
update the order content from the `/cart` page. This is tested
with system test
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
ca7dcb82b8
Apply voucher after transitionning to the confirmation step
...
Testing that VoucherAdjustmentsService.calculate has been called after a
transition doens't work, skipping test for now.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
366cca7984
Prevent voucher adjustment from bein updated when update is called
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
87790b29ae
Fix VoucherAdjustmentsService.calculate so we can call it mutiple time
...
It now uses `order.pre_discount_total` to make any calculation, that
means you can call it multiple time and you will still get the same
adjustment amount, included_tax and tax adjustment when needed. This
is assuming nothing changed on the order.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
60c0c54eb2
Update create_adjustment to create with an amount of 0
...
Amount calculation is handled by VoucherAdjustmentService.calculate
2023-07-14 14:47:03 +10:00
Matt-Yorkley
04bbea53e1
Move voucher processing out of checkout controller
2023-07-14 14:46:16 +10:00
Gaetan Craig-Riou
dc711bde78
Fix voucher adjustment delete
...
When using a voucher with tax not incluced in price, we need to delete
both the voucher adjustment and the tax adjustment
2023-07-14 13:37:45 +10:00
Konrad
bddc10626b
Merge pull request #11148 from cillian/fix-duplicate-rows-in-customer-addresses-report
...
Don't return duplicate rows in the customer addresses report
2023-07-13 20:32:01 +02:00
Filipe
9e0aa1854f
Merge pull request #11159 from abdellani/remove-split-checkout-from-feature_toggle
...
Remove split checkout from feature toggle
2023-07-13 17:20:18 +01:00
Filipe
308ce9263d
Merge pull request #11170 from jibees/11160-bulk-actions-function-not-working-on-safari-mac-browser
...
Admin, Orders: Make bulk actions dropdown re-enabled for Safari browser
2023-07-13 17:17:18 +01:00
Filipe
2f8a056bee
Merge pull request #11187 from jibees/10975-white-label-remember-custom-tab-activation-after-error-message
...
Admin, White Label: check the custom tab checkbox if any errors on custom tab (ie. title is blank)
2023-07-13 16:43:18 +01:00
Filipe
60c75097d3
Merge pull request #11145 from mkllnk/dfc-create-response
...
DFC API return SuppliedProduct after creation
2023-07-13 16:15:22 +01:00
Filipe
448d5ea017
Merge pull request #11135 from Matt-Yorkley/vouchers
...
Vouchers part 2
2023-07-13 12:50:32 +01:00
jibees
9f86218a83
Merge pull request #11202 from openfoodfoundation/dependabot/bundler/view_component-3.4.0
...
chore(deps): bump view_component from 3.3.0 to 3.4.0
2023-07-12 16:00:48 +02:00
dependabot[bot]
e03ffa0405
chore(deps): bump view_component from 3.3.0 to 3.4.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.3.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-12 09:25:11 +00:00
jibees
f22b8db462
Merge pull request #11191 from openfoodfoundation/dependabot/npm_and_yarn/semver-5.7.2
...
chore(deps): bump semver from 5.7.1 to 5.7.2
2023-07-11 17:38:28 +02:00
dependabot[bot]
90ad6ce19d
chore(deps): bump semver from 5.7.1 to 5.7.2
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-11 09:43:07 +00:00
Matt-Yorkley
4884a8c368
Merge pull request #11179 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.1
...
chore(deps): bump cable_ready from 5.0.0 to 5.0.1
2023-07-11 10:42:37 +01:00
David Cook
d03b88cf83
Rename variables
...
To make it clear they are arrays
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
0fdf7876a6
Instanciate instance variable + use spread operator to be more concise
...
and efficient ;)
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
4bcba86fc8
Avoid error when testing through jest about removing event listenner
...
Avoid:
```
TypeError: Cannot read properties of null (reading 'removeEventListener')
at extended.disconnect (/home/runner/work/openfoodnetwork/openfoodnetwork/app/webpacker/controllers/dropdown_controller.js:32:14)
at Context.disconnect (/home/runner/work/openfoodnetwork/openfoodnetwork/node_modules/stimulus/dist/stimulus.umd.js:1441:25)
```
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
6143f4ce6f
Use dropdown controller to manager actions dropdown in orders page
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
7084c53f38
Do not display menu is the dropdown is 'disabled'
...
ie. classList contains `disabled`
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
02aea989be
Add on_click_outside behavior on dropdown_controller
...
"It's a Surprise Tool That Will Help Us Later"
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
d78af187e0
Allow dropdown controller to toggle more than one class
...
"It's a Surprise Tool That Will Help Us Later"
2023-07-11 10:48:51 +02:00
Mohamed ABDELLANI
4b003aa08b
replace status:status with cancelled:boolean on invoice model
2023-07-11 09:15:25 +01:00
David Cook
bb1d053825
Merge pull request #11162 from dacook/DropSpreePromotionTables
...
Drop unused Spree Promotion Tables
2023-07-11 10:16:45 +10:00
Jean-Baptiste Bellet
a8b9d9d8af
Check the custom tab checkbox if any errors (ie. title is blank)
2023-07-10 16:31:33 +02:00
Gaetan Craig-Riou
9f1b4f56c0
Merge pull request #11181 from openfoodfoundation/dependabot/npm_and_yarn/tough-cookie-4.1.3
...
chore(deps): bump tough-cookie from 4.0.0 to 4.1.3
2023-07-10 12:03:02 +10:00
David Cook
b6d10df332
DropSpreePromotionTables
2023-07-10 10:51:44 +10:00
dependabot[bot]
c299f891e0
chore(deps): bump tough-cookie from 4.0.0 to 4.1.3
...
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie ) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases )
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md )
- [Commits](https://github.com/salesforce/tough-cookie/compare/v4.0.0...v4.1.3 )
---
updated-dependencies:
- dependency-name: tough-cookie
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-09 11:11:55 +00:00
Jean-Baptiste Bellet
dab595f17f
Update all locales with the latest Transifex translations
2023-07-07 17:11:40 +02:00
Filipe
f0bcb79c09
Merge pull request #11169 from openfoodfoundation/11164-admin-orders-actions-dropdown-is-not-well-placed
...
Fix container issues introduced by #11123
2023-07-07 11:15:14 +01:00
jibees
967c5a99c3
Merge pull request #11167 from openfoodfoundation/dependabot/bundler/faraday-2.7.10
...
chore(deps): bump faraday from 2.7.9 to 2.7.10
2023-07-07 11:50:01 +02:00
jibees
72fa132c17
Merge pull request #11172 from openfoodfoundation/dependabot/bundler/sanitize-6.0.2
...
chore(deps): bump sanitize from 6.0.1 to 6.0.2
2023-07-07 11:44:16 +02:00
dependabot[bot]
2310c665c3
chore(deps): bump cable_ready from 5.0.0 to 5.0.1
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:35:52 +00:00
dependabot[bot]
9f539df5e0
chore(deps): bump sanitize from 6.0.1 to 6.0.2
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: sanitize
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:31 +00:00
dependabot[bot]
74ef681607
chore(deps): bump faraday from 2.7.9 to 2.7.10
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.9 to 2.7.10.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.9...v2.7.10 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:22 +00:00
David Cook
17da66b72a
Update contents of variable directly
...
Also, it makes the line shorter, allowing us to use one-line if syntax :)
2023-07-07 14:22:36 +10:00
Gaetan Craig-Riou
fb3c99e52c
Merge pull request #11121 from filipefurtad0/cart_state_orders_not_appearing_orders_page
...
Cart state orders not appearing orders page
2023-07-07 09:27:36 +10:00
Matt-Yorkley
eb71c65fc0
Merge pull request #11138 from Matt-Yorkley/variant-timestamps
...
Add timestamps to variants table
2023-07-06 18:22:19 +01:00
Mohamed ABDELLANI
f68064480a
authorize distributor manager to generate invoices
2023-07-06 17:36:13 +01:00
Maikel Linke
11a4cd8613
Protect invoicing against unauthorized use
...
This could be optimised for performance but this was the simplest way
and we can work on it if performance becomes a problem.
2023-07-06 17:36:13 +01:00
Maikel Linke
15c30246a5
Allow to see only invoices of managed enterprises
2023-07-06 17:36:13 +01:00
Maikel Linke
46410b5be2
Test the right invoices controller
...
I was wondering why the spec didn't work and then I noticed that it was
testing the wrong controller and passing the wrong parameter.
2023-07-06 17:36:13 +01:00
Maikel Linke
85002d3804
Spec bug allowing any enterprise to view invoices
2023-07-06 17:36:13 +01:00
Maikel Linke
145696aa7f
Create only used test data
...
The `params` and the user are created before the request. But, for
example, the enterprise user doesn't need creating when testing
permissions of the normal user.
2023-07-06 17:36:13 +01:00
Mohamed ABDELLANI
3a9a023dea
authorize enterprise users to access invoices page
2023-07-06 17:36:13 +01:00
Matt-Yorkley
bbf53133cb
Add timestamps to variants table
2023-07-06 16:16:03 +01:00
jibees
2e9442a7ab
Merge pull request #11127 from openfoodfoundation/dependabot/bundler/vcr-6.2.0
...
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
2023-07-06 16:43:49 +02:00
dependabot[bot]
de384ac261
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
...
Bumps [vcr](https://github.com/vcr/vcr ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/vcr/vcr/releases )
- [Changelog](https://github.com/vcr/vcr/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vcr/vcr/compare/v6.1.0...v6.2.0 )
---
updated-dependencies:
- dependency-name: vcr
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 14:22:55 +00:00
Filipe
ba1ba6dbec
Merge pull request #11092 from mkllnk/bye-datadog
...
Remove datadog gem, too expensive
2023-07-06 15:20:20 +01:00
Filipe
99ed019413
Merge pull request #11136 from Matt-Yorkley/remove-available-on
...
Remove :available_on attribute from Product
2023-07-06 15:20:08 +01:00
jibees
3f070d7152
Merge pull request #11166 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.4
...
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
2023-07-06 16:13:35 +02:00
jibees
5f54c7fe56
Merge pull request #11146 from openfoodfoundation/dependabot/bundler/rails-7.0.6
...
chore(deps): bump rails from 7.0.5 to 7.0.6
2023-07-06 16:04:16 +02:00
jibees
9c035c6114
Merge pull request #11128 from openfoodfoundation/dependabot/bundler/view_component-3.3.0
...
chore(deps): bump view_component from 3.2.0 to 3.3.0
2023-07-06 16:00:51 +02:00
Matt-Yorkley
42a3087cdb
Remove :available_on attribute from Product class
2023-07-06 14:36:35 +01:00
Jean-Baptiste Bellet
6ee388fe51
Fix container issues
2023-07-06 11:41:54 +02:00
dependabot[bot]
5c56c9b60b
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 09:10:25 +00:00
David Cook
05a22b80bc
Merge pull request #11123 from dacook/buu-products-table
...
[admin_style_v3] Products table with variants
2023-07-06 09:37:31 +10:00
Filipe
39b597096c
Merge pull request #11137 from Matt-Yorkley/remove-product-permalink
...
Remove :permalink attribute from Product
2023-07-05 18:35:48 +01:00
Matt-Yorkley
652beac73f
Drop valid? check from zero_priced_order? method
2023-07-05 15:31:05 +01:00
Mohamed ABDELLANI
17b71b0f8d
remove split checkout context from customer spec
...
We don't need to enable split checkout, as this is default and unique mode.
2023-07-05 14:54:07 +01:00
Mohamed ABDELLANI
a89451e667
remove splitcheckout from feature toggle list
2023-07-05 14:53:40 +01:00
jibees
de34b9b109
Merge pull request #11142 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.3
...
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
2023-07-05 14:53:53 +02:00
dependabot[bot]
2a059fd879
chore(deps): bump rails from 7.0.5 to 7.0.6
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 12:52:51 +00:00
jibees
9205aafbd9
Merge pull request #11147 from openfoodfoundation/dependabot/bundler/faraday-2.7.9
...
chore(deps): bump faraday from 2.7.6 to 2.7.9
2023-07-05 14:52:00 +02:00
jibees
409cf54a45
Merge pull request #11152 from openfoodfoundation/dependabot/bundler/state_machines-activerecord-0.9.0
...
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
2023-07-05 14:49:08 +02:00
jibees
24f9770acc
Merge pull request #11154 from openfoodfoundation/dependabot/bundler/rubocop-1.54.1
...
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
2023-07-05 14:48:15 +02:00
jibees
722f7b981b
Merge pull request #11158 from openfoodfoundation/dependabot/bundler/geocoder-1.8.2
...
chore(deps): bump geocoder from 1.8.1 to 1.8.2
2023-07-05 14:47:12 +02:00
dependabot[bot]
20bc6c8028
chore(deps): bump geocoder from 1.8.1 to 1.8.2
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.8.1 to 1.8.2.
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.8.1...v1.8.2 )
---
updated-dependencies:
- dependency-name: geocoder
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 09:23:48 +00:00
David Cook
7e0042ea1d
Apply code suggestion
...
Co-authored-by: Gaetan Craig-Riou <gaetan.riou@gmail.com >
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2023-07-05 11:27:03 +10:00
Cillian O'Ruanaidh
a80ff6097a
Improve formatting in spec/lib/reports/customers_report_spec.rb
2023-07-04 18:27:57 +01:00
Matt-Yorkley
671dfc7082
Don't flush errors when checking zero priced order validity
2023-07-04 14:42:31 +01:00
Matt-Yorkley
66a546027f
Add test coverage for handling zero priced orders
2023-07-04 13:13:05 +01:00
Gaetan Craig-Riou
74073946e6
Move VoucherAdjustmentsController to request specs
2023-07-04 13:13:05 +01:00
Matt-Yorkley
55cc57cf87
Use pre_discount_total when comparing to voucher amount
2023-07-04 13:13:05 +01:00
Matt-Yorkley
ad6d0c1c73
Add nil safety in reports for zero priced orders with no payment method
2023-07-04 13:13:05 +01:00
Matt-Yorkley
2aa3f8eb89
Fix flaky test
2023-07-04 13:13:05 +01:00
Matt-Yorkley
f7912a2240
Fix CSS/layout issues
2023-07-04 13:13:05 +01:00
Matt-Yorkley
672400192f
Update use of params
2023-07-04 13:13:05 +01:00
Matt-Yorkley
37a4c73a12
Fix rubocop complaint
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9b45b71696
Improve feature toggling
2023-07-04 13:13:05 +01:00
Matt-Yorkley
2f0f3e0820
Re-enable voucher test
2023-07-04 13:13:05 +01:00
Matt-Yorkley
28795effc3
Clarify named vouchers in UI
2023-07-04 13:13:05 +01:00
Matt-Yorkley
de97e69e7d
Show/hide payment methods if voucher changes order total to zero
2023-07-04 13:13:05 +01:00
Matt-Yorkley
55bce9f1b2
Remove @voucher_adjustment instance variable
2023-07-04 13:13:05 +01:00
Matt-Yorkley
7a0b83076b
Move loading of saved cards out of checkout concern
2023-07-04 13:13:05 +01:00
Matt-Yorkley
1cd38c957d
Introduce "zero priced orders" in admin order payments UI and helper
2023-07-04 13:13:05 +01:00
Matt-Yorkley
bd29a9acde
Introduce "zero priced orders" to checkout UI and order state flow
2023-07-04 13:13:05 +01:00
Matt-Yorkley
a65b3b8b60
Extract voucher tests to separate controller spec
2023-07-04 13:13:05 +01:00
Matt-Yorkley
d7950617ec
Drop superfluous method
2023-07-04 13:13:05 +01:00
Matt-Yorkley
47b5a3fb1d
Don't apply tax calculations if there's no tax
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9e5061fc31
Move voucher processing out of checkout controller
2023-07-04 13:13:05 +01:00
dependabot[bot]
eba8d8db83
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.1 to 1.54.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.1...v1.54.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-04 09:26:38 +00:00
filipefurtad0
e547e735c0
Adds test on API call for orders page
...
Removes unecessary assertion on http status
2023-07-03 11:51:46 +01:00
filipefurtad0
3f7958afe3
Adds regression test to issue #11120
2023-07-03 11:51:46 +01:00
Matt-Yorkley
91004588f6
Add separate voucher form
2023-07-03 11:03:05 +01:00
Matt-Yorkley
3f83da9928
Move voucher section out of main checkout form
2023-07-03 11:03:05 +01:00
Matt-Yorkley
e04a3f6b4d
Move form definition down into each checkout step
2023-07-03 11:03:05 +01:00
Matt-Yorkley
75e6ccd580
Simplify voucher controller
2023-07-03 11:03:05 +01:00
Matt-Yorkley
3d44f4bc98
Introduce "zero priced order" concept with no required payment
...
This applies to cases where an order contains items with zero price or where applied vouchers have reduced the order's total to zero.
2023-07-03 11:03:05 +01:00
dependabot[bot]
a9cb35dcc0
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
...
Bumps [state_machines-activerecord](https://github.com/state-machines/state_machines-activerecord ) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/state-machines/state_machines-activerecord/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: state_machines-activerecord
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-03 09:58:39 +00:00
Maikel Linke
4a562d0e7f
Add workaround for updated DFC v1.8 URLs
...
Once the DFC Connector was updated we can all use the new URLs. But for
now we have the old ones and add some compatibility to the old ones.
2023-07-03 16:05:18 +10:00
Maikel Linke
fc46dbacdc
Spec DFC Connector import behaviour around context
...
The DFC updated the URLs in their context, basically changing the ids of
all data types. I'll add a hacky workaround in the next commit.
2023-07-03 16:05:18 +10:00
Maikel Linke
9183c8acdd
Deal with bad SuppliedProduct data
2023-07-03 14:17:18 +10:00
Maikel Linke
18bcc179ef
Clarify request body required to create product
...
We have to work around an Rswag limitation here. But I think that this
version is clearer on the spec.
2023-07-03 14:17:18 +10:00
Maikel Linke
d5c41980d6
Document example for updating SuppliedProduct
2023-07-03 13:44:57 +10:00
Maikel Linke
7dc6cb151d
Include DFC context in spec example
...
The DFC Prototype does include the context while the output of the DFC
Connector refers to the URL of the published context. While that's more
efficient, it's also brittle because the context is updated from time to
time. That happened three days ago and working with the newly published
context breaks our integration until we get an updated version of the
DFC Connector containing the new URLs for datatypes.
2023-07-03 13:27:24 +10:00
Maikel Linke
7b9e4f6914
Move test files to own directory
2023-07-03 13:25:55 +10:00
Maikel Linke
811740c361
Correct OFN session cookie name
...
And improve the documentation in general.
2023-07-03 13:25:55 +10:00
Maikel Linke
7a51995aeb
Respond with SuppliedProduct data when creating
2023-07-03 12:37:23 +10:00
Maikel Linke
5a4efdbce3
Separate DFC API swagger config
...
This allows us to run the specs separately to generate the
documentation. It's more efficient this way and the separate swagger doc
file is easier to read.
The engine-specific swagger helper also allows us to simplify the spec
files.
Added an exception to our styleguide because it's intended and useful to
have a complete (lengthy) description of the API in one block.
2023-07-03 12:37:23 +10:00
Maikel
400d087789
Merge pull request #11133 from mkllnk/dfc-api-specs
...
OFN DFC API documenation in OpenAPI format generated with Rswag
2023-07-03 10:53:40 +10:00
Maikel
ffda344838
Merge pull request #11144 from mkllnk/remove-test-unit
...
Remove unused gem test-unit
2023-07-03 10:34:24 +10:00
Cillian O'Ruanaidh
bf44284237
Don't return duplicate rows in the customer addresses report
2023-06-30 17:10:44 +01:00
Matt-Yorkley
fefa9288a4
Remove :permalink attribute from Product
2023-06-30 11:37:57 +01:00
Filipe
b175793b91
Merge pull request #10704 from abdellani/hide-customers-with-no-completed-orders
...
Hide users with no completed orders from a hub's customers list
2023-06-30 10:56:56 +01:00
dependabot[bot]
7c9cabbab7
chore(deps): bump faraday from 2.7.6 to 2.7.9
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.6 to 2.7.9.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.6...v2.7.9 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-30 09:34:58 +00:00
Maikel Linke
9c2d092f4d
Remove unused gem test-unit
2023-06-30 11:37:57 +10:00
filipefurtad0
efb5132ac2
Update all locales with the latest Transifex translations
2023-06-29 23:28:28 +01:00
Filipe
54a85a504d
Merge pull request #11101 from mkllnk/dfc-api-key
...
Allow access to DFC API with OFN API token
2023-06-29 17:20:21 +01:00
Filipe
d27a632a38
Merge pull request #11079 from abdellani/fix-distributors-listing-on-checkout-options
...
filter distributors before listing on checkout options
2023-06-29 17:02:34 +01:00
Filipe
36f4b2e7f9
Merge pull request #11107 from jibees/11085-edit-variant-cant-update-values-on-the-variant-edit-page
...
Admin, Edit variant: remove unwanted extra space on price (added in certain specific conditions)
2023-06-29 16:46:42 +01:00
Filipe
97f131e556
Merge pull request #11089 from jibees/11049-invoices-actions-dropdown-menu-disappears-after-creating-the-first-invoice
...
[Invoices] Actions dropdown menu disappears after creating the first invoice
2023-06-29 16:23:35 +01:00
Filipe
da226ea021
Merge pull request #11109 from mkllnk/image-urls
...
Gracefully deal with missing S3 config
2023-06-29 12:50:36 +01:00
Filipe
d92c7f89bd
Merge pull request #11022 from Matt-Yorkley/matomo
...
Call matomo manually on asynchronous page visits
2023-06-29 12:02:48 +01:00
dependabot[bot]
af4ae4aaae
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-29 09:59:20 +00:00
Jean-Baptiste Bellet
045435e9cc
use the variant price itself
2023-06-29 11:02:56 +02:00
Jean-Baptiste Bellet
3286094804
number_to_currency can be nil: use a safe operator
2023-06-29 10:47:00 +02:00
Maikel Linke
8b3f45263c
Remove unnecessary spec clean-up
...
And clarify locale setup.
2023-06-29 10:40:01 +02:00
Jean-Baptiste Bellet
2fcf706aa3
Remove unwanted space at the end of the price
...
This `number_to_currency` method seems to display an extra space, not necessary when unit is `''`
Strip it.
Update specs as well. Thanks @filipefurtad0 for specs!!!
2023-06-29 10:40:01 +02:00
filipefurtad0
6b84fbf2b8
Adds after block, to remove configurations
...
Sets pending shared examples
2023-06-29 10:40:01 +02:00
filipefurtad0
504ee50dd4
Sets up a spec for #11085
2023-06-29 10:40:00 +02:00
David Cook
0ba342bf11
Merge pull request #10965 from macanudo527/fix_linelength_bundle2
...
Fix Layout/LineLength - Bundle 2
2023-06-29 15:27:08 +10:00
Maikel
dd1e1328cc
Merge pull request #11080 from rioug/fix-bulk-order-cancelation-spec
...
Fix bulk order cancellation test
2023-06-29 14:44:04 +10:00
Maikel
46ddab3781
Merge pull request #11088 from Matt-Yorkley/deployments-check
...
Update workflow permissions check to latest version
2023-06-29 14:34:46 +10:00
Maikel
6392c2c115
Merge pull request #11075 from mkllnk/test-cache
...
Use Redis for caching in test environment
2023-06-29 14:33:09 +10:00
Maikel Linke
029364d4a3
Express spec intent with DSL instead of comment
2023-06-29 14:25:50 +10:00
David Cook
714642f331
Use different Redis database for test environment
2023-06-29 14:15:18 +10:00
Filipe
ba99f85f5c
Merge pull request #10914 from abdellani/fix-stripe-sca-failure
...
redirect user to payment when the card doesn't have enough credit
2023-06-28 19:58:18 +01:00
Matt-Yorkley
ace2c5778f
Call matomo manually on Turbo page visits
2023-06-28 12:52:54 +01:00
Matt-Yorkley
a0a1f8f910
Merge pull request #11002 from openfoodfoundation/voucher-prep
...
Vouchers part 1
2023-06-28 11:30:12 +01:00
Maikel Linke
78d6d129e8
Simplify with extracted helper method
2023-06-28 14:11:50 +10:00
Maikel Linke
d21e6f99bb
Swaggerise CatalogItems spec
2023-06-28 14:11:50 +10:00
Maikel Linke
883e637545
Create deterministic test data for stable API docs
...
Otherwise the auto-generated Swagger file changes all the time without
code changes.
2023-06-28 13:50:54 +10:00
Maikel Linke
df29eaab98
Document DFC example body to create a product
2023-06-28 13:50:54 +10:00
Maikel Linke
db77d1591c
Add test examples to DFC API documentation
...
In other API specs, you provide example values in the schema. So the
specs contain examples which can be used for the documentation. But
instead of defining example data separately, we can use the generated
data by the specs. This way we document real output and don't have to
double up on documentation.
Note that we don't have schema definitions for the DFC API yet. And it
wouldn't make sense to replicate the DFC Ontology manually in JSON
Schema for this purpose. The DFC Connector ensures already that we
comply with the ontology. But I hope that we can use a tool at some
point to generate JSON Schema from the DFC Ontology which would add more
detail to the Swagger docs, I think.
2023-06-28 13:50:54 +10:00
Maikel Linke
b14c9bdf4c
Swaggerize SuppliedProduct spec
2023-06-28 13:50:54 +10:00
Maikel Linke
f0a5475563
Swaggerize Enterprise spec
2023-06-28 13:50:54 +10:00
Maikel Linke
7c0a4108d8
Show api-docs in production as well
...
We were hiding that before because the API is not officially released
yet but that's actually quite annoying. It's very conenient to have the
UI on production and be able to try out endpoints.
2023-06-28 13:50:54 +10:00
Maikel Linke
494c5e78de
Swaggerize Person spec
...
I chose the simplest spec first to demonstrate how it works. The UI at
/api-docs now shows this endpoint with two possible responses.
The docs are missing an example response which I hope to add later.
2023-06-28 13:50:54 +10:00
Maikel Linke
8368a6ccc9
Announce the new DFC endpoint
...
We need to declare in each spec file for which endpoint the spec is
because it was just choosing the first declared one by default. The
first one was v1 and now it's dfc-v1.7.
2023-06-28 13:50:54 +10:00
Maikel Linke
de51a7833d
Add script to swaggerize DFC API in its engine
...
Rswag doesn't look for specs in engines by default. We haven't added any
Rswag specs in the dfc_provider engine yet but that will come.
The generated API schema has some superfluous whitespace removed due to
a fix in the rswag gems.
2023-06-28 13:50:54 +10:00
David Cook
f280881126
Style tables with relaxed and condensed rows
...
* attempt with shadows, but they are between every row: http://jsfiddle.net/d872e3nb/
* another attempt at applying styles to tbody groups http://jsfiddle.net/sb38cLdu/
2023-06-28 09:59:57 +10:00
David Cook
2c14fe0434
Add variant rows and price column
2023-06-28 09:59:57 +10:00
David Cook
9c573f823a
Move .content under main content div
...
The .content div provides overall page margins and a max width, and is already nested inside the nav menus (this allows the nav background to fill the full width of the page.
The main content area should be structured the same way, so we can have flexibility needed to allow some screens to use the full page.
This doesn't seem to change the layout of any screens in the admin interface.
Now the table content can stretch full width
2023-06-28 09:59:57 +10:00
David Cook
6a2025b271
Add products table
...
With ellipsis clipping for long lines.
2023-06-28 09:59:57 +10:00
David Cook
809c15b197
Load products page with reflex
...
We will add the products in the next commit.
2023-06-28 09:59:57 +10:00
David Cook
841192fb96
Add new products page
...
Hidden behind admin_style_v3 feature toggle.
2023-06-28 09:59:57 +10:00
David Cook
efcaab5deb
Rename colour variables
2023-06-28 09:59:57 +10:00
dependabot[bot]
d65239fe47
chore(deps): bump view_component from 3.2.0 to 3.3.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.2.0...v3.3.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-27 10:03:13 +00:00
Filipe
748cdaaa52
Merge pull request #10963 from jibees/10956-orders-page-uncaught-error-missing-target-element-tooltip-for-tooltip-controller
...
Admin, Orders list: add tooltip on Edit action icon + capitalize tooltip (instead of uppercasing)
2023-06-27 09:58:34 +01:00
Mohamed ABDELLANI
e678c6149f
extract payment_faild from processing_failed
2023-06-27 09:26:26 +01:00
Mohamed ABDELLANI
4cca823a66
redirect user to payment when the card doesn't have enough credit
2023-06-27 09:14:48 +01:00
Neal Chambers
a4220891c5
Update .rubocop_todo.yml
2023-06-26 13:06:57 +09:00
Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Maikel Linke
c3d49bf31a
Speed up, simplify helper with ActiveRecord scopes
2023-06-26 12:56:00 +10:00
Maikel Linke
61c4fb936a
Test OrderCycleHelper with real data, not mocks
...
It's more realistic and doesn't break with the next change.
2023-06-26 12:55:57 +10:00
Maikel Linke
7f94fbc085
Add common whitespace to spec
2023-06-26 12:48:54 +10:00
Maikel
014fb69d4b
Merge pull request #10964 from macanudo527/fix_linelength_bundle1
...
Fix Layout/LineLength - Bundle 1
2023-06-26 12:10:39 +10:00
Maikel
bb5c5ffc7b
Merge pull request #11078 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.126.0
...
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
2023-06-26 11:11:39 +10:00
Maikel
a7915b8089
Merge pull request #10849 from mkllnk/report-cable
...
Show "loading" screen for background reports and display when ready
2023-06-26 10:25:48 +10:00
Konrad
49db2f30bc
Merge pull request #11014 from mkllnk/specs
...
Restore line item ordering
2023-06-25 21:45:26 +02:00
Konrad
8a8d78c081
Merge pull request #11041 from cillian/export-ofn-uid-column
...
Add an OFN UID column to the Users & Enterprises report
2023-06-25 20:46:18 +02:00
Maikel Linke
ff588cec40
Restore line item ordering
...
The line item sorting by id has been replaced by sorting by completed_at
time: ccb183d60b
While that's a good idea, the query param to order was only defined in
the client Javascript and there was no default ordering. Line items also
get their completed_at date from the order. So it's the same for all
items of the same order and the ordering with that group of line items
was random.
Now we are adding an order in addition. Items are first sorted by date
and then by id if there's any ambiguity.
2023-06-25 19:24:58 +02:00
Cillian O'Ruanaidh
8ab077bed8
Create enterprise inside :it block because it's only needed there so far
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
1984a1feeb
Use more readable click_button helper instead of find and click in users_and_enterprises_spec.rb
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
40b0bfb433
Add an OFN UID column to the Users & Enterprises report
2023-06-25 19:01:42 +02:00
dependabot[bot]
5010d3bbf3
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.124.0 to 1.126.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-25 18:26:42 +02:00
lauriejefferson
3039ef5535
updated order partials and locales
2023-06-23 12:06:45 -04:00
David Cook
6240baec0d
Update app/controllers/admin/enterprises_controller.rb
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2023-06-23 16:18:45 +09:00
Maikel
e065910d2d
Merge pull request #10939 from Matt-Yorkley/master-variants
...
Remove master variants
2023-06-23 13:42:58 +10:00
Maikel Linke
33d212d274
Gracefully deal with missing S3 config
...
I could have split this into several commits:
* DRY direct linking to images.
* Check S3 config before direct linking.
* Just check if service is public instead of relying on name.
Developers may copy a staging or production database or experiment with
S3 storage. But when the S3 config is missing then calling `service`
raises an ArgumentError due to a missing name.
Now we only try to call `service` if the S3 config is present.
2023-06-23 12:41:36 +10:00
David Cook
4bf65e330b
Enable master variants with associated order cycles
...
There's only 5 in UK prod. keeping them is easier than figuring out if it's safe to delete.
2023-06-23 11:50:26 +10:00
David Cook
2025a98f58
Delete stock_items for master variants
...
All variants have stock_items records, but master variants never use them, so these were always redundant.
2023-06-23 11:49:29 +10:00
David Cook
3bff7a9f13
Fix query
...
With deep nesting syntax.
I chose the longer alias 'left_outer_joins' because it's more explicit, and matches the use up on line 121.
2023-06-23 09:11:03 +09:00
Neal Chambers
172b1eea94
Update .rubocop_todo.yml
2023-06-23 09:11:02 +09:00
Neal Chambers
1e4034534c
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
Filipe
bca7813320
Merge pull request #10323 from abdellani/enterprise-fee-w-tax-by-order
...
Enterprise fee w tax by order
2023-06-22 23:25:11 +01:00
Filipe
9293dd379b
Merge pull request #11087 from Matt-Yorkley/image-error-notifications
...
Add image error Bugsnag notifications
2023-06-22 16:30:57 +01:00
Filipe
b4c4381473
Merge pull request #10987 from jibees/10979-white-label-trix-link-unlink-buttons-are-white-text-on-white-background
...
[White Label] Fix colors of custom content editor to have beautiful toolbar
2023-06-22 16:12:25 +01:00
Jean-Baptiste Bellet
7ce3c3f447
Overide a text-transform: uppercase to capitalize
...
Inherit comes from `app/webpacker/css/admin/components/buttons.scss`
2023-06-22 14:15:43 +02:00
Jean-Baptiste Bellet
91d24ba8ab
Add Edit tooptip for action icon in orders table
2023-06-22 14:15:43 +02:00
Matt-Yorkley
c88799618f
Set master variants which are associated to line items to non-master
...
Line items which reference a master variant is a scenario that in theory shouldn't have been valid or even possible for at least 5-6 years, and these old bits of data in theory should have been cleaned up at the time those changes were made. But a couple of servers have some really old data that's not in a nice state.
Here we can just flip the is_master flag to false for those specific (legacy data) cases before deleting any other master variants, to keep the legacy line item data intact.
2023-06-22 13:10:47 +01:00
jibees
22a3b31172
Merge pull request #11100 from mkllnk/remove-json-patch
...
Revert "Fix json v1.8.6 common.rb warning"
2023-06-22 11:11:21 +02:00
jibees
8eee90118e
Merge pull request #11093 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.2
...
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
2023-06-22 10:25:13 +02:00
jibees
5ba9c815cf
Merge pull request #11082 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.20.2
...
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
2023-06-22 10:18:26 +02:00
jibees
300c4ceed2
Merge pull request #11083 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.2
...
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
2023-06-22 10:17:44 +02:00
Mohamed ABDELLANI
b072da142e
filter distributors before listing on checkout options
2023-06-22 09:00:39 +01:00
Maikel Linke
08a06d21fa
Allow access to DFC API with OFN API token
2023-06-22 16:58:12 +10:00
Maikel Linke
82fc6a2a9d
Prepare spec to authenticate with other means
...
I want to add OFN API key support.
2023-06-22 16:27:04 +10:00
Maikel Linke
e7fe04f526
Revert "Fix json v1.8.6 common.rb warning"
...
This reverts commit 21b80db0ee .
This fix was needed for an old version of the JSON module with a newer
version of Ruby. But we updated the json gem since and don't need this
any more.
2023-06-22 12:47:28 +10:00
lauriejefferson
d3dba87ca1
added styling and table rows for 'Not Paid' order confirmation'
2023-06-21 17:22:12 -04:00
Matt-Yorkley
f9185ea56e
Remove line items related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 18:08:21 +01:00
Matt-Yorkley
6f5d3ceacc
Remove inventory units related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 17:20:28 +01:00
Jean-Baptiste Bellet
d2534d6645
Be more specific via !important than the default button rule
...
This one should override the default one
2023-06-21 15:01:14 +02:00
Jean-Baptiste Bellet
7d9018c590
Instead of overriding css rules, prefer to not select rules for trix buttons
2023-06-21 15:01:14 +02:00
dependabot[bot]
c532e822e5
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.3.0 to 1.4.2.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.2/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-21 09:57:46 +00:00
Jean-Baptiste Bellet
5d1c32e8cd
Remove linksDropdown which is now unused
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
4ec41572b1
Add spec on Canceling an order
...
Strange that it doesn't exist, but anyway, let's create it!
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
ce28c14544
Replace AngularJS directive to a StimulusJS one
...
Delete _order_links.html.haml_spec.rb
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
7421691506
Creates a dropdown controller with its specs
2023-06-21 10:29:47 +02:00
David Cook
5ec872c6fd
Merge pull request #11008 from mkllnk/dfc-connector-import
...
Prototype: Import products via DFC Connector
2023-06-21 12:23:58 +10:00
Maikel Linke
14b2e0f962
Remove datadog gem, too expensive
2023-06-21 11:44:21 +10:00
Matt-Yorkley
98a56bfcf8
Update workflow permissions check to latest version
2023-06-20 14:41:17 +01:00
Matt-Yorkley
776eac9f52
Add image error Bugsnag notifications
2023-06-20 14:14:19 +01:00
Matt-Yorkley
24aa55e053
Remove array syntax on new product form for product image
2023-06-20 13:14:52 +01:00
dependabot[bot]
e8e3aa5f5d
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.1.0 to 5.1.2.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.0...v5.1.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:31:26 +00:00
dependabot[bot]
584a25052f
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.19.1 to 2.20.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.19.1...v2.20.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:14:06 +00:00
Gaetan Craig-Riou
ea73781668
Fix bulk order cancellation
...
Add unticking of "send cancellation email to customer" to match
the current test expectation
2023-06-20 10:03:55 +10:00
Maikel Linke
a9f8c7c4ab
Update DFC API docs, describe all endpoints
2023-06-19 16:20:35 +10:00
Maikel Linke
ec8c710e3a
Import simple DFC SuppliedProduct
...
OFN products and variants need more data like a price but the DFC
stores that in a different object. We may get a larger graph containing
that information but we don't have any test data yet.
2023-06-19 16:19:48 +10:00
Maikel Linke
df9e1ac2b4
Encapsulate SuppliedProductBuilder
...
And improve EnterpriseBuilder. It was builder products twice.
2023-06-19 16:19:48 +10:00
Maikel Linke
1adfb5463a
Import DFC measures
2023-06-19 16:19:40 +10:00
Maikel Linke
949019a277
Map has* predicates to Connector attributes
2023-06-19 16:19:40 +10:00
Maikel Linke
bfd084d9b6
Import graphs including anonymous objects
2023-06-19 16:18:58 +10:00
Maikel Linke
3c6f90dbb3
Import from IO objects for convenience, efficiency
...
The Connector exports to a String but Rails' `request.body` is an IO
object. Since the used JSON-LD parser needs an IO object anyway and it
can lower the memory usage we take IO objects as well and handle
in-memory Strings only when given.
2023-06-19 16:18:58 +10:00
Maikel Linke
f5f8c349e1
Resolve DFC Connector objects when importing graph
2023-06-19 16:18:51 +10:00
Maikel Linke
12d56d725b
Import properties which contains lists
...
Not just single values.
2023-06-19 16:18:51 +10:00
Maikel Linke
2abad60511
Import DFC graphs with multiple objects
2023-06-19 16:18:42 +10:00
Maikel Linke
15dd38d6c6
Import simple data from DFC
2023-06-19 16:16:18 +10:00
Maikel Linke
cceca5f936
Use Redis for caching in test environment
...
All other environments use it.
2023-06-19 15:35:17 +10:00
Maikel Linke
f6db69104f
Update Gemfile.lock with new Ruby version
2023-06-19 15:03:44 +10:00
Maikel
7e20415490
Merge pull request #10888 from mkllnk/ruby3.1
...
Bump Ruby from 3.0.3 to 3.1.4
2023-06-19 10:08:20 +10:00
Maikel
101e72726c
Merge pull request #11032 from dacook/show-current-version2
...
Show current version2
2023-06-19 10:07:49 +10:00
Konrad
dab5436444
Merge pull request #10532 from abdellani/invoices
...
Invoices
2023-06-18 21:44:29 +02:00
Mohamed ABDELLANI
d059680f4b
remove white label from feature toggle
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
27c1fd0d30
test invoice model
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
639567e903
replace attr with attr_reader
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fff0b1e577
Update lib/open_food_network/feature_toggle.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
7a0686786d
Update db/migrate/20230308075421_create_invoices.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
73cdcca022
fix linter issues
2023-06-18 21:03:13 +02:00
Matt-Yorkley
4eb05a1d73
Reduce public interface of OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Matt-Yorkley
3946e7a6f5
Memoize presenters in OrderInvoiceComparator
...
This is now twice as fast and triggers half the number of database queries if both comparison methods get called
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c6ec13443e
Drop next_invoice_number method from Spree::Order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
d3a31bd0bd
Rename @invoice_presenter instance variable to @order in invoice templates
2023-06-18 21:03:13 +02:00
Matt-Yorkley
352ad20681
Fix display_checkout_taxes_hash in invoice_table4 template
2023-06-18 21:03:13 +02:00
Matt-Yorkley
68ab539ed3
Include completed_at attribute
2023-06-18 21:03:13 +02:00
Matt-Yorkley
113e1344f2
Include tax adjustments in serializer and presenter
2023-06-18 21:03:13 +02:00
Matt-Yorkley
5bbc63f716
Fix options_text displaying when there is no options_text
2023-06-18 21:03:13 +02:00
Matt-Yorkley
72e537b598
Update *_amount_with_adjustments methods on LineItem presenter
...
These methods are slightly different and they're both needed in the template for invoice4
2023-06-18 21:03:13 +02:00
Matt-Yorkley
208840b99d
Use @invoice_presenter.checkout_adjustments
2023-06-18 21:03:13 +02:00
Matt-Yorkley
a44f24ad43
Remove prefixes from invoice data representation so it conforms to the same interface as order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
8dba1618b1
Don't call information from @order in new invoice templates
...
Previously this template was calling various bits of data from the @order object and not the @invoice_presenter object
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c3d6b2280f
Update reference to removed method
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0ed7599267
extract methods related to invoices from the order model to the OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
61d58df56f
fix linter issues
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d86173c509
add feature toggle
...
seperate the invoice templates that rely on presenters from the old ones.
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fa14dc370b
implement the invoice data generator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d9efd10ac0
update attributes relevant for the comparaison
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0fbf88190e
Generate invoice model
...
There are three main components:
1. The invoice model
2. order serializers: serialize the order for the invoice
3. data presenters: the object that will be use to access the order's serialize data
2023-06-18 21:03:13 +02:00
Matt-Yorkley
ae24b2d688
Update ScopeVariantsForSearch logic to match both product and variant SKUs
2023-06-16 21:26:28 +01:00
Matt-Yorkley
0f253bb2a0
Blank out product SKU when cloning a product
...
This was effectively being done before for the product's sku (stored on the master variant) via the #duplicate_variant method, but now it needs to be done explicitly on the product in #duplicate_product
2023-06-16 21:26:28 +01:00
Matt-Yorkley
15000c7ed1
Remove unnecessary iterator
2023-06-16 21:26:28 +01:00
Matt-Yorkley
733dd3c428
Disable variant is_master column
2023-06-16 21:23:44 +01:00
Matt-Yorkley
be72bbebb9
Remove master images data migration tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
fbd09869bb
Remove is_master from variant serializer
2023-06-16 21:23:44 +01:00
Matt-Yorkley
ced60d4382
Remove superfluous method from products controller
2023-06-16 21:23:44 +01:00
Matt-Yorkley
b59bdc75e9
Delete master variants
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1daab8994d
Remove is_master and not_master scopes
2023-06-16 21:23:44 +01:00
Matt-Yorkley
0703bb4583
Remove unused is_master references in tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
85059bfb26
Remove master variant validation conditionals
2023-06-16 21:23:44 +01:00
Matt-Yorkley
8247dce2dc
Improve validation feedback on new variant page and add test coverage
2023-06-16 21:23:44 +01:00
Matt-Yorkley
618900767f
Fix flaky spec: use milliseconds in cache service and remove sleep
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1e36043a2e
Set unit_value to true when cloning a product
...
This value doesn't get persisted, but it's presence is validated. The product's duplicated variants store the actual :unit_value attribute
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1922598d2d
Reorganise associations, validations, scopes and callbacks for clarity
2023-06-16 21:23:44 +01:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
21cba0aa13
Migrate first master variant image to product image
2023-06-16 21:23:44 +01:00
Matt-Yorkley
7dc1091bc2
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
d8649fc9fb
Migrate master variant :sku to product
2023-06-16 21:21:40 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Matt-Yorkley
8c0b8dad85
Stop using master variant for storing :display_as value
2023-06-16 21:21:40 +01:00
Matt-Yorkley
1b06c20197
Stop using master variant as a potential store for prices
2023-06-16 21:21:40 +01:00
Matt-Yorkley
80a0138b48
Update old specs that rely on master variant instead of real variants
2023-06-16 21:21:40 +01:00
Matt-Yorkley
d4188da7c1
Simplify product images delegation mess
2023-06-16 21:21:40 +01:00
Matt-Yorkley
42a5a48816
Remove dead code
2023-06-16 21:21:40 +01:00
Matt-Yorkley
dd224b953d
Update stage.yml
2023-06-16 14:24:23 +01:00
Matt-Yorkley
cfe5d9a740
Update stage.yml
2023-06-16 14:00:30 +01:00
Matt-Yorkley
09bfe14ae9
Update stage.yml
2023-06-16 13:39:12 +01:00
Mohamed ABDELLANI
68503e4e8b
remove useless variable
2023-06-16 06:54:11 +01:00
Mohamed ABDELLANI
65bc8e23c1
move update instructions to let blocks
2023-06-16 06:50:45 +01:00
Mohamed ABDELLANI
2b79258fdc
renamed: spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb -> spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order_spec.rb
2023-06-16 06:39:38 +01:00
Mohamed ABDELLANI
c21a35a9fc
fix typo on lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_order.rb
2023-06-16 06:38:15 +01:00
Mohamed ABDELLANI
c8c3e65498
Update lib/reporting/reports/list.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
2cfa435b54
Update spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
3e61830b40
optimize total_excl_tax & enterprise_fee_adjustemnt_ids
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
10fc816bba
update rubocop_todo list
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
542811b9ad
implement filtering by entreprise fee owner
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
9d53d775a6
add filtering by fee name
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
f66d9b9626
remove producers filter
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
83b951662a
add filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9671e4e1f
test enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9367b1f86
add enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
535f651c7e
implement enterprise fee report filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
a120329aa6
rename EnterpriseFeeSummary::Base to EnterpriseFeeSummary::FeeSummary
2023-06-16 06:35:01 +01:00
Maikel
4e1f735630
Include feature toggle heading in release notes
2023-06-16 14:13:41 +10:00
Maikel Linke
2453084a6b
Update translations
2023-06-16 14:02:47 +10:00
Maikel
39183547aa
Merge pull request #11033 from openfoodfoundation/revert-10455-dependabot/bundler/redis-5.0.6
...
Revert "Fix `redis` and `hiredis-client` version requirements "
2023-06-16 13:42:55 +10:00
Maikel
24000b2ce3
Revert "Fix redis and hiredis-client version requirements "
2023-06-16 13:09:25 +10:00
Maikel
8e86f76278
Merge pull request #11018 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.2
...
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
2023-06-16 12:08:25 +10:00
Maikel
4a91c180a3
Merge pull request #11017 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.1
...
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
2023-06-16 11:14:10 +10:00
Maikel
d192024786
Merge pull request #11019 from filipefurtad0/flaky_cache_spec
...
Clears cache around examples
2023-06-16 11:12:24 +10:00
Maikel
ec7de516aa
Merge pull request #11011 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.124.0
...
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
2023-06-16 10:59:56 +10:00
David Cook
56e4b3b843
Load git version once at initialisation
...
Co-authored-by: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2023-06-16 09:36:16 +10:00
David Cook
47745b5e49
Merge pull request #11004 from dacook/show-current-version
...
Show current version at bottom of admin dashboard
2023-06-16 09:26:00 +10:00
Matt-Yorkley
3301c7cabc
Update stage.yml
2023-06-16 00:18:36 +01:00
David Cook
35d9837f24
Show current version at bottom of admin dashboard
...
With generic link to the releases page. We could provide a link to latest tag with `git describe --tags --abbrev=0`. But I thought it better to keep things simple.
2023-06-16 09:11:59 +10:00
Matt-Yorkley
436deb9797
Update stage.yml
2023-06-16 00:03:16 +01:00
Matt-Yorkley
57451f2639
Update stage.yml
2023-06-15 23:26:27 +01:00
Matt-Yorkley
d56ad66ab8
Update stage.yml
2023-06-15 20:57:40 +01:00
Matt-Yorkley
fc5a53ebd9
Update stage.yml
2023-06-15 20:53:20 +01:00
Matt-Yorkley
f27472106e
Update stage.yml
2023-06-15 20:52:07 +01:00
Matt-Yorkley
5729e33f69
Merge pull request #11031 from Matt-Yorkley/deployment-workflow
...
Add workflow for deploying to staging
2023-06-15 20:40:10 +01:00
Matt-Yorkley
584f6297f5
Allow manual workflow triggers
2023-06-15 20:18:44 +01:00
Matt-Yorkley
12bf17e21e
Add workflow for deploying to staging
2023-06-15 19:37:18 +01:00
Matt-Yorkley
7068df5d4b
Merge pull request #10804 from Matt-Yorkley/public-images
...
Update ActiveStorage image processing
2023-06-15 15:49:11 +01:00
Konrad
7a10edff82
Merge pull request #10988 from jibees/10980-white-label-trix-bullets-and-numbers-are-displayed-outside-the-text-field
...
[White Label] Custom tab content editor: order and unordered list should have a margin-left set
2023-06-15 16:13:19 +02:00
Konrad
5c0db892e5
Merge pull request #10983 from jibees/10982-admin_style_v3-use-oidc-settings-instead-of-oidc-settings-in-navigation
...
[OIDC] Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-15 16:07:07 +02:00
filipefurtad0
598f69f42f
Clears cache around examples
...
for specs testing cache
2023-06-15 11:28:01 +01:00
dependabot[bot]
ca5de6b0b2
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.1 to 7.1.2.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.1...v7.1.2 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 10:05:58 +00:00
dependabot[bot]
b0c9c6e6e1
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.12.0...v1.12.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 09:58:24 +00:00
David Cook
d195882645
Use builtin Rails method
2023-06-15 15:26:22 +10:00
Maikel Linke
a46917a7b7
Remove NULL possibility from customer flag
...
It should only be true or false. This was flagged by Rubocop. I also
added another Rubocop suggestion and combined two migrations because
they are related.
2023-06-15 12:02:45 +10:00
Maikel Linke
75cce8bc19
Simplify customer code
...
The API endpoint merges the created_manually flag in the params already.
No need to write it separately.
2023-06-15 12:02:45 +10:00
Maikel Linke
a655d3d787
Remove unnecessary writes on customer creation
...
The form only submits enterprise id and email address. We don't need to
assign any other attributes.
2023-06-15 12:02:45 +10:00
Maikel Linke
9bd6615dad
Change spec to "unhide" customers on create
2023-06-15 12:02:45 +10:00
Maikel Linke
ebebcf7a13
Remove useless code
2023-06-15 12:02:45 +10:00
Maikel Linke
22a6861f6f
Place class methods above instance methods
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
298ae8ffc3
set create_manualll flag if the customer already exists
2023-06-15 12:02:45 +10:00
Maikel Linke
107b17addb
Add index of much used created_manually column
2023-06-15 12:02:45 +10:00
Maikel Linke
9910d10eb8
Simplify and speed-up customers migration
...
This reduces the migration run time from 9.6 seconds to 0.16 seconds on
a production database.
* Simplify model naming.
* Remove unnecessary model code.
* Use Rails `missing` scope for efficient simplicity.
* Add `down` method for rollback instead of running `change` again.
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
608ff054b0
set the created_manually flag to true for all customers that don't have any orders
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
ebc3073604
use Customer#visible on the customers listing endpoints
...
Update app/models/customer.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
authorize created_manually field to be set on APIv1
2023-06-15 12:02:45 +10:00
Maikel
701fef84f3
Merge pull request #10850 from mkllnk/require-belongs-to--part1
...
Require belongs_to associations - part 1
2023-06-15 09:20:42 +10:00
Konrad
cf3692e688
Merge pull request #10992 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.4
...
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
2023-06-14 22:25:16 +02:00
Konrad
863fed56ce
Merge pull request #10455 from openfoodfoundation/dependabot/bundler/redis-5.0.6
...
Fix `redis` and `hiredis-client` version requirements
2023-06-14 22:09:13 +02:00
Filipe
e6d42a0c4f
Merge pull request #10999 from Matt-Yorkley/bom-issues
...
Fix BOM order loading issue
2023-06-14 19:01:54 +01:00
Matt-Yorkley
64508d3c3d
Add unit test for direct image URLs
2023-06-14 12:53:20 +01:00
Matt-Yorkley
395cf7fb8d
Use direct image URLs for enterprise logos
2023-06-14 12:53:20 +01:00
Matt-Yorkley
5ad37ce6a5
Return default image url on ActiveStorage errors in image loading
2023-06-14 12:53:20 +01:00
dependabot[bot]
6e9721b64c
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.123.1 to 1.124.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-14 09:58:54 +00:00
Matt-Yorkley
4c7e947738
Migrate data
...
So it turns out all images uploaded before the ActiveStorage migration are internally set to "public-read", and all images uploaded after the migration are internally set to "private". This migration switches all images in S3 buckets back to "public-read".
2023-06-14 10:56:10 +01:00
Matt-Yorkley
b510668ecf
Render direct URLs for s3 images
2023-06-14 10:56:10 +01:00
Matt-Yorkley
6f12d012ed
Use #url helper
2023-06-14 10:56:10 +01:00
Matt-Yorkley
551d0d3a93
Simplify calling #url_for in models
2023-06-14 10:56:10 +01:00
Matt-Yorkley
a898915724
Use named image variants
2023-06-14 10:56:10 +01:00
Matt-Yorkley
e54cff2274
Set images to public-read
...
Defining an alternate s3 configuration set to `public: true` means we can use it selectively. It sets the objects to `acl: "public-read"` by default (read-only) and means any image tags for those assets can use direct public links in the src attribute (without hitting the ActiveStorage::Representation endpoint). The default non-public service will still be used by default for any other files on instances using s3.
2023-06-14 10:56:10 +01:00
Matt-Yorkley
202b0041d1
Remove voucher processing from checkout edit action
2023-06-14 10:19:30 +01:00
Matt-Yorkley
1a744de37a
Improve voucher #calculate tests
2023-06-14 10:19:30 +01:00
Matt-Yorkley
93df70c0a7
Use order total excluding discounts in voucher calculations
2023-06-14 10:19:30 +01:00
Matt-Yorkley
52806a35ee
Fix Rubocop complaint
2023-06-14 10:19:30 +01:00
Matt-Yorkley
11382a518e
Fix test setup in BOM spec
2023-06-14 10:19:30 +01:00
Matt-Yorkley
ef09492883
Update adjustment spec to use orders past delivery state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
6fa381197a
Don't tax fees before payment state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
837e581c29
Reload order after cancelling it in tests that check shipment states
2023-06-14 10:19:30 +01:00
Matt-Yorkley
06c9697d0d
Don't try to cancel shipments that might already be cancelled
2023-06-14 10:19:30 +01:00
Matt-Yorkley
c5dfecbb69
Reapply taxes at model level if order address changes
...
This should be done at the model level
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0f23fc510
Extract before_payment_state? method
2023-06-14 10:19:30 +01:00
Matt-Yorkley
13a22c56f4
Move taxing of admin adjustments out of customer details controller
2023-06-14 10:19:30 +01:00
Matt-Yorkley
65b6a75c9b
Reorder callback definitions
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0d0f8fd2f
Tidy up checkout tax spec
2023-06-14 10:19:30 +01:00
Maikel Linke
c2605b2606
Display loading spinner before quick reports
...
We had a race condition that could first display the report and then
replace it again with the "loading" spinner. That doesn't seem to happen
now that we changed the order of cable events.
2023-06-14 15:40:52 +10:00
Maikel Linke
91d0dabc1d
Require associations on DistributorShippingMethod
2023-06-14 15:09:12 +10:00
Maikel Linke
bd11475fe1
Require associations on DistributorPaymentMethod
2023-06-14 15:08:22 +10:00
Maikel Linke
ed231ec512
Update belongs_to default in Customer model
2023-06-14 15:08:05 +10:00
Maikel Linke
fc00a48d67
Require associations of CoordinatorFee
2023-06-14 15:08:05 +10:00
Maikel Linke
c02c90317f
Require user of column preference record
...
It doesn't make sense to have a preference without a user. And it was
already enforced in the database.
2023-06-14 15:07:43 +10:00
Maikel Linke
2d4cfd7548
Validate and enforce AdjustmentMetadata associations
2023-06-14 15:07:43 +10:00
Maikel Linke
d88781a083
Start to adopt new default to require belongs_to
...
Newer version of Rails have this option as default. We can slowly
transition to opt in gradually, model by model. Once all models are
covered, we can change the default and remove the setting from the
models again.
The style violation was added to the todo file because it's temporary.
We have 60 models using `belongs_to`. And changing them all at once
breaks some specs. So let's do it gradually.
2023-06-14 15:06:59 +10:00
Maikel
989a88e252
Merge pull request #10848 from mkllnk/totals-report
...
Fix error on summarising total_units in Order Cycle Supplier Totals report
2023-06-14 13:59:48 +10:00
Matt-Yorkley
074eb4b592
Move tax charge logic out of checkout controller and update payment transition
2023-06-13 17:53:46 +01:00
Matt-Yorkley
bf912ae4d3
Remove angular loading element in darkwarm layout
2023-06-13 17:35:13 +01:00
Filipe
9c42781ff1
Merge pull request #10913 from abdellani/remove-split-checkout-toggle-and-legacy-checkout
...
Remove split checkout toggle and legacy checkout
2023-06-13 17:00:07 +01:00
Matt-Yorkley
73b2d37224
Don't try to load orders if the number of line_items with the current filters applied is zero
...
This ends up sending a request to the orders endpoint with no filters and no search params, which then tries to load every order in the entire database if the user is superadmin, which blows up.
2023-06-13 15:47:19 +01:00
Mohamed ABDELLANI
2654d3b866
update the rubocop_todo list
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5fa81d1333
Fix invalid test setup in old tax tests
2023-06-13 14:58:16 +01:00
Matt-Yorkley
4e7fab6914
Delete dead code Checkout#find_transition
...
This method is only called from tests and nowhere else in the codebase. We may as well remove it.
2023-06-13 14:58:16 +01:00
Matt-Yorkley
8d633234f4
Set voucher specs to pending temporarily
2023-06-13 14:58:16 +01:00
Matt-Yorkley
d5a625bdeb
Fix Paypal spec
2023-06-13 14:58:16 +01:00
Matt-Yorkley
0e289a23c1
Set some legacy checkout specs that we might want to rewrite later to pending
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5487aa19fc
Fix missing checkout_state_path
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
345f540723
fix spec/models/spree/tax_rate_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
78617905c6
remove spec/requests/checkout/concurrency_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
56204b2315
fix ./spec/routing/stripe_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
905187f3ce
fix ./spec/services/order_tax_adjustments_fetcher_spec.rb:100
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
7e84579aa3
spec/system/consumer/shopping/checkout_stripe_spec
...
these tests are using the legacy checkout
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
bd0e7cdfc8
remove legacy checkout tests
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
907c65d98c
run create_tax_charge! after transition to payment state
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
c2aaf88e98
remove checkout controller
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
fc0cca2210
remove legacy checkout view
2023-06-13 14:58:16 +01:00
jibees
c379dcacc5
Merge pull request #10993 from openfoodfoundation/dependabot/bundler/jwt-2.7.1
...
chore(deps): bump jwt from 2.7.0 to 2.7.1
2023-06-13 15:05:30 +02:00
jibees
64e6d639c1
Merge pull request #10995 from openfoodfoundation/dependabot/bundler/rubocop-1.52.1
...
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
2023-06-13 15:03:45 +02:00
jibees
374904f473
Merge pull request #10996 from openfoodfoundation/dependabot/bundler/test-unit-3.6.0
...
chore(deps): bump test-unit from 3.5.9 to 3.6.0
2023-06-13 15:03:03 +02:00
jibees
fb7ae9fd58
Merge pull request #10991 from openfoodfoundation/dependabot/bundler/view_component-3.2.0
...
chore(deps): bump view_component from 3.1.0 to 3.2.0
2023-06-13 15:02:26 +02:00
dependabot[bot]
19bd05ce5a
chore(deps): bump test-unit from 3.5.9 to 3.6.0
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.9 to 3.6.0.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.9...3.6.0 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:11:47 +00:00
dependabot[bot]
f9abec4346
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.0 to 1.52.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.0...v1.52.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:10:38 +00:00
dependabot[bot]
3e7ad17f69
chore(deps): bump jwt from 2.7.0 to 2.7.1
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.7.0...v2.7.1 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:08:44 +00:00
dependabot[bot]
b813879330
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.3...1.0.4 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:02:26 +00:00
Filipe
12bb8db7b3
Merge pull request #10933 from Matt-Yorkley/fix-payment-intents
...
Fix ProcessPaymentIntent service
2023-06-13 11:00:27 +01:00
dependabot[bot]
c3846ad269
chore(deps): bump view_component from 3.1.0 to 3.2.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 09:58:11 +00:00
Matt-Yorkley
93c3241bb5
Add more test coverage in stripe controller spec
2023-06-13 10:14:09 +01:00
Matt-Yorkley
abd55b2104
Move order to completed whether it's current state is payment or confirmation
2023-06-13 10:14:09 +01:00
Matt-Yorkley
47df9493ae
Fix ProcessPaymentIntent service
2023-06-13 10:14:09 +01:00
Gaetan Craig-Riou
694e46d1fb
Fix Bundler/OrderedGems
2023-06-13 15:35:40 +10:00
Gaetan Craig-Riou
4564021f79
Remove redis version limitation
2023-06-13 15:06:52 +10:00
David Cook
b85cf26907
Add comment
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
02432ee2ec
Do not upgrade to redis >= 5
...
since Redis >= 3, < 5 is actually a requirement of Action Cable Redis subscription adapter until Rails 7.0.4.
https://github.com/rails/rails/blob/v6.1.7/actioncable/lib/action_cable/subscription_adapter/redis.rb
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
520ced350e
Do not specify redis version
2023-06-13 14:59:19 +10:00
Jean-Baptiste Bellet
e41d1f2205
Following the doc, remove hiredis and use hiredis-client
...
Reference:
- https://github.com/redis/redis-rb/issues/1178
- https://github.com/redis/redis-rb#hiredis-binding
2023-06-13 14:59:19 +10:00
David Cook
c5ce49e08c
Merge pull request #10948 from dacook/buu-table-styles
...
[admin_v3] Update all table styles
2023-06-13 13:08:55 +10:00
David Cook
e4c65ea87d
Prettify palette file
2023-06-13 11:46:28 +10:00
David Cook
f007cf3dad
Fix up table borders
2023-06-13 11:45:39 +10:00
David Cook
edcdcd3f74
Use header colour for table headers
2023-06-13 11:45:39 +10:00
David Cook
16534319b6
Replace dark blue with "Sherpa blue"
...
It looks like it’s used in headers, some buttons and a loading message
2023-06-13 11:45:39 +10:00
David Cook
d85ea628e2
Change default font colour to near-black
...
It looks like this is the main font colour in the new designs.
2023-06-13 11:45:39 +10:00
David Cook
821446e150
Style pagination links
...
And provide a basic hover state for most other buttons.
The pagination button hover and active states will need updating.
The darker background colour sometimes wraps a whole table (eg products table).
2023-06-13 11:45:39 +10:00
David Cook
744f95809a
Remove uppercase styling of form elements
2023-06-13 11:45:39 +10:00
David Cook
fb17a679c0
First pass at new table colours
...
There is more to do, for example the dropshadows.
I've continued with the unopinionated colour naming (eg color-7), but would like to consider giving them more meaningfule names..
2023-06-13 11:45:39 +10:00
David Cook
2ae91bdbe2
Use variable for font size reset
...
The current value is 13px already, but I'd like to experiment changing this.
I'm not sure if we even need the reset, but am not delving into that right now.
2023-06-13 11:44:48 +10:00
David Cook
3967f54533
Use different variables and table styles for admin_v3
2023-06-13 11:44:48 +10:00
Konrad
6bd66585a9
Merge pull request #10935 from openfoodfoundation/dependabot/bundler/i18n-1.14.1
...
chore(deps): bump i18n from 1.13.0 to 1.14.1
2023-06-12 17:39:42 +02:00
Konrad
11f84b5276
Merge pull request #10934 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.123.1
...
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
2023-06-12 17:24:20 +02:00
Filipe
23239bad8b
Merge pull request #10970 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.0
...
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
2023-06-12 16:19:32 +01:00
Konrad
a207a445b1
Merge pull request #10907 from jibees/3041-missing-translation-in-product-variant-selection-upon-order-creation
...
Admin, Create an order, Select a product: translate some messages in the product selection search box
2023-06-12 17:08:52 +02:00
Jean-Baptiste Bellet
16256ee114
Order and Unordered list should have a margin-left set
...
Has been reset to 0 via `typography.scss`
2023-06-12 16:58:00 +02:00
dependabot[bot]
15e9c4eb37
chore(deps): bump i18n from 1.13.0 to 1.14.1
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.13.0...v1.14.1 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 14:44:01 +00:00
Konrad
3e3ae5d8ae
Merge pull request #10929 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.0
...
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
2023-06-12 16:43:01 +02:00
Konrad
48c107bde1
Merge pull request #10974 from cillian/ignore-whitespace-in-product-import
...
Ignore leading and trailing whitespace when importing products via a spreadsheet
2023-06-12 16:32:15 +02:00
Konrad
80dd8755b0
Merge pull request #10915 from mkllnk/mini-racer
...
Remove unused mini_racer gem
2023-06-12 16:05:52 +02:00
Konrad
791518988d
Merge pull request #10918 from openfoodfoundation/dependabot/bundler/view_component-3.1.0
...
chore(deps): bump view_component from 3.0.0 to 3.1.0
2023-06-12 15:36:21 +02:00
Jean-Baptiste Bellet
149ec5511c
Translate select2 messages
2023-06-12 15:11:23 +02:00
dependabot[bot]
351343fb6c
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.122.0 to 1.123.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:06:04 +02:00
dependabot[bot]
6145413b1a
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.1 to 1.12.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.1...v1.12.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:05:11 +02:00
dependabot[bot]
d87e40bb69
chore(deps): bump view_component from 3.0.0 to 3.1.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:04:17 +02:00
Maikel Linke
d6859e0bf7
Remove unused mini_racer gem
...
All asset compilation is done with webpacker at the moment.
2023-06-12 15:01:11 +02:00
Konrad
1f2f5e2eec
Merge pull request #10892 from openfoodfoundation/dependabot/bundler/rails-7.0.5
...
chore(deps): bump rails from 7.0.4.3 to 7.0.5
2023-06-12 14:58:07 +02:00
jibees
b53aba3844
Merge pull request #10986 from openfoodfoundation/dependabot/bundler/capybara-3.39.2
...
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
2023-06-12 14:42:48 +02:00
jibees
45dcdf1611
Merge pull request #10985 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.1
...
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
2023-06-12 14:31:03 +02:00
jibees
8c971f2efa
Merge pull request #10984 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.3.0
...
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
2023-06-12 14:29:56 +02:00
dependabot[bot]
8a8200a039
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.1 to 3.39.2.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.1...3.39.2 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:58:05 +00:00
dependabot[bot]
8a376e782a
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:39 +00:00
dependabot[bot]
6ab1bfb2ab
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.9 to 1.3.0.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.3.0/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:18 +00:00
Sigmund Petersen
c2305615a6
Merge pull request #10971 from filipefurtad0/mouse_hover_spec
...
Adds spec for tooltips on orders page
2023-06-12 09:53:16 +02:00
Jean-Baptiste Bellet
ff0f81167a
Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-12 09:19:16 +02:00
Gaetan Craig-Riou
41b3ddae08
Merge pull request #10714 from macanudo527/fix_linelength
...
Fix Style/LineLength
2023-06-12 09:53:23 +10:00
Konrad
fc09f95fa1
Merge pull request #10961 from jibees/10946-white-label-trix-editor-changes-on-the-custom-tab-content-do-not-trigger-the-update-button
...
[WhiteLabel] Make update button active when changing custom tab content
2023-06-09 21:46:02 +02:00
Konrad
13037d2d9d
Merge pull request #10949 from jibees/10630-buu-as-an-enterprise-user-i-can-see-the-back-office-with-new-brand-colours
...
[`admin_style_v3`] As an enterprise user i can see the back office with new brand colours
2023-06-09 21:24:01 +02:00
Konrad
9125c730ed
Merge pull request #10960 from jibees/customize-trix-editor-to-have-the-right-colors
...
[White Label] Customize colors of custom content editor to have beautiful toolbar
2023-06-09 20:35:36 +02:00
Matt-Yorkley
70170078d1
Merge pull request #10976 from Matt-Yorkley/payment-localized-number
...
Require localized_number in Payment class
2023-06-09 18:45:13 +01:00
Konrad
bd505bbee7
Merge pull request #10959 from jibees/10945-white-label-narrow-screen-width-no-marging-on-custom-tab-content
...
[WhiteLabel] Add some margin to custom tab content for a shop
2023-06-09 19:45:04 +02:00
Matt-Yorkley
24200de8dd
Require localized_number in Payment class
...
There seems to be some contexts (jobs for subscriptions) where the Payment class loads but LocalizedNumber is an undefined constant. It lives in the /lib directory so it's not auto-loaded.
2023-06-09 18:16:37 +01:00
Konrad
d0f4c44add
Merge pull request #10938 from jibees/10931-white-label-custom-tab-without-a-title-impossible-to-disable-the-custom-tab
...
[White Label] Validate the presence of a custom tab title before creating it (+ max 20 characters length)
2023-06-09 19:01:13 +02:00
Cillian O'Ruanaidh
5cde4de512
Ignore leading and trailing whitespace in spreadsheet when importing products
2023-06-09 16:23:18 +01:00
Konrad
502b5e8664
Merge pull request #10937 from jibees/10900-white-label-remove-ofn-navigation-for-small-width-screens
...
[White Label] Remove ofn navigation for small width screens as well when option is activated
2023-06-09 16:28:22 +02:00
Konrad
35fef9e7ac
Merge pull request #10876 from dacook/prettier-css-admin
...
Prettier css admin
2023-06-09 16:02:11 +02:00
filipefurtad0
24913476ac
Adds spec for tooltips on orders page
2023-06-09 11:23:42 +01:00
dependabot[bot]
515a9a9b1c
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.1.0 to 5.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.1.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-09 10:02:21 +00:00
Neal Chambers
a65b43d32f
Update .rubocop_todo.yml
2023-06-09 16:39:29 +09:00
Neal Chambers
9a8551e3ea
Shorten Where Statement
2023-06-09 16:39:29 +09:00
Neal Chambers
a35a07b441
Rewrite sum to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
449430cabc
Indent code to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
252697b782
Rewrite If and Unless Statements to be more Readable
2023-06-09 16:39:26 +09:00
Maikel Linke
ec865627d2
Wait for page setup to avoid flaky spec
...
I'm hiding a real bug here. There's a race condition when the cable event of
the finished report is sent before the loading spinner rendered. The
spinner then overwrites the report again. I added a spec for that but
don't have a solution yet.
I also noticed that the loading spinner is not displayed in testing but
we can assert on the CSS class of the container.
2023-06-09 16:22:01 +10:00
Jean-Baptiste Bellet
74fd1814e4
Create a trixeditor controller and broadcast a change event on form
...
Therefore, AngularJS can set form as dirty
+ add associated spec
2023-06-09 08:03:17 +02:00
Maikel Linke
d312a5912a
Style Layout/MultilineMethodCallIndentation
2023-06-09 14:45:06 +10:00
Maikel Linke
828b2f6f44
Replace too long list of arguments with keywords
...
Rubocop was complaining about too many arguments. But
`ApplicationJob#perform` needs all arguments handled in one call. While
we could allow the `perform` method generally to have more arguments,
there could be other methods called `perform` which should still be
scrutinised. Instead, it seems acceptable to me to have more arguments
as long as they are clearly named as keyword arguments. Rails uses this
a lot to document all options including their default values, for
example in Active Storage. It's better then bundling several arguments
in an undocumented hash just to reduce the number of given arguments.
And once we upgraded to Ruby 3.1, we can clean the method calls up as
well. `call(user: user)` becomes `call(user:)` without repetition.
2023-06-09 14:44:54 +10:00
Maikel Linke
e56c06571c
Remove outdated report timeout handling
...
Since we don't wait for the report any more, a timeout is very unlikely
and we don't need special handling for it.
2023-06-09 14:44:54 +10:00
Matt-Yorkley
7caf4b03d4
Improve flakyness on report specs
2023-06-09 14:44:53 +10:00
Matt-Yorkley
b230b37284
Update report email spec
2023-06-09 14:44:53 +10:00
Matt-Yorkley
524d1f0264
Switch to tighter Channel scoping...
...
This is not a normal pattern for setting up ActionCable channels, so it might need some notes. It ensures the broadcasts from the ReportJob are unique not just to the user session but also to the specific tab in the user's browser. Otherwise if the user has two different report pages open in separate tabs with the same session, the broadcast would overwrite the #report-table element in both of them.
2023-06-09 14:44:53 +10:00
Matt-Yorkley
a3ef604797
Run reports in background
2023-06-09 14:44:53 +10:00
Matt-Yorkley
ced959ad6a
Load reports show page without all the legacy javascript
2023-06-09 14:44:53 +10:00
Matt-Yorkley
242c74ceaf
DRY admin javascript imports
2023-06-09 14:44:53 +10:00
Maikel Linke
6803e0a8f9
Fix error on summarising total_units
2023-06-09 09:55:33 +10:00
Maikel Linke
71e4d2c6ed
Spec total_units report column
...
Current reports don't deal with invalid legacy data.
2023-06-09 09:55:33 +10:00
Maikel Linke
00e171a8f1
Reduce indentation in report spec
...
Specs should also test from the outside instead of declaring modules and
test from within those modules.
2023-06-09 09:55:33 +10:00
Jean-Baptiste Bellet
5d43285834
Update all locales with the latest Transifex translations
2023-06-08 17:36:04 +02:00
Filipe
ca03e1596b
Merge pull request #10952 from Matt-Yorkley/full-name
...
Improve nil-safety in variant naming methods
2023-06-08 16:26:28 +01:00
Filipe
c12415a340
Merge pull request #10955 from Matt-Yorkley/bulk-invoice-bug
...
Ensure directory exists before saving invoices pdf
2023-06-08 15:22:27 +01:00
Matt-Yorkley
f4261b85b8
Merge pull request #10940 from Matt-Yorkley/order-tidyup
...
Order class tidyup
2023-06-08 15:06:59 +01:00
Filipe
7974e1eaa6
Merge pull request #10936 from abdellani/fix-order-progressing-automatically-on-BOO
...
fix Viewing an order in state "confirmation" changes the state to "complete"
2023-06-08 14:50:04 +01:00
Jean-Baptiste Bellet
457d5a6c83
Override some css classes, to have a beautiful trix editor toolbar buttons
...
- buttons background are transparent (instead of blue)
- buttons background on hovering are transparent (instead of green)
- disabled buttons cursor is default (instead of pointer)
2023-06-08 11:43:59 +02:00
Jean-Baptiste Bellet
05104841cd
Add some margin to custom tab content via columns css class
2023-06-08 11:36:06 +02:00
Jean-Baptiste Bellet
d1d050e6a4
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
David Cook
e2ba18f828
Set sentence case tab names in Ruby instead of CSS
...
I chose .capitalize instead of .humanize, because the latter has extra features which may not be desired.
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d6cb483f0d
Adjust color to the title of the page
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d7f7ff7436
Remove background, border and adjust margin top
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
905220a055
Add new color: $color-8 #191c1d Near-black
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b865d8c1c0
Copy/Paste file admin/shared/layout under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
51f47fc351
Add border bottom when hovering or selected
...
+ add some padding to separate those borders then
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
1b4236640d
Add border with box-shadow to menu and sub-menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
2057449dac
Add new color: $color-7 #EFF1F2 Light grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ba98039e95
Adjust color to orange when selected or hover
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d51786ac9e
Adjust font size for labels in menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ccd7466ede
No more white on labels but dark grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b163d4a584
Remove background-color on menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
a4d3011e27
Add new color: $color-9 #2E3132 Dark Grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
dd48092728
Prettier file
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
5ee3550ebd
Change case to Sentence case
...
CSS property `capitalize` uppercase all first letter of each words.
I need to use a small trick with `::first-letter` selector
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
eab46b67e3
Copy/Paste file admin/components/navigation under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
e34f4a9971
AdminV3: Remove icon from icon from primary navigation menu
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-06-08 11:24:43 +02:00
Neal Chambers
dde775d2b7
Remove Old Code and Comments
2023-06-08 15:20:04 +10:00
Neal Chambers
3432e30465
Fix Style/UnlessGuard
2023-06-08 15:20:04 +10:00
Neal Chambers
12aa4f9970
Fix Layout/IndentationStyle
2023-06-08 15:20:04 +10:00
Neal Chambers
b04879604a
Rewrite Ternary Expression to Prevent Layout/LineLength
2023-06-08 15:20:04 +10:00
Maikel Linke
4ecbbae55e
Adapt large browser window as default
...
We were really close to that anyway. It simplifies the code a bit.
2023-06-08 13:51:29 +10:00
Maikel Linke
7cf68cd33b
Ensure that specs restore default window size
2023-06-08 13:51:25 +10:00
Maikel Linke
241b307762
Fix typos
2023-06-08 11:34:05 +10:00
David Cook
7d26158e06
Code cleanup
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 11:31:37 +10:00
Maikel Linke
99fbf80b4c
Style Layout/MultilineMethodCallIndentation
2023-06-08 11:15:42 +10:00
Matt-Yorkley
98f78927b7
Update app/jobs/bulk_invoice_job.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 00:56:24 +01:00
Matt-Yorkley
bf051fc35b
Pull checkout-workflow-related callback methods out into the Checkout module which defines checkout state changes
2023-06-07 18:54:20 +01:00
Matt-Yorkley
760bf269ca
Pull validations-related methods out into a separate module
2023-06-07 18:54:20 +01:00
Matt-Yorkley
bed2fe69f6
Update regression tests
2023-06-07 16:39:37 +01:00
jibees
c6b5eda85c
Merge pull request #10951 from openfoodfoundation/dependabot/bundler/faraday-2.7.6
...
chore(deps): bump faraday from 2.7.5 to 2.7.6
2023-06-07 17:34:10 +02:00
Matt-Yorkley
b091a0ed1a
Ensure directory exists before saving pdf
...
These directories can get wiped during deployments
2023-06-07 16:25:53 +01:00
Mohamed ABDELLANI
fbf55cf7bd
Merge pull request #2 from Matt-Yorkley/fix-order-progressing-automatically-on-BOO
...
Fix pre-existing issues with admin order controller
2023-06-07 13:49:06 +01:00
David Cook
3ce48848f0
Prettify the rest
2023-06-07 14:23:57 +02:00
David Cook
548a6f8d2e
Prettify app/webpacker/css/admin/plugins/
2023-06-07 14:23:57 +02:00
David Cook
10c52959ad
Prettify app/webpacker/css/admin/hacks/
2023-06-07 14:23:57 +02:00
David Cook
08dc3e3cbe
Prettify more admin css
...
yarn prettier --write
2023-06-07 14:23:02 +02:00
David Cook
fbf5862c66
Ignore some css subfolders
...
Prettier changes these files dramatically and they're arguably not easier to read.
2023-06-07 14:21:34 +02:00
dependabot[bot]
01dcf068f9
chore(deps): bump rails from 7.0.4.3 to 7.0.5
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.4.3 to 7.0.5.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.4.3...v7.0.5 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 14:12:34 +02:00
Matt-Yorkley
b58b555e38
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
983353e078
Remove dead code
...
I'm pretty sure this was here because advancing the order was adding order errors in some cases
2023-06-07 13:01:37 +01:00
Matt-Yorkley
968bf882c4
Fix flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
daf243996b
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
7a7ab17db4
Improve customer tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
6daf29400f
Improve distribution and line items tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
f3ee10dd5a
Simplify by moving conditional to guard clause
2023-06-07 13:01:37 +01:00
Matt-Yorkley
cf0f148dba
Advance order when creating a shipment
...
This action gets called from the order edit page when adding line items and it's one of the places that needs to advance the order *before* redirecting back to the order edit action
2023-06-07 13:01:37 +01:00
Matt-Yorkley
bb73d70e57
Improve nil-safety in variant naming methods
2023-06-07 12:17:50 +01:00
dependabot[bot]
24343c769e
chore(deps): bump faraday from 2.7.5 to 2.7.6
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.5...v2.7.6 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 09:57:34 +00:00
Filipe
2d28a57c6f
Merge pull request #10922 from jibees/10903-white-label-make-logo-url-link-more-tolerant-in-terms-of-format-and-add-example
...
[White Label] Make logo url link more tolerant in terms of format
2023-06-07 10:00:31 +01:00
Maikel
1c9a09d88d
Merge pull request #10943 from openfoodfoundation/dependabot/bundler/paranoia-2.6.2
...
chore(deps): bump paranoia from 2.6.1 to 2.6.2
2023-06-07 16:31:01 +10:00
Maikel Linke
1ebacf96ad
Ignore accidental spaces around whitelabel URL
2023-06-07 13:12:06 +10:00
Matt-Yorkley
acc34d1deb
Update advance to payment logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e1b37090be
Use _path helper instead of _url
2023-06-07 00:58:43 +01:00
Matt-Yorkley
6e8ed1f612
Hide secondary form until the order has line items
2023-06-07 00:58:43 +01:00
Matt-Yorkley
c7bb24e2a0
Remove dead code and clarify update logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e88843c733
Ensure order number is generated nicely on new records
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Konrad
1b6147db30
Merge pull request #10896 from jibees/10571-bom-orders-not-sorted-by-most-recent-date
...
BOM: Sort by order completed at desc for line items by default
2023-06-06 17:37:54 +02:00
Matt-Yorkley
2bfb57a1a1
Clarify shipments partial inclusion
2023-06-06 14:59:53 +01:00
Matt-Yorkley
8813edaed8
Fix variables in form partial
2023-06-06 14:59:03 +01:00
Jean-Baptiste Bellet
7dc8c4b891
Hide OFN navigation also on small width screens
2023-06-06 14:55:41 +02:00
Jean-Baptiste Bellet
a8b85a65e9
Add context for visiting a path
2023-06-06 14:44:05 +02:00
Jean-Baptiste Bellet
5c3e07db52
Test that OFN navigation is on mobile views as well
2023-06-06 14:44:05 +02:00
dependabot[bot]
10ca09eaef
chore(deps): bump paranoia from 2.6.1 to 2.6.2
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.1...v2.6.2 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-06 10:00:41 +00:00
Jean-Baptiste Bellet
daaeca88e8
Add some helpers to test mobile views
2023-06-06 12:00:16 +02:00
Mohamed ABDELLANI
77554e21fc
move advance_to_payment on order's details page from edit to update
2023-06-06 10:23:01 +01:00
Matt-Yorkley
7c72969792
Move Order #state_changed method out into Checkout concern (alongside order states logic)
2023-06-05 23:54:04 +01:00
Matt-Yorkley
a62e51c0d0
Remove Order #refresh_shipment_rates method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
1a7d70772a
Make Order #products_available_from_new_distribution method private
2023-06-05 23:54:04 +01:00
Matt-Yorkley
3dd4e7ef03
Delegate order updater method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
8a27dd84fe
Make Order #disallow_guest_order method private
2023-06-05 21:30:49 +01:00
Matt-Yorkley
05a715a43a
Remove Order #distribution_set? method
2023-06-05 21:30:46 +01:00
Matt-Yorkley
17b10d10c0
Make Order #deliver_order_confirmation_email method private
2023-06-05 21:30:43 +01:00
Matt-Yorkley
10dbeb32b2
Remove Order #credit_cards method
2023-06-05 21:30:40 +01:00
Matt-Yorkley
b3bd112cdb
Remove Order #shipped_shipments method
2023-06-05 21:30:36 +01:00
Jean-Baptiste Bellet
93cf562d59
Update en.yml
2023-06-05 15:48:02 +02:00
Jean-Baptiste Bellet
5938577bd1
Update custom_tab_spec.rb
2023-06-05 15:43:11 +02:00
Jean-Baptiste Bellet
1594d1c718
Validate custom tab title
2023-06-05 15:41:33 +02:00
Jean-Baptiste Bellet
abe63e5b04
Add context for visiting a path
2023-06-05 12:08:43 +02:00
Jean-Baptiste Bellet
40111910b6
Validates white_label_logo_link on enterprise model
2023-06-05 11:24:07 +02:00
Jean-Baptiste Bellet
4edb159ef8
Avoid flaky spec by matching the array
...
Context: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/5081492387/jobs/9129944001?pr=10896
2023-06-05 10:05:09 +02:00
Jean-Baptiste Bellet
ccb183d60b
Sort by order_date desc for line_items in BOM
...
+ update spec to have different order time
2023-06-05 10:05:09 +02:00
jibees
a785b4d5e0
Merge pull request #10928 from openfoodfoundation/dependabot/bundler/rubocop-1.52.0
...
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
2023-06-05 09:28:04 +02:00
Maikel Linke
16fba20686
Update rubocop todo file
2023-06-05 12:13:35 +10:00
Maikel Linke
1cbb45a618
Style Lint/RedundantSafeNavigation
...
The cop suggested to change more but they were false positives:
* https://github.com/rubocop/rubocop/pull/11915
2023-06-05 12:09:32 +10:00
Maikel Linke
38bd31d0e3
Style Layout/TrailingWhitespace
2023-06-05 10:42:21 +10:00
Konrad
750b6b284d
Merge pull request #10910 from jibees/10902-white-label-for-uploading-custom-logo-use-same-design-as-for-enterprise-logobanner-and-provide-required-image-dimensions
...
[White Label] Backoffice: improve design for logo used in shopfront
2023-06-04 14:50:49 +02:00
dependabot[bot]
78338864d8
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.51.0 to 1.52.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.51.0...v1.52.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-02 09:57:30 +00:00
filipefurtad0
840da55941
Update all locales with the latest Transifex translations
2023-06-02 09:17:23 +01:00
Jean-Baptiste Bellet
880ba85791
Add http to white label logo link if this do not start with http
2023-06-01 17:37:05 +02:00
Jean-Baptiste Bellet
ced8f8aa58
Use shared_examples as we will test many URLs later on
...
"It's a Surprise Tool That Will Help Us Later"
2023-06-01 17:37:05 +02:00
jibees
d63c47e0f1
Merge pull request #10920 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.3
...
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
2023-06-01 17:26:54 +02:00
jibees
fd7d68d0a8
Merge pull request #10919 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.3
...
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
2023-06-01 17:25:58 +02:00
Jean-Baptiste Bellet
2e0191e603
Improve UX: same as enterprise logo and promo image
2023-06-01 17:16:22 +02:00
Filipe
12159edaca
Merge pull request #10833 from Matt-Yorkley/order-angular
...
Remove Angular from admin orders index page
2023-06-01 13:57:39 +01:00
Filipe
2ba0f635f2
Merge pull request #10860 from Matt-Yorkley/order-cycle-deleting
...
Delete exchange variants in bulk when deleting an order cycle
2023-06-01 13:49:32 +01:00
Filipe
d67227deb8
Merge pull request #10812 from Matt-Yorkley/options-values
...
Remove OptionValue and OptionType code
2023-06-01 13:49:16 +01:00
Matt-Yorkley
1128fd9c02
Visual tweak to ship/capture buttons and success feedback
2023-06-01 12:13:12 +01:00
dependabot[bot]
3e46115f79
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 10:00:31 +00:00
dependabot[bot]
e428944849
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.2...v6.0.3 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 09:59:07 +00:00
Matt-Yorkley
e99c328643
Update app/services/variant_units/variant_and_line_item_naming.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
0ac10472cf
Update app/models/spree/line_item.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
7f5d1be792
Guard against unsaved variant's product in OptionValueNamer for product import
2023-06-01 10:12:19 +01:00
Matt-Yorkley
a20277c3a7
Completely remove option_values and option_types from the codebase
2023-06-01 10:12:19 +01:00
Matt-Yorkley
35b41fc7fe
Persist unit_value on variant and "option value text" on variant and line_item and improve related AR callbacks
2023-06-01 10:12:19 +01:00
Matt-Yorkley
bfcf1203ac
Delete dead code
2023-06-01 10:11:20 +01:00
Matt-Yorkley
896e4c45f2
Clarify confusing class
2023-06-01 10:11:20 +01:00
Matt-Yorkley
3e5ecba738
Remove unhelpful Helper
2023-06-01 10:11:20 +01:00
Matt-Yorkley
e5eb622ac7
Cut dead code
2023-06-01 10:11:20 +01:00
Filipe
6b98e2b3cb
Merge pull request #10911 from jibees/10901-white-label-customized-logo-on-small-screens-doesnt-use-the-customized-url
...
[White Label] Small width screens : use the white label link if exists for logo in nav bar
2023-06-01 08:16:53 +01:00
Filipe
61b70a25d9
Merge pull request #10897 from openfoodfoundation/dependabot/npm_and_yarn/mrujs-1.0.0
...
chore(deps): bump mrujs from 0.10.1 to 1.0.0
2023-06-01 08:03:32 +01:00
Filipe
e0d24ed5c0
Merge pull request #10912 from openfoodfoundation/dependabot/bundler/puma-6.3.0
...
chore(deps): bump puma from 6.2.2 to 6.3.0
2023-06-01 07:42:22 +01:00
Filipe
2d4d8e26f5
Merge pull request #10875 from jibees/10561-allow-user-to-create-custom-tab-in-shop-navigation
...
[White Label] Allow user to create custom tab in shop navigation
2023-06-01 07:21:25 +01:00
Maikel
add725b6c0
Merge pull request #10861 from mkllnk/dfc-import
...
Update products with DFC Prototype
2023-06-01 08:48:39 +10:00
Filipe
5f429c77f8
Merge pull request #10791 from dacook/10630-new-brand-colours
...
[admin_v3] New brand colours in admin interface
2023-05-31 16:03:18 +01:00
dependabot[bot]
1b6815515e
chore(deps): bump puma from 6.2.2 to 6.3.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.2.2 to 6.3.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.2.2...v6.3.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-31 10:01:43 +00:00
Jean-Baptiste Bellet
ac30e8b9da
Use the white label link if exists, otherwise, use the main_app.root_path
2023-05-31 10:46:23 +02:00
Filipe
668a573f12
Merge pull request #10908 from filipefurtad0/flaky_simple_spec
...
Changes date through keystrokes; removes Retry option
2023-05-30 16:43:36 +01:00
filipefurtad0
c5358b1303
Changes date through keystrokes; removes Retry option
2023-05-30 10:02:44 +01:00
jibees
7b6077d01f
Merge pull request #10905 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.9
...
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
2023-05-29 14:57:34 +02:00
dependabot[bot]
841a021bc4
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.8 to 1.2.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.9/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-29 09:59:12 +00:00
jibees
7ea2aa699d
Merge pull request #10904 from mkllnk/update-job-spec
...
Simplify background report spec after rspec fix
2023-05-29 10:19:31 +02:00
Maikel Linke
3fa62ceccf
Simplify background report spec after rspec fix
...
The rspec-rails gem had an issue which was fixed in the last release.
Now we can remove my workaround and simplify the spec.
2023-05-29 13:25:44 +10:00
David Cook
24c407f920
Merge pull request #10898 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.1
...
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
2023-05-29 13:09:15 +10:00
Maikel Linke
77f716306d
Remove redundant test
2023-05-29 10:07:34 +10:00
Konrad
fff02a7ddb
Merge pull request #10893 from jibees/10853-white-label-remove-ofn-logo-on-navigation-menu-for-small-width-screens
...
[White Label] Small width screens: Hide OFN logo and use the customized logo if activated
2023-05-28 12:00:49 +02:00
Maikel Linke
0dcd87dda9
Update stock and SKU from DFC
...
The input has been observed with the nginx access log including
$request_body when the DFC Protoype pushed an update.
2023-05-28 10:39:08 +02:00
Maikel Linke
375b3a3cb0
Update variant's quantity from DFC
2023-05-28 10:39:08 +02:00
Maikel Linke
48a52582e6
Update variant description with DFC description
...
We used the name before because the DFC Prototype only displays the
description.
2023-05-28 10:39:08 +02:00
Maikel Linke
63837381e0
Update DFC test data with observation
...
This request came from the current DFC prototype. The changes are
probably implementing DFC v1.7.
I observed by including `$request_body` in the nginx log on the staging
server.
2023-05-28 10:39:08 +02:00
Maikel Linke
50ef06c973
Name DFC test data to clarify content
...
The DFC has several products like PhysicalProduct and SuppliedProduct.
Here we have a supplied product.
2023-05-28 10:39:08 +02:00
Maikel Linke
7344eb678b
Remove now unused helper
...
It was only used in controller specs which were all converted to request
specs.
2023-05-28 10:39:08 +02:00
Maikel Linke
dde4ea9334
Convert CatalogItems controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
207a15e55c
Convert SuppliedProducts controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
742468efd2
Convert EnterpriseController spec to request spec
...
Also testing request of unrelated enterprise instead of non-existing
enterprise because authorisation is important to test.
2023-05-28 10:39:08 +02:00
Maikel Linke
d338c61d2c
Convert PersonsController spec request spec
...
It's much more realistic and also tests the routing and authentication.
Besides using real authentication I also improved the matchers.
2023-05-28 10:39:08 +02:00
Maikel Linke
67c29dd38f
Activate DFC provider engine, remove feature toggle
2023-05-28 10:39:08 +02:00
Jean-Baptiste Bellet
01b3b3b5bb
Add some specs around tab for a shop
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6b29f7e3c5
Sanitize content with a new TrixScrubber
...
specifically made for trix editor with its allowed tags
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
f26ecdf4f9
Don't need to pass the order through the nested view
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6775e0b8f1
Add custom_ prefix to avoid name collision
...
One can name the custom tab `shop` which can be confusing.
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
9e67bd5824
Use specified values to be sure they aren't empty
2023-05-26 15:19:27 +02:00
dependabot[bot]
2f1e3a5c96
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.0 to 7.1.1.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.0...v7.1.1 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 10:01:59 +00:00
dependabot[bot]
856fcd9e18
chore(deps): bump mrujs from 0.10.1 to 1.0.0
...
Bumps [mrujs](https://github.com/KonnorRogers/mrujs ) from 0.10.1 to 1.0.0.
- [Changelog](https://github.com/KonnorRogers/mrujs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/KonnorRogers/mrujs/compare/v0.10.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: mrujs
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 09:58:38 +00:00
Matt-Yorkley
e34c2acba8
Move CablecarResponses include to ApplicationController
2023-05-26 10:35:41 +01:00
Matt-Yorkley
2373d044f7
Update app/services/orders_bulk_cancel_service.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-26 10:33:23 +01:00
Jean-Baptiste Bellet
a24604f146
Remove unused enterprise declaration
2023-05-26 10:24:11 +02:00
David Cook
14345ef1fa
Change warning orange to Mojo
...
> That way we only have one orangy/red colour and we start simplifying things.
2023-05-26 15:11:23 +10:00
David Cook
0df7c45a61
Change warning red to Mojo
...
Some templates still had this colour hardcoded. They are using angular so I didn't spend time updating them.
2023-05-26 15:11:23 +10:00
David Cook
dcf857cafb
Move warning colour definition to CSS
...
This also changes the orange to red, but that's part of the plan.
2023-05-26 15:11:23 +10:00
David Cook
e674c53535
Change error red color to Mojo
...
color-5 is used for error messages.
2023-05-26 15:11:23 +10:00
David Cook
719a704985
Change blue colour as per design
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/10630#issue-1644928392
2023-05-26 15:11:23 +10:00
David Cook
60ec24b92b
Use variables for spree-blue
...
Aka 'Havelock Blue', which is going to be changing.
2023-05-26 15:11:23 +10:00
David Cook
e928e74ae6
Use different palette for admin styles v3
...
Note that mail.css is still referring to the old palette.
2023-05-26 15:10:49 +10:00
David Cook
31fa9c2c04
Add admin_style_v3 feature toggle
2023-05-26 15:10:27 +10:00
David Cook
01b3901b08
Add admin_style_v3
...
Individual files may be copied in order to replace the old files.
NOTE: these may need manually re-syncing. If any of the copied files have changed on master in the meantime, we'll need to manaully review to consider bringing those changes to the new design.
2023-05-26 15:10:27 +10:00
David Cook
9051318147
Move colour palette to new file
...
This seemed like a good separation which will probably help with the upcoming changes.
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-05-26 15:09:59 +10:00
Maikel
b013d3f2d4
Merge pull request #10895 from jibees/10894-flaky-speccontrollersapiv0order_cycles_controller_specrb89
...
Fix flaky spec: Prefer using `match_array` over `eq` to compare array
2023-05-26 14:06:14 +10:00
Maikel Linke
2e52a633ae
Acknowledge new style violations
2023-05-26 13:34:48 +10:00
Maikel Linke
15ef826ac1
Style Style/ClassAndModuleChildren
2023-05-26 13:27:34 +10:00
Maikel Linke
f674d5cd37
Style Layout/TrailingEmptyLines
2023-05-26 13:26:30 +10:00
David Cook
875f68b0e2
Update one more translation
2023-05-26 11:46:22 +10:00
Jean-Baptiste Bellet
cf9342f2c4
Prefer using match_array over eq to compare array
...
As we don't need order: https://rubydoc.info/github/rspec/rspec-expectations/RSpec%2FMatchers:match_array
2023-05-25 15:24:25 +02:00
Jean-Baptiste Bellet
eea1db4c4a
Hide OFN logo and use the customized logo if activated
2023-05-25 15:17:04 +02:00
jibees
8dde81c498
Merge pull request #10891 from openfoodfoundation/dependabot/bundler/test-unit-3.5.9
...
chore(deps): bump test-unit from 3.5.8 to 3.5.9
2023-05-25 13:34:38 +02:00
dependabot[bot]
2084d84c7a
chore(deps): bump test-unit from 3.5.8 to 3.5.9
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.8 to 3.5.9.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.8...3.5.9 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-25 09:58:28 +00:00
Filipe
8b7ca292af
Merge pull request #10884 from openfoodfoundation/10882-cookie-banner-is-displayed-on-every-page-even-after-accepting
...
Do not show cookies banner once user accept it
2023-05-25 10:36:27 +01:00
Jean-Baptiste Bellet
f961548da2
Deactivate file upload for trix editor
...
Source: https://benborgers.com/posts/trix-disable-files
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
e434eb17f0
Use full width since we use a WYSIWYG editor with toolbar
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb211bfc84
Allow HTML via trix editor for custom tab content
...
+ update spec as well
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
4dede3b361
Add trix editor
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6e677f15ec
Can delete custom tab if uncheck the checkbox
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
f0665b0862
Add custom tab on shop
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
916b2313ab
Some links does not include _panel suffix. Add if needed.
...
Yep. Sounds like a hack.
+ Use the right URL anchor with `_panel` in href for each tab
+ update specs
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
fc21fdb485
Customize default tab: could be either shop or home
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6b1d1ddbce
On order cycle change, go to shop panel
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
a28a792642
Allow communication between controllers via event
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb6b1e59f9
Use tabs_and_panels_controller.js instead of PageSelectionCtrl
...
Prefer StimulusJS over Angular
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
925b0e0308
Add a form in admin to create/update a custom tab for an enterprise
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
839419791f
Create CustomTab model, that belongs to an enterprise
2023-05-25 09:19:51 +02:00
David Cook
f890d9ceb4
Update all locales with the latest Transifex translations
2023-05-25 17:12:10 +10:00
jibees
abc0a29ddb
Merge pull request #10889 from mkllnk/dead-code
...
Remove dead reference to removed model
2023-05-25 09:10:14 +02:00
Maikel Linke
86c35fe2dc
Remove dead reference to removed model
2023-05-25 16:13:33 +10:00
Filipe
6d032002f1
Merge pull request #10750 from jibees/10560-allow-hide-of-groups-tab-in-shop-navigation
...
White Label: allow hide of groups tab in shop navigation
2023-05-24 21:11:04 +01:00
filipefurtad0
ca107c036c
Enables caching for cookies_spec.rb
2023-05-24 19:46:28 +02:00
jibees
e60376e6bd
Merge pull request #10885 from openfoodfoundation/dependabot/bundler/faraday-2.7.5
...
chore(deps): bump faraday from 2.7.4 to 2.7.5
2023-05-24 15:18:10 +02:00
jibees
d704157fef
Merge pull request #10886 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.1.0
...
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
2023-05-24 15:17:16 +02:00
dependabot[bot]
b985ab8d99
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.0.0 to 4.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:10:08 +00:00
dependabot[bot]
d60ba96fe9
chore(deps): bump faraday from 2.7.4 to 2.7.5
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.4 to 2.7.5.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.4...v2.7.5 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:08:17 +00:00
Jean-Baptiste Bellet
3cd53cbd41
Adds some keys to this cached element, due to cookie banner
...
Once the user accept the cookie, we should not show the cookie banner element. This is handled via `app/helpers/footer_links_helper.rb#cookies_policy_link` and boolean:
```
!Web::CookiesConsent.new(cookies, request.host).exists? && Spree::Config.cookies_consent_banner_toggle
```
2023-05-24 10:45:06 +02:00
Maikel Linke
b4deb21872
Bump Ruby from 3.0.3 to 3.1.4
...
Major 3.1 highlights:
* https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/
2023-05-24 16:52:34 +10:00
Maikel
32d425dd58
Merge pull request #10880 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.0.0
...
Bump knapsack_pro from 3.11.0 to 4.0.0
2023-05-24 14:05:09 +10:00
Maikel
ce1317933b
Merge pull request #10815 from Pauloparakleto/issue-7483
...
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
2023-05-24 11:57:44 +10:00
Maikel
340f10b323
Merge pull request #10539 from filipefurtad0/spec_for_enterprise_fee_selection_tax_inherit
...
Adds a spec to check enterprise fees creation
2023-05-24 11:29:27 +10:00
Maikel
8c11bf3033
Merge pull request #10839 from mkllnk/valid-email
...
Validate user's email address
2023-05-24 10:37:00 +10:00
Konrad
0854287b92
Merge pull request #10744 from jibees/10556-remove-ofn-header-banner-in-order-confirmation-emails
...
White Label: remove OFN banner from order confirmation emails when `hide_ofn_navigation` is activated for the shop
2023-05-24 01:14:16 +02:00
dependabot[bot]
6dc1cb6baa
Bump knapsack_pro from 3.11.0 to 4.0.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.11.0 to 4.0.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.11.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-23 10:01:38 +00:00
Maikel Linke
ef3422bf58
Update syntax and clarify use of outdated gem
2023-05-23 08:23:58 +02:00
Maikel Linke
90cbac7176
Validate email domains
...
The gem checks the DNS system for a valid domain entry.
2023-05-23 08:23:58 +02:00
Maikel Linke
ffc45f77cf
Validate user email syntax on change
...
We probably have invalid entries in the database and we don't want these
records to suddenly become invalid. People would not be able to log in.
2023-05-23 08:23:58 +02:00
Maikel Linke
101b9025b4
Spec user email validation
...
The pending spec addresses:
* https://github.com/openfoodfoundation/openfoodnetwork/issues/10808
2023-05-23 08:23:58 +02:00
Konrad
b56b36f617
Merge pull request #10859 from filipefurtad0/change_voucher_default_message_en
...
[Vouchers] Updates warning_forfeit_remaining_amount default message
2023-05-23 08:20:41 +02:00
filipefurtad0
5e248aa715
Improving shared_example naming
2023-05-22 12:27:04 +01:00
filipefurtad0
554d515875
Introduces prefix to simplify assertions
2023-05-22 12:27:04 +01:00
Matt-Yorkley
459ef5f0d1
Only delete related exchange variants if exchange is outgoing
2023-05-22 11:09:29 +01:00
Jean-Baptiste Bellet
0bec7562a0
When hide_groups_tab is set to false, do not display group in shopfront
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-05-22 10:29:57 +02:00
Jean-Baptiste Bellet
0d98ec8f4c
In admin, add form to set hide_groups_tab attribute
...
+ add specs
2023-05-22 10:29:56 +02:00
Jean-Baptiste Bellet
38cc8a89d1
Add hide_groups_tab to Enterprise model
2023-05-22 10:29:56 +02:00
Matt-Yorkley
7c5067ff42
Update "special instructions" note tooltip and add missing test coverage
2023-05-21 14:06:14 +01:00
Matt-Yorkley
005d95e882
Fix "Resend Confirmation" link and add missing test coverage
2023-05-21 13:33:29 +01:00
Matt-Yorkley
dcdcdb4fc0
Align filter buttons centrally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
abf00353ea
Permit explicit params
2023-05-21 00:15:32 +01:00
Matt-Yorkley
be1ed2bbcf
Update tomselect multiselect styling
2023-05-21 00:15:32 +01:00
Matt-Yorkley
52450028a1
Fix checkbox alignment
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d50ac4bf45
Reinstate dropdown-with-prepend
2023-05-21 00:15:32 +01:00
Matt-Yorkley
4ddde65a04
Reimplement saving and restoring submitted search filters between page loads
2023-05-21 00:15:32 +01:00
Matt-Yorkley
7d33e0f74d
Allow programmatically refreshing flatpickr element via "flatpickr:change" event after changing the select's value externally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
2ba2a826db
Clean up event handlers on disconnect in Flatpickr controller
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d64a9afece
Replace angular ofn-with-tip directive on capture/ship buttons
2023-05-21 00:15:32 +01:00
Matt-Yorkley
770880c062
Update specs
2023-05-21 00:15:32 +01:00
Matt-Yorkley
310577c49d
Close dropdown after selection with multiselect
...
This conforms with the previous select2 multiselect behaviour
2023-05-21 00:15:32 +01:00
Matt-Yorkley
c3cf79f5ef
Delete angular ordersCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
71c4f2a5be
Update styling on multiselect tabs for tom-select
2023-05-21 00:15:32 +01:00
Matt-Yorkley
95f1643cec
Combine related reflex actions
2023-05-21 00:15:32 +01:00
Matt-Yorkley
bee46720f4
Combine bulk action controllers and pass reflex as an argument
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5930d0c1f5
Make bulk actions more generic
2023-05-21 00:15:32 +01:00
Matt-Yorkley
55d9deb5bd
Update order cancelling bulk action
2023-05-21 00:15:32 +01:00
Matt-Yorkley
134f1ab151
Replace angular bulkInvoiceCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
27290e5b57
Make modal controller creatable and destroyable
2023-05-21 00:15:32 +01:00
Matt-Yorkley
25aecfa5b9
Add reflex for shipping orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
e58a37f65b
Add reflex for capturing orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
61849d84e7
Extract order capturing to OrderCaptureService
2023-05-21 00:15:32 +01:00
Matt-Yorkley
73b41154cc
Update admin flashes
2023-05-21 00:15:32 +01:00
Matt-Yorkley
048df6230b
Remove angular from admin orders index page
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5ad68f25e3
Handle old jquery_ujs buttons
2023-05-21 00:15:30 +01:00
Matt-Yorkley
3df166fb2f
Drop jquery_ujs
2023-05-20 19:47:41 +01:00
Matt-Yorkley
59fd4ad251
Tidy up JS imports
2023-05-20 19:47:41 +01:00
Matt-Yorkley
48a8f57262
Prep admin JS
2023-05-20 19:47:41 +01:00
Matt-Yorkley
f181b35a90
Add minimal admin js setup
2023-05-20 19:47:41 +01:00
Matt-Yorkley
c4bc0a7bbd
Rename select-all-controller
2023-05-20 19:47:41 +01:00
paulo-felipe
3a35f12801
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group together sample tests to avoid rebuilding browser state.
2023-05-19 19:55:27 -03:00
paulo-felipe
c9ab092f7c
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add back comment explaining bill address has been pre-loaded.
2023-05-19 19:55:27 -03:00
paulo-felipe
1e1d4b07d1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Remove the old chained smoke test.
2023-05-19 19:55:27 -03:00
paulo-felipe
bd05f40b17
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too long offense and separate variables from expectations.
2023-05-19 19:55:27 -03:00
paulo-felipe
105d695f18
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check creation of standing line items when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
4df550fcf1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check basic Subscription properties when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
49ceec8b8e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
share common before action Create subscription between samples.
2023-05-19 19:55:27 -03:00
paulo-felipe
03aade4072
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
It has selector for price, input for quantity and selector for total price.
2023-05-19 19:55:27 -03:00
paulo-felipe
f0da85d723
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
2023-05-19 19:55:27 -03:00
paulo-felipe
8c709e13e0
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too lng offense.
2023-05-19 19:55:27 -03:00
paulo-felipe
c63a8d12f7
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product and click next button.
2023-05-19 19:55:26 -03:00
paulo-felipe
5a5aa4c067
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product.
2023-05-19 19:55:26 -03:00
paulo-felipe
5776bdb31c
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product.
2023-05-19 19:55:26 -03:00
paulo-felipe
b0623ab4de
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product.
2023-05-19 19:55:26 -03:00
paulo-felipe
f05e2618be
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and click next button without adding at least one product.
2023-05-19 19:55:26 -03:00
paulo-felipe
35ce463811
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page.
2023-05-19 19:55:26 -03:00
paulo-felipe
7efc68281e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when using copy button to fill in ship address.
2023-05-19 19:55:26 -03:00
paulo-felipe
aa16110e9a
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address. MOve scenario to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
39a76861f3
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
79ff13e8ba
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Move on second page to a before action and clearing some elements of bill address to a before action. Let the unit test with the action isolated.
2023-05-19 19:55:26 -03:00
paulo-felipe
573ab1beb0
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on second page when clearing some elements of the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
384ad1ba12
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group context for first page scenarios. Extract common customer actions to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
77857a0168
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when date field is filled. It goes to the next page with preloaded data.
2023-05-19 19:55:26 -03:00
paulo-felipe
47b0d626e2
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen describe it better as per reviewer suggestion.
2023-05-19 19:55:26 -03:00
paulo-felipe
0bf7e53ce4
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen.
2023-05-19 19:55:26 -03:00
Konrad
fed7c3da51
Merge pull request #10761 from rioug/vouchers-any-amount
...
[Vouchers] Flat rate of any amount
2023-05-19 17:39:33 +02:00
Matt-Yorkley
a8559e621f
Simplify exchange variant callback and prefer delete over destroy
...
Delete is faster than destroy but should only be used if the object has no callbacks or touches.
2023-05-19 11:26:33 +01:00
Matt-Yorkley
434c9ae110
Delete exchange variants in bulk when deleting an order cycle
2023-05-19 10:46:55 +01:00
David Cook
9d7316c553
Use a fixed value for voucher factory
2023-05-19 17:19:54 +10:00
Maikel Linke
37441be371
Update translations
2023-05-19 14:33:23 +10:00
Maikel
0d403f4087
Merge pull request #10814 from Matt-Yorkley/serializer-eager-loading
...
Improve eager-loading on admin products page
2023-05-19 14:31:25 +10:00
Maikel
f943b411c5
Merge pull request #10823 from abdellani/fix-file-name-used-as-parameter
...
[Security] Validate product import file path
2023-05-19 14:28:09 +10:00
Maikel
7af14e37fa
Merge pull request #10488 from mkllnk/dfc-connector
...
Serialize DFC catalog items with DFC Connector
2023-05-19 11:31:23 +10:00
filipefurtad0
8d2885e147
Updates spec after merging #10512
2023-05-18 16:04:30 +01:00
filipefurtad0
51b144f174
Covers editing into invalid combinations
2023-05-18 15:59:48 +01:00
filipefurtad0
4e2095f0fb
Tests enterprise fee creation
...
...when inheriting tax category from product
as shared examples
2023-05-18 15:59:48 +01:00
Filipe
3d1b0816ed
Merge pull request #10512 from abdellani/fix-tax-not-charged-when-tax-category-set-to-inherit-from-product
...
Prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-18 13:43:14 +01:00
Konrad
39bb1f6f41
Merge pull request #10832 from Matt-Yorkley/cloning
...
Clone all ExchangeVariant objects in bulk
2023-05-18 14:32:30 +02:00
filipefurtad0
c99829e457
Updates spec to reflect change on en.yml
2023-05-18 12:11:37 +01:00
filipefurtad0
7ea3834900
Updates warning_forfeit_remaining_amount default message
2023-05-18 11:57:15 +01:00
David Cook
360a241402
Style fix
2023-05-18 10:07:52 +10:00
Filipe
0d23b63bbd
Merge pull request #10779 from dacook/10634-remove-admin_style_v2
...
10634 Remove admin_style_v2 feature
2023-05-17 15:37:05 +01:00
Konrad
19caadb1a0
Merge pull request #10800 from dacook/remove-localisation
...
Also remove localized number logic from weight calculator
2023-05-17 14:57:26 +02:00
David Cook
c0c123a92a
Remove localized number logic from weight calculator
...
Follow-on from a46eef291c
2023-05-17 14:10:58 +02:00
Konrad
f26bef5f98
Merge pull request #10813 from saunmanoj888/fix-fullname-search-issue-on-bulk-orders
...
Fix searching issue with full name on bulk order management
2023-05-17 13:58:04 +02:00
saunmanoj888
aee7645e29
Fix searching issue with full name on bulk order management
2023-05-17 13:14:10 +02:00
Konrad
02873d7596
Merge pull request #10817 from Matt-Yorkley/permissions-scoping
...
Scope orders before bulk actions
2023-05-17 12:44:07 +02:00
Matt-Yorkley
e1b0a03819
Scope orders before bulk actions
2023-05-17 12:03:40 +02:00
Jean-Baptiste Bellet
2336981ca0
Do not display OFN banner on order confirmation email if white label
2023-05-17 11:35:18 +02:00
Jean-Baptiste Bellet
dfafbfe996
Create an order confirmation email preview of the last completed order
...
Available on `/rails/mailers/order_mailer/confirm_email_for_customer`
2023-05-17 11:35:06 +02:00
Jean-Baptiste Bellet
f7d06fe0e8
Do not display OFN banner on subscription confirmation email if white label
...
+ add specs that test for the presence of the footer logo which is in the header (I know it's a bit contradictory)
2023-05-17 11:34:35 +02:00
Jean-Baptiste Bellet
3ed89fc2db
Create a subscription confirmation email preview of the last completed order
...
Available on: `/rails/mailers/subscription_mailer/confirmation_email`
2023-05-17 11:34:16 +02:00
Maikel Linke
eaf3bd0bae
Update spec after new import file validation
2023-05-17 15:18:29 +10:00
Mohamed ABDELLANI
fcb8550cb1
extract file path sanitizer to an independent class
2023-05-17 15:09:48 +10:00
Mohamed ABDELLANI
4d5ba6a7e6
add file path validation
2023-05-17 15:09:48 +10:00
Maikel Linke
a0d05b26d1
Spec current product import vulnerabilities
...
I didn't use pending specs but deliberately passing specs on wrong
behaviour. This is not how it should be but how it is at the moment.
2023-05-17 15:09:01 +10:00
Konrad
4a66b62fa7
Merge pull request #10825 from jibees/10824-remove-feature-toggle-on-white-label-feature
...
Activate white label feature
2023-05-16 13:50:58 +02:00
Maikel
16329e953f
Merge pull request #10844 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.0
...
Bump jasmine-core from 4.6.0 to 5.0.0
2023-05-16 17:50:39 +10:00
Gaetan Craig-Riou
abf2105df7
Admin::VoucherController check enterprise permission
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
355af9e818
Per review comment, build enterprise instead of create
...
Speed up testing by removing unnecessarily created record
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b585f77be4
Make enterprise mandatory for a voucher
...
It should have already been the case...
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
2d8fa24862
Add a voucher factory
...
As vouchers are getting more complicated, it makes sense to use a
factory to simplify writing test.
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b427e420ce
Update admin pages to allow entering an amount
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
15eee8175e
Add amount to voucher
...
Change value to amount to be more consistent
2023-05-16 16:19:59 +10:00
Maikel
10c918be75
Merge pull request #10732 from mkllnk/report-email
...
[Hidden] Notify about completed report with download link via email
2023-05-16 10:25:23 +10:00
Maikel
a979f7c8df
Merge pull request #10587 from rioug/10432-vouchers-bare-minimum-checkout
...
10432 vouchers bare minimum checkout
2023-05-16 09:19:06 +10:00
Maikel Linke
08aff56e20
Expire report files after 1 week, maximum for S3
...
We didn't see this in tests which use disk storage. But AWS S3 has a
maximum of one week for URL expiry.
2023-05-15 19:41:45 +02:00
Maikel Linke
5ae04a5a3e
Hide report link which only works at unknown time
...
It was bad UX to show a link that doesn't work straight away. At the
time, it was the only way to download the report but now we send an
email which is a much better way to go.
I leave the rest of the code because we want to implement a reflex which
shows the download link once it's ready.
2023-05-15 19:41:45 +02:00
Maikel Linke
299bc253a4
Expire report download links in a month, not 5mins
2023-05-15 19:41:45 +02:00
Maikel Linke
8a8c53ceee
Add ReportMailer preview for devs
2023-05-15 19:41:45 +02:00
Maikel Linke
860fe85af9
Add report download link to email notification
...
I added a system spec to verify that the download link can be generated
within the mailer in a background job. ActiveStorage is a bit particular
when it comes to genererating URLs and depending on the situation it may
generate a redirect URL, a proxy URL or link directly to the storage.
But we want a redirect URL here.
2023-05-15 19:41:45 +02:00
Maikel Linke
cf5a8a26ce
Notify only about slow reports
...
It would be annoying to get an email for reports which display on the
screen immediately.
2023-05-15 19:41:45 +02:00
Maikel Linke
1f4af7f990
Send (dummy) email when background report is done
...
I'll fill it out in future commits.
2023-05-15 19:41:45 +02:00
Jean-Baptiste Bellet
aaa9bac4dd
Remove white_label feature toggle
...
White label is now activated for everyone.
+ add mock for `spec/controllers/spree/orders_controller_spec.rb`
2023-05-15 17:10:50 +02:00
jibees
d43678c68b
Merge pull request #10827 from filipefurtad0/logging_out_spec
...
Adds test case for logging out
2023-05-15 15:33:56 +02:00
Jean-Baptiste Bellet
ec0cbc5bf9
Avoid warning by being more precise about *.erb files
2023-05-15 15:29:28 +02:00
jibees
a1e4c45daa
Merge pull request #10843 from openfoodfoundation/dependabot/bundler/rubocop-1.51.0
...
Bump rubocop from 1.50.2 to 1.51.0
2023-05-15 15:03:24 +02:00
jibees
edeedc0704
Merge pull request #10841 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.8
...
Bump @floating-ui/dom from 1.2.7 to 1.2.8
2023-05-15 15:02:22 +02:00
jibees
d2539b34e0
Merge pull request #10840 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.7
...
Bump rails-i18n from 7.0.6 to 7.0.7
2023-05-15 15:01:12 +02:00
jibees
fea3957481
Merge pull request #10845 from openfoodfoundation/dependabot/bundler/test-unit-3.5.8
...
Bump test-unit from 3.5.7 to 3.5.8
2023-05-15 15:00:03 +02:00
jibees
b183832fbb
Merge pull request #10842 from openfoodfoundation/dependabot/bundler/capybara-3.39.1
...
Bump capybara from 3.39.0 to 3.39.1
2023-05-15 12:22:59 +02:00
dependabot[bot]
8a352132a0
Bump test-unit from 3.5.7 to 3.5.8
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.7 to 3.5.8.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.7...3.5.8 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:55 +00:00
dependabot[bot]
0e59a5db91
Bump jasmine-core from 4.6.0 to 5.0.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.6.0 to 5.0.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.6.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:22 +00:00
dependabot[bot]
340fe91e07
Bump rubocop from 1.50.2 to 1.51.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.2 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.2...v1.51.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:15 +00:00
dependabot[bot]
6c126cfc33
Bump capybara from 3.39.0 to 3.39.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.0 to 3.39.1.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.0...3.39.1 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:59:19 +00:00
dependabot[bot]
82c6eaab4e
Bump @floating-ui/dom from 1.2.7 to 1.2.8
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.7 to 1.2.8.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.8/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:51 +00:00
dependabot[bot]
d4918893a7
Bump rails-i18n from 7.0.6 to 7.0.7
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.6 to 7.0.7.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:24 +00:00
jibees
1e05bc5b5c
Merge pull request #10789 from jibees/10770-bom-cancelling-an-order-always-restocks-the-line-item
...
BOM: when deleting the last item of order that leads to order cancellation, take into account the restock items checkbox
2023-05-15 09:50:13 +02:00
Mohamed ABDELLANI
7f52684488
add check_calculators_compatibility_with_taxes before running enterprise bulk update
2023-05-15 07:35:52 +01:00
Gaetan Craig-Riou
5eb6097101
Fix error handling when creating a voucher adjustment
...
I wrongly assumed that `voucher.create_adjustment` would return nil
if failing to create an adjustment. I will in fact return an
adjustment object with errors.
2023-05-15 13:42:40 +10:00
David Cook
ccff3379ea
Update schema.rb
...
On a freshly mirrored prod db, I found these changes.
I don't know why.. but hopefully this is correct.
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
d29119f5c5
Remove non need belongs_to associations from Adjustments
...
It turns out the "tax_rate" association isn't used and wasn't working.
Same for the "voucher" one, which I added to be consistent with existing
code.
Both of these weren't caught by the specs because you can't test associations
with a custome relation with 'shouda-matchers' see: https://github.com/thoughtbot/shoulda-matchers/issues/981
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b67f5ae154
Fixing Rubocop issue
...
My editor automatically remove blank character on empty line, that's
why rubocop got grumpy here.
2023-05-15 13:42:40 +10:00
Matt-Yorkley
9b1725d39f
Fix model name in adjustment association
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b80274f49d
Per review comment, Use named value on voucher submit button to distinguish between submission types
...
The voucher apply button is inside form that has another a submit button,
it leads to a weird situation where either one will submit the whole
payments page form. Adding a named parameter on the voucher apply button
means we can distinguish between the two by checking for the presence
of params[:apply_voucher].
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
92bcd937dc
Per review comment, remove form object from the partial
...
This partial is rendered inside another <form> element, nested form
don't work.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
0a249d7722
Fix ButtonEnableToggleController to remove hacky button disable
...
As per review comment, use data-disable-with="false" do prevent Rails
from automatically enabling the "Apply" button. We can then remove
the timeout hack.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
236f6926d9
Cleaning up left over TODOs
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
aa526a639c
Checkout payment page, enable voucher "apply" button when code entered
...
The "apply" button is disabled by default. If left enabled, a customer
could try to apply an empty voucher, which results in system trying
to move to the order summary step, an unexpected behaviour!
We only enable the button when something is entered in the input.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
e5f14177d3
Fix rubocop warning
...
I guess the new cops are effective :)
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
815dcbcefe
Fix translations
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
a2e1e6ca33
Review comment, use dig to access voucher_code param
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
2f1fe6d096
Fix rubocop warning
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
56e981d300
Refactor Voucher to get rid of CalculatedAdjustments
...
Voucher adjustment have complicated calculation that prevent us from
using Spree::Calculator, and we need to override CalculatedAdjustments
method, so no point using it.
We still keep the same methods to stay as consitent as possible in
regards to adjustments
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
43ab881181
Rename order association to voucher_adjustments
...
The name vouchers is a bit confusing as the order is linked to a
voucher adjutment and not the actual voucher
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
fe9b94a80e
Fix cart disappearing bug after adding a voucher
...
The split checkout page uses `mrujs` and `CableCar` to set the form as
a remote one and perform `CableCar` operation if any : https://mrujs.com/how-tos/integrate-cablecar
The previous solution broke the cart handled by angularJS, it looks like
`morpdom` (https://mrujs.com/references/remote-forms-and-links Navigation Adapter section )
was doing something that angularJS didn't like when redirecting to
the current page.
With the power of `CableCar`, we now replace the #voucher-section on the
split checkout page instead of doing a redirect.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
94294fa161
Voucher adjustment, add ordering by created_at
...
It gives us a consistent result when calling #vouchers
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
a1ad25f217
Fix failing specs
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
bb9d835bd8
Fix rubocop warning
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
87cc525d27
Refactor #vouchers
...
Use "has_many" instead of a method
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
4b5d6d7eac
Fix voucher adjustments association
...
Add missing, "inverse_of" and "dependent" options. Use :nullify as
for "dependent" because we would want to keep the adjustments on order
even if the voucher is deleted.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
58469adfeb
Adjustments spec, add association test
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
5064bf5383
Allow voucher adjustment to be created with an amount of 0
...
Although unlikely, we should still be able to create a voucher amount
with. This can happen if the order.total is for instance.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
9789911523
Rework how voucher are applied to an order and handle tax calculation
...
At the time when we can apply a voucher to an order (payment step) we
don't have any data on possible taxes and payment fees. These are
calculated when we move to the summary step. So voucher are applied in
two step:
- create an "open" voucher adjustment on the order when a customer enters
a voucher code.
- when we move to the summary step, recalulate the amount and
possible tax for the voucher adjustment, once taxes and payment fees
have been included in the order. And then close the original and update
order to reflect the changes
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
d157d91054
When voucher cover more than order total, use only amount needed
...
The checkout payment step will also show a warning.
The amount used is stored in the adjustment created, so we will be able
to track how much has been used down the line.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
3f609d3842
Add error message if adding a voucher fails
...
It's not really useful to the user but better than failing silently
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
596c775af6
Add controller spec to cover voucher in split checkout
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74e0b0f6b5
Add voucher adjustment loading to CheckoutCallbacks
...
This is needed so the voucher is loaded properly when the "checkout"
partials are render via cable_car.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74a8730f04
Highlight voucher on order summary step
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
856386fcb0
SplitCheckoutController refactor add_voucher
...
Now all redirection/render_error happen in #update, it makes it
easier to understand.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
e487ed0532
Add link to remove voucher when a voucher has been applied
...
Improve styling to match the design
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
b6213b25e9
add acts_as_paranoid to voucher
...
This is so the relation
`belongs_to :originator, -> { with_deleted }, polymorphic: true`
setup in Spree::Adjustement works as expected.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
a9d9b33f7d
First take at adding a voucher to an order
...
Use voucher.create_adjustment to add an adjustment to the order
Currently doesn't take into account tax part
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
3ec58d8791
Add #vouchers, return an array of voucher adjustments
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
9b680e1a92
Add CalculatedAdjustments to Voucher
...
Vouchers are only flat rate of 10 for now, so we add a FlatRate
calculator in a before_validation callback
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
f7ee01b9f8
Add voucher input on checkout payment's step
...
Voucher input is displayed only if the distributor has any voucher
2023-05-15 13:42:37 +10:00
Maikel
4f7059d0c7
Merge pull request #10838 from filipefurtad0/fix_negative_adjustment_error
...
Adds minus sign to validation criteria
2023-05-15 11:07:45 +10:00
Gaetan Craig-Riou
d715b6b3bb
Spec fix LocalisedNumber validation to allow negative number
...
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329
LocalisedNumber validation was tightened, but that means negative number
were not valid anymore.
This commit has been cherry-picked after this fix has already been
applied. Now we just change the order of characters in the regex because
humans are used to reading the minus at the beginning of the number. But
this change doesn't change the logic at all.
2023-05-15 10:55:59 +10:00
Maikel
5045e26792
Merge pull request #10834 from mkllnk/variant-spec
...
Improve readability and performance of variant spec
2023-05-15 09:48:06 +10:00
filipefurtad0
0442f2da7e
Fixes spec warning
...
An example was being ignored due to legacy syntax - WARNING: ignoring the provided expectation message argument since it is not a string or a proc.
2023-05-14 23:02:44 +01:00
filipefurtad0
e7ab839fb3
Adds minus sign as validation criteria
...
Removes pending from passing examples
2023-05-14 23:02:44 +01:00
filipefurtad0
596b318778
Adds spec on negative adjustment
...
with different localization settings
Using shared examples and setting failing
ones as pending
2023-05-14 23:02:00 +01:00
Filipe
3c7337b53a
Merge pull request #10836 from jibees/10835-on-small-width-screen-the-cart-element-is-missplaced
...
Fix bad indentation (and hierarchy) of DOM elements causing bad rendering on small width screens
2023-05-12 11:24:49 +01:00
Jean-Baptiste Bellet
60edb4363e
Fix bad indentation (and hierarchy)
...
`%section` must be siblings each others
introduced by https://github.com/openfoodfoundation/openfoodnetwork/pull/10772
2023-05-12 09:30:37 +02:00
Maikel Linke
6596225a99
Fix typo in VCR cassette name
2023-05-12 14:48:00 +10:00
Maikel Linke
87c4c5373b
Spec more variant naming with realistic data
2023-05-12 14:10:54 +10:00
Maikel Linke
f70607259a
Spec Variant#product_and_full_name with real data
...
Mocking skips a lot of code execution which we want to test as well.
2023-05-12 13:34:34 +10:00
Maikel Linke
ce180caad9
Test with in-memory data when possible
...
This should speed up specs but I observed only one second less run time.
2023-05-12 13:21:58 +10:00
Maikel Linke
01be934caf
Reduce spec run time by not creating unused subject
...
The `variant` instance isn't used in all specs and doesn't need to be
created every time. This reduced run time from 1min5sec to 43sec on my
machine.
2023-05-12 13:21:58 +10:00
Maikel Linke
54c6559b97
Move Spree::Variant spec out of Spree module
...
I also discovered that some specs were just in the Spee module and not
within the `describe Variant` block. I moved them inside the block.
2023-05-12 13:21:19 +10:00
Maikel
93c0a06403
Merge pull request #10829 from filipefurtad0/flaky_order_spec_error
...
Splits assertions to allow JS table populate
2023-05-12 11:49:06 +10:00
Maikel Linke
636b365304
Tell Rubocop and devs about bulk insert
2023-05-12 10:30:47 +10:00
Jean-Baptiste Bellet
51d6fb81dd
Fwd to request the restock_items input value when adjusting items qty
2023-05-11 22:58:44 +02:00
Jean-Baptiste Bellet
f679d8733e
Pass the restock_items params to each methods and request call
...
+ update spec to test whether the restock item checkbox is checked or not.
2023-05-11 22:58:44 +02:00
Matt-Yorkley
b139087c5f
Clone ExchangeVariant objects in bulk
...
An ExchangeVariant is a simple representation of a join table between Exchange and Variant. Previously this code was triggering an additional INSERT query for every variant added to the newly cloned exchange. Some exchanges have ~3000 variants! The code now creates them in bulk in a single INSERT statement. When cloning large order cycles this can improve performance by ~1000% or so.
2023-05-11 20:51:20 +01:00
Filipe
1bdb668cd3
Merge pull request #10769 from Matt-Yorkley/visible-line-items-query
...
Improve `Permissions::Order#visible_line_items` querying
2023-05-11 15:36:32 +01:00
filipefurtad0
d035d4bb87
Update all locales with the latest Transifex translations
2023-05-11 15:25:39 +01:00
Mohamed ABDELLANI
6771d2e7be
test enterprise fees creation with tax category inheritance flag
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
a22fe9f948
fix existing invalid enterprise fees
2023-05-11 12:46:17 +01:00
Maikel Linke
25b7f1749c
Simplify error when tax rate can't be inherited
...
I changed the text to focus on the resolution: the user needs to choose
a tax category or a different calculator.
I associated the error to the model to prevent the attribute name from
being included in the error message. Alternatively, we could have
changed the name of the attribute to match the UI. But this error
affects the combination of two attributes, none of them is invalid on
its own.
I'm using Rails' default lazy lookup for error messages which results in
shorter code and a standard structure.
I also added a simple spec.
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
89eb3a1967
fix existing tests
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
7eca32e84f
prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-11 12:46:17 +01:00
filipefurtad0
f5eb72c804
Adds sleep(1)
2023-05-11 11:29:24 +01:00
Konrad
2836751698
Merge pull request #10805 from jibees/10717-bo-orders-changing-customer-does-not-update-customer_id
...
Admin, Edit customer details for an order: when changing to another customer, update `customer_id` as well
2023-05-10 19:08:57 +02:00
Filipe
bf7a559a32
Merge pull request #10772 from Matt-Yorkley/view-caching
...
Locale-aware Fragment Caching
2023-05-10 11:18:08 +01:00
filipefurtad0
82f307ae61
Adds test case for logging out
2023-05-10 10:41:43 +01:00
Matt-Yorkley
d90653c682
Merge pull request #10793 from jibees/fix-webpack-configuration-use-the-default-one
...
Use the default webpack configuration for dev env
2023-05-10 10:09:28 +01:00
jibees
ca5300284c
Merge pull request #10820 from Matt-Yorkley/js-dependencies
...
Remove indirect JS dependencies
2023-05-10 09:57:05 +02:00
Matt-Yorkley
406cb572ea
Remove indirect JS dependencies
2023-05-10 09:27:00 +02:00
jibees
ca90b5cee2
Merge pull request #10810 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.122.0
...
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
2023-05-10 09:23:44 +02:00
jibees
760860a06d
Merge pull request #10811 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.11.0
...
Bump knapsack_pro from 3.10.0 to 3.11.0
2023-05-10 09:21:46 +02:00
jibees
189207f751
Merge pull request #10822 from openfoodfoundation/dependabot/bundler/debug-1.8.0
...
Bump debug from 1.7.2 to 1.8.0
2023-05-10 09:20:34 +02:00
Matt-Yorkley
1bd9182cea
Update menu cache blocks
2023-05-09 16:46:09 +01:00
David Cook
04a5c7452e
Remove admin_style_v2 description
...
Partially reverts 9a1b1498bf
2023-05-09 21:26:47 +10:00
David Cook
e29df5ea8f
Remove unused secondary class
...
This partially reverts 97c3aaebb2 because it referred to the new feature toggle which has been removed.
2023-05-09 21:26:47 +10:00
David Cook
3ec659d82b
Revert pull #10025
...
[WIP 🚧 ] Admin, behind feature toggle admin_style_v2: adjust some colors
This reverts commits 60f0a58508ce77666fa96c73d76dc0620f23daaf~1..09bcc772ff089f911a56bb
2023-05-09 21:26:47 +10:00
David Cook
be70cd7893
Revert pull #10054
...
[WIP 🚧 ] Admin/Orders, behind feature toggle admin_style_v2: adjust colors
This reverts commits 5cab0f7f3d495daaeb97fd786208a24355b630fe..4ef5609b0eb08fe7e48803de166ae3e979103c1b
2023-05-09 21:26:47 +10:00
David Cook
0ff540e1e3
Revert pull #10080
...
[WIP 🚧 ] Admin - Order edition, behind feature toggle admin_style_v2: adjust colors
This reverts commits faf106b2824f248812f523c10b688bd9b254dc14..74b618230ff736ac7929246e2c83ed95067a4dd0
2023-05-09 21:25:29 +10:00
David Cook
c21ff075de
Revert pull #10131
...
[WIP 🚧 ] /admin/order_cycles behind feature toggle admin_style_v2
This reverts commits ccfc632149f062fca546784c7c2f14708d91a08e~1..e403a2c174def34cfa115eab038c86923482bfbf
2023-05-09 21:24:25 +10:00
dependabot[bot]
969d0b6687
Bump debug from 1.7.2 to 1.8.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-09 10:03:20 +00:00
Maikel Linke
3c6f55732d
Add dummy product type to DFC export
2023-05-09 17:01:00 +10:00
Maikel Linke
b2e8af0cd1
Add stock to DFC Offer as well
2023-05-09 16:51:26 +10:00
Maikel Linke
c81230d334
Add old DFC API name for prototype compatibility
2023-05-09 16:51:26 +10:00
Maikel Linke
54137067dd
Export variant's display_name if present
...
The `#name` method is simply delegated to a variant's product.
2023-05-09 16:51:26 +10:00
Maikel Linke
0c5ab783ca
Update DFC API route to reflect Connector version
2023-05-09 16:51:26 +10:00
Maikel Linke
80edc44ef5
Replace SuppliedProductSerializer with DFC Connector
...
And remove the BaseSerializer because this was the last serializer.
2023-05-09 16:51:26 +10:00
Maikel Linke
0b808a4b1e
Add product quantity to DFC export
2023-05-09 16:51:26 +10:00
Maikel Linke
1e23cf1c92
Replace EnterpriseSerializer with DFC Connector
...
And move same test coverage to a new builder spec.
2023-05-09 16:51:26 +10:00
Maikel Linke
683ad0f5b9
Replace PersonSerializer with DFC Connector
...
And the address serializer was just an empty placeholder.
2023-05-09 16:51:26 +10:00
Maikel Linke
c60d622818
List catalog items with DFC Connector
2023-05-09 16:51:25 +10:00
Maikel Linke
7f8ce08d4e
Include DFC Offer in the export with valid id
2023-05-09 16:51:25 +10:00
Maikel Linke
78cf3b5a1d
Serialize DFC catalog item with DFC Connector
...
This is work in progress. The DFC Connector uses a more recent DFC
version and other endpoints still use the old serializers. We need to
update those endpoints as well and update the version number in the API
URL.
2023-05-09 16:51:25 +10:00
Maikel Linke
5187201796
Add DFC vocabularies
...
- Add a script for downloading updated files.
- Add a service for easier loading of vocab files.
2023-05-09 16:51:25 +10:00
Maikel Linke
352c350840
Add gem datafoodconsortium-connector
...
We hope that replacing our own JSON generation with this gem will reduce
maintenance. Same for parsing DFC input.
2023-05-09 16:51:25 +10:00
David Cook
8fe20ecfbe
Merge pull request #10794 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.8
...
Bump @babel/core from 7.21.5 to 7.21.8
2023-05-09 16:37:42 +10:00
Maikel
83141ec05c
Merge pull request #10818 from mkllnk/schema-order
...
Fixup order of statements in db schema
2023-05-09 14:21:03 +10:00
Matt-Yorkley
4b707b9310
Extract locale file digest logic to a separate class and add tests
2023-05-08 14:09:00 +01:00
Matt-Yorkley
1c277e5547
Cache some html fragments
2023-05-08 14:07:50 +01:00
Matt-Yorkley
be48a6c295
Implement cache_with_locale helper for fragment caching with locales
2023-05-08 14:07:50 +01:00
Matt-Yorkley
11f45dc2f8
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
Konrad
4303cabe56
Merge pull request #10792 from mkllnk/feature-deletion
...
Remove unknown (deleted) feature toggles at boot
2023-05-08 14:49:42 +02:00
Maikel Linke
f1f3ecc4f7
Fixup order of statements in db schema
...
It looks like the resolution of a merge conflict introduced the wrong
ordering of schema statements. Rails wants to sort tables alphabetically
and running `./bin/rails db:migrate` on a fresh database altered the
schema.rb file. This should be fixed here.
Rails also omits the default setting of `precision: 6` since Rails 7.
The vouchers feature was developed during the upgrade to Rails 7.
2023-05-08 14:37:33 +10:00
Maikel
ad033e8d44
Merge pull request #10767 from Matt-Yorkley/remove-session-cookie-upgrader
...
Remove SessionCookieUpgrader from middleware
2023-05-08 12:50:42 +10:00
Gaetan Craig-Riou
f25a3650bd
Merge pull request #10802 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.1
...
Bump ddtrace from 1.11.0 to 1.11.1
2023-05-08 11:45:07 +10:00
Konrad
e4d8dd9f87
Merge pull request #10780 from dacook/enable-prettier-css
...
Enable prettier for Admin SCSS
2023-05-06 18:24:58 +02:00
Matt-Yorkley
1995a44848
Improve eager-loading on admin products page adn resolve issue with serializer
...
For some reason eager-loaded data isn't passed to nested serializers when using associations. Defining the association as a method and passing in some optional paramaters resolves the issue.
This reduces queries run by the controller action by around 75%, as well as the response times.
2023-05-06 17:15:27 +01:00
dependabot[bot]
b29d38f3fb
Bump knapsack_pro from 3.10.0 to 3.11.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.10.0 to 3.11.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.10.0...v3.11.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 10:01:08 +00:00
dependabot[bot]
1c52fe1648
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.121.0 to 1.122.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 09:59:02 +00:00
David Cook
a170b93cc1
Simplify further
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-05 15:34:23 +10:00
Maikel Linke
2a943ecafb
Spec setting up all feature toggle names
2023-05-05 11:09:10 +10:00
Jean-Baptiste Bellet
3a1579104f
Submit customer_id as params when updating customer details on order
2023-05-04 16:40:58 +02:00
jibees
ec4c7b79bf
Merge pull request #10803 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.2
...
Bump rspec-rails from 6.0.1 to 6.0.2
2023-05-04 13:55:37 +02:00
dependabot[bot]
9f12295a89
Bump rspec-rails from 6.0.1 to 6.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:54 +00:00
dependabot[bot]
46fd6b1a3a
Bump ddtrace from 1.11.0 to 1.11.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:25 +00:00
Jean-Baptiste Bellet
8a5608435c
Update all locales with the latest Transifex translations
2023-05-03 17:30:48 +02:00
Konrad
d02d0b8847
Merge pull request #10763 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.0
...
Bump ddtrace from 1.10.1 to 1.11.0
2023-05-03 17:27:13 +02:00
Konrad
4b6ef7796e
Merge pull request #10762 from mkllnk/report-encoding
...
Preserve encoding of stored reports
2023-05-03 17:08:44 +02:00
Konrad
b60a6fbd05
Merge pull request #10329 from thejwuscript/9861-improve-input-validation
...
Improve input validation on new and edit Payment Method pages
2023-05-03 16:11:21 +02:00
jibees
2e267091f6
Merge pull request #10795 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.10.0
...
Bump knapsack_pro from 3.9.0 to 3.10.0
2023-05-03 14:31:11 +02:00
dependabot[bot]
eb3fe1b7a5
Bump knapsack_pro from 3.9.0 to 3.10.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.9.0...v3.10.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 10:06:11 +00:00
dependabot[bot]
61f34a23a7
Bump @babel/core from 7.21.5 to 7.21.8
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.5 to 7.21.8.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.8/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 09:57:57 +00:00
Jean-Baptiste Bellet
2d7356f2bb
Use the default webpack configuration for dev env
...
We used to override the output filename but this was a misunderstanding of an error (due to webpacke(r) incompatibles versions)
https://medium.com/@web_developer/hash-vs-chunkhash-vs-contenthash-e94d38a32208
https://github.com/webpack/webpack.js.org/issues/2096
Context: https://github.com/openfoodfoundation/openfoodnetwork/pull/10631#pullrequestreview-1410083331
2023-05-03 10:10:17 +02:00
jibees
62c2d9a290
Merge pull request #10782 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.0
...
Bump sidekiq from 7.0.9 to 7.1.0
2023-05-03 09:56:07 +02:00
jibees
a329aab007
Merge pull request #10774 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.5
...
Bump @babel/core and @babel/preset-env from 7.21.4 to 7.21.5
2023-05-03 09:26:10 +02:00
Maikel Linke
e24198fe85
Bump @babel/preset-env from 7.21.4 to 7.21.5
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-env )
I did this manually:
```
$ yarn upgrade "@babel/preset-env"
yarn upgrade v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > stimulus_reflex@3.5.0-rc2" has unmet peer dependency "@hotwired/stimulus@>= 3.0".
[4/4] Rebuilding all packages...
success Saved lockfile.
success Saved 35 new dependencies.
info Direct dependencies
└─ @babel/preset-env@7.21 .5
info All dependencies
├─ @babel/code-frame@7.21 .4
├─ @babel/helper-builder-binary-assignment-operator-visitor@7.21 .5
├─ @babel/helper-function-name@7.21 .0
├─ @babel/helper-module-imports@7.21 .4
├─ @babel/helper-replace-supers@7.21 .5
├─ @babel/helper-string-parser@7.21 .5
├─ @babel/helper-wrap-function@7.20 .5
├─ @babel/highlight@7.18 .6
├─ @babel/parser@7.21 .5
├─ @babel/plugin-transform-arrow-functions@7.21 .5
├─ @babel/plugin-transform-computed-properties@7.21 .5
├─ @babel/plugin-transform-for-of@7.21 .5
├─ @babel/plugin-transform-modules-commonjs@7.21 .5
├─ @babel/plugin-transform-regenerator@7.21 .5
├─ @babel/plugin-transform-unicode-escapes@7.21 .5
├─ @babel/preset-env@7.21 .5
├─ @babel/regjsgen@0.8.0
├─ @babel/template@7.20 .7
├─ @babel/traverse@7.21 .5
├─ @jridgewell/resolve-uri@3.1.0
├─ color-convert@1.9.3
├─ escape-string-regexp@1.0.5
├─ is-core-module@2.12 .0
├─ js-tokens@4.0.0
├─ jsesc@2.5.2
├─ ms@2.1.2
├─ regenerate-unicode-properties@10.1.0
├─ regenerator-runtime@0.13.11
├─ regexpu-core@5.3.2
├─ regjsparser@0.9.1
├─ to-fast-properties@2.0.0
├─ unicode-canonical-property-names-ecmascript@2.0.0
├─ unicode-match-property-ecmascript@2.0.0
├─ unicode-match-property-value-ecmascript@2.1.0
└─ unicode-property-aliases-ecmascript@2.1.0
Done in 16.54s.
```
2023-05-03 15:33:57 +10:00
Maikel Linke
b30e962cdd
Remove unknown (deleted) feature toggles at boot
2023-05-03 15:20:26 +10:00
Maikel Linke
5f1f717974
Spec FeatureToggle.setup!
2023-05-03 15:02:08 +10:00
Maikel Linke
b6f2fe0e92
Avoid defining modules in specs
...
We avoid some indent and show how code outside of the module works.
2023-05-03 14:58:59 +10:00
dependabot[bot]
a9bf7a2498
Bump @babel/core from 7.21.4 to 7.21.5
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 12:18:41 +10:00
David Cook
e11518938f
Prettify admin components scss
...
Largely whitespace, but some other updates too, including uppercase colour codes and standardising numbers.
Best viewed with whitespace ignored.
2023-05-03 12:10:58 +10:00
David Cook
c4dc5e0718
Prettier: use double quotes by default
...
Unfortunately Prettier won't let you do one rule at a time (https://stackoverflow.com/q/63813336/421243 ), so I'll break it into file chunks.
2023-05-03 12:10:58 +10:00
David Cook
c67d61a376
Don't ignore admin scss for prettying
...
...and watch the changes flow in!
2023-05-03 12:09:22 +10:00
David Cook
0b4556e72b
Allow line length up to 100char
...
Same as we have for Ruby code: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/.rubocop_styleguide.yml#L78-L80
This will avoid unnecessary reformatting.
2023-05-03 12:09:22 +10:00
David Cook
8c7f92d42e
Explicitly ignore each css folder
...
With the goal to progressively un-ignore them.
2023-05-03 12:09:22 +10:00
Konrad
21a0017352
Merge pull request #10756 from jibees/10743-admin-add-unregistered-users-modal-some-html-is-rendered-as-plain-text-instead-of-being
...
Admin, Add unregistered user: Fix a reflex-morph issue that lead to a HTML escaping error
2023-05-02 19:28:48 +02:00
Konrad
d115c4ce2c
Merge pull request #10733 from jibees/9782-shops-list-overlapping-and-overflowing-texts-on-mobile2
...
Shops list: fix some overlapping and overflowing texts on mobile
2023-05-02 12:15:19 +02:00
dependabot[bot]
b05d46c3e3
Bump sidekiq from 7.0.9 to 7.1.0
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.9 to 7.1.0.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.9...v7.1.0 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-02 09:57:28 +00:00
jibees
aae0fc59fb
Merge pull request #10768 from Matt-Yorkley/query-logs
...
Improve query logging in development
2023-05-02 11:44:19 +02:00
Gaetan Craig-Riou
d1f7cc1b2a
Merge pull request #10764 from Matt-Yorkley/remove-data-hooks
...
Remove `data-hook` attributes
2023-05-02 16:35:46 +10:00
Gaetan Craig-Riou
964481f188
Merge pull request #10765 from Matt-Yorkley/update-webpack-packages
...
Update webpack packages
2023-05-02 15:19:37 +10:00
Maikel
9bca22ae3b
Merge pull request #10775 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.2
...
Bump mini_portile2 from 2.8.1 to 2.8.2
2023-05-02 11:54:37 +10:00
dependabot[bot]
064c843c90
Bump mini_portile2 from 2.8.1 to 2.8.2
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.1...v2.8.2 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-01 10:02:13 +00:00
Maikel
482d438ec9
Merge pull request #10766 from filipefurtad0/remove_asertion_on_js_element_loading_orders
...
Removes assertions on transient JS element - "Loading orders"
2023-05-01 13:36:44 +10:00
Maikel Linke
9f0a66659a
Delete now unused SessionCookieUpgrader
2023-05-01 13:35:52 +10:00
Konrad
1176ea2a5f
Merge pull request #9941 from basilawwad/conditionally-send-cancellation-email
...
Conditionally send cancellation email when cancelling order.
2023-04-28 21:54:42 +02:00
Matt-Yorkley
dfc651ed2c
Convert Permissions::Order#visible_line_items to a relation with or query
...
This change looks innocuous but the result of converting this into a nice relation instead of two queries stuck together with the pipe operator (|) can make a huge difference when chaining this into subqueries. The result set is ultimately the same, but the queries can be built without first returning all the ids and then sticking those ids in an array.
2023-04-28 19:13:22 +01:00
Matt-Yorkley
f42a9e3a66
Add query_count gem in development
...
A very simple gem that counts the total number of queries triggered by each request and displays a little number in the log. Nice.
2023-04-28 15:02:02 +01:00
Matt-Yorkley
8d9a8d8db5
Enable verbose query logs in development
...
This is a new feature in Rails 7. Whenever a query is triggered it not only show you the query (as before), but also tells you (directly in the logs) exactly which line of code was responsible for triggering the query. It's unbelievably useful for debugging and performance work.
2023-04-28 14:35:16 +01:00
Matt-Yorkley
84df1bfeab
Remove SessionCookieUpgrader from middleware
...
This was a transitional bit of code to allow us to rename our session cookies without killing active sessions and logging users out. It's done it's job, the transition is finished, and it isn't doing anything useful now. It can be removed from the middleware stack.
2023-04-28 14:01:15 +01:00
Matt-Yorkley
b9431cd121
Remove data-hook attributes
2023-04-28 13:03:13 +01:00
filipefurtad0
74d18fb6ff
Removes assertions on transient JS element
2023-04-28 12:48:59 +01:00
Matt-Yorkley
5e26e49764
Update webpack packages
...
`webpack-cli` is a dependency of `@rails/webpacker` but needs to be at version 3.x, we can just cut it from the explicit dependecy list and the correct version will be installed.
`webpack-dev-server` version 3.x corresponds (unhelpfully) to `webpacker` 4.x, and needs to be left that way. Dependabot tries to change it occasionally, but it should not be updated to 4.x
2023-04-28 12:48:21 +01:00
dependabot[bot]
c9dada4215
Bump ddtrace from 1.10.1 to 1.11.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.1...v1.11.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-28 10:00:28 +00:00
Maikel Linke
630169f8bb
Preserve encoding of stored reports
...
Active Storage reads stored strings as ASCII and that can clash with
Rails' default UTF-8 encoding when special characters are present.
2023-04-28 16:38:06 +10:00
Gaetan Craig-Riou
152af5e105
Merge pull request #10751 from mkllnk/mail-config
...
Remove unused feature to intercept emails
2023-04-28 16:28:41 +10:00
David Cook
918425fd93
Remove customised error message
...
We're now handling these values on the frontend, so can keep this simple.
fixes up:
Add numericality validation for *
Add translation for Active Record error message
2023-04-28 14:02:12 +10:00
David Cook
a46eef291c
Remove localized number logic from calculators
...
The browser is now responsible for dealing with the decimal separator, for all numeric preferences (as input[type=number]; see Spree::Admin::BaseHelper::preference_field_tag). Calculators are the only place that numeric preferences are used.
It will enforce that only one comma or dot (depending on user's locale) is entered, thus avoiding any ambiguity, and mis-interpretation (eg 100,001 could be interpreted as more than 100 thousand or 100 with a decimal place).
2023-04-28 13:54:16 +10:00
David Cook
d2fbb0bde2
Update translations
...
js: admin: orders: order_state: confirmation
2023-04-27 14:49:28 +10:00
David Cook
c42dfdde10
Merge pull request #10748 from openfoodfoundation/dependabot/bundler/view_component-3.0.0
...
Bump view_component from 2.82.0 to 3.0.0
2023-04-27 14:46:09 +10:00
Jean-Baptiste Bellet
959dcb82e1
Morph the form itself instead of morphing a parent DOM element
...
This seems to avoid HTML parsing error
2023-04-26 17:41:28 +02:00
jibees
51d5817665
Merge pull request #10755 from openfoodfoundation/dependabot/bundler/i18n-1.13.0
...
Bump i18n from 1.12.0 to 1.13.0
2023-04-26 15:45:59 +02:00
jibees
a8384b3155
Merge pull request #10754 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.7
...
Bump @floating-ui/dom from 1.2.6 to 1.2.7
2023-04-26 15:44:04 +02:00
Konrad
394bfd00d8
Merge pull request #10586 from jibees/10563-allow-custom-url-on-logo-click
...
White Label: can link an URL to the white label logo
2023-04-26 13:52:10 +02:00
dependabot[bot]
bda1a527d3
Bump i18n from 1.12.0 to 1.13.0
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.12.0...v1.13.0 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:48 +00:00
dependabot[bot]
77bd832dd6
Bump @floating-ui/dom from 1.2.6 to 1.2.7
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.7/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:09 +00:00
Jean-Baptiste Bellet
b1de28eeea
When there is a white_label_logo_link pref. use it!
...
+ update spec as well
+ use an an helper to get the main logo link for a shopfront
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
679fcc0114
When removing the logo, also delete white_label_logo_link preference
...
since it has no sense without the logo
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
35778ecf1d
If enterprise has a white_label_logo attached, then can edit its link
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
70a6e9f44b
Add a white_label_logo_link attribute to enterprise model
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
30ba29382a
Avoid name collision by renaming some classes with a prefix flex-
...
This classes should only be used with `.flex`
2023-04-26 09:52:24 +02:00
Jean-Baptiste Bellet
9584205a8e
Use .flex class in utilities.scss file
...
No need to have multiple definition as already included
2023-04-26 09:51:28 +02:00
Jean-Baptiste Bellet
3644dbc0fd
Small fix of a prettier formatter error
2023-04-26 09:51:17 +02:00
Jean-Baptiste Bellet
05a7276c9c
Create an utilities.scss file that contains some utility classes
...
Finally Tailwind is coming? ;)
2023-04-26 09:47:23 +02:00
David Cook
1fc60d498a
Merge pull request #10746 from openfoodfoundation/dependabot/bundler/rswag-specs-2.9.0
...
Bump rswag-specs from 2.8.0 to 2.9.0
2023-04-26 14:08:30 +10:00
Maikel Linke
dae8703b02
Remove unused feature to intercept emails
...
This option came from Spree and we never used it. The config input field
is disabled in the admin interface and I checked our managed databases.
I don't think that we will want this feature in the future either.
Staging sends unmodified emails which is more realistic and we haven't
had a use case to intercept those emails. There's still the BCC option
if we need additional access.
2023-04-26 13:50:31 +10:00
Maikel
3078c599f9
Merge pull request #10747 from openfoodfoundation/dependabot/bundler/rswag-ui-2.9.0
...
Bump rswag-ui from 2.8.0 to 2.9.0
2023-04-26 12:04:09 +10:00
dependabot[bot]
5d91ac217d
Bump rswag-specs from 2.8.0 to 2.9.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 02:03:53 +00:00
Maikel
f2edb6d404
Merge pull request #10745 from openfoodfoundation/dependabot/bundler/rswag-api-2.9.0
...
Bump rswag-api from 2.8.0 to 2.9.0
2023-04-26 12:02:38 +10:00
David Cook
7cd1b5d5db
Update link
...
The old project was closed in favour of a new one.
2023-04-26 09:44:58 +10:00
dependabot[bot]
ad82f66173
Bump rswag-api from 2.8.0 to 2.9.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 10:10:17 +00:00
dependabot[bot]
62bfa9e04c
Bump view_component from 2.82.0 to 3.0.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.82.0 to 3.0.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.82.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:51 +00:00
dependabot[bot]
28c9d72342
Bump rswag-ui from 2.8.0 to 2.9.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:22 +00:00
jibees
7317d6ca34
Merge pull request #10742 from filipefurtad0/fix_broken_build
...
Considers recent changes on login test helpers
2023-04-25 11:36:56 +02:00
filipefurtad0
edb8da4b4d
Considers recent changes on login test helpers
...
PR #10696 introduced changes on the login helpers which were not considered, when merging a recent PR; This broke the build
2023-04-24 18:35:10 +01:00
Konrad
00d5bd9165
Merge pull request #10684 from MadisonBowron/master
...
Fix admin product variants form to close issues #10579 & Wishlist: 430
2023-04-24 18:18:01 +02:00
Jean-Baptiste Bellet
1730c9eb60
Fix one warning: Modal window with text has been opened, ...
...
```
Modal window with text `An invoice for this order will be sent to the customer. Are you sure you want to continue?` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
```
2023-04-24 15:18:35 +02:00
Jean-Baptiste Bellet
5b9815f4a3
Test that restock has been called or not, depending on checkbox checked
2023-04-24 15:03:14 +02:00
jibees
445eb45ad7
Merge pull request #10737 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.8
...
Bump prettier from 2.8.7 to 2.8.8
2023-04-24 14:43:20 +02:00
jibees
8770471ada
Merge pull request #10738 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.4.2
...
Bump karma from 6.4.1 to 6.4.2
2023-04-24 14:43:07 +02:00
dependabot[bot]
6d45940ca4
Bump karma from 6.4.1 to 6.4.2
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.4.1 to 6.4.2.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.4.1...v6.4.2 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:22 +00:00
dependabot[bot]
69383ac621
Bump prettier from 2.8.7 to 2.8.8
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.7 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.7...2.8.8 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:05 +00:00
Maikel
945cb84127
Merge pull request #10683 from filipefurtad0/update-the-build-env-to-ubuntu-2204
...
Updates build environment to Ubuntu 22.04
2023-04-24 15:27:05 +10:00
Maikel
343a2db1bf
Merge pull request #10722 from mkllnk/rubocop-autocorrect-script
...
Add script for bulk autocorrect with Rubocop
2023-04-24 10:58:43 +10:00
Maikel Linke
de8f5e13b3
Explain gotcha in case it breaks one day
2023-04-24 09:39:21 +10:00
Konrad
75b5d1fd6f
Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector
...
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)
2023-04-22 16:04:15 +02:00
Konrad
0c1606e50c
Merge pull request #10728 from jibees/10718-missing-translation-confirmation-order-state
...
Admin, `/orders`: adds translation for order in `confirmation` state
2023-04-22 11:56:23 +02:00
jibees
fa05554f15
Merge pull request #10734 from openfoodfoundation/dependabot/npm_and_yarn/karma-chrome-launcher-3.2.0
...
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
2023-04-21 14:13:19 +02:00
Jean-Baptiste Bellet
2cc509de15
Do not check Metrics/BlockLength for shared_examples_for block
...
They can contains a lot of `it` tests
2023-04-21 11:59:24 +02:00
dependabot[bot]
41afad73e4
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
...
Bumps [karma-chrome-launcher](https://github.com/karma-runner/karma-chrome-launcher ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/karma-runner/karma-chrome-launcher/releases )
- [Changelog](https://github.com/karma-runner/karma-chrome-launcher/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-chrome-launcher/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: karma-chrome-launcher
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-21 09:57:29 +00:00
Jean-Baptiste Bellet
b17b25516f
Use a UTF-8 character
2023-04-21 10:37:20 +02:00
Jean-Baptiste Bellet
8444fca19a
Fix syntax error
2023-04-21 10:36:47 +02:00
Jean-Baptiste Bellet
18d90114fe
Be more responsive: use flex, ellipsis, less columns
2023-04-21 10:36:21 +02:00
Gaetan Craig-Riou
2f17a02974
Merge pull request #10726 from mkllnk/spec-email-helper
...
Remove useless email test setup
2023-04-21 15:43:19 +10:00
Gaetan Craig-Riou
135bc7e2f8
Removing env variable $runs_on
...
Seting "env" under "jobs" doesn't work it gets picked up as a job. I moved
runs_on to the top level env. but I couldn't fine a way to get it to work.
I tried all syntax I could think of: $runs_on, ${{ runs_on }} env.runs_on,
${{ env.runs_on }} and their capitalized versions.
2023-04-21 15:14:20 +10:00
Gaetan Craig-Riou
3810d79cad
Merge pull request #10695 from macanudo527/rename_inversables
...
Rename Inversable Method Names
2023-04-21 11:38:58 +10:00
Maikel Linke
4960402643
Update translations
2023-04-21 09:45:45 +10:00
jibees
3557c10cd6
Merge pull request #10730 from openfoodfoundation/dependabot/bundler/stringex-2.8.6
...
Bump stringex from 2.8.5 to 2.8.6
2023-04-20 15:50:19 +02:00
jibees
45dd421f1f
Merge pull request #10729 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.121.0
...
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
2023-04-20 15:48:46 +02:00
Jean-Baptiste Bellet
81606e841a
Canceling an order: clicking on cancel btn or cancel action in dropdown
2023-04-20 14:38:59 +02:00
basilawwad
e633670e01
Use a shared_examples for the order cancellation tests
2023-04-20 14:38:59 +02:00
Filipe
11653c9430
Merge pull request #10575 from jibees/10559-allow-upload-of-custom-header-logo
...
White Label: can upload a custom header logo
2023-04-20 13:27:52 +01:00
dependabot[bot]
d068094044
Bump stringex from 2.8.5 to 2.8.6
...
Bumps [stringex](https://github.com/rsl/stringex ) from 2.8.5 to 2.8.6.
- [Release notes](https://github.com/rsl/stringex/releases )
- [Commits](https://github.com/rsl/stringex/compare/v2.8.5...v2.8.6 )
---
updated-dependencies:
- dependency-name: stringex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:06:33 +00:00
dependabot[bot]
b892bf726e
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.1 to 1.121.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:00:05 +00:00
basilawwad
fa373518fb
applied modal function
...
Update variant_autocomplete.js.erb
Applied modal function
refactored function
fix indentation and removed old function
2023-04-20 11:46:02 +02:00
Jean-Baptiste Bellet
76357789a3
Avoid line break between state wording and its little colored circle
2023-04-20 09:09:29 +02:00
Jean-Baptiste Bellet
5dd7246b85
Rename confirm to use confirmation
...
`confirmation` is the state used by order model
2023-04-20 09:07:01 +02:00
Jean-Baptiste Bellet
ba45dd84dd
Solves rubocop linter errors
2023-04-20 08:46:19 +02:00
Jean-Baptiste Bellet
92e2a83e0e
Use Rails7 command for image variant syntax
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
f42f513f8c
Display white_label_logo image when hide_ofn_navigation is set to true
...
for both desktop and mobile view
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
54342254b6
Do not show white label logo is hide_ofn_navigation is not checked
...
They are both strongly linked
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
470761da86
Add a simple CheckboxDisplay controller that show/hide content
...
depending on the checkbox state (checked or not)
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
6fdf9fa038
Add/Remove white label logo in enterprise preferences panel
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
bbec01a9cb
Create a concern for reflexes that handle Enterprise update
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
e3001cc8c4
Add white_label_logo to enterprise model as attachment
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
ad0d0e393e
ConfirmModalComponent is ready to receive data-reflex
...
And not only `data-action`
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
2690ff5eb5
Add comment, which links these two files together
2023-04-20 08:45:03 +02:00
jibees
2594382488
Merge pull request #10723 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.9
...
Bump sidekiq from 7.0.8 to 7.0.9
2023-04-20 08:31:46 +02:00
Maikel Linke
9b3cfe80ff
Remove useless clearing of test emails
...
They are cleared by the test environment anyway.
2023-04-20 13:35:40 +10:00
Maikel Linke
04d33adaf2
Remove duplicate declaration of test mail delivery
...
Our test environment sets the mail delivery method already. We don't
have to do it in individual spec files.
2023-04-20 13:28:59 +10:00
Maikel Linke
915bd19d7b
Remove useless email test setup
...
We always deliver emails these days.
2023-04-20 12:18:04 +10:00
Maikel Linke
9998025687
Remove useless test header setup for emails
...
Once upon a time we needed a helper to set the `from` header of emails.
This is now set in the ApplicationMailer and not necessary any more.
2023-04-20 12:15:34 +10:00
Maikel
89cb3b7c14
Merge pull request #10707 from mkllnk/mailer-previews
...
Fix ShipmentMailer preview autoload path
2023-04-20 11:30:25 +10:00
Maikel Linke
1955a6719c
Fix commit message formatting
...
Git needs a blank line between the summary and the longer description.
And `echo` doesn't interpret `\n` by default.
2023-04-20 11:19:32 +10:00
Maikel Linke
f71e5ee43c
Limit number of rubocop autocorrect runs
...
The typical use case is to create a small number of commits for a pull
request to ease the review. And you can still run it for all cops with
`-n 999` or `-n -0`.
2023-04-20 11:19:32 +10:00
Maikel Linke
0ac2358f2c
Regenerate Rubocop's TODO file without timestamp
2023-04-20 10:34:35 +10:00
Filipe
3e0b358370
Merge pull request #10461 from vviekk/9978
...
Updating price, on_hand, on_demand validations for product import
2023-04-19 16:09:49 +01:00
Filipe
f206b7ed9e
Merge pull request #10661 from mkllnk/report-download
...
[Hidden] Provide download link for reports generated in the background
2023-04-19 11:53:14 +01:00
dependabot[bot]
946b69242c
Bump sidekiq from 7.0.8 to 7.0.9
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.8 to 7.0.9.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.8...v7.0.9 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-19 09:58:13 +00:00
Filipe
a409d3b97e
Merge pull request #10201 from saunmanoj888/fix-invalid-image-upload
...
Fix corrupt and invalid image upload issue
2023-04-19 10:45:04 +01:00
Jean-Baptiste Bellet
a27b64a66b
Add confirmation state translation
2023-04-19 11:32:51 +02:00
Jean-Baptiste Bellet
0f54d3950d
Save can have a context: simplify then
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
Maikel
1f661c1e69
Merge pull request #10716 from jibees/10048-stimulusreflex-caching-warning
...
Adds caching by default in development environment to avoid StimulusReflex warning
2023-04-19 16:22:37 +10:00
saunmanoj888
97f51d24b8
Validate image on creating product from products/new
2023-04-19 16:11:46 +10:00
saunmanoj888
c3d274c84f
Fix corrupt and invalid image upload issue
2023-04-19 16:11:46 +10:00
Maikel Linke
213fb42a05
Safely autocorrect Gemspec/RequireMFA
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/catalog.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:9:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:21:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 8 offenses detected, 8 offenses corrected
2023-04-19 15:35:30 +10:00
Maikel Linke
bde46fa1e9
Safely autocorrect Gemspec/DeprecatedAttributeAssignment
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
spec.test_files = Dir['spec/**/*']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["spec/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 4 offenses detected, 4 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
dc560d3793
Safely autocorrect Bundler/OrderedGems
...
Inspecting 1404 files
.C..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Gemfile:18:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem angular-rails-templates should appear before rexml.
gem 'angular-rails-templates', '>= 0.3.0'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:19:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem awesome_nested_set should appear before rexml.
gem 'awesome_nested_set'
^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:20:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem ransack should appear before rexml.
gem 'ransack', '~> 2.6.0'
^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:21:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem responders should appear before rexml.
gem 'responders'
^^^^^^^^^^^^^^^^
Gemfile:74:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-rails_csrf_protection should appear before openid_connect.
gem 'omniauth-rails_csrf_protection'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:154:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before factory_bot_rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:155:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before fuubar.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:156:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before json_spec.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:157:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before knapsack_pro.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:158:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before letter_opener.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:159:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:160:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-retry.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:161:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rswag-specs.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:162:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before shoulda-matchers.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:163:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before timecop.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:179:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem foreman should appear before rails-erd.
gem 'foreman'
^^^^^^^^^^^^^
Gemfile:180:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem listen should appear before rails-erd.
gem 'listen'
^^^^^^^^^^^^
Gemfile:181:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry should appear before rails-erd.
gem 'pry', '~> 0.13.0'
^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 18 offenses detected, 18 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
52f134fc9e
Regenerate Rubocop's TODO file
2023-04-19 15:35:29 +10:00
Maikel Linke
c08e264afa
Add script for bulk autocorrect with Rubocop
...
We also had an old script which wasn't used and needed manual steps.
2023-04-19 15:35:29 +10:00
Maikel
0b03152f3b
Merge pull request #10697 from mkllnk/rubocop-config-update
...
Update Rubocop config and replace deprecated TimeWithZone#to_s with argument
2023-04-19 11:23:34 +10:00
Maikel
6f492d868c
Merge pull request #10688 from mkllnk/application-mailer
...
Apply Rails standard to base mailer class
2023-04-19 10:29:16 +10:00
jibees
dab2a4af75
Merge pull request #10693 from jibees/10658-move-all-managed-instances-to-fully-enabled-split_checkout-toggle
...
Activate `split_checkout` feature by default
2023-04-18 17:33:48 +02:00
Jean-Baptiste Bellet
f7935bde34
Enable caching dy default, to avoid StimulusReflex warning
...
```
Heads up! 🔥
👉 StimulusReflex requires caching to be enabled. Caching allows the session to be modified during ActionCable requests.
To enable caching in development, run:
rails dev:cache
```
Documentation: https://docs.stimulusreflex.com/hello-world/setup.html#manual-configuration
2023-04-18 16:02:02 +02:00
Jean-Baptiste Bellet
61850f7e92
Remove duplicate line
...
Probably due to a bad merge conflict resolution
Line is already on line `#25`
2023-04-18 16:01:04 +02:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
jibees
7df456c1e3
Merge pull request #10715 from openfoodfoundation/dependabot/bundler/puma-6.2.2
...
Bump puma from 6.2.1 to 6.2.2
2023-04-18 15:04:17 +02:00
Konrad
2fa86492d1
Merge pull request #10653 from openfoodfoundation/10645-pagination-in-bom-not-aggregating-results-when-clicking-a-productvariant
...
BOM: When selecting a specific variant, trigger a new search that avoid pagination issues
2023-04-18 14:49:14 +02:00
Jean-Baptiste Bellet
722c660697
Do not show any links to other steps when no distribution set
...
distribution means tuple: distributor + order cycle
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ba1d985932
update the set_distribution form on the same path
...
and use the same method `OrdersController#set_distribution`
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
0f28d318ac
Fix rubocop error and prefer using a return clause
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
6172d1f2e5
Extract method on_update that will be used elsewhere
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
05a040b4c3
No need to ensure if the distribution is set on new action
...
This will be handled by validation on set_distribution action
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
dependabot[bot]
85860692ae
Bump puma from 6.2.1 to 6.2.2
...
Bumps [puma](https://github.com/puma/puma ) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.2.1...v6.2.2 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 09:59:41 +00:00
jibees
8ad4d2cc2e
Merge pull request #10708 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.3
...
Bump webpack-dev-server from 4.13.2 to 4.13.3
2023-04-18 10:15:01 +02:00
David Cook
c967eca9c4
Merge pull request #10713 from openfoodfoundation/dependabot/npm_and_yarn/ansi-regex-4.1.1
...
Bump ansi-regex from 4.1.0 to 4.1.1 (security patch)
2023-04-18 15:34:24 +10:00
David Cook
7fff82eec3
Merge pull request #10710 from openfoodfoundation/dependabot/bundler/rubocop-1.50.2
...
Bump rubocop from 1.50.1 to 1.50.2
2023-04-18 15:24:40 +10:00
dependabot[bot]
c30ed0f7c8
Bump rubocop from 1.50.1 to 1.50.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.1 to 1.50.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.1...v1.50.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 04:51:38 +00:00
David Cook
cde420716b
Merge pull request #10709 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.19.1
...
Bump rubocop-rails from 2.19.0 to 2.19.1
2023-04-18 14:50:11 +10:00
David Cook
ee37c5d4a3
Merge pull request #10699 from dacook/sass-deprecations
...
Sass deprecations
2023-04-18 11:48:56 +10:00
dependabot[bot]
e9d236f761
Bump ansi-regex from 4.1.0 to 4.1.1
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 00:05:00 +00:00
Gaetan Craig-Riou
8b78c28feb
Merge pull request #10702 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.0
...
Bump cable_ready from 5.0.0-rc2 to 5.0.0
2023-04-18 10:02:59 +10:00
David Cook
43e51cb592
Simplify login spec helpers, avoid long lines
...
Follow on from 5c6d9a092e
2023-04-18 10:01:23 +10:00
David Cook
6570891349
Fix linter issues
...
Although I don't think the size was an issue here, small hashes can easily fit on one line.
2023-04-18 09:50:08 +10:00
David Cook
0f3e2ae572
Use browser validation for calculator values
...
They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic.
They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.
2023-04-18 09:50:08 +10:00
David Cook
f0110d20a2
Move config to base helper
...
This config is relevant for all specs, including system specs.
2023-04-18 09:50:08 +10:00
David Cook
353acfd6ae
Validate associated calculator with built in error handling
...
Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.
2023-04-18 09:39:39 +10:00
David Cook
e43a018dc7
[wip] Copy each calculator error
...
But we still have the duplicate problem.
Wait a minute, it copies them in the same format that I am copying them. So.. I don't need to copy them at all!
Now I see that we just needed the right format in the translation file.
2023-04-18 09:39:39 +10:00
David Cook
f6fac018ea
[wip] Use a custom message format for associated errors
...
This is much simpler. Multiple messages get combined onto one line though, which is not perfect.
And.. it still seems to duplicate the errors. Weird, it's fine on my frontend though.
2023-04-18 09:39:39 +10:00
David Cook
ce1bd12760
Consolidate specs
...
It takes time to set up this test case. Given that there's no interactions in the expectations, we should save time to generate it only once.
2023-04-18 09:39:39 +10:00
David Cook
364ccc2146
Add comment
2023-04-18 09:39:39 +10:00
James Wu
2a7cb50fa9
Keep and display submitted data on new payment method page
2023-04-18 09:39:39 +10:00
James Wu
29ddc68d20
Fix duplicate validation error message
2023-04-18 09:39:39 +10:00
James Wu
d40f3414ea
fixup! Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
f5e2edb028
fixup! Modify Calculator validation error messages [wip]
...
DC: the error message has now become "Amount Invalid input".
2023-04-18 09:39:39 +10:00
James Wu
7af26e6579
Add errors for invalid input with number localization enabled
2023-04-18 09:39:39 +10:00
James Wu
824d4adf21
Rename spec file
2023-04-18 09:39:39 +10:00
James Wu
00cc8da2fc
Fix rubocop class length error
2023-04-18 09:39:39 +10:00
James Wu
ae5f2cc19d
Fix error saving data on new Calculator
2023-04-18 09:39:39 +10:00
James Wu
41ce4fbc16
Fix cache issue with invalid form data
2023-04-18 09:39:39 +10:00
James Wu
48753df5f0
Improve input validation and error notification
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
3dfaf882a3
Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
7b51f45b4d
Fix spelling in test description
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
James Wu
ee30d3d139
Fix PaymentMethodFactory creating extra Calculator
2023-04-18 09:39:39 +10:00
Filipe
871b2f8816
Merge pull request #10696 from mkllnk/login-as-admin
...
Simplify login test helpers
2023-04-17 12:14:06 +01:00
dependabot[bot]
214bdc6fbe
Bump rubocop-rails from 2.19.0 to 2.19.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.19.0 to 2.19.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.19.0...v2.19.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-17 10:01:45 +00:00
dependabot[bot]
d2fce053a7
Bump webpack-dev-server from 4.13.2 to 4.13.3
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.13.2 to 4.13.3.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.13.2...v4.13.3 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-17 09:57:50 +00:00
Jean-Baptiste Bellet
11a7aa9f96
When clicking on "Clear Filters" button, to not reset variant selection
...
+ add some specs to cover that particular case
2023-04-17 11:08:17 +02:00
Jean-Baptiste Bellet
c0203e7091
Refactor by putting two specs into a shared_example
...
"It's a Surprise Tool That Will Help Us Later"
2023-04-17 11:06:23 +02:00
Maikel
44cc5cc665
Merge pull request #10677 from mkllnk/spec-helpers
...
Simplify spec helpers
2023-04-17 16:16:29 +10:00
Maikel Linke
6c8e383ab8
Fix ShipmentMailer preview autoload path
...
The Zeitwerk autoloader requires class names and file names to match. In
this case, the class had a Spree namespace without being in a spree
folder. The preview couldn't be displayed. Now it can be displayed.
2023-04-17 15:18:22 +10:00
Maikel Linke
5c6d9a092e
Simplify login spec helpers, avoid long lines
...
The `login_as_admin_and_visit` helper was used a lot but isn't really
shorter than:
login_as_admin
visit path_visit
Calling those methods separately reduces line length. It also removes
the potential impression that it may be more efficient to use the
helper. Now we have less indirection if one of the calls fails and see
the failing spec line straight away.
2023-04-17 11:08:32 +10:00
Maikel Linke
8d500a2c27
Remove superflouous login test helper
...
It was often used with a `visit` statement after which resulted in
unnecessary page loads. There was only one case where a `visit` was
expected but it wasn't needed either.
2023-04-17 10:56:51 +10:00
Maikel Linke
425674c4e5
Remove unused return value of admin login helper
...
Well, there was one use of the return helper. But I don't think that
it's a very intuitive method.
2023-04-17 10:56:51 +10:00
Konrad
e91e827f29
Merge pull request #10664 from abdellani/fix-remove-duplicated-cusomter-from-mailing-list-report
...
Fix Repeated customer entries on Mailing List Report
2023-04-16 21:17:33 +02:00
Konrad
8f201c830a
Merge pull request #10665 from abdellani/fix-remove-duplicated-cusomter-from-addresses-list-report
...
Fix Repeated customer entries on Addresses List Report
2023-04-16 20:40:56 +02:00
Konrad
1b536d9265
Merge pull request #10601 from abdellani/fix-v1-customers-endpoint-should-only-return-managed-enterprise-customers
...
fix: v1/customers endpoint should load customers of managed enterprises only
2023-04-16 16:22:02 +02:00
Mohamed ABDELLANI
1b8a9244a6
test when user is a non-persisted object
2023-04-15 06:16:40 +01:00
dependabot[bot]
a40e883d17
Bump cable_ready from 5.0.0-rc2 to 5.0.0
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-rc2 to 5.0.0.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits/v5.0.0 )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-14 09:57:54 +00:00
Jean-Baptiste Bellet
6bf21d2abd
SASS loader: Do not print warnings from dependencies
2023-04-14 11:09:39 +02:00
David Cook
29b9777a96
Replace deprecated sass division operator
...
https://sass-lang.com/documentation/breaking-changes/slash-div
> Sass currently treats / as a division operation in some contexts and a separator in others. This makes it difficult for Sass users to tell what any given / will mean, and makes it hard to work with new CSS features that use / as a separator.
There's a handy migrator:
npm install -g sass-migrator
sass-migrator division **/*.scss
And it cleverly avoids the need for the ugly division method in most cases.
2023-04-14 17:59:01 +10:00
David Cook
283dd84ad6
Add expected whitespace
...
The migrator refused to proceed until I fixed this.
2023-04-14 17:56:24 +10:00
Maikel Linke
03828c5608
Style Rails/ToSWithArgument
2023-04-14 16:34:51 +10:00
Maikel Linke
dad4061ff9
Style Rails/ToFormattedS
2023-04-14 16:32:39 +10:00
Maikel Linke
b19df0dfbf
Enable new Rubocop cops
...
This detects an additional 639 offenses which I added to the todo file.
From now on, when Dependabot bumps rubocop the build may fail due to new
cops. But that's a great opportunity to utilise those new cops and fix
violations straight away. Otherwise we'll never get to them and lose out
on useful autocorrection, for example for updating deprecated syntax.
2023-04-14 16:28:20 +10:00
Maikel Linke
efb2ae6843
Style Rails/Pick - rubocop passes completely
2023-04-14 16:22:46 +10:00
Maikel Linke
407fca17cb
Style Rails/IndexWith
2023-04-14 16:19:21 +10:00
Maikel Linke
33409725a5
Run rubocop-rails with current Rails version 7.0
...
This adds three new issues I will address in the next commits.
```
Offenses:
app/json_schemas/json_api_schema.rb:40:7: C: [Correctable] Rails/IndexWith: Prefer index_with over to_h { ... }.
relationships.to_h { |name| [name, relationship_schema(name)] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/base.rb:18:11: C: [Correctable] Rails/IndexWith: Prefer index_with over map { ... }.to_h.
data_attributes.map { |attr| [attr, I18n.t("header.#{attr}", scope: i18n_scope)] }.to_h
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/sales_tax/sales_tax_totals_by_order.rb:140:14: C: [Correctable] Rails/Pick: Prefer pick('sum(amount)') over pluck('sum(amount)').first.
.pluck('sum(amount)').first || 0
^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 3 offenses detected, 3 offenses autocorrectable
```
2023-04-14 16:15:13 +10:00
Maikel Linke
c70a694111
Style line length - rubocop passes completely
2023-04-14 16:12:14 +10:00
Maikel Linke
9c88c77066
Style empty lines
2023-04-14 16:05:50 +10:00
Maikel Linke
42585bb074
Remove redundant cop disable directive
2023-04-14 16:04:57 +10:00
MadisonBowron
697f2795d4
Remove arbitrary comments
2023-04-14 01:25:14 -04:00
Maikel
b0211d0930
Merge pull request #10686 from filipefurtad0/truncates_product_description
...
Sets too long line truncation spec as pending
2023-04-14 15:11:31 +10:00
Maikel
0675422509
Merge pull request #10678 from dacook/show-commit-in-ci
...
Show commit in CI
2023-04-14 14:43:44 +10:00
Maikel
5ff1b0d358
Merge pull request #10676 from filipefurtad0/fix_spec_ts_and_cs
...
Adds pending test for default ToS
2023-04-14 14:00:32 +10:00
Maikel Linke
43cbac7d17
Simplify report filename generation
2023-04-14 11:29:36 +10:00
Maikel Linke
98e4f867b4
Provide download link for generated reports
2023-04-14 11:29:35 +10:00
Maikel Linke
ebb15781d5
Store report's filename within the blob
...
For future downloads outside the ReportsController.
2023-04-14 11:29:35 +10:00
Maikel Linke
028c4f4281
Simplify ReportJob by extracting model for result
...
This makes the code heaps simpler.
2023-04-14 11:29:35 +10:00
Maikel Linke
ef7dfa3b4f
Store reports with Active Storage
...
This will enable us to offer download links and clean them up
automatically.
2023-04-14 11:29:35 +10:00
Maikel Linke
71f9415d21
Use ApplicationJob as it's a Rails default
2023-04-14 11:29:35 +10:00
Maikel Linke
12848acf21
Fix typo
2023-04-14 11:29:35 +10:00
Maikel Linke
4f751c2711
Leverage test helpers for enqueued jobs
...
The production code calls `perform_later` and it's better to do the same
in specs. Handy test helper allow us to control the execution.
Credit to https://github.com/cyrillefr .
2023-04-14 11:29:35 +10:00
jibees
920e2564a4
Merge pull request #10692 from openfoodfoundation/dependabot/bundler/rubocop-1.50.1
...
Bump rubocop from 1.50.0 to 1.50.1
2023-04-13 13:45:28 +02:00
Jean-Baptiste Bellet
6b4e150e2a
Active split_checkout feature by default
2023-04-13 13:21:23 +02:00
dependabot[bot]
2d43e32688
Bump rubocop from 1.50.0 to 1.50.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.0...v1.50.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 09:57:38 +00:00
David Cook
a6cd393c57
Update all locales with the latest Transifex translations
2023-04-13 16:45:38 +10:00
Filipe
b1060bf1c9
Merge pull request #10640 from openfoodfoundation/dependabot/bundler/stripe-8.5.0
...
Bump stripe from 8.3.0 to 8.5.0
2023-04-12 19:27:18 +01:00
Filipe
1bf5fbaf3a
Merge pull request #10449 from macanudo527/fix_ER
...
Update OCs after ER Permissions are Revoked
2023-04-12 18:59:20 +01:00
Konrad
2ace3afd67
Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting
...
Sort orders by last name
2023-04-12 16:36:45 +02:00
Konrad
0bfceb877d
Merge pull request #10666 from jibees/9723-admin-missing-translation-in-payment-report
...
Admin, Payment reports: add missing translation for payment state
2023-04-12 15:47:23 +02:00
Filipe
c1d28b2e8f
Merge pull request #10119 from binarygit/donot-hide-producers-name-in-products
...
Display producer's name in products inspite of hide all refs option
2023-04-12 13:07:52 +01:00
Jean-Baptiste Bellet
2841b42296
Specify truncate parameter as we don't always truncate description
...
Only when too long.
2023-04-12 10:34:30 +02:00
jibees
98e44e7a40
Merge pull request #10687 from openfoodfoundation/dependabot/bundler/nokogiri-1.14.3
...
Bump nokogiri from 1.14.2 to 1.14.3
2023-04-12 10:25:56 +02:00
jibees
51c6c19f80
Merge pull request #10669 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.8
...
Bump sidekiq from 7.0.7 to 7.0.8
2023-04-12 10:24:59 +02:00
filipefurtad0
26947a64c0
Adds test to check pagination upon line-item selection
2023-04-12 09:58:01 +02:00
Jean-Baptiste Bellet
df5c21048a
Clear on bulk submenu should reset some filters + refresh data as well
2023-04-12 09:58:01 +02:00
Jean-Baptiste Bellet
8a124fb6be
BOM: once variant has been selected, refresh data with a new search
...
- Remove variant_filter
- instantiate a new search to avoid pagination issues
2023-04-12 09:58:00 +02:00
filipefurtad0
7d51979c06
Updates build environment to Ubuntu 22.04
...
Creates environment variable to set OS version
2023-04-12 09:19:14 +02:00
Maikel Linke
ced49e0217
Apply Rails standard to base mailer class
...
It has the advantage that `rails generate mailer` works out of the box
and we comply with rubocop rules.
2023-04-12 16:39:20 +10:00
dependabot[bot]
75b7a1864b
Bump nokogiri from 1.14.2 to 1.14.3
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.14.2 to 1.14.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.14.2...v1.14.3 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-12 06:24:59 +00:00
Maikel Linke
281d0eb417
Simplify mailers with Rails default "from" setting
2023-04-12 16:15:51 +10:00
Maikel Linke
496f5199c9
Use DatabaseCleaner recommendation of late cleaning
...
https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example
2023-04-12 14:24:07 +10:00
Maikel Linke
f13c0e1dca
Bring all Rspec config for database cleaning together
2023-04-12 14:23:09 +10:00
David Cook
f801d4a4cb
Move single-used variables to their own example
...
They were created three times each, but only used once.
2023-04-12 11:05:11 +10:00
David Cook
d94da8df1e
Update comment
2023-04-12 11:04:00 +10:00
MadisonBowron
8c6e0a841c
Fix rubocop extra blank line error
2023-04-11 15:35:37 -04:00
filipefurtad0
70d9cfa08e
Sets too long line truncation spec as pending
2023-04-11 19:46:11 +01:00
jibees
193ae7936e
Merge pull request #10681 from openfoodfoundation/dependabot/bundler/rubocop-1.50.0
...
Bump rubocop from 1.49.0 to 1.50.0
2023-04-11 20:40:55 +02:00
Filipe
0971e8d9b5
Merge pull request #10644 from mkllnk/report-timeout-message
...
[Hidden] Display a friendly message when a background report times out
2023-04-11 19:40:42 +01:00
Jean-Baptiste Bellet
e78b44b9ca
Do not shows <a /> if producers is hidden
...
Different style as it does not open any modal
2023-04-11 14:27:57 +02:00
binarygit
c5779eff81
Do not open modal for producer's who are 'hidden'
2023-04-11 14:27:57 +02:00
Jean-Baptiste Bellet
b616c14f63
Don't hide producer's name in products despite hide all refs opt selected
2023-04-11 14:26:47 +02:00
Mohamed ABDELLANI
03cb14c926
define manage_by scope on customer model
2023-04-11 12:18:15 +01:00
Mohamed ABDELLANI
da78e06a39
load customers of managed enterprises only
2023-04-11 12:10:07 +01:00
dependabot[bot]
f4c351febf
Bump rubocop from 1.49.0 to 1.50.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.49.0 to 1.50.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.49.0...v1.50.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-11 10:05:30 +00:00
Maikel Linke
30184ac6aa
Background reports time out earlier than nginx
...
This allows us to display a friendly message before nginx displays its
default error.
2023-04-11 16:44:13 +10:00
David Cook
a123d45eca
Fix spec
...
It's worth noting that this page hasn't been updated by this PR.
I honestly don't know why it broke, but don't care anymore. It seems the extra `login_as_admin_and_visit` was causing a race condition on one spec. It's not necessary so I've removed this context.
Best viewed with whitespace ignored.
2023-04-11 16:38:49 +10:00
James Wu
a75f16e23c
Implement full_name_for_sorting
2023-04-11 15:25:20 +10:00
James Wu
546e90b286
Sort orders by last names
2023-04-11 15:25:20 +10:00
David Cook
bf9f47a000
Show commit in CI
...
actions/checkout@v3 actually creates a merge commit into master, to ensure you're testing the latest as close to master as possible.
That's all well and good, but quite confusing when you see errors in CI that aren't present in the actual PR branch. Hopefully this will be a clue when such confusions arise.
2023-04-11 15:22:19 +10:00
David Cook
3da6e6b5ed
Link to CI page
2023-04-11 15:22:12 +10:00
Maikel Linke
111705f6f2
Clarify DatabaseCleaner use only for concurrency
...
Otherwise we use transactions.
2023-04-11 14:07:27 +10:00
Maikel Linke
68d5327b12
Load all spec helpers in one place
...
These helpers are loaded depending on the spec type. We don't need to
separate them into different files.
2023-04-11 12:56:28 +10:00
Maikel Linke
688285c374
Remove loading of unused spec helpers
...
We have only one feature spec left and it's loading the
system_helper instead of the spec_helper. These lines were dead code.
2023-04-11 12:14:02 +10:00
MadisonBowron
9d0a69cceb
Fix admin product variants form to close issues #10579 & #430
2023-04-10 18:53:01 -04:00
Konrad
15058299d8
Merge pull request #10641 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.21.4
...
Bump @babel/preset-env from 7.18.2 to 7.21.4
2023-04-10 20:00:06 +02:00
filipefurtad0
4e92f33b1c
DRYes spec; adds pending test for default ToS
2023-04-10 12:08:35 +01:00
Jean-Baptiste Bellet
c7cb982c9a
Update browser list
...
```
npx update-browserslist-db@latest
```
2023-04-10 11:20:19 +02:00
Jean-Baptiste Bellet
34e9112c0a
Fix dependencies warning: adds core and `plugin-transform-runtime
2023-04-10 11:20:19 +02:00
dependabot[bot]
28eb11bda5
Bump @babel/preset-env from 7.20.2 to 7.21.4
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.20.2 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-10 11:20:19 +02:00
jibees
d8e82d9c88
Merge pull request #10668 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.120.1
...
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
2023-04-10 11:12:45 +02:00
Mohamed ABDELLANI
061fc321b4
group records before rending the report
2023-04-07 18:44:19 +01:00
Mohamed ABDELLANI
5201e54f82
group orders before rendering the report
2023-04-07 18:16:12 +01:00
jibees
5192a08082
Merge pull request #10673 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.19.0
...
Bump rubocop-rails from 2.18.0 to 2.19.0
2023-04-07 14:33:31 +02:00
jibees
94d3f136e2
Merge pull request #10672 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.6
...
Bump @floating-ui/dom from 1.2.5 to 1.2.6
2023-04-07 14:32:45 +02:00
dependabot[bot]
db3a923ea7
Bump rubocop-rails from 2.18.0 to 2.19.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.18.0...v2.19.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:59:34 +00:00
dependabot[bot]
619eb43c57
Bump @floating-ui/dom from 1.2.5 to 1.2.6
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.6/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:58:01 +00:00
filipefurtad0
680b6a7122
Update all locales with the latest Transifex translations
2023-04-07 10:17:13 +01:00
Filipe
d9e9add78b
Merge pull request #10527 from vviekk/10456
...
Fixing 'unsaved' alert behaviour for order cycle edit forms
2023-04-06 17:05:49 +01:00
Filipe
8893824b06
Merge pull request #10635 from jibees/fix-content-security-policy-for-local-images
...
Fix content security policy: authorize `ENV["SITE_URL"]` as trusted domain for images
2023-04-06 11:25:05 +01:00
dependabot[bot]
5c221621d3
Bump sidekiq from 7.0.7 to 7.0.8
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.7 to 7.0.8.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.7...v7.0.8 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:58:23 +00:00
dependabot[bot]
60d7ed5036
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.0 to 1.120.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:57:53 +00:00
Filipe
e71a747925
Merge pull request #10667 from jibees/10662-flaky-specqueriescustomers_with_balance_specrb26
...
Flaky: Avoid flaky spec by sorting array before comparing on `spec/queries/customers_with_balance_spec.rb:26`
2023-04-06 10:47:32 +01:00
Jean-Baptiste Bellet
eedd421055
Avoid flaky spec by sorting array before comparing
2023-04-06 10:41:42 +02:00
Jean-Baptiste Bellet
e74328f1d7
Add i18n for payment state key
...
+ update spec
2023-04-06 10:28:44 +02:00
Jean-Baptiste Bellet
bb502c2e65
Authorize localhost:3000 as trusted domain for images
2023-04-06 10:10:44 +02:00
Jean-Baptiste Bellet
6abd652251
Factorize into inherited method from Base: payment_state(order)
2023-04-06 09:50:50 +02:00
Filipe
2f6b730ed4
Merge pull request #10614 from cillian/business-address-country-state-placeholders
...
Add placeholders to business address country and state select fields
2023-04-05 19:55:07 +01:00
dependabot[bot]
3821eede51
Bump stripe from 8.3.0 to 8.5.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.3.0 to 8.5.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.3.0...v8.5.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-05 16:38:33 +00:00
Filipe
2ff464321c
Merge pull request #10619 from openfoodfoundation/dependabot/npm_and_yarn/stimulus_reflex-3.5.0-rc1
...
Bump stimulus_reflex and cable_ready from 3.5.0-preX to 3.5.0-rc2
2023-04-05 17:37:15 +01:00
Filipe
fc8d9252d5
Merge pull request #10605 from abdellani/fix-impossible-to-reach-OCs-older-than-6-months
...
Fix load order cycles by date ranges
2023-04-05 17:33:51 +01:00
Rachel Arnould
3e5becf70a
Merge pull request #10538 from jibees/10537-shopfront-product-description-is-too-long
...
Shopfront: Force product description to be on one line
2023-04-05 17:42:18 +02:00
Maikel
ef841b161f
Merge pull request #10660 from MadisonBowron/master
...
Fix bug #10596 , missing translation for editing shipping category
2023-04-05 16:12:20 +10:00
Maikel
c11dd2c1fb
Merge pull request #10642 from macanudo527/fix_rubocop_errors
...
Fix Rubocop Layout/LineLength
2023-04-05 16:11:08 +10:00
Maikel Linke
8bbc545e39
Cover untranslated text by spec
2023-04-05 15:03:42 +10:00
Maikel
fc08913152
Merge pull request #10648 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.120.0
...
Bump aws-sdk-s3 from 1.119.2 to 1.120.0
2023-04-05 14:44:22 +10:00
Maikel
19ae3651fa
Merge pull request #10643 from dacook/update-node-docker
...
Update node for docker
2023-04-05 14:43:24 +10:00
Jean-Baptiste Bellet
66307c9277
cable_ready changed its Content-Type ; update the mrujs one as well
...
Thanks @marcoroth for the great debugging session! 🙏
2023-04-05 14:19:34 +10:00
Jean-Baptiste Bellet
65084422cb
cable_ready is already imported in app/webpacker/controllers/index.js
2023-04-05 14:19:34 +10:00
Jean-Baptiste Bellet
6f8ab56d2e
Replace deprecated call render operations:
...
```
DEPRECATED: CableReady's `render operations:` call has been renamed to `render cable_ready:`. Please update your render call.
```
2023-04-05 14:19:34 +10:00
dependabot[bot]
ab6cdd4c78
Bump stimulus_reflex from 3.5.0-pre9 to 3.5.0-rc2
...
Updating JS and Ruby libraries. This commit was started by Dependabot
for 3.5.0-rc1. Then we updated to rc2.
Old Dependabot message about rc1:
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex ) from 3.5.0-pre9 to 3.5.0-rc1.
- [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases )
- [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits )
---
updated-dependencies:
- dependency-name: stimulus_reflex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Bump cable_ready from 5.0.0-pre10 to 5.0.0-rc1
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-pre10 to 5.0.0-rc1.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-05 14:19:16 +10:00
David Cook
865d81d28f
Apply suggestions from code review
2023-04-05 14:05:26 +10:00
Maikel Linke
020af0c0e4
Explain report timeout better to user
2023-04-05 09:59:02 +10:00
emiliecm
5abda22831
Fix bug #10596 , missing translation for editing shipping category
2023-04-04 19:48:16 -04:00
Cillian O'Ruanaidh
89dac47aa6
Add placeholders to business address country and state select fields
2023-04-04 19:22:22 +01:00
jibees
e18d973047
Merge pull request #10655 from filipefurtad0/fix_flaky_oc_form_spec
...
Sorts plucked shipping/payment methods
2023-04-04 15:34:39 +02:00
jibees
afeeaf0a9b
Merge pull request #10657 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.23
...
Bump combine_pdf from 1.0.22 to 1.0.23
2023-04-04 14:31:06 +02:00
jibees
3010717ece
Merge pull request #10656 from openfoodfoundation/dependabot/bundler/devise-4.9.2
...
Bump devise from 4.9.1 to 4.9.2
2023-04-04 14:30:11 +02:00
dependabot[bot]
0c48dbe0d5
Bump combine_pdf from 1.0.22 to 1.0.23
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.22 to 1.0.23.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.22...v1.0.23 )
---
updated-dependencies:
- dependency-name: combine_pdf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-04 10:04:31 +00:00
dependabot[bot]
f7b215b7ac
Bump devise from 4.9.1 to 4.9.2
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.1 to 4.9.2.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.1...v4.9.2 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-04 09:58:37 +00:00
filipefurtad0
29520542db
Sorts plucked shipping/payment methods
2023-04-04 09:30:36 +01:00
Maikel Linke
00a3976905
Display a friendly message when a report times out
...
Once we get a download link for a report, we can display this message
sooner. But for now we just use the existing request timeout.
2023-04-04 11:08:20 +10:00
Maikel Linke
3bd8e430f9
Use Rack::Timeout for more realistic tests
...
The closer the test environment is to the production environment the
more realistic the tests will be, and the more code we test.
We are now able to test the app behaviour on timeouts which I want to do
for reports. We can also catch incompatibilities with the rack-timeout
gem during testing.
2023-04-04 11:08:20 +10:00
Neal Chambers
940f806e5f
Fix Rubocop Layout/LineLength
2023-04-04 09:44:15 +09:00
Neal Chambers
77733169fc
Update OCs after ERs Permissions are Revoked
2023-04-04 09:37:13 +09:00
David Cook
c34ced2f65
Merge pull request #10639 from openfoodfoundation/dependabot/bundler/puma-6.2.1
...
Bump puma from 6.1.1 to 6.2.1
2023-04-04 10:08:57 +10:00
Filipe
2051d811cf
Merge pull request #10567 from jibees/10557-allow-hide-of-ofn-main-navigation
...
White Label: Allow enterprise to hide ofn main navigation on `/shop`, `/cart`, `/checkout`, `/orders` pages
2023-04-03 20:29:37 +01:00
jibees
0335cf2441
Merge pull request #10647 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.2
...
Bump webpack-dev-server from 4.13.1 to 4.13.2
2023-04-03 16:47:02 +02:00
jibees
d3ddc8a221
Merge pull request #10650 from openfoodfoundation/dependabot/bundler/devise-4.9.1
...
Bump devise from 4.9.0 to 4.9.1
2023-04-03 16:44:46 +02:00
jibees
25e00d5210
Merge pull request #10649 from openfoodfoundation/dependabot/bundler/capybara-3.39.0
...
Bump capybara from 3.38.0 to 3.39.0
2023-04-03 16:42:53 +02:00
jibees
2a556ab329
Merge pull request #10651 from openfoodfoundation/dependabot/bundler/rubocop-1.49.0
...
Bump rubocop from 1.48.1 to 1.49.0
2023-04-03 16:42:08 +02:00
dependabot[bot]
80a94011b8
Bump rubocop from 1.48.1 to 1.49.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.48.1 to 1.49.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.48.1...v1.49.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:06:36 +00:00
dependabot[bot]
d4f2704213
Bump devise from 4.9.0 to 4.9.1
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.0 to 4.9.1.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.0...v4.9.1 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:02:14 +00:00
dependabot[bot]
91bf3c67cd
Bump capybara from 3.38.0 to 3.39.0
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.38.0 to 3.39.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.38.0...3.39.0 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:01:25 +00:00
dependabot[bot]
307a9effb0
Bump aws-sdk-s3 from 1.119.2 to 1.120.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.2 to 1.120.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:00:03 +00:00
dependabot[bot]
56e8f7b0c6
Bump webpack-dev-server from 4.13.1 to 4.13.2
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.13.1 to 4.13.2.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.13.1...v4.13.2 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 09:58:14 +00:00
Maikel
de58aa1187
Merge pull request #10529 from mkllnk/setup
...
Update setup script with newest template and merge with old script
2023-04-03 15:44:29 +10:00
Maikel Linke
da0ef8531b
Install our used bundler version
2023-04-03 14:37:31 +10:00
Maikel Linke
08f2254a0e
Leverage bin/setup within script/setup
...
And remove duplicate output. `bin/setup` is the Rails default for
updating your environment after code updates and `script/setup` is our
convenience script for the initial setup and starting with sample data.
2023-04-03 14:37:31 +10:00
Maikel Linke
477524039f
Update bundler version when necessary
...
Not just when it's missing.
2023-04-03 14:37:31 +10:00
Maikel Linke
e5e5bf8c17
Install ruby automatically if rbenv is available
...
People may use other ways to provide the right Ruby version but if they
use rbenv then we can use it automatically.
2023-04-03 14:37:30 +10:00
Maikel Linke
4999e231bc
Avoid permission warning when running sudo as root
...
The command is switching to an unprivileged user which can't access
/root and therefore there was a warning when executing. Adding `--login`
to the sudo command switches to that user properly and avoids the
warning.
2023-04-03 14:36:07 +10:00
Maikel Linke
6b857a5683
Make code examples easier to copy without $ sign
...
The $ sign used to indicate shell commands. But with markdown it's
obvious that we are entering commands.
Github has a quick copy button for all code examples which used to copy
the $ sign as well. Removing it allows to copy and paste easier with
that button.
2023-04-03 14:35:52 +10:00
Maikel Linke
f12ee186ee
Speed up setup script when restarting rails
2023-04-03 14:33:39 +10:00
Maikel Linke
93ef95f58e
Update JS dependencies with setup script
2023-04-03 14:33:39 +10:00
Maikel Linke
49dd1dd1fa
Update setup script with newest template
...
I used the script from a new Rails 7 project.
2023-04-03 14:32:22 +10:00
David Cook
04d2f3f50d
Install nodenv to use correct Node version
...
Copying what we do for rbenv, using the same plugins that we use in https://github.com/openfoodfoundation/ofn-install/blob/master/roles/node/tasks/main.yml
2023-04-03 14:11:28 +10:00
David Cook
f43bdec0f4
Update to latest node v17
...
Really this should install nodenv though..
2023-04-03 11:41:54 +10:00
Jean-Baptiste Bellet
b79bd8ef05
Removes empty <p> tags from product description
2023-03-31 11:37:30 +02:00
Jean-Baptiste Bellet
4dfc56954c
Force .product-description to be one line
...
and make it as a `div`
2023-03-31 10:41:27 +02:00
dependabot[bot]
8c08827d35
Bump puma from 6.1.1 to 6.2.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.1.1 to 6.2.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.1.1...v6.2.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-31 08:13:31 +00:00
Maikel Linke
a56081ad5b
Update translations
2023-03-31 14:59:16 +11:00
jibees
996c6d35f3
Merge pull request #10633 from openfoodfoundation/dependabot/bundler/debug-1.7.2
...
Bump debug from 1.7.1 to 1.7.2
2023-03-30 14:08:13 +02:00
Jean-Baptiste Bellet
89036db666
Do not use a preference, but create a new column for hide_ofn_navigation
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
dd9fec58a4
Instead of parsing URLs pass order through method for Orders Ctrl
...
Use methods for before_actions
Maybe we should for hide_of_navigation too, but a name 'hide_ofn_navigation_for_order_distributor' seemed unhelpful..
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
4fa44e6c64
Put the white label behind a feature toggle white_label
...
+ update specs as well
+ for admin section also
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
4ad2a1a723
Prefer a concern that set a variable instead of a global helper
...
Therefor, for the right controllers, simply implements:
```
include WhiteLabel
before_action :hide_ofn_navigation, only: [:show, :edit]
```
This is mort robust, since we're working in a controller level, not parsing URLs...
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
5279be4dc6
Improve spec: visiting order confirmation with distributor
...
Two cases:
- the current distributor is the same than the order of the order confirmation page
- the current distributor *is not* the same than the order of the order confirmation page (and has not set `hide_ofn_navigation` preference to `true`)
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
348c1ff7da
Hide the OFN navigation menu when distributor as set its preference
...
Hide, when preference is true, for page:
- shop
- cart
- checkout
- order confirmation
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
c20ae0de1e
Edit hide_ofn_navigation in 'white label' panel for an enterprise
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
3452864503
Add "white label" panel in enterprise settings page
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
d2f29b7d73
Some refactoring to avoid rubocop class too long warning
2023-03-30 09:13:35 +11:00
Filipe
62cdda2ce2
Merge pull request #10523 from rioug/10431-voucher-minimum-backend
...
Voucher bare minimum backoffice
2023-03-29 20:21:57 +01:00
Filipe
e6123969d2
Merge pull request #10607 from mkllnk/zone-spec
...
Sort zones by name again, in the admin panel
2023-03-29 17:57:50 +01:00
Filipe
90ce52612d
Merge pull request #10615 from mkllnk/background-report-job
...
Run background reports with Sidekiq, not fork
2023-03-29 17:38:48 +01:00
jibees
7e6d40f370
Merge pull request #10621 from openfoodfoundation/dependabot/bundler/valid_email2-4.0.6
...
Bump valid_email2 from 4.0.5 to 4.0.6
2023-03-29 17:13:34 +02:00
Filipe
b6e4ff908f
Merge pull request #10566 from mkllnk/products-meta-description
...
Remove unused product meta description
2023-03-29 15:58:31 +01:00
Filipe
c16c1a5e62
Merge pull request #10544 from filipefurtad0/test_pdf_reports
...
Adds pdf comparison; removes csv, xlsx, pdf file fixtures
2023-03-29 14:03:25 +01:00
dependabot[bot]
3f5aceff99
Bump debug from 1.7.1 to 1.7.2
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.1...v1.7.2 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-29 10:00:12 +00:00
dependabot[bot]
b8e9925601
Bump valid_email2 from 4.0.5 to 4.0.6
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/micke/valid_email2/releases )
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.5...v4.0.6 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-29 07:51:47 +00:00
Maikel
667a514ed2
Merge pull request #10623 from jibees/10622-flaky-specservicesorder_cycle_form_specrb403
...
Flaky: Sort array to avoid flaky spec when comparing values
2023-03-29 16:32:44 +11:00
filipefurtad0
25108f4c70
Removes all fixture files; asserts on downloaded file
...
Changes helper method to assert there is one file only
load_file_txt will be useful in other spec files too, and could probably be moved to spec/support/file_helper.rb
2023-03-29 16:24:21 +11:00
Maikel Linke
6f83607aa8
Remove unused product meta description from DB
2023-03-29 14:35:16 +11:00
Maikel Linke
70aff98581
Remove unused product meta description from UI
2023-03-29 14:33:42 +11:00
Maikel
812fb974dd
Merge pull request #10584 from openfoodfoundation/dependabot/bundler/devise-i18n-1.11.0
...
Bump devise-i18n from 1.10.3 to 1.11.0
2023-03-29 13:08:35 +11:00
filipefurtad0
0a91f3d392
Sorts all shipiping method arrays
2023-03-28 15:46:41 +02:00
Gaetan Craig-Riou
c7c19e47de
Add feature toggle description
2023-03-28 13:46:51 +11:00
Gaetan Craig-Riou
e1845dddac
Fix TabsAndPanelsController now that #! are removed from url
...
This PR https://github.com/openfoodfoundation/openfoodnetwork/pull/9729
remove #! from url. But unfortunately, AngularJs rewrite "example.com#panel"
as "example.com#/panel" thus breaking the original implementation.
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
2e10336a47
Add ability to manage voucher for enterprise user
...
Update spec accordingly
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
37d3c025e9
Make sure New voucher page can be accessed from voucher panel
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
6eb52aa540
TabsAndPanelsController specs, add missinrg panel scenario
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
6809198c96
Vouchers specs, remove obsolete step
...
Vouchers tabs now shows when returning from new voucher page,
no need to manually click on the 'vouchers' link in the menu
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
3b7aebd6da
Enable vouchers feature toggle when running vouchers specs
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
7dc5bc87d1
Fix rubocop warnings
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
0c43d0f16a
Put vouchers admin screen behind 'vouchers' feature toggle
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
fb1ad4c65f
Remove non needed collumn from voucher list
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
04748b6e0e
Move voucher value to the model
...
Use Spree::Money to display amount with currency
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
094fc039e9
Update tabs_and_panels to display tab and panel based on the url anchor
...
For Vouchers, this means the voucher tab and panel are displayed when
you come back to entreprise edit screen from the new vourcher page
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
e4f40d14b8
Fix enterprise voucher tab
...
Add harcoded voucher amount
Add missing translation
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
4085aa22dc
Add create voucher action and system test
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a4add889a8
Add form on the new voucher page
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
f9f6793d10
Add template and basic controller for backoffice voucher pages
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a62687b1a7
Fix warning : The implicit block expectation syntax is deprecated
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a48fd0828c
Add Voucher model
...
A voucher belongs to an enterprise and an enterprise can have many
vouchers
2023-03-28 13:39:29 +11:00
Maikel
6cfb86e578
Link to merged feature toggle wiki page
2023-03-28 12:25:21 +11:00
Maikel
a168126cfa
Merge pull request #10600 from mkllnk/features
...
Add all feature toggles with descriptions at boot
2023-03-28 10:58:40 +11:00
Jean-Baptiste Bellet
88c833ec83
Sort array to avoid flaky spec when comparing values
2023-03-27 15:57:46 +02:00
Konrad
c887efee54
Merge pull request #10519 from vviekk/viv/10515
...
Removing 'none' from shipping categories from product edit page
2023-03-27 14:01:11 +02:00
jibees
86abff224e
Merge pull request #10616 from mkllnk/rails-7-schema
...
Update DB schema to Rails 7.0
2023-03-27 10:56:14 +02:00
vviekk
9a10c8c25a
Removing none from shipping categories from product edit page
2023-03-27 11:56:10 +05:30
Maikel Linke
4461b33491
Sort zones by name again
...
Zones were intended to be sorted by name. But I guess that the syntax of
Ransack changed one day and we didn't notice because the spec was
creating entries in the right order already (which often reflects the
query result order without parameters). So the spec is fixed to fail if
the sorting doesn't happen and Ransack is configured to sort correctly.
The previous sort value was ignored.
2023-03-27 16:36:04 +11:00
Maikel Linke
5ae9016f09
Speed up spec by skipping additional page load
...
The login_as_admin helper has to load a page to log in. Providing the
page we want to go to avoids going to the default page first.
2023-03-27 16:36:04 +11:00
Maikel Linke
67ab8f63e0
Remove superfluous test setup
...
There are no zones at the start of the test. This is probably a
left-over from old times when specs were not encapsulated in
transactions.
2023-03-27 16:36:04 +11:00
Maikel Linke
40e64acd37
Update DB schema to Rails 7.0
...
This is the result of: `./bin/rails db:migrate`
2023-03-27 16:18:02 +11:00
Maikel Linke
78fea7c7f2
Run background reports with Sidekiq, not fork
...
Forking worked in theory but crashed the browser in system specs. It
also came with many other hurdles and isn't well known solution in the
Rails community. Sidekiq can give us better control over execution
limits as well.
2023-03-27 13:27:49 +11:00
Konrad
4c61666fc7
Merge pull request #10547 from vviekk/10419
...
Enable invoices config only controls Print bulk action
2023-03-26 13:53:20 +02:00
Konrad
0c6a12a6f0
Merge pull request #10241 from binarygit/provide-err-msg-when-using-text-in-var-field
...
Admin, edit variant: only allow numerical values for weight, height, width and depth fields
2023-03-26 13:03:20 +02:00
jibees
0da245f912
Merge pull request #10595 from jibees/10592-flaky-specservicesorder_cycle_form_specrb282
...
Flaky spec: Sort each array to ensure the order
2023-03-24 16:11:49 +01:00
jibees
eba0c9c4f7
Merge pull request #10609 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.7
...
Bump prettier from 2.8.6 to 2.8.7
2023-03-24 11:22:07 +01:00
dependabot[bot]
25618c009e
Bump prettier from 2.8.6 to 2.8.7
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.6 to 2.8.7.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.6...2.8.7 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-24 09:58:19 +00:00
jibees
068ac40a76
Merge pull request #10589 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.1
...
Bump webpack-dev-server from 4.12.0 to 4.13.1
2023-03-24 10:52:01 +01:00
dependabot[bot]
5868fd1b7c
Bump webpack-dev-server from 4.12.0 to 4.13.1
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.12.0 to 4.13.1.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.12.0...v4.13.1 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-24 09:36:40 +00:00
jibees
540129854e
Merge pull request #10603 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.119.2
...
Bump aws-sdk-s3 from 1.119.1 to 1.119.2
2023-03-24 10:29:26 +01:00
jibees
f747ab568a
Merge pull request #10604 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.9.0
...
Bump knapsack_pro from 3.8.0 to 3.9.0
2023-03-24 10:23:01 +01:00
Jean-Baptiste Bellet
f9f619c036
Update all locales with the latest Transifex translations
2023-03-24 09:29:45 +01:00
Filipe
31ffeab4cd
Merge pull request #10440 from mkllnk/rails7
...
Upgrade to Rails 7.0
2023-03-23 12:04:11 +00:00
Filipe
1673a18eb6
Merge pull request #9729 from binarygit/remove-angular-from-users
...
Admin, Enterprise Settings, Users tabs: remove tooltips directives + use reflex to invite user to be managers
2023-03-23 11:52:18 +00:00
Mohamed ABDELLANI
d3a25282de
fix load order cycles by date ranges
2023-03-23 12:02:17 +01:00
Jean-Baptiste Bellet
29cdadd563
Avoid using exception but simply errors attribute contained in object
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-03-23 11:21:15 +01:00
Jean-Baptiste Bellet
8dffb38bf5
Sort each array to ensure the order
...
and then expect the right values.
2023-03-23 11:21:05 +01:00
binarygit
ecd5033efa
Replace angular for when adding a new unregistered manager to an enterprise
...
Co-Authored-By: David Cook <david@redcliffs.net >
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
a13227defa
Add I18N to all reflexes
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
465a295dfa
Delete manager invitation controller
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
9c84a6936a
Create a concern for manager invitations
...
Can be used elsewhere
Update manager_invitations.rb
2023-03-23 11:21:05 +01:00
dependabot[bot]
f3d687cbea
Bump knapsack_pro from 3.8.0 to 3.9.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.8.0...v3.9.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 10:05:23 +00:00
dependabot[bot]
6894cb5dd7
Bump aws-sdk-s3 from 1.119.1 to 1.119.2
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.1 to 1.119.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 10:04:05 +00:00
Filipe
809a57dbdb
Merge pull request #10437 from openfoodfoundation/10436-the-cookie-policy-modal-does-not-appear-to-use-the-language-selected-by-the-user
...
Translate cookie policy into languages selected by the user
2023-03-23 10:00:38 +00:00
Filipe
6b30a654a6
Merge pull request #10516 from macanudo527/fix_taxonomy
...
Fix Sorting entries in a taxonomy is broken
2023-03-23 09:23:16 +00:00
Filipe
9b749ee2e0
Merge pull request #10466 from dacook/report-summaries
...
Report summaries in JSON (API) output
2023-03-22 23:34:48 +00:00
David Cook
c27974c5a3
Add marker for summary rows
...
This can be enabled in the reports API with the hidden parameter `fields_to_show[]=report_row_type` to help with parsing summary row output.
2023-03-22 11:47:26 +00:00
David Cook
6f41a4168d
Allow headers and footers for JSON format
...
You wouldn't want it by default, but it can be enabled with a parameter like display_summary_row=true
2023-03-22 11:47:26 +00:00
David Cook
db7ac904e9
Allow column formatting and header/footer stripping to be specified independently
...
This will allow us to change the options in the following commit.
2023-03-22 11:47:26 +00:00
David Cook
96eaec908d
Remove unused mock in specs
...
It looks like it was expected that the price and amount columns would be formatted, but this is not currently the case. So I cleaned this up to be less ambiguous.
If any of these columns were to be configured for formatting, this line could be added back to test for unformatted output.
2023-03-22 11:47:26 +00:00
Maikel Linke
e0fd180edd
DRY Flipper UI config
2023-03-22 15:45:26 +11:00
Maikel Linke
fd68cbf56d
Remove on-the-fly adding of feature toggle entries
...
We now have a new source of truth. You shouldn't use a feature toggle
without adding it to OpenFoodNetwork::FeatureToggle first. All toggles
are added at boot time already.
2023-03-22 15:36:08 +11:00
Maikel Linke
9a1b1498bf
Add all feature toggles with descriptions at boot
...
So you can easily inspect and activate new features without trying to
use them first. It brings more visibility and will enable us to easily
remove retired features as well.
2023-03-22 15:36:08 +11:00
Filipe
12de3ae584
Merge pull request #10509 from mkllnk/filter-shipping-methods-by-category
...
Filter shipping methods by category
2023-03-21 17:47:22 +00:00
Rachel Arnould
75c3bf8b56
Merge pull request #9630 from binarygit/remove-angular-from-business-details
...
Remove angular from business details
2023-03-21 18:31:40 +01:00
Rachel Arnould
52c12ea896
Merge pull request #10554 from mkllnk/dfc-variants
...
Ignore master variants exporting to DFC
2023-03-21 18:30:05 +01:00
jibees
2e4bbb7740
Merge pull request #10590 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.6
...
Bump prettier from 2.8.5 to 2.8.6
2023-03-21 15:32:45 +01:00
dependabot[bot]
1b0880e7df
Bump prettier from 2.8.5 to 2.8.6
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.5 to 2.8.6.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.5...2.8.6 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-21 14:12:05 +00:00
Filipe
84f319894a
Merge pull request #10594 from jibees/10593-deployment-failed-on-master
...
Move `webpack-*` as dependency (not devDependencies)
2023-03-21 14:09:52 +00:00
Jean-Baptiste Bellet
2a9b6f8e8c
Sort each array to ensure the order
...
and then expect the right values.
2023-03-21 14:52:05 +01:00
Jean-Baptiste Bellet
c4e58eab3c
Move webpack-* as dependency (not devDependencies)
2023-03-21 14:35:57 +01:00
Neal Chambers
920e9e65bd
Merge remote-tracking branch 'origin/fix_taxonomy' into fix_taxonomy
2023-03-21 21:39:02 +09:00
David Cook
78b978efba
Merge pull request #10458 from dacook/838-node-install-scripts
...
Node install script
2023-03-21 15:02:08 +11:00
Maikel Linke
31db35675b
Add feature toggle for filtering shipping methods
2023-03-21 14:49:47 +11:00
Maikel Linke
6b25c36476
Filter ship methods by required shipping category
...
The products in an order may require several shipping categories like
refrigeration or express. We now filter the categories according to
their support of shipping categories.
2023-03-21 14:30:45 +11:00
Maikel Linke
73fa6295ec
Simplify shipping method selection code
2023-03-21 14:30:44 +11:00
Maikel Linke
b5f43b3c1c
Rename method because it's not changing the input
...
A common Ruby convention is to to use the bang naming `!` to mark method
which change the given parameter instead of returning a copy.
2023-03-21 14:30:44 +11:00
Maikel Linke
fcc68a0a19
Return new filtered list instead of modifying
...
This makes a clear distinction between the unfiltered and filtered list.
There may also be some gotchas when modifying the array of an
ActiveRecord relation. It also allows us to write shorter code without
storing a separate variable.
2023-03-21 14:30:44 +11:00
Maikel Linke
4c2d7c0d1c
Rename confusing test variable
...
The "subject" is usually the code under test. In this spec it would be
the TagRuleApplicator and not the parameter given to it. So I renamed it
to avoid confusion here.
2023-03-21 14:30:44 +11:00
Maikel Linke
eee5e8eee7
Remove unnecessary tag rule code
...
The applicator converts the input to an array, even `nil` becomes an
empty array. Iterating over an empty array doesn't do anything either,
the result is the same.
2023-03-21 14:30:44 +11:00
Maikel Linke
e227cb912b
Simplify tag rule spec
...
We don't need to know the internals. We want to know that the applicator
is not raising an error when we give `nil` or an empty collection.
2023-03-21 14:30:44 +11:00
Maikel Linke
6f3a0e8812
De-duplicate early for better performance
2023-03-21 14:30:44 +11:00
Maikel Linke
d7e4962fba
Add method for easier reading
2023-03-21 14:30:44 +11:00
David Cook
7ad5181026
Merge pull request #10568 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.12.0
...
Bump webpack-cli and webpack-dev-server from v3 to v4
2023-03-21 11:47:16 +11:00
jibees
c2133c8fa5
Merge pull request #10583 from openfoodfoundation/dependabot/bundler/flipper-active_record-0.26.2
...
Bump flipper-active_record from 0.26.0 to 0.26.2
2023-03-20 14:48:10 +01:00
dependabot[bot]
de5264138d
Bump flipper-active_record from 0.26.0 to 0.26.2
...
Bumps [flipper-active_record](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper-active_record
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 13:30:57 +00:00
Jean-Baptiste Bellet
bfbcdba98c
Modify configuration to match new version of webpacker
...
Error was:
```
ERROR in chunk admin [entry]
js/[name]-[contenthash].js
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)
```
2023-03-20 11:34:57 +01:00
David Cook
0632553a4a
Remove @webpack-cli/serve
...
This now gets included as a dependency of webpack-cli v4. If webpack-cli had been upgraded earlier, we never would have needed to specify this.
2023-03-20 11:34:57 +01:00
David Cook
a97d416bfd
Bump webpack-cli from 3.3.12 to 4.10.0
...
I don't know why, but Dependabot decided not to: https://github.com/openfoodfoundation/openfoodnetwork/pull/9798#issuecomment-1288583629
This is required for webpack-dev-server v4.
2023-03-20 11:34:56 +01:00
dependabot[bot]
b306539163
Bump webpack-dev-server from 3.11.3 to 4.12.0
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 3.11.3 to 4.12.0.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v3.11.3...v4.12.0 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 11:33:31 +01:00
jibees
caea53ab91
Merge pull request #10582 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.5
...
Bump @floating-ui/dom from 1.2.4 to 1.2.5
2023-03-20 11:23:56 +01:00
jibees
d7ee0ca434
Merge pull request #10580 from openfoodfoundation/dependabot/bundler/flipper-ui-0.26.2
...
Bump flipper-ui from 0.26.0 to 0.26.2
2023-03-20 11:20:11 +01:00
jibees
7fa4aa62f9
Merge pull request #10581 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.5
...
Bump prettier from 2.8.4 to 2.8.5
2023-03-20 11:17:14 +01:00
dependabot[bot]
ca97adb724
Bump devise-i18n from 1.10.3 to 1.11.0
...
Bumps [devise-i18n](https://github.com/tigrish/devise-i18n ) from 1.10.3 to 1.11.0.
- [Release notes](https://github.com/tigrish/devise-i18n/releases )
- [Changelog](https://github.com/tigrish/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tigrish/devise-i18n/compare/v1.10.3...v1.11.0 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:59:49 +00:00
dependabot[bot]
6295ecc7cf
Bump @floating-ui/dom from 1.2.4 to 1.2.5
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.4 to 1.2.5.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.5/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:48 +00:00
dependabot[bot]
b207d3e7fd
Bump prettier from 2.8.4 to 2.8.5
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.4 to 2.8.5.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.4...2.8.5 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:31 +00:00
dependabot[bot]
b4f3655fae
Bump flipper-ui from 0.26.0 to 0.26.2
...
Bumps [flipper-ui](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper-ui
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:17 +00:00
Jean-Baptiste Bellet
918e220557
Move $locationProvider configuration to another file
...
Actually the `config()` method of `admin_ofn` file did not run on `/admin/enterprises/*` pages for an unknown reason
Now those two files have the same configuration
2023-03-20 08:37:47 +01:00
binarygit
a397ba1ca9
Replace what's this tooltips
...
There are tooltips here that don't have a what's this?
There are many angular directives/methods being used that I haven't
looked into
Every select box is using select2
2023-03-20 08:37:47 +01:00
Maikel Linke
7cd235c84d
Translate AngularJS templates in the browser
...
AngularJS templates are compiled as assets on deploy. Any translatable
text can't be translated in Ruby during compilation because it's static
text. It needs to be translated with an AngularJS filter in the browser.
2023-03-20 17:02:10 +11:00
Jean-Baptiste Bellet
e97cd0a1fd
That particular spec is actually failing ; this must be solved
2023-03-20 16:59:19 +11:00
Jean-Baptiste Bellet
a56f061663
Prepare the spec to be factorized and to be used in different context
2023-03-20 16:59:19 +11:00
Maikel
512cb44df5
Merge pull request #10330 from mickenorlen/8909-add-balance-to-api-v1-customer-endpoint
...
Add balance to api v1 customers endpoint
2023-03-20 15:47:41 +11:00
Maikel
0ab8e62749
Merge pull request #10405 from jibees/upgrade-node-version
...
Upgrade node version
2023-03-20 10:55:41 +11:00
Mohamed ABDELLANI
008b12a75d
remove "/" from the partial path to load sub-report filters
2023-03-20 10:41:28 +11:00
Maikel Linke
2e51d9be4a
Include Rails version in db schema
...
So Rails knows which defaults to apply.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#rails-version-is-now-included-in-the-active-record-schema-dump
2023-03-20 10:41:28 +11:00
Maikel Linke
bd20e299f3
Support old cookie encryption
...
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#key-generator-digest-class-changing-to-use-sha256
2023-03-20 10:41:28 +11:00
Maikel Linke
90a92421f4
Remove obsolete setting of Zeitwerk
...
It's the default now.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#the-setter-config-autoloader-has-been-deleted
2023-03-20 10:41:28 +11:00
Maikel Linke
84daa046ca
Update I18n spec to Rails 7
2023-03-20 10:41:28 +11:00
Maikel Linke
61259bcfc2
Bump rails from 6.1.7 to 7.0.4
...
Result of:
bundle update --conservative rails railties\
actioncable actionmailbox actionmailer actionpack actiontext\
actionview activejob activemodel activerecord activestorage activesupport
2023-03-20 10:41:15 +11:00
Maikel Linke
4f44d50943
Omit Rails version restriction
2023-03-20 10:38:57 +11:00
Konrad
2e426c701e
Merge pull request #10232 from binarygit/show-correct-error-when-user-inputs-url-as-ig-acc
...
[Enterprise->Create] Show correct error message when user inputs url in instagram field
2023-03-19 21:57:02 +01:00
Konrad
99b3701e17
Merge pull request #10463 from openfoodfoundation/dependabot/bundler/devise-4.9.0
...
Bump devise from 4.8.1 to 4.9.0
2023-03-17 18:41:03 +01:00
Filipe
8bef0f9a43
Merge pull request #10337 from jibees/9419-send-invoices-per-email-in-bulk-from-the-admin-orders-page
...
Admin, orders list page: send invoices per email in bulk
2023-03-17 10:58:26 +00:00
jibees
d69aa04435
Merge pull request #10577 from openfoodfoundation/dependabot/bundler/flipper-0.26.2
...
Bump flipper from 0.26.0 to 0.26.2
2023-03-17 11:42:23 +01:00
dependabot[bot]
0b4a243d8e
Bump flipper from 0.26.0 to 0.26.2
...
Bumps [flipper](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-17 10:01:35 +00:00
David Cook
ced9784fb8
Merge pull request #10576 from openfoodfoundation/revert-10474-fix-customer-can-checkout-non-matching-shipping-and-product-categories
...
Revert "Fix: Customers can checkout with non-matching shipping and product categories"
2023-03-17 15:41:04 +11:00
David Cook
788457618f
Check ship address required based on all available methods
...
This check was implemented based on 'allowed' shipping methods, but we need to revert that logic. So for now, we can check all 'available' shipping methods.
This could potentially result in the same query being run twice, because load_shipping_methods also loads it. I opted to keep things simple and not try to optimise here.
2023-03-17 13:06:45 +11:00
David Cook
ef607da2c1
Revert "Fix: Customers can checkout with non-matching shipping and product categories"
2023-03-17 10:40:53 +11:00
Filipe
9ea6fa5c44
Merge pull request #9687 from dacook/9616-order-cycle-open-webhook
...
Add webhook triggered on Order Cycle Open
2023-03-16 17:24:22 +00:00
Konrad
a945f8f72f
Merge pull request #10522 from mkllnk/flipper-upgrade
...
Bump flipper* from 0.20.4 to 0.26.0
2023-03-16 17:24:33 +01:00
jibees
0c3ee2e8fc
Merge pull request #10574 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-4.6.0
...
Bump jasmine-core from 4.5.0 to 4.6.0
2023-03-16 14:59:33 +01:00
vviekk
54d5d0ed80
Accepting 0<unit values<1 in product import validations
2023-03-16 16:26:43 +05:30
dependabot[bot]
f6458e91c2
Bump jasmine-core from 4.5.0 to 4.6.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.5.0...v4.6.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-16 09:59:04 +00:00
vviekk
ac5cbcf19e
Merge branch 'openfoodfoundation:master' into 9978
2023-03-16 14:30:26 +05:30
David Cook
4757b82a80
Update all locales with the latest Transifex translations
2023-03-16 14:15:04 +11:00
David Cook
ad9e82e973
Merge pull request #10569 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.7
...
Bump sidekiq from 7.0.6 to 7.0.7
2023-03-16 11:47:55 +11:00
Filipe
e8430eae6d
Merge pull request #10460 from jibees/10400-pagination-in-bom-not-aggregating-results-from-quick-search-field
...
BOM: Add a search input that search for items with pagination
2023-03-15 16:31:32 +00:00
dependabot[bot]
584b013a49
Bump sidekiq from 7.0.6 to 7.0.7
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 10:05:08 +00:00
Maikel
f15cb01f2a
Merge pull request #10520 from mkllnk/return-auth-controller-spec
...
Correctly include order id in return auth spec for Rails 7 compatibility
2023-03-15 14:08:16 +11:00
Maikel Linke
f1a5c46685
Remove unnecessary Flipper memoizer config
...
Auto-config, yay.
2023-03-15 12:54:03 +11:00
Maikel Linke
00f2f92ce0
Remove unnecessary Flipper active_record config
...
This is now done automatically when including flipper-active_record in
the Gemfile.
2023-03-15 12:54:03 +11:00
Maikel Linke
fdd71cff51
Remove now unnecessary flipper_id method
...
Flipper does it for us.
2023-03-15 12:54:02 +11:00
Maikel Linke
c9ca020f05
Bump flipper* from 0.20.4 to 0.26.0
2023-03-15 12:54:02 +11:00
David Cook
d59074dabd
Tidy up spec
...
The best way to check if something changed or not, is with 'change' of course.
2023-03-15 12:18:17 +11:00
jibees
6a874b9527
Merge pull request #10562 from openfoodfoundation/dependabot/bundler/rails-6.1.7.3
...
Bump rails from 6.1.7.2 to 6.1.7.3
2023-03-14 15:02:49 +01:00
dependabot[bot]
1f08da207f
Bump rails from 6.1.7.2 to 6.1.7.3
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.7.2 to 6.1.7.3.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.7.2...v6.1.7.3 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-14 09:59:50 +00:00
Maikel Linke
9c3bdc6b9b
Remove unnecessary table join
...
And use Rails syntax for clarity and future extensions.
2023-03-14 14:38:25 +11:00
Maikel Linke
2105c0d0ea
Ignore master variants exporting to DFC
2023-03-14 14:38:24 +11:00
Maikel Linke
6e514acc77
Spec too many variants exported to DFC
2023-03-14 14:38:24 +11:00
Maikel Linke
b8338fb9af
Removing engine namespace from services
...
Services are usually not namespaced because they are part of the app.
This engine has an isolated namespace which means that we don't need to
separate with out own namespacing here.
2023-03-14 13:49:21 +11:00
jibees
687d4593fb
Merge pull request #10550 from openfoodfoundation/dependabot/bundler/database_cleaner-2.0.2
...
Bump database_cleaner from 2.0.1 to 2.0.2
2023-03-13 21:12:42 +01:00
dependabot[bot]
b62f88512f
Bump database_cleaner from 2.0.1 to 2.0.2
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases )
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v2.0.1...v2.0.2 )
---
updated-dependencies:
- dependency-name: database_cleaner
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 15:24:41 +00:00
jibees
6bdb89d090
Merge pull request #10551 from openfoodfoundation/dependabot/bundler/rubocop-1.48.1
...
Bump rubocop from 1.48.0 to 1.48.1
2023-03-13 16:16:56 +01:00
jibees
a63531c8c2
Merge pull request #10549 from openfoodfoundation/dependabot/bundler/ddtrace-1.10.1
...
Bump ddtrace from 1.10.0 to 1.10.1
2023-03-13 16:15:06 +01:00
jibees
de2a15e3e1
Merge pull request #10548 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.4
...
Bump @floating-ui/dom from 1.2.3 to 1.2.4
2023-03-13 16:14:00 +01:00
vviekk
2674df026a
Fixing 'unsaved' alert behaviour for order cycle edit forms
2023-03-13 17:50:00 +05:30
dependabot[bot]
e5f5d42d59
Bump rubocop from 1.48.0 to 1.48.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.48.0 to 1.48.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.48.0...v1.48.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 10:05:22 +00:00
dependabot[bot]
f23de206d9
Bump ddtrace from 1.10.0 to 1.10.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.0 to 1.10.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.0...v1.10.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 10:03:01 +00:00
dependabot[bot]
729bcdf291
Bump @floating-ui/dom from 1.2.3 to 1.2.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 09:58:49 +00:00
vviekk
c1c0eca7c4
Enable invoices config only controls Print bulk action
2023-03-13 11:39:21 +05:30
vviekk
e10ea4b686
Merge branch 'openfoodfoundation:master' into 9978
2023-03-11 11:00:03 +05:30
David Cook
8f67e9839d
Apply code suggestion
...
Avoids an error:
./script/nodenv-install.sh: line 13: brew: command not found
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-10 13:38:59 +11:00
Maikel Linke
62d0ce290a
Update translations
2023-03-10 11:42:36 +11:00
jibees
96ead52fcc
Merge pull request #10536 from openfoodfoundation/dependabot/bundler/rack-2.2.6.3
...
Bump rack from 2.2.6.2 to 2.2.6.3
2023-03-09 14:55:19 +01:00
dependabot[bot]
ff708952ab
Bump rack from 2.2.6.2 to 2.2.6.3
...
Bumps [rack](https://github.com/rack/rack ) from 2.2.6.2 to 2.2.6.3.
- [Release notes](https://github.com/rack/rack/releases )
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rack/rack/compare/v2.2.6.2...v2.2.6.3 )
---
updated-dependencies:
- dependency-name: rack
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-09 02:40:19 +00:00
David Cook
fdeeab5750
Test twitter with (almost) real world example
...
I discovered that twitter doesn't have 'www' in the url anymore, no '@' symbol and interestingly no trailing slash. I added back the '@' just so we can test that still.
Using a regex group we can cater for optional www in a single regex.
2023-03-09 11:22:04 +11:00
David Cook
9e7e176cf9
Accept full URLs
...
It looks like the intention was there, so I made it work.
I've included a real world example, but added capitalisation to complete the test.
2023-03-09 11:21:52 +11:00
Konrad
2daa49406a
Merge pull request #10506 from jibees/9868-product-import-empty-variant-names-recorded-differently-leads-to-variant-duplication
...
Product import: consider `display_name` with `null` or `empty` as value as equal
2023-03-08 16:58:32 +01:00
Konrad
125bc3d14b
Merge pull request #10514 from jibees/9292-changes-to-incomingoutgoing-products-lists-triggering-failed-to-update-order-cycle-error
...
Do not update `estimate_price` of a variant that is not available for the shop on OrderCycle update
2023-03-08 15:45:11 +01:00
Rachel Arnould
02300d6bb6
Merge pull request #10496 from rioug/10479-split-checkout-fix-user-blocked-at-step1
...
[split checkout] Fix bug preventing user from reaching payment step
2023-03-08 15:44:50 +01:00
Rachel Arnould
aba3968bca
Merge pull request #10447 from jibees/9148-no-bulk-delete-possible-on-bom-when-orders-have-multiple-items
...
Admin, BOM: can bulk delete line items of an order
2023-03-08 14:56:25 +01:00
Gaetan Craig-Riou
23c4298519
Fix bug when in specific scenario user couldn't proceed to payment step
...
When using a "pick up" shipping method, with a user who doesn't have a shipping address it was impossible to proceed to the payment step because shipping address was invalid.
To fix this, we ensure that "ship_address_same_as_billing" parameter is set to true when using a "pick up" shipping method.
use distributor address when shipping method doesn't require a ship address ; in doing this we follow the same logic as the legacy checkout
2023-03-08 10:49:37 +01:00
Jean-Baptiste Bellet
40a0d8e08c
Improve design: make delete not a button but a link + close to file name
2023-03-08 10:38:28 +01:00
Jean-Baptiste Bellet
5cbec5521c
Simplify ability
...
Co-Authored-By: David Cook <david@redcliffs.net >
2023-03-08 10:38:28 +01:00
Rachel Arnould
d7047bb4cc
Merge pull request #10513 from jibees/10505-add-shopper-comment-to-order-detail-summary
...
SplitCheckout: Display special_instructions of the order as emphasized text if present on summary page
2023-03-08 10:30:40 +01:00
binarygit
8f6fdf3e31
[Admin, Enterprise Settings] Remove Angular from Business Details tab
2023-03-08 10:26:05 +01:00
Rachel Arnould
1ce029d8e4
Merge pull request #10497 from jibees/10495-split-checkout-label-of-checkbox-save-card-for-future-use-is-clickable-but-not-active
...
SplitCheckout: Make label clickable to check/uncheck checkbox on step 2
2023-03-08 10:20:00 +01:00
jibees
eb7d20d74d
Merge pull request #10530 from mkllnk/flaky-service-spec
...
Stabilise spec with deterministic order
2023-03-08 09:04:29 +01:00
Maikel Linke
c4ba1e6616
Stabilise spec with deterministic order
...
The ids were returned in random order before.
2023-03-08 13:14:40 +11:00
Maikel
f97ccb4203
Merge pull request #10525 from openfoodfoundation/dependabot/bundler/ddtrace-1.10.0
...
Bump ddtrace from 1.9.0 to 1.10.0
2023-03-08 12:09:04 +11:00
Maikel
df8283661d
Merge pull request #10487 from mkllnk/time-spec
...
Prepare caching spec for Rails 7
2023-03-08 11:37:44 +11:00
Maikel
d9ee56b4a5
Merge pull request #10524 from mkllnk/dfc-urls
...
Configure host for dfc_provider engine globally
2023-03-08 11:13:48 +11:00
dependabot[bot]
2230a1f179
Bump ddtrace from 1.9.0 to 1.10.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.9.0...v1.10.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-07 09:58:38 +00:00
Maikel Linke
a9c8d9f304
Configure host for dfc_provider engine globally
...
Passing the parameter all the time was pretty inconvenient.
2023-03-07 16:39:02 +11:00
David Cook
9d5ca2255b
Apply suggestions from code review
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-07 15:38:50 +11:00
David Cook
00a823b2fc
6. Add webhook endpoints to user developer settings screen
...
Allowing creation and deleting via the user association.
It probably won't be much effort to allow editing and multiple records, but I cut it down to the minimum needed to avoid any further delays.
I couldn't find a way to test a failure in the destroy method, but decided to keep the condition because I thought it was worth having.
2023-03-07 15:38:50 +11:00
David Cook
3d81a6e280
Prevent creating duplicate webhook notifications [migration]
...
Using the clever concurrency testing borrowed from SubscriptionPlacementJob, but I thought a shorter pause time (just 100ms) would be sufficient.
I considered doing this with a new 'state' field (upcoming/open/close), but decided to keep it simple.
2023-03-07 15:38:50 +11:00
David Cook
739df4be01
4. OrderCycleOpenedJob triggers webhook
2023-03-07 15:38:50 +11:00
David Cook
b91cabc510
Also send webhook payloads for distributor owners
...
But not supplier owners.
2023-03-07 15:38:50 +11:00
David Cook
ba152f12ee
3. Add OrderCycleWebhookService to create webhook payloads for an order cycle event
2023-03-07 15:38:50 +11:00
David Cook
778baba118
User may have many WebhookEndpoints [migration]
...
Although we won't be allowing multiple in the this PR, we certainly plan to in the future.
The migration helper add_reference couldn't handle the custom column name, so I had to put it together manually.
2023-03-07 15:38:50 +11:00
David Cook
85c98c6d3e
2. Add model WebhookEndpoint [migration]
...
This will store the URL for each user that wants a notification.
We probably don't need URL validation (it's not done on Enterprise for example). It could be validated by browser input, and anyway will be validated if the webhook actually works or not.
Inspired by Keygen: https://keygen.sh/blog/how-to-build-a-webhook-system-in-rails-using-sidekiq/
2023-03-07 15:38:50 +11:00
David Cook
de9546587a
Prevent webhooks to private addresses (SSRF) [add gem]
...
Best reviewed with whitespace hidden.
Unfortunately the spec isn't allowed in CI. But it worked on my environment, I promise.
I chose `xit` so that it doesn't run unnecessarily. Perhaps we could use `pending` instead, which would execute, and notify us if it suddenly started working one day. But I doubt it.
2023-03-07 15:38:50 +11:00
David Cook
9741935955
Raise error on server error
...
And thus retry later.
I tried to test that it actually retries, or ensuring the job remained in the queue to be retried, but couldn't get it to work.
2023-03-07 15:38:50 +11:00
David Cook
9d19f37fec
1. Add WebhookDeliveryJob
...
This job is responsible for delivering a payload for one webhook event only. It allows the action to run asynchronously (and not slow down the calling process).
2023-03-07 15:38:50 +11:00
David Cook
718ac0ab80
Add Faraday for making HTTP requests [add gem]
...
It's the most popular and flexible option, so should be able to cater for our future needs best.
2023-03-07 15:38:47 +11:00
Neal Chambers
d95c5ff8a8
Use Spree Taxon Controller instead of API Taxon Controller
...
Add tests for reordering taxons
2023-03-07 13:22:59 +11:00
Maikel Linke
797b98d686
Remove Rails 5.0 controller spec workaround
...
We added a method to work around a bug. But that's not needed any more.
2023-03-07 08:46:36 +11:00
Maikel Linke
3dc3ebe584
Correctly include order id in return auth spec
...
The route to update a return authorization must include the order number
as id:
/admin/orders/:order_id/return_authorizations/:id(.:format)
The spec only worked because the controller's ivars were not reset
between requests and the order was already set. But Rails 7 will reset
the ivars and it failed finding the order without a given id.
2023-03-07 08:46:36 +11:00
Jean-Baptiste Bellet
a7644f8e8b
Update spec: can edit OC even if variant in subscription has been deleted
2023-03-06 17:12:09 +01:00
jibees
5dd2737811
Merge pull request #10517 from openfoodfoundation/dependabot/bundler/rubocop-1.48.0
...
Bump rubocop from 1.47.0 to 1.48.0
2023-03-06 15:23:25 +01:00
filipefurtad0
6d05d57846
Fixes spec when introducing invalid instagram link
...
It seems that only the slash at the end of the address is making it invalid, which does not correspond to the error message. This is a separate issue.
2023-03-06 15:02:49 +01:00
Jean-Baptiste Bellet
d9b534b829
+ update spec as well
2023-03-06 14:52:32 +01:00
Jean-Baptiste Bellet
ac739108a2
Improve readability by generating search string for ransack
2023-03-06 11:31:36 +01:00
dependabot[bot]
a78768c291
Bump rubocop from 1.47.0 to 1.48.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.47.0 to 1.48.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.47.0...v1.48.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-06 10:02:43 +00:00
Neal Chambers
3f3ae97a40
Add tests for reordering taxons
2023-03-06 18:57:02 +09:00
binarygit
ae166ae220
Fix: User does not get stuck when going backwards while creating new ent
2023-03-06 09:29:04 +01:00
binarygit
533f7048bf
[Enterprise->Create] Show correct error message when user inputs url in instagram field
2023-03-06 09:29:04 +01:00
Neal Chambers
e399e27a7d
Merge remote-tracking branch 'origin/fix_taxonomy' into fix_taxonomy
2023-03-06 15:09:13 +09:00
Neal Chambers
63ba3defec
Use Spree Taxon Controller instead of API Taxon Controller
2023-03-06 15:07:52 +09:00
Maikel
b9a7ff903f
Merge pull request #10494 from filipefurtad0/test_xlsx_reports
...
Adds coverage for CSV and XLSX file download
2023-03-06 15:00:56 +11:00
Maikel
fc6b61fc87
Merge pull request #10503 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.3
...
Bump @floating-ui/dom from 1.2.1 to 1.2.3
2023-03-06 11:52:38 +11:00
Jean-Baptiste Bellet
131772f7b2
Variant can be "not available": next and don't update its estimate price
2023-03-03 15:07:10 +01:00
Jean-Baptiste Bellet
440e776e3a
fee_calculator can be retrieved outside subscription_line_items iteration
2023-03-03 15:05:07 +01:00
filipefurtad0
56b9c28955
Splits test cases into respective context blocks
...
Reduces code
2023-03-03 11:39:03 +00:00
Jean-Baptiste Bellet
c34942dbf0
Display special_instructions of order as emphasized text if present
...
+ update spec as well
2023-03-03 11:12:11 +01:00
Jean-Baptiste Bellet
2814b1f399
Update all locales with the latest Transifex translations
2023-03-03 09:35:40 +01:00
Konrad
0e13e5408f
Merge pull request #10467 from abdellani/fix_hub_supplier_can_control_shipping_payment_method
...
limit users who can update shipping/payment method of an order cycle
2023-03-03 09:27:37 +01:00
Maikel Linke
12906d1e13
Explicitely touch instead of noop save
...
When calling `save!` without changing any attributes then Rails doesn't
always touch other records because nothing changed. So I changed the
spec to `touch` explicitely and it turns out that everything passes.
Tada, our code seems correct and it was only the spec which seemed
broken in Rails 7.
2023-03-03 12:51:12 +11:00
Maikel Linke
103bc50bdc
Make spec robust on very fast computers
...
I didn't observe it but if the spec code would run within the same
millisecond then we wouldn't be able to observe a change to
`updated_at`. Time travel solves this potential problem.
2023-03-03 12:51:12 +11:00
Maikel Linke
b6cccc2e1d
Mark broken specs, possible broken caching
...
I found this because Rails 7 converts timestamps to database precision
straight away. While we may have some broken logic in the code, most of
these cases may just be broken spec code. Watch this space.
2023-03-03 12:34:55 +11:00
Maikel Linke
918e583d01
Account for Rails 7 rounding in time spec
...
Storing a timestamp to the database has less accuracy than a Ruby Time
object. So `updated_at` changes after being written and loaded from the
database. Rails 7 accounts for that by rounding it in the model already
before it's written to the database. That made one spec fail.
2023-03-03 12:34:55 +11:00
Maikel
6371f7eff6
Merge pull request #10474 from abdellani/fix-customer-can-checkout-non-matching-shipping-and-product-categories
...
Fix: Customers can checkout with non-matching shipping and product categories
2023-03-03 11:27:11 +11:00
Filipe
60bea89f5c
Merge pull request #10135 from abdellani/fix_when_user_deletes_a_shipping_method_existing_orders_are_updated_with_a_random_shipping_method
...
Fix When user deletes a shipping method existing orders are updated with a random shipping method
2023-03-02 20:03:59 +00:00
Jean-Baptiste Bellet
7b8ccccdc3
display_name can actually be null or empty: consider them as equal
2023-03-02 17:15:57 +01:00
dependabot[bot]
fb01a6e244
Bump devise from 4.8.1 to 4.9.0
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.8.1 to 4.9.0.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.8.1...v4.9.0 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 14:47:11 +00:00
jibees
f88689e45f
Merge pull request #10469 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.6
...
Bump sidekiq from 7.0.5 to 7.0.6
2023-03-02 15:32:17 +01:00
jibees
1c1a7ffe9b
Merge pull request #10444 from openfoodfoundation/dependabot/bundler/devise-i18n-1.10.3
...
Bump devise-i18n from 1.10.2 to 1.10.3
2023-03-02 15:30:01 +01:00
dependabot[bot]
0cae069769
Bump @floating-ui/dom from 1.2.1 to 1.2.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.1 to 1.2.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:45:36 +00:00
jibees
0aa11581af
Merge pull request #10502 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.3.0
...
Bump @hotwired/turbo from 7.2.5 to 7.3.0
2023-03-02 13:44:20 +01:00
dependabot[bot]
4d72c807ea
Bump devise-i18n from 1.10.2 to 1.10.3
...
Bumps [devise-i18n](https://github.com/tigrish/devise-i18n ) from 1.10.2 to 1.10.3.
- [Release notes](https://github.com/tigrish/devise-i18n/releases )
- [Changelog](https://github.com/tigrish/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tigrish/devise-i18n/compare/v1.10.2...v1.10.3 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:43:57 +00:00
dependabot[bot]
f182712188
Bump sidekiq from 7.0.5 to 7.0.6
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:43:45 +00:00
jibees
1171577d5d
Merge pull request #10489 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.2
...
Bump sidekiq-scheduler from 5.0.1 to 5.0.2
2023-03-02 13:42:54 +01:00
jibees
d05522c21c
Merge pull request #10472 from openfoodfoundation/dependabot/bundler/omniauth_openid_connect-0.6.1
...
Bump omniauth_openid_connect from 0.6.0 to 0.6.1
2023-03-02 13:42:37 +01:00
jibees
cbdb3c2834
Merge pull request #10504 from openfoodfoundation/dependabot/bundler/rubocop-1.47.0
...
Bump rubocop from 1.46.0 to 1.47.0
2023-03-02 11:12:46 +01:00
dependabot[bot]
87c3165a24
Bump rubocop from 1.46.0 to 1.47.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.46.0...v1.47.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 10:02:09 +00:00
dependabot[bot]
81e96298b5
Bump @hotwired/turbo from 7.2.5 to 7.3.0
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.2.5 to 7.3.0.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.2.5...v7.3.0 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 09:57:36 +00:00
binarygit
fd81429f39
Specify weight, height, width and depth as numeric field
2023-03-01 16:32:18 +01:00
filipefurtad0
b99383185b
Adds coverage for PDF file download
2023-03-01 14:32:35 +00:00
filipefurtad0
66485e2e16
Adds coverage for XLSX file download
2023-03-01 14:32:35 +00:00
filipefurtad0
c1b60d88d6
Adds coverage for CSV file download
2023-03-01 14:32:28 +00:00
dependabot[bot]
b734067785
Bump omniauth_openid_connect from 0.6.0 to 0.6.1
...
Bumps [omniauth_openid_connect](https://github.com/m0n9oose/omniauth_openid_connect ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/m0n9oose/omniauth_openid_connect/releases )
- [Changelog](https://github.com/omniauth/omniauth_openid_connect/blob/master/CHANGELOG.md )
- [Commits](https://github.com/m0n9oose/omniauth_openid_connect/compare/v0.6.0...v0.6.1 )
---
updated-dependencies:
- dependency-name: omniauth_openid_connect
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-01 14:22:38 +00:00
jibees
e7bf912a23
Merge pull request #10490 from openfoodfoundation/dependabot/bundler/puma-6.1.1
...
Bump puma from 6.1.0 to 6.1.1
2023-03-01 15:14:57 +01:00
Jean-Baptiste Bellet
50bc48c96f
Introduce some specs around searching in BOM
2023-03-01 14:54:46 +01:00
Jean-Baptiste Bellet
8ad532c41a
Can search bill_address:phone, firstname, lastname and distributor:name
2023-03-01 14:54:46 +01:00
Jean-Baptiste Bellet
ebd5d706c2
Add search input
...
Actually this only search for `order_email` or `order_number` or `product_name` or `supplier_name`
+ Improve display by reduce each columns width
2023-03-01 14:40:12 +01:00
jibees
b07a0fca50
Merge pull request #10498 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.8.0
...
Bump knapsack_pro from 3.7.0 to 3.8.0
2023-03-01 11:01:37 +01:00
Mohamed ABDELLANI
348f806bbe
remove load_shipping_methods
2023-03-01 10:53:03 +01:00
Mohamed ABDELLANI
89037e160c
Update app/controllers/concerns/checkout_callbacks.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-01 10:51:27 +01:00
Mohamed ABDELLANI
eab8e2be6c
load exclusively the shipping methods that support all the shipping categories of the line items
2023-03-01 10:51:27 +01:00
dependabot[bot]
d146684acb
Bump knapsack_pro from 3.7.0 to 3.8.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.7.0...v3.8.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-01 09:13:38 +00:00
Jean-Baptiste Bellet
08e23023b3
Make label clickable to check/uncheck checkbox
2023-03-01 08:46:33 +01:00
Maikel
c3fe399f0c
Merge pull request #10476 from mkllnk/flaky-index-spec
...
Stabilise flaky spec with defined enterprise order
2023-03-01 10:05:44 +11:00
Maikel
182e5bd0ee
Merge pull request #10493 from jibees/10492-background-reports-background_reports-breaks-pdf-and-xlsx-file-download
...
Reports, `background_reports` feature toggle activated: Force writing file in binary mode
2023-03-01 10:00:11 +11:00
Maikel
bccee0698f
Merge pull request #10332 from jibees/8901-allow-product-description-to-show-images-in-the-shopfront
...
Shopfront: Allow product description with formatting and `<img />`
2023-03-01 09:56:41 +11:00
Konrad
11928859bc
Merge pull request #10438 from jibees/10133-update-column-dropdown-everywhere
...
Redesign old columns dropdown component to match the design of the new one
2023-02-28 20:22:00 +01:00
Konrad
6a0b9cbb76
Merge pull request #10459 from openfoodfoundation/dependabot/bundler/stripe-8.3.0
...
Bump stripe from 8.0.0 to 8.3.0
2023-02-28 19:22:50 +01:00
Jean-Baptiste Bellet
8658b1a743
Remove quick filter that search only on displayed line items
...
+ remove specs as well
2023-02-28 15:39:31 +01:00
Jean-Baptiste Bellet
075e295fc2
Force writing file in binary mode
...
```
/Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:22:in `write': "\\xFE" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
from /Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:22:in `write'
from /Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:8:in `perform'
```
2023-02-28 15:30:14 +01:00
jibees
151f96f673
Merge pull request #10486 from mkllnk/i18n-spec
...
Remove unused Spree translation checker
2023-02-28 14:28:39 +01:00
dependabot[bot]
2d7c593fe6
Bump sidekiq-scheduler from 5.0.1 to 5.0.2
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.1 to 5.0.2.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.1...v5.0.2 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-28 10:52:14 +00:00
dependabot[bot]
5cded5ba8d
Bump puma from 6.1.0 to 6.1.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.1.0...v6.1.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-28 09:57:59 +00:00
Maikel Linke
4f15b5a65b
Specify raised error in spec and avoid warning
...
Before it said:
```
WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<RuntimeError: Cannot use t(".legacy_translation") shortcut because path is not available>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`.
```
2023-02-28 15:44:18 +11:00
Maikel Linke
bf1cbe615f
Remove unused Spree translation checker
...
If we wanted similar functionality in the future then we would implement
it differently. At the moment, it's just unused code.
2023-02-28 15:44:18 +11:00
Maikel
890ab6796e
Merge pull request #10413 from mkllnk/reports-params
...
Fix background processing of Enterprise Fee Summary report
2023-02-28 13:07:59 +11:00
Maikel Linke
10aa7730e5
Rename user var again for clarity
2023-02-28 12:50:55 +11:00
Maikel Linke
116e844004
Stabilise flaky spec with defined enterprise order
2023-02-28 12:42:55 +11:00
Maikel Linke
16289a62f1
Rename test vars for clarity
2023-02-28 12:42:55 +11:00
Maikel Linke
e9fa360d61
Take test setup as granted and simplify
2023-02-28 12:42:55 +11:00
Maikel Linke
e6eb9412d9
Simplify owner selection in spec
...
Instead of knowing the input id generated by select2, we now rely on the
fact that the owner is in the fifth column. Both could change but this
is less code.
2023-02-28 12:42:55 +11:00
Maikel Linke
401210ef44
DRY and clarify test case
2023-02-28 12:42:55 +11:00
Maikel Linke
f484518ee5
Remove unused test enterprise
2023-02-28 12:42:55 +11:00
Mohamed ABDELLANI
066c7bb449
promote OrderManagement::Stock::Estimator.calculate_cost to a public method
2023-02-27 17:49:54 +01:00
jibees
165fb59f64
Merge pull request #10482 from anansilva/10044-fix-activemodel-errors-deprecation-warning
...
Fix deprecation warning when accessing model errors
2023-02-27 17:29:33 +01:00
Filipe
42bc9d7f82
Merge pull request #10477 from mkllnk/js-specs
...
Remove old test setup code of feature specs
2023-02-27 15:54:40 +00:00
Mohamed ABDELLANI
25d8ce1737
fix shipping methods related tests
2023-02-27 15:56:14 +01:00
jibees
f8dce4053a
Merge pull request #10473 from openfoodfoundation/dependabot/bundler/rubocop-1.46.0
...
Bump rubocop from 1.45.1 to 1.46.0
2023-02-27 15:36:53 +01:00
dependabot[bot]
c93945a111
Bump rubocop from 1.45.1 to 1.46.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.45.1 to 1.46.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.45.1...v1.46.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 14:26:22 +00:00
jibees
30b2f9164e
Merge pull request #10484 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.18.0
...
Bump rubocop-rails from 2.17.4 to 2.18.0
2023-02-27 15:21:54 +01:00
Jean-Baptiste Bellet
5208094f05
Do not bulk send invoices if order is not 'complete' or 'resumed'
...
+ update specs as well
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
8926a3f08d
Having a cleaner syntax a prefer using map() instead of forEach()
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
58ea3a10e8
Invert condition on can send invoice
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
5ca5c32da4
Factorize what could be into two methods: success and orders
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
7a1a1286d2
Factorize two reflexes into one: BulkActionsInOrdersListReflex
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
5e61aa8a77
Create the bulk send invoice action in order list
...
using the same pattern than SendConfirmationEmail action
Co-Authored-By: David Cook <david@redcliffs.net >
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
af92b9f464
Reorganize spec by dividing into two contexts: 'admin' and 'hub manager'
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
ffaf4a837f
Extract common behavior to BulkActionsController
2023-02-27 14:30:58 +01:00
Jean-Baptiste Bellet
c83dac58a3
Confirm line items deletion that doesn't trigger an order cancelation
2023-02-27 11:09:59 +01:00
dependabot[bot]
f355f1ccfb
Bump rubocop-rails from 2.17.4 to 2.18.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.4 to 2.18.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.4...v2.18.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 09:57:28 +00:00
Jean-Baptiste Bellet
166e2f525e
New design uses lowercase for component title
...
and specify clicking inside the dropdown
2023-02-27 09:56:48 +01:00
Ana Nunes da Silva
d70c34fbd0
fix deprecation warning when accessing model errors
2023-02-26 21:04:16 +00:00
Konrad
27630a4304
Merge pull request #10442 from mkllnk/enterprise-fee-summary-report
...
Report deleted fees in Enterprise Fee Summary
2023-02-26 19:28:01 +01:00
vviekk
913f8bbad0
Addressing comments
2023-02-26 15:50:34 +05:30
Maikel Linke
953ff2bd08
Remove more unused spec helpers
2023-02-24 15:31:18 +11:00
Maikel Linke
d7fa508b60
Remove unused matcher have_flash_message
2023-02-24 15:19:54 +11:00
Maikel Linke
815cef16cc
Remove browser test config from unit tests
...
Mailer specs still use Capybara but they don't use Javascript and don't
need this config.
2023-02-24 15:17:49 +11:00
Maikel Linke
3d5584e47c
Update outdated comment
2023-02-24 15:10:46 +11:00
Maikel Linke
cb64361096
Remove old feature spec tag
...
Nowadays all system specs are run in a real browser.
2023-02-24 15:10:19 +11:00
Maikel Linke
bba41177b4
Remove old test setup code of feature specs
...
The `js: true` tag was only used in feature specs. Some system specs
still contain that tag but they don't require this file. So it's dead
code.
2023-02-24 15:04:03 +11:00
Maikel Linke
800ccf5037
Remove unused method
2023-02-24 10:40:09 +11:00
Maikel Linke
8c7b4f73f7
Detect transaction fee even if fee name is missing
...
The Enterprise Fee Summary report is not always providing a fee name.
While that may be a bug on its own, we handle that gracefully now.
2023-02-24 10:40:09 +11:00
Maikel Linke
8b0c4ee0ac
Add unit test for failing Enterprise Fee Summary
...
I observed this data but I'm unsure about the root cause. It could be
that the SQL query fetching this data needs tweaking to return the fee
name in this case or it could be that it's not available (deleted).
In any case, I thought I document what's happening and make this
summarizer more robust before looking into the query.
2023-02-24 10:40:09 +11:00
Filipe
3ffe39d467
Merge pull request #10448 from vviekk/viv/10009
...
Fixing Enterprise creation submit button behavior
2023-02-23 16:00:53 +00:00
vviekk
956ed826a1
Adding test
2023-02-23 20:02:02 +05:30
Mohamed ABDELLANI
13383316af
fix tests
2023-02-23 08:11:11 +01:00
Mohamed ABDELLANI
28f0d69540
Update app/services/order_cycle_form.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-02-23 07:22:49 +01:00
Mohamed ABDELLANI
e705aa51bd
fix existing tests: OrderCycleForm expects an instance of Spree::User (and not an Enterprise)
2023-02-23 07:12:47 +01:00
Mohamed ABDELLANI
a7e6760028
limit users who can update shipping/payment method of an order cycle
2023-02-23 07:09:49 +01:00
David Cook
06d370a8ac
Update all locales with the latest Transifex translations
2023-02-23 13:00:36 +11:00
David Cook
013533f7de
Merge pull request #10397 from openfoodfoundation/dependabot/bundler/roo-2.10.0
...
Bump roo from 2.9.0 to 2.10.0
2023-02-23 10:53:50 +11:00
David Cook
d199dea5eb
Style fix: Layout/EmptyLines
2023-02-23 10:12:06 +11:00
David Cook
084211f52a
Add comments
2023-02-23 10:10:32 +11:00
Filipe
604fd75cff
Merge pull request #10247 from abdellani/sales_tax_totals_by_order
...
sales tax totals by order report
2023-02-22 20:03:45 +00:00
Konrad
8b89c8d7e0
Merge pull request #10451 from cyrillefr/Sort-properly-date-chronologically-and-not-lexicographically
...
Sort correctly in Bulk Order Managment
2023-02-22 14:39:03 +01:00
cyrillefr
e4845f4165
Add a spec for sorting in Bulk Order management
2023-02-20 21:43:05 +01:00
cyrillefr
c015b2066f
Sort correctly in Bulk Order Managment
...
Converting date to utc + iso8601 format is
sufficient to ensure proper sorting.
2023-02-20 21:41:58 +01:00
Konrad
f7f49377b4
Merge pull request #10297 from cyrillefr/convert-admin-order-cancellation-workflow-to-stimulus-reflex
...
Convert admin order cancellation workflow to stimulus reflex
2023-02-20 21:38:33 +01:00
Mohamed ABDELLANI
960dd81b76
remove customer id filter
2023-02-20 14:58:51 +01:00
Mohamed ABDELLANI
dda61d17ee
delegate distributor && order_cycle to the order in the OrderFeesHandler
2023-02-20 14:19:08 +01:00
Mohamed ABDELLANI
8ff197457e
test accessing the Sales Tax Report By Order using different roles
2023-02-20 14:19:08 +01:00
Mohamed ABDELLANI
c43834915d
sales_tax_totals_by_order report
2023-02-20 14:19:08 +01:00
Filipe
10d8e80c45
Merge pull request #10420 from anansilva/9311-remove-code-generating-receipts
...
Remove code generating receipts
2023-02-20 12:44:13 +00:00
Mohamed ABDELLANI
0738133e99
Update spec/system/admin/order_spec.rb
...
Co-authored-by: Filipe <49817236+filipefurtad0@users.noreply.github.com >
2023-02-20 09:55:29 +01:00
Mohamed ABDELLANI
15c241295e
recreate the shipping rate that refers to the original shipping method if distributor no longer support it
2023-02-20 09:55:22 +01:00
vviekk
fc951e92ac
Updating price, on_hand, on_demand validations for product import
2023-02-18 13:52:35 +05:30
jibees
4e2430ea58
Merge pull request #10454 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.5
...
Bump sidekiq from 7.0.4 to 7.0.5
2023-02-17 14:57:42 +01:00
dependabot[bot]
4661b47ede
Bump stripe from 8.0.0 to 8.3.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.0.0 to 8.3.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.0.0...v8.3.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-17 10:04:03 +00:00
Maikel Linke
e2ea4d21f4
Update translations
2023-02-17 14:12:24 +11:00
David Cook
d377300f32
Support installations with homebrew (macOS)
...
The officially recommended installation for Mac is via Homebrew.
2023-02-17 10:36:10 +11:00
David Cook
b7a3f7263b
Add script to install current node version
...
The API is conveniently exactly the same as rbenv.
2023-02-17 10:17:48 +11:00
Filipe
2f0e00370b
Merge pull request #10385 from rioug/10350-BUU-read-only-product-list-take-2
...
New product page, add missing column and handle formatting
2023-02-16 18:41:05 +00:00
dependabot[bot]
45da8fddf1
Bump sidekiq from 7.0.4 to 7.0.5
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.4 to 7.0.5.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.4...v7.0.5 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-16 18:29:21 +00:00
Filipe
b91bb8961f
Merge pull request #10434 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.4
...
Upgrade sidekiq from 6.5.8 to 7.0.4 (incl new metrics tab)
2023-02-16 18:18:17 +00:00
Filipe
5e3b0cf47c
Merge pull request #10433 from openfoodfoundation/dependabot/npm_and_yarn/rails/webpacker-5.4.4
...
Bump @rails/webpacker from 5.4.3 to 5.4.4
2023-02-16 18:05:13 +00:00
Filipe
ba46756cba
Merge pull request #10445 from cyrillefr/Remov-I18nt-keys-from-automated-tests#9499
...
Remov i18nt keys from automated tests#9499
2023-02-16 17:51:08 +00:00
Filipe
f6c9246e20
Merge pull request #10343 from jibees/9538-track-404-errors-in-bugsnag
...
Notify bugsnag on 404 errors
2023-02-16 17:45:41 +00:00
Konrad
11e9329b97
Merge pull request #10351 from rioug/9874-order-cycle-creation-fix-needless-warning-and-data-loss
...
Order cycle creation, fix needless warning and add warning to prevent data loss
2023-02-16 16:08:37 +01:00
Rachel Arnould
1a7598d96d
Merge pull request #10428 from jibees/9145-Splitcheckout,-add-error-message-when-no-shipping-methods-are-available-to-the-customer
...
SplitCheckout: improve error messages in flash banner to improve user experience
2023-02-16 15:33:12 +01:00
Jean-Baptiste Bellet
2eec3d625a
Notify bugsnag on 404 errors
2023-02-16 13:45:42 +00:00
cyrillefr
ba30606052
Remove I18n keys from consumer specs
2023-02-16 14:33:17 +01:00
cyrillefr
f6f62515b5
Remove I18n keys in system admin specs
2023-02-16 14:33:09 +01:00
cyrillefr
a75892ccc1
Remove I18n keys in support specs
2023-02-16 14:28:14 +01:00
cyrillefr
0082653170
Remove I18n keys in service specs
2023-02-16 14:28:14 +01:00
cyrillefr
cc0b23c0bd
Remove I18n keys in request specs
2023-02-16 14:28:14 +01:00
cyrillefr
b3ad5aeaca
Remove I18n keys in model specs
2023-02-16 14:28:14 +01:00
cyrillefr
ffe9756f50
Removes I18n keys in mailer specs
2023-02-16 14:27:21 +01:00
dependabot[bot]
40eb5e320b
Bump @rails/webpacker from 5.4.3 to 5.4.4
...
Bumps [@rails/webpacker](https://github.com/rails/webpacker ) from 5.4.3 to 5.4.4.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/v5.4.4/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.4.3...v5.4.4 )
---
updated-dependencies:
- dependency-name: "@rails/webpacker"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-16 11:06:29 +00:00
jibees
4e4a392a8c
Merge pull request #10443 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.0-pre10
...
Bump cable_ready from 5.0.0-pre9 to 5.0.0-pre10
2023-02-16 12:00:48 +01:00
Filipe
e3fa933699
Merge pull request #10381 from anansilva/8229-listing-orders-payment-state-cancelled-order
...
Update payment (cash/EFF) state on cancelled order
2023-02-15 12:06:38 +00:00
Jean-Baptiste Bellet
e5ca8b0ee1
Delete selected line items even if does not lead to order cancellation
2023-02-15 11:49:53 +01:00
Jean-Baptiste Bellet
cf8d9c6d07
Improve spec when deleting all items of an order
...
- Order1 has two line items
- Check other Order2 does not change its state
- Prepare context for the second spec: delete one line item of an order that does not trigger any order cancellation
2023-02-15 11:38:04 +01:00
Mikael Norlén
f645f8fc79
Improve schema method get_extra_fields
...
Use double-splat for passing options and improve examples
2023-02-15 11:14:28 +01:00
Mikael Norlén
3d06b75892
Simplify customers_with_balance spec
...
Improve variable names and use multiple expectations
2023-02-15 11:14:28 +01:00
Mikael Norlén
af23375b04
Separate Structure from JsonApiSchema
...
Class was getting too long
2023-02-15 11:14:28 +01:00
Mikael Norlén
f15a4cc943
Add autogenerated whitespaces to swagger.yml
...
These whitespaces were generated by
bundle exec rails rswag.
Might be related to a new version of rswag or
developers' trim trailing whitespace settings.
2023-02-15 11:14:28 +01:00
Mikael Norlén
e95d08cae8
Add balance to api v1 customers endpoint
...
- customers#show: Add balance (data_type: double) to customer attributes.
- customers#index: Add balance only if specified in extra_fields
query parameter: extra_fields[customer]=balance
2023-02-15 11:14:27 +01:00
Mikael Norlén
3989843a21
Add support for extra fields in JsonApiSchemas
...
As we are now supporting optional extra fields,
We need to be able to construct schemas where
extra fields are optionally included.
2023-02-15 11:14:27 +01:00
Mikael Norlén
22b1dd3232
Add support for extra_fields query parameter
...
Api now supports optional fields.
These are included with the extra_fields query param.
Syntax: extra_fields[type]=field1,field2
2023-02-15 11:14:27 +01:00
Mikael Norlén
96c0057b03
Use Customers as argument for CustomersWithBalance
...
Change argument for CustomersWithBalance from
enterprise_id to Customers collection.
We have the need to calculate balance for customers in general,
not just for customers in a given enterprise.
2023-02-15 11:14:27 +01:00
cyrillefr
78a6317c84
Remove I18n keys in reports lib specs
2023-02-15 11:08:19 +01:00
cyrillefr
fa57e37467
Remove I18n keys in User ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
7c24f6b26f
Remove I18n keys from Pay/Stripe/Chkout Ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
f9f6abf740
Remove I18n keys from Api Ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
e6c0dd95c4
Remive I18n keys in Admin ctrller specs
2023-02-15 11:08:19 +01:00
dependabot[bot]
ade2eda638
Bump cable_ready from 5.0.0-pre9 to 5.0.0-pre10
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-pre9 to 5.0.0-pre10.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-15 09:57:26 +00:00
Jean-Baptiste Bellet
0a3d362282
Still improve error message for Billing address
...
```
"Bill" is a person's name, and I don't know his address
```
;)
2023-02-15 10:07:59 +01:00
Jean-Baptiste Bellet
08fb496f55
Don't need to show any ship_address errors if no ship selected nor
...
if the ship_address is the same than the billing one
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
4cea7b1957
Improve error message, and use the same than the view
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
88607a3dce
Improve bill address error message
...
"(Street + House number)" instead of "address1"
and "postcode" instead of "zipcode"
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
a39598d049
Reorder error messages to improve readability
...
tbs;
2023-02-15 09:52:10 +01:00
Jean-Baptiste Bellet
9a03023b6b
Replace bill_address phone by Customer phone to improve readability
...
TBS;
2023-02-15 09:44:26 +01:00
vviekk
2091eff671
Fixing Enterprise creation submit button behavior
2023-02-15 12:42:59 +05:30
David Cook
d3e0ff269f
Remove unsupported config
...
In Sidekiq v7, this field is not recognised and gets passed through to Redis, which also doesn't recognise it and crashes.
It was added to avoid filling up Redis on dev, but it's actually a Sidekiq pro option which needs to be defined on jobs, so I guess it never worked.
2023-02-15 12:22:41 +11:00
Gaetan Craig-Riou
eb67340c52
Simplify usage of UnsavedChangesController
...
Remove the need to manually bind handleSubmit to onSubmit event
2023-02-15 10:51:23 +11:00
Gaetan Craig-Riou
75ed68c9cb
UnsavedChangesController, automatically add onChange event handler to form elements
2023-02-15 10:30:52 +11:00
Maikel
255fc64fdb
Merge pull request #10383 from filipefurtad0/add_pagination_BOM_spec
...
Adds a spec on BOM pagination
2023-02-15 09:38:43 +11:00
Ana Nunes da Silva
40bc53c16b
Delete receipt printing preferences (migration)
2023-02-14 21:29:27 +00:00
Ana Nunes da Silva
6de1fdc4ff
Remove jquery-1.8.0.js
...
Some js tests fail because they are dependant on jquery and we removed
jquery-1.8.0.js. Adding jquery2 to application_spec.js instead.
2023-02-14 21:28:53 +00:00
Jean-Baptiste Bellet
d9eb97bd05
As we are in transition, angularjs dropdown component use both css classes
...
And we should specify a bit the height of the component since it's used in different context
2023-02-14 16:15:44 +01:00
Jean-Baptiste Bellet
28286a4c3e
Slightly change classes and markup to make dropdown use the new style
...
ie. `.ofn-drop-down-v2`
2023-02-14 16:15:44 +01:00
Jean-Baptiste Bellet
6ec219031d
Avoid to specifically use a label component for menu_item
...
Then, add `label` CSS rule inside `menu_item` component
2023-02-14 15:47:55 +01:00
filipefurtad0
c84ec148db
Adds a spec on BOM pagination
...
Adds coverage on bottom section of pagination
Extracts order line item creation to before block
Removes disabled option when asserting on button 2
2023-02-14 12:04:38 +00:00
jibees
eeb059ae17
Merge pull request #10435 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.119.1
...
Bump aws-sdk-s3 from 1.119.0 to 1.119.1
2023-02-14 12:29:58 +01:00
dependabot[bot]
7a5b7c4f64
Bump aws-sdk-s3 from 1.119.0 to 1.119.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.0 to 1.119.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 10:06:09 +00:00
dependabot[bot]
613c693774
Bump sidekiq from 6.5.8 to 7.0.4
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 6.5.8 to 7.0.4.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v6.5.8...v7.0.4 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 10:05:01 +00:00
Ana Nunes da Silva
696edac813
Remove qz gem dependency
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
f9817925aa
Remove receipt printing translations
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
3e03988d93
Remove receipt printing settings
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
bb71b281d6
Remove print ticket links
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
cf519116ee
Remove print ticket authorization
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
8dc50caaa8
Remove print ticket action
2023-02-14 08:08:20 +00:00
dependabot[bot]
f8c802ace4
Bump roo from 2.9.0 to 2.10.0
...
Bumps [roo](https://github.com/roo-rb/roo ) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/roo-rb/roo/releases )
- [Changelog](https://github.com/roo-rb/roo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/roo-rb/roo/compare/v2.9.0...v2.10.0 )
---
updated-dependencies:
- dependency-name: roo
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 02:59:25 +00:00
Maikel
9ea9ac99f9
Merge pull request #10356 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.1
...
Bump rspec-rails from 5.1.2 to 6.0.1
2023-02-14 13:57:38 +11:00
Gaetan Craig-Riou
1cf55cde4d
Refactor column_value, to use a giant case
...
A giant case is more readable that the previous 'smart' solution.
It also disables a couple of Rubocop checks triggered by the giant case
2023-02-14 13:36:49 +11:00
Gaetan Craig-Riou
503e0ecba1
Fix category spec as per code review
...
- Use a hardcoded string for the expected categories (taxons), and fix
taxon step up to not use default taxon
- Fix constant typo
2023-02-14 13:36:12 +11:00
Maikel Linke
4aa6898ecb
Reduce line length for easier reading
2023-02-14 12:33:29 +11:00
Maikel Linke
180434c5bd
Avoid renaming params within report
...
I changed the used parameter names within the report so that we don't
have to rename the given parameter names when the report runs. This
avoids modifying the `params` object and therefore other problems.
2023-02-14 12:33:29 +11:00
Maikel Linke
7fe913713a
Use same parameters for report job as for original
...
The Enterprise Fee Summary report modified the `params` object. So when
we pass the same `params` a second time to the report class it doesn't
find the same values. In some cases that would lead to a server error.
The next commit implements a better solution though.
2023-02-14 12:33:29 +11:00
Maikel
ecc2c7ba43
Merge pull request #10423 from mkllnk/suburbs
...
Remove unused suburbs table
2023-02-14 11:51:48 +11:00
Jean-Baptiste Bellet
32fc1eae61
Remove ship_address errors if shipping method isn't selected
2023-02-13 21:06:41 +01:00
Filipe
822f640997
Merge pull request #10427 from jibees/10417-flaky-rspec-specsystemadminproducts_specrb210
...
Fix flaky spec `spec/system/admin/products_spec.rb:210`
2023-02-13 16:39:21 +00:00
Filipe
2d0e64a7d3
Merge pull request #10426 from openfoodfoundation/dependabot/bundler/puma-6.1.0
...
Bump puma from 6.0.2 to 6.1.0
2023-02-13 15:08:25 +00:00
jibees
f5e1cbca08
Merge pull request #10321 from openfoodfoundation/dependabot/bundler/rails-6.1.7.2
...
Bump rails from 6.1.7 to 6.1.7.2
2023-02-13 14:12:39 +01:00
Jean-Baptiste Bellet
51272eef00
Actually, those two tests are in the same context
...
The diff is pretty hard to read, but i've put the two tests "removes it from the product list" and "keeps the line item on the order (admin)" under the same context and the same `before` block
2023-02-13 13:38:57 +01:00
dependabot[bot]
2f6a910a1c
Bump rails from 6.1.7 to 6.1.7.2
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.7 to 6.1.7.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.7...v6.1.7.2 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:48:01 +00:00
jibees
9ca25df934
Merge pull request #10411 from mkllnk/paper_trail
...
Bump paper_trail from 12.1.0 to 12.3.0
2023-02-13 11:46:34 +01:00
Maikel Linke
a3e1193f28
Bump paper_trail from 12.1.0 to 12.3.0
...
No breaking changes but Rails 7 support.
2023-02-13 11:21:32 +01:00
jibees
889b132069
Merge pull request #10425 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.1
...
Bump @floating-ui/dom from 1.2.0 to 1.2.1
2023-02-13 11:18:09 +01:00
jibees
3e18445c36
Merge pull request #10424 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.4.1
...
Bump js-big-decimal from 1.3.15 to 1.4.1
2023-02-13 11:07:20 +01:00
dependabot[bot]
3c158cd061
Bump puma from 6.0.2 to 6.1.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.0.2 to 6.1.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.0.2...v6.1.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:05:55 +00:00
dependabot[bot]
c464f3a43d
Bump @floating-ui/dom from 1.2.0 to 1.2.1
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.1/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:00:15 +00:00
dependabot[bot]
84be4aec7b
Bump js-big-decimal from 1.3.15 to 1.4.1
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.15 to 1.4.1.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.15...v1.4.1 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 09:59:31 +00:00
jibees
d9d18b086c
Merge pull request #10410 from mkllnk/api-customers-order
...
Sort customers by id on API v1
2023-02-13 10:41:13 +01:00
Maikel Linke
80f015912a
Remove unused suburbs table
...
Once upon a time it was used to search for enterprises in a certain
suburb. But we let Google Maps do that these days and the feature was
removed in 2015.
* c4fb4a8510
2023-02-13 17:18:02 +11:00
Maikel
3b6202313a
Merge pull request #10422 from mkllnk/flaky-karma-specs
...
Avoid side effects in Javascript specs leading to flakiness
2023-02-13 12:37:06 +11:00
Maikel Linke
d05bb508de
Avoid flaky spec by avoiding variable name conflict
...
Specs were sharing the same variable and could influence each other.
2023-02-13 12:23:45 +11:00
Maikel Linke
02ba8c1bf5
Remove side-effect in JS specs via global var
...
The code used the global BulkProducts which was shared amongst a group
of specs. Some were resetting the `products` attribute, others weren't
and the product object of one spec was leaking into the next.
One spec was also referencing a wrong attribute and must have passed
accidentally.
2023-02-13 12:18:05 +11:00
Konrad
3c83b053ce
Merge pull request #10406 from jibees/10402-error-when-no-shipping-info-has-been-selected-in-split-checkout
...
SplitCheckout: Fix an issue raised when first time checkout user submit form without selecting shipping method
2023-02-13 00:36:04 +01:00
Maikel
64032c9207
Merge pull request #10416 from filipefurtad0/flaky_footer_spec
...
Addresses flakyness on footer links spec
2023-02-13 10:12:47 +11:00
Maikel
dee797c427
Merge pull request #10414 from openfoodfoundation/dependabot/bundler/redis-4.8.1
...
Bump redis from 4.8.0 to 4.8.1
2023-02-13 10:10:41 +11:00
Filipe
68b60a11b0
Merge pull request #10418 from openfoodfoundation/readme-patch-1
...
Update README.md
2023-02-10 14:53:20 +00:00
Sigmund Petersen
3b8f2ee4b3
Update README.md
2023-02-10 13:06:18 +01:00
Sigmund Petersen
8c91e3d8fd
Update README.md
2023-02-10 13:04:13 +01:00
Sigmund Petersen
045db5dd49
Merge pull request #10415 from openfoodfoundation/link_to_welcome_devs_board
...
Update README.md
2023-02-10 12:59:19 +01:00
Filipe
24e8c0f973
Update README.md
...
Updates footer link for the Welcome new developers board
2023-02-10 11:40:16 +00:00
filipefurtad0
761a6731db
Sets conctext: asserts within the modal
2023-02-10 11:31:18 +00:00
filipefurtad0
b1ca2c90ce
Replaces I18n.t() by visible string
...
Removes superfluous js: true
2023-02-10 11:11:10 +00:00
Filipe
cd3897db30
Update README.md
...
Updates the link to the Welcome new developers board
2023-02-10 10:54:25 +00:00
dependabot[bot]
f3ffeaf3b4
Bump redis from 4.8.0 to 4.8.1
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.8.0...v4.8.1 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-10 10:03:15 +00:00
Maikel
76c6b438b5
Merge pull request #10369 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-4.5.0
...
Bump jasmine-core from 2.4.1 to 4.5.0
2023-02-10 16:05:04 +11:00
Maikel Linke
a08c7f7823
Sort customers by id on API v1
2023-02-10 15:52:35 +11:00
dependabot[bot]
c9da3200eb
Bump rspec-rails from 5.1.2 to 6.0.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.1.2 to 6.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.1.2...v6.0.1 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-10 10:55:51 +11:00
Jean-Baptiste Bellet
b1d22f7982
Customer can be nil if first time they checkout
2023-02-09 17:11:11 +01:00
Jean-Baptiste Bellet
d65b1bb386
Fix various import issue: mock bugsnag
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
2633ee3606
Fix various import issue: taxons
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
4027eacc06
Fix various import issue: module('admin.enterprises')
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
236e77efd4
Fix various import: CurrentUser
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
a486a08bfc
Fix various import issues: currentHub
2023-02-09 16:50:40 +01:00
dependabot[bot]
292338d467
Bump jasmine-core from 2.4.1 to 4.5.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 2.4.1 to 4.5.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v2.4.1...v4.5.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
1fb4e27064
Upgrade to latest 17.* node version
2023-02-09 14:00:19 +01:00
Jean-Baptiste Bellet
9f2a17c3e9
Upgrade to node 17 which requires a --openssl-legacy-provider option
...
Node 17 moved to OpenSSL3, see https://nodejs.org/en/blog/release/v17.0.0/#openssl-3-0 for more.
2023-02-09 12:54:11 +01:00
Jean-Baptiste Bellet
ac639fa283
Upgrade node to the next LTS version
...
(which is in maintenance mode, but let's be incremental to test)
2023-02-09 10:56:28 +01:00
jibees
a3278ab6d3
Merge pull request #10404 from openfoodfoundation/dependabot/bundler/rubocop-1.45.1
...
Bump rubocop from 1.44.1 to 1.45.1
2023-02-09 10:15:34 +01:00
dependabot[bot]
416a2efea9
Bump rubocop from 1.44.1 to 1.45.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.44.1 to 1.45.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.44.1...v1.45.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-09 09:03:13 +00:00
David Cook
4cf45dcfe1
Update translations
2023-02-09 13:54:29 +11:00
David Cook
0f06c86008
Merge pull request #10367 from openfoodfoundation/dependabot/npm_and_yarn/mrujs-0.10.1
...
Bump mrujs from 0.7.4 to 0.10.1
2023-02-09 12:11:18 +11:00
Rachel Arnould
f8cceef932
Merge pull request #10312 from openfoodfoundation/dependabot/bundler/gitlab-omniauth-openid-connect-0.10.1
...
Bump gitlab-omniauth-openid-connect from 0.10.0 to 0.10.1
2023-02-08 16:05:05 +01:00
Filipe
d5b0891a74
Merge pull request #10382 from jibees/clean-database-for-report_inverse_columns_logic-feature-toggle
...
Remove `report_inverse_columns_logic` from list of feature toggle
2023-02-08 12:39:25 +00:00
Filipe
81b4433b02
Merge pull request #10393 from mkllnk/ransack
...
Bump ransack from 2.4.2 to 2.6.0
2023-02-08 12:12:13 +00:00
jibees
b73d78c785
Merge pull request #10399 from openfoodfoundation/dependabot/bundler/bugsnag-6.25.2
...
Bump bugsnag from 6.25.1 to 6.25.2
2023-02-08 10:26:31 +01:00
jibees
b7b80509dc
Merge pull request #10396 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.4
...
Bump prettier from 2.8.3 to 2.8.4
2023-02-08 10:24:48 +01:00
dependabot[bot]
57d36d2ff1
Bump bugsnag from 6.25.1 to 6.25.2
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.25.1 to 6.25.2.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.25.1...v6.25.2 )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-08 09:05:24 +00:00
dependabot[bot]
c38f1b88d3
Bump prettier from 2.8.3 to 2.8.4
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.3 to 2.8.4.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.3...2.8.4 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-08 09:02:06 +00:00
jibees
8c6a32100d
Merge pull request #10388 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.3
...
Bump prettier from 2.7.1 to 2.8.3
2023-02-08 09:26:36 +01:00
jibees
559b953e16
Merge pull request #10387 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.0
...
Bump @floating-ui/dom from 1.1.1 to 1.2.0
2023-02-08 09:25:03 +01:00
Konrad
73d98bd1b4
Merge pull request #10322 from jibees/8027-performance-improvement-on-adminenterprises
...
For super admin, add pagination on `/admin/enterprises`
2023-02-08 09:04:41 +01:00
Gaetan Craig-Riou
fd278e0086
Fix bug when submitting form triggered a warning and potentially left submit button disable
...
jquery-ujs automatically disable submit button when submitting the form.
If one choose cancel on the leaving page warning, then the submit buttons
end up in a disable state, with no way to re enable them. This fix
prevent the warning from being triggered when submitting the form, so
we can't end up in the scenario described.
2023-02-08 16:28:41 +11:00
Maikel
66a29e58d2
Merge pull request #10340 from mkllnk/job-process-waiting
...
Wait only for report jobs within Puma workers
2023-02-08 14:26:43 +11:00
Gaetan Craig-Riou
313fdab346
Fix rubocop warnings
2023-02-08 12:04:05 +11:00
Gaetan Craig-Riou
722b04a211
Add missing collumns on new_products page
...
It also includes specs for ProductComponent
2023-02-08 12:04:05 +11:00
Maikel Linke
97b5a7f99c
Bump ransack from 2.4.2 to 2.6.0
...
Preparing for Rails 7.
2023-02-08 11:16:25 +11:00
Maikel
0ca7319e32
Merge pull request #10391 from jibees/10390-current-master-not-in-prod-missing-pagination-from-orders-page
...
Orders page and BOM page: use the same pagination file
2023-02-08 11:15:31 +11:00
Jean-Baptiste Bellet
80ba228910
Partial is used in two different contexts: orders and line_items
...
Distinguish them by adding a local variable model that could either be `orders` or `line_items`
2023-02-07 18:10:29 +01:00
Filipe
0f203a474c
Merge pull request #10375 from jibees/10363-bom-page-is-not-finding-or-displaying-name-email-or-order-number-for-some-orders
...
BOM: Ensure orders informations are loaded for each line items
2023-02-07 16:34:57 +00:00
cyrillefr
c37564eea7
Modify spec for orders bulk cancelling
2023-02-07 15:49:56 +01:00
cyrillefr
abf90b8437
Modify spec for orders
2023-02-07 15:40:40 +01:00
cyrillefr
1682f6788d
Delete unused code
...
Delete now unused code for Angular style bulk orders cancelling
- the Angular controller file
- the bulk_cancel method from controller
- the corresponding entry in route
2023-02-07 15:40:40 +01:00
jibees
10bacea861
Merge pull request #10389 from dacook/use-same-node-version-in-ci
...
Use .node-version in CI
2023-02-07 14:54:13 +01:00
Jean-Baptiste Bellet
237b0f03b5
Remove report_inverse_columns_logic from list of feature toggle
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-02-07 14:41:53 +01:00
Ana Nunes da Silva
f4980fa84d
Update void payments to checkout on resumed order
2023-02-07 12:29:59 +00:00
Ana Nunes da Silva
c9e6d24eb0
Add :resume event in Spree::Payment
2023-02-07 12:27:15 +00:00
Ana Nunes da Silva
f2b407c194
Add :void scope in Spree::Payment
2023-02-07 12:27:15 +00:00
Ana Nunes da Silva
b48b3ad42b
Update: Untaken cash payments to void on cancelled order
2023-02-07 12:27:07 +00:00
David Cook
af5e44e3f3
Use .node-version in CI
...
This ensures that all our automated tests are using the same version.
I'm not sure it matters what version Prettier runs on, but thought it should be the same.
This is a down-grade, but it's better to match the version in production. The next step will be to upgrade again for production.
2023-02-07 21:25:20 +11:00
dependabot[bot]
68acca2530
Bump prettier from 2.7.1 to 2.8.3
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.7.1 to 2.8.3.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.7.1...2.8.3 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-07 09:02:25 +00:00
dependabot[bot]
180aabdb90
Bump @floating-ui/dom from 1.1.1 to 1.2.0
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.0/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-07 09:02:00 +00:00
Maikel
c82af88c48
Merge pull request #10371 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.4.1
...
Bump karma from 6.3.20 to 6.4.1
2023-02-07 16:43:19 +11:00
Maikel
40eae3f84d
Merge pull request #10378 from openfoodfoundation/dependabot/bundler/valid_email2-4.0.5
...
Bump valid_email2 from 4.0.4 to 4.0.5
2023-02-07 16:41:47 +11:00
cyrillefr
597e9eae2b
Modify view to call Stimulus controller
...
- Also add call to a new Modal confirm component for
handling of bulk orders cancellings
2023-02-06 19:47:36 +01:00
cyrillefr
332c95dec5
Modify actual modal confirm component
...
- Need to take into account some additional customn message
2023-02-06 19:47:36 +01:00
cyrillefr
7a967715aa
Create Stimulus CancelOrder controller
2023-02-06 19:47:36 +01:00
cyrillefr
c302640644
Create a reflex that handles bulk orders cancelling
2023-02-06 19:47:36 +01:00
cyrillefr
ad0ffd2a64
Create a new service for orders bulk cancelling
2023-02-06 19:47:36 +01:00
Ana Nunes da Silva
8bd890f311
Add :checkout scope in Spree::Payment
2023-02-06 11:09:40 +00:00
dependabot[bot]
64e6bd8248
Bump mrujs from 0.7.4 to 0.10.1
...
Bumps [mrujs](https://github.com/ParamagicDev/mrujs ) from 0.7.4 to 0.10.1.
- [Release notes](https://github.com/ParamagicDev/mrujs/releases )
- [Changelog](https://github.com/KonnorRogers/mrujs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ParamagicDev/mrujs/compare/v0.7.4...v0.10.1 )
---
updated-dependencies:
- dependency-name: mrujs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-06 10:45:12 +00:00
jibees
e066e5ca74
Merge pull request #10370 from openfoodfoundation/dependabot/npm_and_yarn/jquery-ui-1.13.2
...
Bump jquery-ui from 1.13.0 to 1.13.2
2023-02-06 11:43:47 +01:00
jibees
9317cc41b9
Merge pull request #10379 from openfoodfoundation/dependabot/bundler/responders-3.1.0
...
Bump responders from 3.0.1 to 3.1.0
2023-02-06 11:34:19 +01:00
dependabot[bot]
1a35882fb6
Bump responders from 3.0.1 to 3.1.0
...
Bumps [responders](https://github.com/heartcombo/responders ) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/heartcombo/responders/releases )
- [Changelog](https://github.com/heartcombo/responders/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/responders/compare/v3.0.1...v3.1.0 )
---
updated-dependencies:
- dependency-name: responders
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-06 09:08:09 +00:00
dependabot[bot]
ec3d7174de
Bump valid_email2 from 4.0.4 to 4.0.5
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/micke/valid_email2/releases )
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.4...v4.0.5 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-06 09:01:57 +00:00
Maikel
207a3c9ea7
Merge pull request #10357 from openfoodfoundation/dependabot/bundler/webpacker-5.4.4
...
Bump webpacker from 5.4.3 to 5.4.4
2023-02-06 16:26:40 +11:00
Maikel
9ff8433a8d
Merge pull request #10344 from filipefurtad0/update_orders_spec_II
...
Update orders spec ii
2023-02-06 14:32:14 +11:00
jibees
6549ad7d2a
Merge pull request #10366 from dacook/node-version
...
Update Node version
2023-02-03 15:12:08 +01:00
jibees
7d1b71e640
Merge pull request #10300 from dacook/add-webpack-cli
...
Add required webpack package
2023-02-03 14:22:50 +01:00
Jean-Baptiste Bellet
bddd887dcd
Load orders only if current line_items are loaded
...
+ update spec as well
2023-02-03 12:25:47 +01:00
Jean-Baptiste Bellet
d00e75de70
We should load orders that are linked to line_items displayed
...
This should not be related to any pagination, search or whatever: actually we consolidate line_items with order additional info based on line_items.order.id.
2023-02-03 11:40:07 +01:00
Jean-Baptiste Bellet
06cbc120f5
Pagination is actually linked to line_items and not orders
...
We display line_items as rows in BOM
2023-02-03 11:37:51 +01:00
dependabot[bot]
e91c4f1318
Bump karma from 6.3.20 to 6.4.1
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.3.20 to 6.4.1.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.20...v6.4.1 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-03 08:51:33 +00:00
jibees
428b8b0314
Merge pull request #10365 from dacook/webpack-config
...
Make webpack-cli a dev-only dependency
2023-02-03 09:49:43 +01:00
dependabot[bot]
7d5ddb9cf6
Bump jquery-ui from 1.13.0 to 1.13.2
...
Bumps [jquery-ui](https://github.com/jquery/jquery-ui ) from 1.13.0 to 1.13.2.
- [Release notes](https://github.com/jquery/jquery-ui/releases )
- [Commits](https://github.com/jquery/jquery-ui/compare/1.13.0...1.13.2 )
---
updated-dependencies:
- dependency-name: jquery-ui
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-03 08:48:37 +00:00
jibees
cc5632fd14
Merge pull request #10364 from dacook/dependabot-update-js-packages
...
Allow Dependabot to update package.json
2023-02-03 09:46:05 +01:00
Jean-Baptiste Bellet
9b2ed8846c
load_enterprise_set_on_index is used only in one action
...
so let's call it inside the action.
2023-02-03 09:15:07 +01:00
Jean-Baptiste Bellet
e18454c55a
Add pagination on enterprises page for super admin
...
Enterprises are stored in `@enterprise_set` variables, and we iterate over to show the list of enterprises to super admin.
Previously, we used to use `Sets::EnterpriseSet.new(collection)` instead of creating set based on `@collection`: this leads to call the `collection` method twice, which was probably very time consuming. This commit fix also that.
+ use paginated enterprises loading on bulk update but without testing if the current user is an admin
2023-02-03 09:15:07 +01:00
David Cook
785350a089
Bump Node to v14.21.2
...
Currently our CI and servers do not respect this setting, only dev environments that have a Node version manager do.
I checked a few prod servers, and they use this version already so now I'm making it official. But we should aim to upgrade further, the current version is v19.
WARNING: node-v14.21.2-darwin-x64 is in LTS Maintenance mode and nearing its end of life.
It only receives *critical* security updates, *critical* bug fixes and documentation updates.
2023-02-03 16:17:28 +11:00
David Cook
ef4731022e
Recommend Node version manager
...
I chose to combine this in the above section to reduce the length of the document.
Note that the OS-specific pages in the wiki should be updated after this.
2023-02-03 16:06:34 +11:00
David Cook
8adb8a5eaf
Make webpack-cli a dev-only dependency
...
We shouldn't need this in production. According to the [readme](https://www.npmjs.com/package/webpack-cli ) it's only a dev dependency.
2023-02-03 15:26:00 +11:00
David Cook
a0d1183fc0
Use yarn to install dependencies
...
`reviewdoc-action-prettier` is automatically running npm, but we use Yarn, which handles unmet dependencies differently. Let's make it consistent.
This caused the linter to fail when it didn't need to (https://github.com/openfoodfoundation/openfoodnetwork/pull/10300#issuecomment-1413004039 ).
2023-02-03 15:21:58 +11:00
David Cook
3b49ba4de1
Allow Dependabot to update package.json
...
As per the industry standard, all version numbers are specified in package.json, so Dependabot is allowed to suggest increases when a new version is released. This is the default.
Discussed in https://community.openfoodnetwork.org/t/javascript-dependency-management-with-package-json/2753
2023-02-03 14:48:18 +11:00
Jean-Baptiste Bellet
ef4c99bf49
Replace gitlab-omniauth-openid-connect by omniauth_openid_connect
...
```
All changes in this gem are now upstreamed in omniauth_openid_connect
gem v0.6.0 under the OmniAuth group: https://github.com/omniauth/omniauth_openid_connect .
In your Gemfile, replace the line:
gem 'gitlab-omniauth-openid-connect', '~> 0.10', require: 'omniauth_openid_connect'
With:
gem 'omniauth_openid_connect', '~> 0.6'
The gitlab-omniauth-openid-connect gem is no longer updated.
```
Allow upgrading omniauth_openid_connect gem
The pinned version is the most recent and I would be happy for
Dependabot to suggest newer versions when available.
2023-02-03 12:17:17 +11:00
dependabot[bot]
40d767928e
Bump gitlab-omniauth-openid-connect from 0.10.0 to 0.10.1
...
Bumps [gitlab-omniauth-openid-connect](https://gitlab.com/gitlab-org/gitlab-omniauth-openid-connect ) from 0.10.0 to 0.10.1.
- [Release notes](https://gitlab.com/gitlab-org/gitlab-omniauth-openid-connect/tags )
- [Commits](https://gitlab.com/gitlab-org/gitlab-omniauth-openid-connect/compare/v0.10.0...v0.10.1 )
---
updated-dependencies:
- dependency-name: gitlab-omniauth-openid-connect
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-03 12:16:15 +11:00
jibees
5e689b12fe
Merge pull request #10345 from mkllnk/rspec-n
...
Enable RSpec's status file for --next-failure
2023-02-02 16:54:37 +01:00
jibees
518a029b59
Merge pull request #10353 from mkllnk/taggable
...
Bump acts-as-taggable-on from 8.1.0 to 9.0.1
2023-02-02 16:43:56 +01:00
jibees
2b14269dae
Merge pull request #10359 from openfoodfoundation/dependabot/bundler/jwt-2.7.0
...
Bump jwt from 2.6.0 to 2.7.0
2023-02-02 16:42:35 +01:00
Jean-Baptiste Bellet
a463a39abc
Update all locales with the latest Transifex translations
2023-02-02 16:11:57 +01:00
Filipe
99a0056d7f
Merge pull request #10257 from rioug/9720-fix-imperial-weight-display-when-using-float-value
...
Fix decimal display for imperial weight on Cart, Order Confirmation page and Confirmation emails
2023-02-02 15:03:39 +00:00
Rachel Arnould
0973e79a91
Merge pull request #10274 from jibees/8905-convert-popup-to-flash-messages-
...
On `/cart` page, if consumer adds more quantity than available, use in-app flash message instead of native alert
2023-02-02 15:50:17 +01:00
Filipe
d0897ec677
Merge pull request #10248 from jibees/10117-reports-in-order-cycle-customer-totals-incorrect-sorting-when-lastname-first-letter-isnt-capitalized
...
Reports, Orders and fulfillment: Sort by customer lastname + firstname case insensitive
2023-02-02 14:39:10 +00:00
Jean-Baptiste Bellet
915174b513
Do not stack same flash messages
...
Very ugly in UI.
2023-02-02 15:28:35 +01:00
Jean-Baptiste Bellet
f5aae5f8b9
Remplace ouf of stock alert by Flash message
2023-02-02 15:28:35 +01:00
dependabot[bot]
e94fff0d69
Bump jwt from 2.6.0 to 2.7.0
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.6.0...v2.7.0 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-02 09:04:00 +00:00
David Cook
14189aef5c
Use yarn to install dependencies
...
reviewdoc-action-prettier is automatically running npm, but that fails. We use yarn so maybe if we call it first, npm won't get called? Worth a try.
2023-02-02 11:51:13 +11:00
David Cook
6dc54fbd22
Add required webpack package
...
Webpack won't run and tells me I need to install the new package:
> The command moved into a separate package: @webpack-cli/serve
But the latest version depends on webpack 5, so should we install an older version? I couldn't get that working either.
2023-02-02 11:39:26 +11:00
Filipe
1e3f754f96
Merge pull request #10318 from dacook/10272-remove-currency-from-calculators
...
Remove unused currency from calculators
2023-02-01 13:49:51 +00:00
Filipe
095e520777
Merge pull request #10339 from mkllnk/ssl
...
Remove unnecessary SSL code
2023-02-01 13:06:26 +00:00
jibees
452b38fa36
Merge pull request #10355 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.1
...
Bump sidekiq-scheduler from 5.0.0 to 5.0.1
2023-02-01 10:58:15 +01:00
jibees
496bc9120a
Merge pull request #10354 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.2.5
...
Bump @hotwired/turbo from 7.2.4 to 7.2.5
2023-02-01 10:51:37 +01:00
dependabot[bot]
a386d33197
Bump webpacker from 5.4.3 to 5.4.4
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.4.3 to 5.4.4.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.4.3...v5.4.4 )
---
updated-dependencies:
- dependency-name: webpacker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-01 09:13:05 +00:00
dependabot[bot]
762e27b015
Bump sidekiq-scheduler from 5.0.0 to 5.0.1
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-01 09:03:29 +00:00
dependabot[bot]
29915cdbbd
Bump @hotwired/turbo from 7.2.4 to 7.2.5
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.2.4 to 7.2.5.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.2.4...v7.2.5 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-01 09:01:50 +00:00
Gaetan Craig-Riou
5cfedddba4
UnsavedChanges controller, disabling submit button is now optional
2023-02-01 13:46:30 +11:00
David Cook
d5ae5c9af4
Revert "Bump rspec-rails from 5.1.2 to 6.0.1"
...
This reverts commit 1313b55531 .
Because it also updates activemerchant. Dunno why, but it shouldn't have been merged (oops).
2023-02-01 12:16:32 +11:00
David Cook
01c6a8b9ec
Merge pull request #9850 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.1
...
Bump rspec-rails from 5.1.2 to 6.0.1
2023-02-01 11:43:57 +11:00
Maikel Linke
44677fac87
Bump acts-as-taggable-on from 8.1.0 to 9.0.1
2023-02-01 11:41:14 +11:00
Maikel
dda85666e6
Merge pull request #10347 from openfoodfoundation/dependabot/bundler/ddtrace-1.9.0
...
Bump ddtrace from 1.8.0 to 1.9.0
2023-02-01 11:23:53 +11:00
Gaetan Craig-Riou
dd876dfd8d
Order cycle form, disable the save and save and back button on page load
...
Buttons will be enabled once the form has been interacted with.
Update unsavedChanges stimulus controller to handle this. It should
still be generic enought that it can be reused.
2023-02-01 09:43:28 +11:00
Gaetan Craig-Riou
ef309c0fd0
Order cycle form, checkout options steps add user warning when leaving page and form has been changed
...
Add UnsavedChanges stimulus controller, it should be generic enough so
that it can reused somewhere else. It works with both 'beforeunload' event
and 'turbolinks:before-visit' when using turbo links.
2023-02-01 09:43:28 +11:00
Gaetan Craig-Riou
de97c59632
Order cycle exchange form, only set red border on pickup_time field if empty
...
The red border is set by setting pickup_time as $dirty, it then blocks next button and add leave page warning when it is not necessary, this is a fix for it.
2023-02-01 09:43:28 +11:00
filipefurtad0
5d4ab5c1f8
Adds the bang! when updating DB entries
2023-01-31 12:20:26 +00:00
dependabot[bot]
bf9cfd4990
Bump ddtrace from 1.8.0 to 1.9.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.8.0 to 1.9.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-31 09:03:18 +00:00
Maikel Linke
d3251dc03f
Enable RSpec's status file for --next-failure
...
With this config, we can use `rspec -n` which is shorthand for:
rspec --only-failures --fail-fast --order defined
This is much easier than running specs by line numbers.
2023-01-31 15:45:21 +11:00
Maikel Linke
d3b80b7fc9
Clarify expecting a hash, not keyword arguments
...
The syntax was ambiguous and nwer version of rspec-rails catch that.
2023-01-31 15:40:33 +11:00
David Cook
d9aa125903
Merge pull request #10305 from heroinedor/feature/docker-dev
...
Docker dev environment improvement
2023-01-31 10:52:37 +11:00
filipefurtad0
444d689f14
Adds ordering by order total
2023-01-30 20:12:38 +00:00
filipefurtad0
801ebe5819
Adds ordering by billing address name
2023-01-30 20:12:38 +00:00
filipefurtad0
7f4e5d3f2e
Adds ordering by customer name
2023-01-30 20:12:38 +00:00
filipefurtad0
107bb3df66
Adds ordering by shipment state
2023-01-30 20:12:38 +00:00
filipefurtad0
dcbf2ae96b
Removes assertions on the Loading element
2023-01-30 20:12:38 +00:00
filipefurtad0
f2c0a77641
Adds ordering by payment state
2023-01-30 18:39:51 +00:00
filipefurtad0
958a1bde9f
Adds ordering by order state
2023-01-30 17:35:23 +00:00
filipefurtad0
cff06011f1
Fixes rubocop issues; Adds ordering by order number
2023-01-30 17:21:29 +00:00
filipefurtad0
0e878d8ce1
Sets context for filters; Adds context for ordering
2023-01-30 17:08:03 +00:00
Filipe
678c60c9b6
Merge pull request #10175 from abdellani/tax_totals_with_rates_by_producer_report
...
Tax Totals with Rates by Producer Report
2023-01-30 13:56:48 +00:00
jibees
83335cfab4
Merge pull request #10342 from openfoodfoundation/dependabot/bundler/redcarpet-3.6.0
...
Bump redcarpet from 3.5.1 to 3.6.0
2023-01-30 10:20:33 +01:00
jibees
a762aa6ff9
Merge pull request #10341 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.1.1
...
Bump @floating-ui/dom from 1.1.0 to 1.1.1
2023-01-30 10:14:38 +01:00
dependabot[bot]
6b1d6e33c0
Bump redcarpet from 3.5.1 to 3.6.0
...
Bumps [redcarpet](https://github.com/vmg/redcarpet ) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/vmg/redcarpet/releases )
- [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vmg/redcarpet/compare/v3.5.1...v3.6.0 )
---
updated-dependencies:
- dependency-name: redcarpet
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-30 09:06:42 +00:00
dependabot[bot]
24d29c6949
Bump @floating-ui/dom from 1.1.0 to 1.1.1
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.1.1/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-30 09:01:33 +00:00
Maikel Linke
1609cc49e3
Wait only for report jobs within Puma workers
...
Otherwise a root Puma worker will try to wait for its other child
processes as well while they live a long time.
2023-01-30 16:28:59 +11:00
Maikel Linke
8c458c2d48
Remove outdated SSL setting from database
2023-01-30 14:32:31 +11:00
Maikel Linke
0fc108a8e6
Remove useless option to allow SSL
...
It's an outdated Spree setting. We always enforce SSL in production and
staging while development and test environments are running without SSL.
This setting didn't have any effect.
2023-01-30 14:19:37 +11:00
Maikel Linke
f888a0eb21
Remove unnecessary rack-ssl gem
...
Rails comes with ActionDispatch::SSL which is enabled in staging and
production. We don't need this ancient gem last updated in 2014.
2023-01-30 14:08:55 +11:00
filipefurtad0
994232f6d1
Adds pagination test on orders page
2023-01-28 17:50:28 +00:00
jibees
a97fb0f46b
Merge pull request #10336 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.119.0
...
Bump aws-sdk-s3 from 1.118.0 to 1.119.0
2023-01-27 10:29:38 +01:00
dependabot[bot]
73c81e626c
Bump aws-sdk-s3 from 1.118.0 to 1.119.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.118.0 to 1.119.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-27 09:08:25 +00:00
Maikel Linke
b35f9551eb
Update translations
2023-01-27 17:12:37 +11:00
Maikel
4193cdb9f1
Merge pull request #10320 from dacook/remove-ie-warning
...
Remove unnecessary IE warning
2023-01-27 17:02:53 +11:00
David Cook
57678b7566
Remove IE warning
...
It brings me great pleasure to remove this. I've been waiting my whole career: IE is finally gone!!
2023-01-27 12:45:46 +11:00
Maikel
ee5f255fc9
Merge pull request #10326 from openfoodfoundation/dependabot/bundler/bootsnap-1.16.0
...
Bump bootsnap from 1.15.0 to 1.16.0
2023-01-27 12:10:52 +11:00
Maikel
408c2f7a04
Merge pull request #10325 from openfoodfoundation/dependabot/bundler/rubocop-1.44.1
...
Bump rubocop from 1.44.0 to 1.44.1
2023-01-27 11:59:21 +11:00
Jean-Baptiste Bellet
634a54e3f1
Add image in description as they are now authorized
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
8f519eaf21
Factorize expects and include testing html inside modal and in description
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
dd0957fa72
Remove test no related to consumer spec
...
Furthermore, this test is more about testing the text editor (itself) which is an external library
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
6d68460950
Factorize sanitizer options between edition and displaying
...
by using the same `app/services/content_scrubber.rb`
2023-01-26 18:21:27 +01:00
Jean-Baptiste Bellet
79320331c0
As we trust description_html (previously sanitized), direct use HTML
...
via the AngularsJS `bind-html` attribute.
This will display formatting and images.
2023-01-26 17:44:51 +01:00
Jean-Baptiste Bellet
85d9650903
Allow img (and its attributes) to be displayed in the shopfront
2023-01-26 17:42:32 +01:00
Jean-Baptiste Bellet
970b7b6738
Allow attributes src (and alt) to display image for product description
...
on admin ie. `/admin/products/bread/edit`
2023-01-26 17:42:09 +01:00
Filipe
1cfc13e66f
Merge pull request #10208 from jibees/9424-calculator-provide-a-calculator-none
...
Admin: Include a "None" option for calculator type user in shipping method and payment method forms
2023-01-26 14:48:41 +00:00
dependabot[bot]
110c594353
Bump rubocop from 1.44.0 to 1.44.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.44.0 to 1.44.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.44.0...v1.44.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-26 14:31:42 +00:00
dependabot[bot]
1748274e72
Bump bootsnap from 1.15.0 to 1.16.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.15.0...v1.16.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-26 14:31:00 +00:00
Filipe
e6863f83fc
Merge pull request #10328 from jibees/10327-flaky-specsystemconsumersplit_checkout_specrb486
...
SplitCheckout, Specs: fix errors count when submitting form with errors
2023-01-26 14:27:03 +00:00
jibees
e48ba1b5fa
Specify assertions by grouping them into page section
...
Co-Authored-By: Filipe <49817236+filipefurtad0@users.noreply.github.com >
2023-01-26 15:06:00 +01:00
Jean-Baptiste Bellet
999440da0a
Fix errors count when user submit the form
...
Since https://github.com/openfoodfoundation/openfoodnetwork/pull/10317 we are displaying the error message also in the flash message. For unknown reason, build didn't fail for that PR, but, as the PR adds some error message, we need to change the spec to reflect that change.
This PR separates error in checkout page itself, and errors in flash message banner.
2023-01-26 11:05:55 +01:00
Filipe
1ea7304549
Merge pull request #10276 from jibees/10250-split-checkout-responsiveness-is-broken-on-iphone
...
Split Checkout, increase input to 16px for small devices and iOS devices
2023-01-25 17:32:10 +00:00
Filipe
ad4670705e
Merge pull request #10245 from jibees/10222-in-bom-dont-show-group-buy-info-if-equal-to-0
...
Admin, BOM: Don't display "group by size" if group by product value is actually null
2023-01-25 15:29:05 +00:00
Filipe
5e4afb765b
Merge pull request #10307 from rioug/10271-add-mandatory-asterisk-in-business-detail
...
Add required asterisk in business details panel
2023-01-25 13:23:39 +00:00
Filipe
d2d9e318fc
Merge pull request #10310 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.0
...
Bump sidekiq-scheduler from 4.0.3 to 5.0.0
2023-01-25 12:42:16 +00:00
Filipe
a2a1d8b7e2
Merge pull request #10264 from dacook/readonly-mail-settings
...
Update mail settings notice
2023-01-25 12:25:05 +00:00
Filipe
65d8337d3d
Merge pull request #10319 from mkllnk/show-flash-until-closed-by-user
...
Show new flash messages until discarded by user
2023-01-25 12:19:45 +00:00
Filipe
7f3cf743f7
Merge pull request #10317 from mkllnk/9056-stuck-in-split-checkout
...
Display checkout error messages to user for convencience
2023-01-25 12:15:36 +00:00
Rachel Arnould
27e8d89325
Merge pull request #10313 from jibees/split-checkout-do-not-display-payment-method-instruction-if-empty
...
SplitCheckout: On step3, do not display payment method description if not present
2023-01-25 11:43:19 +01:00
Maikel Linke
882d7a1215
Simplify method according to style rules
2023-01-25 15:49:44 +11:00
Maikel Linke
cec9d2987e
Name order attributes similar to other text
...
Rails' auto-generated names used in error messages were a bit cryptic
for users.
2023-01-25 15:49:44 +11:00
Maikel Linke
2bba38134e
Show new flash messages until discarded by user
...
We currently have two mechanisms to display flash messages. The old one
through AngularJS and the new one with StimulusReflex.
The AngularJS directive showed flashes for 10 seconds. The
StimulusReflex controller showed them only for 3 seconds. But any time
based disappearance of error messages is problematic. There's important
information in there and some error messages can be long. It's also
possible that a request takes a while, the user leaves the computer and
comes back later. If we hide the flash automatically then the user may
have no idea what went wrong. They may even think that everything is
fine and their order went through.
I removed the time-based removal of flash messages from the new
StimulusReflex controller to address this problem. But I didn't touch
the AngularJS directive because it will be removed anyway. There may
also be many more messages that could be annoying if they didn't
disappear, for example a simple "login successful".
I personally think that flash messages that are not important to keep,
don't need to be shown in the first place. The best UX makes the success
obvious on the page. And success should be assumed.
2023-01-25 15:33:17 +11:00
David Cook
428b589357
Remove unused currency from calculators
2023-01-25 15:31:40 +11:00
Maikel Linke
ab7e1ac39f
Display error messages to user for convencience
...
It will also help us to debug the application if the error is not
obvious.
2023-01-25 14:50:28 +11:00
Maikel Linke
0782447863
Drop superflous js flag from system spec
2023-01-25 14:50:28 +11:00
Maikel
1a71e55029
Merge pull request #10316 from openfoodfoundation/dependabot/npm_and_yarn/ua-parser-js-0.7.33
...
Bump ua-parser-js from 0.7.30 to 0.7.33
2023-01-25 14:42:03 +11:00
Jean-Baptiste Bellet
f082dfdb79
Move scheduler options to scheduler key in the sidekiq.yml
...
As requested by https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/v5.0.0.beta1/CHANGELOG.md#500beta1 and https://github.com/sidekiq-scheduler/sidekiq-scheduler/pull/412
```
[BREAKING CHANGE] Moves all sidekiq-scheduler config options under the scheduler key in the sidekiq.yml file #412
If you're migrating from v4 to v5, any sidekiq-scheduler config you may have in your sidekiq.yml should be moved under the scheduler key.
See #412 to see which are the config options that you need to move under the scheduler key.
```
2023-01-25 10:43:44 +11:00
dependabot[bot]
10060be300
Bump ua-parser-js from 0.7.30 to 0.7.33
...
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js ) from 0.7.30 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases )
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md )
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.30...0.7.33 )
---
updated-dependencies:
- dependency-name: ua-parser-js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-24 23:05:42 +00:00
David Cook
6424b37e70
Merge pull request #10314 from jibees/upgrade-Brakeman-version
...
Upgrade brakeman to its latest version
2023-01-25 10:03:30 +11:00
Jean-Baptiste Bellet
ada164d29b
Upgrade brakeman to its latest version
2023-01-24 16:23:15 +01:00
Gaetan Craig-Riou
8194ae1eae
Add required asterisk in business details panel
2023-01-24 15:24:14 +01:00
Jean-Baptiste Bellet
64b7ccc2ba
Do not display payment method description if not present
...
This avoid an empty section with `Instructions` title empty
2023-01-24 15:06:46 +01:00
Jean-Baptiste Bellet
3e8ec039f7
Increase input to 16px for small devices and iOS devices
...
This avoid that "zoom on input focus" on iOS devices
2023-01-24 12:05:09 +01:00
Filipe
f917027cb1
Merge pull request #10249 from jibees/10228-split-checkout-error-422-on-step-2-payment-update-highlighted-fields
...
SplitCheckout: Fix an issue that was sending unintentionally bad params for payment
2023-01-24 10:31:49 +00:00
jibees
5d7ab0973a
Merge pull request #10311 from openfoodfoundation/dependabot/bundler/rubocop-1.44.0
...
Bump rubocop from 1.43.0 to 1.44.0
2023-01-24 10:45:18 +01:00
dependabot[bot]
ee07b81cd6
Bump rubocop from 1.43.0 to 1.44.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.43.0...v1.44.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-24 09:06:15 +00:00
dependabot[bot]
04e7b3b617
Bump sidekiq-scheduler from 4.0.3 to 5.0.0
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v4.0.3...v5.0.0 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-24 09:01:21 +00:00
Pipo Bimbo
118d3a9d8e
separate log file for both steps of the tests
2023-01-24 08:50:33 +01:00
Maikel
2fc935e99c
Merge pull request #10167 from openfoodfoundation/dependabot/bundler/ddtrace-1.8.0
...
Bump ddtrace from 0.54.1 to 1.8.0
2023-01-24 14:53:12 +11:00
Maikel
00d9c2836d
Merge pull request #10309 from mkllnk/flaky-serializer-spec
...
Parse JSON to test ids separately and avoid flakiness
2023-01-24 14:32:20 +11:00
Maikel Linke
79887c0b44
Clarify array intend of array operation in spec
2023-01-24 14:17:46 +11:00
Maikel Linke
5b6a855dfe
Clarify test result structure
2023-01-24 13:39:48 +11:00
Maikel Linke
d18d0ef6b1
Parse JSON to test variant and distributor ids
...
We looked at the whole JSON string before and sometimes a distributor id
would match a variant id which made the test flaky.
2023-01-24 11:51:44 +11:00
Maikel Linke
d37fa9fc5f
Simplify spec structure without defining modules
...
Specs should test classes and modules independently and they should not
be in the same module. It also avoids indentation and accidental
namespace polution.
2023-01-24 11:41:06 +11:00
Filipe
7b14afbabe
Merge pull request #10294 from abdellani/fix_invoice_print_spec
...
fix the pending invoice print spec
2023-01-23 19:06:36 +00:00
Filipe
bc788b6d60
Merge pull request #10243 from jibees/10242-change-how-orders-are-loaded-in-bom-+-filters
...
Admin, BOM: add pagination, remove date range filtering on first load
2023-01-23 17:48:05 +00:00
Jean-Baptiste Bellet
3247c32191
Be consistant and use data-paymentmethod-id attribute
...
as already used on other element
2023-01-23 17:48:54 +01:00
Jean-Baptiste Bellet
251ab2ac9a
Payment method id attribute don't need to start with paymentmethod
2023-01-23 17:46:26 +01:00
jibees
dafe4b599f
Merge pull request #10303 from mkllnk/webpacker-ignores-tmp-files
...
Ignore vi .swp files when webpack dev reloads page
2023-01-23 17:12:29 +01:00
Filipe
d7c99a9d8b
Merge pull request #10275 from filipefurtad0/update_orders_spec
...
Updates system spec for orders page
2023-01-23 16:00:38 +00:00
Rachel Arnould
53fb906861
Merge pull request #10254 from jibees/10246-split-checkout-order-summary-page-design-changes
...
Split checkout: order summary page design changes
2023-01-23 15:52:06 +01:00
Pipo Bimbo
54acfbf7f2
documentation for docker on windows
2023-01-23 15:08:18 +01:00
Pipo Bimbo
5708fb04a5
switch from command scripts to powershell scripts
2023-01-23 14:15:16 +01:00
Pipo Bimbo
fa4ff7534b
for windows and docker usage compatibilities, force certain files to use LF line endings, even on Windows
2023-01-23 14:10:41 +01:00
Pipo Bimbo
4bae28bbad
removed node_modules folder mounting on docker because it is not possible to have node_modules files on Windows host used by yarn/npm process on docker container
2023-01-23 14:10:41 +01:00
Pipo Bimbo
e1b79db65e
Set line endings to LF, even on Windows, for Shell scripts. Otherwise, execution within Docker fails.
2023-01-23 14:10:41 +01:00
Pipo Bimbo
d413a39c3c
grep option -x does not work on windows installation due to EOL characters
2023-01-23 14:10:41 +01:00
Pipo Bimbo
d153adca9b
docker server.bat files for use of docker on windows environment + documentation
2023-01-23 14:10:41 +01:00
Pipo Bimbo
38fe572943
Avoid spaces and line return around ruby version, especially for windows
2023-01-23 14:10:41 +01:00
Pipo Bimbo
ee1ad57c7f
add docker build and seed scripts for windows
2023-01-23 14:10:41 +01:00
filipefurtad0
fa96f7339d
Replaces URL with routing syntax
2023-01-23 11:35:53 +00:00
Sigmund Petersen
78bbb08666
Merge pull request #10301 from openfoodfoundation/update-getting-started
...
Docs: Suggest using SSH instead of HTTPS for cloning
2023-01-23 08:36:17 +01:00
Sigmund Petersen
e260112eb8
Merge pull request #10296 from filipefurtad0/add_no_sandbox_to_cuprite_settings
...
Sets no-sandbox option, for CI env.; increases timeout values
2023-01-23 08:34:09 +01:00
Maikel Linke
a91ece8f3b
Replace outdated datadog config syntax
2023-01-23 16:40:36 +11:00
Jean-Baptiste Bellet
6327370401
Update datadog settings from 0.x to 1.x
...
Reference: https://github.com/DataDog/dd-trace-rb/blob/master/docs/UpgradeGuide.md#settings-have-been-renamed
2023-01-23 16:25:03 +11:00
Maikel Linke
b91b85febc
Ignore vi .swp files when webpack dev reloads page
...
The webpack dev server watches assets and reloads the page when files
change on disk. I'm adding vi's temporary files to the ignore list.
2023-01-23 14:42:08 +11:00
Mohamed ABDELLANI
19df15d75b
move item group instruction from db to rails
2023-01-21 18:40:27 +01:00
Mohamed ABDELLANI
92c4bd9eb7
introduces format_percentage in ReportRowBuilder#format_cell
2023-01-21 18:40:27 +01:00
Mohamed ABDELLANI
4822be532b
test Sales Tax Totals By Producer
2023-01-21 18:40:27 +01:00
Mohamed ABDELLANI
c87c8ed0df
subreport filtering partial
2023-01-21 18:39:33 +01:00
Mohamed ABDELLANI
f4a5130cb5
remove pending from tests
2023-01-21 08:35:12 +01:00
Mohamed ABDELLANI
8823b2ac89
add display_line_items_taxes to expected message in invoice view spec
2023-01-21 08:35:01 +01:00
Mohamed ABDELLANI
9bff2718c7
implement display_line_items_taxes to render included & added tax
2023-01-21 08:16:05 +01:00
filipefurtad0
7dc14cc35a
Adds coverage for bulk pdf generation
...
and order cancelling
2023-01-20 18:31:33 +00:00
Mohamed ABDELLANI
a4f388336a
remove duplicated test
2023-01-20 18:00:04 +01:00
Jean-Baptiste Bellet
370e476fc5
has:() relational pseudo class is not available for firefox
...
cf. https://caniuse.com/css-has
So be more generic, as the only `checkout-input` is for that checkbox for T&Cs
2023-01-20 15:37:52 +01:00
filipefurtad0
8bfb17144c
Filters by order state
2023-01-20 13:56:40 +00:00
filipefurtad0
f984cd89c2
Filters by invoice number
2023-01-20 13:14:23 +00:00
filipefurtad0
336210b898
Tests shipping methods filtering
2023-01-20 13:10:18 +00:00
filipefurtad0
9323394eb7
Adds CI condition browser_options; sets timeouts to 60
2023-01-20 11:13:31 +00:00
jibees
895fc94a75
Merge pull request #10295 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.118.0
...
Bump aws-sdk-s3 from 1.117.2 to 1.118.0
2023-01-20 11:43:14 +01:00
jibees
aa725ec8a4
Merge pull request #10299 from openfoodfoundation/dependabot/bundler/globalid-1.0.1
...
Bump globalid from 1.0.0 to 1.0.1
2023-01-20 11:37:20 +01:00
dependabot[bot]
1313b55531
Bump rspec-rails from 5.1.2 to 6.0.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.1.2 to 6.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.1.2...v6.0.1 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-20 10:33:08 +00:00
Sigmund Petersen
f921bbfe45
Merge pull request #10288 from openfoodfoundation/dependabot/bundler/rack-2.2.6.2
...
Bump rack from 2.2.4 to 2.2.6.2
2023-01-20 11:31:49 +01:00
Jean-Baptiste Bellet
f8b8e79725
Specify a bit when T&Cs label is longer that summary width
...
and therefore on two lines
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
b559171d0e
Put order summary footer into its own file _totals_footer.html.haml
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
3e7e0e4d81
Instead of adding inline style, create a CSS rule
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
c5d94d372f
Remove unnecessary within block
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
c99ec38c85
By default, we reject all adjustements with amount equal to 0
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
37f359542e
Remove bold on firstname+lastname
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
21b74386f9
Introduce mobile view for summary step
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
53c701e04c
In fact, it seems likely to be strictly less.
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
ef572668d5
Let's keep fees next to the payment or shipping method
2023-01-20 11:20:35 +01:00
Jean-Baptiste Bellet
fa8e36fbeb
As this is used in a odd/even table, background needs to be transparent
...
Otherwise, it's set via `checkout h5`
2023-01-20 11:20:34 +01:00
Jean-Baptiste Bellet
1ea9c15bb8
Put total on the summary box on the right
2023-01-20 11:20:34 +01:00
Jean-Baptiste Bellet
cc838d2c88
Remove sentence
2023-01-20 11:20:34 +01:00
Jean-Baptiste Bellet
99fcbad0f0
On split checkout, do not display footer on order summary
...
introduced via `display_footer` which is by default `true`
2023-01-20 11:20:34 +01:00
Jean-Baptiste Bellet
52959a913f
New step3: two columns, more condensed
2023-01-20 11:20:34 +01:00
David Cook
097bfd953f
Suggest using SSH instead of HTTPS for cloning
...
This basically reverts 3a0c5bf0c3
2023-01-20 14:46:47 +11:00
dependabot[bot]
b9039f4b1f
Bump globalid from 1.0.0 to 1.0.1
...
Bumps [globalid](https://github.com/rails/globalid ) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/rails/globalid/releases )
- [Commits](https://github.com/rails/globalid/compare/v1.0.0...v1.0.1 )
---
updated-dependencies:
- dependency-name: globalid
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-19 22:24:49 +00:00
filipefurtad0
f7d4d7595c
Filters by customer/billing address first and last names
2023-01-19 16:22:53 +00:00
filipefurtad0
28782775ad
adds filter by Email assertion
2023-01-19 16:22:53 +00:00
filipefurtad0
6f35b38fa8
Asserts on the correct display of orders
...
(for a given distributor)
2023-01-19 16:22:53 +00:00
filipefurtad0
9757ab2a6c
Creates customers and enterprise owners (users)
...
Fixes typo and removes unecessary js: true line
2023-01-19 16:22:53 +00:00
dependabot[bot]
381c4e6146
Bump aws-sdk-s3 from 1.117.2 to 1.118.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.117.2 to 1.118.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-19 09:08:10 +00:00
David Cook
4e7c50e22b
Merge pull request #10283 from mkllnk/application-job
...
Add Rails standard ApplicationJob for consistency
2023-01-19 14:23:22 +11:00
David Cook
9b4538790e
Update translations
2023-01-19 13:29:59 +11:00
Maikel Linke
075b8d2585
Add Rails standard ApplicationJob for consistency
...
New Rails apps come with this class already, the job generator creates
it for every new job and Rubocop requires it as well. Let's make our
lives easier and use the same structure as other Rails projects. This
class may be handy one day.
2023-01-19 13:25:46 +11:00
dependabot[bot]
828c6e5427
Bump rack from 2.2.4 to 2.2.6.2
...
Bumps [rack](https://github.com/rack/rack ) from 2.2.4 to 2.2.6.2.
- [Release notes](https://github.com/rack/rack/releases )
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rack/rack/compare/2.2.4...v2.2.6.2 )
---
updated-dependencies:
- dependency-name: rack
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-19 00:47:53 +00:00
Filipe
b54f4ef686
Merge pull request #10258 from mkllnk/report-job
...
Render reports in a separate process (feature-toggled)
2023-01-18 23:47:09 +00:00
Maikel
4a8e3a751d
Explain what Process.waitall does
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-01-18 23:12:26 +00:00
Maikel Linke
6472070517
Configure MiniRacer to allow forking
...
The spec for forking was hanging. This could be revisited after
upgrading to mini_racer 0.6.1.
2023-01-18 23:12:26 +00:00
Maikel Linke
26402397ea
Stop report workers when parent times out
...
No need to keep running when nobody is collecting the result (yet).
2023-01-18 23:12:26 +00:00
Maikel Linke
b19456535d
Isolate report rendering in separate child process
...
Sidekiq doesn't have any features to limit memory usage or execution
time. We need a separate process for this. Forking avoids the boot time
of a fresh process and copy-on-write ensures minimal memory overheads.
2023-01-18 23:12:26 +00:00
Maikel Linke
a177f4c066
Add feature to render reports in the background
...
This is supposed to lower the memory footprint of all Puma workers. The
reports code will occupy needed memory in one Sidekiq worker instead of
in several Puma processes.
The current code doesn't limit the execution time yet. We either need a
way to terminate the report rendering after a while or send an email
with a link to access a rendered report.
2023-01-18 23:12:26 +00:00
Maikel Linke
19c4596b9e
Untie report from request object
...
We want simple report arguments to store it as background job.
2023-01-18 23:12:26 +00:00
Maikel Linke
0c769706aa
Split method for easier reading
2023-01-18 23:12:26 +00:00
Maikel Linke
65843fbd68
Render on-screen report as HTML in renderer
...
So it can be treated like any other format.
2023-01-18 23:12:26 +00:00
Jean-Baptiste Bellet
7320a1714c
Instead of selecting the controller, send an event handled by stripe-cards
...
Using a query selector to find controller in order to call method could be dangerous as the DOM can change. Using an event should be more robust.
2023-01-18 17:40:17 +01:00
Jean-Baptiste Bellet
9b4f9314bc
Make a proper alignement for filtering options
...
I used inline style, because:
- I didn't find any pre-existing CSS for this page
- I think that flex is self-explaining and I think adding class (for what?) won't add any value
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
455c11c289
Put columns selector component on left, and per_page component on right
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
31dc35c500
Remove that awful double arrow on each select2 component
...
Already defined via `app/webpacker/css/admin/plugins/select2.scss`
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
35791034cc
Remove orders/_per_page_controls and use the shared one
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
1a874d6fcf
Introduce pagination for BOM page
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
85a748af99
When selecting an OC, do not pre-fill date range with OC date range
...
+ update specs as well
2023-01-18 17:39:42 +01:00
Jean-Baptiste Bellet
121a4a08af
On filters reseting , set dates to undefined: range is not mandatory
...
+ send flatpickr event to reset the component
+ update specs as well
2023-01-18 17:39:09 +01:00
Jean-Baptiste Bellet
b75b123cba
Don't check date range before refreshing data: they aren't mandatory
...
- Creates a simple formatDates method that handle date formatting before sending it as params instead of creating scoped variable (useless)
- Put key to `undefined` (ie. don't then the params) if no date: already handled by the backend
2023-01-18 17:39:09 +01:00
jibees
d2e6b7d164
Merge pull request #10286 from filipefurtad0/comment_flaky_bom_flatpickr_date_selection
...
Comments out flaky example on BOM spec
2023-01-18 17:37:17 +01:00
filipefurtad0
fd1391cda9
Comments out flaky example on BOM spec
2023-01-18 16:24:31 +00:00
Maikel
54c58c6ba6
Merge pull request #10278 from mkllnk/pg_stat_statements
...
Enable pg_stat_statements in development like prod
2023-01-18 08:51:25 +11:00
jibees
e04a23cb3c
Merge pull request #10277 from mkllnk/spec-cleanup
...
Remove outdated spec
2023-01-17 10:42:15 +01:00
Mohamed ABDELLANI
61037aa5ad
sales tax totals by producers report
2023-01-17 08:37:47 +01:00
Maikel Linke
4364b1283b
Enable pg_stat_statements in development like prod
...
We activated this database extension in production via ofn-install. But
this had not been reflected in Rails' schema.rb.
This change avoids inconsistent db/schema.rb files on production servers
and makes development more similar to production.
2023-01-17 15:41:35 +11:00
Maikel Linke
da5fa8f608
Remove outdated spec
...
It's just testing that we are not using code which has been deleted in
the past. I don't think that there's a risk that we introduce this again
by accident. Right now, this spec just wastes resources.
2023-01-17 15:18:52 +11:00
dependabot[bot]
fd4fb53df1
Bump ddtrace from 0.54.1 to 1.8.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.54.1 to 1.8.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.54.1...v1.8.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-17 01:39:59 +00:00
Maikel
3f8ca55975
Merge pull request #10273 from mkllnk/mini_racer
...
Bump mini_racer from 0.4.0 to 0.6.3
2023-01-17 12:38:41 +11:00
dependabot[bot]
287f0572c2
Merge pull request #10259 from openfoodfoundation/dependabot/bundler/rubocop-1.43.0
2023-01-16 14:59:16 +00:00
Jean-Baptiste Bellet
5a61722f8b
+ force FlatRate as calculator for payment methods in spec
2023-01-16 09:31:15 +01:00
Jean-Baptiste Bellet
719025f98e
Only set calculator if it's a new record (having an id)
...
Unless we have a ActiveRecord::NotNullViolation
```
ActiveRecord::NotNullViolation:
PG::NotNullViolation: ERROR: null value in column "calculable_id" of relation "spree_calculators" violates not-null constraint
DETAIL: Failing row contains (9370, Calculator::None, null, Spree::ShippingMethod, 2023-01-12 15:09:44.381142, 2023-01-12 15:09:44.381142).
# ------------------
# --- Caused by: ---
# PG::NotNullViolation:
# ERROR: null value in column "calculable_id" of relation "spree_calculators" violates not-null constraint
# DETAIL: Failing row contains (9370, Calculator::None, null, Spree::ShippingMethod, 2023-01-12 15:09:44.381142, 2023-01-12 15:09:44.381142).
```
2023-01-16 09:31:15 +01:00
Jean-Baptiste Bellet
a9097df112
Already defined via CalculatedAdjustments
2023-01-16 09:31:15 +01:00
Jean-Baptiste Bellet
7015cb30c3
Calculator 'None' is the default one for both shipping and payment method
...
+ update specs as well
Update shipping_method.rb
2023-01-16 09:31:15 +01:00
Maikel Linke
ec5077c75b
Bump mini_racer from 0.4.0 to 0.6.3
...
Open mini_racer dependency for updates
I'm hoping that the new version will work with forking code.
2023-01-16 15:22:04 +11:00
Maikel Linke
657fd72f69
Bump bundler from 2.1.4 to 2.4.3
...
It fixes a problem with installing newer mini_racer versions.
2023-01-16 15:21:12 +11:00
Jean-Baptiste Bellet
eb663af292
Update all locales with the latest Transifex translations
2023-01-13 09:55:18 +01:00
Filipe
5c04d00ff8
Merge pull request #10178 from jibees/9573-split-checkout-typing-checkoutcart-on-the-url-bar-brings-back-legacy-checkout
...
When `split_checkout` is enabled, redirect to split checkout controller in any cases
2023-01-12 17:05:53 +00:00
dependabot[bot]
fd446970ca
Merge pull request #10265 from openfoodfoundation/dependabot/bundler/view_component-2.82.0
2023-01-12 09:46:15 +00:00
dependabot[bot]
be004383a4
Bump view_component from 2.80.0 to 2.82.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.80.0 to 2.82.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.80.0...v2.82.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-12 09:02:24 +00:00
David Cook
702bf1b76e
Update mail settings notice
...
It is confusing how these settings work, hopefully the message makes it clear now.
We could just disable the fields entirely, but it was chosen to allow temporary updates so that instance managers can troubleshoot mail issues (063d44fecc ).
2023-01-12 17:40:54 +11:00
Maikel Linke
1e77b96c2c
Simplify negated feature toggle constraint
2023-01-11 10:10:30 +00:00
Jean-Baptiste Bellet
b2db63178f
Redirect /checkout/whatever to /checkout when split_checkout is activate
...
+ constraint the legacy checkout routes when `split_checkout` feature is disabled
+ add specs
2023-01-11 10:10:30 +00:00
dependabot[bot]
798f1dfdfa
Bump rubocop from 1.42.0 to 1.43.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.42.0...v1.43.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-11 09:02:47 +00:00
Gaetan Craig-Riou
6e76bcac4a
Refactor option_value_value_unit_scaled to use to_d instead of calling BigDecimal
...
As we are now using truncate(2) we don't need to specify the number of significant digits
2023-01-11 15:35:30 +11:00
David Cook
ee70645d04
Merge pull request #10251 from openfoodfoundation/dependabot/bundler/listen-3.8.0
...
Bump listen from 3.7.1 to 3.8.0
2023-01-11 13:46:21 +11:00
Gaetan Craig-Riou
91af282ccc
Truncate scaled value unit to maximum of two decimals
...
ie truncate 12.50001234 to 12.5
When using imperial, the scalling calculation rounding results in value unit
having extra decimal when converted back to imperial
+ related spec
2023-01-11 11:04:32 +11:00
Konrad
c4b89e466b
Merge pull request #9804 from jibees/9420-resend-confirmation-email-in-bulk
...
Admin, Orders list: Resend confirmation email in bulk
2023-01-11 00:16:57 +01:00
Filipe
57aeee94f9
Merge pull request #10229 from mkllnk/report-paths
...
Link relative report path instead of absolute URL
2023-01-10 15:35:32 +00:00
Filipe
3a9be42389
Merge pull request #10234 from mkllnk/drop-spree_product_groups
...
Remove unused Spree database tables
2023-01-10 15:16:52 +00:00
dependabot[bot]
b7930e7d38
Merge pull request #10252 from openfoodfoundation/dependabot/bundler/spring-4.1.1
2023-01-10 09:15:37 +00:00
dependabot[bot]
7c69cc5aa9
Bump listen from 3.7.1 to 3.8.0
...
Bumps [listen](https://github.com/guard/listen ) from 3.7.1 to 3.8.0.
- [Release notes](https://github.com/guard/listen/releases )
- [Commits](https://github.com/guard/listen/compare/v3.7.1...v3.8.0 )
---
updated-dependencies:
- dependency-name: listen
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-10 09:05:05 +00:00
dependabot[bot]
2baa55262b
Bump spring from 4.1.0 to 4.1.1
...
Bumps [spring](https://github.com/rails/spring ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: spring
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-10 09:04:31 +00:00
David Cook
2835265a1e
Update release template
...
The release is now posted automatically, thanks to whomever set that up\!
2023-01-10 10:49:39 +11:00
Filipe
bd20a8c16f
Merge pull request #10237 from mkllnk/report-rendering
...
Remove report dependency on report controller
2023-01-09 18:49:19 +00:00
Jean-Baptiste Bellet
8958fe4199
Orders and fulfilment: Sort by lastname + firstname case insensitive
2023-01-06 15:36:12 +01:00
Rachel Arnould
61175c036a
Merge pull request #10131 from jibees/10125-change-oc-page-colors
...
[WIP 🚧 ] `/admin/order_cycles` behind feature toggle `admin_style_v2`
2023-01-06 15:07:41 +01:00
Jean-Baptiste Bellet
2258af9cec
Don't display "group by size" if value is actually null or empty
...
+ add spec
2023-01-06 14:39:39 +01:00
dependabot[bot]
6b3a0fa14a
Merge pull request #10244 from openfoodfoundation/dependabot/bundler/bugsnag-6.25.1
2023-01-06 13:14:53 +00:00
Jean-Baptiste Bellet
e403a2c174
Secondary button can actually be disabled
2023-01-06 14:03:40 +01:00
Jean-Baptiste Bellet
5aca76e520
OC, incoming|outgoing products, have the actions inside the table
2023-01-06 14:03:40 +01:00
Jean-Baptiste Bellet
73a2b90e1b
On hovering, all the tr should be colored
...
This needs to be respecified with an `!important` keyword
Even if already defined in `app/webpacker/css/admin/openfoodnetwork.scss`
2023-01-06 14:03:40 +01:00
Jean-Baptiste Bellet
c7d4c4c195
Put action in the flex container for incoming|outgoing products in OC
2023-01-06 14:03:40 +01:00
Jean-Baptiste Bellet
bba1d6c725
Do not specify sizes, let the browser fix the best layout for table
2023-01-06 10:46:01 +01:00
Jean-Baptiste Bellet
52cb6d4eec
Put all actions in the same flex container, aligned to right
2023-01-06 10:45:30 +01:00
Jean-Baptiste Bellet
fc6bd53720
Put some specials rules for listing_orders as generics for all tables
...
- `.actions` is now integrated to the table itself, with the same design
- We have to use `!important` keyword as already defined like this...
2023-01-06 10:33:27 +01:00
dependabot[bot]
650fd69f60
Bump bugsnag from 6.25.0 to 6.25.1
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.25.0 to 6.25.1.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.25.0...v6.25.1 )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-06 09:12:10 +00:00
Maikel Linke
22a086ebc1
Remove report dependency on report controller
...
The ReportsController was referencing the report and the report was
referencing the controller. It's unlikely that this circular dependency
created a memory leak but it's generally a bad design. And we need to
make the reporting independent of the controller to isolate it in a
background job.
2023-01-05 15:06:41 +11:00
Maikel Linke
446fa2ddab
Remove confusing and unused db table
...
This table came from Spree but has never been used. We soon want to use
the term Product Group and having this table would be confusing.
2023-01-05 15:04:52 +11:00
Maikel Linke
59a565c446
Remove confusing and unused db table
...
This table came from Spree but has never been used.
2023-01-05 15:04:01 +11:00
Maikel
dc6ac99a3f
Merge pull request #10223 from filipefurtad0/sets_pending_on_complex_creating_specific_time_spec
...
Comments out flaky example with xit
2023-01-05 14:10:11 +11:00
David Cook
5c8c4c36f7
Update all locales with the latest Transifex translations
2023-01-05 13:35:44 +11:00
David Cook
be25ea0b9e
Merge pull request #10235 from mkllnk/drop-skrill
...
Remove unused Spree database table
2023-01-05 13:27:51 +11:00
Maikel Linke
9cba9395e3
Remove unused "skrill" translations
2023-01-05 11:16:12 +11:00
Maikel Linke
cdd39f526d
Remove unused Spree database table
...
I randomly stumbled across this one and couldn't find any use of it. I
think that it refers to an old payment gateway that may have been used
by Spree once upon a time.
2023-01-05 11:05:15 +11:00
Maikel
31f7cadd92
Merge pull request #10217 from openfoodfoundation/dependabot/bundler/puma-6.0.2
...
Bump puma from 5.6.5 to 6.0.2 // Blocked by ofn-install/pull/855
2023-01-05 10:16:16 +11:00
Jean-Baptiste Bellet
972e0b5d0b
Specify color for h4. Same as others titles.
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
927c1c81e5
Border and background for a panel
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
fd87013a63
Colorize and customize tagging componenent
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
274e0d0335
Same color but with variable
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
c5f3d3fa71
Use a darker grey for disabled button
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
26684f7db5
New colors for wizard progress
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
2ccb7de004
Specify cursor: default when button is disabled
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
7c321922ad
Actually, this needs to be white since the body is no more white
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
d7e3e81c8c
Adjust border color when active
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
d7454ecb9f
Adjust border radius when drop is above
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
4c172b5ace
Adjust color and height between input type text and select
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
6529a8d98f
#clear_all_filters button as a secondary one
2023-01-04 10:41:30 +01:00
Jean-Baptiste Bellet
ccfc632149
Whatever the condition, display the td
...
And put the `ng-if` inside the `td`, attached to a new `div`
2023-01-04 10:41:30 +01:00
dependabot[bot]
32ec39ad8c
Merge pull request #10231 from openfoodfoundation/dependabot/npm_and_yarn/json5-1.0.2
2023-01-04 09:39:08 +00:00
dependabot[bot]
449d500371
Bump json5 from 1.0.1 to 1.0.2
...
Bumps [json5](https://github.com/json5/json5 ) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-04 09:25:17 +00:00
dependabot[bot]
cbb7e52795
Merge pull request #10230 from openfoodfoundation/dependabot/bundler/bullet-7.0.7
2023-01-04 09:24:24 +00:00
dependabot[bot]
1eb1beda3b
Bump bullet from 7.0.5 to 7.0.7
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.0.5 to 7.0.7.
- [Release notes](https://github.com/flyerhzm/bullet/releases )
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.5...7.0.7 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-04 09:03:38 +00:00
Maikel Linke
da4069679c
Link relative report path instead of absolute URL
...
You can reach a development server under localhost, 127.0.0.1, 0.0.0.0
or other names you define in your environment. The reports were using
absolute links to localhost though and therefore breaking your session
(login) while navigating.
I'm not sure why this was done though. Sebastian didn't explain this in
the commit message and it may have been accidental.
2023-01-04 15:43:12 +11:00
Jean-Baptiste Bellet
b858371735
Be more specific on allowed request origins by adding OFN_URL
...
+ add same configuration for production
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
992b497b75
Allow request origins
...
https://guides.rubyonrails.org/action_cable_overview.html#allowed-request-origins
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
53fa2ef8d5
Change order of the Actions menu: resend, print, cancel
...
It's more close to the Actions menu for a specific order (ie. on page `/admin/orders/[ORDER_ID]/edit`)
2023-01-03 10:32:11 +01:00
Maikel
79f602b4ea
Remove unnecessary spec line
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
ab39341192
Add permission management with cancancan
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
edc0c189df
Add spec for bulk "Resend email confirmation" action
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
7e844ee289
Implement resend email confirmation bulk action
...
- Create a controller that send a reflex action with the order_ids array
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
bcc9d447e1
Create a reflex that handle re-send email confirmation to user
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
9997fe26fc
Small adjustments to make it usable in admin section
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
519c15a9d5
Create a ConfirmModalComponent
...
- Inherits from ModalComponent
- Has a close button
- Accept `confirm_actions` to trigger reflexes
- Accept `controller` to encapsulate stimulus reflexe controllers
2023-01-03 10:32:11 +01:00
Jean-Baptiste Bellet
64ca0a4eea
Extract open/close/closeIfEscapeKey methods to a mixins
...
therefore we can compose any controller from it
- simplify `help-modal-controller` then
- + create a simple `modal-controller` that close on `modal:close` event
2023-01-03 10:30:25 +01:00
Jean-Baptiste Bellet
2fde3abe37
Extract a StimulusJS modal_controller
...
+ make `help_modal_link_controller` inherit from it
2023-01-03 10:30:25 +01:00
Jean-Baptiste Bellet
c3805b8187
Create ModalComponent and make HelpModalComponent inherit from it
2023-01-03 10:30:25 +01:00
dependabot[bot]
70b1888d45
Merge pull request #10225 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.3.15
2023-01-03 09:27:11 +00:00
dependabot[bot]
f03df26e4e
Merge pull request #10224 from openfoodfoundation/dependabot/npm_and_yarn/husky-8.0.3
2023-01-03 09:22:35 +00:00
dependabot[bot]
662ca16aa3
Bump js-big-decimal from 1.3.13 to 1.3.15
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.13 to 1.3.15.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.13...v1.3.15 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-03 09:01:30 +00:00
dependabot[bot]
07f9379956
Bump husky from 8.0.2 to 8.0.3
...
Bumps [husky](https://github.com/typicode/husky ) from 8.0.2 to 8.0.3.
- [Release notes](https://github.com/typicode/husky/releases )
- [Commits](https://github.com/typicode/husky/compare/v8.0.2...v8.0.3 )
---
updated-dependencies:
- dependency-name: husky
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-03 09:01:14 +00:00
Maikel
f122f4bf50
Merge pull request #10188 from filipefurtad0/error_message_inventory_import
...
Adds coverage for error message in product and inventory import
2023-01-03 16:28:25 +11:00
Maikel
4a250f41f3
Merge pull request #10168 from filipefurtad0/updates_bom_spec
...
Updates BOM system spec - prepares for #10123
2023-01-03 15:20:37 +11:00
Maikel
388923e963
Merge pull request #10218 from openfoodfoundation/dependabot/bundler/bullet-7.0.5
...
Bump bullet from 7.0.4 to 7.0.5
2023-01-03 15:18:27 +11:00
Maikel
235f4bb767
Merge pull request #10219 from openfoodfoundation/dependabot/bundler/rubocop-1.42.0
...
Bump rubocop from 1.41.1 to 1.42.0
2023-01-03 15:17:58 +11:00
filipefurtad0
3a3fc066dc
Comments out flaky example with xit
2023-01-02 19:20:00 +00:00
filipefurtad0
f3ff70a9f2
Updates BOM system spec after changes from #10123
2023-01-02 12:58:22 +00:00
filipefurtad0
5ae6223a8c
Updates error messages after #10174 merge
2023-01-02 11:15:26 +00:00
filipefurtad0
a465093d12
Adds coverage for inconsistent variant unit name on csv - product creation
2023-01-02 11:15:26 +00:00
filipefurtad0
95c9f9afbb
Adds coverage for inconsistent variant unit name on csv - inventory import
2023-01-02 11:15:26 +00:00
dependabot[bot]
2842f2bb9e
Bump rubocop from 1.41.1 to 1.42.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.41.1 to 1.42.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.41.1...v1.42.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-02 09:05:39 +00:00
dependabot[bot]
dc8ccba972
Bump bullet from 7.0.4 to 7.0.5
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.0.4 to 7.0.5.
- [Release notes](https://github.com/flyerhzm/bullet/releases )
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.4...7.0.5 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-02 09:04:05 +00:00
dependabot[bot]
a0d7f10256
Bump puma from 5.6.5 to 6.0.2
...
Bumps [puma](https://github.com/puma/puma ) from 5.6.5 to 6.0.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v5.6.5...v6.0.2 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-02 09:02:00 +00:00
Sigmund Petersen
d5ef68323e
Merge pull request #10169 from cillian/remove-unused-angular-directives
...
Remove unused angular directives
2023-01-01 13:14:23 +01:00
Rachel Arnould
6c1c103272
Merge pull request #10080 from jibees/10075-change-edit-order-page-colors
...
[WIP 🚧 ] Admin - Order edition, behind feature toggle `admin_style_v2`: adjust colors
2022-12-30 11:42:23 +01:00
dependabot[bot]
985cf990d6
Merge pull request #10214 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.7.0
2022-12-30 09:35:54 +00:00
dependabot[bot]
22eee4493f
Bump knapsack_pro from 3.6.0 to 3.7.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.6.0...v3.7.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-30 09:01:14 +00:00
Jean-Baptiste Bellet
74b618230f
Put action icons on the same line inside a .flex container
2022-12-30 09:39:01 +01:00
Jean-Baptiste Bellet
5601a6d3b6
Darken labels since the background is now more white but light grey
2022-12-29 14:47:12 +01:00
Jean-Baptiste Bellet
7b7718977f
Put action icons on the same line with .flex container
...
As they are now `display: flex;` (due to alignement of the background, and the icon itself), we are obliged to add this small container
2022-12-29 14:44:30 +01:00
Maikel Linke
c54942d1ce
Update translations
2022-12-29 10:14:50 +11:00
Filipe
fdc78b717e
Merge pull request #10123 from jibees/10017-introduce-a-filter-results-button-on-the-bom-page
...
Introduce a filter results button on the BOM page
2022-12-28 16:55:30 +00:00
Rachel Arnould
95821098d8
Merge pull request #10154 from jibees/10146-split-checkout-design-changes-part-1
...
Split checkout design changes part 1
2022-12-28 16:36:57 +01:00
Rachel Arnould
27643945ed
Merge pull request #10200 from ijdershem/idersh/OFN-9834
...
[OFN-9834] Preserve 'Items' unit size selection on new product form e…
2022-12-28 16:05:43 +01:00
Jean-Baptiste Bellet
b0048cb453
Underline the text for title of the previously completed step
2022-12-28 15:27:37 +01:00
Jean-Baptiste Bellet
1e1ec95a5a
Include payment form right after the payment description
...
which is right after the radio input that select the payment description
2022-12-28 15:24:46 +01:00
Jean-Baptiste Bellet
2d86e8857a
Put payment method description just above the
...
+ update spec by adding `data-paymentmethod-id` attribute
2022-12-28 15:21:29 +01:00
Jean-Baptiste Bellet
f1bb4fdf38
Same display css rules for price of payment and shipping method
...
+ update spec since parenthesis are added by css
2022-12-28 15:21:29 +01:00
Jean-Baptiste Bellet
a6856f3d21
Cancel button looked as disabled: now use a orange border and white bg
2022-12-28 15:21:29 +01:00
Jean-Baptiste Bellet
ca1a850d4a
Show shipping method description just bellow the radio input
2022-12-28 15:21:29 +01:00
Rachel Arnould
921e1f8083
Merge pull request #10113 from jibees/10112-remove-storybook-styleguide
...
Remove `@storybook`
2022-12-28 13:03:00 +01:00
Jean-Baptiste Bellet
a793fc9f99
Create a "None" calculator for shipping and payment methods
...
Only for payment and shipping methods
2022-12-27 17:49:48 +01:00
Jean-Baptiste Bellet
928b4144d5
Remove @storybook
2022-12-27 10:50:11 +01:00
Jean-Baptiste Bellet
93e736fdf6
Use label as a placeholder that move above the input when focused
...
Couldn't make a pure CSS version because of the way rails generates its errors (it add `<span />` over the element, either `input` or `label`, itself)
2022-12-27 10:47:18 +01:00
Jean-Baptiste Bellet
988dcc6081
Use two columns for contact info and first/last name
...
For small screen, it's a one column
2022-12-27 10:46:59 +01:00
Jean-Baptiste Bellet
d43f0331ac
Contact information section for email + phone number
...
+ add first name and last name to the billing address section
2022-12-27 10:46:38 +01:00
Jean-Baptiste Bellet
dcbe9dd1cb
Do not underline element that aren't link
2022-12-27 10:46:37 +01:00
Filipe
c96bba8094
Merge pull request #10137 from ijdershem/idersh/issue-9834-pt2
...
[OFN-9834-PT2] Fix new product form error label styling
2022-12-26 11:54:25 +00:00
Filipe
45a49d01ec
Merge pull request #10064 from abdellani/add_final_weight_to_occt_report_
...
Add final weight to occt report
2022-12-26 11:32:08 +00:00
dependabot[bot]
3b6d0a8760
Merge pull request #10203 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.1
2022-12-26 10:00:23 +00:00
dependabot[bot]
5f4aed92d8
Merge pull request #10204 from openfoodfoundation/dependabot/bundler/simplecov-0.22.0
2022-12-26 09:59:51 +00:00
dependabot[bot]
a118c786ef
Merge pull request #10202 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.1.0
2022-12-26 09:58:11 +00:00
dependabot[bot]
1572a81274
Merge pull request #10205 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.17.4
2022-12-26 09:55:12 +00:00
dependabot[bot]
6f8dc4dd79
Bump rubocop-rails from 2.17.3 to 2.17.4
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.3 to 2.17.4.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.3...v2.17.4 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-26 09:03:23 +00:00
dependabot[bot]
6879643044
Bump simplecov from 0.21.2 to 0.22.0
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.21.2 to 0.22.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.21.2...v0.22.0 )
---
updated-dependencies:
- dependency-name: simplecov
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-26 09:02:54 +00:00
dependabot[bot]
2a0cd5e275
Bump mini_portile2 from 2.8.0 to 2.8.1
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.0...v2.8.1 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-26 09:01:28 +00:00
dependabot[bot]
af7c11bb3e
Bump @floating-ui/dom from 1.0.12 to 1.1.0
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.12 to 1.1.0.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.1.0/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-26 09:01:28 +00:00
dependabot[bot]
046d7d5f44
Merge pull request #10189 from openfoodfoundation/dependabot/bundler/rubocop-1.41.1
2022-12-26 08:40:18 +00:00
dependabot[bot]
81e1bb19a3
Merge pull request #10190 from openfoodfoundation/dependabot/bundler/view_component-2.80.0
2022-12-26 08:39:55 +00:00
dependabot[bot]
d30d3d256d
Merge pull request #10196 from openfoodfoundation/dependabot/bundler/jwt-2.6.0
2022-12-26 08:39:35 +00:00
dependabot[bot]
850c845992
Merge pull request #10197 from openfoodfoundation/dependabot/bundler/debug-1.7.1
2022-12-26 08:39:07 +00:00
Mohamed ABDELLANI
f1b81613d6
fix OCCT unit test
2022-12-26 08:47:42 +01:00
Mohamed ABDELLANI
e3914ed306
add final_weight_volume column to the hidden by default column of OCCT report
2022-12-26 08:29:36 +01:00
ijdershem-jf
ef092dd53a
[OFN-9834] Fix red error highlighting on product unit value label
...
[OFN-9834] Fix unit value form label association
[OFN-9834] Update tests to reference correct product unit 'Value' field id
2022-12-24 18:36:41 -07:00
ijdershem-jf
5e0287d93f
[9834] Fix red error highlighting on product category select label
2022-12-24 18:13:23 -07:00
ijdershem-jf
58fb2ebe29
[9834] Fix red error highlighting on product unit selection label
2022-12-24 09:44:37 -07:00
ijdershem-jf
0d37614e90
[OFN-9834] Preserve 'Items' unit size selection on new product form error
2022-12-24 09:31:31 -07:00
dependabot[bot]
cb4b54c927
Bump rubocop from 1.41.0 to 1.41.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.41.0 to 1.41.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.41.0...v1.41.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:27:11 +00:00
dependabot[bot]
a9a7ad5cb3
Bump debug from 1.7.0 to 1.7.1
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:27:04 +00:00
dependabot[bot]
46562aace7
Bump view_component from 2.79.0 to 2.80.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.79.0 to 2.80.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.79.0...v2.80.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:26:49 +00:00
dependabot[bot]
a57d1863c0
Bump jwt from 2.5.0 to 2.6.0
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.5.0...v2.6.0 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:26:11 +00:00
jibees
fd74473bdd
Merge pull request #10199 from filipefurtad0/fixes_list_spec
...
Changes dates to be dynamic using Time.zone.now
2022-12-24 11:22:34 +01:00
filipefurtad0
78c29f2c6a
Changes dates to be dynamic using Time.zone.now
...
Strips leading zeroes from datepicker assertion
2022-12-23 17:11:49 +00:00
Rachel Arnould
7a62a95e0b
Merge pull request #10103 from binarygit/stop-horizontal-scroll-of-body-in-order-summary-page
...
[Split Checkout] Stop horizontal scroll on body in order summary page
2022-12-23 10:29:21 +01:00
Jean-Baptiste Bellet
b8e4dcac7c
Update all locales with the latest Transifex translations
2022-12-23 10:27:19 +01:00
Filipe
944d552f6b
Merge pull request #10156 from ijdershem/idersh/issue-9834-pt3
...
[OFN-9834-PT3] Add placeholder for new product supplier field
2022-12-22 15:42:38 +00:00
Filipe
c3e4c53a01
Merge pull request #10074 from binarygit/order-cycle-closes-during-split-co
...
Redirect to shopfront when Order cycle closes during split checkout
2022-12-22 15:09:57 +00:00
Filipe
ae59621341
Merge pull request #10174 from ijdershem/idersh/OFN-9870
...
[OFN-9870] Correct error message for differing variant_unit_name for same product in import
2022-12-22 11:20:12 +00:00
Filipe
d61affd82b
Merge pull request #10093 from vviekk/viv/noneTranslate
...
Translating text 'None' for tax and shipping categories of the product
2022-12-21 21:45:05 +00:00
jibees
c0364a845d
Merge pull request #10172 from filipefurtad0/fix_flaky_invoice_spec_2
...
Removes line break for displaying product units
2022-12-21 18:37:50 +01:00
Filipe
47e100607c
Merge pull request #10041 from abdellani/add_on-hand_and_on-demand_to_product_report
...
Add 'on hand' and 'on demand' to Products report
2022-12-21 17:31:21 +00:00
filipefurtad0
7f17bfaa9a
Separates assertions to account for line breaks
...
Rubocop corrections
2022-12-21 17:25:30 +00:00
jibees
e9f92d39aa
Merge pull request #10184 from abdellani/fix-zeitwork-load-exception
...
prevent loading the reporting module if already loaded [dev environment]
2022-12-21 11:26:19 +01:00
Mohamed ABDELLANI
23462e9965
avoid loading reporting lib if it's already loaded
2022-12-21 10:58:48 +01:00
Mohamed ABDELLANI
0d0c568b10
overwrite the default fields_to_hide to [] on OrderCycleSupplierTotals tests
2022-12-21 07:33:05 +01:00
Mohamed ABDELLANI
155b8ed725
subtract fields_to_hide when the fields_to_show are calculated
2022-12-21 07:32:18 +01:00
Mohamed ABDELLANI
11ea6b39cf
test if All products report returns on_hand and on_demand
2022-12-21 07:23:32 +01:00
ijdershem-jf
18e9aba6b8
[OFN-9870] Display accurate error message for differing variant_unit_name for same product in import
2022-12-20 08:19:47 -07:00
Filipe
561458ce43
Merge pull request #9933 from Laurel16/instagram
...
Admin, Enterprise Settings, Social: Add instagram handler validator
2022-12-20 12:40:57 +00:00
Filipe
6f3d27b99b
Merge pull request #10089 from abdellani/fix-payment-non-3d-need-to-be-manually-captured-in-BO
...
Fix Payments with non-3D cards need to be manually captured in the BO (Split checkout)
2022-12-20 10:09:45 +00:00
dependabot[bot]
8e5495c34d
Merge pull request #10176 from openfoodfoundation/dependabot/bundler/rubocop-1.41.0
2022-12-20 09:18:06 +00:00
dependabot[bot]
59b727aa95
Bump rubocop from 1.40.0 to 1.41.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.40.0 to 1.41.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.40.0...v1.41.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-20 09:04:30 +00:00
binarygit
3b179e75a4
Stop horizontal scroll on body in cart page
2022-12-19 21:30:31 +05:45
Jean-Baptiste Bellet
2ff50587d8
Align icon content in the center via display: flex;
2022-12-19 11:53:58 +01:00
Jean-Baptiste Bellet
2296a51dd2
Remove useless CSS class .filte-row
2022-12-19 10:50:00 +01:00
dependabot[bot]
33896a73f3
Merge pull request #10171 from openfoodfoundation/dependabot/bundler/shoulda-matchers-5.3.0
2022-12-19 09:33:32 +00:00
dependabot[bot]
d97f49d1d4
Bump shoulda-matchers from 5.2.0 to 5.3.0
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v5.2.0...v5.3.0 )
---
updated-dependencies:
- dependency-name: shoulda-matchers
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-19 09:03:57 +00:00
Cillian O'Ruanaidh
c000010d0b
Update CSS comment to reflect that singleLineSelectors directive was replaced by filterSelectors
2022-12-16 16:24:42 +00:00
Cillian O'Ruanaidh
26baad53e4
Remove unused singleLineSelectors angular directive
2022-12-16 14:50:09 +00:00
Jean-Baptiste Bellet
86c437ee24
No need to be as specific
...
Didn't work for firefox.
Seems to be useless now, removing it.
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
19bd067379
White background for dropdowns
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
20596b9441
Mark as icon-remove and then considered as secondary
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
d8e22a5ee7
Add rounded corner on top of table header
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
896743ee34
Icon road (ie. ship button) should be dark blue on hover
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
f935a27253
Override border color when open or active for multi select
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
54fd768aa4
Darker blue instead of green on the side menu when active or hover
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
89acd3a589
Body is now with bg-color $v2-body-bg, ie. #f7f9fa
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
819cf5cc49
Add this td even if empty
...
easier to design table then
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
10b0f9b650
Be more and more specific to be sure that this overrides applies
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
67cca34daa
Consider remove button as a secondary one
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
19f3fd872f
Re-organise to be as clear as possible
...
Use default then override
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
3175f0f68c
Specify for edit, capture, ok and plus icons: background is always blue
...
The previously success color (which is green) is doesn't fit the v2 design
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
5f7f7c78b0
Change tom-select colors
...
cf. select2
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
aa26e15e6b
Permit to use hovering background color get from the state
...
Do not override, and then, icon can be:
- red if it's a delete icon,
- green if it's ..
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
64d467ce39
Specify table#listing_orders and be as generic as possible for table
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
727e6d4966
Only called in a v2 context, no need to specify a selector
...
+ adjust that should be adjusted
2022-12-16 15:49:38 +01:00
Jean-Baptiste Bellet
66134c24b7
Sidebar should be blue instead of green
2022-12-16 15:48:36 +01:00
Jean-Baptiste Bellet
19d5723dd6
In v2, .cancel button are secondary
2022-12-16 15:48:36 +01:00
Jean-Baptiste Bellet
03c38aee3c
Only import v2 scss files in a v2 context
2022-12-16 15:48:36 +01:00
Jean-Baptiste Bellet
ada76a9bf7
Create a palette mixin that override global color variables
...
This is widely used elsewhere and especially for all the state colors
2022-12-16 15:48:26 +01:00
Jean-Baptiste Bellet
bf073599d7
Align before pseudo component by using flex (and not width and padding)
2022-12-16 15:48:26 +01:00
Jean-Baptiste Bellet
faf106b282
Specify color for [class*="icon-"] as well
2022-12-16 15:48:26 +01:00
Cillian O'Ruanaidh
d79b4bdcf9
Remove unused fillVertical angular directive
2022-12-16 13:10:36 +00:00
Cillian O'Ruanaidh
d90d352a86
Remove unused showMore angular directive
2022-12-16 12:55:28 +00:00
dependabot[bot]
1ca305ab7c
Merge pull request #10166 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.12
2022-12-16 10:33:18 +00:00
dependabot[bot]
ea07795304
Bump @floating-ui/dom from 1.0.10 to 1.0.12
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.10 to 1.0.12.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.12/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-16 09:01:18 +00:00
Jean-Baptiste Bellet
f8ec71d0d8
Update all locales with the latest Transifex translations
2022-12-16 09:34:23 +01:00
Filipe
006ad6be73
Merge pull request #9929 from abdellani/fix-available-shipping-payment-methods-dont-respect-oc-setting
...
fix payment methods loading on multi-distributor order cycle checkout page
2022-12-15 17:05:03 +00:00
Filipe
d995e7630c
Merge pull request #10076 from abdellani/fix-available-shipping-methods-dont-respect-oc-setting
...
Fix available shipping methods dont respect oc setting
2022-12-15 16:52:16 +00:00
dependabot[bot]
36b3cbb300
Merge pull request #10162 from openfoodfoundation/dependabot/bundler/test-unit-3.5.7
2022-12-15 14:56:56 +00:00
dependabot[bot]
0a5eb9386c
Bump test-unit from 3.5.5 to 3.5.7
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.5 to 3.5.7.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.5...3.5.7 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-15 09:04:54 +00:00
ijdershem-jf
741dc0e29c
[9834-PT3] Add en translation for new product supplier select placeholder
2022-12-14 20:35:19 -07:00
Filipe
d801b6e970
Merge pull request #10102 from binarygit/enable-save-btn-after-removing-fee
...
[Admin][Order Cycle] Enable save btn after removing fee
2022-12-14 17:13:32 +00:00
Filipe
7fe7a672ae
Merge pull request #9990 from abdellani/get_producer_and_product_taxt_status_in_OCSTR
...
add producer and product tax category tax status to the OCSTs report
2022-12-14 15:25:22 +00:00
Rachel Arnould
fd95970774
Merge pull request #8996 from jibees/introduce-backoffice-ui-uplift
...
Introduce backoffice UI uplift
2022-12-14 14:20:43 +01:00
Jean-Baptiste Bellet
a0056553b0
Do not override date range selection when an order cycle is selected
...
Therefor user can change date range after selecting an order cycle
2022-12-14 10:14:54 +01:00
Jean-Baptiste Bellet
87ae8a40d1
Put date filter after the order cycle selector
...
it's way easier to understand then that date range could change when selecting order cycle
2022-12-14 10:13:36 +01:00
Jean-Baptiste Bellet
ac494f97ec
When changing order cycle selection, update date range selector value
...
Date selector should change when selecting an order cycle in order to reflect the order cycle date range itself
2022-12-14 10:12:42 +01:00
dependabot[bot]
a046d0538b
Merge pull request #10158 from openfoodfoundation/dependabot/bundler/rails-html-sanitizer-1.4.4
2022-12-14 08:16:38 +00:00
dependabot[bot]
9cd35ddd65
Bump rails-html-sanitizer from 1.4.3 to 1.4.4
...
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/rails/rails-html-sanitizer/releases )
- [Changelog](https://github.com/rails/rails-html-sanitizer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/rails-html-sanitizer/compare/v1.4.3...v1.4.4 )
---
updated-dependencies:
- dependency-name: rails-html-sanitizer
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-14 07:59:16 +00:00
dependabot[bot]
ac87daab4b
Merge pull request #10155 from openfoodfoundation/dependabot/bundler/loofah-2.19.1
2022-12-14 07:58:33 +00:00
ijdershem-jf
ea45462e50
[9834-PT3] Add placeholder/default select option for new product supplier field
2022-12-13 18:17:49 -07:00
dependabot[bot]
bd0b251724
Bump loofah from 2.19.0 to 2.19.1
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.19.0 to 2.19.1.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.19.0...v2.19.1 )
---
updated-dependencies:
- dependency-name: loofah
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-13 20:38:27 +00:00
Rachel Arnould
f3d82b41ad
Merge pull request #10108 from binarygit/transparent-bg-in-ff
...
Fix: Transparent background of 'Complete Order' area on Firefox mobile
2022-12-13 17:34:52 +01:00
dependabot[bot]
a1d939af24
Merge pull request #10153 from openfoodfoundation/dependabot/bundler/view_component-2.79.0
2022-12-13 09:21:38 +00:00
dependabot[bot]
eeacdb676e
Bump view_component from 2.78.0 to 2.79.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.78.0 to 2.79.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.78.0...v2.79.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-13 09:04:37 +00:00
Jean-Baptiste Bellet
e971f46611
Change behavior: dates shouldn't have changed
...
Seems like more coherent with the new behavior (ie. don't load orders on filters changes but on click on "Filter Results" button)
2022-12-12 16:18:39 +01:00
Jean-Baptiste Bellet
5fd78a8db5
Update specs: Need to click on "Filter Results" button to update orders
2022-12-12 16:18:39 +01:00
Jean-Baptiste Bellet
311675f2cf
Used an already existing key
...
Update bulk_management.html.haml
2022-12-12 16:18:39 +01:00
Jean-Baptiste Bellet
97c3aaebb2
Update the view as well: remove red clear button
...
+ remove all `refreshData()` callback on input change
+ align html (add fieldset, legend) to look same as `/admin/orders`
2022-12-12 16:18:39 +01:00
Jean-Baptiste Bellet
4716ed19dc
Remove the watch collection on date range: not needed anymore
...
Yes!
This simplifies a lot the code now since we have a "Search" button and we don't need to watch for date range changes
2022-12-12 16:18:39 +01:00
Jean-Baptiste Bellet
cd743e5c2c
Call resetSelectFilters on page load
...
+ init start and end date with a method (will be re-used)
2022-12-12 16:18:39 +01:00
jibees
21366f8109
Merge pull request #10127 from filipefurtad0/split_system_tests
...
Splits admin and consumer system tests into two runner machines
2022-12-12 16:14:56 +01:00
jibees
e4bfe7fac6
Merge pull request #10057 from filipefurtad0/fix_rspec_mocks_deprecation_2
...
Updates syntax to remove depracation warnings
2022-12-12 16:02:52 +01:00
Jean-Baptiste Bellet
a8278446b3
Simplify the way we render the name column
2022-12-12 15:20:30 +01:00
Jean-Baptiste Bellet
10bfe00123
Rename column "Name"
2022-12-12 15:20:30 +01:00
dependabot[bot]
e790fc2b7b
Merge pull request #10140 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.6.0
2022-12-12 13:52:50 +00:00
dependabot[bot]
deff728ca8
Merge pull request #10138 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.10
2022-12-12 13:51:59 +00:00
dependabot[bot]
064e97d7ee
Bump knapsack_pro from 3.5.0 to 3.6.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.5.0...v3.6.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-12 09:05:44 +00:00
dependabot[bot]
3003ba0fc0
Bump @floating-ui/dom from 1.0.9 to 1.0.10
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.9 to 1.0.10.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.10/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-12 09:02:19 +00:00
Mohamed ABDELLANI
9fbdb311b0
Update app/services/order_available_payment_methods.rb
...
Co-authored-by: jibees <jb.bellet@gmail.com >
2022-12-10 11:51:35 +01:00
Rachel Arnould
5ed6e5599d
Merge pull request #9943 from mkllnk/dfc-provider-test
...
DFC 1.6 prototype
2022-12-09 19:35:49 +01:00
filipefurtad0
900ff6d053
Enables queue mode for system/admin and system/consumer
2022-12-08 20:50:44 +00:00
filipefurtad0
4d605c7060
Splits admin and consumer system tests
...
Disables queue mode for system tests
2022-12-08 20:50:44 +00:00
Jean-Baptiste Bellet
ffba628691
Update all locales with the latest Transifex translations
2022-12-08 21:36:51 +01:00
Filipe
8b416a8eda
Merge pull request #10106 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.5.0
...
Bump knapsack_pro from 3.4.2 to 3.5.0
2022-12-08 19:27:04 +00:00
filipefurtad0
2c18e97fb8
Fixes deprecation warnings on authorizer_spec
2022-12-08 18:42:48 +00:00
Laurel16
bfd396e644
Add instagram handler validator
...
update entreprise model to match the correct pattern for instagram attribute & add migration to correct wrong links in db + test
2022-12-08 15:22:05 +01:00
dependabot[bot]
e11d644a95
Merge pull request #10122 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.9
2022-12-08 11:09:34 +00:00
dependabot[bot]
26131d105e
Merge pull request #10121 from openfoodfoundation/dependabot/bundler/rubocop-1.40.0
2022-12-08 11:08:50 +00:00
Mohamed ABDELLANI
84aedaa1a1
run process_payments before order confirmation
2022-12-08 11:13:54 +01:00
dependabot[bot]
cfa0a502f1
Bump @floating-ui/dom from 1.0.8 to 1.0.9
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.8 to 1.0.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.9/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-08 09:02:00 +00:00
dependabot[bot]
869a6b42d3
Bump rubocop from 1.39.0 to 1.40.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.39.0 to 1.40.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.39.0...v1.40.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-08 09:01:46 +00:00
dependabot[bot]
fdf3a0d7b7
Merge pull request #10118 from openfoodfoundation/dependabot/bundler/nokogiri-1.13.10
2022-12-08 07:48:22 +00:00
Mohamed ABDELLANI
d5c9c53d8b
fix the failing test
2022-12-08 08:32:11 +01:00
dependabot[bot]
1f98ef5074
Bump nokogiri from 1.13.9 to 1.13.10
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.13.9 to 1.13.10.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.9...v1.13.10 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-08 04:08:49 +00:00
Filipe
996d3afe4f
Merge pull request #9983 from cillian/remove-exchange-tags-n1-query
...
Remove N+1 query loading tags for each order cycle exchange
2022-12-07 17:38:41 +00:00
Jean-Baptiste Bellet
500c4e8a2f
Already handled by app/webpacker/controllers/index.js
...
Controller were instanced twice.
2022-12-07 15:38:20 +01:00
Jean-Baptiste Bellet
5002870b39
Add missing i18n translation for PaginationComponent
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
d97e9ae824
Remove white space
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
f0e0bac3b5
As components: key already exists, use it!
...
(this key was added during the development of the PR)
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
ec31d63c58
Do not import/initialize twice
...
Already done in "controllers"
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
9dfc22451e
Selectors are close by default
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
3cf01623da
Handle filtering on js controller for SelectorWithFilter
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
274ee2c6f6
Toggle is now controlled by the browser (and don't requires a reflex)
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
940b554d23
Toggle is now controlled by the browser (and don't requires a reflex)
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
91d1ecea2e
Click the whole Selector instead of arrow only
2022-12-07 15:08:54 +01:00
Jean-Baptiste Bellet
fbf2315a93
Rename SuperSelector to SelectorWithFilter
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
428256a323
Exclude products_table_component from Metrics/ClassLength rubocop rule
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
20218c00ab
Manage i18n for ProductsTable component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
18adcb7fa4
Handle i18n for SuperSelector component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
56b94342eb
Manage i18n for SearchInput component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
758c40c646
Manage i18n for Products page
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
98391b60c6
Use CSS vars to match linter
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
3e03208cf5
Add loading state for ProductsTable component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
3ae5db907a
Create js controller for ProductsTable component
...
Handle before/after reflex lifecycle methods on client side
Add 'loading" class on products-table component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
27c1fe2f06
Add search query input to search for product by name
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
122677bc7a
Create SearchInput component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
22d13621f4
Only send close reflex if element is actually visible
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
265b4823a7
Add static var + freeze
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
5e689fcce3
No need to fetch as it's done inside beforeReflex lifecycle method
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
e801bb5e40
some CSS linter
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
d75c62a621
Add TableHeader component and better columns implementation
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
1de7fb6fe8
Create TableHeader component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
d37cd09c84
Use the reflex_data_attributes helper method
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
cb24efbc4a
Some styling improvments
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
c23d4f63ed
Add pagination to ProductsTable component
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
c7197364d1
Add a pagination component that handle pagy
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
069b314ae7
Add producer and category to a product in the table
...
+ refactor and automatize optional column rendered
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
7716d2734e
Title of the items per page selector is clearer
2022-12-07 15:08:53 +01:00
Jean-Baptiste Bellet
8adcdf14a7
Include search by category and producer
...
+ use ransack (not sur this one is relevant)
+ fetch_products in the `before_render` lifecycle method
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
224daf2591
Factorize js controller between Selectore and SuperSelector components
...
+ add a computeItemsHeight on afterReflex callback
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
4fa88b9c18
Fatorize CSS between Selector and SuperSelector components
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
1adb22be71
Create SelectorWithFilter component
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
d4cfa7b368
Add header to the table
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
5c5a0c98f1
Rename selected to columns_selected
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
8ce3c9f449
Introduce a new selector: # of results per page
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
5ea7bea9b8
Selector now handle {label, value} instead of only string
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
461d31bef1
Create ProductsTable component that handle the table + all filters
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
8758a2701c
Configure CSS for VC components
...
Move CSS for components in the component directory
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
2b7bccf890
Create Selector component
...
Add a onClickOutside behavior that close the component if clicked outside
Selector component doesn't handle its state but receive props from parent
u
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
7692cebbd3
Create Product component
...
Update product_component.html.haml
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
1869536529
Install view_component_reflex + cable_ready
...
+ Add stimulus reflex in the admin section
+ log stimulusreflex
+ Create channel and connection
+ Some logging options
+ Create application_controller each stimulus reflex controller should inherits from this one
2022-12-07 15:08:52 +01:00
Jean-Baptiste Bellet
d7d29e3654
Create a new controller for new products page
...
Controller is constrained by FeatureToggle
- new_products_page
- and available on '/new_products'
Add simple view for new products page and a product
Add new products page as a new entry in the menu
2022-12-07 15:08:52 +01:00
dependabot[bot]
2aea5d4957
Merge pull request #10111 from openfoodfoundation/dependabot/npm_and_yarn/express-4.18.2
2022-12-07 14:02:04 +00:00
dependabot[bot]
a328888fc2
Bump express from 4.17.1 to 4.18.2
...
Bumps [express](https://github.com/expressjs/express ) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.17.1...4.18.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-07 13:47:24 +00:00
jibees
c33c4860c8
Merge pull request #10110 from jibees/remove-test-prof
...
Remove `test-prof` as no longer required
2022-12-07 14:47:02 +01:00
jibees
efe8030786
Merge pull request #10071 from filipefurtad0/knapsack_fine_tuning
...
Simplifies build.yml syntax
2022-12-07 14:46:48 +01:00
Jean-Baptiste Bellet
76412bfcae
Remove test-prof as no longer required
2022-12-07 14:29:58 +01:00
Jean-Baptiste Bellet
69faf590b0
Create a spy obj for order_cycle_form as required now by removeCoordinatorFee()
...
Based on `spec/javascripts/unit/admin/order_cycles/controllers/order_cycle_exchanges_controller_spec.js.coffee`
2022-12-07 09:37:31 +01:00
binarygit
2f037c3965
Fix: Transparent background of 'Complete Order' area on Firefox mobile
2022-12-07 12:21:03 +05:45
filipefurtad0
70193539b2
Fixes deprecation warnings on parameters_spec
2022-12-06 15:49:28 +00:00
filipefurtad0
8ee5050a49
Fixes deprecation warnings on tax_rate_spec
2022-12-06 15:49:28 +00:00
filipefurtad0
2e4a8f8ae8
Fixes deprecation warnings on payment_spec
2022-12-06 15:49:19 +00:00
dependabot[bot]
8ee05789ef
Merge pull request #10105 from openfoodfoundation/dependabot/bundler/json-2.6.3
2022-12-06 09:40:21 +00:00
dependabot[bot]
e2a8ab16b4
Merge pull request #10104 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.8
2022-12-06 09:39:49 +00:00
dependabot[bot]
6fb337b81c
Bump knapsack_pro from 3.4.2 to 3.5.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.4.2 to 3.5.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.4.2...v3.5.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-06 09:04:54 +00:00
dependabot[bot]
387a46e1db
Bump json from 2.6.2 to 2.6.3
...
Bumps [json](https://github.com/flori/json ) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/compare/v2.6.2...v2.6.3 )
---
updated-dependencies:
- dependency-name: json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-06 09:02:33 +00:00
dependabot[bot]
1db85e295b
Bump @floating-ui/dom from 1.0.7 to 1.0.8
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.8/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-06 09:01:30 +00:00
Mohamed ABDELLANI
86c25e1d48
add on_demand/on_hand columns to all products_and_inventory/all_products report
2022-12-06 08:42:42 +01:00
binarygit
368cd76611
[Split Checkout] Stop horizontal scroll on body in order summary page
2022-12-06 12:12:38 +05:45
binarygit
7df2ad13c6
[Admin][Order Cycle] Enable save btn after removing fee
2022-12-06 10:22:10 +05:45
dependabot[bot]
fee99a95f8
Merge pull request #10086 from openfoodfoundation/dependabot/bundler/bugsnag-6.25.0
2022-12-05 14:00:17 +00:00
dependabot[bot]
ab70a85866
Merge pull request #10095 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.3.13
2022-12-05 10:03:54 +00:00
dependabot[bot]
d31c2d95b3
Merge pull request #10096 from openfoodfoundation/dependabot/bundler/debug-1.7.0
2022-12-05 10:03:38 +00:00
dependabot[bot]
44af982b3e
Merge pull request #10094 from openfoodfoundation/dependabot/bundler/digest-3.1.1
2022-12-05 10:02:51 +00:00
dependabot[bot]
2ea22248e0
Bump digest from 3.1.0 to 3.1.1
...
Bumps [digest](https://github.com/ruby/digest ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/ruby/digest/releases )
- [Commits](https://github.com/ruby/digest/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: digest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-05 09:49:09 +00:00
dependabot[bot]
9d58f16012
Bump debug from 1.6.3 to 1.7.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.6.3 to 1.7.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.6.3...v1.7.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-05 09:48:38 +00:00
dependabot[bot]
f2838105fe
Bump js-big-decimal from 1.3.12 to 1.3.13
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.12 to 1.3.13.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.12...v1.3.13 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-05 09:48:27 +00:00
Mohamed ABDELLANI
500c23ce27
fix failing tests after replacing "" with none
2022-12-05 10:03:56 +01:00
Mohamed ABDELLANI
fac8926396
map nil to "none" in format cell
2022-12-05 08:57:07 +01:00
Mohamed ABDELLANI
bd4b3110c1
test OrderCycleSupplierTotals with different combination: product with/without tax category, supplier enabled/disabled vat
2022-12-05 08:57:02 +01:00
Mohamed ABDELLANI
f7cd168f6d
define producer_charges_sales_tax && product_tax_category as new hidden by default columns
2022-12-05 08:44:33 +01:00
vviekk
ccddb7ad65
Transalting text 'None' for tax and shipping categories of the product
2022-12-03 18:36:46 +05:30
Konrad
07c29df801
Merge pull request #10039 from abdellani/fix_missing_products_in_bulk_coop_packing_sheets_report
...
fix Missing products in Bulk co-op Packing Sheets report
2022-12-02 18:19:47 +01:00
Konrad
6ac21eaab4
Merge pull request #9999 from abdellani/add-ability-to-save-rendering-options-per-report
...
Add ability to save rendering options per report
2022-12-02 14:33:37 +01:00
dependabot[bot]
ff0b84c9c0
Merge pull request #10084 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.5.14
2022-12-02 10:27:52 +00:00
dependabot[bot]
26f40dea6f
Merge pull request #10085 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.5.14
2022-12-02 10:27:32 +00:00
dependabot[bot]
188a0f5d25
Merge pull request #10087 from openfoodfoundation/dependabot/npm_and_yarn/decode-uri-component-0.2.2
2022-12-02 09:41:01 +00:00
dependabot[bot]
454c3d6e31
Bump @storybook/addon-docs from 6.5.13 to 6.5.14
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.5.13 to 6.5.14.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.14/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.14/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-02 09:30:22 +00:00
dependabot[bot]
f76f885ffa
Bump @storybook/addon-controls from 6.5.13 to 6.5.14
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.5.13 to 6.5.14.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.14/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.14/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-02 09:30:01 +00:00
dependabot[bot]
f654e52fbb
Bump decode-uri-component from 0.2.0 to 0.2.2
...
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component ) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases )
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2 )
---
updated-dependencies:
- dependency-name: decode-uri-component
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-02 09:29:54 +00:00
dependabot[bot]
b8400e3655
Merge pull request #10083 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.5.14
2022-12-02 09:29:23 +00:00
dependabot[bot]
8168f122a0
Bump bugsnag from 6.24.2 to 6.25.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.24.2 to 6.25.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.24.2...v6.25.0 )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-02 09:04:18 +00:00
dependabot[bot]
7a2084e4e7
Bump @storybook/server from 6.5.13 to 6.5.14
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.5.13 to 6.5.14.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.14/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.14/app/server )
---
updated-dependencies:
- dependency-name: "@storybook/server"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-02 09:01:21 +00:00
Jean-Baptiste Bellet
92dcf926b5
Update all locales with the latest Transifex translations
2022-12-01 17:44:16 +01:00
jibees
1fcc98af80
Merge pull request #10026 from abdellani/make_default_time_at_00_00_instead_of_12_00
...
Make default time at 00 00 instead of 12 00
2022-12-01 17:43:08 +01:00
dependabot[bot]
67dbf552b1
Merge pull request #10078 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.117.2
2022-12-01 09:54:36 +00:00
dependabot[bot]
899879b88d
Merge pull request #10077 from openfoodfoundation/dependabot/bundler/wkhtmltopdf-binary-0.12.6.6
2022-12-01 09:53:08 +00:00
binarygit
764c8d7d27
Redirect to shopfront when OC closes during split checkout
2022-12-01 15:13:36 +05:45
dependabot[bot]
9a57935709
Bump aws-sdk-s3 from 1.117.1 to 1.117.2
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.117.1 to 1.117.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-01 09:04:02 +00:00
dependabot[bot]
5de928f452
Bump wkhtmltopdf-binary from 0.12.6.5 to 0.12.6.6
...
Bumps [wkhtmltopdf-binary](https://github.com/zakird/wkhtmltopdf_binary_gem ) from 0.12.6.5 to 0.12.6.6.
- [Release notes](https://github.com/zakird/wkhtmltopdf_binary_gem/releases )
- [Changelog](https://github.com/zakird/wkhtmltopdf_binary_gem/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zakird/wkhtmltopdf_binary_gem/commits )
---
updated-dependencies:
- dependency-name: wkhtmltopdf-binary
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-01 09:03:12 +00:00
Mohamed ABDELLANI
2fa05ae248
test the case where 2 PR supports 2 SM, and only one SM is checked for a distributor in the OC
2022-11-30 12:43:23 +01:00
Mohamed ABDELLANI
ca795fcf6e
fix OrderAvailableShippingMethods to load the select shipping methods only
2022-11-30 12:42:12 +01:00
Rachel Arnould
524d68496a
Merge pull request #10054 from jibees/10034-change-orders-page-colors
...
[WIP 🚧 ] Admin/Orders, behind feature toggle `admin_style_v2`: adjust colors
2022-11-30 10:58:14 +01:00
dependabot[bot]
b117608229
Merge pull request #10072 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.2.1
2022-11-30 09:20:16 +00:00
dependabot[bot]
1ccd580c7b
Merge pull request #10073 from openfoodfoundation/dependabot/bundler/timecop-0.9.6
2022-11-30 09:18:51 +00:00
dependabot[bot]
bff38b2c5b
Bump timecop from 0.9.5 to 0.9.6
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.5 to 0.9.6.
- [Release notes](https://github.com/travisjeffery/timecop/releases )
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.5...v0.9.6 )
---
updated-dependencies:
- dependency-name: timecop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-30 09:03:43 +00:00
dependabot[bot]
eb911d9fe3
Bump stimulus from 3.2.0 to 3.2.1
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.2.0...v3.2.1 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-30 09:01:01 +00:00
Sigmund Petersen
9fa46d378f
Merge pull request #10070 from filipefurtad0/fix_authentication_spec_#9913
...
Adds expectation to assure login was sucessful
2022-11-30 09:48:01 +01:00
filipefurtad0
2e5f0d302f
Removes unecessary syntax
2022-11-30 09:05:19 +01:00
filipefurtad0
3c4845813d
Adds expectation to assure login was sucessful
2022-11-29 16:45:01 +01:00
dependabot[bot]
7166fa6a25
Merge pull request #10068 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.2.0
2022-11-29 14:28:33 +00:00
dependabot[bot]
9d36d1942e
Merge pull request #10067 from openfoodfoundation/dependabot/bundler/view_component-2.78.0
2022-11-29 11:27:23 +00:00
Mohamed ABDELLANI
9dc3f2d69e
add new parameter defaultDate to flatpickr to decide the default value when selector is opened
2022-11-29 11:12:33 +01:00
Filipe
7b07817bbf
Merge pull request #10065 from openfoodfoundation/revert-9927-lazy-load-product-images
...
Revert "Load product images in the shop lazily to improve performance"
2022-11-29 10:27:54 +01:00
dependabot[bot]
a36627927d
Merge pull request #10066 from openfoodfoundation/dependabot/bundler/bullet-7.0.4
2022-11-29 09:11:21 +00:00
dependabot[bot]
cc80949d56
Bump stimulus from 3.1.1 to 3.2.0
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-29 09:01:55 +00:00
dependabot[bot]
5c8bbb3a38
Bump view_component from 2.77.0 to 2.78.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.77.0 to 2.78.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.77.0...v2.78.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-29 09:01:38 +00:00
dependabot[bot]
e8669f0178
Bump bullet from 7.0.3 to 7.0.4
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.0.3 to 7.0.4.
- [Release notes](https://github.com/flyerhzm/bullet/releases )
- [Changelog](https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.3...7.0.4 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-29 09:01:23 +00:00
jibees
ef31e1d063
Revert "Load product images in the shop lazily to improve performance"
2022-11-29 09:55:39 +01:00
Jean-Baptiste Bellet
4ef5609b0e
This needs to be !important actually ;(
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
4e70a86fa9
Customize color for flatpickr
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
44f52c21db
This is not only available when open or active but also when closed
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
e8b8a8961e
Update links on the top to be blue as well
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
9a849bb2ee
Default rule: a element are blue and darker blue by default
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
9c8525b797
Change default body text color
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
a9edc0cb9c
Use the default blue for the link and a darker one when hovering
2022-11-28 14:36:51 +01:00
Jean-Baptiste Bellet
7556eee5d4
Do not display: flex; a td but its child
...
Actually, having `td.actions` with `display: flex;` cancel the `table-cell` height computation and it's then impossible to solve.
The solution here is to have a child (`div.flex`) that is `display: flex` and then the parent `td` can compute its height (as the same than its current row).
2022-11-28 14:36:51 +01:00
Filipe
44760ce8b6
Merge pull request #10014 from openfoodfoundation/dependabot/bundler/stripe-8.0.0
...
Bump stripe from 7.1.0 to 8.0.0
2022-11-28 12:03:33 +01:00
Mohamed ABDELLANI
005d5cafde
test if the rendering options are stored for every reports seperately and if they persiste after logout
2022-11-28 11:35:00 +01:00
Jean-Baptiste Bellet
25ab334d73
Add box shadow on icon
2022-11-28 11:09:09 +01:00
dependabot[bot]
85dc32ffcb
Merge pull request #10061 from openfoodfoundation/dependabot/bundler/bootsnap-1.15.0
2022-11-28 09:30:09 +00:00
dependabot[bot]
763d922510
Bump bootsnap from 1.14.0 to 1.15.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.14.0...v1.15.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-28 09:02:58 +00:00
jibees
a8bb05c575
Merge pull request #10058 from filipefurtad0/reduce_number_of_nodes
...
Removes the number of nodes for system specs
2022-11-28 08:38:36 +01:00
Konrad
0ce1ccf2d6
Merge pull request #10040 from abdellani/add_variant_sku_to_ocst_report
...
add variant sku to the OCST report
2022-11-27 21:28:07 +01:00
Konrad
e288c7a551
Merge pull request #9956 from jibees/9626-resize-and-crop-logo-instead-of-just-resizing-should-fit-into-a-square
...
Enterprise logo: Resize and crop logo instead of just resizing --> logo should fit into a square
2022-11-27 20:28:55 +01:00
Konrad
dc030182db
Merge pull request #10023 from abdellani/add-hub-filter-to-orders-and-distributors
...
Add filter by distributor in "Orders And Distributors" report
2022-11-27 19:52:19 +01:00
Konrad
ddd0b939fe
Merge pull request #9968 from openfoodfoundation/9964-xero-reports-bugnsag-error-missing-target-element-checkbox-for-csv-select-controller
...
Xero report: Avoid js error due to missing element, check it exists before setting any properties
2022-11-27 19:20:16 +01:00
filipefurtad0
a4b6c05d58
Removes the number of nodes for system specs
2022-11-27 16:49:23 +01:00
Jean-Baptiste Bellet
b3d0c0f2d5
Adjust bg color for items for multi selector
2022-11-25 16:56:15 +01:00
Jean-Baptiste Bellet
3afd8b7189
Adjust color, size and padding for one item selector
...
Unfortunately `!important` is necessary... 😭 😭 😭
2022-11-25 16:53:31 +01:00
Jean-Baptiste Bellet
7d51bd7b83
Add secondary button
2022-11-25 16:47:48 +01:00
Jean-Baptiste Bellet
974842300c
Prepare buttons to have a border
...
(and a background with the same color than the border)
2022-11-25 16:47:31 +01:00
Jean-Baptiste Bellet
9474b574ad
Do not apply button to td.actions icons
2022-11-25 16:45:21 +01:00
jibees
3a490a1f26
Merge pull request #10056 from filipefurtad0/remove_performance_spec
...
Removes performance spec and folder
2022-11-25 16:09:23 +01:00
filipefurtad0
fce3c46e55
Removes performance spec and folder
2022-11-25 15:40:36 +01:00
dependabot[bot]
a95bef141f
Merge pull request #10051 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.7
2022-11-25 09:10:29 +00:00
Mohamed ABDELLANI
e20e519201
test when two distributors support the same PMs, and only one PM is checked for a distributor in the OC
2022-11-25 10:04:29 +01:00
Mohamed ABDELLANI
c35c003e5a
load exclusively the payment methods that are available on the distributor
2022-11-25 09:23:39 +01:00
Mohamed ABDELLANI
e25f4b1daa
integrate ReportRenderingOptions in the View/Controller
2022-11-25 09:10:53 +01:00
David Cook
7b965718aa
Authorise based on user's UID
...
And test to make sure the wrong user is not selected.
2022-11-25 16:14:25 +11:00
David Cook
61e7b59437
Refactor spec
...
Ready to expand in the next commit.
2022-11-25 16:14:20 +11:00
David Cook
ff9544e08b
Allow AuthorizationControl to run without Warden
...
As explained in 36c44a5487 , it's not normally good to change production code to make testing easier.
But this tiny change makes it more robust, and enables much simpler specs.
2022-11-25 16:01:42 +11:00
Maikel Linke
029c0afaa9
Verify token signature for authenticated login
...
We were just logging in any user without password or other verification
before. Now we verify the Keycloak signature and know that the person is
indeed logged in.
2022-11-25 14:49:36 +11:00
Maikel Linke
33ee03388f
Add DFC product update action, not implemented
2022-11-25 14:49:36 +11:00
Maikel Linke
4d49266f0f
Allow updates just with auth token
...
Rails usually requires an additional CSRF protection token but when it's
not present we ignore the user's session and use only the OIDC auth
token.
2022-11-25 14:49:36 +11:00
Maikel Linke
aea6f864d9
Update to DFC v1.6
...
I just replaced dfc: with dfc-b: where I found this key used in the
prototype. We may need to change more.
2022-11-25 14:49:36 +11:00
Maikel Linke
4cdb224434
Add missing rdfs prefix to DFC context
2022-11-25 14:49:36 +11:00
Maikel Linke
8d6615aa6b
Start to spec DFC auth control
2022-11-25 14:49:36 +11:00
Maikel Linke
b0aa7b7b55
Use Rspec's http matcher for better fail output
...
The previous version would just say that it expected true and got false.
The specific matcher tells us which code it expected and which code it
found.
2022-11-25 14:49:36 +11:00
Maikel Linke
c90d2c7f9a
Spec DFC authorisation with real token
...
Our code doesn't actually verify the token yet but at least we are not
mocking it all anymore.
2022-11-25 14:49:36 +11:00
Maikel Linke
63c1cd7bff
Remove invalid id attribute from DFC offer
...
This one is a bit confusing. The attribute changes throughout the
different versions of the ontology and the DFC examples are not in line
with the specification. WIP I guess.
The previous nil attribute failed JSON-LD validation and DFC examples
just contain the reference as I did it now. But I think that we will
need to update it again vor DFC-v1.7.
2022-11-25 14:49:36 +11:00
Maikel Linke
ee3ec15bc4
Update URL to DFC ontology
2022-11-25 14:49:36 +11:00
Maikel Linke
b9a43df7fe
Include DFC version in API URL
...
And let the OFN app decide under which name to mount the DFC engine.
It simplifies the code and will make it more flexible to introduce other
versions in the future.
2022-11-25 14:49:36 +11:00
Maikel Linke
fd274447fe
Simplify DFC authentication code
2022-11-25 14:49:36 +11:00
Maikel Linke
52a98989e0
Allow logged in users to access DFC API
...
It makes testing in development so much easier.
2022-11-25 14:49:36 +11:00
Maikel Linke
96193a27a4
Simplify DFC authorisation control
...
I want to add other ways to authenticate for easier testing and possibly
more integrations. It will be easier to just test if we got a user or
not instead of testing pre-conditions to that as well.
2022-11-25 14:49:36 +11:00
Maikel Linke
2630fde763
Update dfc_provider for Active Storage images
2022-11-25 14:49:36 +11:00
Maikel Linke
a501bc9687
Encapsulate dfc_provider in api routing
...
Move /api/v0/dfc_provider to /api/dfc_provider. Before it got redirected
to v0 which caused some errors.
2022-11-25 14:49:36 +11:00
David Cook
f25fb19fe8
Merge pull request #10053 from filipefurtad0/knapsackpro_api_key_engines
...
[knapsack] Updates subfolder syntax and adds separate API key for engine tests
2022-11-25 12:37:28 +11:00
David Cook
25ed405da7
Merge pull request #10052 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.4.2
...
Bump knapsack_pro from 3.4.1 to 3.4.2
2022-11-25 11:14:18 +11:00
David Cook
00176b2b95
Merge pull request #10047 from filipefurtad0/fix_rspec_mocks_deprecation
...
Replaces stub with allow
2022-11-25 11:12:11 +11:00
David Cook
8f25718e62
Merge pull request #9973 from jibees/9972-remove-question-mark-from-capybara-saved-screenshots-in-order-to-save-it-through-ghactions
...
Sanitize `image_name` by removing all questions marks when saving any capybara screenshots
2022-11-25 09:51:56 +11:00
Jean-Baptiste Bellet
98b9395c31
Adjust table to reflect the new design
...
colors, size, border, padding/margin, ...
2022-11-24 16:46:22 +01:00
Jean-Baptiste Bellet
540c673924
Basically change colors for progress stuff
2022-11-24 16:45:45 +01:00
Jean-Baptiste Bellet
4149c14e8d
Basically change colors for button components
2022-11-24 16:45:31 +01:00
Jean-Baptiste Bellet
af43fe9a5b
Basically change colors for form inputs, fieldset
2022-11-24 16:45:03 +01:00
Jean-Baptiste Bellet
2a3c4d6649
Basically change colors for powertip component
2022-11-24 16:44:28 +01:00
Jean-Baptiste Bellet
c954187322
Basically change colors for select2 components
2022-11-24 16:44:09 +01:00
Jean-Baptiste Bellet
dbb7155114
Globally change body color
2022-11-24 16:43:33 +01:00
Jean-Baptiste Bellet
27b396cbc2
Add some colors and useful shadow
...
Will be used in the next coming commits
2022-11-24 16:43:02 +01:00
Jean-Baptiste Bellet
1abc406156
Do not ignore scss files in v2 folder
...
Starts with good habits.
2022-11-24 15:20:46 +01:00
Jean-Baptiste Bellet
5cab0f7f3d
Use a darker orange color for selected menu
2022-11-24 15:20:46 +01:00
Rachel Arnould
56ce4ab04f
Merge pull request #10025 from jibees/9998-new-admin-style
...
Admin, behind feature toggle `admin_style_v2`: new navigation menu
2022-11-24 14:59:04 +01:00
filipefurtad0
d351bf9a9a
Adds Dir.glob syntax to include subdirectories
2022-11-24 12:56:17 +01:00
filipefurtad0
b447e4052c
Removes empty spaces to comply to Dir.glob syntax
2022-11-24 12:07:16 +01:00
filipefurtad0
29196375f5
Adds separate API key for engine tests
2022-11-24 11:47:59 +01:00
Sigmund Petersen
23570be6a1
Merge pull request #10043 from filipefurtad0/flaky_complex_creating_specific
...
Adds retry: 3 to flaky example
2022-11-24 11:31:09 +01:00
Mohamed ABDELLANI
845133d3f6
group line_items by [customer,variant] in bulk/coop/packing_sheets
2022-11-24 11:06:09 +01:00
Mohamed ABDELLANI
b6a7ca3047
create ReportRenderingOptions model
2022-11-24 10:25:59 +01:00
dependabot[bot]
6652b7fe5c
Bump knapsack_pro from 3.4.1 to 3.4.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.4.1 to 3.4.2.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.4.1...v3.4.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-24 09:06:09 +00:00
dependabot[bot]
6cb17905cd
Bump @floating-ui/dom from 1.0.6 to 1.0.7
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.7/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-24 09:01:15 +00:00
dependabot[bot]
6aa449aacb
Merge pull request #10050 from openfoodfoundation/dependabot/npm_and_yarn/minimatch-3.1.2
2022-11-24 08:34:11 +00:00
Jean-Baptiste Bellet
c2f82202a6
sanitize image_name by removing all questions marks
...
Co-Authored-By: David Cook <david@redcliffs.net >
2022-11-24 07:49:14 +01:00
David Cook
6c219b31a3
Update all locales with the latest Transifex translations
2022-11-24 16:14:16 +11:00
dependabot[bot]
b889f31c1a
Bump minimatch from 3.0.4 to 3.1.2
...
Bumps [minimatch](https://github.com/isaacs/minimatch ) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases )
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2 )
---
updated-dependencies:
- dependency-name: minimatch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-24 05:12:35 +00:00
David Cook
83c7764456
Merge pull request #9895 from filipefurtad0/adds_knapsack_pro
...
Adds knapsack_pro to the stack; updates configs
2022-11-24 16:11:19 +11:00
Konrad
23c3573b8f
Merge pull request #10032 from vviekk/viv/latlong
...
Removing 'required' tag for 'Latitude / Longitude' for Enterprises
2022-11-23 23:45:20 +01:00
Konrad
7c8a3bd7c9
Merge pull request #9955 from jibees/fix-deprecation-warning
...
Fix deprecation warnings around class loading during initialization
2022-11-23 20:16:15 +01:00
filipefurtad0
b66d263bc6
Replaces stub with allow
2022-11-23 15:12:09 +01:00
filipefurtad0
9afa75d91c
Adds retry: 3 to flaky example
2022-11-23 12:57:21 +01:00
Mohamed ABDELLANI
d15708d4e3
test if OCST report includes variant's sku
2022-11-23 09:51:26 +01:00
Mohamed ABDELLANI
dafbefe8e3
add sku to OCST report as hidden by default column
2022-11-23 09:50:34 +01:00
vviekk
9d33402d9e
Merge branch 'master' into viv/latlong
2022-11-22 16:38:19 +05:30
dependabot[bot]
abf8d44935
Merge pull request #10028 from openfoodfoundation/dependabot/bundler/bootsnap-1.14.0
2022-11-22 10:44:08 +00:00
dependabot[bot]
fb15b19e88
Merge pull request #10029 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.17.3
2022-11-22 10:41:41 +00:00
dependabot[bot]
e5c6ff433c
Merge pull request #10037 from openfoodfoundation/dependabot/bundler/view_component-2.77.0
2022-11-22 09:37:48 +00:00
dependabot[bot]
bb35629960
Bump view_component from 2.76.0 to 2.77.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.76.0 to 2.77.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.76.0...v2.77.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-22 09:09:25 +00:00
filipefurtad0
c4e75dc557
Removes knapsack non-pro
2022-11-21 15:04:47 +01:00
filipefurtad0
10d1d2066e
Merges separate knapsack_pro build files into one
...
Renames jobs
Includes jest and karma tests in build file
Renames jest karma job
Moves build setup into build.yml file
Changes job names
Re-distributes nodes according to run-time
2022-11-21 15:04:15 +01:00
filipefurtad0
3c53214daa
Enables fixed_queue_split
2022-11-21 10:02:14 +00:00
filipefurtad0
40a9c36c85
Increases nr of nodes for system specs
2022-11-21 10:02:14 +00:00
filipefurtad0
48ecbaaa16
Enables queue mode only for system tests
2022-11-21 10:02:14 +00:00
filipefurtad0
ef7684e079
Disables queue mode
2022-11-21 10:02:14 +00:00
filipefurtad0
04c3b8b9cf
Sets failing performance specs as pending
2022-11-21 10:02:14 +00:00
filipefurtad0
fd3a54a904
Creates key for test_the_rest specs
2022-11-21 10:02:14 +00:00
filipefurtad0
236abe485a
Splits test-the-rest specs
2022-11-21 10:02:14 +00:00
filipefurtad0
8fb11b9151
Increases ci_node_total for system specs
2022-11-21 10:02:14 +00:00
filipefurtad0
b9471d4f01
Sets same API key for models and engines
2022-11-21 10:02:14 +00:00
filipefurtad0
b5da120805
Splits engines
...
Keeps test-the-rest specs running without Knapsack
2022-11-21 10:02:14 +00:00
filipefurtad0
da5976d85d
Splits model specs
2022-11-21 10:02:14 +00:00
filipefurtad0
9e1047288f
Runs all the test-the-rest specs
2022-11-21 10:02:14 +00:00
filipefurtad0
ff9985dd88
Further splits the build
2022-11-21 10:02:14 +00:00
filipefurtad0
e62eca93c1
Simplifies settings
2022-11-21 10:02:14 +00:00
filipefurtad0
8d532ae262
Enables knapsack_pro by default
2022-11-21 10:02:14 +00:00
filipefurtad0
d2f28e2095
Makes API key public
2022-11-21 10:02:14 +00:00
filipefurtad0
dbd5186dfa
Enables slow file pattern to run on system specs
2022-11-21 10:02:14 +00:00
filipefurtad0
61cb7c4402
Removes knapsack_pro config from spec_helper.rb
2022-11-21 10:02:14 +00:00
filipefurtad0
ccfb83d2cd
Splits build into 50 jobs
2022-11-21 10:02:14 +00:00
filipefurtad0
d6aa0168b2
Creates fork disabling on forks
...
Changes run job to use bash file
2022-11-21 10:02:14 +00:00
filipefurtad0
2a8ef5a45e
Updates build.yml to run the build the first time with knapsack_pro
2022-11-21 10:02:14 +00:00
filipefurtad0
c423641102
Adds knapsack_pro to the stack; updates configs
2022-11-21 10:02:14 +00:00
vviekk
22559a755f
Removing 'required' tag for 'Latitude / Longitude' for Enterprises
...
Empty/Null values are valid in db and for existing use-cases
2022-11-21 15:19:28 +05:30
dependabot[bot]
e877f94e07
Bump rubocop-rails from 2.17.2 to 2.17.3
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.2 to 2.17.3.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.2...v2.17.3 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-21 09:08:43 +00:00
dependabot[bot]
820fff0528
Bump bootsnap from 1.13.0 to 1.14.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.13.0...v1.14.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-21 09:04:43 +00:00
Jean-Baptiste Bellet
09bcc772ff
Remove useless line
...
Co-Authored-By: David Cook <david@redcliffs.net >
2022-11-21 09:49:06 +01:00
Jean-Baptiste Bellet
49e376f9b6
New design of the admin navigation menu!
2022-11-21 09:48:35 +01:00
Jean-Baptiste Bellet
85d3f5f9d7
Download OpenSans font also at 700 weight
...
needed in the navigation
2022-11-21 09:48:35 +01:00
Jean-Baptiste Bellet
9dd81604e9
Put navigation menu into span even if no icon next to it
2022-11-21 09:48:35 +01:00
Jean-Baptiste Bellet
61d3f79444
Add admin-v2 scss style file
2022-11-21 09:48:35 +01:00
Cillian O'Ruanaidh
b33d382069
Order BatchTaggableTagsQuery by name for consistency and to avoid flakey test failure
2022-11-18 15:05:03 +00:00
Cillian O'Ruanaidh
a8816b3788
Remove debugging code left in by accident
2022-11-18 14:40:30 +00:00
dependabot[bot]
204295dc91
Merge pull request #10013 from openfoodfoundation/dependabot/bundler/rswag-ui-2.8.0
2022-11-18 13:50:23 +00:00
dependabot[bot]
4ed71f1883
Merge pull request #10015 from openfoodfoundation/dependabot/bundler/rswag-api-2.8.0
2022-11-18 13:49:55 +00:00
jibees
92585b65c5
Merge pull request #10002 from heroinedor/fix/ofn-install-ci-unlock
...
unlock the ofn-install installation process
2022-11-18 11:38:43 +01:00
Pipo Bimbo
099f75befb
pg_stat_statement extension already installed with ofn-install -> https://github.com/openfoodfoundation/ofn-install/blob/master/roles/datadog/tasks/pg_stats.yml#L2
2022-11-18 10:44:02 +01:00
Pipo Bimbo
2eaf79b149
missing dependency for ofn-install process
2022-11-18 10:44:02 +01:00
Jean-Baptiste Bellet
60f0a58508
Add admin-v2 on admin body if admin_style_v2 feature toggled on
2022-11-18 09:46:05 +01:00
Mohamed ABDELLANI
688020a304
test filtering by distributor (orders_and_distributors_report_spec)
2022-11-18 08:55:16 +01:00
Mohamed ABDELLANI
4b1bd362e0
[skip ci] add hub filter to the Order and Distributors report
2022-11-18 07:29:08 +01:00
Jean-Baptiste Bellet
23f9c41fec
Update all locales with the latest Transifex translations
2022-11-17 17:58:42 +01:00
Konrad
8510379178
Merge pull request #9985 from binarygit/add-spinner-when-enterprise-sells-changes
...
[Admin][Enterprise Settings] Show spinner when enterprise sells option changes
2022-11-17 16:59:55 +01:00
dependabot[bot]
4b3465de78
Bump rswag-api from 2.7.0 to 2.8.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.7.0...2.8.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 10:21:18 +00:00
dependabot[bot]
415f12c1bc
Merge pull request #10012 from openfoodfoundation/dependabot/bundler/rswag-specs-2.8.0
2022-11-17 10:07:13 +00:00
dependabot[bot]
e3821df73a
Merge pull request #10011 from openfoodfoundation/dependabot/bundler/view_component-2.76.0
2022-11-17 10:06:48 +00:00
dependabot[bot]
b358468952
Bump stripe from 7.1.0 to 8.0.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 7.1.0 to 8.0.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v7.1.0...v8.0.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 09:03:39 +00:00
dependabot[bot]
c1c0a72184
Bump rswag-ui from 2.7.0 to 2.8.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.7.0...2.8.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 09:03:22 +00:00
dependabot[bot]
b5a93a9a88
Bump rswag-specs from 2.7.0 to 2.8.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.7.0...2.8.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 09:02:04 +00:00
dependabot[bot]
23cf18f9c4
Bump view_component from 2.75.0 to 2.76.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.75.0 to 2.76.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.75.0...v2.76.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 09:01:12 +00:00
Sigmund Petersen
5cef0e1939
Merge pull request #9946 from filipefurtad0/fixes_minor_build_issues
...
Fixes minor issues in the build
2022-11-16 18:22:24 +01:00
Sigmund Petersen
7243e49f92
Merge pull request #9958 from filipefurtad0/fix_flaky_taxonomy
...
Fix flaky taxonomy spec by asserting on page redirect and adding retry: 3
2022-11-16 14:59:29 +01:00
jibees
f58a187c9f
Merge pull request #9986 from openfoodfoundation/dependabot/bundler/cuprite-0.14.3
...
Bump cuprite from 0.13 to 0.14.3
2022-11-16 14:55:41 +01:00
filipefurtad0
d728424859
Asserts on page redirect, after Update click
2022-11-16 12:19:02 +00:00
Sigmund Petersen
52487a270d
Merge pull request #9889 from mkllnk/dfc-products
...
Activate DfcProvider with feature toggle, not prod
2022-11-16 12:26:44 +01:00
dependabot[bot]
d9772cbe01
Bump cuprite from 0.13 to 0.14.3
...
Bumps [cuprite](https://github.com/rubycdp/cuprite ) from 0.13 to 0.14.3.
- [Release notes](https://github.com/rubycdp/cuprite/releases )
- [Commits](https://github.com/rubycdp/cuprite/compare/v0.13...v0.14.3 )
---
updated-dependencies:
- dependency-name: cuprite
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-16 10:42:14 +00:00
Sigmund Petersen
1688bf09e3
Merge pull request #9988 from filipefurtad0/bump_cuprite-0.14.3
...
Cuprite bump: Updates helper to click on css element...
2022-11-16 11:41:09 +01:00
dependabot[bot]
53b1b5c062
Merge pull request #9995 from openfoodfoundation/dependabot/bundler/paranoia-2.6.1
2022-11-16 10:23:01 +00:00
filipefurtad0
c3ff1f78ce
Updates GETTING_STARTED.md
2022-11-16 09:56:51 +00:00
filipefurtad0
487e2e4316
Deletes unused specs.rake file
2022-11-16 09:56:51 +00:00
filipefurtad0
05cae1cdf3
Removes obsolete/failing performance specs
2022-11-16 09:56:51 +00:00
filipefurtad0
50e9819a2a
Fixes build.yml to replace rake task syntax
2022-11-16 09:56:51 +00:00
filipefurtad0
bb838e5a5a
Moves flatpickr spec into admin folder
2022-11-16 09:56:51 +00:00
dependabot[bot]
cf5414dbfd
Merge pull request #9987 from openfoodfoundation/dependabot/bundler/rubocop-1.39.0
2022-11-16 09:41:01 +00:00
dependabot[bot]
fd68f91996
Merge pull request #9961 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.6
2022-11-16 09:40:26 +00:00
dependabot[bot]
927e131e87
Merge pull request #9996 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.6
2022-11-16 09:25:20 +00:00
dependabot[bot]
3aa8a8510a
Merge pull request #9994 from openfoodfoundation/dependabot/npm_and_yarn/loader-utils-1.4.2
2022-11-16 09:09:36 +00:00
jibees
089c7b0011
Merge pull request #9940 from filipefurtad0/fix_developer_settings_spec
...
Clears Stripe settings after example run
2022-11-16 10:07:33 +01:00
dependabot[bot]
76d5abcf50
Bump @floating-ui/dom from 1.0.4 to 1.0.6
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.4 to 1.0.6.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.6/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-16 09:02:05 +00:00
dependabot[bot]
6b6c5c03d6
Bump paranoia from 2.6.0 to 2.6.1
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.0...v2.6.1 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-16 09:01:40 +00:00
dependabot[bot]
d9003aeccf
Bump loader-utils from 1.4.1 to 1.4.2
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-16 07:51:33 +00:00
filipefurtad0
1a3c4008fd
Applies helpers to relevant specs
2022-11-15 19:03:14 +00:00
filipefurtad0
4b067e2ece
Creates separate helpers for enabling Stripe and keys
2022-11-15 19:03:14 +00:00
Filipe
94db55dd43
Merge pull request #9993 from openfoodfoundation/revert-9926-cache-address
...
Revert "Cache address JSON to avoid database queries"
2022-11-15 10:18:51 +00:00
jibees
6dcc50ad15
Revert "Cache address JSON to avoid database queries"
2022-11-15 10:40:22 +01:00
filipefurtad0
760635da1f
Updates helper to click on css element...
...
...instead of passing empty_keys
2022-11-14 12:23:53 +00:00
dependabot[bot]
11480f20c5
Bump rubocop from 1.38.0 to 1.39.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.38.0...v1.39.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-14 09:05:05 +00:00
jibees
911d816233
Merge pull request #9979 from filipefurtad0/fix_flaky_bom_3
...
[Flaky BOM] Bumps retry: 2 -> 3
2022-11-14 09:21:17 +01:00
binarygit
8fc721c651
[Admin, Enterprise Settings] Show spinner when enterprise sells changes
2022-11-13 16:24:35 +05:45
Konrad
c2d5ea4a5a
Merge pull request #9942 from mkllnk/taxonomies-spec
...
Avoid image load error and show errors in spec
2022-11-12 20:30:04 +01:00
Konrad
59d555165f
Merge pull request #9936 from dacook/minor-admin-updates
...
Code cleanup: admin interface
2022-11-12 19:43:44 +01:00
Konrad
2eca3d5ef8
Merge pull request #9914 from openfoodfoundation/dependabot/bundler/spreadsheet_architect-5.0.0
...
Bump spreadsheet_architect from 4.2.0 to 5.0.0
2022-11-11 22:49:17 +01:00
Konrad
5fc17b51d2
Merge pull request #9887 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.117.1
...
Bump aws-sdk-s3 from 1.117.0 to 1.117.1
2022-11-11 21:15:58 +01:00
Konrad
c6178f5df9
Merge pull request #9877 from mkllnk/ignored-columns
...
Remove outdated ignoring of Paperclip columns
2022-11-11 21:08:42 +01:00
Cillian O'Ruanaidh
fbe6dcba7a
Remove N+1 query loading tags for each order cycle exchange
2022-11-11 17:01:46 +00:00
Sigmund Petersen
bd718406f4
Merge pull request #9980 from openfoodfoundation/filipefurtad0-add-knapsackpro-badge-to-readme
...
Adds KnapsackPro badge to enable unlimited plan use
2022-11-11 13:20:58 +01:00
Filipe
ca4d92bf99
Adds KnapsackPro badge to enable KnapsackPro use
...
As requested per email: "Please add the Knapsack Pro badge to your open source project readme"
2022-11-11 11:46:24 +00:00
filipefurtad0
2f7cb4d3ca
Bumps retry: 2 -> 3
2022-11-11 10:51:11 +00:00
David Cook
1e24988bd1
Remove label from bug report template
...
I accidentally added it last week.
2022-11-11 09:31:08 +11:00
Konrad
c44195c8a0
Merge pull request #9911 from viniciusueharaweb/9781-improve-shipping-category-not-found-error-message
...
[Product Import] Wrong error message when shipping category does not match predefined shipping categories
2022-11-10 22:48:25 +01:00
Konrad
5b44dc9609
Corrected missspelling of 'mispelling' in en.yml
2022-11-10 20:53:30 +01:00
Jean-Baptiste Bellet
dff9c6d333
Update all locales with the latest Transifex translations
2022-11-10 20:39:17 +01:00
Filipe
4b3184a6ef
Merge pull request #9923 from mkllnk/cache-country
...
Cache default country for an hour
2022-11-10 19:10:29 +00:00
Filipe
f1dd69a4f7
Merge pull request #9926 from mkllnk/cache-address
...
Cache address JSON to avoid database queries
2022-11-10 18:18:03 +00:00
Filipe
24eda1bfae
Merge pull request #9927 from mkllnk/lazy-load-product-images
...
Load product images in the shop lazily to improve performance
2022-11-10 18:11:56 +00:00
Konrad
ae09f7a415
Merge pull request #9869 from abdellani/fix-unit_value_with_description-calculation-on-products-page_admin_dashboard
...
use js-big-decimal to calculate unit_value_with_description in products page
2022-11-10 18:47:16 +01:00
dependabot[bot]
d8d1b38a4d
Merge pull request #9967 from openfoodfoundation/dependabot/npm_and_yarn/socket.io-parser-4.0.5
2022-11-10 10:09:27 +00:00
Filipe
a7353eb69f
Merge pull request #9575 from apricot12/9487-Dimensions-Packing-Reports
...
Added HEIGHT, WEIGHT, WIDTH, DEPTH columns to packing reports by customer.
2022-11-10 09:55:26 +00:00
jibees
8a702daccd
Merge pull request #9966 from filipefurtad0/fix_flaky_spec_9902_2
...
Increases retry option from 2 to 3
2022-11-10 10:05:05 +01:00
jibees
f4de39ae00
Merge pull request #9965 from filipefurtad0/adds_retry_to_BOM_spec
...
Adds retry option to flaky BOM spec
2022-11-10 10:04:33 +01:00
Jean-Baptiste Bellet
4f265eed2a
Check that target exists before setting properties
...
In case of Xero reports, there are no checkbox
2022-11-10 09:55:36 +01:00
Jean-Baptiste Bellet
bdf132a833
Format file according to our prettier configuration
2022-11-10 09:49:28 +01:00
dependabot[bot]
177e3d5885
Bump socket.io-parser from 4.0.4 to 4.0.5
...
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser ) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases )
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md )
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.0.4...4.0.5 )
---
updated-dependencies:
- dependency-name: socket.io-parser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-09 22:15:43 +00:00
Filipe
b7fcc0b4fc
Merge pull request #9924 from jibees/9757-BOM-show-only-one-modal-when-changing-date-range-
...
BOM: Display confirm modal on date range change only one time
2022-11-09 18:42:28 +00:00
filipefurtad0
86d38bbaa5
Increases retry option from 2 to 3
2022-11-09 17:19:13 +00:00
filipefurtad0
36bc17c8b4
Adds retry option to flaky examples
2022-11-09 16:36:36 +00:00
dependabot[bot]
7c7e5aaa59
Bump rails-i18n from 7.0.5 to 7.0.6
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/svenfuchs/rails-i18n/releases )
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-09 09:01:46 +00:00
Konrad
b22beea5fc
Merge pull request #9945 from jibees/9944-translate-columns-in-packing-and-xero-reports
...
Packing reports: translate columns name in the columns selector component
2022-11-09 09:55:21 +01:00
Jean-Baptiste Bellet
262b546836
Add some visual spacing
2022-11-08 14:59:23 +01:00
Jean-Baptiste Bellet
4bfd39caec
The info tip indicates image should be 100*100, so display it at 100*100 size
2022-11-08 14:54:47 +01:00
Jean-Baptiste Bellet
58c8eae08c
Enterprise logo: resize and crop at the center of image instead of just resize
...
Should fit in a square format
2022-11-08 14:54:11 +01:00
dependabot[bot]
2c17a2bafe
Merge pull request #9952 from openfoodfoundation/dependabot/npm_and_yarn/babel-loader-8.3.0
2022-11-08 09:35:27 +00:00
dependabot[bot]
c25375f00a
Merge pull request #9951 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.20.2
2022-11-08 09:34:45 +00:00
dependabot[bot]
7322362eea
Merge pull request #9949 from openfoodfoundation/dependabot/bundler/capybara-3.38.0
2022-11-08 09:34:21 +00:00
dependabot[bot]
94b14d16bf
Merge pull request #9950 from openfoodfoundation/dependabot/npm_and_yarn/husky-8.0.2
2022-11-08 09:33:39 +00:00
dependabot[bot]
116764166c
Merge pull request #9954 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.8
2022-11-08 09:33:21 +00:00
dependabot[bot]
de807b1ee0
Merge pull request #9948 from openfoodfoundation/dependabot/npm_and_yarn/loader-utils-1.4.1
2022-11-08 09:32:05 +00:00
Mohamed ABDELLANI
70e47f3929
fix: convert @attrs[:units] to big decimal instead of float in the unit converter
2022-11-08 10:26:00 +01:00
Mohamed ABDELLANI
b203803eb9
fix test: change product_unit_value_with_description value to float (2 digits precision)
2022-11-08 10:26:00 +01:00
Mohamed ABDELLANI
44d719fcb5
use js-big-decimal to calculate unit_value_with_description
2022-11-08 10:26:00 +01:00
Jean-Baptiste Bellet
cb1b24695e
Fix deprecation warnings around class loading during initialization
...
```
Fix deprecation warnings around class loading during initialization
Thi2022-11-08T08:54:57.542Z pid=40093 tid=nl9 WARN: DEPRECATION WARNING: Initialization autoloaded the constants ReportsHelper, DateTimeStringValidator et IntegerArrayValidator.
Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.
Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload ReportsHelper, for example,
the expected changes won't be reflected in that stale Module object.
These autoloaded constants have been unloaded.
In order to autoload safely at boot time, please wrap your code in a reloader
callback this way:
Rails.application.reloader.to_prepare do
# Autoload classes and modules needed at boot time here.
end
That block runs when the application boots, and every time there is a reload.
For historical reasons, it may run twice, so it has to be idempotent.
Check the "Autoloading and Reloading Constants" guide to learn more about how
Rails autoloads and reloads.
```
2022-11-08 10:07:29 +01:00
dependabot[bot]
2a8731c8da
Bump sidekiq from 6.5.7 to 6.5.8
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.5.7 to 6.5.8.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.5.7...v6.5.8 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 09:04:23 +00:00
dependabot[bot]
ed81ce8ada
Bump babel-loader from 8.2.5 to 8.3.0
...
Bumps [babel-loader](https://github.com/babel/babel-loader ) from 8.2.5 to 8.3.0.
- [Release notes](https://github.com/babel/babel-loader/releases )
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.5...v8.3.0 )
---
updated-dependencies:
- dependency-name: babel-loader
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 09:03:02 +00:00
dependabot[bot]
1c0132ca4d
Bump @babel/preset-env from 7.19.4 to 7.20.2
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.19.4 to 7.20.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.20.2/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 09:02:37 +00:00
dependabot[bot]
c1cd524157
Bump husky from 8.0.1 to 8.0.2
...
Bumps [husky](https://github.com/typicode/husky ) from 8.0.1 to 8.0.2.
- [Release notes](https://github.com/typicode/husky/releases )
- [Commits](https://github.com/typicode/husky/compare/v8.0.1...v8.0.2 )
---
updated-dependencies:
- dependency-name: husky
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 09:02:01 +00:00
dependabot[bot]
2198f12922
Bump capybara from 3.37.1 to 3.38.0
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.37.1 to 3.38.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.37.1...3.38.0 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 09:01:35 +00:00
dependabot[bot]
d86498c81e
Bump loader-utils from 1.4.0 to 1.4.1
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-08 08:36:50 +00:00
Jean-Baptiste Bellet
3e9647590d
Packing report don't need untranslated headers for xlxs, csv format
2022-11-07 15:53:39 +01:00
Jean-Baptiste Bellet
f4572cb8cb
nil is the value of :report_format when GETting a report page
...
This method is used in `custom_headers()` method that handle headers customization. Then, it's `@report.available_headers`
2022-11-07 11:44:01 +01:00
Maikel Linke
122fe8253e
Avoid image load error and show errors in spec
...
I stumbled across some spec code which was hiding an unexpected error. So I
fixed it properly. This code is to be replaced soon anyway and this is a tiny
step in that direction.
2022-11-07 16:07:41 +11:00
Maikel
85017893d3
Merge pull request #9939 from jibees/fix-flatpickr-system-spec
...
Fix flatpickr system spec: `spec/system/flatpickr_spec.rb`
2022-11-07 15:37:57 +11:00
Maikel
35a8f6be74
Merge pull request #9935 from dacook/update-transifex
...
Update Transifex config format for latest version
2022-11-07 15:28:08 +11:00
Jean-Baptiste Bellet
9464f49031
Fix flatpickr system spec
...
On `/admin/orders`, we now have a date range picker.
This spec seems to test only the behavior of flatpickr, which is an external dependencies ; we probably shouldn't test it since it's not our responsibilities. Leave the spec as it for now.
2022-11-04 15:29:36 +01:00
Jean-Baptiste Bellet
39e5613db8
When confirm modal is dismissed, reset daterange picker to previous values
...
+ update specs as well
2022-11-04 14:18:29 +01:00
David Cook
20c0449128
Remove unnecessary case
...
Seems cleaner to me.
Best viewed with whitespace ignored.
2022-11-04 14:26:41 +11:00
David Cook
5405d6f525
Ensure all text inputs have full width
...
I think `url` and `tel` are currently unused, but I think we should use them in the future.
2022-11-04 14:26:39 +11:00
David Cook
9ef07cb110
Update GETTING_STARTED.md
...
[doc] Link to info about loading sample data
[skip ci]
2022-11-04 14:20:48 +11:00
David Cook
8d49ad9d18
Update Transifex config for APIv3
...
I installed the latest version of the CLI client (1.4.1), and the old config no longer worked. This config contains:
- o: organisation
- p: project
- r: resource
You may need to upgrade your installation:
tx update
2022-11-04 09:46:11 +11:00
Jean-Baptiste Bellet
228e484f02
Flatpicker instance can now handle flatpickr:change event
...
With:
```
detail: {
startDate: "2022-10-02",
endDate: "2022-10-10"
}
```
2022-11-03 16:57:03 +01:00
Jean-Baptiste Bellet
66a684920a
allSaved() method from LineItems needs to be spy
2022-11-03 15:55:48 +01:00
Jean-Baptiste Bellet
1a241e4953
Only call confirmRefresh() on time, on date range change
...
Previously, when changing the date range, we had several modals that opened.
Now, the `confirmRefresh()` method should be open only one time.
Update specs as well:
- use the method `accept_confirm`
- Removing pending and sleep as the spec is now green
2022-11-03 15:55:48 +01:00
dependabot[bot]
74529cd595
Merge pull request #9930 from openfoodfoundation/dependabot/bundler/view_component-2.75.0
2022-11-03 13:50:27 +00:00
jibees
d69c2f8314
Merge pull request #9931 from filipefurtad0/fix_flaky_spec_9805_4
...
Sets retry: 3 on flaky example
2022-11-03 14:46:39 +01:00
jibees
3f00e523d3
Merge pull request #9932 from filipefurtad0/fix_flaky_bom_2
...
Sets retry: 3 for BOM spec
2022-11-03 14:45:51 +01:00
filipefurtad0
c10f5ce5df
Sets retry: 3 for BOM spec
2022-11-03 13:13:42 +00:00
filipefurtad0
6bf332ef20
Sets retry: 3 on flaky example
2022-11-03 12:48:22 +00:00
dependabot[bot]
ef27e4f241
Bump view_component from 2.74.1 to 2.75.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.74.1 to 2.75.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.74.1...v2.75.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-03 09:03:30 +00:00
David Cook
af2c185f9f
Update release issue template
...
Fix link 😳
2022-11-03 17:59:46 +11:00
David Cook
d7558a9aea
Update release issue template
...
Add link to slack channel
2022-11-03 17:55:17 +11:00
David Cook
076244ee1c
Update translations
2022-11-03 17:30:01 +11:00
Maikel
2e2488a25e
Make Github expand the issue title on pull request
2022-11-03 14:11:51 +11:00
Maikel Linke
762beb7c1c
Load product images in the shop lazily
...
The browser decides when to load the image, usually when it's close to
the viewport.
2022-11-03 14:02:01 +11:00
Maikel Linke
118c1f7cbd
Cache address JSON to avoid database queries
...
We found that our database is quite busy querying the country all the
time. One source of these queries is the shop front which serializes
enterprises including their addresses. But addresses should be safe to
cache because:
- country records never change
- state records never change
- updating any other attribute changes the cache key
The caching was previously removed when the state_name attribute was
added. That is technically correct because it's possible to change a
state's name without updating the address. Then the cache would be out
of date. But we never update state names. And if we did, we would need
to invalidate the cache now.
2022-11-03 13:07:59 +11:00
Maikel Linke
8009b37723
Spec the AddressSerializer before changing it
2022-11-03 13:01:02 +11:00
dependabot[bot]
bf950d7c69
Merge pull request #9922 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.1.1
2022-11-02 07:42:12 +00:00
Maikel Linke
a2c4242994
Simplify Address code
...
The DefaultCountry code has a fallback already.
2022-11-02 16:21:15 +11:00
Maikel Linke
392aeb7321
Remove unused method loading default country
...
And another unused method.
2022-11-02 16:21:15 +11:00
Maikel Linke
f971131888
Cache default country for an hour
...
The default country usually never changes after the initial setup of an
instance.
2022-11-02 15:33:43 +11:00
Maikel
257959448a
Merge pull request #9921 from openfoodfoundation/dependabot/bundler/rubocop-1.38.0
...
Bump rubocop from 1.37.1 to 1.38.0
2022-11-02 13:00:57 +11:00
Maikel
ba4e7e440d
Merge pull request #9896 from jibees/improve-reliability-of-specs
...
Flaky ; Add a `retry` on spec
2022-11-02 11:25:16 +11:00
Maikel
cb83069101
Merge pull request #9920 from filipefurtad0/webmock_do_not_always_require
...
Disables default loading of webmock and some seldom used gems
2022-11-02 11:10:05 +11:00
Maikel
456355da79
Merge pull request #9893 from jibees/small-improvments-on-script/rspec-slow-repeat-file
...
Small improvements on `script/rspec-slow-repeat` file
2022-11-02 11:01:04 +11:00
dependabot[bot]
2dc3c472c1
Bump stimulus from 3.1.0 to 3.1.1
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-01 09:30:31 +00:00
dependabot[bot]
dfec0c3caf
Bump rubocop from 1.37.1 to 1.38.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.37.1 to 1.38.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.37.1...v1.38.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-01 09:30:16 +00:00
filipefurtad0
73596308ab
Disables default loading of some other seldom used gems
2022-10-31 22:10:58 +00:00
filipefurtad0
b736db0d7b
Disables default loading of webmock gem
2022-10-31 22:07:07 +00:00
Jean-Baptiste Bellet
3ff1cd0793
Prefer to killall descendants instead of just killing yes processes
2022-10-31 16:11:32 +01:00
Jean-Baptiste Bellet
b93f6dfdad
Add convenient logging when failing
2022-10-31 16:11:32 +01:00
Jean-Baptiste Bellet
9ba0695652
Trap CTRL+C to exit all yes commands
2022-10-31 16:11:31 +01:00
Jean-Baptiste Bellet
df42a88150
Retry specs as couldn't make it reliable
2022-10-31 15:34:04 +01:00
dependabot[bot]
8b73660d75
Merge pull request #9915 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.4
2022-10-31 10:11:54 +00:00
dependabot[bot]
f214c1f14f
Merge pull request #9916 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.3
2022-10-31 09:41:02 +00:00
Jean-Baptiste Bellet
0eff4d3906
Add some comment on the purpose
2022-10-31 10:19:36 +01:00
Jean-Baptiste Bellet
84831266f1
Remove useless information
2022-10-31 10:19:14 +01:00
dependabot[bot]
5e1d4892b1
Bump active_storage_validations from 1.0.2 to 1.0.3
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.2...1.0.3 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-31 09:05:49 +00:00
dependabot[bot]
7260bf1041
Bump @floating-ui/dom from 1.0.3 to 1.0.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-31 09:04:17 +00:00
dependabot[bot]
ded0604d18
Bump spreadsheet_architect from 4.2.0 to 5.0.0
...
Bumps [spreadsheet_architect](https://github.com/westonganger/spreadsheet_architect ) from 4.2.0 to 5.0.0.
- [Release notes](https://github.com/westonganger/spreadsheet_architect/releases )
- [Changelog](https://github.com/westonganger/spreadsheet_architect/blob/master/CHANGELOG.md )
- [Commits](https://github.com/westonganger/spreadsheet_architect/compare/v4.2.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: spreadsheet_architect
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-31 09:03:40 +00:00
Maikel
01a907de9f
Merge pull request #9907 from filipefurtad0/fix_flaky_spec_9805_2
...
Adds retry: 2 option
2022-10-31 11:46:53 +11:00
Maikel
5e0a08d99b
Merge pull request #9906 from filipefurtad0/fix_flaky_spec_9902
...
Wraps success message around within block; adds retry option
2022-10-31 11:45:49 +11:00
Vinicius Uehara
6da442eb97
Fix trailing whitespace
2022-10-30 21:42:48 -03:00
Maikel
7b5debb76b
Merge pull request #9904 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.3.12
...
Bump js-big-decimal from 1.3.10 to 1.3.12
2022-10-31 11:41:46 +11:00
Vinicius Uehara
f6cc9fca26
Prioritize attribute errors over product validations
...
With product validations being prioritized, custom and
insightful error messages were being overwriten by
general and ambiguous model validations, which
were confusing users
2022-10-30 20:02:08 -03:00
Vinicius Uehara
1f498e6052
Improve shipping category not found error message
2022-10-30 20:02:05 -03:00
filipefurtad0
32fb898962
Adds retry: 2 option
2022-10-28 18:32:21 +01:00
filipefurtad0
df8fd88682
Wraps success message around within block; adds retry option
2022-10-28 18:03:45 +01:00
Konrad
68b2e48fb3
Merge pull request #9900 from ijdershem/idersh/issue-9845
...
[9845] Make checkout terms and conditions label clickable
2022-10-28 14:28:06 +02:00
Konrad
0202bb40cf
Merge pull request #9827 from saunmanoj888/fix-vairant-unit-decimal-issue
...
Fix unit description UI issue on updating a Product having imperial weight (oz)
2022-10-28 13:52:00 +02:00
Filipe
f7c62dfe45
Merge pull request #9862 from drummer83/master
...
Format reports as list, even if only one sub-type available
2022-10-28 12:13:42 +01:00
Konrad
1c185c2ca4
Merge pull request #9823 from abdellani/fix-product-duplication
...
Fix product duplication
2022-10-28 12:51:01 +02:00
dependabot[bot]
883f01e3e6
Bump js-big-decimal from 1.3.10 to 1.3.12
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.10 to 1.3.12.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.10...v1.3.12 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-28 09:04:17 +00:00
jibees
8ccc88d770
Merge pull request #9897 from filipefurtad0/fix_flaky_spec_9805
...
Wraps expectation on within block
2022-10-28 10:47:04 +02:00
jibees
133512e4f4
Merge pull request #9898 from filipefurtad0/fix_flaky_spec_9894
...
Changes click method making it overlap-safe
2022-10-28 10:45:52 +02:00
dependabot[bot]
86b4570fc2
Merge pull request #9901 from openfoodfoundation/dependabot/bundler/test-prof-1.0.11
2022-10-28 07:45:14 +00:00
dependabot[bot]
3c996fdfb3
Bump test-prof from 1.0.10 to 1.0.11
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.10 to 1.0.11.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.10...v1.0.11 )
---
updated-dependencies:
- dependency-name: test-prof
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-28 07:02:29 +00:00
dependabot[bot]
8048dc2c8b
Merge pull request #9891 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.17.2
2022-10-28 07:01:20 +00:00
ijdershem-jf
0f9f4b07a8
[9845] Make checkout terms and conditions label clickable; associate label with input using correct for attribute
2022-10-27 20:30:42 -06:00
filipefurtad0
a6fdefff08
Changes click method making it overlap-safe
2022-10-27 21:25:45 +01:00
filipefurtad0
6a28918654
Wraps expectation on within block
2022-10-27 19:15:08 +01:00
Konrad
d544233bac
Merge pull request #9780 from jibees/9777-select-the-right-country
...
Admin, Enterprise Details: Fix country selection on business address panel
2022-10-27 14:32:52 +02:00
dependabot[bot]
d577d60de6
Bump rubocop-rails from 2.17.1 to 2.17.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.1 to 2.17.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.1...v2.17.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-27 10:26:01 +00:00
Sigmund Petersen
473a35f330
Merge pull request #9892 from filipefurtad0/dependabot_exclude_push_from_build_double
...
Excludes build triggers using /** syntax for branch pushes
2022-10-27 12:24:40 +02:00
filipefurtad0
2fd8ffa413
Excludes build triggers using /** syntax for branch pushes
2022-10-27 11:00:39 +01:00
Jean-Baptiste Bellet
bbf400a83b
/proc/cpuinfo is not available on Darwin arch (ie. mac)
2022-10-27 11:19:55 +02:00
Maikel Linke
56667f6142
Simplify test setup with enabled features
...
If a feature is activated or not depends on the database which is reset
after each test scenario. So enabling a feature doesn't leak into other
scenarios.
Just enabling the feature is less code and more realistic than mocking a
method call.
2022-10-27 15:32:05 +11:00
Maikel Linke
f9246f1917
Remove unused/broken feature toggle helper
2022-10-27 15:25:33 +11:00
Maikel Linke
36c44a5487
Allow FeatureToggleConstraint to run w/o warden
...
Routing specs and controller specs don't set warden on the request
environment. While we could try to re-implement Warden/Devise logic
here, it's much easier to not rely on the environment to be set.
While I'm usually opposed to changing production code to make testing
easier, it does avoid a lot of complication in this case. And maybe it
would be handy in other circumstances to have a more defensive approach
to checking the logged in user.
2022-10-27 15:07:04 +11:00
Maikel Linke
d1cd1fdefe
Update translations
2022-10-27 11:00:42 +11:00
Maikel
df868d88d8
Merge pull request #9883 from filipefurtad0/dependabot_exclude_push_from_build
...
Adds ignore tag for pull_request dependabot branches
2022-10-27 10:45:04 +11:00
Maikel
da61fdbc2c
Merge pull request #9881 from openfoodfoundation/dependabot/bundler/pdf-reader-2.11.0
...
Bump pdf-reader from 2.10.0 to 2.11.0
2022-10-27 10:34:54 +11:00
dependabot[bot]
a07b72c3c9
Bump aws-sdk-s3 from 1.117.0 to 1.117.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.117.0 to 1.117.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-26 22:55:37 +00:00
Maikel
54b0554bb4
Merge pull request #9831 from filipefurtad0/fix_flaky_spec_bom_9811
...
Brings back rspec_retry; Creates helper method for flaky spec #9811
2022-10-27 09:52:43 +11:00
Rachel Arnould
2652bc086a
Merge pull request #9755 from cillian/order-cycle-payment-methods
...
Let people choose which payment methods are available to customers on order cycles
2022-10-26 20:10:34 +02:00
filipefurtad0
f72e040a4d
Adds ignore tag for pull_request dependabot branches
2022-10-26 13:58:28 +01:00
dependabot[bot]
1546619718
Bump pdf-reader from 2.10.0 to 2.11.0
...
Bumps [pdf-reader](https://github.com/yob/pdf-reader ) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/yob/pdf-reader/releases )
- [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG )
- [Commits](https://github.com/yob/pdf-reader/compare/v2.10.0...v2.11.0 )
---
updated-dependencies:
- dependency-name: pdf-reader
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-26 12:40:42 +00:00
dependabot[bot]
1c17c37915
Merge pull request #9879 from openfoodfoundation/dependabot/bundler/oauth2-1.4.11
2022-10-26 12:39:20 +00:00
dependabot[bot]
063e424bc0
Merge pull request #9878 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.117.0
2022-10-26 12:36:25 +00:00
filipefurtad0
b53faceebb
Retries improved but still flaky examples
2022-10-26 13:26:21 +01:00
filipefurtad0
aebf84b53f
Brings back rspec-retry gem and configs
2022-10-26 13:26:21 +01:00
dependabot[bot]
9ce1c536e4
Merge pull request #9880 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.17.1
2022-10-26 09:50:48 +00:00
Jean-Baptiste Bellet
edb2645af1
Add a country to test db and modify one spec
...
Check that businness address changes are ok
Test with another county since only one country and one state couldn't spot the fact that when changing country it needs to change also states selector
2022-10-26 11:21:44 +02:00
Jean-Baptiste Bellet
d797ef2b3a
As we are in the Business Address panel, use the business_address attr
...
Not the address one, which is different
Business address country could be null, so use an empty array
2022-10-26 11:21:44 +02:00
Jean-Baptiste Bellet
d46105ea90
Correct some input styling
2022-10-26 11:21:44 +02:00
Jean-Baptiste Bellet
151e71b4d9
Actually controller is named dependEnt-select
2022-10-26 11:21:44 +02:00
Jean-Baptiste Bellet
b6bc4c66a2
Specify the current value of country
2022-10-26 11:21:44 +02:00
dependabot[bot]
b8b50fa165
Bump rubocop-rails from 2.16.1 to 2.17.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.16.1 to 2.17.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.16.1...v2.17.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-26 09:06:16 +00:00
dependabot[bot]
4d23113265
Bump oauth2 from 1.4.10 to 1.4.11
...
Bumps [oauth2](https://gitlab.com/oauth-xx/oauth2 ) from 1.4.10 to 1.4.11.
- [Release notes](https://gitlab.com/oauth-xx/oauth2/tags )
- [Changelog](https://gitlab.com/oauth-xx/oauth2/blob/main/CHANGELOG.md )
- [Commits](https://gitlab.com/oauth-xx/oauth2/compare/v1.4.10...v1.4.11 )
---
updated-dependencies:
- dependency-name: oauth2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-26 09:04:45 +00:00
dependabot[bot]
f909b742ce
Bump aws-sdk-s3 from 1.116.0 to 1.117.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.116.0 to 1.117.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-26 09:04:18 +00:00
Maikel Linke
6aefc23c35
Allow devs to lazy-load app with right dependency
2022-10-26 14:08:27 +11:00
Maikel Linke
7c562d321d
Activate DfcProvider with feature toggle, not prod
...
We want to test in dev and on staging, too.
2022-10-26 14:08:27 +11:00
Maikel
5a4727138c
Merge pull request #9875 from filipefurtad0/fix_flaky_spec_8701
...
Minor changes to improve flakyness
2022-10-26 14:00:08 +11:00
Maikel
fe05d17078
Merge pull request #9872 from jibees/update-actions/upload-artifact-to-lastest-version
...
Build: use the latest version of `actions/upload-artifact`
2022-10-26 13:58:48 +11:00
Maikel Linke
9f9d8020c1
Fix URL generation for report without subtype
...
The URL is generated in the partial and it just needs to know that
there's no subtype.
2022-10-26 11:53:25 +11:00
Maikel Linke
3ebd896c3e
Remove outdated ignoring of columns
...
Those columns have been removed from the database and don't need to be
ignored any more.
2022-10-26 10:42:19 +11:00
filipefurtad0
14955ac8ca
Minor changes to improve flakyness
2022-10-25 17:39:10 +01:00
dependabot[bot]
06c6853323
Merge pull request #9856 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.5.13
2022-10-25 14:08:01 +00:00
dependabot[bot]
4e0b206c7b
Merge pull request #9857 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.5.13
2022-10-25 13:59:39 +00:00
Konrad
3d003a735f
Merge pull request #9851 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.116.0
...
Bump aws-sdk-s3 from 1.114.0 to 1.116.0
2022-10-25 15:52:34 +02:00
Jean-Baptiste Bellet
e16c8661a2
Use the same template even if there is no sub_report
2022-10-25 15:27:43 +02:00
dependabot[bot]
eaa6e9bc18
Bump @storybook/addon-docs from 6.5.12 to 6.5.13
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.5.12 to 6.5.13.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.13/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.13/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 13:20:15 +00:00
dependabot[bot]
91652ba792
Bump @storybook/addon-controls from 6.5.12 to 6.5.13
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.5.12 to 6.5.13.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.13/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.13/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 13:19:28 +00:00
dependabot[bot]
4bf640f0c4
Merge pull request #9866 from openfoodfoundation/dependabot/bundler/rubocop-1.37.1
2022-10-25 13:18:51 +00:00
jibees
cf489e809f
Merge pull request #9867 from openfoodfoundation/dependabot/bundler/rswag-specs-2.7.0
...
Bump rswag-specs from 2.6.0 to 2.7.0
2022-10-25 15:18:18 +02:00
jibees
35bb539271
Merge pull request #9855 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.2.4
...
Bump @hotwired/turbo from 7.2.2 to 7.2.4
2022-10-25 15:17:25 +02:00
jibees
b3020a5573
Merge pull request #9854 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.3
...
Bump @floating-ui/dom from 1.0.2 to 1.0.3
2022-10-25 15:17:05 +02:00
jibees
250b9bc3c0
Merge pull request #9853 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.5.13
...
Bump @storybook/server from 6.5.12 to 6.5.13
2022-10-25 15:16:30 +02:00
Jean-Baptiste Bellet
e58add6af0
Use the latest version of actions/upload-artifact
2022-10-25 15:00:14 +02:00
filipefurtad0
3447959a06
Adds click_on_select2 helper
2022-10-25 13:32:29 +01:00
Mohamed ABDELLANI
41440af533
test if product's variant is duplicated properly
2022-10-25 11:28:16 +01:00
Mohamed ABDELLANI
826b1e95ef
add a product variant.
2022-10-25 11:27:51 +01:00
Mohamed ABDELLANI
6cabbee1a2
rename new_variant double to new_master_variant
2022-10-25 11:27:14 +01:00
Mohamed ABDELLANI
11bc5c775c
rename the variant double to master_variant
2022-10-25 11:26:43 +01:00
Mohamed ABDELLANI
788093c7cf
implement variant duplication
2022-10-25 11:23:35 +01:00
Mohamed ABDELLANI
f44228eef7
extract variant duplication logic into a separated function
2022-10-25 11:23:35 +01:00
Konrad
62935f65a2
Merge pull request #9849 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.2
...
Bump active_storage_validations from 1.0.0 to 1.0.2
2022-10-25 12:04:50 +02:00
Konrad
e8425c5805
Merge pull request #9792 from vsmay98/6531-remove-user-registrations-controller
...
Remove spree user registrations controller file
2022-10-25 11:52:34 +02:00
dependabot[bot]
31cde7e06e
Bump @hotwired/turbo from 7.2.2 to 7.2.4
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.2.2 to 7.2.4.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.2.2...v7.2.4 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 09:31:08 +00:00
dependabot[bot]
f467efc42b
Bump @storybook/server from 6.5.12 to 6.5.13
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.5.12 to 6.5.13.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.13/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.13/app/server )
---
updated-dependencies:
- dependency-name: "@storybook/server"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 09:30:49 +00:00
dependabot[bot]
faa8888e2a
Bump @floating-ui/dom from 1.0.2 to 1.0.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 09:30:47 +00:00
jibees
84f488917e
Merge pull request #9865 from jibees/sort-package.json-file
...
Sort package.json to avoid conflicts
2022-10-25 11:29:41 +02:00
dependabot[bot]
00c57fa06c
Bump rswag-specs from 2.6.0 to 2.7.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.6.0...2.7.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 09:03:31 +00:00
dependabot[bot]
c4748104a0
Bump rubocop from 1.36.0 to 1.37.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.36.0 to 1.37.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.36.0...v1.37.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-25 09:02:59 +00:00
Jean-Baptiste Bellet
46bbf1b1ec
Sort package.json to avoid conflicts
2022-10-25 10:54:11 +02:00
Konrad
d12e99e363
Merge pull request #9808 from abdellani/sort_items_by_product_name_in_ocstd_report
...
add sort by product name to order_cycle_supplier_totals_by_distributo…
2022-10-25 10:34:22 +02:00
Jean-Baptiste Bellet
ede38a417f
Respect rubocop Metrics/AbcSize by extracting a method
2022-10-25 10:22:35 +02:00
Jean-Baptiste Bellet
23b5e73c97
Weight is computed with unit_value and product variant_unit_scale
2022-10-25 10:22:35 +02:00
Maikel Linke
7081e712e8
Flag style issue on todo list for later
...
The code needs some bigger refactoring to avoid this style issue.
2022-10-25 10:09:26 +02:00
Nihal Mohammed
5c0f3a2d4b
Add weight, height, width, depth fields to pack by customer reports
...
+ update specs by adding dimensions fields into reports specs
2022-10-25 10:09:26 +02:00
Nihal Mohammed
f8657aaf41
Copy dimensions from variants to line items before validation
2022-10-25 10:09:26 +02:00
Nihal Mohammed
f38661cdf1
Add weight, height, width, depth fields to line items
2022-10-25 10:09:26 +02:00
Maikel
85c8a0ac35
Merge pull request #9852 from openfoodfoundation/dependabot/bundler/rswag-api-2.7.0
...
Bump rswag-api from 2.6.0 to 2.7.0
2022-10-25 14:33:04 +11:00
Maikel
0e9869c4d3
Merge pull request #9848 from openfoodfoundation/dependabot/bundler/debug-1.6.3
...
Bump debug from 1.6.2 to 1.6.3
2022-10-25 14:02:17 +11:00
Maikel
a3416bcb80
Merge pull request #9790 from matisnape/update-docker-readme-for-m1-users-#8421
...
Update docker readme for M1 users [#8421 ]
2022-10-25 11:12:09 +11:00
Maikel
bf206dc4e6
Merge pull request #9858 from jibees/setup-redis-for-build
...
Setup redis on build
2022-10-25 11:11:08 +11:00
Maikel
55ef4dfe0d
Merge pull request #8809 from Matt-Yorkley/dead-code-variants-check
...
Remove dead code: Product#variants?
2022-10-25 10:49:01 +11:00
Konrad
3489f08ec5
Format reports as list, even if only one sub-type available
2022-10-25 00:31:00 +02:00
Konrad
4a7ac45dba
Merge pull request #9830 from jibees/9821-remove-report_inverse_columns_logic-feature-toggle
...
Remove `report_inverse_columns_logic` feature toggle
2022-10-25 00:23:31 +02:00
Konrad
df925d6412
Merge pull request #9737 from Laurel16/fix_issue#9559
...
Translate error messages when creating products
2022-10-24 23:17:32 +02:00
Konrad
84bf38ce4d
Merge pull request #9791 from vsmay98/8250-fix-snail-for-all-enterprise-fee
...
Fix snail issue for all enterprise fees
2022-10-24 21:49:45 +02:00
saunmanoj888
490c5afc59
Mock bigDecimal methods in specs
2022-10-25 00:05:31 +05:30
filipefurtad0
367f77f477
Replaces select2_select helper for find/click
2022-10-24 17:57:10 +01:00
Jean-Baptiste Bellet
892a020bcc
Setup redis on build
2022-10-24 17:01:12 +02:00
dependabot[bot]
1f5281ac1a
Bump rswag-api from 2.6.0 to 2.7.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.6.0...2.7.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-24 11:19:45 +00:00
Rachel Arnould
3c9b7a10f4
Merge pull request #9058 from Matt-Yorkley/oidc-redux
...
Add OIDC authentication for Les Communs
2022-10-24 13:18:36 +02:00
Jean-Baptiste Bellet
e2441cdcf6
Use the report type or subtype as the title
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
6dec80aaaf
Links only on right side
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
1c349049d1
Remove report description when they are useless
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
edc667a336
By default, some columns are hidden.
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
02787e668f
Remove report_inverse_columns_logic feature toggle
...
Co-Authored-By: Maikel <maikel@email.org.au >
2022-10-24 11:12:22 +02:00
dependabot[bot]
830a7c8f1d
Bump aws-sdk-s3 from 1.114.0 to 1.116.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.114.0 to 1.116.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-24 09:03:55 +00:00
dependabot[bot]
cd43bd4522
Bump active_storage_validations from 1.0.0 to 1.0.2
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.0 to 1.0.2.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.0...1.0.2 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-24 09:03:07 +00:00
dependabot[bot]
9dbc9f7272
Bump debug from 1.6.2 to 1.6.3
...
Bumps [debug](https://github.com/ruby/debug ) from 1.6.2 to 1.6.3.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.6.2...v1.6.3 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-24 09:02:49 +00:00
Mohamed ABDELLANI
da9a4803ff
add it "lists products sorted by name" test
2022-10-24 09:01:42 +01:00
Mohamed ABDELLANI
732ebd8457
fix the expected table size in "generates the report" test
2022-10-24 09:01:42 +01:00
Mohamed ABDELLANI
39e567d386
set line_items_count to 3
2022-10-24 09:01:42 +01:00
Mohamed ABDELLANI
4740c2b0db
add sort by product name to order_cycle_supplier_totals_by_distributor report rules
2022-10-24 09:01:42 +01:00
jibees
ee70ab8adb
Merge pull request #9847 from mkllnk/stable-orders_and_fulfillment_spec
...
Expect report rows for same product in random order
2022-10-24 09:57:06 +02:00
Maikel
936a96bd6c
Merge pull request #9839 from openfoodfoundation/dependabot/bundler/rswag-ui-2.7.0
...
Bump rswag-ui from 2.6.0 to 2.7.0
2022-10-24 16:01:04 +11:00
Maikel
b3492981d3
Merge pull request #9832 from openfoodfoundation/dependabot/bundler/nokogiri-1.13.9
...
Bump nokogiri from 1.13.8 to 1.13.9
2022-10-24 15:58:57 +11:00
Maikel Linke
167ce0e53c
Expect report rows in random order
...
It's not deterministic which variant is shown first and therefore this
spec would fail from time to time.
2022-10-24 15:40:35 +11:00
Maikel
8f47d2b2be
Merge pull request #9820 from jibees/update-all-github-action-to-avoid-deprecated
...
Upgrade deprecated github/actions in our CI
2022-10-24 15:26:54 +11:00
Maikel
e873771f18
Merge pull request #9822 from filipefurtad0/redis_CannotConnectError
...
Extracts routing outside it block
2022-10-24 13:33:01 +11:00
Maikel
627b8af37b
Merge pull request #9828 from mkllnk/authorize-api-key
...
Prevent users from changing API keys for others
2022-10-24 11:22:35 +11:00
Cillian O'Ruanaidh
eb72ec8e13
An order cycle isn't ready for checkout if a tag rule means no payment/shipping methods are available to the customer
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
7458dccea6
Call @order_cycles.count instead of #size because TagRuleApplicator doesn't return Relation anymore
...
In March 2020 this was changed to use :size instead of :count because TagRuleApplicator returned an ActiveRecord::Relation, see:
d2eee1dafd
However in October 2020 TagRuleApplicator was changed to always return an Array so this is no longer needed, see:
7e606471e4
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
3e24b7ba6b
Assign variable across two lines so Rubocop override comment isn't needed in OrderCycleClone
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
62cd507fb9
Stub Spree::Config.stripe_connect_enabled instead of changing it before and back after tests
...
It's less code and sometimes there can be issues when config cache values are changed.
Co-authored-by: Maikel <maikel@email.org.au >
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
beba3c7684
Disable Metrics/ClassLength check for OrderCycleForm
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
f5bd23b4d8
Remove unused Spree::Order#available_payment_methods method
...
This was introduced in 47d2f698ef but we are using OrderAvailablePaymentMethods now.
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
2c14aecf4f
Extract a OrderCycleClone service
...
Before it was giving a Rubocop error, probably not a bad idea anyway.
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
4e6d64c0a1
Let people choose which payment methods are available to customers on order cycles
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
5718f9f00c
Create :order_cycles_distributor_payment_methods HABTM join table
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
5423c1c02e
Resolve conflict in db/schema.rb
2022-10-21 17:21:24 +01:00
saunmanoj888
ee8454bd2c
Use js-big-decimal package for calculation
2022-10-21 21:30:00 +05:30
dependabot[bot]
45c23a76ff
Bump rswag-ui from 2.6.0 to 2.7.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.6.0...2.7.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-21 13:24:52 +00:00
Jean-Baptiste Bellet
5a1d9013c6
Update all locales with the latest Transifex translations
2022-10-20 23:12:32 +02:00
jibees
3a68e237de
Merge pull request #9772 from mkllnk/revenue-report-for-au
...
Add more fields to revenue report as used by Aus
2022-10-20 23:10:17 +02:00
Jean-Baptiste Bellet
87ed23211e
Use the last version of github/codeql-action/upload-sarif
2022-10-20 17:42:22 +02:00
jibees
48e18b016a
Merge pull request #9756 from vsmay98/8249-fix-snail-for-all-shipping-method-fee
...
Fix snail issue for all shipping method fees
2022-10-20 17:31:24 +02:00
jibees
da851079f4
Merge pull request #9776 from abdellani/product-creation-minor-improvements
...
Product creation minor improvements
2022-10-20 17:30:47 +02:00
jibees
1d265d19ce
Merge pull request #8872 from Matt-Yorkley/bugsnag-data
...
Update Bugsnag error data
2022-10-20 17:30:14 +02:00
jibees
9e4bd23332
Merge pull request #9738 from AthiraKadampatta/9726-remove-unused-paperclip-columns
...
Delete unused paperclip columns.
2022-10-20 17:29:44 +02:00
jibees
fdc362cb44
Merge pull request #9806 from mkllnk/feature-constraint
...
Generalise feature toggle constraint
2022-10-20 17:27:46 +02:00
Vishal Jain
8d3845508c
remove check_permissions method
2022-10-20 19:54:23 +05:30
Vishal Jain
952b6039f9
Remove spree user registrations controller file
2022-10-20 19:54:23 +05:30
Jean-Baptiste Bellet
053af8416b
Previous setup-ruby action was deprecated. Use ruby/setup-ruby@v1
2022-10-20 16:14:14 +02:00
dependabot[bot]
955b84ae6f
Bump nokogiri from 1.13.8 to 1.13.9
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.13.8 to 1.13.9.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.8...v1.13.9 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-20 13:45:27 +00:00
jibees
2455ecabde
Merge pull request #9758 from openfoodfoundation/dependabot/bundler/activerecord-import-1.4.1
...
Bump activerecord-import from 1.4.0 to 1.4.1
2022-10-20 15:44:42 +02:00
Konrad
71037022ec
Merge pull request #9816 from viniciusueharaweb/9703-product-description-should-have-a-pointer-cursor
...
Add pointer cursor when hovering a clickable product description
2022-10-20 10:38:46 +02:00
Jean-Baptiste Bellet
7ffd4669be
Change node version to use the latest LTS
...
We probably need to modify our `ofn-install` build to also use the latest LTS
2022-10-20 10:20:09 +02:00
jibees
2b7b83ba37
Merge pull request #9826 from filipefurtad0/fix_flaky_spec_bom_9824
...
Clarifies contexts, cleans-up spec DRY
2022-10-20 09:55:33 +02:00
Maikel Linke
fc79612f26
Prevent users from changing API keys for others
...
It was checking for the permission to create a user which everyone can
do. Now it's checking for updating that particular user and doesn't
allow generating new keys for other users any more.
This would have been an inconvenience but not a big security issue
because you can't view the key of another user.
2022-10-20 17:56:46 +11:00
Vishal Jain
de28027623
add system spec
2022-10-20 12:15:22 +05:30
Vishal Jain
755107ec9f
Fix snail issue for all enterprise fees
2022-10-20 12:15:21 +05:30
saunmanoj888
b40cd579bc
Fix spec failure
2022-10-19 23:18:22 +05:30
saunmanoj888
8e45b758ba
Fix unit value UI issue
2022-10-19 22:59:28 +05:30
filipefurtad0
c4de247dd9
Clarifies contexts, cleans-up spec DRY
2022-10-19 16:56:04 +01:00
filipefurtad0
a244b34627
Extracts routing to context (DRY); creates context for separate it block
2022-10-19 11:15:15 +01:00
filipefurtad0
dabe37ebcb
Extracts routing outside it block
2022-10-19 11:01:56 +01:00
Jean-Baptiste Bellet
2fcbe437f2
Upgrade "actions/setup-node" to non-deprecated version
2022-10-19 11:31:47 +02:00
Jean-Baptiste Bellet
642938afe0
Upgrade "actions/checkout" to non-deprecated version
2022-10-19 11:28:31 +02:00
jibees
7b96a1fb5b
Merge pull request #9815 from mkllnk/bulk-product-spec
...
Stabilise spec by waiting for JS
2022-10-19 09:50:55 +02:00
Matt-Yorkley
0ca86344d2
Update use of deprecated #add_tab method to #add_metadata
2022-10-19 17:36:53 +11:00
Matt-Yorkley
980f004b83
Update Bugsnag error data
2022-10-19 17:36:52 +11:00
Matt-Yorkley
c0ee72319f
Remove dead code: Product#variants?
...
This only makes sense in the context of Products which only have "master" variants, and we removed that option a while back.
Remove #variants? check from ProductStock concern
2022-10-19 16:30:12 +11:00
Maikel
3d26b76d17
Merge pull request #9814 from filipefurtad0/fix_flaky_spec_bom_9809
...
Replaces js select2 methods by find/click methods
2022-10-19 14:41:55 +11:00
Vinicius Uehara
7772c01e16
Add pointer cursor when hovering a clickable product description
2022-10-18 23:11:56 -03:00
Maikel Linke
04921aeed4
Stabilise spec by waiting for JS
2022-10-19 09:59:51 +11:00
filipefurtad0
c71c5054e0
Replaces js select2 methods by find/click methods
2022-10-18 21:27:52 +01:00
Filipe
4015413d1d
Merge pull request #9813 from filipefurtad0/fix_flaky_spec_bom
...
Comments out and adds pending on flaky examples
2022-10-18 11:32:50 +01:00
filipefurtad0
b3059bbdbc
Comments out and adds pending on flaky examples
2022-10-18 10:28:44 +01:00
Maikel Linke
a35fab5e1f
Speed up spec by skipping a page
2022-10-18 14:27:18 +11:00
Maikel Linke
c22f6cb805
Add more fields to revenue report as used by Aus
...
We currently maintain our own CSV generation script which could be
replaced if we got all this information here.
2022-10-18 12:51:13 +11:00
Maikel Linke
f00aeb006e
Allow enterprise users to authorize via OIDC
2022-10-18 11:32:14 +11:00
Matt-Yorkley
66c3ba3bba
Remove default omniauth link
2022-10-18 11:32:14 +11:00
Matt-Yorkley
b322df8515
Generate devise links view
2022-10-18 11:32:14 +11:00
Matt-Yorkley
617164684c
Configure OIDC
2022-10-18 11:32:14 +11:00
Matt-Yorkley
b36fae1bbb
Add migration for omniauth attributes
2022-10-18 11:31:35 +11:00
Matt-Yorkley
3a5f263fb5
Add omniauth / OIDC gems
2022-10-18 11:31:35 +11:00
Filipe
d5c3edc8fa
Merge pull request #9749 from drummer83/master
...
Fix layout of 'Create a new product' button in dashboard overview
2022-10-17 13:45:37 +01:00
Laurel16
ec65e4dcaa
Fix: Missing translation in error messages issue#9559
...
Fix: changing local translation for variant_unit in spree/product en.yml
Fix: add unite_value key to en.yml
2022-10-17 15:32:04 +11:00
Maikel
c83eb5d5dc
Merge pull request #9768 from ashwini-seshadri/admin_permissions_granting_permission_to_a_shop_displays_it_in_producers_list_as_if_it_was_a_supplier
...
Fix for: [Admin][Permissions] Granting permission to a shop displays it in "Producers" list as if it was a supplier #9589
2022-10-17 09:58:03 +11:00
Anna Nowak
9a40329bd7
Update docker readme for m1 users [ #8421 ]
2022-10-15 18:29:51 +02:00
jibees
bf74612892
Merge pull request #9775 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.2.2
...
Bump tom-select from 2.2.1 to 2.2.2
2022-10-14 09:27:06 +02:00
jibees
eae7d96b30
Merge pull request #9774 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.2.2
...
Bump @hotwired/turbo from 7.2.0 to 7.2.2
2022-10-14 09:21:36 +02:00
Mohamed ABDELLANI
96c6f58ba2
fix test @/spec/system/admin/products_spec.rb:32
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
6a8c7b15dc
fix product category errors message in the form
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
955492bfdd
show the error message when the variant unit is not selected
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
0000faab91
render the error message when the unit value is not set
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
e3f157ebdd
remove empty option from unit size
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
f8af84d9d4
remove red start from tax category form
2022-10-14 03:26:40 +01:00
Mohamed ABDELLANI
bddbb36813
remove red star from supplier
2022-10-14 03:26:40 +01:00
dependabot[bot]
78b73c988e
Bump tom-select from 2.2.1 to 2.2.2
...
Bumps [tom-select](https://github.com/orchidjs/tom-select ) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/orchidjs/tom-select/releases )
- [Commits](https://github.com/orchidjs/tom-select/compare/v2.2.1...v2.2.2 )
---
updated-dependencies:
- dependency-name: tom-select
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-13 09:41:37 +00:00
jibees
cd641cc5d6
Merge pull request #9714 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.2.1
...
Bump tom-select from 2.1.0 to 2.2.1
2022-10-13 11:30:13 +02:00
dependabot[bot]
50555a3fe9
Bump @hotwired/turbo from 7.2.0 to 7.2.2
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.2.0 to 7.2.2.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.2.0...v7.2.2 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-13 09:08:24 +00:00
jibees
7c6e220bf7
Merge pull request #9771 from mkllnk/rspec-slow
...
Add convencience script to test flaky specs
2022-10-13 10:44:00 +02:00
Maikel Linke
3496b57942
Add convencience script to test flaky specs
2022-10-13 16:28:09 +11:00
Maikel Linke
bc805d94d8
Update translations
2022-10-13 16:03:26 +11:00
Ashwini Seshadri
1596649034
Merge branch 'master' into admin_permissions_granting_permission_to_a_shop_displays_it_in_producers_list_as_if_it_was_a_supplier
2022-10-13 06:48:40 +02:00
Maikel Linke
81461684f3
Generalise feature toggle constraint
...
Now we can re-use it for any feature.
2022-10-13 10:42:20 +11:00
Maikel
d33cdd1327
Merge pull request #9706 from jibees/9625-create-a-component-to-display-hide-columns-for-report
...
Create a component to display/hide columns for report
2022-10-13 10:05:27 +11:00
jibees
daaff2f7e8
Merge pull request #9764 from mkllnk/simple-oc-spec
...
Stabilise spec by waiting for JS requests
2022-10-12 10:17:51 +02:00
Jean-Baptiste Bellet
4de0b9ad11
Avoid warning on compilation
2022-10-12 09:28:50 +02:00
Jean-Baptiste Bellet
14a258c661
Attempt: externalize ofn-drop-down-v2 selector
...
+ add class `redesigned-checkbox` on `input`
Move `input.redesigned-input` definition outside dropdown definition
--> more generic
2022-10-12 09:28:50 +02:00
jibees
3b3f9a7513
Merge pull request #9766 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.19.4
...
Bump @babel/preset-env from 7.19.3 to 7.19.4
2022-10-12 09:07:53 +02:00
Maikel
3e1b66fd01
Remove extra blank line from Gemfile
2022-10-12 17:15:12 +11:00
Maikel Linke
9da6f862cd
Stabilise pending spec
2022-10-12 16:49:29 +11:00
Maikel Linke
3eb597bff4
Fix specs which accidentally reversed relationships
2022-10-12 16:49:29 +11:00
Maikel Linke
46fde6bd40
Remove now unused scope
2022-10-12 16:48:32 +11:00
Ashwini Seshadri
590a09f069
Fixed the permissions relationship, so the shop displays only suppliers and does not display distributors in producers list
...
and updated relevant tests
2022-10-12 16:48:31 +11:00
Maikel
1d9fbbf69e
Merge pull request #9767 from jibees/fix-flaky-spec
...
BOM Specs, don't need to wait for UI feedback: only check on page content
2022-10-12 11:52:50 +11:00
Maikel
b378d7655f
Merge pull request #9762 from openfoodfoundation/dependabot/bundler/view_component-2.74.1
...
Bump view_component from 2.74.0 to 2.74.1
2022-10-12 11:24:11 +11:00
Rachel Arnould
617a417dc2
Merge pull request #9506 from binarygit/remove-angular-from-payment-methods
...
Remove angular from payment methods
2022-10-11 13:13:26 +02:00
Jean-Baptiste Bellet
bfbdb5f44b
Don't need to wait for UI feedback: only check on page content
...
ie. table content
2022-10-11 12:16:25 +02:00
Vishal Jain
e02de2b17d
Fix snail issue for all shipping method fees
2022-10-11 15:30:19 +05:30
dependabot[bot]
ae84dfe3cd
Bump @babel/preset-env from 7.19.3 to 7.19.4
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.19.3 to 7.19.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.19.4/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-11 09:03:45 +00:00
Jean-Baptiste Bellet
8a6874326a
selected could be nil if no columns are selected
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
68de510c4e
Redesign checkboxes
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
230afd5024
Update multiple_checked_select_component.html.haml
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
41e696282c
Don't build inputs, but directly use input checkbox for each option
...
way simpler this way.
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
e655d5b188
Remove useless id attribute. Prefer to use data-value directly.
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
7d15baef9d
Do not use a variable filter_placeholder but translate it in the view
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
312f2544dd
Be sure that option key is a Symbol (it could be a String)
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
157bdd9f3d
Add a vertical scrolling
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
b4e041c7e9
Implements the ofn-drop-down-v2 design
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
23e2d28488
Implements the filter options feature
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
0f9ebfe34a
Use the MultipleCheckedSelectComponent
2022-10-11 10:05:06 +02:00
Jean-Baptiste Bellet
b7adc5f551
Create the MultipleCheckedComponent
...
+ Associate the StimulusController to this component
2022-10-11 10:05:06 +02:00
dependabot[bot]
7bb7391634
Bump activerecord-import from 1.4.0 to 1.4.1
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.4.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: activerecord-import
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-11 07:35:27 +00:00
AthiraKadampatta
e5a136801d
9726 Remove attachment_width and attachment_height from spree_asset
2022-10-11 10:26:32 +05:30
AthiraKadampatta
addd2ea9ac
#9726 Add migration to remove unused paperclip columns
2022-10-11 10:26:32 +05:30
dependabot[bot]
7b0ce3272a
Bump view_component from 2.74.0 to 2.74.1
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.74.0 to 2.74.1.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.74.0...v2.74.1 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-11 04:19:01 +00:00
Maikel Linke
5bbbe4b67a
Stabilise spec by waiting for JS requests
...
Well, two seconds is just a guess. Ideally the page wouldn't display
until we have everything loaded. But this logic will be replaced when we
chuck out AngularJS.
This version passed over 100 runs with a busy CPU on my machine.
2022-10-11 14:57:59 +11:00
Maikel
4705d306b5
Merge pull request #9730 from AthiraKadampatta/9726-unused-paperclip-columns-ignored-list
...
Ignore paperclip columns to prepare for deletion
2022-10-11 11:44:42 +11:00
Maikel
2082404c87
Merge pull request #9752 from maniSHarma7575/9603-fix-order-cycle-fees-dropdown
...
Fixed same enterprise appear several times in the fee dropdown list
2022-10-11 09:41:02 +11:00
Maikel
c9a7230fe2
Merge pull request #9635 from mkllnk/stable-specs
...
Remove retries from test runs
2022-10-11 09:36:50 +11:00
Jean-Baptiste Bellet
1f329e85bc
Also include plugins
2022-10-10 17:15:46 +02:00
AthiraKadampatta
b2c778794d
9726 Remove safe navigation operator and simplify call to attachment file name
2022-10-10 16:52:02 +02:00
AthiraKadampatta
80eef9c302
9726 Add attachment_width and attachment_height to the list of ignored columns for spree images
2022-10-10 16:52:02 +02:00
AthiraKadampatta
f40b569a4a
9726 Use active storage filename instead of attachment_file_name of paperclip
2022-10-10 16:52:02 +02:00
AthiraKadampatta
1f161bee1f
Add paperclip columns to ignored columns list for enterprise, enterprise group, terms_of_service_file, spree/image models
2022-10-10 16:52:02 +02:00
Jean-Baptiste Bellet
4140e3d153
Import tom-select file directly
...
can't use "tom-select" anymore, due to a mis-configuration with babel I guess
2022-10-10 16:10:33 +02:00
Jean-Baptiste Bellet
db70c47a31
Specify IE 11 as a target
...
Comes from error using tom-select:
```
ERROR in ./node_modules/tom-select/dist/esm/tom-select.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: /Users/jibees/dev/openfoodnetwork/node_modules/tom-select/dist/esm/tom-select.js: unknown Statement of type "ForOfStatement"
```
2022-10-10 16:09:43 +02:00
Manish Sharma
cd71233163
Fixed duplicates enterprises in order cycles
2022-10-10 14:30:58 +05:30
Maikel Linke
6ef0e04c18
Mark currently broken spec as pending
...
I thought it's better to progress with this PR before we break more
things.
2022-10-10 16:03:18 +11:00
Maikel Linke
87274bccc6
Remove retries from test runs
...
If a spec is flaky, we need to fix it. Retry is just hiding problems for
a while and is adding to execution time.
2022-10-10 14:09:18 +11:00
dependabot[bot]
981c306977
Bump tom-select from 2.1.0 to 2.2.1
...
Bumps [tom-select](https://github.com/orchidjs/tom-select ) from 2.1.0 to 2.2.1.
- [Release notes](https://github.com/orchidjs/tom-select/releases )
- [Commits](https://github.com/orchidjs/tom-select/compare/v2.1.0...v2.2.1 )
---
updated-dependencies:
- dependency-name: tom-select
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-10 03:00:21 +00:00
Maikel
82e38d7b91
Merge pull request #9526 from jibees/6730-use-a-date-range-picker
...
Admin, List of Orders & Orders Bulk Management pages: use a date range picker
2022-10-10 13:59:37 +11:00
Maikel
5894246474
Merge pull request #9682 from binarygit/picked_up_email
...
Send picked up emails when orders are picked up
2022-10-10 13:15:24 +11:00
Maikel
058a45f4e5
Merge pull request #9442 from jibees/8904-display-fees-name-instead-of-type-on-invoices
...
Display fees name instead of type on invoices
2022-10-10 13:15:01 +11:00
Maikel
e5ccee42cc
Merge pull request #9725 from vsmay98/9468-hide-all-references-hub-from-producers-profile
...
[Shopfront] Hide hub with "hide all references" setup in producers profiles
2022-10-10 13:11:49 +11:00
Maikel
38f145549a
Merge pull request #9741 from mkllnk/empty-variant-param
...
Avoid error when sending empty variant attributes in bulk product edit
2022-10-10 11:43:10 +11:00
Maikel
f551bea00b
Merge pull request #9731 from mkllnk/features
...
Add used feature toggles to appear in the admin UI
2022-10-10 11:41:05 +11:00
Jean-Baptiste Bellet
f5ebc797c4
Send change event on flatpickr widget close
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
263b36d1d9
Confirm input changed by pressing enter key
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
ea76615763
Forward focus event on calendar open
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
e076e23064
Do not use ng-change on endDate but instead watch both start and end date
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
a272479483
When selecting date range picker, orders should load
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
6ec3e7ee0c
Only send event change on valid range (ie. both start and end date)
...
+ do not refresh data on start date change but only on end date change
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
ec4d091c2e
Remove the or label as it was unecessary
...
and actually, untranslated
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
eec117e769
Implements daterangepicker for /admin/orders/bulk_management
...
+ update specs as well
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
eb621cae35
Update spec to be more defensive
...
Actually, this one fail on master too (when changing month?)
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
73f55ae776
Implements daterangepicker for /admin/orders
...
+ update specs as well
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
19584ce6e0
flatpickr controller is now ready to be used in range mode
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
8942d3d17b
Clear date on custom event flatpickr_clear
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
ddfbcacd83
Include plugins
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
c3a7acf9ad
import locale
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
fb0d922d73
Remove datetimepicker directive + default values
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
5c83a3277e
Replace datetimepicker by flatpickr stimulus controller
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
c6332ab306
Remove datepicker instance
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
6b7030a6a8
Don't use directive, but the flatpickr stimulusjs controller
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
b1fd6d9541
Create the flatpickr date|datetime controller
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
d73d6dcdb6
Do not import flatpickr via this require
...
as now flatpickr is managed by yarn and should be imported when module need it, via import
2022-10-08 16:36:26 +02:00
Jean-Baptiste Bellet
792d6d9569
Add stimulus flatpickr
...
Update yarn.lock
2022-10-08 16:36:26 +02:00
Maikel Linke
1137e6890b
Supply feature mock with default value
...
Otherwise Rspec complains about receiving another argument which is not
the one we defined here before.
2022-10-08 16:23:17 +02:00
Maikel Linke
52e934ec2b
Consistently use our FeatureToggle module
...
Direct calls to Flipper have the downside that we can't add any new
functionality like storing the feature in the database when used.
2022-10-08 16:23:17 +02:00
Maikel Linke
bc26a3aa07
Add used feature toggles to appear in the admin UI
...
The admin UI shows only features which were added to the database. We
always had to look up a feature's name add it manually before we could
enable it. Now it will appear in the UI after some code asked if it was
enabled.
This only adds a database query once when the feature doesn't exist yet.
The `feature.exist?` call only performs an in-memory lookup in the
memoizer.
2022-10-08 16:23:17 +02:00
binarygit
01c477f2cb
Remove angular from Payment Methods
2022-10-08 14:20:54 +02:00
binarygit
8335594351
Add different subject for picked up email
2022-10-08 12:31:26 +02:00
binarygit
44db511e66
Send a picked up email (rather than shipped email) when orders are picked up by customers
2022-10-08 12:31:26 +02:00
Jean-Baptiste Bellet
8b89c901ef
Do not display "Admin and Handling" ie. fees total
2022-10-08 10:00:57 +02:00
Jean-Baptiste Bellet
7b57f2358c
Create a new key instead of modifying the old one
...
it could lead to issues when key is not updated and we should avoid that kind of issue.
2022-10-08 10:00:57 +02:00
Maikel Linke
b297299838
Simplify test of adjustments
2022-10-08 10:00:57 +02:00
Maikel Linke
52843de1da
Test against unique fee name
...
The adjustment factory calls everything "Shipping" by default. This was
confusing here because we were explicitely looking at a non-shipping
fee.
2022-10-08 10:00:57 +02:00
Jean-Baptiste Bellet
77e644e3d4
Get adjustment which is not the shipping one
2022-10-08 10:00:57 +02:00
Jean-Baptiste Bellet
72df2867d4
Remove admin_and_handling merging
...
+ update specs as well
2022-10-08 10:00:57 +02:00
Jean-Baptiste Bellet
0cc8349c71
Use fee name for the adjustment label instead of type
...
+ update specs as well
2022-10-08 10:00:57 +02:00
Maikel Linke
47ac118cf7
Simplify ProductSet by using Rails changes feature
...
I added a line to this class before and that made it too long. Now I
removed a line again to keep code quality up.
2022-10-08 09:03:38 +02:00
Maikel Linke
95d68b98a9
Spec both cases of removing variants from order cycles
...
The spec tested only the removal but not he keeping of variants.
I want to change this in the next commit to simplify the class.
2022-10-08 09:03:38 +02:00
Maikel Linke
47a43163d8
Avoid error on empty variant attributes
...
In 2019 Pau observed an error where an empty attributes hash was passed
to the bulk product update method. He added an automated test but wasn't
able to reproduce the error.
A recent change in logic made the spec fail but rspec-retry hid that
fail because it would succeed on a second try (not sure why). I now
changed the logic to ignore empty attributes properly and avoid an error
trying to create a new variant when no attributes are given.
* f940397781 Pau's spec
* 6f228781d4 Fixing error detection
2022-10-08 09:03:38 +02:00
Konrad
52c6f5a222
Fix layout of 'Create a new product' button in dashboard overview
2022-10-07 12:37:45 +02:00
Vishal Jain
b582b61414
add specs to not include hidden hubs
2022-10-07 11:24:32 +02:00
Vishal Jain
6ead127b5c
add not hidden scope to hide hidden hub from producers profile
2022-10-07 11:24:32 +02:00
jibees
22cf05ad94
Merge pull request #9742 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.0
...
Bump active_storage_validations from 0.9.8 to 1.0.0
2022-10-07 09:12:47 +02:00
jibees
a2e68026e5
Merge pull request #9743 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-4.0.3
...
Bump sidekiq-scheduler from 4.0.2 to 4.0.3
2022-10-07 09:09:04 +02:00
dependabot[bot]
c9419d3437
Bump sidekiq-scheduler from 4.0.2 to 4.0.3
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v4.0.2...v4.0.3 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-06 09:02:55 +00:00
dependabot[bot]
c1f34bc680
Bump active_storage_validations from 0.9.8 to 1.0.0
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 0.9.8 to 1.0.0.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/0.9.8...1.0.0 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-06 09:02:40 +00:00
Maikel Linke
a64d146bb1
Update translations
2022-10-06 12:31:39 +11:00
Maikel
a43d31a9d5
Merge pull request #9711 from dacook/translation-cleanup
...
Translation cleanup
2022-10-06 09:51:28 +11:00
Maikel
db2b381c3f
Merge pull request #9718 from mkllnk/style
...
Use standard ApplicationRecord in task class
2022-10-06 09:42:29 +11:00
Konrad
9f0c0208dd
Merge branch 'master' into style
2022-10-05 19:59:10 +02:00
Maikel
8072e97579
Merge pull request #9721 from filipefurtad0/fix_flaky_shopping_spec
...
Addresses flakyness in shopping_spec.rb
2022-10-05 13:19:23 +11:00
filipefurtad0
977916cb11
Adds 2 sec sleep time on other flaky examples
2022-10-04 20:58:30 +01:00
filipefurtad0
f4edfcefa2
Adds 2 sec sleep time
2022-10-04 20:17:14 +01:00
Rachel Arnould
b078d3e0cc
Merge pull request #9719 from mkllnk/secrets-config
...
Simplify config of secret token
2022-10-04 20:36:03 +02:00
Rachel Arnould
611475c48a
Merge pull request #9448 from binarygit/cancel-orders-in-bulk
...
Cancel Orders in Bulk
2022-10-04 19:48:59 +02:00
Rachel Arnould
21ecec894f
Merge pull request #9688 from binarygit/order-cycle-closes-during-checkout
...
Redirect to shopfront when OC closes during checkout
2022-10-04 19:46:38 +02:00
David Cook
0fc8c719fe
Scope Enterprise side menu translations
...
And removed some now-unused global translations, yay! I searched for these in the codebase, eg with regex:
/\bt[\( ]["':]shop_preferences/
2022-10-04 19:39:29 +02:00
David Cook
4c3e20d25a
Scope Enterprise form legend translations
2022-10-04 19:39:29 +02:00
David Cook
13d95ecf1d
Scope Enterprise Group side menu translations
...
With it's own lazy scope, we no longer need to define labels separately.
2022-10-04 19:39:29 +02:00
David Cook
7803e5d4ff
Scope Enterprise Group form legend translations
...
Using lazy-lookup builtin scopes, instead of sharing the global translations, as per our guidelines.
2022-10-04 19:39:29 +02:00
David Cook
2e2ff25ef7
DRY up code
...
Slightly. If we upgrade to Ruby 3.1 with hash value omission, this would be neater.
If we could set a scope in the controller (https://stackoverflow.com/questions/6137960/rails-i18n-default-scope ) it would be even neater.
2022-10-04 19:39:29 +02:00
David Cook
3a61cf05ad
Remove unused locale message
...
I can't find any reference to this in the code. The wiki says maybe it's looked up with a variable, but I don't see how it could be used unless this string is defined in code somewhere (we wouldn't translate data from the database, would we?).
Maybe it's used in a gem? In that case, hopefully CI will pick up the error.
2022-10-04 19:39:29 +02:00
Maikel Linke
ef80c3358d
Explain how to easily configure other environments locally
2022-10-04 19:35:40 +02:00
Maikel Linke
57a70455a8
Simplify setting of secret token
...
We define it in the dotenv files already which has the advantage of
being overridable. I adjusted the dotenv files to have the same value as
was set before, 30 times `x`.
2022-10-04 19:35:40 +02:00
Maikel Linke
885e67a39b
Ignore Rails secrets
...
These files are only used in production but sometimes we want to test
production execution on our dev machines, too.
2022-10-04 19:35:40 +02:00
binarygit
25ae10dbe8
Create bulk orders cancellation feature
2022-10-04 16:57:31 +02:00
filipefurtad0
7b592fd80b
Adds assertion after page visit to promote page loading
2022-10-04 12:27:58 +01:00
jibees
4b6aced962
Merge pull request #9732 from openfoodfoundation/dependabot/bundler/test-unit-3.5.5
...
Bump test-unit from 3.5.3 to 3.5.5
2022-10-04 12:15:55 +02:00
dependabot[bot]
e32ad0b436
Bump test-unit from 3.5.3 to 3.5.5
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.3 to 3.5.5.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.3...3.5.5 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-04 09:19:10 +00:00
binarygit
930721bea6
Redirect to shop front when OC closes during checkout
2022-10-03 20:51:41 +02:00
filipefurtad0
8e6f828f66
Splits it cases into respective contexts
2022-10-03 19:30:57 +01:00
filipefurtad0
fa05327342
Adds assertions on clearing searches
...
Asserts on page contents
2022-10-03 19:12:27 +01:00
filipefurtad0
cafa17ec13
Splits test into two assertions
2022-10-03 19:12:27 +01:00
jibees
b3449137e0
Merge pull request #9728 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.3.10
...
Bump js-big-decimal from 1.3.5 to 1.3.10
2022-10-03 14:56:33 +02:00
dependabot[bot]
da6af22d03
Bump js-big-decimal from 1.3.5 to 1.3.10
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.5 to 1.3.10.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.5...v1.3.10 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-03 09:05:41 +00:00
Jean-Baptiste Bellet
0468d46241
Update all locales with the latest Transifex translations
2022-09-30 16:37:59 +02:00
jibees
0c64720a9e
Merge pull request #9710 from mkllnk/9002-customer-association-updates
...
Associate and update customer records when ordering
2022-09-30 16:36:01 +02:00
Filipe
4b279d28dd
Merge pull request #9262 from cillian/order-cycle-shipping-methods
...
Let people customise which shipping methods are available to customers on order cycles
2022-09-30 14:36:37 +01:00
Cillian O'Ruanaidh
acd4706890
Set closing time correctly in order_cycles/complex_creating_specific_time_spec.rb
2022-09-30 14:22:11 +01:00
Filipe
f7d21406a1
Merge pull request #9702 from ashwini-seshadri/master
...
Fix for new subscription dialog
2022-09-30 13:32:42 +01:00
Cillian O'Ruanaidh
f9e29f3a78
Fix Metrics/AbcSize violation in order_cycles/complex_creating_specific_time_spec.rb
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
def87485c0
Don't delete schedules on the order_cycles#update action just because the :schedule_ids was not specified in the parameters
...
Before this schedules were being deleted when the Checkout Options step of editing order cycles was saved because this step wasn't sending the :schedule_ids parameter. It's more awkard for API users if they always need to explicity send the :schedule_ids parameter even if they don't want to add/remove any of the schedules, for example if they just want to update an order cycle name.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
6542b47e72
Adjust order_cycles/complex_creating_specific_time_spec to take into account that DistributorShippingMethods instead of ShippingMethods are connected to OrderCycles now
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
2827e07da6
Define :oc with let so it is available globally to other methods such as :expect_fees_saved
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
23f6901fb4
Adjust order_cycles/simple_spec.rb to take new Checkout Options step into account
...
Note, this doesn't test checking/unchecking some distributor shipping methods and not others because that is tested in order_cycles/complex_creating_time_specific_spec.rb.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
db92e9d91c
Fix error from OrderCycle#distributor_shipping methods return ActiveRecord::Relation sometimes and Array other times
...
Now it will return ActiveRecord::Relation consistently.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
5207dbf8c6
OrderCycle#distributor_shipping_methods should return all attachable ones by default per distributor, not per all distributors
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
7e40ad39cb
Bring back select all checkboxes on order cycle checkout options form.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a53a3259a8
Connect DistributorShippingMethods to OrderCycles instead of Spree::ShippingMethods
...
Before if a shipping method was shared between multiple distributors it could only be disabled/enabled on that order cycle for all the distributors which have that shipping method e.g. you couldn't select that shipping method for one distributor but disable it for another.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
8c483f2eab
Change join table in migration from order cycles to distributor shipping methods instead of order cycles to shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
65ee9e1486
Implement new design with shipping and payment methods on different rows instead of same one, the select all checkboxes still need to be added back later
...
This is the new design from https://github.com/openfoodfoundation/openfoodnetwork/pull/9262#issuecomment-1206673689
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a73b608f8a
Remove 'shared' shipping method sections from order cycle checkout options form, any shared shipping methods are to be displayed for each distributor e.g. if they belong to multiple distributors they will be displayed multiple times
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
4b0b4ad991
Revert "Use a more simple layout on the order cycle checkout options form"
...
This reverts commit 0dddaa6c2b9f1925adca6ff8deac8181691ae119.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
32d16eacd2
Fix Rubocop Metrics/AbcSize and Layout/LineLength errors in complex_creating_specific_time_spec.rb
...
Not sure if this is correct but it removes the Rubocop violations.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
8e47949260
Check 'Select all' checkboxes on page load if all its checkboxes are checked
...
This means the code to set the initial value in the view template isn't needed.
2022-09-30 13:13:39 +01:00
Maikel Linke
512394862b
Wait for input field before filling it
...
The spec was failing from time to time. I hope that this will fix it.
```
Failures:
1)
As an administrator
I want to create/update complex order cycles with a specific time
creating an order cycle with full interface
Failure/Error: fill_in 'order_cycle_outgoing_exchange_0_pickup_time', with: 'pickup time'
Capybara::ElementNotFound:
Unable to find field "order_cycle_outgoing_exchange_0_pickup_time" that is not disabled
# ./spec/system/admin/order_cycles/complex_creating_specific_time_spec.rb:138:in `add_distributor_with_fees'
# ./spec/system/admin/order_cycles/complex_creating_specific_time_spec.rb:66:in `block (2 levels) in <main>'
# ./spec/system/support/cuprite_setup.rb:39:in `block (2 levels) in <main>'
# -e:1:in `<main>'
```
2022-09-30 13:13:39 +01:00
Maikel Linke
195f1e1237
Make "Select all" translatable
2022-09-30 13:13:39 +01:00
Maikel Linke
26d5ea6cdc
Remove unused input name
2022-09-30 13:13:39 +01:00
Maikel Linke
3518d1ba92
Spec "Select all" shipping methods field
2022-09-30 13:13:39 +01:00
Maikel Linke
c5bb2f52e1
Check "Select all" to start with
...
Reflect the state of the shipping method checkboxes.
2022-09-30 13:13:39 +01:00
Maikel Linke
758030e81a
Test with readable labels instead of ids
2022-09-30 13:13:39 +01:00
Maikel Linke
da2ef3fae2
Give order cycle spec some structure
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
87431c188e
Use ShippingMethod :frontend method and drop :backend to avoid ClassLength Rubocop error
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
0673f9a5ae
Use a more simple layout on the order cycle checkout options form
...
Before there was a row for each distributor and a 'shared' row for shipping methods which were shared among more than one distributor. This layout displays a single list of shipping methods with the distributor or distributors it belongs to beside it as suggested by @lin-d-hop
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
8cb2767f9a
The no shipping/payment method warnings on order cycle checkout options looks better left aligned
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
1a70cc0c4c
Don't display no shipping/payment method warnings on order cycle checkout options if the distributor has some that are shared with other distributors
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
464a9b95a4
On order cycle checkout options shipping methods shared between distributors should be checked by default too
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
8b59b7a796
Use if exclude instead of if !include in OrderCycleForm
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
ad51b41bb3
Use :belongs_to instead of :references in :order_cycles_shipping_methods
...
Also fix migration class name.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
472bd150bb
For consistency with other '<em>' don't strip whitespace.
...
Although both '%em' and '%em>' are rendering the same markup, perhaps because the tag is on it's own new line.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
af87943fd0
Change 'if !' to 'unless' in OrderCyclesList
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
efb1a326b4
Fix line length in OrderCycleForm spec for Rubocop
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
94b96e18ed
Remove OrderCycleForm specs that are no longer necessary
...
These were added for a previous approach which is no longer used.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
80b7a5d39a
Remove OrderCycleShippingMethod model and use a :has_and_belongs_to_many association instead
...
Before the OrderCycleShippingMethod had a validation which checked the shipping method belonged to the order cycle distributor. Instead of this validation this just ignores shipping methods which don't belong to one of the order cycle's distributors when they are being attached in the OrderCycleForm service. This pattern is already being used in the OrderCycleForm service for ignoring Schedules that the person doesn't own.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
61bbf0714e
Remove flag argument anti-pattern from Shop::OrderCyclesList
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
da3eea6005
Fetch shared shipping/payment methods for order cycle checkout options in single query
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
6453bbcc1c
Fix :selected_shipping_method_ids param for shared shipping methods.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
541a340dcf
If an OrderCycle or Spree::ShippingMethod is destroyed then remove it's associated OrderCycleShippingMethod records too
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
593da4996f
A shop won't be shown as open if it doesn't have useable shipping method so these shipping method validations are really necessary
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a3a52a07b7
Build shipping method with a category so it's valid in the test
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
ed13ee6cbc
Fix association alignment in OrderCycle
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
564e4d802c
Don't use :html_safe with payment method name in checkout options in case it contains something malicious
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
747c88fb35
Update the Shop::OrderCyclesList service so it's clearer what kind of order cycles are being fetched
...
Before the Shop::OrderCyclesList service would return order cycles even if they are not ready for checkout and we had a check before calling the service in BaseController which would return OrderCycle.where('false'). It seems like this check should be part of the service too.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
f4a4f7c9ff
Remove validations checking order cycle has shipping methods
...
Instead we will make sure the order cycle is not available on the shopfront if it is doesn't have valid shipping methods. This will preven the issue where if one distributor deletes their shipping method, we don't want to invalidate the order cycle for all other distributors.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
81730f725d
Enterprises shouldn't be considered ready for checkout if it only has backend shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
7bd56007bd
Don't use :html_safe in case shipping method name contains something malicious in app/views/admin/order_cycles/checkout_options.html.haml
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
d9de35799d
Array difference operator is neater than reject in app/views/admin/order_cycles/checkout_options.html.haml
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
67d4c38550
Rename :preferred_shipping_methods to :selected_shipping_methods on OrderCycle
...
It's a clearer name because 'preferred' implies there could be other unpreferred shipping methods available as well.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
cc5daf51b1
Expect to be_valid instead of checking presence of specific error spec/models/spree/shipping_method_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
f25de984d2
Use .empty? instead of !exists? in app/models/order_cycle_shipping_method.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9a511e9e94
Rubocop adjustments
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
0671e52a29
Undo changes to tests, now that order cycle returns all shipping methods by default and doesn't explicitly require OrderCycleShippingMethods anymore
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9296686384
Make backend, frontend scopes on Spree::ShippingMethod neater
...
Co-authored-by: Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
f6c754839b
Make OrderCycleShippingMethod inherit from ApplicationRecord
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
fc4f951a1a
Only require OrderCycleShippingMethod records if people want to override the default shipping methods
...
It makes things much simpler if we return all shipping methods by default without needing OrderCycleShippingMethod records to be added to the database.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
4e0bf75ecf
Get tests broken because of new order cycle shipping method validations working again
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a46b77d10c
Ensure hack for showing products on a shop with closed order cycles also works if an order cycle has no shipping methods
...
If a distributor order cycle has no shipping methods it will be invalid. This is a bit confusing because adding a check for :invalid seems like it would be better if it was done in the Shop::OrderCyclesList service but the hack doesn't work if you put it in there, it seems like something needs a refactor.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
5a4bc79c74
Update sample data task so distributor order cycles have shipping methods attached i.e. are valid
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
bff7650b35
Change :available_shipping_methods helper to use new OrderAvailableShippingMethods service.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
855ec1a708
Add new 'Checkout options' step to the edit order cycle form so people can attach shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
1e817af5aa
Validate deleting a shipping method or switching it to backoffice only doesn't invalidate any order cycles
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
48c2e48b24
Update the OrderCycleForm service so it supports attaching shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
ca97a7f52d
Add :shipping_methods association to OrderCyle and validations
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9a6e8a1113
Add an OrderCycleShippingMethod model to handle attaching shipping methods to order cycles
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
94d71b8dce
Remove extra unnecessary :display_on_checkout scope and reuse :frontend scope instead
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a5daee39e3
Extract out a DISPLAY_ON_OPTIONS constant in Spree::ShippingMethod instead of magic strings
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
37617f63ea
Remove non-functional :backend scope from Spree::ShippingRate
...
It finds shipping methods where 'display_on != front_end' but :front_end values were removed in a1317be19b/db/migrate/20200508101630_convert_frontend_shipping_method_to_both.rb so it will always return true.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9b5f743fa5
Extract out a OrderCycle#simple? method so it can be used in models
2022-09-30 13:13:39 +01:00
Filipe
e85dd99e04
Merge pull request #9633 from binarygit/add-stimulus-reflex
...
Add StimulusReflex
2022-09-29 17:11:18 +01:00
binarygit
ebe4a3d6ab
Add StimulusReflex
2022-09-29 16:03:45 +02:00
jibees
382f8c38f6
Merge pull request #9712 from jibees/solve-uglifier-error
...
Remove now unnecessary uglifier gem
2022-09-29 16:02:14 +02:00
Jean-Baptiste Bellet
a024d0e5ac
Remove uglifier
2022-09-29 15:24:31 +02:00
Rachel Arnould
f8f778eaa1
Merge pull request #9686 from jibees/9684-fix-search-customer-in-order-creation-for-super-admin
...
Admin, New Order, Search customer: As a super admin, search for customer within all enterprises
2022-09-29 14:35:18 +02:00
Maikel Linke
8011d85968
Clarify updating only pre-existing customers
2022-09-29 12:06:06 +02:00
Maikel Linke
a7de56460d
Further simplify Order by outsourcing to service class
2022-09-29 12:06:06 +02:00
Maikel Linke
1f19642dad
Simplify Order by outsourcing to service class
...
This is work in progress and calling the service will be simplified in a
few commits.
2022-09-29 12:06:06 +02:00
Maikel Linke
33d6454dd3
Simplify with guard clause
2022-09-29 12:06:06 +02:00
Maikel Linke
a0260c4ff7
Move customer update logic to own service file
...
The Order class is too big already. We can move more code in the next
commits.
2022-09-29 12:06:06 +02:00
Maikel Linke
cec81a3ae6
Clarify condition to create customer record
2022-09-29 12:06:06 +02:00
Maikel Linke
37eac5ed49
Remove dead code branch in customer check
...
We only try to create a customer when none is present. So the check for
validating the customer always returned false because we didn't have a
customer.
2022-09-29 12:06:06 +02:00
Maikel Linke
b232fa3d0c
Deal with conflicting customer entries
2022-09-29 12:06:06 +02:00
Maikel Linke
f6ac02dce5
Update customer's email after user changed it
...
This may fail if there's already a customer record with the same email
address for the same enterprise. I will fix that in the next commit.
2022-09-29 12:06:06 +02:00
Maikel Linke
9dbba35019
Find customers by user id as well as email
...
Also fixing up a spec which became brittle due to too much mocking.
2022-09-29 12:06:06 +02:00
Maikel Linke
cf634d8d9b
Simplify customer association
2022-09-29 12:06:06 +02:00
Maikel Linke
5fefd3b14b
Remove useless customer loading and clarify name
...
The method `associate_customer` only loads a customer but doesn't
actually associate one. So the deleted line doesn't have any effect.
The intention was to reset the customer after switching shops but the
before_validation logic on the order model takes care of that already.
I'm renaming this private method here for clarity.
2022-09-29 12:06:06 +02:00
Maikel Linke
93da64f466
Spec for duplicate customers after changing email
2022-09-29 12:06:06 +02:00
Maikel Linke
0d1f48ac0d
Simplify order-customer logic
2022-09-29 12:06:06 +02:00
Maikel Linke
ccbf20a73b
Replace spec of customer's internal logic
...
Specs should test public methods. Private methods should be able to
change without specs breaking.
The specs were also just mirroring the code and didn't really have any
meaning. So I wrote new ones which are hopefully clearer.
There's actually a case which I don't quite understand. Why don't we
require a customer for a new complete order? It means that we don't have
a customer creating it but then it's added when updating the order.
Seems inconsistent.
2022-09-29 12:06:06 +02:00
jibees
5dc4a859f7
Merge pull request #9717 from openfoodfoundation/dependabot/bundler/view_component-2.74.0
...
Bump view_component from 2.73.0 to 2.74.0
2022-09-29 10:19:23 +02:00
jibees
9323931a21
Merge pull request #9715 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.19.3
...
Bump @babel/preset-env from 7.19.1 to 7.19.3
2022-09-29 09:33:28 +02:00
Maikel Linke
d81037d658
Simplify branching logic in SearchesController
2022-09-29 09:30:21 +02:00
Maikel Linke
12d7db3dd6
More efficient enterprise access check
2022-09-29 09:30:21 +02:00
Jean-Baptiste Bellet
cdf71b419f
Search within all enterprises if user is the super admin
2022-09-29 09:30:21 +02:00
dependabot[bot]
6f6b1ce9e6
Bump view_component from 2.73.0 to 2.74.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.73.0 to 2.74.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.73.0...v2.74.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-29 07:02:17 +00:00
Maikel
2c2d244c56
Merge pull request #9716 from filipefurtad0/fix_reports_spec
...
Fixes invert columns logic on reports spec
2022-09-29 17:00:38 +10:00
Maikel Linke
c8cfbbb0b2
Use standard ApplicationRecord in task class
...
It's best practice to use the ApplicationRecord. But when Rake is
loaded, our application is not loaded yet and the ApplicationRecord
class wasn't available yet. Requiring within the task solves the problem
because Rake loads the Rails environment before executing this task.
I also removed the unused highline loading.
2022-09-29 11:56:10 +10:00
Maikel
c000c0dd5d
Merge pull request #9709 from openfoodfoundation/dependabot/bundler/view_component-2.73.0
...
Bump view_component from 2.72.0 to 2.73.0
2022-09-29 08:23:09 +10:00
Filipe
958c6fe8f3
Merge pull request #9685 from filipefurtad0/remove_js_tracking_code
...
Removes matomo JS tracking code
2022-09-28 23:15:23 +01:00
Filipe
9cc2d30920
Merge pull request #9642 from mkllnk/9002-customer-association
...
Delete duplicate customer entries
2022-09-28 17:17:23 +01:00
filipefurtad0
e00a59212c
Fixes invert columns logic on reports spec
2022-09-28 11:49:20 +01:00
dependabot[bot]
e783594385
Bump @babel/preset-env from 7.19.1 to 7.19.3
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.19.1 to 7.19.3.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.19.3/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-28 09:03:57 +00:00
Ashwini Seshadri
edee5c693b
Changed new subscription dialog to use tom-select from select2
...
fixed z-index, text-alignment in the dropdown menu to left in new subscription modal, replaced click_link with page.find().click in subscription specs, removed href in subscription index
2022-09-28 10:47:39 +02:00
dependabot[bot]
fea78884e7
Bump view_component from 2.72.0 to 2.73.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.72.0 to 2.73.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.72.0...v2.73.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-28 07:23:18 +00:00
jibees
4f290b5bc5
Merge pull request #9707 from filipefurtad0/remove_visible_true_label
...
Removes "visible: true" from system specs
2022-09-28 09:21:19 +02:00
Maikel
52c38428e8
Merge pull request #9624 from filipefurtad0/add_vcr_to_the_stack
...
Add VCR to the stack
2022-09-28 10:48:59 +10:00
filipefurtad0
538844a1fb
Removes _visible: true_ from system specs
2022-09-27 17:32:25 +01:00
filipefurtad0
4690cb102b
Adds sets-up the cassettes correctly and other configs
...
deletes unecessary files
Reverts helper option to turn VCR off
2022-09-27 07:26:26 +01:00
Maikel Linke
4e33bd2713
Avoid trying to delete address referenced elsewhere
2022-09-27 13:14:51 +10:00
Maikel Linke
286dade66f
Don't enforce ApplicationRecord in migrations
...
We shouldn't use app code in migrations because app code changes while
migrations should always do the same to enable old servers to upgrade.
We have some existing migrations which use ApplicationRecord but I found
that changing them retrospectively breaks them already. So let's leave
them alone.
2022-09-27 13:14:51 +10:00
Maikel Linke
591f901935
Delete duplicate customer entries
2022-09-27 13:14:49 +10:00
Maikel Linke
aec28e0807
Simplify customer model requiring enterprise
2022-09-27 13:14:18 +10:00
Maikel Linke
be31b9a897
Document purpose of customer model
2022-09-27 13:14:18 +10:00
Maikel
6783e7f74c
Fix typo
2022-09-27 12:37:08 +10:00
Maikel
19c9eccffe
Merge pull request #9704 from openfoodfoundation/dependabot/bundler/geocoder-1.8.1
...
Bump geocoder from 1.8.0 to 1.8.1
2022-09-27 12:09:12 +10:00
Maikel
561aa0e291
Merge pull request #9701 from sashashura/patch-6
...
GitHub Workflows security hardening
2022-09-27 11:56:25 +10:00
dependabot[bot]
e45decf14e
Bump geocoder from 1.8.0 to 1.8.1
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/alexreisner/geocoder/releases )
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.8.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: geocoder
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-26 09:32:31 +00:00
jibees
b851aba81a
Merge pull request #9699 from filipefurtad0/localization_number_settings
...
Adds tests to decimal, thousands and localization number settings
2022-09-26 10:57:28 +02:00
jibees
45040ca702
Merge pull request #9696 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.2.0
...
Bump @hotwired/turbo from 7.1.0 to 7.2.0
2022-09-26 10:56:55 +02:00
jibees
126da75167
Merge pull request #9694 from openfoodfoundation/dependabot/bundler/spring-4.1.0
...
Bump spring from 4.0.0 to 4.1.0
2022-09-26 10:55:51 +02:00
jibees
71b24ef8b9
Merge pull request #9690 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.7
...
Bump sidekiq from 6.5.6 to 6.5.7
2022-09-26 10:54:42 +02:00
jibees
4ae93113f0
Merge pull request #9670 from dacook/generate-erd
...
Script to generate ERD
2022-09-26 10:33:06 +02:00
Alex
8ce82a9ad6
build: harden mapi.yml permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com >
2022-09-23 22:52:16 +02:00
Alex
bd6bf9315a
build: harden linters.yml permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com >
2022-09-23 22:51:33 +02:00
filipefurtad0
7b33405530
Replaces translation with actual string
...
DRY: creates update_and_assert_message
2022-09-23 13:00:39 +01:00
filipefurtad0
6e3c0858c1
Adds decimal and thousands separator test
2022-09-23 12:47:18 +01:00
filipefurtad0
fb8d2827d2
Adds number localization preferences test
2022-09-23 12:03:18 +01:00
dependabot[bot]
ae8d505367
Bump @hotwired/turbo from 7.1.0 to 7.2.0
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.1.0 to 7.2.0.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.1.0...v7.2.0 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-23 09:03:43 +00:00
Jean-Baptiste Bellet
cba9779168
Update all locales with the latest Transifex translations
2022-09-22 16:35:32 +02:00
dependabot[bot]
17e9dbc0f7
Bump spring from 4.0.0 to 4.1.0
...
Bumps [spring](https://github.com/rails/spring ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: spring
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-22 09:16:42 +00:00
filipefurtad0
e798277cbf
Adds real requests with concealed secret key
2022-09-21 12:32:49 +01:00
filipefurtad0
3e97433920
Adds VCR config file into support folder
...
...with additional options to vcr_setup
2022-09-21 12:32:49 +01:00
filipefurtad0
038b93fdf6
Adds VCR to the stack
...
...And sets gems in alphabetical order
2022-09-21 12:32:49 +01:00
Rachel Arnould
e98d4af630
Merge pull request #9659 from saunmanoj888/fix-bulk-product-update-unit-value
...
Allow to change unit value for numbers with a comma separator on bulk product update
2022-09-21 13:04:08 +02:00
dependabot[bot]
79374ce5d7
Bump sidekiq from 6.5.6 to 6.5.7
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.5.6 to 6.5.7.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.5.6...v6.5.7 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-21 09:07:14 +00:00
jibees
e0aa94e6af
Merge pull request #9689 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.0.2
...
Bump @floating-ui/dom from 1.0.1 to 1.0.2
2022-09-21 09:21:46 +02:00
Maikel
a4de128a76
Merge pull request #9674 from filipefurtad0/wicked_pdf_config
...
Makes wicked-pdf config ENV-dependent
2022-09-21 13:16:41 +10:00
David Cook
96d1616b70
Update for compatibility with macOS (BSD grep)
...
The --max-count option tells grep to stop reading lines after the first matching line. We're looking for the line AFTER the first matching line.
2022-09-21 12:22:21 +10:00
David Cook
086cde83db
Script to easily generate ERD
...
The generated date is included for reference.
Stored in new 'doc/' directory.
2022-09-21 12:21:49 +10:00
David Cook
4abe677cc6
Add rails-erd gem
...
Only in development environment.
2022-09-21 12:21:46 +10:00
Maikel
fe2e510fdc
Merge pull request #9621 from filipefurtad0/invoice_spec_to_account_for_tax_ordering
...
Invoice spec to account for tax ordering
2022-09-21 10:14:07 +10:00
dependabot[bot]
ae152fd94f
Bump @floating-ui/dom from 1.0.1 to 1.0.2
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.0.2/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-20 09:04:55 +00:00
Maikel
5173ddb7a0
Merge pull request #9675 from filipefurtad0/split_build_consumer_tests
...
Makes build run all specs; fixes failing specs
2022-09-20 11:20:52 +10:00
Filipe
bd698f5d81
Merge pull request #9683 from filipefurtad0/customer_query_superadmin_spec
...
Spec reproducing failing customer query, as superadmin
2022-09-19 15:53:07 +01:00
filipefurtad0
136a4df4d9
Removes matomo JS tracking code
2022-09-19 15:26:07 +01:00
filipefurtad0
7e168fad02
Spec reproduing failing customer query, as superadmin
2022-09-19 14:11:13 +01:00
jibees
c574b2d8ba
Merge pull request #9634 from binarygit/remove-angular-from-shipping-methods
...
Remove shipping methods controller
2022-09-19 14:16:07 +02:00
jibees
502abfdfce
Merge pull request #9681 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.16.1
...
Bump rubocop-rails from 2.16.0 to 2.16.1
2022-09-19 14:13:22 +02:00
jibees
c714204877
Merge pull request #9673 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.19.1
...
Bump @babel/preset-env from 7.19.0 to 7.19.1
2022-09-19 14:13:08 +02:00
dependabot[bot]
cb84f6671a
Bump @babel/preset-env from 7.19.0 to 7.19.1
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.19.0 to 7.19.1.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.19.1/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-19 08:38:38 +00:00
jibees
20c393e4e9
Merge pull request #9680 from openfoodfoundation/dependabot/bundler/shoulda-matchers-5.2.0
...
Bump shoulda-matchers from 5.1.0 to 5.2.0
2022-09-19 10:38:01 +02:00
jibees
8e3cd4653d
Merge pull request #9669 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.5.12
...
Bump @storybook/addon-docs from 6.5.10 to 6.5.12
2022-09-19 10:33:59 +02:00
jibees
b4deb19d8e
Merge pull request #9667 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.5.12
...
Bump @storybook/addon-controls from 6.5.10 to 6.5.12
2022-09-19 10:33:41 +02:00
dependabot[bot]
e30ebd3671
Bump rubocop-rails from 2.16.0 to 2.16.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.16.0 to 2.16.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.16.0...v2.16.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-19 07:58:34 +00:00
dependabot[bot]
b7f8422f30
Bump shoulda-matchers from 5.1.0 to 5.2.0
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v5.1.0...v5.2.0 )
---
updated-dependencies:
- dependency-name: shoulda-matchers
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-19 07:56:59 +00:00
dependabot[bot]
b3d628551e
Bump @storybook/addon-controls from 6.5.10 to 6.5.12
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.5.10 to 6.5.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.12/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.12/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-19 07:55:08 +00:00
dependabot[bot]
70e39174d2
Bump @storybook/addon-docs from 6.5.10 to 6.5.12
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.5.10 to 6.5.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.12/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.12/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-19 07:54:54 +00:00
jibees
b03cfa163a
Merge pull request #9672 from openfoodfoundation/dependabot/bundler/view_component-2.72.0
...
Bump view_component from 2.71.0 to 2.72.0
2022-09-19 09:54:38 +02:00
jibees
4c32548e83
Merge pull request #9668 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.5.12
...
Bump @storybook/server from 6.5.10 to 6.5.12
2022-09-19 09:53:47 +02:00
Jean-Baptiste Bellet
7186526dc6
Fix block too long warnings
2022-09-19 09:26:34 +02:00
filipefurtad0
8c8b262ea1
Sets examples pending and dry running with xit
2022-09-16 15:24:51 +01:00
filipefurtad0
6ae741936f
Scrolls down the page to enable finding element
2022-09-16 15:24:39 +01:00
Jean-Baptiste Bellet
cf8bab97e8
Fix spec by not raising the error image not found
...
`GET http://localhost:3000/throbber.gif 404 (Not Found)`
In the meantime, open an issue to remove jquery.jstree from this page: 9677
2022-09-16 11:04:08 +02:00
Jean-Baptiste Bellet
ba2ad4a0c4
Since #9126 , replacing Paperclip with ActiveStorage, some methods changed
2022-09-16 10:51:04 +02:00
Jean-Baptiste Bellet
4a8dc37b40
Since #9087 , we don't use a boolean but an enum, 'public' or 'hidden'
2022-09-16 10:02:27 +02:00
Jean-Baptiste Bellet
3942c4d808
Fix failing spec: since #9606 we use tom-select
2022-09-16 09:32:34 +02:00
filipefurtad0
ba8162c1d0
Splits consumer specs into two parallel runs
2022-09-15 17:34:01 +01:00
filipefurtad0
bf1fc736b9
Removes _spec.rb ending from admin specs on build.yml
2022-09-15 17:32:48 +01:00
filipefurtad0
bc1ae01eb6
Updates invoice_spec to A3 page size setting
...
Separates display_as in assertion to prevent line break failures
2022-09-15 14:34:15 +01:00
filipefurtad0
e4cceffd5c
Makes wicked-pdf config env dependent
2022-09-15 12:12:47 +01:00
Maikel Linke
887f886110
Update translations
2022-09-15 16:25:33 +10:00
dependabot[bot]
78fa44739f
Bump view_component from 2.71.0 to 2.72.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.71.0 to 2.72.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.71.0...v2.72.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-15 06:22:01 +00:00
Maikel
1f00ddeb3b
Merge pull request #9654 from openfoodfoundation/dependabot/bundler/rswag-specs-2.6.0
...
Bump rswag-specs from 2.5.1 to 2.6.0
2022-09-15 16:17:41 +10:00
dependabot[bot]
46c19580bc
Bump @storybook/server from 6.5.10 to 6.5.12
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.5.10 to 6.5.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.12/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.12/app/server )
---
updated-dependencies:
- dependency-name: "@storybook/server"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-14 09:04:51 +00:00
filipefurtad0
e54acf3ca0
Changes tax parcels into the correct order
...
This should fail now, adding pending example on next commit
Wraps failing assertions around pending block
Addresses rubocop Style/LineEndConcatenation convention
Removes pending blocks
2022-09-14 08:02:45 +01:00
saunmanoj888
498d003684
Add unit specs for the js changes for unit_value
2022-09-13 23:28:27 +05:30
binarygit
90f4b1328b
Remove angular from shipping methods tab in enterprise/edit
2022-09-13 15:20:33 +05:45
dependabot[bot]
0c81ec0202
Bump rswag-specs from 2.5.1 to 2.6.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.5.1...2.6.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-13 00:44:05 +00:00
Maikel
584430d64b
Merge pull request #9655 from openfoodfoundation/dependabot/bundler/rswag-ui-2.6.0
...
Bump rswag-ui from 2.5.1 to 2.6.0
2022-09-13 10:42:41 +10:00
Maikel
8334923a5c
Merge pull request #9653 from openfoodfoundation/dependabot/bundler/rswag-api-2.6.0
...
Bump rswag-api from 2.5.1 to 2.6.0
2022-09-13 10:42:00 +10:00
Maikel
61784ed174
Merge pull request #9656 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.16.0
...
Bump rubocop-rails from 2.15.2 to 2.16.0
2022-09-13 10:40:00 +10:00
Maikel
906bfc5ae8
Merge pull request #9657 from openfoodfoundation/dependabot/bundler/rails-6.1.7
...
Bump rails from 6.1.6.1 to 6.1.7
2022-09-13 10:37:32 +10:00
jibees
5a4b38ec55
Merge pull request #9536 from jibees/9145-Splitcheckout,-add-error-message-when-no-shipping-methods-are-available-to-the-customer
...
Split Checkout: add error message when no shipping methods are available to the customer
2022-09-12 15:22:11 +02:00
saunmanoj888
6917125173
Allow to change unit value for numbers with a comma separator
2022-09-12 15:55:03 +05:30
dependabot[bot]
65506769ab
Bump rails from 6.1.6.1 to 6.1.7
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.6.1 to 6.1.7.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.6.1...v6.1.7 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-12 09:17:01 +00:00
dependabot[bot]
9909e84cb9
Bump rubocop-rails from 2.15.2 to 2.16.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.15.2 to 2.16.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.15.2...v2.16.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-12 09:16:36 +00:00
dependabot[bot]
e00ee364ea
Bump rswag-ui from 2.5.1 to 2.6.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.5.1...2.6.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-12 09:16:16 +00:00
dependabot[bot]
479c895a59
Bump rswag-api from 2.5.1 to 2.6.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.5.1...2.6.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-12 09:14:43 +00:00
Jean-Baptiste Bellet
86cb86e8b5
Add a flash error where no available shipping methods to the customer
...
+ update specs as well
2022-09-12 09:42:26 +02:00
Jean-Baptiste Bellet
9dd3a8bc5a
Store all distributors shipping methods to one array
2022-09-12 09:42:26 +02:00
Maikel
68256346e7
Merge pull request #9644 from filipefurtad0/fix_flaky_search
...
Splits tests into existing/non-existing shops
2022-09-12 14:05:49 +10:00
Maikel
44bf63137a
Merge pull request #9606 from binarygit/remove-angular-from-address
...
Remove Angular from Address Tab
2022-09-12 13:49:54 +10:00
Maikel
e9ad573bcd
Merge pull request #9641 from mkllnk/prod-schema
...
Synchronise db schema with (AU) production
2022-09-12 13:40:57 +10:00
filipefurtad0
215f3e97ad
Splits tests into existing/non-existing shops
...
Sets failing tests as pending for issues #9649 and #5467
2022-09-09 13:08:45 +01:00
Jean-Baptiste Bellet
49f78f3706
Update all locales with the latest Transifex translations
2022-09-08 16:40:17 +02:00
jibees
9563dd6c51
Merge pull request #9497 from jibees/9493-fix-issues-around-rounding-in-imperial-metric-system
...
Avoid floating rounded errors when using imperial or metric system
2022-09-08 16:34:12 +02:00
Rachel Arnould
aa36986d66
Merge pull request #9521 from jibees/create-new-report-revenues-by-hub
...
Create a new report that shows revenues (incl. or excl. taxes) by hub only available for super-admin
2022-09-08 16:10:14 +02:00
jibees
9843e0e450
Merge pull request #9640 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.19.0
...
Bump @babel/preset-env from 7.18.10 to 7.19.0
2022-09-08 09:07:02 +02:00
Jean-Baptiste Bellet
53978de632
Create a new report that show revenues (incl. or excl. taxes) by hub
...
+ Create spec
2022-09-08 09:04:44 +02:00
Maikel
d9f5f7995d
Merge pull request #9611 from mkllnk/9605-tax-total
...
Index tax totals correctly for invoice display
2022-09-08 12:04:19 +10:00
Maikel
f201b9fd11
Merge pull request #9631 from mkllnk/9153-tax-recalculation
...
[Split Checkout] Recalculate tax on summary step
2022-09-08 11:39:44 +10:00
Jean-Baptiste Bellet
d53b2b94b9
When creating new product via /admin/products/new use BigDecimal
...
to avoid bad rounded multiplication
example here:
700*0.001 = 0.7000000000000001
+ update specs as well
2022-09-07 09:17:46 +02:00
Jean-Baptiste Bellet
4452ad2c51
Use BigDecimal to avoir multiplication/division floating errors
...
Like 28.35 * 12 / 12 = 28.350000000000005
+ in js, use parseFloat() to format `12.00` as `12`
2022-09-07 09:17:46 +02:00
Jean-Baptiste Bellet
6594419b22
Add js-big-decimal to work with division and multiplication
...
Use a lib instead of Math.round((value*100)/100)
2022-09-07 09:17:46 +02:00
Maikel Linke
4ba008f31b
Synchronise db schema with production
...
Rails seems to have changed the options in schema.rb at some point to
include more specifics but we didn't record this in our tracked
schema.rb. As a result, production shows changes in that file after
running migrations.
Sometimes I also use production dumps in development, for example to
test migrations. Then the schema is changed for the migration and for
these syntax changes. Synching the schema with migration should
standardise all our setups and and make git diffs clearer.
2022-09-07 16:02:51 +10:00
Maikel
dd2e77a244
Merge pull request #9557 from jibees/9555-update-the-build-env
...
Update the build env. from ubuntu-18.04 to ubuntu-20.04
2022-09-07 13:43:42 +10:00
dependabot[bot]
be561d1032
Bump @babel/preset-env from 7.18.10 to 7.19.0
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.18.10 to 7.19.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.19.0/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-06 09:04:41 +00:00
Jean-Baptiste Bellet
24fc941b4c
Update the build env. from ubuntu-18.04 to ubuntu-20.04
2022-09-06 10:28:26 +02:00
Maikel
21054c1a8a
Merge pull request #9594 from binarygit/remove-angular-from-primary-details
...
Remove Angular from Primary Details Tab
2022-09-06 10:17:14 +10:00
Maikel
0778c5f550
Merge pull request #9607 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.6
...
Bump sidekiq from 6.5.4 to 6.5.6
2022-09-06 10:16:39 +10:00
Maikel Linke
1d04510365
Update totals on summary step
2022-09-05 15:54:33 +10:00
Maikel Linke
6c7a089527
Recalculate tax on summary step
2022-09-05 15:14:08 +10:00
binarygit
abbb61b943
Remove country controller from enterprises/new and Business Details tab
2022-09-05 09:52:27 +05:45
binarygit
36b5cb3b49
Replace country controller with dependent select in address tab
2022-09-05 09:52:27 +05:45
binarygit
0cfe842bd6
Fix typo: dependant to dependent in dependent-select controller
2022-09-05 09:52:27 +05:45
Maikel Linke
eaca953106
Create only required test data for speed
...
It reduced the execution time by 5% on my machine (2-3 seconds).
2022-09-05 13:42:47 +10:00
Maikel Linke
cc5125f49e
Apply related db assertions in tax spec
...
Somehow the helper methods were testing two different orders even though
each spec is using only one order, the one which is currently being
checked out by the user.
So I brought the code closer into the example to easier see what is
related and tested.
I also changed the assertions for the pending spec but can't really
verify them yet until I have completely working code.
2022-09-05 11:40:47 +10:00
Maikel Linke
3f2b3b88eb
Re-use in-memory test objects
...
And reduce code by referring to objects instead of just ids.
2022-09-05 10:59:15 +10:00
Maikel
7101bacc8c
Merge pull request #9620 from openfoodfoundation/dependabot/bundler/rubocop-1.36.0
...
Bump rubocop from 1.35.1 to 1.36.0
2022-09-05 10:30:05 +10:00
Maikel
d76b274d25
Merge pull request #9617 from openfoodfoundation/dependabot/bundler/view_component-2.71.0
...
Bump view_component from 2.69.0 to 2.71.0
2022-09-02 16:56:59 +10:00
dependabot[bot]
8d7f39941a
Bump view_component from 2.69.0 to 2.71.0
...
Bumps [view_component](https://viewcomponent.org ) from 2.69.0 to 2.71.0.
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-02 06:33:40 +00:00
Maikel
95839f88f2
Merge pull request #9623 from mkllnk/fix-storybook
...
Load storybook only in development
2022-09-02 16:32:19 +10:00
Maikel Linke
728eee6d3f
Load storybook after view_component has been loaded automatically
2022-09-02 16:10:19 +10:00
Maikel Linke
7089bd597e
Avoid loading view_component engine manually
...
We load view_component in the application config and it should be
automatic anyway.
2022-09-02 16:08:09 +10:00
Maikel Linke
2aade10aaf
Load storybook only in development
...
The gem is not available in other environments an the app fails to boot.
2022-09-02 16:07:25 +10:00
Maikel
4057df5b93
Merge pull request #9586 from openfoodfoundation/dependabot/bundler/stripe-7.1.0
...
Bump stripe from 7.0.0 to 7.1.0
2022-09-02 13:34:11 +10:00
Filipe
8270a3f386
Merge pull request #9513 from filipefurtad0/matomo_tag_on_register_page
...
Add matomo_tag to /register pages
2022-09-01 10:19:54 +01:00
dependabot[bot]
a2aa5f2607
Bump rubocop from 1.35.1 to 1.36.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.35.1 to 1.36.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.35.1...v1.36.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-01 09:07:43 +00:00
Maikel Linke
30a9e80024
Update translations
2022-09-01 11:55:03 +10:00
Maikel
612001fc3f
Merge pull request #9600 from mkllnk/rubocop
...
Update rubocop config to avoid deprecation
2022-09-01 11:42:15 +10:00
Maikel
2a93968370
Merge pull request #9599 from mkllnk/load-storybook
...
Avoid storybook deprecation warning
2022-09-01 11:41:27 +10:00
Maikel
b0a4fcdc26
Merge pull request #9598 from mkllnk/spec-typos
...
Correct typo in spec which lead to flakiness
2022-09-01 11:39:38 +10:00
Maikel Linke
326b0af35f
Sort tax total by percentage on invoice
2022-09-01 11:19:02 +10:00
Maikel Linke
91eaa522cf
Simplify tax totals helper
2022-08-31 16:47:04 +10:00
Maikel Linke
2a57dc9766
Index tax totals correctly for invoice display
2022-08-31 16:47:04 +10:00
Maikel Linke
f37b681fac
Allow more tax data in the summary
...
I converted the value to a hash so that we can put all information in
there and we won't need the current hash key as percentage any more.
2022-08-31 16:47:04 +10:00
Maikel Linke
f4466b1aad
Spec problem with tax rate summary display
2022-08-31 16:47:04 +10:00
Maikel Linke
33feb7f63f
Test for explicit values, not reusing faulty code
2022-08-31 16:47:04 +10:00
binarygit
02e3184945
Replace angular tooltips in Primary Details tab
2022-08-31 11:51:51 +05:45
Maikel
04778c6fa8
Merge pull request #9597 from saunmanoj888/fix-account-setting-headers-alignment
...
Fix alignment for header Developer settings under Accounts settings
2022-08-31 16:01:41 +10:00
binarygit
8861b6d077
Replace permalinks angular ctrl with stimulus
2022-08-31 10:06:51 +05:45
binarygit
52b1f40acb
Replace select2 with tom-select in primary details tab
2022-08-31 10:06:51 +05:45
Filipe
8ace56956b
Merge pull request #9560 from binarygit/replace-tooltip
...
Replace tooltip on Enterprise Settings /contact page
2022-08-30 16:23:09 +01:00
dependabot[bot]
7718f7c0fc
Bump sidekiq from 6.5.4 to 6.5.6
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.5.4 to 6.5.6.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.5.4...v6.5.6 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-30 09:04:24 +00:00
Maikel
b74c368de2
Merge pull request #9602 from filipefurtad0/fix_flaky_invoice_spec
...
Adds specific tax rates to each type of cost
2022-08-30 09:47:53 +10:00
filipefurtad0
e0a20bf8af
Adds specific tax rates to each type of cost
2022-08-29 17:36:39 +01:00
Maikel Linke
17afdb5912
Update rubocop config to avoid deprecation
2022-08-29 15:31:18 +10:00
Maikel Linke
d55a43d4b1
Avoid storybook deprecation warning
...
Loading the engine directly is deprecated and I followed the current
documentation to load storybook in the app. This avoids a warning:
> DEPRECATION WARNING: This manually engine loading is deprecated and will be removed in v1.0.0. Remove `require "view_component/storybook/engine"`. (called from <top (required)> at config/application.rb:30)
2022-08-29 14:57:14 +10:00
Maikel Linke
bf3da0531e
Correct grammar in spec description
2022-08-29 14:43:43 +10:00
Maikel Linke
3a365b6dc6
Remove useless braces
2022-08-29 14:42:11 +10:00
Maikel Linke
ee7dc821ca
Correct typo in spec which lead to flakiness
...
I'm not sure why this spec passed on CI when it was retried but it was
obviously wrong. Correcting that copy&paste error seems to make the spec
pass.
2022-08-29 14:39:43 +10:00
Maikel
07018370e0
Merge pull request #9595 from openfoodfoundation/dependabot/bundler/jwt-2.5.0
...
Bump jwt from 2.4.1 to 2.5.0
2022-08-29 11:43:27 +10:00
Maikel
bba665e2e1
Merge pull request #9577 from filipefurtad0/invoice-spec
...
Moves invoice_spec.rb into /system; sets :rack_test as webdriver
2022-08-29 11:34:20 +10:00
saunmanoj888
5e69320ff5
Fix header alignmnet
2022-08-27 15:31:19 +05:30
dependabot[bot]
d0242d28d2
Bump jwt from 2.4.1 to 2.5.0
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.4.1 to 2.5.0.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.4.1...v2.5.0 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-26 09:04:29 +00:00
Maikel
9dbdcc9181
Merge pull request #9592 from openfoodfoundation/dependabot/bundler/redis-4.8.0
...
Bump redis from 4.7.1 to 4.8.0
2022-08-25 09:55:45 +10:00
Maikel
7819495d57
Merge pull request #9590 from openfoodfoundation/dependabot/bundler/puma-5.6.5
...
Bump puma from 5.6.4 to 5.6.5
2022-08-25 09:54:50 +10:00
Maikel
8723520848
Merge pull request #9585 from mkllnk/revert-stripe-update
...
Restore ability to check out with Stripe while storing a new card
2022-08-25 09:51:59 +10:00
binarygit
b76d9045ce
Replace power-tip in enterprises/edit/<name>/contact with floatingUI
2022-08-24 13:31:45 +05:45
Maikel
b42d6cf2ac
Merge pull request #9587 from openfoodfoundation/dependabot/bundler/valid_email2-4.0.4
...
Bump valid_email2 from 4.0.3 to 4.0.4
2022-08-24 16:52:13 +10:00
Maikel
f78e72af0d
Merge pull request #9588 from openfoodfoundation/dependabot/bundler/rubocop-1.35.1
...
Bump rubocop from 1.35.0 to 1.35.1
2022-08-24 16:51:14 +10:00
dependabot[bot]
5e021b76b5
Bump valid_email2 from 4.0.3 to 4.0.4
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/micke/valid_email2/releases )
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.3...v4.0.4 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-24 06:50:55 +00:00
Maikel
d03a5458ff
Merge pull request #9582 from openfoodfoundation/dependabot/bundler/view_component-2.69.0
...
Bump view_component from 2.68.0 to 2.69.0
2022-08-24 16:49:45 +10:00
dependabot[bot]
3aef0b4029
Bump stripe from 7.0.0 to 7.1.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v7.0.0...v7.1.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-24 06:48:28 +00:00
Maikel
cd5a83e814
Merge pull request #9581 from openfoodfoundation/dependabot/bundler/webmock-3.18.1
...
Bump webmock from 3.17.1 to 3.18.1
2022-08-24 16:47:45 +10:00
dependabot[bot]
a943d2fee6
Bump redis from 4.7.1 to 4.8.0
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.7.1 to 4.8.0.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.7.1...v4.8.0 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-24 06:47:28 +00:00
Maikel
b016ebd5b4
Merge pull request #9567 from openfoodfoundation/dependabot/bundler/bullet-7.0.3
...
Bump bullet from 7.0.2 to 7.0.3
2022-08-24 16:47:07 +10:00
Maikel
314459df92
Merge pull request #9566 from openfoodfoundation/dependabot/bundler/test-prof-1.0.10
...
Bump test-prof from 1.0.9 to 1.0.10
2022-08-24 16:46:29 +10:00
dependabot[bot]
eb0051c033
Bump puma from 5.6.4 to 5.6.5
...
Bumps [puma](https://github.com/puma/puma ) from 5.6.4 to 5.6.5.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v5.6.4...v5.6.5 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-23 09:04:05 +00:00
dependabot[bot]
ca9a7d255e
Bump rubocop from 1.35.0 to 1.35.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.35.0 to 1.35.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.35.0...v1.35.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-22 09:06:17 +00:00
Maikel Linke
7cb74f2452
Revert "Merge pull request #9456 from openfoodfoundation/dependabot/bundler/activemerchant-1.126.0"
...
This reverts commit 82f38c9aea , reversing
changes made to 689720b749 .
2022-08-22 15:31:57 +10:00
dependabot[bot]
8f42c6fbed
Bump view_component from 2.68.0 to 2.69.0
...
Bumps [view_component](https://viewcomponent.org ) from 2.68.0 to 2.69.0.
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-19 09:05:47 +00:00
dependabot[bot]
bb233c5656
Bump webmock from 3.17.1 to 3.18.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.17.1 to 3.18.1.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.17.1...v3.18.1 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-19 09:05:12 +00:00
filipefurtad0
be021f4697
Removes spec/features from the build-run 🎉
2022-08-17 23:25:02 +01:00
filipefurtad0
f47d86c15b
Sets cuprite as default; sets rack_test in before/after blocks
2022-08-17 23:25:02 +01:00
Filipe
ae391f8af4
Merge pull request #9414 from Philwi/user-generates-api-key
...
Let users view and regenerates api key
2022-08-17 21:36:13 +01:00
Filipe
f28c52342c
Merge pull request #9532 from jibees/9492-translate-404,-500,-422-errors-pages
...
Translate 404, 500, 422 errors pages
2022-08-17 21:12:04 +01:00
Filipe
d3f1d4a5f9
Merge pull request #9529 from Philwi/make-the-shop-url-clickable
...
Make the shop url clickable
2022-08-17 20:47:07 +01:00
Filipe
cedfa35a98
Merge pull request #9341 from jibees/9336-redirect-to-login_path-if-user-is-disabled
...
Disabled_at logic: redirect to login path if user is disabled
2022-08-17 20:33:57 +01:00
Filipe
c11b7ed268
Merge pull request #9407 from Philwi/handle-for-invalid-referer-for-embedded-page-service
...
Handle for invalid referer for embedded page service
2022-08-17 18:40:43 +01:00
Filipe
b992daa1d8
Merge pull request #9510 from binarygit/convert-enterprises/edit-page-to-stimulus
...
Convert enterprises/edit page to stimulus
2022-08-17 18:11:59 +01:00
Filipe
10aa534f52
Merge pull request #9554 from apricot12/9179-Note-on-invoices
...
Add order note at the end of both invoices following current UI patterns.
2022-08-17 17:41:23 +01:00
Filipe
de990b906d
Merge pull request #9563 from aintluks/bulk-coop-report-csv
...
Disable header row bulk_coop report
2022-08-17 16:43:37 +01:00
Maikel Linke
41ef2a4ea5
Run invoice spec as feature spec
2022-08-17 16:30:57 +10:00
filipefurtad0
077479346e
Moves invoice_print_spec into system
2022-08-17 16:21:54 +10:00
binarygit
19c33e4050
Add floating UI
2022-08-17 11:39:13 +05:45
Maikel
1ff3d4a534
Merge pull request #9571 from openfoodfoundation/dependabot/bundler/view_component-2.68.0
...
Bump view_component from 2.64.0 to 2.68.0
2022-08-17 15:06:46 +10:00
dependabot[bot]
8ae6a36b33
Bump bullet from 7.0.2 to 7.0.3
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.0.2 to 7.0.3.
- [Release notes](https://github.com/flyerhzm/bullet/releases )
- [Changelog](https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.2...7.0.3 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-17 04:59:40 +00:00
dependabot[bot]
d8687f30cd
Bump test-prof from 1.0.9 to 1.0.10
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.9 to 1.0.10.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.9...v1.0.10 )
---
updated-dependencies:
- dependency-name: test-prof
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-17 04:58:49 +00:00
Maikel
bff2ddb8db
Merge pull request #9565 from openfoodfoundation/dependabot/bundler/rubocop-1.35.0
...
Bump rubocop from 1.33.0 to 1.35.0
2022-08-17 14:56:36 +10:00
Lucas da Costa
2a9db0eea4
Disable header row bulk_coop report
2022-08-16 16:32:19 -03:00
Filipe
5c41022f76
Merge pull request #9165 from filipefurtad0/tax_split_checkout
...
[Split Checkout] Adds spec to test Tax charges (repoducing issue #9153 )
2022-08-16 19:30:32 +01:00
dependabot[bot]
a9dec41cc1
Bump view_component from 2.64.0 to 2.68.0
...
Bumps [view_component](https://viewcomponent.org ) from 2.64.0 to 2.68.0.
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-16 09:04:18 +00:00
Maikel
918cbb8d92
Merge pull request #9570 from mkllnk/bundle-lock
...
Clean up Gemfile.lock after manual change
2022-08-16 16:16:19 +10:00
Maikel Linke
7cc7de7a5f
Clean up Gemfile.lock
...
It was manually edited before which introduced a couple inconsistencies.
I'm fixing this up here by running `bundle` and restoring the bundler
version.
2022-08-16 16:10:30 +10:00
Maikel Linke
56d8d1eaf7
Scope helper methods to relevant test cases
...
Global methods are usually not a good idea.
2022-08-15 17:34:21 +01:00
dependabot[bot]
b57685e9d5
Bump rubocop from 1.33.0 to 1.35.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.33.0 to 1.35.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.33.0...v1.35.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-15 07:36:07 +00:00
Maikel
a3fa4a0d3e
Merge pull request #9543 from filipefurtad0/remove_selenium_webdriver
...
Removes selenium-webdriver and webdriver gems; updates spec_helper
2022-08-15 17:34:46 +10:00
Maikel Linke
d86aeaa22a
Remove unnecessary after-spec code
2022-08-15 16:51:53 +10:00
filipefurtad0
97f18d7b86
Changes names from helpers to prevent leak between specs
2022-08-15 16:13:37 +10:00
filipefurtad0
bded15a869
Updates spec for inclusive; adds pending related to epic 7540
2022-08-15 16:13:37 +10:00
filipefurtad0
fff5927cdf
Changes pick-up into delivery shipping method
...
On line 62 we set the dependency on the shipping address to calculate taxes. Therefore, we might be better off mocking a delivery-shipping method instead of a pick-up shipping method and assuring the customers shipping address is used for this accordingly.
2022-08-15 16:13:37 +10:00
filipefurtad0
f9881b9af5
Removes if blocks from assert_db_
...
Initianlly, I thought it would be agood idea to have both setups - for included and added tax - in the same file. Hence, the private section would need to cover all cases. The PR has now two separate files, each one for the two tax types, so it seems unecessary to have these if blocks there. I think it is more readable this way.
2022-08-15 16:13:37 +10:00
filipefurtad0
79182a2d32
Removes test on 9131; moves test on 9153 into respective context
2022-08-15 16:13:37 +10:00
Jean-Baptiste Bellet
77eec6e6f3
Check step params and redirect if step is inconsistent to order state
2022-08-15 16:13:37 +10:00
filipefurtad0
a6e3f43344
Adds bug reproducing steps
2022-08-15 16:13:36 +10:00
filipefurtad0
f525a9f5da
Adds inclusive tax-spec
2022-08-15 16:13:36 +10:00
filipefurtad0
2427bfa6ea
Spec tax charging on legacy and split checkout
2022-08-15 16:13:36 +10:00
Maikel Linke
7eea4fdd1c
Adds zone_with_state_member to zone factory
...
And make zone factories more flexible.
2022-08-15 16:13:36 +10:00
Filipe
dde4bd39b2
Merge pull request #9351 from vsmay98/9338-redirect-disabled-user-to-homepage
...
Redirect to homepage with flash error when disabled user trying to access any page
2022-08-12 13:52:19 +01:00
Maikel Linke
091c271237
Spec API key changes more precisely
2022-08-12 15:44:59 +10:00
Philipp Winkler
141a2a507d
Make shop url clickable
2022-08-11 22:14:51 +02:00
Jean-Baptiste Bellet
36aabbb5b6
Update all locales with the latest Transifex translations
2022-08-11 18:14:48 +02:00
Filipe
82f38c9aea
Merge pull request #9456 from openfoodfoundation/dependabot/bundler/activemerchant-1.126.0
...
Bump activemerchant from 1.123.0 to 1.126.0
2022-08-11 17:10:31 +01:00
Filipe
689720b749
Merge pull request #9437 from jibees/8897-preselect-default-card-and-do-not-allow-to-charge-if-no-card-is-marked-as-default
...
User account, Credit cards: Do not allow to check "Allow charges" if no credit cards marked as default
2022-08-11 16:34:42 +01:00
Filipe
50600b9d00
Merge pull request #9462 from openfoodfoundation/dependabot/bundler/pagy-5.10.1
...
Bump pagy from 5.1.2 to 5.10.1
2022-08-11 16:20:03 +01:00
filipefurtad0
232088f3a2
Adds the tag matomo code to the darkswarm template
2022-08-11 15:40:15 +01:00
filipefurtad0
66b9679a7c
Adds matomo_tag to /register pages template
2022-08-11 14:07:02 +01:00
filipefurtad0
42753d85c7
Creates new file for matomo tag code
2022-08-11 14:07:02 +01:00
filipefurtad0
3eca13e2bc
Renames general tracking code file; updates darkswarm
2022-08-11 14:07:02 +01:00
Rachel Arnould
abdef21381
Update FUNDING.yml
2022-08-11 14:45:42 +02:00
filipefurtad0
1fd09617cb
Changes cookies_spec from feature to system spec
2022-08-11 10:44:22 +01:00
filipefurtad0
e5eb74f077
Updates spec_helper
2022-08-11 10:44:22 +01:00
Jean-Baptiste Bellet
f474947d2d
Do not remove 500.html file since it is used by nxginx
...
in case of critical problems when application cannot respond
2022-08-11 11:41:39 +02:00
filipefurtad0
d1b90193a4
Removes selenium-webdriver & webdrivers gems
2022-08-11 10:34:24 +01:00
Nihal Mohammed
53ee5c32eb
Add order note at the end of both invoices following current UI patterns
...
Add translation for note title in invoice
Update invoice spec to also test for order note
2022-08-10 23:02:13 +05:30
binarygit
79ba223e12
Delete angular code for side_menu
2022-08-10 15:14:15 +05:45
binarygit
27552c99b8
Render enterprise groups #edit and #new page using stimulus
2022-08-10 15:14:09 +05:45
binarygit
6b56a8df0a
Display/hide side-menu items when values in primary details change
2022-08-10 15:11:53 +05:45
binarygit
e18a242b90
Render admin/enterprises/<name>/edit page using stimulus
2022-08-10 15:08:59 +05:45
jibees
4a3bd510a7
Merge pull request #9544 from jibees/upgrade-yarn-
...
Upgrade `yarn.lock` since it seemed to be derived
2022-08-10 09:06:16 +02:00
jibees
bb85473eba
Merge pull request #9550 from openfoodfoundation/dependabot/bundler/webmock-3.17.1
...
Bump webmock from 3.17.0 to 3.17.1
2022-08-10 08:57:39 +02:00
jibees
d5fa5e298e
Merge pull request #9551 from openfoodfoundation/dependabot/bundler/debug-1.6.2
...
Bump debug from 1.6.1 to 1.6.2
2022-08-10 08:57:08 +02:00
Jean-Baptiste Bellet
dab4939819
Upgrade yarn.lock since it seemed to be derived
2022-08-10 08:45:24 +02:00
jibees
43b29af922
Merge pull request #9545 from Philwi/control-capybara-headless-mode-via-environment-variable
...
Control capybara headless mode for testing via environment variable
2022-08-10 08:05:26 +02:00
dependabot[bot]
2c1acc14e6
Bump debug from 1.6.1 to 1.6.2
...
Bumps [debug](https://github.com/ruby/debug ) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.6.1...v1.6.2 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-10 06:02:35 +00:00
dependabot[bot]
84f9da4a23
Bump webmock from 3.17.0 to 3.17.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.17.0 to 3.17.1.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.17.0...v3.17.1 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-10 06:00:05 +00:00
jibees
d817319aa4
Merge pull request #9539 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.4
...
Bump sidekiq from 6.5.3 to 6.5.4
2022-08-10 07:58:25 +02:00
Philipp Winkler
093b851395
Control headless mode for testing via environment variable
2022-08-09 20:57:52 +02:00
Filipe
e3a150226e
Merge pull request #9507 from openfoodfoundation/dependabot/bundler/stripe-7.0.0
...
Bump stripe from 5.42.0 to 7.0.0
2022-08-09 12:33:36 +01:00
Rachel Arnould
5122ed9af4
Update FUNDING.yml
2022-08-09 10:11:17 +02:00
Rachel Arnould
ac5a3beb15
Update FUNDING.yml
2022-08-09 10:10:44 +02:00
dependabot[bot]
19481fc55e
Bump sidekiq from 6.5.3 to 6.5.4
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.5.3...v6.5.4 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-09 06:48:01 +00:00
Maikel Linke
c8cab8aae5
Update mocked responses to get a ListObject
2022-08-09 15:13:16 +10:00
dependabot[bot]
d7428015ac
Bump stripe from 5.42.0 to 7.0.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.42.0 to 7.0.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.42.0...v7.0.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-09 15:13:16 +10:00
Maikel
700f91efb5
Merge pull request #9449 from filipefurtad0/packing_report
...
Updates specs on Packing and Payment Reports
2022-08-09 14:56:22 +10:00
Maikel
43e4047447
Merge pull request #9495 from filipefurtad0/invoice_print_spec
...
Invoice print spec: added tax
2022-08-09 14:54:23 +10:00
Maikel
892e843e9e
Merge pull request #9533 from filipefurtad0/remove_bye_bug
...
Removes byebug and pry-byebug; keeps pry 🧹
2022-08-09 10:39:21 +10:00
filipefurtad0
85904f57b8
Removes byebug and pry-byebug; keeps pry
2022-08-08 15:22:45 +01:00
Jean-Baptiste Bellet
60a5bf682b
Handle errors page through controller ErrorsController
2022-08-08 15:36:46 +02:00
Jean-Baptiste Bellet
47c07831c1
Create an ErrorsController that handle errors thrown application
2022-08-08 15:36:23 +02:00
jibees
b5e23717f2
Merge pull request #9531 from mkllnk/awesome-print
...
Remove unnecessary awesome_print gem
2022-08-08 14:21:11 +02:00
jibees
d8d99c930e
Merge pull request #9530 from openfoodfoundation/dependabot/bundler/webmock-3.17.0
...
Bump webmock from 3.15.0 to 3.17.0
2022-08-08 14:09:48 +02:00
filipefurtad0
ce96094f49
Adds around block with time.freeze
2022-08-08 12:23:11 +01:00
Maikel Linke
6c655e6fbc
Remove unnecessary awesome_print gem
...
Most people don't know it and it has now been superseeded by new
versions of irb and debug.
2022-08-08 15:39:59 +10:00
Maikel Linke
2d1483febb
Remove misleading comment
...
That comment was in the original commit of this source code and was
related to another gem which has long been removed.
2022-08-08 15:38:30 +10:00
Maikel
42d7383ff0
Merge pull request #9446 from jibees/add-prettier
...
Add prettier linter for stimulusjs files
2022-08-08 14:41:47 +10:00
Maikel Linke
df4ddf45c4
Only check, not fix in pre-commit hook
2022-08-08 14:40:58 +10:00
Jean-Baptiste Bellet
e0b40222dd
add pre-commit hook
...
with husky and pretty-quick
2022-08-08 14:40:58 +10:00
Jean-Baptiste Bellet
61928cbc05
Run prettier formatter
2022-08-08 14:40:58 +10:00
Jean-Baptiste Bellet
c6884f96e1
Add prettier as a GH action
2022-08-08 14:40:58 +10:00
Jean-Baptiste Bellet
f0b5a04f6b
Ignore everything but js files related to stimulusjs
2022-08-08 14:40:58 +10:00
Jean-Baptiste Bellet
b8ffddb533
Add prettier to our stack
2022-08-08 14:40:58 +10:00
dependabot[bot]
71536767b5
Bump webmock from 3.15.0 to 3.17.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.15.0 to 3.17.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.15.0...v3.17.0 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-08 04:18:03 +00:00
Maikel
938056d1d8
Merge pull request #9453 from openfoodfoundation/dependabot/bundler/angular_rails_csrf-5.0.0
...
Bump angular_rails_csrf from 4.5.0 to 5.0.0
2022-08-08 14:16:56 +10:00
Maikel
63d2d69d08
Clarify copying of test build URL
...
And removing an unused translation step
2022-08-08 12:47:28 +10:00
Maikel
78ec086111
Merge pull request #9501 from Michaelcode2/master
...
Added file "uk.yml" to directory openfoodnetwork/config/locales/
2022-08-08 12:34:01 +10:00
Philipp Winkler
bf53a02270
Add api key toggle view checkbox
2022-08-07 09:48:49 +02:00
filipefurtad0
2aded5b459
Clarifies pending examples
2022-08-05 17:43:02 +01:00
filipefurtad0
5aa6b14756
Fixes tax values
2022-08-05 16:41:35 +01:00
filipefurtad0
07bd84ffbb
Tests added tax - legacy and alternative invoices
2022-08-05 16:41:35 +01:00
filipefurtad0
d2794f328f
Tests included tax - legacy and alternative invoices
2022-08-05 16:41:35 +01:00
filipefurtad0
8b146fc72a
Adds included_in_price trait on broken specs
2022-08-05 16:41:35 +01:00
filipefurtad0
0c491a6651
Adds test case for added tax
2022-08-05 16:41:35 +01:00
filipefurtad0
e8529754f1
Updates order and product factory to consider added tax
2022-08-05 16:41:35 +01:00
dependabot[bot]
d95dc84c34
Bump pagy from 5.1.2 to 5.10.1
...
Bumps [pagy](https://github.com/ddnexus/pagy ) from 5.1.2 to 5.10.1.
- [Release notes](https://github.com/ddnexus/pagy/releases )
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ddnexus/pagy/compare/5.1.2...5.10.1 )
---
updated-dependencies:
- dependency-name: pagy
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-05 14:59:59 +00:00
Filipe
b61ee0211f
Merge pull request #9525 from filipefurtad0/adds_debug_gem
...
Adds debug gem to the stack
2022-08-05 15:58:45 +01:00
filipefurtad0
c777a00874
Adds debug gem to the stack, bundled with 2.1.4
2022-08-05 14:01:47 +01:00
jibees
a0a2dab44f
Merge pull request #9523 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.3
...
Bump sidekiq from 6.5.1 to 6.5.3
2022-08-05 11:31:58 +02:00
jibees
f0aa7f44a5
Merge pull request #9524 from openfoodfoundation/dependabot/bundler/rubocop-1.33.0
...
Bump rubocop from 1.32.0 to 1.33.0
2022-08-05 11:31:18 +02:00
dependabot[bot]
a51940937a
Bump rubocop from 1.32.0 to 1.33.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.32.0 to 1.33.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.32.0...v1.33.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-05 09:06:01 +00:00
dependabot[bot]
f1e401070a
Bump sidekiq from 6.5.1 to 6.5.3
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.5.1 to 6.5.3.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.5.1...v6.5.3 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-05 09:05:41 +00:00
Jean-Baptiste Bellet
999b04ef99
Update all locales with the latest Transifex translations
2022-08-05 09:18:05 +02:00
Maikel
da5e8fcb9f
Merge pull request #9130 from georgethoppil/remove-from-customerlist
...
Update orders and delete subscriptions when customer deleted
2022-08-05 10:35:07 +10:00
Rachel Arnould
e22b9997fe
Update README.md
2022-08-04 16:58:51 +02:00
dependabot[bot]
609cbe2893
Bump angular_rails_csrf from 4.5.0 to 5.0.0
...
Bumps [angular_rails_csrf](https://github.com/jsanders/angular_rails_csrf ) from 4.5.0 to 5.0.0.
- [Release notes](https://github.com/jsanders/angular_rails_csrf/releases )
- [Changelog](https://github.com/jsanders/angular_rails_csrf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jsanders/angular_rails_csrf/compare/v4.5.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: angular_rails_csrf
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 12:15:53 +00:00
jibees
425970aba2
Merge pull request #9519 from openfoodfoundation/dependabot/bundler/view_component-2.64.0
...
Bump view_component from 2.63.0 to 2.64.0
2022-08-04 14:14:32 +02:00
jibees
ace5151afa
Merge pull request #9518 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.5.10
...
Bump @storybook/addon-docs from 6.5.9 to 6.5.10
2022-08-04 14:14:14 +02:00
jibees
3b652581b5
Merge pull request #9517 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.5.10
...
Bump @storybook/server from 6.5.9 to 6.5.10
2022-08-04 14:14:06 +02:00
jibees
17692e722a
Merge pull request #9516 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.5.10
...
Bump @storybook/addon-controls from 6.5.9 to 6.5.10
2022-08-04 14:13:56 +02:00
jibees
a2826b0fdf
Merge pull request #9515 from openfoodfoundation/dependabot/bundler/angular-rails-templates-1.2.0
...
Bump angular-rails-templates from 1.1.0 to 1.2.0
2022-08-04 14:13:43 +02:00
dependabot[bot]
d766f6c0b2
Bump view_component from 2.63.0 to 2.64.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.63.0 to 2.64.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.63.0...v2.64.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 09:06:59 +00:00
dependabot[bot]
0f715e531c
Bump @storybook/addon-docs from 6.5.9 to 6.5.10
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.5.9 to 6.5.10.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.10/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.10/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 09:05:54 +00:00
dependabot[bot]
fba83f847b
Bump @storybook/server from 6.5.9 to 6.5.10
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.5.9 to 6.5.10.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.10/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.10/app/server )
---
updated-dependencies:
- dependency-name: "@storybook/server"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 09:05:41 +00:00
dependabot[bot]
5603745744
Bump @storybook/addon-controls from 6.5.9 to 6.5.10
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.5.9 to 6.5.10.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.10/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.5.10/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 09:05:26 +00:00
dependabot[bot]
2b2f9c205e
Bump angular-rails-templates from 1.1.0 to 1.2.0
...
Bumps [angular-rails-templates](https://github.com/pitr/angular-rails-templates ) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/pitr/angular-rails-templates/releases )
- [Changelog](https://github.com/pitr/angular-rails-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pitr/angular-rails-templates/compare/v1.1.0...v1.2.0 )
---
updated-dependencies:
- dependency-name: angular-rails-templates
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-04 09:05:14 +00:00
jibees
feff2b726b
Merge pull request #9430 from openfoodfoundation/dependabot/bundler/rspec-rails-5.1.2
...
Bump rspec-rails from 5.0.2 to 5.1.2
2022-08-04 09:51:54 +02:00
Maikel Linke
8b3d513aa2
Don't upgrade rspec-mocks which seems to be buggy
...
One of our specs failed even though it was correct:
- spec/controllers/spree/admin/base_controller_spec.rb
2022-08-04 15:54:43 +10:00
Filipe
dd17f98edb
Merge pull request #9196 from jibees/8912-change-order-creation-form-steps-order
...
Admin, Order creation: Change steps ordering
2022-08-03 09:09:43 +01:00
Maikel
c9adcd1479
Merge pull request #9406 from filipefurtad0/oaf_reports_specs
...
Orders and fulfilments report specs improvement (cont. #9350 )
2022-08-03 15:25:38 +10:00
jibees
29c8b0b1a5
Merge pull request #9504 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.18.10
...
Bump @babel/preset-env from 7.18.9 to 7.18.10
2022-08-02 15:13:04 +02:00
jibees
6404c7427c
Merge pull request #9503 from openfoodfoundation/dependabot/bundler/webmock-3.15.0
...
Bump webmock from 3.14.0 to 3.15.0
2022-08-02 15:12:39 +02:00
jibees
85eab5b436
Merge pull request #9502 from openfoodfoundation/dependabot/bundler/view_component-2.63.0
...
Bump view_component from 2.62.0 to 2.63.0
2022-08-02 15:12:08 +02:00
Michael
912713a0c9
added Ukrainian lang. file uk.yml, corrected uk:Ukrainian
2022-08-02 13:22:17 +03:00
dependabot[bot]
ca3b9f8085
Bump @babel/preset-env from 7.18.9 to 7.18.10
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.18.9 to 7.18.10.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-02 09:08:43 +00:00
dependabot[bot]
ac00a20639
Bump webmock from 3.14.0 to 3.15.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.14.0 to 3.15.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.14.0...v3.15.0 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-02 09:07:46 +00:00
dependabot[bot]
139c994e06
Bump view_component from 2.62.0 to 2.63.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.62.0 to 2.63.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.62.0...v2.63.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-02 09:05:18 +00:00
Michael
3621616f7c
Delete en_UA.yml
2022-08-02 11:53:17 +03:00
Michael
41ddd653a0
Added file "uk.yml" to openfoodnetwork/config/locales/
...
Added file "uk.yml" to directory openfoodnetwork/config/locales/
Ukrainian language translation (UA)
2022-08-02 11:52:36 +03:00
Michael
d8c7c0141a
added Ukrainian translation file en_UA.yml
2022-08-02 11:34:12 +03:00
Rachel Arnould
3fa2dd4772
Merge pull request #9496 from saunmanoj888/change-translation-calculator-to-fees
...
Change translation for calculator section from Calculator to Fees
2022-08-02 10:10:23 +02:00
Rachel Arnould
cf26c465cc
Merge pull request #9390 from binarygit/feature/update-orders-table
...
Feature/update orders table
2022-08-02 10:10:03 +02:00
Rachel Arnould
1bc50fd7cb
Merge pull request #9404 from jibees/9384-reports-format-all-money-as-number
...
Admin, Reports: format all currency columns as numerical values (and no as currency value)
2022-08-02 10:09:22 +02:00
Maikel
719724de0b
Merge pull request #9440 from mkllnk/webp
...
Support WEBP images again
2022-08-02 17:19:24 +10:00
saunmanoj888
804ed81acb
Change translation for calculator section from Calculator to Fees
2022-07-31 01:04:02 +05:30
jibees
e980f8882c
Merge pull request #9476 from openfoodfoundation/dependabot/bundler/bootsnap-1.13.0
...
Bump bootsnap from 1.12.0 to 1.13.0
2022-07-29 17:07:40 +02:00
dependabot[bot]
73f910e90c
Bump bootsnap from 1.12.0 to 1.13.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.12.0...v1.13.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-29 09:03:09 +00:00
jibees
5135d32cd8
Merge pull request #9472 from openfoodfoundation/dependabot/bundler/dotenv-rails-2.8.1
...
Bump dotenv-rails from 2.7.6 to 2.8.1
2022-07-28 15:12:19 +02:00
jibees
91d87c887b
Merge pull request #9469 from openfoodfoundation/dependabot/bundler/pdf-reader-2.10.0
...
Bump pdf-reader from 2.5.0 to 2.10.0
2022-07-28 15:10:52 +02:00
georgethoppil
786fe55fc8
Removing dependent destroy on order
2022-07-28 13:41:15 +02:00
georgethoppil
b202678a6b
Delete proxy orders when subscription is deleted
2022-07-28 13:41:14 +02:00
GeorgeThoppil
0e8d2d307b
Clearer translation wording for has_associated_subscriptions
2022-07-28 13:41:14 +02:00
GeorgeThoppil
832b8caa8b
Update spec when deleting customer with subscription and remove unused translation key
2022-07-28 13:41:14 +02:00
GeorgeThoppil
a50b75659f
Update orders and delete subscriptions when customer deleted
2022-07-28 13:41:14 +02:00
dependabot[bot]
df44898557
Bump dotenv-rails from 2.7.6 to 2.8.1
...
Bumps [dotenv-rails](https://github.com/bkeepers/dotenv ) from 2.7.6 to 2.8.1.
- [Release notes](https://github.com/bkeepers/dotenv/releases )
- [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md )
- [Commits](https://github.com/bkeepers/dotenv/compare/v2.7.6...v2.8.1 )
---
updated-dependencies:
- dependency-name: dotenv-rails
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-28 09:04:46 +00:00
dependabot[bot]
5a70985e0e
Bump rspec-rails from 5.0.2 to 5.1.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.0.2 to 5.1.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.0.2...v5.1.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-28 08:50:45 +00:00
Jean-Baptiste Bellet
4791b570e4
Update specs ; Expect customer creation later when creating order
...
The terms are a bit confusing. Updating "Customer Details" updates attributes of the order which will later be used to create a customer.
Customers are not created while the order is in `cart` state. That happens later when the order advances automatically.
2022-07-28 09:52:37 +02:00
Jean-Baptiste Bellet
f087b7184c
Update specs to reflect order steps changes
2022-07-28 09:31:42 +02:00
Jean-Baptiste Bellet
fa9c2b24f2
Select Customer Details as step title for Set Distribution step
2022-07-28 09:31:42 +02:00
Jean-Baptiste Bellet
e3683d25ca
Change second step order: Customer Details instead of Order Details
...
This second step comes from a first one, which is Set Distribution
2022-07-28 09:31:42 +02:00
dependabot[bot]
21c0baa965
Bump activemerchant from 1.123.0 to 1.126.0
...
Bumps [activemerchant](https://github.com/activemerchant/active_merchant ) from 1.123.0 to 1.126.0.
- [Release notes](https://github.com/activemerchant/active_merchant/releases )
- [Changelog](https://github.com/activemerchant/active_merchant/blob/master/CHANGELOG )
- [Commits](https://github.com/activemerchant/active_merchant/compare/v1.123.0...v1.126.0 )
---
updated-dependencies:
- dependency-name: activemerchant
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-28 01:10:42 +00:00
Maikel Linke
75a8d9caf0
Update translations
2022-07-28 11:09:29 +10:00
Maikel
1089a66fff
Merge pull request #9465 from openfoodfoundation/dependabot/bundler/rails-6.1.6.1
...
Bump rails from 6.1.6 to 6.1.6.1
2022-07-28 11:08:39 +10:00
jibees
1feb7b4065
Merge pull request #9457 from openfoodfoundation/dependabot/bundler/i18n-1.12.0
...
Bump i18n from 1.8.10 to 1.12.0
2022-07-27 16:12:45 +02:00
dependabot[bot]
e7cbcf2b51
Bump pdf-reader from 2.5.0 to 2.10.0
...
Bumps [pdf-reader](https://github.com/yob/pdf-reader ) from 2.5.0 to 2.10.0.
- [Release notes](https://github.com/yob/pdf-reader/releases )
- [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG )
- [Commits](https://github.com/yob/pdf-reader/compare/v2.5.0...v2.10.0 )
---
updated-dependencies:
- dependency-name: pdf-reader
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 14:12:07 +00:00
jibees
7b7c6ec7d7
Merge pull request #9467 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.22
...
Bump combine_pdf from 1.0.21 to 1.0.22
2022-07-27 16:09:38 +02:00
jibees
db99ecf255
Merge pull request #9466 from openfoodfoundation/dependabot/bundler/json-2.6.2
...
Bump json from 2.6.1 to 2.6.2
2022-07-27 16:09:23 +02:00
dependabot[bot]
87846529a2
Bump combine_pdf from 1.0.21 to 1.0.22
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.21 to 1.0.22.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.21...v1.0.22 )
---
updated-dependencies:
- dependency-name: combine_pdf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 13:01:48 +00:00
dependabot[bot]
e50f298a0a
Bump i18n from 1.8.10 to 1.12.0
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.8.10 to 1.12.0.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.8.10...v1.12.0 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 13:00:22 +00:00
dependabot[bot]
bbc54d4467
Bump json from 2.6.1 to 2.6.2
...
Bumps [json](https://github.com/flori/json ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/compare/v2.6.1...v2.6.2 )
---
updated-dependencies:
- dependency-name: json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 13:00:22 +00:00
Jean-Baptiste Bellet
006bcd2cf8
Add Symbol class allowed for YAML deserialization
2022-07-27 15:00:19 +02:00
jibees
e56c803610
Merge pull request #9464 from openfoodfoundation/dependabot/bundler/bootsnap-1.12.0
...
Bump bootsnap from 1.10.1 to 1.12.0
2022-07-27 14:58:56 +02:00
jibees
5a9ff58bcf
Merge pull request #9463 from openfoodfoundation/dependabot/bundler/active_storage_validations-0.9.8
...
Bump active_storage_validations from 0.9.7 to 0.9.8
2022-07-27 11:27:48 +02:00
Jean-Baptiste Bellet
7747f2592e
Add BigDecimal classe allowed for YAML deserialization
...
The soft enforcement of the Rails 6.1.6.1 security update in picked up
one more classes that were serialized in the database with YAML: BigDecimal
2022-07-27 11:26:42 +02:00
dependabot[bot]
59504c3d84
Bump rails from 6.1.6 to 6.1.6.1
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.6 to 6.1.6.1.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.6...v6.1.6.1 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 07:29:49 +00:00
dependabot[bot]
57535af982
Bump bootsnap from 1.10.1 to 1.12.0
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.10.1 to 1.12.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.10.1...v1.12.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 07:29:10 +00:00
dependabot[bot]
66358240dc
Bump active_storage_validations from 0.9.7 to 0.9.8
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 0.9.7 to 0.9.8.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/commits/0.9.8 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 07:28:51 +00:00
jibees
a283a7fe49
Merge pull request #9451 from openfoodfoundation/dependabot/bundler/rubocop-1.32.0
...
Bump rubocop from 1.22.2 to 1.32.0
2022-07-27 09:27:23 +02:00
jibees
42cdfe3c1e
Merge pull request #9455 from openfoodfoundation/dependabot/bundler/test-unit-3.5.3
...
Bump test-unit from 3.5.0 to 3.5.3
2022-07-27 09:26:52 +02:00
jibees
806dd6254b
Merge pull request #9461 from openfoodfoundation/dependabot/bundler/valid_email2-4.0.3
...
Bump valid_email2 from 4.0.0 to 4.0.3
2022-07-27 09:26:34 +02:00
jibees
40b53442a8
Merge pull request #9460 from openfoodfoundation/dependabot/bundler/capybara-3.37.1
...
Bump capybara from 3.36.0 to 3.37.1
2022-07-27 09:26:01 +02:00
dependabot[bot]
7662d3fd6a
Bump rubocop from 1.22.2 to 1.32.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.22.2 to 1.32.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.22.2...v1.32.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 06:29:18 +00:00
dependabot[bot]
e4ea9d8cd1
Bump test-unit from 3.5.0 to 3.5.3
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.0 to 3.5.3.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.0...3.5.3 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 06:29:16 +00:00
dependabot[bot]
c6374555b9
Bump valid_email2 from 4.0.0 to 4.0.3
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.0 to 4.0.3.
- [Release notes](https://github.com/micke/valid_email2/releases )
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.0...v4.0.3 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 06:28:36 +00:00
dependabot[bot]
bda5ca33d9
Bump capybara from 3.36.0 to 3.37.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.36.0 to 3.37.1.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.36.0...3.37.1 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 06:28:11 +00:00
jibees
7a10037de8
Merge pull request #9459 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.15.2
...
Bump rubocop-rails from 2.13.2 to 2.15.2
2022-07-27 08:27:58 +02:00
jibees
a8d5fede17
Merge pull request #9458 from openfoodfoundation/dependabot/bundler/view_component-2.62.0
...
Bump view_component from 2.57.1 to 2.62.0
2022-07-27 08:27:01 +02:00
dependabot[bot]
daa2bd5127
Bump rubocop-rails from 2.13.2 to 2.15.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.13.2 to 2.15.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.13.2...v2.15.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 02:08:59 +00:00
dependabot[bot]
506574aefd
Bump view_component from 2.57.1 to 2.62.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.57.1 to 2.62.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.57.1...v2.62.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-27 02:08:12 +00:00
Maikel
4f099da58f
Merge pull request #9452 from openfoodfoundation/dependabot/bundler/rswag-specs-2.5.1
...
Bump rswag-specs from 2.4.0 to 2.5.1
2022-07-27 12:06:50 +10:00
Maikel Linke
59c9f0957b
Simplify default card logic
2022-07-27 11:14:18 +10:00
jibees
6baa36cdaa
Merge pull request #9454 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.5
...
Bump rails-i18n from 7.0.1 to 7.0.5
2022-07-26 17:15:10 +02:00
jibees
e0a8b320a9
Merge pull request #9450 from openfoodfoundation/dependabot/bundler/timecop-0.9.5
...
Bump timecop from 0.9.4 to 0.9.5
2022-07-26 17:12:24 +02:00
filipefurtad0
116f503cf6
Updates Payments reports spec
2022-07-26 16:07:29 +01:00
filipefurtad0
023ebe1909
Asserts on pre-filling of dates; removes manual date selection
2022-07-26 16:07:29 +01:00
dependabot[bot]
d54eb48662
Bump rswag-specs from 2.4.0 to 2.5.1
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.4.0 to 2.5.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.4.0...2.5.1 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-26 14:13:06 +00:00
dependabot[bot]
542e8e22bf
Bump rails-i18n from 7.0.1 to 7.0.5
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.1 to 7.0.5.
- [Release notes](https://github.com/svenfuchs/rails-i18n/releases )
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/commits/v7.0.5 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-26 14:12:46 +00:00
dependabot[bot]
e0426d6dc0
Bump timecop from 0.9.4 to 0.9.5
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.4 to 0.9.5.
- [Release notes](https://github.com/travisjeffery/timecop/releases )
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.4...v0.9.5 )
---
updated-dependencies:
- dependency-name: timecop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-26 14:10:19 +00:00
jibees
a09900c98d
Merge pull request #9433 from openfoodfoundation/dependabot/bundler/rswag-api-2.5.1
...
Bump rswag-api from 2.4.0 to 2.5.1
2022-07-26 16:10:15 +02:00
jibees
f563fcad7f
Merge pull request #9434 from openfoodfoundation/dependabot/bundler/letter_opener-1.8.1
...
Bump letter_opener from 1.7.0 to 1.8.1
2022-07-26 16:09:56 +02:00
jibees
34b76f8683
Merge pull request #9401 from openfoodfoundation/dependabot/bundler/selenium-webdriver-4.3.0
...
Bump selenium-webdriver from 4.0.3 to 4.3.0
2022-07-26 16:09:42 +02:00
jibees
ec82bdda97
Merge pull request #9376 from openfoodfoundation/dependabot/bundler/jwt-2.4.1
...
Bump jwt from 2.3.0 to 2.4.1
2022-07-26 16:09:32 +02:00
jibees
e4c2df4989
Merge pull request #9326 from openfoodfoundation/dependabot/bundler/sidekiq-6.5.1
...
Bump sidekiq from 6.3.1 to 6.5.1
2022-07-26 16:09:22 +02:00
jibees
a1f577dc01
Merge pull request #9400 from openfoodfoundation/dependabot/bundler/rswag-ui-2.5.1
...
Bump rswag-ui from 2.4.0 to 2.5.1
2022-07-26 16:09:11 +02:00
jibees
edbf92424d
Merge pull request #9377 from openfoodfoundation/dependabot/bundler/paranoia-2.6.0
...
Bump paranoia from 2.4.3 to 2.6.0
2022-07-26 16:08:58 +02:00
jibees
35c18664fc
Merge pull request #9389 from jibees/9388-handle-plural-in-order-selection-component
...
Handle plural (and 0) on orders selection component
2022-07-26 15:57:58 +02:00
jibees
be568cdfa6
Update config/locales/en.yml
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-07-26 14:42:55 +02:00
Jean-Baptiste Bellet
0bb90d764c
Allow charges is disabled if no saved cards marked as default
2022-07-26 14:42:55 +02:00
Jean-Baptiste Bellet
34c8748b9c
Mark the next credit cards with payment profile as default
2022-07-26 14:42:55 +02:00
Jean-Baptiste Bellet
875c22346e
Add a tooltip on <td /> when input is disabled, ie no default saved cards
...
Co-Authored-By: Maikel <maikel@email.org.au >
2022-07-26 14:42:54 +02:00
filipefurtad0
c57d5a2408
Updates spec to smoke-test Pack by Product
2022-07-26 12:49:08 +01:00
Maikel
825058472b
Merge pull request #9425 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.1.0
...
Bump stimulus from 3.0.1 to 3.1.0
2022-07-26 16:49:33 +10:00
Maikel Linke
b419f063dc
Support WEBP images again
...
We introduced a list of formats we support and forgot to add webp. Now I
added that as allowed format again and modified the error message.
I removed the first sentence from the error message because it's very
similar to the default error which is shown as well.
2022-07-26 11:09:41 +10:00
Maikel Linke
0ebc803e22
Simplify reports SQL query
2022-07-26 11:05:41 +10:00
dependabot[bot]
cd2119707a
Bump rswag-ui from 2.4.0 to 2.5.1
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.4.0 to 2.5.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.4.0...2.5.1 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:56:05 +00:00
dependabot[bot]
8c27406a7a
Bump paranoia from 2.4.3 to 2.6.0
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.4.3 to 2.6.0.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/2.4.3...v2.6.0 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:55:49 +00:00
dependabot[bot]
b6defc76a8
Bump jwt from 2.3.0 to 2.4.1
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.3.0 to 2.4.1.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.3.0...v2.4.1 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:55:29 +00:00
dependabot[bot]
50529d7ab3
Bump sidekiq from 6.3.1 to 6.5.1
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.3.1 to 6.5.1.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.3.1...v6.5.1 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:55:12 +00:00
dependabot[bot]
b695f3d47f
Bump selenium-webdriver from 4.0.3 to 4.3.0
...
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium ) from 4.0.3 to 4.3.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.3.0 )
---
updated-dependencies:
- dependency-name: selenium-webdriver
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:54:43 +00:00
dependabot[bot]
90ce61fa47
Bump letter_opener from 1.7.0 to 1.8.1
...
Bumps [letter_opener](https://github.com/ryanb/letter_opener ) from 1.7.0 to 1.8.1.
- [Release notes](https://github.com/ryanb/letter_opener/releases )
- [Changelog](https://github.com/ryanb/letter_opener/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ryanb/letter_opener/compare/v1.7.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: letter_opener
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:13:23 +00:00
dependabot[bot]
7c2352f2d6
Bump rswag-api from 2.4.0 to 2.5.1
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.4.0 to 2.5.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.4.0...2.5.1 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:13:07 +00:00
dependabot[bot]
ef7194af85
Bump stimulus from 3.0.1 to 3.1.0
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.0.1...v3.1.0 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-25 14:12:14 +00:00
Jean-Baptiste Bellet
09adc8f690
In Enterprise Fees Summary report, SUM column should be numeric
...
+ update specs as well
2022-07-25 15:08:39 +02:00
filipefurtad0
86b448445f
Adds test cases on Distributor Totals by Supplier
2022-07-22 14:05:33 +01:00
filipefurtad0
ba9ba7da95
Adds test cases to OC Supplier Totals by Distributor
2022-07-22 14:05:33 +01:00
filipefurtad0
f02e1ea04a
Adds test cases to Order Cycle Supplier Totals
2022-07-22 14:05:33 +01:00
filipefurtad0
f88b31ec67
Adds assertion on table headers for different sub-report types
2022-07-22 14:05:33 +01:00
filipefurtad0
6906dd47e8
Changes I18n to strings and cleans up Order Cycle Customer Totals
2022-07-22 14:04:58 +01:00
Jean-Baptiste Bellet
2a35c48498
Do not format price as currency, but as number
...
for all the `Packing Reports`, ie
Pack By Customer
Pack By Supplier
Pack By Product
2022-07-22 09:28:36 +02:00
Jean-Baptiste Bellet
ce0031934a
Do not format sum_total as currency, but as number
...
For the `Bulk Co-op Supplier Report` report
2022-07-22 09:27:52 +02:00
Jean-Baptiste Bellet
4766c7a00b
Update all locales with the latest Transifex translations
2022-07-21 17:42:52 +02:00
jibees
9d470c7a18
Merge pull request #9416 from aintluks/fix-label-button-terms-of-service
...
Fix button labels on terms of service
2022-07-21 17:38:28 +02:00
jibees
9cb0d66f39
Merge pull request #9426 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.18.9
...
Bump @babel/preset-env from 7.18.6 to 7.18.9
2022-07-21 17:38:07 +02:00
dependabot[bot]
7ba6f8c04b
Bump @babel/preset-env from 7.18.6 to 7.18.9
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.18.6 to 7.18.9.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.18.9/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-21 15:03:18 +00:00
jibees
19ff6d011a
Merge pull request #9415 from saunmanoj888/fix-for-shipping-method-radio-button
...
Fix text alignment for category radio button under shipping method
2022-07-21 17:02:29 +02:00
jibees
9b1dcdcc78
Merge pull request #9412 from binarygit/optimize-notes-and-tracking-workflow
...
Optimize notes and tracking workflow
2022-07-21 17:02:03 +02:00
jibees
5eb3c486b2
Merge pull request #9383 from jibees/9382-can-send-invoice-if-ABN-is-not-required
...
Can send invoice if ABN is not required
2022-07-21 17:01:41 +02:00
jibees
20ee0d5009
Merge pull request #9301 from mkllnk/3975-unsupported-image
...
Allow SVG images for products and show errors when uploading unsupported file
2022-07-21 16:56:11 +02:00
Jean-Baptiste Bellet
a3cb1e6ecc
Can Allow charges only if one card is marked as default
2022-07-21 14:42:36 +02:00
jibees
89d68c7708
Merge pull request #9374 from openfoodfoundation/dependabot/bundler/spring-4.0.0
...
Bump spring from 3.0.0 to 4.0.0
2022-07-21 08:56:33 +02:00
jibees
371d517436
Merge pull request #9432 from mkllnk/mayhem
...
Run Mayhem for API only when triggered manually
2022-07-21 08:51:12 +02:00
jibees
17a016eca5
Merge pull request #9431 from mkllnk/roo
...
Bump roo from old master to 2.9.0
2022-07-21 08:46:06 +02:00
Jean-Baptiste Bellet
2b67a0fa80
Specify a list of content-types
...
Then remove specific image format that aren't handled by a web browser (such as `image/x+xcf)`
+ List allowed image formats for enterprises and groups
2022-07-21 08:42:17 +02:00
Maikel Linke
84fcc8f1ac
Upgrade spring binstubs
...
I ran `bundle exec spring binstub --all` after reading about the update
in the changelog.
2022-07-21 10:55:31 +10:00
Maikel
baefe37d0b
Merge pull request #9367 from openfoodfoundation/dependabot/bundler/activerecord-import-1.4.0
...
Bump activerecord-import from 1.3.0 to 1.4.0
2022-07-21 10:45:56 +10:00
Maikel Linke
1e13d579ba
Run Mayhem for API only when triggered manually
...
It currently always fails and we are not using it. We may use it in the
future though and the results can be interesting. So I'm keeping it but
it's not triggered on every pull request. How to trigger:
https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow#running-a-workflow
2022-07-21 10:37:58 +10:00
Maikel Linke
becfb09b3c
Bump roo from old master to 2.9.0
...
This release doesn't include the latest two pull requests but we don't
need those features and it's an upgrade already. Dependabot will now
pick up new releases instead of every new commit to the master branch of
the gem source. That should be less work for us.
2022-07-21 10:29:45 +10:00
Filipe
4767030035
Merge pull request #9429 from filipefurtad0/matomo_tag_change
...
Adds js window element to container code
2022-07-20 10:27:16 +01:00
filipefurtad0
b20385db95
Moves matomo tag to upper position within head section
2022-07-20 09:38:37 +01:00
jibees
019911068a
Merge pull request #9402 from openfoodfoundation/dependabot/bundler/oauth2-1.4.10
...
Bump oauth2 from 1.4.7 to 1.4.10
2022-07-20 09:36:19 +02:00
jibees
da266fed40
Merge pull request #9428 from openfoodfoundation/dependabot/npm_and_yarn/terser-4.8.1
...
Bump terser from 4.8.0 to 4.8.1
2022-07-20 09:35:39 +02:00
Maikel Linke
dd6c066f5a
DRY view with JS translation
2022-07-20 17:01:10 +10:00
dependabot[bot]
9de939c1b1
Bump terser from 4.8.0 to 4.8.1
...
Bumps [terser](https://github.com/terser/terser ) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/commits )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-20 05:48:56 +00:00
Lucas da Costa
35030bfd02
Fix button labels on terms of service
2022-07-19 22:53:30 -03:00
Maikel
3833fb6e52
Merge pull request #9394 from jibees/9167-api-v1,-customers-endpoint-region-and-country-as-object
...
API v1: Provide customer address with region and country objects including id code
2022-07-20 09:41:11 +10:00
filipefurtad0
0a03c0a0fb
Adds js window element to container code
2022-07-19 19:29:02 +01:00
binarygit
0599acbcb8
Refactor shipments.js
2022-07-19 13:37:05 +05:45
binarygit
97dcd44662
Display alert box before deleting note/tracking info
2022-07-19 13:37:05 +05:45
binarygit
1165c997bc
Add styles on notes/tracking info when hoving over their delete buttons
2022-07-19 13:36:58 +05:45
binarygit
1d54777d72
Replace view with status column in past orders table
2022-07-19 13:30:11 +05:45
Maikel
0144e940c4
Remove release step to merge Transifex PR
2022-07-19 17:38:37 +10:00
Jean-Baptiste Bellet
753a643bf1
Simplify main method by creating two private methods
...
Include some unit tests
2022-07-19 09:50:06 +10:00
Maikel Linke
19018c2564
Split address transformation for easier reading
2022-07-19 09:49:42 +10:00
Maikel Linke
c8a65d2fac
Simplify with customer accessor
2022-07-19 09:49:42 +10:00
Maikel Linke
6c0d4cffe5
Allow customer's address update with country code
...
The customer endpoint now serves 2-letter ISO codes for countries and
accepts these for updates. It also serves and accepts region codes
(abbreviations) like VIC for Victoria.
Updates treat these fields as case-insensitive and either code or name
have to be present.
This commit also updates the Swagger documentation.
2022-07-19 09:49:42 +10:00
binarygit
6b042e4a17
Display notes field in admin/orders/new only after an item has been added
2022-07-18 16:15:37 +05:45
binarygit
ae2c56b29d
Omit tracking info row from shipping email when empty
2022-07-18 14:55:36 +05:45
saunmanoj888
55feb7648d
Fix text alignment for category radio button under shipping method
2022-07-16 23:17:06 +05:30
Jean-Baptiste Bellet
cc135c8190
API V1, Customer endpoint: region and country as object
2022-07-15 14:54:33 +02:00
binarygit
2f01351ad2
Enable users to delete only non-empty tracking info/notes
2022-07-15 11:34:37 +05:45
Maikel Linke
3d6842db80
Update translations
2022-07-14 11:54:23 +10:00
Maikel
e1dd92b406
Merge pull request #9395 from openfoodfoundation/transifex
...
Transifex
2022-07-14 11:50:18 +10:00
Maikel
a8160aac8a
Merge pull request #9399 from binarygit/feature/update-note/tracking
...
Update note and tracking fields workflow
2022-07-14 11:49:09 +10:00
binarygit
5e7bfc05d2
Remove link from order number in open/past orders table
2022-07-13 20:10:45 +05:45
binarygit
3c741f0686
Add flash after an order is cancelled
2022-07-13 18:45:43 +05:45
Jean-Baptiste Bellet
afa40ea82f
Authorize product and not @product
2022-07-13 14:26:11 +02:00
Transifex-Openfoodnetwork
6a9fcd0b30
Updating translations for config/locales/en_GB.yml
2022-07-13 04:17:52 +10:00
Jean-Baptiste Bellet
a80cf37fa6
Handle errors message formatting
2022-07-12 18:29:28 +02:00
Jean-Baptiste Bellet
073bad2118
Allow svg images to be resized/cropped
2022-07-12 15:53:32 +02:00
binarygit
6ad0749ce8
Refactor: create parent_node var to find child elements
2022-07-12 14:11:53 +05:45
Transifex-Openfoodnetwork
5a40ccb7df
Updating translations for config/locales/it.yml
2022-07-12 18:07:07 +10:00
binarygit
a56375eaf8
Spec: can delete note/tracking info on an order
2022-07-12 13:33:34 +05:45
Philipp Winkler
6291e3c587
Handle invalid referer for embedded page service
2022-07-11 22:07:00 +02:00
Transifex-Openfoodnetwork
5221e776da
Updating translations for config/locales/de_DE.yml
2022-07-11 20:44:12 +10:00
Transifex-Openfoodnetwork
a290779ef7
Updating translations for config/locales/en_FR.yml
2022-07-11 19:31:07 +10:00
Transifex-Openfoodnetwork
ac2b8e1ebe
Updating translations for config/locales/fr.yml
2022-07-11 19:28:51 +10:00
jibees
a1adcadd6c
Merge pull request #9371 from openfoodfoundation/dependabot/bundler/devise-4.8.1
...
Bump devise from 4.8.0 to 4.8.1
2022-07-11 11:26:43 +02:00
dependabot[bot]
4a53c818fd
Bump oauth2 from 1.4.7 to 1.4.10
...
Bumps [oauth2](https://github.com/oauth-xx/oauth2 ) from 1.4.7 to 1.4.10.
- [Release notes](https://github.com/oauth-xx/oauth2/releases )
- [Changelog](https://github.com/oauth-xx/oauth2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/oauth-xx/oauth2/compare/v1.4.7...v1.4.10 )
---
updated-dependencies:
- dependency-name: oauth2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-11 09:06:54 +00:00
dependabot[bot]
fa59117fd5
Bump devise from 4.8.0 to 4.8.1
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.8.0...v4.8.1 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-11 08:52:18 +00:00
jibees
3b6b2ea936
Merge pull request #9372 from openfoodfoundation/dependabot/bundler/rack-timeout-0.6.3
...
Bump rack-timeout from 0.6.0 to 0.6.3
2022-07-11 10:51:00 +02:00
jibees
ef4a71c048
Merge pull request #9375 from openfoodfoundation/dependabot/bundler/redis-4.7.1
...
Bump redis from 4.7.0 to 4.7.1
2022-07-11 10:50:35 +02:00
jibees
bc82401c24
Merge pull request #9393 from openfoodfoundation/dependabot/bundler/awesome_nested_set-3.5.0
...
Bump awesome_nested_set from 3.4.0 to 3.5.0
2022-07-11 10:49:54 +02:00
jibees
849ceeaa96
Merge pull request #9392 from openfoodfoundation/dependabot/npm_and_yarn/moment-2.29.4
...
Bump moment from 2.29.3 to 2.29.4
2022-07-11 10:49:35 +02:00
jibees
77bac0c24e
Merge pull request #9396 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.1.0
...
Bump tom-select from 2.0.3 to 2.1.0
2022-07-11 09:17:15 +02:00
binarygit
227220e2a6
Add focus to tracking when edit tracking is clicked
2022-07-09 14:40:04 +05:45
binarygit
b88c85555e
Add delete tracking feature
2022-07-09 14:39:20 +05:45
binarygit
b7a49ced39
Add focus to note when edit note is clicked
2022-07-09 14:33:01 +05:45
binarygit
dc31ebebb1
Add delete note feature
2022-07-09 13:23:38 +05:45
Filipe
2f550725e3
Merge pull request #9368 from jibees/9178-add-note-on-order
...
Admin, Edit order: Can add note on order
2022-07-08 12:13:18 +01:00
Filipe
3834724d45
Merge pull request #9236 from AgriculturaFamiliar/add-map-whatsapp-link
...
Show whatsapp link on contact modal on map
2022-07-08 12:10:18 +01:00
dependabot[bot]
ce39f3c119
Bump tom-select from 2.0.3 to 2.1.0
...
Bumps [tom-select](https://github.com/orchidjs/tom-select ) from 2.0.3 to 2.1.0.
- [Release notes](https://github.com/orchidjs/tom-select/releases )
- [Commits](https://github.com/orchidjs/tom-select/compare/v2.0.3...v2.1.0 )
---
updated-dependencies:
- dependency-name: tom-select
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-08 09:05:33 +00:00
Transifex-Openfoodnetwork
7aaa31b137
Updating translations for config/locales/en_FR.yml
2022-07-08 11:27:15 +10:00
Transifex-Openfoodnetwork
656143db48
Updating translations for config/locales/fr.yml
2022-07-08 11:24:09 +10:00
Filipe
decfbc9658
Merge pull request #9356 from jibees/9248-add-tags-to-a-producer-only-order-cycle
...
Add tags to producer-only order cycle interface
2022-07-07 23:45:02 +01:00
Filipe
e91a87d83b
Merge pull request #9295 from filipefurtad0/destroy_order_state_confirmation
...
Restarts checkout flow, when emptying the cart
2022-07-07 22:47:44 +01:00
Filipe
040422c6c0
Merge pull request #9380 from jibees/9068-bulk-product-update-creating-new-on_demand-variant
...
Admin, Products list: fix variant creation when unit is not well formatted and on_demand is checked or on_hand is filled
2022-07-07 22:39:23 +01:00
dependabot[bot]
7535883416
Bump moment from 2.29.3 to 2.29.4
...
Bumps [moment](https://github.com/moment/moment ) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases )
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/moment/moment/compare/2.29.3...2.29.4 )
---
updated-dependencies:
- dependency-name: moment
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-07 08:10:37 +00:00
Jean-Baptiste Bellet
f71c84cea5
Handle save method as it should be: return false if any errors occurs
2022-07-07 09:56:14 +02:00
Maikel Linke
1586320115
Update translations
2022-07-07 13:56:55 +10:00
Maikel
13f81ca20e
Merge pull request #9350 from filipefurtad0/adds_reports_specs
...
Adds system specs on orders and fulfillment reports
2022-07-07 13:51:12 +10:00
dependabot[bot]
25b5b66ae1
Bump awesome_nested_set from 3.4.0 to 3.5.0
...
Bumps [awesome_nested_set](https://github.com/collectiveidea/awesome_nested_set ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/collectiveidea/awesome_nested_set/releases )
- [Changelog](https://github.com/collectiveidea/awesome_nested_set/blob/master/CHANGELOG )
- [Commits](https://github.com/collectiveidea/awesome_nested_set/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: awesome_nested_set
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-07 03:45:48 +00:00
dependabot[bot]
f2b02f6c6b
Bump activerecord-import from 1.3.0 to 1.4.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.3.0...v1.4.0 )
---
updated-dependencies:
- dependency-name: activerecord-import
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-07 03:45:13 +00:00
dependabot[bot]
3139ba7ad0
Bump rack-timeout from 0.6.0 to 0.6.3
...
Bumps [rack-timeout](https://github.com/zombocom/rack-timeout ) from 0.6.0 to 0.6.3.
- [Release notes](https://github.com/zombocom/rack-timeout/releases )
- [Changelog](https://github.com/zombocom/rack-timeout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/zombocom/rack-timeout/compare/v0.6.0...v0.6.3 )
---
updated-dependencies:
- dependency-name: rack-timeout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-07 03:45:12 +00:00
Maikel
1ab1e20bb7
Merge pull request #9378 from openfoodfoundation/dependabot/bundler/rails-6.1.6
...
Bump rails from 6.1.4.4 to 6.1.6
2022-07-07 13:43:58 +10:00
Maikel
f3806ea5ea
Merge pull request #9381 from openfoodfoundation/transifex
...
Transifex
2022-07-07 13:39:23 +10:00
Maikel
182a7f0f93
Merge pull request #9352 from filipefurtad0/price_breakdown_spec
...
Adds price breakdown assertion
2022-07-07 13:36:45 +10:00
Jean-Baptiste Bellet
6f228781d4
Check for product_set errors
...
+ update specs: can't save variant that is not well filled. Now display errors (instead of a generic one)
2022-07-06 10:46:54 +02:00
Jean-Baptiste Bellet
c39b00b6c2
do not set on_demand and on_hand if variant has errors
...
+ update specs
Co-Authored-By: Maikel <maikel@email.org.au >
2022-07-06 10:46:54 +02:00
Jean-Baptiste Bellet
06b1c9aa40
Handle plural (and 0) on orders selection component
2022-07-06 09:48:12 +02:00
lauriewayne
75b71738df
Update FUNDING.yml
...
took away @
2022-07-05 07:02:03 -07:00
lauriewayne
8cb07c4a37
Update FUNDING.yml
2022-07-05 06:59:27 -07:00
lauriewayne
4cbd520cb9
Create FUNDING.yml
...
added @ofnusa to Open Collective line
2022-07-05 06:56:44 -07:00
Jean-Baptiste Bellet
b2a0310e6f
Handle the case when errors is a string
2022-07-05 15:48:31 +02:00
jibees
d71994189c
Creating new variants specs
...
Co-Authored-By: Filipe <49817236+filipefurtad0@users.noreply.github.com >
2022-07-05 10:21:48 +02:00
Jean-Baptiste Bellet
89809aed5f
Add counter on note input
2022-07-05 10:09:20 +02:00
Jean-Baptiste Bellet
de8c71d098
Create a controller that handle a counter for an input text
2022-07-05 10:09:20 +02:00
Jean-Baptiste Bellet
576faff3d7
Spec: can edit/save note on an order
2022-07-05 10:09:20 +02:00
Jean-Baptiste Bellet
90af6bd22d
Handle note saving with a new action on existing API controller
2022-07-05 10:09:20 +02:00
Jean-Baptiste Bellet
3f1099d968
Add edit note line on an order
2022-07-05 10:09:20 +02:00
Jean-Baptiste Bellet
7fbe893927
Add note to spree_orders object
2022-07-05 10:09:20 +02:00
Transifex-Openfoodnetwork
c6ab9f8a6a
Updating translations for config/locales/it.yml
2022-07-05 16:42:36 +10:00
Vishal Jain
3143cc9d92
skip disabled user check for session controller
2022-07-05 11:35:11 +05:30
Jean-Baptiste Bellet
e4be757d96
use the can_invoice method that check both ABN and configuration boolean
...
+ specs Specify an empty ABN number
+ update specs
2022-07-04 15:35:49 +02:00
filipefurtad0
e44845c327
Creates system spec for orders and fulfilment report; adds existing test cases to this file
2022-07-04 11:08:54 +01:00
filipefurtad0
c8cab86b0c
Stubs order and adds assertions
2022-07-04 11:07:00 +01:00
Transifex-Openfoodnetwork
a3cbe8e878
Updating translations for config/locales/en_FR.yml
2022-07-04 19:52:28 +10:00
Transifex-Openfoodnetwork
727c74907d
Updating translations for config/locales/fr.yml
2022-07-04 19:51:29 +10:00
Transifex-Openfoodnetwork
04c38a3c1d
Updating translations for config/locales/de_DE.yml
2022-07-02 08:22:44 +10:00
Jean-Baptiste Bellet
9b51f85e9a
Create a context around "creating new variants"
...
Reproducing bug #9068
2022-07-01 16:42:04 +02:00
dependabot[bot]
544377a624
Bump rails from 6.1.4.4 to 6.1.6
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.4.4 to 6.1.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.4.4...v6.1.6 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-01 11:06:24 +00:00
dependabot[bot]
a5f6773a4d
Bump redis from 4.7.0 to 4.7.1
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.7.0...v4.7.1 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-01 09:34:11 +00:00
dependabot[bot]
43b09640a9
Bump spring from 3.0.0 to 4.0.0
...
Bumps [spring](https://github.com/rails/spring ) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v3.0.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: spring
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-01 08:47:51 +00:00
Arthur Vieira
066879fe62
Add icons to whatsapp links
...
Uses the font awesome 4 WhatsApp icon in .svg format (which is under the
Open Font License) in the pages where an enterprise's WhatsApp number
appears as an hyperlink.
2022-06-30 19:19:10 -03:00
Arthur
54ec4e5016
Update app/views/shopping_shared/tabs/_contact.html.haml
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-06-30 19:19:10 -03:00
Arthur Vieira
e483ef8ccd
Fix whatsapp phone tooltip in registration
...
The tooltip on the contact step of the registration form now displays
the proper text, which has been added in the source language file.
2022-06-30 19:19:10 -03:00
Arthur Vieira
0deb3cd782
Replace url generation with 'whatsapp_url' method
...
As suggested by mkllnk's following comment:
1eda7d8a4c (r890656117)
2022-06-30 19:19:10 -03:00
Arthur Vieira
624485ff25
Add whatsapp link to contact tab view
2022-06-30 19:19:10 -03:00
Arthur Vieira
cace62a718
Add producer whatsapp link to producers list
...
Adds WhatsApp number with wa.me link between phone number and e-mail
address in the producers list profile.
2022-06-30 19:19:10 -03:00
Arthur Vieira
77360f41af
Show WhatsApp link on contact modal on map
...
Strips '+' and ' ' characters from the phone number for the generated
link, but doesn't guarantee the link is valid because the number
registered isn't validated for now.
2022-06-30 19:19:10 -03:00
Arthur Vieira
79e762a815
Add whatsapp number to registration form
...
Creates a field on the contact step of the enterprise registration form
to create an enterprise with a WhatsApp phone number, with corresponding
i18n keys for the field's name and placeholder text.
2022-06-30 19:19:10 -03:00
Arthur Vieira
62ee3c2de1
Add admin view field for whatsapp number
...
Creates a field and tooltip in
/admin/enterprises/<enterprise>/edit#!/contact for updating the
enterprise's WhatsApp phone number, with corresponding i18n keys for the
name of the field, placeholder and tooltip text.
2022-06-30 19:19:10 -03:00
Arthur Vieira
b565b6ba4d
Add whatsapp_phone to permitted attributes
...
Allows creating and updating the enterprise's WhatsApp phone number in
the registration form and contact edit views.
2022-06-30 19:19:10 -03:00
Arthur Vieira
a2bc61475b
Add whatsapp_phone column to enterprises
2022-06-30 19:19:06 -03:00
Jean-Baptiste Bellet
77d12a3e54
Can add tags on simple order_cycle: specs
...
Simple order cycle: enterprise users selling only their own produce
2022-06-29 09:51:15 +02:00
Jean-Baptiste Bellet
fdba33baa3
Pass the form, and re-init() on object change
...
I can't make angularjs directive synchronized to scope object, this seems to be a hack, but it works.
Also add form in the scope (which was not added...)
2022-06-28 15:05:11 +02:00
Jean-Baptiste Bellet
6f303a5244
Add tags interface for a producer only order cycle
...
Add tags for first (and unique) outgoing exchange for a simple OC
Order Cycle can have tags
2022-06-28 15:05:11 +02:00
filipefurtad0
43b6ab5dc5
Updates spec after merging #9325
2022-06-28 07:37:08 +01:00
filipefurtad0
2ba9d250f2
Adds assertion on price breakdown modal
2022-06-27 11:24:57 +01:00
Vishal Jain
84b711e130
redirect disabled user to homepage
2022-06-24 18:09:15 +05:30
Jean-Baptiste Bellet
4007b17b1e
Redirect to login path also if user is disabled
...
+ update spec as well
2022-06-22 15:51:11 +02:00
filipefurtad0
9ab672d0b1
Restarts checkout flow for state 'confirmation'
2022-06-15 10:35:40 +01:00
filipefurtad0
f3ff835902
Adds a spec to assert on the order state change
2022-06-14 08:58:54 +01:00
Maikel Linke
004c7eef9e
Show SVG product images
2022-06-14 15:35:55 +10:00
Maikel Linke
f3f0a84915
Display image upload error as alert
...
Not the nicest UX but better than nothing.
2022-06-14 15:11:26 +10:00
Maikel Linke
5f11b6a650
Respond with errors if image upload fails
2022-06-14 15:06:17 +10:00
Maikel Linke
6b733ad7e2
Increase readability of image controller spec
...
Best viewed without whitespace changes.
- Decrease indent.
- Move `let` to top like in other specs.
- Avoid `let!` to speed up the specs.
2022-06-14 14:56:40 +10:00
Maikel Linke
831aa3aae0
Simplify ProductImagesController
2022-06-14 14:50:55 +10:00