raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Still improve error message for Billing address

Browse Source 
```
"Bill" is a person's name, and I don't know his address
```

;)
This commit is contained in:
Jean-Baptiste Bellet
2023-02-15 10:00:53 +01:00
parent 08fb496f55
commit 0a3d362282
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
config/locales/en.yml
View File

@@ -36,8 +36,12 @@ en:
lastname: "Last name"
zipcode: "Shipping address postcode"
spree/order/bill_address:
address1: "Bill address (Street + House number)"
zipcode: "Bill address postcode"
address1: "Billing address (Street + House number)"
zipcode: "Billing address postcode"
city: "Billing address city"
country: "Billing address country"
firstname: "Billing address first name"
lastname: "Billing address last name"
phone: Customer phone
spree/user:
password: "Password"

2
spec/models/spree/order_spec.rb
View File

@@ -18,7 +18,7 @@ describe Spree::Order do
it "provides friendly error messages for bill address" do
order.bill_address = Spree::Address.new
order.save
expect(order.errors.full_messages).to include "Bill address (Street + House number) can't be blank"
expect(order.errors.full_messages).to include "Billing address (Street + House number) can't be blank"
end
end

2
spec/system/consumer/split_checkout_spec.rb
View File

@@ -211,7 +211,7 @@ describe "As a consumer, I want to checkout my order" do
end
it "should display error message in the right order" do
expect(page).to have_content "Customer E-Mail can't be blank, Customer E-Mail is invalid, Customer phone can't be blank, Bill address firstname can't be blank, Bill address lastname can't be blank, Bill address (Street + House number) can't be blank, Bill address city can't be blank, Bill address postcode can't be blank, and Shipping method Select a shipping method"
expect(page).to have_content "Customer E-Mail can't be blank, Customer E-Mail is invalid, Customer phone can't be blank, Billing address first name can't be blank, Billing address last name can't be blank, Billing address (Street + House number) can't be blank, Billing address city can't be blank, Billing address postcode can't be blank, and Shipping method Select a shipping method"
end
end
end