raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify order definition

Browse Source 
There only needs to be one order at a time, and it can be created on-demand. We can simply override it in the specs that need to.
This commit is contained in:
David Cook
2023-09-01 12:00:29 +10:00
parent e0031225d1
commit 381ce1c2b9
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/services/order_invoice_comparator_spec.rb
View File

@@ -4,9 +4,8 @@ require 'spec_helper'
describe OrderInvoiceComparator do
describe '#can_generate_new_invoice?' do
let!(:completed_order_with_fees) { create(:completed_order_with_fees) }
# this passes 'order' as argument to the invoice comparator
let(:order) { completed_order_with_fees }
let(:order) { create(:completed_order_with_fees) }
let!(:invoice_data_generator){ InvoiceDataGenerator.new(order) }
let!(:invoice){
create(:invoice,
@@ -69,7 +68,7 @@ describe OrderInvoiceComparator do
context "additional tax total changes" do
let(:distributor) { create(:distributor_enterprise) }
let!(:order_with_taxes) do
let(:order) do
create(:order_with_taxes, distributor: distributor, ship_address: create(:address),
product_price: 110, tax_rate_amount: 0.1,
included_in_price: false,
@@ -78,18 +77,17 @@ describe OrderInvoiceComparator do
order.update_shipping_fees!
end
end
let!(:order) { order_with_taxes }
it "returns returns true" do
Spree::TaxRate.first.update!(amount: 0.15)
order_with_taxes.create_tax_charge! && order_with_taxes.save
order.create_tax_charge! && order.save
expect(subject).to be true
end
end
context "included tax total changes" do
let(:distributor) { create(:distributor_enterprise) }
let!(:order_with_taxes) do
let(:order) do
create(:order_with_taxes, distributor: distributor, ship_address: create(:address),
product_price: 110, tax_rate_amount: 0.1,
included_in_price: true,
@@ -98,18 +96,16 @@ describe OrderInvoiceComparator do
order.update_shipping_fees!
end
end
let!(:order) { order_with_taxes }
it "returns returns true" do
Spree::TaxRate.first.update!(amount: 0.15)
order_with_taxes.create_tax_charge! && order_with_taxes.save
order.create_tax_charge! && order.save
expect(subject).to be true
end
end
context "shipping method changes" do
let(:shipping_method) { create(:shipping_method) }
let!(:order) { completed_order_with_fees }
it "returns returns true" do
Spree::ShippingRate.first.update(shipping_method_id: shipping_method.id)
expect(subject).to be true