raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use .empty? instead of !exists? in app/models/order_cycle_shipping_method.rb

Browse Source 
Co-authored-by: Maikel <maikel@email.org.au>
This commit is contained in:
Cillian O'Ruanaidh
2022-06-20 21:06:16 +01:00
committed by Filipe
parent 9a511e9e94
commit f25de984d2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/order_cycle_shipping_method.rb
View File

@@ -14,10 +14,10 @@ class OrderCycleShippingMethod < ApplicationRecord
private
def shipping_method_not_selected_on_any_orders?
!Spree::Order.joins(shipments: :shipping_rates).where(
Spree::Order.joins(shipments: :shipping_rates).where(
"order_cycle_id = ? AND spree_shipping_rates.shipping_method_id = ?",
order_cycle_id, shipping_method_id
).exists?
).empty?
end
def check_shipping_method_not_selected_on_any_orders