raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-29 21:17:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

SplitCheckoutController refactor add_voucher

Browse Source 
Now all redirection/render_error happen in #update, it makes it
easier to understand.
This commit is contained in:
Gaetan Craig-Riou
2023-03-20 16:26:58 +11:00
committed by Maikel Linke
parent e487ed0532
commit 856386fcb0
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/controllers/split_checkout_controller.rb
View File

@@ -32,7 +32,11 @@ class SplitCheckoutController < ::BaseController
end
def update
return add_voucher if payment_step? && params[:order][:voucher_code]
if add_voucher
return redirect_to checkout_step_path(:payment)
elsif @order.errors.present?
return render_error
end
if confirm_order || update_order
return if performed?
@@ -191,19 +195,21 @@ class SplitCheckoutController < ::BaseController
end
def add_voucher
return unless payment_step? && params[:order] && params[:order][:voucher_code]
# Fetch Voucher
voucher = Voucher.find_by(code: params[:order][:voucher_code], enterprise: @order.distributor)
if voucher.nil?
@order.errors.add(:voucher, I18n.t('split_checkout.errors.voucher_not_found'))
return render_error
return false
end
# Create adjustment
# TODO add tax part of adjustement
voucher.create_adjustment(voucher.code, @order)
redirect_to checkout_step_path(:payment)
true
end
def summary_step?