Fix rubocop error and prefer using a return clause

2026-03-01 02:03:22 +00:00 · 2023-04-18 11:56:03 +02:00
parent 6172d1f2e5
commit 0f28d318ac
1 changed files with 4 additions and 4 deletions
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -104,10 +104,10 @@ module Spree
      def on_update
        @order.recreate_all_fees!

-        unless @order.cart?
-          @order.create_tax_charge!
-          @order.update_order!
-        end
+        return if @order.cart?
+
+        @order.create_tax_charge!
+        @order.update_order!
      end

      def order_params