From 0f28d318aca57b3023d8927da92c0dd2989cbd4b Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Tue, 18 Apr 2023 11:56:03 +0200
Subject: [PATCH] Fix rubocop error and prefer using a return clause

---
 app/controllers/spree/admin/orders_controller.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/controllers/spree/admin/orders_controller.rb b/app/controllers/spree/admin/orders_controller.rb
index d77f61d668..3d4b7c1c49 100644
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -104,10 +104,10 @@ module Spree
       def on_update
         @order.recreate_all_fees!
 
-        unless @order.cart?
-          @order.create_tax_charge!
-          @order.update_order!
-        end
+        return if @order.cart?
+
+        @order.create_tax_charge!
+        @order.update_order!
       end
 
       def order_params