Merge pull request #10566 from mkllnk/products-meta-description

Remove unused product meta description

app/models/spree/variant.rb

@@ -20,7 +20,7 @@ module Spree
     belongs_to :product, -> { with_deleted }, touch: true, class_name: 'Spree::Product'
 
     delegate_belongs_to :product, :name, :description, :permalink, :available_on,
-                        :tax_category_id, :shipping_category_id, :meta_description,
+                        :tax_category_id, :shipping_category_id,
                         :meta_keywords, :tax_category, :shipping_category
 
     has_many :inventory_units, inverse_of: :variant

app/services/permitted_attributes/product.rb

@@ -8,7 +8,7 @@ module PermittedAttributes
         :variant_unit, :variant_unit_scale, :unit_value, :unit_description, :variant_unit_name,
         :display_as, :sku, :available_on, :group_buy, :group_buy_unit_size,
         :taxon_ids, :primary_taxon_id, :tax_category_id, :shipping_category_id,
-        :meta_keywords, :meta_description, :notes, :inherits_properties,
+        :meta_keywords, :notes, :inherits_properties,
         { product_properties_attributes: [:id, :property_name, :value],
           variants_attributes: [PermittedAttributes::Variant.attributes],
           images_attributes: [:attachment] }

app/views/spree/admin/products/_seo_form.html.haml

@@ -5,11 +5,6 @@
       %span.icon-question-sign{ 'ofn-with-tip' => t('admin.products.seo.product_search_tip') }
       %br/
       = f.text_field :meta_keywords, :class => 'fullwidth', :rows => 6
-    = f.field_container :meta_description do
-      = f.label :meta_description, t('admin.products.seo.SEO_keywords')
-      %span.icon-question-sign{ 'ofn-with-tip' => t('admin.products.seo.seo_tip') }
-      %br/
-      = f.text_field :meta_description, :class => 'fullwidth', :rows => 6
   .alpha.eleven.columns
     = f.field_container :notes do
       = f.label :notes, t(:notes)

config/locales/en.yml

@@ -728,7 +728,6 @@ en:
       seo:
         product_search_keywords: "Product Search Keywords"
         product_search_tip: "Type words to help search your products in the shops. Use space to separate each keyword."
-        SEO_keywords: "SEO Keywords"
         seo_tip: "Type words to help search your products in the web. Use space to separate each keyword."
       search: "Search"
       properties:

db/migrate/20230315031807_remove_meta_description_from_spree_products.rb

@@ -0,0 +1,5 @@
+class RemoveMetaDescriptionFromSpreeProducts < ActiveRecord::Migration[6.1]
+  def change
+    remove_column :spree_products, :meta_description, :text
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2023_02_13_160135) do
+ActiveRecord::Schema[7.0].define(version: 2023_03_15_031807) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_stat_statements"
   enable_extension "plpgsql"
@@ -718,7 +718,6 @@ ActiveRecord::Schema[7.0].define(version: 2023_02_13_160135) do
     t.datetime "available_on", precision: nil
     t.datetime "deleted_at", precision: nil
     t.string "permalink", limit: 255
-    t.text "meta_description"
     t.string "meta_keywords", limit: 255
     t.integer "tax_category_id"
     t.integer "shipping_category_id"

spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee

@@ -192,7 +192,6 @@ describe "filtering products for submission to database", ->
       available_on: available_on
       deleted_at: null
       permalink: null
-      meta_description: null
       meta_keywords: null
       tax_category_id: null
       shipping_category_id: null
@@ -998,7 +997,6 @@ describe "AdminProductEditCtrl", ->
         deleted_at: null
         permalink: 'test-product'
         permalink_live: 'test-product'
-        meta_description: null
         meta_keywords: null
         tax_category_id: null
         shipping_category_id: null