raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-11 23:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Rspec's http matcher for better fail output

Browse Source 
The previous version would just say that it expected true and got false.
The specific matcher tells us which code it expected and which code it
found.
This commit is contained in:
Maikel Linke
2022-11-08 16:44:57 +11:00
committed by David Cook
parent c90d2c7f9a
commit b0aa7b7b55
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
engines/dfc_provider/spec/controllers/dfc_provider/catalog_items_controller_spec.rb
View File

@@ -23,7 +23,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
before { api_get :index, enterprise_id: 'default' }
it 'is successful' do
expect(response).to be_successful
expect(response).to have_http_status :success
end
it 'renders the required content' do
@@ -41,7 +41,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
it 'returns not_found head' do
api_get :index, enterprise_id: enterprise.id
expect(response).to be_not_found
expect(response).to have_http_status :not_found
end
end
end
@@ -69,7 +69,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
it 'is not found' do
api_get :index, enterprise_id: 'default'
expect(response).to be_not_found
expect(response).to have_http_status :not_found
end
end
end
@@ -89,7 +89,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
context 'without an authorization token' do
it 'returns unauthorized head' do
api_get :index, enterprise_id: enterprise.id
expect(response).to be_unauthorized
expect(response).to have_http_status :unauthorized
end
end
@@ -97,7 +97,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
it "is successful" do
sign_in user
api_get :index, enterprise_id: enterprise.id
expect(response).to be_successful
expect(response).to have_http_status :success
end
end
end
@@ -114,7 +114,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
end
it 'is successful' do
expect(response).to be_successful
expect(response).to have_http_status :success
end
it 'renders the required content' do
@@ -131,7 +131,7 @@ describe DfcProvider::CatalogItemsController, type: :controller do
end
it 'is not found' do
expect(response).to be_not_found
expect(response).to have_http_status :not_found
end
end
end