Fix rubocop warning

This commit is contained in:
Gaetan Craig-Riou
2023-07-21 14:21:57 +10:00
parent 196b674bf1
commit f9afc0ba96
3 changed files with 4 additions and 4 deletions

View File

@@ -56,7 +56,7 @@ module Admin
@rendering_options = rendering_options
@data = Reporting::FrontendData.new(spree_current_user)
variant_id_in = params[:variant_id_in]&.reject(&:blank?)
variant_id_in = params[:variant_id_in]&.compact_blank
load_selected_variant if variant_id_in.present?
end

View File

@@ -24,9 +24,9 @@ module Reporting
end
# Filter by product
variant_id_in = @params[:variant_id_in].reject(&:blank?)
variant_id_in = @params[:variant_id_in]&.compact_blank
if variant_id_in.present?
line_items = line_items.where("spree_line_items.variant_id": variant_id_in)
line_items = line_items.where('spree_line_items.variant_id': variant_id_in)
end
if line_item_includes.present?

View File

@@ -179,7 +179,7 @@ describe "Orders And Fulfillment" do
context "When filtering by product" do
let(:variant1) { create(:variant, product: product, unit_description: "Big") }
let(:variant3) { create(:variant)}
let(:variant3) { create(:variant) }
before do
create(:line_item_with_shipment, variant: variant1, quantity: 1, order: order1)