raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Instanciate instance variable + use spread operator to be more concise

Browse Source 
and efficient ;)
This commit is contained in:
Jean-Baptiste Bellet
2023-07-07 09:27:43 +02:00
parent 4bcba86fc8
commit 0fdf7876a6
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/webpacker/controllers/dropdown_controller.js
View File

@@ -4,6 +4,8 @@ export default class extends Controller {
static targets = ["arrow", "menu"];
connect() {
this.collapsedClass = this.arrowTarget.dataset.collapsedClass.split(" ");
this.expandedClass = this.arrowTarget.dataset.expandedClass.split(" ");
this.#hide();
document.addEventListener("click", this.#onBodyClick.bind(this));
}
@@ -31,20 +33,12 @@ export default class extends Controller {
#show() {
this.menuTarget.classList.remove("hidden");
this.arrowTarget.dataset.collapsedClass.split(" ").forEach((className) => {
this.arrowTarget.classList.remove(className);
});
this.arrowTarget.dataset.expandedClass.split(" ").forEach((className) => {
this.arrowTarget.classList.add(className);
});
this.arrowTarget.classList.remove(...this.collapsedClass);
this.arrowTarget.classList.add(...this.expandedClass);
}
#hide() {
this.menuTarget.classList.add("hidden");
this.arrowTarget.dataset.expandedClass.split(" ").forEach((className) => {
this.arrowTarget.classList.remove(className);
});
this.arrowTarget.dataset.collapsedClass.split(" ").forEach((className) => {
this.arrowTarget.classList.add(className);
});
this.arrowTarget.classList.remove(...this.expandedClass);
this.arrowTarget.classList.add(...this.collapsedClass);
}
}