raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-23 05:28:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Safely autocorrect Layout/ExtraSpacing

Browse Source 
Inspecting 1478 files
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C......................

Offenses:

spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
      let(:product_property) { create(:product_property,  property: property) }
                                                        ^
spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
        cart_service.instance_variable_set :@order_cycle,  double(:order_cycle)
                                                         ^
spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
      expect(page).to have_no_selector 'hub',   text: d2.name
                                             ^^

1478 files inspected, 3 offenses detected, 3 offenses corrected
This commit is contained in:
David Cook
2023-07-20 14:01:44 +10:00
parent bc330b69a5
commit 6859200339
4 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.rubocop_todo.yml
View File

@@ -16,15 +16,6 @@ Gemspec/RequiredRubyVersion:
- 'engines/order_management/order_management.gemspec'
- 'engines/web/web.gemspec'
# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
Layout/ExtraSpacing:
Exclude:
- 'spec/lib/open_food_network/property_merge_spec.rb'
- 'spec/services/cart_service_spec.rb'
- 'spec/system/consumer/shops_spec.rb'
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.

2
spec/lib/open_food_network/property_merge_spec.rb
View File

@@ -19,7 +19,7 @@ module OpenFoodNetwork
end
describe "merging ProducerProperties and Spree::ProductProperties" do
let(:product_property) { create(:product_property, property: property) }
let(:product_property) { create(:product_property, property: property) }
let(:duplicate_product_property) { create(:producer_property, property: duplicate_property) }
let(:producer_property) { create(:producer_property, property: different_property) }

2
spec/services/cart_service_spec.rb
View File

@@ -273,7 +273,7 @@ describe CartService do
end
it "returns true when order cycle is provided" do
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
expect(cart_service.send(:check_order_cycle_provided)).to be true
end
end

2
spec/system/consumer/shops_spec.rb
View File

@@ -75,7 +75,7 @@ describe 'Shops' do
it "does not show hubs that are not in an order cycle" do
expect(page).to have_no_selector 'hub.inactive'
expect(page).to have_no_selector 'hub', text: d2.name
expect(page).to have_no_selector 'hub', text: d2.name
end
it "does not show profiles" do