From 68592003390dc0ba920ee717c71c1b385a22426e Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 20 Jul 2023 14:01:44 +1000 Subject: [PATCH] Safely autocorrect Layout/ExtraSpacing Inspecting 1478 files ................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C...................... Offenses: spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected. let(:product_property) { create(:product_property, property: property) } ^ spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected. cart_service.instance_variable_set :@order_cycle, double(:order_cycle) ^ spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected. expect(page).to have_no_selector 'hub', text: d2.name ^^ 1478 files inspected, 3 offenses detected, 3 offenses corrected --- .rubocop_todo.yml | 9 --------- spec/lib/open_food_network/property_merge_spec.rb | 2 +- spec/services/cart_service_spec.rb | 2 +- spec/system/consumer/shops_spec.rb | 2 +- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d8055acb0c..67232cba0c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -16,15 +16,6 @@ Gemspec/RequiredRubyVersion: - 'engines/order_management/order_management.gemspec' - 'engines/web/web.gemspec' -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. -Layout/ExtraSpacing: - Exclude: - - 'spec/lib/open_food_network/property_merge_spec.rb' - - 'spec/services/cart_service_spec.rb' - - 'spec/system/consumer/shops_spec.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. diff --git a/spec/lib/open_food_network/property_merge_spec.rb b/spec/lib/open_food_network/property_merge_spec.rb index cd139188be..6b338c7b74 100644 --- a/spec/lib/open_food_network/property_merge_spec.rb +++ b/spec/lib/open_food_network/property_merge_spec.rb @@ -19,7 +19,7 @@ module OpenFoodNetwork end describe "merging ProducerProperties and Spree::ProductProperties" do - let(:product_property) { create(:product_property, property: property) } + let(:product_property) { create(:product_property, property: property) } let(:duplicate_product_property) { create(:producer_property, property: duplicate_property) } let(:producer_property) { create(:producer_property, property: different_property) } diff --git a/spec/services/cart_service_spec.rb b/spec/services/cart_service_spec.rb index 05f574ba89..5b314d20f8 100644 --- a/spec/services/cart_service_spec.rb +++ b/spec/services/cart_service_spec.rb @@ -273,7 +273,7 @@ describe CartService do end it "returns true when order cycle is provided" do - cart_service.instance_variable_set :@order_cycle, double(:order_cycle) + cart_service.instance_variable_set :@order_cycle, double(:order_cycle) expect(cart_service.send(:check_order_cycle_provided)).to be true end end diff --git a/spec/system/consumer/shops_spec.rb b/spec/system/consumer/shops_spec.rb index 2bae3a92ed..a807c078d8 100644 --- a/spec/system/consumer/shops_spec.rb +++ b/spec/system/consumer/shops_spec.rb @@ -75,7 +75,7 @@ describe 'Shops' do it "does not show hubs that are not in an order cycle" do expect(page).to have_no_selector 'hub.inactive' - expect(page).to have_no_selector 'hub', text: d2.name + expect(page).to have_no_selector 'hub', text: d2.name end it "does not show profiles" do