raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-22 05:18:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleaning up left over TODOs

Browse Source
This commit is contained in:
Gaetan Craig-Riou
2023-05-01 16:32:42 +10:00
committed by Maikel Linke
parent aa526a639c
commit 236f6926d9
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/voucher_adjustments_controller.rb
View File

@@ -6,7 +6,6 @@ class VoucherAdjustmentsController < BaseController
def destroy
@order = current_order
# TODO: do we need to check the user can delete voucher_adjustment
@order.voucher_adjustments.find_by(id: params[:id])&.destroy
respond_to do |format|

2
app/views/split_checkout/_voucher_section.cable_ready.haml
View File

@@ -11,7 +11,7 @@
%i.ofn-i_051-check-big
= t("split_checkout.step2.voucher.voucher", voucher_amount: voucher_adjustment.originator.display_value)
= link_to t("split_checkout.step2.voucher.remove_code"), voucher_adjustment_path(id: voucher_adjustment.id), method: "delete", data: { confirm: t("split_checkout.step2.voucher.confirm_delete") }
- # TODO: this might not be true, ie payment method include fee which wouldn't be covered by voucher, tax implication raise total to be bigger than voucher other ?
- # This might not be true, ie payment method including a fee which wouldn't be covered by voucher or tax implication raising total to be bigger than the voucher amount ?
- if voucher_adjustment.originator.value > order.total
.checkout-input
%span.formError.standalone