raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stabilise flaky spec with defined enterprise order

Browse Source
This commit is contained in:
Maikel Linke
2023-02-24 14:19:26 +11:00
parent 16289a62f1
commit 116e844004
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spec/system/admin/enterprises/index_spec.rb
View File

@@ -35,7 +35,9 @@ describe 'Enterprises Index' do
end
context "editing enterprises in bulk" do
let!(:distributor){ create(:distributor_enterprise, sells: 'none') }
let!(:distributor) {
create(:distributor_enterprise, sells: 'none', name: "Adam's Market")
}
let!(:mani) { create(:user, enterprise_limit: 1) }
before do
@@ -64,7 +66,11 @@ describe 'Enterprises Index' do
end
context "with data that violates rules" do
let!(:second_distributor) { create(:distributor_enterprise, sells: 'none') }
let!(:second_distributor) {
# Choose name appearing at the end of the list because the spec
# relies on the order of saving records during update.
create(:distributor_enterprise, sells: "none", name: "Zed's Shop")
}
before do
second_distributor.users << mani
@@ -76,11 +82,14 @@ describe 'Enterprises Index' do
select_new_owner(mani, distributor)
select_new_owner(mani, second_distributor)
click_button "Update"
expect {
click_button "Update"
expect(flash_message).to eq('Update failed')
expect(page).to have_content "#{mani.email} is not permitted to own any more enterprises (limit is 1)."
second_distributor.reload
}.to_not change { second_distributor.owner }
expect(flash_message).to eq('Update failed')
expect(page).to have_content "#{mani.email} is not permitted to own any more enterprises (limit is 1)."
second_distributor.reload
expect(second_distributor.owner).to_not eq mani
end