raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-20 04:59:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded report spec

Browse Source 
Testing for the absence of behaviour is useful when changing code to
assert that the change is successful but in the long term, it doesn't
add any value. If you don't have any reason to believe that the report
may delete parameters then we don't need to test for that.
This commit is contained in:
Maikel Linke
2023-10-18 15:49:53 +11:00
parent d45fe44c9f
commit 43b1eca026
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/lib/reports/enterprise_fee_summary/enterprise_fee_summary_report_spec.rb
View File

@@ -100,12 +100,6 @@ describe Reporting::Reports::EnterpriseFeeSummary::FeeSummary do
let!(:second_customer_order) { prepare_order(customer:) }
let!(:other_customer_order) { prepare_order(customer: another_customer) }
it "doesn't delete params" do
params = ActionController::Parameters.new("completed_at_gt" => "2023-02-08+00:00")
described_class.new(current_user, params)
expect(params["completed_at_gt"]).to eq "2023-02-08+00:00"
end
it "groups and sorts entries correctly" do
totals = subject.query_result