From 43b1eca0267f63c0dbcedb55a69a76d2520afae6 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 18 Oct 2023 15:49:53 +1100 Subject: [PATCH] Remove unneeded report spec Testing for the absence of behaviour is useful when changing code to assert that the change is successful but in the long term, it doesn't add any value. If you don't have any reason to believe that the report may delete parameters then we don't need to test for that. --- .../enterprise_fee_summary_report_spec.rb | 6 ------ 1 file changed, 6 deletions(-) diff --git a/spec/lib/reports/enterprise_fee_summary/enterprise_fee_summary_report_spec.rb b/spec/lib/reports/enterprise_fee_summary/enterprise_fee_summary_report_spec.rb index aaeb80717c..2ddcf23d6c 100644 --- a/spec/lib/reports/enterprise_fee_summary/enterprise_fee_summary_report_spec.rb +++ b/spec/lib/reports/enterprise_fee_summary/enterprise_fee_summary_report_spec.rb @@ -100,12 +100,6 @@ describe Reporting::Reports::EnterpriseFeeSummary::FeeSummary do let!(:second_customer_order) { prepare_order(customer:) } let!(:other_customer_order) { prepare_order(customer: another_customer) } - it "doesn't delete params" do - params = ActionController::Parameters.new("completed_at_gt" => "2023-02-08+00:00") - described_class.new(current_user, params) - expect(params["completed_at_gt"]).to eq "2023-02-08+00:00" - end - it "groups and sorts entries correctly" do totals = subject.query_result