raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-11 23:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Rails is clever enough to not query the database without ids

Co-authored-by: Maikel <maikel@email.org.au>
This commit is contained in:
David Cook
2023-08-24 08:48:27 +10:00
committed by GitHub
parent 2edf504d65
commit a8d37d0899
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/services/sets/product_set.rb
View File

@@ -20,10 +20,9 @@ module Sets
end
def collection_attributes=(attributes)
ids = attributes.each_value.map { |product| product[:id] }.compact
@collection = []
ids = attributes.values.pluck(:id).compact
# Find and load existing products in the order they are provided
@collection = Spree::Product.find(ids) if ids.present?
@collection = Spree::Product.find(ids)
@collection_hash = attributes
end