raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-27 06:05:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sort products by name in ascending order

Browse Source 
The order is specified above in fetch_products. I'm guessing this line was unintentional?

Original requirment doesn't say ascending but I think it's safe to assume (issue#10694).
This commit is contained in:
David Cook
2023-07-21 14:19:24 +10:00
committed by Jean-Baptiste Bellet
parent 6dbfb36e52
commit e816228959
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/reflexes/products_reflex.rb
View File

@@ -96,7 +96,7 @@ class ProductsReflex < ApplicationReflex
end
def ransack_query
query = { s: "name desc" }
query = {}
query.merge!(supplier_id_in: @producer_id) if @producer_id.present?
if @search_term.present?
query.merge!(Spree::Variant::SEARCH_KEY => @search_term)

15
spec/system/admin/products_v3/products_spec.rb
View File

@@ -23,6 +23,21 @@ describe 'As an admin, I can see the new product page' do
expect(page).to have_content "Bulk Edit Products"
end
describe "sorting" do
let!(:product_z) { create(:simple_product, name: "Zucchini") }
let!(:product_a) { create(:simple_product, name: "Apples") }
before do
visit admin_products_v3_index_url
end
it "Should sort products alphabetically by default" do
expect(page).to have_selector "table.products tbody tr td", text: "Apples"
# other products push later one to next page
expect(page).not_to have_selector "table.products tbody tr td", text: "Zucchini"
end
end
describe "pagination" do
before do
visit admin_products_v3_index_url