raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use plain text instead of computed date in specs

Browse Source 
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-plain-text-over-method-calls-in-expected-values
This commit is contained in:
Jean-Baptiste Bellet
2023-07-24 11:39:08 +02:00
committed by Filipe
parent 5eab033a80
commit d6c10170da
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/lib/reports/customers_report_spec.rb
View File

@@ -54,8 +54,8 @@ module Reporting
shipping_method: sm)
}
before do
o1.update(completed_at: Time.zone.yesterday)
o2.update(completed_at: Time.zone.today)
o1.update(completed_at: "2023-01-01")
o2.update(completed_at: "2023-01-02")
[o1, o2].each do |order|
order.update!(email: "test@test.com")
end
@@ -70,7 +70,7 @@ module Reporting
[a.address1, a.address2, a.city].join(" "),
o1.email, a.phone, d.name,
[d.address.address1, d.address.address2, d.address.city].join(" "),
o1.shipping_method.name, 2, o1.total + o2.total, o2.completed_at.strftime("%Y-%m-%d")
o1.shipping_method.name, 2, o1.total + o2.total, "2023-01-02"
]])
end
@@ -92,13 +92,13 @@ module Reporting
[a.address1, a.address2, a.city].join(" "),
o1.email, a.phone, d.name,
[d.address.address1, d.address.address2, d.address.city].join(" "),
o1.shipping_method.name, 1, o1.total, o1.completed_at.strftime("%Y-%m-%d")
o1.shipping_method.name, 1, o1.total, "2023-01-01"
], [
a.firstname, a.lastname,
[a.address1, a.address2, a.city].join(" "),
o2.email, a.phone, d2.name,
[d2.address.address1, d2.address.address2, d2.address.city].join(" "),
o2.shipping_method.name, 1, o2.total, o2.completed_at.strftime("%Y-%m-%d")
o2.shipping_method.name, 1, o2.total, "2023-01-02"
]])
end
end