From d6c10170da130facb989909ef0ea4bdb510fd88d Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Mon, 24 Jul 2023 11:39:08 +0200 Subject: [PATCH] Use plain text instead of computed date in specs https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-plain-text-over-method-calls-in-expected-values --- spec/lib/reports/customers_report_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/lib/reports/customers_report_spec.rb b/spec/lib/reports/customers_report_spec.rb index c172e9d766..6dfd70ca51 100644 --- a/spec/lib/reports/customers_report_spec.rb +++ b/spec/lib/reports/customers_report_spec.rb @@ -54,8 +54,8 @@ module Reporting shipping_method: sm) } before do - o1.update(completed_at: Time.zone.yesterday) - o2.update(completed_at: Time.zone.today) + o1.update(completed_at: "2023-01-01") + o2.update(completed_at: "2023-01-02") [o1, o2].each do |order| order.update!(email: "test@test.com") end @@ -70,7 +70,7 @@ module Reporting [a.address1, a.address2, a.city].join(" "), o1.email, a.phone, d.name, [d.address.address1, d.address.address2, d.address.city].join(" "), - o1.shipping_method.name, 2, o1.total + o2.total, o2.completed_at.strftime("%Y-%m-%d") + o1.shipping_method.name, 2, o1.total + o2.total, "2023-01-02" ]]) end @@ -92,13 +92,13 @@ module Reporting [a.address1, a.address2, a.city].join(" "), o1.email, a.phone, d.name, [d.address.address1, d.address.address2, d.address.city].join(" "), - o1.shipping_method.name, 1, o1.total, o1.completed_at.strftime("%Y-%m-%d") + o1.shipping_method.name, 1, o1.total, "2023-01-01" ], [ a.firstname, a.lastname, [a.address1, a.address2, a.city].join(" "), o2.email, a.phone, d2.name, [d2.address.address1, d2.address.address2, d2.address.city].join(" "), - o2.shipping_method.name, 1, o2.total, o2.completed_at.strftime("%Y-%m-%d") + o2.shipping_method.name, 1, o2.total, "2023-01-02" ]]) end end