Merge pull request #9407 from Philwi/handle-for-invalid-referer-for-embedded-page-service

Handle for invalid referer for embedded page service

app/services/embedded_page_service.rb

@@ -68,12 +68,12 @@ class EmbeddedPageService
   end
 
   def current_referer
-    return if @request.referer.blank?
-
-    uri = URI(@request.referer)
-    return if uri.host.blank?
+    uri = URI.parse(@request.referer)
+    return unless uri.is_a?(URI::HTTP) && uri.host.present?
 
     uri.host.downcase
+  rescue URI::InvalidURIError
+    false
   end
 
   def current_referer_without_www

spec/services/embedded_page_service_spec.rb

@@ -74,7 +74,7 @@ describe EmbeddedPageService do
     context "when the request's referer is malformed" do
       let(:request) {
         ActionController::TestRequest.new(
-          { 'HTTP_HOST' => 'ofn-instance.com', 'HTTP_REFERER' => 'hello' }, nil, nil
+          { 'HTTP_HOST' => 'ofn-instance.com', 'HTTP_REFERER' => 'hello# 32' }, nil, nil
         )
       }
       before do