raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Safely autocorrect Style/FileRead

Browse Source 
Inspecting 1488 files
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................

Offenses:

lib/tasks/karma.rake:33:15: C: [Corrected] Style/FileRead: Use File.read.
    unit_js = File.open('config/ng-test.conf.js', 'r').read
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/upload_sanitizer_spec.rb:13:41: C: [Corrected] Style/FileRead: Use File.read.
    let(:service) { UploadSanitizer.new(File.open(upload).read) }
                                        ^^^^^^^^^^^^^^^^^^^^^^

1488 files inspected, 2 offenses detected, 2 offenses corrected
This commit is contained in:
Neal Chambers
2023-08-25 00:15:41 +09:00
parent 4cce85378c
commit afdddc9237
3 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.rubocop_todo.yml
View File

@@ -783,13 +783,6 @@ Style/ClassVars:
Exclude:
- 'lib/spree/core/delegate_belongs_to.rb'
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
Style/FileRead:
Exclude:
- 'lib/tasks/karma.rake'
- 'spec/services/upload_sanitizer_spec.rb'
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.

2
lib/tasks/karma.rake
View File

@@ -30,7 +30,7 @@ namespace :karma do
def unit_js(files)
puts files
unit_js = File.open('config/ng-test.conf.js', 'r').read
unit_js = File.read('config/ng-test.conf.js')
unit_js.gsub "APPLICATION_SPEC", "\"#{files.join("\",\n\"")}\""
end

2
spec/services/upload_sanitizer_spec.rb
View File

@@ -10,7 +10,7 @@ describe UploadSanitizer do
f << "Test"
end
end
let(:service) { UploadSanitizer.new(File.open(upload).read) }
let(:service) { UploadSanitizer.new(File.read(upload)) }
it "sanitizes the uploaded file" do
sanitized_upload = service.call