From afdddc923768415c3560ae50d70d5fa4880bd514 Mon Sep 17 00:00:00 2001 From: Neal Chambers Date: Fri, 25 Aug 2023 00:15:41 +0900 Subject: [PATCH] Safely autocorrect Style/FileRead Inspecting 1488 files .........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................ Offenses: lib/tasks/karma.rake:33:15: C: [Corrected] Style/FileRead: Use File.read. unit_js = File.open('config/ng-test.conf.js', 'r').read ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/services/upload_sanitizer_spec.rb:13:41: C: [Corrected] Style/FileRead: Use File.read. let(:service) { UploadSanitizer.new(File.open(upload).read) } ^^^^^^^^^^^^^^^^^^^^^^ 1488 files inspected, 2 offenses detected, 2 offenses corrected --- .rubocop_todo.yml | 7 ------- lib/tasks/karma.rake | 2 +- spec/services/upload_sanitizer_spec.rb | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index f6a0d00ed0..9527f9e0e2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -783,13 +783,6 @@ Style/ClassVars: Exclude: - 'lib/spree/core/delegate_belongs_to.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Style/FileRead: - Exclude: - - 'lib/tasks/karma.rake' - - 'spec/services/upload_sanitizer_spec.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns. diff --git a/lib/tasks/karma.rake b/lib/tasks/karma.rake index 2044fd04ef..3ee505f731 100644 --- a/lib/tasks/karma.rake +++ b/lib/tasks/karma.rake @@ -30,7 +30,7 @@ namespace :karma do def unit_js(files) puts files - unit_js = File.open('config/ng-test.conf.js', 'r').read + unit_js = File.read('config/ng-test.conf.js') unit_js.gsub "APPLICATION_SPEC", "\"#{files.join("\",\n\"")}\"" end diff --git a/spec/services/upload_sanitizer_spec.rb b/spec/services/upload_sanitizer_spec.rb index ccea217785..c90625fe72 100644 --- a/spec/services/upload_sanitizer_spec.rb +++ b/spec/services/upload_sanitizer_spec.rb @@ -10,7 +10,7 @@ describe UploadSanitizer do f << "Test" end end - let(:service) { UploadSanitizer.new(File.open(upload).read) } + let(:service) { UploadSanitizer.new(File.read(upload)) } it "sanitizes the uploaded file" do sanitized_upload = service.call