Luis Ramos
22a60e4fa9
Merge pull request #3769 from amers185/fix_rebase_error
...
Closes translation bug for enterprise fee settings
2019-05-03 12:53:52 +01:00
luisramos0
d7596b4066
Merge branch 'master' into fix_rebase_error
2019-05-03 12:10:57 +01:00
luisramos0
f0f08f7cd3
Update all locales with the latest Transifex translations
2019-05-02 11:22:37 +01:00
Pau Pérez Fabregat
5f47a37fac
Merge pull request #3763 from coopdevs/allow-passing-s3-region
...
Allow passing s3 region
2019-05-02 12:17:58 +02:00
Pau Pérez Fabregat
2d77605e59
Merge pull request #3764 from Matt-Yorkley/s3_backups_without_images
...
Don't use s3 for images unless images bucket has been provisioned.
2019-05-01 17:55:01 +02:00
Syed Usama Amer
75a7745736
Closes translation bug for enterprise fee settings
2019-05-01 10:43:35 -05:00
Pau Pérez Fabregat
88cbf5bd36
Merge pull request #3753 from openfoodfoundation/dependabot/bundler/whenever-0.11.0
...
Bump whenever from 0.10.0 to 0.11.0
2019-04-30 18:38:52 +02:00
Matt-Yorkley
732d0f7cf4
Don't use s3 for images unless images bucket has been provisioned.
...
Sets the "use_s3" (for images) option based on presence of `s3_images_bucket` from ofn-install instead of presence of s3 keys, for instances that use s3 for backups but not for images.
2019-04-30 17:06:42 +01:00
Pau Perez
d5b08c602a
Allow passing a specific AWS region to S3 settings
...
This solves the error showed below when executed `bundle exec rake
db2fog:backup RAILS_ENV=staging` on Katuma staging
```
Excon::Error::BadRequest: Expected(200) <=> Actual(400 Bad Request)
excon.error.response
:body => "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>AuthorizationHeaderMalformed</Code><Message>The authorization header is malformed; the region 'us-east-1' is wrong; expecting 'eu-central-1'</Message><Region>eu-central-1</Region><RequestId>3DE2763883FC601D</RequestId><HostId>1E6UapnblBqVZM0SeeLrdPNDd+VaQ0nxCWwrQ9mi8HjRo2xevAUwtSq5V3fxhsj4Cj9ynnDroco=</HostId></Error>"
```
2019-04-30 13:31:36 +02:00
Pau Perez
f36646d0a3
Store S3 keys in Config before calling db2fog
...
This ensures that Db2fog always picks up the latest value of the S3_*
env vars and not the one that was persisted last time. Now you can do
things like `S3_BUCKET=xxx bundle exec rake db2fog:backup` if you had
to.
2019-04-30 13:31:36 +02:00
Pau Pérez Fabregat
010f058618
Merge pull request #3744 from openfoodfoundation/dependabot/bundler/oj-3.7.12
...
Bump oj from 3.7.11 to 3.7.12
2019-04-30 11:53:44 +02:00
Pau Pérez Fabregat
6c9101dffa
Merge pull request #3745 from openfoodfoundation/transifex
...
Transifex
2019-04-30 11:46:17 +02:00
dependabot[bot]
2c536c29c5
Bump whenever from 0.10.0 to 0.11.0
...
Bumps [whenever](https://github.com/javan/whenever ) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/javan/whenever/releases )
- [Changelog](https://github.com/javan/whenever/blob/master/CHANGELOG.md )
- [Commits](https://github.com/javan/whenever/compare/v0.10.0...v0.11.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-04-23 19:18:23 +00:00
Transifex-Openfoodnetwork
225b159b9b
Updating translations for config/locales/en_BE.yml
2019-04-17 02:23:46 +10:00
Transifex-Openfoodnetwork
e07ae3d931
Updating translations for config/locales/en_BE.yml
2019-04-17 02:20:37 +10:00
Luis Ramos
c5720bede5
Merge pull request #3697 from coopdevs/add-delayed-job-web
...
Add delayed job web
2019-04-16 15:33:59 +01:00
dependabot[bot]
2a025be032
Bump oj from 3.7.11 to 3.7.12
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.7.11 to 3.7.12.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.7.11...v3.7.12 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-04-15 19:14:59 +00:00
Pau Pérez Fabregat
ffbea7d3fd
Merge pull request #3712 from openfoodfoundation/transifex
...
Transifex
2019-04-15 12:58:30 +02:00
Transifex-Openfoodnetwork
f76fada066
Updating translations for config/locales/es.yml
2019-04-15 19:15:24 +10:00
Transifex-Openfoodnetwork
1b01c44ce4
Updating translations for config/locales/es.yml
2019-04-15 19:12:19 +10:00
Transifex-Openfoodnetwork
10c917a693
Updating translations for config/locales/ca.yml
2019-04-15 17:08:06 +10:00
Transifex-Openfoodnetwork
418d80bdc0
Updating translations for config/locales/ca.yml
2019-04-15 17:05:00 +10:00
Pau Pérez Fabregat
e0fd2fbaa9
Merge pull request #3726 from Matt-Yorkley/db2fog_patch
...
Db2fog patch
2019-04-12 14:26:46 +02:00
Transifex-Openfoodnetwork
45ca63e751
Updating translations for config/locales/fr_BE.yml
2019-04-12 01:14:59 +10:00
Transifex-Openfoodnetwork
b6989c6d6e
Updating translations for config/locales/nl_BE.yml
2019-04-12 01:05:30 +10:00
Matt-Yorkley
7373fff190
Define default s3_protocol as 'https'
2019-04-10 19:23:16 +01:00
Matt-Yorkley
4912a9e258
Ensure ENV vars in applications.yml actually update stored Spree::Config preferences
2019-04-10 19:10:31 +01:00
Matt-Yorkley
2ac981a9a3
Make db2fog tasks conditional
2019-04-10 17:17:43 +01:00
Matt-Yorkley
37cbfcb692
Use ENV var for backups bucket
2019-04-10 17:17:17 +01:00
Transifex-Openfoodnetwork
029e8eb848
Updating translations for config/locales/de_DE.yml
2019-04-09 20:50:31 +10:00
Transifex-Openfoodnetwork
44e6adbe34
Updating translations for config/locales/en_GB.yml
2019-04-09 00:21:57 +10:00
Transifex-Openfoodnetwork
fde3d72a66
Updating translations for config/locales/en_GB.yml
2019-04-09 00:18:48 +10:00
Pau Pérez Fabregat
6e727e12e2
Merge pull request #3711 from openfoodfoundation/transifex
...
Transifex
2019-04-08 15:15:28 +02:00
Transifex-Openfoodnetwork
0261baaed3
Updating translations for config/locales/pt.yml
2019-04-08 21:06:43 +10:00
Transifex-Openfoodnetwork
4a69fdef27
Updating translations for config/locales/pt.yml
2019-04-08 21:06:39 +10:00
Transifex-Openfoodnetwork
5e672dc7d4
Updating translations for config/locales/pt.yml
2019-04-08 21:03:32 +10:00
Pau Pérez Fabregat
ffce31ca45
Merge pull request #3710 from coopdevs/pull-Transifex-translations
...
Update locales with latest Transifex translations
2019-04-08 12:56:23 +02:00
Pau Perez
860414fa31
Update locales with latest Transifex translations
2019-04-08 12:27:19 +02:00
Pau Pérez Fabregat
fa31ca5a95
Merge pull request #3686 from openfoodfoundation/transifex
...
Transifex
2019-04-08 12:23:36 +02:00
Transifex-Openfoodnetwork
f5ab89eb03
Updating translations for config/locales/it.yml
2019-04-06 07:38:45 +11:00
Transifex-Openfoodnetwork
80fd367da0
Updating translations for config/locales/en_US.yml
2019-04-06 00:27:12 +11:00
Transifex-Openfoodnetwork
231fa28713
Updating translations for config/locales/en_US.yml
2019-04-06 00:24:05 +11:00
Pau Pérez Fabregat
67376a29a6
Merge pull request #3694 from Matt-Yorkley/db2fog
...
Fix outdated db2fog initializer
2019-04-05 12:26:07 +02:00
Transifex-Openfoodnetwork
74b7418f59
Updating translations for config/locales/fr.yml
2019-04-05 04:39:15 +11:00
Transifex-Openfoodnetwork
545f2fefa4
Updating translations for config/locales/fr.yml
2019-04-05 04:36:07 +11:00
Pau Perez
aa3f0ac577
Reuse #superadmin? in Delayed Job Web route
...
This moves #superadmin? to the user decorator so it can be reused
outside FeatureFlags.
2019-04-04 16:00:27 +02:00
Pau Perez
bf20376667
Add Delayed Job Web for superadmins only
...
This adds https://github.com/ejschmitt/delayed_job_web to enable async
job management such as retries, removal of failed jobs, etc.
Only superadmins can access this web UI though. Therefore any sysadmin
that needs to use it should have access to the appropriate instance
superadmin credentials in Bitwarden.
2019-04-04 16:00:27 +02:00
Pau Pérez Fabregat
07888b355a
Merge pull request #3679 from mkllnk/3477-missing-v2-translation
...
Add missing translation for order form in v2
2019-04-04 14:25:05 +02:00
Transifex-Openfoodnetwork
8d69180c8c
Updating translations for config/locales/es.yml
2019-04-04 23:23:06 +11:00
Transifex-Openfoodnetwork
4b60a75eae
Updating translations for config/locales/ca.yml
2019-04-04 23:22:59 +11:00
Matt-Yorkley
9b45269cbb
Fix name of Spree::Config preference
2019-04-04 13:06:05 +01:00
Matt-Yorkley
7522594b85
Fix outdated db2fog initializer
2019-04-04 12:02:57 +01:00
Pau Pérez Fabregat
ec00544130
Merge pull request #3665 from mkllnk/stripe-version
...
Relax stripe version requirement
2019-04-03 17:02:40 +02:00
Pau Pérez Fabregat
c515a8f115
Merge pull request #3537 from Matt-Yorkley/pi/on_demand_error
...
Fix nil values in on_hand column
2019-04-03 11:56:06 +02:00
Pau Pérez Fabregat
b288cb00c1
Merge pull request #3654 from mkllnk/3237-spec-overrides-in-inventory-report
...
Test inventory report to use variant overrides
2019-04-03 11:55:33 +02:00
Transifex-Openfoodnetwork
898966fbea
Updating translations for config/locales/pt.yml
2019-04-03 03:20:34 +11:00
Transifex-Openfoodnetwork
b8f8ea964e
Updating translations for config/locales/pt.yml
2019-04-03 03:17:29 +11:00
Transifex-Openfoodnetwork
1874f55fa4
Updating translations for config/locales/pt.yml
2019-04-03 03:14:14 +11:00
Maikel Linke
8b6561addd
Add missing translation for order form in v2
...
I saw the following error on the 2-0-stable branch:
translation missing: en.spree.line_item_adjustments
In a pending PR I change all three translations in the view file to use
lazy lookup. This commit backports the addition to the locale so that it
can be translated via Transifex before we release v2.
2019-04-02 17:52:24 +11:00
Luis Ramos
d48d2a748b
Merge pull request #3662 from SDBowen/add_shipping_method
...
Add shipping method name to orders detail report
2019-04-01 15:37:57 +01:00
Maikel
6e31f0078a
Merge pull request #3639 from coopdevs/fix-variant-cache-refreshing-on-delete
...
Fix variant cache refreshing on delete
2019-03-29 15:12:46 +11:00
Maikel Linke
29f32604f2
Relax stripe version requirement
...
We are using the latest version of the `stripe` gem. We don't depend on
any particular version. I'm proposing to drop our dependency declaration
on a particular version and just track the current used version in
Gemfile.lock. That means fewer code changes when updating, which happens
quite frequently with this gem.
2019-03-29 13:40:51 +11:00
Maikel
973ae3d43a
Merge pull request #3656 from openfoodfoundation/dependabot/bundler/stripe-4.11.0
...
Bump stripe from 4.10.0 to 4.11.0
2019-03-29 13:39:08 +11:00
sdbowen
0f7ef2671f
Add shipping method name to orders detail report
...
Added column allows users to see the shipping method of each order.
2019-03-28 16:08:10 -06:00
Maikel
fed2b60743
Merge pull request #3644 from kevinchristianson/master
...
Fixed producer profile translation bug
2019-03-28 15:51:45 +11:00
Luis Ramos
4455073f6d
Merge pull request #3647 from luisramos0/fix-shipment-state-translation
...
Add missing translation key for order shipment state canceled
2019-03-27 13:02:14 +00:00
dependabot[bot]
6c97bb6cac
Bump stripe from 4.10.0 to 4.11.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 4.10.0 to 4.11.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v4.10.0...v4.11.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-26 19:25:43 +00:00
Maikel
d963df2c87
Merge pull request #3632 from openfoodfoundation/dependabot/bundler/oj-3.7.11
...
Bump oj from 3.7.10 to 3.7.11
2019-03-26 16:28:36 +11:00
Maikel
84246fedc9
Merge pull request #3631 from openfoodfoundation/dependabot/bundler/stripe-4.10.0
...
Bump stripe from 4.9.0 to 4.10.0
2019-03-26 16:28:08 +11:00
Maikel
6ad42fcceb
Merge pull request #3636 from openfoodfoundation/transifex
...
Transifex
2019-03-26 16:27:50 +11:00
Maikel Linke
9d4589632b
Test inventory report to use variant overrides
2019-03-26 16:13:50 +11:00
Maikel
9e3734fc3e
Merge pull request #3646 from kristinalim/fix/3528-product_sku_in_report
...
3528 Scope Customer Totals report also by variant (not just product) and use variant SKU
2019-03-26 12:05:14 +11:00
Transifex-Openfoodnetwork
a2f3110b06
Updating translations for config/locales/en_CA.yml
2019-03-26 03:33:01 +11:00
Transifex-Openfoodnetwork
e504783929
Updating translations for config/locales/fr_CA.yml
2019-03-26 03:06:18 +11:00
Transifex-Openfoodnetwork
a4bc739d48
Updating translations for config/locales/de_DE.yml
2019-03-25 16:40:06 +11:00
Kristina Lim
807cdb4746
Code style changes for Customer Totals report
2019-03-25 07:46:32 +08:00
Kristina Lim
4a95578db2
Use name helpers in Customer Totals report
2019-03-25 07:46:31 +08:00
Kristina Lim
79d0b63069
Add Spree::Address#full_name_reverse
2019-03-25 07:46:31 +08:00
Kristina Lim
7c7d61fbc5
Simplify some logic for Customer Totals report
...
Line items belong to a single order.
2019-03-25 07:46:30 +08:00
Kristina Lim
c088fb9a49
Use shorter syntax for Customer Totals report
2019-03-25 07:46:30 +08:00
Kristina Lim
46e7090d11
Group report by variant and use variant SKU
...
This groups the Customer Totals report by variant too (among others,
including by product), and then changes the report to use the variant
SKU not the product SKU.
This adds a spec for customer totals grouping and details, which
replaces the test specific to the SKU column.
2019-03-25 07:45:32 +08:00
Maikel Linke
7bc735eea3
Cover report content with specs
2019-03-25 04:47:13 +08:00
Maikel Linke
fdd8c06823
Style reports spec
2019-03-25 04:47:13 +08:00
Maikel Linke
856603cadd
Convert specs to RSpec 3.8.0 syntax with Transpec
...
This conversion is done by Transpec 3.4.0 with the following command:
transpec spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb
* 8 conversions
from: == expected
to: eq(expected)
* 8 conversions
from: obj.should
to: expect(obj).to
* 1 conversion
from: obj.stub(:message)
to: allow(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2019-03-25 04:47:13 +08:00
Maikel Linke
0a243ac9ca
Give spec vars proper names
2019-03-25 04:47:12 +08:00
Maikel Linke
6ee27cd166
Fix spec to test the right report
...
Probably a copy&paste error. The PackingReport had exactly the same
spec.
2019-03-25 04:47:12 +08:00
Maikel Linke
dac4d4ff1a
DRY report spec
2019-03-25 04:47:07 +08:00
luisramos0
2c97eaa62e
Add missing translation key for order shipment state canceled
2019-03-24 15:33:14 +00:00
Transifex-Openfoodnetwork
b979a09478
Updating translations for config/locales/en_US.yml
2019-03-23 23:42:22 +11:00
Transifex-Openfoodnetwork
f050086d47
Updating translations for config/locales/pt.yml
2019-03-23 23:28:49 +11:00
Transifex-Openfoodnetwork
dc198b7b5d
Updating translations for config/locales/pt.yml
2019-03-23 23:28:43 +11:00
Usama
698c71f039
Fixed producer profile translation bug
2019-03-22 18:25:40 -05:00
Luis Ramos
6cd07cd107
Merge pull request #3605 from kristinalim/fix/2788-improve_specs_for_order_syncer
...
[Subscriptions] (v1) Fix assertions in specs for OrderSyncer
2019-03-22 10:31:01 +00:00
Luis Ramos
8d2d5a8708
Merge pull request #3579 from luisramos0/sanitize_data
...
Add sanitize and truncate data tasks
2019-03-22 10:29:57 +00:00
Pau Pérez Fabregat
deec4f83f8
Merge pull request #3633 from mkllnk/remove-product-distribution-from-sample-data
...
Remove usage of ProductDistribution which is dead
2019-03-22 10:54:59 +01:00
Pau Pérez Fabregat
4595ea033f
Merge pull request #3624 from mkllnk/2873-spec-register-link
...
Add spec for registration link on Spree pages
2019-03-22 10:47:43 +01:00
Pau Pérez Fabregat
5b06f580e2
Merge pull request #3614 from mkllnk/3335-localized-number-for-weight-calculator
...
Support international decimals in weight calculator
2019-03-22 10:35:37 +01:00
Pau Perez
96b8c8ac2c
Refresh products cache also on Variant#delete
...
Note that, as explained in
https://apidock.com/rails/v3.2.13/ActiveRecord/Relation/delete , `delete` does
not trigger callbacks and so it skips the products cache logic.
If we still want to avoid instantiating the AR object, we need to explicitly
call that logic for the cache to be up-to-date.
2019-03-22 09:57:15 +01:00
Pau Perez
b293e00777
Test that we refresh the cache on variant destroy
...
These tests prove that
https://github.com/openfoodfoundation/openfoodnetwork/issues/3629 is
indeed is a bug because we don't refresh the cache when deleting
a variant.
2019-03-22 09:38:24 +01:00
Pau Perez
fbc3fc6a51
Test spree/admin/variants_controller #destroy
2019-03-22 09:18:31 +01:00
Transifex-Openfoodnetwork
2ba10c416a
Updating translations for config/locales/nb.yml
2019-03-22 07:41:18 +11:00
Kristina Lim
c222971e26
Clean up setup data for some OrderSyncer specs
2019-03-22 03:30:50 +08:00
Kristina Lim
0c2a75a227
Randomize bill and ship address of sample subscriptions
...
This also fixes some phone references in OrderSyncer specs.
2019-03-22 02:47:12 +08:00
Kristina Lim
7be669e1dd
Add address factory with randomized attributes
...
Randomizing all addresses generated will be explored separately.
2019-03-22 02:45:50 +08:00
Kristina Lim
d047e04e33
Customize addresses for subscriptions in specs
...
This forces us to write correct assertions when adding specs affected by
subscription addresses.
2019-03-22 01:58:27 +08:00
Transifex-Openfoodnetwork
f0d985753f
Updating translations for config/locales/fr.yml
2019-03-22 03:23:47 +11:00
Transifex-Openfoodnetwork
310b4a08b7
Updating translations for config/locales/fr.yml
2019-03-22 03:20:40 +11:00
luisramos0
61433ee395
Make anonimize and truncate tasks respect rubocop rules
2019-03-21 11:16:56 +00:00
Maikel Linke
0b7192b82a
Remove usage of ProductDistribution which is dead
...
Sample data was failing since:
https://github.com/openfoodfoundation/openfoodnetwork/pull/3570
2019-03-21 17:37:16 +11:00
Maikel Linke
3803094409
Add more examples to LocalizedNumber spec
2019-03-21 12:49:19 +11:00
Maikel Linke
3ef6878233
Avoid global state change by using config stub
2019-03-21 12:49:19 +11:00
Maikel Linke
1ea2f37c18
Support international decimals in weight calculator
...
A previous pull request added support for flexible decimal characters
when editing money amounts.
https://github.com/openfoodfoundation/openfoodnetwork/pull/1831
This pull request applies the same principle to the weight calculator
which was missed in the previous pull request.
2019-03-21 12:49:19 +11:00
Maikel
130ba64f2f
Merge pull request #3619 from openfoodfoundation/dependabot/bundler/dalli-2.7.10
...
Bump dalli from 2.7.9 to 2.7.10
2019-03-21 12:47:29 +11:00
Maikel
f1ac33f304
Merge pull request #3590 from mkllnk/3576-bulk-order-spec
...
3576 Fix bulk order management race condition
2019-03-21 12:40:41 +11:00
Maikel Linke
d62908fd2d
Add spec for registration link on Spree pages
...
The `registration_path` helper resolves to `/signup` in Spree
controllers due to spree_auth_device > config > routes.rb.
We worked around that in:
https://github.com/openfoodfoundation/openfoodnetwork/pull/3174
Here we add a spec for this so that we can test more easily if we
remove that workaround or detect it's accidental removal.
2019-03-21 10:06:15 +11:00
dependabot[bot]
6b01eba293
Bump oj from 3.7.10 to 3.7.11
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.7.10 to 3.7.11.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.7.10...v3.7.11 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-20 19:23:20 +00:00
dependabot[bot]
ee79f97aa0
Bump stripe from 4.9.0 to 4.10.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v4.9.0...v4.10.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-20 19:22:18 +00:00
Kristina Lim
d3c2d1859c
Update all locales with the latest Transifex translations
2019-03-21 01:56:45 +08:00
Kristina Lim
b942dc1074
Merge pull request #3628 from openfoodfoundation/transifex
...
Transifex
2019-03-21 01:52:58 +08:00
Transifex-Openfoodnetwork
08894c242c
Updating translations for config/locales/en_GB.yml
2019-03-21 04:04:33 +11:00
Transifex-Openfoodnetwork
eeb8f12b4e
Updating translations for config/locales/en_GB.yml
2019-03-21 04:01:27 +11:00
Transifex-Openfoodnetwork
79eb89ac0b
Updating translations for config/locales/en_GB.yml
2019-03-21 03:58:20 +11:00
luisramos0
3841656979
Rename data sanitize task to data anonymize
2019-03-20 11:58:26 +00:00
luisramos0
fefced5400
Improve sanitize data: keep customers connected to users and let addresses' city and zipcode remain as they are
2019-03-20 11:49:55 +00:00
Pau Pérez Fabregat
4f82808243
Merge pull request #3617 from luisramos0/edit-variants-specs
...
Add spec to cover editing on_hand and on_demand values in the variants edit page
2019-03-20 09:13:56 +01:00
Pau Pérez Fabregat
2a3a935c16
Merge pull request #3570 from luisramos0/byebye-prod-distributions
...
Delete dead feature product distributions
2019-03-20 09:01:23 +01:00
Maikel Linke
a66eb7fe1d
Add spec for registration link on Spree pages
...
The `registration_path` helper resolves to `/signup` in Spree
controllers due to spree_auth_device > config > routes.rb.
We worked around that in:
https://github.com/openfoodfoundation/openfoodnetwork/pull/3174
Here we add a spec for this so that we can test more easily if we can
remove that workaround or detect it's accidental removal.
2019-03-20 15:02:30 +11:00
dependabot[bot]
b0854b6d51
Bump dalli from 2.7.9 to 2.7.10
...
Bumps [dalli](https://github.com/petergoldstein/dalli ) from 2.7.9 to 2.7.10.
- [Release notes](https://github.com/petergoldstein/dalli/releases )
- [Changelog](https://github.com/petergoldstein/dalli/blob/master/History.md )
- [Commits](https://github.com/petergoldstein/dalli/compare/v2.7.9...v2.7.10 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-18 19:21:33 +00:00
luisramos0
90a14d426b
Add spec to cover editing on_hand and on_demand values in the variants edit page
2019-03-18 17:04:59 +00:00
luisramos0
9fff795162
Fix typo in en.yml in key new_shipping_category
2019-03-18 17:04:59 +00:00
luisramos0
b148b9ae46
Remove delete addresses SQL from truncate task
2019-03-18 12:04:37 +00:00
Pau Pérez Fabregat
fb29a7c7c2
Merge pull request #3606 from openfoodfoundation/dependabot/bundler/oj-3.7.10
...
Bump oj from 3.7.9 to 3.7.10
2019-03-18 12:12:13 +01:00
dependabot[bot]
d7b25d63f9
Bump oj from 3.7.9 to 3.7.10
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.7.9 to 3.7.10.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.7.9...v3.7.10 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-14 19:25:55 +00:00
Kristina Lim
3ab00d862e
Create subscriptions with set up shipping methods
...
The shipping methods are updated to their target settings after the
subscription order has been created, so the order is created with the
"require_ship_address" factory default which is "true".
The shipping method setting at time of order creation has implications
on whether a shipment is set up for the order or not.
2019-03-15 03:15:55 +08:00
Kristina Lim
ba100a6522
Specify order addresses in some OrderSyncer specs
...
This is to check that we are using the correct address data in
assertions.
This also clarifies the scenario for one of the specs.
2019-03-15 03:15:55 +08:00
Kristina Lim
7200e2c2c2
Specify hub address in some OrderSyncer specs
...
This fixes some assertions from using the same subscription shipping and
billing addresses, and distributor address.
One of the specs also pass because the subscription shipping address
matches the distributor address. This commit makes that scenario
clearer.
2019-03-15 03:15:55 +08:00
Kristina Lim
ad935e8d66
Require spec_helper.rb for OrderSyncer specs
2019-03-15 03:15:54 +08:00
Pau Pérez Fabregat
75abd4586e
Merge pull request #3583 from coopdevs/handle-deleted-oc-refreshing-cache
...
Handle deleted order cycle when refreshing cache
2019-03-14 20:11:14 +01:00
Pau Pérez Fabregat
33b74bef0e
Merge pull request #3599 from coopdevs/add-nl_BE-belgium
...
Bring in latest nl_BE translations
2019-03-14 18:59:57 +01:00
Pau Pérez Fabregat
baacea9f6a
Merge pull request #3595 from coopdevs/instrument-products-cache
...
Instrument products cache
2019-03-14 18:58:43 +01:00
Pau Perez
e60437c6a2
Refactor test to execute public API instead
2019-03-14 18:53:11 +01:00
Pau Perez
b9636b975a
Refactor test to stop using .any_instance
...
Although might be useful in very particular cases its use is discourage
by RSpec itself. See https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance
2019-03-14 18:53:11 +01:00
Pau Perez
bc34d04c31
Do not retry when refreshing cache on deleted OC
2019-03-14 18:53:11 +01:00
luisramos0
cb78f8f8c8
Fetch latest nl_BE translations from transifex with correct menu links
2019-03-13 23:29:40 +00:00
Pau Perez
fede58289b
Move Cache::Store config to new initializer
...
I don't know why but `Rails.logger` is still nil when evaluated from
`configure` block in `config/environments/development.rb`. The only way
I found to make ActiveSupport's cache to use the default logger is from
an initializer.
Note that `ActiveSupport::Cache::Store` uses `debug` level and so we
need to set the dev logger in that same level to see its messages. If
you want to debug in staging as well, you'll need to modify the log
level manually.
2019-03-13 19:08:46 +01:00
Pau Perez
15a95a3bf5
Use :file_store cache store in development
...
:memory_store uses the process' memory and therefore, what the
background job writes is not reachable for the rails server process when
it reads from the cache. See
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Products-cache#development .
2019-03-13 19:08:46 +01:00
Pau Perez
10a79d5a65
Decouple CachedProductsRenderer from the Rails env
...
This way we don't need to touch the class implementation to enable the
products cache in development. Just change the default value in
`app/models/spree/app_configuration_decorator.rb`.
2019-03-13 19:08:46 +01:00
Pau Pérez Fabregat
13b2115a29
Merge pull request #3581 from coopdevs/cache-stylistic-improvements
...
Cache stylistic improvements
2019-03-13 19:05:38 +01:00
luisramos0
8965dedfd7
Add sanitize and truncate tasks to support loading live data into other environments safely
2019-03-13 16:08:07 +00:00
luisramos0
786ba15174
Remove unused translation
2019-03-13 12:24:40 +00:00
luisramos0
7a2bc384d5
Re-add spec removed in product distributions removal but now adapted to use order cycles
2019-03-13 12:24:40 +00:00
luisramos0
34d7070c6c
Delete spec used to test product distributions (removed feature)
2019-03-13 12:24:40 +00:00
luisramos0
b62e350fab
Improve reports controller decorator by removing some copy pasted code and deleting some code repeated across data_load and the main action methods
2019-03-13 12:24:40 +00:00
luisramos0
2401b947b9
Make load sample data rake task work without product distributions
2019-03-13 12:24:40 +00:00
luisramos0
05d42d475e
Make reports and subscriptions specs work without product.distributors attribute
2019-03-13 12:24:40 +00:00
luisramos0
2de6c46834
Make order.order_cycle required in cart_service. There’s no more exception for that without product_distributions.
2019-03-13 12:24:40 +00:00
luisramos0
4768ca27c7
Remove all dependencies to product distributions including the validation to avoid deleting fees with product distributions
2019-03-13 11:50:35 +00:00
luisramos0
3117dbf624
Remove product distributions from order model
2019-03-13 11:50:35 +00:00
luisramos0
a022cebfc8
Remove product distributions from enterprise model and controller
2019-03-13 11:49:13 +00:00
luisramos0
ed9321e92d
Remove product distributions from product model and controller
2019-03-13 11:47:50 +00:00
luisramos0
86f9b3d663
Delete product_distributions: drop table and remove models, controllers and BO edit page
2019-03-13 11:47:50 +00:00
Maikel Linke
d129665d43
Wait for orders being loaded in bulk order manage
...
The bulk order management page tried to wait for orders being loaded.
But instead of receiving a request object with an a promise to wait for
the page received a simple array without promise. As a result, the page
didn't wait for orders being loaded.
When loading of orders took longer than loading of line items they or at
least not all of them were enriched with distributors and order cycles
and the line items were missing some orders. That lead to random spec
failures.
2019-03-13 10:37:24 +11:00
Pau Pérez Fabregat
2dd55770fe
Merge pull request #3569 from luisramos0/delete-more-overrides
...
Delete some more dead overrides and more dead code
2019-03-12 17:48:12 +01:00
Pau Pérez Fabregat
01baba336d
Merge pull request #3575 from openfoodfoundation/dependabot/bundler/unicorn-5.5.0
...
Bump unicorn from 5.4.1 to 5.5.0
2019-03-12 17:30:56 +01:00
Pau Perez
c4fcc25faa
Bring in latest nl_BE translations
...
As we didn't reach 100% translation Transifex does not sync the changes
into the repo. However, the Belgian instance still needs it.
2019-03-12 15:30:52 +01:00
Maikel Linke
7270a9e8e8
DRY date calculation in BOM js
...
This also minimises the risk of values changing in the meantime.
2019-03-12 18:59:14 +11:00
Maikel
6722f21cb0
Merge pull request #3593 from openfoodfoundation/transifex
...
Transifex
2019-03-12 16:01:28 +11:00
Maikel Linke
49a6b5224d
Remove duplicate expectations from spec
2019-03-12 11:35:06 +11:00
Maikel Linke
af9e80e55d
Load data after all callbacks are installed
2019-03-12 09:46:27 +11:00
Maikel Linke
0c6a5d730b
Add spaces around HAML brackets
2019-03-12 09:12:10 +11:00
Maikel Linke
6f875e83ec
Remove unconventional and unused ng:cloak selector
2019-03-12 09:10:39 +11:00
Maikel Linke
9e33ef8140
Style ng-cloak directive
2019-03-12 09:09:52 +11:00
Maikel Linke
30c1a8d924
Move ng-cloak CSS to components
2019-03-12 08:59:59 +11:00
Pau Perez
931cb89a9d
Move new class to services and rename it
2019-03-11 18:28:25 +01:00
Transifex-Openfoodnetwork
46f16c060b
Updating translations for config/locales/en_US.yml
2019-03-12 00:38:22 +11:00
Transifex-Openfoodnetwork
8afd5e7050
Updating translations for config/locales/nb.yml
2019-03-09 06:33:01 +11:00
Maikel Linke
4574a770d3
Synchronise dereferencing and initilising
...
This seems to make the spec 4 times more reliable. Still failing from
time to time.
2019-03-08 17:36:25 +11:00
Maikel Linke
e00a3ee263
Use clearer and more reliable waiting in spec
2019-03-08 17:24:31 +11:00
Maikel Linke
52fd7b102e
Unify visiting bulk order management
...
DRYing the code allows for easier refactor and more consistency.
2019-03-08 14:46:58 +11:00
Maikel Linke
37d37a6057
Speed up initial spec log in
2019-03-08 14:46:39 +11:00
Maikel Linke
2d7498b77b
Hide elements before Angular is loaded
...
The "Loading orders" spinner is still visible from the beginning so that
it can be used as indicator for when the page is loaded.
Before, the "No orders found" message was visible between page load and
Angular initilisation.
2019-03-08 14:23:18 +11:00
Maikel
22bac3daaf
Merge pull request #3588 from openfoodfoundation/transifex
...
Transifex
2019-03-08 11:31:36 +11:00
Maikel
608c322770
Merge pull request #3585 from mkllnk/1829-missing-translation-product-category
...
1829 missing translation product category
2019-03-08 10:10:09 +11:00
Transifex-Openfoodnetwork
2eb3b7acea
Updating translations for config/locales/fr.yml
2019-03-08 04:06:14 +11:00
Transifex-Openfoodnetwork
66d6936452
Updating translations for config/locales/en_GB.yml
2019-03-08 01:36:28 +11:00
Pau Pérez Fabregat
f125686016
Merge pull request #3511 from coopdevs/update-bugsnag-notifier-library
...
Update Bugsnag from 5.5.0 to 6.11.1
2019-03-07 11:30:04 +01:00
Maikel Linke
972ebb5fc9
Fix missing translation by using AR default
...
Using the default fixes a missing translation. The text is slightly
changed but should be okay as well:
- "^Tax Category is required"
+ "Tax category can't be blank"
2019-03-07 11:54:04 +11:00
Maikel Linke
5ed13d1539
Fix translation by using ActiveRecord's default
...
Our translations are not available when decorators are loaded. The
message for a missing product category was missing:
https://github.com/openfoodfoundation/openfoodnetwork/issues/1829
I moved the translation to ActiveRecord's default scope so that it can
be picked up automatically.
2019-03-07 11:37:54 +11:00
Matt-Yorkley
3f6a6f7f33
Merge pull request #3572 from openfoodfoundation/transifex
...
Transifex
2019-03-07 00:17:49 +00:00
Matt-Yorkley
59fd5ce478
Merge branch 'master' into transifex
2019-03-07 00:17:14 +00:00
Matt-Yorkley
4fe7d276b4
Update all locales with the latest Transifex translations
2019-03-07 00:04:09 +00:00
Maikel Linke
f033cfcc12
Remove obsolete Bugsnag option
...
It prevents the app from booting with the new Bugsnag version.
2019-03-07 10:04:20 +11:00
Pau Perez
8db6560fe7
Update Bugsnag from 5.5.0 to 6.11.1
...
This brings lots of fixes and a great dose of enhancements such as
a rewritten `Delayed::Job` integration.
2019-03-07 10:03:43 +11:00
Maikel
4780a2193f
Merge pull request #3209 from mkllnk/2072-test-data
...
2072 New sample data for testing
2019-03-07 08:49:12 +11:00
Pau Pérez Fabregat
e850182f95
Merge pull request #3563 from kristinalim/fix/3562-fix_payment_fee_for_order_based_calculator
...
3562 Fix error calculating payment fee using order-based calculator
2019-03-06 19:31:49 +01:00
Pau Pérez Fabregat
9f8d90cc0a
Merge pull request #3305 from coopdevs/improve-shops-performance-take-2
...
Improve shops performance take 2
2019-03-06 16:25:28 +01:00
Transifex-Openfoodnetwork
9922ce070e
Updating translations for config/locales/es.yml
2019-03-07 02:22:03 +11:00
Pau Perez
347aa3c4ae
Replace #valid_products_distributed_by by class
2019-03-06 15:06:00 +01:00
Pau Perez
adb40d6c73
Test just the public method
...
This one is the one calling the private method that was tested now. It
involves some refactoring of the specs as well.
2019-03-06 13:38:53 +01:00
Pau Perez
7c533c6347
Extract DistributedValidProducts from OrderCycle
2019-03-06 13:35:43 +01:00
luisramos0
9644fcf67c
Improve payment method factory in sample data by removing constantize
2019-03-06 10:01:17 +00:00
Pau Perez
2b58aab197
Extract method from cache key generation
2019-03-06 10:49:56 +01:00
Pau Perez
bbfd35c861
Fix CacheSettingsController violations
2019-03-06 10:45:45 +01:00
Transifex-Openfoodnetwork
0e2d303701
Updating translations for config/locales/ca.yml
2019-03-06 20:00:41 +11:00
Pau Pérez Fabregat
7e06807a11
Merge pull request #3539 from Matt-Yorkley/subs/confirmation_email
...
Don't process proxy_order if the order has been cancelled
2019-03-05 17:38:29 +01:00
Pau Pérez Fabregat
3ddee83be5
Merge pull request #3404 from luisramos0/2-0-disable-cache
...
[Spree Upgrade] Add checkbox to disable products cache
2019-03-05 14:51:11 +01:00
Pau Pérez Fabregat
30bbc5ee6f
Merge pull request #3472 from pacodelaluna/fix-datetime-picker
...
Fix datetime picker on Order Cycle form
2019-03-05 14:50:34 +01:00
Pau Pérez Fabregat
b330db3b4b
Merge pull request #2947 from Matt-Yorkley/pi/submenu_link
...
Pi/submenu link
2019-03-05 14:49:02 +01:00
Transifex-Openfoodnetwork
03aaea2a08
Updating translations for config/locales/ca.yml
2019-03-05 21:52:24 +11:00
dependabot[bot]
6ecb9cc848
Bump unicorn from 5.4.1 to 5.5.0
...
Bumps [unicorn](https://bogomips.org/unicorn/ ) from 5.4.1 to 5.5.0.
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-03-04 19:18:03 +00:00
Transifex-Openfoodnetwork
5ddb8fb1ae
Updating translations for config/locales/nb.yml
2019-03-04 21:22:36 +11:00
Pau Perez
54e120889f
Remove useless array wrapping on AR relation
2019-03-04 11:08:34 +01:00
luisramos0
5ab4ae88f5
Remove distribution change in order_spec, order distributor cannot be changed, if distributor or oc is changed, the order is emptied
2019-03-02 13:08:39 +00:00
luisramos0
7ac4a99bc7
Remove product distributions spe that needed distribution_change_validator. Product distributions will be removed soon, see https://github.com/openfoodfoundation/openfoodnetwork/issues/3525
2019-03-02 13:08:39 +00:00
luisramos0
d7bd944af3
Fix distribution_change_validator spec
2019-03-02 13:08:35 +00:00
luisramos0
351555d4e2
Remove unused methods from add_to_cart helper and distribution change validator
2019-03-02 12:55:08 +00:00
luisramos0
93e13742be
Delete some more dead overrides. We are not using spree/checkout (except for /checkout/payment) nor spree/products
2019-03-01 23:56:03 +00:00
Pau Pérez Fabregat
6c83f67b86
Merge pull request #3556 from Matt-Yorkley/pi/template
...
Add description to CSV template
2019-03-01 11:37:58 +01:00
Maikel
a14c785e69
Merge pull request #3435 from Matt-Yorkley/bug/tmpfile
...
Use Dir::Tmpname.make_tmpname for threadsafe file naming
2019-03-01 10:20:26 +11:00
Maikel
54679f6651
Merge pull request #3535 from luisramos0/translations-for-v2
...
Move to master all en.yml entries added so far to v2 and add more missing v2 translations
2019-03-01 10:04:13 +11:00
luisramos0
e4edfe0b61
Merge branch 'master' into translations-for-v2
2019-02-28 21:32:34 +00:00
Pau Pérez Fabregat
88e6fa84a2
Merge pull request #3534 from luisramos0/registration_trans_all
...
Move registration process translations to lazy lookups to better organize the en.yml file
2019-02-28 17:15:09 +01:00
Pau Pérez Fabregat
aa635106ac
Merge pull request #3531 from mkllnk/document-stock-validation-rules
...
Document stock validation of variant overrides
2019-02-28 17:14:45 +01:00
Pau Pérez Fabregat
89708de7c1
Merge pull request #3512 from kristinalim/fix/3478-scope_enterprise_fee_summary_to_eligible
...
3466,3478 [Enterprise Fee Summary] Scope report to eligible: true and non-zero adjustments
2019-02-28 17:14:15 +01:00
Pau Pérez Fabregat
6f0479c27d
Merge pull request #3547 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.16
...
Bump combine_pdf from 1.0.15 to 1.0.16
2019-02-28 17:13:50 +01:00
Pau Pérez Fabregat
63312a6d5f
Merge pull request #3554 from coopdevs/bring-bugsnag-initializer
...
Bring in Bugsnag initializer from ofn-install
2019-02-28 16:41:59 +01:00
Kristina Lim
36e4a22b58
Use delegate for Payment#line_items
2019-02-28 09:52:56 +08:00
Kristina Lim
bd58667747
Remove stock check done for payment fees
2019-02-28 09:24:29 +08:00
Maikel Linke
958e98debd
Document stock validation of variant overrides
2019-02-28 12:21:26 +11:00
Kristina Lim
ce658e9dfa
Fix error computing payment fee when order-based
2019-02-28 12:17:45 +11:00
Kristina Lim
dfc8cc0f9e
Add failing test for calculation of payment fee
2019-02-28 12:17:44 +11:00
Maikel
4ed0831e4c
Merge pull request #3550 from openfoodfoundation/transifex
...
Transifex
2019-02-28 11:39:57 +11:00
Maikel
824beba066
Merge pull request #3505 from luisramos0/vo-false
...
Adapt scope_variant_to_hub to new VO rules where on_demand=nil means use_producer_settings
2019-02-28 10:26:23 +11:00
Maikel
c472d2fbbe
Merge pull request #3498 from luisramos0/delete-dead-overrides
...
Remove dead overrides
2019-02-28 10:25:42 +11:00
luisramos0
03d242c061
Fix typo in sample_data zone creation (zonEable) and added clause to avoid re-adding the same country to the zone
2019-02-27 23:19:39 +00:00
luisramos0
ad5c379771
Make sample data zone read from the environment variable CHECKOUT_ZONE
2019-02-27 09:46:18 +00:00
luisramos0
d418ca1b1f
Add mandatory payment method provider to sample data payment methods
2019-02-27 09:45:21 +00:00
Pau Pérez Fabregat
a04de6e3cd
Merge pull request #3499 from openfoodfoundation/dependabot/bundler/stripe-4.9.0
...
Bump stripe from 4.5.0 to 4.9.0
2019-02-27 09:56:32 +01:00
Danni M
5b880f7bfe
Update issue templates
...
Fixed headings on the story template
2019-02-27 10:41:39 +11:00
François Turbelin
82fbcd35a8
Update tests
2019-02-26 22:07:11 +01:00
Matt-Yorkley
9dd5b9dd6c
Fix import button specificity in feature spec
2019-02-26 20:06:02 +00:00
Matt-Yorkley
25e2d2adda
Update references to product_sub_menu view
2019-02-26 20:06:01 +00:00
Matt-Yorkley
777850259b
Apply and delete overrides
2019-02-26 19:42:47 +00:00
Matt-Yorkley
f1e55507c3
Recreate product_sub_menu Spree view
2019-02-26 19:42:47 +00:00
Matt-Yorkley
32470f33ec
Add description to CSV template
2019-02-26 19:36:44 +00:00
luisramos0
3f3581cdbc
Add more missing translations for v2, remove unnecessary en.order_state and remove duplicated en.spree.payment_states and en.spree.shipment_states
2019-02-26 16:54:48 +00:00
Pau Perez
4d47276810
Bring Bugsnag initializer from ofn-install
...
This copies ofn-install's `roles/app/templates/bugsnag.rb.j2` to
`config/initializers/bugsnag.rb`. All tasks and templates
regarding Bugsnag can then be 🔥 from ofn-install.
As a result, it'll fix the issue that both Katuma and OFF are facing
where the `config/initializer/bugsnag.rb` symlink to
`shared/config/bugsnag.rb` does not exist thus, nothing gets notified to
Bugsnag since December 3rd (according to customer support).
2019-02-26 17:52:49 +01:00
Pau Perez
a728da4f62
Cover product and producer props. in ctrl. spec
2019-02-26 12:09:26 +01:00
Pau Perez
915b5cf09e
Inline also the active product properties query
...
This makes it easier to spot what are the differences and similarities
between active and non-active, which in turn, it'll help remove the N+1
the "active" branch causes.
Make it look `#distributed_producer_properties` with which seems to
share a lot.
2019-02-26 11:39:43 +01:00
Pau Perez
19cbda4128
Fix Rubocop violation
2019-02-26 11:39:43 +01:00
Pau Perez
24c031b3cd
Extract #distributed_product_properties method
2019-02-26 11:39:43 +01:00
Pau Perez
6e9bb640f6
Add spacing between long scopes
2019-02-26 11:36:36 +01:00
Pau Perez
7b2d4f10ee
Cover #distributed_properties \w a controller spec
...
This exercises the controller and the serializer ensuring the
integration works allowing to confidently refactor things further.
2019-02-26 11:36:36 +01:00
Pau Perez
e55fbf80fc
Check property presentation attribute only in test
...
The PropertySerializer contains :id, :name and :presentation attributes
which leads to JSON objects like `{"id": 1, "name": "foo",
"presentation": "foo"}`. Because of this, we don't care about object
identity, just about their presentation attribute.
2019-02-26 11:36:36 +01:00
Pau Perez
d4635bd7cb
Fetch Property instead of ProducerProps from query
...
By not having to treat producer properties differently we can filter and
fetch all properties from DB without having to process it with Ruby and
with a single query.
2019-02-26 11:36:36 +01:00
Pau Perez
92e2ed78d1
Test active distributor as well
2019-02-26 11:36:36 +01:00
Pau Perez
8eb35e491d
Don't fetch rows by ids of DISTINCT records
...
There's no point on fetching the same records again by the resulting ids
of the previous query (nasty way of removing duplicates), when that
query has a DISTINCT.
2019-02-26 11:36:36 +01:00
Pau Perez
328cda66f5
Stop using PropertyMerge in serializer
2019-02-26 11:36:36 +01:00
Pau Perez
47a90e937b
Have a duplicate product to test with
2019-02-26 11:36:36 +01:00
Pau Perez
8fef69387e
Simplify test setup using factory transient attrs
2019-02-26 11:36:36 +01:00
Pau Perez
0782907f4d
Setup a test order cycle with its exchanges
2019-02-26 11:36:36 +01:00
Pau Perez
64fb230297
Make it more obvious we talk about an enterprise
2019-02-26 11:36:36 +01:00
Pau Perez
a5f890cf36
Fix styling on method
2019-02-26 11:36:36 +01:00
Transifex-Openfoodnetwork
539544de28
Updating translations for config/locales/es.yml
2019-02-26 20:49:18 +11:00
Transifex-Openfoodnetwork
595fb75d82
Updating translations for config/locales/es.yml
2019-02-26 20:46:12 +11:00
François Turbelin
e1953c279b
Move jquery-ui-timepicker libs to vendor dir
2019-02-25 22:48:30 +01:00
François Turbelin
ab86332949
Tune up config and style
2019-02-25 22:22:27 +01:00
François Turbelin
68fd6de39b
Update Jquery datetimepicker lib to v1.6.3
2019-02-25 22:22:27 +01:00
dependabot[bot]
a1647053cb
Bump combine_pdf from 1.0.15 to 1.0.16
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.15 to 1.0.16.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.15...v1.0.16 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-25 19:26:41 +00:00
Pau Pérez Fabregat
df77f6e051
Merge pull request #3536 from Matt-Yorkley/flaky/bom_spec
...
Wait for angular to load in BOM spec
2019-02-25 13:14:57 +01:00
Pau Pérez Fabregat
6004d09698
Merge pull request #3538 from Matt-Yorkley/flaky/shipping_methods_spec
...
Adjust expectations in flaky spec
2019-02-25 12:50:48 +01:00
Matt-Yorkley
6e77afbf35
Adjust expectations in flaky spec
2019-02-25 11:08:10 +00:00
Pau Pérez Fabregat
4e180f9f43
Merge pull request #3517 from openfoodfoundation/dependabot/bundler/oj-3.7.9
...
Bump oj from 3.7.8 to 3.7.9
2019-02-25 11:37:43 +01:00
Pau Pérez Fabregat
59962bbfb1
Merge pull request #3540 from openfoodfoundation/transifex
...
Transifex
2019-02-25 11:36:56 +01:00
Matt-Yorkley
bbfe71fd27
Improve readability and add code comment
2019-02-25 10:27:34 +00:00
Transifex-Openfoodnetwork
021220514e
Updating translations for config/locales/ca.yml
2019-02-25 21:11:12 +11:00
luisramos0
963fddf159
Add missing translations
...
These translations are missing in v2 but some will also make v1 better
2019-02-24 22:29:44 +00:00
luisramos0
f40ff61f97
Move all en.yml entries added so far to v2 to master so that we can start the translation process now
2019-02-24 22:28:30 +00:00
Matt-Yorkley
627b101be9
Don't process proxy_order if the order has been cancelled
2019-02-24 12:06:58 +00:00
Matt-Yorkley
ea8be0ab95
Fine-tune angular helper
2019-02-23 21:45:33 +00:00
Matt-Yorkley
c4b646c583
Wait for angular to load in BOM spec
2019-02-23 16:12:37 +00:00
luisramos0
ee8fe4b6b4
Move registration process translations to lazy lookups to better organize the en.yml file
2019-02-22 14:37:45 +00:00
luisramos0
0b1ea1beda
Rename VariantOverride.use_producer_settings to VariantOverride.use_producer_stock_settings
2019-02-22 09:57:21 +00:00
Pau Pérez Fabregat
632826a192
Merge pull request #3494 from luisramos0/break-oc-specs
...
Break order_cycle_spec.js in specific files and remove reference to product.count_on_hand in bulk_product_update_spec.js
2019-02-22 08:30:35 +01:00
luisramos0
45e5fed609
Improve scope_variant_to_hub code and spec by testing an invalid data state
2019-02-21 11:25:01 +00:00
Maikel
509e644cf7
Merge pull request #3526 from openfoodfoundation/transifex
...
Transifex
2019-02-21 16:05:21 +11:00
Transifex-Openfoodnetwork
4b21c9cb70
Updating translations for config/locales/en_CA.yml
2019-02-21 07:32:50 +11:00
Luis Ramos
34acaa4e03
Merge pull request #3425 from mkllnk/2783-product-importer-spec
...
Apply import defaults to variants of new products in Spree 2
2019-02-20 13:34:57 +00:00
Matt-Yorkley
f73221ed85
Use Dir::Tmpname.make_tmpname for threadsafe file naming
2019-02-20 13:10:47 +00:00
luisramos0
ef786adcfc
Make variant_override.stock_overridden? simpler and add comment to explain relationship between count_on_hand and on_demand in a VO
2019-02-20 13:07:21 +00:00
Maikel
ec26948949
Merge pull request #3521 from openfoodfoundation/transifex
...
Transifex
2019-02-20 19:10:16 +11:00
Transifex-Openfoodnetwork
aba4d742f6
Updating translations for config/locales/fr_CA.yml
2019-02-20 12:55:33 +11:00
Maikel
e7e2d1d870
Merge pull request #3516 from openfoodfoundation/transifex
...
Transifex
2019-02-20 10:39:55 +11:00
Transifex-Openfoodnetwork
7e59132bb2
Updating translations for config/locales/en_GB.yml
2019-02-20 06:50:52 +11:00
dependabot[bot]
47e154f2ac
Bump oj from 3.7.8 to 3.7.9
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.7.8 to 3.7.9.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.7.8...v3.7.9 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-19 19:21:37 +00:00
Transifex-Openfoodnetwork
9688fe7540
Updating translations for config/locales/fr.yml
2019-02-20 06:15:01 +11:00
Maikel
f0a6f5ae3c
Merge pull request #3514 from openfoodfoundation/transifex
...
Transifex
2019-02-19 15:40:30 +11:00
Transifex-Openfoodnetwork
0a50a74561
Updating translations for config/locales/en_US.yml
2019-02-19 15:23:20 +11:00
Maikel
bb4d42ef9d
Merge pull request #3464 from openfoodfoundation/transifex
...
Transifex
2019-02-19 12:41:16 +11:00
Maikel
1b45033e33
Merge pull request #3506 from Matt-Yorkley/pi/parse_bom
...
Sanitize non-parsable BOM characters inserted by Excel
2019-02-19 11:24:11 +11:00
Maikel
be59a8ce32
Merge pull request #3434 from Matt-Yorkley/pi/fix_hash_merge
...
Fix hash merge for recording already created products by name
2019-02-19 11:21:49 +11:00
Maikel
b7abb72ed5
Merge pull request #3462 from luisramos0/delete-api-order-ctrl
...
Delete empty controller class eval and spec
2019-02-19 11:14:29 +11:00
Maikel
ae4d36b3ed
Merge pull request #3451 from Matt-Yorkley/subs/currency
...
Use localized currency symbols in Subs pages
2019-02-19 09:55:36 +11:00
Matt-Yorkley
9705c249ac
Sanitize no-parsable BOM characters inserted by Excel
2019-02-18 13:13:37 +00:00
Kristina Lim
b0a82b0e21
Exclude $0 adjustments from report
2019-02-18 16:53:19 +08:00
Kristina Lim
36fd385f7d
Add test showing $0 mandatory adjustments included
2019-02-18 16:53:19 +08:00
Kristina Lim
19f99255fa
Exclude non-eligible entries from report
2019-02-18 16:53:18 +08:00
Kristina Lim
8ce7337c9d
Add test showing $0 non-mandatory adjustments included
2019-02-18 16:53:18 +08:00
Kristina Lim
ca2c8e6ff2
Add test showing non-"eligible" entries included
2019-02-18 16:53:18 +08:00
Pau Pérez Fabregat
f5df10f5dc
Merge pull request #3507 from openfoodfoundation/dependabot/bundler/selenium-webdriver-3.141.0
...
Bump selenium-webdriver from 3.12.0 to 3.141.0
2019-02-18 09:28:01 +01:00
Matt-Yorkley
09655b9f88
Fix nil values in on_hand column
2019-02-16 01:05:20 +00:00
dependabot[bot]
ed7015ae98
Bump selenium-webdriver from 3.12.0 to 3.141.0
...
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium ) from 3.12.0 to 3.141.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/master/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-3.12.0...selenium-3.141.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-15 19:20:25 +00:00
luisramos0
75a79717cf
Adapt scope_variant_to_hub to new VO rules where on_demand nil is seen as use_producer_settings
2019-02-15 14:05:24 +00:00
Transifex-Openfoodnetwork
9bf5531233
Updating translations for config/locales/nb.yml
2019-02-15 23:47:20 +11:00
Pau Pérez Fabregat
93c6271400
Merge pull request #3500 from openfoodfoundation/dependabot/bundler/bugsnag-5.5.0
...
Bump bugsnag from 4.1.0 to 5.5.0
2019-02-15 09:26:41 +01:00
Pau Pérez Fabregat
0a391783bc
Merge pull request #3470 from kristinalim/fix/3426-intermittent_spec_failures
...
3426 [Flaky Spec] Address timing issues in enterprise users feature specs
2019-02-15 08:39:39 +01:00
Maikel Linke
6790e8895d
Create sample payment methods with current environment
2019-02-15 16:44:55 +11:00
Maikel
d4589cc2f4
Merge pull request #3444 from mkllnk/3437-supplier-name-on-invoice
...
3437 supplier name on invoice
2019-02-15 16:31:29 +11:00
Matt-Yorkley
0c5cc23415
Fix hash merge for recording already created products by name
2019-02-14 21:38:18 +00:00
dependabot[bot]
7c5e58dd94
Bump bugsnag from 4.1.0 to 5.5.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 4.1.0 to 5.5.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v4.1.0...v5.5.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-14 19:34:17 +00:00
dependabot[bot]
a369b48bf4
Bump stripe from 4.5.0 to 4.9.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 4.5.0 to 4.9.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v4.5.0...v4.9.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-14 19:30:48 +00:00
Pau Pérez Fabregat
6f2b894cfe
Merge pull request #3403 from openfoodfoundation/dependabot/bundler/dalli-2.7.9
...
Bump dalli from 2.7.2 to 2.7.9
2019-02-14 20:12:06 +01:00
Pau Pérez Fabregat
43fff8f18d
Merge pull request #3460 from openfoodfoundation/dependabot/bundler/spinjs-rails-1.4
...
Bump spinjs-rails from 1.3 to 1.4
2019-02-14 19:42:33 +01:00
luisramos0
4a35b53b43
Remove dead overrides
2019-02-14 18:00:25 +00:00
Pau Pérez Fabregat
34020f7bf6
Merge pull request #3377 from openfoodfoundation/dependabot/bundler/i18n-js-3.2.1
...
Bump i18n-js from 3.1.0 to 3.2.1
2019-02-14 18:26:49 +01:00
Kristina Lim
af95e3871f
Move check for table presence out of helper
2019-02-15 01:15:58 +08:00
luisramos0
bf4ce90f98
Add product.on_hand and product.on_demand positive test, these should be returned if no variants are provided in the input
...
Also, removed product.count_on_hand negative test (there's no such attriubte in v2) and added product.on_hand, this should not be returned because a variant is provided
2019-02-14 15:58:15 +00:00
luisramos0
bfa0734cc6
Break order_cycle_spec.js in specific files like create controller, edit controller and services
...
Move bulk_product_update_spec.js to its apropriate place under /admin
2019-02-14 15:57:40 +00:00
Pau Pérez Fabregat
0a885af7a6
Merge pull request #3481 from mkllnk/simplify-stripe-creation-in-specs
...
Simplify specs with stripe factory
2019-02-14 09:42:05 +01:00
Transifex-Openfoodnetwork
a71c89f70e
Updating translations for config/locales/en_GB.yml
2019-02-14 18:01:18 +11:00
Transifex-Openfoodnetwork
19568577f5
Updating translations for config/locales/es.yml
2019-02-14 18:01:18 +11:00
Transifex-Openfoodnetwork
71b24ba314
Updating translations for config/locales/ca.yml
2019-02-14 18:01:17 +11:00
Maikel
9058729a9d
Merge pull request #3459 from openfoodfoundation/dependabot/bundler/rspec-rails-3.8.2
...
Bump rspec-rails from 3.8.1 to 3.8.2
2019-02-14 17:18:07 +11:00
Maikel Linke
87abfcd704
Simplify shopping spec
2019-02-14 11:42:46 +11:00
Maikel Linke
5f5b0aaabf
Simplify specs with stripe factory
2019-02-13 18:34:22 +11:00
Maikel Linke
612ea4c781
Simplify spec of invoice creation
2019-02-13 17:55:48 +11:00
Maikel
a36dc13192
Add issue templates for tech debt
2019-02-13 17:26:56 +11:00
Pau Pérez Fabregat
bda5eb1b1f
Merge pull request #3337 from kristinalim/feature-enterprise_fees_report-order_based_calculator_bug
...
3283 [Enterprise Fee Summary] Fix values when calculator is order-based
2019-02-12 20:07:57 +01:00
Kristina Lim
5e8a336e24
Initialize data representation classes with data
...
There is no more need to pass the summarizer.
2019-02-13 01:51:34 +11:00
Kristina Lim
ddc788ed5d
Move data representation translations to class
2019-02-13 01:51:34 +11:00
Kristina Lim
bc95560598
Add descriptions for data representation classes
2019-02-13 01:51:33 +11:00
Kristina Lim
664943a6e5
Include UsingEnterpriseFee instead of inheriting
2019-02-13 01:51:33 +11:00
Kristina Lim
b9c144bb1f
Prepare to change AssociatedEnterpriseFee to module
...
The superclasses will include this module, instead of inheriting the class.
2019-02-13 01:51:32 +11:00
Kristina Lim
373e3e1039
Simplify name of SQL data summarizer class
2019-02-13 01:51:32 +11:00
Kristina Lim
7a76355cfe
Separate summarizing of SQL data by source
2019-02-13 01:51:32 +11:00
Kristina Lim
c4801aafd4
Fix Fee Calc on Transfer Through and Tax Category
...
For exchange fees with calculator that is order-based:
* "Fee Calc on Transfer Through" should show "Entire Orders through
DISTRIBUTOR_NAME".
* For tax category:
a. If the enterprise fee itself has a tax category, this is used.
b. If the enterprise fee inherits the product's tax category, this is
"Various".
c. If the enterprise fee has no tax, this is blank.
For coordinator fees:
* "Fee Calc on Transfer Through" should be "All".
* For tax category: Same as abova.
2019-02-13 01:51:31 +11:00
Kristina Lim
8f65beeb0b
Clarify method name in report scope
2019-02-13 01:51:31 +11:00
Kristina Lim
e550be9bda
Add test for using order-based exchange fees
...
This is not filling the "Fee Calc on Transfer Through" column. This will
be addressed in another commit.
2019-02-13 01:51:31 +11:00
Kristina Lim
0212454041
Refactor SQL result summarizer for report
2019-02-13 01:51:30 +11:00
Kristina Lim
06ba5182b4
Add flat rate calculator traits to related factories
2019-02-13 01:51:30 +11:00
dependabot[bot]
0fc9ead934
Bump i18n-js from 3.1.0 to 3.2.1
...
Bumps [i18n-js](https://github.com/fnando/i18n-js ) from 3.1.0 to 3.2.1.
- [Release notes](https://github.com/fnando/i18n-js/releases )
- [Changelog](https://github.com/fnando/i18n-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fnando/i18n-js/compare/v3.1.0...v3.2.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-12 13:19:50 +00:00
Pau Pérez Fabregat
1f72eb9f68
Merge pull request #3378 from kevinchristianson/active-products-translation-fix
...
Add missing 'active products' translation on dashboard
2019-02-12 14:15:53 +01:00
Pau Pérez Fabregat
a0c144fd0c
Merge pull request #3415 from openfoodfoundation/feature/enterprise_fee_summary
...
[Enterprise Fee Summary] Merge "Enterprise Fee Summary" report to master
2019-02-12 13:58:47 +01:00
Pau Pérez Fabregat
a6c5e3423f
Merge pull request #3474 from Matt-Yorkley/pi/broken_build
...
Fix broken spec from refactored method
2019-02-12 11:03:28 +01:00
Matt-Yorkley
097ffba323
Fix broken spec from refactored method
2019-02-11 23:57:13 +00:00
Pau Pérez Fabregat
4165ba5cdb
Merge pull request #3463 from coopdevs/enable-catalan
...
Import Catalan translation from Transifex
2019-02-11 18:13:50 +01:00
Pau Perez
990de63728
Merge branch 'master' into active-products-translation-fix
...
* master: (46 commits)
Wait for button to disappear before checking flash
Use flash matcher in shipping method feature specs
Add RSpec matchers for flash messages
Do not expect modal open when checking spinner gone
Update issue templates
Update all locales with the latest Transifex translations
Do not show table until first time dereferencing is done
Remove unused have_no_selector argument in feature test
Compile row ID with higher priority
Compile edit link with higher priority
Support selecting date in next months
Improve sync between keyword filter and selecting all
Wait for datepicker to associate and open before selecting date
Update cancan permissions for second iteration of bulk invoices
Fix shop accidentally becoming order coordinator
Match date format in spec with import date filter
Update name spaces for rake tasks to shorter 'ofn'.
Refactor checking no preview image in specs
Refactor checking of preview image path in specs
Fix race condition in enterprise image feature specs
...
2019-02-11 16:12:52 +01:00
Pau Pérez Fabregat
9d065c8a0b
Merge pull request #3233 from Matt-Yorkley/pi/inventories
...
Pi/inventories
2019-02-11 16:10:33 +01:00
Pau Pérez Fabregat
da09c8f86c
Merge pull request #3467 from kristinalim/fix/3455-intermittent_spec_failure
...
3455 [Flaky Spec] Do not expect modal still open when checking that the spinner is gone
2019-02-11 15:58:22 +01:00
Pau Pérez Fabregat
b508d51406
Merge pull request #3469 from kristinalim/fix/3468-intermittent_spec_failures
...
3468 [Flaky Spec] Check for presence of flash div before trying to get its text
2019-02-11 15:54:33 +01:00
luisramos0
acc99fc9bb
Improve readability of cached_product_renderer and respective spec
2019-02-11 11:46:04 +00:00
Kristina Lim
a876c2ab9f
Address timing issues in enterprise roles specs
2019-02-11 13:02:40 +08:00
Kristina Lim
0032a237a2
Wait for button to disappear before checking flash
2019-02-10 22:08:18 +08:00
Kristina Lim
175264f41f
Use flash matcher in shipping method feature specs
2019-02-10 22:08:18 +08:00
Kristina Lim
e14c60c1c1
Add RSpec matchers for flash messages
2019-02-10 22:08:18 +08:00
Kristina Lim
f143540d0c
Do not expect modal open when checking spinner gone
...
The element referenced in the following might no longer be visible:
within "div.reveal-modal"
2019-02-09 22:40:40 +08:00
Kristina Lim
b6be8c48d1
Fix layout violation in Spree::Ability decorator
2019-02-08 21:26:39 +00:00
Kristina Lim
de30cf1198
Fix description for feature flag example groups
2019-02-08 21:26:39 +00:00
Kristina Lim
461b5725d1
Hide report link and resource from non-superadmins
2019-02-08 21:26:38 +00:00
Kristina Lim
1d3f4aa28a
Add feature flag for enterprise fee summary
2019-02-08 21:26:38 +00:00
Kristina Lim
f59834ddc8
Use receiver as "Fee Calc on Transfer Through" for outgoing exchanges
2019-02-08 21:26:38 +00:00
Kristina Lim
ddf15f1d30
Add scenario test for enterprise fee summary
...
Add test for more complex scenario where there is a coordinator and
distributor fee for an incoming exchange, and a producer and coordinator
fee for an outgoing exchange.
2019-02-08 21:26:38 +00:00
Kristina Lim
c92d202612
Rename files for factories in spec/factories/
...
Make these follow the "#{SINGULAR_OBJECT}_factory.rb" convention.
2019-02-08 21:26:38 +00:00
Kristina Lim
625069cb5a
Add :per_item factory trait to shipping and payment methods
2019-02-08 21:26:38 +00:00
Kristina Lim
d2e49b8b49
Move variant setup to new factory trait
2019-02-08 21:26:38 +00:00
Kristina Lim
f36d13a736
Rename helper for setting up incomplete order
2019-02-08 21:26:38 +00:00
Kristina Lim
ce030aeb07
Move order setup to new factory traits
2019-02-08 21:26:38 +00:00
Kristina Lim
a3aa594c42
Use enterprise fee factory trait where applicable
2019-02-08 21:26:38 +00:00
Kristina Lim
5dda3b67eb
Use factory for tax category in entperprise fee summary tests
2019-02-08 21:26:38 +00:00
Kristina Lim
61ec43f868
Add enterprise fee factory trait for per item rate
...
We should not presume what is not default for an enterprise fee object.
2019-02-08 21:26:38 +00:00
Kristina Lim
53c458f817
Clean up setup data for enterprise fee summary tests
2019-02-08 21:26:38 +00:00
Kristina Lim
4a73b1d26c
Do not include incomplete orders in report
2019-02-08 21:26:38 +00:00
Kristina Lim
eaa7800427
Do not assign I18n translation to constants
...
The preferred language could change dynamically.
2019-02-08 21:26:38 +00:00
Kristina Lim
6378afdddb
Address Rubocop violation
2019-02-08 21:26:38 +00:00
Kristina Lim
c81be75530
Move engine libraries except Engine and Version to services
2019-02-08 21:26:38 +00:00
Kristina Lim
3e499faa7c
Do not use ReportData::EnterpriseFeeTypeTotals
2019-02-08 21:26:38 +00:00
Kristina Lim
3f84d0008a
Move some in OpenFoodNetwork to engine services
...
This removes the OpenFoodNetwork namespace from these too.
2019-02-08 21:26:38 +00:00
Kristina Lim
95e3a2f45d
Move authorization to the ::Parameters class
2019-02-08 21:26:38 +00:00
Kristina Lim
c61a83faca
Move routes for enterprise fee summary to engine
2019-02-08 21:26:38 +00:00
Kristina Lim
9e035efd50
Render enterprise fee report directly in renderer
2019-02-08 21:26:38 +00:00
Kristina Lim
c8b154b12a
Separate enterprise fee summary action
...
Split the previous "index" action into "new" and "create" actions.
2019-02-08 21:26:38 +00:00
Kristina Lim
da914289ea
Copy spree/admin/reports#index into application
2019-02-08 21:26:38 +00:00
Kristina Lim
a17fa8013f
Clean up I18n scope in feature specs for report
2019-02-08 21:26:38 +00:00
Kristina Lim
c0e6b70131
Rename EnterpriseFeeSummaryReportController
...
Remove "Report" because this is redundant, and pluralize the resource
name.
2019-02-08 21:26:38 +00:00
Kristina Lim
207b6c7f30
Use shorthand for RSpec expect(subject).to
2019-02-08 21:26:38 +00:00
Kristina Lim
2063752b97
Improve specs for Enterprise Fee Summary
...
This also addresses a spec that has failed over the rebasing.
2019-02-08 21:26:38 +00:00
Kristina Lim
2bf38b3ea1
Improve code based on Rubocop recommendations
2019-02-08 21:26:38 +00:00
Kristina Lim
552bf1b9f7
Move report list to own class
2019-02-08 21:26:38 +00:00
Kristina Lim
b78e2b4720
Move lib files for enterprise fee summary to engine
2019-02-08 21:26:38 +00:00
Kristina Lim
0cdcd96bb5
Add skeleton for OrderManagement engine
2019-02-08 21:26:38 +00:00
Kristina Lim
dcb1d9fe25
Add feature tests for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
edf0b0df76
Add navigation item for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
d3e9a53120
Filter enterprise fee summary for user permissions
2019-02-08 21:26:37 +00:00
Kristina Lim
8ad53055c7
Allow non-admins to see enterprise fee summary
...
Relax controller permissions for enterprise fee summary. Even non-admin
enterprise users should be able to see these reports.
Filtering of data based on permissions is handled in:
* OrderManagement::Reports::EnterpriseFeeSummary::Authorizer and
* OrderManagement::Reports::EnterpriseFeeSummary::Permissions.
2019-02-08 21:26:37 +00:00
Kristina Lim
f81f4b7e4a
Authorize filters before generating enterprise fee report
2019-02-08 21:26:37 +00:00
Kristina Lim
9ce313c7f5
Define filter authorizer for enterprise fee report
2019-02-08 21:26:37 +00:00
Kristina Lim
cd3e258b59
Rename report authorizers to reflect permissions
2019-02-08 21:26:37 +00:00
Kristina Lim
469988856d
Define permissions for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
5fce9d0a7d
Add multi-distributor scope to shipping and payment methods
2019-02-08 21:26:37 +00:00
Kristina Lim
24ab2e7fb0
Add filtering to enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
2407531957
Make more code for report tests reusable
2019-02-08 21:26:37 +00:00
Kristina Lim
d573dc5023
Make order builder for enterprise fee summary flexible
...
This is in preparation for tests for filtering the report.
2019-02-08 21:26:37 +00:00
Kristina Lim
4a00aceba2
Include shipping fees in enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
1273cc085b
Include payment fees in enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
7d74ddc85b
Add HTML view for enterprise fee summary report
2019-02-08 21:26:37 +00:00
Kristina Lim
418050c1b8
Remove blank strings from array report parameters
...
Remove the blank strings that Rails multiple selects add by default to
make sure that blank lists are still submitted to the server as arrays
instead of nil.
https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-select
2019-02-08 21:26:37 +00:00
Kristina Lim
6e03ab03f5
Extract general behaviour for report parameters
2019-02-08 21:26:37 +00:00
Kristina Lim
34dc16f8c9
Base filter options from initial authorizer object
2019-02-08 21:26:37 +00:00
Kristina Lim
bd2b4c0134
Add enterprise fee summary form without options
...
The objects will be filled in another commit. This simply sets up the
filters UI for now.
2019-02-08 21:26:37 +00:00
Kristina Lim
ec81e4221f
Add basic action for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
b7439d2574
Fix sort for nil cells in enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
5b6bbc3920
Add generation of CSV renderer filename
2019-02-08 21:26:37 +00:00
Kristina Lim
ed2b8e9b9f
Add CSV renderer for enterprise fee summary report
2019-02-08 21:26:37 +00:00
Kristina Lim
00e70733b0
Add test data for enterprise fee summary report
2019-02-08 21:26:37 +00:00
Kristina Lim
e7ed625d5a
Add processing of enterprise fee summary from DB
2019-02-08 21:26:37 +00:00
Kristina Lim
faf7079780
Specify sort order of enterprise fee totals data
2019-02-08 21:26:37 +00:00
Kristina Lim
3763cb98a3
Add data classes for Enterprise Fee Summary report
2019-02-08 21:26:37 +00:00
Kristina Lim
a097640464
Add basic form object for enterprise fee summary
2019-02-08 21:26:36 +00:00
Kristina Lim
519a7d2ee6
Add datetime and integer array validator matchers
2019-02-08 21:26:36 +00:00
Kristina Lim
f6e8f18d89
Add validator for integer arrays
...
Example usage:
validates :related_post_ids, integer_array: true
2019-02-08 21:26:36 +00:00
Kristina Lim
de9cff6fc2
Add validator for datetime string
...
Example usage:
validates :start_at, date_time_string: true
2019-02-08 21:26:36 +00:00
Pau Perez
7359789903
Import Catalan translation from Transifex
...
Although we've started translating to Catalan and focused on it
recently, we never imported the file in the app thus the language menu
showed "English" for the "ca" locale and clicking on it switched to
English as well instead of Catalan.
2019-02-08 15:22:59 +01:00
luisramos0
3dc75c88d2
Delete empty controller class eval and spec. Useless left overs from 0ad2978926
2019-02-08 09:29:58 +00:00
Danni M
8ff5f9055b
Update issue templates
...
I've created 3 types of templates based on those in the wiki and the default (bug) issue template. These can be edited or additional ones added at your leisure.
I also added the OFN software instance and version to the bugs template
2019-02-08 16:58:32 +11:00
Matt-Yorkley
f9ea93933e
Use localizeCurrency filter in subscriptions
2019-02-07 22:58:49 +00:00
Matt-Yorkley
5582160e73
Add localizeCurrency filter to admin and inject currencyConfig data
2019-02-07 22:55:08 +00:00
luisramos0
1b4666fc6a
Add checkbox to cache settings to disable products cache
2019-02-07 20:06:27 +00:00
dependabot[bot]
72cd0537fb
Bump spinjs-rails from 1.3 to 1.4
...
Bumps [spinjs-rails](https://github.com/dnagir/spinjs-rails ) from 1.3 to 1.4.
- [Release notes](https://github.com/dnagir/spinjs-rails/releases )
- [Commits](https://github.com/dnagir/spinjs-rails/compare/v1.3...v1.4 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-07 19:39:54 +00:00
dependabot[bot]
492b1c905f
Bump rspec-rails from 3.8.1 to 3.8.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.8.1...v3.8.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-02-07 19:39:25 +00:00
luisramos0
93aabf6741
Update all locales with the latest Transifex translations
2019-02-07 19:26:00 +00:00
Pau Pérez Fabregat
676fa3d84d
Merge pull request #3433 from Matt-Yorkley/bi/user_permission
...
Update cancan permissions for second iteration of bulk invoices
2019-02-07 20:17:34 +01:00
Luis Ramos
8c0683938a
Merge pull request #3416 from kristinalim/fix/race_condition_in_bulk_order_management_feature_specs
...
3417,2962,3358 [Flaky Spec] Address some race conditions for bulk order management specs
2019-02-07 11:28:54 +00:00
Maikel Linke
5ee3dbf9f2
Re-use renderer object
2019-02-07 10:12:06 +11:00
Luis Ramos
2d0df7ffdf
Update app/controllers/spree/admin/orders_controller_decorator.rb
...
Co-Authored-By: mkllnk <maikel@email.org.au >
2019-02-07 09:19:19 +11:00
Kristina Lim
0030428647
Do not show table until first time dereferencing is done
2019-02-07 04:39:45 +08:00
Kristina Lim
428e58f8f7
Remove unused have_no_selector argument in feature test
2019-02-07 04:39:44 +08:00
Kristina Lim
35ecbe1584
Compile row ID with higher priority
2019-02-07 04:39:44 +08:00
Kristina Lim
ed5856afa4
Compile edit link with higher priority
2019-02-07 04:39:44 +08:00
Kristina Lim
fdede83086
Support selecting date in next months
...
This was causing failures when selecting tomorrow when running tests on
the last day of the month.
2019-02-07 04:39:43 +08:00
Kristina Lim
bb51f7e36b
Improve sync between keyword filter and selecting all
2019-02-07 04:36:28 +08:00
Kristina Lim
3eedee313e
Wait for datepicker to associate and open before selecting date
2019-02-07 04:36:24 +08:00
Pau Pérez Fabregat
8f63be9519
Merge pull request #2733 from kristinalim/fix-subscription_should_not_require_future_oc
...
Reduce restrictions for adding a variant to a subscription
2019-02-06 21:24:57 +01:00
Pau Pérez Fabregat
cd1f469588
Merge pull request #3389 from openfoodfoundation/dependabot/bundler/redcarpet-3.4.0
...
Bump redcarpet from 3.2.3 to 3.4.0
2019-02-06 21:23:21 +01:00
Pau Pérez Fabregat
433d10c42f
Merge pull request #3386 from leandroalemao/fix-moment-deprecation-warning
...
[ISSUE-3348] LC: Fix moment.js deprecation warning
2019-02-06 21:22:58 +01:00
Pau Pérez Fabregat
b4ba9e65e1
Merge pull request #3367 from openfoodfoundation/dependabot/bundler/jwt-2.1.0
...
Bump jwt from 1.5.6 to 2.1.0
2019-02-06 21:22:37 +01:00
Pau Pérez Fabregat
6239397589
Merge pull request #3357 from openfoodfoundation/dependabot/bundler/stripe-4.5.0
...
Bump stripe from 3.3.2 to 4.5.0
2019-02-06 21:22:19 +01:00
Matt-Yorkley
2c3eeec2b9
Update cancan permissions for second iteration of bulk invoices
2019-02-06 18:19:53 +00:00
Maikel Linke
4a3e5f1d0a
Print supplier name on invoice
2019-02-06 15:07:05 +11:00
Maikel Linke
3aea16e9ba
Cover alternative invoice template with specs
2019-02-06 15:06:44 +11:00
Maikel Linke
d97fa60c31
Remove code duplication and test PDF creation
2019-02-06 14:53:05 +11:00
Maikel Linke
7c5b430a37
Test execution of BulkInvoiceService#start_pdf_job
...
The spec just tested if a job was enqueued, but not if the job can
actually be executed. Unfortunately, this test is quite slow.
2019-02-06 11:26:22 +11:00
Maikel Linke
cc46bfd002
Rename namespace to ofn
2019-02-05 16:30:46 +11:00
Maikel Linke
659aa269de
Fix creation of sample payment methods on staging
...
Due to an unknown reason my chosen way of creating calculator and
assigning it to a payment method didn't work in staging environment even
though it was working in development.
Without diving deeper into the cause of this, I decided to change the
record assignments and fix the problem that way.
2019-02-05 16:24:30 +11:00
Maikel Linke
7a723d9061
Use new sample data during setup
2019-02-05 16:24:30 +11:00
Maikel Linke
c6393b6077
Warn about deprecation via ActiveSupport
2019-02-05 16:23:17 +11:00
Maikel Linke
c3029c612a
Fix sample product creation and use bang methods
...
Mistakes like the missing fee when creating product distributions were
hidden, because I didn't use the bang methods to create records.
2019-02-05 16:23:17 +11:00
Maikel Linke
1d07327325
Add descriptions to enterprises
2019-02-05 16:23:17 +11:00
Maikel Linke
4b389ba357
Move sample data factories into their own files
2019-02-05 16:23:17 +11:00
Maikel Linke
3ab02d90df
Move sample data address module to own file
2019-02-05 16:23:17 +11:00
Maikel Linke
bec9f5eb2e
Move sample data logger to own module
2019-02-05 16:23:17 +11:00
Maikel Linke
fae05ff713
Deprecate old sample data task
2019-02-05 16:23:17 +11:00
Maikel Linke
876e73a989
Rewrite task to generate sample data
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/2072
We need more and better structured sample data for dev testing and to
bootstrap staging data. This new task aims to replace
openfoodnetwork:dev:sample_data.
2019-02-05 16:23:17 +11:00
Maikel
a910468fc7
Merge pull request #3418 from Jefferson-Faseler/change-rake-tasks-namespace
...
Update Rake task namespace
2019-02-05 16:21:59 +11:00
Maikel Linke
dbfcbc6db9
Apply import defaults to variants of new products
...
Spree 2 doesn't have `Product#on_hand=` any more. We actually can't save
stock levels without saving the product first which creates a stock
item.
This hacky solution overwrites the attribute in the entry so that it
gets copied to the variant later on. I think a better solution needs
some refactoring as proposed in:
https://github.com/openfoodfoundation/openfoodnetwork/issues/2783#issuecomment-459601530
2019-02-05 15:41:19 +11:00
Luis Ramos
5a4205d151
Merge pull request #3432 from kristinalim/fix/3327-intermittent_spec_failures
...
3327 [Flaky Spec] Fix shop accidentally becoming order coordinator
2019-02-03 19:32:40 +00:00
Luis Ramos
4b133bbc31
Merge pull request #3412 from kristinalim/fix/3059-race_condition_in_enterprise_image_specs
...
3059 [Flaky Spec] Fix race condition in enterprise image feature specs
2019-02-03 19:32:11 +00:00
Luis Ramos
a0b5509850
Merge pull request #3430 from kristinalim/fix/3420-intermittent_spec_failures
...
3420 [Flaky Spec] Fix date format in spec when single-digit day of month
2019-02-03 19:30:22 +00:00
Kristina Lim
3104862739
Fix shop accidentally becoming order coordinator
...
The original setup of the order calls:
create(:simple_order_cycle)
Which picks an arbitrary distributor as coordinator:
coordinator { Enterprise.is_distributor.first || ... }
There is a chance that any of the existing distributor enterprises
becomes coordinator, causing a test to intermittently fail.
This commit makes the relationship between the reference enterprises and
the order consistent.
2019-02-01 20:28:36 +00:00
Kristina Lim
4bff256f6d
Match date format in spec with import date filter
...
This was failing if the current day of month only has one digit. The
test could not find the date in the import date filter.
Before this commit, the resulting string in the test replaced " " with
" ", so "February 2" was being changed to "February 2". The import date
filter however uses two spaces in this case, even if the browser shows
only one (HTML inline text renders two spaces as just one).
2019-02-02 01:43:52 +08:00
Pau Pérez Fabregat
e1fb005e70
Merge pull request #3387 from kristinalim/fix/3384-product_import_timeout
...
3384 [Product Import] Process only one batch of rows at a time
2019-02-01 17:29:04 +01:00
Isaac Haseley
09d3cea830
Lazy-load one more translation
2019-02-01 09:22:26 -06:00
Isaac Haseley
73a58435a8
Adopt one/other pluralization
2019-01-31 21:45:57 -06:00
Isaac Haseley
a18c98191a
Better accomodate different sentence structures
2019-01-31 21:45:57 -06:00
Isaac Haseley
8543bb7cfb
Add missing 'active products' translation on dashboard
2019-01-31 21:45:57 -06:00
Maikel
a9bac2c1af
Merge pull request #3411 from openfoodfoundation/transifex
...
Transifex
2019-01-31 13:42:50 +11:00
Transifex-Openfoodnetwork
32c5c48709
Updating translations for config/locales/en_US.yml
2019-01-31 12:38:44 +11:00
Jefferson Faseler
d4d0489328
Update name spaces for rake tasks to shorter 'ofn'.
2019-01-30 17:14:00 -05:00
Kristina Lim
65438e2619
Refactor checking no preview image in specs
2019-01-31 05:04:18 +08:00
Kristina Lim
a3c808a172
Refactor checking of preview image path in specs
2019-01-31 05:02:57 +08:00
Kristina Lim
777712a0e9
Fix race condition in enterprise image feature specs
2019-01-31 04:52:40 +08:00
Transifex-Openfoodnetwork
24c12897de
Updating translations for config/locales/fr_CA.yml
2019-01-31 07:42:29 +11:00
Transifex-Openfoodnetwork
bd43e06605
Updating translations for config/locales/fr_CA.yml
2019-01-31 07:41:40 +11:00
Luis Ramos
cf744bb663
Merge pull request #3407 from openfoodfoundation/transifex
...
Transifex
2019-01-30 13:58:26 +00:00
Transifex-Openfoodnetwork
2b13516d3d
Updating translations for config/locales/nb.yml
2019-01-30 19:20:56 +11:00
Transifex-Openfoodnetwork
1b50ba2729
Updating translations for config/locales/fr.yml
2019-01-30 19:16:54 +11:00
Maikel
e8ac0e4a9f
Merge pull request #3402 from openfoodfoundation/transifex
...
Transifex
2019-01-30 14:45:39 +11:00
Maikel
bef7684505
Merge pull request #3399 from kristinalim/fix/3381-address_failing_tests
...
3381 [Flaky Spec] Load enterprise users tab before inspecting table
2019-01-30 14:29:16 +11:00
dependabot[bot]
8750310648
Bump dalli from 2.7.2 to 2.7.9
...
Bumps [dalli](https://github.com/petergoldstein/dalli ) from 2.7.2 to 2.7.9.
- [Release notes](https://github.com/petergoldstein/dalli/releases )
- [Changelog](https://github.com/petergoldstein/dalli/blob/master/History.md )
- [Commits](https://github.com/petergoldstein/dalli/compare/v2.7.2...v2.7.9 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-29 19:14:15 +00:00
Transifex-Openfoodnetwork
f7b7e98fec
Updating translations for config/locales/en_GB.yml
2019-01-30 05:12:58 +11:00
luisramos0
c07b90ffb0
Update all locales with the latest Transifex translations
2019-01-29 12:45:28 +00:00
Pau Pérez Fabregat
2b3ffd8c82
Merge pull request #2833 from kristinalim/fix-variant_override_permissions
...
Add tests for permissions for variant overrides
2019-01-29 09:51:41 +01:00
Pau Pérez Fabregat
a5ed17f0f5
Merge pull request #3390 from openfoodfoundation/dependabot/bundler/oj-3.7.8
...
Bump oj from 3.7.4 to 3.7.8
2019-01-29 09:50:25 +01:00
Pau Pérez Fabregat
c9a8ec84c0
Merge pull request #3359 from kevinchristianson/ready
...
Convert sass files to scss
2019-01-28 20:02:37 +01:00
Kristina Lim
2129ab991b
Load enterprise users tab before inspecting table
2019-01-26 12:11:41 +08:00
Kristina Lim
5992bba97b
Import color variables in new page SCSS partials
...
"admin/all.css" which imports these SCSS partials already imports the
color variables in "admin/variables", so actually there should be no
need to import the variables again.
However, "application.css" calls "require_tree", which means asset
precompilation through Sprockets would attempt to compile each of the
SCSS partials individually. When compiled individually, the color
variables are not available to these partials.
This is a quick solution to allow precompilation of "application.css" to
complete.
2019-01-26 03:29:19 +08:00
Kristina Lim
4a58aedf09
Use clearer translation for "No Upcoming OC"
2019-01-26 02:03:57 +08:00
Kristina Lim
c33808e8f5
Extract some actions in tests into methods
2019-01-26 02:03:56 +08:00
Kristina Lim
da4d6a092a
Add spec helper for choosing today from datepicker
2019-01-26 02:03:56 +08:00
Kristina Lim
9965e95c65
Refactor methods in SubscriptionVariantsService
2019-01-26 02:03:55 +08:00
Kristina Lim
b691d727a7
Move OFN::SubscriptionService to SubscriptionVariantsService
2019-01-26 02:03:55 +08:00
Kristina Lim
c23002102c
Add warning for unavailable subscription items
2019-01-26 02:03:55 +08:00
Kristina Lim
929290fc77
Reduce restrictions for creating subscriptions
...
Allow the following variants:
* Variants of permitted producers
* Variants of hub
* Variants that are in outgoing exchanges where the hub is receiver
2019-01-26 02:03:54 +08:00
Kristina Lim
57f6a7a3b9
Support clicking different text for select2 helper
...
Interaction with the variant autocomplete is not precise. The specs only
search for the product name, then click the first result that matches
the product name which they see.
This could have been the case because searching using the full variant
name does not match the variant. For example, searching "Some Product -
1kg" would not have results, while searching only "Some Product" (the
product name) would list "Some Product - 1kg".
Clicking the first match does not work in all scenarios.
This allows using a separate text for searching and for clicking.
2019-01-26 02:03:54 +08:00
Kristina Lim
d3f20289f8
Move setup of feature specs for creating subscriptions
2019-01-26 02:03:53 +08:00
Kristina Lim
35c0bcb3df
Add tests for eligible variants for a subscription
2019-01-26 02:03:53 +08:00
Kristina Lim
28c70c7719
Fix nesting of specs for editing subscriptions
2019-01-26 02:03:53 +08:00
Kristina Lim
b9492d6483
Fix setup in tests for SubscriptionValidator
2019-01-26 02:03:49 +08:00
Kristina Lim
b6d8611359
Return early in JS if last batch
2019-01-25 09:06:25 +08:00
Kristina Lim
4425b0416d
Rename import_data feature test method
2019-01-25 04:42:11 +08:00
Kristina Lim
b0efc3a2fa
Add feature spec for large file import
2019-01-25 04:42:06 +08:00
dependabot[bot]
33ee46b224
Bump oj from 3.7.4 to 3.7.8
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.7.4 to 3.7.8.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.7.4...v3.7.8 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-24 19:16:56 +00:00
dependabot[bot]
5610f64c7a
Bump redcarpet from 3.2.3 to 3.4.0
...
Bumps [redcarpet](https://github.com/vmg/redcarpet ) from 3.2.3 to 3.4.0.
- [Release notes](https://github.com/vmg/redcarpet/releases )
- [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vmg/redcarpet/compare/v3.2.3...v3.4.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-24 19:14:52 +00:00
Kristina Lim
b67ba89aca
Process batches of the import CSV one after another
...
Start the HTTP request for processing next batches only after the
previous batch has completed.
A con of this approach is that the user needs to keep their browser open
for later parts of the large CSV to be processed, but this is better
than a higher chance of requests timing out.
2019-01-25 00:33:13 +08:00
Kristina Lim
bf084cd8df
Move import batch size outside method
2019-01-25 00:28:56 +08:00
leandroalemao
dfa11834e3
[ISSUE-3348] LC: Fix moment.js deprecation warning
2019-01-24 11:16:31 +00:00
Maikel
4cc6a8c966
Merge pull request #3350 from openfoodfoundation/dependabot/bundler/delayed_job_active_record-4.1.3
...
Bump delayed_job_active_record from 4.1.2 to 4.1.3
2019-01-24 11:58:32 +11:00
Maikel
66cb0e6a91
Merge pull request #3352 from openfoodfoundation/dependabot/bundler/foundation-rails-5.5.2.1
...
Bump foundation-rails from 5.5.0.0 to 5.5.2.1
2019-01-24 10:29:17 +11:00
Maikel
a3cd1dc945
Merge pull request #3344 from mkllnk/3279-moment-upgrade
...
Avoid deprecation warnings of momentjs
2019-01-24 10:28:41 +11:00
Kristina Lim
cf7f8b887f
Add tests for permissions for variant overrides
2019-01-24 07:08:54 +11:00
Pau Pérez Fabregat
7881f96cac
Merge pull request #3341 from openfoodfoundation/dependabot/bundler/daemons-1.3.1
...
Bump daemons from 1.2.2 to 1.3.1
2019-01-23 16:09:28 +01:00
Pau Pérez Fabregat
8320dc75e8
Merge pull request #3002 from kevinchristianson/margin-fix
...
Fix bad spacing on account settings error page
2019-01-23 16:09:14 +01:00
Pau Pérez Fabregat
77fd0b228e
Merge pull request #3360 from brases/wording_order_cofirmation
...
Fix wording in email template for orders confirmation
2019-01-23 13:35:00 +01:00
Maikel
2064ffe548
Merge pull request #3354 from luisramos0/knapsack
...
New Knapsack report
2019-01-22 10:58:13 +11:00
Maikel
06af79d1b0
Merge pull request #3339 from Matt-Yorkley/headless4
...
[Headless Chrome] Fix embedded_shopfront_spec unhandled alert
2019-01-22 10:46:42 +11:00
dependabot[bot]
ea7f62123b
Bump jwt from 1.5.6 to 2.1.0
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 1.5.6 to 2.1.0.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v1.5.6...v2.1.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-21 19:14:44 +00:00
Pau Pérez Fabregat
8b1c1881f7
Merge pull request #3351 from openfoodfoundation/dependabot/bundler/diffy-3.3.0
...
Bump diffy from 3.1.0 to 3.3.0
2019-01-21 15:08:24 +01:00
Kevin Christianson
6b7273f685
Convert sass files to scss
2019-01-19 22:40:41 -06:00
nozakis
972bfd5e62
Fixed bad margins on the account settings error page.
2019-01-19 16:23:13 -06:00
Brases
3437257515
Fix wording in order confirmation email template
...
Fixes issue #3063 "Repeated translation in Order Confirmation Screen and Email".
Now "Ready for" (collection time) is not repeated in place of "Collection
details" (collection instructions)
2019-01-19 20:37:21 +00:00
luisramos0
d155bb142c
Make proxy order spec a bit more resilient by allowing two secs diff in timestamps
2019-01-19 15:53:05 +00:00
luisramos0
6f7a351ffa
Update knapsack report to get build jobs more balanced
2019-01-18 23:46:09 +00:00
dependabot[bot]
990b90009e
Bump stripe from 3.3.2 to 4.5.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 3.3.2 to 4.5.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v3.3.2...v4.5.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-18 19:17:05 +00:00
Matt-Yorkley
3929689d48
Ensure login via modal is completed
2019-01-18 19:06:42 +00:00
dependabot[bot]
49e3aa5070
Bump daemons from 1.2.2 to 1.3.1
...
Bumps [daemons](https://github.com/thuehlinger/daemons ) from 1.2.2 to 1.3.1.
- [Release notes](https://github.com/thuehlinger/daemons/releases )
- [Changelog](https://github.com/thuehlinger/daemons/blob/master/Releases )
- [Commits](https://github.com/thuehlinger/daemons/compare/v1.2.2...v1.3.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-18 16:52:13 +00:00
dependabot[bot]
1e01cf81ec
Bump diffy from 3.1.0 to 3.3.0
...
Bumps [diffy](https://github.com/samg/diffy ) from 3.1.0 to 3.3.0.
- [Release notes](https://github.com/samg/diffy/releases )
- [Changelog](https://github.com/samg/diffy/blob/master/CHANGELOG )
- [Commits](https://github.com/samg/diffy/compare/3.1.0...3.3.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-18 16:51:42 +00:00
Pau Pérez Fabregat
a95dd98ed6
Merge pull request #2869 from Matt-Yorkley/bi/bulk_invoices
...
[Bulk Invoice Printing] Bulk invoices
2019-01-18 17:49:34 +01:00
Pau Pérez Fabregat
ee28cc5a29
Merge pull request #3323 from openfoodfoundation/dependabot/bundler/paper_trail-5.2.3
...
Bump paper_trail from 3.0.9 to 5.2.3
2019-01-18 17:48:56 +01:00
dependabot[bot]
2e993542a7
Bump foundation-rails from 5.5.0.0 to 5.5.2.1
...
Bumps [foundation-rails](http://foundation.zurb.com ) from 5.5.0.0 to 5.5.2.1.
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-17 19:20:09 +00:00
dependabot[bot]
560e52a0ce
Bump delayed_job_active_record from 4.1.2 to 4.1.3
...
Bumps [delayed_job_active_record](https://github.com/collectiveidea/delayed_job_active_record ) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/collectiveidea/delayed_job_active_record/releases )
- [Commits](https://github.com/collectiveidea/delayed_job_active_record/compare/v4.1.2...v4.1.3 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-17 19:17:20 +00:00
dependabot[bot]
adfa6b306c
Bump paper_trail from 3.0.9 to 5.2.3
...
Bumps [paper_trail](https://github.com/airblade/paper_trail ) from 3.0.9 to 5.2.3.
- [Release notes](https://github.com/airblade/paper_trail/releases )
- [Changelog](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md )
- [Commits](https://github.com/airblade/paper_trail/compare/v3.0.9...v5.2.3 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-17 19:08:33 +00:00
Pau Pérez Fabregat
c178478a4f
Merge pull request #3346 from luisramos0/headless-chrome
...
Merge Headless Chrome to master
2019-01-17 20:04:27 +01:00
Pau Pérez Fabregat
29990f25c1
Merge pull request #3325 from mkllnk/2469-fix-async-js-requests
...
2469 Fix async js requests
2019-01-17 20:03:54 +01:00
Pau Pérez Fabregat
e8dd6e9ce7
Merge pull request #3322 from luisramos0/delete_archive_spec
...
Delete dead code and unused folders
2019-01-17 20:01:49 +01:00
Luis Ramos
a8998fad79
Merge branch 'master' into headless-chrome
2019-01-17 18:22:25 +00:00
Pau Pérez Fabregat
fd00ad4e94
Merge pull request #3342 from openfoodfoundation/dependabot/bundler/letter_opener-1.7.0
...
Bump letter_opener from 1.6.0 to 1.7.0
2019-01-17 16:55:46 +01:00
Pau Pérez Fabregat
c51aa0f3b8
Merge pull request #3340 from openfoodfoundation/dependabot/bundler/whenever-0.10.0
...
Bump whenever from 0.9.2 to 0.10.0
2019-01-17 16:52:21 +01:00
Matt-Yorkley
e7e208061f
Assign polling numbers to variables and add comments
2019-01-17 09:37:32 +00:00
Matt-Yorkley
a3b9936f37
Improve matching inventory using 'items' unit type
2019-01-17 09:33:39 +00:00
Maikel Linke
4d3aed8467
Avoid deprecation warnings of momentjs
2019-01-17 14:49:43 +11:00
Maikel
9322c3f0c8
Merge pull request #3343 from Matt-Yorkley/headless5
...
[Headless Chrome] Fix datepicker interactions in bulk_order_management_spec
2019-01-17 14:19:00 +11:00
Maikel Linke
520ec5d047
Fix whenever upgrade by declaring dependency
...
Whenever doesn't depend on ActiveSupport any more. So we can't rely on
YAML being automatically loaded for us. We have to require it.
2019-01-17 10:41:11 +11:00
Maikel
7272ec8738
Merge pull request #3333 from Matt-Yorkley/headless3
...
[Headless Chrome] Fix shipping method tests
2019-01-17 09:18:12 +11:00
Matt-Yorkley
b3849778fa
Fix datepicker interactions in bulk_order_management_spec
2019-01-16 21:51:15 +00:00
dependabot[bot]
d884be54f9
Bump letter_opener from 1.6.0 to 1.7.0
...
Bumps [letter_opener](https://github.com/ryanb/letter_opener ) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/ryanb/letter_opener/releases )
- [Changelog](https://github.com/ryanb/letter_opener/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ryanb/letter_opener/compare/v1.6.0...v1.7.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-16 19:22:19 +00:00
dependabot[bot]
483d8893f2
Bump whenever from 0.9.2 to 0.10.0
...
Bumps [whenever](https://github.com/javan/whenever ) from 0.9.2 to 0.10.0.
- [Release notes](https://github.com/javan/whenever/releases )
- [Changelog](https://github.com/javan/whenever/blob/master/CHANGELOG.md )
- [Commits](https://github.com/javan/whenever/compare/v0.9.2...v0.10.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-16 19:18:32 +00:00
Matt-Yorkley
07dff0af7f
Check tag js has finished executing before submitting form
2019-01-16 17:46:56 +00:00
Matt-Yorkley
7487a6da3c
Fix shipping method tests
2019-01-16 17:17:10 +00:00
Matt-Yorkley
5caa958db0
Merge pull request #3336 from luisramos0/chrome-helper-fix
...
Fix Gemfile.lock by running bundle install. Adds missing chromedriver-helper.
2019-01-16 17:16:22 +00:00
Pau Pérez Fabregat
e557e06a7b
Merge pull request #3324 from openfoodfoundation/dependabot/bundler/spring-1.7.2
...
Bump spring from 1.1.3 to 1.7.2
2019-01-16 17:50:08 +01:00
luisramos0
41cd8c7ed3
Fix Gemfile.lock by running bundle install. Adds missing chromedriver-helper.
2019-01-16 16:29:55 +00:00
Matt-Yorkley
21bdaf9960
Fix enterprise images spec
2019-01-16 16:24:01 +00:00
Matt-Yorkley
0589516368
Add chromedriver-helper to Gemfile for test and development
2019-01-16 16:24:01 +00:00
Matt-Yorkley
40ccabc2b4
Fix broken product import spec
2019-01-16 16:24:01 +00:00
Maikel Linke
f391eab5b0
Revert "Temporarily move 2 broken specs to pending (shops and producers search by url) due to google maps api changes"
...
This reverts commit 7dc208fb8c .
2019-01-16 16:24:01 +00:00
Maikel Linke
6a53e5fd3d
Avoid alert by waiting until shop loaded
2019-01-16 16:24:01 +00:00
Maikel Linke
dd5bd5b616
Remove js_errors = false from specs because it is not available in Selenium ChromeDriver
...
If the js errors this line was hidding become a problem we will need to address them
2019-01-16 16:24:01 +00:00
luisramos0
fce56776f6
Make embedded_shopfronts_spec work with selenium
2019-01-16 16:24:01 +00:00
luisramos0
5fb4faac91
Make features/admin/subscriptions_spec and shopworkflow work with selenium
...
Also, remove a test support method, dead code
2019-01-16 16:24:01 +00:00
Maikel Linke
e49eb42af6
Make Chrome accepting alerts
2019-01-16 16:21:30 +00:00
Maikel Linke
843ec2c08f
Wait for table rows before testing them
...
Unfortunately, the exact table row matcher doesn't wait correctly for
changes on the page. Waiting correctly would mean to assemble a very
complicated xpath similar to this gem:
https://github.com/jnicklas/capybara_table
2019-01-16 16:21:30 +00:00
Maikel Linke
1407ae7778
Make TableMatcher match exactly, not part of row
...
Reverts dbf3a7aaaf9d458f99e14983ca9db2d4cbe4b564.
The reverted commit tried to avoid a 30 second delay by using
have_selector. While that was successful in reducing test time, it made
the matcher find rows that where not exactly the wanted row, but contained
text of the wanted row. This wasn't a problem until we experimented with
Chrome as test browser returns text on select boxes.
This commit makes the matcher precise again. We still have to deal with
the 30 second delay.
2019-01-16 16:21:30 +00:00
Rob Harrington
ef68bd1b43
Replace unnecessary perform_and_ensure* type helpers with standard actions and expectations
2019-01-16 16:21:30 +00:00
Rob Harrington
98f4ae9b60
Change screen size back to large after authentication_spec
2019-01-16 16:21:30 +00:00
Rob Harrington
a988fad2db
Update orders_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
98a5b40aec
Ensure multiligual switcher specs run in large screen
2019-01-16 16:21:30 +00:00
Rob Harrington
3a781049ed
Update orders_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
3b40ede0b8
Fix table row matchers
...
The matcher was silently failing on the check step (adding ~30 seconds to out specs each time it was used!), so I changed it to fail if the basic step does not succeed
2019-01-16 16:21:30 +00:00
Rob Harrington
56c07aac5c
Don't run ticket printing spec
2019-01-16 16:21:30 +00:00
Rob Harrington
4951863e9b
Update enterprises_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
eccf874f03
Update shopping_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
2b48b4ee18
Update cart_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
bba8b2020c
Replace use of 'trigger' in ui_component helper
2019-01-16 16:21:30 +00:00
Rob Harrington
23fa57ff6d
Update multilingual_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
bbaf6359f3
Update shopping_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
1923c0dbc6
Update enterprise_fees_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
c2432fab0b
Use all_options_absent method instead of poorly written no_options_present
...
SAVES 30 SECONDS FOR EVERY SPEC THAT IS IT USED IN!
2019-01-16 16:21:30 +00:00
Rob Harrington
3e90f9aa1d
Update customers_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
189856a92a
Reimplement resize helper methods to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
1bad08c1c0
Update checkout_workflow and spec_helper to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
3ab7a3d62b
Update order_cycles_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
50a8554b55
Update enterprises_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
69e44bdeb3
Update enterprise_roles_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
5ae33747ea
Update enterprise_relationships_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
7dc792b6fe
Update enterprise_groups_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
e97f5e36a6
Update bulk_order_management_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
2ece6bfb49
Update subscriptions_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
8416af4995
Update variants_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
8413c5f60a
Update variant_overrides_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
5c268e9359
Update schedules_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
708e308b7c
Update products_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
c6a383aafd
Update bulk_product_update_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
cc55f59b00
Update tag_rules_spec to work with Selenium
2019-01-16 16:21:30 +00:00
Rob Harrington
118d26b2ff
Add aynchronous select2 search helper
...
select2_search from spree times out after 1 second, so this new method just waits for a result to be returned before attempting to select it
2019-01-16 16:21:30 +00:00
Rob Harrington
70502a7a32
Switch to using selenium as js driver for capybara specs
...
PhantomJS is no longer being maintained
2019-01-16 16:21:30 +00:00
Rob Harrington
6608655e9a
Use headless chrome for karma specs instead of PhantomJS
...
PhantomJS is no longer being maintained
2019-01-16 16:21:30 +00:00
Pau Pérez Fabregat
d2325fc7dd
Merge pull request #3230 from luisramos0/stock_levels
...
3222 Improve stock levels calculation code on cart populate and add specs to test handling of variant overrides
2019-01-16 12:54:25 +01:00
Pau Pérez Fabregat
5bb327efbd
Merge pull request #3234 from openfoodfoundation/dependabot/bundler/oauth2-1.4.1
...
Bump oauth2 from 1.2.0 to 1.4.1
2019-01-16 12:33:39 +01:00
Matt-Yorkley
79dce01aef
Add spec for new on_demand logic
2019-01-16 01:19:01 +00:00
Matt-Yorkley
7dc7ffe1b7
Update inventory template
2019-01-16 01:18:46 +00:00
Maikel
54311c2d1b
Merge pull request #3304 from HugsDaniel/3288-3291-translation-issues
...
Add I18n keys for order state and order firstname and lastname filters
2019-01-16 09:43:28 +11:00
Maikel
2c197d40bb
Merge pull request #3326 from mkllnk/cleanup-specs
...
Cleanup specs
2019-01-16 09:23:06 +11:00
luisramos0
ea61e415e1
Add bugsnag notifications to detect potential dead code scenarios in variants_stock_levels and cart_service
2019-01-15 13:42:51 +00:00
luisramos0
d926f7c776
Reorganize and improve cart controller spec
2019-01-15 13:42:51 +00:00
luisramos0
aa603c9a84
Make rubocop happy on cart controller, cart service and stock levels service
2019-01-15 13:42:51 +00:00
luisramos0
b0449be302
Add spec to test cart controller handling of variant overrides on cart populate
2019-01-15 13:38:58 +00:00
luisramos0
c0473a4505
Extract variants_stock_levels from cart_controller and refactor some names
2019-01-15 13:38:58 +00:00
Maikel
e56915e65a
Merge pull request #3303 from openfoodfoundation/transifex
...
Transifex
2019-01-15 17:19:21 +11:00
Maikel Linke
5a5db3c458
Fix state of RequestMonitor
...
`@loading` was set to false when the request with the last id finished.
But another request started earlier (having a lower id) could take
longer. `@loading` was set to false even though these long requests were
still active.
2019-01-15 15:45:49 +11:00
Maikel Linke
ca9673f562
Fix Dereferencer service
...
It failed when `object[attr]` was `undefined` instead of `null`.
2019-01-15 15:43:00 +11:00
Maikel
8ba0e3b474
Merge pull request #3302 from mkllnk/74-bundler-version
...
Add script to install required bundler version
2019-01-15 09:36:18 +11:00
dependabot[bot]
22c225968a
Bump spring from 1.1.3 to 1.7.2
...
Bumps [spring](https://github.com/rails/spring ) from 1.1.3 to 1.7.2.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v1.1.3...v1.7.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-14 19:18:25 +00:00
luisramos0
90240f1802
Delete unused folders under /vendor
2019-01-14 14:38:51 +00:00
luisramos0
497974db74
Delete outdated archived version of checkout spec
2019-01-14 14:32:51 +00:00
luisramos0
e2c966244a
Delete /doc.
...
The list of specs is outdated and the images were transfered to the wiki itself
The project docs should be in the wiki
2019-01-14 14:31:31 +00:00
Pau Pérez Fabregat
ccc0a2cf96
Merge pull request #3280 from openfoodfoundation/dependabot/bundler/uglifier-4.1.20
...
Bump uglifier from 4.1.19 to 4.1.20
2019-01-11 19:46:04 +01:00
Matt-Yorkley
3f62d82afc
Add more inventory testing for visibility in the inventory UI
2019-01-11 11:26:38 +00:00
Maikel Linke
4abacb3691
Remove unused spec helpers
...
They all seem to have been used in the past. People forgot to remove
them after removing the using spec code.
2019-01-11 18:04:24 +11:00
Maikel Linke
e89a836e72
Remove forgotten code from spec
...
Commit e4ebeb8a29 forgot to remove this
code.
2019-01-11 18:04:24 +11:00
Maikel Linke
223982f571
Prepare spec for Chrome testing
2019-01-11 18:04:24 +11:00
Maikel Linke
cbdda54989
DRY specs with new helper
2019-01-11 18:04:24 +11:00
Maikel
4920782742
Merge pull request #3072 from luisramos0/2-0-calc-line-items-for-take-2
...
Fix bug on calculator_decorator line_items_for where input is line_item with a nil order
2019-01-11 14:49:25 +11:00
dependabot[bot]
1548c7c25a
Bump oauth2 from 1.2.0 to 1.4.1
...
Bumps [oauth2](https://github.com/oauth-xx/oauth2 ) from 1.2.0 to 1.4.1.
- [Release notes](https://github.com/oauth-xx/oauth2/releases )
- [Changelog](https://github.com/oauth-xx/oauth2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/oauth-xx/oauth2/compare/v1.2.0...v1.4.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-10 23:46:45 +00:00
dependabot[bot]
7f09112d7b
Bump uglifier from 4.1.19 to 4.1.20
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 4.1.19 to 4.1.20.
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v4.1.19...v4.1.20 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2019-01-10 23:45:22 +00:00
Maikel
ab14b73e17
Merge pull request #3211 from openfoodfoundation/dependabot/bundler/blockenspiel-0.5.0
...
Bump blockenspiel from 0.4.5 to 0.5.0
2019-01-11 10:42:40 +11:00
Maikel
fff054efc1
Merge pull request #3169 from luisramos0/hubPermissions
...
Add guard clause on variant overrides filter in case hub id is not present in the hubPermissions
2019-01-11 10:41:57 +11:00
Maikel
6c3d769121
Merge pull request #3229 from mkllnk/3127-tax-rates-report
...
3127 More robust tax rates report
2019-01-11 10:41:12 +11:00
Maikel
935e233605
Merge pull request #3244 from luisramos0/ruby-racer
...
Revert to the ruby racer
2019-01-11 10:40:02 +11:00
Hugo Daniel
026fe55f1d
Add I18n keys for order state and order firstname and lastname filters
2019-01-10 15:32:23 +01:00
Transifex-Openfoodnetwork
e70b8c03ce
Updating translations for config/locales/nb.yml
2019-01-10 22:18:58 +11:00
Matt-Yorkley
e624faaacb
Add 'please wait' message to bulk invoice modal
2019-01-10 09:57:06 +00:00
Matt-Yorkley
0e478ff501
Increase polling to 150 seconds maximum before showing error message.
2019-01-10 09:57:06 +00:00
Matt-Yorkley
66ac61f591
Rename background processing method
2019-01-10 09:57:06 +00:00
Matt-Yorkley
4f9f8adcd6
Add Service and remove Job
2019-01-10 09:57:06 +00:00
Matt-Yorkley
003014daf8
Extract invoice methods from ordersCtrl
2019-01-10 09:57:06 +00:00
Matt-Yorkley
bb814f91ef
Extract timeout to named function
2019-01-10 09:57:06 +00:00
Matt-Yorkley
6b6a41cfbc
Update CSS
2019-01-10 09:57:06 +00:00
Matt-Yorkley
638dc6eada
Add polling and show action
2019-01-10 09:57:06 +00:00
Matt-Yorkley
b0f75162ac
Add delayed job for create bulk invoice
2019-01-10 09:57:06 +00:00
Matt-Yorkley
7d82020657
Move bulk invoice to new RESTful route
2019-01-10 09:57:06 +00:00
Matt-Yorkley
4a88fb0626
Use simpler array for selected ids
2019-01-10 09:57:06 +00:00
Matt-Yorkley
5279210254
Improve invoice order querying
2019-01-10 09:57:06 +00:00
Matt-Yorkley
f3585befff
Fix customer missing from some order records - guest checkout?
2019-01-10 09:57:06 +00:00
Matt-Yorkley
24207053e4
Reset selected orders on filter change
2019-01-10 09:57:06 +00:00
Matt-Yorkley
5cc8bad42b
Improve UI layout for select all option
2019-01-10 09:57:06 +00:00
Matt-Yorkley
42cf96e635
Disable button unless orders selected
2019-01-10 09:57:06 +00:00
Matt-Yorkley
4ec0f0ff73
Add bulk invoices printing
2019-01-10 09:57:06 +00:00
Matt-Yorkley
96d530b473
Tidy up invoice template selection
2019-01-10 09:57:06 +00:00
Matt-Yorkley
9a71236abd
Add combine_pdf gem
2019-01-10 09:57:06 +00:00
Matt-Yorkley
f263ef7dc0
Add selectable checkboxes
2019-01-10 09:57:06 +00:00
Maikel
4f5bb96484
Merge pull request #3300 from openfoodfoundation/transifex
...
Transifex
2019-01-10 17:52:28 +11:00
Maikel Linke
199dee3f64
Use install-bundler in setup script
2019-01-10 17:44:13 +11:00
Maikel Linke
dafa433788
Add script to install required bundler version
...
The newest version of bundler is not compatible with our current version
of Ruby. This script helps to install the bundler version defined in
Gemfile.lock.
2019-01-10 17:44:09 +11:00
Transifex-Openfoodnetwork
15e197b3b0
Updating translations for config/locales/en_GB.yml
2019-01-10 07:31:46 +11:00
Pau Pérez Fabregat
399cc5f796
Merge pull request #3224 from alvaro-chalar/footer-message
...
Add custom footer message in reports section
2019-01-09 16:01:02 +01:00
Pau Pérez Fabregat
1815a2116d
Merge pull request #3257 from coopdevs/refactor-enterprise-controller-shop-injection
...
Refactor to reveal how we load enterprises in shop
2019-01-09 13:21:56 +01:00
Maikel
abe4f78e5c
Merge pull request #2988 from Matt-Yorkley/pi/utf8
...
Pi/utf8
2019-01-09 15:39:05 +11:00
Pau Pérez Fabregat
57267ab4a4
Merge pull request #3297 from openfoodfoundation/transifex
...
Transifex
2019-01-08 22:45:55 +01:00
Transifex-Openfoodnetwork
f05f4ce0b1
Updating translations for config/locales/en_GB.yml
2019-01-09 07:06:27 +11:00
Pau Pérez Fabregat
bd10400457
Merge pull request #3295 from coopdevs/pull-translations
...
Update all locales with the latest Transifex translations
2019-01-08 17:58:51 +01:00
Pau Perez
f1f1ab9daf
Update all locales with the latest Transifex translations
2019-01-08 17:17:35 +01:00
luisramos0
364f9f9abd
Improve variable names in cart spec
2019-01-07 11:40:42 +00:00
Pau Pérez Fabregat
34876cc255
Merge pull request #3275 from openfoodfoundation/transifex
...
Transifex
2019-01-07 11:43:06 +01:00
Pau Pérez Fabregat
ed8f719769
Merge pull request #3245 from luisramos0/spring
...
Add spring, a rails preloader alternative to zeus, to our gemfile
2019-01-07 11:07:34 +01:00
luisramos0
2893f1c141
Add test to cover weight calculation bug #3072
2019-01-07 01:18:40 +00:00
Maikel Linke
d2ba305ce6
Fix context data for tax rate finder spec
...
The spec was accidentally finding an exact tax rate match. The new test
data provides only close matches to choose from.
The naming of variables has been simplified as well.
2019-01-04 18:31:46 +11:00
Maikel Linke
a8ccb9b818
Explain why we look for the closest tax rate of a fee
2019-01-04 17:24:45 +11:00
Maikel
1024fc1f34
Merge pull request #3273 from coopdevs/fix-fr-BE-link
...
Fix menu_1_url translation for fr_BE
2019-01-04 09:52:44 +11:00
Transifex-Openfoodnetwork
9da7ff5698
Updating translations for config/locales/fr.yml
2019-01-04 02:15:57 +11:00
Pau Pérez Fabregat
9f0c6a6bac
Merge pull request #3251 from openfoodfoundation/dependabot/bundler/webmock-3.5.1
...
Bump webmock from 3.4.2 to 3.5.1
2019-01-03 11:18:59 +01:00
Pau Perez
edffbd72fe
Update rubocop_manual_todo
2019-01-03 11:17:10 +01:00
Pau Perez
ddf916814f
Reduce complexity of EnterprisesController#shop
...
As asked by Rubocop.
2019-01-03 11:17:10 +01:00
Pau Perez
e3edb51d3e
Update rubocop_todo
2019-01-03 11:17:10 +01:00
Pau Perez
51da607ab1
Fix too long line
2019-01-03 11:17:10 +01:00
Pau Perez
46760ce28c
Do not double-render when there is no stock
2019-01-03 11:17:10 +01:00
Pau Perez
cca15e75a6
Refactor to reveal how we load enterprises in shop
...
By sticking to Rails conventions we make it more obvious how (badly) we
are loading enterprises in EnterprisesController#shop and shed some
light on the obscure InjectionHelper.
This will also make it easier to improve its performance in the future as
it's among the top offenders. See https://www.skylight.io/app/applications/ibo3NOqCYMnq/1545851520/1d/endpoints/EnterprisesController%23shop?responseType=html
2019-01-03 11:17:10 +01:00
Maikel
ac76580932
Merge pull request #3274 from openfoodfoundation/transifex
...
Transifex
2019-01-03 11:35:47 +11:00
Transifex-Openfoodnetwork
89bf819b37
Updating translations for config/locales/en_US.yml
2019-01-03 00:33:56 +11:00
Pau Perez
112080d8c6
Fix menu_1_url translation for fr_BE
...
The first menu item in OFN BE is currently broken.
2019-01-02 13:10:33 +01:00
dependabot[bot]
8170937708
Bump webmock from 3.4.2 to 3.5.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.4.2 to 3.5.1.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.4.2...v3.5.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-27 19:16:35 +00:00
Pau Pérez Fabregat
d88be202a6
Merge pull request #3223 from kristinalim/fix-rubocop_block_length_ignore_rake_routes_dsl
...
Ignore Rake and routes DSL methods in Rubocop BlockLength
2018-12-27 17:14:57 +01:00
Pau Pérez Fabregat
755eca5abe
Merge pull request #3236 from openfoodfoundation/dependabot/bundler/guard-2.15.0
...
Bump guard from 2.14.1 to 2.15.0
2018-12-27 17:14:32 +01:00
Alvaro Chalar
6dccbeca70
Add custom footer message in reports section
2018-12-27 12:22:48 +01:00
luisramos0
fd21914a15
Add spring, a rails preloader alternative to zeus, to our gemfile
...
Add /bin to gitignore, bin is used by spring, rails preloader
2018-12-26 13:36:48 +00:00
luisramos0
4eaaeb37c9
Reverting to therubyracer because mini racer is causing trouble to some developers using osx.
...
We will probably be able to move back to the faster mini racer when we upgrade to newer rails versions
2018-12-26 13:07:52 +00:00
Pau Pérez Fabregat
1ab50798fe
Merge pull request #3189 from luisramos0/3043-i18n-emails
...
Make all mailers use appropriate locale when sending emails
2018-12-24 14:59:04 +01:00
albarnaz
5d515712ed
Fix for instagram links ( #2849 )
...
* Add new attribute instagram_placeholder to local yml
* Add placeholder to instagram link input
* Add migration to fix wrong instagram links
* Add new attribute facebook_placeholder to local yml
* Add placeholder to facebook link input
* Add new attribute linkedin_placeholder to local yml
* Add placeholder to linkedin link input
* Change each for find_each in migration
* Add new attribute instagram_placeholder to local yml
* Add migration to fix wrong instagram links
* Add new attribute linkedin_placeholder to local yml
* Add placeholder to linkedin link input
2018-12-21 14:42:28 +11:00
Maikel
9557457ec2
Merge pull request #3088 from kristinalim/cleanup-test_scripts
...
Run RSpec tests in custom engines (and some fixes, cleanup)
2018-12-21 14:32:56 +11:00
dependabot[bot]
e680559169
Bump guard from 2.14.1 to 2.15.0
...
Bumps [guard](https://github.com/guard/guard ) from 2.14.1 to 2.15.0.
- [Release notes](https://github.com/guard/guard/releases )
- [Changelog](https://github.com/guard/guard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/guard/guard/compare/v2.14.1...v2.15.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-20 19:18:59 +00:00
Pau Pérez Fabregat
e61b7139cc
Merge pull request #3212 from openfoodfoundation/dependabot/bundler/wkhtmltopdf-binary-0.12.4
...
Bump wkhtmltopdf-binary from 0.12.3.1 to 0.12.4
2018-12-20 16:43:24 +01:00
Pau Pérez Fabregat
0876986215
Merge pull request #3227 from openfoodfoundation/dependabot/bundler/momentjs-rails-2.20.1
...
Bump momentjs-rails from 2.5.1 to 2.20.1
2018-12-20 16:36:40 +01:00
dependabot[bot]
aac8706f9a
Bump blockenspiel from 0.4.5 to 0.5.0
...
Bumps [blockenspiel](https://github.com/dazuma/blockenspiel ) from 0.4.5 to 0.5.0.
- [Release notes](https://github.com/dazuma/blockenspiel/releases )
- [Changelog](https://github.com/dazuma/blockenspiel/blob/master/History.rdoc )
- [Commits](https://github.com/dazuma/blockenspiel/commits/v0.5.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-20 08:35:01 +00:00
Pau Pérez Fabregat
2a759a9c0d
Merge pull request #3196 from openfoodfoundation/dependabot/bundler/angularjs-file-upload-rails-2.4.1
...
Bump angularjs-file-upload-rails from 1.1.6 to 2.4.1
2018-12-20 09:31:49 +01:00
Maikel
073f88b1c2
Merge pull request #3198 from kristinalim/fix-variant_override_stock_settings_validation
...
Validation and others for keeping variant override "On Demand" and "Count on Hand" compatible
2018-12-20 14:05:20 +11:00
Kristina Lim
4adae0a1e8
Disable Knapsack when running engine RSpec tests
2018-12-19 17:50:52 +08:00
Kristina Lim
a460e9d35f
Allow disabling Knapsack when running RSpec tests
2018-12-19 17:50:29 +08:00
Kristina Lim
abcb71f8b3
Document running app engine RSpec tests
2018-12-19 17:11:03 +08:00
Kristina Lim
12780b722e
Make Travis CI run RSpec tests in app engines
2018-12-19 17:08:27 +08:00
Kristina Lim
74ea1eee6b
Add description for Rake tasks
2018-12-19 17:08:24 +08:00
Kristina Lim
571ad37c3e
Add Rake task openfoodnetwork:specs:engines:rspec
2018-12-19 17:06:33 +08:00
Kristina Lim
f7e03ca60e
Add Rake tasks openfoodnetwork:specs:engines:NAME:rspec
...
The task name follows the directory name under engines/. For example,
for the Web engine in engines/web, run:
bundle exec rake openfoodnetwork:specs:engines:web:rspec
2018-12-19 17:02:19 +08:00
Maikel Linke
a978e992bf
Remove tax_rates shortcut from adjustment
...
Becoming less dependent on Spree, using our own namespace, keeping
decorators small.
2018-12-19 14:42:38 +11:00
Maikel Linke
fc1b182275
Simplify method complexity and comply with rubocop
2018-12-19 14:31:29 +11:00
Maikel Linke
3169a384ba
Find approximate tax rate if no other is found
...
There are several cases in which a tax rate is not associated with an
adjustment. We find the closest one for reporting here. It is not a good
solution, but a workaround introduced for reporting:
https://github.com/openfoodfoundation/openfoodnetwork/pull/1496
2018-12-19 14:31:29 +11:00
Maikel Linke
a341561446
Move tax rate finding into service and spec it
...
The `#tax_rates` method is actually not present in Spree. We encapsulate
the logic in this commit and enable better unit testing. The new tests
cover a current bug: https://github.com/openfoodfoundation/openfoodnetwork/issues/3127
2018-12-19 14:31:29 +11:00
Maikel
84f2f9af3c
Merge pull request #3156 from HugsDaniel/3121-deface-payment-methods-new
...
[Defacepocalypse] De-deface payment methods new and form
2018-12-19 09:44:57 +11:00
dependabot[bot]
6de1844b7c
Bump momentjs-rails from 2.5.1 to 2.20.1
...
Bumps [momentjs-rails](https://github.com/derekprior/momentjs-rails ) from 2.5.1 to 2.20.1.
- [Release notes](https://github.com/derekprior/momentjs-rails/releases )
- [Changelog](https://github.com/derekprior/momentjs-rails/blob/master/news.md )
- [Commits](https://github.com/derekprior/momentjs-rails/compare/v2.5.1...v2.20.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-18 19:14:54 +00:00
luisramos0
5e960512ac
Set user locale on user registrations #create
...
This is done so that user.locale is used in the first confirmation email. This also stores user.locale in the DB from registration.
2018-12-18 15:30:01 +00:00
luisramos0
a9222665b8
Refactor user registrations controller, early return to reduce indentation
2018-12-18 15:26:49 +00:00
Maikel
f36c045425
Merge pull request #3213 from kristinalim/fix-rubocop_block_length_ignore_it
...
Ignore `it` in Rubocop BlockLength
2018-12-18 11:42:14 +11:00
Matt-Yorkley
d34b8c52b8
Update all locales with the latest Transifex translations
2018-12-17 11:17:54 +00:00
Pau Pérez Fabregat
54775f6b6a
Merge pull request #3221 from zvkemp/skylight-1.7.2
...
update Skylight to 1.7.2
2018-12-17 10:44:16 +01:00
Pau Pérez Fabregat
1876ec42dc
Merge pull request #3201 from kevinchristianson/add-missing-stars
...
Add missing 'required field' stars in new product form
2018-12-17 10:36:51 +01:00
Pau Pérez Fabregat
554d650b8c
Merge pull request #3176 from kevinchristianson/button-translation-fix
...
Fix untranslated buttons at image step of registration modal
2018-12-17 10:36:07 +01:00
Pau Pérez Fabregat
2deffb9c9f
Merge pull request #3076 from Matt-Yorkley/orders_checkboxes
...
Fix checkbox values on orders page
2018-12-17 10:35:46 +01:00
Kristina Lim
216c598e74
Ignore more methods in Metrics/BlockLength cop
...
Ignore these additional methods:
* collection
* member
* namespace
* resource
* resources
2018-12-17 05:21:20 +08:00
Kristina Lim
fb5a9356dc
Fix spec_helper.rb of web engine
...
This fixes the tests of the web engine when running the following from
its root: bundle exec rspec
An engine is meant to have some independence from the main application,
and its tests should be run independently.
This should be using the engine's own dummy application, actually, or
the dummy application of a dependency.
2018-12-15 16:11:15 +08:00
Kristina Lim
93940ced3a
Remove outdated comment recommending knapsack
...
We are already using this.
2018-12-15 16:11:12 +08:00
zvkemp
d3d43c8808
update Skylight to 1.7.2
2018-12-14 12:25:41 -08:00
Pau Pérez Fabregat
fe0c56c800
Merge pull request #3174 from kevinchristianson/footer-url-fix
...
Fix broken registration link in footer
2018-12-14 15:42:08 +01:00
dependabot[bot]
2f19b37b54
Bump angularjs-file-upload-rails from 1.1.6 to 2.4.1
...
Bumps [angularjs-file-upload-rails](https://github.com/marthyn/angularjs-file-upload-rails ) from 1.1.6 to 2.4.1.
- [Release notes](https://github.com/marthyn/angularjs-file-upload-rails/releases )
- [Commits](https://github.com/marthyn/angularjs-file-upload-rails/commits/v2.4.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-14 14:29:42 +00:00
Pau Pérez Fabregat
34a42cc592
Merge pull request #3181 from luisramos0/roadie-rails-upgrade
...
Bump roadie-rails from 1.0.3 to 1.1.1
2018-12-14 15:26:25 +01:00
Kristina Lim
d0d10eba4b
Ignore it method in Rubocop BlockLength
2018-12-14 17:44:19 +08:00
Kristina Lim
77a6562762
Make DB migration generate summary by distributor
2018-12-14 13:02:43 +08:00
Kristina Lim
a6664d0ac6
Move report generated by migration to subdirectory
...
This is in preparation of an upcoming change to split the main CSV file
by distributor.
2018-12-14 13:00:42 +08:00
Kristina Lim
91e5a523f0
Add /reports/ to .gitignore but ignore README
...
Using the first slash to make sure that other reports/ directories are
not ignored.
2018-12-14 10:25:23 +08:00
Kristina Lim
d859939c79
Add README.md to reports/ directory
2018-12-14 10:24:26 +08:00
Kristina Lim
6458127892
Add undo logic for DB migration script
2018-12-14 10:09:09 +08:00
Kristina Lim
5a98acd101
Log changes from DB migration to CSV file
2018-12-14 10:09:09 +08:00
Kristina Lim
842a11b564
Refactor DB migration script
2018-12-14 10:09:08 +08:00
dependabot[bot]
2ecec93514
Bump wkhtmltopdf-binary from 0.12.3.1 to 0.12.4
...
Bumps [wkhtmltopdf-binary](https://github.com/zakird/wkhtmltopdf_binary_gem ) from 0.12.3.1 to 0.12.4.
- [Release notes](https://github.com/zakird/wkhtmltopdf_binary_gem/releases )
- [Changelog](https://github.com/zakird/wkhtmltopdf_binary_gem/blob/master/CHANGELOG )
- [Commits](https://github.com/zakird/wkhtmltopdf_binary_gem/compare/0.12.3.1...0.12.4 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-13 19:19:36 +00:00
Pau Pérez Fabregat
2eb6d0a047
Merge pull request #3185 from openfoodfoundation/dependabot/bundler/oj-3.7.4
...
Bump oj from 3.6.10 to 3.7.4
2018-12-13 18:10:55 +01:00
Kristina Lim
aa92dd8771
Declare VariantOverride in migration for safe use
2018-12-13 23:29:05 +08:00
Kristina Lim
9e3332ba2a
Rename DB migration file
2018-12-13 23:25:48 +08:00
Maikel
eb016c0471
Merge pull request #3145 from openfoodfoundation/dependabot/bundler/i18n-js-3.1.0
...
Bump i18n-js from 3.0.11 to 3.1.0
2018-12-13 10:58:22 +11:00
Pau Pérez Fabregat
d317603872
Merge pull request #3187 from openfoodfoundation/dependabot/bundler/rspec-rails-3.8.1
...
Bump rspec-rails from 3.7.2 to 3.8.1
2018-12-12 17:14:05 +01:00
Pau Pérez Fabregat
64e41712c6
Merge pull request #3130 from coopdevs/extract-restart-checkout
...
Extract restart checkout
2018-12-12 17:12:53 +01:00
luisramos0
e274442d77
Cover i18nhelper.valid_locale and user mailer with tests related to localized emails
2018-12-11 11:16:50 +00:00
haseleyi
835617159e
Add missing 'required field' stars in new product form
2018-12-10 18:02:39 -08:00
Matt-Yorkley
0c5ac99e0f
Fix multiple results with 'inventory_items_shipment_id_null' ransack query
...
The q['inventory_items_shipment_id_null'] search element was generating duplicates where there were multiple line items on an order that were ready to be shipped, with id = null
2018-12-10 20:48:53 +00:00
Matt-Yorkley
e711c5ed03
Add spec for search filters
2018-12-10 20:48:53 +00:00
Matt-Yorkley
d48774e3a2
Add comment
2018-12-10 20:48:53 +00:00
Matt-Yorkley
997169b974
Fix checkbox values on orders page
2018-12-10 20:48:53 +00:00
luisramos0
38ff99717a
Fix bug on calculator_decorator line_items_for where input is line_item with an nil order. Adapted line_items_for so that weight_calculator.line_items_for could be removed.
2018-12-09 19:37:11 +00:00
Kristina Lim
df51d137dc
Update some code style for product import
2018-12-10 03:30:52 +08:00
Kristina Lim
cec50e81f5
Make product import set correct VO stock settings
2018-12-10 03:30:46 +08:00
Kristina Lim
0de829017a
Refactor finding or initializing VO for product import
2018-12-10 03:30:39 +08:00
Kristina Lim
c873a7b8e3
Move stock settings override validation to concern
2018-12-09 23:29:36 +08:00
Kristina Lim
1bfdb708c1
Add app/models/concerns to autoload path
2018-12-09 23:29:36 +08:00
Kristina Lim
d67b3faf01
Address affected specs from new VO validations
2018-12-09 21:48:08 +08:00
Kristina Lim
34313c94ca
Make reset stock settings for VO force limited stock
2018-12-09 21:47:05 +08:00
Kristina Lim
ad35ea1102
Add factory stock traits for variant overrides
2018-12-09 21:47:05 +08:00
Kristina Lim
210a11783c
Test that saving invalid variant override provides error
2018-12-09 21:43:57 +08:00
Kristina Lim
4c0c0bbfd0
Simplify stock configuration in existing variant overrides
2018-12-07 14:40:15 +08:00
Kristina Lim
83b6973bc2
Require compatible VO on_demand and count_on_hand
2018-12-07 14:39:36 +08:00
Maikel
046ba14da4
Merge pull request #3191 from openfoodfoundation/dependabot/bundler/knapsack-1.17.1
...
Bump knapsack from 1.16.0 to 1.17.1
2018-12-07 15:18:25 +11:00
haseleyi
3f6e96dd5d
Fix comment
2018-12-06 14:07:45 -08:00
haseleyi
4a0744dd94
Add comment to explain hard-coded link
2018-12-06 11:49:39 -08:00
dependabot[bot]
6ae2df7b92
Bump knapsack from 1.16.0 to 1.17.1
...
Bumps [knapsack](https://github.com/ArturT/knapsack ) from 1.16.0 to 1.17.1.
- [Release notes](https://github.com/ArturT/knapsack/releases )
- [Changelog](https://github.com/ArturT/knapsack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ArturT/knapsack/compare/v1.16.0...v1.17.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-06 19:16:09 +00:00
luisramos0
b9b91231ae
Fix rubocop issues in mailers
2018-12-06 14:18:24 +00:00
luisramos0
0f442a911e
Improve I18nHelper.valid_locale to handle empty objects
2018-12-06 12:48:48 +00:00
luisramos0
feea499298
Make all mailers use appropriate locale when sending emails
2018-12-06 11:45:44 +00:00
Kristina Lim
71db9f5289
Import CSS variables in admin/components/input
2018-12-06 14:08:06 +08:00
luisramos0
c33ca508f7
Add guard clause on variant overrides filter in case hub id is not present in the hubPermissions
2018-12-06 15:35:44 +11:00
Maikel
3a3c9f3847
Merge pull request #3177 from coopdevs/dont-clean-db-twice-in-feature-specs
...
Do not clean DB twice on feature specs
2018-12-06 12:36:34 +11:00
haseleyi
75277e92e4
Lazy-load the translations for images step of registration
2018-12-05 11:36:27 -08:00
dependabot[bot]
727cc9d578
Bump rspec-rails from 3.7.2 to 3.8.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 3.7.2 to 3.8.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.7.2...v3.8.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:19:50 +00:00
dependabot[bot]
ebff8be996
Bump oj from 3.6.10 to 3.7.4
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.6.10 to 3.7.4.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.6.10...v3.7.4 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:16:55 +00:00
luisramos0
bbc61b4eda
Bump roadie-rails to 1.1.1
2018-12-05 15:11:45 +00:00
Pau Pérez Fabregat
1052d98255
Merge pull request #3175 from haseleyi/patch-1
...
Fix link to Mac setup guide in Getting Started
2018-12-05 12:52:08 +01:00
Kristina Lim
842a8e3654
Move null option for VO use_producer_settings to JS
2018-12-05 17:40:32 +08:00
Kristina Lim
802e3bb447
Refactor choosing VO on_demand in feature specs
...
We are still using the Rails view I18n scope for :use_producer_settings.
Angular requires this replacement of the default blank option, which we
use for nil on_demand, to be in the template itself.
If we eventually move this template to a JS template, we can move it to
the same I18n scope as the :yes and :no options.
2018-12-05 17:40:31 +08:00
Kristina Lim
d8908bdf4b
Remove unused translation keys js.yes and js.no
2018-12-05 17:40:31 +08:00
Kristina Lim
47d51ca525
Prefer guard clause in updateCountOnHand for VOs
2018-12-05 17:40:31 +08:00
Kristina Lim
34c34b94d1
Describe method countOnHandPlaceholder for VOs
2018-12-05 17:40:30 +08:00
Kristina Lim
cff4eb0005
Improve and simplify VO count on hand suggestions
...
Set variant override count_on_hand in UI to variant count_on_hand value
if on_demand is changed and both specify limited stock.
2018-12-05 17:40:30 +08:00
Kristina Lim
4f2d96d763
Use correct placeholders for VO count_on_hand
2018-12-05 17:40:29 +08:00
Kristina Lim
f5dc03e118
Style disabled text fields in admin pages
2018-12-05 17:40:29 +08:00
Kristina Lim
09b9f968b7
Make VO count on hand readonly unless limited stock
2018-12-05 17:40:29 +08:00
Kristina Lim
cc003c99d5
Ensure in UI compatible VO count and on demand
2018-12-05 17:40:28 +08:00
Kristina Lim
a32bb0445f
Change translation for variant override use_producer_settings
2018-12-05 17:40:28 +08:00
Kristina Lim
7ae555cd9c
Translate variant override on_demand yes and no
2018-12-05 17:40:27 +08:00
Kristina Lim
4b3198a2b4
Allow reset of "on demand" for variant overrides
...
Change the UI control for "on demand" in the Inventory page from a
checkbox to a SELECT field with three options: nil, true, and false.
This resolves the following issues:
* There is no way to tell between nil and false - both are represented
by an unticked checkbox.
* There is no way to go back to nil.
2018-12-05 17:40:24 +08:00
Pau Perez
25567d6bd6
Do not clean DB twice on feature specs
...
It turns out that we were executing `DatabaseCleaner.clean` on two
`after(:each)` blocks. One for all specs and another one for `js: true`
specs. As a result feature specs were hitting both which slows them down
considerably.
On my machine this changes consistently saves 2sec on
`spec/features/consumer/shops_spec.rb` but chances are it has an
accumulative effect when run on the whole test suite.
2018-12-05 09:58:14 +01:00
Pau Pérez Fabregat
3b56212290
Merge pull request #3151 from coopdevs/remove-frontoffice-enterprises-n+1
...
Remove frontoffice enterprises n+1
2018-12-05 08:12:19 +01:00
Pau Pérez Fabregat
e5a267f4c2
Merge pull request #2735 from luisramos0/cookies_colors
...
Moved definition of colors in the cookies modal and banner colors to common darkswarm/base/colors
2018-12-05 08:06:58 +01:00
haseleyi
94d12217de
Fix untranslated buttons at image step of registration modal
2018-12-04 21:30:42 -08:00
Isaac Haseley
76e5d281bf
Fix link for Mac setup guide
2018-12-04 20:37:23 -08:00
Maikel
609a4fde4d
Merge pull request #3173 from openfoodfoundation/transifex
...
Transifex
2018-12-05 11:55:29 +11:00
Transifex-Openfoodnetwork
18a5f53330
Updating translations for config/locales/fr.yml
2018-12-05 09:17:00 +11:00
haseleyi
e863c3dec8
Fix broken link in register call partial
2018-12-04 10:23:46 -08:00
Pau Pérez Fabregat
24415226bf
Merge pull request #3168 from luisramos0/google-maps-comment-specs
...
Temporarily xit 2 broken specs (shops and producers search by url)
2018-12-04 19:13:40 +01:00
Transifex-Openfoodnetwork
9bedc69df8
Updating translations for config/locales/en_GB.yml
2018-12-05 04:52:44 +11:00
luisramos0
7dc208fb8c
Temporarily move 2 broken specs to pending (shops and producers search by url) due to google maps api changes
2018-12-04 13:20:20 +00:00
Maikel Linke
66585e93a8
Update all locales with the latest Transifex translations
2018-12-04 14:48:03 +11:00
Hugo Daniel
24dab58de7
Lazy load translations and add keys
2018-11-30 10:49:36 +01:00
luisramos0
1c5d94472f
Make colors.css relative reference to branding.css an absolute reference so that colors can be imported in engines
2018-11-29 18:39:58 +00:00
Pau Pérez Fabregat
08297863be
Merge pull request #3047 from mllocs/feature/expand-all-steps-in-checkout-page
...
Expand all steps in the checkout page by default
2018-11-29 16:28:42 +01:00
Pau Pérez Fabregat
9f17acd63c
Merge pull request #3136 from kevinchristianson/dashboard-translation
...
Add missing translation for 'Has Shopfront' in single-enterprise dashboard
2018-11-29 16:27:05 +01:00
Hugo Daniel
aa948552e1
Import payment_methods edit view and apply overrides
2018-11-29 14:58:14 +01:00
Hugo Daniel
34bc79c7f6
Import payment_methods form partial and apply overrides
2018-11-29 14:58:06 +01:00
Hugo Daniel
29bc4c52a5
Import payment_methods#new view and apply overrides
2018-11-29 14:56:28 +01:00
luisramos0
93e1310deb
Fixed bug in cookies css, import colors, not branding
2018-11-29 11:47:51 +00:00
luisramos0
cdc5899791
Moved cookies policy modal and cookies banner colors to darkswarm/base/colors.scss
2018-11-29 11:47:51 +00:00
Pau Pérez Fabregat
949efd88ce
Merge pull request #3154 from mkllnk/update-db-schema
...
Update schema for latest migration
2018-11-29 11:34:43 +01:00
Maikel Linke
285346fcda
Update schema for latest migration
...
I feel embarrased that this is the second follow up of my last
migration: https://github.com/openfoodfoundation/openfoodnetwork/pull/3126
The last migration didn't change any database structure, but the schema
still needs the latest migration version. Otherwise it will display
pending migrations when setting up the database.
This commit allows to run `bundle exec rake db:reset` in development
without the following message:
Run `rake db:migrate` to update your database then try again.
You have 1 pending migrations:
20181123012635 AssociateCustomersToUsers
The next pull request with a migration would have solved this problem as
well.
2018-11-29 10:29:56 +11:00
Pau Pérez Fabregat
3ea7fac25f
Merge pull request #3095 from luisramos0/admin-users-transl
...
In admin/users, convert Spree.t calls to t calls and use lazy lookup
2018-11-28 17:37:42 +01:00
Pau Pérez Fabregat
8df781887a
Merge pull request #3111 from kevinchristianson/pay-list-translation
...
Add translation for 'Back to Payments List' button in new payment form
2018-11-28 17:03:29 +01:00
Pau Pérez Fabregat
64c12c7a65
Merge pull request #2955 from HugsDaniel/import-spree-views-for-orders#edit
...
Import Spree views for orders#edit in our codebase
2018-11-28 17:02:40 +01:00
Pau Perez
96202ab00d
Fix Rubocop violations
2018-11-28 16:23:56 +01:00
Pau Perez
e0f43191e2
Make helper methods private
...
Otherwise next dev might think these are attributes of the resulting
JSON serialized object.
They just made the refactoring a bit easier.
2018-11-28 16:21:40 +01:00
Pau Perez
c330d931ce
Eager load product properties to avoid N+1
...
This totally removes the following N+1 query from the GET /shops request
```sql
SELECT "spree_properties".* FROM "spree_properties"
INNER JOIN "spree_product_properties"
ON "spree_product_properties"."property_id" = "spree_properties"."id"
INNER JOIN "spree_products"
ON "spree_products"."id" = "spree_product_properties"."product_id"
INNER JOIN "enterprises"
ON "enterprises"."id" = "spree_products"."supplier_id"
WHERE "spree_products"."supplier_id" = 24;
```
The product properties of the corresponding enterprises are now loaded
in a single query fired from the controller.
2018-11-28 16:21:40 +01:00
Pau Perez
4608c434b4
Eager load producer properties to avoid N+1
...
This totally removes the following N+1 query from the GET /shops request
```sql
SELECT "spree_properties".* FROM "spree_properties"
INNER JOIN "producer_properties"
ON "spree_properties"."id" = "producer_properties"."property_id"
WHERE "producer_properties"."producer_id" = 17
ORDER BY producer_properties.position;
```
The producer properties of the corresponding enterprises are now loaded
in a single query fired from the controller.
2018-11-28 16:21:40 +01:00
Pau Perez
e40c1c08ca
Refactor spec to not stub the class under test
...
This also relies on ActiveRecord which will come in handy as we move on
the refactor.
2018-11-28 16:21:40 +01:00
Pau Perez
149fc1ac6f
Inline PropertyMerge's #merge into serializer
...
Now that it has become a plain Ruby #uniq, there's no point on having
the abstraction and indirection.
2018-11-28 16:21:40 +01:00
Pau Perez
faac5f4b2d
Refactor PropertyMerge to use Ruby's #uniq instead
2018-11-28 16:21:40 +01:00
Pau Perez
1363a2a17d
Improve readability of spec
2018-11-28 16:21:40 +01:00
Pau Perez
8e1f9a1ba3
Refactor #product_properties not to fetch ids
2018-11-28 16:21:40 +01:00
Pau Perez
bc7258d43b
Test #supplied_properties helper methods
2018-11-28 16:21:40 +01:00
Pau Perez
23f629cfd6
Autofix all Rubocop violations in serializer
2018-11-28 13:54:42 +01:00
Pau Perez
c6ab5feb81
Move cached & uncached serializers to their files
2018-11-28 13:54:42 +01:00
Pau Perez
41d988176c
Pass enterprises to inject method from controller
2018-11-28 13:54:42 +01:00
Pau Perez
5a85d7a77b
RSpec3-ize controller spec
2018-11-28 13:54:42 +01:00
Pau Pérez Fabregat
b9dfaea274
Merge pull request #3143 from coopdevs/setup-rack-mini-profiler
...
Enable rack-mini-profiler in development
2018-11-28 13:54:27 +01:00
Pau Pérez Fabregat
438cff6e6d
Merge pull request #3080 from Matt-Yorkley/pi/french_issue
...
Pi/french issue
2018-11-28 13:39:04 +01:00
Hugo Daniel
69e186f482
Define dynamic classes in variables as a turnaround to HAML bug
2018-11-28 10:31:47 +01:00
Hugo Daniel
65dd3eb5b9
Change line items controller HTML response spec to look for form order_edit class
2018-11-28 10:31:47 +01:00
Hugo Daniel
60214b9a90
Fix failing specs
2018-11-28 10:31:47 +01:00
Hugo Daniel
422a68630f
Remove data-hook tags
2018-11-28 10:31:47 +01:00
Hugo Daniel
652191a4c5
Fixing missing variable none
2018-11-28 10:31:47 +01:00
Hugo Daniel
c233ea38cf
Import Spree views for orders#edit in our codebase and integrate deface modifications
2018-11-28 10:31:47 +01:00
dependabot[bot]
7b95e3a8d7
Bump i18n-js from 3.0.11 to 3.1.0
...
Bumps [i18n-js](https://github.com/fnando/i18n-js ) from 3.0.11 to 3.1.0.
- [Release notes](https://github.com/fnando/i18n-js/releases )
- [Changelog](https://github.com/fnando/i18n-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fnando/i18n-js/compare/v3.0.11...v3.1.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-27 19:17:57 +00:00
Pau Pérez Fabregat
5c8a638320
Merge pull request #3055 from HugsDaniel/3051-products-edit-views
...
[Defacepocalypse] Import products#edit and form partial in our codebase and apply overrides
2018-11-27 17:32:25 +01:00
Pau Pérez Fabregat
869f17256d
Merge pull request #3011 from HugsDaniel/3000-api-endpoint-enterprise-fee
...
Add an API endpoint for EnterpriseFeesController#destroy
2018-11-27 17:28:43 +01:00
Pau Pérez Fabregat
ea6f44e78d
Merge pull request #3144 from mkllnk/2841-fix-migration-encoding
...
Encode records with special chars as well
2018-11-27 17:28:13 +01:00
Pau Pérez Fabregat
04d57f8e6e
Merge pull request #3135 from openfoodfoundation/dependabot/bundler/unicorn-rails-2.2.1
...
Bump unicorn-rails from 1.1.0 to 2.2.1
2018-11-27 17:26:12 +01:00
Pau Pérez Fabregat
d073157424
Merge pull request #3134 from coopdevs/update-skylight
...
Update Skylight from 1.6.1 to 1.7.1
2018-11-27 08:54:39 +01:00
Maikel
2967fdccf7
Merge pull request #3142 from kristinalim/fix-rubocop_block_length_ignore_describe_context
...
Ignore `describe` and `context` in Rubocop BlockLength
2018-11-27 14:54:46 +11:00
Maikel Linke
9efa45663c
Encode records with special chars as well
...
Using Marshal.dump on the French production database raised an error:
Encoding::UndefinedConversionError: "\xC3" from ASCII-8BIT to UTF-8
Replacing Marshal with YAML solves the problem. It is also more reliable
and human readable.
This code was run against the French, Australian and UK production
data successfully.
2018-11-27 14:34:03 +11:00
Pau Perez
b365488653
Enable rack-mini-profiler in development
...
This will run it always in development mode.
2018-11-26 12:10:49 +01:00
Kristina Lim
5c6ec50dea
Ignore describe and context in Rubocop BlockLength
2018-11-26 13:55:55 +08:00
Maikel
c152da8122
Merge pull request #3126 from mkllnk/2841-convert-guest-customer
...
2841 Associate customers with their user records
2018-11-26 13:56:31 +11:00
haseleyi
691de9199f
Add missing translation for 'Has Shopfront' in single-enterprise dashboard
2018-11-23 11:23:28 -08:00
dependabot[bot]
4499c38cfe
Bump unicorn-rails from 1.1.0 to 2.2.1
...
Bumps [unicorn-rails](https://github.com/samuelkadolph/unicorn-rails ) from 1.1.0 to 2.2.1.
- [Release notes](https://github.com/samuelkadolph/unicorn-rails/releases )
- [Commits](https://github.com/samuelkadolph/unicorn-rails/compare/v1.1.0...v2.2.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-23 19:14:51 +00:00
Maxim Colls
4b588cbfb0
Removed unused toggle helpers in spec/support
2018-11-23 16:47:55 +00:00
Pau Perez
2abb316bcc
Update Skylight from 1.6.1 to 1.7.1
...
This doesn't bring too many improvements but it's the latest version can
work on our Rails 3.2 version.
You can read the changelog at
https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md#170-april-24-2018 .
2018-11-23 17:31:53 +01:00
Pau Perez
453b2a99de
Rename redundant #restart_checkout to #call
2018-11-23 12:05:39 +01:00
Pau Perez
88afa70f37
Simplify and speed up service tests
2018-11-23 12:04:42 +01:00
Pau Perez
2c8a1f5e78
Check for value and not object identity in spec
2018-11-23 12:04:42 +01:00
Pau Perez
99463427ce
Refactor RestartCheckout service just extracted
2018-11-23 12:04:42 +01:00
Pau Perez
3b681a59ba
Move controller tests to service class tests
2018-11-23 12:04:42 +01:00
Pau Perez
a62a2cb52f
Extract #restart_checkout to a service
2018-11-23 12:04:42 +01:00
Maikel Linke
f4d5727fb4
Associate customers with their user records
...
When we introduced the Customer model, we didn't associate any existing
customers with users that have the same email address.
Later we decided to create that association when users sign up. But we didn't
update all the existing customers. We do that now for data consistency and to
solve several bugs.
2018-11-23 15:38:35 +11:00
Maikel Linke
95dbfae757
Use expect syntax
2018-11-22 15:42:56 +11:00
Maikel
be7fea9d14
Merge pull request #3003 from kevinchristianson/getting-started-edits
...
Getting Started edits
2018-11-22 12:51:16 +11:00
haseleyi
07e246db39
Remove outdated time zone precaution from Getting Started wiki
2018-11-21 15:56:14 -08:00
haseleyi
364a00074b
Remove Resources header
2018-11-21 15:56:14 -08:00
Kevin Christianson
7dce6e1180
Remove weird red "for" text in Troubleshooting
2018-11-21 15:56:14 -08:00
Kevin Christianson
1216567be9
Add Troubleshooting section with an alternative database setup
2018-11-21 15:56:13 -08:00
Samuel Nozaki
a7032a8822
Clarify that the time zone should be Melbourne
2018-11-21 15:56:13 -08:00
nozakis
6a73ee86f8
Clarify GETTING_STARTED.md in regards to rspec test failures and time zones
2018-11-21 15:56:13 -08:00
haseleyi
d4b49a662f
Add translation for 'Back to Payments List' button in new payment form
2018-11-21 15:33:45 -08:00
Matt-Yorkley
b3a9b502fa
Add missing translation key
2018-11-21 19:16:08 +00:00
Matt-Yorkley
a5407d780c
Include unexpected validation errors
2018-11-21 19:16:07 +00:00
Pau Pérez Fabregat
ac9cfaa8c3
Merge pull request #3093 from mllocs/fix/factories-ignore-warning
...
Fixed Factory warning while running tests
2018-11-21 14:44:03 +01:00
Pau Pérez Fabregat
6a1776b84a
Merge pull request #3053 from HugsDaniel/3050-products-new-views
...
[Defacepocalypse] Import products#new view into our codebase and apply overrides
2018-11-21 14:43:22 +01:00
luisramos0
783e0eed3c
In admin/users, convert Spree.t calls to t calls using lazy lookup and move translations to ofn's en.yml
2018-11-21 11:46:14 +00:00
luisramos0
0189cefd1c
Update all locales with the latest Transifex translations
2018-11-20 22:40:11 +00:00
Maxim Colls
f179bf8c49
Fixed Factory warning while running tests
2018-11-20 18:27:43 +00:00
Pau Pérez Fabregat
398092fa50
Merge pull request #3065 from openfoodfoundation/dependabot/bundler/turbo-sprockets-rails3-0.3.14
...
Bump turbo-sprockets-rails3 from 0.3.6 to 0.3.14
2018-11-20 12:13:23 +01:00
Pau Pérez Fabregat
4c6dec6203
Merge pull request #3082 from coopdevs/remove-travis-leftovers
...
Remove all database.travis.yml
2018-11-20 09:35:12 +01:00
Pau Perez
9301c5e1d5
Remove all database.travis.yml
...
We no longer use this file since we started with Semaphore CI.
2018-11-19 17:16:04 +01:00
Maikel
90e8813ff6
Merge pull request #3054 from coopdevs/fix/incorrect-order-dates
...
Fix/incorrect order dates
2018-11-19 09:17:11 +11:00
Maxim Colls
884d4d0122
Fixed specs
2018-11-17 19:46:09 +01:00
Maxim Colls
3301b5850a
Improved UX in the accordion steps in the checkout page
2018-11-17 18:48:10 +01:00
dependabot[bot]
e655e60b56
Bump turbo-sprockets-rails3 from 0.3.6 to 0.3.14
...
Bumps [turbo-sprockets-rails3](https://github.com/ndbroadbent/turbo-sprockets-rails3 ) from 0.3.6 to 0.3.14.
- [Release notes](https://github.com/ndbroadbent/turbo-sprockets-rails3/releases )
- [Commits](https://github.com/ndbroadbent/turbo-sprockets-rails3/compare/v0.3.6...v0.3.14 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-16 19:16:27 +00:00
Maikel
f593a70000
Merge pull request #2967 from openfoodfoundation/dependabot/bundler/unicorn-5.4.1
...
Bump unicorn from 4.9.0 to 5.4.1
2018-11-16 14:05:47 +11:00
dependabot[bot]
0d93705856
Bump unicorn from 4.9.0 to 5.4.1
...
Bumps [unicorn](https://bogomips.org/unicorn/ ) from 4.9.0 to 5.4.1.
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-16 02:00:48 +00:00
Pau Perez
23bda74ecb
Match name of filter and db column for consistency
2018-11-15 19:09:17 +01:00
Pau Perez
a4bbe2b696
Query completed_at filtering orders by date range
2018-11-15 19:09:17 +01:00
Pau Perez
c7a1c4b253
Change order date column translation in BOM
...
This makes it consistent with the order page. In both cases we use the
`completed_at` column underneath.
2018-11-15 19:09:17 +01:00
Hugo Daniel
a50786be34
Remove old do_not_remove_referenced_fees method
2018-11-15 17:59:06 +01:00
Hugo Daniel
0868404e98
Add specs for new Api::EnterpriseFeesController
2018-11-15 17:58:56 +01:00
Hugo Daniel
1309d80f65
Import products#edit and form partial in our codebase and apply overrides
2018-11-15 17:39:36 +01:00
Pau Pérez Fabregat
ee2ace8023
Merge pull request #3022 from HugsDaniel/2756-duplicate-product-with-image
...
Add specs for cloning a product with image
2018-11-15 17:35:28 +01:00
Hugo Daniel
094d88d03a
Import products#new view into our codebase and apply overrides
2018-11-15 16:35:31 +01:00
Hugo Daniel
d060704e86
Change Spree step-6a commit reference in Gemfile
2018-11-15 15:40:44 +01:00
Pau Perez
52e58a1c31
Remove unused @show_only_completed from view
...
Now there's no difference in behavior. In both cases we sort by
completed_at in the second column of the orders page.
2018-11-15 15:40:13 +01:00
Pau Perez
b7a3255dbe
Replace completed_at in orders table w/ created_at
2018-11-15 15:40:13 +01:00
Pau Perez
b1b04b505e
Fetch orders sorted by completion date
2018-11-15 15:40:13 +01:00
Pau Perez
e69d297f86
Wrap long and unreadable lines
2018-11-15 14:26:13 +01:00
Hugo Daniel
a162a2c50b
Move product distributions check as a before_destroy in EnterpriseFee model
2018-11-15 14:05:15 +01:00
Hugo Daniel
7b33712f7a
Add an API endpoint for EnterpriseFeesController#destroy
2018-11-15 14:05:08 +01:00
Hugo Daniel
4e29589be0
Add specs for cloning a product with image
2018-11-15 13:51:40 +01:00
Pau Pérez Fabregat
605f84d30a
Merge pull request #3010 from openfoodfoundation/transifex
...
Transifex
2018-11-14 11:27:01 +01:00
Pau Pérez Fabregat
8ee193dbcf
Merge pull request #2984 from Matt-Yorkley/email_https_links2
...
Specify only email link protocol setting
2018-11-14 11:26:14 +01:00
Pau Pérez Fabregat
e66f406ea6
Merge pull request #2946 from luisramos0/improve_taxons
...
Sort Product categories alphabetically by name
2018-11-14 11:23:59 +01:00
Transifex-Openfoodnetwork
f9fae06a7a
Updating translations for config/locales/en_BE.yml
2018-11-10 07:09:02 +11:00
Maikel
5c208a68c6
Merge pull request #3007 from openfoodfoundation/revert-2859-instagram_pattern
...
Revert "Instagram pattern"
2018-11-09 14:23:44 +11:00
Maikel
d8d20429aa
Revert "Instagram pattern"
2018-11-09 13:33:11 +11:00
Pau Pérez Fabregat
51a94c8194
Merge pull request #2964 from openfoodfoundation/dependabot/bundler/awesome_print-1.8.0
...
Bump awesome_print from 1.0.2 to 1.8.0
2018-11-07 18:48:32 +00:00
Matt-Yorkley
9011f5d9a2
Rescue ArgumentError and give user feedback
2018-11-07 18:48:08 +00:00
Pau Pérez Fabregat
72a9d39ee1
Merge pull request #2932 from luisramos0/2931-weight-calculator
...
2931 Refactor and prepare weight calculator for spree 2
2018-11-07 18:40:38 +00:00
Pau Pérez Fabregat
ecc69c2c58
Merge pull request #2948 from pfac/pfac-config-time-zone
...
Fix default time zone config
2018-11-07 18:39:25 +00:00
Matt-Yorkley
b5c6ecb45a
Explicitly use UTF-8 encoding when opening spreadsheet files
2018-11-07 16:50:24 +00:00
Matt-Yorkley
5b16353938
Specify only link protocol setting
2018-11-07 11:22:24 +00:00
luisramos0
b7ffde795a
Add migration to update calculator class name of weight calculators
2018-11-07 09:54:53 +00:00
luisramos0
9490da329a
Move Calculator::Weight from models/open_food_network/calculator to models/calculator
2018-11-07 09:54:30 +00:00
luisramos0
bf55f50a7e
Fix rubocop warnings on weight and weight_spec
2018-11-07 09:54:30 +00:00
luisramos0
275a192270
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/models/calculator/weight_spec.rb
* 3 conversions
from: == expected
to: eq(expected)
* 3 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-11-07 09:54:30 +00:00
luisramos0
1ef04354fd
Add capacity to weight calculator to calculate based on any object with an order (needed in spree 2 to calculate based on package)
2018-11-07 09:54:30 +00:00
Luis Ramos
0c02e8c15f
Merge pull request #2981 from coopdevs/remove-commented-out-code
...
Remove old commented out code
2018-11-06 16:06:59 +00:00
Luis Ramos
1ceb632b83
Merge pull request #2980 from coopdevs/fix-long-line
...
Fix long line
2018-11-06 16:05:22 +00:00
Pau Perez
51155bb368
Remove old commented out code
...
You know, git already keeps old code for us.
2018-11-06 14:23:15 +00:00
Pau Perez
26d95b7250
Fix long lines
2018-11-06 13:59:51 +00:00
Pau Pérez Fabregat
4155f086e0
Merge pull request #2968 from openfoodfoundation/transifex
...
Transifex
2018-11-05 19:40:33 +01:00
Transifex-Openfoodnetwork
98d79ec939
Updating translations for config/locales/fr_BE.yml
2018-11-05 18:46:40 +11:00
Maikel
4930c9bc06
Merge pull request #2934 from mkllnk/manual-rubocop-todo-config
...
Add offending files to rubocop config
2018-11-05 10:37:03 +11:00
Maikel Linke
7ad40074a5
Make Code Climate show our real score ans split rubocop config
...
Our rubocop config hides all current violations. It allows us to have a
passing rubocop run on the current code and improve it gradually. It
detects new violations, but doesn't annoy us with all the existing ones.
Code Climate has its own way of remembering all current violations which
is more sophisticated than ours. The new config for Code Climate doesn't
hide any violations so that Code Climate can give us a realistic score
of code quality and warn us about every new violation.
Splitting the configuration into the main three parts gives a quicker
overview and makes maintaining the parts easier.
2018-11-05 10:19:30 +11:00
Maikel Linke
e798532a2f
Add offending files to rubocop config
...
The file .rubocop_todo.yml is generated automatically and contains a
configuration to make all files pass. For a lot of cops it just lists
the offending files. But for some cops it sets a different metric.
Since we don't want these lax metrics, we override them in our config
file .rubocop.yml. This leads to a lot of offences again. This patch
lists all offending files for each cop to make rubocop pass. We can
improve the code over time and remove items from the list.
2018-11-05 10:11:35 +11:00
Pau Pérez Fabregat
3b85bbe911
Merge pull request #2923 from mkllnk/2882-extract-email-setup-in-specs
...
Extract email setup in specs for easy upgrade
2018-11-02 15:40:19 +01:00
Maikel
3259b3ecf1
Merge pull request #2912 from Matt-Yorkley/admin_orders_refactor
...
Admin orders refactor
2018-11-02 16:57:28 +11:00
Maikel
cbfe1b535d
Merge pull request #2871 from openfoodfoundation/dependabot/bundler/figaro-1.1.1
...
Bump figaro from 0.7.0 to 1.1.1
2018-11-02 12:09:53 +11:00
dependabot[bot]
6416d0e1c3
Bump awesome_print from 1.0.2 to 1.8.0
...
Bumps [awesome_print](https://github.com/awesome-print/awesome_print ) from 1.0.2 to 1.8.0.
- [Release notes](https://github.com/awesome-print/awesome_print/releases )
- [Changelog](https://github.com/awesome-print/awesome_print/blob/master/CHANGELOG.md )
- [Commits](https://github.com/awesome-print/awesome_print/compare/v1.0.2...v1.8.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-11-01 19:15:40 +00:00
Maikel
931c1207da
Merge pull request #2813 from openfoodfoundation/dependabot/bundler/haml-4.0.7
...
Bump haml from 4.0.4 to 4.0.7
2018-11-01 16:52:07 +11:00
Maikel
7c4370be69
Merge pull request #2963 from luisramos0/2960_migration
...
Fix variant_overrides permissions for overrides that belong to the supplier herself
2018-11-01 11:41:51 +11:00
luisramos0
079d4e0bf5
Fix variant_overrides permissions for overrides that belong to the supplier herself
2018-10-31 11:26:15 +00:00
Pau Pérez Fabregat
1fbeb43c3a
Merge pull request #2958 from coopdevs/pull-translations
...
Update all locales with the latest Transifex translations
2018-10-31 10:52:02 +01:00
Pau Pérez Fabregat
fc6a2d4a53
Merge pull request #2959 from coopdevs/fix-name-error-on-migrate
...
Move default_url_options set up to an initializer
2018-10-31 10:51:06 +01:00
Pau Perez
f16897a0b8
Fix DE translations manually
...
We don't want 🇩🇪 to have a broken menu.
2018-10-31 08:39:25 +01:00
Pedro Costa
1ddbc24a8b
Fix default time zone config
...
Why:
* Starting the environment, even with just `bundle exec rake`, results
in the following error:
```sh
Value assigned to config.time_zone not recognized.Run "rake -D time"
for a list of tasks for finding appropriate time zone names.
```
This change addresses the issue by:
* Adding the time zone setting to environment specific configurations,
defaulting to UTC in development, and using Melbourne in tests.
2018-10-30 23:50:23 +00:00
Pau Perez
2e2c7c56cb
Move default_url_options set up to an initializer
...
For some reason running `bundle exec rake db:migrate RAILS_ENV=staging`
fails with:
```
rake aborted!
NameError: uninitialized constant Spree::Config
```
Running `bundle exec rails server` for instance, does not. There must be
a difference on the way a rake task and the rails commands load the app.
Moving this configuration to an initializer, at the end of the
initialization process, fixes it. The constant `Spree::Config` is
already loaded.
**This is preventing the release v1.22.0 from being staged and tested**
2018-10-30 19:45:04 +01:00
luisramos0
3d106d749b
Fix rubocop warnings on load_sample_data task
2018-10-30 18:00:52 +00:00
luisramos0
82befd945b
Sort Product categories alphabetically by name and fixsample data by fixing taxons taxonomy id
2018-10-30 18:00:48 +00:00
Pau Pérez Fabregat
e4b988c9a2
Merge pull request #2924 from kristinalim/fix-disable_hiding_of_offcanvas_upon_resize
...
Disable hiding of hamburger menu upon resize <= 1024px width
2018-10-30 19:00:14 +01:00
Pau Pérez Fabregat
b35b24d4ae
Merge pull request #2914 from luisramos0/checkout-language-bug
...
Fix multi lingual issue in cart and checkout: the user language selection was not being used
2018-10-30 17:46:37 +01:00
Pau Pérez Fabregat
7ffa3a2ca1
Merge pull request #2913 from HugsDaniel/2905_password_reset_missing_translations
...
Add password confirmation, token and expired keys
2018-10-30 17:34:01 +01:00
Pau Pérez Fabregat
3d88199257
Merge pull request #2896 from Matt-Yorkley/email_https_links
...
Use https on all links in emails in production
2018-10-30 17:33:32 +01:00
Pau Pérez Fabregat
8e602d453b
Merge pull request #2876 from luisramos0/subs-states-fix
...
Fix bug in subscriptions address controller where country states were not correctly returned
2018-10-30 17:32:34 +01:00
Pau Perez
7f177598f2
Update all locales with the latest Transifex translations
2018-10-30 15:13:57 +01:00
Maikel
d63670d675
Merge pull request #2846 from Matt-Yorkley/pi/rename_enterprise_fields
...
[Product Import] Rename enterprise fields and update template
2018-10-30 15:11:02 +11:00
Maikel
7609496df3
Merge pull request #2859 from albarnaz/instagram_pattern
...
Instagram pattern
2018-10-30 15:10:27 +11:00
Maikel
ee042f51a4
Merge pull request #2949 from pfac/pfac-fix-new-preferences-migration
...
Fix new preferences migration
2018-10-30 15:09:35 +11:00
Pau Pérez Fabregat
5fade045f8
Merge pull request #2928 from luisramos0/line_items_controller_spec
...
Reorganize LineItemsController's destroy line item specs
2018-10-29 16:09:20 +01:00
Pedro Costa
91e4f99c19
Fix new preferences migration
...
Why:
* In a clean environment, running the new preferences migration fails,
due to a missing file from Spree core being manually required. This
file has now been missing since ab707cf .
This change addresses the issue by:
* Copying the missing file from Spree Core 1.3.6.beta into the migration.
This fixes the issue for now, but also means that a migration merge
and/or rewrite might be in order for the future.
2018-10-29 14:53:01 +00:00
Matt-Yorkley
443515dae4
Improve comment in index action
2018-10-29 10:34:05 +00:00
Matt-Yorkley
f3124e5472
Explicitly add :host to actionmailer config
2018-10-26 22:42:47 +01:00
Matt-Yorkley
b826beb0d7
Inline hashes in tests
2018-10-26 21:38:57 +01:00
Matt-Yorkley
29492d61f9
Use #allow syntax
2018-10-26 21:38:57 +01:00
Matt-Yorkley
8c19d1afec
Move tests from spree/admin/orders_controller_spec to api/orders_controller_spec and tidy up
2018-10-26 21:38:57 +01:00
Matt-Yorkley
033ae4f570
Add basic SearchOrders service spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
1f8f7b0495
Add new Api::OrdersController spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
46b1317159
Update orders resource js spec
2018-10-26 21:38:57 +01:00
Matt-Yorkley
334eebeab1
Move json to API and strip index action
2018-10-26 21:38:57 +01:00
Matt-Yorkley
0bd67bd06a
Remove unnecessary Spree::Config fallback value
2018-10-26 21:38:57 +01:00
Matt-Yorkley
77251848ee
Refactor Spree::Admin::OrdersController
2018-10-26 21:38:57 +01:00
luisramos0
09f8df6340
Reorganize LineItemsController's destroy line item specs to separate contexts with different test orders (completed_with_total and completed_with_fees)
2018-10-25 18:06:48 +01:00
Pau Pérez Fabregat
8a3f621b42
Merge pull request #2893 from luisramos0/deleted_products_break_inventory
...
Fix bug in inventory management page
2018-10-25 18:20:42 +02:00
Pau Pérez Fabregat
7cac4637fe
Merge pull request #2916 from luisramos0/date-transl-fix
...
Add Portuguese and German to list of momentJS locales
2018-10-25 18:18:53 +02:00
Kristina Lim
2cc594dc98
Proceed to hide off-canvas when resized to >1024px
2018-10-25 20:36:27 +08:00
Kristina Lim
14eaa49204
Disable hiding the off-canvas upon window resize.
...
In some browsers for mobile devices, the address bar is automatically
hidden when scrolling down the page. This is not workable if the height
of the contents of the off-canvas exceeds the height of the screen,
because the latter portion of the contents stays hidden to the user.
https://github.com/openfoodfoundation/angular-foundation/blob/0.9.0-20180826174721/src/offcanvas/offcanvas.js
2018-10-25 19:29:19 +08:00
Maikel
acb8ec772e
Merge pull request #2922 from mkllnk/update-rubocop-todo
...
Update rubocop todo list
2018-10-25 14:48:51 +11:00
Maikel
3cab3d1798
Merge pull request #2921 from openfoodfoundation/transifex
...
Transifex
2018-10-25 14:22:10 +11:00
Maikel Linke
cd5c23993a
Update rubocop todo list
...
Since we activated more cops in 0ac16ce096
we had a lot of files missing in the todo list. They are likely from
other pull requests that have been open at the same time. This is a
quick update so that rubocop gives us some useful feedback again.
2018-10-25 14:08:04 +11:00
Maikel Linke
e6adb8a3b9
Extract email setup in specs for easy upgrade
...
The way we set up email sending completely changes with Spree 2. This
change encapsulates that code in a single method so that it can be
changed easily and doesn't create further merge conflicts while we are
still working on the master branch and the Spree upgrade.
2018-10-25 13:53:22 +11:00
Maikel
51a1787881
Merge pull request #2908 from Matt-Yorkley/bulk_orders_bug
...
Fix pagination conflict with LineItemsCtrl requests
2018-10-25 13:18:11 +11:00
Maikel Linke
dc5302ca08
Speed up database queries and make them scale
...
This commit makes use of three ActiveRecord features:
1. Using `select` instead of `all.map` enables ActiveRecord to nest one
select into the other, resulting in one more efficient query instead of
two.
2. Using `find_each` saves memory by loading records in batches.
https://api.rubyonrails.org/classes/ActiveRecord/Batches.html#method-i-find_each
3. Using `pluck` creates only an array, avoiding loading all the other
columns of the records into objects.
Running this on the current Canadian database, fixes the following
variant overrides:
```
[]
[]
[]
[]
[]
[]
[925, 924, 966, 965]
[]
[]
[]
[]
[462,
863,
464,
822,
949,
947,
944,
939,
942,
946,
945,
943,
438,
937,
938,
941,
940,
467,
952,
875,
453,
953,
454,
951,
487,
460,
457,
528,
527,
486,
459,
458,
461,
529,
530,
950,
642,
384,
380,
643,
385,
381,
644,
386,
382,
960,
959,
379,
640,
377,
375,
532,
639,
376,
374,
646,
390,
389,
637,
406,
408,
647,
391,
393,
633,
396,
400,
398,
645,
388,
387,
648,
394,
392,
536,
632,
399,
397,
395,
634,
403,
401,
635,
404,
402,
636,
407,
405,
535,
534,
638,
410,
409,
948,
533,
537,
531,
877,
880,
894,
893,
672,
671,
673,
674,
703,
714,
715,
716,
717,
862,
864,
879,
876,
865,
881,
878,
463,
954,
866,
823,
957,
958,
955,
956,
899,
897]
[]
[969]
```
2018-10-25 11:33:14 +11:00
Transifex-Openfoodnetwork
c17939631f
Updating translations for config/locales/en_US.yml
2018-10-25 09:31:36 +11:00
Pau Pérez Fabregat
ce93c52dfe
Merge pull request #2850 from Matt-Yorkley/password_change_logout
...
Password change logout
2018-10-24 11:43:09 +02:00
Pau Pérez Fabregat
9ef4852bd4
Merge pull request #2818 from nikobozi/refactor-variant-overrides-query
...
Move query from variant_overrides_controller to its model scope
2018-10-24 11:42:22 +02:00
Pau Pérez Fabregat
7651ee0909
Merge pull request #2798 from as1729/as1729-update-docs-Stripe-publishable_key-for-pr
...
Better docs for Stripe.publishable_key and Stripe.endpoint_secret.
2018-10-24 11:23:21 +02:00
luisramos0
c9784a5eda
Add Portuguese and German to list of moment locales. The main usage is in the order cycle closure time in the shopfront
2018-10-23 17:53:08 +01:00
luisramos0
034d9ef72a
Refactor multilingual spec: extract method with repeated assertion
2018-10-23 14:10:52 +01:00
luisramos0
9d9f5d38d7
Fix multi lingual issue in cart and checkout: the user language selection was not being used
2018-10-23 14:10:48 +01:00
Hugo Daniel
c5f6af95c7
Add password confirmation, token and expired keys
2018-10-23 10:40:20 +02:00
Maikel
6f5289c730
Merge pull request #2894 from openfoodfoundation/transifex
...
Transifex
2018-10-23 16:21:20 +11:00
Matt-Yorkley
42c1584e6f
Fix pagination conflict with LineItemsCtrl requests
2018-10-22 18:13:56 +01:00
Pau Pérez Fabregat
a1bbf5328e
Merge pull request #2872 from mkllnk/2765-fix-geocoding
...
2765 Fix geocoding to display enterprises on map
2018-10-22 16:44:30 +02:00
luisramos0
d375bb8c55
Migration: Revoke variant overrides without permissions
2018-10-20 12:32:55 +01:00
luisramos0
9079437284
Add before_destroy to enterprise_relationship so that variant overrides are revoked when permission is deleted
2018-10-20 12:32:51 +01:00
luisramos0
5ae0ad87a7
Refactor EnterpriseRelationship before save hook: some renames and extract methods
2018-10-20 11:52:11 +01:00
Matt-Yorkley
c3cef699ca
Use https on all links in emails in production
2018-10-19 17:03:51 +01:00
Transifex-Openfoodnetwork
c911462737
Updating translations for config/locales/en_GB.yml
2018-10-20 02:04:33 +11:00
Maikel Linke
9698fd3c5a
Style spec
2018-10-18 11:07:16 +11:00
Maikel Linke
d197c8587f
Test address deletion
2018-10-18 11:06:32 +11:00
Maikel Linke
e96cab957a
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/models/spree/addresses_spec.rb
* 13 conversions
from: obj.should
to: expect(obj).to
* 2 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 1 conversion
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-10-18 10:52:46 +11:00
luisramos0
fe9f4a1c95
Move countryStates service from ofn.admin to admin.utils to remove bad dependency from admin modules (customers and subscriptions) to main ofn.admin module. Now the dependency admin.utils is used instead
2018-10-17 12:16:33 +01:00
luisramos0
c281927372
Fix subscription address form. It now clears the state selection when a different country is selected
2018-10-16 23:02:26 +01:00
luisramos0
1804bf5a2b
Extract countryStates logic from customer_address modal and re-use new CountryStates service
2018-10-16 22:45:38 +01:00
luisramos0
5c5a2194d6
Extract country states logic out of subscriptions address controller into new service CountryStates
2018-10-16 21:58:27 +01:00
luisramos0
feaf16d878
Fix bug in subscriptions address controller where the country id lookup was not exact and states returned were incorrect. Add unit tests to cover different cases
2018-10-16 20:59:34 +01:00
fabricio.albarnaz
419493f153
Move instagram regex to an method to fix codeclimate
2018-10-16 16:09:15 -03:00
fabricio.albarnaz
8e4adbd23a
Add more test cases
2018-10-16 15:34:46 -03:00
fabricio.albarnaz
93a051bf5a
Regex ajust
2018-10-16 15:33:10 -03:00
Pau Pérez Fabregat
590091c42a
Merge pull request #2842 from Matt-Yorkley/pi/missing_variable
...
Fix missing local variable in EntryProcessor
2018-10-16 13:19:23 +02:00
Maikel Linke
8fb81bb6a7
Configure Geocoder with API key as required by Google
2018-10-16 16:49:52 +11:00
Maikel Linke
61797fff56
Restrict deletion of address explicitely
...
Enterprises have an `address_id` which must point to a valid
`Spree::Address`. As Rubocop suggested, I restricted the deletion of
addresses when they are still associated to an enterprise.
Without declaring `dependent: :restrict`, trying to delete the address
would raise `ActiveRecord::InvalidForeignKey`. Now it is more specific
and raises `ActiveRecord::DeleteRestrictionError`.
I didn't find code rescuing the InvalidForeignKey when deleting addresses. I
actually think that we never delete addresses. So this change should not
have any impact on the execution.
2018-10-16 15:18:44 +11:00
Maikel Linke
a8705ca179
Simplify address methods
2018-10-16 14:49:36 +11:00
Maikel Linke
5021ed9c69
Simplify by using Rails tools
2018-10-16 14:49:35 +11:00
Maikel Linke
34849c441a
Reduce complexity and duplication
2018-10-16 14:48:12 +11:00
Maikel Linke
c4437a6437
Style address decorator
2018-10-16 14:48:12 +11:00
Maikel Linke
b109f6d78c
Remove temporary reporting code
2018-10-16 14:48:12 +11:00
fabricio.albarnaz
02bc134c59
Change befor save check to format validation
2018-10-15 17:51:33 -03:00
dependabot[bot]
dc6c8ec455
Bump figaro from 0.7.0 to 1.1.1
...
Bumps [figaro](https://github.com/laserlemon/figaro ) from 0.7.0 to 1.1.1.
- [Release notes](https://github.com/laserlemon/figaro/releases )
- [Changelog](https://github.com/laserlemon/figaro/blob/master/CHANGELOG.md )
- [Commits](https://github.com/laserlemon/figaro/compare/v0.7.0...v1.1.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-15 19:14:26 +00:00
Pau Pérez Fabregat
f8bccda6ab
Merge pull request #2847 from Matt-Yorkley/emails/validation
...
Emails/validation
2018-10-15 15:54:41 +02:00
Pau Pérez Fabregat
8946fe3ce8
Merge pull request #2829 from Matt-Yorkley/bi/results_per_page
...
Add per_page controls to admin orders index
2018-10-15 12:17:39 +02:00
Pau Pérez Fabregat
0e4a3dbc26
Merge pull request #2845 from coopdevs/fix-invalid-variant-creation
...
Fix invalid variant creation
2018-10-15 12:16:39 +02:00
Pau Pérez Fabregat
fe149967e4
Merge pull request #2521 from luisramos0/cookies_in_engine
...
[OFN Domains] Breaking OFN into domains - POC cookies inside an engine
2018-10-15 10:03:30 +02:00
Matt-Yorkley
fcff835922
Update results on dropdown select
2018-10-12 17:06:42 +01:00
Matt-Yorkley
a2828ea305
Use :for_hubs scope
2018-10-12 17:00:19 +01:00
Matt-Yorkley
123d1963ad
Remove duplicate method
2018-10-12 17:00:19 +01:00
Matt-Yorkley
3cb43121d5
Refactor long lines for new character limit
2018-10-12 17:00:18 +01:00
Matt-Yorkley
8fcaa54de7
Update CSV templates
2018-10-12 16:57:13 +01:00
Matt-Yorkley
bd4f0507ce
Adjustments for new Settings and ResetAbsent classes
2018-10-12 16:57:13 +01:00
Matt-Yorkley
1c85de6f58
Use producer and distributor for field names
2018-10-12 16:57:13 +01:00
Matt-Yorkley
2c9dc8899a
Update fields in specs
2018-10-12 16:57:13 +01:00
Matt-Yorkley
5c2b5377bc
Assign supplier_id when saving new product to products list
2018-10-12 16:57:13 +01:00
Matt-Yorkley
e7a909e828
Rename supplier to enterprise
2018-10-12 16:57:13 +01:00
Matt-Yorkley
8a0a33deec
Merge pull request #2858 from Matt-Yorkley/rubocop_line_limit
...
Increase rubocop line limit to 100
2018-10-12 16:52:37 +01:00
fabricio.albarnaz
6ad32fb66d
Add check for instagram.com
2018-10-11 18:05:18 -03:00
fabricio.albarnaz
e46b3566c3
Remove the check for www.instagram.com
2018-10-11 16:51:43 -03:00
fabricio.albarnaz
48720c835c
Add spec to instagram pattern
2018-10-11 16:30:17 -03:00
fabricio.albarnaz
e87075aed7
Add before save to check the instagram link pattern
2018-10-11 15:27:46 -03:00
Matt-Yorkley
57c6530e46
DRY code and use more flexible I18n
2018-10-11 16:38:14 +01:00
Matt-Yorkley
ebb03906cf
Increase rubocop line limit to 100
2018-10-11 15:37:38 +01:00
Pau Perez
60d05a941c
Fix variants with 'weight' and missing unit_value
...
This adds a data migration to fix those cases. It defaults to showing
1 unit of the specified weight. That is, if the user chose Kg, it'll
display 1 as unit.
Note that migration logs the process in a log/migrate.log file separate
from the regular Rails log/production.log file.
When you run the migration you'll see something like:
Fixing variants missing unit_value...
Processing variant 12...
Succesfully fixed variant 12
Done!
This helps auditing the changes applied and debug any possible failure
scenarios. You can delete it once all is ok.
2018-10-11 15:52:40 +02:00
Pau Perez
5bd375d422
Favor early return over dumb else branch
2018-10-11 15:52:40 +02:00
Pau Perez
c8c16f0e8a
Use Rails 3.2 validates syntax
2018-10-11 15:52:40 +02:00
Pau Perez
cbac916e66
Validate unit value when updating variant_unit
...
Variants whose product's variant_unit is weight or volume require
a unit_value.
2018-10-11 15:52:40 +02:00
Pau Perez
a2228d4131
Make ProductSet parseable by humans
...
Now it's imposible to understand what is really going on. Feels more
like assembler than Ruby.
2018-10-11 15:52:40 +02:00
Pau Perez
575d76e23e
Cover variant creation and update with basic tests
2018-10-11 15:52:40 +02:00
Pau Perez
d43726504b
Make #update_attributes parseable by humans
...
As it is this is impossible to follow.
2018-10-11 15:52:40 +02:00
Pau Perez
f54c69cbba
Add first test case for ProductSet
...
This covers creation and update of a product.
2018-10-11 15:52:40 +02:00
Pau Perez
2d60b3180e
Wrap and improve comment block readability
2018-10-11 15:52:40 +02:00
Matt-Yorkley
4760ebb80c
Use global config
2018-10-11 09:04:37 +01:00
Matt-Yorkley
dafcd0ddc2
Add per_page controls to admin orders index
2018-10-10 18:32:12 +01:00
Pau Pérez Fabregat
1bafa0cb7d
Merge pull request #2853 from mkllnk/remove-parallel-tests
...
Remove parallel tests
2018-10-10 16:01:44 +02:00
Pau Pérez Fabregat
227dd3e399
Merge pull request #2831 from kristinalim/fix-product_import_date_error
...
Fix product import date error when some but not all variants have import date
2018-10-09 16:37:25 +02:00
Pau Pérez Fabregat
85962158b8
Merge pull request #2821 from nikobozi/oc-clear-filter
...
Make 'Clear All' button work on order cycle page
2018-10-09 16:35:57 +02:00
Matt-Yorkley
900c65e0fc
Merge pull request #2855 from openfoodfoundation/transifex
...
Transifex
2018-10-09 14:21:14 +01:00
Matt-Yorkley
edca209f67
Merge pull request #2844 from Matt-Yorkley/bi/angular_orders_changing_page
...
Fix bindings on angular orders data
2018-10-09 14:15:38 +01:00
Transifex-Openfoodnetwork
c2c492cd6b
Updating translations for config/locales/es.yml
2018-10-09 21:57:06 +11:00
Matt-Yorkley
55411af3fa
Improve user account spec
2018-10-09 10:07:41 +01:00
Maikel Linke
245d900b58
Remove unused CI scripts
...
We used to have our own CI server, but now we are using Travis and
Semaphore. We don't need these scripts any more. And since
parallel_tests was removed in the previous commit, they are broken
anyway.
2018-10-09 17:06:59 +11:00
Maikel Linke
4cbc449a51
Remove unused parallel_tests gem
...
Reverts db47c01784
2018-10-09 16:54:08 +11:00
Pau Pérez Fabregat
5606550cd2
Merge pull request #2815 from openfoodfoundation/dependabot/bundler/rspec-retry-0.6.1
...
Bump rspec-retry from 0.5.6 to 0.6.1
2018-10-09 07:30:25 +02:00
Maikel
68c58dcb68
Merge pull request #2770 from openfoodfoundation/transifex
...
Transifex
2018-10-09 15:18:17 +11:00
Matt-Yorkley
3e39f3e749
Disable logout on password change
2018-10-08 23:06:54 +01:00
Matt-Yorkley
8f5fd41c8b
Update email confirmation address
2018-10-08 21:38:47 +01:00
Matt-Yorkley
3ec8c12899
Update account setting spec for updating email address
2018-10-08 20:41:59 +01:00
Pau Pérez Fabregat
ea6e522775
Merge pull request #2826 from 73VW/master
...
[README] Updated build status badge
2018-10-08 17:47:52 +02:00
Pau Pérez Fabregat
f5573f419b
Merge pull request #2778 from coopdevs/refactor-entry-processor
...
Refactor entry processor
2018-10-08 17:11:23 +02:00
Matt-Yorkley
37a7cceead
Fix bindings on angular orders data
2018-10-08 15:42:46 +01:00
Matt-Yorkley
b78716c283
Fix missing local variable
2018-10-08 14:49:29 +01:00
Transifex-Openfoodnetwork
8b59943256
Updating translations for config/locales/de_DE.yml
2018-10-08 16:58:01 +11:00
luisramos0
574f031020
Fix typo in matomo optout iframe url in cookies_policy_helper
2018-10-05 21:36:03 +01:00
Kristina Lim
da904c908d
Fix product import date when not all variants have it
2018-10-06 03:03:22 +08:00
Pau Pérez Fabregat
58a99a7f89
Merge pull request #2692 from Matt-Yorkley/bi/angular_orders
...
Angularise orders page
2018-10-04 21:10:48 +02:00
73VW
7a1cffb4b5
Updated build status badge
2018-10-04 18:43:30 +02:00
Pau Pérez Fabregat
b139f3839a
Merge pull request #2806 from luisramos0/rep
...
Delete representative_view dependency, not used
2018-10-04 13:02:35 +02:00
niko
f99ed81863
Make 'Clear All' button work on order cycle page
2018-10-04 11:46:38 +02:00
niko
f65d3c2815
fix rubocop issue
2018-10-04 03:30:32 +02:00
niko
3ae38178a3
Move query from variant_overrides_controller to its model scope
2018-10-04 02:43:02 +02:00
dependabot[bot]
8a6da745a3
Bump rspec-retry from 0.5.6 to 0.6.1
...
Bumps [rspec-retry](https://github.com/noredink/rspec-retry ) from 0.5.6 to 0.6.1.
- [Release notes](https://github.com/noredink/rspec-retry/releases )
- [Changelog](https://github.com/NoRedInk/rspec-retry/blob/master/changelog.md )
- [Commits](https://github.com/noredink/rspec-retry/compare/v0.5.6...v0.6.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-02 19:15:12 +00:00
dependabot[bot]
4e1521fd6a
Bump haml from 4.0.4 to 4.0.7
...
Bumps [haml](https://github.com/haml/haml ) from 4.0.4 to 4.0.7.
- [Release notes](https://github.com/haml/haml/releases )
- [Changelog](https://github.com/haml/haml/blob/master/CHANGELOG.md )
- [Commits](https://github.com/haml/haml/compare/4.0.4...4.0.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-10-02 19:13:34 +00:00
luisramos0
daafe73d81
Delete representative_view dependency, not used
2018-10-02 15:11:13 +01:00
Pau Pérez Fabregat
aa78b9e54c
Merge pull request #2777 from coopdevs/setup-simplecov
...
Setup simplecov
2018-10-02 14:39:43 +02:00
Pau Pérez Fabregat
6ddcb01b7c
Merge pull request #2736 from openfoodfoundation/dependabot/bundler/oj-3.6.10
...
Bump oj from 2.1.2 to 3.6.10
2018-10-02 14:38:26 +02:00
Matt-Yorkley
55d7d5d1e4
Rename #capture_path to #payment_capture_path
2018-10-02 11:10:51 +01:00
Matt-Yorkley
017e3d14df
Use variable colour assignment
2018-10-02 11:10:21 +01:00
Pau Perez
6a7359a3c5
Pass supplier_ids in strategy #reset instead
...
This removes the need to expose supplier_ids through #<< and makes both
ResetAbsent and its strategies simpler.
This could be made even simpler if the strategies just implemented
`#relation` as public method and ResetAbsent called `#update_all` on
them. The data to be fetched is the only thing that changes but the
update is the same.
2018-10-01 17:37:49 +02:00
Pau Perez
82654cd1ee
Turn delegation to a reader to make it simpler
...
This makes the solution less smart and as a result ResetAbsent improves
it's consistency and returns always an integer.
2018-10-01 16:40:34 +02:00
Pau Perez
148321f7b7
Make strategies class names more explicit
2018-10-01 16:40:34 +02:00
Pau Perez
af93af1a64
Replace strategy with a more explicit name
2018-10-01 16:40:34 +02:00
Pau Perez
8715fce295
Remove @import_settings in favor of Settings
2018-10-01 13:12:06 +02:00
Pau Perez
fd69c7672d
Add specs for ResetAbsent strategies
...
This also fixes the case where there are no overrides to exclude.
2018-10-01 13:12:06 +02:00
Pau Perez
d527f6265a
Remove pointless sum
2018-10-01 13:12:06 +02:00
Pau Perez
5eb10edbfd
Inject #updated_ids to strategy
...
Their values are known beforehand.
2018-10-01 13:12:06 +02:00
Pau Perez
186801a1e2
Remove unused supplier_ids argument
2018-10-01 13:12:06 +02:00
Pau Perez
718f529ede
Use nested module in test to improve readability
2018-10-01 13:12:06 +02:00
Pau Perez
f04fa4ed63
Do not treat ResetAbsent as a decorator anymore
...
This fully encapsulates it's logic and reduces its tight coupling with
EntryProcessor.
2018-10-01 13:12:06 +02:00
Pau Perez
95ae18a1ba
Remove method delegation
2018-10-01 13:12:06 +02:00
Pau Perez
54d6bc5443
Don't use importing_into_inventory? in ResetAbsent
...
This completely decouples ResetAbsent from the particular strategy used.
2018-10-01 13:12:06 +02:00
Pau Perez
a10e58e20a
Inject strategy_factory into ResetAbsent
2018-10-01 13:12:06 +02:00
Pau Perez
a9444b8909
Extract InventoryReset and Products strategies
...
Extract this strategy classes from ResetAbsent and move #reset there.
2018-10-01 13:12:06 +02:00
Pau Perez
8d7a11b0ac
Make all steps of the algorithm have 2 branches
2018-10-01 13:12:06 +02:00
Pau Perez
23471346b6
Do not call ResetAbsent when preconditions not met
2018-10-01 13:12:06 +02:00
Pau Perez
a409353d37
Move import_settings query methods to Settings
2018-10-01 13:12:06 +02:00
Pau Perez
fd84bea463
Test that variants or overrides are actually reset
2018-10-01 13:12:06 +02:00
Pau Perez
b940f06238
Return early if reset_all_absent is not set
...
No need to go through half of the algorithm if the setting is not
enabled. It does not change per enterprise.
This also assumes "Previously we were updating both (products and inventory)
at the same time during one import, but now it's one or the other" in
Matt's words.
2018-10-01 13:12:06 +02:00
Pau Perez
c955e151b7
Pass enterprise ids as strs as current code does
2018-10-01 13:12:06 +02:00
Pau Perez
e04162415a
Move code comment to be the method's doc
2018-10-01 13:12:06 +02:00
Pau Perez
5ac3598550
Inject Settings object in ResetAbsent
2018-10-01 13:12:06 +02:00
Pau Perez
b5766a2dd9
Extract common conditional clauses
...
This also turns local vars into ivars so that the behaviour can be
thoroughly tested. These ivars are meant to be removed once this class
is refactored further. Now there's no other way to ensure its state.
2018-10-01 13:12:06 +02:00
Pau Perez
ed073e9750
Rely on Settings and don't access internal struct.
2018-10-01 13:12:06 +02:00
Aditya Sridhar
372ae8e4aa
updated the spacing to be consistent.
2018-09-30 16:10:57 -04:00
Aditya Sridhar
06b28c1ab4
Better docs for Stripe.publishable_key and Stripe.endpoint_secret.
2018-09-30 15:50:33 -04:00
Pau Perez
663db47433
Move products_reset_count to ResetAbsent
2018-09-29 10:57:23 +02:00
Pau Perez
3150741849
Extract ResetAbsent class from EntryProcessor
2018-09-29 10:57:18 +02:00
luisramos0
3cf10020bf
Fix bug on slow page loads where banner and policy modal were both loaded
...
This solution makes the banner aware of the policy modal: the banner doesnt open if the policy modal is enabled
2018-09-27 17:47:36 +01:00
Pau Perez
16badcd1b5
Setup Simplecov to have code coverage analysis
...
This enables code coverage analysis when running specs in your dev
environment. Simply run them as usual and you'll see a line like the
following at the end of the output:
Coverage report generated for RSpec to /home/pau/dev/openfoodnetwork/coverage
Simply browse to coverage/index.html and the results in a web UI.
This is a useful tool that helps you decide if the tests you added are
enough or not.
2018-09-27 15:57:02 +02:00
Matt-Yorkley
54b17ac701
Use Spree::Order.pending_payments and remove service
2018-09-27 13:04:56 +01:00
Maikel
d488ae3f44
Merge pull request #2725 from mkllnk/2699-email-confirm-jobs
...
2699 email confirm jobs
2018-09-27 14:27:43 +10:00
Maikel Linke
f0021be53c
Style I18n call
2018-09-27 13:33:09 +10:00
Maikel Linke
af1ac333df
Create MailMethod before User when seeding
2018-09-27 13:33:09 +10:00
Maikel Linke
9dcc683dc0
Notify Bugsnag on sign-up errors
...
This may lead to more error reports than we want to see. A not existing
email address may cause Bugsnag to be notified. If this happens, we can
rescue form these specific errors and only report the rest.
2018-09-27 13:33:09 +10:00
Maikel Linke
17d951f99d
Rescue from any sign-up errors
...
The most common failure would happen when sending the confirmation email
triggered by `user.save`. We rescue any errors here and give feedback to
the user.
This allows for immediate feedback when the user types an email address
that is not accepted by our mail server or the email setup is not
configured properly.
2018-09-27 13:33:08 +10:00
Maikel Linke
3ae073dce5
Convert specs to RSpec 3.7.1 syntax with Transpec
...
This conversion is done by Transpec 3.3.0 with the following command:
transpec spec/controllers/user_registrations_controller_spec.rb
* 10 conversions
from: obj.should
to: expect(obj).to
* 7 conversions
from: == expected
to: eq(expected)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2018-09-27 13:33:08 +10:00
Maikel Linke
600c8fcd4c
Send confirmation emails immediately
...
Using deferred methods on the user model breaks delayed jobs when the
user is deleted while the job still exists. We could create a proper job
referencing a user id for sending these emails instead. But since the
user has to wait for the confirmation email anyway, we can send it
within the current request. This should be revised if performance
becomes an issue.
Sending the email directly also has the advantage that we can tell the
user if emailing failed. See the following commits.
This change impacts a bunch of specs as we now need a working email
setup to create unconfirmed users. This commit introduces a custom
matcher to unify testing for confirmation emails.
2018-09-27 13:33:08 +10:00
luisramos0
921105301c
Move angular-templates route and controller into Web engine
...
The route and controller were in the main app and the views in the engine, with this commit they stay all inside the engine
This is done to keep it simple and remove the unnecessary dependency between main app and engine
If we use this mechanism in the future for other things in the main app or other engines, we can find a way to extract/abstract this
2018-09-26 12:39:51 +01:00
luisramos0
b1c7e6c091
Fix assets precompilation by including web/all.js and web/all.css in the assets precompilation list in application.rb
2018-09-26 12:30:45 +01:00
luisramos0
a23b1b980d
Make Web engine an isolated namespace engine mounted on / (without /web prefix)
...
This approach is better to separate concerns, see “Isolated Engine” here: https://api.rubyonrails.org/v3.2/classes/Rails/Engine.html
2018-09-26 12:30:06 +01:00
Matt-Yorkley
2dcc8ea4bb
Add spec for pending payments service
2018-09-25 10:05:32 +01:00
Matt-Yorkley
e93d46e75a
Use .find instead of .select().first
2018-09-25 09:35:05 +01:00
Maikel
51f9a0afa1
Merge pull request #2562 from Matt-Yorkley/pi/product_attributes
...
[Product Import] Product attributes
2018-09-25 11:36:03 +10:00
Maikel
bf1f2b93c6
Merge pull request #2768 from coopdevs/fire-unused-users-task
...
Remove no longer used rake task
2018-09-25 11:30:04 +10:00
Transifex-Openfoodnetwork
97775c0bc1
Updating translations for config/locales/fr_CA.yml
2018-09-25 06:12:48 +10:00
Matt-Yorkley
1d9243af19
DRY and clarify serializer and service
2018-09-24 16:58:43 +01:00
Pau Perez
4a7ee9b91e
Remove no longer used rake task
2018-09-24 17:17:10 +02:00
Matt-Yorkley
6f2760cf92
Move translations into their namespace and use '.key' format
2018-09-24 15:54:05 +01:00
Pau Perez
f743b5f02f
Extract Settings from Product Import processor
...
This encapsulates the data structure used by the entry processor to
check various settings. It still requires a lot of work to move more
logic to this new class.
2018-09-24 13:55:33 +02:00
Pau Pérez Fabregat
b8417058b4
Merge pull request #2741 from coopdevs/refactor-checkout-process-bits
...
Refactor checkout process bits
2018-09-24 12:08:19 +02:00
Maikel
9d48ea7b62
Merge pull request #2759 from luisramos0/del_old_spec_helper
...
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-24 11:25:51 +10:00
Matt-Yorkley
9f57b43a13
Move sortble header elements to a partial
2018-09-23 22:14:12 +01:00
Maikel
f0bb927020
Merge pull request #2734 from coopdevs/make-rubocop-useful
...
Get useful feedback from Rubocop Metrics cops
2018-09-23 19:48:05 +10:00
Maikel
89be54f79e
Merge pull request #2750 from openfoodfoundation/transifex
...
Transifex
2018-09-22 16:05:04 +10:00
Transifex-Openfoodnetwork
7175434910
Updating translations for config/locales/en_US.yml
2018-09-22 01:25:48 +10:00
Maikel
e2fd5a36d8
Merge pull request #2757 from luisramos0/delete_dead_specs
...
Deleted sample specs and one pending spec
2018-09-21 15:41:49 +10:00
luisramos0
33d2b65d65
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-20 23:01:23 +01:00
luisramos0
2a68184c01
Deleted unused test helper for rabl views
2018-09-20 20:09:14 +01:00
Pau Pérez Fabregat
20077c99b5
Merge pull request #2618 from coopdevs/enable-style-send-cop
...
Favor #public_send over #send using Rubocop's cop
2018-09-20 19:03:40 +02:00
Pau Pérez Fabregat
3dd1fcbc72
Merge pull request #2749 from luisramos0/delete-li-ship-method-name
...
Drop unused db column line_items.shipping_method_name
2018-09-20 13:26:26 +02:00
Matt-Yorkley
897e43fe0b
Remove Spree's Deface data-hooks from new view
2018-09-20 11:33:22 +01:00
Maikel Linke
5763bf0518
Update all translations
2018-09-20 10:33:02 +10:00
luisramos0
0e6b0aa248
Deleted sample specs and one pending spec
2018-09-19 23:45:00 +01:00
Matt-Yorkley
fc68e28e4d
Add :description to non-updatable attributes list
2018-09-19 22:30:10 +01:00
Matt-Yorkley
ebb18e9394
Remove unneccesary method
2018-09-19 21:12:30 +01:00
Matt-Yorkley
cc98cc832c
Prefer #public_send over #send
2018-09-19 21:12:30 +01:00
Matt-Yorkley
b57c6cf9ac
Add errors when attempting to update non-updatable fields
2018-09-19 21:12:29 +01:00
Pau Perez
0ac16ce096
Get useful feedback from Rubocop Metrics cops
...
One of the biggest pros of linters like Rubocop is to get valuable feedback to
help write better code. The way we have Rubocop configured now we don't prevent
new code from adhere improved code quality and this is specially important when
touching code that already suffers from complexity.
Without all Rubocop's Metrics cops enabled there's no way to get this insights
and write better code. This enables them while regenerating the
`.rubocop_todo.yml` to hide the current violations.
So, next time we touch existing code that we think could be simpler, we should
go to `.rubocop_todo.yml` and remove any occurrences of the file in question.
This way we could Rubocop's feedback right in the editor. This is tremendously
helpful when refactoring. It shows you where to start.
2018-09-19 19:27:40 +02:00
Pau Pérez Fabregat
62bebdb15e
Merge pull request #2698 from openfoodfoundation/dependabot/bundler/uglifier-4.1.19
...
[Security] Bump uglifier from 2.7.1 to 4.1.19
2018-09-19 18:02:06 +02:00
Pau Perez
a2b3d8372e
Reduce complexity of OrderUpdater decorator
2018-09-19 16:03:33 +02:00
Transifex-Openfoodnetwork
454cd8bfbf
Updating translations for config/locales/nb.yml
2018-09-19 22:30:06 +10:00
HugsDaniel
c4d4b52668
Merge pull request #2742 from openfoodfoundation/transifex
...
Transifex
2018-09-19 14:18:03 +02:00
Matt-Yorkley
3cbb576b4f
Move payment object logic out of order serializer and delete code
2018-09-19 13:00:30 +01:00
Matt-Yorkley
ba254802f8
Move angular_pagination to /views/admin/shared/
2018-09-19 13:00:30 +01:00
Matt-Yorkley
9ce32e3c14
Add new ordersCtrl spec
2018-09-19 13:00:30 +01:00
Matt-Yorkley
64620c2797
Tidy up response formats for easier testing
2018-09-19 13:00:30 +01:00
Matt-Yorkley
6768055b4d
Split orders into 2 angular controllers
2018-09-19 13:00:30 +01:00
Matt-Yorkley
b2551b4e0b
Rewrite existing specs
2018-09-19 13:00:30 +01:00
Matt-Yorkley
68f0c80016
Add loading message and spinner
2018-09-19 13:00:30 +01:00
Matt-Yorkley
9da6a5a9b3
Add column sorting to table
2018-09-19 13:00:30 +01:00
Matt-Yorkley
2112f296e4
Angularise filters
2018-09-19 13:00:30 +01:00
Matt-Yorkley
3b9d9db16b
Add pagination
2018-09-19 13:00:29 +01:00
luisramos0
524f9af148
Drop unused db column line_items.shipping_method_name
2018-09-19 11:38:19 +01:00
Matt-Yorkley
93d273f94a
Convert orders index table to use angular ng-repeat
2018-09-19 09:33:25 +01:00
Transifex-Openfoodnetwork
f0d015be0d
Updating translations for config/locales/de_DE.yml
2018-09-19 08:34:42 +10:00
Transifex-Openfoodnetwork
258347bc63
Updating translations for config/locales/fr.yml
2018-09-19 01:45:12 +10:00
Pau Pérez Fabregat
9f7d24934d
Merge pull request #2671 from kristinalim/translations-any_enterprise_in_oc_filters
...
Translate "Any Enterprise" and "Any Schedule" in OC filters
2018-09-18 11:42:19 +02:00
Pau Perez
2a0e0eed73
Move state_machine's additions inside class_eval
...
And also cover them with tests.
2018-09-18 11:20:32 +02:00
Pau Perez
1fdc578901
Increase readability (a bit) of OrderUpdater
2018-09-18 11:20:32 +02:00
Pau Perez
99cdeca0b1
Remove useless RSpec context block
2018-09-18 11:20:32 +02:00
Pau Perez
13f73b4512
Test :restart_checkout state machine event
2018-09-18 11:20:32 +02:00
Maikel
19df4ff640
Merge pull request #2701 from mkllnk/2700-improve-product-refresh-scheduling
...
2700 improve product refresh scheduling
2018-09-18 12:09:24 +10:00
dependabot[bot]
ccf7d91487
Bump oj from 2.1.2 to 3.6.10
...
Bumps [oj](https://github.com/ohler55/oj ) from 2.1.2 to 3.6.10.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/commits/v3.6.10 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-17 19:16:27 +00:00
luisramos0
c22ac0086b
Moved cookies_policy_helper to Web engine and respective spec
2018-09-17 16:05:38 +01:00
luisramos0
95f2f92cf3
Extracted cookies footer links from view to footer links helper
2018-09-17 16:05:38 +01:00
luisramos0
bded530137
Moved web api endpoint from /api to /web/api
2018-09-17 16:05:38 +01:00
luisramos0
dc5eb6448e
Change web/all.css from sprockets to SASS and include web/all.css through darkswarm/all.css
2018-09-17 16:05:38 +01:00
luisramos0
d170a4d489
New domain Web (rails engine) with the following features extracted from the main app:
...
- cookies banner
- cookies policy page
- cookies policy and privacy policy links in the footer
2018-09-17 16:05:32 +01:00
Matt-Yorkley
e577bcb46f
Prepare angular controller and serialized data
2018-09-17 14:18:23 +01:00
Pau Pérez Fabregat
0f627cdf39
Merge pull request #2661 from kristinalim/translations-copy_of_order_cycle
...
Translate "COPY OF" when cloning an OC
2018-09-17 12:38:29 +02:00
Pau Pérez Fabregat
0520f2187c
Merge pull request #2540 from luisramos0/delete_dead_store
...
removed assets related to spree store: dead code
2018-09-17 11:33:56 +02:00
Kristina Lim
798a6ed391
Translate more text in OC filters
2018-09-17 10:09:17 +10:00
Maikel Linke
ac85b90315
Clarify private class method declaration
2018-09-15 10:18:54 +10:00
Maikel
ce7be68fac
Merge pull request #2660 from kristinalim/translations-failed_oc_creation
...
Translate and fix fallback errors when creating or updating OC
2018-09-14 16:58:39 +10:00
dependabot[bot]
05225aaba7
[Security] Bump uglifier from 2.7.1 to 4.1.19
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 2.7.1 to 4.1.19. **This update includes security fixes.**
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v2.7.1...v4.1.19 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-14 06:29:22 +00:00
Maikel
c3f461ad6e
Merge pull request #2622 from openfoodfoundation/dependabot/bundler/db2fog-0.9.0
...
Bump db2fog from 0.8.0 to 0.9.0
2018-09-14 16:26:54 +10:00
Maikel
e836ac0234
Merge pull request #2686 from HugsDaniel/2593_customize_user_guide_link
...
Enable setting a customized user guide link in general settings
2018-09-14 15:46:05 +10:00
Maikel
beedd933e9
Merge pull request #2512 from kristinalim/feature-remove_enterprise_images
...
Support removal of enterprise logo and promo image
2018-09-14 15:07:24 +10:00
Maikel
eabb9f4574
Merge pull request #2659 from kristinalim/translations-admin_area_fixes
...
Simple translation fixes for admin area and profile page
2018-09-14 14:38:25 +10:00
Maikel
da2f278060
Merge pull request #2649 from kristinalim/translations-fix_store_link_in_admin_header
...
Fix i18n translation for Store link in admin header for `fr`
2018-09-14 14:24:29 +10:00
Maikel
43a3ecff06
Merge pull request #2612 from openfoodfoundation/dependabot/bundler/jwt-1.5.6
...
Bump jwt from 1.5.4 to 1.5.6
2018-09-14 14:13:02 +10:00
Maikel
514f64c8d0
Merge pull request #2650 from kristinalim/translations-more_admin_header
...
Add "more" translation key
2018-09-14 13:31:13 +10:00
Maikel
6b56def649
Merge pull request #2697 from mkllnk/2655-fix-admin-payments
...
2655 fix admin payments
2018-09-14 11:26:20 +10:00
Maikel
1000bd4d24
Merge pull request #2658 from kristinalim/translations-order_and_shipment_emails
...
Allow fixing and customizing translations for order cancellation and shipment emails
2018-09-14 10:11:56 +10:00
Hugo Daniel
8dd0e01b8e
Use explicit syntax for section objects in preference_sections definition
2018-09-13 12:34:06 +02:00
Maikel Linke
ec953e1db0
Style cache refreshment class
2018-09-13 17:22:01 +10:00
Maikel Linke
2e635f94f6
Make job queuing more robust and efficient
2018-09-13 17:20:11 +10:00
dependabot[bot]
b676bfdcc8
Bump jwt from 1.5.4 to 1.5.6
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 1.5.4 to 1.5.6.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v1.5.4...v1.5.6 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-13 02:34:11 +00:00
Maikel
065df96872
Merge pull request #2675 from Matt-Yorkley/bi/remake_views
...
Remake orders index view
2018-09-13 12:29:54 +10:00
Maikel
5e722bf57d
Merge pull request #2634 from luisramos0/cookies_matomo_optout
...
[Cookies] Adds matomo optout iframe to cookies policy page
2018-09-13 12:29:09 +10:00
Maikel
f46c1e8414
Merge pull request #2424 from frank-west-iii/issue-2100-mini-racer
...
Replace therubyracer with mini_racer
2018-09-13 12:28:03 +10:00
Maikel Linke
81f60aab46
Make PaymentMethod serialisable with fees
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/2655
2018-09-13 12:01:17 +10:00
Maikel Linke
d7b19750e5
Add spec for GH issue #2655
2018-09-13 12:01:16 +10:00
Maikel Linke
a447fe4f40
Require lib file where needed
...
We can't always rely on other parts of the code been loaded first. We
need to declare dependencies so that they are always present.
I just ran into this problem in my dev environment.
2018-09-13 12:01:16 +10:00
luisramos0
478dd68072
In cookies policy helper, added string interpolation to variable to avoid variable (Spree::Config entry) to break the concatenation. Added unit test to validate the error case
2018-09-12 18:30:24 +01:00
luisramos0
409f084bd4
Added matomo opt out iframe to cookies policy page
2018-09-12 18:30:24 +01:00
Pau Pérez Fabregat
3f5c799166
Merge pull request #2648 from kristinalim/fix-ask_anonymous_users_to_login_for_order_page
...
Fix ask anonymous users to login for order page
2018-09-12 16:17:34 +02:00
Hugo Daniel
cc43d789e2
Refacto edit method for content controller and enable custom user guide link
2018-09-12 14:51:53 +02:00
dependabot[bot]
91c0de3f2a
Bump db2fog from 0.8.0 to 0.9.0
...
Bumps [db2fog](https://github.com/itbeaver/db2fog ) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/itbeaver/db2fog/releases )
- [Changelog](https://github.com/itbeaver/db2fog/blob/master/CHANGELOG.md )
- [Commits](https://github.com/itbeaver/db2fog/commits/v0.9.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-09-12 11:09:57 +00:00
Pau Pérez Fabregat
e474271698
Merge pull request #2637 from Vadlusk/remove_css_splitter
...
Remove duplicate css_splitter references, delete split css file.
2018-09-12 13:07:15 +02:00
Pau Pérez Fabregat
64e71a1ee7
Merge pull request #2544 from kristinalim/fix-scrolling_in_modals
...
Fix top position, height, and scrolling with modals
2018-09-12 13:05:20 +02:00
Matt-Yorkley
4d9ebf0550
Apply submenu override
2018-09-11 12:17:28 +01:00
Matt-Yorkley
f08d6389d8
Apply capture order override
2018-09-11 12:06:58 +01:00
Matt-Yorkley
507f4d0878
OCD tidy up of visually misaligned filter
2018-09-11 11:53:37 +01:00
Matt-Yorkley
afedaea2b5
Apply special instructions override
2018-09-11 11:49:28 +01:00
Matt-Yorkley
8f174b1308
Apply ship shortcut override
2018-09-11 11:43:38 +01:00
Matt-Yorkley
ba0701457e
Apply distributor td override
2018-09-11 11:42:08 +01:00
Matt-Yorkley
6389c552ca
Apply distributor th override
2018-09-11 11:41:25 +01:00
Matt-Yorkley
1958ac9932
Apply distributor filter inputs override
2018-09-11 11:39:05 +01:00
Matt-Yorkley
c7e2f817ed
Apply colgroup override
2018-09-11 11:34:34 +01:00
Matt-Yorkley
5a2491cb47
Apply ng-app override
2018-09-11 11:30:14 +01:00
Matt-Yorkley
980c46c63f
Convert Spree view to HAML
2018-09-11 11:22:54 +01:00
Kristina Lim
02a909c1b1
Do not use image_tag for enterprise image previews
...
If Rails config.assets.compile is false and config.assets.digest is
true, which is the case for staging and production, image_tag fails when
the image file is not found.
We do not need sprockets to ensure presence of the image file for these
tags, because the correct SRC values are assigned through the JS.
Inserting HTML should be sufficient.
2018-09-08 23:23:49 +08:00
Maikel
5e0997d03e
Merge pull request #2635 from apoc64/timezone_comments
...
Adds comments for setting up timezone in application.yml
2018-09-08 15:55:16 +10:00
Kristina Lim
003e65fbed
Translate error when failing to create order cycle
2018-09-08 02:15:52 +08:00
Kristina Lim
2c2dd62f6a
Translate "COPY OF" when cloning an OC
2018-09-08 02:06:52 +08:00
Kristina Lim
9dcdb67352
Translate inherits_properties label in product form
2018-09-08 01:37:57 +08:00
Kristina Lim
fc79aae17c
Translate authorized shops headers in account page
2018-09-08 00:34:47 +08:00
Kristina Lim
c64acf47ab
Fix translation key for "involving" in OC filters
2018-09-07 21:38:44 +08:00
Kristina Lim
86f4a118dd
Translate placeholder for order cycle name filter
2018-09-07 17:58:34 +08:00
Kristina Lim
40443b19f1
Add translations for headers in enterprise index
...
This is for the view when logged in as enterprise manager.
The translations added are:
* Producer?
* Package
* Status
2018-09-07 17:51:08 +08:00
Kristina Lim
2cf608ffdf
Add translations for shipment emails
2018-09-07 17:08:12 +08:00
Kristina Lim
f1d5088aaa
Add translations for order cancellation emails
2018-09-07 17:01:43 +08:00
Maikel Linke
d6c2a36451
Blacklist libv8 version that breaks mini_racer
2018-09-07 14:11:33 +10:00
Frank West
b9fe1ced16
Replace therubyracer with mini_racer
...
This is being replaced to increase the reliability and speed of asset
compilation.
2018-09-07 14:11:30 +10:00
Kristina Lim
d06bccb832
Change i18n key for Store link in admin header
...
spree_i18n translates the "store" key in different ways, sometimes like
"shop" and sometimes like "save". This could be because of a clash in
usage between Spree add-ons.
To be more specific, the "Store" link in the admin section now uses the
"admin.header.store" translation key.
2018-09-06 22:03:39 +08:00
Kristina Lim
6d5f8553ef
Add "more" translation key
...
This is used in places such as the adaptive menu in the admin section.
This is actually included in spree_i18n but not correctly translated for
fr.
2018-09-06 18:10:27 +08:00
Kristina Lim
f9533f8fb8
Refactor redirecting back after requiring login
2018-09-06 19:46:17 +10:00
Kristina Lim
cd41498da9
Ask to login when not authenticated for order page
...
Redirect the user to the login page, instead of responding with HTTP
401.
2018-09-06 16:26:48 +08:00
Kristina Lim
3bf9e95511
Add specs for existing behaviour in order page
2018-09-06 16:26:45 +08:00
Kristina Lim
28d2bb3d47
Wrap controller specs for viewing cart
2018-09-06 15:04:11 +08:00
Kristina Lim
339ea6fa91
Clean up SCSS as suggested by scss-lint
2018-09-06 04:21:35 +10:00
Kristina Lim
9258e8c464
Remove height limit for modals in small screens
2018-09-05 23:58:26 +08:00
Kristina Lim
169aa752d8
Enlarge potential size of modals for large screens
...
Change modals for large screens from 10% position from top and 80% max
height, to 5% position from top and 90% max height.
This is to accommodate the taller cookies policy modal.
It seems that it is not easy to apply a custom position and height to a
specific modal only. This doesn't seem to be supported by the modal
library currently being used.
Before the recent changes, most modals were rendering at 10px top
position (not the originally planned 10%), so changing this to 5%
doesn't seem to be much of a compromise.
2018-09-05 23:58:26 +08:00
Kristina Lim
f4725198e8
Move some CSS to pages/ subdirectory.
2018-09-05 23:58:26 +08:00
Kristina Lim
f03eb02269
Keep height of modal, dialog within screen height
2018-09-05 23:58:25 +08:00
Kristina Lim
a37e9f1b87
Use v0.9.0-20180826174721 in kristinalim fork of angular-foundation
...
There is a bug in the handling of % values for the "top" CSS property of
the modals. See details here:
https://github.com/kristinalim/angular-foundation/pull/1
A PR to the original repository has also been submitted, but the project
doesn't seem to be active anymore:
https://github.com/yalabot/angular-foundation/pull/319
And to another fork of the repository:
https://github.com/cwadrupldijjit/angular-foundation/pull/1
The bug was causing the 10% "top" CSS property for the modal to be
treated as 10px.
2018-09-05 23:58:25 +08:00
Kristina Lim
34adf7cf6c
Lower the start point for sliding of modals
...
Occasionally, the page scrolls up while the modal is being opened. This
was causing the final position of the modal to be at the wrong location
relative to the viewport.
This was happening because of a race condition between the animation
that slides the modal from above the viewport to the middle, and focus()
which the modal does:
https://github.com/yalabot/angular-foundation/blob/0.8.0/src/modal/modal.js#L109
The final vertical position of the modal is at 10%, so the animation
which translates the modal -25% vertically was starting -15% above the
viewport. The focus() was then causing vertical scroll.
This lowers the starting point of the animation, so there will no longer
be scrolling.
Additionally, the animation would only happen on large screens. The CSS
property "top" is 0 for smaller screens.
2018-09-05 23:58:25 +08:00
Kristina Lim
6e55e5b1c7
Use maximum of 80% for modals in large screens
...
When there is enough content in the modal, the height of the modal plus
its top margin could exceed the height of the viewport.
Considering a top position of 10%, a max height of 80% renders a tall
modal vertically centered, with 10% remaining space at the bottom.
2018-09-05 23:58:22 +08:00
Pau Perez
b23cb55525
Fix current violations of Style/Send cop
2018-09-05 12:05:05 +02:00
Kristina Lim
ce0758d420
Add confirm dialog for enterprise image removal
2018-09-04 02:08:26 +08:00
Kristina Lim
368612cad6
Allow removal of enterprise logo and promo image
2018-09-04 02:08:25 +08:00
Kristina Lim
c9370672c6
Add JS support for removal of enterprise images
2018-09-04 02:08:12 +08:00
Kristina Lim
9c3bb863da
Add endpoints for removing enterprise images
2018-09-04 01:32:39 +08:00
Kristina Lim
01d4b8fb10
Allow custom resource permission for admin controllers
2018-09-04 01:18:48 +08:00
Kristina Lim
f30032eee7
Include image URLs in serialized enterprise for admin
2018-09-04 01:18:45 +08:00
VadLusk
8efbe0e6d2
Delete _split2.css from application.rb assets precompile array.
2018-09-03 11:08:38 -06:00
apoc64
fbce828305
Breaks comment into multiple lines
2018-09-03 08:56:42 -06:00
luisramos0
14d526efc2
removed assets related to spree store: dead code
2018-09-03 09:50:42 +01:00
VadLusk
f74a6e47d5
Remove css_splitter references, delete all_split2.css. #1361 #2633
2018-09-03 09:20:26 +10:00
apoc64
e62a755ddb
Adds comments for setting up timezone in application.yml
2018-09-02 11:08:27 -06:00
Pau Perez
1de13a5049
Favor #public_send over #send using Rubocop's cop
...
Devs keep using `#send` although that method does not preserve
private/protected visibility. Watching after this turned out to be quite
time-consuming while doing code review.
Currently, the Style/Send cop doesn't enforce `#public_send` however
(that's what we want). It simply discourages the use of #send. See
https://github.com/rubocop-hq/rubocop/pull/2081#issuecomment-292251650
for details. So a new entry on the Code Conventions doc has been added
to overcome this limitation:
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-public_send-over-send
2018-08-30 18:48:45 +02:00
Kristina Lim
28792fc895
Add tests for adding/updating enterprise images
2018-08-26 03:58:19 +08:00