raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't fetch rows by ids of DISTINCT records

Browse Source 
There's no point on fetching the same records again by the resulting ids
of the previous query (nasty way of removing duplicates), when that
query has a DISTINCT.
This commit is contained in:
Pau Perez
2018-12-18 17:18:10 +01:00
parent 328cda66f5
commit 8eb35e491d
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/serializers/api/cached_enterprise_serializer.rb
View File

@@ -85,14 +85,12 @@ module Api
def distributed_properties
if active
product_properties = Spree::Property.currently_sold_by(enterprise)
producer_property_ids = ProducerProperty.currently_sold_by(enterprise).pluck(:property_id)
producer_properties = ProducerProperty.currently_sold_by(enterprise)
else
product_properties = Spree::Property.ever_sold_by(enterprise)
producer_property_ids = ProducerProperty.ever_sold_by(enterprise).pluck(:property_id)
producer_properties = ProducerProperty.ever_sold_by(enterprise)
end
producer_properties = Spree::Property.where(id: producer_property_ids)
(product_properties + producer_properties).uniq do |property_object|
property_object.property.presentation
end