raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-01 02:03:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor test to stop using .any_instance

Browse Source 
Although might be useful in very particular cases its use is discourage
by RSpec itself. See https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance
This commit is contained in:
Pau Perez
2019-03-06 16:07:22 +01:00
parent bc34d04c31
commit b9636b975a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/jobs/refresh_products_cache_job_spec.rb
View File

@@ -6,11 +6,13 @@ describe RefreshProductsCacheJob do
let(:order_cycle) { create(:simple_order_cycle) }
context 'when the enterprise and the order cycle exist' do
it "renders products and writes them to cache" do
RefreshProductsCacheJob.any_instance.stub(:products_json) { 'products' }
before do
refresh_products_cache_job = instance_double(OpenFoodNetwork::ProductsRenderer, products_json: 'products')
allow(OpenFoodNetwork::ProductsRenderer).to receive(:new).with(distributor, order_cycle) { refresh_products_cache_job }
end
it 'renders products and writes them to cache' do
run_job RefreshProductsCacheJob.new distributor.id, order_cycle.id
expect(Rails.cache.read("products-json-#{distributor.id}-#{order_cycle.id}")).to eq 'products'
end
end