Maikel Linke
ee3fe08378
Update all locales with the latest Transifex translations
2023-09-01 13:51:29 +10:00
David Cook
441b9febc8
Merge pull request #11454 from macanudo527/fix_rubocop_8
...
Fix Rubocop Style Errors
2023-09-01 13:22:38 +10:00
Maikel Linke
c439aaf32f
Spec trying to ready a shipment twice
2023-09-01 08:55:56 +09:00
Neal Chambers
b0bb97a22f
Fix ready to execute only if it isn't ready
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-09-01 08:55:56 +09:00
Neal Chambers
819fa611e8
Fix Rails/Blank
2023-09-01 08:55:56 +09:00
Neal Chambers
8ae5b61252
Manually Fix Style/GuardClause
2023-09-01 08:55:56 +09:00
Neal Chambers
70e765bff6
Safely autocorrect Style/GuardClause
...
Inspecting 1488 files
......................C....C.C..........................C.........C.........................C............................................C..............................................................................................................C.C........................................CC..............................C...........C...........................................................................................................................................................................................................C........................................................................................................C.......................................................C.............C...........................................................................................C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...C....................................................................................................................C.............
Offenses:
app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless params[:stimulus]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:stimulus]) instead of wrapping the code inside a conditional expression.
if params[:stimulus]
^^
app/controllers/admin/enterprises_controller.rb:51:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.is_primary_producer = params[:is_primary_producer]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:52:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.sells = params[:enterprise_sells]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:53:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
render cable_ready: cable_car.morph("#side_menu", partial("admin/shared/side_menu")) ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:55:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:56:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless user_id.positive? && @enterprise.user_ids.include?(user_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless user_id.positive? && @enterprise.user_ids.include?(user_id)) instead of wrapping the code inside a conditional expression.
if user_id.positive? && @enterprise.user_ids.include?(user_id)
^^
app/controllers/admin/enterprises_controller.rb:267:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@enterprise.update_contact(user_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:268:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:270:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present?) instead of wrapping the code inside a conditional expression.
if attrs[:calculator_type].present? && attrs[:calculator_attributes].present?
^^
app/controllers/admin/enterprises_controller.rb:273:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
rule.update(calculator_type: attrs[:calculator_type])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:274:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
attrs[:calculator_attributes].merge!( id: rule.calculator.id )
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:275:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:278:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:280:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
params[:sets_enterprise_set][:collection_attributes].each do |_i, enterprise_params| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:285:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:289:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin? || spree_current_user == @enterprise.owner
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin? || spree_current_user == @enterprise.owner) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin? || spree_current_user == @enterprise.owner
^^^^^^
app/controllers/admin/enterprises_controller.rb:290:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :sells
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:291:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:296:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:300:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
has_hub = spree_current_user.owned_enterprises.is_hub.any?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:301:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
new_enterprise_is_producer = Enterprise.new(enterprise_params).is_primary_producer
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:302:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params[:sells] = has_hub && !new_enterprise_is_producer ? 'any' : 'none'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:303:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:308:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :owner_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:314:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
bulk_params[:collection_attributes].each do |_i, enterprise_params| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:316:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:317:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression.
unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?
^^^^^^
app/controllers/admin/enterprises_controller.rb:322:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprise_params.delete :user_ids
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/enterprises_controller.rb:323:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/enterprises_controller.rb:325:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/enterprises_controller.rb:332:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless json_request?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless json_request?) instead of wrapping the code inside a conditional expression.
if json_request?
^^
app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 8 instead of 6).
# to limit returned ocs to recent or undated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
orders_close_at_gt = raw_params[:q]&.delete(:orders_close_at_gt) || 31.days.ago
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:189:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
raw_params[:q] = { ...
^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:194:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@collection = collection
^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:195:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/order_cycles_controller.rb:196:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)) instead of wrapping the code inside a conditional expression.
unless Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)
^^^^^^
app/controllers/admin/order_cycles_controller.rb:249:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
order_cycle_params.delete_if do |k, _v| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/order_cycles_controller.rb:252:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/order_cycles_controller.rb:254:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if params[:file] || (params[:filepath] && File.exist?(params[:filepath]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if params[:file] || (params[:filepath] && File.exist?(params[:filepath]))) instead of wrapping the code inside a conditional expression.
unless params[:file] || (params[:filepath] && File.exist?(params[:filepath]))
^^^^^^
app/controllers/admin/product_import_controller.rb:60:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to '/admin/product_import', notice: I18n.t(:product_import_file_not_found_notice)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:61:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/product_import_controller.rb:62:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if importer.item_count
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if importer.item_count) instead of wrapping the code inside a conditional expression.
unless importer.item_count
^^^^^^
app/controllers/admin/product_import_controller.rb:94:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to '/admin/product_import', ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:96:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
true
^^^^
app/controllers/admin/product_import_controller.rb:97:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/admin/product_import_controller.rb:99:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/api/v0/shipments_controller.rb:48:11: C: Style/GuardClause: Use a guard clause (unless @shipment.can_ready?; render(json: { error: I18n.t(:cannot_ready, scope: "spree.api.shipment") },
status: :unprocessable_entity) && return; end) instead of wrapping the code inside a conditional expression.
if @shipment.can_ready?
^^
app/controllers/application_controller.rb:118:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if (@distributor = current_distributor)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:118:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if (@distributor = current_distributor)) instead of wrapping the code inside a conditional expression.
unless (@distributor = current_distributor)
^^^^^^
app/controllers/application_controller.rb:119:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.root_path
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:120:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
false
^^^^^
app/controllers/application_controller.rb:121:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:122:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/application_controller.rb:125:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if current_order_cycle
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:125:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if current_order_cycle) instead of wrapping the code inside a conditional expression.
unless current_order_cycle
^^^^^^
app/controllers/application_controller.rb:126:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.shop_path
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:127:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:129:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/application_controller.rb:131:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless current_distributor_closed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:131:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless current_distributor_closed?) instead of wrapping the code inside a conditional expression.
if current_distributor_closed?
^^
app/controllers/application_controller.rb:132:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
current_order.empty!
^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:133:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
current_order.set_distribution! nil, nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:134:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
flash[:info] = I18n.t('order_cycles_closed_for_hub')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:135:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.root_url
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:136:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/application_controller.rb:139:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/home_controller.rb:7:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless ContentConfig.home_show_stats
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:7:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless ContentConfig.home_show_stats) instead of wrapping the code inside a conditional expression.
if ContentConfig.home_show_stats
^^
app/controllers/home_controller.rb:8:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_distributors = cached_count('distributors', Enterprise.is_distributor.activated.visible)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:9:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_producers = cached_count('producers', Enterprise.is_primary_producer.activated.visible)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:10:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_orders = cached_count('orders', Spree::Order.complete)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:11:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@num_users = cached_count( ...
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/home_controller.rb:14:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/home_controller.rb:15:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless params[:order] && params[:order][:line_items_attributes]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:order] && params[:order][:line_items_attributes]) instead of wrapping the code inside a conditional expression.
if params[:order] && params[:order][:line_items_attributes]
^^
app/controllers/spree/orders_controller.rb:137:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
params[:order][:line_items_attributes] = ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:139:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/spree/orders_controller.rb:140:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless items.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless items.empty?) instead of wrapping the code inside a conditional expression.
if items.empty?
^^
app/controllers/spree/orders_controller.rb:184:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
flash[:error] = I18n.t(:orders_cannot_remove_the_final_item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:185:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
redirect_to main_app.order_path(order_to_update)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/orders_controller.rb:186:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/controllers/spree/orders_controller.rb:188:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:518:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if owner.can_own_more_enterprises?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:518:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if owner.can_own_more_enterprises?) instead of wrapping the code inside a conditional expression.
unless owner.can_own_more_enterprises?
^^^^^^
app/models/enterprise.rb:519:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:owner, I18n.t(:enterprise_owner_error, email: owner.email, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:521:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:522:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:546:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless is_hub
^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:546:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless is_hub) instead of wrapping the code inside a conditional expression.
if is_hub
^^
app/models/enterprise.rb:547:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
enterprises.is_primary_producer.each do |enterprise| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:553:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:555:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:557:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:557:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression.
unless preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^
app/models/enterprise.rb:558:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:shopfront_category_ordering, "must contain a list of taxons.")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:559:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:562:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise.rb:563:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:563:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression.
unless preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/
^^^^^^
app/models/enterprise.rb:564:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
errors.add(:shopfront_category_ordering, "must contain a list of producers.")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:565:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise.rb:569:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/enterprise_group.rb:80:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless permalink.blank? || permalink_changed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:80:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless permalink.blank? || permalink_changed?) instead of wrapping the code inside a conditional expression.
if permalink.blank? || permalink_changed?
^^
app/models/enterprise_group.rb:81:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
requested = permalink.presence || permalink_was.presence || name.presence || 'group'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:82:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
self.permalink = create_unique_permalink(requested.parameterize)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:83:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/enterprise_group.rb:84:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/producer_property.rb:16:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless name.present?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:16:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless name.present?) instead of wrapping the code inside a conditional expression.
if name.present?
^^
app/models/producer_property.rb:16:12: C: [Correctable] Rails/Blank: Use if name.blank? instead of unless name.present?.
return unless name.present?
^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:17:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
self.property = Spree::Property.find_by(name: name) || ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/producer_property.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/producer_property.rb:20:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless total_saved_count.zero?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless total_saved_count.zero?) instead of wrapping the code inside a conditional expression.
if total_saved_count.zero?
^^
app/models/product_import/entry_processor.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@importer.errors.add(:importer, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/entry_processor.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/product_import/entry_processor.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/spree/order.rb:506:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless !completed? && shipments.any?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:506:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !completed? && shipments.any?) instead of wrapping the code inside a conditional expression.
if !completed? && shipments.any?
^^
app/models/spree/order.rb:507:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
shipments.destroy_all
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:508:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
restart_checkout_flow
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:509:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/spree/order.rb:510:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless method_defined? preference_description_getter_method(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless method_defined? preference_description_getter_method(name)) instead of wrapping the code inside a conditional expression.
if method_defined? preference_description_getter_method(name)
^^
app/models/spree/preferences/preferable_class_methods.rb:68:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
remove_method preference_description_getter_method(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:69:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/spree/preferences/preferable_class_methods.rb:70:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
app/services/order_syncer.rb:90:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless !pickup_to_delivery || order.shipment.blank?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/order_syncer.rb:90:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !pickup_to_delivery || order.shipment.blank?) instead of wrapping the code inside a conditional expression.
if !pickup_to_delivery || order.shipment.blank?
^^
app/services/order_syncer.rb:91:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
order.updater.shipping_address_from_distributor
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/order_syncer.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
app/services/order_syncer.rb:93:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless payment.completed? || order.completed?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless payment.completed? || order.completed?) instead of wrapping the code inside a conditional expression.
if payment.completed? || order.completed?
^^
engines/order_management/app/services/order_management/order/updater.rb:167:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
persist_totals
^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/order/updater.rb:168:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
engines/order_management/app/services/order_management/order/updater.rb:169:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Style/GuardClause: Use a guard clause (raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m) instead of wrapping the code inside a conditional expression.
if parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m
^^
lib/discourse/single_sign_on.rb:34:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
raise "The SSO field should be Base64 encoded, using only A-Z, a-z, 0-9, +, /, " \ ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/discourse/single_sign_on.rb:37:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:38:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/discourse/single_sign_on.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless manages_coordinator?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression.
if manages_coordinator?
^^
lib/open_food_network/order_cycle_form_applicator.rb:77:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
exchange.save!
^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:78:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
ExchangeVariantBulkUpdater.new(exchange).update!(variant_ids) unless variant_ids.nil?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:80:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
@touched_exchanges << exchange
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:81:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/open_food_network/order_cycle_form_applicator.rb:82:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless manages_coordinator?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression.
if manages_coordinator?
^^
lib/open_food_network/order_cycle_form_applicator.rb:108:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
untouched_exchanges.each(&:destroy)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/open_food_network/order_cycle_form_applicator.rb:109:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/open_food_network/order_cycle_form_applicator.rb:111:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
raise ActionController::UnknownFormat unless format
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (raise ActionController::UnknownFormat unless format) instead of wrapping the code inside a conditional expression.
if format
^^
lib/spree/core/controller_helpers/respond_with.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
_process_format(format)
^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:44:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
collector
^^^^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless order_cycle && page.has_select?('order_order_cycle_id')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless order_cycle && page.has_select?('order_order_cycle_id')) instead of wrapping the code inside a conditional expression.
if order_cycle && page.has_select?('order_order_cycle_id')
^^
spec/support/request/distribution_helper.rb:11:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
select_by_value order_cycle.id, from: 'order_order_cycle_id'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/distribution_helper.rb:12:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/support/request/distribution_helper.rb:13:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return unless oc.exchanges.from_enterprise(supplier).incoming.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless oc.exchanges.from_enterprise(supplier).incoming.empty?) instead of wrapping the code inside a conditional expression.
if oc.exchanges.from_enterprise(supplier).incoming.empty?
^^
spec/support/request/shop_workflow.rb:128:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
create(:exchange, order_cycle: oc, incoming: true, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:130:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/support/request/shop_workflow.rb:131:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
spec/system/support/precompile_assets.rb:18:5: C: [Corrected] Style/GuardClause: Use a guard clause (next if Webpacker.dev_server.running?) instead of wrapping the code inside a conditional expression.
if Webpacker.dev_server.running?
^^
spec/system/support/precompile_assets.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/support/precompile_assets.rb:21:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
$stdout.puts "\n Precompiling assets.\n"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/support/precompile_assets.rb:23:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
Webpacker.compile
^^^^^^^^^^^^^^^^^
spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1488 files inspected, 220 offenses detected, 218 offenses corrected, 1 more offense can be corrected with `rubocop -A`
2023-09-01 08:55:56 +09:00
Neal Chambers
afdddc9237
Safely autocorrect Style/FileRead
...
Inspecting 1488 files
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................
Offenses:
lib/tasks/karma.rake:33:15: C: [Corrected] Style/FileRead: Use File.read.
unit_js = File.open('config/ng-test.conf.js', 'r').read
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/upload_sanitizer_spec.rb:13:41: C: [Corrected] Style/FileRead: Use File.read.
let(:service) { UploadSanitizer.new(File.open(upload).read) }
^^^^^^^^^^^^^^^^^^^^^^
1488 files inspected, 2 offenses detected, 2 offenses corrected
2023-09-01 08:55:56 +09:00
Neal Chambers
4cce85378c
Safely autocorrect Rails/WhereNot
...
Inspecting 1488 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
lib/reporting/reports/users_and_enterprises/base.rb:27:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: nil }) instead of manually constructing negated SQL in where.
.where("enterprises.id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:39:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprise_id: nil) instead of manually constructing negated SQL in where.
.where("enterprise_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:40:14: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1488 files inspected, 3 offenses detected, 3 offenses corrected
2023-09-01 08:55:56 +09:00
Neal Chambers
f71ee22d2f
Regenerate Rubocop's TODO file
2023-09-01 08:55:56 +09:00
Maikel
67d5ffdc54
Merge pull request #11475 from filipefurtad0/uncomment_i18n_inflections_spec
...
Uncomments pluralize test
2023-08-31 17:20:35 +10:00
filipefurtad0
6bc8a1a850
Uncomments pluralize test
2023-08-30 22:57:46 +01:00
Maikel
dea96fd3ab
Merge pull request #11469 from openfoodfoundation/dependabot/bundler/rubocop-1.56.2
...
chore(deps-dev): bump rubocop from 1.56.1 to 1.56.2
2023-08-30 12:14:36 +10:00
Konrad
077bb41412
Merge pull request #11348 from abdellani/fix-non-empty-orders-in-cart-state-not-appearing
...
fix Non-empty orders in the cart state do not appear in orders page
2023-08-29 15:33:49 +02:00
David Cook
ff3802fe69
Merge pull request #11457 from filipefurtad0/renames_knapsack_nodes
...
Renames Knapsack nodes
2023-08-29 21:04:43 +10:00
dependabot[bot]
091544583f
chore(deps-dev): bump rubocop from 1.56.1 to 1.56.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.1 to 1.56.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.56.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-29 09:38:31 +00:00
David Cook
78585afc9c
Fix format
2023-08-29 16:00:26 +10:00
filipefurtad0
0d1f3f82fd
Balances build time
...
Two nodes were removed from models and three engines; these were and added to system_consumer and system_admin, respectively
2023-08-28 10:28:14 +01:00
filipefurtad0
3a6ca38432
Renames Knapsack nodes
2023-08-28 10:28:14 +01:00
Filipe
67fdc56270
Merge pull request #11427 from mkllnk/release-template
...
Generate all release note categories with labels
2023-08-28 10:04:57 +01:00
Maikel
cf8d5a584e
Merge pull request #11455 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.1.1
...
chore(deps-dev): bump jasmine-core from 5.1.0 to 5.1.1
2023-08-28 11:51:36 +10:00
Maikel
7e44c75456
Merge pull request #11453 from dacook/buu-labels
...
Buu labels
2023-08-28 11:50:35 +10:00
Maikel
86842847ad
Merge pull request #11452 from dacook/flaky-spec-products_v3-11328
...
[Flaky] spec/system/admin/products_v3/products_spec.rb
2023-08-28 11:45:12 +10:00
Maikel
dd79761186
Merge pull request #11448 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.134.0
...
chore(deps): bump aws-sdk-s3 from 1.133.0 to 1.134.0
2023-08-28 11:43:31 +10:00
Maikel
0b869f2abe
Merge pull request #11451 from mkllnk/flaky-voucher-specs
...
De-flake voucher specs by checking success
2023-08-28 11:16:43 +10:00
dependabot[bot]
00ea2e5b07
chore(deps-dev): bump jasmine-core from 5.1.0 to 5.1.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-25 09:09:08 +00:00
David Cook
7d6ba2d31f
Clean up unneeded override
2023-08-25 17:23:05 +10:00
David Cook
451513ad04
Markup labels as.. labels
...
This means you can click on the label name to select the field, and accessibility software can read the label name. I was motivated to do this so that we could update the spec to use label text rather than IDs. But it seems we can't do that with tom-select.
I've updated the styles for all form labels (in admin_style_v3 toggle) to match the design.
2023-08-25 17:19:46 +10:00
Maikel Linke
200729f198
Show incomplete orders when sorting by name
...
An inner join with the billing address was hiding some orders when
sorting by billing address name. Telling Rails that those fields are
referenced triggers an outer left join including orders without billing
address.
But when the Bulk Order Management page sorts by `bill_address_lastname`
then Ransack does most of the magic, except that we need to override the
select in combination with distinct results.
2023-08-25 16:15:11 +10:00
David Cook
4d79cdb0ea
Ensure records are created before visiting the page
...
'let!' is executed in the same way as 'before', so it matters which order they are defined in.
For contexts with a single example, I just put it straight into the example.
2023-08-25 16:09:52 +10:00
Maikel Linke
d8da808901
Resolve pending spec, reported issue is fixed
2023-08-25 15:48:31 +10:00
David Cook
ccafdc4494
Remove redundant code
...
bill_address is already joined in this query.
The class variable isn't needed outside this scope.
Arguably I think the condition on the select isn't needed; it wouldn't hurt to always select spree_addresses. But I'll try to avoid changing too much..
2023-08-25 15:48:31 +10:00
Mohamed ABDELLANI
04312b05c6
add orders without billing address to SearchOrders#fetch_orders' results
2023-08-25 15:48:31 +10:00
David Cook
4f9651f5c9
Wait for pagination message to update
...
Hopefully this fixes openfoodfoundation/openfoodnetwork#11328
2023-08-25 14:52:50 +10:00
Maikel Linke
1a95476634
Combine some voucher system specs to save time
...
It also simplifies the spec code a bit not having a shared example.
2023-08-25 13:56:41 +10:00
Maikel Linke
233171a9ce
De-flake voucher specs by checking success
...
Vouchers are applied via a reflex and we need to check for success
before trying to navigate further. The new helper does this in a
consistent way.
2023-08-25 13:56:41 +10:00
Maikel Linke
4be38ba8da
Remove redundant system spec
...
System specs are expensive. And this spec just looked for the visibility
of certain elements while other tests actually use them and therefore
verify their function much more thoroughly.
2023-08-25 13:56:41 +10:00
Maikel
7414b5cbc9
Merge pull request #11397 from rioug/11331-add-required-field-dcf-enterprise
...
Add required enterprise fields to DFC API
2023-08-25 11:44:49 +10:00
Maikel
56f4eca79e
Update engines/dfc_provider/app/controllers/dfc_provider/addresses_controller.rb
...
Fix type in comment
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-25 11:31:00 +10:00
Maikel
a7e2d23e3b
Merge pull request #11449 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.6.0
...
chore(deps-dev): bump knapsack_pro from 5.4.1 to 5.6.0
2023-08-25 10:50:32 +10:00
David Cook
aea0a629ee
Merge pull request #11425 from macanudo527/fix_rails_activerecordoverride
...
Fix Rails/ActiveRecordOverride
2023-08-25 09:22:05 +10:00
dependabot[bot]
5b25fa80a2
chore(deps-dev): bump knapsack_pro from 5.4.1 to 5.6.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.4.1 to 5.6.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.4.1...v5.6.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 23:01:05 +00:00
dependabot[bot]
61109259e4
chore(deps): bump aws-sdk-s3 from 1.133.0 to 1.134.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.133.0 to 1.134.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 23:00:22 +00:00
Maikel
54e8df7c88
Merge pull request #11443 from openfoodfoundation/dependabot/bundler/ffaker-2.22.0
...
chore(deps): bump ffaker from 2.21.0 to 2.22.0
2023-08-25 08:56:34 +10:00
Maikel
0441453469
Merge pull request #11439 from mkllnk/unflake-customer-report-spec
...
Report customers in deterministic order
2023-08-25 08:54:21 +10:00
Neal Chambers
2bfa51cbb1
Fix Rails/ActiveRecordOverride
2023-08-25 08:51:27 +10:00
filipefurtad0
a39c465692
Update all locales with the latest Transifex translations
2023-08-24 21:36:53 +01:00
Filipe
cc3b7c68ae
Merge pull request #11208 from dacook/buu-editing-11059
...
[BUU] Change name of my products 🚧
2023-08-24 21:19:52 +01:00
Filipe
10bc2a3ee6
Merge pull request #11430 from abdellani/fix-updating-invoices-data
...
fix order invoice generator must update the latest invoice
2023-08-24 20:58:37 +01:00
dependabot[bot]
221eea227f
chore(deps): bump ffaker from 2.21.0 to 2.22.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 2.21.0 to 2.22.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/main/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/compare/v2.21.0...v2.22.0 )
---
updated-dependencies:
- dependency-name: ffaker
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 09:58:42 +00:00
Filipe
020276a248
Merge pull request #11418 from macanudo527/fix_rubocop_7
...
Fix Rails and Style Autocorrect Rubocop Errors
2023-08-24 10:29:45 +01:00
Filipe
c5e1444613
Merge pull request #11206 from macanudo527/fix_class_length
...
Add Form Object to Schedules Controller
2023-08-24 09:28:50 +01:00
Konrad
c90b244a96
Merge pull request #11415 from abdellani/snail-when-setting-unit-value-to-0
...
fix Snail when setting "0" in the unit value field
2023-08-24 10:04:26 +02:00
Konrad
6ec022b731
Merge pull request #11391 from rioug/11362-fix-error-creating-percentage-voucher
...
[Vouchers] fix error when creating a percentage voucher
2023-08-24 09:09:30 +02:00
Maikel Linke
1c3574ce79
Include address in DFC Enterprise endpoint
2023-08-24 16:51:36 +10:00
Maikel Linke
20b09b5352
Add DFC Address API endpoint
2023-08-24 16:20:13 +10:00
Gaetan Craig-Riou
a8d15154a2
Link address to enterprise
...
+ spec
2023-08-24 15:55:15 +10:00
Gaetan Craig-Riou
86bb77ab9f
Add AddressBuilder
...
It will let us include address in the various DFC API endpoint
2023-08-24 15:55:15 +10:00
Gaetan Craig-Riou
f5fb760128
Update Enterprise request spec
...
Check all the attributes supported by the DFC connector
2023-08-24 15:55:14 +10:00
Maikel Linke
244b9abd21
Spec with given data included in examples
...
And use in-memory data where possible to speed up specs.
2023-08-24 15:55:14 +10:00
Maikel Linke
5d05c3c0f1
DRY DFC enterprise spec
2023-08-24 15:55:14 +10:00
Gaetan Craig-Riou
18565f4a85
Add all the enterpise attributes supported by DFC connector
2023-08-24 15:55:14 +10:00
David Cook
3c617a51e0
Merge pull request #11433 from openfoodfoundation/dependabot/bundler/mime-types-3.5.1
...
chore(deps): bump mime-types from 3.5.0 to 3.5.1
2023-08-24 15:11:09 +10:00
David Cook
a96b712eb2
Merge pull request #11432 from openfoodfoundation/dependabot/bundler/activerecord-import-1.5.0
...
chore(deps): bump activerecord-import from 1.4.1 to 1.5.0
2023-08-24 15:10:02 +10:00
David Cook
4a877fe019
Merge pull request #11426 from mkllnk/style-has-many
...
Allow has_and_belongs_to_many to reduce code
2023-08-24 15:03:17 +10:00
dependabot[bot]
f0dce7765c
chore(deps): bump activerecord-import from 1.4.1 to 1.5.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.4.1 to 1.5.0.
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.4.1...v1.5.0 )
---
updated-dependencies:
- dependency-name: activerecord-import
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-24 02:54:17 +00:00
Maikel
79211bd856
Merge pull request #11438 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.133.0
...
chore(deps): bump aws-sdk-s3 from 1.132.1 to 1.133.0
2023-08-24 12:52:39 +10:00
Maikel
fba55fe9fd
Merge pull request #11437 from openfoodfoundation/dependabot/bundler/rails-7.0.7.2
...
chore(deps): bump rails from 7.0.7 to 7.0.7.2
2023-08-24 12:51:08 +10:00
Maikel
d6572d9fde
Merge pull request #11434 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.4.1
...
chore(deps-dev): bump knapsack_pro from 5.3.5 to 5.4.1
2023-08-24 12:46:33 +10:00
Neal Chambers
a363f88f2c
Put Subscriptions back into Schedules Controller
2023-08-24 09:18:35 +09:00
Neal Chambers
7eab4d64ba
Update .rubocop_todo.yml
2023-08-24 09:17:55 +09:00
Neal Chambers
134cbb4f04
Add Form Object to Fix Metrics/ClassLength
2023-08-24 09:17:53 +09:00
David Cook
a8d37d0899
Apply suggestions from code review
...
Rails is clever enough to not query the database without ids
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-24 08:48:27 +10:00
Filipe
1021fd94b5
Merge pull request #11419 from openfoodfoundation/dependabot/bundler/stripe-9.0.0
...
chore(deps): bump stripe from 8.6.0 to 9.0.0
2023-08-23 17:35:29 +01:00
Mohamed ABDELLANI
928494af23
use Invoice#latest to fetch the most recent invoice
2023-08-23 11:57:30 +01:00
dependabot[bot]
cd9bf6a62e
chore(deps): bump stripe from 8.6.0 to 9.0.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.6.0 to 9.0.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.6.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 11:42:43 +01:00
Maikel Linke
4c3d619260
Report customers in deterministic order
...
The result could be random before which led to a flaky spec. I could
have adjusted the spec but I thought that it may be better UX as well to
be deterministic, especially when exporting into spreadsheets.
2023-08-23 17:03:30 +10:00
Maikel Linke
226d270cc1
Remove now obsolete comment
2023-08-23 14:30:46 +10:00
Maikel Linke
58fc9fc8bb
Update symbol for technical changes
2023-08-23 14:29:52 +10:00
Maikel
7e55421ab8
Convey feature toggle release category more clearly
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-23 12:38:49 +10:00
dependabot[bot]
ea46d15ad4
chore(deps): bump aws-sdk-s3 from 1.132.1 to 1.133.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.132.1 to 1.133.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 02:28:35 +00:00
dependabot[bot]
752d77110d
chore(deps): bump rails from 7.0.7 to 7.0.7.2
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.7 to 7.0.7.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.7...v7.0.7.2 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-23 02:28:07 +00:00
Maikel
57c44ffc72
Merge pull request #11429 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.2
...
chore(deps): bump newrelic_rpm from 9.4.1 to 9.4.2
2023-08-23 12:24:53 +10:00
Maikel
9bfb59d45f
Merge pull request #11428 from openfoodfoundation/dependabot/bundler/rubocop-1.56.1
...
chore(deps-dev): bump rubocop from 1.56.0 to 1.56.1
2023-08-23 12:23:43 +10:00
Konrad
3aca33b8a6
Merge pull request #11230 from macanudo527/fix_products_controller
...
Add Query Object to Product Model to Fix Metrics/ClassLength
2023-08-22 11:38:09 +02:00
Mohamed ABDELLANI
b082475c35
update product's unit_value validation
2023-08-22 10:28:27 +01:00
dependabot[bot]
067ddb7bcd
chore(deps-dev): bump knapsack_pro from 5.3.5 to 5.4.1
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.5 to 5.4.1.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.5...v5.4.1 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-22 09:04:55 +00:00
dependabot[bot]
238249e8ec
chore(deps): bump mime-types from 3.5.0 to 3.5.1
...
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types ) from 3.5.0 to 3.5.1.
- [Changelog](https://github.com/mime-types/ruby-mime-types/blob/main/History.md )
- [Commits](https://github.com/mime-types/ruby-mime-types/compare/v3.5.0...v3.5.1 )
---
updated-dependencies:
- dependency-name: mime-types
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-22 09:03:13 +00:00
Mohamed ABDELLANI
a896d414c2
optimize system test
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
3ab288f435
fix product's unit value validation
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
d4dbc0adb5
fix unit_value initialization on the product duplicator
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
a9e4159839
validate unit_value > 0 on product model
2023-08-22 09:16:47 +01:00
David Cook
2edf504d65
Ignore long classes for now
...
As much as I hate to add to this list, this is still a work in progress so it's not worth refactoring at this point.
2023-08-22 11:51:05 +10:00
David Cook
b0e77df226
Style form actions area
2023-08-22 11:51:05 +10:00
David Cook
fccde964bf
Enable 'medium' style for reset buttons
2023-08-22 11:46:56 +10:00
David Cook
7bf79441c8
Update link colours to match new design
2023-08-22 11:40:58 +10:00
David Cook
3cc5d7ba1d
Copy form styles to v3
2023-08-22 11:40:58 +10:00
David Cook
37d1113e4c
Align row headers with input contents
...
Inputs add extra padding, so we add the same padding to the header. Using an opt-in class, because I think we won't want this on all columns.
2023-08-22 11:40:58 +10:00
David Cook
8440c44a6f
Remove unused style
2023-08-22 11:40:58 +10:00
David Cook
2b09ec7c21
[fixup] Left line for row hover
2023-08-22 11:40:58 +10:00
David Cook
be24247df2
[wip] Left line for row hover
...
But it's not perfect. Can we use a pseudo element instead?
2023-08-22 11:40:58 +10:00
David Cook
565ea23175
Hide borders from inputs until hover
2023-08-22 11:40:58 +10:00
David Cook
ef63c520c0
Aggregate errors
2023-08-22 11:40:58 +10:00
David Cook
a70f392654
Show error messages
...
It's kinda hard to test reflexes..
2023-08-22 11:40:58 +10:00
David Cook
a0dba001bc
Attempt to save all records in bulk update
...
Before, it would abort after the first invalid record, and it doesn't tell you about the others. This way you find out about all at once.
This affects the existing Bulk Edit Products screen, and can result in longer error messages than before. But I would argue that's a good thing.
I think this is technically optional for BUU at this point, but a helpful improvement.
2023-08-22 11:40:58 +10:00
David Cook
71c36585bc
Retain order when saving.
...
Perhaps this should be tested in the system spec too ("I can rename a product and still see it after saving"). But I'd like to find the compromise to avoid bulking up system specs too much. I think it's covered well enough by the reflex spec?
2023-08-22 11:40:58 +10:00
David Cook
6ffe1ec1ad
Retain the order of products in the collection
2023-08-22 11:40:58 +10:00
David Cook
ae3cd6f7e0
Add bulk_update product form for product name
...
(For now at least,) we use one big standard Rails form, and ModelSet to update each record.
Submitting with Reflex allows us to manage the loading state along with the rest of the page (although I would rather use the built in HTTP POST standard).
Aria-label makes it a bit easier for testing (and accessibility software of course!). Technically it should have been aria-labelledby="id_of_column_header" but that would have resulted in more HTML and processing, which seemed silly.
Best viewed with whitespace ignored.
2023-08-22 11:40:58 +10:00
David Cook
a98242e5b4
Capybara: enable_aria_label
2023-08-22 11:40:58 +10:00
David Cook
e37a499125
Merge pull request #11383 from jibees/11274-buu-as-a-single-producer-i-should-not-be-able-to-see-the-producer-dropdown
...
🚧 Products V3: Do not display "Producers" selector if only one is possible
2023-08-22 11:33:12 +10:00
Maikel Linke
31d87ca087
Show producer filter only when multiple options
...
Also introducing a view spec here because the code was incorrectly
refactored before. The execution of the view spec takes only 100ms
which is much faster than a system spec.
2023-08-22 10:00:06 +10:00
Jean-Baptiste Bellet
6582a875c6
Do not display "Producers" selector if only one is possible
...
Fix #11274
Co-Authored-By: David Cook <david@redcliffs.net >
2023-08-22 10:00:06 +10:00
David Cook
71b297b5b5
Merge pull request #11417 from jibees/11410-go-back-to-top-after-selecting-a-page-in-pagination
...
🚧 BUU: Once products are loaded, scroll higher, ie. just above filters
2023-08-22 09:20:31 +10:00
Konrad
391d06130d
Merge pull request #11395 from duleorlovic/google-map-region
...
Add Google map region parameter
2023-08-21 18:14:56 +02:00
Mohamed ABDELLANI
aaf1d22ccc
fix order invoice generator must update the latest invoice
2023-08-21 16:10:05 +01:00
dependabot[bot]
397f365fe6
chore(deps): bump newrelic_rpm from 9.4.1 to 9.4.2
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.4.1 to 9.4.2.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.4.1...9.4.2 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-21 09:28:35 +00:00
dependabot[bot]
c97b5b3693
chore(deps-dev): bump rubocop from 1.56.0 to 1.56.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.0 to 1.56.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.0...v1.56.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-21 09:27:48 +00:00
Maikel
af73720157
Merge pull request #11423 from openfoodfoundation/dependabot/bundler/puma-6.3.1
...
chore(deps): bump puma from 6.3.0 to 6.3.1
2023-08-21 14:04:20 +10:00
Maikel Linke
2917e2f849
Generate all release note categories with labels
...
If reviewers add the right labels to pull requests then the release
note categories can be generated automatically.
2023-08-21 10:39:52 +10:00
Maikel Linke
ff18270898
Allow has_and_belongs_to_many to reduce code
...
The Rails/HasAndBelongsToMany rule wants model classes for all
many-to-many relationship tables in the database. But our team thinks
that it's useful to declare has_and_belongs_to_many relationships which
don't require an additional model.
2023-08-21 10:12:33 +10:00
Neal Chambers
0b6b750706
Clarify Product Scope Query Spec
2023-08-20 13:01:34 +09:00
Neal Chambers
fc47c57603
Add helper method to products controller and Use query object
2023-08-20 13:00:39 +09:00
Neal Chambers
9e82ab8a0f
Remove query scopes from product model
2023-08-20 13:00:39 +09:00
Neal Chambers
c125c42a6d
Add Tests for Product Scope Query
2023-08-20 13:00:39 +09:00
Neal Chambers
a867f7c543
Add Product Scope Query
2023-08-20 13:00:36 +09:00
Maikel Linke
eb204c9e5b
Style HashSyntax and reduce line length
2023-08-20 12:33:43 +09:00
Maikel Linke
e0acc25808
Fix subscription spec and add more coverage
...
One spec was only passing due to a bug. The setup wasn't complete and
despite the variant being unavailable in the order cycle it was reported
as being available. The order cycle has now been set up correctly.
Another spec was added to cover an edge case lead to a bug before this
pull request. When all subscription items where unavailable, all were
marked as available.
2023-08-20 12:33:43 +09:00
Neal Chambers
bc559b966c
Safely autocorrect Style/FetchEnvVar
...
Inspecting 1483 files
..............................................................................................................................................................C.............................................................................................................................................................................CC.............................................................................................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................C.................................................................................C..............................................................................................................................................................................................C.....................................................................................................................................................................................................................................C......................................................................................................................
Offenses:
app/helpers/discourse_helper.rb:9:5: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('DISCOURSE_URL') or ENV.fetch('DISCOURSE_URL', nil) instead of ENV['DISCOURSE_URL'].
ENV['DISCOURSE_URL']
^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/configuration.rb:35:10: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('RAILS_CACHE_ID') or ENV.fetch('RAILS_CACHE_ID', nil) instead of ENV['RAILS_CACHE_ID'].
[ENV['RAILS_CACHE_ID'], self.class.name, name].flatten.join('::').underscore
^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable.rb:84:10: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("RAILS_CACHE_ID") or ENV.fetch("RAILS_CACHE_ID", nil) instead of ENV["RAILS_CACHE_ID"].
[ENV["RAILS_CACHE_ID"], self.class.name, name, id].join('::').underscore
^^^^^^^^^^^^^^^^^^^^^
app/services/default_country.rb:13:40: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("DEFAULT_COUNTRY_CODE") or ENV.fetch("DEFAULT_COUNTRY_CODE", nil) instead of ENV["DEFAULT_COUNTRY_CODE"].
Spree::Country.cached_find_by(iso: ENV["DEFAULT_COUNTRY_CODE"]) || Spree::Country.first
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/default_country.rb:13:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
Spree::Country.cached_find_by(iso: ENV.fetch("DEFAULT_COUNTRY_CODE",
^
app/services/default_country.rb:13:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
Spree::Country.cached_find_by(iso: ENV.fetch("DEFAULT_COUNTRY_CODE", nil)) || Spree::Country.first
^^
app/services/default_country.rb:14:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
nil)) || Spree::Country.first
^^^
spec/base_spec_helper.rb:51:49: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch("SITE_URL") or ENV.fetch("SITE_URL", nil) instead of ENV["SITE_URL"].
ActionMailer::Base.default_url_options[:host] = ENV["SITE_URL"]
^^^^^^^^^^^^^^^
spec/controllers/spree/credit_cards_controller_spec.rb:8:20: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_SECRET_TEST_API_KEY') or ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) instead of ENV['STRIPE_SECRET_TEST_API_KEY'].
let(:secret) { ENV['STRIPE_SECRET_TEST_API_KEY'] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:48:70: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(order_balance.display_amount).to eq(Spree::Money.new(20,
^
spec/models/order_balance_spec.rb:48:81: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('currency') or ENV.fetch('currency', nil) instead of ENV['currency'].
expect(order_balance.display_amount).to eq(Spree::Money.new(20, currency: ENV['currency']))
^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:48:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100]
expect(order_balance.display_amount).to eq(Spree::Money.new(20, currency: ENV.fetch('currency', nil)))
^^^^^^^^
spec/models/order_balance_spec.rb:49:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
currency: ENV.fetch('currency', nil)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/order_balance_spec.rb:49:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
currency: ENV.fetch('currency',
^
spec/models/order_balance_spec.rb:49:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
currency: ENV.fetch('currency', nil)))
^^^^
spec/models/order_balance_spec.rb:50:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
nil)))
^^^
spec/support/vcr_setup.rb:10:50: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_SECRET_TEST_API_KEY') or ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) instead of ENV['STRIPE_SECRET_TEST_API_KEY'].
config.filter_sensitive_data('<HIDDEN_KEY>') { ENV['STRIPE_SECRET_TEST_API_KEY'] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/vcr_setup.rb:11:55: C: [Corrected] Style/FetchEnvVar: Use ENV.fetch('STRIPE_CUSTOMER') or ENV.fetch('STRIPE_CUSTOMER', nil) instead of ENV['STRIPE_CUSTOMER'].
config.filter_sensitive_data('<HIDDEN_CUSTOMER>') { ENV['STRIPE_CUSTOMER'] }
^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 18 offenses detected, 18 offenses corrected
2023-08-20 12:33:43 +09:00
Neal Chambers
fd795d8513
Safely autocorrect Style/BlockComments
...
Inspecting 1483 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................
Offenses:
spec/system/admin/tag_rules_spec.rb:209:1: C: [Corrected] Style/BlockComments: Do not use block comments.
=begin ...
^^^^^^
spec/system/admin/tag_rules_spec.rb:217:101: C: Layout/LineLength: Line is too long. [103/100]
# expect(default_fsm_tag_rule.preferred_matched_shipping_methods_visibility).to eq "hidden"
^^^
spec/system/admin/tag_rules_spec.rb:241:1: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 6).
# expect(foc_tag_rule.preferred_matched_order_cycles_visibility).to eq "hidden"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 3 offenses detected, 2 offenses corrected
2023-08-20 12:33:43 +09:00
Neal Chambers
06e217c527
Safely autocorrect Rails/WhereNot
...
Inspecting 1483 files
........................................................................................................................C..................................................................................................................C...........CC.C..........................................C......C..........C.........................C......................CC..........C........................................................................................................................C.......................................................................................................C........................................................C...........................................................................................................................................C......................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/spree/admin/products_controller.rb:183:11: C: [Corrected] Rails/WhereNot: Use where.not(spree_variants: { import_date: nil }) instead of manually constructing negated SQL in where.
where('spree_variants.import_date IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/concerns/permalink_generator.rb:37:26: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
scope_with_deleted.where('id != ?', id)
^^^^^^^^^^^^^^^^^^^^
app/models/concerns/permalink_generator.rb:37:40: C: [Corrected] Style/HashSyntax: Omit the hash value.
scope_with_deleted.where.not(id: id)
^^
app/models/enterprise.rb:152:7: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: ready_enterprises }) instead of manually constructing negated SQL in where.
where("enterprises.id NOT IN (?)", ready_enterprises)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:158:31: C: [Corrected] Rails/WhereNot: Use where.not(sells: 'none') instead of manually constructing negated SQL in where.
scope :is_distributor, -> { where('sells != ?', 'none') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:479:17: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
dups = dups.where('id != ?', id) unless new_record?
^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:534:43: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: self }) instead of manually constructing negated SQL in where.
enterprises = owner.owned_enterprises.where('enterprises.id != ?', self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:583:7: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: id }) instead of manually constructing negated SQL in where.
where('enterprises.id != ?', id).
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_fee.rb:40:24: C: [Corrected] Rails/WhereNot: Use where.not(spree_calculators: { type: PER_ORDER_CALCULATORS }) instead of manually constructing negated SQL in where.
joins(:calculator).where('spree_calculators.type NOT IN (?)', PER_ORDER_CALCULATORS)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:78:19: C: [Corrected] Rails/WhereNot: Use where.not(name: perms) instead of manually constructing negated SQL in where.
permissions.where('name NOT IN (?)', perms).destroy_all
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/product_import/inventory_reset_strategy.rb:27:16: C: [Corrected] Rails/WhereNot: Use where.not(id: excluded_items_ids) instead of manually constructing negated SQL in where.
relation.where('id NOT IN (?)', excluded_items_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/proxy_order.rb:19:25: C: [Corrected] Rails/WhereNot: Use where.not(proxy_orders: { canceled_at: nil }) instead of manually constructing negated SQL in where.
scope :canceled, -> { where('proxy_orders.canceled_at IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/credit_card.rb:26:39: C: [Corrected] Rails/WhereNot: Use where.not(gateway_customer_profile_id: nil) instead of manually constructing negated SQL in where.
scope :with_payment_profile, -> { where('gateway_customer_profile_id IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/product.rb:166:9: C: [Corrected] Rails/WhereNot: Use where.not(order_cycles: { id: nil }) instead of manually constructing negated SQL in where.
where('order_cycles.id IS NOT NULL')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:94:30: C: [Corrected] Rails/WhereNot: Use where.not(deleted_at: nil) instead of manually constructing negated SQL in where.
scope :deleted, lambda { where('deleted_at IS NOT NULL') }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:165:43: C: [Corrected] Rails/WhereNot: Use where.not(spree_prices: { amount: nil }) instead of manually constructing negated SQL in where.
where('spree_prices.amount IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/zone.rb:141:19: C: [Corrected] Rails/WhereNot: Use where.not(id: id) instead of manually constructing negated SQL in where.
Spree::Zone.where('id != ?', id).update_all(default_tax: false) if default_tax
^^^^^^^^^^^^^^^^^^^^
app/models/spree/zone.rb:141:33: C: [Corrected] Style/HashSyntax: Omit the hash value.
Spree::Zone.where.not(id: id).update_all(default_tax: false) if default_tax
^^
app/models/variant_override.rb:32:7: C: [Corrected] Rails/WhereNot: Use where.not(variant_overrides: { import_date: nil }) instead of manually constructing negated SQL in where.
where('variant_overrides.import_date IS NOT NULL').
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/cap_quantity.rb:45:22: C: [Corrected] Rails/WhereNot: Use where.not(variant_id: available_variants_for.select(&:id)) instead of manually constructing negated SQL in where.
order.line_items.where('variant_id NOT IN (?)', available_variants_for.select(&:id))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/app/services/catalog/product_import/products_reset_strategy.rb:32:18: C: [Corrected] Rails/WhereNot: Use where.not(spree_variants: { id: excluded_items_ids }) instead of manually constructing negated SQL in where.
relation.where('spree_variants.id NOT IN (?)', excluded_items_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/app/services/order_management/subscriptions/proxy_order_syncer.rb:78:18: C: [Corrected] Rails/WhereNot: Use where.not(order_cycle_id: order_cycle_ids) instead of manually constructing negated SQL in where.
orphaned.where('order_cycle_id NOT IN (?)', order_cycle_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:27:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: nil }) instead of manually constructing negated SQL in where.
.where("enterprises.id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:39:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprise_id: nil) instead of manually constructing negated SQL in where.
.where("enterprise_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:40:14: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/anonymize_data.rake:50:16: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
Customer.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1483 files inspected, 26 offenses detected, 26 offenses corrected
2023-08-20 12:33:43 +09:00
Konrad
241239ac68
Merge pull request #11379 from dacook/respond_to-not_found
...
Respond to all formats for "not found" error
2023-08-18 18:47:09 +02:00
Konrad
0dc8996701
Merge pull request #11295 from Matt-Yorkley/scope-error
...
Remove product display_as cell
2023-08-18 18:16:16 +02:00
Konrad
df7d42a420
Merge pull request #11352 from abdellani/remove-dead-code-bulk-invoice
...
Remove dead code related to bulk invoice printing
2023-08-18 18:14:01 +02:00
Matt-Yorkley
2b9b79c828
Remove product display_as cell
...
This was attempting to reference the master variant, which is now gone. Fixes an Angular scope error.
2023-08-18 17:38:36 +02:00
Konrad
f3b09508ff
Merge pull request #11347 from abdellani/fix-edit-order-button
...
fix cancel order button
2023-08-18 17:07:42 +02:00
Konrad
d8bc479a70
Merge pull request #11387 from jibees/10957-missing-translation-invalid-url
...
Admin, White Label: add translation for invalid URL in white label context
2023-08-18 15:59:39 +02:00
dependabot[bot]
fcb3a74b64
chore(deps): bump puma from 6.3.0 to 6.3.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.3.0...v6.3.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-18 09:10:32 +00:00
Jean-Baptiste Bellet
2abfa623f0
Once products start loading, scroll higher, ie. just above filters
...
can see the loading spinner then
2023-08-18 10:20:10 +02:00
jibees
5395bc56f8
Merge pull request #11416 from jibees/11197-buu-no-results-page-and-number-of-results-tweaks
...
🚧 BUU: No results page and number of results tweaks
2023-08-18 10:14:09 +02:00
Jean-Baptiste Bellet
06fccd8618
Totally hide input above its container
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
47115a0daf
Change default label for searched products
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
721baa4d3f
Increase button size
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
117c373985
Add "remove-sign" icon before text in disruptive button
2023-08-18 09:46:57 +02:00
Jean-Baptiste Bellet
d27b2084ed
Do not underline text when it's a button
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
e4479e7935
Increase button height when no result
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
f5e7738c78
Introduce relaxed, regular and condensed button for specify height
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
5de0d79ca2
Increase distance from search container to 136px
...
116px + 20px (gap) = 136px
2023-08-18 09:46:56 +02:00
Jean-Baptiste Bellet
4219d0aa08
Change font size and weight
2023-08-18 09:46:56 +02:00
Maikel Linke
0acdf5833f
Update all locales with the latest Transifex translations
2023-08-18 15:54:00 +10:00
David Cook
01f0de2f4e
Merge pull request #11405 from macanudo527/fix_rubocop_rails_errors
...
Fix rubocop rails errors
2023-08-18 11:54:17 +10:00
David Cook
7a04f63d62
Merge pull request #11407 from jibees/10878-buu-pagination-tweaks
...
🚧 BUU: Pagination tweaks
2023-08-18 09:25:55 +10:00
jibees
e82ff80582
Merge pull request #11420 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.1
...
chore(deps): bump newrelic_rpm from 9.4.0 to 9.4.1
2023-08-17 13:46:47 +02:00
dependabot[bot]
47ca35c38e
chore(deps): bump newrelic_rpm from 9.4.0 to 9.4.1
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.4.0 to 9.4.1.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.4.0...9.4.1 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-17 09:28:40 +00:00
Neal Chambers
fe5288c015
Update .rubocop_todo.yml
2023-08-17 16:45:52 +09:00
Neal Chambers
3c9afcf360
Fix Rails/CompactBlank
2023-08-17 16:43:13 +09:00
Neal Chambers
871a8e6f2c
Fix Rails/Blank
2023-08-17 16:42:46 +09:00
Neal Chambers
b78bbd2629
Fix Rails/ApplicationController
2023-08-17 16:42:41 +09:00
Jean-Baptiste Bellet
fa4dda9976
Finally, remove disabled rule that is unused
...
We only display active link
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
394e964b91
Specify for element that have href attr: the ones we want to hover
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
e7d36ed772
Let link have the cursor: pointer by default, and specify only for current
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
2405dfdaa3
Refine and adjust position of icon in button
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
1a8a4ee72b
Change size of pagination
...
"it becomes extremely long for big catalogues"
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
66a106b1c9
hide pagination for single page catalogue
...
+ update specs then
2023-08-17 09:26:10 +02:00
Jean-Baptiste Bellet
3fb8726c6a
Do not display arrows if they're disabled
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
b1ea77e611
Remove white background from dots
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
c252de87b6
Specify cursor in order to not be text
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
5fc4f7bdaf
Design hover (like current)
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
9d8325c0d9
font weight to be 600
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
d914644c35
change not selected font color to $near-black, also for arrows
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
06af58e923
increase distance between arrows and numbers to be 36px
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
6e29dd95ef
Increase distance between numbers to be 8px
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
a2da3c2f61
Better management of margin/gap between each button with flex display
2023-08-17 09:06:26 +02:00
Jean-Baptiste Bellet
9396e75806
Increase padding top and padding bottom
2023-08-17 09:06:26 +02:00
Maikel
5762492511
Merge pull request #11392 from dacook/release-template
...
Release template
2023-08-17 16:47:49 +10:00
Maikel
6377149e18
Merge pull request #11400 from jibees/buu-update/refactor-tests
...
🚧 BUU: refactor/improve testing
2023-08-17 16:32:00 +10:00
David Cook
a854dccf04
Simplify tag steps
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-17 16:09:06 +10:00
Maikel
d0559d2a6c
Merge pull request #11413 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.4.0
...
chore(deps): bump newrelic_rpm from 9.3.1 to 9.4.0
2023-08-17 15:36:28 +10:00
Maikel
27dcad205e
Merge pull request #11337 from macanudo527/fix_rubocop_6
...
Fix autocorrect Rails Cops 2
2023-08-17 10:39:34 +10:00
jibees
132d2e792e
Merge pull request #11406 from openfoodfoundation/dependabot/bundler/timecop-0.9.8
...
chore(deps-dev): bump timecop from 0.9.6 to 0.9.8
2023-08-16 17:07:56 +02:00
dependabot[bot]
21e38c424f
chore(deps): bump newrelic_rpm from 9.3.1 to 9.4.0
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.3.1 to 9.4.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.3.1...9.4.0 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-16 14:41:10 +00:00
jibees
afe05f1932
Merge pull request #11414 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.8
...
chore(deps): bump rails-i18n from 7.0.7 to 7.0.8
2023-08-16 16:40:05 +02:00
dependabot[bot]
33d5e8436f
chore(deps): bump rails-i18n from 7.0.7 to 7.0.8
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.7 to 7.0.8.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.7...v7.0.8 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-16 09:49:57 +00:00
jibees
33fc5bd409
Merge pull request #11409 from dacook/script-update
...
Don't show extra red messages when gems missing
2023-08-16 09:01:20 +02:00
David Cook
9bef8b74f8
Merge pull request #11401 from jibees/some-buu-design-updates
...
🚧 BUU: some design updates + one small code fix
2023-08-16 11:41:33 +10:00
Maikel
fd7b00ac7f
Merge pull request #11323 from mkllnk/dfc-import-context
...
Use known, statically cached DFC context
2023-08-16 11:35:57 +10:00
David Cook
b49de7d49e
Simplify spec
...
What if Zucchini didn't appear at all? Better to test that the two products appear on the same page, in the correct order.
2023-08-16 11:13:54 +10:00
David Cook
412dac7556
Don't show extra red messages when gems missing
...
When a gem is missing, it looks like a big ugly error. But we don't need to see this, because bundle install will run next and tell us which gems its installing.
Bundle check isn't actually necessary because bundle install will handle this, but for some reason it's 300ms slower. So I chose to keep 'check' to help keep this script nice and quick.
2023-08-16 09:56:24 +10:00
David Cook
b320a1d289
Create release tag early for greater clarity
...
This way, it's clearer in the repo what is going to be released, and we don't need to copy/paste commit IDs.
([skip ci] because this branch only touches .md file)
2023-08-15 21:47:32 +10:00
David Cook
1cd87c170b
Use new staging deployment method
2023-08-15 21:35:12 +10:00
David Cook
8b9d483227
Add more detailed notes for current process
2023-08-15 21:35:10 +10:00
Matt-Yorkley
70ba027603
Merge pull request #11221 from Matt-Yorkley/product-shipping-category
...
[Product Refactor] Shipping Category
2023-08-15 11:12:56 +01:00
dependabot[bot]
cd5c7e8fc7
chore(deps-dev): bump timecop from 0.9.6 to 0.9.8
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.6 to 0.9.8.
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.6...v0.9.8 )
---
updated-dependencies:
- dependency-name: timecop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-15 09:18:16 +00:00
David Cook
f4a6bec25d
Code fix
...
Cache result.
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
200550588a
Be as clause as possible from native <select />
...
Still need to wrap/ellipsis selected item...
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
0c11ea5868
Use tom-select to have a designed dropdown
...
Not sure this is the best solution, since it's not exactly the right usage of tom-select
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
6fe069608c
Re-adjust tom-select to match admin v3 style
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
223d350b43
Use grid instead of flex in order to be more fixed and less flexible ;)
2023-08-15 08:36:50 +02:00
Jean-Baptiste Bellet
2814368670
Adjust inside container to content without any padding
2023-08-15 08:36:50 +02:00
David Cook
1155bd42ea
Reflex test to reveal collation sorting varies on different OS...
...
https://dba.stackexchange.com/questions/106964/why-is-my-postgresql-order-by-case-insensitive
Uncommented, the spec fails on macOS (BSD).. but succeeds in Ubuntu (Linux). Weird.
2023-08-15 08:36:22 +02:00
David Cook
0f086df12b
Setup StimulusReflex testing [add gem]
...
Surprisingly, the StimulusReflex framework [doesn't have many resources for testing](https://docs.stimulusreflex.com/appendices/testing.html ), but thankfully someone's made a gem.
2023-08-15 08:36:22 +02:00
David Cook
e816228959
Sort products by name in ascending order
...
The order is specified above in fetch_products. I'm guessing this line was unintentional?
Original requirment doesn't say ascending but I think it's safe to assume (issue#10694).
2023-08-15 08:36:22 +02:00
David Cook
6dbfb36e52
Spec: use url helpers
...
To be consistent with other specs.
2023-08-15 08:36:22 +02:00
David Cook
9a3820db4f
Tidy up spec
...
Although 'describe' and 'context' are the same simple constructs to label groups of examples, to humans they mean:
* Describe a particular domain of functionality
* Context means a different environment, IE something has been set up differently (generally with before and/or let blocks)
Also the default 'before' is :each, so we don't need to specify it.
2023-08-15 08:36:22 +02:00
David Cook
757ba27908
Optimise spec: only create objects when needed
...
Moving the 'clear filters' and 'no results' tests up into the first context.
2023-08-15 08:36:22 +02:00
David Cook
2a4d5af552
Remove redundant test
...
This is already covered in the following test.
2023-08-15 08:36:21 +02:00
David Cook
8949f1dc2e
Convert route to resource
...
I don't know why the route helper now has "index" in the name.
2023-08-15 08:36:21 +02:00
jibees
364ae5c0c6
Merge pull request #11404 from rioug/11402-invoice-data-generator-fix-flacky-test
...
Invoice data generator, fix flaky test
2023-08-15 08:34:53 +02:00
Gaetan Craig-Riou
5a2155aeb7
Use the same sorting when choosing a line item to update
...
The presenter uses order.sorted_line_items, so use the same method
when picking up the line item to update.
2023-08-15 11:33:02 +10:00
David Cook
2196cd5be8
Merge pull request #11381 from openfoodfoundation/release_v4.4.7
...
Update translations for release v4.4.7
2023-08-15 10:21:34 +10:00
David Cook
8b666c67d6
Fix typo
...
🤦 Always, always preview changes before committing.
2023-08-15 09:54:42 +10:00
David Cook
54328d7b98
Mention browser limitations
2023-08-15 09:53:39 +10:00
Matt-Yorkley
75f246109f
Fix assignment of default shipping category in variant new/edit pages
2023-08-14 21:02:48 +01:00
Matt-Yorkley
811a8cde7f
Use optional: false instead of validates: presence
2023-08-14 21:02:48 +01:00
Matt-Yorkley
97d9aadb69
Update specs
2023-08-14 21:02:48 +01:00
Matt-Yorkley
dea2adc3d6
Update EntryValidator
2023-08-14 21:02:48 +01:00
Matt-Yorkley
42d04b6581
Update OrderAvailableShippingMethods service
2023-08-14 21:02:47 +01:00
Matt-Yorkley
a712eac333
Update shipping_category in /lib and /engines
2023-08-14 21:02:47 +01:00
Matt-Yorkley
5e0e60dfd6
Update reports
2023-08-14 21:02:47 +01:00
Matt-Yorkley
724c08c94d
Set default shipping_category if absent
2023-08-14 21:02:47 +01:00
Matt-Yorkley
c18c525d9f
Save shipping category selection to new variant when creating a new product
2023-08-14 21:02:47 +01:00
Matt-Yorkley
e3c488306c
Migrate data for shipping_category_id
2023-08-14 21:02:47 +01:00
Matt-Yorkley
eefc356472
Update shipping_category usage in admin pages
2023-08-14 21:02:47 +01:00
Matt-Yorkley
0c634cf04f
Update shipping_category permitted attributes
2023-08-14 21:02:47 +01:00
Matt-Yorkley
57d6fa006c
Update shipping_category association in models
2023-08-14 21:02:47 +01:00
Matt-Yorkley
e2caebc374
Add shipping_category to variants table
2023-08-14 21:00:02 +01:00
Neal Chambers
ec49065739
Reword image_exists? to use Rails.public_path
2023-08-14 17:29:11 +09:00
Neal Chambers
e5740a82bd
Safely autocorrect Rails/StripHeredoc
...
Inspecting 1484 files
........................................................................................................................................................................................................................................................C.........................................................................................................................................CC...........................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/content_configuration.rb:74:48: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
preference :footer_links_md, :text, default: <<-EOS.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
app/queries/customers_with_balance.rb:23:5: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-SQL.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
app/queries/outstanding_balance.rb:32:5: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-SQL.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:71:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:84:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:96:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:109:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:119:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:135:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:151:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:161:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:168:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:182:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:192:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:208:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:218:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:228:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:235:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:253:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:274:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:289:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:310:13: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:369:15: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
<<-JOIN_STRING.strip_heredoc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/truncate_data.rake:35:17: C: [Corrected] Rails/StripHeredoc: Use squiggly heredoc (<<~) instead of strip_heredoc.
message = <<-MSG.strip_heredoc
^^^^^^^^^^^^^^^^^^^^
lib/tasks/data/truncate_data.rake:36:1: C: [Corrected] Layout/HeredocIndentation: Use 2 spaces for indentation in a heredoc.
\n ...
^^^^^^^^
1484 files inspected, 25 offenses detected, 25 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
94f1b89a9f
Safely autocorrect Rails/RootPublicPath
...
Inspecting 1484 files
.............................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................C..........C..........................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................C...................C.............................................................C.C.......C....................
Offenses:
app/controllers/concerns/request_timeouts.rb:19:22: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
file: Rails.root.join("public/500.html"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/controller_helpers/common.rb:45:30: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
file: Rails.root.join("public/404.html"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/product_images_controller_spec.rb:13:22: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:pdf_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/terms_and_conditions_controller_spec.rb:15:31: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:terms_file_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/terms_of_service_file_spec.rb:6:25: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:pdf) { File.open(Rails.root.join("public/Terms-of-service.pdf")) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_product_update_spec.rb:907:37: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
attach_file 'image-upload', Rails.root.join("public/500.jpg"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprises/terms_and_conditions_spec.rb:27:30: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:original_terms) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprises/terms_and_conditions_spec.rb:28:29: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:updated_terms) { Rails.root.join("public/Terms-of-ServiceUK.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/checkout_spec.rb:94:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/Terms-of-service.pdf"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/embedded_groups_spec.rb:18:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/embedded-group-preview.html")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/embedded_groups_spec.rb:26:9: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
Rails.root.join("public/embedded-group-preview.html")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/split_checkout_spec.rb:986:35: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:system_terms_path) { Rails.root.join("public/Terms-of-service.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/split_checkout_spec.rb:987:33: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
let(:shop_terms_path) { Rails.root.join("public/Terms-of-ServiceUK.pdf") }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 13 offenses detected, 13 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
b60fd6b572
Safely autocorrect Rails/I18nLazyLookup
...
Inspecting 1484 files
.......................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/admin/proxy_orders_controller.rb:16:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers.
render json: { errors: [t('admin.proxy_orders.cancel.could_not_cancel_the_order')] },
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/proxy_orders_controller.rb:25:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers.
render json: { errors: [t('admin.proxy_orders.resume.could_not_resume_the_order')] },
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 2 offenses detected, 2 offenses corrected
2023-08-14 17:29:11 +09:00
Neal Chambers
aaf2181768
Safely autocorrect Rails/FilePath
...
Inspecting 1484 files
.............................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C....................C.....................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................C...........................................................................................................................................................
Offenses:
app/models/product_import/product_importer.rb:290:35: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
return unless @file.path == Rails.root.join('tmp', 'product_import').to_s
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:5: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH)}/translations.js"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:5: C: [Correctable] Style/RedundantInterpolation: Prefer to_s over string interpolation.
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH, 'translations.js')}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/karma.rake:42:59: C: [Corrected] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
"#{Rails.root.join(I18n::JS::DEFAULT_EXPORT_DIR_PATH, "translations.js")}"
^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:25: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
config.fixture_path = "#{::Rails.root}/spec/fixtures"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:25: C: [Correctable] Style/RedundantInterpolation: Prefer to_s over string interpolation.
config.fixture_path = "#{Rails.root.join('spec/fixtures')}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/base_spec_helper.rb:58:44: C: [Corrected] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
config.fixture_path = "#{Rails.root.join("spec/fixtures")}"
^^^^^^^^^^^^^^^
spec/models/content_configuration_spec.rb:15:19: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').to_s.
File.exist?(File.join(Rails.root, 'public', default_url))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/content_configuration_spec.rb:15:19: C: [Corrected] Rails/RootPublicPath: Use Rails.public_path.
File.exist?(Rails.root.join('public', default_url).to_s)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/downloads_helper.rb:7:5: C: [Corrected] Rails/FilePath: Prefer Rails.root.join('path/to').
Rails.root.join("tmp", "capybara")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 files inspected, 10 offenses detected, 8 offenses corrected, 2 more offenses can be corrected with `rubocop -A`
2023-08-14 17:29:11 +09:00
Neal Chambers
c36728625d
Regenerate Rubocop's TODO file
2023-08-14 17:29:08 +09:00
Maikel Linke
91e4fb18ed
Use input labels in Voucher system spec
...
It's more robust, and closer to what the user sees and does. It's also
verifying that the labels are correctly connected to the inputs.
2023-08-14 12:46:13 +10:00
Maikel Linke
ba53f31309
Use new hash syntax in Voucher spec
2023-08-14 12:40:54 +10:00
Maikel Linke
160cdc7f8e
Clarify Voucher request spec not a controller spec
2023-08-14 12:25:56 +10:00
Maikel Linke
4b0e910dff
Simplify default values in Voucher form
2023-08-14 12:23:00 +10:00
Maikel Linke
efe2dfff8e
Let Rails handle Voucher type building
2023-08-14 11:51:34 +10:00
Maikel Linke
4d5e1ffb3b
Simplify VouchersController with single param name
...
The Voucher form now deals with a generic Voucher instead of a subclass
which makes the naming easier and is less confusing when changing types.
2023-08-14 11:39:59 +10:00
Mohamed ABDELLANI
8370d7ce83
Update app/views/spree/admin/shared/_order_links.html.haml
...
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-08-13 13:12:56 +01:00
Dusan Orlovic
b360e2ffaa
Add Google map region parameter
2023-08-13 08:56:04 +02:00
Konrad
99daab07b7
Merge pull request #11297 from mkllnk/require-belongs-to--part2
...
Require belongs_to associations by default
2023-08-12 17:09:03 +02:00
Matt-Yorkley
613802f477
Update stage.yml
2023-08-11 13:50:34 +01:00
Matt-Yorkley
99907dc3a6
Update stage.yml
2023-08-11 13:48:31 +01:00
Matt-Yorkley
7084d0cb40
Update stage.yml
2023-08-11 13:44:38 +01:00
Matt-Yorkley
e33b0af6fe
Update stage.yml
2023-08-11 13:42:14 +01:00
Matt-Yorkley
6dfeecead1
Update stage.yml
2023-08-11 13:30:35 +01:00
Rachel Arnould
5afe45d922
Merge pull request #11382 from jibees/11273-buu-remove-new_products_page-feature-toggle
...
🔧 Remove `new_products_page` and all associated controllers/components/...
2023-08-11 11:43:49 +02:00
David Cook
5a96f285c1
Update release title
2023-08-11 16:24:11 +10:00
David Cook
1a58914e43
Categories release notes by dependencies label
...
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
2023-08-11 16:13:22 +10:00
Gaetan Craig-Riou
06f986ff52
Allow for creating a voucher with either flat or percentage rate
...
In the scenario when you get an error when trying to create a
percentage voucher, on the subsequent try we would be dealing with
a "percentage rate voucher". The code now handle any type of voucher
2023-08-11 16:09:48 +10:00
Gaetan Craig-Riou
61e6d55872
Merge pull request #10821 from rioug/10727-vouchers-percentage-rate
...
[Vouchers] Percentage rate
2023-08-11 16:06:09 +10:00
Gaetan Craig-Riou
a2def2424c
Add a comment around the use of safe_constantize
...
It triggers a Brakeman error that can be safely ignored
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
9c9a6234e1
Per review, clean up voucher specs
...
Add explicit 'order.item_total' to make specs more readable
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
054eac0822
Use a better describe
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
e6b53c0a42
Per review , Simplify creation of Voucher
...
We now check against known type to instanciate the correct voucher
instead of using a case
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
3f63cfbc27
Fix Rubocop warning
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
e8b374d0f2
Remove left over comment
2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou
2828bd098d
Refactor VoucherAdjustment service
...
We are taking advantage of having a FlatRate and a PercentageRate
model to simplify the code a little
2023-08-11 15:41:34 +10:00
Gaetan Craig-Riou
29a38467d2
Fix admin pages to work with refactored vouchers
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
46e04ca7ee
Refactor voucher: 3 percentage rate voucher
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
def594ab81
Refactor voucher: 2 FlatRate voucher
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
204f3933d0
Refactor voucher: 1 base voucher class
...
Refactor voucher to use a single table inheritance. It will simplify the
code and remove a bunch of conditional
2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou
959e2308dd
Add system specs for percentage based voucher
...
Similar to tax included in price scenario, adds a test for percentage
based voucher to check the adjustments are recalculated when needed.
Plus fix tax incluced in price specs to use new factory
2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou
70bd714369
Finish calculation for percentage voucher
...
Add calculation when tax is not included in price
2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou
cdb33aa0d0
Add calculation for percentage voucher
...
It include calculation for order with taxes included in the price
2023-08-11 14:30:48 +10:00
David Cook
e536393f02
Merge pull request #11389 from mkllnk/session_store
...
Remove ignored session store config
2023-08-11 14:27:44 +10:00
Gaetan Craig-Riou
cc9069e9c6
Add voucher type to admin screen
...
Plus specs
2023-08-11 14:19:26 +10:00
Gaetan Craig-Riou
619285ad4a
Add voucher_type to voucher
...
And update related specs
voucher_type doesn't do anything for now.
2023-08-11 14:19:25 +10:00
Gaetan Craig-Riou
1be8daaf86
Add specs to cover re calculation
...
It is important that the calculated voucher adjustments don't change
if they are recalculated and it is equally important that they are
updated if the order has changed
2023-08-11 14:19:25 +10:00
David Cook
6ee6ad2b86
[fixup] Remove unnecessary template name
...
This was left over after trying different things to get this working.
2023-08-11 14:14:32 +10:00
Maikel
fc8e39987a
Merge pull request #11385 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.132.1
...
chore(deps): bump aws-sdk-s3 from 1.132.0 to 1.132.1
2023-08-11 11:39:14 +10:00
Maikel Linke
7fe74e811e
Remove ignored session store config
...
We set the session store in an initializer and therefore the development
config was overridden without having any effect.
2023-08-11 10:27:37 +10:00
Maikel Linke
a34a351cee
Stabilise flaky spec with deterministic row order
2023-08-11 10:14:47 +10:00
Maikel
146b09dc57
Spec EnterpriseFee tax_category association
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-11 10:14:47 +10:00
Maikel Linke
efbf1d6b8f
Stabilise flaky assertion on PDF text
...
The PDF reader can't always place text elements in the right place. So
something that should be in one line can be in multiple lines and those
lines can be in a different order. I'm asserting the moving parts
separately as done in other places of this spec.
2023-08-11 10:14:47 +10:00
Maikel Linke
1b6eeb0928
Reduce line length of PaymentMethod class
...
Rubocop was complaining. So I found code that could be simplified and
specced it before refactoring.
2023-08-11 10:14:47 +10:00
Maikel Linke
faeb8ae8f8
Fix Exchange clone tagging
...
The validation of ActsAsTaggableOn::Taggable failed when trying to copy
tag ids during cloning. But I found that it's totally unnecessary
because `Exchange.dup` copies the `tag_list` attribute already and it
gets saved correctly. There's an existing spec for this.
2023-08-11 10:14:47 +10:00
Maikel Linke
4a13576f78
Remove now superfluous belongs_to default declaration
2023-08-11 10:14:47 +10:00
Maikel Linke
e6c679cb34
Apply belongs_to_required_by_default to all models
...
Unless they state otherwise.
The new standard also changes the default behaviour of the Shoulda
matcher in Rspec. It now defaults to asserting that an association is
required. That needed some spec updates.
In one case, Spree::Product, I also had to update the model because the
presence validation was somehow not recognised by the Shoulda matcher.
The error message may change slightly but the outcome should be the
same.
2023-08-11 10:14:47 +10:00
Maikel Linke
8ef6966891
Declare old belongs_to default on remaining models
...
It would take ages to go through all files now and assess all belongs_to
associations. So I just declare the old default and then we can move on
and apply the new default for the application while these classes still
use the old one. All new models will then use the new default which is
the goal of this excercise and we can refactor old classes when we touch
them anyway.
2023-08-11 10:14:43 +10:00
Maikel Linke
252f809463
Require CustomTab.belongs_to by default
2023-08-11 10:14:15 +10:00
Maikel Linke
070d1e722e
Require EnterpriseRole.belongs_to by default
2023-08-11 10:14:14 +10:00
Maikel Linke
4dd2955400
Require EnterpriseRelationshipPermission.belongs_to by default
...
I had to change some specs to keep them simple but I don't think
anything is broken. In one case, it would have needed a lot more setup
to make the spec work. But in production, the permissions are never used
with ModelSet, for example.
2023-08-11 10:13:48 +10:00
Maikel Linke
cb494b84f2
Require EnterpriseRelationship.belongs_to by default
2023-08-11 10:13:29 +10:00
Maikel Linke
4b630f187b
Require EnterpriseGroup.belongs_to by default
2023-08-11 10:13:10 +10:00
Maikel Linke
13b2f37884
Require EnterpriseFee.belongs_to by default
2023-08-11 10:13:09 +10:00
Maikel Linke
87ccfc94ef
Require Enterprise.belongs_to by default
...
And remove a duplicate spec.
2023-08-11 10:13:09 +10:00
Konrad
60212f92c3
Merge pull request #11270 from rioug/9553-removing-cutomer-tag-when-search-for-tag
...
Fix removing customer tag when using search bar for said tag
2023-08-11 00:11:55 +02:00
Konrad
c3414143e6
Merge pull request #11222 from Matt-Yorkley/checkout-controller
...
Reduce controller size
2023-08-10 23:28:57 +02:00
Konrad
f59e681826
Merge pull request #11259 from cillian/single-line-voucher-code
...
Don't allow multi-line voucher codes
2023-08-10 23:09:55 +02:00
Jean-Baptiste Bellet
5b4b37032c
Add translation for invalid URL in white label context
2023-08-10 15:22:35 +02:00
Matt-Yorkley
df077caafa
Merge pull request #11375 from Matt-Yorkley/drop-unused-tables
...
Drop unused tables
2023-08-10 12:28:14 +01:00
Matt-Yorkley
f19d66f4d6
Drop unused tables
2023-08-10 12:27:31 +01:00
Matt-Yorkley
688b411e97
Merge pull request #11374 from Matt-Yorkley/drop-variant-master-column
...
Drop :is_master column from variants table
2023-08-10 12:25:59 +01:00
Matt-Yorkley
b82f368bec
Drop :is_master column from variants table
2023-08-10 12:25:18 +01:00
Matt-Yorkley
128d5c29bd
Merge pull request #11373 from Matt-Yorkley/drop-options-tables
...
Drop option_types and option_values tables
2023-08-10 12:21:39 +01:00
jibees
95612a8cb6
Merge pull request #11384 from openfoodfoundation/dependabot/bundler/rails-7.0.7
...
chore(deps): bump rails from 7.0.6 to 7.0.7
2023-08-10 12:13:07 +02:00
dependabot[bot]
4bbd9e9d49
chore(deps): bump aws-sdk-s3 from 1.132.0 to 1.132.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.132.0 to 1.132.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 09:55:40 +00:00
dependabot[bot]
f08a7ea254
chore(deps): bump rails from 7.0.6 to 7.0.7
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 09:53:38 +00:00
Jean-Baptiste Bellet
3b68674896
Remove new_products_page and all associated controller/components/
...
new_products_page` is dead, long live `admin_style_v3` !
2023-08-10 10:02:45 +02:00
jibees
f58fedfc86
Merge pull request #11376 from mkllnk/flaky-voucher-spec
...
Stabilise flaky checkout spec with voucher
2023-08-10 09:10:59 +02:00
David Cook
b58d15b5ed
Update all locales with the latest Transifex translations
2023-08-10 16:54:26 +10:00
David Cook
f64a24a5bb
Respond to all formats with html
2023-08-10 16:14:08 +10:00
David Cook
c191158a97
Use the newer syntax
2023-08-10 14:52:04 +10:00
Matt-Yorkley
5c0329ce17
Drop option_types and option_values tables
2023-08-10 11:52:10 +10:00
Maikel
8db8d6de8d
Merge pull request #11372 from Matt-Yorkley/remove-variant-position
...
Remove unused variant :position attribute
2023-08-10 11:48:55 +10:00
Maikel
507803c2dc
Merge pull request #11371 from jibees/8443-missing-translation-passwords-not-matching-or-too-short
...
Account creation: translate some messages around password creation
2023-08-10 11:40:56 +10:00
Maikel Linke
04bba2adf1
Stabilise flaky checkout spec with voucher
...
While applying a voucher the spec tried to proceed the checkout before
the voucher update completed rendering. It failed when the machine was
slow.
With rspec-slow-repeate I got 100% fail rate before and 100% pass after
this change.
2023-08-10 10:05:01 +10:00
Maikel
926c8aed94
Merge pull request #11354 from abdellani/fix-rename-invoice-generate-update-button
...
rename 'new invoice' button to 'create or update invoice'
2023-08-10 09:59:11 +10:00
Mohamed ABDELLANI
620dd70dd7
rename 'new invoice' button to 'create or update invoice'
2023-08-10 09:35:13 +10:00
Matt-Yorkley
a33b6e0ec9
Update variant sorting
2023-08-09 18:30:56 +01:00
Matt-Yorkley
e65efe0f85
Remove unused variant :position attribute
2023-08-09 18:24:46 +01:00
Rachel Arnould
4505beff98
Merge pull request #11327 from bouaik/fix-display-invoice-tab-for-completed-resumed-canceled-only
...
Fix display invoice tab for completed, resumed and canceled orders only
2023-08-09 18:37:02 +02:00
Jean-Baptiste Bellet
1f5dc1f864
Add ActiveRecords messages for translation in account creation
2023-08-09 16:58:08 +02:00
Rachel Arnould
2b108dfeee
Merge pull request #11116 from abdellani/fix-show-date-only-on-invoices-list
...
render date without time on invoices list
2023-08-09 14:33:40 +02:00
jibees
249dea56f3
Merge pull request #11366 from openfoodfoundation/dependabot/bundler/rubocop-1.56.0
...
chore(deps-dev): bump rubocop from 1.55.1 to 1.56.0
2023-08-09 11:35:25 +02:00
dependabot[bot]
467a63cf12
chore(deps-dev): bump rubocop from 1.55.1 to 1.56.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.55.1 to 1.56.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.55.1...v1.56.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-09 09:20:52 +00:00
Konrad
89d8fa0306
Merge pull request #11346 from Matt-Yorkley/remove-multiple-taxons
...
[Product Refactor] Remove multiple taxons
2023-08-09 11:19:11 +02:00
Maikel
655fdf3fff
Merge pull request #11353 from abdellani/remove-duplicated-keys-in-en-yml
...
Remove duplicated keys in en yml
2023-08-09 13:42:01 +10:00
Maikel
d149f71199
Merge pull request #11365 from dacook/setup-reduce-output
...
Setup script tweaks
2023-08-09 11:45:47 +10:00
Maikel
b50fa216eb
Merge pull request #11117 from rioug/10857-voucher-error-moving-between-summary-and-cart-take2
...
[vouchers] error moving between summary and cart pages
2023-08-09 11:14:52 +10:00
David Cook
91c874737a
Combine rake tasks to save time
...
The log:clear task seems to take quite a bit of time. At least we can speed up a bit by only booting up Rails once.
I'm more likely to run the script if it's quick ;)
2023-08-09 10:28:41 +10:00
David Cook
9d79c7cda7
Reduce bundler install output
...
bundle install always shows a very long list of all gems. But we really only want to know about the new gems being installed. Thankfully there's an option for that.
2023-08-09 10:26:11 +10:00
Matt-Yorkley
6fee1d2dde
Use dependent: :restrict_with_error on Taxon/Product association
2023-08-08 11:36:31 +01:00
David Cook
1706b8b4bc
fixup: Drop spree_products_taxons join table
...
Make it reversible for dev or staging.
2023-08-08 11:36:31 +01:00
David Cook
a9ca07f4fb
fixup Update specs
...
Delete empty describe block
2023-08-08 11:36:31 +01:00
Matt-Yorkley
321047d663
Update specs
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3d83ca01f7
Drop spree_products_taxons join table
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3655f3019d
Update products and inventory report
2023-08-08 11:36:31 +01:00
Matt-Yorkley
38d9f4f1da
Update product v3 table
2023-08-08 11:36:31 +01:00
Matt-Yorkley
e4a49f5d02
Update product duplication
2023-08-08 11:36:31 +01:00
Matt-Yorkley
820f9530b2
Update product serializer
2023-08-08 11:36:31 +01:00
Matt-Yorkley
8d01e1f024
Update taxon specs
2023-08-08 11:36:31 +01:00
Matt-Yorkley
33d40ed750
Update association
2023-08-08 11:36:31 +01:00
Matt-Yorkley
cffd7073e2
Delete unused method
2023-08-08 11:36:31 +01:00
Matt-Yorkley
3898af2c37
Update factories and tests
2023-08-08 11:36:31 +01:00
Matt-Yorkley
a93809b75f
Remove associated abilities
2023-08-08 11:36:31 +01:00
Matt-Yorkley
a69ab2ef71
Remove multiple taxons on products functionality
2023-08-08 11:36:31 +01:00
Mohamed ABDELLANI
982f30399f
merge :errors values under one key
2023-08-08 10:34:11 +01:00
Mohamed ABDELLANI
024a01ba94
remove duplicated keys on en.yml
2023-08-08 10:34:05 +01:00
Mohamed ABDELLANI
70b61eb481
remove bulk invoice service
2023-08-08 08:41:33 +01:00
Mohamed ABDELLANI
fc01ffc509
remove InvoicesController#create
2023-08-08 08:38:32 +01:00
Gaetan Craig-Riou
fe6075319e
Merge pull request #11344 from openfoodfoundation/dependabot/bundler/mime-types-3.5.0
...
chore(deps): bump mime-types from 3.4.1 to 3.5.0
2023-08-08 16:43:47 +10:00
Gaetan Craig-Riou
bb375ccee5
Merge pull request #11343 from openfoodfoundation/dependabot/npm_and_yarn/stimulus-3.2.2
...
chore(deps): bump stimulus from 3.2.1 to 3.2.2
2023-08-08 16:41:45 +10:00
Mohamed ABDELLANI
c185a47592
render the confirm model on the same component that includes the action on the order.
2023-08-08 07:32:20 +01:00
Gaetan Craig-Riou
6f10907555
Fix rubocop warnings
2023-08-08 15:37:05 +10:00
Gaetan Craig-Riou
a64023c3df
Apply review suggestion, simplify code slightly
2023-08-08 15:29:23 +10:00
Gaetan Craig-Riou
4e468c81f9
Handle updating customer attribute when directive is destroyed
...
Handle any customer attribute not just tags
2023-08-08 15:29:22 +10:00
Gaetan Craig-Riou
41dbad629b
Add system spec to cover deleting data when filtering
...
covers tag scenario and code scenario
2023-08-08 15:29:22 +10:00
Gaetan Craig-Riou
f96bd51344
Rework form to allow displaying the save bar when no result
...
When filtering by a tag, and then removing the tag on the filtered
customers, it let us show the save bar once the last customer has been
removed from the filtered list.
2023-08-08 15:28:13 +10:00
Gaetan Craig-Riou
dba8809057
Handle deleting tag when directive destroyed
2023-08-08 15:28:13 +10:00
dependabot[bot]
df76710ae8
chore(deps): bump mime-types from 3.4.1 to 3.5.0
...
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types ) from 3.4.1 to 3.5.0.
- [Changelog](https://github.com/mime-types/ruby-mime-types/blob/main/History.md )
- [Commits](https://github.com/mime-types/ruby-mime-types/compare/v3.4.1...v3.5.0 )
---
updated-dependencies:
- dependency-name: mime-types
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-07 09:56:54 +00:00
dependabot[bot]
1af30bdff4
chore(deps): bump stimulus from 3.2.1 to 3.2.2
...
Bumps [stimulus](https://github.com/stimulusjs/stimulus ) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/stimulusjs/stimulus/releases )
- [Changelog](https://github.com/hotwired/stimulus/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusjs/stimulus/compare/v3.2.1...v3.2.2 )
---
updated-dependencies:
- dependency-name: stimulus
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-07 09:52:05 +00:00
Gaetan Craig-Riou
b731e8319b
Merge pull request #11339 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-2.0.4
...
chore(deps): bump js-big-decimal from 2.0.1 to 2.0.4
2023-08-07 11:46:10 +10:00
Gaetan Craig-Riou
430aa685ce
Merge pull request #11321 from mkllnk/dev-user-valid
...
Skip online domain validation of dev user email
2023-08-07 11:27:31 +10:00
Maikel
ccc5975517
Merge pull request #11320 from dacook/css-cleanup
...
SCSS cleanup
2023-08-07 10:23:49 +10:00
Maikel
4b0bffa095
Merge pull request #11256 from rioug/10997-add-new-relic-gem
...
Add new relic gem
2023-08-07 10:17:59 +10:00
Gaetan Craig-Riou
0103942dcb
Disable new relic agent by default
...
It can be enable as needed by setting NEW_RELIC_AGENT_ENABLED env
variable to true and setting a license key
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
de52ff4abf
Move New Relic out of production, staging group
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
5793cb14ee
Add generated configuration
2023-08-07 09:37:36 +10:00
Gaetan Craig-Riou
c3d26b1900
Add the New Relic gem
2023-08-07 09:37:36 +10:00
Rachel Arnould
1b1279aa56
Merge pull request #11192 from abdellani/bulk-invoice-printing
...
fix Bulk invoice printing/sending
2023-08-04 12:02:43 +02:00
dependabot[bot]
760d237288
chore(deps): bump js-big-decimal from 2.0.1 to 2.0.4
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 2.0.1 to 2.0.4.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v2.0.1...v2.0.4 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-04 09:24:25 +00:00
Cillian O'Ruanaidh
d026438edc
Revert "Validate voucher code length doesn't exceed the database column length i.e. 255 characters"
...
This reverts commit 0d0df82522 .
2023-08-04 10:24:21 +01:00
Cillian O'Ruanaidh
9eba266efc
Strip leading and trailing whitespace from code on assignment instead of before validation
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-08-04 10:15:22 +01:00
Cillian O'Ruanaidh
ab0d899a17
Revert "Validate voucher code doesn't contain new line characters"
...
This reverts commit 0c0b85f4c4 .
2023-08-04 10:04:14 +01:00
Gaetan Craig-Riou
6ed35f4cc1
Per review, delete only incomplete payments
...
Use destroy_all so we don't have to manually delete the payment fees
adjustment
2023-08-04 17:03:31 +10:00
Maikel Linke
ad37c401e5
Update translations
2023-08-04 13:48:29 +10:00
David Cook
42230c07b2
Merge pull request #11312 from macanudo527/fix_rubocop_5
...
Fix autocorrect Rails Cops
2023-08-04 11:13:52 +10:00
bouaik
41d649404f
make suggested changes
2023-08-04 00:55:35 +01:00
Maikel
2b18effe6d
Merge pull request #11322 from macanudo527/fix_remaining_line_length
...
Fix remaining Layout/LineLength Rubocop Errors
2023-08-04 09:34:00 +10:00
Maikel
64398066ce
Merge pull request #11324 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-2.0.1
...
chore(deps): bump js-big-decimal from 1.4.1 to 2.0.1
2023-08-04 09:20:30 +10:00
Matt-Yorkley
dd9bdd9c0e
Move address params handling into Checkout::Params
2023-08-04 08:43:15 +10:00
Matt-Yorkley
13a7c19a06
Extract checkout step(s) validation to a service
2023-08-04 08:43:15 +10:00
Matt-Yorkley
82b8bb74a1
Remove #before_save_hook method and clarify it's intention
2023-08-04 08:43:15 +10:00
Matt-Yorkley
f3899ee251
Extract some related methods to CheckoutSteps concern
2023-08-04 08:43:15 +10:00
Matt-Yorkley
d1bcdde49f
Simplify split checkout errors
2023-08-04 08:43:15 +10:00
Filipe
69dfd53658
Merge pull request #11254 from rioug/11130-add-product-filter-order-report
...
11130 add product filter order report
2023-08-03 16:08:44 +01:00
Filipe
5c67d522b8
Merge pull request #11209 from openfoodfoundation/dependabot/npm_and_yarn/stimulus_reflex-3.5.0-rc3
...
chore(deps): bump stimulus_reflex from 3.5.0-rc2 to 3.5.0-rc3 + cable_ready from 5.0.0.rc2 to 5.0.1
2023-08-03 16:01:40 +01:00
Mohamed ABDELLANI
6c53f3b8b0
move pretty_date helper into invoice presenter
2023-08-03 15:12:02 +01:00
Mohamed ABDELLANI
c21ffd338b
fix only date is expected on the invoices list table.
...
time is not supposed to be rendered on the invoices list table (only date)
2023-08-03 15:12:02 +01:00
Mohamed ABDELLANI
5358802ab5
replace Presenter#invoice_date with a delagator
2023-08-03 15:11:58 +01:00
Mohamed ABDELLANI
9a3aef525a
add distributor's phone number to list of attributes to serialize
2023-08-03 15:06:04 +01:00
Mohamed ABDELLANI
d044959cec
fix date formatting
...
implement a new helper `pretty_date`
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
1a8c0f18b7
order invoices by "created_at desc" on the default scope
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
8fecc9db4b
render date without time on invoices list
...
+ sort invoices in the reverse order of the creation time
2023-08-03 14:55:26 +01:00
Mohamed ABDELLANI
24b1918df5
implment blank? on Address presenter
...
To keep the same method calls that are used on the legacy invoice template. I needed to redefine blank? on the address presenter.
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
4449484402
replace double with instance_double
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
2fb112aecd
import BulkInvoiceJob#perform spec
...
1. remove the mocks
2. test the content of the generated pdf
3. remove the test of private methods
2023-08-03 14:53:40 +01:00
Mohamed ABDELLANI
c89c8a69bc
optimize OrderMailer#invoice_email spec
...
Check if the email was sent without raising an error
Check if the email has an attached pdf
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
9b80676d7d
update the logic to send invoice
...
When the invoices feature is enabled, for every order, we check if
1. a new invoice must be generated
2. or, the latest invoice needs to be updated
the invoice rendrer input depends on the invoices flag.
if the feature is enabled, the input is supposed to be an invoice presenter
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
7daa4d3a63
simplify filtering condition to select only invoiceable orders on OrdersReflex
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
5ae2545918
Update app/jobs/bulk_invoice_job.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
687760046b
update the bulk invoice job to print invoiceable orders
...
the invoices feature is enabled:
1. we filter non-invoiceable order
2. for each invoiceable order, we check if we need to generate a new invoice or update the latest invoice
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
c921250d68
implement Spree::Order#invoiceable?
...
This will be used to filter the orders when running bulk print
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
4f6ab69add
implement OrderInvoiceGenerator service
2023-08-03 14:52:45 +01:00
Mohamed ABDELLANI
f24af3feb0
extract invoice printing logic into a seperated method
2023-08-03 14:52:45 +01:00
bouaik
0c849f08fd
fix tests
2023-08-03 13:04:16 +01:00
bouaik
2c08602664
fix display invoice tab
2023-08-03 11:25:31 +01:00
Filipe
46cb1add63
Merge pull request #11126 from abdellani/show-invoice-number-on-invoices
...
Show invoice number on invoices
2023-08-03 10:48:34 +01:00
Filipe
c0a4bccb3e
Merge pull request #11156 from Matt-Yorkley/product-tax-category
...
[Product Refactor] Tax category
2023-08-03 10:29:40 +01:00
dependabot[bot]
106938ddbf
chore(deps): bump js-big-decimal from 1.4.1 to 2.0.1
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.4.1 to 2.0.1.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.4.1...v2.0.1 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-03 09:19:52 +00:00
Maikel Linke
f96636072e
Use original DFC Connector.export implementation
...
We wanted to use our own context before but now I found a better way for
the connector to cache the context and therfore we can use the original
implementation again.
2023-08-03 16:45:31 +10:00
Maikel Linke
1daed8c29c
Always load our DFC Connector patches
...
We want to use the preloaded context when exporting documents as well.
2023-08-03 16:45:30 +10:00
Maikel Linke
ff359664a9
Use cached DFC context
2023-08-03 16:45:30 +10:00
Neal Chambers
f5f9b80de7
Update .rubocop_todo.yml
2023-08-03 09:49:51 +09:00
Neal Chambers
a4f270bdec
Fix Layout/LineLength
2023-08-03 09:49:47 +09:00
David Cook
32cc776725
Merge pull request #11177 from cyrillefr/Registration_of_an_enterprise_name_already_taken_stops_registration_process
...
Registration of an enterprise name already taken stops registration process
2023-08-03 10:37:47 +10:00
Maikel Linke
c8511ecd0d
Remove superfluous line
...
The `<<` operation saves the association already.
2023-08-03 10:26:59 +10:00
Maikel Linke
6056c59301
Skip online domain validation of dev user email
...
We improved the email address validation to check the domain for
existing DNS entries. But our default user has the example.com domain
which is not resolved by my internet service provider.
I couldn't find a better way to deactivate this one check than
overriding the method in the validator. The code does not affect other
parts of the app unless you run multiple rake tasks in the same command
line with the database setup.
2023-08-03 10:22:00 +10:00
Maikel
76b7a9ea14
Merge pull request #11307 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.5.1
...
chore(deps): bump @floating-ui/dom from 1.4.5 to 1.5.1
2023-08-03 10:04:31 +10:00
David Cook
293e135a45
Move variables to one variables file
...
Note that color-tbl-border is not needed in the new admin_v3 styles.
2023-08-03 09:49:29 +10:00
David Cook
0aa4c144b9
Rename disabled button variable
...
TIL that underscores and dashes are treated the same in SCSS variables.
2023-08-03 09:49:29 +10:00
David Cook
1a02e108a5
Use red colour from the palette
...
It's very similar.
2023-08-03 09:49:29 +10:00
David Cook
9610281ed3
Rename variables
2023-08-03 09:49:29 +10:00
David Cook
b46e6c462d
Rename table border variable
...
There are other vars named brd, but I think border is clearer and doesn't need to be abreviated here.
2023-08-03 09:49:29 +10:00
David Cook
c4a335548a
Rename warning color variable
...
To match the others in the variables file.
Also `warning-orange` was unused.
2023-08-03 09:49:29 +10:00
David Cook
01a9095121
Move some variables to the palette
2023-08-03 09:49:29 +10:00
David Cook
2f801d346d
Prettify some more css files
2023-08-03 09:49:29 +10:00
David Cook
14e07e38d3
Remove depdenency on darkswarm/mixins
2023-08-03 09:49:29 +10:00
David Cook
bf9cd09462
Remove dependence on darkswarm variables
...
There were all sorts of dependencies hiding in there, and it was overwriting some of the admin variables. Better to keep things separate and simple.
I discovered that there was one legitimate reason for importing them though: for styling the trix editor. I can't think of a good way to safely import them without affecting the other variables, so I just hardcoded the colours for now.
2023-08-03 09:47:44 +10:00
David Cook
9207724779
Copy legacy variables
...
I'd like to go through and remove these, but it will have to happen another day.
2023-08-03 09:47:44 +10:00
David Cook
828df3ed82
Consistently use red in forms
...
Errors and required fields now use the colour from the palette. The error messages in the old design are a bit darker now, but I think it's clearer. And it makes the new design look way better.
Also snuck in a tiny padding tweak.
2023-08-03 09:47:44 +10:00
Maikel
9c6e0418cb
Merge pull request #11317 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.5
...
chore(deps-dev): bump knapsack_pro from 5.3.4 to 5.3.5
2023-08-03 08:18:52 +10:00
Filipe
f816d4b2d6
Merge pull request #11235 from jibees/11223-notices-tab-on-shopfront-persisting-after-selecting-an-order-cycle
...
Shopfront: On non-shop tab, when changing OC, switch to shop tab and hides non-shop tab content
2023-08-02 16:02:23 +01:00
Konrad
27e3a65440
Merge pull request #11234 from jibees/10867-vouchers-vouchers-page-is-shown-for-profile-enterprises
...
Show vouchers panel only if enterprise sells products (own or any)
2023-08-02 13:11:29 +02:00
Konrad
44d25dbb6a
Merge pull request #11299 from cillian/order-name-sorting
...
Sort orders by last name, then first name i.e. the same way bulk order management works
2023-08-02 11:30:25 +02:00
Konrad
12f6457ab2
Merge pull request #11302 from bouaik/margin-guest-checkout
...
fix margin in guest checkout
2023-08-02 10:57:12 +02:00
Maikel
b73dfed4e9
Merge pull request #11308 from openfoodfoundation/dependabot/bundler/rubocop-1.55.1
...
chore(deps-dev): bump rubocop from 1.55.0 to 1.55.1
2023-08-02 16:29:36 +10:00
Maikel
7886e25f83
Merge pull request #11303 from macanudo527/fix_rubocop_script
...
Add file limit to Rubocop Autocorrect Script
2023-08-02 14:36:20 +10:00
dependabot[bot]
bff74e9472
chore(deps-dev): bump knapsack_pro from 5.3.4 to 5.3.5
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.4 to 5.3.5.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.4...v5.3.5 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-02 03:17:45 +00:00
David Cook
ff76e3afa1
Merge pull request #11263 from mkllnk/dfc-connector-context
...
Dfc connector context
2023-08-02 13:16:28 +10:00
David Cook
44d1066e5c
Merge pull request #11310 from Matt-Yorkley/image-magick
...
Rescue ImageMagick errors
2023-08-02 10:26:46 +10:00
Neal Chambers
0d2e2fa42c
Add skip for cops that couldn't be autocorrected
2023-08-02 09:11:00 +09:00
Konrad
bc01207fec
Merge pull request #11281 from jibees/11205-white-label-logo-image-not-displaying-correctly-on-mobile
...
White label: Update mobile variant size for white label logo to fit the same ratio
2023-08-02 00:10:14 +02:00
bouaik
5681c45a9e
use classes like logged in checkout
2023-08-01 22:08:56 +01:00
Maikel Linke
bebdaace4b
Prefer plain text in spec expectations
2023-08-01 23:06:26 +02:00
cyrillefr
d4c864a118
Add testing for modal warning that name is already in use
2023-08-01 23:06:26 +02:00
cyrillefr
057754305d
Useless 'end' at end of coffeescript block
2023-08-01 23:06:26 +02:00
cyrillefr
05d610e598
Spec for (re)enabling 'Create Profile' button if not returning promise
2023-08-01 23:06:26 +02:00
cyrillefr
ae1e6032f6
Enable 'Create Profile' button via callback in case of not returning promise
2023-08-01 23:06:26 +02:00
Neal Chambers
f47f6efcd0
Safely autocorrect Rails/DurationArithmetic
...
Inspecting 1481 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.................................................................................................................................................................................................................................................................................C..............C..........................................................C...............................C....C..........CC................................................................
Offenses:
app/services/create_order_cycle.rb:41:24: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
orders_close_at: Time.zone.now + 1.month
^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:7:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now - 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:10:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now + 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_closing_job_spec.rb:13:75: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, automatic_notifications: false, orders_close_at: Time.zone.now - 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_opened_job_spec.rb:7:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, orders_open_at: Time.zone.now - 1.hour)
^^^^^^^^^^^^^^^^^^^^^^
spec/jobs/order_cycle_opened_job_spec.rb:13:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
create(:order_cycle, orders_open_at: Time.zone.now + 1.minute)
^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/permissions/order_spec.rb:26:58: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now - 1.year)
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:21:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week }
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:22:59: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(TermsOfServiceFile).to receive(:updated_at) { Time.zone.now - 2.weeks }
^^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:36:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week }
^^^^^^^^^^^^^^^^^^^^^^
spec/services/terms_of_service_spec.rb:38:45: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
ActiveStorage::Blob.new(created_at: Time.zone.now - 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:647:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now + 1.week,
^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:652:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
completed_at: Time.zone.now + 2.weeks,
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:661:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc3.update!(orders_close_at: Time.zone.now + 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:662:39: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc3.update!(orders_open_at: Time.zone.now + 1.week)
^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:128:18: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc_open_at = Time.zone.now - 2.weeks
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:129:19: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
oc_close_at = Time.zone.now + 2.weeks
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:289:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order2.update!(completed_at: Time.zone.now - 2.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:290:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order3.update!(completed_at: Time.zone.now - 3.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:291:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order4.update!(completed_at: Time.zone.now - 4.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:292:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
order5.update!(completed_at: Time.zone.now - 5.weeks)
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:113:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:completed_at1) { Time.zone.now - 1500.hours } # 1500 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:114:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:completed_at2) { Time.zone.now - 1700.hours } # 1700 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:115:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_start1) { Time.zone.now - 1600.hours } # 1600 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:116:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_start2) { Time.zone.now - 1800.hours } # 1600 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/orders_and_fulfillment_spec.rb:117:30: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let(:datetime_end) { Time.zone.now - 1400.hours } # 1400 hours in the past
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/reports/packing_report_spec.rb:13:26: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a method call.
let!(:open_datetime) { (1.month.ago).strftime("%Y-%m-%d 00:00") }
^^^^^^^^^^^^^
spec/system/admin/reports/packing_report_spec.rb:13:27: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration.
let!(:open_datetime) { (Time.zone.now - 1.month).strftime("%Y-%m-%d 00:00") }
^^^^^^^^^^^^^^^^^^^^^^^
1481 files inspected, 28 offenses detected, 28 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
a263110799
Safely autocorrect Rails/DotSeparatedKeys
...
Inspecting 1481 files
........................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/api/v1/base_controller.rb:72:66: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option.
message = I18n.t(:missing_parameter, param: error.param, scope: :api)
^^^^^^^^^^^
app/controllers/api/v1/base_controller.rb:79:84: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option.
message = I18n.t(:unpermitted_parameters, params: error.params.join(", "), scope: :api)
^^^^^^^^^^^
1481 files inspected, 2 offenses detected, 2 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
44cf2faa1e
Safely autocorrect Rails/ActiveRecordCallbacksOrder
...
Inspecting 1481 files
...........................................................................................................................................................................................................................................................C..C.CC........................................................................C...C..........C..C..................CC........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/customer.rb:32:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy.
before_validation :downcase_email
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:33:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy.
before_validation :empty_code
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/customer.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/customer.rb:49:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_create is supposed to appear before before_destroy.
before_create :associate_user
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:129:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch.
after_create :set_default_contact
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:130:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch.
after_create :relate_to_owners_enterprises
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:133:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_rollback is supposed to appear before after_touch.
after_rollback :restore_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:134:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_save is supposed to appear before after_find.
after_save :unset_undefined_address_fields
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:19:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_find.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_group.rb:23:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save.
before_validation :sanitize_permalink
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:15:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save.
before_destroy :revoke_all_child_variant_overrides
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise_relationship.rb:16:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save.
before_destroy :destroy_related_exchanges
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:108:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :update_shipping_fees!, if: :complete?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/order.rb:109:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :update_payment_fees!, if: :complete?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:30:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before before_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:32:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:33:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :invalidate_old_payments
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:34:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:35:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :invalidate_old_payments
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:36:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:46:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create.
after_initialize :build_source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/payment.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/product.rb:87:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :ensure_standard_variant
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/return_authorization.rb:12:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create.
before_save :force_positive_amount
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/user.rb:49:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before before_destroy.
after_create :associate_customers, :associate_orders
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/user.rb:50:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:88:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :create_stock_items
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:89:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save.
after_create :set_position
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:90:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:91:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/models/spree/variant.rb:91:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: around_destroy is supposed to appear before after_save.
around_destroy :destruction
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/variant.rb:92:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1481 files inspected, 35 offenses detected, 35 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
a1560263a1
Safely autocorrect Rails/ActionOrder
...
Inspecting 1481 files
.........................................C.................C.........................................................CC........C..........C.C.........C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Rails/ActionOrder: Action create should appear before update.
def create ...
^^^^^^^^^^
app/controllers/admin/resource_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/admin/resource_controller.rb:52:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update_positions
^^^^^^^^^^^^^^^^^^^^
app/controllers/api/v0/orders_controller.rb:13:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/api/v0/orders_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def show
^^^^^^^^
app/controllers/api/v0/orders_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/api/v0/orders_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/images_controller.rb:26:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/images_controller.rb:37:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/images_controller.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/images_controller.rb:41:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:19:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/spree/admin/invoices_controller.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/invoices_controller.rb:50:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def poll
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Rails/ActionOrder: Action show should appear before new.
def show ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:24:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:27:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:27:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def index
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Rails/ActionOrder: Action index should appear before new.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def new
^^^^^^^
app/controllers/spree/admin/products_controller.rb:32:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:32:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:33:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def edit
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:36:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:38:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:42:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show.
def index ...
^^^^^^^^^
app/controllers/spree/admin/products_controller.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def edit
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/products_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/products_controller.rb:52:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:13:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:29:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create.
def edit ...
^^^^^^^^
app/controllers/spree/admin/taxons_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/taxons_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:17:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def edit
^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:18:7: C: [Corrected] Rails/ActionOrder: Action new should appear before edit.
def new ...
^^^^^^^
app/controllers/spree/admin/variants_controller.rb:21:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:21:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:22:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:31:7: C: [Corrected] Rails/ActionOrder: Action new should appear before update.
def new ...
^^^^^^^
app/controllers/spree/admin/variants_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Rails/ActionOrder: Action create should appear before update.
def create ...
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:42:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def update
^^^^^^^^^^
app/controllers/spree/admin/variants_controller.rb:55:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/spree/admin/variants_controller.rb:56:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def search
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:14:3: C: [Corrected] Rails/ActionOrder: Action show should appear before new.
def show ...
^^^^^^^^
app/controllers/user_confirmations_controller.rb:15:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def new
^^^^^^^
app/controllers/user_confirmations_controller.rb:19:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/user_confirmations_controller.rb:20:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
def create
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:21:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
def create
^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:37:3: C: [Corrected] Rails/ActionOrder: Action show should appear before create.
def show ...
^^^^^^^^
app/controllers/user_confirmations_controller.rb:42:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
app/controllers/user_confirmations_controller.rb:43:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1481 files inspected, 63 offenses detected, 63 offenses corrected
2023-08-01 22:50:21 +09:00
Neal Chambers
e49c9e9061
Regenerate Rubocop's TODO file
2023-08-01 22:50:21 +09:00
Matt-Yorkley
885bc46d88
Update tax_category in product v3 table
2023-08-01 11:49:04 +01:00
David Cook
f7a137049f
Merge pull request #11296 from dacook/hide-git-errors
...
Prevent git errors from showing in command output
2023-08-01 12:16:53 +10:00
Matt-Yorkley
91fc4b51b4
Rescue ImageMagick errors
2023-07-31 17:21:49 +01:00
Mohamed ABDELLANI
7d38a7b381
remove order number next to Tax Invoice
2023-07-31 17:01:36 +01:00
Mohamed ABDELLANI
760b17042b
fix existing tests
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
0ce8fae7c9
replace invoice_number method with delegate
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
8abb9d2ecf
add invoice number to alternative invoices
2023-07-31 16:31:24 +01:00
Mohamed ABDELLANI
e66cd5aaa3
add order number & invoice number to invoices
2023-07-31 16:31:24 +01:00
dependabot[bot]
8dcaba695e
chore(deps-dev): bump rubocop from 1.55.0 to 1.55.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.55.0 to 1.55.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.55.0...v1.55.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-31 09:50:50 +00:00
dependabot[bot]
c885b42df1
chore(deps): bump @floating-ui/dom from 1.4.5 to 1.5.1
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.5.1/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-31 09:44:08 +00:00
Gaetan Craig-Riou
85adb9f345
Fix rubocop warning
2023-07-31 15:19:04 +10:00
Gaetan Craig-Riou
2857930263
Fix voucher adjustment request spec
...
Error messages have been updated to be more user friendly. This spec
was missed somehow.
2023-07-31 14:06:36 +10:00
Gaetan Craig-Riou
089d2b9c84
Clear any existing payment and payment fees when adding a voucher
...
If a user come back to checkout step 2 from step 3, the order
will have payment and possibly payment fee existing. This can
interfere with voucher calculation, so we clear them.
The user can then select a payment method again if needed
2023-07-31 12:05:52 +10:00
Maikel
c8ad6d7d1c
Merge pull request #11300 from macanudo527/fix_rubocop_layout_3
...
Fix rubocop layout 4
2023-07-31 11:26:53 +10:00
Maikel
aa92aac5a9
Style FrozenStringLiteralComment
...
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-07-31 11:19:10 +10:00
Matt-Yorkley
64b29d40a8
Migrate data for tax_category_id from products to variants
2023-07-31 09:23:40 +10:00
Matt-Yorkley
e2094665c5
Update enterprise fee report tax_category fetching
2023-07-31 09:23:20 +10:00
Matt-Yorkley
07774c4572
Update tax category specs
2023-07-31 09:23:20 +10:00
Matt-Yorkley
d1209dd49b
Update order_with_taxes factory
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b593e356b0
Update product factories
2023-07-31 09:23:20 +10:00
Matt-Yorkley
a84f9ebd2e
Allow passing tax_category to new variant when creating a new product
2023-07-31 09:23:20 +10:00
Matt-Yorkley
0df121bcc8
Move tax_category validations test
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b2a7a931f3
Update tax_category tests
2023-07-31 09:23:20 +10:00
Matt-Yorkley
4cb291290b
Update product factory
2023-07-31 09:23:20 +10:00
Matt-Yorkley
5a48721af4
Update serializers, views, and JS for bulk products edit
2023-07-31 09:23:20 +10:00
Matt-Yorkley
363bbded43
Update permitted attributes
2023-07-31 09:23:20 +10:00
Matt-Yorkley
a52516bcbf
Move tax_category dropdown in edit pages
2023-07-31 09:23:20 +10:00
Matt-Yorkley
b12c130e02
Add tax_category column to variants table
2023-07-31 09:23:20 +10:00
Matt-Yorkley
4934d09a4c
Update delegation and method chaining between product and tax_category
2023-07-31 09:23:20 +10:00
Matt-Yorkley
d33e780411
Move tax_category association from product to variant
2023-07-31 09:23:19 +10:00
Neal Chambers
60cd84d565
Safely autocorrect Naming/BlockForwarding
...
Inspecting 1480 files
...................................................................................................................................................................C.......C..........C...............................................................................................................................................................................................................C...........................................................................................................C.........C...............................................................................................................................................................................................................................................................C........................................CC...C............................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................C..............C.........C..CC.......C.....................................................................................................C...............
Offenses:
app/helpers/application_helper.rb:41:32: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def ng_form_for(name, *args, &block)
^^^^^^
app/helpers/application_helper.rb:44:75: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
form_for(name, *(args << options.merge(builder: AngularFormBuilder)), &block)
^^^^^^
app/helpers/application_helper.rb:49:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def method_missing(method, *args, &block)
^^^^^^
app/helpers/link_helper.rb:4:57: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def link_to_service(baseurl, name, html_options = {}, &block)
^^^^^^
app/helpers/link_helper.rb:8:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
link_to ext_url(baseurl, name), html_options, &block
^^^^^^
app/helpers/spree/admin/base_helper.rb:6:56: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def field_container(model, method, options = {}, &block)
^^^^^^
app/helpers/spree/admin/base_helper.rb:13:29: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
capture(&block),
^^^^^^
app/reflexes/application_reflex.rb:29:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def with_locale(&block)
^^^^^^
app/reflexes/application_reflex.rb:30:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
I18n.with_locale(current_user.locale, &block)
^^^^^^
app/services/cache_service.rb:8:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.cache(cache_key, options = {}, &block)
^^^^^^
app/services/cache_service.rb:9:48: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
Rails.cache.fetch cache_key.to_s, options, &block
^^^^^^
app/services/cache_service.rb:14:58: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.cached_data_by_class(cache_key, cached_class, &block)
^^^^^^
app/services/cache_service.rb:16:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
&block
^^^^^^
app/services/cache_service.rb:25:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.home_stats(statistic, &block)
^^^^^^
app/services/cache_service.rb:28:47: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
race_condition_ttl: 10, &block)
^^^^^^
app/services/current_order_locker.rb:12:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def self.around(controller, &block)
^^^^^^
app/services/current_order_locker.rb:13:55: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
lock_order_and_variants(controller.current_order, &block)
^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:392:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def chain_to_scope(&block)
^^^^^^
lib/reporting/reports/enterprise_fee_summary/scope.rb:393:41: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
@scope = @scope.instance_eval(&block)
^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:7:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def respond_with(*resources, &block)
^^^^^^
lib/spree/core/controller_helpers/respond_with.rb:13:64: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
return unless (collector = retrieve_collector_from_mimes(&block))
^^^^^^
lib/spree/core/delegate_belongs_to.rb:80:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def class_def(name, method = nil, &blk)
^^^^
lib/spree/core/delegate_belongs_to.rb:81:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
class_eval { method.nil? ? define_method(name, &blk) : define_method(name, method) }
^^^^
lib/spree/core/environment_extension.rb:22:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def create_method(name, &block)
^^^^^^
lib/spree/core/environment_extension.rb:23:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
self.class.__send__(:define_method, name, &block)
^^^^^^
spec/models/enterprise_caching_spec.rb:144:13: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def later(&block)
^^^^^^
spec/models/enterprise_caching_spec.rb:145:36: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
Timecop.travel(1.day.from_now, &block)
^^^^^^
spec/support/embedded_pages_helper.rb:5:26: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def on_embedded_page(&block)
^^^^^^
spec/support/embedded_pages_helper.rb:6:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within_frame :frame, &block
^^^^^^
spec/support/preferences_helper.rb:11:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def reset_spree_preferences(&config_block)
^^^^^^^^^^^^^
spec/support/preferences_helper.rb:16:33: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
configure_spree_preferences(&config_block) if block_given?
^^^^^^^^^^^^^
spec/support/request/shop_workflow.rb:87:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def within_variant(variant = nil, &block)
^^^^^^
spec/support/request/shop_workflow.rb:90:22: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within(selector, &block)
^^^^^^
spec/support/request/ui_component_helper.rb:4:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def browse_as_small(&block)
^^^^^^
spec/support/request/ui_component_helper.rb:5:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
browse_with_window_size(640, 480, &block)
^^^^^^
spec/support/request/ui_component_helper.rb:8:24: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def browse_as_medium(&block)
^^^^^^
spec/support/request/ui_component_helper.rb:9:40: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
browse_with_window_size(1024, 768, &block)
^^^^^^
spec/support/request/web_helper.rb:52:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def within_row(num, &block)
^^^^^^
spec/support/request/web_helper.rb:53:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
within("table.index tbody tr:nth-child(#{num})", &block)
^^^^^^
spec/swagger_helper.rb:77:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def param(args, &block)
^^^^^^
spec/swagger_helper.rb:78:45: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
public_send(:let, args) { instance_eval(&block) }
^^^^^^
spec/system/support/capybara_setup.rb:20:27: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding.
def using_session(name, &block)
^^^^^^
1480 files inspected, 42 offenses detected, 42 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
ae8a5b7f93
Safely autocorrect Lint/UnusedMethodArgument
...
Inspecting 1480 files
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
lib/reporting/queries/query_interface.rb:18:30: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it.
def sum_grouped(field, default = 0)
^^^^^^^
lib/reporting/queries/query_interface.rb:22:26: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it.
def sum_new(field, default = 0)
^^^^^^^
1480 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
2a76b1972f
Safely autocorrect Lint/SafeNavigationChain
...
Inspecting 1480 files
........................................................................................................................................................................................................................................................................................................................................W............................W..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/spree/line_item.rb:283:55: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
self.final_weight_volume = variant&.unit_value * quantity
^^^^^^^^^^^
app/models/spree/line_item.rb:283:57: C: [Corrected] Layout/SpaceAroundMethodCallOperator: Avoid using spaces around a method call operator.
self.final_weight_volume = variant&.unit_value&. * quantity
^
app/models/spree/stock/availability_validator.rb:31:77: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
return line_item.order.shipments.first if line_item.order&.shipments.any?
^^^^^
1480 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
e7d53753e4
Safely autocorrect Lint/RedundantCopDisableDirective
...
Inspecting 1480 files
..............W.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/components/product_component.rb:23:51: W: [Corrected] Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/MethodLength.
# rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
^^^^^^^^^^^^^^^^^^^^
app/components/product_component.rb:50:50: W: [Corrected] Lint/RedundantCopEnableDirective: Unnecessary enabling of Metrics/MethodLength.
# rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength
^^^^^^^^^^^^^^^^^^^^
1480 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-30 21:29:19 +09:00
Neal Chambers
e9f448fad9
Safely autocorrect Lint/AmbiguousOperatorPrecedence
...
Inspecting 1480 files
...................................................................................................................................................................................................................................W..........................W........................................................W................W..............W................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/calculator/flexi_rate.rb:38:7: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
count * preferred_additional_item.to_f + preferred_first_item.to_f
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:362:12: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
cat << "sells_" + sells
^^^^^^^^^^^^^^^^
app/models/enterprise.rb:496:21: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
phone_number && "https://wa.me/ " + phone_number.tr('+ ', '')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/ability.rb:27:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
order.user == user || order.token && token == order.token
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/ability.rb:30:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
order.user == user || order.token && token == order.token
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/line_item.rb:205:16: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
(price + fees / quantity).round(2)
^^^^^^^^^^^^^^^
app/models/spree/preferences/store.rb:28:11: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
should_persist? && Spree::Preference.where(key: key).exists?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1480 files inspected, 7 offenses detected, 7 offenses corrected
2023-07-30 21:29:19 +09:00
bouaik
addbbc4006
fix margin in guest checkout
2023-07-29 07:52:55 -04:00
filipefurtad0
0bcde2dbda
Update all locales with the latest Transifex translations
2023-07-28 16:33:49 +01:00
Filipe
5d624ef4be
Merge pull request #11278 from mkllnk/swagger-fix
...
Fix swagger-api integration after last update
2023-07-28 16:27:32 +01:00
Filipe
1ddbb1c4e1
Merge pull request #11294 from Matt-Yorkley/connect-src
...
Update CSP configuration for Safari
2023-07-28 16:16:02 +01:00
Cillian O'Ruanaidh
8039c0106a
Set firstname correctly in spec/system/admin/orders_spec.rb
2023-07-28 15:04:47 +01:00
Cillian O'Ruanaidh
276b94de5b
Sort orders by last name, then first name i.e. the same way bulk order management works
2023-07-28 14:20:29 +01:00
Filipe
a975e2bd93
Merge pull request #11247 from jibees/9123-inconsistent-default-visibility-setting-for-newly-created-enterprises
...
Admin, Enterprise creation : set visibility to "Hidden" by default
2023-07-28 12:15:32 +01:00
Filipe
ef947f8749
Merge pull request #11282 from jibees/11025-white-label-trix-quotes-code-and-links-cant-be-identified-in-the-editor
...
White label: Customize rendering inside the trix-editor, to match the shopfront rendering
2023-07-28 11:23:50 +01:00
Filipe
21690670f5
Merge pull request #11292 from jibees/11108-dashboard-supplier-profile-inconsistent-indentation-on-deployed-version
...
Admin: improve platform version displaying on admin homepage
2023-07-28 11:01:07 +01:00
Gaetan Craig-Riou
33ef8def08
Update order total after removing a voucher
...
We need to do this to make sure when display the payment method
again.
Plus spec
2023-07-28 14:52:25 +10:00
Gaetan Craig-Riou
f35001dacc
Update voucher adjustment and order total when adding a voucher
...
This is needed so we can check if payment is needed and display
no payment required when no payment needed
2023-07-28 14:27:27 +10:00
David Cook
ef62fb885d
Check if record actually saved
...
I'm not sure if it will ever make a difference, but I think this makes more sense.
2023-07-28 14:11:45 +10:00
David Cook
be1a72743a
Pending spec: vouchers should not require payment
2023-07-28 14:11:31 +10:00
David Cook
895f534afa
Remove unnecessary extra page load
2023-07-28 14:11:19 +10:00
David Cook
febe6501c0
Prevent git errors from showing in command output
...
This would be a very rare case, but one time the git command failed, printing out an obscure "fatal" message to stderr which caused confusion.
2023-07-28 12:07:52 +10:00
Maikel
774bb7a607
Merge pull request #11238 from filipefurtad0/legal_invoices_spec
...
Adds coverage to Invoices (system specs)
2023-07-28 08:41:01 +10:00
filipefurtad0
98f29dcd9b
Adds coverage on invoices section/table
2023-07-27 17:27:41 +01:00
Matt-Yorkley
dd9b28787c
Update CSP configuration for Safari
...
Apparently some versions of Safari have issues with Websockets if the CSP doesn't explicitly define the `connect_src` in a certain way (including specifying the host). This issue is fixed in later versions of Safari and doesn't affect other browsers, for which the `default_src` with `:self` is sufficient.
2023-07-27 16:20:42 +01:00
filipefurtad0
35dfdc8bdc
Adds coverage on Invoice tab
...
which should be visible as a function of the order state
Corrects cancelled case
2023-07-27 15:47:40 +01:00
Jean-Baptiste Bellet
8b4de3ddc7
Add version into its own .row .columns with centered text
2023-07-27 15:41:54 +02:00
jibees
55fbab4c0d
Merge pull request #11287 from openfoodfoundation/dependabot/bundler/rexml-3.2.6
...
chore(deps): bump rexml from 3.2.5 to 3.2.6
2023-07-27 12:00:28 +02:00
Jean-Baptiste Bellet
a179c006fc
Default design for ul and ol into the custom tab
...
`ul` and `old` default design already been reset, reactivate default design only for `.custom-tab`
2023-07-27 11:53:47 +02:00
Jean-Baptiste Bellet
4485490b0b
Customize rendering inside the trix-editor, to match the shopfront rendering
2023-07-27 11:53:47 +02:00
jibees
b3949965fc
Merge pull request #11288 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.4
...
chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4
2023-07-27 11:34:37 +02:00
dependabot[bot]
79d0728fdd
chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.3 to 5.3.4.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.3...v5.3.4 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 09:25:02 +00:00
dependabot[bot]
4e9dae6817
chore(deps): bump rexml from 3.2.5 to 3.2.6
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.6 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 09:21:38 +00:00
jibees
96418dcde6
Merge pull request #11284 from mkllnk/caching-spec
...
Compile JS before testing caching
2023-07-27 09:41:22 +02:00
Maikel Linke
b9ebcc9b1b
Remove version number from DFC API URLs
...
While it's quite common to version APIs it's not possible with current
DFC tools. The architecture also uses URLs as identifiers for objects
like products. Having the id of an object change just because the format
of its description changes doesn't make sense. The DFC may solve this by
adding a version number in a different way.
By removing the version from our API URL, all object ids (URIs) should
be stable from now on.
2023-07-27 15:38:36 +10:00
Maikel Linke
4872855471
Update DFC context to newest version
...
The new DFC Connector is based on the new DFC context which changed all
URLs of all data types.
There's also a better way to access semantic properties now.
2023-07-27 15:38:36 +10:00
dependabot[bot]
34fbcb0e02
chore(deps): bump datafoodconsortium-connector
...
Bumps datafoodconsortium-connector from 1.0.0.pre.alpha.6 to 1.0.0.pre.alpha.8.
---
updated-dependencies:
- dependency-name: datafoodconsortium-connector
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-27 15:38:36 +10:00
Maikel Linke
3b5b9ec54d
Avoid network request to DFC context on export
...
This protects us from the DFC website going down or the DFC updating
the context with breaking changes. We are in control of updating the
context now (opt-in to newer versions).
2023-07-27 15:38:36 +10:00
David Cook
fdb80fe87c
Merge pull request #11283 from macanudo527/fix_rubocop_layout_2
...
Fix rubocop layout 3
2023-07-27 10:29:29 +10:00
Neal Chambers
e923defd55
Safely autocorrect Layout/TrailingWhitespace
...
Inspecting 1479 files
...................................................................................................................................................C..C.......................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................C.............................................................................................C...................................................................C.......................................................................................................................................................................C....................................................C.............C...........CC.........C......C.CC.C....................C........................................................
Offenses:
app/controllers/spree/users_controller.rb:36:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/spree/users_controller.rb:51:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/user_confirmations_controller.rb:27:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/models/enterprise.rb:117:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
validates :instagram,
^
spec/controllers/spree/credit_cards_controller_spec.rb:250:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:stored_credit_card, user_id: user.id,
^
spec/controllers/user_confirmations_controller_spec.rb:45:44: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
session[:confirmation_return_url] =
^
spec/factories/order_factory.rb:40:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
order.payments << build(:payment, amount: order.total,
^
spec/lib/reports/packing/packing_report_spec.rb:59:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/lib/reports/packing/packing_report_spec.rb:63:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/models/enterprise_spec.rb:521:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(Enterprise.supplying_variant_in([p1.variants.first,
^
spec/models/enterprise_spec.rb:906:77: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:enterprise_relationship, parent: distributor, child: supplier,
^
spec/services/products_renderer_spec.rb:22:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:product, name: "banana bread", primary_taxon_id: cakes.id,
^
spec/services/products_renderer_spec.rb:88:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:90:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:97:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
fruits_supplier.producer_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:99:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:109:93: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_conventional.id,
^
spec/services/products_renderer_spec.rb:111:94: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_banana_bread.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:113:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_cherries.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:115:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_doughnuts.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:117:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/support/request/stripe_stubs.rb:17:81: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def stub_payment_intent_get_request(response: {}, stripe_account_header: true,
^
spec/support/request/stripe_stubs.rb:172:6: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
{
^
spec/support/request/stripe_stubs.rb:175:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
object: "list",
^
spec/support/request/stripe_stubs.rb:176:25: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
has_more: false,
^
spec/system/admin/bulk_order_management_spec.rb:792:99: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it "displays only line items whose orders meet the date restriction criteria, when changed",
^
spec/system/admin/bulk_order_management_spec.rb:1071:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1121:82: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
shared_examples "display only group by information for selected variant" do
^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1143:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1166:12: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^
spec/system/admin/customers_spec.rb:18:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:customer, first_name: 'John', last_name: 'Doe', enterprise: managed_distributor1,
^
spec/system/admin/enterprise_fees_spec.rb:102:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Inherit From Product',
^
spec/system/admin/enterprise_fees_spec.rb:128:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Weight (per kg or lb)',
^
spec/system/admin/enterprise_fees_spec.rb:132:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per item)',
^
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:157:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:159:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per order)',
^
spec/system/admin/enterprise_fees_spec.rb:222:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:22:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:27:32: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("#admin-menu").click
^^^^^^^
spec/system/admin/flatpickr_spec.rb:32:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:34:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:41:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_cycles/complex_editing_spec.rb:74:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/complex_editing_spec.rb:110:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/list_spec.rb:147:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:160:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:188:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/simple_spec.rb:447:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).not_to have_selector(
^
spec/system/admin/order_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:207:30: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within(".modal") do
^
spec/system/admin/order_spec.rb:235:21: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
login_as_admin
^^
spec/system/admin/order_spec.rb:240:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:247:62: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
context "when using the cancel option in the dropdown" do
^^
spec/system/admin/order_spec.rb:248:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:299:53: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_content "Are you sure?"
^^^^^^^^
spec/system/admin/order_spec.rb:327:36: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("a.delete-item").click
^
spec/system/admin/order_spec.rb:401:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:405:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:598:59: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Resend Confirmation",
^
spec/system/admin/order_spec.rb:617:52: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Cancel Order",
^
spec/system/admin/order_spec.rb:633:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:674:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:735:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:762:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:778:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:780:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:796:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:807:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
# Since the order is completed, the price is not supposed to be updated
^
spec/system/admin/order_spec.rb:813:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:815:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:924:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:959:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:981:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^^
spec/system/admin/order_spec.rb:992:8: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:1002:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1479 files inspected, 81 offenses detected, 81 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
e0206a0be6
Safely autocorrect Layout/TrailingEmptyLines
...
Inspecting 1479 files
..C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Rakefile:10:1: C: [Corrected] Layout/TrailingEmptyLines: 1 trailing blank lines detected.
1479 files inspected, 1 offense detected, 1 offense corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
2dbaa7f89d
Safely autocorrect Layout/MultilineMethodCallIndentation
...
Inspecting 1479 files
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......CC......................C..................................................
Offenses:
spec/controllers/api/v0/orders_controller_spec.rb:150:13: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
.map{ |o| o["id"] }
^^^^
spec/system/admin/order_cycles/complex_editing_spec.rb:30:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
.to eq(oc.orders_open_at.strftime("%Y-%m-%d %H:%M"))
^^^
spec/system/admin/order_cycles/complex_editing_spec.rb:32:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
.to eq(oc.orders_close_at.strftime("%Y-%m-%d %H:%M"))
^^^
spec/system/admin/overview_spec.rb:16:62: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 55) spaces for indenting an expression spanning multiple lines.
.and_return @enterprise_user
^^^^^^^^^^^
spec/system/admin/payment_method_spec.rb:62:22: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
.to_return(body: JSON.generate(stripe_account_mock))
^^^^^^^^^^
spec/system/admin/variant_overrides_spec.rb:214:64: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 51) spaces for indenting an expression spanning multiple lines.
.and_return(build(:user))
^^^^^^^^^^^
1479 files inspected, 6 offenses detected, 6 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
164385ad13
Safely autocorrect Layout/MultilineMethodCallBraceLayout
...
Inspecting 1479 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C.....................................................................
Offenses:
spec/system/admin/orders_spec.rb:485:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^
spec/system/admin/orders_spec.rb:486:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0)
)).to be_checked
^
spec/system/admin/orders_spec.rb:486:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
).to be_checked
^
spec/system/admin/orders_spec.rb:493:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^
spec/system/admin/orders_spec.rb:494:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0)
)).to_not be_checked
^
spec/system/admin/orders_spec.rb:494:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
).to_not be_checked
^
spec/system/admin/products_spec.rb:346:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
product.id, filter)))
^
spec/system/admin/products_spec.rb:347:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0)
)))
^
spec/system/admin/products_spec.rb:352:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
product.id, filter)))
^
spec/system/admin/products_spec.rb:354:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0)
)))
^
1479 files inspected, 10 offenses detected, 10 offenses corrected
2023-07-27 09:58:33 +10:00
Neal Chambers
a97e208881
Safely autocorrect Layout/MultilineBlockLayout
...
Inspecting 1479 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/order_management/app/services/order_management/subscriptions/validator.rb:101:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 12) spaces for indentation.
sli.quantity > 0 && !sli.marked_for_destruction?
^^^^^^^^^^^^
engines/order_management/app/services/order_management/subscriptions/validator.rb:101:11: C: [Corrected] Layout/MultilineBlockLayout: Block argument expression is not on the same line as the block start.
|sli| sli.quantity > 0 && !sli.marked_for_destruction?
^^^^^
1479 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-27 09:58:05 +10:00
Maikel Linke
f7d5217ef6
Compile JS before testing caching
...
That avoids flakiness.
2023-07-27 09:40:08 +10:00
Neal Chambers
ffda639629
Regenerate Rubocop's TODO file
2023-07-27 08:35:27 +09:00
Maikel
f9589b8b23
Merge pull request #11280 from filipefurtad0/fix_flaky_caching_spec
...
Comments out flaky caching example
2023-07-27 08:50:06 +10:00
Maikel
5e94c038dc
Merge pull request #11227 from filipefurtad0/update_several_enterprise_fees
...
Updates spec to cover #11150 (regression spec)
2023-07-27 08:45:27 +10:00
Maikel
16d28ab797
Merge pull request #11277 from mkllnk/greek
...
Add greek locale
2023-07-27 08:38:51 +10:00
filipefurtad0
5ed9583048
Rubocop fixes - not seen locally
...
Not sure why these were triggered remotly, but not locally - even after making sure I'm up-to-date with master?
2023-07-26 18:35:12 +01:00
filipefurtad0
f7301b72aa
Adds test case for updating multiple fees
...
Adds values, updates and asserts these are saved correctly
2023-07-26 18:35:09 +01:00
Jean-Baptiste Bellet
1a7e99143b
Update mobile variant size for white label logo to fit the same ratio
...
Default size is 217*44. On mobile, we used to use 75*26, but with a different image.
With the white label, using the same image, we should have the same ratio between default and mobile ; that's why I've updated the width of the variant to 128.
2023-07-26 14:43:06 +02:00
filipefurtad0
83f1266b8a
Comments out flaky example
...
Sets example to xit
pending is not suitable for flaky specs, as we'll get a red build anyway, each time the spec passes; commenting out should be the right approach till we fix this one
2023-07-26 12:05:06 +01:00
jibees
f5564a5947
Merge pull request #11279 from openfoodfoundation/dependabot/bundler/rubocop-1.55.0
...
chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0
2023-07-26 12:56:01 +02:00
filipefurtad0
d4d8941117
Reverts #11019
...
As discussed here (https://github.com/openfoodfoundation/openfoodnetwork/issues/11010#issuecomment-1594153860 ), reset_spree_preferences already does Rails.cache.clear
2023-07-26 11:49:41 +01:00
dependabot[bot]
45edda9bf6
chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.54.2 to 1.55.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.54.2...v1.55.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-26 08:43:15 +00:00
jibees
ad7ec1e6d0
Merge pull request #11271 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.132.0
...
chore(deps): bump aws-sdk-s3 from 1.131.0 to 1.132.0
2023-07-26 10:41:38 +02:00
jibees
b9871933e3
Merge pull request #11272 from openfoodfoundation/dependabot/bundler/view_component-3.5.0
...
chore(deps): bump view_component from 3.4.0 to 3.5.0
2023-07-26 10:40:55 +02:00
Maikel Linke
627e689757
Fix swagger-api integration after last update
...
See also:
* https://github.com/rswag/rswag/pull/668
2023-07-26 15:52:48 +10:00
Maikel Linke
cea44c1a78
Add greek locale
2023-07-26 14:45:35 +10:00
jibees
a832562d1f
Merge pull request #11198 from dacook/admin_v3-table-tweaks
...
🚧 Products v3: table and menu tweaks
2023-07-25 16:00:24 +02:00
David Cook
8ef73906db
Show products_v3 in the submenu
...
It's not translated, but that doesn't matter, it's just a shortcut while we're developing it.
2023-07-25 15:31:57 +02:00
David Cook
439c0a8e18
Remove unnecessary match_path options
...
Spree::Tab already knows when to highlight these, based on the controller name. It even handles sub-paths like '/admin/products/garlic/edit'.
2023-07-25 15:31:57 +02:00
David Cook
ea93800ee6
[table] Tax category: display None instead of blank
2023-07-25 15:31:57 +02:00
David Cook
51189a3138
[table] Hide properties for variant row
...
These were a duplicate of the product.
2023-07-25 15:31:57 +02:00
jibees
605cb730f7
Merge pull request #11163 from jibees/productsV3-searching-filtering-pagination
...
🚧 Products v3: viewing, searching, filtering & pagination
2023-07-25 15:22:42 +02:00
Jean-Baptiste Bellet
352cf2ff71
Import typography.scss for admin_v3
...
And do not apply `a` style to `.button` element.
ie.
```
a:not(.button)
```
2023-07-25 14:29:00 +02:00
dependabot[bot]
e816629038
chore(deps): bump view_component from 3.4.0 to 3.5.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-25 10:10:33 +00:00
dependabot[bot]
789fde3c89
chore(deps): bump aws-sdk-s3 from 1.131.0 to 1.132.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.131.0 to 1.132.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-25 10:03:30 +00:00
filipefurtad0
04f83fbcce
Finally, update system test for an end-to-end testing
2023-07-25 10:57:27 +02:00
Jean-Baptiste Bellet
d22566aa50
Set visible to only_through_links on enterprise creation
2023-07-25 10:57:27 +02:00
Jean-Baptiste Bellet
5a0d4d2a93
Set visible to only_through_links on enterprise registration
2023-07-25 10:57:26 +02:00
Jean-Baptiste Bellet
7aed068bb7
Enterprises.visible attribute is set to only_through_links by default
...
+ update enterprise_factory.rb to create "public" enterprise through specs via its factory
2023-07-25 10:57:26 +02:00
Jean-Baptiste Bellet
2a81a9acfb
Add ability for non super-admin user to see products_v3 page
2023-07-25 09:20:25 +02:00
jibees
6f83d5b316
Merge pull request #11264 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.3
...
chore(deps-dev): bump knapsack_pro from 5.3.2 to 5.3.3
2023-07-24 15:19:57 +02:00
jibees
af086253de
Merge pull request #11265 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.1.0
...
chore(deps-dev): bump jasmine-core from 5.0.1 to 5.1.0
2023-07-24 15:11:45 +02:00
Filipe
8ff877b865
Merge pull request #11258 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.131.0
...
chore(deps): bump aws-sdk-s3 from 1.126.0 to 1.131.0
2023-07-24 13:30:42 +01:00
Filipe
1e2fb077cd
Merge pull request #11261 from macanudo527/fix_rubocop_layout_1
...
Fix Rubocop Layout violations - 2
2023-07-24 13:05:46 +01:00
dependabot[bot]
f5c326f1b0
chore(deps-dev): bump jasmine-core from 5.0.1 to 5.1.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.0.1 to 5.1.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.0.1...v5.1.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-24 09:36:51 +00:00
dependabot[bot]
bf010d273a
chore(deps-dev): bump knapsack_pro from 5.3.2 to 5.3.3
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.2 to 5.3.3.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.2...v5.3.3 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-24 09:17:36 +00:00
Maikel Linke
f36ca77f5f
Ease reading with related spec values on one line
2023-07-24 13:31:09 +10:00
Maikel Linke
a677444a97
Fix specs with missign parenthesis
2023-07-24 13:23:54 +10:00
Neal Chambers
bede52bdae
Safely autocorrect Layout/LineLength
...
Inspecting 1478 files
.......C............................C..............................................................................................................C.......................................................................................................C............................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.................C......................................C...................................................................................................................C...........................................................C........................C...C.....C..C..C..........C..................C...............C.....................C...................................................................................C......................................................C........C..C...........C....................C.CC....C....................................C......C..........................
Offenses:
app/components/confirm_modal_component.rb:4:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil,
^
app/components/confirm_modal_component.rb:4:101: C: [Corrected] Layout/LineLength: Line is too long. [110/100]
def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, confirm_reflexes: nil)
^^^^^^^^^^
app/components/confirm_modal_component.rb:5:1: C: [Corrected] Layout/ParameterAlignment: Align the parameters of a method definition if they span more than one line.
confirm_reflexes: nil)
^^^^^^^^^^^^^^^^^^^^^
app/controllers/admin/product_import_controller.rb:142:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
redirect_to '/admin/product_import',
^
app/controllers/admin/product_import_controller.rb:142:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
redirect_to '/admin/product_import', notice: I18n.t(:product_import_no_data_in_spreadsheet_notice)
^^^^
app/controllers/admin/product_import_controller.rb:143:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
notice: I18n.t(:product_import_no_data_in_spreadsheet_notice)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100]
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^
app/models/customer.rb:43:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
scope :managed_by, ->(user) { user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none }
^^^^^^^^^^^^^
app/models/customer.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^
app/models/customer.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -19) spaces for indentation.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^^^^^^^^^^^^^^^^^^^
app/models/customer.rb:44:82: C: [Corrected] Layout/BlockEndNewline: Expression at 44, 82 should be on its own line.
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none }
^
app/models/customer.rb:44:101: C: Layout/LineLength: Line is too long. [102/100]
user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none
^^
app/models/customer.rb:45:1: C: [Corrected] Layout/BlockAlignment: } at 45, 0 is not aligned with ->(user) { at 43, 21 or scope :managed_by, ->(user) { at 43, 2.
}
^
app/models/spree/line_item.rb:53:101: C: Layout/LineLength: Line is too long. [110/100]
attr_accessor :skip_stock_check, :target_shipment # Allows manual skipping of Stock::AvailabilityValidator
^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:38:101: C: Layout/LineLength: Line is too long. [108/100]
it "loads order cycles that closed within the past month, and orders without a close_at date" do
^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:48:101: C: Layout/LineLength: Line is too long. [111/100]
it "loads order cycles that closed after the specified date, and orders without a close_at date" do
^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:100:101: C: Layout/LineLength: Line is too long. [125/100]
expect(flash[:error]).to eq "You don't have permission to create an order cycle coordinated by that enterprise"
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:125:101: C: Layout/LineLength: Line is too long. [101/100]
order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: true,
^
spec/controllers/admin/order_cycles_controller_spec.rb:127:101: C: Layout/LineLength: Line is too long. [102/100]
order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: false,
^^
spec/controllers/admin/order_cycles_controller_spec.rb:284:101: C: Layout/LineLength: Line is too long. [101/100]
merge(order_cycle: { preferred_product_selection_from_coordinator_inventory_only: true })
^
spec/controllers/admin/order_cycles_controller_spec.rb:311:101: C: Layout/LineLength: Line is too long. [104/100]
create(:exchange, order_cycle: order_cycle, sender: coordinator, receiver: hub, incoming: false,
^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:374:101: C: Layout/LineLength: Line is too long. [102/100]
expect(json_response['errors']).to eq 'Hm, something went wrong. No order cycle data found.'
^^
spec/controllers/admin/order_cycles_controller_spec.rb:460:101: C: Layout/LineLength: Line is too long. [176/100]
expect(flash[:error]).to eq 'That order cycle has been selected by a customer and cannot be deleted. To prevent customers from accessing it, please close it instead.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/admin/order_cycles_controller_spec.rb:470:101: C: Layout/LineLength: Line is too long. [147/100]
expect(flash[:error]).to eq 'That order cycle is linked to a schedule and cannot be deleted. Please unlink or delete the schedule first.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:16:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100]
let!(:product1) { create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) }
^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1])
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1])
^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:85: C: [Corrected] Layout/BlockEndNewline: Expression at 17, 85 should be on its own line.
create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) }
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:17:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100]
let!(:product2) { create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) }
^^^^^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:18:1: C: [Corrected] Layout/BlockAlignment: } at 18, 0 is not aligned with let!(:product1) { at 16, 4.
}
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:19:85: C: [Corrected] Layout/BlockEndNewline: Expression at 19, 85 should be on its own line.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) }
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:20:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2])
^
spec/controllers/api/v0/order_cycles_controller_spec.rb:20:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation.
create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2])
^^
spec/controllers/api/v0/order_cycles_controller_spec.rb:21:1: C: [Corrected] Layout/BlockAlignment: } at 21, 0 is not aligned with let!(:product2) { at 19, 4.
}
^
spec/controllers/spree/admin/orders_controller_spec.rb:232:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
let!(:order_cycle){ create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) }
^^^^^^^^^^^^^^^^^
spec/controllers/spree/admin/orders_controller_spec.rb:233:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant])
^
spec/controllers/spree/admin/orders_controller_spec.rb:233:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant])
^^^^^^
spec/controllers/spree/admin/orders_controller_spec.rb:233:90: C: [Corrected] Layout/BlockEndNewline: Expression at 233, 90 should be on its own line.
create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) }
^
spec/controllers/spree/admin/orders_controller_spec.rb:234:1: C: [Corrected] Layout/BlockAlignment: } at 234, 0 is not aligned with let!(:order_cycle){ at 232, 8.
}
^
spec/controllers/spree/admin/orders_controller_spec.rb:252:101: C: Layout/LineLength: Line is too long. [109/100]
allow_any_instance_of(Spree::Order).to receive(:ensure_available_shipping_rates).and_return(true)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:93:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:94:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:94:101: C: Layout/LineLength: Line is too long. [109/100]
bill_address: a, shipping_method: sm)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:97:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:98:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:98:101: C: Layout/LineLength: Line is too long. [109/100]
bill_address: a, shipping_method: sm)
^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:113:101: C: Layout/LineLength: Line is too long. [118/100]
[d.address.address1, d.address.address2, d.address.city].join(" "),
^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:120:101: C: [Corrected] Layout/LineLength: Line is too long. [129/100]
create(:order_with_totals_and_distribution, :completed, distributor: d2, bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:122:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d2,
^
spec/lib/reports/customers_report_spec.rb:123:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:123:101: C: Layout/LineLength: Line is too long. [112/100]
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:133:101: C: Layout/LineLength: Line is too long. [120/100]
[d.address.address1, d.address.address2, d.address.city].join(" "),
^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:139:101: C: Layout/LineLength: Line is too long. [123/100]
[d2.address.address1, d2.address.address2, d2.address.city].join(" "),
^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:145:101: C: [Corrected] Layout/LineLength: Line is too long. [128/100]
create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:148:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_totals_and_distribution, :completed, distributor: d,
^
spec/lib/reports/customers_report_spec.rb:149:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^^^^
spec/lib/reports/customers_report_spec.rb:149:101: C: Layout/LineLength: Line is too long. [112/100]
bill_address: a, shipping_method: sm2)
^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/models/enterprise_spec.rb:521:101: C: [Corrected] Layout/LineLength: Line is too long. [111/100]
expect(Enterprise.supplying_variant_in([p1.variants.first, p2.variants.first])).to match_array [s1, s2]
^^^^^^^^^^^
spec/models/enterprise_spec.rb:522:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
p2.variants.first])).to match_array [s1, s2]
^^^^^^^^^^^^^^^^^
spec/models/order_cycle_spec.rb:207:101: C: Layout/LineLength: Line is too long. [118/100]
expect(oc.variants).to match_array [p0.variants.first, p1.variants.first, p2.variants.first, p2_v, p1_v_visible,
^^^^^^^^^^^^^^^^^^
spec/models/order_cycle_spec.rb:220:101: C: Layout/LineLength: Line is too long. [111/100]
expect(oc.distributed_variants).to match_array [p1.variants.first, p2.variants.first, p2_v, p1_v_visible,
^^^^^^^^^^^
spec/models/product_importer_spec.rb:782:101: C: Layout/LineLength: Line is too long. [101/100]
csv << [" Oats ", "\nPorridge Oats\n", "\r#{enterprise2.name}\r", "\t#{enterprise.name}\t",
^
spec/models/spree/ability_spec.rb:340:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :edit, :update, :search, :destroy,
^
spec/models/spree/ability_spec.rb:340:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
[:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p1.variants.first
^
spec/models/spree/ability_spec.rb:341:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:delete], for: p1.variants.first
^^^^^^^
spec/models/spree/ability_spec.rb:350:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100]
[:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p_related.variants.first
^^^^^^^^
spec/models/spree/ability_spec.rb:351:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :edit, :update, :search, :destroy,
^
spec/models/spree/ability_spec.rb:352:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:delete], for: p_related.variants.first
^^^^^^^
spec/models/spree/ability_spec.rb:379:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
[:admin, :index, :read, :create, :edit, :search, :update, :destroy], for: p2.variants.first
^
spec/models/spree/ability_spec.rb:381:68: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
[:admin, :index, :read, :create, :edit, :search, :update,
^
spec/models/spree/ability_spec.rb:382:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
:destroy], for: p2.variants.first
^^^^^^^^
spec/models/spree/adjustment_spec.rb:339:101: C: Layout/LineLength: Line is too long. [106/100]
create(:tax_rate, included_in_price: true, calculator: ::Calculator::DefaultTax.new, zone: zone,
^^^^^^
spec/models/spree/adjustment_spec.rb:367:101: C: Layout/LineLength: Line is too long. [101/100]
calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0))
^
spec/models/spree/adjustment_spec.rb:428:101: C: Layout/LineLength: Line is too long. [105/100]
context "when enterprise fees inherit their tax_category from the product they are applied to" do
^^^^^
spec/models/spree/adjustment_spec.rb:443:101: C: Layout/LineLength: Line is too long. [101/100]
calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0))
^
spec/models/spree/line_item_spec.rb:208:101: C: Layout/LineLength: Line is too long. [107/100]
expect(LineItem.from_order_cycle(oc_order.order_cycle).first.id).to eq oc_order.line_items.first.id
^^^^^^^
spec/models/spree/line_item_spec.rb:342:101: C: Layout/LineLength: Line is too long. [102/100]
Spree::Variant.find(variant.id).on_hand
^^
spec/models/spree/product_spec.rb:409:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d1],
^
spec/models/spree/product_spec.rb:409:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first])
^^^^
spec/models/spree/product_spec.rb:410:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p1.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:410:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first])
^^^^
spec/models/spree/product_spec.rb:411:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d2],
^
spec/models/spree/product_spec.rb:412:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p2.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:486:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first])
^^^^
spec/models/spree/product_spec.rb:487:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first])
^^^^
spec/models/spree/product_spec.rb:488:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d1],
^
spec/models/spree/product_spec.rb:489:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p1.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:490:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d2],
^
spec/models/spree/product_spec.rb:491:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p2.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/product_spec.rb:495:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
create(:simple_order_cycle, suppliers: [s], distributors: [d], variants: [p.variants.first])
^^
spec/models/spree/product_spec.rb:499:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:simple_order_cycle, suppliers: [s], distributors: [d],
^
spec/models/spree/product_spec.rb:500:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
variants: [p.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/spree/variant_spec.rb:356:101: C: Layout/LineLength: Line is too long. [108/100]
it "lists any variants that are not listed as visible=false only for the relevant enterprise" do
^^^^^^^^
spec/models/spree/variant_spec.rb:479:101: C: Layout/LineLength: Line is too long. [108/100]
expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_for).with(variant) {
^^^^^^^^
spec/models/spree/variant_spec.rb:494:101: C: Layout/LineLength: Line is too long. [116/100]
expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_by_type_for).with(variant) {
^^^^^^^^^^^^^^^^
spec/models/spree/variant_spec.rb:704:101: C: Layout/LineLength: Line is too long. [115/100]
expect_any_instance_of(VariantUnits::OptionValueNamer).to receive(:name).exactly(1).times.and_call_original
^^^^^^^^^^^^^^^
spec/requests/api/orders_spec.rb:167:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:order_with_line_items, line_items_count: 1, bill_address_id: nil,
^
spec/requests/api/orders_spec.rb:167:101: C: [Corrected] Layout/LineLength: Line is too long. [109/100]
create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/requests/api/orders_spec.rb:168:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
ship_address_id: nil)
^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/support/request/web_helper.rb:96:84: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option',
^
spec/support/request/web_helper.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100]
tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', text: value).click
^^
spec/support/request/web_helper.rb:97:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
text: value).click
^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:29:101: C: [Corrected] Layout/LineLength: Line is too long. [197/100]
let!(:tax_rate2) { create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:30:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
^
spec/system/admin/adjustments_spec.rb:30:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
spec/system/admin/adjustments_spec.rb:30:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true,
^
spec/system/admin/adjustments_spec.rb:30:101: C: [Corrected] Layout/LineLength: Line is too long. [177/100]
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:30:177: C: [Corrected] Layout/BlockEndNewline: Expression at 30, 177 should be on its own line.
create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) }
^
spec/system/admin/adjustments_spec.rb:31:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
tax_category: tax_category_included, calculator: Calculator::DefaultTax.new )
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:32:1: C: [Corrected] Layout/BlockAlignment: } at 32, 0 is not aligned with let!(:tax_rate2) { at 29, 2.
}
^
spec/system/admin/adjustments_spec.rb:41:101: C: Layout/LineLength: Line is too long. [134/100]
shared_examples "when the enable_localized_number preference" do |adjustment_label, adjustment_amount, tax_category, tax, tax_total|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:67:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67"
^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:68:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
^
spec/system/admin/adjustments_spec.rb:69:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$0.33", "$-1.67"
^^^^^^^
spec/system/admin/adjustments_spec.rb:71:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:73:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "100",
^
spec/system/admin/adjustments_spec.rb:74:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^
spec/system/admin/adjustments_spec.rb:77:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:80:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST",
^
spec/system/admin/adjustments_spec.rb:81:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$8.00"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:81:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:85:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST",
^
spec/system/admin/adjustments_spec.rb:86:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$120"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67"
^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:97:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:98:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
^
spec/system/admin/adjustments_spec.rb:99:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$0.33", "$-1.67"
^^^^^^^
spec/system/admin/adjustments_spec.rb:103:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "100",
^
spec/system/admin/adjustments_spec.rb:103:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:104:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"TVA 20%", "$-16.67", "$83.33"
^^^^^^^^^
spec/system/admin/adjustments_spec.rb:107:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100]
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120"
^^^^^^^^^^^^^
spec/system/admin/adjustments_spec.rb:110:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST",
^
spec/system/admin/adjustments_spec.rb:111:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$8.00"
^^^^^^^^
spec/system/admin/adjustments_spec.rb:115:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST",
^
spec/system/admin/adjustments_spec.rb:116:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"$10.00", "$120"
^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:268:101: C: Layout/LineLength: Line is too long. [105/100]
text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}"
^^^^^
spec/system/admin/bulk_order_management_spec.rb:1036:101: C: Layout/LineLength: Line is too long. [147/100]
expect(page).to have_content "This operation will result in one or more empty orders, which will be cancelled. Do you wish to proceed?"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1060:101: C: Layout/LineLength: Line is too long. [138/100]
it "the user can confirm + wants to send email confirmation : line item is then deleted, order is canceled and email is sent" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1072:101: C: Layout/LineLength: Line is too long. [134/100]
it "the user can confirm + uncheck the restock option: line item is then deleted and order is canceled without retocking" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100]
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100]
with_options: [schedule_of_other_managed_distributor.name]
^
spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:598:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100]
expect(page).to have_link "Resend Confirmation", href: spree.resend_admin_order_path(order)
^
spec/system/admin/order_spec.rb:599:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
href: spree.resend_admin_order_path(order)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:616:101: C: [Corrected] Layout/LineLength: Line is too long. [105/100]
expect(page).to have_link "Cancel Order", href: spree.fire_admin_order_path(order, e: 'cancel')
^^^^^
spec/system/admin/order_spec.rb:618:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
href: spree.fire_admin_order_path(order, e: 'cancel')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100]
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/system/admin/product_import_spec.rb:573:101: C: Layout/LineLength: Line is too long. [106/100]
expect(page).to have_content "line 4: Cabbage - On_hand incorrect value - On_demand incorrect value"
^^^^^^
spec/system/admin/product_import_spec.rb:574:101: C: Layout/LineLength: Line is too long. [108/100]
expect(page).to have_content "line 5: Aubergine - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^
spec/system/admin/product_import_spec.rb:583:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type",
^^
spec/system/admin/product_import_spec.rb:585:101: C: Layout/LineLength: Line is too long. [106/100]
csv << ["Beans", "User Enterprise", "Vegetables", "invalid", "3.50", "1", "0.5", "g", "Small Bag",
^^^^^^
spec/system/admin/product_import_spec.rb:587:101: C: Layout/LineLength: Line is too long. [103/100]
csv << ["Potatoes", "User Enterprise", "Vegetables", "6", "6", "invalid", "5", "kg", "Big Bag",
^^^
spec/system/admin/product_import_spec.rb:589:101: C: Layout/LineLength: Line is too long. [106/100]
csv << ["Cabbage", "User Enterprise", "Vegetables", "invalid", "1.5", "invalid", "1", "kg", "Bag",
^^^^^^
spec/system/admin/product_import_spec.rb:591:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["Aubergine", "User Enterprise", "Vegetables", nil, "1.5", "invalid", "1", "kg", "Bag",
^^
spec/system/admin/product_import_spec.rb:607:101: C: Layout/LineLength: Line is too long. [114/100]
expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:608:101: C: Layout/LineLength: Line is too long. [116/100]
expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:617:101: C: Layout/LineLength: Line is too long. [102/100]
csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type",
^^
spec/system/admin/product_import_spec.rb:619:101: C: Layout/LineLength: Line is too long. [101/100]
csv << ["Beans", "User Enterprise", "Vegetables", "-1", "3.50", "1", "500", "g", "Small Bag",
^
spec/system/admin/product_import_spec.rb:641:101: C: Layout/LineLength: Line is too long. [114/100]
expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:642:101: C: Layout/LineLength: Line is too long. [116/100]
expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value"
^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100]
preferred_unit_from_list: "kg"),
^
spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100]
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^
1478 files inspected, 173 offenses detected, 106 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
e546a6b583
Safely autocorrect Layout/LineContinuationSpacing
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................C............................................................................
Offenses:
spec/system/admin/enterprise_fees_spec.rb:52:46: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
fill_in "#{prefix}_calculator_attributes"\
^
spec/system/admin/enterprise_fees_spec.rb:57:58: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
expect(page).to have_selector("##{prefix}_calculator"\
^
spec/system/admin/enterprise_fees_spec.rb:142:43: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
"#{prefix}_calculator_attributes_"\
^
spec/system/admin/order_spec.rb:646:84: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash.
accept_alert "An invoice for this order will be sent to the customer. "\
^
1478 files inspected, 4 offenses detected, 4 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
948b287fd6
Safely autocorrect Layout/LeadingCommentSpace
...
Inspecting 1478 files
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................
Offenses:
spec/system/admin/enterprises_spec.rb:204:5: C: [Corrected] Layout/LeadingCommentSpace: Missing space after #.
#using "find" as fields outside of the screen and are not visible
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
9155614501
Safely autocorrect Layout/IndentationConsistency
...
Inspecting 1478 files
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.......C......................................................................
Offenses:
spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb:84:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"#order_cycle_incoming_exchange_1_variants_#{initial_variants.last.id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:784:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method_id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:791:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
"order_cycle_selected_distributor_shipping_method_ids_#{distributor_shipping_method_id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/product_import_spec.rb:818:15: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
I18n.t("admin.product_import.product_headings.#{heading}").upcase
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 4 offenses detected, 4 offenses corrected
2023-07-24 09:14:13 +09:00
Neal Chambers
dce02160d4
Safely autocorrect Layout/HashAlignment
...
Inspecting 1478 files
...................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................................................................................................................................................................................................................C......................CC....................C......................................................
Offenses:
app/controllers/spree/users_controller.rb:53:19: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100]
message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') })
^^^^^^^
spec/models/enterprise_spec.rb:906:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
permissions: [permission])
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:19:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
code: nil, created_manually: true)
^^^^^^^^^
spec/system/admin/order_spec.rb:708:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributors: [distributor1])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:45:4: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributors: [distributor4, distributor5])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:249:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
line_items_count: 0)
^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:254:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
line_items_count: 1)
^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100]
distributor: distributor2, bill_address_id: nil, ship_address_id: nil)
^^^^^^^^^
spec/system/admin/tag_rules_spec.rb:145:37: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
count: 4
^^^^^^^^
1478 files inspected, 11 offenses detected, 9 offenses corrected
2023-07-24 09:14:13 +09:00
Filipe
8bd25f9711
Merge pull request #11251 from jibees/11207-update-all-products-report-to-include-stock
...
Admin, Products & Inventory reports: add `on_hand` and `on_demand?` columns by default ; mark `Inventory (on hand)` report as deprecated
2023-07-21 17:07:00 +01:00
Filipe
0d0beda887
Merge pull request #11084 from abdellani/update_invoice_status_automatically
...
set invoice status automatically after creation
2023-07-21 16:21:05 +01:00
jibees
5142efc86e
Merge pull request #11257 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.2
...
chore(deps-dev): bump knapsack_pro from 5.3.1 to 5.3.2
2023-07-21 14:36:46 +02:00
Cillian O'Ruanaidh
0c0b85f4c4
Validate voucher code doesn't contain new line characters
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
0d0df82522
Validate voucher code length doesn't exceed the database column length i.e. 255 characters
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
5d66c8a578
Strip leading and trailing whitespace from voucher codes before validation
2023-07-21 12:32:36 +01:00
Cillian O'Ruanaidh
535ca954de
Voucher codes should only be a single line so use a text field instead of a textarea
2023-07-21 12:12:36 +01:00
dependabot[bot]
df633f7855
chore(deps): bump aws-sdk-s3 from 1.126.0 to 1.131.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.126.0 to 1.131.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-21 09:17:05 +00:00
dependabot[bot]
44551766c5
chore(deps-dev): bump knapsack_pro from 5.3.1 to 5.3.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.1 to 5.3.2.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.1...v5.3.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-21 09:15:41 +00:00
jibees
6ddb3cd644
Merge pull request #11252 from filipefurtad0/invoices_missing_translations
...
Adds missing key
2023-07-21 10:42:35 +02:00
Jean-Baptiste Bellet
a094a89c09
Mark "Inventory (on hand)" report as deprecated
...
Co-Authored-By: Maikel <maikel@email.org.au >, @dacook
2023-07-21 09:27:07 +02:00
Jean-Baptiste Bellet
28fe479f53
Unhide on_demand & on_hand columns by default
...
+ update specs as well
2023-07-21 09:27:07 +02:00
David Cook
b464e51ba4
Merge pull request #11246 from mkllnk/engine-ruby-version
...
Add Ruby version to engines for Rubocop
2023-07-21 15:03:01 +10:00
Gaetan Craig-Riou
f9afc0ba96
Fix rubocop warning
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
196b674bf1
Add system spec to test filtering by product
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
2fff77b2ee
Report, add filtering by product for line items
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
ec78de7cea
Add product dropdown on Order and Fulfillment reports
...
It includes loading the selected product to populate the dropdown
when needed.
2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou
b4a3aaab19
Add select variant stimulus controller
...
This is similar to variantAutocomplete directive used on the
new order page. It doesn't have all the same feature, but it's a
start
2023-07-21 14:51:40 +10:00
Maikel Linke
54f39668ba
Remove unused, outdated dependency declarations
...
The Gemfile of the main app is used.
2023-07-21 14:13:27 +10:00
Maikel Linke
a01aa8849c
Add Ruby version to engines for Rubocop
...
> This ensures that RuboCop is using the same Ruby version as the gem.
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
2023-07-21 14:13:26 +10:00
Maikel
022225581f
Merge pull request #11249 from openfoodfoundation/dependabot/bundler/bugsnag-6.26.0
...
chore(deps): bump bugsnag from 6.25.2 to 6.26.0
2023-07-21 09:58:56 +10:00
Maikel
5c8939fb69
Merge pull request #11248 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.1
...
chore(deps-dev): bump knapsack_pro from 5.3.0 to 5.3.1
2023-07-21 09:58:07 +10:00
Maikel
9ba9519622
Merge pull request #11241 from dacook/rubocop-layout-1
...
Fix Rubocop Layout violations - 1
2023-07-21 09:57:12 +10:00
filipefurtad0
4b64b9085c
Adds missing keys
2023-07-20 19:18:27 +01:00
Filipe
6199d2c957
Merge pull request #11218 from openfoodfoundation/dependabot/bundler/stripe-8.6.0
...
chore(deps): bump stripe from 8.5.0 to 8.6.0
2023-07-20 12:56:42 +01:00
dependabot[bot]
a0cc07dc35
chore(deps): bump bugsnag from 6.25.2 to 6.26.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.25.2 to 6.26.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/commits )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-20 09:41:23 +00:00
dependabot[bot]
afd854d32a
chore(deps-dev): bump knapsack_pro from 5.3.0 to 5.3.1
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.3.0 to 5.3.1.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.0...v5.3.1 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-20 09:39:40 +00:00
David Cook
c112fad4b2
Update all locales with the latest Transifex translations
2023-07-20 14:11:16 +10:00
David Cook
19ee2b50c2
Safely autocorrect Layout/FirstHashElementIndentation
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................
Offenses:
spec/services/products_renderer_spec.rb:73:11: C: [Corrected] Layout/FirstHashElementIndentation: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
"#{[:name, :meta_keywords, :variants_display_as, ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:76:9: C: [Corrected] Layout/FirstHashElementIndentation: Indent the right brace the same as the first position after the preceding left parenthesis.
} })
^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 14:05:16 +10:00
David Cook
aa124511de
Safely autocorrect Layout/FirstArgumentIndentation
...
Inspecting 1478 files
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/system/admin/orders_spec.rb:485:11: C: [Corrected] Layout/FirstArgumentIndentation: Indent the first argument one step more than page.find(.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:493:11: C: [Corrected] Layout/FirstArgumentIndentation: Indent the first argument one step more than page.find(.
"#listing_orders tbody tr td:first-child input[type=checkbox]")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 14:03:31 +10:00
David Cook
6859200339
Safely autocorrect Layout/ExtraSpacing
...
Inspecting 1478 files
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C......................
Offenses:
spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
let(:product_property) { create(:product_property, property: property) }
^
spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
^
spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
expect(page).to have_no_selector 'hub', text: d2.name
^^
1478 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-20 14:01:44 +10:00
David Cook
bc330b69a5
Safely autocorrect Layout/EmptyLinesAroundBlockBody
...
Inspecting 1478 files
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...............................................................................
Offenses:
spec/system/admin/order_cycles/list_spec.rb:191:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:59:53 +10:00
David Cook
6fa9165cc2
Safely autocorrect Layout/EmptyLines
...
Inspecting 1478 files
..............................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
app/models/spree/payment.rb:100:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:58:00 +10:00
David Cook
159a0d391c
Safely autocorrect Layout/ClosingParenthesisIndentation
...
Inspecting 1478 files
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/system/admin/orders_spec.rb:486:9: C: [Corrected] Layout/ClosingParenthesisIndentation: Align ) with (.
).to be_checked
^
spec/system/admin/orders_spec.rb:494:9: C: [Corrected] Layout/ClosingParenthesisIndentation: Align ) with (.
).to_not be_checked
^
1478 files inspected, 2 offenses detected, 2 offenses corrected
2023-07-20 13:56:13 +10:00
David Cook
0030343897
Safely autocorrect Layout/BlockEndNewline
...
Inspecting 1478 files
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................
Offenses:
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:127:87: C: [Corrected] Layout/BlockEndNewline: Expression at 127, 87 should be on its own line.
create(:enterprise_fee, fee_type: 'packing', amount: 7.89, name: "Packing") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:128:1: C: [Corrected] Layout/BlockAlignment: } at 128, 0 is not aligned with let!(:ef_packing) { at 126, 8.
}
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:129:91: C: [Corrected] Layout/BlockEndNewline: Expression at 129, 91 should be on its own line.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:130:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:130:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'transport', amount: 0.12, name: "Transport")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:131:1: C: [Corrected] Layout/BlockAlignment: } at 131, 0 is not aligned with let!(:ef_transport) { at 129, 8.
}
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:131:95: C: [Corrected] Layout/BlockEndNewline: Expression at 131, 95 should be on its own line.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising") }
^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:133:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 10) spaces for indentation.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising")
^^^^^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:133:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation.
create(:enterprise_fee, fee_type: 'fundraising', amount: 3.45, name: "Fundraising")
^^^^^^
spec/lib/open_food_network/enterprise_fee_calculator_spec.rb:134:1: C: [Corrected] Layout/BlockAlignment: } at 134, 0 is not aligned with let!(:ef_fundraising) { at 132, 8.
}
^
spec/system/admin/orders_spec.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
create(:shipping_method_with, :pickup, name: "delivery",
^
spec/system/admin/orders_spec.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
create(:shipping_method_with, :pickup, name: "delivery",
spec/system/admin/orders_spec.rb:45:45: C: [Corrected] Layout/BlockEndNewline: Expression at 45, 45 should be on its own line.
distributors: [distributor4, distributor5]) }
^
spec/system/admin/orders_spec.rb:46:1: C: [Corrected] Layout/BlockAlignment: } at 46, 0 is not aligned with let!(:shipping_method2) { at 43, 2.
}
^
1478 files inspected, 16 offenses detected, 16 offenses corrected
2023-07-20 13:54:30 +10:00
David Cook
7cbe1d94ad
Safely autocorrect Layout/BlockAlignment
...
Inspecting 1478 files
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..................................................................................................................................................................................
Offenses:
spec/services/products_renderer_spec.rb:28:7: C: [Corrected] Layout/BlockAlignment: } at 28, 6 is not aligned with let!(:product_cherries) { at 25, 4.
}
^
1478 files inspected, 1 offense detected, 1 offense corrected
2023-07-20 13:52:44 +10:00
David Cook
5a3a4a041f
Safely autocorrect Layout/ArrayAlignment
...
Inspecting 1478 files
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................CC.........................................C.................................
Offenses:
spec/system/admin/customers_spec.rb:40:13: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100]
managed_distributor2.name], without_options: [unmanaged_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_spec.rb:742:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
different_shipping_method_for_distributor1]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/orders_spec.rb:48:33: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
distributor3, distributor4],
^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:21:37: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line.
product_with_fee.variants.first])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1478 files inspected, 5 offenses detected, 4 offenses corrected
2023-07-20 13:50:55 +10:00
David Cook
bcfa70af4e
Safely autocorrect Layout/ArgumentAlignment
...
Inspecting 1478 files
...................................................................................................................................................C..C.......................................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..........................................C................................................................................................................................................................................................C..................................................................C............C..................CC............................................C......C..........................
Offenses:
app/controllers/spree/users_controller.rb:37:15: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "alert", message: t('devise.failure.already_registered') })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/spree/users_controller.rb:52:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "success", ...
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/user_confirmations_controller.rb:28:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
locals: { type: "success", message: t("devise.confirmations.send_instructions") })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:54:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
inverse_of: :distributor, foreign_key: :distributor_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:56:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
inverse_of: :distributor, foreign_key: :distributor_id
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/enterprise.rb:118:5: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
format: { ...
^^^^^^^^^
spec/lib/reports/packing/packing_report_spec.rb:60:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
product: create(:simple_product, name: "visible", supplier: supplier1))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/reports/packing/packing_report_spec.rb:64:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
product: create(:simple_product, name: "not visible", supplier: supplier2))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:7: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^
spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100]
value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}")
^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:100:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/services/products_renderer_spec.rb:118:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
{ q: { with_properties: [property_organic.id] } })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100]
{ q: { with_properties: [property_organic.id] } })
^
spec/system/admin/bulk_order_management_spec.rb:268:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:793:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
retry: 3 do
^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:103:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_tax_category_id"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:129:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:133:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:160:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
from: "#{prefix}_calculator_type"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:221:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
selected: 'Second Distributor'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/enterprise_fees_spec.rb:232:43: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
'Flat Rate (per order)', message, 0
^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:148:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to start_with oc_open_at.strftime("%Y-%m-%d %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:161:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to eq oc_open_at.strftime("%Y-%m-13 %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/list_spec.rb:189:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
match: :first).value).to eq test_value.to_datetime.strftime("%Y-%m-%d %H:%M")
^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:13: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
with_options: [schedule_of_other_managed_distributor.name]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100]
with_options: [schedule_of_other_managed_distributor.name]
^
spec/system/admin/order_cycles/simple_spec.rb:623:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100]
value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:9: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100]
value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false
^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:35: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
preferred_unit_from_list: "kg"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100]
preferred_unit_from_list: "kg"),
^
spec/system/consumer/shopping/products_spec.rb:98:11: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100]
"<script>alert('Dangerous!');</script>", truncate: false)
^^^^^^^^^^^^^
1478 files inspected, 45 offenses detected, 32 offenses corrected
2023-07-20 13:48:51 +10:00
David Cook
bb728d97fd
Regenerate Rubocop's TODO file
2023-07-20 13:46:52 +10:00
Maikel
fd05f41349
Merge pull request #11236 from filipefurtad0/BO_out_of_stock_warning
...
Adds assertion on the Out of Stock message
2023-07-20 10:19:41 +10:00
David Cook
cdffeea5cb
Merge pull request #10966 from macanudo527/fix_linelength_bundle3
...
Fix Layout/LineLength - Bundle 3
2023-07-20 10:04:24 +10:00
Maikel
f82222d97c
Merge pull request #11239 from filipefurtad0/missing_translation_on_invoices_tab
...
Fixes missing translation on Invoices tab
2023-07-20 08:42:36 +10:00
filipefurtad0
8f8e28f816
Fixes missing translation on Invoices tab
...
Adds invoices to en.yml, fixing #11237
2023-07-19 18:11:45 +01:00
filipefurtad0
537e225c84
Adds assertion on the Out of Stock message
2023-07-19 16:28:06 +01:00
Jean-Baptiste Bellet
1750575f8c
Need to update tab before updating panel since we retrieve panel from tab
2023-07-19 16:28:10 +02:00
Jean-Baptiste Bellet
695f76d3b6
Update format to be solve prettier warnings
2023-07-19 16:28:03 +02:00
Jean-Baptiste Bellet
0065ece6a6
Show vouchers panel only if enterprise sells products (own or any)
2023-07-19 16:02:16 +02:00
jibees
49a192eacc
Merge pull request #11231 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.4
...
chore(deps): bump mini_portile2 from 2.8.2 to 2.8.4
2023-07-19 15:13:50 +02:00
jibees
821e5226fa
Merge pull request #11232 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.0
...
chore(deps-dev): bump knapsack_pro from 5.2.0 to 5.3.0
2023-07-19 15:11:27 +02:00
Jean-Baptiste Bellet
5d4ef5b52c
To test the search by category, we need to use set primary_taxon attr
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
bada2ef4a7
Remove useless spec (will be tested right after)
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
62eaf4a1a9
This spec is not flaky anymore
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
55cad3659f
Simplify products creation
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
6f6de00919
Better naming of argument to not override existing variable...
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
3fab9714f5
Use a constant as the search_key
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
79421f2265
Expect to found the product
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
2697a637a9
Use the OpenFoodNetwork::Permissions helper
...
To retrieve only primary producers
2023-07-19 14:58:40 +02:00
jibees
3245f7ff99
Update app/reflexes/products_reflex.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
b42dfb574b
Delete already imported (and modified) file
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
90c6398197
Simplify and call methods directly via before_reflex
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
b3bdba3a9b
Better use merge! instead of q = q.merge
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
755a1842c2
Simplify to save execution time
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
037589ecda
Add columns translation
2023-07-19 14:58:40 +02:00
Jean-Baptiste Bellet
dec779a357
available_on column has been deleted
...
https://github.com/openfoodfoundation/openfoodnetwork/pull/11136
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
fac02c794c
Search through more attributes than only name
...
Copy/paste from `app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee`
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
010f19cb83
Create a medium height button, and adjust #sort row
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
c378ad1d88
Add "no results found" container
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
5a8a187f54
Add clear search button and action
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
904c7bfacf
Buttons design
...
Remove already defined `$border-radius`
Defined `app/webpacker/css/admin/globals/variables.scss`
Adjust height
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
7b56cbf3d4
Add labels to selectors, and adjust css
...
+ Adjusting filter elements with flex-grow properties
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
333dc11fc1
Manage form params vs. URL params. And replace state with params.
...
"One needs to understand what the source of the params in a reflex is. And there are two sources:
the closest form
the url of the currently displayed page"
Source: https://github.com/stimulusreflex/stimulus_reflex/issues/290#issuecomment-683334963
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
bfe1884ab5
Can filter by categories
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
ef1702188f
Extract filters from 'no products found' logic
...
We still want to display filters if no products found
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
f58cf2d3b2
Can filter by producer
...
Not sur the request nor the `producers` in the reflex should be like this. This is a proof of concept, and should probably be reviewed
Fix linter issues
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
ddfc60c85e
Don't use events, but call the loading controller itself
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
762b777995
Design of the search button
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
51e139b6f1
Create first spec for the new products page
...
Modify comment, and contextualize search (inside search term)
Extract creation of products outside a before block
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
38d0af8ec0
Simplify: don't need to pass through the js controller
...
Use the reflex itself
+ Don't need to create a method that will be called only in the connect
+ Simply code by adding only two lifecycle methods
Actually it seems that all reflex related to products controller should show/hide loading
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9d52f0b20a
Loading spinner should be above content (filters, sort, ...)
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
643897abb2
Add search functionnality
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
c786f300ca
Have a tiny url state management by using replace_state of cable_ready
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
0fd4d892d9
This is now unused: through the js controller only at startup
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
3da6e02192
Call pagination via perPage param: no state to manage, use param
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
61d1f30e04
Rename productsV3 to products: avoid upper|lower case issues
...
This is causing some issues, misunderstandings around case.
Therefore, directly use the Reflex, and lifecycle methods `beforeFetch` and `afterFetch` are called, even if we use the Reflex (and not the js controller methods). This is pretty handy.
+ adds some id to pagination element (https://docs.stimulusreflex.com/guide/reflexes.html#declaring-a-reflex-in-html-with-data-attributes )
Global documentation: https://docs.stimulusreflex.com/guide/reflexes.html
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
574adb88d2
Add a per page component
...
This is still a WIP.
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
0b83dc088d
Separation of concerns: use a loading controller
...
Two different events can be used: `show-loading` and `hide-loading`.
I'm not 100% sure this is the right way to go, but let's try!
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
5aebbe4102
use beforeFetch and afterFetch lifecycle methods
...
+ Move outside `Admin` module the reflex
Therefore, this reflex should be _equivalent_ to its javascript controller: `ProductsV3` (relation is made through names)
Remove unwanted line
Actually call StimulusJS controller instead of calling the reflex itself
In order to have this "showLoading", "hideLoading" behavior.
It seems to be possible to directly use the Reflex itself (use `data-reflex` instead of `data-action`) but I can't make it work: the `stimulus-controller:after` event is never broadcasted/catched (but `stimulus-controller:before` yes...)
Documentation:
https://docs.stimulusreflex.com/guide/reflexes.html#understanding-stimulusreflex-controllers
https://docs.stimulusreflex.com/guide/lifecycle.html#generic-life-cycle-methods
Maybe @dacook if you want to have a look...
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
3b61508652
Be more specific to only apply to the first container, ie. the root one
...
+ Override default position (relative) in order to have loading above
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
47f21cb59e
Add pagination with pagy
...
For `admin_style_v3` use `<` and `>` for next and previous link
instead of `next` and `previous` string
Extract a mixin for a default box-shadow
Maybe this needs to be redefined. Let's see how next things goes.
When a table is followed by a pagination, remove its margin-bottom + border
Finally, design the pagination component
Add sorting/pagination module, on top of table
We use `cablea_ready.replace`, so need to add `#products-content` id
Use a `pagy` partial with reflex action, instead of the legacy one
- revert the legacy one to its previous state
- in reflex, fetch product with page attribute, 1 by default
Move `pagy` into `admin/shared/v3/` to be reusable
+ use fontawesome icons for next and previous page
Remove useless line
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
69cff85577
Change color to EFF1F2
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9b92c25879
Add a section for specific rules for both admin-menu and sub-menu
...
+ change height for border bottom on selected/hovered menu
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
9762819aa8
Use the right color
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
1f3d41972f
Add same padding than #admin-menu,#sub-menu li a in order to align
...
content (header, navigation, content) on both left and right
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
2892301336
Factorize menu and submenu into same definition
...
as they are the same, expect the font-size
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
24c045a09c
Reduce padding
2023-07-19 14:58:39 +02:00
Jean-Baptiste Bellet
a8088ae231
Create a pseudo element to add a line under the menu item
...
- Increase top menu underline height to 3px
- reduce underline width to same width of label
2023-07-19 14:58:39 +02:00
Konrad
d99ac35824
Merge pull request #11105 from jibees/11098-summary-step-order-details-line-break-on-currency-symbol-and-lettering
...
Checkout summary: avoid carriage return on price
2023-07-19 13:00:08 +02:00
Filipe
91e2e447c0
Merge pull request #11175 from jibees/11171-checkout-step-3-delivery-details-are-showing-bill-address-instead-of-delivery-address
...
Checkout, Summary step: Display the ship/delivery address (instead of the billing one)
2023-07-19 11:36:19 +01:00
Filipe
843bcaa500
Merge pull request #11184 from rioug/11183-fix-delete-voucher-tax-excl-price
...
[vouchers] fix delete voucher when tax excluded from price
2023-07-19 11:24:25 +01:00
dependabot[bot]
314c02a92b
chore(deps-dev): bump knapsack_pro from 5.2.0 to 5.3.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.2.0 to 5.3.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.2.0...v5.3.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:31:24 +00:00
dependabot[bot]
6c323c82d5
chore(deps): bump mini_portile2 from 2.8.2 to 2.8.4
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.2 to 2.8.4.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.2...v2.8.4 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:27:32 +00:00
Jean-Baptiste Bellet
731fb3c0b3
Update cable_ready and stimulus_reflex as well
...
In order to reflect the one used in package.json
2023-07-19 09:05:31 +02:00
dependabot[bot]
385f3964ad
chore(deps): bump stimulus_reflex from 3.5.0-rc2 to 3.5.0-rc3
...
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex ) from 3.5.0-rc2 to 3.5.0-rc3.
- [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases )
- [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits )
---
updated-dependencies:
- dependency-name: stimulus_reflex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 09:05:31 +02:00
jibees
8475a31ebb
Merge pull request #11228 from openfoodfoundation/dependabot/npm_and_yarn/word-wrap-1.2.4
...
chore(deps): bump word-wrap from 1.2.3 to 1.2.4
2023-07-19 08:51:34 +02:00
dependabot[bot]
dd7e6d1a19
chore(deps): bump word-wrap from 1.2.3 to 1.2.4
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-19 02:14:43 +00:00
Neal Chambers
c1095c3616
Update .rubocop_todo.yml
2023-07-19 08:43:36 +09:00
Neal Chambers
728926cc9a
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
Filipe
40db81f056
Merge pull request #11150 from macanudo527/fix_admin_class_size
...
Fix Metrics/ClassSize
2023-07-18 19:10:03 +01:00
Filipe
15282f9738
Merge pull request #11115 from abdellani/fix-enterprise-users-should-have-access-to-invoices
...
authorize enterprise users to access invoices page
2023-07-18 16:42:00 +01:00
jibees
11b2d911d2
Merge pull request #11217 from openfoodfoundation/dependabot/bundler/rubocop-1.54.2
...
chore(deps-dev): bump rubocop from 1.54.1 to 1.54.2
2023-07-18 17:31:17 +02:00
jibees
bbdeb0c9ab
Merge pull request #11213 from openfoodfoundation/dependabot/bundler/rswag-specs-2.10.1
...
chore(deps-dev): bump rswag-specs from 2.9.0 to 2.10.1
2023-07-18 17:29:37 +02:00
jibees
4e29fcba64
Merge pull request #11210 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.5
...
chore(deps): bump @floating-ui/dom from 1.4.4 to 1.4.5
2023-07-18 17:14:41 +02:00
dependabot[bot]
a975b78816
chore(deps-dev): bump rubocop from 1.54.1 to 1.54.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.54.1 to 1.54.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.54.1...v1.54.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 15:08:00 +00:00
dependabot[bot]
02b1c6dd2d
chore(deps-dev): bump rswag-specs from 2.9.0 to 2.10.1
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 15:07:21 +00:00
jibees
af365c6b79
Merge pull request #11215 from openfoodfoundation/dependabot/bundler/rswag-api-2.10.1
...
chore(deps): bump rswag-api from 2.9.0 to 2.10.1
2023-07-18 17:06:07 +02:00
jibees
f054b74c7d
Merge pull request #11216 from openfoodfoundation/dependabot/bundler/rswag-ui-2.10.1
...
chore(deps): bump rswag-ui from 2.9.0 to 2.10.1
2023-07-18 17:05:15 +02:00
Filipe
adc5692bc5
Merge pull request #11182 from filipefurtad0/profile_change_spec
...
Adds spec for profile change
2023-07-18 16:02:39 +01:00
jibees
1d03f7a009
Merge pull request #11224 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.2.0
...
chore(deps-dev): bump knapsack_pro from 5.1.2 to 5.2.0
2023-07-18 16:30:45 +02:00
dependabot[bot]
74f8f9dd52
chore(deps): bump rswag-api from 2.9.0 to 2.10.1
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:58 +00:00
dependabot[bot]
dae690ae5c
chore(deps): bump rswag-ui from 2.9.0 to 2.10.1
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.9.0...2.10.1 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:55 +00:00
dependabot[bot]
53b1188a43
chore(deps): bump @floating-ui/dom from 1.4.4 to 1.4.5
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.4 to 1.4.5.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.5/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 14:28:47 +00:00
dependabot[bot]
6c02e1c05d
chore(deps-dev): bump knapsack_pro from 5.1.2 to 5.2.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.1.2 to 5.2.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.2...v5.2.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 09:18:55 +00:00
Gaetan Craig-Riou
a5b2bc6293
Per review, Refactor VoucherAdjustmentsService
...
Change #calculate to #update and clean up internal code
2023-07-18 15:16:21 +10:00
Gaetan Craig-Riou
a584f9aaec
Refactor VoucherAdjustmentsService
...
It's more inline with existing coding style
2023-07-18 14:39:01 +10:00
David Cook
46b27b2d9d
Number release steps
...
There are three distinct parts to the process, so I thought it worth giving them an identifying number.
2023-07-18 09:34:28 +10:00
Neal Chambers
8fc0a20249
Add Additional Test for Model Creation
2023-07-18 08:17:34 +09:00
Neal Chambers
ba862bc4b7
Add tests for Enterprise Fees Bulk Update
2023-07-18 08:17:34 +09:00
Neal Chambers
186d7a2f54
Move and Rename BulkUpdateForm
2023-07-18 08:17:34 +09:00
David Cook
9b16c1171f
Remove redundant returns
...
The return value of active record validations doesn't actually do anything. A record is 'valid?' if @errors is empty.
2023-07-18 08:17:34 +09:00
Neal Chambers
521af70959
Add Strong Params to Enterprise Fees Form
2023-07-18 08:17:34 +09:00
Neal Chambers
9e17b80ea9
Update .rubocop_todo.yml
2023-07-18 08:17:34 +09:00
Neal Chambers
fb1ae855c2
Fix Metrics/ClassLength
2023-07-18 08:17:34 +09:00
filipefurtad0
e14bc5e642
Adds comments on producer_profile_only attribute
...
Fixing typo
2023-07-17 15:06:02 +01:00
filipefurtad0
16477cad51
Adds spec for profile change (2)
...
via enterprises path
2023-07-17 15:06:02 +01:00
filipefurtad0
e0be25f927
Adds spec for profile change
...
via admin path
2023-07-17 15:06:02 +01:00
Jean-Baptiste Bellet
1cf647e04b
Avoid line-break by wrapping into nowrap element
2023-07-17 14:00:48 +02:00
Jean-Baptiste Bellet
776b9adc72
Display shipping address in summary step, instead of the billing one
...
+ update specs accordingly
2023-07-17 09:37:05 +02:00
Jean-Baptiste Bellet
f177258444
Randomize also city and zipcode for randomized address
2023-07-17 09:33:29 +02:00
filipefurtad0
bfb2fc528e
Update all locales with the latest Transifex translations
2023-07-14 17:37:22 +01:00
dependabot[bot]
654601f4b2
chore(deps): bump stripe from 8.5.0 to 8.6.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.5.0 to 8.6.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.5.0...v8.6.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-14 09:09:19 +00:00
Gaetan Craig-Riou
0e0850ef49
Add specs to cover re calculation
...
It is important that the calculated voucher adjustments don't change
if they are recalculated and it is equally important that they are
updated if the order has changed
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
5a59396a41
Remove call to VoucherAdjustmentService when creating a voucher
...
Voucher will be automatically applied when the order transition to
the confirmation step. No need to do the work twice.
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
3d9542fec2
Per review, rename amount to adjustment_amount
...
It was confusing as I was re assigning a variable given as a parameter
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
41271192e1
Per review, Makes quantity change more explicit
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
751056ba39
As per review comment, spell out voucher code when entering a voucher
...
Plus, update other related spec to be consistent
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
789ce39ff4
Fixing Rubocop errors
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
a8062e951a
Add a scenario to make sure voucher adjustment a recalculated
...
This is specificly for voucher with a tax component, but it will
also become relevant for percentage based voucher.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
edabc56b5c
Add voucher calculation after updating an order
...
This is to make sure the voucher are recalculated when a customer
update the order content from the `/cart` page. This is tested
with system test
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
ca7dcb82b8
Apply voucher after transitionning to the confirmation step
...
Testing that VoucherAdjustmentsService.calculate has been called after a
transition doens't work, skipping test for now.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
366cca7984
Prevent voucher adjustment from bein updated when update is called
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
87790b29ae
Fix VoucherAdjustmentsService.calculate so we can call it mutiple time
...
It now uses `order.pre_discount_total` to make any calculation, that
means you can call it multiple time and you will still get the same
adjustment amount, included_tax and tax adjustment when needed. This
is assuming nothing changed on the order.
2023-07-14 14:47:03 +10:00
Gaetan Craig-Riou
60c0c54eb2
Update create_adjustment to create with an amount of 0
...
Amount calculation is handled by VoucherAdjustmentService.calculate
2023-07-14 14:47:03 +10:00
Matt-Yorkley
04bbea53e1
Move voucher processing out of checkout controller
2023-07-14 14:46:16 +10:00
Gaetan Craig-Riou
dc711bde78
Fix voucher adjustment delete
...
When using a voucher with tax not incluced in price, we need to delete
both the voucher adjustment and the tax adjustment
2023-07-14 13:37:45 +10:00
Konrad
bddc10626b
Merge pull request #11148 from cillian/fix-duplicate-rows-in-customer-addresses-report
...
Don't return duplicate rows in the customer addresses report
2023-07-13 20:32:01 +02:00
Filipe
9e0aa1854f
Merge pull request #11159 from abdellani/remove-split-checkout-from-feature_toggle
...
Remove split checkout from feature toggle
2023-07-13 17:20:18 +01:00
Filipe
308ce9263d
Merge pull request #11170 from jibees/11160-bulk-actions-function-not-working-on-safari-mac-browser
...
Admin, Orders: Make bulk actions dropdown re-enabled for Safari browser
2023-07-13 17:17:18 +01:00
Filipe
2f8a056bee
Merge pull request #11187 from jibees/10975-white-label-remember-custom-tab-activation-after-error-message
...
Admin, White Label: check the custom tab checkbox if any errors on custom tab (ie. title is blank)
2023-07-13 16:43:18 +01:00
Filipe
60c75097d3
Merge pull request #11145 from mkllnk/dfc-create-response
...
DFC API return SuppliedProduct after creation
2023-07-13 16:15:22 +01:00
Filipe
448d5ea017
Merge pull request #11135 from Matt-Yorkley/vouchers
...
Vouchers part 2
2023-07-13 12:50:32 +01:00
jibees
9f86218a83
Merge pull request #11202 from openfoodfoundation/dependabot/bundler/view_component-3.4.0
...
chore(deps): bump view_component from 3.3.0 to 3.4.0
2023-07-12 16:00:48 +02:00
dependabot[bot]
e03ffa0405
chore(deps): bump view_component from 3.3.0 to 3.4.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.3.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-12 09:25:11 +00:00
jibees
f22b8db462
Merge pull request #11191 from openfoodfoundation/dependabot/npm_and_yarn/semver-5.7.2
...
chore(deps): bump semver from 5.7.1 to 5.7.2
2023-07-11 17:38:28 +02:00
dependabot[bot]
90ad6ce19d
chore(deps): bump semver from 5.7.1 to 5.7.2
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-11 09:43:07 +00:00
Matt-Yorkley
4884a8c368
Merge pull request #11179 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.1
...
chore(deps): bump cable_ready from 5.0.0 to 5.0.1
2023-07-11 10:42:37 +01:00
David Cook
d03b88cf83
Rename variables
...
To make it clear they are arrays
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
0fdf7876a6
Instanciate instance variable + use spread operator to be more concise
...
and efficient ;)
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
4bcba86fc8
Avoid error when testing through jest about removing event listenner
...
Avoid:
```
TypeError: Cannot read properties of null (reading 'removeEventListener')
at extended.disconnect (/home/runner/work/openfoodnetwork/openfoodnetwork/app/webpacker/controllers/dropdown_controller.js:32:14)
at Context.disconnect (/home/runner/work/openfoodnetwork/openfoodnetwork/node_modules/stimulus/dist/stimulus.umd.js:1441:25)
```
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
6143f4ce6f
Use dropdown controller to manager actions dropdown in orders page
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
7084c53f38
Do not display menu is the dropdown is 'disabled'
...
ie. classList contains `disabled`
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
02aea989be
Add on_click_outside behavior on dropdown_controller
...
"It's a Surprise Tool That Will Help Us Later"
2023-07-11 10:48:52 +02:00
Jean-Baptiste Bellet
d78af187e0
Allow dropdown controller to toggle more than one class
...
"It's a Surprise Tool That Will Help Us Later"
2023-07-11 10:48:51 +02:00
Mohamed ABDELLANI
4b003aa08b
replace status:status with cancelled:boolean on invoice model
2023-07-11 09:15:25 +01:00
David Cook
bb1d053825
Merge pull request #11162 from dacook/DropSpreePromotionTables
...
Drop unused Spree Promotion Tables
2023-07-11 10:16:45 +10:00
Jean-Baptiste Bellet
a8b9d9d8af
Check the custom tab checkbox if any errors (ie. title is blank)
2023-07-10 16:31:33 +02:00
Gaetan Craig-Riou
9f1b4f56c0
Merge pull request #11181 from openfoodfoundation/dependabot/npm_and_yarn/tough-cookie-4.1.3
...
chore(deps): bump tough-cookie from 4.0.0 to 4.1.3
2023-07-10 12:03:02 +10:00
David Cook
b6d10df332
DropSpreePromotionTables
2023-07-10 10:51:44 +10:00
dependabot[bot]
c299f891e0
chore(deps): bump tough-cookie from 4.0.0 to 4.1.3
...
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie ) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases )
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md )
- [Commits](https://github.com/salesforce/tough-cookie/compare/v4.0.0...v4.1.3 )
---
updated-dependencies:
- dependency-name: tough-cookie
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-09 11:11:55 +00:00
Jean-Baptiste Bellet
dab595f17f
Update all locales with the latest Transifex translations
2023-07-07 17:11:40 +02:00
Filipe
f0bcb79c09
Merge pull request #11169 from openfoodfoundation/11164-admin-orders-actions-dropdown-is-not-well-placed
...
Fix container issues introduced by #11123
2023-07-07 11:15:14 +01:00
jibees
967c5a99c3
Merge pull request #11167 from openfoodfoundation/dependabot/bundler/faraday-2.7.10
...
chore(deps): bump faraday from 2.7.9 to 2.7.10
2023-07-07 11:50:01 +02:00
jibees
72fa132c17
Merge pull request #11172 from openfoodfoundation/dependabot/bundler/sanitize-6.0.2
...
chore(deps): bump sanitize from 6.0.1 to 6.0.2
2023-07-07 11:44:16 +02:00
dependabot[bot]
2310c665c3
chore(deps): bump cable_ready from 5.0.0 to 5.0.1
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:35:52 +00:00
dependabot[bot]
9f539df5e0
chore(deps): bump sanitize from 6.0.1 to 6.0.2
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: sanitize
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:31 +00:00
dependabot[bot]
74ef681607
chore(deps): bump faraday from 2.7.9 to 2.7.10
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.9 to 2.7.10.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.9...v2.7.10 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:22 +00:00
David Cook
17da66b72a
Update contents of variable directly
...
Also, it makes the line shorter, allowing us to use one-line if syntax :)
2023-07-07 14:22:36 +10:00
Gaetan Craig-Riou
fb3c99e52c
Merge pull request #11121 from filipefurtad0/cart_state_orders_not_appearing_orders_page
...
Cart state orders not appearing orders page
2023-07-07 09:27:36 +10:00
Matt-Yorkley
eb71c65fc0
Merge pull request #11138 from Matt-Yorkley/variant-timestamps
...
Add timestamps to variants table
2023-07-06 18:22:19 +01:00
Mohamed ABDELLANI
f68064480a
authorize distributor manager to generate invoices
2023-07-06 17:36:13 +01:00
Maikel Linke
11a4cd8613
Protect invoicing against unauthorized use
...
This could be optimised for performance but this was the simplest way
and we can work on it if performance becomes a problem.
2023-07-06 17:36:13 +01:00
Maikel Linke
15c30246a5
Allow to see only invoices of managed enterprises
2023-07-06 17:36:13 +01:00
Maikel Linke
46410b5be2
Test the right invoices controller
...
I was wondering why the spec didn't work and then I noticed that it was
testing the wrong controller and passing the wrong parameter.
2023-07-06 17:36:13 +01:00
Maikel Linke
85002d3804
Spec bug allowing any enterprise to view invoices
2023-07-06 17:36:13 +01:00
Maikel Linke
145696aa7f
Create only used test data
...
The `params` and the user are created before the request. But, for
example, the enterprise user doesn't need creating when testing
permissions of the normal user.
2023-07-06 17:36:13 +01:00
Mohamed ABDELLANI
3a9a023dea
authorize enterprise users to access invoices page
2023-07-06 17:36:13 +01:00
Matt-Yorkley
bbf53133cb
Add timestamps to variants table
2023-07-06 16:16:03 +01:00
jibees
2e9442a7ab
Merge pull request #11127 from openfoodfoundation/dependabot/bundler/vcr-6.2.0
...
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
2023-07-06 16:43:49 +02:00
dependabot[bot]
de384ac261
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
...
Bumps [vcr](https://github.com/vcr/vcr ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/vcr/vcr/releases )
- [Changelog](https://github.com/vcr/vcr/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vcr/vcr/compare/v6.1.0...v6.2.0 )
---
updated-dependencies:
- dependency-name: vcr
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 14:22:55 +00:00
Filipe
ba1ba6dbec
Merge pull request #11092 from mkllnk/bye-datadog
...
Remove datadog gem, too expensive
2023-07-06 15:20:20 +01:00
Filipe
99ed019413
Merge pull request #11136 from Matt-Yorkley/remove-available-on
...
Remove :available_on attribute from Product
2023-07-06 15:20:08 +01:00
jibees
3f070d7152
Merge pull request #11166 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.4
...
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
2023-07-06 16:13:35 +02:00
jibees
5f54c7fe56
Merge pull request #11146 from openfoodfoundation/dependabot/bundler/rails-7.0.6
...
chore(deps): bump rails from 7.0.5 to 7.0.6
2023-07-06 16:04:16 +02:00
jibees
9c035c6114
Merge pull request #11128 from openfoodfoundation/dependabot/bundler/view_component-3.3.0
...
chore(deps): bump view_component from 3.2.0 to 3.3.0
2023-07-06 16:00:51 +02:00
Matt-Yorkley
42a3087cdb
Remove :available_on attribute from Product class
2023-07-06 14:36:35 +01:00
Jean-Baptiste Bellet
6ee388fe51
Fix container issues
2023-07-06 11:41:54 +02:00
dependabot[bot]
5c56c9b60b
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 09:10:25 +00:00
David Cook
05a22b80bc
Merge pull request #11123 from dacook/buu-products-table
...
[admin_style_v3] Products table with variants
2023-07-06 09:37:31 +10:00
Filipe
39b597096c
Merge pull request #11137 from Matt-Yorkley/remove-product-permalink
...
Remove :permalink attribute from Product
2023-07-05 18:35:48 +01:00
Matt-Yorkley
652beac73f
Drop valid? check from zero_priced_order? method
2023-07-05 15:31:05 +01:00
Mohamed ABDELLANI
17b71b0f8d
remove split checkout context from customer spec
...
We don't need to enable split checkout, as this is default and unique mode.
2023-07-05 14:54:07 +01:00
Mohamed ABDELLANI
a89451e667
remove splitcheckout from feature toggle list
2023-07-05 14:53:40 +01:00
jibees
de34b9b109
Merge pull request #11142 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.3
...
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
2023-07-05 14:53:53 +02:00
dependabot[bot]
2a059fd879
chore(deps): bump rails from 7.0.5 to 7.0.6
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 12:52:51 +00:00
jibees
9205aafbd9
Merge pull request #11147 from openfoodfoundation/dependabot/bundler/faraday-2.7.9
...
chore(deps): bump faraday from 2.7.6 to 2.7.9
2023-07-05 14:52:00 +02:00
jibees
409cf54a45
Merge pull request #11152 from openfoodfoundation/dependabot/bundler/state_machines-activerecord-0.9.0
...
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
2023-07-05 14:49:08 +02:00
jibees
24f9770acc
Merge pull request #11154 from openfoodfoundation/dependabot/bundler/rubocop-1.54.1
...
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
2023-07-05 14:48:15 +02:00
jibees
722f7b981b
Merge pull request #11158 from openfoodfoundation/dependabot/bundler/geocoder-1.8.2
...
chore(deps): bump geocoder from 1.8.1 to 1.8.2
2023-07-05 14:47:12 +02:00
dependabot[bot]
20bc6c8028
chore(deps): bump geocoder from 1.8.1 to 1.8.2
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.8.1 to 1.8.2.
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.8.1...v1.8.2 )
---
updated-dependencies:
- dependency-name: geocoder
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 09:23:48 +00:00
David Cook
7e0042ea1d
Apply code suggestion
...
Co-authored-by: Gaetan Craig-Riou <gaetan.riou@gmail.com >
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2023-07-05 11:27:03 +10:00
Cillian O'Ruanaidh
a80ff6097a
Improve formatting in spec/lib/reports/customers_report_spec.rb
2023-07-04 18:27:57 +01:00
Matt-Yorkley
671dfc7082
Don't flush errors when checking zero priced order validity
2023-07-04 14:42:31 +01:00
Matt-Yorkley
66a546027f
Add test coverage for handling zero priced orders
2023-07-04 13:13:05 +01:00
Gaetan Craig-Riou
74073946e6
Move VoucherAdjustmentsController to request specs
2023-07-04 13:13:05 +01:00
Matt-Yorkley
55cc57cf87
Use pre_discount_total when comparing to voucher amount
2023-07-04 13:13:05 +01:00
Matt-Yorkley
ad6d0c1c73
Add nil safety in reports for zero priced orders with no payment method
2023-07-04 13:13:05 +01:00
Matt-Yorkley
2aa3f8eb89
Fix flaky test
2023-07-04 13:13:05 +01:00
Matt-Yorkley
f7912a2240
Fix CSS/layout issues
2023-07-04 13:13:05 +01:00
Matt-Yorkley
672400192f
Update use of params
2023-07-04 13:13:05 +01:00
Matt-Yorkley
37a4c73a12
Fix rubocop complaint
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9b45b71696
Improve feature toggling
2023-07-04 13:13:05 +01:00
Matt-Yorkley
2f0f3e0820
Re-enable voucher test
2023-07-04 13:13:05 +01:00
Matt-Yorkley
28795effc3
Clarify named vouchers in UI
2023-07-04 13:13:05 +01:00
Matt-Yorkley
de97e69e7d
Show/hide payment methods if voucher changes order total to zero
2023-07-04 13:13:05 +01:00
Matt-Yorkley
55bce9f1b2
Remove @voucher_adjustment instance variable
2023-07-04 13:13:05 +01:00
Matt-Yorkley
7a0b83076b
Move loading of saved cards out of checkout concern
2023-07-04 13:13:05 +01:00
Matt-Yorkley
1cd38c957d
Introduce "zero priced orders" in admin order payments UI and helper
2023-07-04 13:13:05 +01:00
Matt-Yorkley
bd29a9acde
Introduce "zero priced orders" to checkout UI and order state flow
2023-07-04 13:13:05 +01:00
Matt-Yorkley
a65b3b8b60
Extract voucher tests to separate controller spec
2023-07-04 13:13:05 +01:00
Matt-Yorkley
d7950617ec
Drop superfluous method
2023-07-04 13:13:05 +01:00
Matt-Yorkley
47b5a3fb1d
Don't apply tax calculations if there's no tax
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9e5061fc31
Move voucher processing out of checkout controller
2023-07-04 13:13:05 +01:00
dependabot[bot]
eba8d8db83
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.1 to 1.54.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.1...v1.54.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-04 09:26:38 +00:00
filipefurtad0
e547e735c0
Adds test on API call for orders page
...
Removes unecessary assertion on http status
2023-07-03 11:51:46 +01:00
filipefurtad0
3f7958afe3
Adds regression test to issue #11120
2023-07-03 11:51:46 +01:00
Matt-Yorkley
91004588f6
Add separate voucher form
2023-07-03 11:03:05 +01:00
Matt-Yorkley
3f83da9928
Move voucher section out of main checkout form
2023-07-03 11:03:05 +01:00
Matt-Yorkley
e04a3f6b4d
Move form definition down into each checkout step
2023-07-03 11:03:05 +01:00
Matt-Yorkley
75e6ccd580
Simplify voucher controller
2023-07-03 11:03:05 +01:00
Matt-Yorkley
3d44f4bc98
Introduce "zero priced order" concept with no required payment
...
This applies to cases where an order contains items with zero price or where applied vouchers have reduced the order's total to zero.
2023-07-03 11:03:05 +01:00
dependabot[bot]
a9cb35dcc0
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
...
Bumps [state_machines-activerecord](https://github.com/state-machines/state_machines-activerecord ) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/state-machines/state_machines-activerecord/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: state_machines-activerecord
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-03 09:58:39 +00:00
Maikel Linke
4a562d0e7f
Add workaround for updated DFC v1.8 URLs
...
Once the DFC Connector was updated we can all use the new URLs. But for
now we have the old ones and add some compatibility to the old ones.
2023-07-03 16:05:18 +10:00
Maikel Linke
fc46dbacdc
Spec DFC Connector import behaviour around context
...
The DFC updated the URLs in their context, basically changing the ids of
all data types. I'll add a hacky workaround in the next commit.
2023-07-03 16:05:18 +10:00
Maikel Linke
9183c8acdd
Deal with bad SuppliedProduct data
2023-07-03 14:17:18 +10:00
Maikel Linke
18bcc179ef
Clarify request body required to create product
...
We have to work around an Rswag limitation here. But I think that this
version is clearer on the spec.
2023-07-03 14:17:18 +10:00
Maikel Linke
d5c41980d6
Document example for updating SuppliedProduct
2023-07-03 13:44:57 +10:00
Maikel Linke
7dc6cb151d
Include DFC context in spec example
...
The DFC Prototype does include the context while the output of the DFC
Connector refers to the URL of the published context. While that's more
efficient, it's also brittle because the context is updated from time to
time. That happened three days ago and working with the newly published
context breaks our integration until we get an updated version of the
DFC Connector containing the new URLs for datatypes.
2023-07-03 13:27:24 +10:00
Maikel Linke
7b9e4f6914
Move test files to own directory
2023-07-03 13:25:55 +10:00
Maikel Linke
811740c361
Correct OFN session cookie name
...
And improve the documentation in general.
2023-07-03 13:25:55 +10:00
Maikel Linke
7a51995aeb
Respond with SuppliedProduct data when creating
2023-07-03 12:37:23 +10:00
Maikel Linke
5a4efdbce3
Separate DFC API swagger config
...
This allows us to run the specs separately to generate the
documentation. It's more efficient this way and the separate swagger doc
file is easier to read.
The engine-specific swagger helper also allows us to simplify the spec
files.
Added an exception to our styleguide because it's intended and useful to
have a complete (lengthy) description of the API in one block.
2023-07-03 12:37:23 +10:00
Maikel
400d087789
Merge pull request #11133 from mkllnk/dfc-api-specs
...
OFN DFC API documenation in OpenAPI format generated with Rswag
2023-07-03 10:53:40 +10:00
Maikel
ffda344838
Merge pull request #11144 from mkllnk/remove-test-unit
...
Remove unused gem test-unit
2023-07-03 10:34:24 +10:00
Cillian O'Ruanaidh
bf44284237
Don't return duplicate rows in the customer addresses report
2023-06-30 17:10:44 +01:00
Matt-Yorkley
fefa9288a4
Remove :permalink attribute from Product
2023-06-30 11:37:57 +01:00
Filipe
b175793b91
Merge pull request #10704 from abdellani/hide-customers-with-no-completed-orders
...
Hide users with no completed orders from a hub's customers list
2023-06-30 10:56:56 +01:00
dependabot[bot]
7c9cabbab7
chore(deps): bump faraday from 2.7.6 to 2.7.9
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.6 to 2.7.9.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.6...v2.7.9 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-30 09:34:58 +00:00
Maikel Linke
9c2d092f4d
Remove unused gem test-unit
2023-06-30 11:37:57 +10:00
filipefurtad0
efb5132ac2
Update all locales with the latest Transifex translations
2023-06-29 23:28:28 +01:00
Filipe
54a85a504d
Merge pull request #11101 from mkllnk/dfc-api-key
...
Allow access to DFC API with OFN API token
2023-06-29 17:20:21 +01:00
Filipe
d27a632a38
Merge pull request #11079 from abdellani/fix-distributors-listing-on-checkout-options
...
filter distributors before listing on checkout options
2023-06-29 17:02:34 +01:00
Filipe
36f4b2e7f9
Merge pull request #11107 from jibees/11085-edit-variant-cant-update-values-on-the-variant-edit-page
...
Admin, Edit variant: remove unwanted extra space on price (added in certain specific conditions)
2023-06-29 16:46:42 +01:00
Filipe
97f131e556
Merge pull request #11089 from jibees/11049-invoices-actions-dropdown-menu-disappears-after-creating-the-first-invoice
...
[Invoices] Actions dropdown menu disappears after creating the first invoice
2023-06-29 16:23:35 +01:00
Filipe
da226ea021
Merge pull request #11109 from mkllnk/image-urls
...
Gracefully deal with missing S3 config
2023-06-29 12:50:36 +01:00
Filipe
d92c7f89bd
Merge pull request #11022 from Matt-Yorkley/matomo
...
Call matomo manually on asynchronous page visits
2023-06-29 12:02:48 +01:00
dependabot[bot]
af4ae4aaae
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-29 09:59:20 +00:00
Jean-Baptiste Bellet
045435e9cc
use the variant price itself
2023-06-29 11:02:56 +02:00
Jean-Baptiste Bellet
3286094804
number_to_currency can be nil: use a safe operator
2023-06-29 10:47:00 +02:00
Maikel Linke
8b3f45263c
Remove unnecessary spec clean-up
...
And clarify locale setup.
2023-06-29 10:40:01 +02:00
Jean-Baptiste Bellet
2fcf706aa3
Remove unwanted space at the end of the price
...
This `number_to_currency` method seems to display an extra space, not necessary when unit is `''`
Strip it.
Update specs as well. Thanks @filipefurtad0 for specs!!!
2023-06-29 10:40:01 +02:00
filipefurtad0
6b84fbf2b8
Adds after block, to remove configurations
...
Sets pending shared examples
2023-06-29 10:40:01 +02:00
filipefurtad0
504ee50dd4
Sets up a spec for #11085
2023-06-29 10:40:00 +02:00
David Cook
0ba342bf11
Merge pull request #10965 from macanudo527/fix_linelength_bundle2
...
Fix Layout/LineLength - Bundle 2
2023-06-29 15:27:08 +10:00
Maikel
dd1e1328cc
Merge pull request #11080 from rioug/fix-bulk-order-cancelation-spec
...
Fix bulk order cancellation test
2023-06-29 14:44:04 +10:00
Maikel
46ddab3781
Merge pull request #11088 from Matt-Yorkley/deployments-check
...
Update workflow permissions check to latest version
2023-06-29 14:34:46 +10:00
Maikel
6392c2c115
Merge pull request #11075 from mkllnk/test-cache
...
Use Redis for caching in test environment
2023-06-29 14:33:09 +10:00
Maikel Linke
029364d4a3
Express spec intent with DSL instead of comment
2023-06-29 14:25:50 +10:00
David Cook
714642f331
Use different Redis database for test environment
2023-06-29 14:15:18 +10:00
Filipe
ba99f85f5c
Merge pull request #10914 from abdellani/fix-stripe-sca-failure
...
redirect user to payment when the card doesn't have enough credit
2023-06-28 19:58:18 +01:00
Matt-Yorkley
ace2c5778f
Call matomo manually on Turbo page visits
2023-06-28 12:52:54 +01:00
Matt-Yorkley
a0a1f8f910
Merge pull request #11002 from openfoodfoundation/voucher-prep
...
Vouchers part 1
2023-06-28 11:30:12 +01:00
Maikel Linke
78d6d129e8
Simplify with extracted helper method
2023-06-28 14:11:50 +10:00
Maikel Linke
d21e6f99bb
Swaggerise CatalogItems spec
2023-06-28 14:11:50 +10:00
Maikel Linke
883e637545
Create deterministic test data for stable API docs
...
Otherwise the auto-generated Swagger file changes all the time without
code changes.
2023-06-28 13:50:54 +10:00
Maikel Linke
df29eaab98
Document DFC example body to create a product
2023-06-28 13:50:54 +10:00
Maikel Linke
db77d1591c
Add test examples to DFC API documentation
...
In other API specs, you provide example values in the schema. So the
specs contain examples which can be used for the documentation. But
instead of defining example data separately, we can use the generated
data by the specs. This way we document real output and don't have to
double up on documentation.
Note that we don't have schema definitions for the DFC API yet. And it
wouldn't make sense to replicate the DFC Ontology manually in JSON
Schema for this purpose. The DFC Connector ensures already that we
comply with the ontology. But I hope that we can use a tool at some
point to generate JSON Schema from the DFC Ontology which would add more
detail to the Swagger docs, I think.
2023-06-28 13:50:54 +10:00
Maikel Linke
b14c9bdf4c
Swaggerize SuppliedProduct spec
2023-06-28 13:50:54 +10:00
Maikel Linke
f0a5475563
Swaggerize Enterprise spec
2023-06-28 13:50:54 +10:00
Maikel Linke
7c0a4108d8
Show api-docs in production as well
...
We were hiding that before because the API is not officially released
yet but that's actually quite annoying. It's very conenient to have the
UI on production and be able to try out endpoints.
2023-06-28 13:50:54 +10:00
Maikel Linke
494c5e78de
Swaggerize Person spec
...
I chose the simplest spec first to demonstrate how it works. The UI at
/api-docs now shows this endpoint with two possible responses.
The docs are missing an example response which I hope to add later.
2023-06-28 13:50:54 +10:00
Maikel Linke
8368a6ccc9
Announce the new DFC endpoint
...
We need to declare in each spec file for which endpoint the spec is
because it was just choosing the first declared one by default. The
first one was v1 and now it's dfc-v1.7.
2023-06-28 13:50:54 +10:00
Maikel Linke
de51a7833d
Add script to swaggerize DFC API in its engine
...
Rswag doesn't look for specs in engines by default. We haven't added any
Rswag specs in the dfc_provider engine yet but that will come.
The generated API schema has some superfluous whitespace removed due to
a fix in the rswag gems.
2023-06-28 13:50:54 +10:00
David Cook
f280881126
Style tables with relaxed and condensed rows
...
* attempt with shadows, but they are between every row: http://jsfiddle.net/d872e3nb/
* another attempt at applying styles to tbody groups http://jsfiddle.net/sb38cLdu/
2023-06-28 09:59:57 +10:00
David Cook
2c14fe0434
Add variant rows and price column
2023-06-28 09:59:57 +10:00
David Cook
9c573f823a
Move .content under main content div
...
The .content div provides overall page margins and a max width, and is already nested inside the nav menus (this allows the nav background to fill the full width of the page.
The main content area should be structured the same way, so we can have flexibility needed to allow some screens to use the full page.
This doesn't seem to change the layout of any screens in the admin interface.
Now the table content can stretch full width
2023-06-28 09:59:57 +10:00
David Cook
6a2025b271
Add products table
...
With ellipsis clipping for long lines.
2023-06-28 09:59:57 +10:00
David Cook
809c15b197
Load products page with reflex
...
We will add the products in the next commit.
2023-06-28 09:59:57 +10:00
David Cook
841192fb96
Add new products page
...
Hidden behind admin_style_v3 feature toggle.
2023-06-28 09:59:57 +10:00
David Cook
efcaab5deb
Rename colour variables
2023-06-28 09:59:57 +10:00
dependabot[bot]
d65239fe47
chore(deps): bump view_component from 3.2.0 to 3.3.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.2.0...v3.3.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-27 10:03:13 +00:00
Filipe
748cdaaa52
Merge pull request #10963 from jibees/10956-orders-page-uncaught-error-missing-target-element-tooltip-for-tooltip-controller
...
Admin, Orders list: add tooltip on Edit action icon + capitalize tooltip (instead of uppercasing)
2023-06-27 09:58:34 +01:00
Mohamed ABDELLANI
e678c6149f
extract payment_faild from processing_failed
2023-06-27 09:26:26 +01:00
Mohamed ABDELLANI
4cca823a66
redirect user to payment when the card doesn't have enough credit
2023-06-27 09:14:48 +01:00
Neal Chambers
a4220891c5
Update .rubocop_todo.yml
2023-06-26 13:06:57 +09:00
Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Maikel Linke
c3d49bf31a
Speed up, simplify helper with ActiveRecord scopes
2023-06-26 12:56:00 +10:00
Maikel Linke
61c4fb936a
Test OrderCycleHelper with real data, not mocks
...
It's more realistic and doesn't break with the next change.
2023-06-26 12:55:57 +10:00
Maikel Linke
7f94fbc085
Add common whitespace to spec
2023-06-26 12:48:54 +10:00
Maikel
014fb69d4b
Merge pull request #10964 from macanudo527/fix_linelength_bundle1
...
Fix Layout/LineLength - Bundle 1
2023-06-26 12:10:39 +10:00
Maikel
bb5c5ffc7b
Merge pull request #11078 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.126.0
...
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
2023-06-26 11:11:39 +10:00
Maikel
a7915b8089
Merge pull request #10849 from mkllnk/report-cable
...
Show "loading" screen for background reports and display when ready
2023-06-26 10:25:48 +10:00
Konrad
49db2f30bc
Merge pull request #11014 from mkllnk/specs
...
Restore line item ordering
2023-06-25 21:45:26 +02:00
Konrad
8a8d78c081
Merge pull request #11041 from cillian/export-ofn-uid-column
...
Add an OFN UID column to the Users & Enterprises report
2023-06-25 20:46:18 +02:00
Maikel Linke
ff588cec40
Restore line item ordering
...
The line item sorting by id has been replaced by sorting by completed_at
time: ccb183d60b
While that's a good idea, the query param to order was only defined in
the client Javascript and there was no default ordering. Line items also
get their completed_at date from the order. So it's the same for all
items of the same order and the ordering with that group of line items
was random.
Now we are adding an order in addition. Items are first sorted by date
and then by id if there's any ambiguity.
2023-06-25 19:24:58 +02:00
Cillian O'Ruanaidh
8ab077bed8
Create enterprise inside :it block because it's only needed there so far
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
1984a1feeb
Use more readable click_button helper instead of find and click in users_and_enterprises_spec.rb
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
40b0bfb433
Add an OFN UID column to the Users & Enterprises report
2023-06-25 19:01:42 +02:00
dependabot[bot]
5010d3bbf3
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.124.0 to 1.126.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-25 18:26:42 +02:00
David Cook
6240baec0d
Update app/controllers/admin/enterprises_controller.rb
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2023-06-23 16:18:45 +09:00
Maikel
e065910d2d
Merge pull request #10939 from Matt-Yorkley/master-variants
...
Remove master variants
2023-06-23 13:42:58 +10:00
Maikel Linke
33d212d274
Gracefully deal with missing S3 config
...
I could have split this into several commits:
* DRY direct linking to images.
* Check S3 config before direct linking.
* Just check if service is public instead of relying on name.
Developers may copy a staging or production database or experiment with
S3 storage. But when the S3 config is missing then calling `service`
raises an ArgumentError due to a missing name.
Now we only try to call `service` if the S3 config is present.
2023-06-23 12:41:36 +10:00
David Cook
4bf65e330b
Enable master variants with associated order cycles
...
There's only 5 in UK prod. keeping them is easier than figuring out if it's safe to delete.
2023-06-23 11:50:26 +10:00
David Cook
2025a98f58
Delete stock_items for master variants
...
All variants have stock_items records, but master variants never use them, so these were always redundant.
2023-06-23 11:49:29 +10:00
David Cook
3bff7a9f13
Fix query
...
With deep nesting syntax.
I chose the longer alias 'left_outer_joins' because it's more explicit, and matches the use up on line 121.
2023-06-23 09:11:03 +09:00
Neal Chambers
172b1eea94
Update .rubocop_todo.yml
2023-06-23 09:11:02 +09:00
Neal Chambers
1e4034534c
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
Filipe
bca7813320
Merge pull request #10323 from abdellani/enterprise-fee-w-tax-by-order
...
Enterprise fee w tax by order
2023-06-22 23:25:11 +01:00
Filipe
9293dd379b
Merge pull request #11087 from Matt-Yorkley/image-error-notifications
...
Add image error Bugsnag notifications
2023-06-22 16:30:57 +01:00
Filipe
b4c4381473
Merge pull request #10987 from jibees/10979-white-label-trix-link-unlink-buttons-are-white-text-on-white-background
...
[White Label] Fix colors of custom content editor to have beautiful toolbar
2023-06-22 16:12:25 +01:00
Jean-Baptiste Bellet
7ce3c3f447
Overide a text-transform: uppercase to capitalize
...
Inherit comes from `app/webpacker/css/admin/components/buttons.scss`
2023-06-22 14:15:43 +02:00
Jean-Baptiste Bellet
91d24ba8ab
Add Edit tooptip for action icon in orders table
2023-06-22 14:15:43 +02:00
Matt-Yorkley
c88799618f
Set master variants which are associated to line items to non-master
...
Line items which reference a master variant is a scenario that in theory shouldn't have been valid or even possible for at least 5-6 years, and these old bits of data in theory should have been cleaned up at the time those changes were made. But a couple of servers have some really old data that's not in a nice state.
Here we can just flip the is_master flag to false for those specific (legacy data) cases before deleting any other master variants, to keep the legacy line item data intact.
2023-06-22 13:10:47 +01:00
jibees
22a3b31172
Merge pull request #11100 from mkllnk/remove-json-patch
...
Revert "Fix json v1.8.6 common.rb warning"
2023-06-22 11:11:21 +02:00
jibees
8eee90118e
Merge pull request #11093 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.2
...
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
2023-06-22 10:25:13 +02:00
jibees
5ba9c815cf
Merge pull request #11082 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.20.2
...
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
2023-06-22 10:18:26 +02:00
jibees
300c4ceed2
Merge pull request #11083 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.2
...
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
2023-06-22 10:17:44 +02:00
Mohamed ABDELLANI
b072da142e
filter distributors before listing on checkout options
2023-06-22 09:00:39 +01:00
Maikel Linke
08a06d21fa
Allow access to DFC API with OFN API token
2023-06-22 16:58:12 +10:00
Maikel Linke
82fc6a2a9d
Prepare spec to authenticate with other means
...
I want to add OFN API key support.
2023-06-22 16:27:04 +10:00
Maikel Linke
e7fe04f526
Revert "Fix json v1.8.6 common.rb warning"
...
This reverts commit 21b80db0ee .
This fix was needed for an old version of the JSON module with a newer
version of Ruby. But we updated the json gem since and don't need this
any more.
2023-06-22 12:47:28 +10:00
Matt-Yorkley
f9185ea56e
Remove line items related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 18:08:21 +01:00
Matt-Yorkley
6f5d3ceacc
Remove inventory units related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 17:20:28 +01:00
Jean-Baptiste Bellet
d2534d6645
Be more specific via !important than the default button rule
...
This one should override the default one
2023-06-21 15:01:14 +02:00
Jean-Baptiste Bellet
7d9018c590
Instead of overriding css rules, prefer to not select rules for trix buttons
2023-06-21 15:01:14 +02:00
dependabot[bot]
c532e822e5
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.3.0 to 1.4.2.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.2/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-21 09:57:46 +00:00
Jean-Baptiste Bellet
5d1c32e8cd
Remove linksDropdown which is now unused
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
4ec41572b1
Add spec on Canceling an order
...
Strange that it doesn't exist, but anyway, let's create it!
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
ce28c14544
Replace AngularJS directive to a StimulusJS one
...
Delete _order_links.html.haml_spec.rb
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
7421691506
Creates a dropdown controller with its specs
2023-06-21 10:29:47 +02:00
David Cook
5ec872c6fd
Merge pull request #11008 from mkllnk/dfc-connector-import
...
Prototype: Import products via DFC Connector
2023-06-21 12:23:58 +10:00
Maikel Linke
14b2e0f962
Remove datadog gem, too expensive
2023-06-21 11:44:21 +10:00
Matt-Yorkley
98a56bfcf8
Update workflow permissions check to latest version
2023-06-20 14:41:17 +01:00
Matt-Yorkley
776eac9f52
Add image error Bugsnag notifications
2023-06-20 14:14:19 +01:00
Matt-Yorkley
24aa55e053
Remove array syntax on new product form for product image
2023-06-20 13:14:52 +01:00
dependabot[bot]
e8e3aa5f5d
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.1.0 to 5.1.2.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.0...v5.1.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:31:26 +00:00
dependabot[bot]
584a25052f
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.19.1 to 2.20.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.19.1...v2.20.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:14:06 +00:00
Gaetan Craig-Riou
ea73781668
Fix bulk order cancellation
...
Add unticking of "send cancellation email to customer" to match
the current test expectation
2023-06-20 10:03:55 +10:00
Maikel Linke
a9f8c7c4ab
Update DFC API docs, describe all endpoints
2023-06-19 16:20:35 +10:00
Maikel Linke
ec8c710e3a
Import simple DFC SuppliedProduct
...
OFN products and variants need more data like a price but the DFC
stores that in a different object. We may get a larger graph containing
that information but we don't have any test data yet.
2023-06-19 16:19:48 +10:00
Maikel Linke
df9e1ac2b4
Encapsulate SuppliedProductBuilder
...
And improve EnterpriseBuilder. It was builder products twice.
2023-06-19 16:19:48 +10:00
Maikel Linke
1adfb5463a
Import DFC measures
2023-06-19 16:19:40 +10:00
Maikel Linke
949019a277
Map has* predicates to Connector attributes
2023-06-19 16:19:40 +10:00
Maikel Linke
bfd084d9b6
Import graphs including anonymous objects
2023-06-19 16:18:58 +10:00
Maikel Linke
3c6f90dbb3
Import from IO objects for convenience, efficiency
...
The Connector exports to a String but Rails' `request.body` is an IO
object. Since the used JSON-LD parser needs an IO object anyway and it
can lower the memory usage we take IO objects as well and handle
in-memory Strings only when given.
2023-06-19 16:18:58 +10:00
Maikel Linke
f5f8c349e1
Resolve DFC Connector objects when importing graph
2023-06-19 16:18:51 +10:00
Maikel Linke
12d56d725b
Import properties which contains lists
...
Not just single values.
2023-06-19 16:18:51 +10:00
Maikel Linke
2abad60511
Import DFC graphs with multiple objects
2023-06-19 16:18:42 +10:00
Maikel Linke
15dd38d6c6
Import simple data from DFC
2023-06-19 16:16:18 +10:00
Maikel Linke
cceca5f936
Use Redis for caching in test environment
...
All other environments use it.
2023-06-19 15:35:17 +10:00
Maikel Linke
f6db69104f
Update Gemfile.lock with new Ruby version
2023-06-19 15:03:44 +10:00
Maikel
7e20415490
Merge pull request #10888 from mkllnk/ruby3.1
...
Bump Ruby from 3.0.3 to 3.1.4
2023-06-19 10:08:20 +10:00
Maikel
101e72726c
Merge pull request #11032 from dacook/show-current-version2
...
Show current version2
2023-06-19 10:07:49 +10:00
Konrad
dab5436444
Merge pull request #10532 from abdellani/invoices
...
Invoices
2023-06-18 21:44:29 +02:00
Mohamed ABDELLANI
d059680f4b
remove white label from feature toggle
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
27c1fd0d30
test invoice model
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
639567e903
replace attr with attr_reader
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fff0b1e577
Update lib/open_food_network/feature_toggle.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
7a0686786d
Update db/migrate/20230308075421_create_invoices.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
73cdcca022
fix linter issues
2023-06-18 21:03:13 +02:00
Matt-Yorkley
4eb05a1d73
Reduce public interface of OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Matt-Yorkley
3946e7a6f5
Memoize presenters in OrderInvoiceComparator
...
This is now twice as fast and triggers half the number of database queries if both comparison methods get called
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c6ec13443e
Drop next_invoice_number method from Spree::Order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
d3a31bd0bd
Rename @invoice_presenter instance variable to @order in invoice templates
2023-06-18 21:03:13 +02:00
Matt-Yorkley
352ad20681
Fix display_checkout_taxes_hash in invoice_table4 template
2023-06-18 21:03:13 +02:00
Matt-Yorkley
68ab539ed3
Include completed_at attribute
2023-06-18 21:03:13 +02:00
Matt-Yorkley
113e1344f2
Include tax adjustments in serializer and presenter
2023-06-18 21:03:13 +02:00
Matt-Yorkley
5bbc63f716
Fix options_text displaying when there is no options_text
2023-06-18 21:03:13 +02:00
Matt-Yorkley
72e537b598
Update *_amount_with_adjustments methods on LineItem presenter
...
These methods are slightly different and they're both needed in the template for invoice4
2023-06-18 21:03:13 +02:00
Matt-Yorkley
208840b99d
Use @invoice_presenter.checkout_adjustments
2023-06-18 21:03:13 +02:00
Matt-Yorkley
a44f24ad43
Remove prefixes from invoice data representation so it conforms to the same interface as order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
8dba1618b1
Don't call information from @order in new invoice templates
...
Previously this template was calling various bits of data from the @order object and not the @invoice_presenter object
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c3d6b2280f
Update reference to removed method
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0ed7599267
extract methods related to invoices from the order model to the OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
61d58df56f
fix linter issues
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d86173c509
add feature toggle
...
seperate the invoice templates that rely on presenters from the old ones.
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fa14dc370b
implement the invoice data generator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d9efd10ac0
update attributes relevant for the comparaison
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0fbf88190e
Generate invoice model
...
There are three main components:
1. The invoice model
2. order serializers: serialize the order for the invoice
3. data presenters: the object that will be use to access the order's serialize data
2023-06-18 21:03:13 +02:00
Matt-Yorkley
ae24b2d688
Update ScopeVariantsForSearch logic to match both product and variant SKUs
2023-06-16 21:26:28 +01:00
Matt-Yorkley
0f253bb2a0
Blank out product SKU when cloning a product
...
This was effectively being done before for the product's sku (stored on the master variant) via the #duplicate_variant method, but now it needs to be done explicitly on the product in #duplicate_product
2023-06-16 21:26:28 +01:00
Matt-Yorkley
15000c7ed1
Remove unnecessary iterator
2023-06-16 21:26:28 +01:00
Matt-Yorkley
733dd3c428
Disable variant is_master column
2023-06-16 21:23:44 +01:00
Matt-Yorkley
be72bbebb9
Remove master images data migration tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
fbd09869bb
Remove is_master from variant serializer
2023-06-16 21:23:44 +01:00
Matt-Yorkley
ced60d4382
Remove superfluous method from products controller
2023-06-16 21:23:44 +01:00
Matt-Yorkley
b59bdc75e9
Delete master variants
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1daab8994d
Remove is_master and not_master scopes
2023-06-16 21:23:44 +01:00
Matt-Yorkley
0703bb4583
Remove unused is_master references in tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
85059bfb26
Remove master variant validation conditionals
2023-06-16 21:23:44 +01:00
Matt-Yorkley
8247dce2dc
Improve validation feedback on new variant page and add test coverage
2023-06-16 21:23:44 +01:00
Matt-Yorkley
618900767f
Fix flaky spec: use milliseconds in cache service and remove sleep
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1e36043a2e
Set unit_value to true when cloning a product
...
This value doesn't get persisted, but it's presence is validated. The product's duplicated variants store the actual :unit_value attribute
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1922598d2d
Reorganise associations, validations, scopes and callbacks for clarity
2023-06-16 21:23:44 +01:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
21cba0aa13
Migrate first master variant image to product image
2023-06-16 21:23:44 +01:00
Matt-Yorkley
7dc1091bc2
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
d8649fc9fb
Migrate master variant :sku to product
2023-06-16 21:21:40 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Matt-Yorkley
8c0b8dad85
Stop using master variant for storing :display_as value
2023-06-16 21:21:40 +01:00
Matt-Yorkley
1b06c20197
Stop using master variant as a potential store for prices
2023-06-16 21:21:40 +01:00
Matt-Yorkley
80a0138b48
Update old specs that rely on master variant instead of real variants
2023-06-16 21:21:40 +01:00
Matt-Yorkley
d4188da7c1
Simplify product images delegation mess
2023-06-16 21:21:40 +01:00
Matt-Yorkley
42a5a48816
Remove dead code
2023-06-16 21:21:40 +01:00
Matt-Yorkley
dd224b953d
Update stage.yml
2023-06-16 14:24:23 +01:00
Matt-Yorkley
cfe5d9a740
Update stage.yml
2023-06-16 14:00:30 +01:00
Matt-Yorkley
09bfe14ae9
Update stage.yml
2023-06-16 13:39:12 +01:00
Mohamed ABDELLANI
68503e4e8b
remove useless variable
2023-06-16 06:54:11 +01:00
Mohamed ABDELLANI
65bc8e23c1
move update instructions to let blocks
2023-06-16 06:50:45 +01:00
Mohamed ABDELLANI
2b79258fdc
renamed: spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb -> spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order_spec.rb
2023-06-16 06:39:38 +01:00
Mohamed ABDELLANI
c21a35a9fc
fix typo on lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_order.rb
2023-06-16 06:38:15 +01:00
Mohamed ABDELLANI
c8c3e65498
Update lib/reporting/reports/list.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
2cfa435b54
Update spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
3e61830b40
optimize total_excl_tax & enterprise_fee_adjustemnt_ids
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
10fc816bba
update rubocop_todo list
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
542811b9ad
implement filtering by entreprise fee owner
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
9d53d775a6
add filtering by fee name
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
f66d9b9626
remove producers filter
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
83b951662a
add filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9671e4e1f
test enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9367b1f86
add enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
535f651c7e
implement enterprise fee report filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
a120329aa6
rename EnterpriseFeeSummary::Base to EnterpriseFeeSummary::FeeSummary
2023-06-16 06:35:01 +01:00
Maikel
4e1f735630
Include feature toggle heading in release notes
2023-06-16 14:13:41 +10:00
Maikel Linke
2453084a6b
Update translations
2023-06-16 14:02:47 +10:00
Maikel
39183547aa
Merge pull request #11033 from openfoodfoundation/revert-10455-dependabot/bundler/redis-5.0.6
...
Revert "Fix `redis` and `hiredis-client` version requirements "
2023-06-16 13:42:55 +10:00
Maikel
24000b2ce3
Revert "Fix redis and hiredis-client version requirements "
2023-06-16 13:09:25 +10:00
Maikel
8e86f76278
Merge pull request #11018 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.2
...
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
2023-06-16 12:08:25 +10:00
Maikel
4a91c180a3
Merge pull request #11017 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.1
...
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
2023-06-16 11:14:10 +10:00
Maikel
d192024786
Merge pull request #11019 from filipefurtad0/flaky_cache_spec
...
Clears cache around examples
2023-06-16 11:12:24 +10:00
Maikel
ec7de516aa
Merge pull request #11011 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.124.0
...
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
2023-06-16 10:59:56 +10:00
David Cook
56e4b3b843
Load git version once at initialisation
...
Co-authored-by: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2023-06-16 09:36:16 +10:00
David Cook
47745b5e49
Merge pull request #11004 from dacook/show-current-version
...
Show current version at bottom of admin dashboard
2023-06-16 09:26:00 +10:00
Matt-Yorkley
3301c7cabc
Update stage.yml
2023-06-16 00:18:36 +01:00
David Cook
35d9837f24
Show current version at bottom of admin dashboard
...
With generic link to the releases page. We could provide a link to latest tag with `git describe --tags --abbrev=0`. But I thought it better to keep things simple.
2023-06-16 09:11:59 +10:00
Matt-Yorkley
436deb9797
Update stage.yml
2023-06-16 00:03:16 +01:00
Matt-Yorkley
57451f2639
Update stage.yml
2023-06-15 23:26:27 +01:00
Matt-Yorkley
d56ad66ab8
Update stage.yml
2023-06-15 20:57:40 +01:00
Matt-Yorkley
fc5a53ebd9
Update stage.yml
2023-06-15 20:53:20 +01:00
Matt-Yorkley
f27472106e
Update stage.yml
2023-06-15 20:52:07 +01:00
Matt-Yorkley
5729e33f69
Merge pull request #11031 from Matt-Yorkley/deployment-workflow
...
Add workflow for deploying to staging
2023-06-15 20:40:10 +01:00
Matt-Yorkley
584f6297f5
Allow manual workflow triggers
2023-06-15 20:18:44 +01:00
Matt-Yorkley
12bf17e21e
Add workflow for deploying to staging
2023-06-15 19:37:18 +01:00
Matt-Yorkley
7068df5d4b
Merge pull request #10804 from Matt-Yorkley/public-images
...
Update ActiveStorage image processing
2023-06-15 15:49:11 +01:00
Konrad
7a10edff82
Merge pull request #10988 from jibees/10980-white-label-trix-bullets-and-numbers-are-displayed-outside-the-text-field
...
[White Label] Custom tab content editor: order and unordered list should have a margin-left set
2023-06-15 16:13:19 +02:00
Konrad
5c0db892e5
Merge pull request #10983 from jibees/10982-admin_style_v3-use-oidc-settings-instead-of-oidc-settings-in-navigation
...
[OIDC] Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-15 16:07:07 +02:00
filipefurtad0
598f69f42f
Clears cache around examples
...
for specs testing cache
2023-06-15 11:28:01 +01:00
dependabot[bot]
ca5de6b0b2
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.1 to 7.1.2.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.1...v7.1.2 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 10:05:58 +00:00
dependabot[bot]
b0c9c6e6e1
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.12.0...v1.12.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 09:58:24 +00:00
David Cook
d195882645
Use builtin Rails method
2023-06-15 15:26:22 +10:00
Maikel Linke
a46917a7b7
Remove NULL possibility from customer flag
...
It should only be true or false. This was flagged by Rubocop. I also
added another Rubocop suggestion and combined two migrations because
they are related.
2023-06-15 12:02:45 +10:00
Maikel Linke
75cce8bc19
Simplify customer code
...
The API endpoint merges the created_manually flag in the params already.
No need to write it separately.
2023-06-15 12:02:45 +10:00
Maikel Linke
a655d3d787
Remove unnecessary writes on customer creation
...
The form only submits enterprise id and email address. We don't need to
assign any other attributes.
2023-06-15 12:02:45 +10:00
Maikel Linke
9bd6615dad
Change spec to "unhide" customers on create
2023-06-15 12:02:45 +10:00
Maikel Linke
ebebcf7a13
Remove useless code
2023-06-15 12:02:45 +10:00
Maikel Linke
22a6861f6f
Place class methods above instance methods
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
298ae8ffc3
set create_manualll flag if the customer already exists
2023-06-15 12:02:45 +10:00
Maikel Linke
107b17addb
Add index of much used created_manually column
2023-06-15 12:02:45 +10:00
Maikel Linke
9910d10eb8
Simplify and speed-up customers migration
...
This reduces the migration run time from 9.6 seconds to 0.16 seconds on
a production database.
* Simplify model naming.
* Remove unnecessary model code.
* Use Rails `missing` scope for efficient simplicity.
* Add `down` method for rollback instead of running `change` again.
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
608ff054b0
set the created_manually flag to true for all customers that don't have any orders
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
ebc3073604
use Customer#visible on the customers listing endpoints
...
Update app/models/customer.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
authorize created_manually field to be set on APIv1
2023-06-15 12:02:45 +10:00
Maikel
701fef84f3
Merge pull request #10850 from mkllnk/require-belongs-to--part1
...
Require belongs_to associations - part 1
2023-06-15 09:20:42 +10:00
Konrad
cf3692e688
Merge pull request #10992 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.4
...
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
2023-06-14 22:25:16 +02:00
Konrad
863fed56ce
Merge pull request #10455 from openfoodfoundation/dependabot/bundler/redis-5.0.6
...
Fix `redis` and `hiredis-client` version requirements
2023-06-14 22:09:13 +02:00
Filipe
e6d42a0c4f
Merge pull request #10999 from Matt-Yorkley/bom-issues
...
Fix BOM order loading issue
2023-06-14 19:01:54 +01:00
Matt-Yorkley
64508d3c3d
Add unit test for direct image URLs
2023-06-14 12:53:20 +01:00
Matt-Yorkley
395cf7fb8d
Use direct image URLs for enterprise logos
2023-06-14 12:53:20 +01:00
Matt-Yorkley
5ad37ce6a5
Return default image url on ActiveStorage errors in image loading
2023-06-14 12:53:20 +01:00
dependabot[bot]
6e9721b64c
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.123.1 to 1.124.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-14 09:58:54 +00:00
Matt-Yorkley
4c7e947738
Migrate data
...
So it turns out all images uploaded before the ActiveStorage migration are internally set to "public-read", and all images uploaded after the migration are internally set to "private". This migration switches all images in S3 buckets back to "public-read".
2023-06-14 10:56:10 +01:00
Matt-Yorkley
b510668ecf
Render direct URLs for s3 images
2023-06-14 10:56:10 +01:00
Matt-Yorkley
6f12d012ed
Use #url helper
2023-06-14 10:56:10 +01:00
Matt-Yorkley
551d0d3a93
Simplify calling #url_for in models
2023-06-14 10:56:10 +01:00
Matt-Yorkley
a898915724
Use named image variants
2023-06-14 10:56:10 +01:00
Matt-Yorkley
e54cff2274
Set images to public-read
...
Defining an alternate s3 configuration set to `public: true` means we can use it selectively. It sets the objects to `acl: "public-read"` by default (read-only) and means any image tags for those assets can use direct public links in the src attribute (without hitting the ActiveStorage::Representation endpoint). The default non-public service will still be used by default for any other files on instances using s3.
2023-06-14 10:56:10 +01:00
Matt-Yorkley
202b0041d1
Remove voucher processing from checkout edit action
2023-06-14 10:19:30 +01:00
Matt-Yorkley
1a744de37a
Improve voucher #calculate tests
2023-06-14 10:19:30 +01:00
Matt-Yorkley
93df70c0a7
Use order total excluding discounts in voucher calculations
2023-06-14 10:19:30 +01:00
Matt-Yorkley
52806a35ee
Fix Rubocop complaint
2023-06-14 10:19:30 +01:00
Matt-Yorkley
11382a518e
Fix test setup in BOM spec
2023-06-14 10:19:30 +01:00
Matt-Yorkley
ef09492883
Update adjustment spec to use orders past delivery state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
6fa381197a
Don't tax fees before payment state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
837e581c29
Reload order after cancelling it in tests that check shipment states
2023-06-14 10:19:30 +01:00
Matt-Yorkley
06c9697d0d
Don't try to cancel shipments that might already be cancelled
2023-06-14 10:19:30 +01:00
Matt-Yorkley
c5dfecbb69
Reapply taxes at model level if order address changes
...
This should be done at the model level
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0f23fc510
Extract before_payment_state? method
2023-06-14 10:19:30 +01:00
Matt-Yorkley
13a22c56f4
Move taxing of admin adjustments out of customer details controller
2023-06-14 10:19:30 +01:00
Matt-Yorkley
65b6a75c9b
Reorder callback definitions
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0d0f8fd2f
Tidy up checkout tax spec
2023-06-14 10:19:30 +01:00
Maikel Linke
c2605b2606
Display loading spinner before quick reports
...
We had a race condition that could first display the report and then
replace it again with the "loading" spinner. That doesn't seem to happen
now that we changed the order of cable events.
2023-06-14 15:40:52 +10:00
Maikel Linke
91d0dabc1d
Require associations on DistributorShippingMethod
2023-06-14 15:09:12 +10:00
Maikel Linke
bd11475fe1
Require associations on DistributorPaymentMethod
2023-06-14 15:08:22 +10:00
Maikel Linke
ed231ec512
Update belongs_to default in Customer model
2023-06-14 15:08:05 +10:00
Maikel Linke
fc00a48d67
Require associations of CoordinatorFee
2023-06-14 15:08:05 +10:00
Maikel Linke
c02c90317f
Require user of column preference record
...
It doesn't make sense to have a preference without a user. And it was
already enforced in the database.
2023-06-14 15:07:43 +10:00
Maikel Linke
2d4cfd7548
Validate and enforce AdjustmentMetadata associations
2023-06-14 15:07:43 +10:00
Maikel Linke
d88781a083
Start to adopt new default to require belongs_to
...
Newer version of Rails have this option as default. We can slowly
transition to opt in gradually, model by model. Once all models are
covered, we can change the default and remove the setting from the
models again.
The style violation was added to the todo file because it's temporary.
We have 60 models using `belongs_to`. And changing them all at once
breaks some specs. So let's do it gradually.
2023-06-14 15:06:59 +10:00
Maikel
989a88e252
Merge pull request #10848 from mkllnk/totals-report
...
Fix error on summarising total_units in Order Cycle Supplier Totals report
2023-06-14 13:59:48 +10:00
Matt-Yorkley
074eb4b592
Move tax charge logic out of checkout controller and update payment transition
2023-06-13 17:53:46 +01:00
Matt-Yorkley
bf912ae4d3
Remove angular loading element in darkwarm layout
2023-06-13 17:35:13 +01:00
Filipe
9c42781ff1
Merge pull request #10913 from abdellani/remove-split-checkout-toggle-and-legacy-checkout
...
Remove split checkout toggle and legacy checkout
2023-06-13 17:00:07 +01:00
Matt-Yorkley
73b2d37224
Don't try to load orders if the number of line_items with the current filters applied is zero
...
This ends up sending a request to the orders endpoint with no filters and no search params, which then tries to load every order in the entire database if the user is superadmin, which blows up.
2023-06-13 15:47:19 +01:00
Mohamed ABDELLANI
2654d3b866
update the rubocop_todo list
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5fa81d1333
Fix invalid test setup in old tax tests
2023-06-13 14:58:16 +01:00
Matt-Yorkley
4e7fab6914
Delete dead code Checkout#find_transition
...
This method is only called from tests and nowhere else in the codebase. We may as well remove it.
2023-06-13 14:58:16 +01:00
Matt-Yorkley
8d633234f4
Set voucher specs to pending temporarily
2023-06-13 14:58:16 +01:00
Matt-Yorkley
d5a625bdeb
Fix Paypal spec
2023-06-13 14:58:16 +01:00
Matt-Yorkley
0e289a23c1
Set some legacy checkout specs that we might want to rewrite later to pending
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5487aa19fc
Fix missing checkout_state_path
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
345f540723
fix spec/models/spree/tax_rate_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
78617905c6
remove spec/requests/checkout/concurrency_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
56204b2315
fix ./spec/routing/stripe_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
905187f3ce
fix ./spec/services/order_tax_adjustments_fetcher_spec.rb:100
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
7e84579aa3
spec/system/consumer/shopping/checkout_stripe_spec
...
these tests are using the legacy checkout
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
bd0e7cdfc8
remove legacy checkout tests
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
907c65d98c
run create_tax_charge! after transition to payment state
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
c2aaf88e98
remove checkout controller
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
fc0cca2210
remove legacy checkout view
2023-06-13 14:58:16 +01:00
jibees
c379dcacc5
Merge pull request #10993 from openfoodfoundation/dependabot/bundler/jwt-2.7.1
...
chore(deps): bump jwt from 2.7.0 to 2.7.1
2023-06-13 15:05:30 +02:00
jibees
64e6d639c1
Merge pull request #10995 from openfoodfoundation/dependabot/bundler/rubocop-1.52.1
...
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
2023-06-13 15:03:45 +02:00
jibees
374904f473
Merge pull request #10996 from openfoodfoundation/dependabot/bundler/test-unit-3.6.0
...
chore(deps): bump test-unit from 3.5.9 to 3.6.0
2023-06-13 15:03:03 +02:00
jibees
fb7ae9fd58
Merge pull request #10991 from openfoodfoundation/dependabot/bundler/view_component-3.2.0
...
chore(deps): bump view_component from 3.1.0 to 3.2.0
2023-06-13 15:02:26 +02:00
dependabot[bot]
19bd05ce5a
chore(deps): bump test-unit from 3.5.9 to 3.6.0
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.9 to 3.6.0.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.9...3.6.0 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:11:47 +00:00
dependabot[bot]
f9abec4346
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.0 to 1.52.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.0...v1.52.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:10:38 +00:00
dependabot[bot]
3e7ad17f69
chore(deps): bump jwt from 2.7.0 to 2.7.1
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.7.0...v2.7.1 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:08:44 +00:00
dependabot[bot]
b813879330
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.3...1.0.4 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:02:26 +00:00
Filipe
12bb8db7b3
Merge pull request #10933 from Matt-Yorkley/fix-payment-intents
...
Fix ProcessPaymentIntent service
2023-06-13 11:00:27 +01:00
dependabot[bot]
c3846ad269
chore(deps): bump view_component from 3.1.0 to 3.2.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 09:58:11 +00:00
Matt-Yorkley
93c3241bb5
Add more test coverage in stripe controller spec
2023-06-13 10:14:09 +01:00
Matt-Yorkley
abd55b2104
Move order to completed whether it's current state is payment or confirmation
2023-06-13 10:14:09 +01:00
Matt-Yorkley
47df9493ae
Fix ProcessPaymentIntent service
2023-06-13 10:14:09 +01:00
Gaetan Craig-Riou
694e46d1fb
Fix Bundler/OrderedGems
2023-06-13 15:35:40 +10:00
Gaetan Craig-Riou
4564021f79
Remove redis version limitation
2023-06-13 15:06:52 +10:00
David Cook
b85cf26907
Add comment
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
02432ee2ec
Do not upgrade to redis >= 5
...
since Redis >= 3, < 5 is actually a requirement of Action Cable Redis subscription adapter until Rails 7.0.4.
https://github.com/rails/rails/blob/v6.1.7/actioncable/lib/action_cable/subscription_adapter/redis.rb
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
520ced350e
Do not specify redis version
2023-06-13 14:59:19 +10:00
Jean-Baptiste Bellet
e41d1f2205
Following the doc, remove hiredis and use hiredis-client
...
Reference:
- https://github.com/redis/redis-rb/issues/1178
- https://github.com/redis/redis-rb#hiredis-binding
2023-06-13 14:59:19 +10:00
David Cook
c5ce49e08c
Merge pull request #10948 from dacook/buu-table-styles
...
[admin_v3] Update all table styles
2023-06-13 13:08:55 +10:00
David Cook
e4c65ea87d
Prettify palette file
2023-06-13 11:46:28 +10:00
David Cook
f007cf3dad
Fix up table borders
2023-06-13 11:45:39 +10:00
David Cook
edcdcd3f74
Use header colour for table headers
2023-06-13 11:45:39 +10:00
David Cook
16534319b6
Replace dark blue with "Sherpa blue"
...
It looks like it’s used in headers, some buttons and a loading message
2023-06-13 11:45:39 +10:00
David Cook
d85ea628e2
Change default font colour to near-black
...
It looks like this is the main font colour in the new designs.
2023-06-13 11:45:39 +10:00
David Cook
821446e150
Style pagination links
...
And provide a basic hover state for most other buttons.
The pagination button hover and active states will need updating.
The darker background colour sometimes wraps a whole table (eg products table).
2023-06-13 11:45:39 +10:00
David Cook
744f95809a
Remove uppercase styling of form elements
2023-06-13 11:45:39 +10:00
David Cook
fb17a679c0
First pass at new table colours
...
There is more to do, for example the dropshadows.
I've continued with the unopinionated colour naming (eg color-7), but would like to consider giving them more meaningfule names..
2023-06-13 11:45:39 +10:00
David Cook
2ae91bdbe2
Use variable for font size reset
...
The current value is 13px already, but I'd like to experiment changing this.
I'm not sure if we even need the reset, but am not delving into that right now.
2023-06-13 11:44:48 +10:00
David Cook
3967f54533
Use different variables and table styles for admin_v3
2023-06-13 11:44:48 +10:00
Konrad
6bd66585a9
Merge pull request #10935 from openfoodfoundation/dependabot/bundler/i18n-1.14.1
...
chore(deps): bump i18n from 1.13.0 to 1.14.1
2023-06-12 17:39:42 +02:00
Konrad
11f84b5276
Merge pull request #10934 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.123.1
...
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
2023-06-12 17:24:20 +02:00
Filipe
23239bad8b
Merge pull request #10970 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.0
...
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
2023-06-12 16:19:32 +01:00
Konrad
a207a445b1
Merge pull request #10907 from jibees/3041-missing-translation-in-product-variant-selection-upon-order-creation
...
Admin, Create an order, Select a product: translate some messages in the product selection search box
2023-06-12 17:08:52 +02:00
Jean-Baptiste Bellet
16256ee114
Order and Unordered list should have a margin-left set
...
Has been reset to 0 via `typography.scss`
2023-06-12 16:58:00 +02:00
dependabot[bot]
15e9c4eb37
chore(deps): bump i18n from 1.13.0 to 1.14.1
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.13.0...v1.14.1 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 14:44:01 +00:00
Konrad
3e3ae5d8ae
Merge pull request #10929 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.0
...
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
2023-06-12 16:43:01 +02:00
Konrad
48c107bde1
Merge pull request #10974 from cillian/ignore-whitespace-in-product-import
...
Ignore leading and trailing whitespace when importing products via a spreadsheet
2023-06-12 16:32:15 +02:00
Konrad
80dd8755b0
Merge pull request #10915 from mkllnk/mini-racer
...
Remove unused mini_racer gem
2023-06-12 16:05:52 +02:00
Konrad
791518988d
Merge pull request #10918 from openfoodfoundation/dependabot/bundler/view_component-3.1.0
...
chore(deps): bump view_component from 3.0.0 to 3.1.0
2023-06-12 15:36:21 +02:00
Jean-Baptiste Bellet
149ec5511c
Translate select2 messages
2023-06-12 15:11:23 +02:00
dependabot[bot]
351343fb6c
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.122.0 to 1.123.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:06:04 +02:00
dependabot[bot]
6145413b1a
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.1 to 1.12.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.1...v1.12.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:05:11 +02:00
dependabot[bot]
d87e40bb69
chore(deps): bump view_component from 3.0.0 to 3.1.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:04:17 +02:00
Maikel Linke
d6859e0bf7
Remove unused mini_racer gem
...
All asset compilation is done with webpacker at the moment.
2023-06-12 15:01:11 +02:00
Konrad
1f2f5e2eec
Merge pull request #10892 from openfoodfoundation/dependabot/bundler/rails-7.0.5
...
chore(deps): bump rails from 7.0.4.3 to 7.0.5
2023-06-12 14:58:07 +02:00
jibees
b53aba3844
Merge pull request #10986 from openfoodfoundation/dependabot/bundler/capybara-3.39.2
...
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
2023-06-12 14:42:48 +02:00
jibees
45dcdf1611
Merge pull request #10985 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.1
...
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
2023-06-12 14:31:03 +02:00
jibees
8c971f2efa
Merge pull request #10984 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.3.0
...
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
2023-06-12 14:29:56 +02:00
dependabot[bot]
8a8200a039
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.1 to 3.39.2.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.1...3.39.2 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:58:05 +00:00
dependabot[bot]
8a376e782a
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:39 +00:00
dependabot[bot]
6ab1bfb2ab
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.9 to 1.3.0.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.3.0/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:18 +00:00
Sigmund Petersen
c2305615a6
Merge pull request #10971 from filipefurtad0/mouse_hover_spec
...
Adds spec for tooltips on orders page
2023-06-12 09:53:16 +02:00
Jean-Baptiste Bellet
ff0f81167a
Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-12 09:19:16 +02:00
Gaetan Craig-Riou
41b3ddae08
Merge pull request #10714 from macanudo527/fix_linelength
...
Fix Style/LineLength
2023-06-12 09:53:23 +10:00
Konrad
fc09f95fa1
Merge pull request #10961 from jibees/10946-white-label-trix-editor-changes-on-the-custom-tab-content-do-not-trigger-the-update-button
...
[WhiteLabel] Make update button active when changing custom tab content
2023-06-09 21:46:02 +02:00
Konrad
13037d2d9d
Merge pull request #10949 from jibees/10630-buu-as-an-enterprise-user-i-can-see-the-back-office-with-new-brand-colours
...
[`admin_style_v3`] As an enterprise user i can see the back office with new brand colours
2023-06-09 21:24:01 +02:00
Konrad
9125c730ed
Merge pull request #10960 from jibees/customize-trix-editor-to-have-the-right-colors
...
[White Label] Customize colors of custom content editor to have beautiful toolbar
2023-06-09 20:35:36 +02:00
Matt-Yorkley
70170078d1
Merge pull request #10976 from Matt-Yorkley/payment-localized-number
...
Require localized_number in Payment class
2023-06-09 18:45:13 +01:00
Konrad
bd505bbee7
Merge pull request #10959 from jibees/10945-white-label-narrow-screen-width-no-marging-on-custom-tab-content
...
[WhiteLabel] Add some margin to custom tab content for a shop
2023-06-09 19:45:04 +02:00
Matt-Yorkley
24200de8dd
Require localized_number in Payment class
...
There seems to be some contexts (jobs for subscriptions) where the Payment class loads but LocalizedNumber is an undefined constant. It lives in the /lib directory so it's not auto-loaded.
2023-06-09 18:16:37 +01:00
Konrad
d0f4c44add
Merge pull request #10938 from jibees/10931-white-label-custom-tab-without-a-title-impossible-to-disable-the-custom-tab
...
[White Label] Validate the presence of a custom tab title before creating it (+ max 20 characters length)
2023-06-09 19:01:13 +02:00
Cillian O'Ruanaidh
5cde4de512
Ignore leading and trailing whitespace in spreadsheet when importing products
2023-06-09 16:23:18 +01:00
Konrad
502b5e8664
Merge pull request #10937 from jibees/10900-white-label-remove-ofn-navigation-for-small-width-screens
...
[White Label] Remove ofn navigation for small width screens as well when option is activated
2023-06-09 16:28:22 +02:00
Konrad
35fef9e7ac
Merge pull request #10876 from dacook/prettier-css-admin
...
Prettier css admin
2023-06-09 16:02:11 +02:00
filipefurtad0
24913476ac
Adds spec for tooltips on orders page
2023-06-09 11:23:42 +01:00
dependabot[bot]
515a9a9b1c
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.1.0 to 5.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.1.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-09 10:02:21 +00:00
Neal Chambers
a65b43d32f
Update .rubocop_todo.yml
2023-06-09 16:39:29 +09:00
Neal Chambers
9a8551e3ea
Shorten Where Statement
2023-06-09 16:39:29 +09:00
Neal Chambers
a35a07b441
Rewrite sum to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
449430cabc
Indent code to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
252697b782
Rewrite If and Unless Statements to be more Readable
2023-06-09 16:39:26 +09:00
Maikel Linke
ec865627d2
Wait for page setup to avoid flaky spec
...
I'm hiding a real bug here. There's a race condition when the cable event of
the finished report is sent before the loading spinner rendered. The
spinner then overwrites the report again. I added a spec for that but
don't have a solution yet.
I also noticed that the loading spinner is not displayed in testing but
we can assert on the CSS class of the container.
2023-06-09 16:22:01 +10:00
Jean-Baptiste Bellet
74fd1814e4
Create a trixeditor controller and broadcast a change event on form
...
Therefore, AngularJS can set form as dirty
+ add associated spec
2023-06-09 08:03:17 +02:00
Maikel Linke
d312a5912a
Style Layout/MultilineMethodCallIndentation
2023-06-09 14:45:06 +10:00
Maikel Linke
828b2f6f44
Replace too long list of arguments with keywords
...
Rubocop was complaining about too many arguments. But
`ApplicationJob#perform` needs all arguments handled in one call. While
we could allow the `perform` method generally to have more arguments,
there could be other methods called `perform` which should still be
scrutinised. Instead, it seems acceptable to me to have more arguments
as long as they are clearly named as keyword arguments. Rails uses this
a lot to document all options including their default values, for
example in Active Storage. It's better then bundling several arguments
in an undocumented hash just to reduce the number of given arguments.
And once we upgraded to Ruby 3.1, we can clean the method calls up as
well. `call(user: user)` becomes `call(user:)` without repetition.
2023-06-09 14:44:54 +10:00
Maikel Linke
e56c06571c
Remove outdated report timeout handling
...
Since we don't wait for the report any more, a timeout is very unlikely
and we don't need special handling for it.
2023-06-09 14:44:54 +10:00
Matt-Yorkley
7caf4b03d4
Improve flakyness on report specs
2023-06-09 14:44:53 +10:00
Matt-Yorkley
b230b37284
Update report email spec
2023-06-09 14:44:53 +10:00
Matt-Yorkley
524d1f0264
Switch to tighter Channel scoping...
...
This is not a normal pattern for setting up ActionCable channels, so it might need some notes. It ensures the broadcasts from the ReportJob are unique not just to the user session but also to the specific tab in the user's browser. Otherwise if the user has two different report pages open in separate tabs with the same session, the broadcast would overwrite the #report-table element in both of them.
2023-06-09 14:44:53 +10:00
Matt-Yorkley
a3ef604797
Run reports in background
2023-06-09 14:44:53 +10:00
Matt-Yorkley
ced959ad6a
Load reports show page without all the legacy javascript
2023-06-09 14:44:53 +10:00
Matt-Yorkley
242c74ceaf
DRY admin javascript imports
2023-06-09 14:44:53 +10:00
Maikel Linke
6803e0a8f9
Fix error on summarising total_units
2023-06-09 09:55:33 +10:00
Maikel Linke
71e4d2c6ed
Spec total_units report column
...
Current reports don't deal with invalid legacy data.
2023-06-09 09:55:33 +10:00
Maikel Linke
00e171a8f1
Reduce indentation in report spec
...
Specs should also test from the outside instead of declaring modules and
test from within those modules.
2023-06-09 09:55:33 +10:00
Jean-Baptiste Bellet
5d43285834
Update all locales with the latest Transifex translations
2023-06-08 17:36:04 +02:00
Filipe
ca03e1596b
Merge pull request #10952 from Matt-Yorkley/full-name
...
Improve nil-safety in variant naming methods
2023-06-08 16:26:28 +01:00
Filipe
c12415a340
Merge pull request #10955 from Matt-Yorkley/bulk-invoice-bug
...
Ensure directory exists before saving invoices pdf
2023-06-08 15:22:27 +01:00
Matt-Yorkley
f4261b85b8
Merge pull request #10940 from Matt-Yorkley/order-tidyup
...
Order class tidyup
2023-06-08 15:06:59 +01:00
Filipe
7974e1eaa6
Merge pull request #10936 from abdellani/fix-order-progressing-automatically-on-BOO
...
fix Viewing an order in state "confirmation" changes the state to "complete"
2023-06-08 14:50:04 +01:00
Jean-Baptiste Bellet
457d5a6c83
Override some css classes, to have a beautiful trix editor toolbar buttons
...
- buttons background are transparent (instead of blue)
- buttons background on hovering are transparent (instead of green)
- disabled buttons cursor is default (instead of pointer)
2023-06-08 11:43:59 +02:00
Jean-Baptiste Bellet
05104841cd
Add some margin to custom tab content via columns css class
2023-06-08 11:36:06 +02:00
Jean-Baptiste Bellet
d1d050e6a4
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
David Cook
e2ba18f828
Set sentence case tab names in Ruby instead of CSS
...
I chose .capitalize instead of .humanize, because the latter has extra features which may not be desired.
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d6cb483f0d
Adjust color to the title of the page
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d7f7ff7436
Remove background, border and adjust margin top
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
905220a055
Add new color: $color-8 #191c1d Near-black
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b865d8c1c0
Copy/Paste file admin/shared/layout under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
51f47fc351
Add border bottom when hovering or selected
...
+ add some padding to separate those borders then
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
1b4236640d
Add border with box-shadow to menu and sub-menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
2057449dac
Add new color: $color-7 #EFF1F2 Light grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ba98039e95
Adjust color to orange when selected or hover
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d51786ac9e
Adjust font size for labels in menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ccd7466ede
No more white on labels but dark grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b163d4a584
Remove background-color on menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
a4d3011e27
Add new color: $color-9 #2E3132 Dark Grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
dd48092728
Prettier file
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
5ee3550ebd
Change case to Sentence case
...
CSS property `capitalize` uppercase all first letter of each words.
I need to use a small trick with `::first-letter` selector
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
eab46b67e3
Copy/Paste file admin/components/navigation under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
e34f4a9971
AdminV3: Remove icon from icon from primary navigation menu
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-06-08 11:24:43 +02:00
Neal Chambers
dde775d2b7
Remove Old Code and Comments
2023-06-08 15:20:04 +10:00
Neal Chambers
3432e30465
Fix Style/UnlessGuard
2023-06-08 15:20:04 +10:00
Neal Chambers
12aa4f9970
Fix Layout/IndentationStyle
2023-06-08 15:20:04 +10:00
Neal Chambers
b04879604a
Rewrite Ternary Expression to Prevent Layout/LineLength
2023-06-08 15:20:04 +10:00
Maikel Linke
4ecbbae55e
Adapt large browser window as default
...
We were really close to that anyway. It simplifies the code a bit.
2023-06-08 13:51:29 +10:00
Maikel Linke
7cf68cd33b
Ensure that specs restore default window size
2023-06-08 13:51:25 +10:00
Maikel Linke
241b307762
Fix typos
2023-06-08 11:34:05 +10:00
David Cook
7d26158e06
Code cleanup
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 11:31:37 +10:00
Maikel Linke
99fbf80b4c
Style Layout/MultilineMethodCallIndentation
2023-06-08 11:15:42 +10:00
Matt-Yorkley
98f78927b7
Update app/jobs/bulk_invoice_job.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 00:56:24 +01:00
Matt-Yorkley
bf051fc35b
Pull checkout-workflow-related callback methods out into the Checkout module which defines checkout state changes
2023-06-07 18:54:20 +01:00
Matt-Yorkley
760bf269ca
Pull validations-related methods out into a separate module
2023-06-07 18:54:20 +01:00
Matt-Yorkley
bed2fe69f6
Update regression tests
2023-06-07 16:39:37 +01:00
jibees
c6b5eda85c
Merge pull request #10951 from openfoodfoundation/dependabot/bundler/faraday-2.7.6
...
chore(deps): bump faraday from 2.7.5 to 2.7.6
2023-06-07 17:34:10 +02:00
Matt-Yorkley
b091a0ed1a
Ensure directory exists before saving pdf
...
These directories can get wiped during deployments
2023-06-07 16:25:53 +01:00
Mohamed ABDELLANI
fbf55cf7bd
Merge pull request #2 from Matt-Yorkley/fix-order-progressing-automatically-on-BOO
...
Fix pre-existing issues with admin order controller
2023-06-07 13:49:06 +01:00
David Cook
3ce48848f0
Prettify the rest
2023-06-07 14:23:57 +02:00
David Cook
548a6f8d2e
Prettify app/webpacker/css/admin/plugins/
2023-06-07 14:23:57 +02:00
David Cook
10c52959ad
Prettify app/webpacker/css/admin/hacks/
2023-06-07 14:23:57 +02:00
David Cook
08dc3e3cbe
Prettify more admin css
...
yarn prettier --write
2023-06-07 14:23:02 +02:00
David Cook
fbf5862c66
Ignore some css subfolders
...
Prettier changes these files dramatically and they're arguably not easier to read.
2023-06-07 14:21:34 +02:00
dependabot[bot]
01dcf068f9
chore(deps): bump rails from 7.0.4.3 to 7.0.5
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.4.3 to 7.0.5.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.4.3...v7.0.5 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 14:12:34 +02:00
Matt-Yorkley
b58b555e38
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
983353e078
Remove dead code
...
I'm pretty sure this was here because advancing the order was adding order errors in some cases
2023-06-07 13:01:37 +01:00
Matt-Yorkley
968bf882c4
Fix flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
daf243996b
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
7a7ab17db4
Improve customer tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
6daf29400f
Improve distribution and line items tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
f3ee10dd5a
Simplify by moving conditional to guard clause
2023-06-07 13:01:37 +01:00
Matt-Yorkley
cf0f148dba
Advance order when creating a shipment
...
This action gets called from the order edit page when adding line items and it's one of the places that needs to advance the order *before* redirecting back to the order edit action
2023-06-07 13:01:37 +01:00
Matt-Yorkley
bb73d70e57
Improve nil-safety in variant naming methods
2023-06-07 12:17:50 +01:00
dependabot[bot]
24343c769e
chore(deps): bump faraday from 2.7.5 to 2.7.6
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.5...v2.7.6 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 09:57:34 +00:00
Filipe
2d28a57c6f
Merge pull request #10922 from jibees/10903-white-label-make-logo-url-link-more-tolerant-in-terms-of-format-and-add-example
...
[White Label] Make logo url link more tolerant in terms of format
2023-06-07 10:00:31 +01:00
Maikel
1c9a09d88d
Merge pull request #10943 from openfoodfoundation/dependabot/bundler/paranoia-2.6.2
...
chore(deps): bump paranoia from 2.6.1 to 2.6.2
2023-06-07 16:31:01 +10:00
Maikel Linke
1ebacf96ad
Ignore accidental spaces around whitelabel URL
2023-06-07 13:12:06 +10:00
Matt-Yorkley
acc34d1deb
Update advance to payment logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e1b37090be
Use _path helper instead of _url
2023-06-07 00:58:43 +01:00
Matt-Yorkley
6e8ed1f612
Hide secondary form until the order has line items
2023-06-07 00:58:43 +01:00
Matt-Yorkley
c7bb24e2a0
Remove dead code and clarify update logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e88843c733
Ensure order number is generated nicely on new records
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Konrad
1b6147db30
Merge pull request #10896 from jibees/10571-bom-orders-not-sorted-by-most-recent-date
...
BOM: Sort by order completed at desc for line items by default
2023-06-06 17:37:54 +02:00
Matt-Yorkley
2bfb57a1a1
Clarify shipments partial inclusion
2023-06-06 14:59:53 +01:00
Matt-Yorkley
8813edaed8
Fix variables in form partial
2023-06-06 14:59:03 +01:00
Jean-Baptiste Bellet
7dc8c4b891
Hide OFN navigation also on small width screens
2023-06-06 14:55:41 +02:00
Jean-Baptiste Bellet
a8b85a65e9
Add context for visiting a path
2023-06-06 14:44:05 +02:00
Jean-Baptiste Bellet
5c3e07db52
Test that OFN navigation is on mobile views as well
2023-06-06 14:44:05 +02:00
dependabot[bot]
10ca09eaef
chore(deps): bump paranoia from 2.6.1 to 2.6.2
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.1...v2.6.2 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-06 10:00:41 +00:00
Jean-Baptiste Bellet
daaeca88e8
Add some helpers to test mobile views
2023-06-06 12:00:16 +02:00
Mohamed ABDELLANI
77554e21fc
move advance_to_payment on order's details page from edit to update
2023-06-06 10:23:01 +01:00
Matt-Yorkley
7c72969792
Move Order #state_changed method out into Checkout concern (alongside order states logic)
2023-06-05 23:54:04 +01:00
Matt-Yorkley
a62e51c0d0
Remove Order #refresh_shipment_rates method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
1a7d70772a
Make Order #products_available_from_new_distribution method private
2023-06-05 23:54:04 +01:00
Matt-Yorkley
3dd4e7ef03
Delegate order updater method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
8a27dd84fe
Make Order #disallow_guest_order method private
2023-06-05 21:30:49 +01:00
Matt-Yorkley
05a715a43a
Remove Order #distribution_set? method
2023-06-05 21:30:46 +01:00
Matt-Yorkley
17b10d10c0
Make Order #deliver_order_confirmation_email method private
2023-06-05 21:30:43 +01:00
Matt-Yorkley
10dbeb32b2
Remove Order #credit_cards method
2023-06-05 21:30:40 +01:00
Matt-Yorkley
b3bd112cdb
Remove Order #shipped_shipments method
2023-06-05 21:30:36 +01:00
Jean-Baptiste Bellet
93cf562d59
Update en.yml
2023-06-05 15:48:02 +02:00
Jean-Baptiste Bellet
5938577bd1
Update custom_tab_spec.rb
2023-06-05 15:43:11 +02:00
Jean-Baptiste Bellet
1594d1c718
Validate custom tab title
2023-06-05 15:41:33 +02:00
Jean-Baptiste Bellet
abe63e5b04
Add context for visiting a path
2023-06-05 12:08:43 +02:00
Jean-Baptiste Bellet
40111910b6
Validates white_label_logo_link on enterprise model
2023-06-05 11:24:07 +02:00
Jean-Baptiste Bellet
4edb159ef8
Avoid flaky spec by matching the array
...
Context: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/5081492387/jobs/9129944001?pr=10896
2023-06-05 10:05:09 +02:00
Jean-Baptiste Bellet
ccb183d60b
Sort by order_date desc for line_items in BOM
...
+ update spec to have different order time
2023-06-05 10:05:09 +02:00
jibees
a785b4d5e0
Merge pull request #10928 from openfoodfoundation/dependabot/bundler/rubocop-1.52.0
...
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
2023-06-05 09:28:04 +02:00
Maikel Linke
16fba20686
Update rubocop todo file
2023-06-05 12:13:35 +10:00
Maikel Linke
1cbb45a618
Style Lint/RedundantSafeNavigation
...
The cop suggested to change more but they were false positives:
* https://github.com/rubocop/rubocop/pull/11915
2023-06-05 12:09:32 +10:00
Maikel Linke
38bd31d0e3
Style Layout/TrailingWhitespace
2023-06-05 10:42:21 +10:00
Konrad
750b6b284d
Merge pull request #10910 from jibees/10902-white-label-for-uploading-custom-logo-use-same-design-as-for-enterprise-logobanner-and-provide-required-image-dimensions
...
[White Label] Backoffice: improve design for logo used in shopfront
2023-06-04 14:50:49 +02:00
dependabot[bot]
78338864d8
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.51.0 to 1.52.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.51.0...v1.52.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-02 09:57:30 +00:00
filipefurtad0
840da55941
Update all locales with the latest Transifex translations
2023-06-02 09:17:23 +01:00
Jean-Baptiste Bellet
880ba85791
Add http to white label logo link if this do not start with http
2023-06-01 17:37:05 +02:00
Jean-Baptiste Bellet
ced8f8aa58
Use shared_examples as we will test many URLs later on
...
"It's a Surprise Tool That Will Help Us Later"
2023-06-01 17:37:05 +02:00
jibees
d63c47e0f1
Merge pull request #10920 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.3
...
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
2023-06-01 17:26:54 +02:00
jibees
fd7d68d0a8
Merge pull request #10919 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.3
...
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
2023-06-01 17:25:58 +02:00
Jean-Baptiste Bellet
2e0191e603
Improve UX: same as enterprise logo and promo image
2023-06-01 17:16:22 +02:00
Filipe
12159edaca
Merge pull request #10833 from Matt-Yorkley/order-angular
...
Remove Angular from admin orders index page
2023-06-01 13:57:39 +01:00
Filipe
2ba0f635f2
Merge pull request #10860 from Matt-Yorkley/order-cycle-deleting
...
Delete exchange variants in bulk when deleting an order cycle
2023-06-01 13:49:32 +01:00
Filipe
d67227deb8
Merge pull request #10812 from Matt-Yorkley/options-values
...
Remove OptionValue and OptionType code
2023-06-01 13:49:16 +01:00
Matt-Yorkley
1128fd9c02
Visual tweak to ship/capture buttons and success feedback
2023-06-01 12:13:12 +01:00
dependabot[bot]
3e46115f79
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 10:00:31 +00:00
dependabot[bot]
e428944849
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.2...v6.0.3 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 09:59:07 +00:00
Matt-Yorkley
e99c328643
Update app/services/variant_units/variant_and_line_item_naming.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
0ac10472cf
Update app/models/spree/line_item.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
7f5d1be792
Guard against unsaved variant's product in OptionValueNamer for product import
2023-06-01 10:12:19 +01:00
Matt-Yorkley
a20277c3a7
Completely remove option_values and option_types from the codebase
2023-06-01 10:12:19 +01:00
Matt-Yorkley
35b41fc7fe
Persist unit_value on variant and "option value text" on variant and line_item and improve related AR callbacks
2023-06-01 10:12:19 +01:00
Matt-Yorkley
bfcf1203ac
Delete dead code
2023-06-01 10:11:20 +01:00
Matt-Yorkley
896e4c45f2
Clarify confusing class
2023-06-01 10:11:20 +01:00
Matt-Yorkley
3e5ecba738
Remove unhelpful Helper
2023-06-01 10:11:20 +01:00
Matt-Yorkley
e5eb622ac7
Cut dead code
2023-06-01 10:11:20 +01:00
Filipe
6b98e2b3cb
Merge pull request #10911 from jibees/10901-white-label-customized-logo-on-small-screens-doesnt-use-the-customized-url
...
[White Label] Small width screens : use the white label link if exists for logo in nav bar
2023-06-01 08:16:53 +01:00
Filipe
61b70a25d9
Merge pull request #10897 from openfoodfoundation/dependabot/npm_and_yarn/mrujs-1.0.0
...
chore(deps): bump mrujs from 0.10.1 to 1.0.0
2023-06-01 08:03:32 +01:00
Filipe
e0d24ed5c0
Merge pull request #10912 from openfoodfoundation/dependabot/bundler/puma-6.3.0
...
chore(deps): bump puma from 6.2.2 to 6.3.0
2023-06-01 07:42:22 +01:00
Filipe
2d4d8e26f5
Merge pull request #10875 from jibees/10561-allow-user-to-create-custom-tab-in-shop-navigation
...
[White Label] Allow user to create custom tab in shop navigation
2023-06-01 07:21:25 +01:00
Maikel
add725b6c0
Merge pull request #10861 from mkllnk/dfc-import
...
Update products with DFC Prototype
2023-06-01 08:48:39 +10:00
Filipe
5f429c77f8
Merge pull request #10791 from dacook/10630-new-brand-colours
...
[admin_v3] New brand colours in admin interface
2023-05-31 16:03:18 +01:00
dependabot[bot]
1b6815515e
chore(deps): bump puma from 6.2.2 to 6.3.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.2.2 to 6.3.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.2.2...v6.3.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-31 10:01:43 +00:00
Jean-Baptiste Bellet
ac30e8b9da
Use the white label link if exists, otherwise, use the main_app.root_path
2023-05-31 10:46:23 +02:00
Filipe
668a573f12
Merge pull request #10908 from filipefurtad0/flaky_simple_spec
...
Changes date through keystrokes; removes Retry option
2023-05-30 16:43:36 +01:00
filipefurtad0
c5358b1303
Changes date through keystrokes; removes Retry option
2023-05-30 10:02:44 +01:00
jibees
7b6077d01f
Merge pull request #10905 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.9
...
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
2023-05-29 14:57:34 +02:00
dependabot[bot]
841a021bc4
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.8 to 1.2.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.9/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-29 09:59:12 +00:00
jibees
7ea2aa699d
Merge pull request #10904 from mkllnk/update-job-spec
...
Simplify background report spec after rspec fix
2023-05-29 10:19:31 +02:00
Maikel Linke
3fa62ceccf
Simplify background report spec after rspec fix
...
The rspec-rails gem had an issue which was fixed in the last release.
Now we can remove my workaround and simplify the spec.
2023-05-29 13:25:44 +10:00
David Cook
24c407f920
Merge pull request #10898 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.1
...
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
2023-05-29 13:09:15 +10:00
Maikel Linke
77f716306d
Remove redundant test
2023-05-29 10:07:34 +10:00
Konrad
fff02a7ddb
Merge pull request #10893 from jibees/10853-white-label-remove-ofn-logo-on-navigation-menu-for-small-width-screens
...
[White Label] Small width screens: Hide OFN logo and use the customized logo if activated
2023-05-28 12:00:49 +02:00
Maikel Linke
0dcd87dda9
Update stock and SKU from DFC
...
The input has been observed with the nginx access log including
$request_body when the DFC Protoype pushed an update.
2023-05-28 10:39:08 +02:00
Maikel Linke
375b3a3cb0
Update variant's quantity from DFC
2023-05-28 10:39:08 +02:00
Maikel Linke
48a52582e6
Update variant description with DFC description
...
We used the name before because the DFC Prototype only displays the
description.
2023-05-28 10:39:08 +02:00
Maikel Linke
63837381e0
Update DFC test data with observation
...
This request came from the current DFC prototype. The changes are
probably implementing DFC v1.7.
I observed by including `$request_body` in the nginx log on the staging
server.
2023-05-28 10:39:08 +02:00
Maikel Linke
50ef06c973
Name DFC test data to clarify content
...
The DFC has several products like PhysicalProduct and SuppliedProduct.
Here we have a supplied product.
2023-05-28 10:39:08 +02:00
Maikel Linke
7344eb678b
Remove now unused helper
...
It was only used in controller specs which were all converted to request
specs.
2023-05-28 10:39:08 +02:00
Maikel Linke
dde4ea9334
Convert CatalogItems controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
207a15e55c
Convert SuppliedProducts controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
742468efd2
Convert EnterpriseController spec to request spec
...
Also testing request of unrelated enterprise instead of non-existing
enterprise because authorisation is important to test.
2023-05-28 10:39:08 +02:00
Maikel Linke
d338c61d2c
Convert PersonsController spec request spec
...
It's much more realistic and also tests the routing and authentication.
Besides using real authentication I also improved the matchers.
2023-05-28 10:39:08 +02:00
Maikel Linke
67c29dd38f
Activate DFC provider engine, remove feature toggle
2023-05-28 10:39:08 +02:00
Jean-Baptiste Bellet
01b3b3b5bb
Add some specs around tab for a shop
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6b29f7e3c5
Sanitize content with a new TrixScrubber
...
specifically made for trix editor with its allowed tags
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
f26ecdf4f9
Don't need to pass the order through the nested view
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6775e0b8f1
Add custom_ prefix to avoid name collision
...
One can name the custom tab `shop` which can be confusing.
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
9e67bd5824
Use specified values to be sure they aren't empty
2023-05-26 15:19:27 +02:00
dependabot[bot]
2f1e3a5c96
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.0 to 7.1.1.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.0...v7.1.1 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 10:01:59 +00:00
dependabot[bot]
856fcd9e18
chore(deps): bump mrujs from 0.10.1 to 1.0.0
...
Bumps [mrujs](https://github.com/KonnorRogers/mrujs ) from 0.10.1 to 1.0.0.
- [Changelog](https://github.com/KonnorRogers/mrujs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/KonnorRogers/mrujs/compare/v0.10.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: mrujs
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 09:58:38 +00:00
Matt-Yorkley
e34c2acba8
Move CablecarResponses include to ApplicationController
2023-05-26 10:35:41 +01:00
Matt-Yorkley
2373d044f7
Update app/services/orders_bulk_cancel_service.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-26 10:33:23 +01:00
Jean-Baptiste Bellet
a24604f146
Remove unused enterprise declaration
2023-05-26 10:24:11 +02:00
David Cook
14345ef1fa
Change warning orange to Mojo
...
> That way we only have one orangy/red colour and we start simplifying things.
2023-05-26 15:11:23 +10:00
David Cook
0df7c45a61
Change warning red to Mojo
...
Some templates still had this colour hardcoded. They are using angular so I didn't spend time updating them.
2023-05-26 15:11:23 +10:00
David Cook
dcf857cafb
Move warning colour definition to CSS
...
This also changes the orange to red, but that's part of the plan.
2023-05-26 15:11:23 +10:00
David Cook
e674c53535
Change error red color to Mojo
...
color-5 is used for error messages.
2023-05-26 15:11:23 +10:00
David Cook
719a704985
Change blue colour as per design
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/10630#issue-1644928392
2023-05-26 15:11:23 +10:00
David Cook
60ec24b92b
Use variables for spree-blue
...
Aka 'Havelock Blue', which is going to be changing.
2023-05-26 15:11:23 +10:00
David Cook
e928e74ae6
Use different palette for admin styles v3
...
Note that mail.css is still referring to the old palette.
2023-05-26 15:10:49 +10:00
David Cook
31fa9c2c04
Add admin_style_v3 feature toggle
2023-05-26 15:10:27 +10:00
David Cook
01b3901b08
Add admin_style_v3
...
Individual files may be copied in order to replace the old files.
NOTE: these may need manually re-syncing. If any of the copied files have changed on master in the meantime, we'll need to manaully review to consider bringing those changes to the new design.
2023-05-26 15:10:27 +10:00
David Cook
9051318147
Move colour palette to new file
...
This seemed like a good separation which will probably help with the upcoming changes.
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-05-26 15:09:59 +10:00
Maikel
b013d3f2d4
Merge pull request #10895 from jibees/10894-flaky-speccontrollersapiv0order_cycles_controller_specrb89
...
Fix flaky spec: Prefer using `match_array` over `eq` to compare array
2023-05-26 14:06:14 +10:00
Maikel Linke
2e52a633ae
Acknowledge new style violations
2023-05-26 13:34:48 +10:00
Maikel Linke
15ef826ac1
Style Style/ClassAndModuleChildren
2023-05-26 13:27:34 +10:00
Maikel Linke
f674d5cd37
Style Layout/TrailingEmptyLines
2023-05-26 13:26:30 +10:00
David Cook
875f68b0e2
Update one more translation
2023-05-26 11:46:22 +10:00
Jean-Baptiste Bellet
cf9342f2c4
Prefer using match_array over eq to compare array
...
As we don't need order: https://rubydoc.info/github/rspec/rspec-expectations/RSpec%2FMatchers:match_array
2023-05-25 15:24:25 +02:00
Jean-Baptiste Bellet
eea1db4c4a
Hide OFN logo and use the customized logo if activated
2023-05-25 15:17:04 +02:00
jibees
8dde81c498
Merge pull request #10891 from openfoodfoundation/dependabot/bundler/test-unit-3.5.9
...
chore(deps): bump test-unit from 3.5.8 to 3.5.9
2023-05-25 13:34:38 +02:00
dependabot[bot]
2084d84c7a
chore(deps): bump test-unit from 3.5.8 to 3.5.9
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.8 to 3.5.9.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.8...3.5.9 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-25 09:58:28 +00:00
Filipe
8b7ca292af
Merge pull request #10884 from openfoodfoundation/10882-cookie-banner-is-displayed-on-every-page-even-after-accepting
...
Do not show cookies banner once user accept it
2023-05-25 10:36:27 +01:00
Jean-Baptiste Bellet
f961548da2
Deactivate file upload for trix editor
...
Source: https://benborgers.com/posts/trix-disable-files
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
e434eb17f0
Use full width since we use a WYSIWYG editor with toolbar
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb211bfc84
Allow HTML via trix editor for custom tab content
...
+ update spec as well
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
4dede3b361
Add trix editor
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6e677f15ec
Can delete custom tab if uncheck the checkbox
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
f0665b0862
Add custom tab on shop
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
916b2313ab
Some links does not include _panel suffix. Add if needed.
...
Yep. Sounds like a hack.
+ Use the right URL anchor with `_panel` in href for each tab
+ update specs
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
fc21fdb485
Customize default tab: could be either shop or home
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6b1d1ddbce
On order cycle change, go to shop panel
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
a28a792642
Allow communication between controllers via event
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb6b1e59f9
Use tabs_and_panels_controller.js instead of PageSelectionCtrl
...
Prefer StimulusJS over Angular
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
925b0e0308
Add a form in admin to create/update a custom tab for an enterprise
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
839419791f
Create CustomTab model, that belongs to an enterprise
2023-05-25 09:19:51 +02:00
David Cook
f890d9ceb4
Update all locales with the latest Transifex translations
2023-05-25 17:12:10 +10:00
jibees
abc0a29ddb
Merge pull request #10889 from mkllnk/dead-code
...
Remove dead reference to removed model
2023-05-25 09:10:14 +02:00
Maikel Linke
86c35fe2dc
Remove dead reference to removed model
2023-05-25 16:13:33 +10:00
Filipe
6d032002f1
Merge pull request #10750 from jibees/10560-allow-hide-of-groups-tab-in-shop-navigation
...
White Label: allow hide of groups tab in shop navigation
2023-05-24 21:11:04 +01:00
filipefurtad0
ca107c036c
Enables caching for cookies_spec.rb
2023-05-24 19:46:28 +02:00
jibees
e60376e6bd
Merge pull request #10885 from openfoodfoundation/dependabot/bundler/faraday-2.7.5
...
chore(deps): bump faraday from 2.7.4 to 2.7.5
2023-05-24 15:18:10 +02:00
jibees
d704157fef
Merge pull request #10886 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.1.0
...
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
2023-05-24 15:17:16 +02:00
dependabot[bot]
b985ab8d99
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.0.0 to 4.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:10:08 +00:00
dependabot[bot]
d60ba96fe9
chore(deps): bump faraday from 2.7.4 to 2.7.5
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.4 to 2.7.5.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.4...v2.7.5 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:08:17 +00:00
Jean-Baptiste Bellet
3cd53cbd41
Adds some keys to this cached element, due to cookie banner
...
Once the user accept the cookie, we should not show the cookie banner element. This is handled via `app/helpers/footer_links_helper.rb#cookies_policy_link` and boolean:
```
!Web::CookiesConsent.new(cookies, request.host).exists? && Spree::Config.cookies_consent_banner_toggle
```
2023-05-24 10:45:06 +02:00
Maikel Linke
b4deb21872
Bump Ruby from 3.0.3 to 3.1.4
...
Major 3.1 highlights:
* https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/
2023-05-24 16:52:34 +10:00
Maikel
32d425dd58
Merge pull request #10880 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.0.0
...
Bump knapsack_pro from 3.11.0 to 4.0.0
2023-05-24 14:05:09 +10:00
Maikel
ce1317933b
Merge pull request #10815 from Pauloparakleto/issue-7483
...
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
2023-05-24 11:57:44 +10:00
Maikel
340f10b323
Merge pull request #10539 from filipefurtad0/spec_for_enterprise_fee_selection_tax_inherit
...
Adds a spec to check enterprise fees creation
2023-05-24 11:29:27 +10:00
Maikel
8c11bf3033
Merge pull request #10839 from mkllnk/valid-email
...
Validate user's email address
2023-05-24 10:37:00 +10:00
Konrad
0854287b92
Merge pull request #10744 from jibees/10556-remove-ofn-header-banner-in-order-confirmation-emails
...
White Label: remove OFN banner from order confirmation emails when `hide_ofn_navigation` is activated for the shop
2023-05-24 01:14:16 +02:00
dependabot[bot]
6dc1cb6baa
Bump knapsack_pro from 3.11.0 to 4.0.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.11.0 to 4.0.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.11.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-23 10:01:38 +00:00
Maikel Linke
ef3422bf58
Update syntax and clarify use of outdated gem
2023-05-23 08:23:58 +02:00
Maikel Linke
90cbac7176
Validate email domains
...
The gem checks the DNS system for a valid domain entry.
2023-05-23 08:23:58 +02:00
Maikel Linke
ffc45f77cf
Validate user email syntax on change
...
We probably have invalid entries in the database and we don't want these
records to suddenly become invalid. People would not be able to log in.
2023-05-23 08:23:58 +02:00
Maikel Linke
101b9025b4
Spec user email validation
...
The pending spec addresses:
* https://github.com/openfoodfoundation/openfoodnetwork/issues/10808
2023-05-23 08:23:58 +02:00
Konrad
b56b36f617
Merge pull request #10859 from filipefurtad0/change_voucher_default_message_en
...
[Vouchers] Updates warning_forfeit_remaining_amount default message
2023-05-23 08:20:41 +02:00
filipefurtad0
5e248aa715
Improving shared_example naming
2023-05-22 12:27:04 +01:00
filipefurtad0
554d515875
Introduces prefix to simplify assertions
2023-05-22 12:27:04 +01:00
Matt-Yorkley
459ef5f0d1
Only delete related exchange variants if exchange is outgoing
2023-05-22 11:09:29 +01:00
Jean-Baptiste Bellet
0bec7562a0
When hide_groups_tab is set to false, do not display group in shopfront
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-05-22 10:29:57 +02:00
Jean-Baptiste Bellet
0d98ec8f4c
In admin, add form to set hide_groups_tab attribute
...
+ add specs
2023-05-22 10:29:56 +02:00
Jean-Baptiste Bellet
38cc8a89d1
Add hide_groups_tab to Enterprise model
2023-05-22 10:29:56 +02:00
Matt-Yorkley
7c5067ff42
Update "special instructions" note tooltip and add missing test coverage
2023-05-21 14:06:14 +01:00
Matt-Yorkley
005d95e882
Fix "Resend Confirmation" link and add missing test coverage
2023-05-21 13:33:29 +01:00
Matt-Yorkley
dcdcdb4fc0
Align filter buttons centrally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
abf00353ea
Permit explicit params
2023-05-21 00:15:32 +01:00
Matt-Yorkley
be1ed2bbcf
Update tomselect multiselect styling
2023-05-21 00:15:32 +01:00
Matt-Yorkley
52450028a1
Fix checkbox alignment
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d50ac4bf45
Reinstate dropdown-with-prepend
2023-05-21 00:15:32 +01:00
Matt-Yorkley
4ddde65a04
Reimplement saving and restoring submitted search filters between page loads
2023-05-21 00:15:32 +01:00
Matt-Yorkley
7d33e0f74d
Allow programmatically refreshing flatpickr element via "flatpickr:change" event after changing the select's value externally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
2ba2a826db
Clean up event handlers on disconnect in Flatpickr controller
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d64a9afece
Replace angular ofn-with-tip directive on capture/ship buttons
2023-05-21 00:15:32 +01:00
Matt-Yorkley
770880c062
Update specs
2023-05-21 00:15:32 +01:00
Matt-Yorkley
310577c49d
Close dropdown after selection with multiselect
...
This conforms with the previous select2 multiselect behaviour
2023-05-21 00:15:32 +01:00
Matt-Yorkley
c3cf79f5ef
Delete angular ordersCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
71c4f2a5be
Update styling on multiselect tabs for tom-select
2023-05-21 00:15:32 +01:00
Matt-Yorkley
95f1643cec
Combine related reflex actions
2023-05-21 00:15:32 +01:00
Matt-Yorkley
bee46720f4
Combine bulk action controllers and pass reflex as an argument
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5930d0c1f5
Make bulk actions more generic
2023-05-21 00:15:32 +01:00
Matt-Yorkley
55d9deb5bd
Update order cancelling bulk action
2023-05-21 00:15:32 +01:00
Matt-Yorkley
134f1ab151
Replace angular bulkInvoiceCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
27290e5b57
Make modal controller creatable and destroyable
2023-05-21 00:15:32 +01:00
Matt-Yorkley
25aecfa5b9
Add reflex for shipping orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
e58a37f65b
Add reflex for capturing orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
61849d84e7
Extract order capturing to OrderCaptureService
2023-05-21 00:15:32 +01:00
Matt-Yorkley
73b41154cc
Update admin flashes
2023-05-21 00:15:32 +01:00
Matt-Yorkley
048df6230b
Remove angular from admin orders index page
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5ad68f25e3
Handle old jquery_ujs buttons
2023-05-21 00:15:30 +01:00
Matt-Yorkley
3df166fb2f
Drop jquery_ujs
2023-05-20 19:47:41 +01:00
Matt-Yorkley
59fd4ad251
Tidy up JS imports
2023-05-20 19:47:41 +01:00
Matt-Yorkley
48a8f57262
Prep admin JS
2023-05-20 19:47:41 +01:00
Matt-Yorkley
f181b35a90
Add minimal admin js setup
2023-05-20 19:47:41 +01:00
Matt-Yorkley
c4bc0a7bbd
Rename select-all-controller
2023-05-20 19:47:41 +01:00
paulo-felipe
3a35f12801
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group together sample tests to avoid rebuilding browser state.
2023-05-19 19:55:27 -03:00
paulo-felipe
c9ab092f7c
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add back comment explaining bill address has been pre-loaded.
2023-05-19 19:55:27 -03:00
paulo-felipe
1e1d4b07d1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Remove the old chained smoke test.
2023-05-19 19:55:27 -03:00
paulo-felipe
bd05f40b17
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too long offense and separate variables from expectations.
2023-05-19 19:55:27 -03:00
paulo-felipe
105d695f18
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check creation of standing line items when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
4df550fcf1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check basic Subscription properties when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
49ceec8b8e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
share common before action Create subscription between samples.
2023-05-19 19:55:27 -03:00
paulo-felipe
03aade4072
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
It has selector for price, input for quantity and selector for total price.
2023-05-19 19:55:27 -03:00
paulo-felipe
f0da85d723
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
2023-05-19 19:55:27 -03:00
paulo-felipe
8c709e13e0
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too lng offense.
2023-05-19 19:55:27 -03:00
paulo-felipe
c63a8d12f7
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product and click next button.
2023-05-19 19:55:26 -03:00
paulo-felipe
5a5aa4c067
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product.
2023-05-19 19:55:26 -03:00
paulo-felipe
5776bdb31c
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product.
2023-05-19 19:55:26 -03:00
paulo-felipe
b0623ab4de
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product.
2023-05-19 19:55:26 -03:00
paulo-felipe
f05e2618be
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and click next button without adding at least one product.
2023-05-19 19:55:26 -03:00
paulo-felipe
35ce463811
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page.
2023-05-19 19:55:26 -03:00
paulo-felipe
7efc68281e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when using copy button to fill in ship address.
2023-05-19 19:55:26 -03:00
paulo-felipe
aa16110e9a
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address. MOve scenario to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
39a76861f3
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
79ff13e8ba
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Move on second page to a before action and clearing some elements of bill address to a before action. Let the unit test with the action isolated.
2023-05-19 19:55:26 -03:00
paulo-felipe
573ab1beb0
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on second page when clearing some elements of the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
384ad1ba12
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group context for first page scenarios. Extract common customer actions to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
77857a0168
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when date field is filled. It goes to the next page with preloaded data.
2023-05-19 19:55:26 -03:00
paulo-felipe
47b0d626e2
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen describe it better as per reviewer suggestion.
2023-05-19 19:55:26 -03:00
paulo-felipe
0bf7e53ce4
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen.
2023-05-19 19:55:26 -03:00
Konrad
fed7c3da51
Merge pull request #10761 from rioug/vouchers-any-amount
...
[Vouchers] Flat rate of any amount
2023-05-19 17:39:33 +02:00
Matt-Yorkley
a8559e621f
Simplify exchange variant callback and prefer delete over destroy
...
Delete is faster than destroy but should only be used if the object has no callbacks or touches.
2023-05-19 11:26:33 +01:00
Matt-Yorkley
434c9ae110
Delete exchange variants in bulk when deleting an order cycle
2023-05-19 10:46:55 +01:00
David Cook
9d7316c553
Use a fixed value for voucher factory
2023-05-19 17:19:54 +10:00
Maikel Linke
37441be371
Update translations
2023-05-19 14:33:23 +10:00
Maikel
0d403f4087
Merge pull request #10814 from Matt-Yorkley/serializer-eager-loading
...
Improve eager-loading on admin products page
2023-05-19 14:31:25 +10:00
Maikel
f943b411c5
Merge pull request #10823 from abdellani/fix-file-name-used-as-parameter
...
[Security] Validate product import file path
2023-05-19 14:28:09 +10:00
Maikel
7af14e37fa
Merge pull request #10488 from mkllnk/dfc-connector
...
Serialize DFC catalog items with DFC Connector
2023-05-19 11:31:23 +10:00
filipefurtad0
8d2885e147
Updates spec after merging #10512
2023-05-18 16:04:30 +01:00
filipefurtad0
51b144f174
Covers editing into invalid combinations
2023-05-18 15:59:48 +01:00
filipefurtad0
4e2095f0fb
Tests enterprise fee creation
...
...when inheriting tax category from product
as shared examples
2023-05-18 15:59:48 +01:00
Filipe
3d1b0816ed
Merge pull request #10512 from abdellani/fix-tax-not-charged-when-tax-category-set-to-inherit-from-product
...
Prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-18 13:43:14 +01:00
Konrad
39bb1f6f41
Merge pull request #10832 from Matt-Yorkley/cloning
...
Clone all ExchangeVariant objects in bulk
2023-05-18 14:32:30 +02:00
filipefurtad0
c99829e457
Updates spec to reflect change on en.yml
2023-05-18 12:11:37 +01:00
filipefurtad0
7ea3834900
Updates warning_forfeit_remaining_amount default message
2023-05-18 11:57:15 +01:00
David Cook
360a241402
Style fix
2023-05-18 10:07:52 +10:00
Filipe
0d23b63bbd
Merge pull request #10779 from dacook/10634-remove-admin_style_v2
...
10634 Remove admin_style_v2 feature
2023-05-17 15:37:05 +01:00
Konrad
19caadb1a0
Merge pull request #10800 from dacook/remove-localisation
...
Also remove localized number logic from weight calculator
2023-05-17 14:57:26 +02:00
David Cook
c0c123a92a
Remove localized number logic from weight calculator
...
Follow-on from a46eef291c
2023-05-17 14:10:58 +02:00
Konrad
f26bef5f98
Merge pull request #10813 from saunmanoj888/fix-fullname-search-issue-on-bulk-orders
...
Fix searching issue with full name on bulk order management
2023-05-17 13:58:04 +02:00
saunmanoj888
aee7645e29
Fix searching issue with full name on bulk order management
2023-05-17 13:14:10 +02:00
Konrad
02873d7596
Merge pull request #10817 from Matt-Yorkley/permissions-scoping
...
Scope orders before bulk actions
2023-05-17 12:44:07 +02:00
Matt-Yorkley
e1b0a03819
Scope orders before bulk actions
2023-05-17 12:03:40 +02:00
Jean-Baptiste Bellet
2336981ca0
Do not display OFN banner on order confirmation email if white label
2023-05-17 11:35:18 +02:00
Jean-Baptiste Bellet
dfafbfe996
Create an order confirmation email preview of the last completed order
...
Available on `/rails/mailers/order_mailer/confirm_email_for_customer`
2023-05-17 11:35:06 +02:00
Jean-Baptiste Bellet
f7d06fe0e8
Do not display OFN banner on subscription confirmation email if white label
...
+ add specs that test for the presence of the footer logo which is in the header (I know it's a bit contradictory)
2023-05-17 11:34:35 +02:00
Jean-Baptiste Bellet
3ed89fc2db
Create a subscription confirmation email preview of the last completed order
...
Available on: `/rails/mailers/subscription_mailer/confirmation_email`
2023-05-17 11:34:16 +02:00
Maikel Linke
eaf3bd0bae
Update spec after new import file validation
2023-05-17 15:18:29 +10:00
Mohamed ABDELLANI
fcb8550cb1
extract file path sanitizer to an independent class
2023-05-17 15:09:48 +10:00
Mohamed ABDELLANI
4d5ba6a7e6
add file path validation
2023-05-17 15:09:48 +10:00
Maikel Linke
a0d05b26d1
Spec current product import vulnerabilities
...
I didn't use pending specs but deliberately passing specs on wrong
behaviour. This is not how it should be but how it is at the moment.
2023-05-17 15:09:01 +10:00
Konrad
4a66b62fa7
Merge pull request #10825 from jibees/10824-remove-feature-toggle-on-white-label-feature
...
Activate white label feature
2023-05-16 13:50:58 +02:00
Maikel
16329e953f
Merge pull request #10844 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.0
...
Bump jasmine-core from 4.6.0 to 5.0.0
2023-05-16 17:50:39 +10:00
Gaetan Craig-Riou
abf2105df7
Admin::VoucherController check enterprise permission
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
355af9e818
Per review comment, build enterprise instead of create
...
Speed up testing by removing unnecessarily created record
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b585f77be4
Make enterprise mandatory for a voucher
...
It should have already been the case...
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
2d8fa24862
Add a voucher factory
...
As vouchers are getting more complicated, it makes sense to use a
factory to simplify writing test.
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b427e420ce
Update admin pages to allow entering an amount
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
15eee8175e
Add amount to voucher
...
Change value to amount to be more consistent
2023-05-16 16:19:59 +10:00
Maikel
10c918be75
Merge pull request #10732 from mkllnk/report-email
...
[Hidden] Notify about completed report with download link via email
2023-05-16 10:25:23 +10:00
Maikel
a979f7c8df
Merge pull request #10587 from rioug/10432-vouchers-bare-minimum-checkout
...
10432 vouchers bare minimum checkout
2023-05-16 09:19:06 +10:00
Maikel Linke
08aff56e20
Expire report files after 1 week, maximum for S3
...
We didn't see this in tests which use disk storage. But AWS S3 has a
maximum of one week for URL expiry.
2023-05-15 19:41:45 +02:00
Maikel Linke
5ae04a5a3e
Hide report link which only works at unknown time
...
It was bad UX to show a link that doesn't work straight away. At the
time, it was the only way to download the report but now we send an
email which is a much better way to go.
I leave the rest of the code because we want to implement a reflex which
shows the download link once it's ready.
2023-05-15 19:41:45 +02:00
Maikel Linke
299bc253a4
Expire report download links in a month, not 5mins
2023-05-15 19:41:45 +02:00
Maikel Linke
8a8c53ceee
Add ReportMailer preview for devs
2023-05-15 19:41:45 +02:00
Maikel Linke
860fe85af9
Add report download link to email notification
...
I added a system spec to verify that the download link can be generated
within the mailer in a background job. ActiveStorage is a bit particular
when it comes to genererating URLs and depending on the situation it may
generate a redirect URL, a proxy URL or link directly to the storage.
But we want a redirect URL here.
2023-05-15 19:41:45 +02:00
Maikel Linke
cf5a8a26ce
Notify only about slow reports
...
It would be annoying to get an email for reports which display on the
screen immediately.
2023-05-15 19:41:45 +02:00
Maikel Linke
1f4af7f990
Send (dummy) email when background report is done
...
I'll fill it out in future commits.
2023-05-15 19:41:45 +02:00
Jean-Baptiste Bellet
aaa9bac4dd
Remove white_label feature toggle
...
White label is now activated for everyone.
+ add mock for `spec/controllers/spree/orders_controller_spec.rb`
2023-05-15 17:10:50 +02:00
jibees
d43678c68b
Merge pull request #10827 from filipefurtad0/logging_out_spec
...
Adds test case for logging out
2023-05-15 15:33:56 +02:00
Jean-Baptiste Bellet
ec0cbc5bf9
Avoid warning by being more precise about *.erb files
2023-05-15 15:29:28 +02:00
jibees
a1e4c45daa
Merge pull request #10843 from openfoodfoundation/dependabot/bundler/rubocop-1.51.0
...
Bump rubocop from 1.50.2 to 1.51.0
2023-05-15 15:03:24 +02:00
jibees
edeedc0704
Merge pull request #10841 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.8
...
Bump @floating-ui/dom from 1.2.7 to 1.2.8
2023-05-15 15:02:22 +02:00
jibees
d2539b34e0
Merge pull request #10840 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.7
...
Bump rails-i18n from 7.0.6 to 7.0.7
2023-05-15 15:01:12 +02:00
jibees
fea3957481
Merge pull request #10845 from openfoodfoundation/dependabot/bundler/test-unit-3.5.8
...
Bump test-unit from 3.5.7 to 3.5.8
2023-05-15 15:00:03 +02:00
jibees
b183832fbb
Merge pull request #10842 from openfoodfoundation/dependabot/bundler/capybara-3.39.1
...
Bump capybara from 3.39.0 to 3.39.1
2023-05-15 12:22:59 +02:00
dependabot[bot]
8a352132a0
Bump test-unit from 3.5.7 to 3.5.8
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.7 to 3.5.8.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.7...3.5.8 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:55 +00:00
dependabot[bot]
0e59a5db91
Bump jasmine-core from 4.6.0 to 5.0.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.6.0 to 5.0.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.6.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:22 +00:00
dependabot[bot]
340fe91e07
Bump rubocop from 1.50.2 to 1.51.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.2 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.2...v1.51.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:15 +00:00
dependabot[bot]
6c126cfc33
Bump capybara from 3.39.0 to 3.39.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.0 to 3.39.1.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.0...3.39.1 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:59:19 +00:00
dependabot[bot]
82c6eaab4e
Bump @floating-ui/dom from 1.2.7 to 1.2.8
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.7 to 1.2.8.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.8/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:51 +00:00
dependabot[bot]
d4918893a7
Bump rails-i18n from 7.0.6 to 7.0.7
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.6 to 7.0.7.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:24 +00:00
jibees
1e05bc5b5c
Merge pull request #10789 from jibees/10770-bom-cancelling-an-order-always-restocks-the-line-item
...
BOM: when deleting the last item of order that leads to order cancellation, take into account the restock items checkbox
2023-05-15 09:50:13 +02:00
Mohamed ABDELLANI
7f52684488
add check_calculators_compatibility_with_taxes before running enterprise bulk update
2023-05-15 07:35:52 +01:00
Gaetan Craig-Riou
5eb6097101
Fix error handling when creating a voucher adjustment
...
I wrongly assumed that `voucher.create_adjustment` would return nil
if failing to create an adjustment. I will in fact return an
adjustment object with errors.
2023-05-15 13:42:40 +10:00
David Cook
ccff3379ea
Update schema.rb
...
On a freshly mirrored prod db, I found these changes.
I don't know why.. but hopefully this is correct.
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
d29119f5c5
Remove non need belongs_to associations from Adjustments
...
It turns out the "tax_rate" association isn't used and wasn't working.
Same for the "voucher" one, which I added to be consistent with existing
code.
Both of these weren't caught by the specs because you can't test associations
with a custome relation with 'shouda-matchers' see: https://github.com/thoughtbot/shoulda-matchers/issues/981
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b67f5ae154
Fixing Rubocop issue
...
My editor automatically remove blank character on empty line, that's
why rubocop got grumpy here.
2023-05-15 13:42:40 +10:00
Matt-Yorkley
9b1725d39f
Fix model name in adjustment association
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b80274f49d
Per review comment, Use named value on voucher submit button to distinguish between submission types
...
The voucher apply button is inside form that has another a submit button,
it leads to a weird situation where either one will submit the whole
payments page form. Adding a named parameter on the voucher apply button
means we can distinguish between the two by checking for the presence
of params[:apply_voucher].
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
92bcd937dc
Per review comment, remove form object from the partial
...
This partial is rendered inside another <form> element, nested form
don't work.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
0a249d7722
Fix ButtonEnableToggleController to remove hacky button disable
...
As per review comment, use data-disable-with="false" do prevent Rails
from automatically enabling the "Apply" button. We can then remove
the timeout hack.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
236f6926d9
Cleaning up left over TODOs
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
aa526a639c
Checkout payment page, enable voucher "apply" button when code entered
...
The "apply" button is disabled by default. If left enabled, a customer
could try to apply an empty voucher, which results in system trying
to move to the order summary step, an unexpected behaviour!
We only enable the button when something is entered in the input.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
e5f14177d3
Fix rubocop warning
...
I guess the new cops are effective :)
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
815dcbcefe
Fix translations
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
a2e1e6ca33
Review comment, use dig to access voucher_code param
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
2f1fe6d096
Fix rubocop warning
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
56e981d300
Refactor Voucher to get rid of CalculatedAdjustments
...
Voucher adjustment have complicated calculation that prevent us from
using Spree::Calculator, and we need to override CalculatedAdjustments
method, so no point using it.
We still keep the same methods to stay as consitent as possible in
regards to adjustments
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
43ab881181
Rename order association to voucher_adjustments
...
The name vouchers is a bit confusing as the order is linked to a
voucher adjutment and not the actual voucher
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
fe9b94a80e
Fix cart disappearing bug after adding a voucher
...
The split checkout page uses `mrujs` and `CableCar` to set the form as
a remote one and perform `CableCar` operation if any : https://mrujs.com/how-tos/integrate-cablecar
The previous solution broke the cart handled by angularJS, it looks like
`morpdom` (https://mrujs.com/references/remote-forms-and-links Navigation Adapter section )
was doing something that angularJS didn't like when redirecting to
the current page.
With the power of `CableCar`, we now replace the #voucher-section on the
split checkout page instead of doing a redirect.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
94294fa161
Voucher adjustment, add ordering by created_at
...
It gives us a consistent result when calling #vouchers
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
a1ad25f217
Fix failing specs
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
bb9d835bd8
Fix rubocop warning
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
87cc525d27
Refactor #vouchers
...
Use "has_many" instead of a method
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
4b5d6d7eac
Fix voucher adjustments association
...
Add missing, "inverse_of" and "dependent" options. Use :nullify as
for "dependent" because we would want to keep the adjustments on order
even if the voucher is deleted.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
58469adfeb
Adjustments spec, add association test
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
5064bf5383
Allow voucher adjustment to be created with an amount of 0
...
Although unlikely, we should still be able to create a voucher amount
with. This can happen if the order.total is for instance.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
9789911523
Rework how voucher are applied to an order and handle tax calculation
...
At the time when we can apply a voucher to an order (payment step) we
don't have any data on possible taxes and payment fees. These are
calculated when we move to the summary step. So voucher are applied in
two step:
- create an "open" voucher adjustment on the order when a customer enters
a voucher code.
- when we move to the summary step, recalulate the amount and
possible tax for the voucher adjustment, once taxes and payment fees
have been included in the order. And then close the original and update
order to reflect the changes
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
d157d91054
When voucher cover more than order total, use only amount needed
...
The checkout payment step will also show a warning.
The amount used is stored in the adjustment created, so we will be able
to track how much has been used down the line.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
3f609d3842
Add error message if adding a voucher fails
...
It's not really useful to the user but better than failing silently
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
596c775af6
Add controller spec to cover voucher in split checkout
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74e0b0f6b5
Add voucher adjustment loading to CheckoutCallbacks
...
This is needed so the voucher is loaded properly when the "checkout"
partials are render via cable_car.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74a8730f04
Highlight voucher on order summary step
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
856386fcb0
SplitCheckoutController refactor add_voucher
...
Now all redirection/render_error happen in #update, it makes it
easier to understand.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
e487ed0532
Add link to remove voucher when a voucher has been applied
...
Improve styling to match the design
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
b6213b25e9
add acts_as_paranoid to voucher
...
This is so the relation
`belongs_to :originator, -> { with_deleted }, polymorphic: true`
setup in Spree::Adjustement works as expected.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
a9d9b33f7d
First take at adding a voucher to an order
...
Use voucher.create_adjustment to add an adjustment to the order
Currently doesn't take into account tax part
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
3ec58d8791
Add #vouchers, return an array of voucher adjustments
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
9b680e1a92
Add CalculatedAdjustments to Voucher
...
Vouchers are only flat rate of 10 for now, so we add a FlatRate
calculator in a before_validation callback
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
f7ee01b9f8
Add voucher input on checkout payment's step
...
Voucher input is displayed only if the distributor has any voucher
2023-05-15 13:42:37 +10:00
Maikel
4f7059d0c7
Merge pull request #10838 from filipefurtad0/fix_negative_adjustment_error
...
Adds minus sign to validation criteria
2023-05-15 11:07:45 +10:00
Gaetan Craig-Riou
d715b6b3bb
Spec fix LocalisedNumber validation to allow negative number
...
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329
LocalisedNumber validation was tightened, but that means negative number
were not valid anymore.
This commit has been cherry-picked after this fix has already been
applied. Now we just change the order of characters in the regex because
humans are used to reading the minus at the beginning of the number. But
this change doesn't change the logic at all.
2023-05-15 10:55:59 +10:00
Maikel
5045e26792
Merge pull request #10834 from mkllnk/variant-spec
...
Improve readability and performance of variant spec
2023-05-15 09:48:06 +10:00
filipefurtad0
0442f2da7e
Fixes spec warning
...
An example was being ignored due to legacy syntax - WARNING: ignoring the provided expectation message argument since it is not a string or a proc.
2023-05-14 23:02:44 +01:00
filipefurtad0
e7ab839fb3
Adds minus sign as validation criteria
...
Removes pending from passing examples
2023-05-14 23:02:44 +01:00
filipefurtad0
596b318778
Adds spec on negative adjustment
...
with different localization settings
Using shared examples and setting failing
ones as pending
2023-05-14 23:02:00 +01:00
Filipe
3c7337b53a
Merge pull request #10836 from jibees/10835-on-small-width-screen-the-cart-element-is-missplaced
...
Fix bad indentation (and hierarchy) of DOM elements causing bad rendering on small width screens
2023-05-12 11:24:49 +01:00
Jean-Baptiste Bellet
60edb4363e
Fix bad indentation (and hierarchy)
...
`%section` must be siblings each others
introduced by https://github.com/openfoodfoundation/openfoodnetwork/pull/10772
2023-05-12 09:30:37 +02:00
Maikel Linke
6596225a99
Fix typo in VCR cassette name
2023-05-12 14:48:00 +10:00
Maikel Linke
87c4c5373b
Spec more variant naming with realistic data
2023-05-12 14:10:54 +10:00
Maikel Linke
f70607259a
Spec Variant#product_and_full_name with real data
...
Mocking skips a lot of code execution which we want to test as well.
2023-05-12 13:34:34 +10:00
Maikel Linke
ce180caad9
Test with in-memory data when possible
...
This should speed up specs but I observed only one second less run time.
2023-05-12 13:21:58 +10:00
Maikel Linke
01be934caf
Reduce spec run time by not creating unused subject
...
The `variant` instance isn't used in all specs and doesn't need to be
created every time. This reduced run time from 1min5sec to 43sec on my
machine.
2023-05-12 13:21:58 +10:00
Maikel Linke
54c6559b97
Move Spree::Variant spec out of Spree module
...
I also discovered that some specs were just in the Spee module and not
within the `describe Variant` block. I moved them inside the block.
2023-05-12 13:21:19 +10:00
Maikel
93c0a06403
Merge pull request #10829 from filipefurtad0/flaky_order_spec_error
...
Splits assertions to allow JS table populate
2023-05-12 11:49:06 +10:00
Maikel Linke
636b365304
Tell Rubocop and devs about bulk insert
2023-05-12 10:30:47 +10:00
Jean-Baptiste Bellet
51d6fb81dd
Fwd to request the restock_items input value when adjusting items qty
2023-05-11 22:58:44 +02:00
Jean-Baptiste Bellet
f679d8733e
Pass the restock_items params to each methods and request call
...
+ update spec to test whether the restock item checkbox is checked or not.
2023-05-11 22:58:44 +02:00
Matt-Yorkley
b139087c5f
Clone ExchangeVariant objects in bulk
...
An ExchangeVariant is a simple representation of a join table between Exchange and Variant. Previously this code was triggering an additional INSERT query for every variant added to the newly cloned exchange. Some exchanges have ~3000 variants! The code now creates them in bulk in a single INSERT statement. When cloning large order cycles this can improve performance by ~1000% or so.
2023-05-11 20:51:20 +01:00
Filipe
1bdb668cd3
Merge pull request #10769 from Matt-Yorkley/visible-line-items-query
...
Improve `Permissions::Order#visible_line_items` querying
2023-05-11 15:36:32 +01:00
filipefurtad0
d035d4bb87
Update all locales with the latest Transifex translations
2023-05-11 15:25:39 +01:00
Mohamed ABDELLANI
6771d2e7be
test enterprise fees creation with tax category inheritance flag
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
a22fe9f948
fix existing invalid enterprise fees
2023-05-11 12:46:17 +01:00
Maikel Linke
25b7f1749c
Simplify error when tax rate can't be inherited
...
I changed the text to focus on the resolution: the user needs to choose
a tax category or a different calculator.
I associated the error to the model to prevent the attribute name from
being included in the error message. Alternatively, we could have
changed the name of the attribute to match the UI. But this error
affects the combination of two attributes, none of them is invalid on
its own.
I'm using Rails' default lazy lookup for error messages which results in
shorter code and a standard structure.
I also added a simple spec.
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
89eb3a1967
fix existing tests
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
7eca32e84f
prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-11 12:46:17 +01:00
filipefurtad0
f5eb72c804
Adds sleep(1)
2023-05-11 11:29:24 +01:00
Konrad
2836751698
Merge pull request #10805 from jibees/10717-bo-orders-changing-customer-does-not-update-customer_id
...
Admin, Edit customer details for an order: when changing to another customer, update `customer_id` as well
2023-05-10 19:08:57 +02:00
Filipe
bf7a559a32
Merge pull request #10772 from Matt-Yorkley/view-caching
...
Locale-aware Fragment Caching
2023-05-10 11:18:08 +01:00
filipefurtad0
82f307ae61
Adds test case for logging out
2023-05-10 10:41:43 +01:00
Matt-Yorkley
d90653c682
Merge pull request #10793 from jibees/fix-webpack-configuration-use-the-default-one
...
Use the default webpack configuration for dev env
2023-05-10 10:09:28 +01:00
jibees
ca5300284c
Merge pull request #10820 from Matt-Yorkley/js-dependencies
...
Remove indirect JS dependencies
2023-05-10 09:57:05 +02:00
Matt-Yorkley
406cb572ea
Remove indirect JS dependencies
2023-05-10 09:27:00 +02:00
jibees
ca90b5cee2
Merge pull request #10810 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.122.0
...
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
2023-05-10 09:23:44 +02:00
jibees
760860a06d
Merge pull request #10811 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.11.0
...
Bump knapsack_pro from 3.10.0 to 3.11.0
2023-05-10 09:21:46 +02:00
jibees
189207f751
Merge pull request #10822 from openfoodfoundation/dependabot/bundler/debug-1.8.0
...
Bump debug from 1.7.2 to 1.8.0
2023-05-10 09:20:34 +02:00
Matt-Yorkley
1bd9182cea
Update menu cache blocks
2023-05-09 16:46:09 +01:00
David Cook
04a5c7452e
Remove admin_style_v2 description
...
Partially reverts 9a1b1498bf
2023-05-09 21:26:47 +10:00
David Cook
e29df5ea8f
Remove unused secondary class
...
This partially reverts 97c3aaebb2 because it referred to the new feature toggle which has been removed.
2023-05-09 21:26:47 +10:00
David Cook
3ec659d82b
Revert pull #10025
...
[WIP 🚧 ] Admin, behind feature toggle admin_style_v2: adjust some colors
This reverts commits 60f0a58508ce77666fa96c73d76dc0620f23daaf~1..09bcc772ff089f911a56bb
2023-05-09 21:26:47 +10:00
David Cook
be70cd7893
Revert pull #10054
...
[WIP 🚧 ] Admin/Orders, behind feature toggle admin_style_v2: adjust colors
This reverts commits 5cab0f7f3d495daaeb97fd786208a24355b630fe..4ef5609b0eb08fe7e48803de166ae3e979103c1b
2023-05-09 21:26:47 +10:00
David Cook
0ff540e1e3
Revert pull #10080
...
[WIP 🚧 ] Admin - Order edition, behind feature toggle admin_style_v2: adjust colors
This reverts commits faf106b2824f248812f523c10b688bd9b254dc14..74b618230ff736ac7929246e2c83ed95067a4dd0
2023-05-09 21:25:29 +10:00
David Cook
c21ff075de
Revert pull #10131
...
[WIP 🚧 ] /admin/order_cycles behind feature toggle admin_style_v2
This reverts commits ccfc632149f062fca546784c7c2f14708d91a08e~1..e403a2c174def34cfa115eab038c86923482bfbf
2023-05-09 21:24:25 +10:00
dependabot[bot]
969d0b6687
Bump debug from 1.7.2 to 1.8.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-09 10:03:20 +00:00
Maikel Linke
3c6f55732d
Add dummy product type to DFC export
2023-05-09 17:01:00 +10:00
Maikel Linke
b2e8af0cd1
Add stock to DFC Offer as well
2023-05-09 16:51:26 +10:00
Maikel Linke
c81230d334
Add old DFC API name for prototype compatibility
2023-05-09 16:51:26 +10:00
Maikel Linke
54137067dd
Export variant's display_name if present
...
The `#name` method is simply delegated to a variant's product.
2023-05-09 16:51:26 +10:00
Maikel Linke
0c5ab783ca
Update DFC API route to reflect Connector version
2023-05-09 16:51:26 +10:00
Maikel Linke
80edc44ef5
Replace SuppliedProductSerializer with DFC Connector
...
And remove the BaseSerializer because this was the last serializer.
2023-05-09 16:51:26 +10:00
Maikel Linke
0b808a4b1e
Add product quantity to DFC export
2023-05-09 16:51:26 +10:00
Maikel Linke
1e23cf1c92
Replace EnterpriseSerializer with DFC Connector
...
And move same test coverage to a new builder spec.
2023-05-09 16:51:26 +10:00
Maikel Linke
683ad0f5b9
Replace PersonSerializer with DFC Connector
...
And the address serializer was just an empty placeholder.
2023-05-09 16:51:26 +10:00
Maikel Linke
c60d622818
List catalog items with DFC Connector
2023-05-09 16:51:25 +10:00
Maikel Linke
7f8ce08d4e
Include DFC Offer in the export with valid id
2023-05-09 16:51:25 +10:00
Maikel Linke
78cf3b5a1d
Serialize DFC catalog item with DFC Connector
...
This is work in progress. The DFC Connector uses a more recent DFC
version and other endpoints still use the old serializers. We need to
update those endpoints as well and update the version number in the API
URL.
2023-05-09 16:51:25 +10:00
Maikel Linke
5187201796
Add DFC vocabularies
...
- Add a script for downloading updated files.
- Add a service for easier loading of vocab files.
2023-05-09 16:51:25 +10:00
Maikel Linke
352c350840
Add gem datafoodconsortium-connector
...
We hope that replacing our own JSON generation with this gem will reduce
maintenance. Same for parsing DFC input.
2023-05-09 16:51:25 +10:00
David Cook
8fe20ecfbe
Merge pull request #10794 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.8
...
Bump @babel/core from 7.21.5 to 7.21.8
2023-05-09 16:37:42 +10:00
Maikel
83141ec05c
Merge pull request #10818 from mkllnk/schema-order
...
Fixup order of statements in db schema
2023-05-09 14:21:03 +10:00
Matt-Yorkley
4b707b9310
Extract locale file digest logic to a separate class and add tests
2023-05-08 14:09:00 +01:00
Matt-Yorkley
1c277e5547
Cache some html fragments
2023-05-08 14:07:50 +01:00
Matt-Yorkley
be48a6c295
Implement cache_with_locale helper for fragment caching with locales
2023-05-08 14:07:50 +01:00
Matt-Yorkley
11f45dc2f8
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
Konrad
4303cabe56
Merge pull request #10792 from mkllnk/feature-deletion
...
Remove unknown (deleted) feature toggles at boot
2023-05-08 14:49:42 +02:00
Maikel Linke
f1f3ecc4f7
Fixup order of statements in db schema
...
It looks like the resolution of a merge conflict introduced the wrong
ordering of schema statements. Rails wants to sort tables alphabetically
and running `./bin/rails db:migrate` on a fresh database altered the
schema.rb file. This should be fixed here.
Rails also omits the default setting of `precision: 6` since Rails 7.
The vouchers feature was developed during the upgrade to Rails 7.
2023-05-08 14:37:33 +10:00
Maikel
ad033e8d44
Merge pull request #10767 from Matt-Yorkley/remove-session-cookie-upgrader
...
Remove SessionCookieUpgrader from middleware
2023-05-08 12:50:42 +10:00
Gaetan Craig-Riou
f25a3650bd
Merge pull request #10802 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.1
...
Bump ddtrace from 1.11.0 to 1.11.1
2023-05-08 11:45:07 +10:00
Konrad
e4d8dd9f87
Merge pull request #10780 from dacook/enable-prettier-css
...
Enable prettier for Admin SCSS
2023-05-06 18:24:58 +02:00
Matt-Yorkley
1995a44848
Improve eager-loading on admin products page adn resolve issue with serializer
...
For some reason eager-loaded data isn't passed to nested serializers when using associations. Defining the association as a method and passing in some optional paramaters resolves the issue.
This reduces queries run by the controller action by around 75%, as well as the response times.
2023-05-06 17:15:27 +01:00
dependabot[bot]
b29d38f3fb
Bump knapsack_pro from 3.10.0 to 3.11.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.10.0 to 3.11.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.10.0...v3.11.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 10:01:08 +00:00
dependabot[bot]
1c52fe1648
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.121.0 to 1.122.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 09:59:02 +00:00
David Cook
a170b93cc1
Simplify further
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-05 15:34:23 +10:00
Maikel Linke
2a943ecafb
Spec setting up all feature toggle names
2023-05-05 11:09:10 +10:00
Jean-Baptiste Bellet
3a1579104f
Submit customer_id as params when updating customer details on order
2023-05-04 16:40:58 +02:00
jibees
ec4c7b79bf
Merge pull request #10803 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.2
...
Bump rspec-rails from 6.0.1 to 6.0.2
2023-05-04 13:55:37 +02:00
dependabot[bot]
9f12295a89
Bump rspec-rails from 6.0.1 to 6.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:54 +00:00
dependabot[bot]
46fd6b1a3a
Bump ddtrace from 1.11.0 to 1.11.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:25 +00:00
Jean-Baptiste Bellet
8a5608435c
Update all locales with the latest Transifex translations
2023-05-03 17:30:48 +02:00
Konrad
d02d0b8847
Merge pull request #10763 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.0
...
Bump ddtrace from 1.10.1 to 1.11.0
2023-05-03 17:27:13 +02:00
Konrad
4b6ef7796e
Merge pull request #10762 from mkllnk/report-encoding
...
Preserve encoding of stored reports
2023-05-03 17:08:44 +02:00
Konrad
b60a6fbd05
Merge pull request #10329 from thejwuscript/9861-improve-input-validation
...
Improve input validation on new and edit Payment Method pages
2023-05-03 16:11:21 +02:00
jibees
2e267091f6
Merge pull request #10795 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.10.0
...
Bump knapsack_pro from 3.9.0 to 3.10.0
2023-05-03 14:31:11 +02:00
dependabot[bot]
eb3fe1b7a5
Bump knapsack_pro from 3.9.0 to 3.10.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.9.0...v3.10.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 10:06:11 +00:00
dependabot[bot]
61f34a23a7
Bump @babel/core from 7.21.5 to 7.21.8
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.5 to 7.21.8.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.8/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 09:57:57 +00:00
Jean-Baptiste Bellet
2d7356f2bb
Use the default webpack configuration for dev env
...
We used to override the output filename but this was a misunderstanding of an error (due to webpacke(r) incompatibles versions)
https://medium.com/@web_developer/hash-vs-chunkhash-vs-contenthash-e94d38a32208
https://github.com/webpack/webpack.js.org/issues/2096
Context: https://github.com/openfoodfoundation/openfoodnetwork/pull/10631#pullrequestreview-1410083331
2023-05-03 10:10:17 +02:00
jibees
62c2d9a290
Merge pull request #10782 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.0
...
Bump sidekiq from 7.0.9 to 7.1.0
2023-05-03 09:56:07 +02:00
jibees
a329aab007
Merge pull request #10774 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.5
...
Bump @babel/core and @babel/preset-env from 7.21.4 to 7.21.5
2023-05-03 09:26:10 +02:00
Maikel Linke
e24198fe85
Bump @babel/preset-env from 7.21.4 to 7.21.5
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-env )
I did this manually:
```
$ yarn upgrade "@babel/preset-env"
yarn upgrade v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > stimulus_reflex@3.5.0-rc2" has unmet peer dependency "@hotwired/stimulus@>= 3.0".
[4/4] Rebuilding all packages...
success Saved lockfile.
success Saved 35 new dependencies.
info Direct dependencies
└─ @babel/preset-env@7.21 .5
info All dependencies
├─ @babel/code-frame@7.21 .4
├─ @babel/helper-builder-binary-assignment-operator-visitor@7.21 .5
├─ @babel/helper-function-name@7.21 .0
├─ @babel/helper-module-imports@7.21 .4
├─ @babel/helper-replace-supers@7.21 .5
├─ @babel/helper-string-parser@7.21 .5
├─ @babel/helper-wrap-function@7.20 .5
├─ @babel/highlight@7.18 .6
├─ @babel/parser@7.21 .5
├─ @babel/plugin-transform-arrow-functions@7.21 .5
├─ @babel/plugin-transform-computed-properties@7.21 .5
├─ @babel/plugin-transform-for-of@7.21 .5
├─ @babel/plugin-transform-modules-commonjs@7.21 .5
├─ @babel/plugin-transform-regenerator@7.21 .5
├─ @babel/plugin-transform-unicode-escapes@7.21 .5
├─ @babel/preset-env@7.21 .5
├─ @babel/regjsgen@0.8.0
├─ @babel/template@7.20 .7
├─ @babel/traverse@7.21 .5
├─ @jridgewell/resolve-uri@3.1.0
├─ color-convert@1.9.3
├─ escape-string-regexp@1.0.5
├─ is-core-module@2.12 .0
├─ js-tokens@4.0.0
├─ jsesc@2.5.2
├─ ms@2.1.2
├─ regenerate-unicode-properties@10.1.0
├─ regenerator-runtime@0.13.11
├─ regexpu-core@5.3.2
├─ regjsparser@0.9.1
├─ to-fast-properties@2.0.0
├─ unicode-canonical-property-names-ecmascript@2.0.0
├─ unicode-match-property-ecmascript@2.0.0
├─ unicode-match-property-value-ecmascript@2.1.0
└─ unicode-property-aliases-ecmascript@2.1.0
Done in 16.54s.
```
2023-05-03 15:33:57 +10:00
Maikel Linke
b30e962cdd
Remove unknown (deleted) feature toggles at boot
2023-05-03 15:20:26 +10:00
Maikel Linke
5f1f717974
Spec FeatureToggle.setup!
2023-05-03 15:02:08 +10:00
Maikel Linke
b6f2fe0e92
Avoid defining modules in specs
...
We avoid some indent and show how code outside of the module works.
2023-05-03 14:58:59 +10:00
dependabot[bot]
a9bf7a2498
Bump @babel/core from 7.21.4 to 7.21.5
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 12:18:41 +10:00
David Cook
e11518938f
Prettify admin components scss
...
Largely whitespace, but some other updates too, including uppercase colour codes and standardising numbers.
Best viewed with whitespace ignored.
2023-05-03 12:10:58 +10:00
David Cook
c4dc5e0718
Prettier: use double quotes by default
...
Unfortunately Prettier won't let you do one rule at a time (https://stackoverflow.com/q/63813336/421243 ), so I'll break it into file chunks.
2023-05-03 12:10:58 +10:00
David Cook
c67d61a376
Don't ignore admin scss for prettying
...
...and watch the changes flow in!
2023-05-03 12:09:22 +10:00
David Cook
0b4556e72b
Allow line length up to 100char
...
Same as we have for Ruby code: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/.rubocop_styleguide.yml#L78-L80
This will avoid unnecessary reformatting.
2023-05-03 12:09:22 +10:00
David Cook
8c7f92d42e
Explicitly ignore each css folder
...
With the goal to progressively un-ignore them.
2023-05-03 12:09:22 +10:00
Konrad
21a0017352
Merge pull request #10756 from jibees/10743-admin-add-unregistered-users-modal-some-html-is-rendered-as-plain-text-instead-of-being
...
Admin, Add unregistered user: Fix a reflex-morph issue that lead to a HTML escaping error
2023-05-02 19:28:48 +02:00
Konrad
d115c4ce2c
Merge pull request #10733 from jibees/9782-shops-list-overlapping-and-overflowing-texts-on-mobile2
...
Shops list: fix some overlapping and overflowing texts on mobile
2023-05-02 12:15:19 +02:00
dependabot[bot]
b05d46c3e3
Bump sidekiq from 7.0.9 to 7.1.0
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.9 to 7.1.0.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.9...v7.1.0 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-02 09:57:28 +00:00
jibees
aae0fc59fb
Merge pull request #10768 from Matt-Yorkley/query-logs
...
Improve query logging in development
2023-05-02 11:44:19 +02:00
Gaetan Craig-Riou
d1f7cc1b2a
Merge pull request #10764 from Matt-Yorkley/remove-data-hooks
...
Remove `data-hook` attributes
2023-05-02 16:35:46 +10:00
Gaetan Craig-Riou
964481f188
Merge pull request #10765 from Matt-Yorkley/update-webpack-packages
...
Update webpack packages
2023-05-02 15:19:37 +10:00
Maikel
9bca22ae3b
Merge pull request #10775 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.2
...
Bump mini_portile2 from 2.8.1 to 2.8.2
2023-05-02 11:54:37 +10:00
dependabot[bot]
064c843c90
Bump mini_portile2 from 2.8.1 to 2.8.2
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.1...v2.8.2 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-01 10:02:13 +00:00
Maikel
482d438ec9
Merge pull request #10766 from filipefurtad0/remove_asertion_on_js_element_loading_orders
...
Removes assertions on transient JS element - "Loading orders"
2023-05-01 13:36:44 +10:00
Maikel Linke
9f0a66659a
Delete now unused SessionCookieUpgrader
2023-05-01 13:35:52 +10:00
Konrad
1176ea2a5f
Merge pull request #9941 from basilawwad/conditionally-send-cancellation-email
...
Conditionally send cancellation email when cancelling order.
2023-04-28 21:54:42 +02:00
Matt-Yorkley
dfc651ed2c
Convert Permissions::Order#visible_line_items to a relation with or query
...
This change looks innocuous but the result of converting this into a nice relation instead of two queries stuck together with the pipe operator (|) can make a huge difference when chaining this into subqueries. The result set is ultimately the same, but the queries can be built without first returning all the ids and then sticking those ids in an array.
2023-04-28 19:13:22 +01:00
Matt-Yorkley
f42a9e3a66
Add query_count gem in development
...
A very simple gem that counts the total number of queries triggered by each request and displays a little number in the log. Nice.
2023-04-28 15:02:02 +01:00
Matt-Yorkley
8d9a8d8db5
Enable verbose query logs in development
...
This is a new feature in Rails 7. Whenever a query is triggered it not only show you the query (as before), but also tells you (directly in the logs) exactly which line of code was responsible for triggering the query. It's unbelievably useful for debugging and performance work.
2023-04-28 14:35:16 +01:00
Matt-Yorkley
84df1bfeab
Remove SessionCookieUpgrader from middleware
...
This was a transitional bit of code to allow us to rename our session cookies without killing active sessions and logging users out. It's done it's job, the transition is finished, and it isn't doing anything useful now. It can be removed from the middleware stack.
2023-04-28 14:01:15 +01:00
Matt-Yorkley
b9431cd121
Remove data-hook attributes
2023-04-28 13:03:13 +01:00
filipefurtad0
74d18fb6ff
Removes assertions on transient JS element
2023-04-28 12:48:59 +01:00
Matt-Yorkley
5e26e49764
Update webpack packages
...
`webpack-cli` is a dependency of `@rails/webpacker` but needs to be at version 3.x, we can just cut it from the explicit dependecy list and the correct version will be installed.
`webpack-dev-server` version 3.x corresponds (unhelpfully) to `webpacker` 4.x, and needs to be left that way. Dependabot tries to change it occasionally, but it should not be updated to 4.x
2023-04-28 12:48:21 +01:00
dependabot[bot]
c9dada4215
Bump ddtrace from 1.10.1 to 1.11.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.1...v1.11.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-28 10:00:28 +00:00
Maikel Linke
630169f8bb
Preserve encoding of stored reports
...
Active Storage reads stored strings as ASCII and that can clash with
Rails' default UTF-8 encoding when special characters are present.
2023-04-28 16:38:06 +10:00
Gaetan Craig-Riou
152af5e105
Merge pull request #10751 from mkllnk/mail-config
...
Remove unused feature to intercept emails
2023-04-28 16:28:41 +10:00
David Cook
918425fd93
Remove customised error message
...
We're now handling these values on the frontend, so can keep this simple.
fixes up:
Add numericality validation for *
Add translation for Active Record error message
2023-04-28 14:02:12 +10:00
David Cook
a46eef291c
Remove localized number logic from calculators
...
The browser is now responsible for dealing with the decimal separator, for all numeric preferences (as input[type=number]; see Spree::Admin::BaseHelper::preference_field_tag). Calculators are the only place that numeric preferences are used.
It will enforce that only one comma or dot (depending on user's locale) is entered, thus avoiding any ambiguity, and mis-interpretation (eg 100,001 could be interpreted as more than 100 thousand or 100 with a decimal place).
2023-04-28 13:54:16 +10:00
David Cook
d2fbb0bde2
Update translations
...
js: admin: orders: order_state: confirmation
2023-04-27 14:49:28 +10:00
David Cook
c42dfdde10
Merge pull request #10748 from openfoodfoundation/dependabot/bundler/view_component-3.0.0
...
Bump view_component from 2.82.0 to 3.0.0
2023-04-27 14:46:09 +10:00
Jean-Baptiste Bellet
959dcb82e1
Morph the form itself instead of morphing a parent DOM element
...
This seems to avoid HTML parsing error
2023-04-26 17:41:28 +02:00
jibees
51d5817665
Merge pull request #10755 from openfoodfoundation/dependabot/bundler/i18n-1.13.0
...
Bump i18n from 1.12.0 to 1.13.0
2023-04-26 15:45:59 +02:00
jibees
a8384b3155
Merge pull request #10754 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.7
...
Bump @floating-ui/dom from 1.2.6 to 1.2.7
2023-04-26 15:44:04 +02:00
Konrad
394bfd00d8
Merge pull request #10586 from jibees/10563-allow-custom-url-on-logo-click
...
White Label: can link an URL to the white label logo
2023-04-26 13:52:10 +02:00
dependabot[bot]
bda1a527d3
Bump i18n from 1.12.0 to 1.13.0
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.12.0...v1.13.0 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:48 +00:00
dependabot[bot]
77bd832dd6
Bump @floating-ui/dom from 1.2.6 to 1.2.7
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.7/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:09 +00:00
Jean-Baptiste Bellet
b1de28eeea
When there is a white_label_logo_link pref. use it!
...
+ update spec as well
+ use an an helper to get the main logo link for a shopfront
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
679fcc0114
When removing the logo, also delete white_label_logo_link preference
...
since it has no sense without the logo
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
35778ecf1d
If enterprise has a white_label_logo attached, then can edit its link
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
70a6e9f44b
Add a white_label_logo_link attribute to enterprise model
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
30ba29382a
Avoid name collision by renaming some classes with a prefix flex-
...
This classes should only be used with `.flex`
2023-04-26 09:52:24 +02:00
Jean-Baptiste Bellet
9584205a8e
Use .flex class in utilities.scss file
...
No need to have multiple definition as already included
2023-04-26 09:51:28 +02:00
Jean-Baptiste Bellet
3644dbc0fd
Small fix of a prettier formatter error
2023-04-26 09:51:17 +02:00
Jean-Baptiste Bellet
05a7276c9c
Create an utilities.scss file that contains some utility classes
...
Finally Tailwind is coming? ;)
2023-04-26 09:47:23 +02:00
David Cook
1fc60d498a
Merge pull request #10746 from openfoodfoundation/dependabot/bundler/rswag-specs-2.9.0
...
Bump rswag-specs from 2.8.0 to 2.9.0
2023-04-26 14:08:30 +10:00
Maikel Linke
dae8703b02
Remove unused feature to intercept emails
...
This option came from Spree and we never used it. The config input field
is disabled in the admin interface and I checked our managed databases.
I don't think that we will want this feature in the future either.
Staging sends unmodified emails which is more realistic and we haven't
had a use case to intercept those emails. There's still the BCC option
if we need additional access.
2023-04-26 13:50:31 +10:00
Maikel
3078c599f9
Merge pull request #10747 from openfoodfoundation/dependabot/bundler/rswag-ui-2.9.0
...
Bump rswag-ui from 2.8.0 to 2.9.0
2023-04-26 12:04:09 +10:00
dependabot[bot]
5d91ac217d
Bump rswag-specs from 2.8.0 to 2.9.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 02:03:53 +00:00
Maikel
f2edb6d404
Merge pull request #10745 from openfoodfoundation/dependabot/bundler/rswag-api-2.9.0
...
Bump rswag-api from 2.8.0 to 2.9.0
2023-04-26 12:02:38 +10:00
David Cook
7cd1b5d5db
Update link
...
The old project was closed in favour of a new one.
2023-04-26 09:44:58 +10:00
dependabot[bot]
ad82f66173
Bump rswag-api from 2.8.0 to 2.9.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 10:10:17 +00:00
dependabot[bot]
62bfa9e04c
Bump view_component from 2.82.0 to 3.0.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.82.0 to 3.0.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.82.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:51 +00:00
dependabot[bot]
28c9d72342
Bump rswag-ui from 2.8.0 to 2.9.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:22 +00:00
jibees
7317d6ca34
Merge pull request #10742 from filipefurtad0/fix_broken_build
...
Considers recent changes on login test helpers
2023-04-25 11:36:56 +02:00
filipefurtad0
edb8da4b4d
Considers recent changes on login test helpers
...
PR #10696 introduced changes on the login helpers which were not considered, when merging a recent PR; This broke the build
2023-04-24 18:35:10 +01:00
Konrad
00d5bd9165
Merge pull request #10684 from MadisonBowron/master
...
Fix admin product variants form to close issues #10579 & Wishlist: 430
2023-04-24 18:18:01 +02:00
Jean-Baptiste Bellet
1730c9eb60
Fix one warning: Modal window with text has been opened, ...
...
```
Modal window with text `An invoice for this order will be sent to the customer. Are you sure you want to continue?` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
```
2023-04-24 15:18:35 +02:00
Jean-Baptiste Bellet
5b9815f4a3
Test that restock has been called or not, depending on checkbox checked
2023-04-24 15:03:14 +02:00
jibees
445eb45ad7
Merge pull request #10737 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.8
...
Bump prettier from 2.8.7 to 2.8.8
2023-04-24 14:43:20 +02:00
jibees
8770471ada
Merge pull request #10738 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.4.2
...
Bump karma from 6.4.1 to 6.4.2
2023-04-24 14:43:07 +02:00
dependabot[bot]
6d45940ca4
Bump karma from 6.4.1 to 6.4.2
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.4.1 to 6.4.2.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.4.1...v6.4.2 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:22 +00:00
dependabot[bot]
69383ac621
Bump prettier from 2.8.7 to 2.8.8
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.7 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.7...2.8.8 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:05 +00:00
Maikel
945cb84127
Merge pull request #10683 from filipefurtad0/update-the-build-env-to-ubuntu-2204
...
Updates build environment to Ubuntu 22.04
2023-04-24 15:27:05 +10:00
Maikel
343a2db1bf
Merge pull request #10722 from mkllnk/rubocop-autocorrect-script
...
Add script for bulk autocorrect with Rubocop
2023-04-24 10:58:43 +10:00
Maikel Linke
de8f5e13b3
Explain gotcha in case it breaks one day
2023-04-24 09:39:21 +10:00
Konrad
75b5d1fd6f
Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector
...
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)
2023-04-22 16:04:15 +02:00
Konrad
0c1606e50c
Merge pull request #10728 from jibees/10718-missing-translation-confirmation-order-state
...
Admin, `/orders`: adds translation for order in `confirmation` state
2023-04-22 11:56:23 +02:00
jibees
fa05554f15
Merge pull request #10734 from openfoodfoundation/dependabot/npm_and_yarn/karma-chrome-launcher-3.2.0
...
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
2023-04-21 14:13:19 +02:00
Jean-Baptiste Bellet
2cc509de15
Do not check Metrics/BlockLength for shared_examples_for block
...
They can contains a lot of `it` tests
2023-04-21 11:59:24 +02:00
dependabot[bot]
41afad73e4
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
...
Bumps [karma-chrome-launcher](https://github.com/karma-runner/karma-chrome-launcher ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/karma-runner/karma-chrome-launcher/releases )
- [Changelog](https://github.com/karma-runner/karma-chrome-launcher/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-chrome-launcher/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: karma-chrome-launcher
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-21 09:57:29 +00:00
Jean-Baptiste Bellet
b17b25516f
Use a UTF-8 character
2023-04-21 10:37:20 +02:00
Jean-Baptiste Bellet
8444fca19a
Fix syntax error
2023-04-21 10:36:47 +02:00
Jean-Baptiste Bellet
18d90114fe
Be more responsive: use flex, ellipsis, less columns
2023-04-21 10:36:21 +02:00
Gaetan Craig-Riou
2f17a02974
Merge pull request #10726 from mkllnk/spec-email-helper
...
Remove useless email test setup
2023-04-21 15:43:19 +10:00
Gaetan Craig-Riou
135bc7e2f8
Removing env variable $runs_on
...
Seting "env" under "jobs" doesn't work it gets picked up as a job. I moved
runs_on to the top level env. but I couldn't fine a way to get it to work.
I tried all syntax I could think of: $runs_on, ${{ runs_on }} env.runs_on,
${{ env.runs_on }} and their capitalized versions.
2023-04-21 15:14:20 +10:00
Gaetan Craig-Riou
3810d79cad
Merge pull request #10695 from macanudo527/rename_inversables
...
Rename Inversable Method Names
2023-04-21 11:38:58 +10:00
Maikel Linke
4960402643
Update translations
2023-04-21 09:45:45 +10:00
jibees
3557c10cd6
Merge pull request #10730 from openfoodfoundation/dependabot/bundler/stringex-2.8.6
...
Bump stringex from 2.8.5 to 2.8.6
2023-04-20 15:50:19 +02:00
jibees
45dd421f1f
Merge pull request #10729 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.121.0
...
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
2023-04-20 15:48:46 +02:00
Jean-Baptiste Bellet
81606e841a
Canceling an order: clicking on cancel btn or cancel action in dropdown
2023-04-20 14:38:59 +02:00
basilawwad
e633670e01
Use a shared_examples for the order cancellation tests
2023-04-20 14:38:59 +02:00
Filipe
11653c9430
Merge pull request #10575 from jibees/10559-allow-upload-of-custom-header-logo
...
White Label: can upload a custom header logo
2023-04-20 13:27:52 +01:00
dependabot[bot]
d068094044
Bump stringex from 2.8.5 to 2.8.6
...
Bumps [stringex](https://github.com/rsl/stringex ) from 2.8.5 to 2.8.6.
- [Release notes](https://github.com/rsl/stringex/releases )
- [Commits](https://github.com/rsl/stringex/compare/v2.8.5...v2.8.6 )
---
updated-dependencies:
- dependency-name: stringex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:06:33 +00:00
dependabot[bot]
b892bf726e
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.1 to 1.121.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:00:05 +00:00
basilawwad
fa373518fb
applied modal function
...
Update variant_autocomplete.js.erb
Applied modal function
refactored function
fix indentation and removed old function
2023-04-20 11:46:02 +02:00
Jean-Baptiste Bellet
76357789a3
Avoid line break between state wording and its little colored circle
2023-04-20 09:09:29 +02:00
Jean-Baptiste Bellet
5dd7246b85
Rename confirm to use confirmation
...
`confirmation` is the state used by order model
2023-04-20 09:07:01 +02:00
Jean-Baptiste Bellet
ba45dd84dd
Solves rubocop linter errors
2023-04-20 08:46:19 +02:00
Jean-Baptiste Bellet
92e2a83e0e
Use Rails7 command for image variant syntax
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
f42f513f8c
Display white_label_logo image when hide_ofn_navigation is set to true
...
for both desktop and mobile view
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
54342254b6
Do not show white label logo is hide_ofn_navigation is not checked
...
They are both strongly linked
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
470761da86
Add a simple CheckboxDisplay controller that show/hide content
...
depending on the checkbox state (checked or not)
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
6fdf9fa038
Add/Remove white label logo in enterprise preferences panel
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
bbec01a9cb
Create a concern for reflexes that handle Enterprise update
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
e3001cc8c4
Add white_label_logo to enterprise model as attachment
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
ad0d0e393e
ConfirmModalComponent is ready to receive data-reflex
...
And not only `data-action`
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
2690ff5eb5
Add comment, which links these two files together
2023-04-20 08:45:03 +02:00
jibees
2594382488
Merge pull request #10723 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.9
...
Bump sidekiq from 7.0.8 to 7.0.9
2023-04-20 08:31:46 +02:00
Maikel Linke
9b3cfe80ff
Remove useless clearing of test emails
...
They are cleared by the test environment anyway.
2023-04-20 13:35:40 +10:00
Maikel Linke
04d33adaf2
Remove duplicate declaration of test mail delivery
...
Our test environment sets the mail delivery method already. We don't
have to do it in individual spec files.
2023-04-20 13:28:59 +10:00
Maikel Linke
915bd19d7b
Remove useless email test setup
...
We always deliver emails these days.
2023-04-20 12:18:04 +10:00
Maikel Linke
9998025687
Remove useless test header setup for emails
...
Once upon a time we needed a helper to set the `from` header of emails.
This is now set in the ApplicationMailer and not necessary any more.
2023-04-20 12:15:34 +10:00
Maikel
89cb3b7c14
Merge pull request #10707 from mkllnk/mailer-previews
...
Fix ShipmentMailer preview autoload path
2023-04-20 11:30:25 +10:00
Maikel Linke
1955a6719c
Fix commit message formatting
...
Git needs a blank line between the summary and the longer description.
And `echo` doesn't interpret `\n` by default.
2023-04-20 11:19:32 +10:00
Maikel Linke
f71e5ee43c
Limit number of rubocop autocorrect runs
...
The typical use case is to create a small number of commits for a pull
request to ease the review. And you can still run it for all cops with
`-n 999` or `-n -0`.
2023-04-20 11:19:32 +10:00
Maikel Linke
0ac2358f2c
Regenerate Rubocop's TODO file without timestamp
2023-04-20 10:34:35 +10:00
Filipe
3e0b358370
Merge pull request #10461 from vviekk/9978
...
Updating price, on_hand, on_demand validations for product import
2023-04-19 16:09:49 +01:00
Filipe
f206b7ed9e
Merge pull request #10661 from mkllnk/report-download
...
[Hidden] Provide download link for reports generated in the background
2023-04-19 11:53:14 +01:00
dependabot[bot]
946b69242c
Bump sidekiq from 7.0.8 to 7.0.9
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.8 to 7.0.9.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.8...v7.0.9 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-19 09:58:13 +00:00
Filipe
a409d3b97e
Merge pull request #10201 from saunmanoj888/fix-invalid-image-upload
...
Fix corrupt and invalid image upload issue
2023-04-19 10:45:04 +01:00
Jean-Baptiste Bellet
a27b64a66b
Add confirmation state translation
2023-04-19 11:32:51 +02:00
Jean-Baptiste Bellet
0f54d3950d
Save can have a context: simplify then
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
Maikel
1f661c1e69
Merge pull request #10716 from jibees/10048-stimulusreflex-caching-warning
...
Adds caching by default in development environment to avoid StimulusReflex warning
2023-04-19 16:22:37 +10:00
saunmanoj888
97f51d24b8
Validate image on creating product from products/new
2023-04-19 16:11:46 +10:00
saunmanoj888
c3d274c84f
Fix corrupt and invalid image upload issue
2023-04-19 16:11:46 +10:00
Maikel Linke
213fb42a05
Safely autocorrect Gemspec/RequireMFA
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/catalog.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:9:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:21:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 8 offenses detected, 8 offenses corrected
2023-04-19 15:35:30 +10:00
Maikel Linke
bde46fa1e9
Safely autocorrect Gemspec/DeprecatedAttributeAssignment
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
spec.test_files = Dir['spec/**/*']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["spec/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 4 offenses detected, 4 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
dc560d3793
Safely autocorrect Bundler/OrderedGems
...
Inspecting 1404 files
.C..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Gemfile:18:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem angular-rails-templates should appear before rexml.
gem 'angular-rails-templates', '>= 0.3.0'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:19:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem awesome_nested_set should appear before rexml.
gem 'awesome_nested_set'
^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:20:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem ransack should appear before rexml.
gem 'ransack', '~> 2.6.0'
^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:21:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem responders should appear before rexml.
gem 'responders'
^^^^^^^^^^^^^^^^
Gemfile:74:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-rails_csrf_protection should appear before openid_connect.
gem 'omniauth-rails_csrf_protection'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:154:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before factory_bot_rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:155:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before fuubar.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:156:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before json_spec.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:157:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before knapsack_pro.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:158:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before letter_opener.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:159:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:160:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-retry.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:161:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rswag-specs.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:162:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before shoulda-matchers.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:163:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before timecop.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:179:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem foreman should appear before rails-erd.
gem 'foreman'
^^^^^^^^^^^^^
Gemfile:180:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem listen should appear before rails-erd.
gem 'listen'
^^^^^^^^^^^^
Gemfile:181:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry should appear before rails-erd.
gem 'pry', '~> 0.13.0'
^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 18 offenses detected, 18 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
52f134fc9e
Regenerate Rubocop's TODO file
2023-04-19 15:35:29 +10:00
Maikel Linke
c08e264afa
Add script for bulk autocorrect with Rubocop
...
We also had an old script which wasn't used and needed manual steps.
2023-04-19 15:35:29 +10:00
Maikel
0b03152f3b
Merge pull request #10697 from mkllnk/rubocop-config-update
...
Update Rubocop config and replace deprecated TimeWithZone#to_s with argument
2023-04-19 11:23:34 +10:00
Maikel
6f492d868c
Merge pull request #10688 from mkllnk/application-mailer
...
Apply Rails standard to base mailer class
2023-04-19 10:29:16 +10:00
jibees
dab2a4af75
Merge pull request #10693 from jibees/10658-move-all-managed-instances-to-fully-enabled-split_checkout-toggle
...
Activate `split_checkout` feature by default
2023-04-18 17:33:48 +02:00
Jean-Baptiste Bellet
f7935bde34
Enable caching dy default, to avoid StimulusReflex warning
...
```
Heads up! 🔥
👉 StimulusReflex requires caching to be enabled. Caching allows the session to be modified during ActionCable requests.
To enable caching in development, run:
rails dev:cache
```
Documentation: https://docs.stimulusreflex.com/hello-world/setup.html#manual-configuration
2023-04-18 16:02:02 +02:00
Jean-Baptiste Bellet
61850f7e92
Remove duplicate line
...
Probably due to a bad merge conflict resolution
Line is already on line `#25`
2023-04-18 16:01:04 +02:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
jibees
7df456c1e3
Merge pull request #10715 from openfoodfoundation/dependabot/bundler/puma-6.2.2
...
Bump puma from 6.2.1 to 6.2.2
2023-04-18 15:04:17 +02:00
Konrad
2fa86492d1
Merge pull request #10653 from openfoodfoundation/10645-pagination-in-bom-not-aggregating-results-when-clicking-a-productvariant
...
BOM: When selecting a specific variant, trigger a new search that avoid pagination issues
2023-04-18 14:49:14 +02:00
Jean-Baptiste Bellet
722c660697
Do not show any links to other steps when no distribution set
...
distribution means tuple: distributor + order cycle
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ba1d985932
update the set_distribution form on the same path
...
and use the same method `OrdersController#set_distribution`
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
0f28d318ac
Fix rubocop error and prefer using a return clause
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
6172d1f2e5
Extract method on_update that will be used elsewhere
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
05a040b4c3
No need to ensure if the distribution is set on new action
...
This will be handled by validation on set_distribution action
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
dependabot[bot]
85860692ae
Bump puma from 6.2.1 to 6.2.2
...
Bumps [puma](https://github.com/puma/puma ) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.2.1...v6.2.2 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 09:59:41 +00:00
jibees
8ad4d2cc2e
Merge pull request #10708 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.3
...
Bump webpack-dev-server from 4.13.2 to 4.13.3
2023-04-18 10:15:01 +02:00
David Cook
c967eca9c4
Merge pull request #10713 from openfoodfoundation/dependabot/npm_and_yarn/ansi-regex-4.1.1
...
Bump ansi-regex from 4.1.0 to 4.1.1 (security patch)
2023-04-18 15:34:24 +10:00
David Cook
7fff82eec3
Merge pull request #10710 from openfoodfoundation/dependabot/bundler/rubocop-1.50.2
...
Bump rubocop from 1.50.1 to 1.50.2
2023-04-18 15:24:40 +10:00
dependabot[bot]
c30ed0f7c8
Bump rubocop from 1.50.1 to 1.50.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.1 to 1.50.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.1...v1.50.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 04:51:38 +00:00
David Cook
cde420716b
Merge pull request #10709 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.19.1
...
Bump rubocop-rails from 2.19.0 to 2.19.1
2023-04-18 14:50:11 +10:00
David Cook
ee37c5d4a3
Merge pull request #10699 from dacook/sass-deprecations
...
Sass deprecations
2023-04-18 11:48:56 +10:00
dependabot[bot]
e9d236f761
Bump ansi-regex from 4.1.0 to 4.1.1
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-18 00:05:00 +00:00
Gaetan Craig-Riou
8b78c28feb
Merge pull request #10702 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.0
...
Bump cable_ready from 5.0.0-rc2 to 5.0.0
2023-04-18 10:02:59 +10:00
David Cook
43e51cb592
Simplify login spec helpers, avoid long lines
...
Follow on from 5c6d9a092e
2023-04-18 10:01:23 +10:00
David Cook
6570891349
Fix linter issues
...
Although I don't think the size was an issue here, small hashes can easily fit on one line.
2023-04-18 09:50:08 +10:00
David Cook
0f3e2ae572
Use browser validation for calculator values
...
They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic.
They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.
2023-04-18 09:50:08 +10:00
David Cook
f0110d20a2
Move config to base helper
...
This config is relevant for all specs, including system specs.
2023-04-18 09:50:08 +10:00
David Cook
353acfd6ae
Validate associated calculator with built in error handling
...
Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.
2023-04-18 09:39:39 +10:00
David Cook
e43a018dc7
[wip] Copy each calculator error
...
But we still have the duplicate problem.
Wait a minute, it copies them in the same format that I am copying them. So.. I don't need to copy them at all!
Now I see that we just needed the right format in the translation file.
2023-04-18 09:39:39 +10:00
David Cook
f6fac018ea
[wip] Use a custom message format for associated errors
...
This is much simpler. Multiple messages get combined onto one line though, which is not perfect.
And.. it still seems to duplicate the errors. Weird, it's fine on my frontend though.
2023-04-18 09:39:39 +10:00
David Cook
ce1bd12760
Consolidate specs
...
It takes time to set up this test case. Given that there's no interactions in the expectations, we should save time to generate it only once.
2023-04-18 09:39:39 +10:00
David Cook
364ccc2146
Add comment
2023-04-18 09:39:39 +10:00
James Wu
2a7cb50fa9
Keep and display submitted data on new payment method page
2023-04-18 09:39:39 +10:00
James Wu
29ddc68d20
Fix duplicate validation error message
2023-04-18 09:39:39 +10:00
James Wu
d40f3414ea
fixup! Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
f5e2edb028
fixup! Modify Calculator validation error messages [wip]
...
DC: the error message has now become "Amount Invalid input".
2023-04-18 09:39:39 +10:00
James Wu
7af26e6579
Add errors for invalid input with number localization enabled
2023-04-18 09:39:39 +10:00
James Wu
824d4adf21
Rename spec file
2023-04-18 09:39:39 +10:00
James Wu
00cc8da2fc
Fix rubocop class length error
2023-04-18 09:39:39 +10:00
James Wu
ae5f2cc19d
Fix error saving data on new Calculator
2023-04-18 09:39:39 +10:00
James Wu
41ce4fbc16
Fix cache issue with invalid form data
2023-04-18 09:39:39 +10:00
James Wu
48753df5f0
Improve input validation and error notification
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
3dfaf882a3
Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
7b51f45b4d
Fix spelling in test description
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
James Wu
ee30d3d139
Fix PaymentMethodFactory creating extra Calculator
2023-04-18 09:39:39 +10:00
Filipe
871b2f8816
Merge pull request #10696 from mkllnk/login-as-admin
...
Simplify login test helpers
2023-04-17 12:14:06 +01:00
dependabot[bot]
214bdc6fbe
Bump rubocop-rails from 2.19.0 to 2.19.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.19.0 to 2.19.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.19.0...v2.19.1 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-17 10:01:45 +00:00
dependabot[bot]
d2fce053a7
Bump webpack-dev-server from 4.13.2 to 4.13.3
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.13.2 to 4.13.3.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.13.2...v4.13.3 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-17 09:57:50 +00:00
Jean-Baptiste Bellet
11a7aa9f96
When clicking on "Clear Filters" button, to not reset variant selection
...
+ add some specs to cover that particular case
2023-04-17 11:08:17 +02:00
Jean-Baptiste Bellet
c0203e7091
Refactor by putting two specs into a shared_example
...
"It's a Surprise Tool That Will Help Us Later"
2023-04-17 11:06:23 +02:00
Maikel
44cc5cc665
Merge pull request #10677 from mkllnk/spec-helpers
...
Simplify spec helpers
2023-04-17 16:16:29 +10:00
Maikel Linke
6c8e383ab8
Fix ShipmentMailer preview autoload path
...
The Zeitwerk autoloader requires class names and file names to match. In
this case, the class had a Spree namespace without being in a spree
folder. The preview couldn't be displayed. Now it can be displayed.
2023-04-17 15:18:22 +10:00
Maikel Linke
5c6d9a092e
Simplify login spec helpers, avoid long lines
...
The `login_as_admin_and_visit` helper was used a lot but isn't really
shorter than:
login_as_admin
visit path_visit
Calling those methods separately reduces line length. It also removes
the potential impression that it may be more efficient to use the
helper. Now we have less indirection if one of the calls fails and see
the failing spec line straight away.
2023-04-17 11:08:32 +10:00
Maikel Linke
8d500a2c27
Remove superflouous login test helper
...
It was often used with a `visit` statement after which resulted in
unnecessary page loads. There was only one case where a `visit` was
expected but it wasn't needed either.
2023-04-17 10:56:51 +10:00
Maikel Linke
425674c4e5
Remove unused return value of admin login helper
...
Well, there was one use of the return helper. But I don't think that
it's a very intuitive method.
2023-04-17 10:56:51 +10:00
Konrad
e91e827f29
Merge pull request #10664 from abdellani/fix-remove-duplicated-cusomter-from-mailing-list-report
...
Fix Repeated customer entries on Mailing List Report
2023-04-16 21:17:33 +02:00
Konrad
8f201c830a
Merge pull request #10665 from abdellani/fix-remove-duplicated-cusomter-from-addresses-list-report
...
Fix Repeated customer entries on Addresses List Report
2023-04-16 20:40:56 +02:00
Konrad
1b536d9265
Merge pull request #10601 from abdellani/fix-v1-customers-endpoint-should-only-return-managed-enterprise-customers
...
fix: v1/customers endpoint should load customers of managed enterprises only
2023-04-16 16:22:02 +02:00
Mohamed ABDELLANI
1b8a9244a6
test when user is a non-persisted object
2023-04-15 06:16:40 +01:00
dependabot[bot]
a40e883d17
Bump cable_ready from 5.0.0-rc2 to 5.0.0
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-rc2 to 5.0.0.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits/v5.0.0 )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-14 09:57:54 +00:00
Jean-Baptiste Bellet
6bf21d2abd
SASS loader: Do not print warnings from dependencies
2023-04-14 11:09:39 +02:00
David Cook
29b9777a96
Replace deprecated sass division operator
...
https://sass-lang.com/documentation/breaking-changes/slash-div
> Sass currently treats / as a division operation in some contexts and a separator in others. This makes it difficult for Sass users to tell what any given / will mean, and makes it hard to work with new CSS features that use / as a separator.
There's a handy migrator:
npm install -g sass-migrator
sass-migrator division **/*.scss
And it cleverly avoids the need for the ugly division method in most cases.
2023-04-14 17:59:01 +10:00
David Cook
283dd84ad6
Add expected whitespace
...
The migrator refused to proceed until I fixed this.
2023-04-14 17:56:24 +10:00
Maikel Linke
03828c5608
Style Rails/ToSWithArgument
2023-04-14 16:34:51 +10:00
Maikel Linke
dad4061ff9
Style Rails/ToFormattedS
2023-04-14 16:32:39 +10:00
Maikel Linke
b19df0dfbf
Enable new Rubocop cops
...
This detects an additional 639 offenses which I added to the todo file.
From now on, when Dependabot bumps rubocop the build may fail due to new
cops. But that's a great opportunity to utilise those new cops and fix
violations straight away. Otherwise we'll never get to them and lose out
on useful autocorrection, for example for updating deprecated syntax.
2023-04-14 16:28:20 +10:00
Maikel Linke
efb2ae6843
Style Rails/Pick - rubocop passes completely
2023-04-14 16:22:46 +10:00
Maikel Linke
407fca17cb
Style Rails/IndexWith
2023-04-14 16:19:21 +10:00
Maikel Linke
33409725a5
Run rubocop-rails with current Rails version 7.0
...
This adds three new issues I will address in the next commits.
```
Offenses:
app/json_schemas/json_api_schema.rb:40:7: C: [Correctable] Rails/IndexWith: Prefer index_with over to_h { ... }.
relationships.to_h { |name| [name, relationship_schema(name)] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/base.rb:18:11: C: [Correctable] Rails/IndexWith: Prefer index_with over map { ... }.to_h.
data_attributes.map { |attr| [attr, I18n.t("header.#{attr}", scope: i18n_scope)] }.to_h
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/sales_tax/sales_tax_totals_by_order.rb:140:14: C: [Correctable] Rails/Pick: Prefer pick('sum(amount)') over pluck('sum(amount)').first.
.pluck('sum(amount)').first || 0
^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 3 offenses detected, 3 offenses autocorrectable
```
2023-04-14 16:15:13 +10:00
Maikel Linke
c70a694111
Style line length - rubocop passes completely
2023-04-14 16:12:14 +10:00
Maikel Linke
9c88c77066
Style empty lines
2023-04-14 16:05:50 +10:00
Maikel Linke
42585bb074
Remove redundant cop disable directive
2023-04-14 16:04:57 +10:00
MadisonBowron
697f2795d4
Remove arbitrary comments
2023-04-14 01:25:14 -04:00
Maikel
b0211d0930
Merge pull request #10686 from filipefurtad0/truncates_product_description
...
Sets too long line truncation spec as pending
2023-04-14 15:11:31 +10:00
Maikel
0675422509
Merge pull request #10678 from dacook/show-commit-in-ci
...
Show commit in CI
2023-04-14 14:43:44 +10:00
Maikel
5ff1b0d358
Merge pull request #10676 from filipefurtad0/fix_spec_ts_and_cs
...
Adds pending test for default ToS
2023-04-14 14:00:32 +10:00
Maikel Linke
43cbac7d17
Simplify report filename generation
2023-04-14 11:29:36 +10:00
Maikel Linke
98e4f867b4
Provide download link for generated reports
2023-04-14 11:29:35 +10:00
Maikel Linke
ebb15781d5
Store report's filename within the blob
...
For future downloads outside the ReportsController.
2023-04-14 11:29:35 +10:00
Maikel Linke
028c4f4281
Simplify ReportJob by extracting model for result
...
This makes the code heaps simpler.
2023-04-14 11:29:35 +10:00
Maikel Linke
ef7dfa3b4f
Store reports with Active Storage
...
This will enable us to offer download links and clean them up
automatically.
2023-04-14 11:29:35 +10:00
Maikel Linke
71f9415d21
Use ApplicationJob as it's a Rails default
2023-04-14 11:29:35 +10:00
Maikel Linke
12848acf21
Fix typo
2023-04-14 11:29:35 +10:00
Maikel Linke
4f751c2711
Leverage test helpers for enqueued jobs
...
The production code calls `perform_later` and it's better to do the same
in specs. Handy test helper allow us to control the execution.
Credit to https://github.com/cyrillefr .
2023-04-14 11:29:35 +10:00
jibees
920e2564a4
Merge pull request #10692 from openfoodfoundation/dependabot/bundler/rubocop-1.50.1
...
Bump rubocop from 1.50.0 to 1.50.1
2023-04-13 13:45:28 +02:00
Jean-Baptiste Bellet
6b4e150e2a
Active split_checkout feature by default
2023-04-13 13:21:23 +02:00
dependabot[bot]
2d43e32688
Bump rubocop from 1.50.0 to 1.50.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.0...v1.50.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 09:57:38 +00:00
David Cook
a6cd393c57
Update all locales with the latest Transifex translations
2023-04-13 16:45:38 +10:00
Filipe
b1060bf1c9
Merge pull request #10640 from openfoodfoundation/dependabot/bundler/stripe-8.5.0
...
Bump stripe from 8.3.0 to 8.5.0
2023-04-12 19:27:18 +01:00
Filipe
1bf5fbaf3a
Merge pull request #10449 from macanudo527/fix_ER
...
Update OCs after ER Permissions are Revoked
2023-04-12 18:59:20 +01:00
Konrad
2ace3afd67
Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting
...
Sort orders by last name
2023-04-12 16:36:45 +02:00
Konrad
0bfceb877d
Merge pull request #10666 from jibees/9723-admin-missing-translation-in-payment-report
...
Admin, Payment reports: add missing translation for payment state
2023-04-12 15:47:23 +02:00
Filipe
c1d28b2e8f
Merge pull request #10119 from binarygit/donot-hide-producers-name-in-products
...
Display producer's name in products inspite of hide all refs option
2023-04-12 13:07:52 +01:00
Jean-Baptiste Bellet
2841b42296
Specify truncate parameter as we don't always truncate description
...
Only when too long.
2023-04-12 10:34:30 +02:00
jibees
98e44e7a40
Merge pull request #10687 from openfoodfoundation/dependabot/bundler/nokogiri-1.14.3
...
Bump nokogiri from 1.14.2 to 1.14.3
2023-04-12 10:25:56 +02:00
jibees
51c6c19f80
Merge pull request #10669 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.8
...
Bump sidekiq from 7.0.7 to 7.0.8
2023-04-12 10:24:59 +02:00
filipefurtad0
26947a64c0
Adds test to check pagination upon line-item selection
2023-04-12 09:58:01 +02:00
Jean-Baptiste Bellet
df5c21048a
Clear on bulk submenu should reset some filters + refresh data as well
2023-04-12 09:58:01 +02:00
Jean-Baptiste Bellet
8a124fb6be
BOM: once variant has been selected, refresh data with a new search
...
- Remove variant_filter
- instantiate a new search to avoid pagination issues
2023-04-12 09:58:00 +02:00
filipefurtad0
7d51979c06
Updates build environment to Ubuntu 22.04
...
Creates environment variable to set OS version
2023-04-12 09:19:14 +02:00
Maikel Linke
ced49e0217
Apply Rails standard to base mailer class
...
It has the advantage that `rails generate mailer` works out of the box
and we comply with rubocop rules.
2023-04-12 16:39:20 +10:00
dependabot[bot]
75b7a1864b
Bump nokogiri from 1.14.2 to 1.14.3
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.14.2 to 1.14.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.14.2...v1.14.3 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-12 06:24:59 +00:00
Maikel Linke
281d0eb417
Simplify mailers with Rails default "from" setting
2023-04-12 16:15:51 +10:00
Maikel Linke
496f5199c9
Use DatabaseCleaner recommendation of late cleaning
...
https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example
2023-04-12 14:24:07 +10:00
Maikel Linke
f13c0e1dca
Bring all Rspec config for database cleaning together
2023-04-12 14:23:09 +10:00
David Cook
f801d4a4cb
Move single-used variables to their own example
...
They were created three times each, but only used once.
2023-04-12 11:05:11 +10:00
David Cook
d94da8df1e
Update comment
2023-04-12 11:04:00 +10:00
MadisonBowron
8c6e0a841c
Fix rubocop extra blank line error
2023-04-11 15:35:37 -04:00
filipefurtad0
70d9cfa08e
Sets too long line truncation spec as pending
2023-04-11 19:46:11 +01:00
jibees
193ae7936e
Merge pull request #10681 from openfoodfoundation/dependabot/bundler/rubocop-1.50.0
...
Bump rubocop from 1.49.0 to 1.50.0
2023-04-11 20:40:55 +02:00
Filipe
0971e8d9b5
Merge pull request #10644 from mkllnk/report-timeout-message
...
[Hidden] Display a friendly message when a background report times out
2023-04-11 19:40:42 +01:00
Jean-Baptiste Bellet
e78b44b9ca
Do not shows <a /> if producers is hidden
...
Different style as it does not open any modal
2023-04-11 14:27:57 +02:00
binarygit
c5779eff81
Do not open modal for producer's who are 'hidden'
2023-04-11 14:27:57 +02:00
Jean-Baptiste Bellet
b616c14f63
Don't hide producer's name in products despite hide all refs opt selected
2023-04-11 14:26:47 +02:00
Mohamed ABDELLANI
03cb14c926
define manage_by scope on customer model
2023-04-11 12:18:15 +01:00
Mohamed ABDELLANI
da78e06a39
load customers of managed enterprises only
2023-04-11 12:10:07 +01:00
dependabot[bot]
f4c351febf
Bump rubocop from 1.49.0 to 1.50.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.49.0 to 1.50.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.49.0...v1.50.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-11 10:05:30 +00:00
Maikel Linke
30184ac6aa
Background reports time out earlier than nginx
...
This allows us to display a friendly message before nginx displays its
default error.
2023-04-11 16:44:13 +10:00
David Cook
a123d45eca
Fix spec
...
It's worth noting that this page hasn't been updated by this PR.
I honestly don't know why it broke, but don't care anymore. It seems the extra `login_as_admin_and_visit` was causing a race condition on one spec. It's not necessary so I've removed this context.
Best viewed with whitespace ignored.
2023-04-11 16:38:49 +10:00
James Wu
a75f16e23c
Implement full_name_for_sorting
2023-04-11 15:25:20 +10:00
James Wu
546e90b286
Sort orders by last names
2023-04-11 15:25:20 +10:00
David Cook
bf9f47a000
Show commit in CI
...
actions/checkout@v3 actually creates a merge commit into master, to ensure you're testing the latest as close to master as possible.
That's all well and good, but quite confusing when you see errors in CI that aren't present in the actual PR branch. Hopefully this will be a clue when such confusions arise.
2023-04-11 15:22:19 +10:00
David Cook
3da6e6b5ed
Link to CI page
2023-04-11 15:22:12 +10:00
Maikel Linke
111705f6f2
Clarify DatabaseCleaner use only for concurrency
...
Otherwise we use transactions.
2023-04-11 14:07:27 +10:00
Maikel Linke
68d5327b12
Load all spec helpers in one place
...
These helpers are loaded depending on the spec type. We don't need to
separate them into different files.
2023-04-11 12:56:28 +10:00
Maikel Linke
688285c374
Remove loading of unused spec helpers
...
We have only one feature spec left and it's loading the
system_helper instead of the spec_helper. These lines were dead code.
2023-04-11 12:14:02 +10:00
MadisonBowron
9d0a69cceb
Fix admin product variants form to close issues #10579 & #430
2023-04-10 18:53:01 -04:00
Konrad
15058299d8
Merge pull request #10641 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.21.4
...
Bump @babel/preset-env from 7.18.2 to 7.21.4
2023-04-10 20:00:06 +02:00
filipefurtad0
4e92f33b1c
DRYes spec; adds pending test for default ToS
2023-04-10 12:08:35 +01:00
Jean-Baptiste Bellet
c7cb982c9a
Update browser list
...
```
npx update-browserslist-db@latest
```
2023-04-10 11:20:19 +02:00
Jean-Baptiste Bellet
34e9112c0a
Fix dependencies warning: adds core and `plugin-transform-runtime
2023-04-10 11:20:19 +02:00
dependabot[bot]
28eb11bda5
Bump @babel/preset-env from 7.20.2 to 7.21.4
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.20.2 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-10 11:20:19 +02:00
jibees
d8e82d9c88
Merge pull request #10668 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.120.1
...
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
2023-04-10 11:12:45 +02:00
Mohamed ABDELLANI
061fc321b4
group records before rending the report
2023-04-07 18:44:19 +01:00
Mohamed ABDELLANI
5201e54f82
group orders before rendering the report
2023-04-07 18:16:12 +01:00
jibees
5192a08082
Merge pull request #10673 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.19.0
...
Bump rubocop-rails from 2.18.0 to 2.19.0
2023-04-07 14:33:31 +02:00
jibees
94d3f136e2
Merge pull request #10672 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.6
...
Bump @floating-ui/dom from 1.2.5 to 1.2.6
2023-04-07 14:32:45 +02:00
dependabot[bot]
db3a923ea7
Bump rubocop-rails from 2.18.0 to 2.19.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.18.0...v2.19.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:59:34 +00:00
dependabot[bot]
619eb43c57
Bump @floating-ui/dom from 1.2.5 to 1.2.6
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.6/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:58:01 +00:00
filipefurtad0
680b6a7122
Update all locales with the latest Transifex translations
2023-04-07 10:17:13 +01:00
Filipe
d9e9add78b
Merge pull request #10527 from vviekk/10456
...
Fixing 'unsaved' alert behaviour for order cycle edit forms
2023-04-06 17:05:49 +01:00
Filipe
8893824b06
Merge pull request #10635 from jibees/fix-content-security-policy-for-local-images
...
Fix content security policy: authorize `ENV["SITE_URL"]` as trusted domain for images
2023-04-06 11:25:05 +01:00
dependabot[bot]
5c221621d3
Bump sidekiq from 7.0.7 to 7.0.8
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.7 to 7.0.8.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.7...v7.0.8 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:58:23 +00:00
dependabot[bot]
60d7ed5036
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.0 to 1.120.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:57:53 +00:00
Filipe
e71a747925
Merge pull request #10667 from jibees/10662-flaky-specqueriescustomers_with_balance_specrb26
...
Flaky: Avoid flaky spec by sorting array before comparing on `spec/queries/customers_with_balance_spec.rb:26`
2023-04-06 10:47:32 +01:00
Jean-Baptiste Bellet
eedd421055
Avoid flaky spec by sorting array before comparing
2023-04-06 10:41:42 +02:00
Jean-Baptiste Bellet
e74328f1d7
Add i18n for payment state key
...
+ update spec
2023-04-06 10:28:44 +02:00
Jean-Baptiste Bellet
bb502c2e65
Authorize localhost:3000 as trusted domain for images
2023-04-06 10:10:44 +02:00
Jean-Baptiste Bellet
6abd652251
Factorize into inherited method from Base: payment_state(order)
2023-04-06 09:50:50 +02:00
Filipe
2f6b730ed4
Merge pull request #10614 from cillian/business-address-country-state-placeholders
...
Add placeholders to business address country and state select fields
2023-04-05 19:55:07 +01:00
dependabot[bot]
3821eede51
Bump stripe from 8.3.0 to 8.5.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.3.0 to 8.5.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.3.0...v8.5.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-05 16:38:33 +00:00
Filipe
2ff464321c
Merge pull request #10619 from openfoodfoundation/dependabot/npm_and_yarn/stimulus_reflex-3.5.0-rc1
...
Bump stimulus_reflex and cable_ready from 3.5.0-preX to 3.5.0-rc2
2023-04-05 17:37:15 +01:00
Filipe
fc8d9252d5
Merge pull request #10605 from abdellani/fix-impossible-to-reach-OCs-older-than-6-months
...
Fix load order cycles by date ranges
2023-04-05 17:33:51 +01:00
Rachel Arnould
3e5becf70a
Merge pull request #10538 from jibees/10537-shopfront-product-description-is-too-long
...
Shopfront: Force product description to be on one line
2023-04-05 17:42:18 +02:00
Maikel
ef841b161f
Merge pull request #10660 from MadisonBowron/master
...
Fix bug #10596 , missing translation for editing shipping category
2023-04-05 16:12:20 +10:00
Maikel
c11dd2c1fb
Merge pull request #10642 from macanudo527/fix_rubocop_errors
...
Fix Rubocop Layout/LineLength
2023-04-05 16:11:08 +10:00
Maikel Linke
8bbc545e39
Cover untranslated text by spec
2023-04-05 15:03:42 +10:00
Maikel
fc08913152
Merge pull request #10648 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.120.0
...
Bump aws-sdk-s3 from 1.119.2 to 1.120.0
2023-04-05 14:44:22 +10:00
Maikel
19ae3651fa
Merge pull request #10643 from dacook/update-node-docker
...
Update node for docker
2023-04-05 14:43:24 +10:00
Jean-Baptiste Bellet
66307c9277
cable_ready changed its Content-Type ; update the mrujs one as well
...
Thanks @marcoroth for the great debugging session! 🙏
2023-04-05 14:19:34 +10:00
Jean-Baptiste Bellet
65084422cb
cable_ready is already imported in app/webpacker/controllers/index.js
2023-04-05 14:19:34 +10:00
Jean-Baptiste Bellet
6f8ab56d2e
Replace deprecated call render operations:
...
```
DEPRECATED: CableReady's `render operations:` call has been renamed to `render cable_ready:`. Please update your render call.
```
2023-04-05 14:19:34 +10:00
dependabot[bot]
ab6cdd4c78
Bump stimulus_reflex from 3.5.0-pre9 to 3.5.0-rc2
...
Updating JS and Ruby libraries. This commit was started by Dependabot
for 3.5.0-rc1. Then we updated to rc2.
Old Dependabot message about rc1:
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex ) from 3.5.0-pre9 to 3.5.0-rc1.
- [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases )
- [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits )
---
updated-dependencies:
- dependency-name: stimulus_reflex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Bump cable_ready from 5.0.0-pre10 to 5.0.0-rc1
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-pre10 to 5.0.0-rc1.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-05 14:19:16 +10:00
David Cook
865d81d28f
Apply suggestions from code review
2023-04-05 14:05:26 +10:00
Maikel Linke
020af0c0e4
Explain report timeout better to user
2023-04-05 09:59:02 +10:00
emiliecm
5abda22831
Fix bug #10596 , missing translation for editing shipping category
2023-04-04 19:48:16 -04:00
Cillian O'Ruanaidh
89dac47aa6
Add placeholders to business address country and state select fields
2023-04-04 19:22:22 +01:00
jibees
e18d973047
Merge pull request #10655 from filipefurtad0/fix_flaky_oc_form_spec
...
Sorts plucked shipping/payment methods
2023-04-04 15:34:39 +02:00
jibees
afeeaf0a9b
Merge pull request #10657 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.23
...
Bump combine_pdf from 1.0.22 to 1.0.23
2023-04-04 14:31:06 +02:00
jibees
3010717ece
Merge pull request #10656 from openfoodfoundation/dependabot/bundler/devise-4.9.2
...
Bump devise from 4.9.1 to 4.9.2
2023-04-04 14:30:11 +02:00
dependabot[bot]
0c48dbe0d5
Bump combine_pdf from 1.0.22 to 1.0.23
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.22 to 1.0.23.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.22...v1.0.23 )
---
updated-dependencies:
- dependency-name: combine_pdf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-04 10:04:31 +00:00
dependabot[bot]
f7b215b7ac
Bump devise from 4.9.1 to 4.9.2
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.1 to 4.9.2.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.1...v4.9.2 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-04 09:58:37 +00:00
filipefurtad0
29520542db
Sorts plucked shipping/payment methods
2023-04-04 09:30:36 +01:00
Maikel Linke
00a3976905
Display a friendly message when a report times out
...
Once we get a download link for a report, we can display this message
sooner. But for now we just use the existing request timeout.
2023-04-04 11:08:20 +10:00
Maikel Linke
3bd8e430f9
Use Rack::Timeout for more realistic tests
...
The closer the test environment is to the production environment the
more realistic the tests will be, and the more code we test.
We are now able to test the app behaviour on timeouts which I want to do
for reports. We can also catch incompatibilities with the rack-timeout
gem during testing.
2023-04-04 11:08:20 +10:00
Neal Chambers
940f806e5f
Fix Rubocop Layout/LineLength
2023-04-04 09:44:15 +09:00
Neal Chambers
77733169fc
Update OCs after ERs Permissions are Revoked
2023-04-04 09:37:13 +09:00
David Cook
c34ced2f65
Merge pull request #10639 from openfoodfoundation/dependabot/bundler/puma-6.2.1
...
Bump puma from 6.1.1 to 6.2.1
2023-04-04 10:08:57 +10:00
Filipe
2051d811cf
Merge pull request #10567 from jibees/10557-allow-hide-of-ofn-main-navigation
...
White Label: Allow enterprise to hide ofn main navigation on `/shop`, `/cart`, `/checkout`, `/orders` pages
2023-04-03 20:29:37 +01:00
jibees
0335cf2441
Merge pull request #10647 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.2
...
Bump webpack-dev-server from 4.13.1 to 4.13.2
2023-04-03 16:47:02 +02:00
jibees
d3ddc8a221
Merge pull request #10650 from openfoodfoundation/dependabot/bundler/devise-4.9.1
...
Bump devise from 4.9.0 to 4.9.1
2023-04-03 16:44:46 +02:00
jibees
25e00d5210
Merge pull request #10649 from openfoodfoundation/dependabot/bundler/capybara-3.39.0
...
Bump capybara from 3.38.0 to 3.39.0
2023-04-03 16:42:53 +02:00
jibees
2a556ab329
Merge pull request #10651 from openfoodfoundation/dependabot/bundler/rubocop-1.49.0
...
Bump rubocop from 1.48.1 to 1.49.0
2023-04-03 16:42:08 +02:00
dependabot[bot]
80a94011b8
Bump rubocop from 1.48.1 to 1.49.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.48.1 to 1.49.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.48.1...v1.49.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:06:36 +00:00
dependabot[bot]
d4f2704213
Bump devise from 4.9.0 to 4.9.1
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.0 to 4.9.1.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.0...v4.9.1 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:02:14 +00:00
dependabot[bot]
91bf3c67cd
Bump capybara from 3.38.0 to 3.39.0
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.38.0 to 3.39.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.38.0...3.39.0 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:01:25 +00:00
dependabot[bot]
307a9effb0
Bump aws-sdk-s3 from 1.119.2 to 1.120.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.2 to 1.120.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 10:00:03 +00:00
dependabot[bot]
56e8f7b0c6
Bump webpack-dev-server from 4.13.1 to 4.13.2
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.13.1 to 4.13.2.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.13.1...v4.13.2 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-03 09:58:14 +00:00
Maikel
de58aa1187
Merge pull request #10529 from mkllnk/setup
...
Update setup script with newest template and merge with old script
2023-04-03 15:44:29 +10:00
Maikel Linke
da0ef8531b
Install our used bundler version
2023-04-03 14:37:31 +10:00
Maikel Linke
08f2254a0e
Leverage bin/setup within script/setup
...
And remove duplicate output. `bin/setup` is the Rails default for
updating your environment after code updates and `script/setup` is our
convenience script for the initial setup and starting with sample data.
2023-04-03 14:37:31 +10:00
Maikel Linke
477524039f
Update bundler version when necessary
...
Not just when it's missing.
2023-04-03 14:37:31 +10:00
Maikel Linke
e5e5bf8c17
Install ruby automatically if rbenv is available
...
People may use other ways to provide the right Ruby version but if they
use rbenv then we can use it automatically.
2023-04-03 14:37:30 +10:00
Maikel Linke
4999e231bc
Avoid permission warning when running sudo as root
...
The command is switching to an unprivileged user which can't access
/root and therefore there was a warning when executing. Adding `--login`
to the sudo command switches to that user properly and avoids the
warning.
2023-04-03 14:36:07 +10:00
Maikel Linke
6b857a5683
Make code examples easier to copy without $ sign
...
The $ sign used to indicate shell commands. But with markdown it's
obvious that we are entering commands.
Github has a quick copy button for all code examples which used to copy
the $ sign as well. Removing it allows to copy and paste easier with
that button.
2023-04-03 14:35:52 +10:00
Maikel Linke
f12ee186ee
Speed up setup script when restarting rails
2023-04-03 14:33:39 +10:00
Maikel Linke
93ef95f58e
Update JS dependencies with setup script
2023-04-03 14:33:39 +10:00
Maikel Linke
49dd1dd1fa
Update setup script with newest template
...
I used the script from a new Rails 7 project.
2023-04-03 14:32:22 +10:00
David Cook
04d2f3f50d
Install nodenv to use correct Node version
...
Copying what we do for rbenv, using the same plugins that we use in https://github.com/openfoodfoundation/ofn-install/blob/master/roles/node/tasks/main.yml
2023-04-03 14:11:28 +10:00
David Cook
f43bdec0f4
Update to latest node v17
...
Really this should install nodenv though..
2023-04-03 11:41:54 +10:00
Jean-Baptiste Bellet
b79bd8ef05
Removes empty <p> tags from product description
2023-03-31 11:37:30 +02:00
Jean-Baptiste Bellet
4dfc56954c
Force .product-description to be one line
...
and make it as a `div`
2023-03-31 10:41:27 +02:00
dependabot[bot]
8c08827d35
Bump puma from 6.1.1 to 6.2.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.1.1 to 6.2.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.1.1...v6.2.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-31 08:13:31 +00:00
Maikel Linke
a56081ad5b
Update translations
2023-03-31 14:59:16 +11:00
jibees
996c6d35f3
Merge pull request #10633 from openfoodfoundation/dependabot/bundler/debug-1.7.2
...
Bump debug from 1.7.1 to 1.7.2
2023-03-30 14:08:13 +02:00
Jean-Baptiste Bellet
89036db666
Do not use a preference, but create a new column for hide_ofn_navigation
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
dd9fec58a4
Instead of parsing URLs pass order through method for Orders Ctrl
...
Use methods for before_actions
Maybe we should for hide_of_navigation too, but a name 'hide_ofn_navigation_for_order_distributor' seemed unhelpful..
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
4fa44e6c64
Put the white label behind a feature toggle white_label
...
+ update specs as well
+ for admin section also
2023-03-30 09:19:17 +11:00
Jean-Baptiste Bellet
4ad2a1a723
Prefer a concern that set a variable instead of a global helper
...
Therefor, for the right controllers, simply implements:
```
include WhiteLabel
before_action :hide_ofn_navigation, only: [:show, :edit]
```
This is mort robust, since we're working in a controller level, not parsing URLs...
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
5279be4dc6
Improve spec: visiting order confirmation with distributor
...
Two cases:
- the current distributor is the same than the order of the order confirmation page
- the current distributor *is not* the same than the order of the order confirmation page (and has not set `hide_ofn_navigation` preference to `true`)
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
348c1ff7da
Hide the OFN navigation menu when distributor as set its preference
...
Hide, when preference is true, for page:
- shop
- cart
- checkout
- order confirmation
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
c20ae0de1e
Edit hide_ofn_navigation in 'white label' panel for an enterprise
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
3452864503
Add "white label" panel in enterprise settings page
2023-03-30 09:17:57 +11:00
Jean-Baptiste Bellet
d2f29b7d73
Some refactoring to avoid rubocop class too long warning
2023-03-30 09:13:35 +11:00
Filipe
62cdda2ce2
Merge pull request #10523 from rioug/10431-voucher-minimum-backend
...
Voucher bare minimum backoffice
2023-03-29 20:21:57 +01:00
Filipe
e6123969d2
Merge pull request #10607 from mkllnk/zone-spec
...
Sort zones by name again, in the admin panel
2023-03-29 17:57:50 +01:00
Filipe
90ce52612d
Merge pull request #10615 from mkllnk/background-report-job
...
Run background reports with Sidekiq, not fork
2023-03-29 17:38:48 +01:00
jibees
7e6d40f370
Merge pull request #10621 from openfoodfoundation/dependabot/bundler/valid_email2-4.0.6
...
Bump valid_email2 from 4.0.5 to 4.0.6
2023-03-29 17:13:34 +02:00
Filipe
b6e4ff908f
Merge pull request #10566 from mkllnk/products-meta-description
...
Remove unused product meta description
2023-03-29 15:58:31 +01:00
Filipe
c16c1a5e62
Merge pull request #10544 from filipefurtad0/test_pdf_reports
...
Adds pdf comparison; removes csv, xlsx, pdf file fixtures
2023-03-29 14:03:25 +01:00
dependabot[bot]
3f5aceff99
Bump debug from 1.7.1 to 1.7.2
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.1...v1.7.2 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-29 10:00:12 +00:00
dependabot[bot]
b8e9925601
Bump valid_email2 from 4.0.5 to 4.0.6
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/micke/valid_email2/releases )
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v4.0.5...v4.0.6 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-29 07:51:47 +00:00
Maikel
667a514ed2
Merge pull request #10623 from jibees/10622-flaky-specservicesorder_cycle_form_specrb403
...
Flaky: Sort array to avoid flaky spec when comparing values
2023-03-29 16:32:44 +11:00
filipefurtad0
25108f4c70
Removes all fixture files; asserts on downloaded file
...
Changes helper method to assert there is one file only
load_file_txt will be useful in other spec files too, and could probably be moved to spec/support/file_helper.rb
2023-03-29 16:24:21 +11:00
Maikel Linke
6f83607aa8
Remove unused product meta description from DB
2023-03-29 14:35:16 +11:00
Maikel Linke
70aff98581
Remove unused product meta description from UI
2023-03-29 14:33:42 +11:00
Maikel
812fb974dd
Merge pull request #10584 from openfoodfoundation/dependabot/bundler/devise-i18n-1.11.0
...
Bump devise-i18n from 1.10.3 to 1.11.0
2023-03-29 13:08:35 +11:00
filipefurtad0
0a91f3d392
Sorts all shipiping method arrays
2023-03-28 15:46:41 +02:00
Gaetan Craig-Riou
c7c19e47de
Add feature toggle description
2023-03-28 13:46:51 +11:00
Gaetan Craig-Riou
e1845dddac
Fix TabsAndPanelsController now that #! are removed from url
...
This PR https://github.com/openfoodfoundation/openfoodnetwork/pull/9729
remove #! from url. But unfortunately, AngularJs rewrite "example.com#panel"
as "example.com#/panel" thus breaking the original implementation.
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
2e10336a47
Add ability to manage voucher for enterprise user
...
Update spec accordingly
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
37d3c025e9
Make sure New voucher page can be accessed from voucher panel
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
6eb52aa540
TabsAndPanelsController specs, add missinrg panel scenario
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
6809198c96
Vouchers specs, remove obsolete step
...
Vouchers tabs now shows when returning from new voucher page,
no need to manually click on the 'vouchers' link in the menu
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
3b7aebd6da
Enable vouchers feature toggle when running vouchers specs
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
7dc5bc87d1
Fix rubocop warnings
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
0c43d0f16a
Put vouchers admin screen behind 'vouchers' feature toggle
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
fb1ad4c65f
Remove non needed collumn from voucher list
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
04748b6e0e
Move voucher value to the model
...
Use Spree::Money to display amount with currency
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
094fc039e9
Update tabs_and_panels to display tab and panel based on the url anchor
...
For Vouchers, this means the voucher tab and panel are displayed when
you come back to entreprise edit screen from the new vourcher page
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
e4f40d14b8
Fix enterprise voucher tab
...
Add harcoded voucher amount
Add missing translation
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
4085aa22dc
Add create voucher action and system test
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a4add889a8
Add form on the new voucher page
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
f9f6793d10
Add template and basic controller for backoffice voucher pages
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a62687b1a7
Fix warning : The implicit block expectation syntax is deprecated
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a48fd0828c
Add Voucher model
...
A voucher belongs to an enterprise and an enterprise can have many
vouchers
2023-03-28 13:39:29 +11:00
Maikel
6cfb86e578
Link to merged feature toggle wiki page
2023-03-28 12:25:21 +11:00
Maikel
a168126cfa
Merge pull request #10600 from mkllnk/features
...
Add all feature toggles with descriptions at boot
2023-03-28 10:58:40 +11:00
Jean-Baptiste Bellet
88c833ec83
Sort array to avoid flaky spec when comparing values
2023-03-27 15:57:46 +02:00
Konrad
c887efee54
Merge pull request #10519 from vviekk/viv/10515
...
Removing 'none' from shipping categories from product edit page
2023-03-27 14:01:11 +02:00
jibees
86abff224e
Merge pull request #10616 from mkllnk/rails-7-schema
...
Update DB schema to Rails 7.0
2023-03-27 10:56:14 +02:00
vviekk
9a10c8c25a
Removing none from shipping categories from product edit page
2023-03-27 11:56:10 +05:30
Maikel Linke
4461b33491
Sort zones by name again
...
Zones were intended to be sorted by name. But I guess that the syntax of
Ransack changed one day and we didn't notice because the spec was
creating entries in the right order already (which often reflects the
query result order without parameters). So the spec is fixed to fail if
the sorting doesn't happen and Ransack is configured to sort correctly.
The previous sort value was ignored.
2023-03-27 16:36:04 +11:00
Maikel Linke
5ae9016f09
Speed up spec by skipping additional page load
...
The login_as_admin helper has to load a page to log in. Providing the
page we want to go to avoids going to the default page first.
2023-03-27 16:36:04 +11:00
Maikel Linke
67ab8f63e0
Remove superfluous test setup
...
There are no zones at the start of the test. This is probably a
left-over from old times when specs were not encapsulated in
transactions.
2023-03-27 16:36:04 +11:00
Maikel Linke
40e64acd37
Update DB schema to Rails 7.0
...
This is the result of: `./bin/rails db:migrate`
2023-03-27 16:18:02 +11:00
Maikel Linke
78fea7c7f2
Run background reports with Sidekiq, not fork
...
Forking worked in theory but crashed the browser in system specs. It
also came with many other hurdles and isn't well known solution in the
Rails community. Sidekiq can give us better control over execution
limits as well.
2023-03-27 13:27:49 +11:00
Konrad
4c61666fc7
Merge pull request #10547 from vviekk/10419
...
Enable invoices config only controls Print bulk action
2023-03-26 13:53:20 +02:00
Konrad
0c6a12a6f0
Merge pull request #10241 from binarygit/provide-err-msg-when-using-text-in-var-field
...
Admin, edit variant: only allow numerical values for weight, height, width and depth fields
2023-03-26 13:03:20 +02:00
jibees
0da245f912
Merge pull request #10595 from jibees/10592-flaky-specservicesorder_cycle_form_specrb282
...
Flaky spec: Sort each array to ensure the order
2023-03-24 16:11:49 +01:00
jibees
eba0c9c4f7
Merge pull request #10609 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.7
...
Bump prettier from 2.8.6 to 2.8.7
2023-03-24 11:22:07 +01:00
dependabot[bot]
25618c009e
Bump prettier from 2.8.6 to 2.8.7
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.6 to 2.8.7.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.6...2.8.7 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-24 09:58:19 +00:00
jibees
068ac40a76
Merge pull request #10589 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.13.1
...
Bump webpack-dev-server from 4.12.0 to 4.13.1
2023-03-24 10:52:01 +01:00
dependabot[bot]
5868fd1b7c
Bump webpack-dev-server from 4.12.0 to 4.13.1
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 4.12.0 to 4.13.1.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v4.12.0...v4.13.1 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-24 09:36:40 +00:00
jibees
540129854e
Merge pull request #10603 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.119.2
...
Bump aws-sdk-s3 from 1.119.1 to 1.119.2
2023-03-24 10:29:26 +01:00
jibees
f747ab568a
Merge pull request #10604 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.9.0
...
Bump knapsack_pro from 3.8.0 to 3.9.0
2023-03-24 10:23:01 +01:00
Jean-Baptiste Bellet
f9f619c036
Update all locales with the latest Transifex translations
2023-03-24 09:29:45 +01:00
Filipe
31ffeab4cd
Merge pull request #10440 from mkllnk/rails7
...
Upgrade to Rails 7.0
2023-03-23 12:04:11 +00:00
Filipe
1673a18eb6
Merge pull request #9729 from binarygit/remove-angular-from-users
...
Admin, Enterprise Settings, Users tabs: remove tooltips directives + use reflex to invite user to be managers
2023-03-23 11:52:18 +00:00
Mohamed ABDELLANI
d3a25282de
fix load order cycles by date ranges
2023-03-23 12:02:17 +01:00
Jean-Baptiste Bellet
29cdadd563
Avoid using exception but simply errors attribute contained in object
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-03-23 11:21:15 +01:00
Jean-Baptiste Bellet
8dffb38bf5
Sort each array to ensure the order
...
and then expect the right values.
2023-03-23 11:21:05 +01:00
binarygit
ecd5033efa
Replace angular for when adding a new unregistered manager to an enterprise
...
Co-Authored-By: David Cook <david@redcliffs.net >
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
a13227defa
Add I18N to all reflexes
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
465a295dfa
Delete manager invitation controller
2023-03-23 11:21:05 +01:00
Jean-Baptiste Bellet
9c84a6936a
Create a concern for manager invitations
...
Can be used elsewhere
Update manager_invitations.rb
2023-03-23 11:21:05 +01:00
dependabot[bot]
f3d687cbea
Bump knapsack_pro from 3.8.0 to 3.9.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.8.0...v3.9.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 10:05:23 +00:00
dependabot[bot]
6894cb5dd7
Bump aws-sdk-s3 from 1.119.1 to 1.119.2
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.1 to 1.119.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 10:04:05 +00:00
Filipe
809a57dbdb
Merge pull request #10437 from openfoodfoundation/10436-the-cookie-policy-modal-does-not-appear-to-use-the-language-selected-by-the-user
...
Translate cookie policy into languages selected by the user
2023-03-23 10:00:38 +00:00
Filipe
6b30a654a6
Merge pull request #10516 from macanudo527/fix_taxonomy
...
Fix Sorting entries in a taxonomy is broken
2023-03-23 09:23:16 +00:00
Filipe
9b749ee2e0
Merge pull request #10466 from dacook/report-summaries
...
Report summaries in JSON (API) output
2023-03-22 23:34:48 +00:00
David Cook
c27974c5a3
Add marker for summary rows
...
This can be enabled in the reports API with the hidden parameter `fields_to_show[]=report_row_type` to help with parsing summary row output.
2023-03-22 11:47:26 +00:00
David Cook
6f41a4168d
Allow headers and footers for JSON format
...
You wouldn't want it by default, but it can be enabled with a parameter like display_summary_row=true
2023-03-22 11:47:26 +00:00
David Cook
db7ac904e9
Allow column formatting and header/footer stripping to be specified independently
...
This will allow us to change the options in the following commit.
2023-03-22 11:47:26 +00:00
David Cook
96eaec908d
Remove unused mock in specs
...
It looks like it was expected that the price and amount columns would be formatted, but this is not currently the case. So I cleaned this up to be less ambiguous.
If any of these columns were to be configured for formatting, this line could be added back to test for unformatted output.
2023-03-22 11:47:26 +00:00
Maikel Linke
e0fd180edd
DRY Flipper UI config
2023-03-22 15:45:26 +11:00
Maikel Linke
fd68cbf56d
Remove on-the-fly adding of feature toggle entries
...
We now have a new source of truth. You shouldn't use a feature toggle
without adding it to OpenFoodNetwork::FeatureToggle first. All toggles
are added at boot time already.
2023-03-22 15:36:08 +11:00
Maikel Linke
9a1b1498bf
Add all feature toggles with descriptions at boot
...
So you can easily inspect and activate new features without trying to
use them first. It brings more visibility and will enable us to easily
remove retired features as well.
2023-03-22 15:36:08 +11:00
Filipe
12de3ae584
Merge pull request #10509 from mkllnk/filter-shipping-methods-by-category
...
Filter shipping methods by category
2023-03-21 17:47:22 +00:00
Rachel Arnould
75c3bf8b56
Merge pull request #9630 from binarygit/remove-angular-from-business-details
...
Remove angular from business details
2023-03-21 18:31:40 +01:00
Rachel Arnould
52c12ea896
Merge pull request #10554 from mkllnk/dfc-variants
...
Ignore master variants exporting to DFC
2023-03-21 18:30:05 +01:00
jibees
2e4bbb7740
Merge pull request #10590 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.6
...
Bump prettier from 2.8.5 to 2.8.6
2023-03-21 15:32:45 +01:00
dependabot[bot]
1b0880e7df
Bump prettier from 2.8.5 to 2.8.6
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.5 to 2.8.6.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.5...2.8.6 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-21 14:12:05 +00:00
Filipe
84f319894a
Merge pull request #10594 from jibees/10593-deployment-failed-on-master
...
Move `webpack-*` as dependency (not devDependencies)
2023-03-21 14:09:52 +00:00
Jean-Baptiste Bellet
2a9b6f8e8c
Sort each array to ensure the order
...
and then expect the right values.
2023-03-21 14:52:05 +01:00
Jean-Baptiste Bellet
c4e58eab3c
Move webpack-* as dependency (not devDependencies)
2023-03-21 14:35:57 +01:00
Neal Chambers
920e9e65bd
Merge remote-tracking branch 'origin/fix_taxonomy' into fix_taxonomy
2023-03-21 21:39:02 +09:00
David Cook
78b978efba
Merge pull request #10458 from dacook/838-node-install-scripts
...
Node install script
2023-03-21 15:02:08 +11:00
Maikel Linke
31db35675b
Add feature toggle for filtering shipping methods
2023-03-21 14:49:47 +11:00
Maikel Linke
6b25c36476
Filter ship methods by required shipping category
...
The products in an order may require several shipping categories like
refrigeration or express. We now filter the categories according to
their support of shipping categories.
2023-03-21 14:30:45 +11:00
Maikel Linke
73fa6295ec
Simplify shipping method selection code
2023-03-21 14:30:44 +11:00
Maikel Linke
b5f43b3c1c
Rename method because it's not changing the input
...
A common Ruby convention is to to use the bang naming `!` to mark method
which change the given parameter instead of returning a copy.
2023-03-21 14:30:44 +11:00
Maikel Linke
fcc68a0a19
Return new filtered list instead of modifying
...
This makes a clear distinction between the unfiltered and filtered list.
There may also be some gotchas when modifying the array of an
ActiveRecord relation. It also allows us to write shorter code without
storing a separate variable.
2023-03-21 14:30:44 +11:00
Maikel Linke
4c2d7c0d1c
Rename confusing test variable
...
The "subject" is usually the code under test. In this spec it would be
the TagRuleApplicator and not the parameter given to it. So I renamed it
to avoid confusion here.
2023-03-21 14:30:44 +11:00
Maikel Linke
eee5e8eee7
Remove unnecessary tag rule code
...
The applicator converts the input to an array, even `nil` becomes an
empty array. Iterating over an empty array doesn't do anything either,
the result is the same.
2023-03-21 14:30:44 +11:00
Maikel Linke
e227cb912b
Simplify tag rule spec
...
We don't need to know the internals. We want to know that the applicator
is not raising an error when we give `nil` or an empty collection.
2023-03-21 14:30:44 +11:00
Maikel Linke
6f3a0e8812
De-duplicate early for better performance
2023-03-21 14:30:44 +11:00
Maikel Linke
d7e4962fba
Add method for easier reading
2023-03-21 14:30:44 +11:00
David Cook
7ad5181026
Merge pull request #10568 from openfoodfoundation/dependabot/npm_and_yarn/webpack-dev-server-4.12.0
...
Bump webpack-cli and webpack-dev-server from v3 to v4
2023-03-21 11:47:16 +11:00
jibees
c2133c8fa5
Merge pull request #10583 from openfoodfoundation/dependabot/bundler/flipper-active_record-0.26.2
...
Bump flipper-active_record from 0.26.0 to 0.26.2
2023-03-20 14:48:10 +01:00
dependabot[bot]
de5264138d
Bump flipper-active_record from 0.26.0 to 0.26.2
...
Bumps [flipper-active_record](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper-active_record
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 13:30:57 +00:00
Jean-Baptiste Bellet
bfbcdba98c
Modify configuration to match new version of webpacker
...
Error was:
```
ERROR in chunk admin [entry]
js/[name]-[contenthash].js
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)
```
2023-03-20 11:34:57 +01:00
David Cook
0632553a4a
Remove @webpack-cli/serve
...
This now gets included as a dependency of webpack-cli v4. If webpack-cli had been upgraded earlier, we never would have needed to specify this.
2023-03-20 11:34:57 +01:00
David Cook
a97d416bfd
Bump webpack-cli from 3.3.12 to 4.10.0
...
I don't know why, but Dependabot decided not to: https://github.com/openfoodfoundation/openfoodnetwork/pull/9798#issuecomment-1288583629
This is required for webpack-dev-server v4.
2023-03-20 11:34:56 +01:00
dependabot[bot]
b306539163
Bump webpack-dev-server from 3.11.3 to 4.12.0
...
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server ) from 3.11.3 to 4.12.0.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases )
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v3.11.3...v4.12.0 )
---
updated-dependencies:
- dependency-name: webpack-dev-server
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 11:33:31 +01:00
jibees
caea53ab91
Merge pull request #10582 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.5
...
Bump @floating-ui/dom from 1.2.4 to 1.2.5
2023-03-20 11:23:56 +01:00
jibees
d7ee0ca434
Merge pull request #10580 from openfoodfoundation/dependabot/bundler/flipper-ui-0.26.2
...
Bump flipper-ui from 0.26.0 to 0.26.2
2023-03-20 11:20:11 +01:00
jibees
7fa4aa62f9
Merge pull request #10581 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.5
...
Bump prettier from 2.8.4 to 2.8.5
2023-03-20 11:17:14 +01:00
dependabot[bot]
ca97adb724
Bump devise-i18n from 1.10.3 to 1.11.0
...
Bumps [devise-i18n](https://github.com/tigrish/devise-i18n ) from 1.10.3 to 1.11.0.
- [Release notes](https://github.com/tigrish/devise-i18n/releases )
- [Changelog](https://github.com/tigrish/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tigrish/devise-i18n/compare/v1.10.3...v1.11.0 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:59:49 +00:00
dependabot[bot]
6295ecc7cf
Bump @floating-ui/dom from 1.2.4 to 1.2.5
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.4 to 1.2.5.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.5/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:48 +00:00
dependabot[bot]
b207d3e7fd
Bump prettier from 2.8.4 to 2.8.5
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.4 to 2.8.5.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.4...2.8.5 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:31 +00:00
dependabot[bot]
b4f3655fae
Bump flipper-ui from 0.26.0 to 0.26.2
...
Bumps [flipper-ui](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper-ui
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 09:58:17 +00:00
Jean-Baptiste Bellet
918e220557
Move $locationProvider configuration to another file
...
Actually the `config()` method of `admin_ofn` file did not run on `/admin/enterprises/*` pages for an unknown reason
Now those two files have the same configuration
2023-03-20 08:37:47 +01:00
binarygit
a397ba1ca9
Replace what's this tooltips
...
There are tooltips here that don't have a what's this?
There are many angular directives/methods being used that I haven't
looked into
Every select box is using select2
2023-03-20 08:37:47 +01:00
Maikel Linke
7cd235c84d
Translate AngularJS templates in the browser
...
AngularJS templates are compiled as assets on deploy. Any translatable
text can't be translated in Ruby during compilation because it's static
text. It needs to be translated with an AngularJS filter in the browser.
2023-03-20 17:02:10 +11:00
Jean-Baptiste Bellet
e97cd0a1fd
That particular spec is actually failing ; this must be solved
2023-03-20 16:59:19 +11:00
Jean-Baptiste Bellet
a56f061663
Prepare the spec to be factorized and to be used in different context
2023-03-20 16:59:19 +11:00
Maikel
512cb44df5
Merge pull request #10330 from mickenorlen/8909-add-balance-to-api-v1-customer-endpoint
...
Add balance to api v1 customers endpoint
2023-03-20 15:47:41 +11:00
Maikel
0ab8e62749
Merge pull request #10405 from jibees/upgrade-node-version
...
Upgrade node version
2023-03-20 10:55:41 +11:00
Mohamed ABDELLANI
008b12a75d
remove "/" from the partial path to load sub-report filters
2023-03-20 10:41:28 +11:00
Maikel Linke
2e51d9be4a
Include Rails version in db schema
...
So Rails knows which defaults to apply.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#rails-version-is-now-included-in-the-active-record-schema-dump
2023-03-20 10:41:28 +11:00
Maikel Linke
bd20e299f3
Support old cookie encryption
...
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#key-generator-digest-class-changing-to-use-sha256
2023-03-20 10:41:28 +11:00
Maikel Linke
90a92421f4
Remove obsolete setting of Zeitwerk
...
It's the default now.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#the-setter-config-autoloader-has-been-deleted
2023-03-20 10:41:28 +11:00
Maikel Linke
84daa046ca
Update I18n spec to Rails 7
2023-03-20 10:41:28 +11:00
Maikel Linke
61259bcfc2
Bump rails from 6.1.7 to 7.0.4
...
Result of:
bundle update --conservative rails railties\
actioncable actionmailbox actionmailer actionpack actiontext\
actionview activejob activemodel activerecord activestorage activesupport
2023-03-20 10:41:15 +11:00
Maikel Linke
4f44d50943
Omit Rails version restriction
2023-03-20 10:38:57 +11:00
Konrad
2e426c701e
Merge pull request #10232 from binarygit/show-correct-error-when-user-inputs-url-as-ig-acc
...
[Enterprise->Create] Show correct error message when user inputs url in instagram field
2023-03-19 21:57:02 +01:00
Konrad
99b3701e17
Merge pull request #10463 from openfoodfoundation/dependabot/bundler/devise-4.9.0
...
Bump devise from 4.8.1 to 4.9.0
2023-03-17 18:41:03 +01:00
Filipe
8bef0f9a43
Merge pull request #10337 from jibees/9419-send-invoices-per-email-in-bulk-from-the-admin-orders-page
...
Admin, orders list page: send invoices per email in bulk
2023-03-17 10:58:26 +00:00
jibees
d69aa04435
Merge pull request #10577 from openfoodfoundation/dependabot/bundler/flipper-0.26.2
...
Bump flipper from 0.26.0 to 0.26.2
2023-03-17 11:42:23 +01:00
dependabot[bot]
0b4a243d8e
Bump flipper from 0.26.0 to 0.26.2
...
Bumps [flipper](https://github.com/jnunemaker/flipper ) from 0.26.0 to 0.26.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.26.0...v0.26.2 )
---
updated-dependencies:
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-17 10:01:35 +00:00
David Cook
ced9784fb8
Merge pull request #10576 from openfoodfoundation/revert-10474-fix-customer-can-checkout-non-matching-shipping-and-product-categories
...
Revert "Fix: Customers can checkout with non-matching shipping and product categories"
2023-03-17 15:41:04 +11:00
David Cook
788457618f
Check ship address required based on all available methods
...
This check was implemented based on 'allowed' shipping methods, but we need to revert that logic. So for now, we can check all 'available' shipping methods.
This could potentially result in the same query being run twice, because load_shipping_methods also loads it. I opted to keep things simple and not try to optimise here.
2023-03-17 13:06:45 +11:00
David Cook
ef607da2c1
Revert "Fix: Customers can checkout with non-matching shipping and product categories"
2023-03-17 10:40:53 +11:00
Filipe
9ea6fa5c44
Merge pull request #9687 from dacook/9616-order-cycle-open-webhook
...
Add webhook triggered on Order Cycle Open
2023-03-16 17:24:22 +00:00
Konrad
a945f8f72f
Merge pull request #10522 from mkllnk/flipper-upgrade
...
Bump flipper* from 0.20.4 to 0.26.0
2023-03-16 17:24:33 +01:00
jibees
0c3ee2e8fc
Merge pull request #10574 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-4.6.0
...
Bump jasmine-core from 4.5.0 to 4.6.0
2023-03-16 14:59:33 +01:00
vviekk
54d5d0ed80
Accepting 0<unit values<1 in product import validations
2023-03-16 16:26:43 +05:30
dependabot[bot]
f6458e91c2
Bump jasmine-core from 4.5.0 to 4.6.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.5.0...v4.6.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-16 09:59:04 +00:00
vviekk
ac5cbcf19e
Merge branch 'openfoodfoundation:master' into 9978
2023-03-16 14:30:26 +05:30
David Cook
4757b82a80
Update all locales with the latest Transifex translations
2023-03-16 14:15:04 +11:00
David Cook
ad9e82e973
Merge pull request #10569 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.7
...
Bump sidekiq from 7.0.6 to 7.0.7
2023-03-16 11:47:55 +11:00
Filipe
e8430eae6d
Merge pull request #10460 from jibees/10400-pagination-in-bom-not-aggregating-results-from-quick-search-field
...
BOM: Add a search input that search for items with pagination
2023-03-15 16:31:32 +00:00
dependabot[bot]
584b013a49
Bump sidekiq from 7.0.6 to 7.0.7
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 10:05:08 +00:00
Maikel
f15cb01f2a
Merge pull request #10520 from mkllnk/return-auth-controller-spec
...
Correctly include order id in return auth spec for Rails 7 compatibility
2023-03-15 14:08:16 +11:00
Maikel Linke
f1a5c46685
Remove unnecessary Flipper memoizer config
...
Auto-config, yay.
2023-03-15 12:54:03 +11:00
Maikel Linke
00f2f92ce0
Remove unnecessary Flipper active_record config
...
This is now done automatically when including flipper-active_record in
the Gemfile.
2023-03-15 12:54:03 +11:00
Maikel Linke
fdd71cff51
Remove now unnecessary flipper_id method
...
Flipper does it for us.
2023-03-15 12:54:02 +11:00
Maikel Linke
c9ca020f05
Bump flipper* from 0.20.4 to 0.26.0
2023-03-15 12:54:02 +11:00
David Cook
d59074dabd
Tidy up spec
...
The best way to check if something changed or not, is with 'change' of course.
2023-03-15 12:18:17 +11:00
jibees
6a874b9527
Merge pull request #10562 from openfoodfoundation/dependabot/bundler/rails-6.1.7.3
...
Bump rails from 6.1.7.2 to 6.1.7.3
2023-03-14 15:02:49 +01:00
dependabot[bot]
1f08da207f
Bump rails from 6.1.7.2 to 6.1.7.3
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.7.2 to 6.1.7.3.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.7.2...v6.1.7.3 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-14 09:59:50 +00:00
Maikel Linke
9c3bdc6b9b
Remove unnecessary table join
...
And use Rails syntax for clarity and future extensions.
2023-03-14 14:38:25 +11:00
Maikel Linke
2105c0d0ea
Ignore master variants exporting to DFC
2023-03-14 14:38:24 +11:00
Maikel Linke
6e514acc77
Spec too many variants exported to DFC
2023-03-14 14:38:24 +11:00
Maikel Linke
b8338fb9af
Removing engine namespace from services
...
Services are usually not namespaced because they are part of the app.
This engine has an isolated namespace which means that we don't need to
separate with out own namespacing here.
2023-03-14 13:49:21 +11:00
jibees
687d4593fb
Merge pull request #10550 from openfoodfoundation/dependabot/bundler/database_cleaner-2.0.2
...
Bump database_cleaner from 2.0.1 to 2.0.2
2023-03-13 21:12:42 +01:00
dependabot[bot]
b62f88512f
Bump database_cleaner from 2.0.1 to 2.0.2
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases )
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v2.0.1...v2.0.2 )
---
updated-dependencies:
- dependency-name: database_cleaner
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 15:24:41 +00:00
jibees
6bdb89d090
Merge pull request #10551 from openfoodfoundation/dependabot/bundler/rubocop-1.48.1
...
Bump rubocop from 1.48.0 to 1.48.1
2023-03-13 16:16:56 +01:00
jibees
a63531c8c2
Merge pull request #10549 from openfoodfoundation/dependabot/bundler/ddtrace-1.10.1
...
Bump ddtrace from 1.10.0 to 1.10.1
2023-03-13 16:15:06 +01:00
jibees
de2a15e3e1
Merge pull request #10548 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.4
...
Bump @floating-ui/dom from 1.2.3 to 1.2.4
2023-03-13 16:14:00 +01:00
vviekk
2674df026a
Fixing 'unsaved' alert behaviour for order cycle edit forms
2023-03-13 17:50:00 +05:30
dependabot[bot]
e5f5d42d59
Bump rubocop from 1.48.0 to 1.48.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.48.0 to 1.48.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.48.0...v1.48.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 10:05:22 +00:00
dependabot[bot]
f23de206d9
Bump ddtrace from 1.10.0 to 1.10.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.0 to 1.10.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.0...v1.10.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 10:03:01 +00:00
dependabot[bot]
729bcdf291
Bump @floating-ui/dom from 1.2.3 to 1.2.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-13 09:58:49 +00:00
vviekk
c1c0eca7c4
Enable invoices config only controls Print bulk action
2023-03-13 11:39:21 +05:30
vviekk
e10ea4b686
Merge branch 'openfoodfoundation:master' into 9978
2023-03-11 11:00:03 +05:30
David Cook
8f67e9839d
Apply code suggestion
...
Avoids an error:
./script/nodenv-install.sh: line 13: brew: command not found
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-10 13:38:59 +11:00
Maikel Linke
62d0ce290a
Update translations
2023-03-10 11:42:36 +11:00
jibees
96ead52fcc
Merge pull request #10536 from openfoodfoundation/dependabot/bundler/rack-2.2.6.3
...
Bump rack from 2.2.6.2 to 2.2.6.3
2023-03-09 14:55:19 +01:00
dependabot[bot]
ff708952ab
Bump rack from 2.2.6.2 to 2.2.6.3
...
Bumps [rack](https://github.com/rack/rack ) from 2.2.6.2 to 2.2.6.3.
- [Release notes](https://github.com/rack/rack/releases )
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rack/rack/compare/v2.2.6.2...v2.2.6.3 )
---
updated-dependencies:
- dependency-name: rack
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-09 02:40:19 +00:00
David Cook
fdeeab5750
Test twitter with (almost) real world example
...
I discovered that twitter doesn't have 'www' in the url anymore, no '@' symbol and interestingly no trailing slash. I added back the '@' just so we can test that still.
Using a regex group we can cater for optional www in a single regex.
2023-03-09 11:22:04 +11:00
David Cook
9e7e176cf9
Accept full URLs
...
It looks like the intention was there, so I made it work.
I've included a real world example, but added capitalisation to complete the test.
2023-03-09 11:21:52 +11:00
Konrad
2daa49406a
Merge pull request #10506 from jibees/9868-product-import-empty-variant-names-recorded-differently-leads-to-variant-duplication
...
Product import: consider `display_name` with `null` or `empty` as value as equal
2023-03-08 16:58:32 +01:00
Konrad
125bc3d14b
Merge pull request #10514 from jibees/9292-changes-to-incomingoutgoing-products-lists-triggering-failed-to-update-order-cycle-error
...
Do not update `estimate_price` of a variant that is not available for the shop on OrderCycle update
2023-03-08 15:45:11 +01:00
Rachel Arnould
02300d6bb6
Merge pull request #10496 from rioug/10479-split-checkout-fix-user-blocked-at-step1
...
[split checkout] Fix bug preventing user from reaching payment step
2023-03-08 15:44:50 +01:00
Rachel Arnould
aba3968bca
Merge pull request #10447 from jibees/9148-no-bulk-delete-possible-on-bom-when-orders-have-multiple-items
...
Admin, BOM: can bulk delete line items of an order
2023-03-08 14:56:25 +01:00
Gaetan Craig-Riou
23c4298519
Fix bug when in specific scenario user couldn't proceed to payment step
...
When using a "pick up" shipping method, with a user who doesn't have a shipping address it was impossible to proceed to the payment step because shipping address was invalid.
To fix this, we ensure that "ship_address_same_as_billing" parameter is set to true when using a "pick up" shipping method.
use distributor address when shipping method doesn't require a ship address ; in doing this we follow the same logic as the legacy checkout
2023-03-08 10:49:37 +01:00
Jean-Baptiste Bellet
40a0d8e08c
Improve design: make delete not a button but a link + close to file name
2023-03-08 10:38:28 +01:00
Jean-Baptiste Bellet
5cbec5521c
Simplify ability
...
Co-Authored-By: David Cook <david@redcliffs.net >
2023-03-08 10:38:28 +01:00
Rachel Arnould
d7047bb4cc
Merge pull request #10513 from jibees/10505-add-shopper-comment-to-order-detail-summary
...
SplitCheckout: Display special_instructions of the order as emphasized text if present on summary page
2023-03-08 10:30:40 +01:00
binarygit
8f6fdf3e31
[Admin, Enterprise Settings] Remove Angular from Business Details tab
2023-03-08 10:26:05 +01:00
Rachel Arnould
1ce029d8e4
Merge pull request #10497 from jibees/10495-split-checkout-label-of-checkbox-save-card-for-future-use-is-clickable-but-not-active
...
SplitCheckout: Make label clickable to check/uncheck checkbox on step 2
2023-03-08 10:20:00 +01:00
jibees
eb7d20d74d
Merge pull request #10530 from mkllnk/flaky-service-spec
...
Stabilise spec with deterministic order
2023-03-08 09:04:29 +01:00
Maikel Linke
c4ba1e6616
Stabilise spec with deterministic order
...
The ids were returned in random order before.
2023-03-08 13:14:40 +11:00
Maikel
f97ccb4203
Merge pull request #10525 from openfoodfoundation/dependabot/bundler/ddtrace-1.10.0
...
Bump ddtrace from 1.9.0 to 1.10.0
2023-03-08 12:09:04 +11:00
Maikel
df8283661d
Merge pull request #10487 from mkllnk/time-spec
...
Prepare caching spec for Rails 7
2023-03-08 11:37:44 +11:00
Maikel
d9ee56b4a5
Merge pull request #10524 from mkllnk/dfc-urls
...
Configure host for dfc_provider engine globally
2023-03-08 11:13:48 +11:00
dependabot[bot]
2230a1f179
Bump ddtrace from 1.9.0 to 1.10.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.9.0...v1.10.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-07 09:58:38 +00:00
Maikel Linke
a9c8d9f304
Configure host for dfc_provider engine globally
...
Passing the parameter all the time was pretty inconvenient.
2023-03-07 16:39:02 +11:00
David Cook
9d5ca2255b
Apply suggestions from code review
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-07 15:38:50 +11:00
David Cook
00a823b2fc
6. Add webhook endpoints to user developer settings screen
...
Allowing creation and deleting via the user association.
It probably won't be much effort to allow editing and multiple records, but I cut it down to the minimum needed to avoid any further delays.
I couldn't find a way to test a failure in the destroy method, but decided to keep the condition because I thought it was worth having.
2023-03-07 15:38:50 +11:00
David Cook
3d81a6e280
Prevent creating duplicate webhook notifications [migration]
...
Using the clever concurrency testing borrowed from SubscriptionPlacementJob, but I thought a shorter pause time (just 100ms) would be sufficient.
I considered doing this with a new 'state' field (upcoming/open/close), but decided to keep it simple.
2023-03-07 15:38:50 +11:00
David Cook
739df4be01
4. OrderCycleOpenedJob triggers webhook
2023-03-07 15:38:50 +11:00
David Cook
b91cabc510
Also send webhook payloads for distributor owners
...
But not supplier owners.
2023-03-07 15:38:50 +11:00
David Cook
ba152f12ee
3. Add OrderCycleWebhookService to create webhook payloads for an order cycle event
2023-03-07 15:38:50 +11:00
David Cook
778baba118
User may have many WebhookEndpoints [migration]
...
Although we won't be allowing multiple in the this PR, we certainly plan to in the future.
The migration helper add_reference couldn't handle the custom column name, so I had to put it together manually.
2023-03-07 15:38:50 +11:00
David Cook
85c98c6d3e
2. Add model WebhookEndpoint [migration]
...
This will store the URL for each user that wants a notification.
We probably don't need URL validation (it's not done on Enterprise for example). It could be validated by browser input, and anyway will be validated if the webhook actually works or not.
Inspired by Keygen: https://keygen.sh/blog/how-to-build-a-webhook-system-in-rails-using-sidekiq/
2023-03-07 15:38:50 +11:00
David Cook
de9546587a
Prevent webhooks to private addresses (SSRF) [add gem]
...
Best reviewed with whitespace hidden.
Unfortunately the spec isn't allowed in CI. But it worked on my environment, I promise.
I chose `xit` so that it doesn't run unnecessarily. Perhaps we could use `pending` instead, which would execute, and notify us if it suddenly started working one day. But I doubt it.
2023-03-07 15:38:50 +11:00
David Cook
9741935955
Raise error on server error
...
And thus retry later.
I tried to test that it actually retries, or ensuring the job remained in the queue to be retried, but couldn't get it to work.
2023-03-07 15:38:50 +11:00
David Cook
9d19f37fec
1. Add WebhookDeliveryJob
...
This job is responsible for delivering a payload for one webhook event only. It allows the action to run asynchronously (and not slow down the calling process).
2023-03-07 15:38:50 +11:00
David Cook
718ac0ab80
Add Faraday for making HTTP requests [add gem]
...
It's the most popular and flexible option, so should be able to cater for our future needs best.
2023-03-07 15:38:47 +11:00
Neal Chambers
d95c5ff8a8
Use Spree Taxon Controller instead of API Taxon Controller
...
Add tests for reordering taxons
2023-03-07 13:22:59 +11:00
Maikel Linke
797b98d686
Remove Rails 5.0 controller spec workaround
...
We added a method to work around a bug. But that's not needed any more.
2023-03-07 08:46:36 +11:00
Maikel Linke
3dc3ebe584
Correctly include order id in return auth spec
...
The route to update a return authorization must include the order number
as id:
/admin/orders/:order_id/return_authorizations/:id(.:format)
The spec only worked because the controller's ivars were not reset
between requests and the order was already set. But Rails 7 will reset
the ivars and it failed finding the order without a given id.
2023-03-07 08:46:36 +11:00
Jean-Baptiste Bellet
a7644f8e8b
Update spec: can edit OC even if variant in subscription has been deleted
2023-03-06 17:12:09 +01:00
jibees
5dd2737811
Merge pull request #10517 from openfoodfoundation/dependabot/bundler/rubocop-1.48.0
...
Bump rubocop from 1.47.0 to 1.48.0
2023-03-06 15:23:25 +01:00
filipefurtad0
6d05d57846
Fixes spec when introducing invalid instagram link
...
It seems that only the slash at the end of the address is making it invalid, which does not correspond to the error message. This is a separate issue.
2023-03-06 15:02:49 +01:00
Jean-Baptiste Bellet
d9b534b829
+ update spec as well
2023-03-06 14:52:32 +01:00
Jean-Baptiste Bellet
ac739108a2
Improve readability by generating search string for ransack
2023-03-06 11:31:36 +01:00
dependabot[bot]
a78768c291
Bump rubocop from 1.47.0 to 1.48.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.47.0 to 1.48.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.47.0...v1.48.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-06 10:02:43 +00:00
Neal Chambers
3f3ae97a40
Add tests for reordering taxons
2023-03-06 18:57:02 +09:00
binarygit
ae166ae220
Fix: User does not get stuck when going backwards while creating new ent
2023-03-06 09:29:04 +01:00
binarygit
533f7048bf
[Enterprise->Create] Show correct error message when user inputs url in instagram field
2023-03-06 09:29:04 +01:00
Neal Chambers
e399e27a7d
Merge remote-tracking branch 'origin/fix_taxonomy' into fix_taxonomy
2023-03-06 15:09:13 +09:00
Neal Chambers
63ba3defec
Use Spree Taxon Controller instead of API Taxon Controller
2023-03-06 15:07:52 +09:00
Maikel
b9a7ff903f
Merge pull request #10494 from filipefurtad0/test_xlsx_reports
...
Adds coverage for CSV and XLSX file download
2023-03-06 15:00:56 +11:00
Maikel
fc6b61fc87
Merge pull request #10503 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.3
...
Bump @floating-ui/dom from 1.2.1 to 1.2.3
2023-03-06 11:52:38 +11:00
Jean-Baptiste Bellet
131772f7b2
Variant can be "not available": next and don't update its estimate price
2023-03-03 15:07:10 +01:00
Jean-Baptiste Bellet
440e776e3a
fee_calculator can be retrieved outside subscription_line_items iteration
2023-03-03 15:05:07 +01:00
filipefurtad0
56b9c28955
Splits test cases into respective context blocks
...
Reduces code
2023-03-03 11:39:03 +00:00
Jean-Baptiste Bellet
c34942dbf0
Display special_instructions of order as emphasized text if present
...
+ update spec as well
2023-03-03 11:12:11 +01:00
Jean-Baptiste Bellet
2814b1f399
Update all locales with the latest Transifex translations
2023-03-03 09:35:40 +01:00
Konrad
0e13e5408f
Merge pull request #10467 from abdellani/fix_hub_supplier_can_control_shipping_payment_method
...
limit users who can update shipping/payment method of an order cycle
2023-03-03 09:27:37 +01:00
Maikel Linke
12906d1e13
Explicitely touch instead of noop save
...
When calling `save!` without changing any attributes then Rails doesn't
always touch other records because nothing changed. So I changed the
spec to `touch` explicitely and it turns out that everything passes.
Tada, our code seems correct and it was only the spec which seemed
broken in Rails 7.
2023-03-03 12:51:12 +11:00
Maikel Linke
103bc50bdc
Make spec robust on very fast computers
...
I didn't observe it but if the spec code would run within the same
millisecond then we wouldn't be able to observe a change to
`updated_at`. Time travel solves this potential problem.
2023-03-03 12:51:12 +11:00
Maikel Linke
b6cccc2e1d
Mark broken specs, possible broken caching
...
I found this because Rails 7 converts timestamps to database precision
straight away. While we may have some broken logic in the code, most of
these cases may just be broken spec code. Watch this space.
2023-03-03 12:34:55 +11:00
Maikel Linke
918e583d01
Account for Rails 7 rounding in time spec
...
Storing a timestamp to the database has less accuracy than a Ruby Time
object. So `updated_at` changes after being written and loaded from the
database. Rails 7 accounts for that by rounding it in the model already
before it's written to the database. That made one spec fail.
2023-03-03 12:34:55 +11:00
Maikel
6371f7eff6
Merge pull request #10474 from abdellani/fix-customer-can-checkout-non-matching-shipping-and-product-categories
...
Fix: Customers can checkout with non-matching shipping and product categories
2023-03-03 11:27:11 +11:00
Filipe
60bea89f5c
Merge pull request #10135 from abdellani/fix_when_user_deletes_a_shipping_method_existing_orders_are_updated_with_a_random_shipping_method
...
Fix When user deletes a shipping method existing orders are updated with a random shipping method
2023-03-02 20:03:59 +00:00
Jean-Baptiste Bellet
7b8ccccdc3
display_name can actually be null or empty: consider them as equal
2023-03-02 17:15:57 +01:00
dependabot[bot]
fb01a6e244
Bump devise from 4.8.1 to 4.9.0
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.8.1 to 4.9.0.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.8.1...v4.9.0 )
---
updated-dependencies:
- dependency-name: devise
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 14:47:11 +00:00
jibees
f88689e45f
Merge pull request #10469 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.6
...
Bump sidekiq from 7.0.5 to 7.0.6
2023-03-02 15:32:17 +01:00
jibees
1c1a7ffe9b
Merge pull request #10444 from openfoodfoundation/dependabot/bundler/devise-i18n-1.10.3
...
Bump devise-i18n from 1.10.2 to 1.10.3
2023-03-02 15:30:01 +01:00
dependabot[bot]
0cae069769
Bump @floating-ui/dom from 1.2.1 to 1.2.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.1 to 1.2.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:45:36 +00:00
jibees
0aa11581af
Merge pull request #10502 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-7.3.0
...
Bump @hotwired/turbo from 7.2.5 to 7.3.0
2023-03-02 13:44:20 +01:00
dependabot[bot]
4d72c807ea
Bump devise-i18n from 1.10.2 to 1.10.3
...
Bumps [devise-i18n](https://github.com/tigrish/devise-i18n ) from 1.10.2 to 1.10.3.
- [Release notes](https://github.com/tigrish/devise-i18n/releases )
- [Changelog](https://github.com/tigrish/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tigrish/devise-i18n/compare/v1.10.2...v1.10.3 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:43:57 +00:00
dependabot[bot]
f182712188
Bump sidekiq from 7.0.5 to 7.0.6
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 12:43:45 +00:00
jibees
1171577d5d
Merge pull request #10489 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.2
...
Bump sidekiq-scheduler from 5.0.1 to 5.0.2
2023-03-02 13:42:54 +01:00
jibees
d05522c21c
Merge pull request #10472 from openfoodfoundation/dependabot/bundler/omniauth_openid_connect-0.6.1
...
Bump omniauth_openid_connect from 0.6.0 to 0.6.1
2023-03-02 13:42:37 +01:00
jibees
cbdb3c2834
Merge pull request #10504 from openfoodfoundation/dependabot/bundler/rubocop-1.47.0
...
Bump rubocop from 1.46.0 to 1.47.0
2023-03-02 11:12:46 +01:00
dependabot[bot]
87c3165a24
Bump rubocop from 1.46.0 to 1.47.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.46.0...v1.47.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 10:02:09 +00:00
dependabot[bot]
81e96298b5
Bump @hotwired/turbo from 7.2.5 to 7.3.0
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 7.2.5 to 7.3.0.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/v7.2.5...v7.3.0 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-02 09:57:36 +00:00
binarygit
fd81429f39
Specify weight, height, width and depth as numeric field
2023-03-01 16:32:18 +01:00
filipefurtad0
b99383185b
Adds coverage for PDF file download
2023-03-01 14:32:35 +00:00
filipefurtad0
66485e2e16
Adds coverage for XLSX file download
2023-03-01 14:32:35 +00:00
filipefurtad0
c1b60d88d6
Adds coverage for CSV file download
2023-03-01 14:32:28 +00:00
dependabot[bot]
b734067785
Bump omniauth_openid_connect from 0.6.0 to 0.6.1
...
Bumps [omniauth_openid_connect](https://github.com/m0n9oose/omniauth_openid_connect ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/m0n9oose/omniauth_openid_connect/releases )
- [Changelog](https://github.com/omniauth/omniauth_openid_connect/blob/master/CHANGELOG.md )
- [Commits](https://github.com/m0n9oose/omniauth_openid_connect/compare/v0.6.0...v0.6.1 )
---
updated-dependencies:
- dependency-name: omniauth_openid_connect
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-01 14:22:38 +00:00
jibees
e7bf912a23
Merge pull request #10490 from openfoodfoundation/dependabot/bundler/puma-6.1.1
...
Bump puma from 6.1.0 to 6.1.1
2023-03-01 15:14:57 +01:00
Jean-Baptiste Bellet
50bc48c96f
Introduce some specs around searching in BOM
2023-03-01 14:54:46 +01:00
Jean-Baptiste Bellet
8ad532c41a
Can search bill_address:phone, firstname, lastname and distributor:name
2023-03-01 14:54:46 +01:00
Jean-Baptiste Bellet
ebd5d706c2
Add search input
...
Actually this only search for `order_email` or `order_number` or `product_name` or `supplier_name`
+ Improve display by reduce each columns width
2023-03-01 14:40:12 +01:00
jibees
b07a0fca50
Merge pull request #10498 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.8.0
...
Bump knapsack_pro from 3.7.0 to 3.8.0
2023-03-01 11:01:37 +01:00
Mohamed ABDELLANI
348f806bbe
remove load_shipping_methods
2023-03-01 10:53:03 +01:00
Mohamed ABDELLANI
89037e160c
Update app/controllers/concerns/checkout_callbacks.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-03-01 10:51:27 +01:00
Mohamed ABDELLANI
eab8e2be6c
load exclusively the shipping methods that support all the shipping categories of the line items
2023-03-01 10:51:27 +01:00
dependabot[bot]
d146684acb
Bump knapsack_pro from 3.7.0 to 3.8.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.7.0...v3.8.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-01 09:13:38 +00:00
Jean-Baptiste Bellet
08e23023b3
Make label clickable to check/uncheck checkbox
2023-03-01 08:46:33 +01:00
Maikel
c3fe399f0c
Merge pull request #10476 from mkllnk/flaky-index-spec
...
Stabilise flaky spec with defined enterprise order
2023-03-01 10:05:44 +11:00
Maikel
182e5bd0ee
Merge pull request #10493 from jibees/10492-background-reports-background_reports-breaks-pdf-and-xlsx-file-download
...
Reports, `background_reports` feature toggle activated: Force writing file in binary mode
2023-03-01 10:00:11 +11:00
Maikel
bccee0698f
Merge pull request #10332 from jibees/8901-allow-product-description-to-show-images-in-the-shopfront
...
Shopfront: Allow product description with formatting and `<img />`
2023-03-01 09:56:41 +11:00
Konrad
11928859bc
Merge pull request #10438 from jibees/10133-update-column-dropdown-everywhere
...
Redesign old columns dropdown component to match the design of the new one
2023-02-28 20:22:00 +01:00
Konrad
6a0b9cbb76
Merge pull request #10459 from openfoodfoundation/dependabot/bundler/stripe-8.3.0
...
Bump stripe from 8.0.0 to 8.3.0
2023-02-28 19:22:50 +01:00
Jean-Baptiste Bellet
8658b1a743
Remove quick filter that search only on displayed line items
...
+ remove specs as well
2023-02-28 15:39:31 +01:00
Jean-Baptiste Bellet
075e295fc2
Force writing file in binary mode
...
```
/Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:22:in `write': "\\xFE" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
from /Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:22:in `write'
from /Users/jibees/dev/openfoodnetwork/app/jobs/report_job.rb:8:in `perform'
```
2023-02-28 15:30:14 +01:00
jibees
151f96f673
Merge pull request #10486 from mkllnk/i18n-spec
...
Remove unused Spree translation checker
2023-02-28 14:28:39 +01:00
dependabot[bot]
2d7c593fe6
Bump sidekiq-scheduler from 5.0.1 to 5.0.2
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.1 to 5.0.2.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.1...v5.0.2 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-28 10:52:14 +00:00
dependabot[bot]
5cded5ba8d
Bump puma from 6.1.0 to 6.1.1
...
Bumps [puma](https://github.com/puma/puma ) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.1.0...v6.1.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-28 09:57:59 +00:00
Maikel Linke
4f15b5a65b
Specify raised error in spec and avoid warning
...
Before it said:
```
WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<RuntimeError: Cannot use t(".legacy_translation") shortcut because path is not available>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`.
```
2023-02-28 15:44:18 +11:00
Maikel Linke
bf1cbe615f
Remove unused Spree translation checker
...
If we wanted similar functionality in the future then we would implement
it differently. At the moment, it's just unused code.
2023-02-28 15:44:18 +11:00
Maikel
890ab6796e
Merge pull request #10413 from mkllnk/reports-params
...
Fix background processing of Enterprise Fee Summary report
2023-02-28 13:07:59 +11:00
Maikel Linke
10aa7730e5
Rename user var again for clarity
2023-02-28 12:50:55 +11:00
Maikel Linke
116e844004
Stabilise flaky spec with defined enterprise order
2023-02-28 12:42:55 +11:00
Maikel Linke
16289a62f1
Rename test vars for clarity
2023-02-28 12:42:55 +11:00
Maikel Linke
e9fa360d61
Take test setup as granted and simplify
2023-02-28 12:42:55 +11:00
Maikel Linke
e6eb9412d9
Simplify owner selection in spec
...
Instead of knowing the input id generated by select2, we now rely on the
fact that the owner is in the fifth column. Both could change but this
is less code.
2023-02-28 12:42:55 +11:00
Maikel Linke
401210ef44
DRY and clarify test case
2023-02-28 12:42:55 +11:00
Maikel Linke
f484518ee5
Remove unused test enterprise
2023-02-28 12:42:55 +11:00
Mohamed ABDELLANI
066c7bb449
promote OrderManagement::Stock::Estimator.calculate_cost to a public method
2023-02-27 17:49:54 +01:00
jibees
165fb59f64
Merge pull request #10482 from anansilva/10044-fix-activemodel-errors-deprecation-warning
...
Fix deprecation warning when accessing model errors
2023-02-27 17:29:33 +01:00
Filipe
42bc9d7f82
Merge pull request #10477 from mkllnk/js-specs
...
Remove old test setup code of feature specs
2023-02-27 15:54:40 +00:00
Mohamed ABDELLANI
25d8ce1737
fix shipping methods related tests
2023-02-27 15:56:14 +01:00
jibees
f8dce4053a
Merge pull request #10473 from openfoodfoundation/dependabot/bundler/rubocop-1.46.0
...
Bump rubocop from 1.45.1 to 1.46.0
2023-02-27 15:36:53 +01:00
dependabot[bot]
c93945a111
Bump rubocop from 1.45.1 to 1.46.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.45.1 to 1.46.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.45.1...v1.46.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 14:26:22 +00:00
jibees
30b2f9164e
Merge pull request #10484 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.18.0
...
Bump rubocop-rails from 2.17.4 to 2.18.0
2023-02-27 15:21:54 +01:00
Jean-Baptiste Bellet
5208094f05
Do not bulk send invoices if order is not 'complete' or 'resumed'
...
+ update specs as well
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
8926a3f08d
Having a cleaner syntax a prefer using map() instead of forEach()
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
58ea3a10e8
Invert condition on can send invoice
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
5ca5c32da4
Factorize what could be into two methods: success and orders
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
7a1a1286d2
Factorize two reflexes into one: BulkActionsInOrdersListReflex
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
5e61aa8a77
Create the bulk send invoice action in order list
...
using the same pattern than SendConfirmationEmail action
Co-Authored-By: David Cook <david@redcliffs.net >
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
af92b9f464
Reorganize spec by dividing into two contexts: 'admin' and 'hub manager'
2023-02-27 14:30:59 +01:00
Jean-Baptiste Bellet
ffaf4a837f
Extract common behavior to BulkActionsController
2023-02-27 14:30:58 +01:00
Jean-Baptiste Bellet
c83dac58a3
Confirm line items deletion that doesn't trigger an order cancelation
2023-02-27 11:09:59 +01:00
dependabot[bot]
f355f1ccfb
Bump rubocop-rails from 2.17.4 to 2.18.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.4 to 2.18.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.4...v2.18.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 09:57:28 +00:00
Jean-Baptiste Bellet
166e2f525e
New design uses lowercase for component title
...
and specify clicking inside the dropdown
2023-02-27 09:56:48 +01:00
Ana Nunes da Silva
d70c34fbd0
fix deprecation warning when accessing model errors
2023-02-26 21:04:16 +00:00
Konrad
27630a4304
Merge pull request #10442 from mkllnk/enterprise-fee-summary-report
...
Report deleted fees in Enterprise Fee Summary
2023-02-26 19:28:01 +01:00
vviekk
913f8bbad0
Addressing comments
2023-02-26 15:50:34 +05:30
Maikel Linke
953ff2bd08
Remove more unused spec helpers
2023-02-24 15:31:18 +11:00
Maikel Linke
d7fa508b60
Remove unused matcher have_flash_message
2023-02-24 15:19:54 +11:00
Maikel Linke
815cef16cc
Remove browser test config from unit tests
...
Mailer specs still use Capybara but they don't use Javascript and don't
need this config.
2023-02-24 15:17:49 +11:00
Maikel Linke
3d5584e47c
Update outdated comment
2023-02-24 15:10:46 +11:00
Maikel Linke
cb64361096
Remove old feature spec tag
...
Nowadays all system specs are run in a real browser.
2023-02-24 15:10:19 +11:00
Maikel Linke
bba41177b4
Remove old test setup code of feature specs
...
The `js: true` tag was only used in feature specs. Some system specs
still contain that tag but they don't require this file. So it's dead
code.
2023-02-24 15:04:03 +11:00
Maikel Linke
800ccf5037
Remove unused method
2023-02-24 10:40:09 +11:00
Maikel Linke
8c7b4f73f7
Detect transaction fee even if fee name is missing
...
The Enterprise Fee Summary report is not always providing a fee name.
While that may be a bug on its own, we handle that gracefully now.
2023-02-24 10:40:09 +11:00
Maikel Linke
8b0c4ee0ac
Add unit test for failing Enterprise Fee Summary
...
I observed this data but I'm unsure about the root cause. It could be
that the SQL query fetching this data needs tweaking to return the fee
name in this case or it could be that it's not available (deleted).
In any case, I thought I document what's happening and make this
summarizer more robust before looking into the query.
2023-02-24 10:40:09 +11:00
Filipe
3ffe39d467
Merge pull request #10448 from vviekk/viv/10009
...
Fixing Enterprise creation submit button behavior
2023-02-23 16:00:53 +00:00
vviekk
956ed826a1
Adding test
2023-02-23 20:02:02 +05:30
Mohamed ABDELLANI
13383316af
fix tests
2023-02-23 08:11:11 +01:00
Mohamed ABDELLANI
28f0d69540
Update app/services/order_cycle_form.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2023-02-23 07:22:49 +01:00
Mohamed ABDELLANI
e705aa51bd
fix existing tests: OrderCycleForm expects an instance of Spree::User (and not an Enterprise)
2023-02-23 07:12:47 +01:00
Mohamed ABDELLANI
a7e6760028
limit users who can update shipping/payment method of an order cycle
2023-02-23 07:09:49 +01:00
David Cook
06d370a8ac
Update all locales with the latest Transifex translations
2023-02-23 13:00:36 +11:00
David Cook
013533f7de
Merge pull request #10397 from openfoodfoundation/dependabot/bundler/roo-2.10.0
...
Bump roo from 2.9.0 to 2.10.0
2023-02-23 10:53:50 +11:00
David Cook
d199dea5eb
Style fix: Layout/EmptyLines
2023-02-23 10:12:06 +11:00
David Cook
084211f52a
Add comments
2023-02-23 10:10:32 +11:00
Filipe
604fd75cff
Merge pull request #10247 from abdellani/sales_tax_totals_by_order
...
sales tax totals by order report
2023-02-22 20:03:45 +00:00
Konrad
8b89c8d7e0
Merge pull request #10451 from cyrillefr/Sort-properly-date-chronologically-and-not-lexicographically
...
Sort correctly in Bulk Order Managment
2023-02-22 14:39:03 +01:00
cyrillefr
e4845f4165
Add a spec for sorting in Bulk Order management
2023-02-20 21:43:05 +01:00
cyrillefr
c015b2066f
Sort correctly in Bulk Order Managment
...
Converting date to utc + iso8601 format is
sufficient to ensure proper sorting.
2023-02-20 21:41:58 +01:00
Konrad
f7f49377b4
Merge pull request #10297 from cyrillefr/convert-admin-order-cancellation-workflow-to-stimulus-reflex
...
Convert admin order cancellation workflow to stimulus reflex
2023-02-20 21:38:33 +01:00
Mohamed ABDELLANI
960dd81b76
remove customer id filter
2023-02-20 14:58:51 +01:00
Mohamed ABDELLANI
dda61d17ee
delegate distributor && order_cycle to the order in the OrderFeesHandler
2023-02-20 14:19:08 +01:00
Mohamed ABDELLANI
8ff197457e
test accessing the Sales Tax Report By Order using different roles
2023-02-20 14:19:08 +01:00
Mohamed ABDELLANI
c43834915d
sales_tax_totals_by_order report
2023-02-20 14:19:08 +01:00
Filipe
10d8e80c45
Merge pull request #10420 from anansilva/9311-remove-code-generating-receipts
...
Remove code generating receipts
2023-02-20 12:44:13 +00:00
Mohamed ABDELLANI
0738133e99
Update spec/system/admin/order_spec.rb
...
Co-authored-by: Filipe <49817236+filipefurtad0@users.noreply.github.com >
2023-02-20 09:55:29 +01:00
Mohamed ABDELLANI
15c241295e
recreate the shipping rate that refers to the original shipping method if distributor no longer support it
2023-02-20 09:55:22 +01:00
vviekk
fc951e92ac
Updating price, on_hand, on_demand validations for product import
2023-02-18 13:52:35 +05:30
jibees
4e2430ea58
Merge pull request #10454 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.5
...
Bump sidekiq from 7.0.4 to 7.0.5
2023-02-17 14:57:42 +01:00
dependabot[bot]
4661b47ede
Bump stripe from 8.0.0 to 8.3.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 8.0.0 to 8.3.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v8.0.0...v8.3.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-17 10:04:03 +00:00
Maikel Linke
e2ea4d21f4
Update translations
2023-02-17 14:12:24 +11:00
David Cook
d377300f32
Support installations with homebrew (macOS)
...
The officially recommended installation for Mac is via Homebrew.
2023-02-17 10:36:10 +11:00
David Cook
b7a3f7263b
Add script to install current node version
...
The API is conveniently exactly the same as rbenv.
2023-02-17 10:17:48 +11:00
Filipe
2f0e00370b
Merge pull request #10385 from rioug/10350-BUU-read-only-product-list-take-2
...
New product page, add missing column and handle formatting
2023-02-16 18:41:05 +00:00
dependabot[bot]
45da8fddf1
Bump sidekiq from 7.0.4 to 7.0.5
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.4 to 7.0.5.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.4...v7.0.5 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-16 18:29:21 +00:00
Filipe
b91bb8961f
Merge pull request #10434 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.4
...
Upgrade sidekiq from 6.5.8 to 7.0.4 (incl new metrics tab)
2023-02-16 18:18:17 +00:00
Filipe
5e3b0cf47c
Merge pull request #10433 from openfoodfoundation/dependabot/npm_and_yarn/rails/webpacker-5.4.4
...
Bump @rails/webpacker from 5.4.3 to 5.4.4
2023-02-16 18:05:13 +00:00
Filipe
ba46756cba
Merge pull request #10445 from cyrillefr/Remov-I18nt-keys-from-automated-tests#9499
...
Remov i18nt keys from automated tests#9499
2023-02-16 17:51:08 +00:00
Filipe
f6c9246e20
Merge pull request #10343 from jibees/9538-track-404-errors-in-bugsnag
...
Notify bugsnag on 404 errors
2023-02-16 17:45:41 +00:00
Konrad
11e9329b97
Merge pull request #10351 from rioug/9874-order-cycle-creation-fix-needless-warning-and-data-loss
...
Order cycle creation, fix needless warning and add warning to prevent data loss
2023-02-16 16:08:37 +01:00
Rachel Arnould
1a7598d96d
Merge pull request #10428 from jibees/9145-Splitcheckout,-add-error-message-when-no-shipping-methods-are-available-to-the-customer
...
SplitCheckout: improve error messages in flash banner to improve user experience
2023-02-16 15:33:12 +01:00
Jean-Baptiste Bellet
2eec3d625a
Notify bugsnag on 404 errors
2023-02-16 13:45:42 +00:00
cyrillefr
ba30606052
Remove I18n keys from consumer specs
2023-02-16 14:33:17 +01:00
cyrillefr
f6f62515b5
Remove I18n keys in system admin specs
2023-02-16 14:33:09 +01:00
cyrillefr
a75892ccc1
Remove I18n keys in support specs
2023-02-16 14:28:14 +01:00
cyrillefr
0082653170
Remove I18n keys in service specs
2023-02-16 14:28:14 +01:00
cyrillefr
cc0b23c0bd
Remove I18n keys in request specs
2023-02-16 14:28:14 +01:00
cyrillefr
b3ad5aeaca
Remove I18n keys in model specs
2023-02-16 14:28:14 +01:00
cyrillefr
ffe9756f50
Removes I18n keys in mailer specs
2023-02-16 14:27:21 +01:00
dependabot[bot]
40eb5e320b
Bump @rails/webpacker from 5.4.3 to 5.4.4
...
Bumps [@rails/webpacker](https://github.com/rails/webpacker ) from 5.4.3 to 5.4.4.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/v5.4.4/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.4.3...v5.4.4 )
---
updated-dependencies:
- dependency-name: "@rails/webpacker"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-16 11:06:29 +00:00
jibees
4e4a392a8c
Merge pull request #10443 from openfoodfoundation/dependabot/npm_and_yarn/cable_ready-5.0.0-pre10
...
Bump cable_ready from 5.0.0-pre9 to 5.0.0-pre10
2023-02-16 12:00:48 +01:00
Filipe
e3fa933699
Merge pull request #10381 from anansilva/8229-listing-orders-payment-state-cancelled-order
...
Update payment (cash/EFF) state on cancelled order
2023-02-15 12:06:38 +00:00
Jean-Baptiste Bellet
e5ca8b0ee1
Delete selected line items even if does not lead to order cancellation
2023-02-15 11:49:53 +01:00
Jean-Baptiste Bellet
cf8d9c6d07
Improve spec when deleting all items of an order
...
- Order1 has two line items
- Check other Order2 does not change its state
- Prepare context for the second spec: delete one line item of an order that does not trigger any order cancellation
2023-02-15 11:38:04 +01:00
Mikael Norlén
f645f8fc79
Improve schema method get_extra_fields
...
Use double-splat for passing options and improve examples
2023-02-15 11:14:28 +01:00
Mikael Norlén
3d06b75892
Simplify customers_with_balance spec
...
Improve variable names and use multiple expectations
2023-02-15 11:14:28 +01:00
Mikael Norlén
af23375b04
Separate Structure from JsonApiSchema
...
Class was getting too long
2023-02-15 11:14:28 +01:00
Mikael Norlén
f15a4cc943
Add autogenerated whitespaces to swagger.yml
...
These whitespaces were generated by
bundle exec rails rswag.
Might be related to a new version of rswag or
developers' trim trailing whitespace settings.
2023-02-15 11:14:28 +01:00
Mikael Norlén
e95d08cae8
Add balance to api v1 customers endpoint
...
- customers#show: Add balance (data_type: double) to customer attributes.
- customers#index: Add balance only if specified in extra_fields
query parameter: extra_fields[customer]=balance
2023-02-15 11:14:27 +01:00
Mikael Norlén
3989843a21
Add support for extra fields in JsonApiSchemas
...
As we are now supporting optional extra fields,
We need to be able to construct schemas where
extra fields are optionally included.
2023-02-15 11:14:27 +01:00
Mikael Norlén
22b1dd3232
Add support for extra_fields query parameter
...
Api now supports optional fields.
These are included with the extra_fields query param.
Syntax: extra_fields[type]=field1,field2
2023-02-15 11:14:27 +01:00
Mikael Norlén
96c0057b03
Use Customers as argument for CustomersWithBalance
...
Change argument for CustomersWithBalance from
enterprise_id to Customers collection.
We have the need to calculate balance for customers in general,
not just for customers in a given enterprise.
2023-02-15 11:14:27 +01:00
cyrillefr
78a6317c84
Remove I18n keys in reports lib specs
2023-02-15 11:08:19 +01:00
cyrillefr
fa57e37467
Remove I18n keys in User ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
7c24f6b26f
Remove I18n keys from Pay/Stripe/Chkout Ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
f9f6abf740
Remove I18n keys from Api Ctrllers spec
2023-02-15 11:08:19 +01:00
cyrillefr
e6c0dd95c4
Remive I18n keys in Admin ctrller specs
2023-02-15 11:08:19 +01:00
dependabot[bot]
ade2eda638
Bump cable_ready from 5.0.0-pre9 to 5.0.0-pre10
...
Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready ) from 5.0.0-pre9 to 5.0.0-pre10.
- [Release notes](https://github.com/stimulusreflex/cable_ready/releases )
- [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md )
- [Commits](https://github.com/stimulusreflex/cable_ready/commits )
---
updated-dependencies:
- dependency-name: cable_ready
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-15 09:57:26 +00:00
Jean-Baptiste Bellet
0a3d362282
Still improve error message for Billing address
...
```
"Bill" is a person's name, and I don't know his address
```
;)
2023-02-15 10:07:59 +01:00
Jean-Baptiste Bellet
08fb496f55
Don't need to show any ship_address errors if no ship selected nor
...
if the ship_address is the same than the billing one
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
4cea7b1957
Improve error message, and use the same than the view
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
88607a3dce
Improve bill address error message
...
"(Street + House number)" instead of "address1"
and "postcode" instead of "zipcode"
2023-02-15 09:52:24 +01:00
Jean-Baptiste Bellet
a39598d049
Reorder error messages to improve readability
...
tbs;
2023-02-15 09:52:10 +01:00
Jean-Baptiste Bellet
9a03023b6b
Replace bill_address phone by Customer phone to improve readability
...
TBS;
2023-02-15 09:44:26 +01:00
vviekk
2091eff671
Fixing Enterprise creation submit button behavior
2023-02-15 12:42:59 +05:30
David Cook
d3e0ff269f
Remove unsupported config
...
In Sidekiq v7, this field is not recognised and gets passed through to Redis, which also doesn't recognise it and crashes.
It was added to avoid filling up Redis on dev, but it's actually a Sidekiq pro option which needs to be defined on jobs, so I guess it never worked.
2023-02-15 12:22:41 +11:00
Gaetan Craig-Riou
eb67340c52
Simplify usage of UnsavedChangesController
...
Remove the need to manually bind handleSubmit to onSubmit event
2023-02-15 10:51:23 +11:00
Gaetan Craig-Riou
75ed68c9cb
UnsavedChangesController, automatically add onChange event handler to form elements
2023-02-15 10:30:52 +11:00
Maikel
255fc64fdb
Merge pull request #10383 from filipefurtad0/add_pagination_BOM_spec
...
Adds a spec on BOM pagination
2023-02-15 09:38:43 +11:00
Ana Nunes da Silva
40bc53c16b
Delete receipt printing preferences (migration)
2023-02-14 21:29:27 +00:00
Ana Nunes da Silva
6de1fdc4ff
Remove jquery-1.8.0.js
...
Some js tests fail because they are dependant on jquery and we removed
jquery-1.8.0.js. Adding jquery2 to application_spec.js instead.
2023-02-14 21:28:53 +00:00
Jean-Baptiste Bellet
d9eb97bd05
As we are in transition, angularjs dropdown component use both css classes
...
And we should specify a bit the height of the component since it's used in different context
2023-02-14 16:15:44 +01:00
Jean-Baptiste Bellet
28286a4c3e
Slightly change classes and markup to make dropdown use the new style
...
ie. `.ofn-drop-down-v2`
2023-02-14 16:15:44 +01:00
Jean-Baptiste Bellet
6ec219031d
Avoid to specifically use a label component for menu_item
...
Then, add `label` CSS rule inside `menu_item` component
2023-02-14 15:47:55 +01:00
filipefurtad0
c84ec148db
Adds a spec on BOM pagination
...
Adds coverage on bottom section of pagination
Extracts order line item creation to before block
Removes disabled option when asserting on button 2
2023-02-14 12:04:38 +00:00
jibees
eeb059ae17
Merge pull request #10435 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.119.1
...
Bump aws-sdk-s3 from 1.119.0 to 1.119.1
2023-02-14 12:29:58 +01:00
dependabot[bot]
7a5b7c4f64
Bump aws-sdk-s3 from 1.119.0 to 1.119.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.119.0 to 1.119.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 10:06:09 +00:00
dependabot[bot]
613c693774
Bump sidekiq from 6.5.8 to 7.0.4
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 6.5.8 to 7.0.4.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v6.5.8...v7.0.4 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 10:05:01 +00:00
Ana Nunes da Silva
696edac813
Remove qz gem dependency
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
f9817925aa
Remove receipt printing translations
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
3e03988d93
Remove receipt printing settings
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
bb71b281d6
Remove print ticket links
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
cf519116ee
Remove print ticket authorization
2023-02-14 08:08:20 +00:00
Ana Nunes da Silva
8dc50caaa8
Remove print ticket action
2023-02-14 08:08:20 +00:00
dependabot[bot]
f8c802ace4
Bump roo from 2.9.0 to 2.10.0
...
Bumps [roo](https://github.com/roo-rb/roo ) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/roo-rb/roo/releases )
- [Changelog](https://github.com/roo-rb/roo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/roo-rb/roo/compare/v2.9.0...v2.10.0 )
---
updated-dependencies:
- dependency-name: roo
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-14 02:59:25 +00:00
Maikel
9ea9ac99f9
Merge pull request #10356 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.1
...
Bump rspec-rails from 5.1.2 to 6.0.1
2023-02-14 13:57:38 +11:00
Gaetan Craig-Riou
1cf55cde4d
Refactor column_value, to use a giant case
...
A giant case is more readable that the previous 'smart' solution.
It also disables a couple of Rubocop checks triggered by the giant case
2023-02-14 13:36:49 +11:00
Gaetan Craig-Riou
503e0ecba1
Fix category spec as per code review
...
- Use a hardcoded string for the expected categories (taxons), and fix
taxon step up to not use default taxon
- Fix constant typo
2023-02-14 13:36:12 +11:00
Maikel Linke
4aa6898ecb
Reduce line length for easier reading
2023-02-14 12:33:29 +11:00
Maikel Linke
180434c5bd
Avoid renaming params within report
...
I changed the used parameter names within the report so that we don't
have to rename the given parameter names when the report runs. This
avoids modifying the `params` object and therefore other problems.
2023-02-14 12:33:29 +11:00
Maikel Linke
7fe913713a
Use same parameters for report job as for original
...
The Enterprise Fee Summary report modified the `params` object. So when
we pass the same `params` a second time to the report class it doesn't
find the same values. In some cases that would lead to a server error.
The next commit implements a better solution though.
2023-02-14 12:33:29 +11:00
Maikel
ecc2c7ba43
Merge pull request #10423 from mkllnk/suburbs
...
Remove unused suburbs table
2023-02-14 11:51:48 +11:00
Jean-Baptiste Bellet
32fc1eae61
Remove ship_address errors if shipping method isn't selected
2023-02-13 21:06:41 +01:00
Filipe
822f640997
Merge pull request #10427 from jibees/10417-flaky-rspec-specsystemadminproducts_specrb210
...
Fix flaky spec `spec/system/admin/products_spec.rb:210`
2023-02-13 16:39:21 +00:00
Filipe
2d0e64a7d3
Merge pull request #10426 from openfoodfoundation/dependabot/bundler/puma-6.1.0
...
Bump puma from 6.0.2 to 6.1.0
2023-02-13 15:08:25 +00:00
jibees
f5e1cbca08
Merge pull request #10321 from openfoodfoundation/dependabot/bundler/rails-6.1.7.2
...
Bump rails from 6.1.7 to 6.1.7.2
2023-02-13 14:12:39 +01:00
Jean-Baptiste Bellet
51272eef00
Actually, those two tests are in the same context
...
The diff is pretty hard to read, but i've put the two tests "removes it from the product list" and "keeps the line item on the order (admin)" under the same context and the same `before` block
2023-02-13 13:38:57 +01:00
dependabot[bot]
2f6a910a1c
Bump rails from 6.1.7 to 6.1.7.2
...
Bumps [rails](https://github.com/rails/rails ) from 6.1.7 to 6.1.7.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.1.7...v6.1.7.2 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:48:01 +00:00
jibees
9ca25df934
Merge pull request #10411 from mkllnk/paper_trail
...
Bump paper_trail from 12.1.0 to 12.3.0
2023-02-13 11:46:34 +01:00
Maikel Linke
a3e1193f28
Bump paper_trail from 12.1.0 to 12.3.0
...
No breaking changes but Rails 7 support.
2023-02-13 11:21:32 +01:00
jibees
889b132069
Merge pull request #10425 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.1
...
Bump @floating-ui/dom from 1.2.0 to 1.2.1
2023-02-13 11:18:09 +01:00
jibees
3e18445c36
Merge pull request #10424 from openfoodfoundation/dependabot/npm_and_yarn/js-big-decimal-1.4.1
...
Bump js-big-decimal from 1.3.15 to 1.4.1
2023-02-13 11:07:20 +01:00
dependabot[bot]
3c158cd061
Bump puma from 6.0.2 to 6.1.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.0.2 to 6.1.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.0.2...v6.1.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:05:55 +00:00
dependabot[bot]
c464f3a43d
Bump @floating-ui/dom from 1.2.0 to 1.2.1
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.1/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:00:15 +00:00
dependabot[bot]
84be4aec7b
Bump js-big-decimal from 1.3.15 to 1.4.1
...
Bumps [js-big-decimal](https://github.com/royNiladri/js-big-decimal ) from 1.3.15 to 1.4.1.
- [Release notes](https://github.com/royNiladri/js-big-decimal/releases )
- [Commits](https://github.com/royNiladri/js-big-decimal/compare/v1.3.15...v1.4.1 )
---
updated-dependencies:
- dependency-name: js-big-decimal
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 09:59:31 +00:00
jibees
d9d18b086c
Merge pull request #10410 from mkllnk/api-customers-order
...
Sort customers by id on API v1
2023-02-13 10:41:13 +01:00
Maikel Linke
80f015912a
Remove unused suburbs table
...
Once upon a time it was used to search for enterprises in a certain
suburb. But we let Google Maps do that these days and the feature was
removed in 2015.
* c4fb4a8510
2023-02-13 17:18:02 +11:00
Maikel
3b6202313a
Merge pull request #10422 from mkllnk/flaky-karma-specs
...
Avoid side effects in Javascript specs leading to flakiness
2023-02-13 12:37:06 +11:00
Maikel Linke
d05bb508de
Avoid flaky spec by avoiding variable name conflict
...
Specs were sharing the same variable and could influence each other.
2023-02-13 12:23:45 +11:00
Maikel Linke
02ba8c1bf5
Remove side-effect in JS specs via global var
...
The code used the global BulkProducts which was shared amongst a group
of specs. Some were resetting the `products` attribute, others weren't
and the product object of one spec was leaking into the next.
One spec was also referencing a wrong attribute and must have passed
accidentally.
2023-02-13 12:18:05 +11:00
Konrad
3c83b053ce
Merge pull request #10406 from jibees/10402-error-when-no-shipping-info-has-been-selected-in-split-checkout
...
SplitCheckout: Fix an issue raised when first time checkout user submit form without selecting shipping method
2023-02-13 00:36:04 +01:00
Maikel
64032c9207
Merge pull request #10416 from filipefurtad0/flaky_footer_spec
...
Addresses flakyness on footer links spec
2023-02-13 10:12:47 +11:00
Maikel
dee797c427
Merge pull request #10414 from openfoodfoundation/dependabot/bundler/redis-4.8.1
...
Bump redis from 4.8.0 to 4.8.1
2023-02-13 10:10:41 +11:00
Filipe
68b60a11b0
Merge pull request #10418 from openfoodfoundation/readme-patch-1
...
Update README.md
2023-02-10 14:53:20 +00:00
Sigmund Petersen
3b8f2ee4b3
Update README.md
2023-02-10 13:06:18 +01:00
Sigmund Petersen
8c91e3d8fd
Update README.md
2023-02-10 13:04:13 +01:00
Sigmund Petersen
045db5dd49
Merge pull request #10415 from openfoodfoundation/link_to_welcome_devs_board
...
Update README.md
2023-02-10 12:59:19 +01:00
Filipe
24e8c0f973
Update README.md
...
Updates footer link for the Welcome new developers board
2023-02-10 11:40:16 +00:00
filipefurtad0
761a6731db
Sets conctext: asserts within the modal
2023-02-10 11:31:18 +00:00
filipefurtad0
b1ca2c90ce
Replaces I18n.t() by visible string
...
Removes superfluous js: true
2023-02-10 11:11:10 +00:00
Filipe
cd3897db30
Update README.md
...
Updates the link to the Welcome new developers board
2023-02-10 10:54:25 +00:00
dependabot[bot]
f3ffeaf3b4
Bump redis from 4.8.0 to 4.8.1
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.8.0...v4.8.1 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-10 10:03:15 +00:00
Maikel
76c6b438b5
Merge pull request #10369 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-4.5.0
...
Bump jasmine-core from 2.4.1 to 4.5.0
2023-02-10 16:05:04 +11:00
Maikel Linke
a08c7f7823
Sort customers by id on API v1
2023-02-10 15:52:35 +11:00
dependabot[bot]
c9da3200eb
Bump rspec-rails from 5.1.2 to 6.0.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.1.2 to 6.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.1.2...v6.0.1 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-10 10:55:51 +11:00
Jean-Baptiste Bellet
b1d22f7982
Customer can be nil if first time they checkout
2023-02-09 17:11:11 +01:00
Jean-Baptiste Bellet
d65b1bb386
Fix various import issue: mock bugsnag
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
2633ee3606
Fix various import issue: taxons
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
4027eacc06
Fix various import issue: module('admin.enterprises')
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
236e77efd4
Fix various import: CurrentUser
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
a486a08bfc
Fix various import issues: currentHub
2023-02-09 16:50:40 +01:00
dependabot[bot]
292338d467
Bump jasmine-core from 2.4.1 to 4.5.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 2.4.1 to 4.5.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v2.4.1...v4.5.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-09 16:50:40 +01:00
Jean-Baptiste Bellet
1fb4e27064
Upgrade to latest 17.* node version
2023-02-09 14:00:19 +01:00
Jean-Baptiste Bellet
9f2a17c3e9
Upgrade to node 17 which requires a --openssl-legacy-provider option
...
Node 17 moved to OpenSSL3, see https://nodejs.org/en/blog/release/v17.0.0/#openssl-3-0 for more.
2023-02-09 12:54:11 +01:00
Jean-Baptiste Bellet
ac639fa283
Upgrade node to the next LTS version
...
(which is in maintenance mode, but let's be incremental to test)
2023-02-09 10:56:28 +01:00
jibees
a3278ab6d3
Merge pull request #10404 from openfoodfoundation/dependabot/bundler/rubocop-1.45.1
...
Bump rubocop from 1.44.1 to 1.45.1
2023-02-09 10:15:34 +01:00
dependabot[bot]
416a2efea9
Bump rubocop from 1.44.1 to 1.45.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.44.1 to 1.45.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.44.1...v1.45.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-09 09:03:13 +00:00
Gaetan Craig-Riou
fd278e0086
Fix bug when submitting form triggered a warning and potentially left submit button disable
...
jquery-ujs automatically disable submit button when submitting the form.
If one choose cancel on the leaving page warning, then the submit buttons
end up in a disable state, with no way to re enable them. This fix
prevent the warning from being triggered when submitting the form, so
we can't end up in the scenario described.
2023-02-08 16:28:41 +11:00
Gaetan Craig-Riou
313fdab346
Fix rubocop warnings
2023-02-08 12:04:05 +11:00
Gaetan Craig-Riou
722b04a211
Add missing collumns on new_products page
...
It also includes specs for ProductComponent
2023-02-08 12:04:05 +11:00
cyrillefr
c37564eea7
Modify spec for orders bulk cancelling
2023-02-07 15:49:56 +01:00
cyrillefr
abf90b8437
Modify spec for orders
2023-02-07 15:40:40 +01:00
cyrillefr
1682f6788d
Delete unused code
...
Delete now unused code for Angular style bulk orders cancelling
- the Angular controller file
- the bulk_cancel method from controller
- the corresponding entry in route
2023-02-07 15:40:40 +01:00
Ana Nunes da Silva
f4980fa84d
Update void payments to checkout on resumed order
2023-02-07 12:29:59 +00:00
Ana Nunes da Silva
c9e6d24eb0
Add :resume event in Spree::Payment
2023-02-07 12:27:15 +00:00
Ana Nunes da Silva
f2b407c194
Add :void scope in Spree::Payment
2023-02-07 12:27:15 +00:00
Ana Nunes da Silva
b48b3ad42b
Update: Untaken cash payments to void on cancelled order
2023-02-07 12:27:07 +00:00
cyrillefr
597e9eae2b
Modify view to call Stimulus controller
...
- Also add call to a new Modal confirm component for
handling of bulk orders cancellings
2023-02-06 19:47:36 +01:00
cyrillefr
332c95dec5
Modify actual modal confirm component
...
- Need to take into account some additional customn message
2023-02-06 19:47:36 +01:00
cyrillefr
7a967715aa
Create Stimulus CancelOrder controller
2023-02-06 19:47:36 +01:00
cyrillefr
c302640644
Create a reflex that handles bulk orders cancelling
2023-02-06 19:47:36 +01:00
cyrillefr
ad0ffd2a64
Create a new service for orders bulk cancelling
2023-02-06 19:47:36 +01:00
Ana Nunes da Silva
8bd890f311
Add :checkout scope in Spree::Payment
2023-02-06 11:09:40 +00:00
Gaetan Craig-Riou
5cfedddba4
UnsavedChanges controller, disabling submit button is now optional
2023-02-01 13:46:30 +11:00
Gaetan Craig-Riou
dd876dfd8d
Order cycle form, disable the save and save and back button on page load
...
Buttons will be enabled once the form has been interacted with.
Update unsavedChanges stimulus controller to handle this. It should
still be generic enought that it can be reused.
2023-02-01 09:43:28 +11:00
Gaetan Craig-Riou
ef309c0fd0
Order cycle form, checkout options steps add user warning when leaving page and form has been changed
...
Add UnsavedChanges stimulus controller, it should be generic enough so
that it can reused somewhere else. It works with both 'beforeunload' event
and 'turbolinks:before-visit' when using turbo links.
2023-02-01 09:43:28 +11:00
Gaetan Craig-Riou
de97c59632
Order cycle exchange form, only set red border on pickup_time field if empty
...
The red border is set by setting pickup_time as $dirty, it then blocks next button and add leave page warning when it is not necessary, this is a fix for it.
2023-02-01 09:43:28 +11:00
Jean-Baptiste Bellet
634a54e3f1
Add image in description as they are now authorized
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
8f519eaf21
Factorize expects and include testing html inside modal and in description
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
dd0957fa72
Remove test no related to consumer spec
...
Furthermore, this test is more about testing the text editor (itself) which is an external library
2023-01-26 18:21:28 +01:00
Jean-Baptiste Bellet
6d68460950
Factorize sanitizer options between edition and displaying
...
by using the same `app/services/content_scrubber.rb`
2023-01-26 18:21:27 +01:00
Jean-Baptiste Bellet
79320331c0
As we trust description_html (previously sanitized), direct use HTML
...
via the AngularsJS `bind-html` attribute.
This will display formatting and images.
2023-01-26 17:44:51 +01:00
Jean-Baptiste Bellet
85d9650903
Allow img (and its attributes) to be displayed in the shopfront
2023-01-26 17:42:32 +01:00
Jean-Baptiste Bellet
970b7b6738
Allow attributes src (and alt) to display image for product description
...
on admin ie. `/admin/products/bread/edit`
2023-01-26 17:42:09 +01:00