Maikel Linke
ccc96c8725
Update translations from Transifex
2021-06-15 15:33:46 +10:00
Maikel Linke
4faf76794d
Update translations from Transifex
2021-06-11 09:44:47 +10:00
Maikel
56570ec604
Merge pull request #7755 from openfoodfoundation/transifex
...
Transifex
2021-06-11 09:41:22 +10:00
Andy Brett
4047f135f7
Merge pull request #7747 from openfoodfoundation/dependabot/bundler/pdf-reader-2.5.0
...
Bump pdf-reader from 2.4.2 to 2.5.0
2021-06-10 14:49:35 -07:00
Matt-Yorkley
690cbe3ad3
Merge pull request #7468 from mkllnk/6328-tos-tracking
...
6328 tos tracking
2021-06-10 19:48:13 +02:00
Matt-Yorkley
04e76ed506
Merge pull request #7776 from openfoodfoundation/dependabot/npm_and_yarn/ssri-6.0.2
...
Bump ssri from 6.0.1 to 6.0.2
2021-06-10 19:45:00 +02:00
Andy Brett
d22f807084
Merge pull request #7773 from Matt-Yorkley/rspec-retries
...
Set Capybara retry count to 3 and remove conditional
2021-06-10 09:52:50 -07:00
Andy Brett
75440856af
Merge pull request #7770 from openfoodfoundation/dependabot/bundler/rubocop-1.16.1
...
Bump rubocop from 1.16.0 to 1.16.1
2021-06-10 09:51:35 -07:00
dependabot[bot]
c614b92c5f
Bump ssri from 6.0.1 to 6.0.2
...
Bumps [ssri](https://github.com/npm/ssri ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases )
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md )
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: ssri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-10 16:51:16 +00:00
Andy Brett
84e3db30f1
Merge pull request #7772 from openfoodfoundation/dependabot/bundler/view_component-2.34.0
...
Bump view_component from 2.33.0 to 2.34.0
2021-06-10 09:50:42 -07:00
Matt-Yorkley
50b5fc7545
Set Capybara retry count to 3 and remove conditional
...
This is a slippery slope and there's perfectly reasonable arguments against doing this, but on a practical level I think retrying the occasional flaky spec (and adding an extra 10 seconds or so on to the build time) is categorically better than failing the build and having to restart the whole thing (potentially multiple times).
2021-06-10 11:39:05 +01:00
Matt-Yorkley
f36c01abf6
Merge pull request #7765 from mkllnk/7764-heartbeat-job
...
Avoid false alarms due to delayed HeartbeatJob
2021-06-10 11:15:42 +02:00
dependabot[bot]
d259771ce9
Bump view_component from 2.33.0 to 2.34.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.33.0 to 2.34.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.33.0...v2.34.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-10 05:11:51 +00:00
dependabot[bot]
9fd0b096bd
Bump rubocop from 1.16.0 to 1.16.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.16.0 to 1.16.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.16.0...v1.16.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-10 05:07:28 +00:00
Transifex-Openfoodnetwork
1bbc765028
Updating translations for config/locales/ru.yml
2021-06-10 05:21:49 +10:00
Transifex-Openfoodnetwork
a232722f64
Updating translations for config/locales/ru.yml
2021-06-10 05:18:45 +10:00
Andy Brett
2c1ffa929c
Merge pull request #7766 from mkllnk/schema
...
Update schema file description
2021-06-09 08:45:06 -07:00
Andy Brett
2b66d270c0
Merge pull request #7704 from coopdevs/drop-master-variant-leftovers
...
Drop product.price from /api/order_cycles/:id/products
2021-06-09 08:20:44 -07:00
Transifex-Openfoodnetwork
0e19232f45
Updating translations for config/locales/ca.yml
2021-06-09 17:22:50 +10:00
Transifex-Openfoodnetwork
f4d9e8e520
Updating translations for config/locales/es.yml
2021-06-09 17:22:39 +10:00
Transifex-Openfoodnetwork
d0041334fa
Updating translations for config/locales/en_FR.yml
2021-06-09 16:42:33 +10:00
Transifex-Openfoodnetwork
3b68d8a94e
Updating translations for config/locales/fr.yml
2021-06-09 16:41:46 +10:00
Maikel Linke
fc8e22b82e
Update schema file description
...
I ran `rake db:migrate` and Rails updated this section. Let's use or we
have to constantly checkout the schema after migrations or we'll have
unrelated changes in future pull requests.
2021-06-09 16:02:05 +10:00
Maikel
6caae9e886
Merge pull request #7694 from coopdevs/split-confirm-order-job
...
Split ConfirmOrderJob to avoid blocking DJ worker
2021-06-09 14:11:10 +10:00
Andy Brett
d145d3a8ec
add create/delete specs for admin and non-admin users
2021-06-09 14:06:55 +10:00
Andy Brett
d4e9c0afdc
spec TOS service object
2021-06-09 14:06:55 +10:00
Andy Brett
e0cdf4ff49
refactor to TOS service
2021-06-09 14:06:54 +10:00
Andy Brett
a4bb697787
add spec for trying to create TOS with no file
2021-06-09 14:06:54 +10:00
Maikel Linke
3e2f81d640
Add helper to view spec needing it
2021-06-09 14:06:54 +10:00
Andy Brett
768c56400c
add TOS helper to application_controller.rb
2021-06-09 14:06:54 +10:00
Maikel Linke
af314cbbdf
Allow fast checkout without re-accepting old terms
...
We did that for the shop's terms already and now do it for the platform
terms as well.
2021-06-09 14:06:54 +10:00
Maikel Linke
17a3d23d68
Handle user clicking upload button early
2021-06-09 14:06:54 +10:00
Maikel Linke
e3be519b25
Style TOS page to be usable
...
It's not pretty but only used by instance managers, very rarely.
2021-06-09 14:06:54 +10:00
Maikel Linke
51ad8f8065
Remove old UI to edit Terms of service
...
It's now completely replaced by file uploads on a separate page.
2021-06-09 14:06:54 +10:00
Maikel Linke
960b829ece
Link to last uploaded Terms of service
2021-06-09 14:06:54 +10:00
Maikel Linke
23999c96bf
Unify all links to platform Terms of service
...
DRY code and have more consistency. We always use "Terms of service" now
and not "Terms of Service" or "Terms and conditions". The latter is used
for the shop's terms, not the platform terms.
2021-06-09 14:06:54 +10:00
Maikel Linke
3b3ba70670
Safeguard deletion of ToS with alert
2021-06-09 14:06:54 +10:00
Maikel Linke
690118c2bd
Add delete method to terms of service files
2021-06-09 14:06:54 +10:00
Maikel Linke
3bee9cb951
Add Rails action #new to ToS
2021-06-09 14:06:54 +10:00
Maikel Linke
abe76ccf0f
Add upload of Terms of Service files
...
Admins can upload files and view the most recent (current) one.
2021-06-09 14:06:54 +10:00
Maikel Linke
ed4f61acd7
Add title to TOS config page
2021-06-09 14:06:53 +10:00
Maikel Linke
007b8cd888
Add new admin page for TOS files
...
Just the basic Rails setup without any functionality yet.
2021-06-09 14:06:53 +10:00
Maikel Linke
1f63bb15eb
Remove executable bit from spec
2021-06-09 14:06:53 +10:00
Maikel Linke
9027f8b604
Add attachment to TOS record
2021-06-09 14:06:53 +10:00
Maikel Linke
c4317c5707
Add model TermsOfServiceFile
...
We want to enable instance managers to upload TOS files.
I also added the rails_helper which is a new convention. It can contain
more Rails specific configuration we currently have in the spec_helper.
2021-06-09 14:06:09 +10:00
Maikel Linke
a0835eae54
Avoid false alarms due to delayed HeartbeatJob
...
When Sidekiq was restarted, the scheduler's time was reset and jobs were
executed later. Now we trigger the HeartbeatJob straight after a Sidekiq
boot and we shouldn't see any false alarms in our monitoring.
2021-06-09 12:05:18 +10:00
Maikel
2556921110
Merge pull request #7718 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-3.1.0
...
Bump sidekiq-scheduler from 3.0.1 to 3.1.0
2021-06-09 12:03:31 +10:00
Andy Brett
fcbe42f080
Merge pull request #7756 from openfoodfoundation/dependabot/bundler/ddtrace-0.50.0
...
Bump ddtrace from 0.49.0 to 0.50.0
2021-06-08 14:59:22 -07:00
Andy Brett
b6f6407c31
Merge pull request #7660 from jibees/7499-remove-feature-toggle-for-unit-price
...
Remove feature toggle around unit_price
2021-06-08 10:39:32 -07:00
Andy Brett
82ec04552c
Merge pull request #7693 from andrewpbrett/add-password-translation
...
Add translation keys for password messages
2021-06-08 10:35:41 -07:00
Andy Brett
fe62a0a2a7
Merge pull request #7697 from jibees/7689-trigger-a-change-when-hour/minute-inputs-are-modified
...
Datetimepicker for order cycles: add keyup event listener on hour/minute inputs
2021-06-08 10:32:07 -07:00
Andy Brett
ba6ebdee15
Merge pull request #7686 from shen-sat/7470-add-delete-action-test-to-shipping-categories-controller-spec
...
[7470] Add delete action test to ShippingCategoriesController spec
2021-06-08 10:31:26 -07:00
Andy Brett
ede966f2d1
Merge pull request #7640 from apricot12/closed_OC_bheaviour
...
Checkout made to redirect to shop front when OC closed
2021-06-08 10:30:13 -07:00
Andy Brett
74d93e324c
Merge pull request #7661 from romale/products_import_date_translation
...
Missed import_date translation key
2021-06-08 10:26:13 -07:00
Andy Brett
37b3f7aa3f
Merge pull request #7743 from openfoodfoundation/dependabot/bundler/test-unit-3.4.4
...
Bump test-unit from 3.4.2 to 3.4.4
2021-06-08 10:05:01 -07:00
Matt-Yorkley
9921e9c72b
Merge pull request #7754 from Matt-Yorkley/stripe-issues
...
Stripe 3DS issues
2021-06-08 11:33:54 +02:00
dependabot[bot]
6edb80ea29
Bump ddtrace from 0.49.0 to 0.50.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.49.0 to 0.50.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.49.0...v0.50.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-08 05:10:49 +00:00
Matt-Yorkley
15b386bce3
Set :execute_threed option to explicitly handle 3DS responses
2021-06-07 22:48:54 +01:00
Transifex-Openfoodnetwork
225edbf745
Updating translations for config/locales/fr_CA.yml
2021-06-08 07:13:36 +10:00
Transifex-Openfoodnetwork
e8fb5d39a1
Updating translations for config/locales/en_CA.yml
2021-06-08 06:39:23 +10:00
Matt-Yorkley
3544b7de7a
Remove Stripe Decorator
...
The method being overridden here is the same in the upstream
2021-06-07 20:44:58 +01:00
Jean-Baptiste Bellet
e3f56556cf
Remove feature toggle around unit_price and enable it
2021-06-07 20:53:45 +02:00
Matt-Yorkley
8e0a84a502
Merge pull request #7729 from Matt-Yorkley/delayed-cleanup
...
Delayed::Cleanup
2021-06-07 19:11:37 +02:00
dependabot[bot]
90f1e3a80d
Bump pdf-reader from 2.4.2 to 2.5.0
...
Bumps [pdf-reader](https://github.com/yob/pdf-reader ) from 2.4.2 to 2.5.0.
- [Release notes](https://github.com/yob/pdf-reader/releases )
- [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG )
- [Commits](https://github.com/yob/pdf-reader/compare/v2.4.2...v2.5.0 )
---
updated-dependencies:
- dependency-name: pdf-reader
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-07 05:42:29 +00:00
Matt-Yorkley
82e38b0156
Merge pull request #7623 from Matt-Yorkley/order-contents
...
Use OrderContents to update line items
2021-06-05 17:11:45 +02:00
Andy Brett
640aa11f3b
Merge pull request #7744 from luisramos0/byebug
...
Move byebug to test gem group so we can use it in specs
2021-06-04 13:17:43 -07:00
Luis Ramos
b939a292df
Move byebug to test gem group so we can use it in specs
2021-06-04 20:59:50 +01:00
Matt-Yorkley
099ef5d358
Add more explicit tests on updating shipping fees in Api::ShipmentsController
2021-06-04 18:19:27 +01:00
dependabot[bot]
6de0682439
Bump test-unit from 3.4.2 to 3.4.4
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.4.2 to 3.4.4.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.4.2...3.4.4 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-04 16:57:41 +00:00
Matt-Yorkley
efcf71fd2b
Use OrderContents in cart spec test setups
2021-06-04 17:26:49 +01:00
Matt-Yorkley
acf7c0c4d8
Use :order_with_totals factory in CustomersController spec
2021-06-04 17:10:50 +01:00
Matt-Yorkley
443b180f32
Update order totals in :order_with_totals factory
2021-06-04 17:10:50 +01:00
Matt-Yorkley
3222d4980d
Improve comment on #ensure_updated_shipments
2021-06-04 17:10:50 +01:00
Matt-Yorkley
e246eed99d
Move #restart_chceckout_flow out of Order class
2021-06-04 17:10:50 +01:00
Matt-Yorkley
b69d61dd77
Remove #order_update! call from method used in order after_save callbacks
...
This method gets called twice every time we save a completed order, calling order_update! twice...
2021-06-04 17:10:50 +01:00
Matt-Yorkley
2d76c2730a
Update shipment updating
2021-06-04 17:10:50 +01:00
Matt-Yorkley
6b364dc420
Update specs on shipping fee changes and mark as pending
...
The shipping fee and it's tax actually don't get updated correctly here (in master).
2021-06-04 17:10:50 +01:00
Matt-Yorkley
d5b20d5446
Add specs for Order#ensure_updated_shipments
2021-06-04 17:10:50 +01:00
Matt-Yorkley
05c001807e
Add variant override specs for Stock::AvailabilityValidator
2021-06-04 17:10:50 +01:00
Matt-Yorkley
011da05712
Add more test coverage to OrderContents
2021-06-04 17:10:50 +01:00
Matt-Yorkley
2e96982e60
Refactor conditional
...
CartService#populate already returns the value of the #valid? method by default.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
6abe0b375c
Refactor stock levels check in CartController
2021-06-04 17:10:50 +01:00
Matt-Yorkley
dc6be6f06b
Don't resubmit the whole cart contents for no reason.
...
There's a couple of places where this was causing a cart update submission where it wasn't needed, eg the items had not actually changed. The conditional here was designed to stop that from happening, but it was actually passing every time (the conditional logic was not actually catching the case it was supposed to).
This is really expensive!
2021-06-04 17:10:50 +01:00
Matt-Yorkley
47e2976fd1
Update CartService specs
2021-06-04 17:10:50 +01:00
Matt-Yorkley
38ce9eb0c4
Update line item removal in CartService when the line item doesn't exist
2021-06-04 17:10:50 +01:00
Matt-Yorkley
3b52b173e8
Delete more dead code in CartService
2021-06-04 17:10:50 +01:00
Matt-Yorkley
b8ccee5f30
Simplify use of #to_i in variant data hash
2021-06-04 17:10:50 +01:00
Matt-Yorkley
0cfe7fdc45
Move required logic into OrderContents and improve spec
2021-06-04 17:10:50 +01:00
Matt-Yorkley
42ff2307fa
Update specs that use removed #add_variant and #remove_variant methods in test setup
2021-06-04 17:10:50 +01:00
Matt-Yorkley
b25e7fcb89
Delete tests for removed Order #add_variant and #remove_variant methods
2021-06-04 17:10:50 +01:00
Matt-Yorkley
79aebed40e
Bring OrderContents#update_cart tests from upstream and tidy up
2021-06-04 17:10:50 +01:00
Matt-Yorkley
f5c08baabb
Use OrderContents in LineItemsController and move enterprise fee updating logic
2021-06-04 17:10:50 +01:00
Matt-Yorkley
a883b2cf63
Remove dead code CartService#cart_remove
2021-06-04 17:10:50 +01:00
Matt-Yorkley
398d4b2612
Tidy up public interface of CartService
...
We don't need this extra hash to be passed around
2021-06-04 17:10:50 +01:00
Matt-Yorkley
4a7c0e8297
Remove variant early if we're deleting them and they're already loaded
2021-06-04 17:10:50 +01:00
Matt-Yorkley
67df6728f6
Fix Order line items association definition
...
Populating the cart was throwing an "Association Mismatch" error D:
2021-06-04 17:10:50 +01:00
Matt-Yorkley
0178cd7530
Adapt OrderContents to allow use with frontend cart service and updating :max_quantity
...
The cart service and it's surrounding logic is a bit messy, as it jumps through hoops to add extra logic for the :max_quantity attribute used with the "group buy" feature.
This is the last bit of code where an order's line items could be changed where we were not using OrderContents.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
cb92231835
Clarify behavior via variable names
...
This is a small semantic thing to clarify that we're not adding to / incrementing the quantity here, we're setting it to the given value. In other places where we change line items on an order we are actually adding the given value to the existing quantity.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
6e8fd3c3f8
Simplify CartService interface
...
There's only one place this method is called, and the "overwrite" argument is always explicitly true. It doesn't need to be there if it's mandatory.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
6451ef173c
Use OrderContents when removing line items with soft-deleted variants in CartService
2021-06-04 17:10:50 +01:00
Matt-Yorkley
7af5e8931f
Adapt OrderContents for use with BulkLineItemsController#update
2021-06-04 17:10:50 +01:00
Matt-Yorkley
9045cc7d65
Use OrderContents in CartService for removing line items from cart
2021-06-04 17:10:50 +01:00
Matt-Yorkley
5ff8436c1a
Adapt OrderContents#remove to allow deleting line item without passing a quantity
2021-06-04 17:10:50 +01:00
Matt-Yorkley
a5ccaf9595
Remove unnecessary code in BulkLineItemsController
...
This method isn't called from anywhere else
2021-06-04 17:10:50 +01:00
Matt-Yorkley
423c140670
Remove pointless currency code in Order and CartService
...
The currency will always be the currency of the variant, there's no need to pass this value around.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
e8ef183623
Delete dead code Order#set_variant_attributes
2021-06-04 17:10:50 +01:00
Matt-Yorkley
000e2c07f8
Use OrderContents in OrdersController
2021-06-04 17:10:50 +01:00
Matt-Yorkley
c1c69b00b4
Update order explicitly in OrderSyncer
2021-06-04 17:10:50 +01:00
Matt-Yorkley
d5edf03042
Update reports_spec test setup
2021-06-04 17:10:50 +01:00
Matt-Yorkley
305ac037fe
Use OrderContents in customers controller spec
2021-06-04 17:10:50 +01:00
Matt-Yorkley
23910dbab4
Use OrderContents in BulkLineItemsController
...
We should move towards *all* operations on an order's line items being done exclusively through this service.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
632f4228f0
Bring in line item fetching refactor
2021-06-04 17:10:50 +01:00
Matt-Yorkley
1268cb565c
Extract method
2021-06-04 17:10:50 +01:00
Matt-Yorkley
c55e47f6af
Remove superfluous updates in OrderFeesHandler
2021-06-04 17:10:50 +01:00
Matt-Yorkley
03fc63ad14
Remove #order_update! from line item after_save callback
2021-06-04 17:10:50 +01:00
Matt-Yorkley
a124141537
Move Shipment#line_items to private
2021-06-04 17:10:50 +01:00
Matt-Yorkley
0fabb5bc2f
Don't pluck variant_ids multiple times (once for each line item)
2021-06-04 17:10:50 +01:00
Matt-Yorkley
1fff81c214
Remove call to OrderInventory#verify
...
This already gets called in after_save and after_destroy in Spree::LineItem.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
67264c047f
Delete dead code #editable_by?
...
This is junk Spree code from 2010. 11 years old! The method that previous called this was removed long ago...
2021-06-04 17:10:50 +01:00
Matt-Yorkley
34eaf6f0f2
DRY shipment updating
2021-06-04 17:10:50 +01:00
Matt-Yorkley
8405a7672d
Bring in shipment updating
2021-06-04 17:10:50 +01:00
Matt-Yorkley
66a3246a23
Move order updating
2021-06-04 17:10:50 +01:00
Matt-Yorkley
34482f6710
Bring OrderContents#update_cart from Spree 2.2
2021-06-04 17:10:50 +01:00
Matt-Yorkley
f550d1e9f3
Bring Order#ensure_updated_shipments from Spree 2.2
2021-06-04 17:10:50 +01:00
Matt-Yorkley
d99e598e7a
Delete dead code in CartController
...
The two conditionals in #populate_variant_attributes here are never actually true, so the subsequent code paths are never reached.
2021-06-04 17:10:50 +01:00
Matt-Yorkley
eb59b691d8
Move hash parsing outside of order lock
2021-06-04 17:10:50 +01:00
Matt-Yorkley
d5d76d9b9a
Move private controller methods to private
2021-06-04 17:10:50 +01:00
Andy Brett
3c933befbb
Merge pull request #7607 from luisramos0/rails6_select2_upgrade
...
[Rails 6.1] Upgrade thor
2021-06-04 07:45:47 -07:00
Andy Brett
fc4a40ec8b
Merge pull request #7668 from openfoodfoundation/dependabot/bundler/stripe-5.33.0
...
Bump stripe from 5.32.1 to 5.33.0
2021-06-04 07:45:02 -07:00
Andy Brett
d197b81351
Merge pull request #7606 from luisramos0/deprecation
...
[Rails 6.1] Fix deprecation warning in rails 6.0
2021-06-04 07:42:50 -07:00
Andy Brett
b1f619a90a
Merge pull request #7715 from openfoodfoundation/dependabot/bundler/activemerchant-1.120.0
...
Bump activemerchant from 1.119.0 to 1.120.0
2021-06-04 07:40:24 -07:00
Andy Brett
f70c1f0644
Merge pull request #7611 from luisramos0/rails61_arel
...
[Rails 6.1] Adapt code to circunvent security constraint on rails 6.1
2021-06-04 07:36:23 -07:00
Andy Brett
b23530be4c
Merge pull request #7736 from Matt-Yorkley/ssl-in-dev
...
Remove Spree::Config[:allow_ssl_in_development_and_test]
2021-06-04 07:21:05 -07:00
dependabot[bot]
1fe74c9690
Bump activemerchant from 1.119.0 to 1.120.0
...
Bumps [activemerchant](https://github.com/activemerchant/active_merchant ) from 1.119.0 to 1.120.0.
- [Release notes](https://github.com/activemerchant/active_merchant/releases )
- [Changelog](https://github.com/activemerchant/active_merchant/blob/master/CHANGELOG )
- [Commits](https://github.com/activemerchant/active_merchant/compare/v1.119.0...v1.120.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-04 14:20:09 +00:00
Andy Brett
5d39155519
Merge pull request #7739 from openfoodfoundation/dependabot/bundler/rails-6.0.3.7
...
Bump rails from 6.0.3.6 to 6.0.3.7
2021-06-04 07:18:59 -07:00
Pau Perez
dfe83e5c51
Do not return master variant in api/ocs/products
...
`product.master` seems to always be `null` on
/api/v0/order_cycles/:id/products JSON response. That's because the
first of the underlying AR relation,
`order_cycle.variants_distributed_by(distributor)`, does not include
master variants. They are not in OC exchanges.
2021-06-04 12:10:52 +02:00
Pau Perez
e7166ba5d4
Drop product.price from /api/ocs/:id/products
...
Its serializer it's only used by this endpoint and
app/assets/javascripts/templates/shop_variant.html.haml doesn't rely on
the response's product.price but the variant's price.
Because our DB schema allows NULL on spree_prices.amount, a master
variant without a price can cause the shopfront not to load products.
This was the case in
https://app.bugsnag.com/yaycode/openfoodnetwork-uk/errors/60adfcc31cf9740007f82fc9 .
2021-06-04 12:10:52 +02:00
dependabot[bot]
b6c9d4d6a9
Bump rails from 6.0.3.6 to 6.0.3.7
...
Bumps [rails](https://github.com/rails/rails ) from 6.0.3.6 to 6.0.3.7.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v6.0.3.6...v6.0.3.7 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-04 05:30:32 +00:00
Maikel
0c92a594f4
Merge pull request #7717 from coopdevs/fix-docker-jemalloc-sidekiq
...
Fix docker Jemalloc + Sidekiq setup
2021-06-04 13:16:53 +10:00
Maikel
4dacdb180f
Merge pull request #7617 from luisramos0/layout61
...
[Rails 6.1] Make admin layout path relative
2021-06-04 12:26:40 +10:00
Andy Brett
c1ad4243bb
Update all locales with the latest Transifex translations
2021-06-03 18:21:21 -07:00
Luis Ramos
66934af579
Upgrade to thor v1
2021-06-03 20:54:55 +01:00
Andy Brett
9f3ddfc88b
Merge pull request #7735 from Matt-Yorkley/bootsnap-reloaded
...
Add bootsnap gem (again)
2021-06-03 12:54:22 -07:00
Luis Ramos
466f7030c6
Depend on select2-rails without the thor v0.14 requirement
2021-06-03 20:54:07 +01:00
Matt-Yorkley
7d38bec26d
Remove Spree::Config[:allow_ssl_in_development_and_test]
...
Unconditionally disables forced https-redirects in dev and test
2021-06-03 20:52:09 +01:00
Matt-Yorkley
67d7d225cc
Add bootsnap gem
2021-06-03 19:03:18 +01:00
Andy Brett
24edad15ae
Merge pull request #7727 from openfoodfoundation/dependabot/bundler/view_component-2.33.0
...
Bump view_component from 2.32.0 to 2.33.0
2021-06-03 09:57:36 -07:00
Andy Brett
6d56a0791f
Merge pull request #7728 from Matt-Yorkley/papertrail-deprecation
...
Remove papertrail initializer
2021-06-03 09:52:56 -07:00
dependabot[bot]
cd1d77c572
Bump view_component from 2.32.0 to 2.33.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.32.0 to 2.33.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.32.0...v2.33.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-03 16:43:45 +00:00
dependabot[bot]
69690f1e37
Bump stripe from 5.30.0 to 5.33.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.30.0 to 5.33.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.30.0...v5.33.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-03 16:43:38 +00:00
Andy Brett
2dddd625a1
Merge pull request #7554 from luisramos0/rails6
...
[Rails 6.0] Upgrade to rails 6.0
2021-06-03 09:42:33 -07:00
Matt-Yorkley
d66b6f7192
Fix InvoicesController spec and change from pending to active
2021-06-03 12:51:15 +01:00
Matt-Yorkley
ba592c1ca3
Switch JobLogger to using the default Rails logger
...
Logging in background jobs with Sidekiq all ultimately get sent to STDOUT now anyway, which is redirected to `/log/sidekiq.log` via the Sidekiq systemd service.
2021-06-03 12:48:18 +01:00
Matt-Yorkley
0ede0acc6a
Remove DelayedJob references
2021-06-03 12:45:23 +01:00
Matt-Yorkley
5b676e8f93
Remove papertrail initializer
...
This setting is now deprecated and triggers this message:
Association Tracking for PaperTrail has been extracted to a separate gem. To use it, please add `paper_trail-association_tracking` to your Gemfile. If you don't use it (most people don't, that's the default) and you set `track_associations = false` somewhere (probably a rails initializer) you can remove that line now.
2021-06-03 11:33:33 +01:00
Pau Perez
5d91f5f398
Document Redis as a requirement
2021-06-03 10:11:05 +02:00
Pau Pérez Fabregat
62959cc883
Merge pull request #7724 from openfoodfoundation/transifex
...
Transifex
2021-06-03 09:34:51 +02:00
Andy Brett
bab4b404f4
Merge pull request #7722 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.3.3
...
Bump karma from 6.3.2 to 6.3.3
2021-06-02 15:01:46 -07:00
Andy Brett
5ecd24d66a
Merge pull request #7721 from openfoodfoundation/dependabot/bundler/rubocop-1.16.0
...
Bump rubocop from 1.15.0 to 1.16.0
2021-06-02 15:00:55 -07:00
Transifex-Openfoodnetwork
db373a826b
Updating translations for config/locales/en_IE.yml
2021-06-03 02:38:20 +10:00
Shen
80ae211b72
Use correct syntax for change matcher in spec/controllers/spree/admin/shipping_categories_controller_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2021-06-02 13:17:49 +01:00
Shen Sat
99a4be134b
Add delete action test to ShippingCategoriesController spec
2021-06-02 13:17:49 +01:00
dependabot[bot]
1ddfd2a4f7
Bump karma from 6.3.2 to 6.3.3
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.3.2 to 6.3.3.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.2...v6.3.3 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-02 05:32:51 +00:00
dependabot[bot]
d972f6e041
Bump rubocop from 1.15.0 to 1.16.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.15.0...v1.16.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-02 05:12:04 +00:00
Luis Ramos
cf756c5774
Added action cable to gemfile by running bundle install
...
After rebase Action cable was missing from Gemfile.lock
2021-06-01 22:34:04 +01:00
Luis Ramos
4252bd0bb1
For some reason report helper is not available on this view now, so we call Spree::Money directly
2021-06-01 22:34:04 +01:00
Luis Ramos
cb6e626193
Remove require rails/all, this is already done in application.rb where we are loading only the rails modules we need
2021-06-01 22:34:04 +01:00
Andy Brett
77c384633b
specify payment intent ID in stripe stub
2021-06-01 22:34:04 +01:00
Luis Ramos
64de303b59
Move compass-rails back to 4.0
...
This must have been a mistake when managing initial conflicts in rails6 branch
2021-06-01 22:34:04 +01:00
Matt-Yorkley
88cae21ab4
Disable currently unused modules and add notes
...
We should migrate to ActiveStorage soon, but we're not using it yet. ActionText is cool but we also don't currently use it. ActionMailbox is not something we need at all.
2021-06-01 22:34:04 +01:00
Matt-Yorkley
66e4986944
Bring modules list from rails/all to application.rb
...
This is the default list in Rails 6.0
2021-06-01 22:34:04 +01:00
Andy Brett
b3e08b47b9
set Stripe api key directly instead of using allow
2021-06-01 22:33:12 +01:00
Luis Ramos
85508f45b4
Replace be_success on test_reponse with status 200
...
In rails 6 response.success? is not supported.
2021-06-01 22:33:12 +01:00
Luis Ramos
f07cc32be0
Remove authorization token from stripe stubs
2021-06-01 22:33:12 +01:00
Luis Ramos
2c43522bf9
change devise config to use secret_key_Base instead of secret_token as pepper
2021-06-01 22:33:12 +01:00
Luis Ramos
adf35f8e18
Fix sass-rails compass-rails compatibility problem
2021-06-01 22:33:12 +01:00
Luis Ramos
04ff4fa47c
Update to rails 6.0 and resolve Gemfile conflicts
2021-06-01 22:33:12 +01:00
Matt-Yorkley
0d30e3359f
Merge pull request #7081 from openfoodfoundation/dependabot/bundler/database_cleaner-2.0.1
...
Bump database_cleaner from 1.99.0 to 2.0.1
2021-06-01 21:59:27 +02:00
Matt-Yorkley
b1bfac5144
Update all locales with the latest Transifex translations
2021-06-01 19:10:58 +01:00
Matt-Yorkley
30e2be13f0
Update spec/lib/open_food_network/i18n_config_spec.rb
2021-06-01 18:50:04 +01:00
Luis Ramos
dc1cdf4254
Add required DB cleaner setup code
2021-06-01 18:50:04 +01:00
dependabot[bot]
c4bd9208ce
Bump database_cleaner from 1.99.0 to 2.0.1
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 1.99.0 to 2.0.1.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases )
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v1.99.0...v2.0.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-01 18:50:04 +01:00
Pau Pérez Fabregat
01f8aff3e0
Merge pull request #7716 from coopdevs/pick-up-site-name-from-env
...
Allow :site_name to be picked up from ENV vars
2021-06-01 13:50:36 +02:00
Jean-Baptiste Bellet
60f3ebca62
Check whether the changes made by the keyboard are taken into account in datetimepicker
...
- User can change minute directly with keyboard, and without closing the datetimepicker, the modification should be catch and then a label "You have unsaved changes" with the "Save changes" button should appear
2021-06-01 12:05:03 +02:00
Jean-Baptiste Bellet
0db7df6c14
Add keyup event listener on hour/minute inputs
...
- To set the date (and trigger the onChange event) when the user is typing through its keyboard
2021-06-01 12:04:55 +02:00
Pau Perez
74a8b3038a
Split ConfirmOrderJob to avoid blocking a worker
...
This unties this two email notifications so that they are picked up by
a DJ worker independently. This should avoid the blocking the worker experiences (remember we
still have a single one in all instances) when waiting between the two
deliveries. See the flamegraph:
https://app.datadoghq.com/apm/traces?end=1622015605459&paused=true&query=env%3Aproduction%20service%3Adelayed_job%20operation_name%3Adelayed_job%20resource_name%3AConfirmOrderJob%20%40duration%3A%3E%3D5s&start=1622009898303&streamTraces=true&trace=AQAAAXmngbg_woqc_QAAAABBWG1uZ2IwVkFBRHVDbWJkN25QTUVuY28&traceID=2916038355421570548&spanID=2005781139590273685 .
Overall, both operations may take longer but other jobs can be processed
in between. Also, if any of the two fails, the other won't be affected.
2021-06-01 11:43:00 +02:00
dependabot[bot]
de1d4fa4eb
Bump sidekiq-scheduler from 3.0.1 to 3.1.0
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v3.0.1...v3.1.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-06-01 05:31:12 +00:00
Pau Perez
07fd5cb29c
Configure Sidekiq in development also
2021-05-31 17:04:14 +02:00
Pau Perez
ee7da14019
Provide Redis docker container
2021-05-31 17:04:14 +02:00
Pau Perez
e5adbf1f08
Fix jemalloc installation
2021-05-31 16:54:35 +02:00
Matt-Yorkley
7f9179193e
Merge pull request #7713 from openfoodfoundation/dependabot/npm_and_yarn/ws-7.4.6
...
Bump ws from 7.4.4 to 7.4.6
2021-05-31 16:07:05 +02:00
Pau Perez
3be0e1c13a
Allow :site_name to be picked up from ENV vars
...
This mimics what we did in 6377736f4 . This way provisioning an instance
from scratch doesn't require configuring things from the backoffice,
which will simplify the roll out of
https://github.com/openfoodfoundation/ofn-install/pull/734 .
2021-05-31 15:50:54 +02:00
Pau Pérez Fabregat
18c020535a
Merge pull request #7711 from Matt-Yorkley/sidekiq
...
Sidekiq!
2021-05-31 15:11:45 +02:00
Matt-Yorkley
8d1fcc06fd
Remove logfile config
...
This setting was removed in Sidekiq 6.0, logs are handled a bit differently now. The logging works though 👍
2021-05-31 10:46:43 +01:00
Matt-Yorkley
2b6a72ffb4
Remove DelayedJob web UI
2021-05-31 10:10:36 +01:00
Pau Pérez Fabregat
157d86c94f
Merge pull request #7714 from openfoodfoundation/dependabot/bundler/test-unit-3.4.2
...
Bump test-unit from 3.4.1 to 3.4.2
2021-05-31 11:04:42 +02:00
Pau Pérez Fabregat
d41de06809
Merge pull request #7707 from openfoodfoundation/transifex
...
Transifex
2021-05-31 10:59:04 +02:00
Transifex-Openfoodnetwork
d730f21dc7
Updating translations for config/locales/en_GB.yml
2021-05-31 17:54:39 +10:00
dependabot[bot]
49dfaa20ab
Bump test-unit from 3.4.1 to 3.4.2
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.4.1 to 3.4.2.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.4.1...3.4.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-31 05:38:26 +00:00
dependabot[bot]
bfeb892cab
Bump ws from 7.4.4 to 7.4.6
...
Bumps [ws](https://github.com/websockets/ws ) from 7.4.4 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-30 21:28:21 +00:00
Matt-Yorkley
4b56422abd
Add network timeouts
...
In rare cases where Redis is being updated/restarted while a job is running, this should add some flexibility.
2021-05-29 21:07:36 +01:00
Matt-Yorkley
53e3e2b66d
Remove outdated Job test helpers
...
This logic around testing jobs is already handled by integrations with ActiveJob since Rails 4.2
2021-05-29 16:37:06 +01:00
Matt-Yorkley
834140f0a2
Don't dump massive binary PDF data into the job queue
...
Here we were rendering an entire PDF, then passing that PDF into the job queue as an *argument* containing the entire binary of the PDF in a massive string. This means the job object itself would contain that entire PDF. That's bad queueing!
We now create the PDF *during* the job (not before it), and pass simple arguments.
2021-05-29 16:06:29 +01:00
Matt-Yorkley
0d95d83ef9
Add sidekiq-scheduler to web UI
2021-05-29 13:12:33 +01:00
Matt-Yorkley
54d373c963
Enqueue scheduled jobs with sidekick-scheduler
2021-05-29 13:12:33 +01:00
Matt-Yorkley
1dfd68c691
Add sidekiq-scheduler
2021-05-29 13:12:33 +01:00
Matt-Yorkley
df9213e812
Bump port for new caching instance
2021-05-29 13:12:33 +01:00
Matt-Yorkley
03a078a3a0
Remove namespacing in cache config
2021-05-29 13:11:59 +01:00
Matt-Yorkley
11da025247
Add Sidekiq web interface
2021-05-29 13:11:59 +01:00
Matt-Yorkley
07a9da901f
Switch queue adapter to Sidekiq
2021-05-29 13:11:59 +01:00
Matt-Yorkley
4ac3853be9
Configure Sidekiq
2021-05-29 13:11:59 +01:00
Transifex-Openfoodnetwork
eae7a9978c
Updating translations for config/locales/de_DE.yml
2021-05-29 18:47:49 +10:00
Transifex-Openfoodnetwork
bdd8572fbf
Updating translations for config/locales/en_US.yml
2021-05-29 02:59:45 +10:00
Matt-Yorkley
07422dac29
Add sidekiq gem
2021-05-28 16:58:26 +01:00
jibees
088ae496cc
Merge pull request #7664 from shen-sat/7626-fix-unknown-currency-error
...
7626 fix unknown currency error
2021-05-28 16:18:04 +02:00
Pau Pérez Fabregat
c83a619082
Merge pull request #7705 from openfoodfoundation/transifex
...
Transifex
2021-05-28 15:45:58 +02:00
Transifex-Openfoodnetwork
ca7d1b111a
Updating translations for config/locales/ru.yml
2021-05-28 21:35:53 +10:00
Pau Pérez Fabregat
3c507c1727
Merge pull request #7696 from openfoodfoundation/transifex
...
Transifex
2021-05-28 13:28:39 +02:00
Jean-Baptiste Bellet
b111d24488
Update all locales with the latest Transifex translations
2021-05-28 09:12:42 +02:00
Andy Brett
4dc8b44e81
Merge pull request #7695 from coopdevs/fix-ruby-installation-dockerfile
...
Fix Rbenv and ruby-build installation to get Ruby 2.5.9
2021-05-27 11:30:31 -07:00
Andy Brett
27a9ad7bcb
Merge pull request #7698 from Matt-Yorkley/remove-eventmachine
...
Remove eventmachine gem
2021-05-27 11:30:14 -07:00
Pau Perez
fbd4d512d5
Add libssl as required by Ruby 2.5.9
...
This is a more recent libssl version in Ubuntu 20. Not related to the
libssl1.0 hack required by older Ruby versions.
2021-05-27 17:50:22 +02:00
Pau Perez
0f85db6d36
Fix Rbenv and ruby-build installation to get 2.5.9
...
This newer Ruby version can't be found on that ruby-build's branch that
we were installing. The `docker-compose build` command works again.
2021-05-27 17:50:22 +02:00
Pau Pérez Fabregat
0f78b5b315
Merge pull request #7616 from jibees/7602-unit-price-not-displaying-when-comma-is-the-decimal-separator
...
Backoffice: Unit price not displaying when comma is the decimal separator
2021-05-27 17:45:19 +02:00
Matt-Yorkley
78e3bb1acd
Remove eventmachine gem
...
This was a dependency of a dependency a long time ago...
2021-05-27 15:57:17 +01:00
Transifex-Openfoodnetwork
c5e1c057ae
Updating translations for config/locales/es.yml
2021-05-28 00:17:47 +10:00
Transifex-Openfoodnetwork
f34a3c3c02
Updating translations for config/locales/ca.yml
2021-05-28 00:17:29 +10:00
Transifex-Openfoodnetwork
546a32e97a
Updating translations for config/locales/en_FR.yml
2021-05-27 22:47:27 +10:00
Transifex-Openfoodnetwork
abd269949d
Updating translations for config/locales/fr.yml
2021-05-27 22:47:09 +10:00
Pau Pérez Fabregat
0d5f76b19e
Merge pull request #7621 from jibees/7534-upload-logo-and-promo-image-for-enterprise
...
Upload enterprise image (logo and promo): force content type to "text/plain"
2021-05-27 11:33:56 +02:00
Pau Pérez Fabregat
bfa77baae1
Merge pull request #7542 from jibees/6359-add-payment-method-description-to-invoice
...
Add payment method description to invoice
2021-05-27 11:01:07 +02:00
Pau Pérez Fabregat
a2a1aac384
Merge pull request #7604 from coopdevs/compile-with-jemalloc
...
Compile Ruby with jemalloc
2021-05-27 08:30:51 +02:00
Pau Perez
43ede7ba26
Remove libssl1.0 from Dockerfile
...
We recently removed it from production in
bd9e382fba .
2021-05-27 08:09:51 +02:00
kgericke
bb8535cb3a
add translation keys for password messages
2021-05-26 08:50:16 -07:00
Andy Brett
883e9fdf62
Merge pull request #7690 from Matt-Yorkley/ruby-259
...
Bump Ruby to 2.5.9
2021-05-26 08:41:15 -07:00
Matt-Yorkley
c625766af1
Bump Ruby to 2.5.9
2021-05-26 09:36:28 +01:00
Andy Brett
23730ab28f
Merge pull request #7683 from openfoodfoundation/dependabot/bundler/view_component-2.32.0
...
Bump view_component from 2.31.1 to 2.32.0
2021-05-25 07:36:25 -07:00
Jean-Baptiste Bellet
0c8bfea2f7
Add feature tests for upload images on enterprise registration
...
For both logo and promo images
2021-05-25 15:30:35 +02:00
Jean-Baptiste Bellet
0306732a3d
Add test for enterprise logo and promo image uploading
...
- Add a fixture image to do the upload thanks to `fixture_file_upload`
- Check the response status, the content type and the response body for both logo image and promo image
2021-05-25 15:30:29 +02:00
Jean-Baptiste Bellet
6842cbfda4
Force content type to "text/html"
...
- Force the content type to be `text/html` (instead of `application/json`)
2021-05-25 15:30:21 +02:00
Matt-Yorkley
ecb4cb31ad
Merge pull request #7599 from Matt-Yorkley/cart-rendering
...
Move line item rendering to a collection in cart page
2021-05-25 13:37:50 +02:00
Jean-Baptiste Bellet
dd47430f19
Improve unlocalizeCurrency filter to handle many cases
...
- Complete the unit test to handle all these cases.
2021-05-25 13:14:53 +02:00
Matt-Yorkley
74f27544f7
Merge pull request #7647 from andrewpbrett/default-country-codes
...
Use correct default country code
2021-05-25 11:21:34 +02:00
Matt-Yorkley
5868765087
Merge pull request #7673 from Matt-Yorkley/spree-config-caching
...
Fix clashing loggers
2021-05-25 11:09:33 +02:00
Maikel
545d64a2e5
Merge pull request #7682 from openfoodfoundation/dependabot/bundler/i18n-js-3.8.3
...
Bump i18n-js from 3.8.2 to 3.8.3
2021-05-25 14:48:19 +10:00
Matt-Yorkley
c69dee4c96
Merge pull request #7636 from psychoslave/tip/zeus
...
Remove all material related to Zeus
2021-05-25 00:10:01 +02:00
Andy Brett
b367001b95
Merge pull request #7641 from luisramos0/order_path
...
[Rails 6.1] Fix view specs
2021-05-24 14:41:32 -07:00
Andy Brett
120fc4ca42
Merge pull request #7605 from filipefurtad0/import_item_products
...
Products and Inventory import: Items units
2021-05-24 14:17:43 -07:00
Andy Brett
e4756a523a
Merge pull request #7678 from mkllnk/schema
...
Update schema syntax with Rails 5.2
2021-05-24 13:22:18 -07:00
Andy Brett
46843a5efa
Merge pull request #7662 from Matt-Yorkley/enterprise-rendering
...
Render enterprise rows as a collection
2021-05-24 09:37:58 -07:00
Matt-Yorkley
6377736f43
Allow :site_url to be picked up from ENV vars
2021-05-24 14:58:53 +01:00
Jean-Baptiste Bellet
afe97bcc96
Add tests for creating/editing product/variant cases with decimal price
2021-05-24 10:55:05 +02:00
Jean-Baptiste Bellet
8af6fedf8a
Factorize js:true as a common configuration around all tests
2021-05-24 10:55:05 +02:00
Jean-Baptiste Bellet
d8042b25e4
Add test for unlocalize currency filter
...
- Test that comma is well handle in both cases where comma is the default decimal separator or not.
2021-05-24 10:55:05 +02:00
Jean-Baptiste Bellet
f97e71d054
Add test for decimal price separated by point or comma
2021-05-24 10:55:05 +02:00
Jean-Baptiste Bellet
d066f0b94d
Enable displayable unit price for price with comma as decimal separator
...
Retrieve the current decimal separator used to display price (`I18n.toCurrency()`), and check if number is formatted with only if this is `,`. If so, remplace comma by point, to pass the check `!isNaN`, and format unit price
2021-05-24 10:55:05 +02:00
dependabot[bot]
e9d389e4f1
Bump view_component from 2.31.1 to 2.32.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.31.1 to 2.32.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.31.1...v2.32.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-24 05:51:25 +00:00
dependabot[bot]
e90403dbbe
Bump i18n-js from 3.8.2 to 3.8.3
...
Bumps [i18n-js](https://github.com/fnando/i18n-js ) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/fnando/i18n-js/releases )
- [Changelog](https://github.com/fnando/i18n-js/blob/main/CHANGELOG.md )
- [Commits](https://github.com/fnando/i18n-js/compare/v3.8.2...v3.8.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-24 05:49:51 +00:00
Matt-Yorkley
3dc3581e6b
Ensure Mail configs are applied when the app starts
...
Previously we only set these part-way through deployment, so the values could be out of sync between our ENV vars and Spree::Config (which itself is a mix of both cached values and database-persisted values).
2021-05-23 23:05:16 +01:00
Matt-Yorkley
ff82f70e9a
Remove custom logger object
...
This is handled already in Delayed::Command and Delayed::Worker
2021-05-23 23:05:16 +01:00
Andy Brett
560f462f7b
Merge pull request #7679 from mkllnk/sample-data
...
Fix sample_data by filtering params for products
2021-05-22 10:37:30 -07:00
Pau Pérez Fabregat
23b2b5ba56
Merge pull request #7563 from filipefurtad0/import_products_fixture_path
...
Adds file and fixture path to test product import
2021-05-21 10:12:20 +02:00
Maikel Linke
11cb8cbbdc
Fix sample_data by filtering params for products
...
We were passing too many parameters to the product creation. Rails 5.2
complained that products don't have a distributor. Filtering the
parameters helps.
2021-05-21 12:41:55 +10:00
Maikel Linke
41799b2663
Update schema syntax with Rails 5.2
...
The style seems to be different. This avoids a modified schema after
running rake db:migrate.
2021-05-21 11:50:34 +10:00
filipefurtad0
2f842bcbdd
Adds file and fixture path to test product import
...
Adds file and fixture path to test product import
Reverts changes on context and it descriptions
2021-05-20 20:08:47 +01:00
Matt-Yorkley
336a8b5825
Merge pull request #7671 from Matt-Yorkley/licence
...
Add Spree copyright notice
2021-05-20 18:56:16 +02:00
Andy Brett
d2f54f5bd2
Merge pull request #7666 from mkllnk/codecov
...
Stop Codecov failing good pull requests
2021-05-20 09:18:34 -07:00
Pau Pérez Fabregat
8c81c14c8d
Merge pull request #7580 from apricot12/Remove-LineItems-N+1
...
Removed N+1 queries while counting line_items
2021-05-20 11:42:14 +02:00
Matt-Yorkley
1f6d872fa5
Add Spree copyright notice
2021-05-20 10:25:48 +01:00
Jean-Baptiste Bellet
ae1b9b8dd5
Update all locales with the latest Transifex translations
2021-05-20 10:12:46 +02:00
Maikel
1e1706d371
Merge pull request #7280 from Matt-Yorkley/atomic
...
Remove atomic gem
2021-05-20 17:53:36 +10:00
Maikel Linke
5ccaa521cf
Stop Codecov failing good pull requests
...
Something doesn't quite work with our Codecov setup. It somehow thinks
that the coverage is decreasing even though it's either not changing or
even increasing.
Until those problems are resolved, let's not mark pull requests as
failed so that we can rely on the pull's overall status report.
2021-05-20 14:18:43 +10:00
Maikel Linke
90bb9870ab
Bump Codecov from 1.3.1 to 1.5.0
2021-05-20 14:17:36 +10:00
Andy Brett
70ac719725
Merge pull request #7649 from andrewpbrett/payments-when-out-of-stock
...
Check stock before doing anything related to admin payments
2021-05-19 14:45:38 -07:00
Andy Brett
08d540a761
Merge pull request #7648 from Matt-Yorkley/redis
...
Switch cache store from memcached to redis
2021-05-19 10:36:20 -07:00
Andy Brett
304a3804bc
Merge pull request #7594 from luisramos0/update_attributes
...
[Rails 6.1] Replace AR's update_attributes! with update! (and rename order.update! and adjustment.update! in the process)
2021-05-19 10:34:12 -07:00
Luis Ramos
f7726e552a
Adapt code coming from master to the new order api with update_order!
2021-05-19 10:09:42 -07:00
Luis Ramos
a1ac4e85ed
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
f8e5370b0b
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
fb560089b9
Replace usages of update_attributes! with usage of update!
2021-05-19 09:54:25 -07:00
Luis Ramos
341f6c9f62
Now that adjustment.update! has been renamed to adjustment.update_adjustment! we can use AR's update! on adjustment
2021-05-19 09:54:25 -07:00
Luis Ramos
b2e97fe1d2
Rename order.update! to order.update_order! and adjustment.update! to adjustment.update_adjustment!
2021-05-19 09:54:22 -07:00
Andy Brett
e73584fef7
remove setters from DefaultCountry service
2021-05-19 09:42:52 -07:00
Andy Brett
45ad4bbcf1
remove setting of Spree::Config country code
2021-05-19 09:33:02 -07:00
Matt-Yorkley
096847ea07
Merge pull request #7618 from openfoodfoundation/dependabot/npm_and_yarn/hosted-git-info-2.8.9
...
Bump hosted-git-info from 2.8.8 to 2.8.9
2021-05-19 13:51:01 +02:00
Pau Pérez Fabregat
faf6a37c9f
Merge pull request #7631 from openfoodfoundation/dependabot/bundler/ddtrace-0.49.0
...
Bump ddtrace from 0.48.0 to 0.49.0
2021-05-19 12:32:52 +02:00
Pau Pérez Fabregat
d4ec1bda54
Merge pull request #7652 from openfoodfoundation/dependabot/bundler/webmock-3.13.0
...
Bump webmock from 3.12.2 to 3.13.0
2021-05-19 12:32:08 +02:00
Jean-Baptiste Bellet
325b97b683
Add tests around invoice printing in PDF
...
- use PDF Reader to read pdf and get its content
- check with we print the payment description information section with the right value
2021-05-19 11:55:46 +02:00
Jean-Baptiste Bellet
7ab065e8cd
Add section at the bottom of invoice: Payment Description at Checkout
...
- If there is any payments, we use the last one to retrieve the payment method description
Use the first completed payment to display payment description
Completed is state = "checkout" or state = "completed"
Squash w/ "Add section at the bottom of invoice: Payment Description at Checkout"
Squash w "Add section at the bottom of invoice: Payment Description a"
2021-05-19 11:55:38 +02:00
Jean-Baptiste Bellet
aea0670268
Add method payment_method to get the payment method from a payment
...
- Method `payment_method_name` now use `payment_method`
2021-05-19 11:55:38 +02:00
Pau Pérez Fabregat
5560a99423
Merge pull request #7663 from openfoodfoundation/transifex
...
Transifex
2021-05-19 11:50:02 +02:00
Matt-Yorkley
0c4e191f3b
Render enterprise rows as a collection
...
Note: this is a bit like an N+1 query, but for rendering. If there are 30 enterprises, the partial file would be loaded and parsed 30 times; but if we render it as a collection it'll load the partial once and substantially improve the performance.
2021-05-19 08:48:25 +01:00
Shen Sat
cb914e4729
Change wording in create_admin_user to be more descriptive
2021-05-19 08:45:40 +01:00
Shen Sat
ab027d6af6
Change money initializer to use ENV vars instead of Spree::Config
2021-05-19 08:44:55 +01:00
Shen Sat
6a8ee544e8
Change readme to strong encourage running setup script
2021-05-19 08:44:10 +01:00
Andy Brett
2bb38619ea
Merge pull request #7656 from openfoodfoundation/dependabot/bundler/rubocop-1.15.0
...
Bump rubocop from 1.14.0 to 1.15.0
2021-05-18 13:36:56 -07:00
Andy Brett
4b352da402
Merge pull request #7630 from apricot12/persistent_flash_after_reload
...
Persistent flash after reload
2021-05-18 12:55:37 -07:00
Transifex-Openfoodnetwork
75243b8e6a
Updating translations for config/locales/en_US.yml
2021-05-19 05:54:38 +10:00
Andy Brett
7df2915fbd
add DefaultCountry service
2021-05-18 12:44:53 -07:00
Matt-Yorkley
6427a3846b
Merge pull request #7651 from openfoodfoundation/dependabot/bundler/activerecord-import-1.1.0
...
Bump activerecord-import from 1.0.8 to 1.1.0
2021-05-18 20:06:21 +02:00
Andy Brett
5169ee91ea
add comment for before_action
2021-05-18 10:42:19 -07:00
Andy Brett
5917accdd2
refactor using Extract Method
2021-05-18 10:38:35 -07:00
alex
4a5cb7f628
Missed import_date translation
2021-05-18 18:30:59 +03:00
Matt-Yorkley
5dd24623f7
Merge pull request #7479 from Matt-Yorkley/payment-callbacks
...
Update Payment after_save callback
2021-05-18 16:19:29 +02:00
Matt-Yorkley
befb6f632f
Merge pull request #7659 from openfoodfoundation/dependabot/bundler/nokogiri-1.11.4
...
Bump nokogiri from 1.11.3 to 1.11.4
2021-05-18 11:14:32 +02:00
dependabot[bot]
92e0f8349c
Bump nokogiri from 1.11.3 to 1.11.4
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.3 to 1.11.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.3...v1.11.4 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-18 08:37:29 +00:00
dependabot[bot]
ffbba01c41
Bump rubocop from 1.14.0 to 1.15.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.14.0...v1.15.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-18 05:24:48 +00:00
Pau Pérez Fabregat
5f9679655c
Merge pull request #7645 from Matt-Yorkley/stripe-payment-processing
...
Stripe payment processing
2021-05-17 16:17:21 +02:00
dependabot[bot]
6ded80d2c6
Bump webmock from 3.12.2 to 3.13.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.12.2 to 3.13.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.2...v3.13.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-17 05:51:55 +00:00
dependabot[bot]
eb3c33b091
Bump activerecord-import from 1.0.8 to 1.1.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.0.8 to 1.1.0.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.0.8...v1.1.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-17 05:51:01 +00:00
Matt-Yorkley
794216713a
Ensure payment is processed if order is in completed state
2021-05-16 23:03:07 +01:00
Matt-Yorkley
a2862e604c
Find relevant payment that matches the payment intent, not the last payment
2021-05-16 23:00:31 +01:00
Matt-Yorkley
8429da3d2a
Remove unused argument from ProcessPaymentIntent
2021-05-16 22:19:01 +01:00
Matt-Yorkley
381b0e78d5
Improve ProcessPaymentIntent specs
2021-05-16 20:14:14 +01:00
Matt-Yorkley
2e63cd8116
Add explanatory comment on payment processing flow
2021-05-16 20:11:45 +01:00
Matt-Yorkley
52e0d84238
Reload in-memory payment before checking it's new state
...
The state should have changed in the database if the payment was processed successfully, and the memoized version here will not know that without a reload.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
5725535715
Fix payment state checking
2021-05-16 20:11:45 +01:00
Matt-Yorkley
05ed98aa0c
Use :order_with_totals in ProcessPaymentIntent
...
If we just use the :order factory here, it has no line items and no total, which means when we try to push it into complete state, the #requires_payment? check fails because the order total is zero, which means the call to #process_payments is ignored
2021-05-16 20:11:45 +01:00
Matt-Yorkley
fd021d4778
Refactor payment intent status checking and return "ok" if the payment has already been processed successfully in a previous request
...
If the page is reloaded after the payment has already gone through, we can skip the processing and give a non-error response; the payment is already completed and Stripe's response confirms it was successful.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
2b9f9fce86
Fix flash session memory-effect when showing errors after payment processing
...
We're not doing a redirect after setting this flash message, so we need to ensure it's discarded after the current page load.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
81aac442f2
Improve conditional in raise_if_not_in_capture_state
2021-05-16 20:11:45 +01:00
Matt-Yorkley
16e3af9b49
Update OrderController spec
2021-05-16 20:11:45 +01:00
Matt-Yorkley
227bdd7d4c
Update ProcessPaymentIntent spec
2021-05-16 12:55:48 +01:00
Matt-Yorkley
471a7903f6
Update PaymentIntentValidator spec
2021-05-16 12:19:04 +01:00
Matt-Yorkley
37177e7207
Add test coverage to StripeSCA spec
2021-05-16 12:19:04 +01:00
Matt-Yorkley
5805104d13
Tidy up controller and add explanatory comment
2021-05-16 12:19:04 +01:00
Matt-Yorkley
e686a4f627
Move raising of errors when payment intent state != "requires_capture" out of PaymentIntentValidator service
...
When we're fetching the payment intent via PaymentIntentValidator in StripeSCA#purhcase (to capture it), we want it to fail loudly if it's not in "requires_capture" state. We're now also re-using the same PaymentIntentValidator service to check if payment processing was *successful*, in which case we need it *not* to fail loudly if the state == "succeeded", eg != "requires_capture".
2021-05-16 12:19:04 +01:00
Andy Brett
c7f80d86a8
Merge pull request #7638 from Matt-Yorkley/dead-code-order-distribution
...
Delete dead code in OrdersController#update_distribution
2021-05-15 12:40:25 -07:00
Andy Brett
19187583e1
Merge pull request #7643 from openfoodfoundation/dependabot/bundler/test-prof-1.0.5
...
Bump test-prof from 1.0.3 to 1.0.5
2021-05-15 12:28:22 -07:00
Andy Brett
f2c3b096a0
Merge pull request #7566 from luisramos0/erb
...
[Rails 6.0] Fix problem in erb template by explicitly setting format to js
2021-05-15 10:45:01 -07:00
Andy Brett
816d752dc8
Merge pull request #7439 from openfoodfoundation/dependabot/bundler/jwt-2.2.3
...
Bump jwt from 2.2.2 to 2.2.3
2021-05-15 10:36:13 -07:00
Andy Brett
0a880a2bf3
flip conditional order for performance
2021-05-15 07:08:07 -07:00
Matt-Yorkley
d6b3b0a3d3
Ensure a basic level of fault-tolerance on Redis connections
...
The default for reconnect_attempts is 0, which is not helpful! 1 is generally considered to be enough.
2021-05-15 11:36:19 +01:00
Andy Brett
ca38948e21
check stock before doing anything related to admin payments
2021-05-14 17:42:37 -07:00
Andy Brett
fe67c01e57
guard against no database, but not against .connected?
...
Similar to b22ce43efe
2021-05-14 12:56:24 -07:00
Matt-Yorkley
37053239c0
Switch cache store from memcached to redis
2021-05-14 20:46:13 +01:00
dependabot[bot]
2bb5a4b11f
Bump test-prof from 1.0.3 to 1.0.5
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.3 to 1.0.5.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.3...v1.0.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-14 05:17:23 +00:00
Maikel Linke
cea3ee4ef9
Transifex updates
2021-05-14 10:06:31 +10:00
Luis Ramos
90db52e5f5
Fix route
2021-05-14 00:14:02 +01:00
Luis Ramos
3f020ec855
Circunvent security contraint on rails 61
2021-05-14 00:13:38 +01:00
Luis Ramos
b1896733ca
Fix routes
2021-05-14 00:08:20 +01:00
Luis Ramos
3d2155b60e
Use Arel.sql to curcunvent security restriction on rails 6.1
2021-05-13 23:55:08 +01:00
Luis Ramos
a949422ac9
Adapt view spec stubs to rails 6
2021-05-13 23:28:35 +01:00
Luis Ramos
0243e5cbb8
Fix route in order view
2021-05-13 23:08:50 +01:00
Nihal Mohammed
0b12b398ba
Update spec test for the changed redirect path
2021-05-14 03:32:14 +05:30
Nihal Mohammed
122577b11b
Checkout made to redirect to shop front when OC closed
2021-05-14 02:58:41 +05:30
Andy Brett
ebdbfe0027
Merge pull request #7639 from drummer83/patch-1
...
Remove Ruby version from WIKI
2021-05-13 13:26:34 -07:00
Konrad
b680697af6
Remove Ruby version
...
Let's remove the Ruby version from the text. It changes regularly and have the link where to find it right behind it.
2021-05-13 21:16:02 +02:00
Matt-Yorkley
2e248744c0
Merge pull request #7520 from Matt-Yorkley/shipment-controller
...
Shipment controller: test coverage and improvements
2021-05-13 20:26:51 +02:00
Matt-Yorkley
82a6befce7
Delete dead code in OrdersController#update_distribution
...
I can't see any evidence that these params ever get sent to this action...
2021-05-13 15:29:53 +01:00
Mathieu Lovato Stumpf Guntz
ccef65039a
Remove all material related to Zeus
2021-05-13 12:21:58 +02:00
dependabot[bot]
e4a670da5a
Bump ddtrace from 0.48.0 to 0.49.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.48.0 to 0.49.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.48.0...v0.49.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-13 05:24:45 +00:00
Nihal Mohammed
c930b2ee60
Fix persistet flash after /cart page reload
2021-05-13 05:57:25 +05:30
Matt-Yorkley
4932e1dcb5
Merge pull request #7628 from viktorsmari/remove-distributer-sample-data
...
Remove distributer from sample_data
2021-05-12 23:53:13 +02:00
Viktor Smari
536281ec80
Remove distributer from sample_data
...
Closes #7625
2021-05-12 23:01:08 +02:00
Nihal Mohammed
367cee593f
Move eager loading line_items to controller
2021-05-13 01:12:13 +05:30
Matt-Yorkley
99cf23df26
Merge pull request #7530 from Matt-Yorkley/email-after-commit
...
Email after commit
2021-05-12 21:22:55 +02:00
Matt-Yorkley
f49d4592a0
Merge pull request #7506 from guidoDutra/5546-prevent-deleting-only-item-in-confirmed-order
...
prevent deleting only item in confirmed order
2021-05-12 21:10:09 +02:00
Pau Pérez Fabregat
7f27544acb
Merge pull request #7612 from openfoodfoundation/dependabot/bundler/actionpack-action_caching-1.2.2
...
Bump actionpack-action_caching from 1.2.1 to 1.2.2
2021-05-12 16:24:25 +02:00
Pau Pérez Fabregat
2aac44d95e
Merge pull request #7620 from openfoodfoundation/transifex
...
Transifex
2021-05-12 15:50:25 +02:00
Pau Pérez Fabregat
8f921b8b08
Merge pull request #7593 from viktorsmari/add-bullet-footer
...
Add bullet footer
2021-05-12 15:47:54 +02:00
Transifex-Openfoodnetwork
dfe485b079
Updating translations for config/locales/ru.yml
2021-05-12 17:49:31 +10:00
dependabot[bot]
ad9096b5a8
Bump hosted-git-info from 2.8.8 to 2.8.9
...
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info ) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases )
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md )
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-11 23:49:14 +00:00
Luis Ramos
b265fbf9a0
Remove initial slash from admin layout, this fixes a problem with layouts cant be loaded from absolute paths
2021-05-11 22:34:15 +01:00
Matt-Yorkley
e60a513c88
Merge pull request #7571 from coopdevs/make-specs-accurate
...
Properly mock validator and extend tests
2021-05-11 22:24:01 +02:00
Pau Pérez Fabregat
1f8e731594
Merge pull request #7596 from openfoodfoundation/transifex
...
Transifex
2021-05-11 11:56:35 +02:00
dependabot[bot]
d69ef31bf9
Bump actionpack-action_caching from 1.2.1 to 1.2.2
...
Bumps [actionpack-action_caching](https://github.com/rails/actionpack-action_caching ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/rails/actionpack-action_caching/releases )
- [Changelog](https://github.com/rails/actionpack-action_caching/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/actionpack-action_caching/compare/v1.2.1...v1.2.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-11 05:05:32 +00:00
Andy Brett
9ae7c5efbc
Merge pull request #7578 from psychoslave/master
...
Update things related to some package manager influencing setup process
2021-05-10 17:01:46 -07:00
Matt-Yorkley
902bbf7dc4
Merge pull request #7576 from Matt-Yorkley/bulk-line-items
...
Add test coverage to BulkLineItemsController actions
2021-05-11 01:47:17 +02:00
Andy Brett
d29ef0d7b1
Merge branch 'master' into make-specs-accurate
2021-05-10 16:10:33 -07:00
Luis Ramos
f29f525d90
Adapt code to circunvent security constraint on rails 6.1
2021-05-10 23:39:17 +01:00
Andy Brett
d2a3d9049f
Merge pull request #7588 from andrewpbrett/enterprise-permalink-spec
...
[Rails 6.0] Fix enterprise permalink spec
2021-05-10 15:30:45 -07:00
Luis Ramos
d308e20871
Fix deprecation warning in rails 6.0
...
Warning: Class level methods will no longer inherit scoping from create in Rails 6.1
2021-05-10 21:03:24 +01:00
filipefurtad0
0cd6c53e0d
Adds test-case on the inventory import for unit Items
2021-05-10 19:12:41 +01:00
filipefurtad0
5475b79cde
Adds test-case on the product import unit Items
2021-05-10 19:07:05 +01:00
filipefurtad0
8e24c655b0
Adds verification of inventory import on inventory page
2021-05-10 19:01:41 +01:00
filipefurtad0
bb5452ad26
Adds verification of product import on products page
2021-05-10 18:57:47 +01:00
Pau Perez
ed6b7f1ab4
Split apt packages list into a name per line
...
This super long line was hard to read.
2021-05-10 19:57:24 +02:00
Matt-Yorkley
85b8e9b51f
Merge pull request #7595 from openfoodfoundation/dependabot/bundler/factory_bot_rails-6.2.0
...
Bump factory_bot_rails from 6.1.0 to 6.2.0
2021-05-10 19:55:54 +02:00
Pau Perez
4453123944
Compile Ruby with jemalloc
2021-05-10 19:31:04 +02:00
Andy Brett
3239c893ba
Merge pull request #7590 from viktorsmari/ransack-search-deprecation
...
Ransack.search is deprecated. Use .ransack instead
2021-05-10 08:43:09 -07:00
Andy Brett
17a0063b40
Merge pull request #7402 from filipefurtad0/products_spec_add_ons
...
Adds coverage for product deletion and cloning
2021-05-10 06:26:11 -07:00
Matt-Yorkley
122ba385f7
Move line item rendering to collection in cart page
...
Improvement from upstream Spree commit. Brings a big performance boost to rendering, especially with larger numbers of items in the cart. 50%+ reduction in rendering times reported.
2021-05-10 11:50:31 +01:00
Transifex-Openfoodnetwork
75dc7af0ed
Updating translations for config/locales/en_GB.yml
2021-05-10 18:16:04 +10:00
dependabot[bot]
cb15e28cef
Bump factory_bot_rails from 6.1.0 to 6.2.0
...
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases )
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v6.1.0...v6.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-10 05:55:18 +00:00
Andy Brett
cbefa5f882
Merge pull request #7589 from andrewpbrett/order-adjustments-spec
...
[Rails 6.0] Fix order adjustments spec
2021-05-09 10:38:19 -07:00
Andy Brett
231f01dad2
fix order adjustments spec
2021-05-09 10:09:22 -07:00
Viktor Smari
c14ccdc21c
Add bullet footer
...
Left corner of the page will show the bullet warnings
2021-05-09 16:49:00 +02:00
Nihal Mohammed
fcf70c242e
edit item_count method to shorthand for improved readability
2021-05-09 18:31:26 +05:30
Andy Brett
a0476be2c9
Merge pull request #7568 from andrewpbrett/stripe-mock-js
...
[Rails 6.0] Use raw to render stripe mock js file
2021-05-08 17:46:24 -07:00
Matt-Yorkley
24a5407c8f
Merge pull request #7565 from luisramos0/rails6_success
...
[Rails 6.0] Replace be_success on test_response with status 200
2021-05-09 02:33:49 +02:00
Andy Brett
66da72ccc2
use raw to render stripe mock js
2021-05-08 17:29:38 -07:00
Viktor Smari
6a342ae368
Ransack.search is deprecated. Use .ransack instead
...
https://github.com/activerecord-hackery/ransack/pull/975
2021-05-09 01:05:37 +02:00
Andy Brett
dd851edbdc
fix enterprise permalink spec
2021-05-08 14:21:45 -07:00
Andy Brett
2910cbf15c
Merge pull request #7582 from openfoodfoundation/transifex
...
Transifex
2021-05-08 13:55:11 -07:00
Transifex-Openfoodnetwork
d24d7fce56
Updating translations for config/locales/de_DE.yml
2021-05-09 05:16:39 +10:00
Nihal Mohammed
e485a4a8ef
Remove untested change to payments
2021-05-08 23:51:38 +05:30
Nihal Mohammed
026942dd72
Fix item_count to properly count quantity of every item
2021-05-08 23:45:41 +05:30
Nihal Mohammed
237ebd6ec4
Removed N+1 queries while counting line_items
2021-05-08 21:09:06 +05:30
Mathieu Lovato Stumpf Guntz
a4d6e69309
Replace nmp with yarn, remove newrelic
2021-05-07 21:10:55 +02:00
Mathieu Lovato Stumpf Guntz
29e04dd8c8
Merge branch 'master' of https://github.com/openfoodfoundation/openfoodnetwork
2021-05-07 16:00:08 +02:00
Mathieu Lovato Stumpf Guntz
5a8e271037
Update .node-version to last LTS and drop setup tests
2021-05-07 15:54:15 +02:00
Andy Brett
5a16954bf6
Merge pull request #7572 from openfoodfoundation/transifex
...
Transifex
2021-05-07 06:46:56 -07:00
Matt-Yorkley
43e41f4980
Add more explicit test coverage to BulkLineItemsController acitons
...
This spec includes taxes on line items, fees on the order and on line items, taxes on fees (inherited and non-inherited), shipping and payment fees and taxes on shipping. It checks all of these things are correctly updated after the order is changed via BOM.
2021-05-07 11:54:04 +01:00
Matt-Yorkley
39156ec988
Merge pull request #7574 from Matt-Yorkley/dfc-routes
...
Update DFC routes
2021-05-07 11:27:50 +02:00
Matt-Yorkley
c71d4bce6a
Update DFC routes
2021-05-07 09:42:35 +01:00
Pau Pérez Fabregat
8d8abed529
Merge pull request #7496 from jibees/4957-flaky-specs
...
Uncomment flaky spec on variant_overrides_spec.rb
2021-05-07 10:29:36 +02:00
Transifex-Openfoodnetwork
55018260df
Updating translations for config/locales/en_FR.yml
2021-05-07 17:53:34 +10:00
Transifex-Openfoodnetwork
cbdeef064a
Updating translations for config/locales/fr.yml
2021-05-07 17:53:20 +10:00
Transifex-Openfoodnetwork
ac2c02a983
Updating translations for config/locales/es.yml
2021-05-07 16:40:26 +10:00
Transifex-Openfoodnetwork
c71a4918a0
Updating translations for config/locales/ca.yml
2021-05-07 16:40:03 +10:00
Pau Perez
fd5e0fd60f
Properly mock validator and extend tests
...
Tests were passing but not due to the expected reason. While at it, we
extended the assertions to be more precise.
2021-05-07 08:35:54 +02:00
Andy Brett
dbd0d4a795
Merge pull request #7570 from openfoodfoundation/release/v3.6.10
...
Update all locales with the latest Transifex translations
2021-05-06 20:41:25 -07:00
Andy Brett
328381b732
Update all locales with the latest Transifex translations
2021-05-06 20:38:41 -07:00
Luis Ramos
de000228cf
Fix problem in erb template by explicitly setting format to js while calling it
2021-05-06 23:52:16 +01:00
Luis Ramos
a2de86c23e
Replace be_success on test_reponse with status 200
...
In rails 6 response.success? is not supported.
2021-05-06 23:51:30 +01:00
Andy Brett
415d86bff0
Merge pull request #7562 from coopdevs/fix-failed-sca-auth
...
Fix failed SCA authentication on subs. order payment not reflected in OFN
2021-05-06 15:25:16 -07:00
Andy Brett
8b9083d28f
Merge pull request #7560 from openfoodfoundation/dependabot/bundler/rails-5.2.6
...
Bump rails from 5.2.5 to 5.2.6
2021-05-06 15:14:06 -07:00
dependabot[bot]
7f5dddffa0
Bump rails from 5.2.5 to 5.2.6
...
Bumps [rails](https://github.com/rails/rails ) from 5.2.5 to 5.2.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v5.2.5...v5.2.6 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-06 17:35:58 +00:00
Andy Brett
cfa4bde965
Merge pull request #7559 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.10.1
...
Bump rubocop-rails from 2.10.0 to 2.10.1
2021-05-06 10:34:20 -07:00
Andy Brett
9e6ede4072
Merge pull request #7561 from openfoodfoundation/dependabot/bundler/rubocop-1.14.0
...
Bump rubocop from 1.13.0 to 1.14.0
2021-05-06 10:33:40 -07:00
Pau Perez
9a63f38790
I18n-ize error messages.
2021-05-06 16:34:29 +02:00
Pau Perez
69b91ea136
Wait until the end to mark payment as processed
...
This gives us the opportunity to retry the operation in case the
processing fails.
2021-05-06 16:19:01 +02:00
Pau Perez
dea6a01e61
Handle SCA payments that can't complete
2021-05-06 16:19:01 +02:00
Pau Perez
2147584daf
Validate intents against Stripe and display errors
...
Now the existing validation is redundant. It's Stripe's API who does
that now. It's up to them to decide what's a valid intent.
2021-05-06 16:19:01 +02:00
Pau Perez
b723ed4a98
Skip Stripe logic when no payment data is passed
2021-05-06 16:19:01 +02:00
dependabot[bot]
ccfe352d62
Bump rubocop from 1.13.0 to 1.14.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.13.0...v1.14.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-06 05:22:38 +00:00
dependabot[bot]
76fb157518
Bump rubocop-rails from 2.10.0 to 2.10.1
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.10.0 to 2.10.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.10.0...v2.10.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-06 05:18:52 +00:00
Andy Brett
a7331efd67
Merge pull request #7477 from luisramos0/require_dependency
...
Remove require_dependency or use require
2021-05-05 13:24:19 -07:00
Pau Pérez Fabregat
b57755398c
Merge pull request #7531 from openfoodfoundation/dependabot/bundler/daemons-1.4.0
...
Bump daemons from 1.3.1 to 1.4.0
2021-05-05 21:42:25 +02:00
dependabot[bot]
076081929f
Bump daemons from 1.3.1 to 1.4.0
...
Bumps [daemons](https://github.com/thuehlinger/daemons ) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/thuehlinger/daemons/releases )
- [Changelog](https://github.com/thuehlinger/daemons/blob/master/Releases )
- [Commits](https://github.com/thuehlinger/daemons/compare/v1.3.1...v1.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-05 18:07:37 +00:00
Andy Brett
4b183bb6c1
Merge pull request #7555 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.10.0
...
Bump rubocop-rails from 2.9.1 to 2.10.0
2021-05-05 11:06:43 -07:00
Andy Brett
d2f3cdd6b9
Merge pull request #7546 from openfoodfoundation/dependabot/bundler/activerecord-session_store-2.0.0
...
Bump activerecord-session_store from 1.1.3 to 2.0.0
2021-05-05 11:06:10 -07:00
Andy Brett
baf3d4b2cd
Merge pull request #6488 from openfoodfoundation/dependabot/bundler/pg-1.2.3
...
Bump pg from 0.21.0 to 1.2.3
2021-05-05 11:05:52 -07:00
Andy Brett
f8f3cb78e3
Merge pull request #7549 from openfoodfoundation/dependabot/bundler/roadie-rails-2.2.0
...
Bump roadie-rails from 1.3.0 to 2.2.0
2021-05-05 11:05:24 -07:00
dependabot[bot]
18373533e6
Bump roadie-rails from 1.3.0 to 2.2.0
...
Bumps [roadie-rails](https://github.com/Mange/roadie-rails ) from 1.3.0 to 2.2.0.
- [Release notes](https://github.com/Mange/roadie-rails/releases )
- [Changelog](https://github.com/Mange/roadie-rails/blob/master/Changelog.md )
- [Commits](https://github.com/Mange/roadie-rails/compare/v1.3.0...v2.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-05 17:40:59 +00:00
dependabot[bot]
679ceaead7
Bump pg from 0.21.0 to 1.2.3
...
Bumps [pg](https://github.com/ged/ruby-pg ) from 0.21.0 to 1.2.3.
- [Release notes](https://github.com/ged/ruby-pg/releases )
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc )
- [Commits](https://github.com/ged/ruby-pg/compare/v0.21.0...v1.2.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-05 17:40:49 +00:00
Pau Pérez Fabregat
64baebd791
Merge pull request #7545 from openfoodfoundation/dependabot/bundler/ransack-2.4.1
...
Bump ransack from 2.3.0 to 2.4.1
2021-05-05 19:39:42 +02:00
dependabot[bot]
31adbdbf7a
Bump activerecord-session_store from 1.1.3 to 2.0.0
...
Bumps [activerecord-session_store](https://github.com/rails/activerecord-session_store ) from 1.1.3 to 2.0.0.
- [Release notes](https://github.com/rails/activerecord-session_store/releases )
- [Commits](https://github.com/rails/activerecord-session_store/compare/v1.1.3...v2.0.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-05 17:15:11 +00:00
Pau Pérez Fabregat
819479f05c
Merge pull request #7552 from luisramos0/rails525
...
Upgrade to rails 5.2.5 with "bundle update rails"
2021-05-05 19:14:04 +02:00
Pau Pérez Fabregat
324999494b
Merge pull request #7523 from openfoodfoundation/transifex
...
Transifex
2021-05-05 18:31:30 +02:00
Andy Brett
82845e1cfc
Merge pull request #7528 from Matt-Yorkley/has_many_through
...
Reorder has_many relationship with :through option
2021-05-05 08:08:15 -07:00
Andy Brett
3e714b1539
Merge pull request #7527 from Matt-Yorkley/dead-code-deleted
...
Remove #deleted? method from Product and Variant
2021-05-05 08:07:39 -07:00
Andy Brett
002420304d
Merge pull request #7526 from Matt-Yorkley/dead-currency
...
Remove currency from OrderContents
2021-05-05 08:06:53 -07:00
dependabot[bot]
aa90c4f34f
Bump rubocop-rails from 2.9.1 to 2.10.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.9.1...v2.10.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-05 05:14:36 +00:00
Luis Ramos
63e2122593
Upgrade to rails 5.2.5 with a bundle update rails
2021-05-04 21:31:09 +01:00
Andy Brett
35671e2464
Merge pull request #7548 from openfoodfoundation/dependabot/bundler/rspec-rails-5.0.1
...
Bump rspec-rails from 4.1.2 to 5.0.1
2021-05-04 13:22:48 -07:00
Andy Brett
4b9418ebd6
Merge pull request #7547 from openfoodfoundation/dependabot/bundler/coffee-rails-5.0.0
...
Bump coffee-rails from 4.2.2 to 5.0.0
2021-05-04 13:02:50 -07:00
dependabot[bot]
ec8f42513b
Bump rspec-rails from 4.1.2 to 5.0.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 4.1.2 to 5.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v4.1.2...v5.0.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-04 19:21:11 +00:00
dependabot[bot]
3ba439ec0d
Bump coffee-rails from 4.2.2 to 5.0.0
...
Bumps [coffee-rails](https://github.com/rails/coffee-rails ) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/rails/coffee-rails/releases )
- [Changelog](https://github.com/rails/coffee-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/coffee-rails/compare/v4.2.2...v5.0.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-04 19:20:07 +00:00
dependabot[bot]
47e79a8d60
Bump ransack from 2.3.0 to 2.4.1
...
Bumps [ransack](https://github.com/activerecord-hackery/ransack ) from 2.3.0 to 2.4.1.
- [Release notes](https://github.com/activerecord-hackery/ransack/releases )
- [Changelog](https://github.com/activerecord-hackery/ransack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/activerecord-hackery/ransack/compare/v2.3.0...2.4.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-04 19:19:33 +00:00
Transifex-Openfoodnetwork
119fdd9e53
Updating translations for config/locales/en_CA.yml
2021-05-05 03:12:14 +10:00
Matt-Yorkley
00c4a28d22
Extract order-updating logic to Order::Updater
2021-05-04 16:40:10 +01:00
Matt-Yorkley
8e10f7af0e
Update payments controller test setup
...
We need to use a completed order in the test setup here or it doesn't behave correctly. `order.completed_at` is nil, for example.
2021-05-04 16:40:10 +01:00
Matt-Yorkley
135a311c05
Update void payments
...
Backport from Spree 2.4 stable: 4121992398
2021-05-04 16:40:10 +01:00
Matt-Yorkley
13bb5aa8dd
Update Payment after_save callback
...
Backport from Spree 2.4 stable: 4d652a77fd
2021-05-04 16:40:09 +01:00
Matt-Yorkley
2b1becfd47
Merge pull request #7185 from openfoodfoundation/rails-5-2
...
Rails 5.2 upgrade
2021-05-04 17:21:03 +02:00
Pau Perez
cb1e4caad8
Update all locales with the latest Transifex translations
2021-05-04 08:34:04 +02:00
Andy Brett
edc51d1155
Merge pull request #7532 from openfoodfoundation/dependabot/bundler/test-prof-1.0.3
...
Bump test-prof from 1.0.2 to 1.0.3
2021-05-03 11:31:50 -07:00
filipefurtad0
a476416dc4
Removes html tr tag; Clarifies it block
2021-05-03 17:03:34 +01:00
Transifex-Openfoodnetwork
55b1b860d1
Updating translations for config/locales/en_US.yml
2021-05-04 02:03:25 +10:00
Matt-Yorkley
e2a411c23c
Add map helper to RegistrationController
...
Fixes 3 errors including:
Registration Terms of Service agreement if accepting Terms of Service is not required allows registration as normal
Failure/Error: super
ActionView::Template::Error:
undefined method `using_google_maps?' for #<#<Class:0x00007fd4949c4558>:0x00007fd499dd0ae8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
# ./app/views/registration/steps/_details.html.haml:60:in `_app_views_registration_steps__details_html_haml___1911121144363058234_70275472163280'
# ./app/views/registration/index.html.haml:12:in `block in _app_views_registration_index_html_haml__993897347679518865_70275545598940'
# ./app/views/registration/index.html.haml:11:in `each'
# ./app/views/registration/index.html.haml:11:in `_app_views_registration_index_html_haml__993897347679518865_70275545598940'
# ./lib/open_food_network/rack_request_blocker.rb:36:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `using_google_maps?' for #<#<Class:0x00007fd4949c4558>:0x00007fd499dd0ae8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
2021-05-03 14:17:54 +01:00
Matt-Yorkley
aa013ef76a
Update redirect_back syntax for Rails 5
...
Introduced in 5.0, the old syntax is removed in 5.2
2021-05-03 14:17:54 +01:00
Matt-Yorkley
a645b8c58f
Re-apply previous 5.2 commit: Don't reload payments in after_save callback
...
This causes issues in master, but is needed in the 5.2 branch.
2021-05-03 14:17:54 +01:00
Matt-Yorkley
4888f1cd06
Stub OrderPaymentFinder to return correct object
...
OrderPaymentFinder was re-fetching the payment object from the database, so the subsequent line that stubs #authorize! on that payment was not being applied to the correct object.
2021-05-03 14:17:54 +01:00
Matt-Yorkley
31fc6201fc
Include payment method helper in ApplicationController
2021-05-03 14:17:54 +01:00
Matt-Yorkley
ab65b01fcf
Rename payments helper
2021-05-03 14:17:54 +01:00
Matt-Yorkley
1de68d091a
Update guard clause in line item callbacks (take two)
...
The `changed?` method is more accurately replaced by `saved_changes.present?`
In some cases here (where the object had just been saved for the first time) the guard clause was still stopping execution unexpectedly.
2021-05-03 14:17:54 +01:00
Matt-Yorkley
ac53df37d9
Fix callback in LineItem
...
#changed? here was not working as before, and the code was never getting past this guard in various places where previously it did. This meant the callback was effectively disabled, and order.update! was not being called when it should be.
2021-05-03 14:17:54 +01:00
Luis Ramos
279c15c306
Adapt spec to rails 5.2
2021-05-03 14:17:54 +01:00
Luis Ramos
47a5809100
Fix rspec syntax
2021-05-03 14:17:54 +01:00
Andy Brett
705666ecd0
fix /spec/models/spree/credit_card_spec.rb:301
2021-05-03 14:17:54 +01:00
Luis Ramos
aaf4710694
Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash
2021-05-03 14:17:54 +01:00
Luis Ramos
f5a7ff0f0a
Switch from map, that does not exist in ActionController::Parameters, to each
2021-05-03 14:17:54 +01:00
Andy Brett
203dbb7a8b
Revert "Switch from map, that does not exist in ActionController::Parameters, to each"
...
This reverts commit 69a15d4f04 .
2021-05-03 14:17:54 +01:00
Andy Brett
ea5f9c6747
Revert "Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash"
...
This reverts commit bb465b5715 .
2021-05-03 14:17:54 +01:00
Andy Brett
d255ca22f5
use new attribute_changed method for taxons take 2
2021-05-03 14:17:54 +01:00
Andy Brett
be0eb5f5f9
ignore nil in payment report spec expectation
2021-05-03 14:17:54 +01:00
Andy Brett
52525dc437
Fix /spec/models/spree/product_spec.rb:118
2021-05-03 14:17:54 +01:00
Andy Brett
d381b2a544
Use saved_change_to prefix to check for changes
2021-05-03 14:17:54 +01:00
Luis Ramos
c08bc743d3
Replace usage of changed? with saved_change_to_
2021-05-03 14:17:54 +01:00
Luis Ramos
c1402fe4f2
Upgrade state_machines
2021-05-03 14:17:54 +01:00
Matt-Yorkley
e9b6f89ae0
Update params syntax in engine controller specs
2021-05-03 14:17:54 +01:00
Matt-Yorkley
26688dda36
Add angular_form helper
...
Fixes:
Failure/Error: super
ActionView::Template::Error:
undefined method `ng_options_for_select' for #<#<Class:0x00007fbf8e43e310>:0x000055783fbebec0>
Did you mean? options_for_select
# ./app/helpers/application_helper.rb:20:in `method_missing'
# ./app/helpers/angular_form_builder.rb:26:in `ng_select'
# ./app/views/admin/enterprise_fees/index.html.haml:34:in `block (2 levels) in _app_views_admin_enterprise_fees_index_html_haml__800455454875182851_46987476952700'
# ./app/helpers/angular_form_builder.rb:6:in `ng_fields_for'
# ./app/views/admin/enterprise_fees/index.html.haml:28:in `block in _app_views_admin_enterprise_fees_index_html_haml__800455454875182851_46987476952700'
# ./app/helpers/application_helper.rb:11:in `ng_form_for'
# ./app/views/admin/enterprise_fees/index.html.haml:4:in `_app_views_admin_enterprise_fees_index_html_haml__800455454875182851_46987476952700'
# ./lib/open_food_network/rack_request_blocker.rb:36:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `ng_options_for_select' for #<#<Class:0x00007fbf8e43e310>:0x000055783fbebec0>
# Did you mean? options_for_select
# ./app/helpers/application_helper.rb:20:in `method_missing'
2021-05-03 14:17:54 +01:00
Matt-Yorkley
b7aeceaf67
Add enterprise_fees helper
...
Fixes:
Failure/Error: super
ActionView::Template::Error:
undefined method `angular_id' for #<#<Class:0x00007f57c7126670>:0x00007f57c55754f8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
# ./app/views/admin/enterprise_fees/index.html.haml:32:in `block (2 levels) in _app_views_admin_enterprise_fees_index_html_haml__3854507252304647884_70007474860840'
# ./app/helpers/angular_form_builder.rb:6:in `ng_fields_for'
# ./app/views/admin/enterprise_fees/index.html.haml:28:in `block in _app_views_admin_enterprise_fees_index_html_haml__3854507252304647884_70007474860840'
# ./app/helpers/application_helper.rb:11:in `ng_form_for'
# ./app/views/admin/enterprise_fees/index.html.haml:4:in `_app_views_admin_enterprise_fees_index_html_haml__3854507252304647884_70007474860840'
# ./lib/open_food_network/rack_request_blocker.rb:36:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `angular_id' for #<#<Class:0x00007f57c7126670>:0x00007f57c55754f8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
2021-05-03 14:17:54 +01:00
Matt-Yorkley
e6a3041f45
Add admin/enterprises helper
...
Fixes:
Failure/Error: super
ActionView::Template::Error:
undefined method `add_check_if_single' for #<#<Class:0x0000564501a3c838>:0x00007f446cdd68e8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
# ./app/views/spree/admin/shared/_hubs_sidebar.html.haml:16:in `block in _app_views_spree_admin_shared__hubs_sidebar_html_haml___1973426344114200431_69965928779540'
# ./app/views/spree/admin/shared/_hubs_sidebar.html.haml:11:in `each'
# ./app/views/spree/admin/shared/_hubs_sidebar.html.haml:11:in `_app_views_spree_admin_shared__hubs_sidebar_html_haml___1973426344114200431_69965928779540'
# ./app/views/spree/admin/payment_methods/edit.html.haml:15:in `block in _app_views_spree_admin_payment_methods_edit_html_haml__571217921761730685_69965930474120'
# ./app/views/spree/admin/payment_methods/edit.html.haml:11:in `_app_views_spree_admin_payment_methods_edit_html_haml__571217921761730685_69965930474120'
# ./app/controllers/admin/resource_controller.rb:23:in `block (2 levels) in edit'
# ./lib/spree/core/controller_helpers/respond_with.rb:24:in `respond_with'
# ./app/controllers/admin/resource_controller.rb:22:in `edit'
# ./lib/open_food_network/rack_request_blocker.rb:36:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `add_check_if_single' for #<#<Class:0x0000564501a3c838>:0x00007f446cdd68e8>
# ./app/helpers/application_helper.rb:20:in `method_missing'
2021-05-03 14:17:54 +01:00
Matt-Yorkley
b0787e83b2
Add checkout helper
...
Fixes:
Failure/Error: super
ActionView::Template::Error:
undefined method `checkout_adjustments_for' for #<#<Class:0x000055f4bd847a30>:0x000055f4bd845c30>
# ./app/helpers/application_helper.rb:20:in `method_missing'
# ./app/views/spree/admin/orders/_invoice_table.html.haml:26:in `_app_views_spree_admin_orders__invoice_table_html_haml___3617932924646213210_47254819384740'
# ./app/views/spree/admin/orders/invoice.html.haml:67:in `_app_views_spree_admin_orders_invoice_html_haml__1476001169744481148_47254819971700'
# ./app/services/invoice_renderer.rb:8:in `render_to_string'
# ./app/controllers/spree/admin/orders_controller.rb:81:in `invoice'
# ./spec/support/controller_requests_helper.rb:49:in `process_action_with_route'
# ./spec/support/controller_requests_helper.rb:23:in `spree_get'
# ./spec/controllers/spree/admin/orders/invoices_spec.rb:58:in `block (6 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `checkout_adjustments_for' for #<#<Class:0x000055f4bd847a30>:0x000055f4bd845c30>
# ./app/helpers/application_helper.rb:20:in `method_missing'
2021-05-03 14:17:54 +01:00
Luis Ramos
1b4930de8f
Fix mimemagic 036 yank issue
2021-05-03 14:17:54 +01:00
Matt-Yorkley
f874397115
Fix errors in PermittedAttributes::OrderCycle
2021-05-03 14:17:54 +01:00
Matt-Yorkley
5fc60f53ba
Update mimemagic gem!
...
The package maintainer nuked this gem last night as part of a major licence change for the repo, and chaos ensued. It's a dependency for ActiveStorage which is now part of Rails. Versions *above* 0.3.5 are now available, and work. All versions below 0.3.6 have been removed without warning (currently used by ~576,971 repos on Github!) D:
2021-05-03 14:17:54 +01:00
Matt-Yorkley
943c00c924
WIP - Update loading of helpers in controllers
...
Rails has changed the way helpers are loaded. It's a bit weird. It was throwing lots of errors, and recommended using this setting, but now requires that all helpers are loaded explicitly. I'm not sure about this.
2021-05-03 14:17:54 +01:00
Matt-Yorkley
138f00876b
Update Rails to 5.2
2021-05-03 14:17:54 +01:00
Transifex-Openfoodnetwork
b00dcecd52
Updating translations for config/locales/en_GB.yml
2021-05-03 18:16:39 +10:00
dependabot[bot]
d3b3ed3b9c
Bump test-prof from 1.0.2 to 1.0.3
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-03 05:47:40 +00:00
filipefurtad0
19768e1398
adds coverage for product deletion and cloning
2021-05-02 18:33:13 +01:00
Matt-Yorkley
7c2d77a3ee
Fix assertion in ModelSet test
...
The mismatched use of hash attributes as strings and hash attributes as symbols here (attrs['name'] and attrs[:name]) meant that the conditional was not returning the expected results in the test.
2021-05-02 13:42:38 +01:00
Matt-Yorkley
2560757ea2
Change Enterprise after_create callback to after_create_commit
...
As a general rule, if you're triggering an email job as part of an after create/save callback, it should use after commit instead.
Why? The transaction can't finish until after the record is persisted (the data is committed) which includes the logic in all callbacks. So for example if the transaction fails after the email job has been placed it will be rolled back, but the email job will already be in the queue, and it'll be referencing a record that doesn't actually exist (due to the rollback).
2021-05-02 13:23:31 +01:00
Matt-Yorkley
9d23c0d9e2
Reorder has_many relationship with :through option
...
If it's using :through it should be defined after the relationship it's connected to
2021-05-01 16:20:36 +01:00
Matt-Yorkley
7948c5943d
Remove #deleted? method from Product and Variant
...
This method is already supplied via the paranoia gem, there's no need to re-implement it here.
2021-05-01 12:54:33 +01:00
Matt-Yorkley
2eb17dbbd1
Remove currency from OrderContents
...
The currency argument here is not actually used anywhere. The related conditional logic is also not covered in any tests.
2021-05-01 11:10:51 +01:00
Transifex-Openfoodnetwork
0a9fc429ac
Updating translations for config/locales/de_DE.yml
2021-05-01 08:32:50 +10:00
Andy Brett
8672969798
Merge pull request #7515 from openfoodfoundation/dependabot/bundler/devise-4.8.0
...
Bump devise from 4.7.3 to 4.8.0
2021-04-30 11:24:20 -07:00
Andy Brett
1be730fcfb
Merge pull request #7512 from Matt-Yorkley/package-refactor
...
Package update
2021-04-30 08:51:51 -07:00
Transifex-Openfoodnetwork
7fd82540ce
Updating translations for config/locales/en_IE.yml
2021-05-01 00:27:53 +10:00
Matt-Yorkley
e290c128bf
Fix error in Api::ShipmentController#update with :unlock parameter
...
This is a generic issue caused by a clash between state machines trying to define (or failing to define) the #open method on adjustments as part of their state changes interface. This method is already defined in Object. For more details, see: bb42e33bf7/lib/state_machines/machine.rb (L323-L350)
2021-04-30 14:13:22 +01:00
Matt-Yorkley
95a73704a2
Add more test coverage to Api::ShipmentController#update
2021-04-30 14:09:32 +01:00
Matt-Yorkley
b843b871f6
Ensure order totals and payment/shipment states are correct when changing shipping method on a completed order.
...
This used to happen via an after_save callback in Shipment, which called `order.update!`. That has recently been removed. After changing a shipment's selected shipping rate (shipping method), we need to ensure the order's totals and states are updated. We don't need to update all of the order's adjustments though (see previous commit).
FYI Spree handled this issue like this: 24388485ed , but there are lots of things about that commit that are clearly awful, like: params handling in a model, duplication of Order::Updater logic across the codebase, the Shipment class having responsiblity for knowing which things need to be updated on the order, etc. The result is ultimately the same as what we're doing here though.
2021-04-30 12:57:01 +01:00
Matt-Yorkley
925676f136
Split Order::Updater#update into two methods
...
There are two distinct (and very important) operations happening here. The first is to update all adjustments (which can be *incredibly* expensive) and the second is to ensure the order's totals and shipping/payment states are correct. There are lots of places where we currently do both of these things where in fact we only need to do the latter (and skip the really expensive part).
2021-04-30 12:48:53 +01:00
Matt-Yorkley
d3f41f14c7
Add test coverage for Api::ShipmentsController#update
2021-04-30 12:45:49 +01:00
Matt-Yorkley
045ce73c83
Simplify shipment controller params
2021-04-30 12:20:47 +01:00
Matt-Yorkley
932d000c9d
Improve shipping method factory
...
You can now specify an amount for the flat_rate option.
2021-04-30 12:19:43 +01:00
Matt-Yorkley
c7ce10f998
Handle order objects with no distributor
2021-04-30 11:12:41 +01:00
Matt-Yorkley
5b29243847
Delete unused method Stock::Package#currency
2021-04-30 11:10:20 +01:00
Matt-Yorkley
3897c3af68
Refactor Stock::Package#shipping_methods
2021-04-30 11:10:20 +01:00
Matt-Yorkley
c3c396eaea
Add soft-deletion test coverage to Package#shipping_methods
2021-04-30 11:10:19 +01:00
Pau Perez
03b2e558b3
Update all locales with the latest Transifex translations
2021-04-30 11:58:13 +02:00
Pau Pérez Fabregat
fca4fde9a6
Merge pull request #7518 from openfoodfoundation/transifex
...
Transifex
2021-04-30 11:54:01 +02:00
Pau Pérez Fabregat
057bcddee9
Merge pull request #7478 from jibees/7458-get-products-on-order-cycle-change-events
...
Get the whole list of products on order cycle changes
2021-04-30 11:39:15 +02:00
Transifex-Openfoodnetwork
05b1e598e0
Updating translations for config/locales/es.yml
2021-04-30 19:37:16 +10:00
Transifex-Openfoodnetwork
0faee508b5
Updating translations for config/locales/ca.yml
2021-04-30 19:34:42 +10:00
Pau Pérez Fabregat
3aaa818d00
Merge pull request #7516 from openfoodfoundation/transifex
...
Transifex
2021-04-30 11:30:07 +02:00
Pau Pérez Fabregat
006cf45f2a
Merge pull request #7514 from openfoodfoundation/dependabot/bundler/rack-mini-profiler-2.3.2
...
Bump rack-mini-profiler from 2.3.1 to 2.3.2
2021-04-30 11:29:28 +02:00
Transifex-Openfoodnetwork
afd17d6cf8
Updating translations for config/locales/ru.yml
2021-04-30 18:45:03 +10:00
Transifex-Openfoodnetwork
f6b6564048
Updating translations for config/locales/fr.yml
2021-04-30 17:48:22 +10:00
Transifex-Openfoodnetwork
9c49040fbb
Updating translations for config/locales/en_FR.yml
2021-04-30 17:47:48 +10:00
Transifex-Openfoodnetwork
a8b3d10377
Updating translations for config/locales/fr.yml
2021-04-30 17:45:21 +10:00
dependabot[bot]
c1d246081e
Bump devise from 4.7.3 to 4.8.0
...
Bumps [devise](https://github.com/plataformatec/devise ) from 4.7.3 to 4.8.0.
- [Release notes](https://github.com/plataformatec/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/master/CHANGELOG.md )
- [Commits](https://github.com/plataformatec/devise/compare/v4.7.3...v4.8.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-30 05:20:39 +00:00
dependabot[bot]
cf6545e501
Bump rack-mini-profiler from 2.3.1 to 2.3.2
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.3.1...v2.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-30 05:17:41 +00:00
Andy Brett
f64d5a9f59
Merge pull request #7438 from jibees/7353-fix-OC-display-issue-text-on-two-lines
...
Change the position of order_cycle component into a shop front
2021-04-29 14:05:06 -07:00
Andy Brett
c069a23926
Merge pull request #7476 from cillian/admin-stripe-elements-width
...
Increase the width of Stripe Elements fields in admin so they don't overlap
2021-04-29 14:04:44 -07:00
Andy Brett
8ba139c6fb
Merge pull request #6825 from julesemmac/6584-map-location-confirm
...
6584 map location confirm
2021-04-29 14:04:06 -07:00
Matt-Yorkley
0291a7c471
Merge pull request #7482 from Matt-Yorkley/updater-update
...
Updater update
2021-04-29 21:12:15 +02:00
Andy Brett
699f1c4f41
Merge pull request #7497 from andrewpbrett/fix-double-stripe-payments
...
Use capture! if payment is already authorized
2021-04-29 08:35:19 -07:00
Jean-Baptiste Bellet
5a3771fc42
Add special config to avoid a inconsistant LoadError
...
Error is
```
Failure/Error: @app.call(env)
LoadError:
Unable to autoload constant Api::V0::OrderCyclesController, expected /Users/jibees/dev/openfoodnetwork/app/controllers/api/v0/order_cycles_controller.rb to define it
```
2021-04-29 15:31:24 +02:00
Pau Pérez Fabregat
6c5db0f836
Merge pull request #7507 from Matt-Yorkley/shipment-state-update
...
Shipment callback state update
2021-04-29 12:01:55 +02:00
Matt-Yorkley
2f49d089ea
Use Time.zone.now
2021-04-29 08:56:17 +01:00
Matt-Yorkley
290c1d0ebf
Bring in shipment state updating from Spree 2.2
2021-04-28 21:43:28 +01:00
Matt-Yorkley
2fda550821
Add test for shipment state after ship action
2021-04-28 21:40:08 +01:00
Guido Oliveira
84285ff985
prevent deleting only item in confirmed order
2021-04-28 17:37:28 -03:00
Andy Brett
4f246da79f
add feature spec
2021-04-28 11:25:43 -07:00
Andy Brett
73e5fd3f5b
use method to clarify intent on payment intents
2021-04-28 10:43:06 -07:00
Andy Brett
4736013946
update spec
2021-04-28 10:43:06 -07:00
Pau Pérez Fabregat
6ee6e4ed04
Merge pull request #7472 from openfoodfoundation/transifex
...
Transifex
2021-04-28 19:36:43 +02:00
Pau Pérez Fabregat
ef9720aee7
Merge pull request #7461 from andrewpbrett/fix-blocked-bo-orders
...
Scope variant to take overrides into account in packer
2021-04-28 19:36:02 +02:00
Matt-Yorkley
4bd2fb8930
Merge pull request #7498 from openfoodfoundation/dependabot/bundler/view_component-2.31.1
...
Bump view_component from 2.31.0 to 2.31.1
2021-04-28 12:47:55 +02:00
dependabot[bot]
2494ba0def
Bump view_component from 2.31.0 to 2.31.1
...
Bumps [view_component](https://github.com/github/view_component ) from 2.31.0 to 2.31.1.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.31.0...v2.31.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-28 05:28:59 +00:00
Andy Brett
9906afa1a6
use capture! if payment is already authorized
2021-04-27 17:59:03 -07:00
Matt-Yorkley
1d29e277f2
Merge pull request #7493 from Matt-Yorkley/order-states-bug-redux
...
Reload order before updating in Payment callback
2021-04-27 17:43:34 +02:00
Matt-Yorkley
c7e65185ee
Regression test for new order with variant overrides
2021-04-27 07:44:41 -07:00
Matt-Yorkley
22f79fe540
Reload order before updating in Payment callback
2021-04-27 14:27:35 +01:00
Matt-Yorkley
a5a324fd6f
Add failing spec for payment and shipment states bug
...
The order was being left in an unexpected condition here, it's states are not set and there seem to be some weird issues.
2021-04-27 14:27:35 +01:00
Matt-Yorkley
5934b100e9
Test payment and shipment states in checkout spec
...
If these aren't behaving correctly we need to know about it...
2021-04-27 14:27:35 +01:00
Jean-Baptiste Bellet
81385b63c7
Uncomment (not so) flaky spec
2021-04-27 15:27:16 +02:00
Matt-Yorkley
574d78403d
Merge pull request #7433 from coopdevs/raise-on-failed-customer-creation
...
Notify Bugsnag if customer fails to be created
2021-04-27 12:42:39 +02:00
Matt-Yorkley
3c1889d719
Merge pull request #7490 from openfoodfoundation/dependabot/bundler/view_component-2.31.0
...
Bump view_component from 2.30.0 to 2.31.0
2021-04-27 12:08:29 +02:00
Jean-Baptiste Bellet
5085501f89
Add automated tests around pagination in product list for a shop
...
- with two order cycles and go from one to the other
2021-04-27 11:24:56 +02:00
Jean-Baptiste Bellet
07881ede2d
Do not trigger loadMore method immediatly
...
- This avoid to request unwanted resources, ie. the next 10 products of a shop
2021-04-27 11:24:48 +02:00
Jean-Baptiste Bellet
cdbcbf4214
Reinitialize page params when changing order cycle
2021-04-27 11:24:48 +02:00
Jean-Baptiste Bellet
523b957ba7
Initialize activeTaxons and activeProperties
...
- so there is no unwanted changes (from `undefined` to `[]`) that would trigger a loadProducts request
2021-04-27 11:24:48 +02:00
Jean-Baptiste Bellet
71466e643f
Instanciate only one ProductsCtrl
...
- instead of 2: therefore, for each shop display, we only request products one time instead of two times.
2021-04-27 11:24:48 +02:00
Matt-Yorkley
cc85bf791a
Merge pull request #7481 from openfoodfoundation/dependabot/bundler/codecov-0.5.2
...
Bump codecov from 0.5.1 to 0.5.2
2021-04-27 09:24:51 +02:00
dependabot[bot]
fa32aecebf
Bump view_component from 2.30.0 to 2.31.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.30.0 to 2.31.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.30.0...v2.31.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-27 05:26:40 +00:00
Andy Brett
de02acad64
add feature spec
2021-04-26 15:42:36 -07:00
Matt-Yorkley
f52d03fbf4
Refactor Order::Updater#update so we don't call update_totals twice
...
Calling this method twice on every update is really expensive and not necessary.
2021-04-26 11:46:05 +01:00
Pau Perez
ee01b0162c
Write if as a one-liner and avoid extra queries
2021-04-26 12:39:03 +02:00
Pau Perez
002dabb80c
Improve spec
2021-04-26 10:15:13 +02:00
Pau Perez
451e05985f
Fix spec
2021-04-26 10:15:13 +02:00
Pau Perez
679de40a41
Move specs to where they belong
2021-04-26 10:15:13 +02:00
Pau Perez
5845ace8e9
Don't persist models to test serializer
...
Serializers don't care whether or not the objects they go through are
persisted in DB. They just convert them.
2021-04-26 10:15:13 +02:00
Pau Perez
c65d82be01
Notify Bugsnag if customer fails to be created
...
This will hopefully let us see in Bugsnag when #6038 happens and so
we'll have all the diagnostics data. The fact that the `order.distributor`
is optional but mandatory to create the customer already gives us some
clue.
2021-04-26 10:15:12 +02:00
dependabot[bot]
69dd33383c
Bump codecov from 0.5.1 to 0.5.2
...
Bumps [codecov](https://github.com/codecov/codecov-ruby ) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/codecov/codecov-ruby/releases )
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.5.1...v0.5.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-26 05:53:44 +00:00
Andy Brett
6153f1c1b4
Merge pull request #7471 from Matt-Yorkley/dead-scopes
...
Order scopes
2021-04-25 11:51:00 -07:00
Andy Brett
6f20a23d47
Merge pull request #7436 from coopdevs/remove-duplicate-method
...
Replace duplicate #unauthorized method with module inclusion
2021-04-25 11:26:12 -07:00
Luis Ramos
f357c3ff30
Remove require_dependency or use require
...
See here https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#require-dependency
2021-04-23 19:20:25 +01:00
Cillian O'Ruanaidh
8cdc4bc3f4
Increase the width of Stripe Elements fields in admin so they don't overlap
...
The card number and expiry month/year fields were overlapping on the new payment form in the admin area.
2021-04-23 17:54:22 +01:00
Andy Brett
e42b0bb1ae
Merge pull request #7469 from openfoodfoundation/dependabot/bundler/view_component-2.30.0
...
Bump view_component from 2.28.0 to 2.30.0
2021-04-23 09:48:57 -07:00
Andy Brett
5e21480ae0
add packer spec
2021-04-23 09:35:27 -07:00
Matt-Yorkley
0c08e3cb3a
Merge pull request #7466 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.2.9
...
Bump @storybook/addon-docs from 6.2.7 to 6.2.9
2021-04-23 13:53:04 +02:00
dependabot[bot]
3c9b7db763
Bump @storybook/addon-docs from 6.2.7 to 6.2.9
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.2.7 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.2.9/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/docs )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-23 11:49:16 +00:00
Matt-Yorkley
d116d664f5
Merge pull request #7467 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.2.9
...
Bump @storybook/addon-controls from 6.2.7 to 6.2.9
2021-04-23 13:47:14 +02:00
dependabot[bot]
ff36cea0b0
Bump @storybook/addon-controls from 6.2.7 to 6.2.9
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.2.7 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.2.9/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/controls )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-23 11:30:47 +00:00
Matt-Yorkley
0c6f8e978e
Merge pull request #7465 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.2.9
...
Bump @storybook/server from 6.2.7 to 6.2.9
2021-04-23 13:27:50 +02:00
Pau Perez
e5eb68dffc
Replace duplicate method with module inclusion
...
No reason to risk diverging their implementations. They are exact
copies.
Likewise, there's no need to have to I18n keys with almost the same
content.
2021-04-23 12:03:11 +02:00
Transifex-Openfoodnetwork
35658e984b
Updating translations for config/locales/en_IE.yml
2021-04-23 19:43:25 +10:00
Transifex-Openfoodnetwork
a019c73166
Updating translations for config/locales/en_IE.yml
2021-04-23 19:40:16 +10:00
Matt-Yorkley
4938285dd7
Move order query methods to chainable scopes
2021-04-23 10:29:48 +01:00
Matt-Yorkley
caee2eb3e9
Remove dead code in order
...
These aren't used anywhere
2021-04-23 10:23:40 +01:00
dependabot[bot]
54fd2c5f0f
Bump view_component from 2.28.0 to 2.30.0
...
Bumps [view_component](https://github.com/github/view_component ) from 2.28.0 to 2.30.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.28.0...v2.30.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-23 08:18:44 +00:00
dependabot[bot]
8c76752045
Bump @storybook/server from 6.2.7 to 6.2.9
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.2.7 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.2.9/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/app/server )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-23 06:06:24 +00:00
Cillian O'Ruanaidh
af3eb82343
Merge in upstream changes from julesemmac:6584-map-location-confirm and resolve conflicts
2021-04-22 22:34:02 +01:00
Cillian O'Ruanaidh
1e96f92df2
Fix the toggle address confirmed checkbox so the latitude/longitude gets set
...
Before when you checked and unchecked the checkbox it was toggling the :isConfirmed variable.
2021-04-22 22:16:47 +01:00
Cillian O'Ruanaidh
12704af143
Use after_action calls for geocoding instead of old update.after, create.after calls
2021-04-22 22:13:28 +01:00
Cillian O'Ruanaidh
42d002cee8
Increase the default geocoder timeout to prevent geocoding timeouts in development
...
The timeout default was 3 before, this changes it to 6. I presume these timeouts could happen in production too.
2021-04-22 22:10:36 +01:00
Cillian O'Ruanaidh
cd97f1a6ef
Update angular-google-maps to 2.0.1 instead of 2.4.0 which was breaking /map page.
...
The master branch uses 2.0.0 but this PR went up to 2.4.0, however that caused the /map page to break and it was difficult to figure out why. We need to update to 2.0.1 because when you drag and drop the location icon during sign up there was an error which is fixed in 2.0.1. Maybe it would be good to upgrade to 2.4.0 at some point but this PR is already quite big.
2021-04-22 22:08:40 +01:00
Andy Brett
56cf43f1c1
scope variant to take overrides into account in packer
2021-04-22 11:45:12 -07:00
Cillian O'Ruanaidh
c41476423b
Merge latest master into julesemmac/6584-map-location-confirm and resolve conflict in api/enterprises_controller.rb
2021-04-22 19:43:49 +01:00
Matt-Yorkley
9b52c453db
Update all locales with the latest Transifex translations
2021-04-22 19:14:57 +01:00
Pau Pérez Fabregat
cf2e3db645
Merge pull request #7445 from jibees/7403-add-customer-name-into-subscriptions-table
...
Add customer name into subscriptions list in order to search subscription by customer name
2021-04-22 19:46:49 +02:00
Pau Pérez Fabregat
74968c308c
Merge pull request #7448 from openfoodfoundation/dependabot/bundler/knapsack-1.22.0
...
Bump knapsack from 1.20.0 to 1.22.0
2021-04-22 19:20:30 +02:00
Pau Pérez Fabregat
c1da97527a
Merge pull request #7420 from Matt-Yorkley/adjustments-controller
...
Adjustments controller index
2021-04-22 19:15:28 +02:00
Pau Pérez Fabregat
0194e39bd2
Merge pull request #7437 from jibees/7422-add-flipper-banner
...
Add banner to Flipper UI to warn the admin users
2021-04-22 18:29:12 +02:00
Matt-Yorkley
123e96eb1e
Merge pull request #7284 from jibees/styleguide
...
Implements our StyleGuide
2021-04-22 18:14:40 +02:00
Matt-Yorkley
bef3f8c51f
Merge pull request #7452 from Matt-Yorkley/adjustments-permissions
...
Update CanCan permissions on adjustments
2021-04-22 18:07:18 +02:00
Andy Brett
cf7efa5589
Merge pull request #7450 from jibees/6205-remove-line-items-empty-error-on-order-creation-in-backoffice
...
Suppress "Line items can't be blank" message on order creation process
2021-04-22 08:40:51 -07:00
Andy Brett
10834c1d3a
Merge pull request #7447 from openfoodfoundation/dependabot/bundler/rubocop-1.13.0
...
Bump rubocop from 1.12.1 to 1.13.0
2021-04-22 07:22:35 -07:00
Pau Pérez Fabregat
e5610d5424
Merge pull request #7427 from jibees/add-flipper-instrumentation
...
Instrument Flipper with ActiveSupport
2021-04-22 16:11:30 +02:00
jibees
1c53bbec57
Add banner to Flipper UI to warn the admin users
...
Add a link (escaped...) to the wiki page
Co-authored-by: Pau Pérez Fabregat <saulopefa@gmail.com >
2021-04-22 15:40:39 +02:00
Jean-Baptiste Bellet
9a670c7821
Print order needs render_with_wicked_pdf
...
and call WickedPdf::PdfHelper explicitly
2021-04-22 15:18:27 +02:00
Jean-Baptiste Bellet
de592de13a
Use the first view component DistributorTitleComponent for a shopfront
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
4781d6cc84
Add new (and first) component: DistributorTitle
...
- Simple wrapper around `<h3 />` for distributor title, used in the shop front
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
39683bd814
Create first story for ExampleComponent
...
- Once story has been created, still need to generate the story itself (in json file format). Help with command: `rake view_component_storybook:write_stories_json`
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
57e5214217
Call WickedPdf::PdfHelper#render_to_string_with_wicked_pdf explicitly
2021-04-22 15:08:54 +02:00
Matt-Yorkley
18881180ae
Remove WickedPdf monkey-patch on ActionController#render
2021-04-22 15:08:54 +02:00
Matt-Yorkley
453328a97e
Configure CORS settings for StoriesController
...
- Storybook need to access through a GET method on `/rails/stories/**` served by `ViewComponent::Storybook::StoriesController`
- Configure exact policy with an initialized filter
2021-04-22 15:08:54 +02:00
Maikel Linke
d674490896
Serve assets (css+roboto font) for the preview iframe
...
- Thus, component can inherit from all CSS rules, rendering is as close as to the truth
- Still need to import `admin` css file if we want to create components for admin part (and we probably want too). This will probably lead to overlapping problems between all CSS rules...
- This is a bit hacky, but as our CSS files are packed by rails I didn't find any better solution. We could also use any sass loader, but with this solution we can be confident on the fact that the generated CSS is the one used by the server that finally displays the component
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
30bd932ddc
Add storybook
...
- Via `view_component_storybook` : https://github.com/jonspalmer/view_component_storybook
- Configure both `view_component_storybook` and `storybook`
- Add two addons: `@storybook/addon-docs` and `@storybook/addon-controls`
Update config comment for clarity
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
390c8a89da
Add (very simple) spec for a ViewComponent component
...
- Add `ViewComponent::TestHelpers` to get the helper method `render_inline`
- Use Capybara to expect some assertion
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
6c37461c37
Create very first component
...
- With command: `rails generate component Example title --sidecar`
- Delete generated spec file
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
e25cb1b65e
Add view_components to manage our components
...
- Documentation : https://viewcomponent.org/
- Our template engine generator is haml
2021-04-22 15:08:54 +02:00
Jean-Baptiste Bellet
05a00a07ef
Add test on order creation and correct display of the error
...
- The error "Line items can't be blank" should not be displayed when we first arrived on this page after creation but only if we update the page
2021-04-22 10:03:43 +02:00
Jean-Baptiste Bellet
259e758d6e
When suppress_error_msg is present do no validate order and redirect
...
- When creating a new order, it's not necessary to display the "Line items can't be blank" as the order has just been created and the user is rightly doing configuration about line items
2021-04-22 10:03:36 +02:00
Matt-Yorkley
6dc23804a1
Merge pull request #7425 from mkllnk/application-record
...
Add ApplicationRecord for customisations of models
2021-04-21 23:18:03 +02:00
Matt-Yorkley
ecd433b343
Update permissions on adjustments
...
The previous permissions assumed that an adjustment's "adjustable" could only be only line items or orders, and that's no longer true. It's now commonly a shipment or a payment as well.
2021-04-21 18:17:20 +01:00
Jean-Baptiste Bellet
da5f1b0b38
Update test for subscriptions search by email and name
...
- We now display the name of the customer so we can search by its name: add specs about search by email/name
2021-04-21 09:44:30 +02:00
dependabot[bot]
519c04f2e4
Bump knapsack from 1.20.0 to 1.22.0
...
Bumps [knapsack](https://github.com/KnapsackPro/knapsack ) from 1.20.0 to 1.22.0.
- [Release notes](https://github.com/KnapsackPro/knapsack/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack/compare/v1.20.0...v1.22.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-21 05:17:32 +00:00
dependabot[bot]
99a857cdf9
Bump rubocop from 1.12.1 to 1.13.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.12.1 to 1.13.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.12.1...v1.13.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-21 05:15:48 +00:00
Andy Brett
479897fcbd
Merge pull request #7315 from Matt-Yorkley/double-checkout
...
Double checkout
2021-04-20 10:44:32 -07:00
Andy Brett
883cc6f96f
Merge pull request #7428 from jibees/7426-show-unit-price-in-the-bulk-modal
...
Show unit price in the bulk buy modal
2021-04-20 10:43:28 -07:00
Jean-Baptiste Bellet
ddb63dff8a
Add name of the customers into subscriptions table
...
- Thus, we can filter subscriptions by customer email
2021-04-20 16:09:48 +02:00
Jean-Baptiste Bellet
5e712fa4c0
Add variable for the zIndex of the navigation header
2021-04-20 13:50:39 +02:00
Jean-Baptiste Bellet
6dbe91b199
Positions the order_cycle according to shop-tabs
...
- Move from `enterprises/shop.html.haml` to `shopping_shared/_tabs.html.haml` to handle its position correctly
- Remove marginTop and height to order cycle component and display it relative to parent's bottom (ie. the columns in `tab-buttons`)
- Adjust z-index to display the entire component
2021-04-20 13:50:33 +02:00
Matt-Yorkley
a3b90f3a63
Merge pull request #7443 from mkllnk/order-cycle-factory
...
Spec customer creation during checkout
2021-04-20 10:08:57 +02:00
Pau Pérez Fabregat
7da0dc0053
Merge pull request #7441 from openfoodfoundation/dependabot/bundler/test-unit-3.4.1
...
Bump test-unit from 3.4.0 to 3.4.1
2021-04-20 09:49:19 +02:00
Pau Pérez Fabregat
ef7c47d8f1
Merge pull request #7440 from openfoodfoundation/dependabot/bundler/acts_as_list-1.0.4
...
Bump acts_as_list from 1.0.3 to 1.0.4
2021-04-20 09:04:04 +02:00
Pau Pérez Fabregat
9907c678e4
Merge pull request #7442 from openfoodfoundation/dependabot/bundler/ddtrace-0.48.0
...
Bump ddtrace from 0.47.0 to 0.48.0
2021-04-20 09:01:58 +02:00
Pau Pérez Fabregat
87624f4c9f
Merge pull request #7416 from coopdevs/remove-old-balance-implementation
...
Remove old balance implementation
2021-04-20 08:51:27 +02:00
Maikel Linke
1753156578
Spec customer creation during checkout
...
Expanding the controller spec with real data instead of mocks to test
the real callback behaviours.
2021-04-20 16:14:41 +10:00
Maikel Linke
db0e681add
Open order cycle factory for passing enterprises
...
The simple order cycle factory was flexible enough already to work with
given suppliers and distributors. We are now re-using that code so that
you can pass these enterprises when creating a normal order cycle, too.
2021-04-20 16:06:45 +10:00
dependabot[bot]
4dc350408b
Bump ddtrace from 0.47.0 to 0.48.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.47.0 to 0.48.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.47.0...v0.48.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-20 05:26:52 +00:00
dependabot[bot]
8cb9053115
Bump test-unit from 3.4.0 to 3.4.1
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.4.0...3.4.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-20 05:26:14 +00:00
dependabot[bot]
f354ace186
Bump acts_as_list from 1.0.3 to 1.0.4
...
Bumps [acts_as_list](https://github.com/brendon/acts_as_list ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/brendon/acts_as_list/releases )
- [Changelog](https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md )
- [Commits](https://github.com/brendon/acts_as_list/compare/v1.0.3...v1.0.4 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-20 05:24:53 +00:00
dependabot[bot]
8b06a735ac
Bump jwt from 2.2.2 to 2.2.3
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.2.2...v2.2.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-20 05:21:34 +00:00
Andy Brett
aca19edd3b
Merge pull request #7421 from andrewpbrett/rails-5-2-prep-2
...
Prepare for Rails 5.2
2021-04-19 11:32:21 -07:00
Pau Pérez Fabregat
5b0921e6ba
Merge pull request #7435 from openfoodfoundation/dependabot/bundler/geocoder-1.6.7
...
Bump geocoder from 1.6.6 to 1.6.7
2021-04-19 16:55:08 +02:00
Pau Perez
d26c52c2fa
Memoize OrderBalance instance
...
There's no need to create an instance of such class for every call to
one of its methods. The balance is computed each time anyway, so it'll
always be up-to-date.
2021-04-19 11:52:41 +02:00
Pau Perez
5bca7d1f8f
Remove the old balance's code branch
...
This keeps the `OrderBalance` abstraction but removes the old code now
that the feature is enabled for all users in all instances and there are
no bugs reported. It's become dead code.
2021-04-19 11:52:41 +02:00
dependabot[bot]
f999e04020
Bump geocoder from 1.6.6 to 1.6.7
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.6.6 to 1.6.7.
- [Release notes](https://github.com/alexreisner/geocoder/releases )
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.6.6...v1.6.7 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 06:05:20 +00:00
Andy Brett
9bddf5b00f
Merge pull request #7432 from coopdevs/add-tests-to-customers
...
Add tests to customers
2021-04-17 11:28:24 -07:00
Pau Perez
fd29030bf9
Doc through specs how customer creation works
2021-04-16 13:34:35 +02:00
Pau Perez
5087ca709a
Make method stick to Boolean instead of Nil
2021-04-16 13:23:56 +02:00
Pau Perez
e30ddf3f77
Test and simplify #require_customer?
2021-04-16 13:08:42 +02:00
Jean-Baptiste Bellet
8b3a178d97
Increase zIndex of the tooltip as it's now displayed inside modal
...
specify zIndex by using vars from modal zIndex
2021-04-16 11:09:26 +02:00
Jean-Baptiste Bellet
e0987c52ed
Add unit price information into the bulk buy modal
...
- Pass a parameter to scope: showunitprice and display unit price information if it's true
2021-04-16 11:09:05 +02:00
Jean-Baptiste Bellet
f9aab2ef5f
Adjust little cross inside blue circle to close tooltip
2021-04-16 11:08:57 +02:00
Maikel Linke
de6a3fdf2c
Update locales
2021-04-16 09:26:45 +10:00
Maikel
19e48cb0cb
Merge pull request #7424 from openfoodfoundation/transifex
...
Transifex
2021-04-16 09:20:25 +10:00
Andy Brett
472b0b5964
Merge pull request #7412 from andrewpbrett/no-zero-unit-values
...
Add greater-than-zero validation to variant unit_value
2021-04-15 10:05:38 -07:00
Andy Brett
4aa2ce4b58
Merge pull request #7362 from richardc2117/master
...
Fixes Alphabetical Sorting In Packing Reports
2021-04-15 09:50:02 -07:00
Andy Brett
c0bd8f0248
Merge pull request #7419 from Matt-Yorkley/adjustments-display
...
Don't show duplicate adjustments in order edit
2021-04-15 09:49:38 -07:00
Andy Brett
a9fe6c787d
add database constraint for variant unit_value
2021-04-15 09:43:57 -07:00
Andy Brett
8e14e0e950
add variant spec
2021-04-15 09:43:22 -07:00
Andy Brett
f85ef86b1b
update spec with valid variant
2021-04-15 09:43:22 -07:00
Andy Brett
94ca2f3079
add validation to variant unit_value
2021-04-15 09:43:22 -07:00
Pau Pérez Fabregat
5ddccc79ae
Merge pull request #7404 from jibees/7180-variant-unit-scale-field-invalid-when-editing-a-product
...
Fix Variant Unit Scale field initialization in Edit Product form
2021-04-15 18:20:31 +02:00
Matt-Yorkley
d29c0cdcb7
Don't show line item adjustments in Admin::OrdersHelper#order_adjustments_for_display
...
Line item adjustments are displayed separately, if we don't filter them here they get displayed twice.
2021-04-15 14:23:37 +01:00
Matt-Yorkley
206d9e06ea
Reinstate old logic for adjustments controller
...
Certain types of adjustments (eg enterprise fees) cannot really be changed arbitrarily; when the order is saved and "recalculated" the values will be reset. The adjustments are still shown in the main order edit tab, but are not editable in the adjustments tab.
2021-04-15 14:00:48 +01:00
Matt-Yorkley
50da77c6db
Hide tax rate selection when editing non-admin adjustments
2021-04-15 13:59:05 +01:00
Jean-Baptiste Bellet
1e0230aae2
Instrument Flipper with ActiveSupport
2021-04-15 14:05:15 +02:00
Transifex-Openfoodnetwork
468eb6423e
Updating translations for config/locales/nb.yml
2021-04-15 21:14:45 +10:00
Maikel Linke
5c0cdce597
Confine Permalinks patch to application
...
We were also patching ActiveRecord::Relation for the `#find_by_param`
methods but we are not using those any more. They were deprecated a
while ago. We now use `find_by(permalink: ...)`.
2021-04-15 15:59:03 +10:00
Maikel Linke
125374c488
Confine Preferences patch to our app
2021-04-15 15:59:03 +10:00
Maikel Linke
1893313c40
Confine DelegateBelongsTo patch to our app
2021-04-15 15:59:03 +10:00
Maikel Linke
1364b878fe
Add ApplicationRecord for customisations
...
Rails 5 introduced this new class to confine application-specific monkey
patches to our models only, and not leak into other libraries using
ActiveRecord::Base.
https://bigbinary.com/blog/application-record-in-rails-5
2021-04-15 15:59:03 +10:00
Transifex-Openfoodnetwork
b79465ba4f
Updating translations for config/locales/en_US.yml
2021-04-15 12:03:24 +10:00
Transifex-Openfoodnetwork
6b60a40b45
Updating translations for config/locales/en_US.yml
2021-04-15 12:00:23 +10:00
Maikel
0c182c4606
Merge pull request #7259 from jibees/7193-implements-feature-toggle-with-flipper
...
Implements feature toggle with flipper
2021-04-15 11:33:12 +10:00
Matt-Yorkley
a1317be19b
Merge pull request #7329 from Matt-Yorkley/adjustments-polymorphic
...
[Adjustments] Polymorphic reduction
2021-04-14 19:12:16 +02:00
Matt-Yorkley
fa14a80295
Adapt order payment creation in failing specs
...
In the test setups here order.payments is empty
2021-04-14 09:22:31 -07:00
Matt-Yorkley
a4cb698d6f
Don't reload payments in after_save callback
2021-04-14 09:22:18 -07:00
Andy Brett
ebb413bd83
only reload payments after updating order
2021-04-14 09:22:02 -07:00
Luis Ramos
4590db1cc2
Fix view spec by adding mocks to helper methods
2021-04-14 09:20:30 -07:00
Andy Brett
3e14138a3f
fix ./spec/features/admin/customers_spec.rb:27
2021-04-14 09:19:13 -07:00
Luis Ramos
6fab8db1b0
Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash
2021-04-14 09:18:29 -07:00
Luis Ramos
0707f3c0cc
Switch from map, that does not exist in ActionController::Parameters, to each
2021-04-14 09:17:53 -07:00
Matt-Yorkley
7fc29961e2
Fix handling of other empty params
2021-04-14 09:16:39 -07:00
Matt-Yorkley
72c6935ff8
Fix handling of empty order cycle params
...
This guard clause was returning an instance of an unpermitted Params object (containing a blank hash) here, which was causing unexpected results in various places. Returning a blank hash explicitly resolved the issue.
Fixes:
4) Admin::OrderCyclesController create as a manager of a shop when creation is successful returns success: true and a valid edit path
Failure/Error:
@order_cycle_params ||= PermittedAttributes::OrderCycle.new(params).call.
to_h.with_indifferent_access
ActionController::UnfilteredParameters:
unable to convert unpermitted parameters to hash
# ./app/controllers/admin/order_cycles_controller.rb:245:in `order_cycle_params'
# ./app/controllers/admin/order_cycles_controller.rb:44:in `create'
# ./spec/support/controller_requests_helper.rb:49:in `process_action_with_route'
# ./spec/support/controller_requests_helper.rb:27:in `spree_post'
# ./spec/controllers/admin/order_cycles_controller_spec.rb:124:in `block (5 levels) in <module:Admin>'
2021-04-14 09:16:27 -07:00
Matt-Yorkley
6f8ade52eb
Persist last_ip_address when loading current_order
...
Leaving the object with unpersisted changes breaks order locking with this error (in various places):
RuntimeError:
Locking a record with unpersisted changes is not supported. Use `save` to persist the changes, or `reload` to discard them explicitly.
2021-04-14 09:14:58 -07:00
Jean-Baptiste Bellet
86cba6e904
Remove trailing .0 from variant unit scale
...
- As VariantUnitManager.variantUnitOptions() returns array formatted like this: `"Weight (g)", "weight_1"` and `product.variant_unit_scale` is formatted like this `weight_1.0` there is no possible match for the <select /> element
- So, remove the trailing `.0` from `product.variant_unit_scale` to match the options
2021-04-14 16:17:17 +02:00
Jean-Baptiste Bellet
8a3eea7a27
Enable tests
...
Thanks to @filipefurtad0 you now have tests ready before fixing anything : 👍 🙏
2021-04-14 16:17:17 +02:00
Matt-Yorkley
93affe4e82
Remove previous migration test
...
It's outdated now.
2021-04-14 12:01:21 +01:00
Matt-Yorkley
83acc3faac
Improve test setup where checking ineligible payment fee adjustments
2021-04-14 12:01:21 +01:00
Matt-Yorkley
86977da033
Update enterprise fee test setup
2021-04-14 12:01:21 +01:00
Matt-Yorkley
15edb5b13b
Remove more uses of adjustment source association in tests
2021-04-14 12:01:21 +01:00
Matt-Yorkley
e323d016a2
Simplify arguments of #create_adjustment method
2021-04-14 12:01:21 +01:00
Matt-Yorkley
ebce32c57b
Update factory and specs
2021-04-14 12:01:21 +01:00
Matt-Yorkley
b6038c01a3
Remove references to Adjustment source
2021-04-14 12:01:21 +01:00
Matt-Yorkley
6474323282
Remove source association from Spree::Adjustment
2021-04-14 12:01:21 +01:00
Matt-Yorkley
76112fcf40
Merge pull request #7413 from andrewpbrett/rails-5-2-prep
...
Rails 5 2 prep
2021-04-14 12:37:02 +02:00
Matt-Yorkley
94bff6c512
Merge pull request #7414 from openfoodfoundation/dependabot/bundler/unicorn-worker-killer-0.4.5
...
Bump unicorn-worker-killer from 0.4.4 to 0.4.5
2021-04-14 11:41:14 +02:00
Pau Pérez Fabregat
3d7ac3c965
Merge pull request #7411 from openfoodfoundation/transifex
...
Transifex
2021-04-14 11:24:22 +02:00
dependabot[bot]
ed8a35df8c
Bump unicorn-worker-killer from 0.4.4 to 0.4.5
...
Bumps [unicorn-worker-killer](https://github.com/kzk/unicorn-worker-killer ) from 0.4.4 to 0.4.5.
- [Release notes](https://github.com/kzk/unicorn-worker-killer/releases )
- [Changelog](https://github.com/kzk/unicorn-worker-killer/blob/master/ChangeLog )
- [Commits](https://github.com/kzk/unicorn-worker-killer/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-14 05:31:14 +00:00
Matt-Yorkley
4bd7f964d0
Fix LocalizedNumber issues
2021-04-13 16:56:03 -07:00
Andy Brett
67e41f4548
remove check for connected?
2021-04-13 16:55:49 -07:00
Matt-Yorkley
39fa315ecc
Guard against calls to the database during db:create
...
Rails 5.2 has changed the way initializers are called during certain rake tasks including `db:create`. Initializers that were previously not loaded are now loaded (basically the whole app is loaded). This means any calls to #table_exists? that appear in the app will throw fatal errors as the database doesn't exist yet during that task, but those calls are made before `db:create` has even started, which means the database can't be created.
There are also a few other places in Spree code where #table_exists? is called, and they already call #connected? first to guard against this issue.
2021-04-13 16:55:19 -07:00
Luis Ramos
e4a6afab81
Add needed helper to BulkInvoiceRenderer spec
2021-04-13 16:54:32 -07:00
Luis Ramos
ae7e1677f7
Add needed helper to BulkInvoiceService spec
2021-04-13 16:54:32 -07:00
Luis Ramos
f61c04e314
Adapt helpers to make view spec green
2021-04-13 16:54:32 -07:00
Luis Ramos
abd6faf686
Adapt routes and helpers to make view spec green
2021-04-13 16:54:32 -07:00
Luis Ramos
2c05478b2f
Adapt routes and helpers to make view spec green
2021-04-13 16:54:32 -07:00
Luis Ramos
049c2b59ca
Adapt routes and helpers to make view spec green
2021-04-13 16:54:32 -07:00
Matt-Yorkley
ab4660ecd0
Fix callback in Classification and update spec
...
Fixes:
2) Spree::Classification won't destroy if classification is the primary taxon
(Used from /home/runner/work/openfoodnetwork/openfoodnetwork/spec/models/enterprise_group_spec.rb:43:in `block (3 levels) in <top (required)>')
Failure/Error: expect(classification.destroy).to be false
2021-04-13 16:54:32 -07:00
Matt-Yorkley
3f6fcf3350
Fix taxon error handling in Api::TaxonsController
...
Fixes:
Api::V0::TaxonsController as an admin cannot create a new taxon with invalid taxonomy_id
Failure/Error: expect(json_response["error"]).to eq("Invalid resource. Please fix errors and try again.")
expected: "Invalid resource. Please fix errors and try again."
got: nil
(compared using ==)
# ./spec/controllers/api/v0/taxons_controller_spec.rb:105:in `block (3 levels) in <top (required)>'
2021-04-13 16:54:31 -07:00
Matt-Yorkley
a891ac1cdf
Fix deprecated use of #stub in payment spec
...
Fixes:
Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /home/runner/work/openfoodnetwork/openfoodnetwork/spec/models/spree/payment_spec.rb:10:in `block (3 levels) in <top (required)>'.
RuntimeError:
stubbed models are not allowed to access the database - Spree::Product#touch(updated_at,{:time=>2021-04-10 14:24:50 UTC})
2021-04-13 16:54:31 -07:00
Matt-Yorkley
be6fd23ebc
Fix unpersisted changes in checkout controller specs
...
The test setup left the object with unsaved changes, which doesn't work nicely with the new order locking added recently on the edit action.
Fixes ~5 specs including:
5) CheckoutController redirection to cart and stripe redirects when some items are out of stock
Failure/Error:
order.with_lock do
lock_variants_of(order)
yield
end
RuntimeError:
Locking a record with unpersisted changes is not supported. Use `save` to persist the changes, or `reload` to discard them explicitly.
# ./app/services/current_order_locker.rb:22:in `lock_order_and_variants'
# ./app/services/current_order_locker.rb:11:in `around'
# ./spec/controllers/checkout_controller_spec.rb:57:in `block (3 levels) in <top (required)>'
2021-04-13 16:54:31 -07:00
Andy Brett
a0b4925943
update migration versions
2021-04-13 15:51:14 -07:00
Matt-Yorkley
fbda3c15ff
Fix deprecated use of #stub in payment spec
...
Fixes:
Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /home/runner/work/openfoodnetwork/openfoodnetwork/spec/models/spree/payment_spec.rb:10:in `block (3 levels) in <top (required)>'.
RuntimeError:
stubbed models are not allowed to access the database - Spree::Product#touch(updated_at,{:time=>2021-04-10 14:24:50 UTC})
2021-04-13 15:50:54 -07:00
Matt-Yorkley
3bce1bad62
Add missing Stripe API request stub
...
The first time the checkout is submitted here it uses the defaults in CheckoutRequestHelper#fill_out_details
2021-04-13 15:41:37 -07:00
Matt-Yorkley
b1416952d0
Fix deprecated syntax for reloading #line_items association
2021-04-13 15:40:12 -07:00
Transifex-Openfoodnetwork
97891dc667
Updating translations for config/locales/en_CA.yml
2021-04-14 06:12:04 +10:00
Transifex-Openfoodnetwork
c730e888e1
Updating translations for config/locales/en_CA.yml
2021-04-14 06:08:56 +10:00
Matt-Yorkley
477dce79df
Merge pull request #7407 from Matt-Yorkley/shipping-without-tax
...
Ensure Shipping Methods can be created with no tax category
2021-04-13 18:45:28 +02:00
Matt-Yorkley
acb593c2f1
Ensure Shipping Methods can be created with no tax category
...
The option to apply *no* tax category should be present in this dropdown.
2021-04-13 16:40:49 +01:00
Matt-Yorkley
2932b1e39b
Merge pull request #7395 from openfoodfoundation/dependabot/bundler/mini_racer-0.4.0
...
Bump mini_racer from 0.3.1 to 0.4.0
2021-04-13 15:33:41 +02:00
Pau Pérez Fabregat
eab97d6f42
Merge pull request #7400 from openfoodfoundation/transifex
...
Transifex
2021-04-12 18:29:07 +02:00
Maikel Linke
8a062b05eb
Clarify test users in feature toggle spec
2021-04-12 18:26:18 +02:00
Maikel Linke
f242dc8a19
Spec new #flipper_id method
2021-04-12 18:26:18 +02:00
Maikel Linke
5775051e35
Simplify FeatureToggle module
...
This saves ten lines of code and makes the simplicity of the
FeatureToggle interface clearer.
2021-04-12 18:26:18 +02:00
Jean-Baptiste Bellet
796068439d
Enable running Flipper migration
...
The initializer ran code the needs the database in the migrated state.
The decision is to not initialize anything relative to feature. This has to be done within the FlipperUI by the instance managers.
2021-04-12 18:26:18 +02:00
Maikel Linke
7a0912d5a4
Use Flipper within the OFN FeatureToggle interface
...
This ensures that we keep the same interface as before and can migrate
to Flipper in a backwards-compatible way.
2021-04-12 18:26:18 +02:00
Maikel Linke
b045a59685
Consider feature toggles without user as well
...
This is running the same feature toggle logic when a user is given or no
user is given. This allows features to define what to do with guests.
2021-04-12 18:26:18 +02:00
Jean-Baptiste Bellet
a4b53d6ac4
Initialize flipper with default value
...
- Use the ActiveRecord adapter
- Use a middle to cache data through memoization (see https://github.com/jnunemaker/flipper/blob/master/docs/Optimization.md )
- Create the group `admins`: only user which are admins
- Create `unit_price` feature attached to `admins` group
- Add method `flipper_id` on User
2021-04-12 18:26:18 +02:00
Jean-Baptiste Bellet
ad71f925be
Add gem flipper-active_record to store flipper data
...
- Creates the migration for flipper: `flipper_features` and `flipper_gates`
2021-04-12 18:26:18 +02:00
Jean-Baptiste Bellet
7cf96d1484
Add flipper to manage our feature toggle
...
- Also add flipper-ui to have a small UI that can be used by each instance admin to manage feature toggle
- Mount on `/admin/feature-toggle` with same restriction as `/admin`
2021-04-12 18:26:18 +02:00
Pau Pérez Fabregat
a946585029
Merge pull request #7392 from mkllnk/7391-db-connection-pool
...
Increase DB connection pool size for specs
2021-04-12 18:24:56 +02:00
Matt-Yorkley
0dde8112d2
Add redirect specs for PaypalController#express
2021-04-12 17:23:49 +01:00
Matt-Yorkley
06c01955f5
Rename describe block names to controller actions
2021-04-12 16:44:45 +01:00
Andy Brett
a3ac7a7ffd
Merge pull request #7354 from andrewpbrett/uncomment-tag-rule-spec
...
Uncomment out flaky tag rules spec
2021-04-12 08:17:14 -07:00
Transifex-Openfoodnetwork
07a95b3edf
Updating translations for config/locales/ru.yml
2021-04-13 01:08:43 +10:00
Transifex-Openfoodnetwork
addd287e74
Updating translations for config/locales/ru.yml
2021-04-13 01:05:34 +10:00
Pau Pérez Fabregat
bd2484c3e0
Merge pull request #7396 from coopdevs/enable-customer-balance-in-tests
...
Enable customer_balance toggle in tests
2021-04-12 13:42:49 +02:00
Pau Pérez Fabregat
3f53806ce3
Merge pull request #7397 from openfoodfoundation/transifex
...
Transifex
2021-04-12 13:16:17 +02:00
Transifex-Openfoodnetwork
a3b88c3279
Updating translations for config/locales/en_GB.yml
2021-04-12 18:39:35 +10:00
Transifex-Openfoodnetwork
e7d652b701
Updating translations for config/locales/en_GB.yml
2021-04-12 18:36:28 +10:00
Transifex-Openfoodnetwork
e1bacad726
Updating translations for config/locales/en_GB.yml
2021-04-12 18:33:15 +10:00
Pau Perez
5cf4aecc26
Enable customer_balance toggle in tests
...
This makes all tests exercise the new branch that `OrderBalance`
abstracts. It follows up #7363 addressing code review comments.
2021-04-12 09:31:23 +02:00
dependabot[bot]
23c45921de
Bump mini_racer from 0.3.1 to 0.4.0
...
Bumps [mini_racer](https://github.com/discourse/mini_racer ) from 0.3.1 to 0.4.0.
- [Release notes](https://github.com/discourse/mini_racer/releases )
- [Changelog](https://github.com/rubyjs/mini_racer/blob/master/CHANGELOG )
- [Commits](https://github.com/discourse/mini_racer/compare/v0.3.1...v0.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-12 05:51:04 +00:00
Andy Brett
e90420b581
Merge pull request #7363 from coopdevs/release-balances-to-all-users
...
Enable customer_balance feature toggle to all users
2021-04-11 21:50:15 -07:00
Andy Brett
14161ba329
Update all locales with the latest Transifex translations
2021-04-11 21:49:37 -07:00
Andy Brett
7283050bc9
Merge pull request #7389 from openfoodfoundation/transifex
...
Transifex
2021-04-11 21:46:11 -07:00
Maikel Linke
aeaaf8935e
Increase DB connection pool size for specs
...
A spec failed with this message:
ActiveRecord::ConnectionTimeoutError:
could not obtain a connection from the pool within 5.000 seconds (waited 5.000 seconds); all pooled connections were in use
The error seems to be raised when trying to authenticate the user
through Devise in a before_action block. Increasing the pool size by one
helped.
I don't know why our app needs more than 5 connections at the same time.
Maybe some gem "forgets" to release connections?
2021-04-12 12:15:59 +10:00
Transifex-Openfoodnetwork
b2d9b4a559
Updating translations for config/locales/de_DE.yml
2021-04-12 01:31:14 +10:00
Transifex-Openfoodnetwork
59754b227c
Updating translations for config/locales/de_DE.yml
2021-04-12 01:28:04 +10:00
Andy Brett
d00970e05d
Merge pull request #7207 from andrewpbrett/fix-nil-price-subs
...
Report subscription failures
2021-04-09 12:13:11 -07:00
Andy Brett
190050da17
Merge pull request #7288 from mkllnk/codeclimate
...
Use the same Rubocop config on Code Climate as locally
2021-04-09 09:32:15 -07:00
Pau Perez
95f29e4252
Remove outdated initializer specs
...
These no longer make sense since we're enabling customer_balance
unconditionally.
2021-04-09 10:22:21 +02:00
Pau Pérez Fabregat
0900bcadb2
Merge pull request #7330 from Matt-Yorkley/adjustments-deleted-originator
...
Update unscoping of deleted_at on Adjustment originator association
2021-04-09 09:15:46 +02:00
Pau Pérez Fabregat
92f45badac
Merge pull request #7340 from Matt-Yorkley/deleted-enterprise-fees
...
Add test coverage: deleted enterprise fees
2021-04-09 09:05:11 +02:00
Pau Pérez Fabregat
0e2855ea60
Merge pull request #7328 from Matt-Yorkley/dead-scope
...
Remove included_tax scope from Adjustment
2021-04-09 09:03:47 +02:00
Pau Perez
bac9f62132
Enable customer_balance to all users
...
This however makes the tests still pass, which rely on the off-branch
logic of the toggle. We'll work on them next.
2021-04-09 08:20:26 +02:00
Pau Pérez Fabregat
a902230106
Merge pull request #7316 from Matt-Yorkley/dead-code-shipments
...
DCOTW: #ensure_updated_shipments
2021-04-09 08:03:24 +02:00
ricchen
8c391251b3
added test case for alphabetically sorting
2021-04-08 23:57:33 -04:00
ricchen
61bb1bdcdc
fix incorrect last name sorting for packing report
2021-04-08 22:47:04 -04:00
Maikel Linke
1b14755401
Reduce AbcSize for rubocop
2021-04-09 12:15:47 +10:00
Maikel Linke
ce516db20f
Replace usage of Spree's action hooks with Rails
...
We don't need Spree's hooks any more and will remove them. Rails'
version is much simpler.
2021-04-09 12:04:31 +10:00
Cillian O'Ruanaidh
8a4e7d70a9
Pass in owner_id parameter correctly so admin/enterprises#create controller spec doesn't fail
2021-04-09 12:04:31 +10:00
Cillian O'Ruanaidh
a59a340fcd
Extract location map from registration form into its own partial, also add missing new lines
2021-04-09 12:04:31 +10:00
Cillian O'Ruanaidh
16b90cfc2e
Allow people to set enterprise latitude/longitude manually or automatically.
...
This for new changes to the enterprise registration/signup flow where a map will be displayed when people are filling in their address. On this map people can check the geocoder has geocoded their address correctly and if not they can manually adjust their latitude/longitude on the map.
But currently every time someone changes their address in the Admin > Enterprise > Address section the address would automatically be geocoded so this could overwrite the latitude/longitude that was set during sign up. To prevent the latitude/longitude from being overwritten this add's a checkbox which people need to explicity click if they want their address to be automatically geocoded, otherwise it will just use the manually configured latitude/longitude.
Note this new feature which allows people to select their location on a map during registration only works with Google maps so far. So if an instance is using Open Street Map this change also adds support for passing a :use_geocoder parameter to the Api::EnterprisesController during registration so that the address will be geocoded on the backend without the use of a map.
2021-04-09 12:03:12 +10:00
julesemmac
5e6ea31ad1
Improving user discover on ofn map
...
The context for this update is here: https://community.openfoodnetwork.org/t/improving-user-discovery-on-ofn-map/2013
Also with rebasing help from Maikel Linke <mkllnk@web.de >
2021-04-09 12:02:22 +10:00
Andy Brett
199efb1e20
Merge pull request #7351 from Matt-Yorkley/dead-code-discount-order
...
Dead code: DiscountOrder
2021-04-08 12:48:38 -07:00
Andy Brett
c6be9deb9b
Merge pull request #7352 from Matt-Yorkley/dead-code-api-helper
...
Dead code: Spree::Api::ApiHelpers
2021-04-08 12:48:22 -07:00
jibees
ca36996060
Merge pull request #7314 from Matt-Yorkley/order-payment-amount
...
Rename #charge_shipping_and_payment_fees! to #set_payment_amount!
2021-04-08 21:22:56 +02:00
Andy Brett
48f2ab7ad7
Revert "comment out flaky spec"
...
This reverts commit fc4634cd67 .
2021-04-08 11:07:30 -07:00
Matt-Yorkley
d1755acac5
Merge pull request #7355 from andrewpbrett/rspec-syntax
...
Update rspec syntax
2021-04-08 20:01:48 +02:00
Andy Brett
67d49b7486
Merge pull request #7342 from luisramos0/dead_code
...
[Rails 5.2] Delete dead code in variants list page, this is old spree logic
2021-04-08 10:47:02 -07:00
Andy Brett
b78ed85ad3
Merge pull request #7321 from Matt-Yorkley/remove-bugherd
...
Remove Bugherd
2021-04-08 10:35:17 -07:00
Luis Ramos
706b854d8c
Fix rspec syntax
2021-04-08 10:03:11 -07:00
Matt-Yorkley
99265bb75b
Merge pull request #7350 from filipefurtad0/feature_toggle_off_staging
...
Sets feature toggle off on staging, by default
2021-04-08 18:40:11 +02:00
Matt-Yorkley
d72cf18ec4
Merge pull request #7356 from andrewpbrett/fix-shipment-controller-spec
...
Fix failing shipments controller spec
2021-04-08 18:30:29 +02:00
Andy Brett
c3c482c0fe
fix failing spec
...
Another PR introduced a before_action to the controller, so we have to stub that out to avoid the double receiving an unexpected message
2021-04-08 08:53:35 -07:00
Andy Brett
9b3628a4dd
Merge pull request #7299 from andrewpbrett/line-item-fees
...
Update fees after changing a line item
2021-04-08 07:26:34 -07:00
Matt-Yorkley
704ed128cf
Merge pull request #7338 from gucci-ninja/7306-remove-arrows-from-number-input
...
Remove arrows on number input when adding items
2021-04-08 16:10:02 +02:00
Pau Pérez Fabregat
478c310d4a
Merge pull request #7325 from Matt-Yorkley/wkhtmltopdf
...
Remove wkhtmltopdf-binary version pin and bump gem
2021-04-08 15:23:59 +02:00
Matt-Yorkley
88df425b78
Remove Spree::Api::ApiHelpers
...
🔥
2021-04-08 12:53:17 +01:00
Matt-Yorkley
e1a10db410
Remove :tag_rule factory and update tests to use alternate (valid) factories
2021-04-08 12:37:45 +01:00
Matt-Yorkley
9a4bbacbaa
Update enterprises controller spec to use different (valid) TagRule class
2021-04-08 12:37:19 +01:00
Matt-Yorkley
80d43c714d
Remove TagRule::DiscountOrder
...
This class was removed from the UI in 2016 and hasn't been used since...
2021-04-08 12:37:17 +01:00
Matt-Yorkley
e61fe86d00
Merge pull request #7300 from andrewpbrett/on-demand-max-quantities
...
Allow any quantity if variant is set to on demand
2021-04-08 12:33:19 +02:00
Matt-Yorkley
034f452f4f
Merge pull request #7313 from jibees/7301-fix-line-breaks-on-cart-page
...
Add non-breaking space to avoid unwanted line breaks on unit price
2021-04-08 12:31:45 +02:00
filipefurtad0
4920db7f91
sets feature toggle off on staging, by default
2021-04-08 09:41:34 +01:00
Pau Pérez Fabregat
b00828cc46
Merge pull request #7311 from Matt-Yorkley/codecov-whitelisting
...
Exclude /lib/tasks/sample_data from CodeCov
2021-04-08 09:59:56 +02:00
Pau Pérez Fabregat
682cdc4ece
Merge pull request #7349 from andrewpbrett/fix-unit-price-nil-method
...
Guard against variants that use items but have scales
2021-04-08 09:56:48 +02:00
Pau Pérez Fabregat
953454e2fb
Merge pull request #7343 from luisramos0/dead_code_2
...
[Rails 5.2] Remove dead code
2021-04-08 09:48:25 +02:00
Pau Pérez Fabregat
27ac17f95e
Merge pull request #7344 from luisramos0/helpers
...
[Rails 5.2] Fix base helper spec in rails 52
2021-04-08 09:47:49 +02:00
Pau Pérez Fabregat
cd253c625e
Merge pull request #7317 from openfoodfoundation/transifex
...
Transifex
2021-04-08 09:42:11 +02:00
Transifex-Openfoodnetwork
26cf569f41
Updating translations for config/locales/es.yml
2021-04-08 17:18:54 +10:00
Transifex-Openfoodnetwork
0bd2f09c6f
Updating translations for config/locales/es.yml
2021-04-08 17:15:47 +10:00
Transifex-Openfoodnetwork
eb0cb6fe86
Updating translations for config/locales/es.yml
2021-04-08 17:12:38 +10:00
Transifex-Openfoodnetwork
629b289f84
Updating translations for config/locales/ca.yml
2021-04-08 17:07:19 +10:00
Transifex-Openfoodnetwork
20e22de40c
Updating translations for config/locales/en_FR.yml
2021-04-08 17:01:50 +10:00
Transifex-Openfoodnetwork
f241620682
Updating translations for config/locales/fr.yml
2021-04-08 17:01:40 +10:00
Andy Brett
2128675e95
Merge pull request #7236 from Matt-Yorkley/exchange-deadlocks
...
Update Exchange touch on Enterprise to use #touch_later
2021-04-07 20:54:03 -07:00
Andy Brett
a60b4a41c5
guard against variants that use items but have scales
2021-04-07 18:31:15 -07:00
Maikel
b83340ac45
Merge pull request #7287 from mkllnk/7166-cancelled-stock
...
Disallow changes of canceled order
2021-04-08 11:28:35 +10:00
Maikel Linke
42543bfaf7
Add flash when order cannot be changed
2021-04-08 09:24:39 +10:00
Maikel Linke
cf22a864f3
Fix typo in spec description
2021-04-08 09:24:39 +10:00
Maikel Linke
bfa5d443f1
Don't change canceled orders
...
We have a PR already that removes the UI for this when the order is
canceled. Implementing it on controller-side makes sure that it doesn't
happen accidentally if the user has multiple tabs open.
2021-04-08 09:24:39 +10:00
Maikel Linke
f0d5bf0ab5
Disallow changes of canceled order
2021-04-08 09:24:39 +10:00
Maikel Linke
f2a2cbd3f9
Spec stock bug when changing canceled orders
...
We decided to disallow changing canceled orders in a way that would
affect stock or totals.
2021-04-08 09:24:39 +10:00
Maikel Linke
8079fb0315
Add specs for stock changes
2021-04-08 09:24:39 +10:00
Maikel Linke
e1d22aec83
Prepare for more shipment specs with different context
...
This commit is best viewed ignoring whitespaces.
2021-04-08 09:24:39 +10:00
Maikel Linke
c5e72f8563
Test shipment changes more precisely
2021-04-08 09:24:39 +10:00
Maikel Linke
65b37b249d
Prepare spec code for re-use
2021-04-08 09:24:39 +10:00
Maikel Linke
d571bc731b
Style spec with rubocop -a
2021-04-08 09:24:39 +10:00
Luis Ramos
026c0640c4
Remove dead code
2021-04-07 23:31:43 +01:00
Luis Ramos
c33cf67ec7
Fix base helper spec in rails 52
2021-04-07 23:25:14 +01:00
Luis Ramos
ec6bb7f9fe
Delete dead code, this is old spree logic
2021-04-07 22:55:06 +01:00
gucci-ninja
d70c2b99fd
Remove arrows on number input when adding items
2021-04-07 14:32:29 -04:00
Matt-Yorkley
ea6540838a
Add test coverage for hard-deleted EnterpriseFee case when editing orders
2021-04-07 18:53:24 +01:00
Matt-Yorkley
d385c1ad4d
Soft-delete return authorizations
2021-04-07 18:11:06 +01:00
Matt-Yorkley
4043e19910
Add deleted_at to spree_return_authorizations
2021-04-07 18:10:07 +01:00
Matt-Yorkley
52c7abf1c0
Merge pull request #7334 from Matt-Yorkley/payment-reports-error
...
Fix outstanding balance sum in payment report
2021-04-07 13:47:45 +02:00
Matt-Yorkley
05b8b8e9db
Fix outstanding balance sum in payment report
2021-04-07 10:56:20 +01:00
Matt-Yorkley
2ed1aaf575
Update unscoping of deleted_at on originator association
2021-04-07 00:26:01 +01:00
Transifex-Openfoodnetwork
5e99294f79
Updating translations for config/locales/en_GB.yml
2021-04-07 08:33:57 +10:00
Transifex-Openfoodnetwork
0888658431
Updating translations for config/locales/fr.yml
2021-04-07 08:33:53 +10:00
Transifex-Openfoodnetwork
85cc9be07b
Updating translations for config/locales/en_GB.yml
2021-04-07 08:30:57 +10:00
Transifex-Openfoodnetwork
b34c2d3b9f
Updating translations for config/locales/ru.yml
2021-04-07 08:30:52 +10:00
Transifex-Openfoodnetwork
837130bebe
Updating translations for config/locales/it.yml
2021-04-07 08:30:49 +10:00
Transifex-Openfoodnetwork
480dc3d4b8
Updating translations for config/locales/fr.yml
2021-04-07 08:30:45 +10:00
Matt-Yorkley
1ce3103aa7
Merge pull request #6924 from Matt-Yorkley/adjustments-shipping-tax
...
[Adjustments] Shipping tax
2021-04-07 00:21:12 +02:00
Transifex-Openfoodnetwork
27ac53aabc
Updating translations for config/locales/it.yml
2021-04-07 05:33:40 +10:00
Transifex-Openfoodnetwork
ffc9da9972
Updating translations for config/locales/en_IE.yml
2021-04-07 05:33:35 +10:00
Transifex-Openfoodnetwork
1fa7035c2f
Updating translations for config/locales/it.yml
2021-04-07 05:30:33 +10:00
Transifex-Openfoodnetwork
cedbfbc8ea
Updating translations for config/locales/en_IE.yml
2021-04-07 05:30:29 +10:00
Transifex-Openfoodnetwork
3e26ccabeb
Updating translations for config/locales/ru.yml
2021-04-07 05:30:26 +10:00
Matt-Yorkley
4a65e5817f
Add fieldset title to shipping methods edit form
2021-04-06 20:30:07 +01:00
Matt-Yorkley
01e6397e27
Remove Spree::Config[:shipment_inc_vat]
...
This is now done per ShippingMethod instead of globally
2021-04-06 20:29:58 +01:00
Andy Brett
2c17d12f6e
Merge pull request #7303 from drummer83/independent-update-cart-label
...
Independent 'update cart' label
2021-04-06 10:59:06 -07:00
Andy Brett
2aeed30775
Merge pull request #7265 from andrewpbrett/freeze-adjustments
...
Don't allow edits to adjustments for canceled orders
2021-04-06 10:56:27 -07:00
Matt-Yorkley
61b41491fe
Remove included_tax scope from Adjustment
...
This scope is no longer used, and it's name is exactly the same as other method names and database columns on multiple objects, which is quite confusing.
2021-04-06 12:42:14 +01:00
Matt-Yorkley
5c0a968c27
Remove wkhtmltopdf-binary version pin and bump gem
...
Previously we were tied to a lower version that maintained compatibility with Ubuntu 14 (which we used in Semaphore). We can drop this version pin now and upgrade it. PDF tests should now pass locally if using Ubuntu 20 🎉
2021-04-05 16:16:25 +01:00
Andy Brett
271cc26066
Merge pull request #7319 from openfoodfoundation/dependabot/bundler/rubocop-1.12.1
...
Bump rubocop from 1.12.0 to 1.12.1
2021-04-05 08:14:35 -07:00
Transifex-Openfoodnetwork
3a45d2781a
Updating translations for config/locales/de_DE.yml
2021-04-06 01:10:34 +10:00
Matt-Yorkley
4a18ba256d
Add test for paypal controller redirect
2021-04-05 14:00:07 +01:00
Matt-Yorkley
03c36dfd7f
Remove Bugherd
...
🔥
2021-04-05 13:31:13 +01:00
Transifex-Openfoodnetwork
96f5adf0be
Updating translations for config/locales/en_GB.yml
2021-04-05 22:06:23 +10:00
dependabot[bot]
1320a12a16
Bump rubocop from 1.12.0 to 1.12.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.12.0...v1.12.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-05 05:50:26 +00:00
Andy Brett
c30ced2060
put Time.zone back
2021-04-04 12:27:46 -07:00
Transifex-Openfoodnetwork
788601ea02
Updating translations for config/locales/en_CA.yml
2021-04-05 04:54:25 +10:00
Matt-Yorkley
c702b398d6
Add warning comment on migration test isolation
2021-04-04 19:19:06 +01:00
Matt-Yorkley
3092397346
Isolate migration tests
2021-04-04 19:19:06 +01:00
Matt-Yorkley
a2f6ff7b39
Update deprecated params in checkout spec
2021-04-04 19:19:06 +01:00
Matt-Yorkley
76cf239623
Sort ids in test in case ordering is reversed
2021-04-04 19:19:06 +01:00
Matt-Yorkley
ea3044f47a
Bring in more explicit model code now that good_migrations disables all access to models
2021-04-04 19:19:06 +01:00
Matt-Yorkley
595389cbea
Update stripe spec
...
The hard-coded order total here was incorrect. It's now correctly including the $3 shipping fee used with that order factory, and the total is actually $13.
2021-04-04 19:19:06 +01:00
Matt-Yorkley
d00bdbe1b8
Add index on spree_shipping_methods.tax_category_id
2021-04-04 19:19:06 +01:00
Matt-Yorkley
4fbbbbca76
Load relevant tax rates in a single query outside of find_each block
2021-04-04 19:19:06 +01:00
Matt-Yorkley
e442187672
Delete unused private method OrderTaxAdjustmentsFetcher#table
2021-04-04 19:19:06 +01:00
Matt-Yorkley
821be3eef5
Update combined queries to use #or
2021-04-04 19:19:06 +01:00
Matt-Yorkley
96d8de35f2
Delete dead code Adjustment#set_included_tax!
2021-04-04 19:19:06 +01:00
Matt-Yorkley
fcdc627ce3
Add fallbacks in migration for migrating locally with RAILS_ENV=test
...
Instances have these preference values set, but when running this migration locally with RAILS_ENV=test, the preference does not exist in the database.
2021-04-04 19:19:06 +01:00
Matt-Yorkley
fec2b0b7c1
Define models in migration
2021-04-04 19:19:06 +01:00
Matt-Yorkley
903788903b
Remove Spree::Config[:shipping_tax_rate]
2021-04-04 19:19:06 +01:00
Matt-Yorkley
a26880a3a1
Update shipment tax fetching in Xero Invoices report
2021-04-04 19:19:06 +01:00
Matt-Yorkley
3c602cad97
Add unit tests for migration
2021-04-04 19:19:06 +01:00
Matt-Yorkley
eb3c2da740
Migrate shipping taxes to adjustments
2021-04-04 19:19:06 +01:00
Matt-Yorkley
63483818d7
Remove dead code
...
This spec is doing nothing...
2021-04-04 19:19:06 +01:00
Matt-Yorkley
56a01194cd
Update shipping tax adjustments specs
2021-04-04 19:19:06 +01:00
Matt-Yorkley
e81270d0d7
Fix adjustment test setups missing order associations
...
All adjustments must be associated with an order
2021-04-04 19:19:06 +01:00
Matt-Yorkley
bbd4a33a87
Tax adjustments should be open when created
...
All adjustments get closed during `order.finalize!`, but before that point they should be open.
2021-04-04 19:19:06 +01:00
Matt-Yorkley
6d48471368
Update shipment totals updating
2021-04-04 19:19:06 +01:00
Matt-Yorkley
ac67f7391e
Update tax charging in checkout flow
2021-04-04 19:19:06 +01:00
Matt-Yorkley
2ab9602ad7
Increase tested details in Order spec
2021-04-04 19:19:06 +01:00
Matt-Yorkley
d635d70add
Update Order::Updater adjustment handling
2021-04-04 19:19:06 +01:00
Matt-Yorkley
93771aeb94
Update orders spec
2021-04-04 19:19:06 +01:00
Matt-Yorkley
2f19428b40
Update orders controller
2021-04-04 19:19:06 +01:00
Matt-Yorkley
1f897b1e44
Update sales tax report spec
2021-04-04 19:19:06 +01:00
Matt-Yorkley
1d1b842e08
Delete dead code
2021-04-04 19:19:06 +01:00
Matt-Yorkley
889b357408
Update Order#total_tax
2021-04-04 19:19:06 +01:00
Matt-Yorkley
2af0afafe9
Update Order#shipping_tax
2021-04-04 19:19:06 +01:00
Matt-Yorkley
ead85e71de
Update shipping tax in checkout spec
2021-04-04 19:19:06 +01:00
Matt-Yorkley
a8366a3a72
Update Order::Updater totals counts
2021-04-04 19:19:06 +01:00
Matt-Yorkley
a060b9fe5a
Update LineItemsController and order factory
2021-04-04 19:19:06 +01:00
Matt-Yorkley
8b0a9ddb2f
Update OrderTaxAdjustmentsFetcher
2021-04-04 19:19:06 +01:00
Matt-Yorkley
7d3288ca53
Remove #to_package calls on shipment calculations
2021-04-04 19:19:06 +01:00
Matt-Yorkley
db07a73bd7
Ensure Adjustment#update! returns an amount
2021-04-04 19:19:06 +01:00
Matt-Yorkley
232286b0be
Add adjustment_total to spree_shipments
2021-04-04 19:19:06 +01:00
Matt-Yorkley
7e0aad7c7e
Adapt current tax setup to work with shipment taxes
...
This is a temporary step...
2021-04-04 19:19:06 +01:00
Matt-Yorkley
7425ad5c4a
Include ItemAdjustments handling in Adjustment class
...
Currently only applies to shipments, but will later include line items, etc
2021-04-04 19:19:06 +01:00
Matt-Yorkley
0d5d4aca11
Update tax_rate_factory
...
The amount is a decimal, so `0.1` here is actually a 10% tax rate. `100` is ridiculous (10000% tax).
Also, the factory fails without a calculator, and it should explicitly be a DefaultTax calculator or it will not be correct.
2021-04-04 19:19:06 +01:00
Matt-Yorkley
0fea92b63d
Add :default_tax_calculator factory
2021-04-04 19:19:06 +01:00
Matt-Yorkley
25a739ea75
Remove Shipment #update_adjustment_included_tax
2021-04-04 19:19:06 +01:00
Matt-Yorkley
385b12d83b
Add tax total fields to spree_shipments
2021-04-04 19:19:06 +01:00
Matt-Yorkley
9bbe57afda
Extract method
2021-04-04 19:19:06 +01:00
Matt-Yorkley
89889bc280
Record tax totals in ItemAdjustments
2021-04-04 19:19:06 +01:00
Matt-Yorkley
605a94e3c9
Use Spree::ItemAdjustments in Shipment callbacks for updating adjustments
2021-04-04 19:19:06 +01:00
Matt-Yorkley
ac9ecdfcbc
Introduce Spree::ItemAdjustments class
2021-04-04 19:19:06 +01:00
Matt-Yorkley
45f0082321
Add tax_category_id to shipping method permitted params
2021-04-04 19:19:06 +01:00
Matt-Yorkley
431706b704
Add tax_category_id to spree_shipping_methods
2021-04-04 19:19:06 +01:00
Matt-Yorkley
8fccdbf92f
Introduce TaxCategories to ShippingMethods
2021-04-04 19:19:06 +01:00
Transifex-Openfoodnetwork
180fa0beb0
Updating translations for config/locales/en_IE.yml
2021-04-04 08:34:05 +10:00
Transifex-Openfoodnetwork
953756bf2a
Updating translations for config/locales/en_US.yml
2021-04-04 08:34:04 +10:00
Transifex-Openfoodnetwork
875105373a
Updating translations for config/locales/it.yml
2021-04-04 08:31:04 +10:00
Transifex-Openfoodnetwork
2aa549fe33
Updating translations for config/locales/en_FR.yml
2021-04-04 08:31:00 +10:00
Transifex-Openfoodnetwork
33875a528f
Updating translations for config/locales/en_IE.yml
2021-04-04 08:30:59 +10:00
Transifex-Openfoodnetwork
ee056561eb
Updating translations for config/locales/fr.yml
2021-04-04 08:30:58 +10:00
Andy Brett
2ee15838d9
Merge pull request #7213 from Matt-Yorkley/optional-bullet
...
Make bullet activation optional
2021-04-03 13:48:21 -07:00
Andy Brett
b5846592b1
Merge pull request #7260 from jibees/7069-add-automated-tests-for-unit-price-in-backoffice
...
Add automated tests for unit price in backoffice
2021-04-03 13:43:32 -07:00
Andy Brett
f2e238d0ea
refactor view logic to helper
2021-04-03 13:33:09 -07:00
Matt-Yorkley
c895153b58
Remove dead code: #ensure_updated_shipments
2021-04-03 19:47:34 +01:00
Matt-Yorkley
e2e943e394
Update uses of checkout_state route
2021-04-03 19:13:41 +01:00
Matt-Yorkley
fe507f63fc
Move checkout_state route from spree to main_app
2021-04-03 19:13:41 +01:00
Andy Brett
5bfd6fd2ba
add spec for fee recalculation
2021-04-03 10:54:57 -07:00
Matt-Yorkley
dd73af8e7a
Remove duplicate checkout controller
2021-04-03 18:52:05 +01:00
Matt-Yorkley
cb0644ce47
Merge pull request #7312 from openfoodfoundation/transifex
...
Transifex
2021-04-03 17:32:13 +02:00
Matt-Yorkley
2d647be8b4
Rename #charge_shipping_and_payment_fees! to #set_payment_amount!
...
This method sets the order's payment amount during the checkout. It doesn't really have anything to do with shipping or payment fees...
2021-04-03 16:14:38 +01:00
Transifex-Openfoodnetwork
9b2255cb20
Updating translations for config/locales/en_US.yml
2021-04-03 14:03:44 +11:00
Transifex-Openfoodnetwork
1159c425b9
Updating translations for config/locales/en_US.yml
2021-04-03 14:03:09 +11:00
Andy Brett
c0cbd1e688
remove new adjustment button for canceled orders
2021-04-02 12:26:59 -07:00
filipefurtad0
a01493725d
Merge pull request #7309 from openfoodfoundation/filipefurtad0-add-QA-info
...
Update README.md
2021-04-02 16:00:16 +01:00
Jean-Baptiste Bellet
6756ffcf42
Add non-breaking space to avoid unwanted line breaks
2021-04-02 16:59:50 +02:00
Transifex-Openfoodnetwork
d7787261ed
Updating translations for config/locales/en_IE.yml
2021-04-03 01:54:41 +11:00
Matt-Yorkley
d68b73dd07
Exclude /lib/tasks/sample_data from CodeCov
...
We will almost certainly *never* invest the required amount of dev time to cover all this non-critical code with tests, so we may as well drop it from the report.
2021-04-02 15:50:01 +01:00
filipefurtad0
857611d232
Update README.md
...
Adding a line about our new QAs board.
2021-04-02 15:23:15 +01:00
Jean-Baptiste Bellet
9126901578
Add missing key for unit price in new variant form
2021-04-02 15:22:01 +02:00
Jean-Baptiste Bellet
abd2d3f46f
Add tests around unit price in backoffice
...
3 cases:
- creating a new product
- creating a new variant
- editing an existing variant
2021-04-02 15:22:01 +02:00
Jean-Baptiste Bellet
608a28316c
Specify right for attribute for <label /> element
...
- So, `<label />` is rightly linked to its `<input />`
2021-04-02 15:22:01 +02:00
Jean-Baptiste Bellet
76fbb2be84
Use custom input text (instead of :price one)
...
- Use `variant_unit_price` for `id` attribute and `variant[unit_price]` for `name` attribute
- Previously, there was an duplicated `#id` on the page because we used `:price`
2021-04-02 15:22:01 +02:00
Pau Perez
d7cadde0a1
Update all locales with the latest Transifex translations
2021-04-02 11:55:52 +02:00
Konrad
7c47102869
Use new independent label for 'update cart'
...
orders_form_update_cart
2021-04-01 23:30:00 +02:00
Konrad
221a7ce402
Add independent string for 'update cart'
...
orders_form_update_cart
2021-04-01 23:29:02 +02:00
Pau Pérez Fabregat
003b45d4b9
Merge pull request #7294 from Matt-Yorkley/balance-missing-methods
...
OrderBalance missing methods
2021-04-01 19:34:57 +02:00
Andy Brett
1eb5ee9266
Merge pull request #7174 from Matt-Yorkley/dead-code-callbacks
...
Remove Spree ResourceController callbacks
2021-04-01 07:24:44 -07:00
Andy Brett
a9c7f84bd3
Merge pull request #7197 from guidoDutra/5916-fix-content-moves-when-cart-open
...
fix content moving when cart is open
2021-04-01 07:23:32 -07:00
Andy Brett
4efcd8457c
Merge pull request #7227 from jibees/7215-fix-page-content-up/down-move-when-opening-the-unit-price-tooltip
...
Add some CSS specification to avoid page content up/down move
2021-04-01 07:21:13 -07:00
Andy Brett
8261a33ae4
Merge pull request #7226 from jibees/7223-fix-display-issue-on-unit-price-tooltip-in-cart-sidebar-
...
Add 'context' variable: used to specify display of the unit price tooltip inside cart sidebar
2021-04-01 07:20:46 -07:00
Andy Brett
7312341fc4
Merge pull request #7233 from jibees/7224-add-unit-price-to-previously-orders-in-the-cart-page
...
Add unit price for already bought products in cart page
2021-04-01 07:19:36 -07:00
Matt-Yorkley
f94fe452f0
Merge pull request #7191 from mkllnk/fix-deprecation-gateway-mode
...
Replace ActiveMerchant's deprecated gateway_mode
2021-04-01 13:29:10 +02:00
Matt-Yorkley
2292deebe6
Merge pull request #7232 from mkllnk/7231-timeout
...
Keep status bar with message without auto-close
2021-04-01 13:23:12 +02:00
Andy Brett
9f0f88de4e
allow any quantity if variant is set to on demand
2021-03-31 22:02:32 -07:00
Maikel
3f4b97d006
Merge pull request #7289 from coopdevs/setup-codecov
...
Add code coverage reporting to our CI build with Codecov
2021-04-01 12:23:33 +11:00
Andy Brett
38f5bfdca2
update fees after changing a line item
2021-03-31 14:17:10 -07:00
Matt-Yorkley
c40928d805
Merge pull request #7167 from Matt-Yorkley/adjustments-returns
...
[Adjustments] Update return adjustments
2021-03-31 21:33:45 +02:00
Andy Brett
7b391adbac
Merge pull request #7290 from openfoodfoundation/dependabot/bundler/i18n-1.8.10
...
Bump i18n from 1.8.9 to 1.8.10
2021-03-31 09:25:06 -07:00
Matt-Yorkley
93efd3ab8f
Merge pull request #7291 from openfoodfoundation/transifex
...
Transifex
2021-03-31 18:00:36 +02:00
Transifex-Openfoodnetwork
29d3c61b52
Updating translations for config/locales/en_FR.yml
2021-04-01 01:25:28 +11:00
Transifex-Openfoodnetwork
b6b07328ee
Updating translations for config/locales/ru.yml
2021-04-01 01:16:03 +11:00
Transifex-Openfoodnetwork
35f6f8e73d
Updating translations for config/locales/fr.yml
2021-04-01 00:32:08 +11:00
Matt-Yorkley
bb0cf65ecc
Handle OrderBalance comparison operators
...
These operators get used on the object returned by order_balance in a few places, and were not working correctly.
2021-03-31 13:23:13 +01:00
Matt-Yorkley
a02c505e62
Delegate #to_f and #to_d to #amount in OrderBalance
2021-03-31 13:23:13 +01:00
Matt-Yorkley
77506caca1
Rename OrderBalance methods for clarity
2021-03-31 13:09:17 +01:00
Transifex-Openfoodnetwork
ff82d37a40
Updating translations for config/locales/it.yml
2021-03-31 21:08:45 +11:00
Pau Pérez Fabregat
958023d6da
Merge pull request #7183 from filipefurtad0/variant_unit_scale_spec
...
Covers unit variant changes; adds test to #7180
2021-03-31 11:21:49 +02:00
Pau Perez
7857487bbb
Add coverage badge to README
2021-03-31 10:39:29 +02:00
Pau Perez
8a5762afba
Remove minimum coverage
...
This clashes with Codecov coverage uploading. If the tests fail chances
are that they didn't hit the threshold and thus, won't be uploaded to
Codecov.
2021-03-31 10:02:50 +02:00
Pau Perez
b2840aaebf
Enable coverage in CI and use Codecov formatter
2021-03-31 10:02:50 +02:00
dependabot[bot]
e43f98405a
Bump i18n from 1.8.9 to 1.8.10
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.8.9 to 1.8.10.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.8.9...v1.8.10 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-31 07:45:51 +00:00
Pau Perez
756b3a6ee5
Upload coverage report after every CI job
2021-03-31 08:56:58 +02:00
Maikel Linke
8f79fe2768
Use the same config on Code Climate as locally
...
We configured Code Climate to be aware of all open issues instead of
ignoring open issues via the rubocop todo lists. We were hoping that
Code Climate could give us some nice stats like progress if it's aware
of all our open issues. But the graphs don't tell us anything. So it's
better to have one source of truth for our open style issues and that is
our rubocop config in this repository. It contains two todo lists that
document all violations we would like to fix in the future but it's okay
to submit pull requests that don't fix those.
Instead of accepting new style issues in Code Climate, every pull
request with new violations has to add them to the rubocop config. I
hope that this will make rubocop more useful and encourage developers to
reduce code style debt.
2021-03-31 15:25:19 +11:00
Maikel Linke
f8ba256ebf
Use bundled version in CodeClimate
2021-03-31 15:22:33 +11:00
Pau Pérez Fabregat
9c468f0557
Merge pull request #7240 from Matt-Yorkley/escalating-paranoia
...
Escalating paranoia
2021-03-30 22:24:13 +02:00
Matt-Yorkley
f3347229fb
Add Variant#default_price test coverage for soft-deletion
2021-03-30 20:25:37 +01:00
Pau Pérez Fabregat
7e255442a5
Merge pull request #7262 from openfoodfoundation/transifex
...
Transifex
2021-03-30 19:52:45 +02:00
Andy Brett
02009ed48b
Merge pull request #7270 from openfoodfoundation/dependabot/bundler/ddtrace-0.47.0
...
Bump ddtrace from 0.46.0 to 0.47.0
2021-03-30 10:51:22 -07:00
Matt-Yorkley
3f14694b2b
Merge pull request #6960 from andrewpbrett/namespace-api
...
Namespace existing API endpoints to api/v0/*
2021-03-30 19:45:27 +02:00
Pau Pérez Fabregat
d34dd30e51
Merge pull request #7268 from openfoodfoundation/dependabot/bundler/simplecov-0.21.2
...
Bump simplecov from 0.18.5 to 0.21.2
2021-03-30 19:17:16 +02:00
Andy Brett
0954a13f55
Merge pull request #7273 from openfoodfoundation/dependabot/bundler/angular_rails_csrf-4.5.0
...
Bump angular_rails_csrf from 4.2.0 to 4.5.0
2021-03-30 10:01:04 -07:00
Andy Brett
38cba66207
Merge pull request #7272 from openfoodfoundation/dependabot/bundler/activemerchant-1.119.0
...
Bump activemerchant from 1.107.4 to 1.119.0
2021-03-30 09:59:41 -07:00
dependabot[bot]
0d935725e2
Bump angular_rails_csrf from 4.2.0 to 4.5.0
...
Bumps [angular_rails_csrf](https://github.com/jsanders/angular_rails_csrf ) from 4.2.0 to 4.5.0.
- [Release notes](https://github.com/jsanders/angular_rails_csrf/releases )
- [Changelog](https://github.com/jsanders/angular_rails_csrf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jsanders/angular_rails_csrf/compare/4.2.0...v4.5.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 16:43:35 +00:00
Andy Brett
b799a1777f
Merge pull request #7271 from openfoodfoundation/dependabot/bundler/acts_as_list-1.0.3
...
Bump acts_as_list from 0.9.19 to 1.0.3
2021-03-30 09:42:42 -07:00
Andy Brett
3fb2e503f5
Merge pull request #7275 from openfoodfoundation/dependabot/bundler/factory_bot_rails-6.1.0
...
Bump factory_bot_rails from 5.2.0 to 6.1.0
2021-03-30 09:39:37 -07:00
Matt-Yorkley
cd6ef9e274
Merge pull request #7269 from openfoodfoundation/dependabot/bundler/bugsnag-6.20.0
...
Bump bugsnag from 6.19.0 to 6.20.0
2021-03-30 18:13:02 +02:00
dependabot[bot]
ce83be4eac
Bump factory_bot_rails from 5.2.0 to 6.1.0
...
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails ) from 5.2.0 to 6.1.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases )
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v5.2.0...v6.1.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 16:04:36 +00:00
Andy Brett
aac4a17c1f
Merge pull request #7274 from openfoodfoundation/dependabot/bundler/test-prof-1.0.2
...
Bump test-prof from 0.11.3 to 1.0.2
2021-03-30 09:01:24 -07:00
dependabot[bot]
0eaa4aeb62
Bump activemerchant from 1.107.4 to 1.119.0
...
Bumps [activemerchant](https://github.com/activemerchant/active_merchant ) from 1.107.4 to 1.119.0.
- [Release notes](https://github.com/activemerchant/active_merchant/releases )
- [Changelog](https://github.com/activemerchant/active_merchant/blob/master/CHANGELOG )
- [Commits](https://github.com/activemerchant/active_merchant/compare/v1.107.4...v1.119.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 16:00:49 +00:00
Andy Brett
880075729d
Merge pull request #7267 from openfoodfoundation/dependabot/bundler/capybara-3.35.3
...
Bump capybara from 3.32.2 to 3.35.3
2021-03-30 08:59:37 -07:00
Andy Brett
dee2004305
Merge pull request #7276 from openfoodfoundation/dependabot/bundler/ffaker-2.18.0
...
Bump ffaker from 2.16.0 to 2.18.0
2021-03-30 08:58:12 -07:00
Andy Brett
57035ae0cc
Merge pull request #7277 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.3.2
...
Bump karma from 6.3.1 to 6.3.2
2021-03-30 08:57:35 -07:00
Matt-Yorkley
b6b367c378
Add return adjustments test in checkout helper
2021-03-30 16:41:23 +01:00
Matt-Yorkley
d447864b7e
Update test description
2021-03-30 16:39:40 +01:00
Matt-Yorkley
08491d9ad4
Use an instance double in #compute_amount test
2021-03-30 16:39:40 +01:00
Matt-Yorkley
7882c427f7
Simplify creation of negative amounts
2021-03-30 16:39:40 +01:00
Matt-Yorkley
dbe227bd41
Use #change in adjustment spec with changing value
2021-03-30 16:39:40 +01:00
Matt-Yorkley
e71f47a2e3
Use underscore in unused arguments
2021-03-30 16:39:40 +01:00
Matt-Yorkley
4b4f29641e
Add test for ReturnAuthorization#compute_amount override
2021-03-30 16:39:40 +01:00
Matt-Yorkley
fcb8145a6c
Bring in changes to Adjustment#update! and CalculatedAdjustments#update_adjustment
2021-03-30 16:39:40 +01:00
Matt-Yorkley
c480d43bda
Override #compute_amount in ReturnAuthorization
...
In some cases adjustments are updated (recalculated) via their originator. In the case of return adjustments, there's no calculation (and no calculator).
2021-03-30 16:39:40 +01:00
Matt-Yorkley
4c5ecbc2d4
Migrate return adjustments source to originator
2021-03-30 16:39:40 +01:00
Matt-Yorkley
3c1883dac2
Remove use of :source polymorphic association for return adjustments
2021-03-30 16:39:40 +01:00
Matt-Yorkley
8db598bff7
Simplify return adjustment creation
2021-03-30 16:39:40 +01:00
Andy Brett
a67038720c
Merge pull request #7255 from mkllnk/fail-on-translations
...
Raise errors in specs with missing translations
2021-03-30 08:37:15 -07:00
Matt-Yorkley
74ba6e35be
Merge pull request #7283 from Matt-Yorkley/unit-price-nils
...
Defend against nils in variant serializer
2021-03-30 17:00:26 +02:00
Transifex-Openfoodnetwork
42efb6f762
Updating translations for config/locales/fr_CA.yml
2021-03-31 01:10:30 +11:00
Pau Pérez Fabregat
7d5726b6c7
Merge pull request #7150 from coopdevs/use-order-balance-object
...
Feature-toggle all remaining parts of the app where the order balance is shown
2021-03-30 15:58:12 +02:00
Matt-Yorkley
741dee29c3
Defend against nils in variant serializer
...
If unit_price.denominator ever returns nil, the serializer won't explode now.
2021-03-30 14:45:33 +01:00
Transifex-Openfoodnetwork
a41852ee7a
Updating translations for config/locales/en_CA.yml
2021-03-31 00:41:40 +11:00
Guido Oliveira
877d76cf19
fix display scrollbar only if needed
2021-03-30 10:05:04 -03:00
Matt-Yorkley
153ec268b7
Remove RackRequestBlocker
2021-03-30 13:24:44 +01:00
Matt-Yorkley
92eaf5fbaa
Remove atomic gem
...
Bundler says this when installing gems:
```
Post-install message from atomic:
This gem has been deprecated and merged into Concurrent Ruby (http://concurrent-ruby.com ).
```
We already have concurrent-ruby 👍
2021-03-30 12:29:48 +01:00
Maikel Linke
0980b81742
Raise errors in specs with missing translations
...
The previous mechanism didn't seem to work and newer Rails versions have
an easier config for this now.
Also fixing all i18n errors which were now failing specs.
2021-03-30 17:08:17 +11:00
dependabot[bot]
30df1cc55d
Bump karma from 6.3.1 to 6.3.2
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.3.1 to 6.3.2.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.1...v6.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:55:35 +00:00
Andy Brett
61a39311b4
improve specs
2021-03-29 22:51:40 -07:00
dependabot[bot]
c05a9cfb40
Bump ffaker from 2.16.0 to 2.18.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 2.16.0 to 2.18.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/main/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/compare/v2.16.0...v2.18.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:35:24 +00:00
dependabot[bot]
adff08038a
Bump test-prof from 0.11.3 to 1.0.2
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 0.11.3 to 1.0.2.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v0.11.3...v1.0.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:33:19 +00:00
dependabot[bot]
e8bc1f5aca
Bump acts_as_list from 0.9.19 to 1.0.3
...
Bumps [acts_as_list](https://github.com/brendon/acts_as_list ) from 0.9.19 to 1.0.3.
- [Release notes](https://github.com/brendon/acts_as_list/releases )
- [Changelog](https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md )
- [Commits](https://github.com/brendon/acts_as_list/compare/v0.9.19...v1.0.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:24:11 +00:00
dependabot[bot]
ab3b36ac0b
Bump ddtrace from 0.46.0 to 0.47.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.46.0 to 0.47.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.46.0...v0.47.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:23:19 +00:00
dependabot[bot]
1a25fb78df
Bump bugsnag from 6.19.0 to 6.20.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.19.0 to 6.20.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.19.0...v6.20.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:21:06 +00:00
dependabot[bot]
e7e337f0aa
Bump simplecov from 0.18.5 to 0.21.2
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.18.5 to 0.21.2.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.18.5...v0.21.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:19:27 +00:00
dependabot[bot]
65f9454760
Bump capybara from 3.32.2 to 3.35.3
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.32.2 to 3.35.3.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.32.2...3.35.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-30 05:18:12 +00:00
Andy Brett
8867f1ef7a
refactor responsibilities and order of operations
2021-03-29 15:37:30 -07:00
Andy Brett
3664b86e03
ignore long module in rubocop
2021-03-29 14:53:13 -07:00
Andy Brett
d0d3b73257
add specs
2021-03-29 14:53:13 -07:00
Andy Brett
9d2fd373ce
record subscription issue if no order is generated
2021-03-29 14:53:13 -07:00
Andy Brett
32c0f6777a
don't allow edits to adjustments for canceled orders
2021-03-29 14:27:46 -07:00
Transifex-Openfoodnetwork
9094a133d6
Updating translations for config/locales/de_DE.yml
2021-03-30 06:13:32 +11:00
filipefurtad0
9092b60229
turns testcases into shared examples
2021-03-29 20:00:04 +01:00
Matt-Yorkley
4bddc59696
Merge pull request #7247 from luisramos0/ruby25
...
Upgrade to ruby 2.5.8
2021-03-29 20:21:42 +02:00
Matt-Yorkley
9c2010a43e
Update SubscriptionLineItem#variant
2021-03-29 18:41:09 +01:00
Matt-Yorkley
558457993a
Update Price#variant
2021-03-29 18:41:09 +01:00
Matt-Yorkley
2c1305b99e
Update StockItem#variant
2021-03-29 18:41:09 +01:00
Matt-Yorkley
9f4b825d46
Update InventoryUnit#variant
2021-03-29 18:41:09 +01:00
Matt-Yorkley
eccfcbc396
Update Variant#default_price
2021-03-29 18:41:09 +01:00
Guido Oliveira
dcb5b36859
refactor scroll logic
2021-03-29 14:17:33 -03:00
Guido Oliveira
f004cc5b91
fix content resizing in some browsers
2021-03-29 14:14:39 -03:00
Andy Brett
2be04cc25c
Merge pull request #7263 from Matt-Yorkley/mailer-bug
...
Fix showing soft-deleted products in producer mailer
2021-03-29 09:55:13 -07:00
Pau Pérez Fabregat
e5b1af131f
Merge pull request #7261 from coopdevs/remove-semaphore-ci-badge
...
Remove Semaphore CI badge
2021-03-29 18:40:51 +02:00
Matt-Yorkley
707876820a
Fix showing soft-deleted products in producer mailer
...
The test at `spec/mailers/producer_mailer_spec.rb:115` was failing but we missed it before, as the CI was not reporting failures in some jobs.
2021-03-29 17:31:10 +01:00
Transifex-Openfoodnetwork
5fe8f89e32
Updating translations for config/locales/ca.yml
2021-03-30 03:29:44 +11:00
Transifex-Openfoodnetwork
42803e7a0f
Updating translations for config/locales/en_FR.yml
2021-03-30 03:29:41 +11:00
Transifex-Openfoodnetwork
05d38efd8c
Updating translations for config/locales/es.yml
2021-03-30 03:29:39 +11:00
Transifex-Openfoodnetwork
e38336693a
Updating translations for config/locales/en_FR.yml
2021-03-30 03:06:10 +11:00
Transifex-Openfoodnetwork
f70473677b
Updating translations for config/locales/fr.yml
2021-03-30 03:06:05 +11:00
Transifex-Openfoodnetwork
25abf46599
Updating translations for config/locales/es.yml
2021-03-30 02:36:17 +11:00
Transifex-Openfoodnetwork
f0365790d6
Updating translations for config/locales/ca.yml
2021-03-30 02:36:03 +11:00
Pau Perez
2e2e9918a9
Remove Semaphore CI badge
...
We're now relying on Github Actions as CI build so that's the only
indicator we should check to see if the build is passing in `master`.
2021-03-29 16:28:04 +02:00
Pau Pérez Fabregat
fe3013b0b9
Merge pull request #7250 from drummer83/independent-shopping-tabs
...
Independent shopping tabs
2021-03-29 16:26:01 +02:00
Maikel Linke
02703053bc
Keep status bar with message without auto-close
...
The message would disappear after five seconds which can be confusing
for the user (they may miss an important message) and makes our specs
flaky.
2021-03-29 11:12:40 +11:00
Konrad
a4f9706082
Use independent strings for shopping tabs
...
shopping_tabs_producers
shopping_tab_groups
2021-03-29 00:34:16 +02:00
Konrad
9f4d2b27bd
Add indepentend strings for shopping tabs
...
shopping_tabs_producers
shopping_tabs_groups
2021-03-29 00:32:32 +02:00
Luis Ramos
e450fe95a1
Upgrade to ruby 2.5.8
2021-03-27 19:16:32 +00:00
Andy Brett
d92510db56
fix some easy rubocop offenses
2021-03-27 11:21:18 -07:00
Andy Brett
025f1f2725
add routing tests
2021-03-27 11:21:18 -07:00
Andy Brett
51d075166a
match any API version
2021-03-27 11:21:18 -07:00
Andy Brett
0b9c62284a
only match v0 immediately following api/ in the path
2021-03-27 11:21:18 -07:00
Andy Brett
ef38abed28
preserve GET params in url
2021-03-27 11:21:18 -07:00
Andy Brett
5a19a14042
rename to v0
2021-03-27 11:21:18 -07:00
Matt-Yorkley
881e6dbac7
Add more explicit touch spec for Exchange -> Enterprise
2021-03-26 13:01:33 +00:00
Matt-Yorkley
45a06a300e
Update Exchange touch on Enterprise to use touch_later
...
This can improve issues with deadlocks where multiple touch calls are triggered in a single update, for example where an exchange touches it's parent enterprise on save, and we do this:
oc_with_lots_of_exchanges.exchanges.each{|ex| ex.clone! }
2021-03-26 12:44:50 +00:00
Jean-Baptiste Bellet
0ea085a275
Add unit prices for already bought product in cart page
2021-03-26 09:49:28 +01:00
Jean-Baptiste Bellet
2b93814fb1
Add context inside scope: used to specify display
...
- Context is used to customize some CSS specifications as sometimes display can be different (depending on the context)
- variant variable was not used: copy/paste error
2021-03-26 09:11:42 +01:00
Jean-Baptiste Bellet
2849f18313
Add some CSS specification to avoid page content up/down move
...
- Use `display: flex`
- Improve the display of the blue cross by a better alignement into the circle
2021-03-25 23:21:26 +01:00
Matt-Yorkley
f684b5b234
Make bullet activation optional
...
This should speed up CI, and still makes it easy to use when needed.
2021-03-25 15:36:51 +00:00
Guido Oliveira
6f340174d3
fix content moving when cart is open
2021-03-24 08:29:37 -03:00
Maikel Linke
b27ecb3465
Replace ActiveMerchant's deprecated gateway_mode
...
It's now just called `mode`. This avoids the warning:
../app/models/spree/gateway.rb:31:in `provider': Base#gateway_mode is deprecated in favor of Base#mode and will be removed in a future version
2021-03-24 15:27:44 +11:00
filipefurtad0
36ab3825e9
covers unit variant changes; adds test to #7180
2021-03-23 15:30:15 +00:00
Pau Perez
c7b85a3591
Sum balances in Payments report implementing #+
...
This avoids consumers of `OrderBalance` having to couple with the inner
details of this abstraction, which makes the code more changeable.
2021-03-23 09:28:40 +01:00
Pau Perez
1a1552a6ed
Make OrderUpdater use new balance implementation
...
In this class we properly calculated the balance taking into account the
orders in cancellation state so we need to use the new implementation if
we don't want to introduce a regression by using
`#old_oustanding_balance`.
I was initially a bit dubious because this method was checking
`order.payments` as well but now I see that was redundant. Is on
`payment_total` to take into account whether or not the order is paid or
any other payment related details.
2021-03-22 11:45:12 +01:00
Pau Perez
f494b720f8
Fix spec
2021-03-22 11:45:12 +01:00
Pau Perez
9762275555
Use old_outstanding_balance on disabled toggle
...
No need to go through the `OrderBalance` in this context since we
already check for the toggle.
2021-03-22 11:45:12 +01:00
Pau Perez
5082b6dc99
Make BalanceCalculator use old balance calculation
...
This class is currently used and it gets skipped when the
:customer_balance toggle is enabled, so there's no point on abstracting
the balance with `OrderBalance`. It'll never go through its
`#new_outstanding_balance` branch and it'll be removed once we active
that toggle to everyone.
2021-03-22 11:45:12 +01:00
Pau Perez
5815d1a4a4
Make #outstanding_balance return an OrderBalance
...
This will let us branch by abstraction. All existing calls to
`#outstanding_balance` will go through `OrderBalance` hence, will
check the feature toggle.
Note that by default, `OrderBalance` will end up calling
`#old_outstanding_balance`. As the name states, that's exactly what
`#outstanding_balance` was so far. This means no consumers will see any
change in behavior. We just added on item in the call stack (sort of).
2021-03-22 11:45:12 +01:00
Matt-Yorkley
50e0d78c0c
Remove dead callback invocations
2021-03-21 14:06:23 +00:00
Matt-Yorkley
0da90ab834
Update schedules controller callbacks
2021-03-21 14:06:01 +00:00
Matt-Yorkley
6c17680423
Update return authorizations controller callbacks
2021-03-21 14:06:01 +00:00
Matt-Yorkley
365dc2a49e
Update payment methods controller callback
2021-03-21 14:05:57 +00:00
Matt-Yorkley
a70b2a12d1
Update variants controller callback
2021-03-21 13:25:32 +00:00
Matt-Yorkley
a82bae2a46
Remove Spree resource controller custom callbacks
2021-03-21 13:25:32 +00:00
Cillian O'Ruanaidh
31f737422c
Pass in owner_id parameter correctly so admin/enterprises#create controller spec doesn't fail
2021-03-19 22:21:47 +00:00
Cillian O'Ruanaidh
4e1eefa877
Extract location map from registration form into its own partial, also add missing new lines
2021-03-19 21:43:29 +00:00
Cillian O'Ruanaidh
f20cea7e4f
Allow people to set enterprise latitude/longitude manually or automatically.
...
This for new changes to the enterprise registration/signup flow where a map will be displayed when people are filling in their address. On this map people can check the geocoder has geocoded their address correctly and if not they can manually adjust their latitude/longitude on the map.
But currently every time someone changes their address in the Admin > Enterprise > Address section the address would automatically be geocoded so this could overwrite the latitude/longitude that was set during sign up. To prevent the latitude/longitude from being overwritten this add's a checkbox which people need to explicity click if they want their address to be automatically geocoded, otherwise it will just use the manually configured latitude/longitude.
Note this new feature which allows people to select their location on a map during registration only works with Google maps so far. So if an instance is using Open Street Map this change also adds support for passing a :use_geocoder parameter to the Api::EnterprisesController during registration so that the address will be geocoded on the backend without the use of a map.
2021-03-19 21:43:29 +00:00
julesemmac
971971803e
Improving user discover on ofn map
...
The context for this update is here: https://community.openfoodnetwork.org/t/improving-user-discovery-on-ofn-map/2013
Also with rebasing help from Maikel Linke <mkllnk@web.de >
2021-03-19 21:43:29 +00:00