Make method stick to Boolean instead of Nil

This commit is contained in:
Pau Perez
2021-04-16 13:23:25 +02:00
parent e30ddf3f77
commit 5087ca709a
2 changed files with 4 additions and 4 deletions

View File

@@ -733,7 +733,7 @@ module Spree
end
def require_customer?
return if new_record? || state == 'cart'
return false if new_record? || state == 'cart'
true
end

View File

@@ -923,7 +923,7 @@ describe Spree::Order do
let(:state) { "complete" }
it "returns true" do
expect(order.send(:require_customer?)).to eq(nil)
expect(order.send(:require_customer?)).to eq(false)
end
end
@@ -931,7 +931,7 @@ describe Spree::Order do
let(:state) { "cart" }
it "returns false" do
expect(order.send(:require_customer?)).to eq(nil)
expect(order.send(:require_customer?)).to eq(false)
end
end
end
@@ -951,7 +951,7 @@ describe Spree::Order do
let(:state) { "cart" }
it "returns false" do
expect(order.send(:require_customer?)).to eq(nil)
expect(order.send(:require_customer?)).to eq(false)
end
end
end