From 5087ca709ade6b1c213ea5c8ff4b15a60d3e475f Mon Sep 17 00:00:00 2001
From: Pau Perez <saulopefa@gmail.com>
Date: Fri, 16 Apr 2021 13:23:25 +0200
Subject: [PATCH] Make method stick to Boolean instead of Nil

---
 app/models/spree/order.rb       | 2 +-
 spec/models/spree/order_spec.rb | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb
index 6fa9c152e5..ba4e819d00 100644
--- a/app/models/spree/order.rb
+++ b/app/models/spree/order.rb
@@ -733,7 +733,7 @@ module Spree
     end
 
     def require_customer?
-      return if new_record? || state == 'cart'
+      return false if new_record? || state == 'cart'
       true
     end
 
diff --git a/spec/models/spree/order_spec.rb b/spec/models/spree/order_spec.rb
index 6cbce7875d..06592594ff 100644
--- a/spec/models/spree/order_spec.rb
+++ b/spec/models/spree/order_spec.rb
@@ -923,7 +923,7 @@ describe Spree::Order do
         let(:state) { "complete" }
 
         it "returns true" do
-          expect(order.send(:require_customer?)).to eq(nil)
+          expect(order.send(:require_customer?)).to eq(false)
         end
       end
 
@@ -931,7 +931,7 @@ describe Spree::Order do
         let(:state) { "cart" }
 
         it "returns false" do
-          expect(order.send(:require_customer?)).to eq(nil)
+          expect(order.send(:require_customer?)).to eq(false)
         end
       end
     end
@@ -951,7 +951,7 @@ describe Spree::Order do
         let(:state) { "cart" }
 
         it "returns false" do
-          expect(order.send(:require_customer?)).to eq(nil)
+          expect(order.send(:require_customer?)).to eq(false)
         end
       end
     end