raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't pluck variant_ids multiple times (once for each line item)

Browse Source
This commit is contained in:
Matt-Yorkley
2021-05-11 01:45:54 +01:00
parent 1fff81c214
commit 0fabb5bc2f
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/spree/shipment.rb
View File

@@ -185,7 +185,8 @@ module Spree
def line_items
if order.complete?
order.line_items.select { |li| inventory_units.pluck(:variant_id).include?(li.variant_id) }
inventory_unit_ids = inventory_units.pluck(:variant_id)
order.line_items.select { |li| inventory_unit_ids.include?(li.variant_id) }
else
order.line_items
end