Rename payments helper

.rubocop_todo.yml

@@ -931,7 +931,6 @@ Style/FrozenStringLiteralComment:
     - 'app/helpers/spree/admin/base_helper.rb'
     - 'app/helpers/spree/admin/general_settings_helper.rb'
     - 'app/helpers/spree/admin/orders_helper.rb'
-    - 'app/helpers/spree/admin/payments_helper.rb'
     - 'app/helpers/spree/admin/taxons_helper.rb'
     - 'app/helpers/spree/admin/zones_helper.rb'
     - 'app/helpers/spree/orders_helper.rb'

app/helpers/spree/admin/payments_helper.rb

@@ -1,11 +0,0 @@
-module Spree
-  module Admin
-    module PaymentsHelper
-      def payment_method_name(payment)
-        # hack to allow us to retrieve the name of a "deleted" payment method
-        id = payment.payment_method_id
-        Spree::PaymentMethod.find_with_destroyed(id).name
-      end
-    end
-  end
-end

app/helpers/spree/payment_methods_helper.rb

@@ -0,0 +1,9 @@
+module Spree
+  module PaymentMethodsHelper
+    def payment_method_name(payment)
+      # hack to allow us to retrieve the name of a "deleted" payment method
+      id = payment.payment_method_id
+      Spree::PaymentMethod.find_with_destroyed(id).name
+    end
+  end
+end

app/mailers/spree/order_mailer.rb

@@ -4,7 +4,7 @@ module Spree
   class OrderMailer < BaseMailer
     helper 'checkout'
     helper SpreeCurrencyHelper
-    helper Spree::Admin::PaymentsHelper
+    helper Spree::PaymentMethodsHelper
     helper OrderHelper
     helper MailerHelper
     include I18nHelper

app/mailers/subscription_mailer.rb

@@ -3,7 +3,7 @@ class SubscriptionMailer < Spree::BaseMailer
   helper MailerHelper
   helper ShopMailHelper
   helper OrderHelper
-  helper Spree::Admin::PaymentsHelper
+  helper Spree::PaymentMethodsHelper
   include I18nHelper
 
   def confirmation_email(order)

spec/services/bulk_invoice_service_spec.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: false
 
 require 'spec_helper'
-require 'spree/admin/payments_helper'
+require 'spree/payment_methods_helper'
 
 describe BulkInvoiceService do
   include ActiveJob::TestHelper
-  include Spree::Admin::PaymentsHelper
+  include Spree::PaymentMethodsHelper
 
   let(:service) { BulkInvoiceService.new }
 

spec/services/invoice_renderer_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'spree/admin/payments_helper'
+require 'spree/payment_methods_helper'
 
 describe InvoiceRenderer do
-  include Spree::Admin::PaymentsHelper
+  include Spree::PaymentMethodsHelper
 
   let(:service) { described_class.new }
   let(:order) do