Pau Pérez Fabregat
8a359ba1e4
Merge pull request #7086 from Matt-Yorkley/adjustments-index
...
[Adjustments] Add index on spree_adjustments.order_id
2021-03-15 21:52:40 +01:00
Pau Pérez Fabregat
7b6e94057c
Merge pull request #7119 from Matt-Yorkley/flaky-timezones
...
Allow timezone from ENV vars, but use UTC as default
2021-03-15 17:53:15 +01:00
Matt-Yorkley
c045efb89d
Merge pull request #7112 from Matt-Yorkley/admin-adjustments-controller
...
Ensure order association is set correctly when adding admin adjustments
2021-03-15 16:51:10 +01:00
Matt-Yorkley
4d7029f0c9
Allow timezone from ENV vars, but use UTC as default
2021-03-15 14:55:22 +00:00
Matt-Yorkley
657291df90
Update order total when editing admin adjustments
2021-03-15 11:46:14 +00:00
Pau Pérez Fabregat
162ae4ff24
Merge pull request #7103 from andrewpbrett/update-ci
...
Combine model jobs in CI
2021-03-15 12:29:09 +01:00
Matt-Yorkley
3219ea231d
Ensure order association is set correctly when adding admin adjustments
2021-03-15 11:18:14 +00:00
Pau Pérez Fabregat
71aec23c0d
Merge pull request #7064 from coopdevs/abstract-order-balance
...
Abstract order balance in a simple PORO
2021-03-15 11:35:45 +01:00
Matt-Yorkley
8531d82f02
Merge pull request #7102 from andrewpbrett/fix-ci
...
Update miniracer to 0.3.1
2021-03-14 15:20:00 +01:00
Andy Brett
9bcefd3605
Merge pull request #7083 from openfoodfoundation/dependabot/bundler/activerecord-import-1.0.8
...
Bump activerecord-import from 1.0.7 to 1.0.8
2021-03-13 11:27:49 -08:00
Andy Brett
c45bb470e7
Merge pull request #7066 from luisramos0/legacy_user
...
Remove dead current_api_user helper
2021-03-13 11:17:05 -08:00
Andy Brett
29db3ed3ad
Merge pull request #7078 from mkllnk/coverage
...
Disable code coverage by default
2021-03-13 11:16:47 -08:00
dependabot[bot]
135f5c63e0
Bump activerecord-import from 1.0.7 to 1.0.8
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.0.7...v1.0.8 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-13 19:00:54 +00:00
Andy Brett
89e0fd8f0a
combine model jobs
2021-03-13 10:30:15 -08:00
Andy Brett
902cd92f96
update miniracer
2021-03-13 10:28:09 -08:00
Andy Brett
54825aa264
Merge pull request #7099 from Matt-Yorkley/rails-5-fixes
...
Rails 5.0 fixes
2021-03-13 07:51:48 -08:00
Andy Brett
b7f9fb8d72
send full redirect URL to stripe
2021-03-13 10:58:33 +00:00
Andy Brett
6996001580
add defensive checking for stripe response
2021-03-13 10:58:30 +00:00
Matt-Yorkley
707d089419
Update type handling in PaymentMethodsController and add tests
2021-03-13 10:57:54 +00:00
Matt-Yorkley
6d51ece69c
Tidy up payment method params
2021-03-13 10:57:51 +00:00
Matt-Yorkley
00c7ab1ebb
Add index on spree_adjustments.order_id
2021-03-12 10:12:56 +00:00
Matt-Yorkley
274440acdd
Migrate database
...
This is the first migration with Rails 5. Some of the formatting has changed. Done in a separate commit for clarity.
2021-03-12 10:11:55 +00:00
Maikel Linke
62234c0708
Configure SimpleCov as recommended by author
...
The configuration can go into the central .simplecov file and then we
just need to `require` simplecov to start the coverage process. This
also avoids duplicating the config if we want to start simplecov from
the rails server to cover the lines used in by the server in feature
specs.
https://github.com/simplecov-ruby/simplecov#using-simplecov-for-centralized-config
2021-03-12 11:08:38 +11:00
Maikel Linke
3ee54b1bfa
Disable code coverage by default
...
We can activate it on demand:
COVERAGE=1 bundle exec rspec
We often run specs in chunks but simplecov needs all tests to be run.
2021-03-12 11:03:12 +11:00
Matt-Yorkley
2c0e9d77b8
Merge pull request #6832 from openfoodfoundation/rails-5-upgrade
...
Rails 5.0 -> master
2021-03-11 20:20:36 +01:00
Matt-Yorkley
321da76005
Update regression test
...
This error is no longer thrown by the payment object creation
2021-03-11 12:23:00 +00:00
Matt-Yorkley
6bb85e9acd
Fix payment and shipment states issue
...
For some reason the order objects were stale here when calling order.update! from either a payment or shipment callback, which was overwriting those states as nil on the order.
2021-03-11 12:23:00 +00:00
Matt-Yorkley
ac37db7e00
Update test setup in OrderCycleManagement report
2021-03-11 12:23:00 +00:00
Matt-Yorkley
04a13a4f6f
Update Boolean typecasting to Rails 5 version
2021-03-11 12:23:00 +00:00
Matt-Yorkley
7bc63e6e81
Re-add db2fog
...
Turns out it works with Rails 5
2021-03-11 12:23:00 +00:00
Matt-Yorkley
096b693461
Update Gemfile.lock
2021-03-11 12:23:00 +00:00
Matt-Yorkley
6c00fe44ae
Revert order permissions changes
2021-03-11 12:19:55 +00:00
Matt-Yorkley
7924865ff8
Set clearer version
2021-03-11 12:19:55 +00:00
Matt-Yorkley
8d8df447c6
Remove debugging
2021-03-11 12:19:55 +00:00
Matt-Yorkley
25139178b5
Fix appending to collection (take 2)
2021-03-11 12:19:55 +00:00
Matt-Yorkley
c827d77236
Fix reloading completed_order_with_fees factory
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4542a3464e
Fix params in Admin::ProductsController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4c2871e572
Refactor and fix params issues in Admin::OrderCyclesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
64b52527fd
Fix params issues in Admin::SubsciptionsController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
bbbce4e6c9
Fix params issues in Api::EnterprisesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
c2c8dbfb38
Add strong params in Api::ExchangeProductsController and deal with boolean issue
2021-03-11 12:19:55 +00:00
Matt-Yorkley
9e83cb65db
Set concurrency spec to pending
...
It's not working at all in Rails 5. There's new concurrency modules in Rails 5, we should investigate them...
2021-03-11 12:19:55 +00:00
Matt-Yorkley
3748d92bc8
Fix modifying taxons in ShopsCaching spec
...
This was triggering an error via the callback Spree::Product#remove_previous_primary_taxon_from_taxons
2021-03-11 12:19:55 +00:00
Matt-Yorkley
aea8d1dc99
Fix appending to Relation in in EnterpriseFeesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
95b5586f9b
Using strings for keys in FormAdapter spec
2021-03-11 12:19:55 +00:00
Matt-Yorkley
e11d1e6cdb
Add strong params to Spree::Admin::SearchController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
6087a4b969
Fix rendering of javascript template
...
The erb tags in this partial were not being parsed as erb, breaking various other things on the page.
2021-03-11 12:19:55 +00:00
Matt-Yorkley
688b3c98d7
Use strong params in variants search
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4ff56ce625
Update deprecated use of #uniq in OrderCyle scopes
2021-03-11 12:19:55 +00:00
Matt-Yorkley
ccf0556711
Fix params mangling in Admin::EnterprisesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
83278b17db
Fix test controller issue
2021-03-11 12:19:55 +00:00
Matt-Yorkley
190770b9df
Update query filter params handling
2021-03-11 12:19:55 +00:00
Matt-Yorkley
bd408e02b0
Update OrderCyclesController params usage
2021-03-11 12:19:55 +00:00
Matt-Yorkley
0393ea4219
Update variant params in CartController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
ec597aab1a
Fix params issue in ReportsController expectation
2021-03-11 12:19:55 +00:00
Matt-Yorkley
e46fe3735b
Fix params issue in controller specs
2021-03-11 12:19:54 +00:00
Matt-Yorkley
1911d25959
Fix Sets::ModelSet spec
2021-03-11 12:19:54 +00:00
Matt-Yorkley
29c34060e9
Add tight pinning on wkhtmltopdf-binary gem version
2021-03-11 12:19:54 +00:00
Matt-Yorkley
2ac4ace3e8
Fix params issues in UserPasswordsController
2021-03-11 12:19:54 +00:00
Matt-Yorkley
dcecfaea87
Fix params issues in OrderCyclescontroller spec
2021-03-11 12:19:54 +00:00
Matt-Yorkley
31df28b348
Fix params mangling in Api::ProductController
2021-03-11 12:19:54 +00:00
Matt-Yorkley
304da48d50
Remove dual boot
2021-03-11 12:19:54 +00:00
Matt-Yorkley
f28cd4a4e5
Adapt checkout FormDataAdapter
2021-03-11 12:06:00 +00:00
Matt-Yorkley
fd1b14ca4a
Fix string/integer issues in states controller spec
2021-03-11 12:06:00 +00:00
Matt-Yorkley
ff722e6969
Fix cookie issues in i18n helper spec
2021-03-11 12:06:00 +00:00
Matt-Yorkley
5e3d646f8c
Fix params access in reports views
2021-03-11 12:06:00 +00:00
Matt-Yorkley
dcf982c1c3
Fix params mangling issues in SubscriptionsController
2021-03-11 12:06:00 +00:00
Matt-Yorkley
af8d497433
Fix handling of params in variant overrides bulk update actions
2021-03-11 12:06:00 +00:00
Matt-Yorkley
7bf4f88034
Fix params issues in Api::TaxonsController
2021-03-11 12:06:00 +00:00
Matt-Yorkley
c5feb19e5b
Fix use of ActiveRecord::Type::Boolean#type_cast_from_database
...
This method longer exists.
2021-03-11 12:06:00 +00:00
Matt-Yorkley
009844bfe7
Update expected params in reports controller tests
2021-03-11 12:06:00 +00:00
Matt-Yorkley
0f1142b5c4
Fix more broken specs related to accessing params hash
2021-03-11 12:06:00 +00:00
Matt-Yorkley
ed09db6003
Fix broken specs related to accessing params hash
2021-03-11 12:06:00 +00:00
Matt-Yorkley
2fdb1861a6
Fix uses of ActionController::TestResponse in specs
...
This class has moved / changed slightly.
2021-03-11 12:06:00 +00:00
Matt-Yorkley
5bd1e9c37c
Add rails-controller-testing gem
...
```
Spree::Admin::PaymentMethodsController#create and #update can create a payment method of a valid type
Failure/Error: expect(response).to redirect_to spree.edit_admin_payment_method_path(assigns(:payment_method))
NoMethodError:
assigns has been extracted to a gem. To continue using it,
add `gem 'rails-controller-testing'` to your Gemfile.
# ./spec/controllers/spree/admin/payment_methods_controller_spec.rb:41:in `block (3 levels) in <module:Spree>'
```
2021-03-11 12:06:00 +00:00
Matt-Yorkley
120a2c4f3a
Merge pull request #7036 from Matt-Yorkley/adjustments-callbacks
...
[Adjustments] Reduce adjustments callbacks
2021-03-11 12:59:34 +01:00
Matt-Yorkley
29c5703161
Improve OrdersHelper spec and delete dead code
...
The removed test here was checking for adjustments that have an amount of zero and are eligible. If the amount is zero, it will already be marked as ineligible.
2021-03-11 11:22:35 +00:00
Matt-Yorkley
c5a47b51a6
Update order totals during CheckoutController#update
2021-03-11 11:20:01 +00:00
Matt-Yorkley
714e4f7896
Update test setup in checkout helper spec
2021-03-11 11:20:01 +00:00
Matt-Yorkley
90712647b1
Update totals when processing a return
2021-03-11 11:20:01 +00:00
Matt-Yorkley
4c64aaed77
Remove callbacks in Adjustment that call order.update!
2021-03-11 11:20:01 +00:00
Matt-Yorkley
791a47d170
Merge pull request #6858 from Matt-Yorkley/adjustments-shipping-cost
...
[Adjustments] Move shipping adjustment from order to shipment
2021-03-11 12:17:14 +01:00
Luis Ramos
12d5120629
Remove dead current_api_user helper
2021-03-11 00:40:51 +00:00
Pau Pérez Fabregat
41adacbffb
Merge pull request #7056 from jibees/6978-unit-prices-transform-question-mark-to-cross-to-close-it
...
Transform question mark to cross to close it (unit price)
2021-03-10 17:08:05 +01:00
Pau Pérez Fabregat
e341b04487
Merge pull request #6902 from openfoodfoundation/setup-postgres-gh-actions
...
Setup Github Actions as CI
2021-03-10 16:59:59 +01:00
Pau Perez
42d0f16773
Abstract order balance in a simple PORO
...
This new class lets us [Branch by
abstraction](https://www.martinfowler.com/bliki/BranchByAbstraction.html )
by encapsulating an order's balance. As a result, that's the only place
where we need to check the feature toggle, instead of every place where
`#outstanding_balance` is called (quite some). That would be very hard
to review and it'd be more likely to introduce bugs.
What I like about this is that we also managed to group together the
data and logic that we had spread in a few places and have it nicely
encapsulated. So, where we had a number, we'll now have an object.
Once we fully change all `#outstanding_balance` consumers to use this
new abstraction we'll be able to remove the methods this class replaces.
These are: `Spree::Order#outstanding_balance?`,
`Spree::Order#display_oustanding_balance` and
`OrderHelper.outstanding_balance_label`.
This is just the first step. I'll follow this up with a PR per
page/mailer/whatever where we use the balance to replace it with an
instance of `OrderBalance`. That is, splitting up what I explored in
https://github.com/openfoodfoundation/openfoodnetwork/pull/6959 but in
very small and manageable pieces.
2021-03-10 16:09:09 +01:00
Pau Pérez Fabregat
82257185c4
Merge pull request #7057 from Matt-Yorkley/missing-tax-translation
...
Update untranslated string
2021-03-10 10:42:14 +01:00
Pau Pérez Fabregat
66201c6618
Merge pull request #7055 from coopdevs/remove-js-capabilities-to-test
...
Remove unnecessary JS-capabilites for test
2021-03-10 09:53:23 +01:00
Andy Brett
05a074d33a
Merge pull request #7041 from Matt-Yorkley/adjustments-set-eligibility
...
[Adjustments] Remove Adjustment#set_eligibility
2021-03-09 13:33:21 -08:00
Pau Pérez Fabregat
332d7b8482
Merge pull request #7044 from filipefurtad0/transaction_fees_specs
...
adds coverage to transacion fees/payment methods
2021-03-09 18:52:58 +01:00
Matt-Yorkley
11d5c6a2f1
Update untranslated string
...
This translation already exists, we just weren't using it in this view.
2021-03-09 17:19:40 +00:00
Jean-Baptiste Bellet
2414161210
Remove useless and error-prone css specification
...
- This shouldn't be a general specification, but eventually used inside context. By default, no need to this.
2021-03-09 17:25:32 +01:00
Jean-Baptiste Bellet
5239b259d0
Transform question mark to cross when tooltip is open
...
- Behavior consistent w/ price_breakdown feature.
2021-03-09 17:22:07 +01:00
Pau Pérez Fabregat
64a2493cc7
Merge pull request #7001 from coopdevs/add-bullet-for-development
...
Set up Bullet for development and testing
2021-03-09 16:47:53 +01:00
Pau Pérez Fabregat
3543e7f005
Merge pull request #6894 from jibees/6878-question-mark-icon-as-svg
...
Use svg icon instead of CSS `before` for the question mark icon
2021-03-09 16:47:30 +01:00
Pau Pérez Fabregat
4a6de97935
Merge pull request #7054 from coopdevs/removes-puts-debugging
...
Remove puts debugging in tests
2021-03-09 16:27:32 +01:00
Pau Perez
5b31e06cab
Add Github Actions badge to README
2021-03-09 16:22:46 +01:00
Pau Perez
8301f2d550
Output RSpec profiling data
...
This shows things like:
```
Top 10 slowest examples (32.34 seconds, 87.1% of total time):
As a site administrator
I want to configure the site content
fills in a setting shows the result on the home page
19.12 seconds ./spec/features/admin/configuration/content_spec.rb:17
States creating and editing states should allow an admin to edit existing states
7.36 seconds ./spec/features/admin/configuration/states_spec.rb:40
Tax Rates while editing can be deleted
1.22 seconds ./spec/features/admin/configuration/tax_rates_spec.rb:58
States creating and editing states should allow an admin to create states for non default countries
1.16 seconds ./spec/features/admin/configuration/states_spec.rb:52
States creating and editing states should show validation errors
1 seconds ./spec/features/admin/configuration/states_spec.rb:68
Zones edit existing zone
0.90067 seconds ./spec/features/admin/configuration/zones_spec.rb:42
```
and
```
Top 8 slowest example groups:
As a site administrator
I want to configure the site content
6.64 seconds average (19.93 seconds / 3 examples) ./spec/features/admin/configuration/content_spec.rb:5
States
2.42 seconds average (9.68 seconds / 4 examples) ./spec/features/admin/configuration/states_spec.rb:5
Tax Rates
0.51138 seconds average (2.56 seconds / 5 examples) ./spec/features/admin/configuration/tax_rates_spec.rb:4
Zones
0.49488 seconds average (1.48 seconds / 3 examples) ./spec/features/admin/configuration/zones_spec.rb:5
Tax Categories
0.32438 seconds average (1.3 seconds / 4 examples) ./spec/features/admin/configuration/tax_categories_spec.rb:5
Taxonomies
0.30578 seconds average (1.22 seconds / 4 examples) ./spec/features/admin/configuration/taxonomies_spec.rb:5
General Settings
0.28868 seconds average (0.57737 seconds / 2 examples) ./spec/features/admin/configuration/general_settings_spec.rb:5
Mail Methods
0.26415 seconds average (0.26415 seconds / 1 example) ./spec/features/admin/configuration/mail_methods_spec.rb:5
Finished in 37.11 seconds (files took 6.27 seconds to load)
26 examples, 0 failures
```
which is essential to speed up our test suite.
2021-03-09 16:22:46 +01:00
Andy Brett
5e19e5e83d
use UTC
2021-03-09 16:22:46 +01:00
Andy Brett
b5b751fa39
fix admin feature spec
2021-03-09 16:22:46 +01:00
Andy Brett
bc7469c7aa
fix order test
2021-03-09 16:22:46 +01:00
Pau Perez
a5fbd6bb57
DRY downloads directory path
2021-03-09 16:22:46 +01:00
Pau Perez
0e4f9d18d4
Fix browser's download path configuration
...
The CI build can't find the downloaded file and fails like:
```
2) enterprise fee summaries csv downloads smoke test for generation of report based on permissions when logged in as enterprise user generates file with data for the enterprise
Failure/Error: sleep 0.1 until downloaded?
Timeout::Error:
execution expired
# ./spec/support/downloads_helper.rb:34:in `sleep'
# ./spec/support/downloads_helper.rb:34:in `block in wait_for_download'
# ./spec/support/downloads_helper.rb:33:in `wait_for_download'
# ./spec/support/downloads_helper.rb:11:in `downloaded_filename'
# ./engines/order_management/spec/features/order_management/reports/enterprise_fee_summaries_spec.rb:119:in `block (5 levels) in <top (required)>'
# ./engines/order_management/spec/features/order_management/reports/enterprise_fee_summaries_spec.rb:80:in `block (4 levels) in <top (required)>'
# ./spec/support/downloads_helper.rb:22:in `with_empty_downloads_folder'
# ./engines/order_management/spec/features/order_management/reports/enterprise_fee_summaries_spec.rb:80:in `block (3 levels) in <top (required)>'
```
2021-03-09 16:19:27 +01:00
Andy Brett
ae3b186bcd
remove hardcoded time string in T&C spec
2021-03-09 16:19:27 +01:00
Pau Perez
42c9050a17
Fix cookie retrieval in feature spec
...
I also took the chance to reduce some redundant assertions.
2021-03-09 16:19:27 +01:00
Pau Perez
c61fc25e9f
Disable Knapsack only to Github workflow
2021-03-09 16:19:27 +01:00
Pau Perez
838563a80b
Skip code coverage in Github Actions
...
No need to slow down the build with partial coverage analysis that won't
be merged in a single report for the whole build.
Also, this makes builds fail because we are not running the whole suite.
2021-03-09 16:19:27 +01:00
Pau Perez
3cef261de1
Force RSpec's output to be in color
...
While also simplifying the configuration using the default `progress`
RSpec formatter.
2021-03-09 16:18:29 +01:00
Pau Perez
1f0b597120
Run tests in a Github workflow
...
Things to be aware of:
* Allows manually triggering GH workflow. See:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch .
* Installs versions in the yarn.lock and prevents updates to the yarn.lock.
* Yarn and npm come pre-installed in Github's runner VMs. See
https://docs.github.com/en/actions/guides/building-and-testing-nodejs#installing-dependencies .
* We use the latest LTS Node version so it can read ES6 syntax `let`.
* Karma tests require RAILS_ENV. In lib/tasks/karma.rake we default to
`test` so that means someone else is setting `RAILS_ENV` before that.
We'll need to find out who so we can avoid this.
* We run the CI build only on pushes to any branch. This the
redundancy of all build jobs due to the `push` and `pull_request`
events. I still don't see what's the exact difference between these
two events. See:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows .
2021-03-09 16:18:04 +01:00
filipefurtad0
f26a7befab
removes default value assertions
2021-03-09 15:18:02 +00:00
Pau Perez
c986583d09
Remove unnecessary JS-capabilites for test
...
This gets this file execution time from ~10s to ~2s.
2021-03-09 16:04:29 +01:00
Pau Perez
333c669fbf
Remove puts debugging in tests
2021-03-09 16:01:55 +01:00
Pau Pérez Fabregat
6b111561e8
Merge pull request #7000 from Matt-Yorkley/dead-code-tax-total
...
DCOTW: Order#tax_total
2021-03-08 16:57:59 +01:00
Matt-Yorkley
c99a9f4ee1
Remove Adjustment#set_eligibility
2021-03-08 15:29:04 +00:00
Jean-Baptiste Bellet
ac70bbfd9b
Add missing closing curly bracket
2021-03-08 15:58:26 +01:00
Pau Pérez Fabregat
876c378e4f
Merge pull request #7028 from Matt-Yorkley/dead-code-available-shipment
...
DCOTW: Order#has_available_shipment
2021-03-08 15:25:39 +01:00
Pau Pérez Fabregat
696a429bcb
Merge pull request #7030 from Matt-Yorkley/dcotw-item-count
...
DCOTW: Order#item_count
2021-03-08 15:23:09 +01:00
Pau Pérez Fabregat
367882951b
Merge pull request #7039 from openfoodfoundation/dependabot/bundler/webmock-3.12.1
...
Bump webmock from 3.12.0 to 3.12.1
2021-03-08 13:43:17 +01:00
Pau Pérez Fabregat
da2b36449d
Merge pull request #7040 from openfoodfoundation/transifex
...
Transifex
2021-03-08 13:42:40 +01:00
filipefurtad0
3b81f51fe4
adds coverage to transacion fees/payment methods
2021-03-08 12:35:35 +00:00
Transifex-Openfoodnetwork
e7e812bee7
Updating translations for config/locales/en_FR.yml
2021-03-08 20:28:18 +11:00
Transifex-Openfoodnetwork
a7919c72e3
Updating translations for config/locales/fr.yml
2021-03-08 20:27:46 +11:00
Transifex-Openfoodnetwork
096b31f783
Updating translations for config/locales/en_GB.yml
2021-03-08 20:19:16 +11:00
dependabot[bot]
844c8b85d9
Bump webmock from 3.12.0 to 3.12.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.12.0 to 3.12.1.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.0...v3.12.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-08 05:58:15 +00:00
Matt-Yorkley
af29c67ea5
Update Order#ship_total
2021-03-06 14:14:56 +00:00
Andy Brett
5f01fcd902
Merge pull request #7017 from openfoodfoundation/dependabot/bundler/geocoder-1.6.6
...
Bump geocoder from 1.6.5 to 1.6.6
2021-03-05 20:32:09 -08:00
Matt-Yorkley
f894473e03
Delete dead code: Order#item_count
2021-03-06 00:04:46 +00:00
Matt-Yorkley
68e752ef32
Delete dead code: Order#has_available_shipment
2021-03-05 23:42:08 +00:00
Pau Perez
d814f98bb6
Update all locales with the latest Transifex translations
2021-03-05 13:46:14 +01:00
Pau Pérez Fabregat
2f81af3818
Merge pull request #7010 from openfoodfoundation/transifex
...
Transifex
2021-03-05 13:43:13 +01:00
Transifex-Openfoodnetwork
918db44925
Updating translations for config/locales/it.yml
2021-03-05 21:58:06 +11:00
Transifex-Openfoodnetwork
f5e6a98360
Updating translations for config/locales/ru.yml
2021-03-05 20:55:59 +11:00
Transifex-Openfoodnetwork
7db560341b
Updating translations for config/locales/es.yml
2021-03-05 18:43:17 +11:00
Transifex-Openfoodnetwork
cc65aba292
Updating translations for config/locales/ca.yml
2021-03-05 18:42:59 +11:00
Pau Pérez Fabregat
b354a4226a
Merge pull request #7009 from coopdevs/remove-subs-performance-specs
...
Remove subs-related performance specs
2021-03-05 08:37:13 +01:00
dependabot[bot]
6033c276d8
Bump geocoder from 1.6.5 to 1.6.6
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.6.5 to 1.6.6.
- [Release notes](https://github.com/alexreisner/geocoder/releases )
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.6.5...v1.6.6 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-05 05:30:15 +00:00
Andy Brett
7bf1bd6287
Merge pull request #6995 from coopdevs/add-good-migrations
...
Add gem to watch after data migrations
2021-03-04 12:09:22 -08:00
Transifex-Openfoodnetwork
2ea9664ecb
Updating translations for config/locales/en_US.yml
2021-03-05 05:13:51 +11:00
Transifex-Openfoodnetwork
dfdc97cfa4
Updating translations for config/locales/de_DE.yml
2021-03-05 05:00:27 +11:00
Pau Pérez Fabregat
674f0f87a3
Merge pull request #6528 from mprieger/5546-cart-page-last-item-deletion
...
Fix users removing last item of confirmed order on /cart page
2021-03-04 17:27:51 +01:00
Pau Pérez Fabregat
982c3d2215
Merge pull request #6965 from andrewpbrett/fix-sca-snail
...
Fix #6964 : don't try to complete a failed payment
2021-03-04 17:26:24 +01:00
Pau Pérez Fabregat
ff239802b6
Merge pull request #6982 from andrewpbrett/canceled-order-payments
...
Fix #5018 : Allow access to payments tab for canceled orders
2021-03-04 17:25:30 +01:00
Matt-Yorkley
3396319f29
Fix test setup in Order spec
2021-03-04 14:27:02 +00:00
Matt-Yorkley
9deadc8ae1
Simplify order.adjustment_total sum
2021-03-04 14:27:02 +00:00
Matt-Yorkley
1afcd70510
Simplify Order#total_tax
2021-03-04 14:27:02 +00:00
Matt-Yorkley
9cf8c84a7d
Add model definition to migration
2021-03-04 14:27:02 +00:00
Matt-Yorkley
ff58e2da54
Use AR syntax in queries
2021-03-04 14:27:02 +00:00
Matt-Yorkley
b1bf2487e2
Update adjustment scope use in Xero Invoices report
2021-03-04 14:27:02 +00:00
Matt-Yorkley
e33950721c
Change misleading method name in Xero Invoices code
2021-03-04 14:27:02 +00:00
Matt-Yorkley
945605e3a8
Rename Shipment #adjustment to #fee_adjustment for clarity
2021-03-04 14:27:02 +00:00
Matt-Yorkley
a5929b489a
Ensure order object has line items in bulk_invoice_service
2021-03-04 14:27:02 +00:00
Matt-Yorkley
eed71d795e
Use persisted shipment in shipping adjustment test
2021-03-04 14:27:02 +00:00
Matt-Yorkley
57b54637e3
Ensure order factory selects shipping rates correctly
2021-03-04 14:27:02 +00:00
Matt-Yorkley
434c9f1c7c
Fix test setup in adjustments_spec
...
The order association is required for these objects to be found
2021-03-04 14:27:02 +00:00
Matt-Yorkley
0e2c1d0317
Refresh shipment rates when changing shipping method cost
...
The test setup here wasn't correctly updating he shipment's shipping_rates, so they were still zero.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
55db911334
Update sales tax report
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f956aca82f
Use shipping fee adjustment as single source of truth, and persist it on the shipment :cost field when it changes.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
bcbea618e8
Fix adjustment spec
...
The tested adjustment isn't found correctly if it isn't associated to the order...
2021-03-04 14:27:02 +00:00
Matt-Yorkley
7fb5bf217f
Update checkout spec adjustment fetching
2021-03-04 14:27:02 +00:00
Matt-Yorkley
aa16c64f20
Update Order#finalize! to include all adjustments
2021-03-04 14:27:02 +00:00
Matt-Yorkley
c0b33de0f0
Move #adjustment_label to shipment
2021-03-04 14:27:02 +00:00
Matt-Yorkley
e67c29872a
Update OrderMailer spec
2021-03-04 14:27:02 +00:00
Matt-Yorkley
86110f2f40
Improve shipment factory
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f0de09da84
Update order correctly in ReturnAuthorizationsController
2021-03-04 14:27:02 +00:00
Matt-Yorkley
833aae23e5
Update admin adjustments controller
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f94f424b63
Update fee fetching in controller tests
2021-03-04 14:27:02 +00:00
Matt-Yorkley
65bcf83552
Migrate shipping fee adjustments to shipments
2021-03-04 14:27:02 +00:00
Matt-Yorkley
c093701adf
Improve UserBalanceCalculator spec test setup
...
Previously we were creating order objects that were not actually complete, and manually setting the `completed_at` field. This meant the order objects being tested were not actually in the correct state, ie: pre-checkout orders that had not been processed properly.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
d4c9d70caa
Update Adjustment specs
2021-03-04 14:27:02 +00:00
Matt-Yorkley
045cdec23c
Update OrderDetailedSerializer
2021-03-04 14:27:02 +00:00
Matt-Yorkley
80aefa8e73
Update OrderTaxAdjustmentsFetcher
2021-03-04 14:27:02 +00:00
Matt-Yorkley
02fb2c6a55
Update CheckoutHelper
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f0aa43e198
Update Order shipment adjustments fetching
2021-03-04 14:27:01 +00:00
Matt-Yorkley
00f116f35f
Update Order::Updater to include shipment adjustments
2021-03-04 14:27:01 +00:00
Matt-Yorkley
1aec324269
Update shipment cost spec
2021-03-04 14:27:01 +00:00
Matt-Yorkley
f5d3e22730
Add shipment_adjustments association to Order
2021-03-04 14:27:01 +00:00
Matt-Yorkley
9ed6ae588f
Update EnterpriseFeeSummary report adjustment scopes
2021-03-04 14:27:01 +00:00
Matt-Yorkley
4c57addb02
Move shipping fee adjustment from the order to the shipment
2021-03-04 14:27:01 +00:00
Matt-Yorkley
551cb9a2d2
Remove Shipment#cost method
...
Cost is now recorded on the shipment record itself
2021-03-04 14:27:01 +00:00
Matt-Yorkley
81cdc2eac1
Bring in Shipment#update_amounts method
2021-03-04 14:27:01 +00:00
Matt-Yorkley
2a0f132b8b
Improve ShippingMethod -> Shipment association
...
5a54a0b6b0
2021-03-04 14:27:01 +00:00
Matt-Yorkley
f33c881503
Set default 0 on spree_shipments cost
2021-03-04 14:27:01 +00:00
Pau Pérez Fabregat
1ad3f38942
Merge pull request #6981 from drummer83/missing-translations
...
Updated translations to close #6666
2021-03-04 15:01:36 +01:00
Pau Pérez Fabregat
d856e006ec
Merge pull request #6989 from andrewpbrett/fix-group-map-icons
...
Update path to +1 map icon
2021-03-04 11:31:17 +01:00
Pau Pérez Fabregat
ab5bb03b04
Merge pull request #7007 from openfoodfoundation/dependabot/bundler/ddtrace-0.46.0
...
Bump ddtrace from 0.45.0 to 0.46.0
2021-03-04 10:40:26 +01:00
Pau Pérez Fabregat
5c0e55a281
Merge pull request #7005 from openfoodfoundation/transifex
...
Transifex
2021-03-04 10:39:47 +01:00
Pau Perez
07481575dc
Remove subs-related performance specs
...
This is a rather naive take on assessing performance, it slows down the
test suite and clutters the output with timings without providing value
in return.
Stems from
https://github.com/openfoodfoundation/openfoodnetwork/pull/6902 .
2021-03-04 10:33:20 +01:00
dependabot[bot]
9bd85804b9
Bump ddtrace from 0.45.0 to 0.46.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.45.0 to 0.46.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.45.0...v0.46.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-04 05:33:57 +00:00
Transifex-Openfoodnetwork
baa0f82ede
Updating translations for config/locales/de_DE.yml
2021-03-04 08:12:09 +11:00
Transifex-Openfoodnetwork
546fa6e6c4
Updating translations for config/locales/es.yml
2021-03-04 06:37:35 +11:00
Transifex-Openfoodnetwork
72f9f944af
Updating translations for config/locales/ca.yml
2021-03-04 06:37:13 +11:00
Pau Pérez Fabregat
5985344166
Merge pull request #6999 from coopdevs/add-missing-translation-key
...
Add missing shipment_states I18n key
2021-03-03 17:55:01 +01:00
Pau Pérez Fabregat
094ef28456
Merge pull request #6996 from filipefurtad0/payment_method_spec
...
fixes a pending test case for hubs w/ several distributors
2021-03-03 16:48:10 +01:00
Pau Pérez Fabregat
3539ceaec1
Merge pull request #6986 from coopdevs/fix-pending-locale-spec
...
Fix old pending locale-related spec
2021-03-03 16:15:03 +01:00
Pau Perez
ed41888ba4
Set up Bullet for development and testing
...
This will log any N+1 it finds, pointing to the line causing it and
a way to solve it, aka. which `#includes` to add. Like so
```
web_1 | GET /admin/order_cycles.json?ams_prefix=index&q%5Borders_close_at_gt%5D=Sun+Jan+31+2021+00:00:00+GMT%2B0100+(Central+European+Standard+Time)
web_1 | USE eager loading detected
web_1 | OrderCycle => [:coordinator]
web_1 | Add to your query: .includes([:coordinator])
web_1 | Call stack
web_1 | /usr/src/app/app/serializers/api/admin/index_order_cycle_serializer.rb:41:in `coordinator'
web_1 | /usr/src/app/app/controllers/spree/admin/base_controller.rb:98:in `render_as_json'
web_1 | /usr/src/app/app/controllers/admin/order_cycles_controller.rb:17:in `block (2 levels) in index'
web_1 | /usr/src/app/app/controllers/admin/order_cycles_controller.rb:14:in `index'
web_1 | bin/rails:4:in `require'
web_1 | bin/rails:4:in `<main>'
```
We gave a try at Bullet long ago and abandoned it because it's not
a silver bullet (pun intended) due to false positives. However, it's
pretty clear that this won't happen often; we have endless N+1 still to fix.
I recently experienced how, relying on Bullet made it just extra 30s to fix
additional N+1s other than the one I was fixing. Usually, finding the
culprit line takes me more of 30min.
2021-03-03 13:50:03 +01:00
Pau Pérez Fabregat
d7ee7e02dd
Merge pull request #6987 from coopdevs/remove-delegation-specs
...
Remove unnecessary delegation specs
2021-03-03 13:44:00 +01:00
Pau Pérez Fabregat
433b9c030c
Merge pull request #6988 from coopdevs/remove-unused-rspec-filtering
...
Remove unused RSpec specs filtering
2021-03-03 13:43:36 +01:00
Matt-Yorkley
d17ff38a7e
Delete Order#tax_total
...
#display_tax_total is not used anywhere, #tax_total is used in once place but it's not needed.
2021-03-03 11:26:32 +00:00
Pau Perez
c83cb554d5
Add missing shipment_states I18n key
...
I spot `[missing "en.spree.shipment_states.canceled" translation]` while
checking the transactions tab on /account for an order that was
canceled.
2021-03-03 12:17:14 +01:00
filipefurtad0
1c018bdd90
fixes a pending test case for hubs w/ several distributors
2021-03-03 08:59:56 +00:00
Pau Pérez Fabregat
03e969fa51
Merge pull request #6993 from openfoodfoundation/dependabot/bundler/delayed_job_web-1.4.4
...
Bump delayed_job_web from 1.4.3 to 1.4.4
2021-03-03 08:30:53 +01:00
Pau Pérez Fabregat
1cfee50300
Merge pull request #6983 from openfoodfoundation/dependabot/bundler/rubocop-1.11.0
...
Bump rubocop from 1.10.0 to 1.11.0
2021-03-03 08:30:29 +01:00
Pau Perez
63f82bd142
Add gem to watch after data migrations
...
> This gem prevents Rails from auto-loading app code while it's running
migrations, preventing the common mistake of referencing ActiveRecord
models from migration code.
This will make us stop relying on @mkllnk to have robust data migrations
that don't cause trouble in the future.
2021-03-03 08:22:32 +01:00
dependabot[bot]
b9bf084136
Bump delayed_job_web from 1.4.3 to 1.4.4
...
Bumps [delayed_job_web](https://github.com/ejschmitt/delayed_job_web ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/ejschmitt/delayed_job_web/releases )
- [Changelog](https://github.com/ejschmitt/delayed_job_web/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ejschmitt/delayed_job_web/compare/v1.4.3...v1.4.4 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-03 05:17:59 +00:00
Andy Brett
5966557b59
update path to +1 map icon
2021-03-02 08:53:13 -08:00
Pau Perez
742b54376d
Remove unused RSpec specs filtering
...
This was introduced ages ago and became dead code as no specs use these
filters anymore.
It stems from the work done in
https://github.com/openfoodfoundation/openfoodnetwork/pull/6902/ .
2021-03-02 14:40:44 +01:00
Pau Perez
d439a5074b
Remove unnecessary delegation specs
...
The custom RSpec matchers they use raises the following deprecation
warning
```
Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /home/runner/work/openfoodnetwork/openfoodnetwork/spec/support/matchers/delegate_matchers.rb:22:in `block (2 levels) in <top (required)>'.
```
It's not worth maintaining those matchers to test such
implementation-related thing. Whether or not any delegations work is
something that will be caught by integration tests or directly stubbing
the collaborator object's methods.
This stems from
https://github.com/openfoodfoundation/openfoodnetwork/pull/6902 .
2021-03-02 11:54:46 +01:00
Pau Perez
45d0501ca6
Fix old pending locale-related spec
...
This is the correct behavior: if you set a language that is not
available, it'll fallback to English.
2021-03-02 11:42:45 +01:00
dependabot[bot]
54409265d0
Bump rubocop from 1.10.0 to 1.11.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.10.0...v1.11.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-02 05:20:56 +00:00
Andy Brett
ad8973d74b
add messages object to order controller
2021-03-01 21:01:34 -08:00
Andy Brett
6b1a1a59b1
update cart spec
2021-03-01 20:42:06 -08:00
Andy Brett
72b7fe723f
fix indentation
2021-03-01 20:42:05 -08:00
Andy Brett
5751e247bd
Update app/assets/javascripts/darkswarm/controllers/edit_bought_order_controller.js.coffee
2021-03-01 20:42:05 -08:00
Andy Brett
3725ba0fc4
Update app/assets/javascripts/darkswarm/services/cart.js.coffee
2021-03-01 20:42:05 -08:00
Matthew Rieger
651bdad7b9
Fix users removing last item of confirmed order on /cart page
2021-03-01 20:42:05 -08:00
Andy Brett
a02065b66f
allow access to payments tab for canceled orders
2021-03-01 19:51:50 -08:00
Andy Brett
3b15e0ee15
only complete the payment if it is in a completable state
2021-03-01 18:51:14 -08:00
Konrad
97d2c0e255
Updated translations to close #6666
2021-03-02 01:02:36 +01:00
Andy Brett
b3610e035d
Merge pull request #6961 from openfoodfoundation/dependabot/bundler/i18n-js-3.8.1
...
Bump i18n-js from 3.8.0 to 3.8.1
2021-03-01 09:34:49 -08:00
Pau Pérez Fabregat
b701098dee
Merge pull request #6975 from openfoodfoundation/dependabot/bundler/webdrivers-4.6.0
...
Bump webdrivers from 4.5.0 to 4.6.0
2021-03-01 17:29:02 +01:00
Pau Pérez Fabregat
6d42f93f8a
Merge pull request #6979 from openfoodfoundation/transifex
...
Transifex
2021-03-01 17:27:45 +01:00
Jean-Baptiste Bellet
d6cf69df34
Fix vertical alignment using flex
...
- Firefox displayed the icon above the legend
- Use `display: flex;` and `align-items: center;` to vertical align icon and text
2021-03-01 16:40:02 +01:00
Jean-Baptiste Bellet
36573701dc
Use svg icon instead of CSS before
...
CSS can be sometimes a little bit inconsistent to create such an icon. Using SVG is better solution to create beautiful icon.
2021-03-01 16:39:53 +01:00
Transifex-Openfoodnetwork
8e477fef9e
Updating translations for config/locales/es.yml
2021-03-02 02:15:01 +11:00
Transifex-Openfoodnetwork
ab8ac24797
Updating translations for config/locales/ca.yml
2021-03-02 02:14:44 +11:00
Pau Pérez Fabregat
c7577e29d6
Merge pull request #6977 from openfoodfoundation/transifex
...
Transifex
2021-03-01 16:13:43 +01:00
Transifex-Openfoodnetwork
79d4f4127a
Updating translations for config/locales/ru.yml
2021-03-02 01:33:23 +11:00
Transifex-Openfoodnetwork
5682f87893
Updating translations for config/locales/en_FR.yml
2021-03-01 23:56:18 +11:00
Transifex-Openfoodnetwork
846cfe0050
Updating translations for config/locales/fr.yml
2021-03-01 23:56:05 +11:00
Pau Pérez Fabregat
7f4849da25
Merge pull request #6971 from Matt-Yorkley/dead-code-assassin
...
Remove dead code Order#display_ship_total
2021-03-01 10:07:30 +01:00
Pau Pérez Fabregat
8d31ba2677
Merge pull request #6966 from Matt-Yorkley/dead-code-totals
...
Dead code of the week
2021-03-01 10:05:31 +01:00
Pau Pérez Fabregat
68aafb9d4d
Merge pull request #6967 from Matt-Yorkley/spree-missing-translations
...
Add missing Spree translation keys
2021-03-01 10:04:49 +01:00
Transifex-Openfoodnetwork
ea2139b9f2
Updating translations for config/locales/ca.yml
2021-03-01 20:04:42 +11:00
Pau Pérez Fabregat
9389de9aa1
Merge pull request #6970 from andrewpbrett/flaky-spec
...
Remove duplicate specs
2021-03-01 10:03:23 +01:00
Transifex-Openfoodnetwork
a6f72d3311
Updating translations for config/locales/es.yml
2021-03-01 20:02:18 +11:00
Transifex-Openfoodnetwork
066708fad0
Updating translations for config/locales/ca.yml
2021-03-01 20:01:37 +11:00
Pau Pérez Fabregat
be2dc2df09
Merge pull request #6976 from openfoodfoundation/dependabot/bundler/webmock-3.12.0
...
Bump webmock from 3.11.3 to 3.12.0
2021-03-01 10:00:07 +01:00
Pau Pérez Fabregat
a0aeb1ceb4
Merge pull request #6889 from mkllnk/6102-footer
...
Emphasise ways to get help in user emails
2021-03-01 09:59:18 +01:00
Transifex-Openfoodnetwork
7647d961fe
Updating translations for config/locales/en_FR.yml
2021-03-01 19:46:21 +11:00
Transifex-Openfoodnetwork
0e888f1793
Updating translations for config/locales/fr.yml
2021-03-01 19:45:55 +11:00
Transifex-Openfoodnetwork
fbd24fac43
Updating translations for config/locales/en_GB.yml
2021-03-01 18:03:38 +11:00
dependabot[bot]
eace7822b6
Bump webmock from 3.11.3 to 3.12.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.11.3 to 3.12.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.3...v3.12.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-01 06:41:44 +00:00
dependabot[bot]
dbccc95aaf
Bump webdrivers from 4.5.0 to 4.6.0
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.5.0...v4.6.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-03-01 06:39:15 +00:00
Matt-Yorkley
4c3ff402e6
Remove dead code Order#display_ship_total
2021-02-28 13:49:38 +00:00
Andy Brett
448c0e0ce3
Remove duplicate specs
...
The second of these is flaky; moreover, the OrdersController doesn't specifically have a method that they're testing. I think the ready_to_capture behaviors is adequately covered by 006236b8dd/spec/serializers/api/admin/order_serializer_spec.rb (L39-L68)
2021-02-27 15:05:11 -08:00
Matt-Yorkley
1f2e9a6b58
Add missing Spree translation keys
2021-02-27 12:07:17 +00:00
Matt-Yorkley
16eff698df
Remove dead code; Spree::Order #line_item_adjustment_totals and #price_adjustment_totals
2021-02-27 11:56:44 +00:00
Andy Brett
006236b8dd
Merge pull request #6919 from andrewpbrett/authorize-payment-links
...
Show authorization links in separate table
2021-02-26 18:31:26 -08:00
Andy Brett
855e38cd73
add I18n
2021-02-26 07:47:58 -08:00
Pau Perez
c3179b4304
Restore table's top rounded corners
2021-02-26 07:44:09 -08:00
Pau Perez
2146ed277f
Fix table header spacing when status is hidden
2021-02-26 07:44:09 -08:00
Pau Perez
ad147ed8f5
Make payment auth table as wide as table below
...
This makes this page look a bit more consistent. Note I also had to fix
the price in the value column.
To do this I pulled out the width property from `.orders` which defines
too many things. This way we can make the auth table full-width while
not being tied to all the other properties which are not needed in this
table. Then, `.orders`'s nested `.order1, .order2` etc. column class
become useless.
2021-02-26 07:44:09 -08:00
Pau Perez
cbb919f28b
Left-align table with table below
2021-02-26 07:44:09 -08:00
Pau Perez
8696882549
Refactor payment auth button to fit into table row
...
This looks a bit more cohesive with the rest of the row cells while
still standing out from the rest.
2021-02-26 07:44:08 -08:00
Andy Brett
7bbfb6b8db
use rpsec subject in payments spec
2021-02-26 07:44:08 -08:00
Andy Brett
c23fb27031
remove unnecessary join
2021-02-26 07:44:08 -08:00
Andy Brett
7bb49b51fd
use scope on payment model
2021-02-26 07:44:08 -08:00
Andy Brett
e5eb8f97f9
add basic feature spec for authorisation table
2021-02-26 07:44:08 -08:00
Andy Brett
83bc9d2a12
add unit spec for Payments query
2021-02-26 07:44:08 -08:00
Andy Brett
0b245ad7b1
make user attr private
2021-02-26 07:44:08 -08:00
Andy Brett
ee351d91a9
show authorization links in separate table
2021-02-26 07:44:08 -08:00
Matt-Yorkley
f1fca874a1
Update all locales with the latest Transifex translations
2021-02-26 13:13:59 +00:00
dependabot[bot]
e6b5775327
Bump i18n-js from 3.8.0 to 3.8.1
...
Bumps [i18n-js](https://github.com/fnando/i18n-js ) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/fnando/i18n-js/releases )
- [Changelog](https://github.com/fnando/i18n-js/blob/main/CHANGELOG.md )
- [Commits](https://github.com/fnando/i18n-js/compare/v3.8.0...v3.8.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-26 05:25:43 +00:00
Pau Pérez Fabregat
4116066a75
Merge pull request #6725 from Matt-Yorkley/adjustments-tax-totals
...
[Adjustments] Order tax totals
2021-02-25 19:24:23 +01:00
Pau Pérez Fabregat
5ded4ed938
Merge pull request #6958 from Matt-Yorkley/remove-weird-file
...
Remove dead file
2021-02-25 15:56:04 +01:00
Matt-Yorkley
d92de62a0b
I guess this was committed by mistake
2021-02-25 12:56:07 +00:00
Pau Pérez Fabregat
404ec7bf92
Merge pull request #6950 from andrewpbrett/fix-nil-enterprise-category
...
Fix #6949 : Add default icon value if enterprise.category is nil
2021-02-25 13:20:10 +01:00
Pau Pérez Fabregat
a6d6530852
Merge pull request #6957 from openfoodfoundation/dependabot/bundler/webmock-3.11.3
...
Bump webmock from 3.11.2 to 3.11.3
2021-02-25 13:19:54 +01:00
Pau Pérez Fabregat
dc4ec4d69d
Merge pull request #6955 from openfoodfoundation/transifex
...
Transifex
2021-02-25 11:49:49 +01:00
dependabot[bot]
5cf7fbd48c
Bump webmock from 3.11.2 to 3.11.3
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.11.2 to 3.11.3.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.2...v3.11.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-25 05:31:20 +00:00
Transifex-Openfoodnetwork
2c66184f73
Updating translations for config/locales/es_US.yml
2021-02-25 09:31:10 +11:00
Transifex-Openfoodnetwork
b81686133e
Updating translations for config/locales/ca.yml
2021-02-25 09:31:08 +11:00
Transifex-Openfoodnetwork
a4ea792325
Updating translations for config/locales/en_GB.yml
2021-02-25 09:31:07 +11:00
Transifex-Openfoodnetwork
4c28bcf0d1
Updating translations for config/locales/fr_CA.yml
2021-02-25 09:31:05 +11:00
Transifex-Openfoodnetwork
3cbb14af04
Updating translations for config/locales/en_CA.yml
2021-02-25 09:31:02 +11:00
Transifex-Openfoodnetwork
f77417acef
Updating translations for config/locales/en_US.yml
2021-02-25 09:31:00 +11:00
Transifex-Openfoodnetwork
65e040948f
Updating translations for config/locales/fr.yml
2021-02-25 09:30:58 +11:00
Transifex-Openfoodnetwork
2fa6583176
Updating translations for config/locales/es.yml
2021-02-25 09:30:55 +11:00
Andy Brett
bc7477795c
Merge pull request #6910 from andrewpbrett/remove-order-capture
...
Make orders not capturable if they have a payment pending authorization
2021-02-24 12:20:43 -08:00
Pau Pérez Fabregat
d7d86729ad
Merge pull request #6929 from efgalvao/issue#6892
...
Fix the issue #6892
2021-02-24 20:48:27 +01:00
Andy Brett
741ed73cf5
add specs for enterprises with nil or unknown category
2021-02-24 11:43:53 -08:00
Andy Brett
106803cc0b
Merge pull request #6945 from openfoodfoundation/dependabot/bundler/stripe-5.30.0
...
Bump stripe from 5.29.1 to 5.30.0
2021-02-24 10:11:24 -08:00
Pau Pérez Fabregat
15e6c28cc5
Merge pull request #6954 from coopdevs/remove-dead-serializer
...
Remove dead serializer
2021-02-24 18:01:29 +01:00
Transifex-Openfoodnetwork
6b0339df63
Updating translations for config/locales/fr_CA.yml
2021-02-25 03:33:32 +11:00
Transifex-Openfoodnetwork
3eec52b8f1
Updating translations for config/locales/en_CA.yml
2021-02-25 03:33:26 +11:00
Transifex-Openfoodnetwork
7b52abbd35
Updating translations for config/locales/fr_CA.yml
2021-02-25 03:30:39 +11:00
Transifex-Openfoodnetwork
3825712755
Updating translations for config/locales/es_US.yml
2021-02-25 03:30:28 +11:00
Transifex-Openfoodnetwork
0a0ba1255a
Updating translations for config/locales/ca.yml
2021-02-25 03:30:26 +11:00
Transifex-Openfoodnetwork
dbb0d9bd38
Updating translations for config/locales/en_GB.yml
2021-02-25 03:30:24 +11:00
Transifex-Openfoodnetwork
583e091f67
Updating translations for config/locales/de_DE.yml
2021-02-25 03:30:23 +11:00
Transifex-Openfoodnetwork
c169e63b53
Updating translations for config/locales/fr.yml
2021-02-25 03:30:19 +11:00
Matt-Yorkley
0f0f3e1ab4
Merge pull request #6940 from drummer83/patch-1
...
Create independent title string for 'Map' page
2021-02-24 17:24:25 +01:00
Pau Perez
ec3b402856
Remove dead serializer
...
This became unused in
b9d72ce4cf (diff-5df9d1d16b9e9ac1724af5c6180ca86f7caeb6a4880d2f77ac25fbe757b597b9) .
2021-02-24 17:09:16 +01:00
Pau Pérez Fabregat
0e03864aa9
Merge pull request #6906 from jibees/6895-close-tooptip-when-user-clicks-anywhere-else
...
Close unit price tooltip when user click outside the tooltip
2021-02-24 15:19:25 +01:00
Pau Pérez Fabregat
d513dc31de
Merge pull request #6905 from jibees/6498-show-unit-price-in-checkout
...
Show unit price in checkout process (both cart page and cart sidebar)
2021-02-24 11:59:25 +01:00
Maikel
0654e3d1cf
Merge pull request #6854 from openfoodfoundation/dependabot/bundler/rswag-2.4.0
...
Bump rswag from 2.3.3 to 2.4.0
2021-02-24 15:47:31 +11:00
Maikel Linke
bcd9ea2b87
Update generated swagger file
...
rake rswag PATTERN="spec/requests/api/*_spec.rb"
This file is just a demo so far. The more complete description of the
API is: /swagger.yaml
2021-02-24 15:45:47 +11:00
Andy Brett
2d304bd997
add default icon value if enterprise.category is nil
2021-02-23 11:37:36 -08:00
Pau Pérez Fabregat
89947c8154
Merge pull request #6946 from openfoodfoundation/dependabot/bundler/awesome_nested_set-3.4.0
...
Bump awesome_nested_set from 3.3.1 to 3.4.0
2021-02-23 20:37:07 +01:00
Pau Perez
116109c63d
Make /api/orders N+1 free
...
With the help of the bullet gem, and since we remove a couple of N+1s
already, remove them all was just a few keystrokes away. This commits
gets us from 42 SQL queries to 17, and 364.5ms to 253.9ms on my machine
where I just have the sample data's orders. As usual, this will have
a much bigger impact in scenarios with more data.
2021-02-23 10:26:12 -08:00
Pau Perez
20a7f2f24e
Eager load payment and subs. order associations
...
This removes the N+1 queries caused by
`Api::Admin::OrderSerialier#ready_to_capture` when used from
`Api::OrdersController#index`. While it's fine for the single-order
controller actions, it's not for this one that deals with a collection
of orders.
Fortunately, `SearchOrders` is used only in this controller action so we
can put the `includes` calls there, otherwise, we would need to refactor
it a bit to pass in a context-specific AR relation.
2021-02-23 10:26:12 -08:00
Andy Brett
d62a984939
make orders not capturable if they have a payment pending authorization
2021-02-23 10:26:04 -08:00
Matt-Yorkley
9852470ef6
Merge pull request #6913 from Matt-Yorkley/rails-5-backports
...
Rails 5 backports
2021-02-23 11:55:31 +01:00
dependabot[bot]
37707f4a5b
Bump awesome_nested_set from 3.3.1 to 3.4.0
...
Bumps [awesome_nested_set](https://github.com/collectiveidea/awesome_nested_set ) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/collectiveidea/awesome_nested_set/releases )
- [Changelog](https://github.com/collectiveidea/awesome_nested_set/blob/master/CHANGELOG )
- [Commits](https://github.com/collectiveidea/awesome_nested_set/compare/v3.3.1...v3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-23 05:35:38 +00:00
dependabot[bot]
f7173ff0b0
Bump stripe from 5.29.1 to 5.30.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.29.1 to 5.30.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.29.1...v5.30.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-23 05:35:07 +00:00
Maikel Linke
b61ce13a1b
Add missing helper to UserMailer
2021-02-23 11:24:55 +11:00
Maikel Linke
a971b62068
Emphasise ways to get help in user emails
...
We had a very prominent footer showing how to get in contact with the
local instance people but most users need to get in contact with the
enterprise they are buying from. So removing all those details and
replacing them by a simple "powered by" line will hopefully direct
attention to the shop's contact details.
2021-02-23 11:24:55 +11:00
Maikel
3e0547f563
Merge pull request #6926 from andrewpbrett/check-nan
...
Ensure unit_value is a number
2021-02-23 10:40:00 +11:00
drummer83
7e01b76af2
Create independent title string for 'Map' page
...
The "map" page didn't have a separate Transifex string for the page title. Instead the string 'label_map' was being used, which is also used elsewhere on the website.
To make the page title independent from 'label_map' the title string 'map_title' is added (like on shops page, producers page etc.).
2021-02-22 22:13:46 +01:00
drummer83
43055d8704
Create independent title string for 'Map' page
...
The "map" page didn't have a separate Transifex string for the page title. Instead the string 'label_map' was being used, which is also used elsewhere on the website. So no good idea to change that.
To make the page title independent from 'label_map' the title string is changed to 'map_title' (like on shops page, producers page etc.).
2021-02-22 21:29:42 +01:00
Matt-Yorkley
0e3429dc35
Merge pull request #6758 from Matt-Yorkley/enterprise-fees-refactor
...
Enterprise fees refactor
2021-02-22 17:59:18 +01:00
Andy Brett
dac7176bde
Merge pull request #6922 from jibees/6917-fix-prefilled-date-for-new-date-picker-
...
Separate date format used for server communication from user-readable date
2021-02-22 08:23:51 -08:00
Andy Brett
ff243c40a7
Merge pull request #6885 from andrewpbrett/fix-group-map-icons
...
Move map icons to /public
2021-02-22 08:11:54 -08:00
Pau Pérez Fabregat
fd067d01f6
Merge pull request #6937 from openfoodfoundation/transifex
...
Transifex
2021-02-22 16:37:54 +01:00
Transifex-Openfoodnetwork
13f5083386
Updating translations for config/locales/de_DE.yml
2021-02-23 02:05:31 +11:00
Transifex-Openfoodnetwork
2aa90a4bbe
Updating translations for config/locales/de_DE.yml
2021-02-23 02:02:28 +11:00
Pau Pérez Fabregat
f7f8ecf654
Merge pull request #6930 from openfoodfoundation/dependabot/bundler/activerecord-import-1.0.8
...
Bump activerecord-import from 1.0.7 to 1.0.8
2021-02-22 13:05:41 +01:00
Pau Pérez Fabregat
9c75efdce8
Merge pull request #6921 from openfoodfoundation/transifex
...
Transifex
2021-02-22 13:05:04 +01:00
Jean-Baptiste Bellet
9bc5aa69bb
Use the right default date time format
...
- Using the altInput from flatpickr forces us to use this default date format which is `%Y-%m-%d %H:%M`
2021-02-22 13:00:43 +01:00
Jean-Baptiste Bellet
c22101783c
Forward focus event on original input as flatpickr instance is open
...
- Thus, warning about modifying the opening date of an order cycle with active subscription will trigger (see `spec/features/admin/order_cycles/list_spec.rb`)
2021-02-22 13:00:43 +01:00
Jean-Baptiste Bellet
e93474d493
Look for hidden input using the right date time format
...
- This is an option, and by default it has the previous behavior: look only for visible element
- This option allows us to look for non-visible elements
- Using new altInput from flatpickr create a input hidden element. This is why we need to look at this element.
- Using the altInput from flatpickr forces us to use this default date format
- As we now use `altInput` from flatpickr, the value used to communicate between backend and frontend is stored into an input type hidden.
2021-02-22 13:00:04 +01:00
Jean-Baptiste Bellet
fbe53a3a2e
Use UI to fill date into datetimepicker
...
This creates a new method to select date and time from datetimepicker.
Field cannot be filled "manually" (ie. by entering its value)
2021-02-22 12:58:29 +01:00
Transifex-Openfoodnetwork
83ed5dde85
Updating translations for config/locales/es_US.yml
2021-02-22 20:59:57 +11:00
Transifex-Openfoodnetwork
3698d0b4ad
Updating translations for config/locales/en_GB.yml
2021-02-22 20:10:03 +11:00
Andy Brett
5dcda317d2
add bugsnag alert
2021-02-21 22:27:58 -08:00
Andy Brett
dec6d2189f
add unit test for unit_value
2021-02-21 22:26:36 -08:00
dependabot[bot]
9b13ac78be
Bump activerecord-import from 1.0.7 to 1.0.8
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.0.7...v1.0.8 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-22 05:56:33 +00:00
Andy Brett
55215bb59a
Merge pull request #6899 from Matt-Yorkley/cost-price-dead-code
...
Remove cost_price and other dead code
2021-02-21 11:10:17 -08:00
edmar.galvao@codeminer42.com
cf6fe1a903
Fix the issue #6892
2021-02-21 15:08:50 -03:00
Transifex-Openfoodnetwork
467c05bc50
Updating translations for config/locales/fr_CA.yml
2021-02-22 01:13:31 +11:00
Transifex-Openfoodnetwork
4cc4d1aa68
Updating translations for config/locales/en_CA.yml
2021-02-22 01:05:41 +11:00
Matt-Yorkley
54cd543118
Update data migration to use raw SQL
2021-02-20 19:03:19 +00:00
Matt-Yorkley
24dd971943
Include scopes in migration
2021-02-20 19:03:19 +00:00
Matt-Yorkley
1aeee83c29
Populate tax total fields on spree_orders
2021-02-20 19:03:19 +00:00
Matt-Yorkley
ec7d1d8133
Introduce tax totals in Order::Updater
2021-02-20 19:03:19 +00:00
Andy Brett
e06843c445
ensure unit_value is a number
2021-02-19 14:38:08 -08:00
Transifex-Openfoodnetwork
a5c633cd89
Updating translations for config/locales/en_US.yml
2021-02-20 07:30:09 +11:00
Andy Brett
05736884fe
prepend / to route
2021-02-19 07:43:29 -08:00
Andy Brett
e7489965c5
move map icons to public/
2021-02-19 07:43:23 -08:00
Matt-Yorkley
90f5659e68
Merge pull request #6923 from openfoodfoundation/filipefurtad0-update-doc-1
...
Update CONTRIBUTING.md
2021-02-19 15:56:01 +01:00
Jean-Baptiste Bellet
ce0d33caa6
Add needed class to be displayed as datetimepicker input
...
- + Remplace `ng-disabled` by `ng-if` as its correctly handled by flatpickr/altInput combo.
2021-02-19 15:37:12 +01:00
Jean-Baptiste Bellet
2a504f7359
Add a flatpickr plugin to attach 'id' attribute to input element
...
- As we use `altInput`, the original input is hidden. This plugin forward the `id` attribute of the original input to the input created on-the-fly and used by end user.
2021-02-19 14:59:13 +01:00
filipefurtad0
cc009ba33f
Update CONTRIBUTING.md
...
Added lines on bundle and yarn install. For context see this thread:
https://openfoodnetwork.slack.com/archives/C2GQ45KNU/p1613393033083800
2021-02-19 13:02:03 +00:00
Matt-Yorkley
40eab5f73c
Use params.dig in TaxonsController
2021-02-19 12:12:20 +00:00
Matt-Yorkley
f858fe3c68
Improve coverage in admin_orders_controller_spec
2021-02-19 11:18:00 +00:00
Matt-Yorkley
cc55e9eeda
Improve coverage in orders_controller_spec
2021-02-19 11:17:59 +00:00
Matt-Yorkley
d4750b9f26
Improve clarity of orders controller test
2021-02-19 11:17:59 +00:00
Matt-Yorkley
ba81bd8395
Remove after_action callback in Admin:OrdersController
2021-02-19 11:17:59 +00:00
Matt-Yorkley
5c5d687c9b
Remove hacks for working around closed adjustments
...
The enterprise fees are recreated and the shipping and payment fees are updated. The rest of the deleted code is not necessary (eg #with_open_adjustments). Everything else that needs to happen here is already done automatically (eg updating order totals).
2021-02-19 11:17:59 +00:00
Matt-Yorkley
9303d61db1
Update specs
2021-02-19 11:17:58 +00:00
Jean-Baptiste Bellet
424067d2dd
Add mandatory class for date input
...
- Using flatpickr component, we need to add class to have a beautiful input with white background and pointer hover it.
2021-02-19 11:22:52 +01:00
Jean-Baptiste Bellet
26be76b95c
Add new CSS specifications for flatpickr input as using altInput
...
- We now use altInput which is the only visible input to the end user.
- This input inherits all the classes from the component who instantiated it, but not the `.flatpickr-input` class.
- Add more specification to have a beautiful white background with pointer component.
2021-02-19 11:21:04 +01:00
Jean-Baptiste Bellet
c9cf989b27
Introduce altInput for flatpickr date(time)picker
...
- altInput is used to display the date to the end user: this field must be i18nized
- dateFormat is the date format used through the front and the backend
2021-02-19 11:16:43 +01:00
Transifex-Openfoodnetwork
c80b67ed9c
Updating translations for config/locales/es.yml
2021-02-19 21:10:34 +11:00
Transifex-Openfoodnetwork
1ae4786a06
Updating translations for config/locales/ca.yml
2021-02-19 21:10:00 +11:00
Transifex-Openfoodnetwork
5782504b3a
Updating translations for config/locales/en_FR.yml
2021-02-19 21:01:34 +11:00
Transifex-Openfoodnetwork
86fa186421
Updating translations for config/locales/fr.yml
2021-02-19 21:01:32 +11:00
Maikel Linke
fe3fb78f76
Update from Transifex
2021-02-19 15:56:50 +11:00
Maikel
af832666ff
Merge pull request #6916 from openfoodfoundation/transifex
...
Transifex
2021-02-19 15:50:04 +11:00
Maikel Linke
5b94049620
Whitelist params for several settings for Rails 5
...
Rails 5 is a bit stricter and Spree's Config#set method doesn't work
with a Parameters object.
2021-02-19 14:20:15 +11:00
Matt-Yorkley
5d1af5620c
Merge pull request #6674 from cillian/include-ready-for-in-producer-notification
...
Include the 'Ready for' time for the order cycle in the Notify Producers email
2021-02-18 22:01:08 +01:00
Transifex-Openfoodnetwork
5c431fa99c
Updating translations for config/locales/en_IE.yml
2021-02-19 04:34:00 +11:00
Matt-Yorkley
c47902d932
Fix params in Admin::EnterprisesController#register
2021-02-18 15:04:09 +00:00
Matt-Yorkley
84f56b2b44
Fix relation/array handling in OrderCycles List
2021-02-18 14:59:38 +00:00
Matt-Yorkley
aebd785a54
Fix persistence issue in view test setup
2021-02-18 14:58:25 +00:00
Jean-Baptiste Bellet
dd0ef0d599
Display unit price info if feature is enabled
2021-02-18 15:05:40 +01:00
Jean-Baptiste Bellet
ee4943f6e2
Display unit price on /cart page
...
- Use a new class to specify css customization
- Add to `line_item.rb` a fake method: `unit_price_price_and_unit` @andrewpbrett will change it with real values.
- Add a new variable: $text-xs to specify small font-size
squash "Display unit price on /cart page"
2021-02-18 15:02:30 +01:00
Jean-Baptiste Bellet
5914e6c885
Add a context to question mark icon with tooltip to display it adjusted
...
- This behavior permit use to create custom CSS specifications to display this tooltip best fitted to the context.
2021-02-18 15:02:30 +01:00
Jean-Baptiste Bellet
5b91f096ba
Add unit price information into the cart
...
- .total-price element must be a div (display: block) to be text right aligned (and not being float: right)
- use .option-text to display a grey text
- use display: flex to display question mark icon and text information
2021-02-18 15:02:30 +01:00
Matt-Yorkley
76009c259f
Ensure encodable object in StripeAccountsController
...
Fixes:
```
Admin::StripeAccountsController#connect redirects to Stripe Authorization url constructed OAuth
Failure/Error: url_params = { state: JWT.encode(payload, key, 'HS256'), scope: "read_write" }
JSON::GeneratorError:
only generation of JSON objects or arrays allowed
# ./app/controllers/admin/stripe_accounts_controller.rb:8:in `connect'
# ./spec/controllers/admin/stripe_accounts_controller_spec.rb:18:in `block (3 levels) in <top (required)>'
```
2021-02-18 13:51:01 +00:00
Matt-Yorkley
3976f8ef89
Use params.dig when traversing nested params in passwords controllers
2021-02-18 13:05:16 +00:00
Matt-Yorkley
12c9ac7ccd
Use params.dig when traversing nested params in views
2021-02-18 13:02:58 +00:00
Matt-Yorkley
219c982db7
Re-implement pre-Rails-5 versions of #implement! and #decrement! on Spree::LineItem
...
Rails 5 introduced some breaking changes to these built-in methods, and the new versions no longer work correctly in relation to decrementing stock with VariantOverrides.
2021-02-18 12:28:24 +00:00
Matt-Yorkley
dfadcbd2e0
Fix relation/array modification issues in EnterprisesHelper
2021-02-18 12:28:24 +00:00
Pau Pérez Fabregat
1fc21bdcb3
Merge pull request #6903 from openfoodfoundation/transifex
...
Transifex
2021-02-18 13:23:02 +01:00
Matt-Yorkley
18a354ec1e
Fix private method called
...
```
Failure/Error: variant.stock_items.first.update_attribute(:count_on_hand, 10)
NoMethodError:
private method `count_on_hand=' called for #<Spree::StockItem:0x00005573998948a8>
Did you mean? count_on_hand
count_on_hand?
count_on_hand_was
# ./spec/models/spree/variant_spec.rb:249:in `block (5 levels) in <module:Spree>'
# -e:1:in `<main>'
```
2021-02-18 12:20:29 +00:00
Matt-Yorkley
a8009d044b
Use permit in StripeAccountsController
2021-02-18 12:20:29 +00:00
Matt-Yorkley
1535c680f5
Fix direct params access in StripeAccountsController
2021-02-18 12:20:28 +00:00
Pau Pérez Fabregat
3c208a4fe9
Merge pull request #6911 from mkllnk/remove-dead-rails3-code
...
Remove dead code needed for Rails 3
2021-02-18 12:45:03 +01:00
Pau Pérez Fabregat
a21a8b18b1
Merge pull request #6861 from ccozkan/new-product-form-on_hand-field-improvements
...
Remove required field asterisk from on_hand's field on new products form
2021-02-18 12:39:58 +01:00
Matt-Yorkley
5a260b4e71
Update deprecated middleware configurations
2021-02-18 11:03:20 +00:00
Matt-Yorkley
7230d2767c
Add concern for accessing raw params hash
2021-02-18 11:02:22 +00:00
Matt-Yorkley
c8824ec59f
Fix undefined method #push on ActiveRecord::Relation
2021-02-18 11:00:24 +00:00
Matt-Yorkley
2413afa355
Update patch with warning
2021-02-18 10:57:03 +00:00
Transifex-Openfoodnetwork
1e51884cb2
Updating translations for config/locales/en_FR.yml
2021-02-18 21:46:42 +11:00
Transifex-Openfoodnetwork
cb5543ea75
Updating translations for config/locales/fr.yml
2021-02-18 21:43:20 +11:00
Matt-Yorkley
c8ff745471
Patch paperclip bug
2021-02-18 10:42:57 +00:00
Transifex-Openfoodnetwork
ff423a7b7c
Updating translations for config/locales/de_DE.yml
2021-02-18 20:57:34 +11:00
Transifex-Openfoodnetwork
88e8d110b3
Updating translations for config/locales/es.yml
2021-02-18 18:45:06 +11:00
Transifex-Openfoodnetwork
ce501d4715
Updating translations for config/locales/ca.yml
2021-02-18 18:44:58 +11:00
Maikel Linke
29d7596b4e
Remove dead code needed for Rails 3
...
This was initially added to allow unprivileged database users to run the
app but Rails 4 contains that patch already.
References:
b70edd542
719c45b40
2021-02-18 16:18:54 +11:00
Transifex-Openfoodnetwork
a48d8d8a61
Updating translations for config/locales/pt_BR.yml
2021-02-18 10:16:53 +11:00
Andy Brett
f463af327c
Merge pull request #6808 from andrewpbrett/authorize-payment-links
...
Allow a customer to perform further action for a Stripe payment if needed (#4181 )
2021-02-17 10:17:51 -08:00
Pau Pérez Fabregat
8068c6015f
Merge pull request #6836 from coopdevs/customer-balance-reports
...
Customer balance reports
2021-02-17 17:34:37 +01:00
Matt-Yorkley
719b65138f
Add tax total fields to spree_orders
2021-02-17 16:15:34 +00:00
Matt-Yorkley
899552cfee
Improve summing of line item totals
2021-02-17 16:15:34 +00:00
Matt-Yorkley
752d8bd5a0
Start refactoring Order::Updater class
2021-02-17 16:15:34 +00:00
Matt-Yorkley
b31d75aa67
Remove cost_price fields from database
2021-02-17 14:29:30 +00:00
Matt-Yorkley
42a5d7cdc7
Delete dead code Variant#set_option_value
2021-02-17 14:27:51 +00:00
Matt-Yorkley
105f59d959
Delete dead code Variant#default_price?
2021-02-17 14:27:51 +00:00
Matt-Yorkley
4213f66afb
Delete dead code Variant#name_and_sku
2021-02-17 14:27:51 +00:00
Matt-Yorkley
d06fee026c
Delete dead code Variant#on_backorder
2021-02-17 14:27:51 +00:00
Matt-Yorkley
81ac2c5add
Delete code related to :cost_price field
2021-02-17 14:27:51 +00:00
Matt-Yorkley
12dedf8a3b
Merge pull request #6774 from Matt-Yorkley/increase-precision
...
Increase limit on database columns that involve prices
2021-02-17 15:06:19 +01:00
Jean-Baptiste Bellet
c313083593
Specify background position and with/height
...
- Click on this background trigger the tooltip close event.
2021-02-17 14:59:29 +01:00
Transifex-Openfoodnetwork
789e2dca7b
Updating translations for config/locales/de_DE.yml
2021-02-17 23:15:21 +11:00
Pau Pérez Fabregat
766acdf75b
Merge pull request #6900 from openfoodfoundation/try-out-gh-actions-as-ci
...
Add Github CI build workflow
2021-02-17 12:45:15 +01:00
Pau Perez
e4c0fa5043
Add Github CI build workflow
...
based on
https://docs.github.com/en/actions/guides/building-and-testing-ruby#starting-with-the-ruby-workflow-template .
Things worth mentioning:
* ruby/setup-ruby reads `.ruby-version` by default. See:
https://github.com/ruby/setup-ruby#supported-version-syntax
* I chose to run on ubuntu-18.04 because that's what we use in
production. This should reduce potential "it runs on machine but fails
in CI" due to different system libraries versions and such.
We're temporarily running only `spec/queries/` specs because we want it
to finish quickly as we iterate on its configuration.
2021-02-17 12:37:11 +01:00
Pau Pérez Fabregat
a88280566c
Merge branch 'master' into increase-precision
2021-02-17 11:36:36 +01:00
Pau Pérez Fabregat
297927c8df
Merge pull request #6897 from openfoodfoundation/transifex
...
Transifex
2021-02-17 11:12:14 +01:00
Pau Pérez Fabregat
16140b7b0b
Merge pull request #6843 from Matt-Yorkley/tax-rates-double-take
...
Also soft-delete tax rates when changing `included_in_price`
2021-02-17 09:41:07 +01:00
Transifex-Openfoodnetwork
4d07faff06
Updating translations for config/locales/es.yml
2021-02-17 19:37:21 +11:00
Transifex-Openfoodnetwork
93bb84ddd0
Updating translations for config/locales/ca.yml
2021-02-17 19:37:10 +11:00
Andy Brett
cfd8403125
Merge pull request #6865 from jibees/6833-bom-fix-display-issue-for-product
...
Fix some display issues on Bulk Order Management page
2021-02-16 19:06:42 -08:00
Maikel
10c86e852f
Merge pull request #6888 from mkllnk/use-google-tiles-with-google-maps
...
Use Google's map tiles with Google Maps
2021-02-17 08:56:03 +11:00
Transifex-Openfoodnetwork
5bd336ac09
Updating translations for config/locales/en_FR.yml
2021-02-17 05:38:48 +11:00
Transifex-Openfoodnetwork
3dd2dd31cd
Updating translations for config/locales/fr.yml
2021-02-17 05:38:37 +11:00
Andy Brett
d444c5d6d4
Merge pull request #6893 from openfoodfoundation/transifex
...
Transifex
2021-02-16 08:32:07 -08:00
Pau Pérez Fabregat
71c8a62351
Merge pull request #6851 from jibees/6497-show-unit-price-in-shopfront
...
Show unit price in shopfront
2021-02-16 16:33:49 +01:00
Transifex-Openfoodnetwork
6de797c0a4
Updating translations for config/locales/fr_CA.yml
2021-02-17 02:33:21 +11:00
Transifex-Openfoodnetwork
1ceda0c076
Updating translations for config/locales/en_CA.yml
2021-02-17 02:29:14 +11:00
Jean-Baptiste Bellet
a8cc0d1001
add translation for question mark tooltip
2021-02-16 15:26:36 +01:00
Jean-Baptiste Bellet
e509925789
Use question mark with tooltip directive
...
Needs some css customization due to the use of a button element (instead of a basic span)
2021-02-16 15:26:21 +01:00
Jean-Baptiste Bellet
4be2b42fe1
create a new directive: question mark with tooltip
...
- Display a rounded blue question mark icon
- Show (hide) on click a blue tooltip on top of the question mark icon
2021-02-16 15:26:21 +01:00
Jean-Baptiste Bellet
7442d06bed
add new template to manage variant
...
- The aim of this template is to display unit price
- Duplicate the angular directive
- Add a question mark icon and its own file
- Add some needed colors in the branding file
2021-02-16 15:26:21 +01:00
Jean-Baptiste Bellet
8c42388af1
add a randomized unit price for variant
...
unit price is composed with :
- a unit_price_price which is a number that can be localized (depending on the currency)
- a unit_price_unit which can be either `item` of `kg`
@andrewpbrett will do stuff to have a relevant unit price for each variant
2021-02-16 15:26:21 +01:00
Jean-Baptiste Bellet
d97b46cd5b
add new feature for beta testers: unit_price
...
The aim of this "feature toggle" is to enable the unit price display for each product/variants.
By default activate on both development and staging environment.
2021-02-16 15:26:21 +01:00
Matt-Yorkley
3da5c0d7fd
Update TaxRate transition spec
...
Setting a tax rate to included fails a validation if a default zone doesn't exist, so that's added. Also improved the tested scenarios and some of the details checked on the updated objects.
2021-02-16 13:21:57 +00:00
Pau Perez
36ce39a217
Sort OC report orders by completed_at
...
This is then consistent with the ordering we use to list orders in
/admin, which is more useful. As a result, the test is also more robust.
2021-02-16 13:25:21 +01:00
dependabot[bot]
c56c5d0028
Bump rswag from 2.3.3 to 2.4.0
...
Bumps [rswag](https://github.com/rswag/rswag ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.3.3...2.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-16 08:52:23 +00:00
Pau Pérez Fabregat
77dc6b7d57
Merge pull request #6890 from openfoodfoundation/dependabot/bundler/rubocop-1.10.0
...
Bump rubocop from 1.9.1 to 1.10.0
2021-02-16 09:51:15 +01:00
Pau Pérez Fabregat
fc25a921d3
Merge pull request #6891 from openfoodfoundation/transifex
...
Transifex
2021-02-16 09:50:13 +01:00
Transifex-Openfoodnetwork
67a201de55
Updating translations for config/locales/en_GB.yml
2021-02-16 18:07:29 +11:00
dependabot[bot]
e87550f1e9
Bump rubocop from 1.9.1 to 1.10.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.9.1...v1.10.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-16 05:32:38 +00:00
Maikel Linke
445fae4d09
Use Google's map tiles with Google Maps
...
We started to move to Open Street Maps (OSM) and one simple change was
to show OSM tiles on top of the current Google Maps functionality. This
hybrid use violates Google's terms and conditions though and I'm
reverting it here (basically reverting daa5b00a2 ).
Another branch of work was already started to use OSM without Google
functionality and it's available behind a feature toggle. We can
continue that work in our own time without a license violation. This
change is only changing the tiles, the look of the map and doesn't touch
any functionality which was always provided by Google Maps.
2021-02-16 14:30:24 +11:00
Andy Brett
560ad49057
unit tests for ProcessPaymentIntent
2021-02-15 18:09:07 -08:00
Andy Brett
05e762ff21
add controller specs for confirming payment intent
2021-02-15 17:09:38 -08:00
Andy Brett
f8239ed3ed
use image path generator for map icons
2021-02-15 14:43:34 -08:00
Çağrı Özkan
dee2095a13
Remove required star from on_hand field
2021-02-16 00:23:53 +03:00
Çağrı Özkan
6fad35a975
Checkout upstream's admin/products/new view
2021-02-16 00:22:09 +03:00
Pau Pérez Fabregat
897a0c7779
Merge pull request #6880 from openfoodfoundation/transifex
...
Transifex
2021-02-15 16:47:51 +01:00
Transifex-Openfoodnetwork
8277093fa9
Updating translations for config/locales/de_DE.yml
2021-02-15 23:32:14 +11:00
Pau Pérez Fabregat
ffc850a794
Merge pull request #6876 from openfoodfoundation/transifex
...
Transifex
2021-02-15 11:50:41 +01:00
Transifex-Openfoodnetwork
347f193aeb
Updating translations for config/locales/es.yml
2021-02-15 19:56:52 +11:00
Transifex-Openfoodnetwork
0084aff9d4
Updating translations for config/locales/ca.yml
2021-02-15 19:56:38 +11:00
Transifex-Openfoodnetwork
03d8ecbb56
Updating translations for config/locales/en_FR.yml
2021-02-15 19:27:01 +11:00
Transifex-Openfoodnetwork
41defd3d2f
Updating translations for config/locales/fr.yml
2021-02-15 19:26:36 +11:00
Andy Brett
01293a3a3a
Merge pull request #6863 from turinglabsorg/master
...
deleting only OFN related Docker containers and images
2021-02-13 09:24:00 -08:00
Andy Brett
77a3649e50
documentation
2021-02-12 13:46:05 -08:00
Andy Brett
c851705d5a
reload order's new state after processing payment
2021-02-12 13:36:17 -08:00
Andy Brett
cd2b4d2fb2
advance order after processing payment intent
2021-02-12 13:36:04 -08:00
Andy Brett
8c7bf863f8
return pending payments in order serializer
2021-02-12 12:20:35 -08:00
Andy Brett
6efad74c5c
add authorize link to transactions page
2021-02-12 12:20:35 -08:00
Andy Brett
1b2416652f
update translations
2021-02-12 10:45:54 -08:00
Andy Brett
538dfb1e59
Merge pull request #6868 from openfoodfoundation/transifex
...
Transifex
2021-02-12 10:36:46 -08:00
Andy Brett
0a7396eb1c
Merge pull request #6713 from andrewpbrett/sca-subs-emails
...
Send emails when subscription payments require SCA auth
2021-02-12 08:23:32 -08:00
Jean-Baptiste Bellet
034153dacf
Fix some columns grid system issues
...
- Use class directly instead of attribut of element (`.three` instead of `%div{ :class => "three"}` )
- Correct a lots of bad calculation about columns grid system
- Use class instead of style if it's possible (`.text-center` instead of `:style => 'text-align: center;'`)
2021-02-12 10:02:27 +01:00
Transifex-Openfoodnetwork
2981be7013
Updating translations for config/locales/en_US.yml
2021-02-12 12:56:39 +11:00
Maikel
9aa7dd3206
Merge pull request #6714 from luisramos0/rails5-new
...
[Rails 5] Update Gemfile_next.lock and fix app/services/permissions/order.rb
2021-02-12 12:32:39 +11:00
Andy Brett
7c2febdd78
Merge pull request #6813 from jibees/6795-missing-cases-for-loading-spinner
...
Make loading spinner visible
2021-02-11 10:55:05 -08:00
Andy Brett
b5e9c935e9
Merge pull request #6821 from cillian/admin-product-sorting-bug
...
Include sort direction parameter during bulk product update to prevent JS error causing 'Saving' text to hang
2021-02-11 10:54:24 -08:00
Andy Brett
5a8a3b8d6b
Merge pull request #6822 from arku/chore/cost-price-removal
...
Remove cost price field field from product variant form
2021-02-11 10:48:00 -08:00
Andy Brett
96a746175d
update spec with new behavior
2021-02-11 10:36:50 -08:00
Pau Pérez Fabregat
7f882bfe92
Merge pull request #6295 from luisramos0/remove_pin
...
Remove Pin Payments
2021-02-11 18:04:59 +01:00
Transifex-Openfoodnetwork
96dea93745
Updating translations for config/locales/en_FR.yml
2021-02-12 03:56:37 +11:00
Transifex-Openfoodnetwork
6d87861efc
Updating translations for config/locales/fr.yml
2021-02-12 03:55:05 +11:00
Transifex-Openfoodnetwork
69724cfc24
Updating translations for config/locales/ru.yml
2021-02-12 02:51:41 +11:00
Transifex-Openfoodnetwork
09575b20bd
Updating translations for config/locales/de_DE.yml
2021-02-12 02:51:40 +11:00
Transifex-Openfoodnetwork
e168393662
Updating translations for config/locales/es.yml
2021-02-12 02:37:16 +11:00
Transifex-Openfoodnetwork
ae8488da92
Updating translations for config/locales/ca.yml
2021-02-12 02:35:35 +11:00
turinglabsorg
07a42e8a21
deleting only OFN related Docker containers and images
2021-02-11 14:30:07 +01:00
Pau Pérez Fabregat
99dbd8afa7
Merge pull request #6791 from filipefurtad0/customers_spec
...
enhances customers_spec.rb to check customer balance, after additional payments were added to an order
2021-02-11 11:36:30 +01:00
Pau Pérez Fabregat
5fd1bc3604
Merge pull request #6862 from openfoodfoundation/dependabot/bundler/geocoder-1.6.5
...
Bump geocoder from 1.6.4 to 1.6.5
2021-02-11 11:23:13 +01:00
Pau Pérez Fabregat
7fe79eccea
Merge pull request #6691 from jibees/6664-new-datetimepicker
...
6664 new datetimepicker
2021-02-11 11:21:19 +01:00
Pau Pérez Fabregat
34ce3c0db1
Merge branch 'master' into remove_pin
2021-02-11 11:19:18 +01:00
Pau Perez
23b0885f4b
Turn ivars into private attr_readers
...
This makes them more changeable and robust. Ruby will raise
NoMethodError on typos while it'll silently create a new ivar without
us noticing. Also, in my experience, a reader method gives more room to
future refactorings and eases testing because methods are easier to
stub.
2021-02-11 11:04:39 +01:00
Pau Perez
e2853b9afb
Do not load order twice
...
The controller already does so, then, we can pass it to the service and
avoid that extra round-trip to the DB and save some memory. Spree::Order
is a rather bulky object (God object code smell perhaps) and it'll
surely make a difference.
2021-02-11 11:04:21 +01:00
Pau Perez
e703113c08
Fix typo in test wording
2021-02-11 10:29:56 +01:00
filipefurtad0
33f7335c02
splitted testcases into different context blocks
2021-02-11 10:29:56 +01:00
filipefurtad0
82b93fc757
declared relevant variables with let!
2021-02-11 10:29:56 +01:00
filipefurtad0
3160d723b0
checks whether second payment was added correctly to the order
2021-02-11 10:29:56 +01:00
filipefurtad0
467b9e71a2
adds additional test case, in which a negative payment is added to an order
2021-02-11 10:29:56 +01:00
filipefurtad0
c722e1c082
declares variables for orders using let; prepares additional test cases
2021-02-11 10:29:56 +01:00
dependabot[bot]
f3d1206de8
Bump geocoder from 1.6.4 to 1.6.5
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.6.4 to 1.6.5.
- [Release notes](https://github.com/alexreisner/geocoder/releases )
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.6.4...v1.6.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-11 09:29:01 +00:00
Pau Pérez Fabregat
752421cd8b
Merge pull request #6814 from jibees/6797-to-much-white-space-when-editing-subscription
...
6797 Too much white space when editing subscription
2021-02-11 10:18:31 +01:00
Çağrı Özkan
4db41f8a16
Change on_hand's field to number_field and add required attribute
2021-02-10 22:52:31 +03:00
Andy Brett
891874995b
refactor ProcessPaymentIntent to service
2021-02-10 11:22:29 -08:00
Andy Brett
ef6d1a3afb
refactor flag param to module
2021-02-10 11:06:01 -08:00
Pau Pérez Fabregat
3a3485614d
Merge pull request #6839 from openfoodfoundation/transifex
...
Transifex
2021-02-10 18:52:35 +01:00
Pau Pérez Fabregat
38da86c65b
Merge pull request #6857 from andrewpbrett/remove-variant-migration
...
Remove variant migration
2021-02-10 18:45:03 +01:00
Pau Pérez Fabregat
8af805d10c
Merge pull request #6840 from coopdevs/temp-skip-flaky-specs
...
Temporarily skip very flaky specs
2021-02-10 18:42:43 +01:00
Andy Brett
9104ca72a9
refactor to descriptive method authorization_action_required?
2021-02-10 09:36:35 -08:00
Pau Pérez Fabregat
98aed88295
Merge pull request #6853 from openfoodfoundation/dependabot/bundler/stripe-5.29.1
...
Bump stripe from 5.29.0 to 5.29.1
2021-02-10 18:31:28 +01:00
Pau Pérez Fabregat
3f20d939fa
Merge pull request #6852 from openfoodfoundation/dependabot/bundler/timecop-0.9.4
...
Bump timecop from 0.9.3 to 0.9.4
2021-02-10 18:29:52 +01:00
Andy Brett
7814e74649
remove migration
2021-02-10 08:56:35 -08:00
Pau Pérez Fabregat
b7af92abb2
Merge pull request #6801 from coopdevs/toggle-customer-balance-to-entire-instance
...
Toggle customer balance to entire instance
2021-02-10 17:32:35 +01:00
dependabot[bot]
7baaa6f046
Bump stripe from 5.29.0 to 5.29.1
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.29.0 to 5.29.1.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.29.0...v5.29.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-10 05:31:53 +00:00
dependabot[bot]
dc74be45b9
Bump timecop from 0.9.3 to 0.9.4
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/travisjeffery/timecop/releases )
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.3...v0.9.4 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-10 05:30:17 +00:00
Matt-Yorkley
ff549fb62e
Also soft-delete tax rates when changing included_in_price
...
We need to do this when the included_in_price boolean changes as well, for the same reasons.
2021-02-09 17:26:16 +00:00
Matt-Yorkley
a811fb3783
Merge pull request #6838 from Matt-Yorkley/minor-rails-5-bits
...
Minor Rails 5 bits -> master
2021-02-09 14:40:13 +01:00
Matt-Yorkley
d6442bb16f
Fix get requests in API controller spec
2021-02-09 11:57:00 +00:00
Matt-Yorkley
78eb5d23f9
Update TaxRatesController spec
...
BigDecimal was throwing an error here (in Rails 5) unless it received a string, but I think this is actually an issue with the way params were being passed in the relevant spec, as opposed to the controller itself.
2021-02-09 11:57:00 +00:00
Matt-Yorkley
4c4142c56d
Fix HAML "unbalanced brackets" errors
2021-02-09 11:57:00 +00:00
Matt-Yorkley
1b947d30fa
Pass ids in params that should be ids
2021-02-09 11:57:00 +00:00
Matt-Yorkley
d9bd0e8f0e
Use alternate method for setting request.referer in controller specs
...
Apparently stubbing `request.referer` is tricky business in Rails 5... :shrugs:
2021-02-09 11:57:00 +00:00
Pau Pérez Fabregat
41410fdab5
Merge pull request #6834 from andrewpbrett/fix-variants-with-no-products
...
Remove variants with no product
2021-02-09 12:07:54 +01:00
Pau Perez
31d3854a74
Temporarily skip very flaky specs
...
These are the tests that are failing a lot across all builds, slowing
down everything in the pipe. It's better to skip these rather than
paying this huge toll. They can be restored once we spike a new CI service.
2021-02-09 11:48:06 +01:00
Pau Perez
50c429f393
Update db/schema's timestamp after migration
2021-02-09 11:27:48 +01:00
Transifex-Openfoodnetwork
66c331542c
Updating translations for config/locales/it.yml
2021-02-09 18:39:59 +11:00
Matt-Yorkley
12a513c54c
Apply an upstream fix to Spree::I18n
...
See: fe95f637c9
Fixes error mentioned in the above Spree commit.
2021-02-08 22:14:42 +00:00
Matt-Yorkley
bd7bc803cb
Fix broken syntax in multiple angular files
...
I have no idea how this was not already throwing errors before...
2021-02-08 22:13:50 +00:00
Andy Brett
9a2bf9d333
use #destroy_all
2021-02-08 13:12:40 -08:00
Pau Pérez Fabregat
a820304166
Merge pull request #6819 from openfoodfoundation/transifex
...
Transifex
2021-02-08 22:10:59 +01:00
Jean-Baptiste Bellet
653f576bb1
Fill date and time value into the fields
...
as the new datetimepicker provide a disabled input field, it needs to be virtualized (and cannot be filled in with method `fill_in`)
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
57e20373fc
overriding flatpickr selectors needs to be with uppercase
...
so disable the scss-lint check SelectorFormat
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
6a2461b30b
overriding specific selectors needs to be as specific
...
so disable the scss-lint check QualifyingElement
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
fbd6db89c9
avoid selecting the day in the previous month
...
When you select date at the end of the month (27,28,29,30,...) it is likely possible that this date is already displayed by the calender but for the previous month.
Avoid this by using css selector :not()
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
8383b19458
factorize as we need only one file for datepicker
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
9619ea06de
code climate checks
...
- use variables for colors instead of values
- trailinf line at the end of file
- new line after each declaration
- 2 spaces of indentation
- avoid qualifying elements in selectors
- prefer lowercase in hexa color
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
54f34093b4
reorder tests and set oc1 to an "updated" value
...
Seems like we need to set a value to "" before fill_in the input.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
f5c77f17a6
remove useless files.
...
As we use flatpickr, these files are useless. Delete it.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
b72ef18ad6
update datepicker_helper and add method to select date
...
Introduce a new method `select_date_from_datepicker` and then use it on test
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
3ab1d728a1
update helper with right selectors
...
As we now use flatpickr, need to update css/xpath selectors used by tests.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
1dbafcaf7d
remove animation
...
To make tests ok.
I could use Capybara.disable_animation = true, but there was no animation to old datetimepicker, so it's more consistant like this.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
6dbaf1f7f3
specify date and datetime format
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
e3db4e2e86
update test to match new datepicker
...
And use the method choose_today_from_datepicker
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
11d62eb331
add translation for "today" and "now" buttons
...
and remove useless translations
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
83f5d49ce2
remove references to jquery-ui datetimepicker
...
need to add dialog module from jquery-ui
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
84b402675a
force onChange events to fire
...
And so the "You have unsaved changes" bar appears
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
079008d99b
introduce "Now" button
...
Throught the plugin: https://github.com/jcsmorais/shortcut-buttons-flatpickr
import js library via yarn
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
329ec3455f
update order_cycles (both list and simple) tests
...
As we know use a new datepicker (flatpickr), we need to update our test.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
2ce361c655
code climate update
...
"color white should be written in hexadecimal form as #ffffff"
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
947a9da18b
remove useless translations
...
as flatpickr is already translated
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
6c3ededb0b
apply flatpickr on element
...
- update flatpickr instance value with `onOpen` callback
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
a5d58ea36c
change css selector and use a precise one
...
Be more precise on selector. `flatpickr-input` is more selective.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
e06ea6ccd3
remove unused options
...
as we use flatpickr, we don't need these options
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
4f7f8b559a
localize flatpickr date format
...
Flatpickr can format date. Use a localized dateFormat.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
4d9289c45b
Render flatpickr input more enabled
...
by default, `input[readonly]` is styled as disable one. Using flatpickr with these disable inputs need to be customized. By clinking on it, it opens the datepicker widget.
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
6cf172abc9
add flatpickr to order cycle and .datetimepicker
...
Add your new date(time)picker on both order cycle and elements with class `.datetimepicker`
set the right options to datetimepicker
2021-02-08 22:09:06 +01:00
Jean-Baptiste Bellet
c8a3951830
add flatpickr
...
add flatpick as a yarn package and import it into the appropriate files (both js and scss)
2021-02-08 22:09:06 +01:00
Transifex-Openfoodnetwork
f6d47bc3e4
Updating translations for config/locales/de_DE.yml
2021-02-09 07:00:15 +11:00
Pau Perez
cbfea1ba97
Hide new report's balance under toggle
2021-02-08 19:43:45 +01:00
Pau Perez
e4319b06e6
Take into account other finalized order states
...
This makes it consistent with other places where we show order balances.
Here though, we purposefully skip canceled ones.
2021-02-08 19:34:42 +01:00
Pau Perez
a66d1b7299
Compute order balance chaining with query object
2021-02-08 19:34:42 +01:00
Pau Perez
106dcbae01
Add test coverage to the two distinct output rows
2021-02-08 19:34:42 +01:00
Pau Perez
412bb24e42
Ensure report rows are always in the same order
...
I saw the row were returned not respecting any ordering when refreshing
the page locally. It made it hard to debug whether or not the customer
balance was right.
It's less than ideal to use `allow_any_instance_of` but with this legacy
and very coupled code, it's the best we can do.
2021-02-08 19:34:42 +01:00
Pau Pérez Fabregat
d7cf265f0e
Merge pull request #6831 from Matt-Yorkley/netread-timeout
...
Add retry handling for flaky spec timeouts
2021-02-08 19:26:01 +01:00
Andy Brett
8f59d76eb2
remove variants with no product
2021-02-08 08:57:11 -08:00
Pau Pérez Fabregat
ed1c1e5607
Merge pull request #6823 from Matt-Yorkley/dead-code-shipment
...
Dead code: Shipment#total_cost
2021-02-08 13:44:14 +01:00
Pau Pérez Fabregat
8fcfcfe813
Merge pull request #6826 from openfoodfoundation/dependabot/bundler/rswag-2.3.3
...
Bump rswag from 2.3.2 to 2.3.3
2021-02-08 13:43:23 +01:00
Pau Pérez Fabregat
8d1354f07a
Merge pull request #6827 from openfoodfoundation/dependabot/bundler/timecop-0.9.3
...
Bump timecop from 0.9.2 to 0.9.3
2021-02-08 13:42:58 +01:00
Matt-Yorkley
dcc3d933bc
Add retry handling for flaky spec timeouts
2021-02-08 12:38:22 +00:00
Transifex-Openfoodnetwork
af7ba5c535
Updating translations for config/locales/ru.yml
2021-02-08 23:32:39 +11:00
Transifex-Openfoodnetwork
fe04295ea5
Updating translations for config/locales/en_GB.yml
2021-02-08 22:33:05 +11:00
Transifex-Openfoodnetwork
6a9f6c82ef
Updating translations for config/locales/es.yml
2021-02-08 20:19:50 +11:00
Transifex-Openfoodnetwork
c638729df2
Updating translations for config/locales/ca.yml
2021-02-08 20:19:34 +11:00
Transifex-Openfoodnetwork
96c017939c
Updating translations for config/locales/en_FR.yml
2021-02-08 19:27:38 +11:00
Transifex-Openfoodnetwork
662c65665c
Updating translations for config/locales/fr.yml
2021-02-08 19:27:27 +11:00
dependabot[bot]
da71cd0b84
Bump timecop from 0.9.2 to 0.9.3
...
Bumps [timecop](https://github.com/travisjeffery/timecop ) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/travisjeffery/timecop/releases )
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md )
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.2...v0.9.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-08 05:59:25 +00:00
dependabot[bot]
c49122461c
Bump rswag from 2.3.2 to 2.3.3
...
Bumps [rswag](https://github.com/rswag/rswag ) from 2.3.2 to 2.3.3.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.3.2...2.3.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-08 05:47:09 +00:00
Maikel
173cf9e536
Merge pull request #6565 from Matt-Yorkley/adjustments-inclusive
...
[Adjustments] Improve inclusive/additional tax recording
2021-02-08 09:38:31 +11:00
Transifex-Openfoodnetwork
f97fd8f8a7
Updating translations for config/locales/de_DE.yml
2021-02-08 02:01:06 +11:00
Matt-Yorkley
14530ddbc5
Remove dead code: Shipment#total_cost
2021-02-07 13:41:44 +00:00
Matt-Yorkley
8d6468dab1
Remove dead code: Shipment#display_total_cost
2021-02-07 13:41:40 +00:00
Matt-Yorkley
b9f46d4253
Increase precision on database columns that involve prices
...
Increases the maximum number of digits (on the left side of the decimal place) that the column can hold, to allow larger values. This change is made in Spree 2.2 and is relevant in cases with either large order values, or certain currencies that have large values as standard. For example, 100 UK Pounds is roughly 4000 Thai Baht. 1 million pounds is unlikely to ever be needed as a value, but 1 million Baht is not so unlikely...
2021-02-07 00:16:32 +00:00
Matt-Yorkley
7bf31d120b
Add price field test
2021-02-07 00:05:39 +00:00
Arun Kumar Mohan
beece545de
Remove cost price field from product variant form
2021-02-06 18:48:06 -05:00
Luis Ramos
e9aa6a5cd4
Rename Pin payment methods to check
2021-02-06 11:17:11 +00:00
Luis Ramos
c0ddeceb1e
Remove Pin Payments
2021-02-06 11:15:48 +00:00
Transifex-Openfoodnetwork
5c96b3e070
Updating translations for config/locales/en_IE.yml
2021-02-06 03:50:32 +11:00
Cillian O'Ruanaidh
1fcf797d4e
Include sort direction parameter during bulk product update to prevent JS error causing 'Saving' text to hang
...
Before if you did a bulk product update there was an error:
> TypeError: Cannot set property 'variants' of null
It only seemed to happen if pagination was required i.e. more than 15 products. It seemed to be happening because the default sort order on the products API endpoint which handles the bulk update is 'created desc' but 'name asc' on the /admin/products controller.
Another fix included here is for the sorting direction arrows which were not displaying on the admin products page. The sorting arrows require the sorting expression to be on the :sorting var instead of :q.sorting.
Fixes #6399
2021-02-05 16:08:08 +00:00
Transifex-Openfoodnetwork
5eb88f60e4
Updating translations for config/locales/fr_CA.yml
2021-02-06 00:23:51 +11:00
Transifex-Openfoodnetwork
52fc9cee31
Updating translations for config/locales/en_CA.yml
2021-02-06 00:14:49 +11:00
Matt-Yorkley
9851c9a762
Merge pull request #6678 from Matt-Yorkley/soft-deprecate-tax-rates
...
Introduce soft-deprecation strategy when modifying tax rates
2021-02-05 13:16:40 +01:00
Transifex-Openfoodnetwork
1dcdbd83a2
Updating translations for config/locales/es.yml
2021-02-05 21:46:31 +11:00
Transifex-Openfoodnetwork
f941ce1c7a
Updating translations for config/locales/ca.yml
2021-02-05 21:46:27 +11:00
Pau Perez
5832bce1e4
Update all locales with the latest Transifex translations
2021-02-05 11:28:29 +01:00
Pau Pérez Fabregat
6ccf4b0245
Merge pull request #6817 from openfoodfoundation/transifex
...
Transifex
2021-02-05 11:24:00 +01:00
Transifex-Openfoodnetwork
dd2baf7e96
Updating translations for config/locales/en_FR.yml
2021-02-05 20:23:24 +11:00
Transifex-Openfoodnetwork
4a619e596e
Updating translations for config/locales/fr.yml
2021-02-05 20:22:32 +11:00
Pau Pérez Fabregat
aee56f6331
Merge pull request #6812 from openfoodfoundation/transifex
...
Transifex
2021-02-05 08:45:46 +01:00
Andy Brett
d3ad997964
Merge pull request #6792 from andrewpbrett/migrate-variant-unit-values
...
Migrate variants with nil unit_value
2021-02-04 18:00:23 -08:00
Andy Brett
f746dec537
update spec
2021-02-04 13:52:45 -08:00
Andy Brett
1e863c6e65
Merge branch 'master' into migrate-variant-unit-values
2021-02-04 13:27:30 -08:00
Andy Brett
9c135ee0f7
add default to unit_value and weight
2021-02-04 13:17:43 -08:00
Pau Pérez Fabregat
3ab6da03e7
Merge pull request #6296 from luisramos0/remove_migs
...
Remove Migs payment gateway
2021-02-04 22:07:35 +01:00
Pau Pérez Fabregat
4b892d408e
Merge pull request #6809 from andrewpbrett/remove-bogus-providers
...
Remove "Bogus" payment providers from staging and production
2021-02-04 21:09:16 +01:00
Pau Pérez Fabregat
35a76a313a
Merge pull request #6807 from jibees/6798-new-product-form-fill-all-space
...
New Product Form: Fill all space available
2021-02-04 21:08:56 +01:00
Andy Brett
212186e059
check all variants, not just where we use 'items'
2021-02-04 11:45:36 -08:00
Andy Brett
d642984261
add db constraint; check for existing nil/nan in migration
2021-02-04 11:24:35 -08:00
Pau Pérez Fabregat
f6e6b6041c
Merge pull request #6734 from coopdevs/disable-ui-mail-settings
...
Disable mail methods form so no one can edit
2021-02-04 17:57:32 +01:00
Andy Brett
91245ae6ab
also set weight to default to 0.0
2021-02-04 08:05:48 -08:00
Pau Pérez Fabregat
76fa63fd71
Merge pull request #6789 from coopdevs/authorize-only-changed-vos
...
Authorize only changed vos
2021-02-04 15:22:50 +01:00
Pau Perez
655fe887f9
Distinguish user not present and list empty
...
This is a bit more thorough.
2021-02-04 13:19:04 +01:00
Pau Perez
88e22a78c2
Execute Ruby file in each test example
...
Kernel#require prevented this from happening thus, the file was only
loaded once so tests were passing so far by pure luck.
2021-02-04 13:16:03 +01:00
Jean-Baptiste Bellet
ef42653fee
Use all available space
...
Don't need to put the table into a `.seven.columns.alpha.omega` div: use the maximum available space.
2021-02-04 12:53:12 +01:00
Jean-Baptiste Bellet
502ef8f6f2
Use as many space as available
...
Each row is sixteen long, use all space (five + eleven = sixteen)
2021-02-04 12:52:07 +01:00
Jean-Baptiste Bellet
7aef8a609e
Use method image_path
...
Instead of using URL, use the image_path method which computes the path to an image asset in the public images directory.
2021-02-04 11:51:46 +01:00
Pau Perez
d6350c3d0b
Remove deprecated Feature class implementation
...
This became dead code now.
2021-02-04 10:20:54 +01:00
Pau Perez
14cee0e45d
Add new Feature class to toggle based on a closure
...
This enables toggling features as best fits us in each case. With this
new approach we can then toggle :customer_balance to an entire instance,
which is what we want in France.
2021-02-04 10:20:54 +01:00
Transifex-Openfoodnetwork
6c4f74e4e4
Updating translations for config/locales/es.yml
2021-02-04 20:06:10 +11:00
Transifex-Openfoodnetwork
3505ced3c2
Updating translations for config/locales/ca.yml
2021-02-04 20:05:50 +11:00
Pau Pérez Fabregat
4d7b29ca33
Merge pull request #6811 from openfoodfoundation/transifex
...
Transifex
2021-02-04 10:05:07 +01:00
Transifex-Openfoodnetwork
ea134d4600
Updating translations for config/locales/en_FR.yml
2021-02-04 19:07:08 +11:00
Transifex-Openfoodnetwork
e3b7736c68
Updating translations for config/locales/fr.yml
2021-02-04 19:06:37 +11:00
Transifex-Openfoodnetwork
439280d046
Updating translations for config/locales/de_DE.yml
2021-02-04 10:52:26 +11:00
Andy Brett
51630ac77b
remove "Bogus" payment providers from staging and production
2021-02-03 14:03:13 -08:00
Luis Ramos
e5e2402a7c
Add migrate to rename Migs payments to check
2021-02-03 21:53:15 +00:00
Luis Ramos
60667e23d9
Remove en.yml migs entry
2021-02-03 21:47:37 +00:00
Luis Ramos
e69eefdc0f
Remove Migs payment gateway
2021-02-03 21:41:40 +00:00
Jean-Baptiste Bellet
4cb98dd4ac
Fill all space available
...
These two fields (Display As, and Unit Names) are mutually exclusive: they are never displayed at the same time. Use all the available space.
2021-02-03 21:44:33 +01:00
Andy Brett
5d2c612839
don't send emails if auth required during checkout
2021-02-03 10:05:51 -08:00
Andy Brett
5160140d88
move SCA Auth module out of Subscriptions since we reuse it in Checkout
2021-02-03 10:05:47 -08:00
Andy Brett
5f84cd9f13
add param to ScaAuthorize call for redirect url
2021-02-03 09:50:42 -08:00
Andy Brett
6e735739a5
after customer auth + redirect, process payment and clear cvv_response_message
2021-02-03 09:50:37 -08:00
Andy Brett
558b01896f
extract url helpers to helper module
2021-02-03 09:50:37 -08:00
Andy Brett
c0b3fc301e
add email template to notify hub that auth is required
2021-02-03 09:50:28 -08:00
Andy Brett
4e3594b8f8
remove redundant url check method
2021-02-03 09:09:05 -08:00
Andy Brett
84db1c9bb4
update text of auth emails
2021-02-03 09:07:16 -08:00
Andy Brett
50074aae9d
update db schema
2021-02-03 08:45:42 -08:00
Matt-Yorkley
389e149ded
Wrap updates in a transaction block
...
Ensures the operation will be rolled ack if either saving the new record or deleting the old record fail
2021-02-03 11:54:54 +00:00
Pau Pérez Fabregat
79f98bdfa7
Merge pull request #6770 from Matt-Yorkley/more-dead-code
...
Dead code: Spree::Order#clear_adjustments
2021-02-03 09:37:42 +01:00
Pau Pérez Fabregat
fbab5120f1
Merge pull request #6771 from Matt-Yorkley/touch-updated-at
...
Touch updated_at column when updating records via #update_column
2021-02-03 09:33:37 +01:00
Luis Ramos
0a1863aa2d
Remove extra empty line
2021-02-02 23:05:11 +00:00
Luis Ramos
54489948b9
Remove useless assignment
2021-02-02 23:04:12 +00:00
Luis Ramos
eb56d1ff28
Put the workaround inside a if clause on rails version so it works in both rails 4 and rails 5
2021-02-02 23:00:21 +00:00
Luis Ramos
886888c2a8
Workaround to get where_values to work in rails 5
2021-02-02 22:51:34 +00:00
Luis Ramos
bb91d37270
Force angular-rails-templates to be below 1.1.0
2021-02-02 22:51:34 +00:00
Luis Ramos
c171441b6c
Add rails-controller-testing to rails 5
2021-02-02 22:51:34 +00:00
Luis Ramos
08d5a82627
Move some entries in Gemfile to general part, no need to keep these as rails 5 exceptions as a general rule works well
2021-02-02 22:51:34 +00:00
Luis Ramos
068b72e41a
Update Gemfile_next.log by running bundle install
2021-02-02 22:51:34 +00:00
Andy Brett
4ba5d9dafc
Merge pull request #6779 from openfoodfoundation/dependabot/bundler/test-unit-3.4.0
...
Bump test-unit from 3.3.9 to 3.4.0
2021-02-02 14:50:23 -08:00
Andy Brett
83d7d49e44
refactor sub confirm job; move email to service
2021-02-02 10:43:37 -08:00
Andy Brett
142af0055c
use #find_each instead of #each
2021-02-02 09:40:17 -08:00
Andy Brett
109a3da104
use more efficient query; enforce not null at db level
2021-02-02 09:32:47 -08:00
Pau Pérez Fabregat
19636c687e
Merge pull request #6796 from openfoodfoundation/transifex
...
Transifex
2021-02-02 15:50:15 +01:00
Pau Pérez Fabregat
32892b7ae5
Merge pull request #6793 from openfoodfoundation/dependabot/bundler/rubocop-1.9.1
...
Bump rubocop from 1.9.0 to 1.9.1
2021-02-02 15:49:48 +01:00
Pau Pérez Fabregat
9bb2970a07
Merge pull request #6782 from jibees/6766-manage-hover-on-account-tabs
...
User profile tabs: specify :hover rule only for devices that can effectively handle it
2021-02-02 15:47:03 +01:00
Pau Perez
a19aceae8c
Replace spree_put with put in controller tests
...
This removes the following annoying deprecation warnings that happen in
each test.
```
DEPRECATION WARNING: You are trying to generate the URL for a named route called :main_app but no such route was found. In the future, this will result in an `ActionController::UrlGenerationError` exception. (called from process_action_with_route at /usr/s
rc/app/spec/support/controller_requests_helper.rb:49)
DEPRECATION WARNING: Passing the `use_route` option in functional tests are deprecated. Support for this option in the `process` method (and the related `get`, `head`, `post`, `patch`, `put` and `delete` helpers) will be removed in the next version without
replacement. Functional tests are essentially unit tests for controllers and they should not require knowledge to how the application's routes are configured. Instead, you should explicitly pass the appropiate params to the `process` method. Previously th
e engines guide also contained an incorrect example that recommended using this option to test an engine's controllers within the dummy application. That recommendation was incorrect and has since been corrected. Instead, you should override the `@routes`
variable in the test case with `Foo::Engine.routes`. See the updated engines guide for details. (called from process_action_with_route at /usr/src/app/spec/support/controller_requests_helper.rb:49)
```
2021-02-02 15:39:24 +01:00
Pau Perez
aef0d28dd1
Do not load unmodified VOs from DB
...
Closes #6727 .
This avoids the authorization of all the VOs of the hub, which will go
through VOs that may have become invalid due to their underlying product
not belonging to the supplier the hub has permissions with (or any other
data integrity issue).
This is utterly confusing for the user who is only given a generic error
and doesn't understand what's wrong with the particular VO they changed,
while it may be fine after all. What's more, this often results in
a customer support request, which then may end up with a dev finding out
which VO is broken.
Also, there's no point in loading them from DB if the users didn't touch
them.
2021-02-02 15:39:23 +01:00
Pau Pérez Fabregat
d48aa4a73f
Merge pull request #6748 from coopdevs/dont-fetch-vos-with-deleted-variant
...
Do not fetch VOs with deleted variant
2021-02-02 15:38:29 +01:00
Matt-Yorkley
d7b130d293
Update all locales with the latest Transifex translations
2021-02-02 12:23:25 +00:00
Matt-Yorkley
617d914835
Merge pull request #6788 from jibees/6783-align-new-product-form
...
Use full width for "new product" form
2021-02-02 13:11:12 +01:00
Matt-Yorkley
b1349306f9
Merge pull request #6787 from jibees/6784-align-items-on-shipping-and-payment-methods-forms
...
Align items on shipping and payment methods forms
2021-02-02 13:08:28 +01:00
Pau Perez
cdcda46bff
Re-enable mail_bcc field in mail method settings
...
This feels safer because we don't risk messing up with any instance's
operations while still moving us towards removing this page.
2021-02-02 12:16:55 +01:00
Jean-Baptiste Bellet
a82b24d4c1
specify width and height
...
Was too small, almost invisible.
2021-02-02 11:19:20 +01:00
Transifex-Openfoodnetwork
596e8a6828
Updating translations for config/locales/ru.yml
2021-02-02 20:48:36 +11:00
dependabot[bot]
1613c2e6fb
Bump rubocop from 1.9.0 to 1.9.1
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.9.0...v1.9.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-02 05:34:32 +00:00
Andy Brett
850dfd776a
migrate variants with nil unit_value
2021-02-01 21:27:32 -08:00
Pau Pérez Fabregat
9db9d2d138
Merge pull request #6786 from jibees/6781-align-packages-selection-on-registration
...
Package selection: use "columns" system to display 3 items on same line
2021-02-01 21:06:00 +01:00
Pau Pérez Fabregat
bcbd1ce8bc
Merge pull request #6790 from openfoodfoundation/transifex
...
Transifex
2021-02-01 21:05:16 +01:00
Pau Perez
20b9ac89b8
Fix missing translation
...
The used key doesn't exist.
2021-02-01 18:45:02 +01:00
Pau Perez
063d44fecc
Disable mail methods form fields except mails_from
...
This moves a step closer to having a simple and straightforward way to
configure the app's mail delivery which doesn't require to be a nuclear
engineer to troubleshoot mail issues.
It happens way too often that servers have mail config broken when
restarted or redeployed and it takes too much brain power to fix it. No
doubt; it's way too complex.
I chose to leave this page's form fields but "Send mails as" as
read-only. This other field is still used by instance manager to
troubleshoot mail issues.
2021-02-01 18:45:02 +01:00
Jean-Baptiste Bellet
370a108b3d
Add stripe account owner selector as a new row
...
Otherwise, not displayed.
2021-02-01 18:00:28 +01:00
Transifex-Openfoodnetwork
38dde5e063
Updating translations for config/locales/es.yml
2021-02-02 03:04:56 +11:00
Transifex-Openfoodnetwork
fe79186bec
Updating translations for config/locales/ca.yml
2021-02-02 03:03:33 +11:00
Pau Pérez Fabregat
d5413224b7
Merge pull request #6769 from openfoodfoundation/transifex
...
Transifex
2021-02-01 16:57:45 +01:00
Pau Pérez Fabregat
90466e19dc
Merge pull request #6776 from Matt-Yorkley/dead-argument
...
Dead code: superfluous argument in CartService#populate
2021-02-01 16:49:02 +01:00
Pau Perez
0ee1e2cd72
Eager load taggings related to variant overrides
...
This removes an N+1 with taggings but doesn't solve the one with tags.
Using `includes(taggings: :base_tags)` based on
47da5036de/lib/acts_as_taggable_on/taggable.rb (L83-L84)
wasn't enough to solve it and I got to stop here. This is scope-creeping
too much.
2021-02-01 16:38:40 +01:00
Pau Perez
ee4f2a7b02
Remove N+1 on variants and products
...
We get from an initial INNER JOIN with variants and products to fetch
the variant overrides + N queries like:
```sql
SELECT "spree_variants".* FROM "spree_variants" WHERE
"spree_variants"."deleted_at" IS NULL AND "spree_variants"."id" = $1
LIMIT 1 [["id", 1545]]
SELECT "spree_products".* FROM "spree_products" WHERE
"spree_products"."id" = $1 LIMIT 1 [["id", 604]]
```
to the same initial INNER JOIN + just 2 queries like:
```sql
SELECT "spree_variants".* FROM "spree_variants" WHERE
"spree_variants"."deleted_at" IS NULL AND "spree_variants"."id" IN
(1551, 1554)
SELECT "spree_products".* FROM "spree_products" WHERE
"spree_products"."deleted_at" IS NULL AND "spree_products"."id" IN (606,
607)
```
2021-02-01 16:38:40 +01:00
Pau Perez
6584f510e8
Remove now dead code
2021-02-01 16:38:40 +01:00
Jean-Baptiste Bellet
acbe0faa1e
use full width for new product form
...
- use the sixteen full width: eight + eight or eight + four + four, ...
2021-02-01 16:35:55 +01:00
Pau Pérez Fabregat
1420c43a0a
Merge pull request #6778 from openfoodfoundation/dependabot/bundler/database_cleaner-1.99.0
...
Bump database_cleaner from 1.8.5 to 1.99.0
2021-02-01 16:06:51 +01:00
Jean-Baptiste Bellet
adf67475be
special aligment for stripe form
2021-02-01 15:39:51 +01:00
Jean-Baptiste Bellet
c44ce85f30
alignment for specific provider settings form in payment method
2021-02-01 15:31:39 +01:00
Jean-Baptiste Bellet
46e6bc6179
align payment method form
...
- enlarge the form to be "full size" (four + twelve = 16 columns)
2021-02-01 15:18:45 +01:00
Jean-Baptiste Bellet
e57acd3163
align shipping method form (editing)
...
- use `row` and no more `field` to be consistent
- enlarge the form to be "full size" (four + twelve = 16 columns)
- enlarge "hubs sidebar"
2021-02-01 15:11:47 +01:00
Pau Pérez Fabregat
0878db70fe
Merge pull request #6780 from openfoodfoundation/dependabot/bundler/webmock-3.11.2
...
Bump webmock from 3.11.1 to 3.11.2
2021-02-01 14:57:45 +01:00
Pau Pérez Fabregat
640681d664
Merge pull request #6719 from coopdevs/stop-using-spree-req-helpers-in-users-controller-spec
...
[Rails 5] Stop using deprecated req. helpers in users specs
2021-02-01 14:56:28 +01:00
Pau Perez
060530cda8
Do not fetch VOs with deleted variant
...
In the line below we filter them out in Ruby so it's a waste of
resources. The fundamental difference is that `#includes` and
`#references` results in LEFT JOINs, whereas `#joins` results in INNER
JOIN, and because there's a default scope on `deleted_at IS NULL`, these
are not included in the result set.
This however, requires us to move away from the current algorithm but
unfortunately we can't refactor it completely yet.
Before:
```sql
SELECT *
FROM "variant_overrides"
LEFT OUTER
JOIN "spree_variants"
ON "spree_variants"."id" = "variant_overrides"."variant_id"
AND "spree_variants"."deleted_at" IS NULL
LEFT OUTER
JOIN "spree_products"
ON "spree_products"."id" = "spree_variants"."product_id"
AND "spree_products"."deleted_at" IS NULL
WHERE "variant_overrides"."permission_revoked_at" IS NULL
AND "variant_overrides"."hub_id" IN (
SELECT "enterprises"."id"
FROM "enterprises"
INNER
JOIN "enterprise_roles"
ON "enterprise_roles"."enterprise_id" = "enterprises"."id"
WHERE (enterprise_roles.user_id = ?)
AND (sells != 'none')
ORDER BY name)
```
After:
```sql
SELECT "variant_overrides".*
FROM "variant_overrides"
INNER
JOIN "spree_variants"
ON "spree_variants"."id" = "variant_overrides"."variant_id"
AND "spree_variants"."deleted_at" IS NULL
INNER
JOIN "spree_products"
ON "spree_products"."id" = "spree_variants"."product_id"
AND "spree_products"."deleted_at" IS NULL
WHERE "variant_overrides"."permission_revoked_at" IS NULL
AND "variant_overrides"."hub_id" IN (
SELECT "enterprises"."id"
FROM "enterprises"
INNER
JOIN "enterprise_roles"
ON "enterprise_roles"."enterprise_id" = "enterprises"."id"
WHERE (enterprise_roles.user_id = ?)
AND (sells != 'none')
ORDER BY name)
```
This is covered in the test suite by
spec/controllers/admin/variant_overrides_controller_spec.rb:72. It keeps
passing so we're good to go.
2021-02-01 14:47:51 +01:00
Jean-Baptiste Bellet
b7e23a7401
user "columns" system to display 3 items on same line
2021-02-01 14:15:50 +01:00
Jean-Baptiste Bellet
fcd304182b
specify :hover rule only for devices that can handle it
...
Since mobile device cannot handle :hover rule (hover is non sense for touch devices), specify css for only devices that effectivly handle it.
see https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/
and https://caniuse.com/mdn-css_at-rules_media_hover for compatibility (quite good)
2021-02-01 10:53:34 +01:00
dependabot[bot]
863a7ec688
Bump webmock from 3.11.1 to 3.11.2
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.1...v3.11.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:29:04 +00:00
dependabot[bot]
6f4b18a7d5
Bump test-unit from 3.3.9 to 3.4.0
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.3.9 to 3.4.0.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.3.9...3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:23:46 +00:00
dependabot[bot]
e9c789a459
Bump database_cleaner from 1.8.5 to 1.99.0
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 1.8.5 to 1.99.0.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases )
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/master/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v1.8.5...v1.99.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:20:51 +00:00
Matt-Yorkley
3da21ce2bd
Add historical note to CartService
...
Useful background when applying upstream fixes from Spree::OrderPopulator, and means grepping for OrderPopulator doesn't come up empty.
2021-01-30 16:57:05 +00:00
Matt-Yorkley
d39468013e
Clarify CartService#populate arguments
...
This method doesn't use :products anywhere, it doesn't need to be passed in as part of the argument.
2021-01-30 16:52:59 +00:00
Matt-Yorkley
2de54e5ae2
Fix updated_at issue in RemoveTransientData spec
...
The value in the test setup was not what was expected after the updates to touching the updated_at columns.
2021-01-30 13:10:38 +00:00
Matt-Yorkley
0e82160b76
Touch the updated_at column when updating records via #update_column
...
#update_column(s) skips callbacks (which is useful), but it doesn't change the updated_at field on the record by default (which we should be doing in these cases).
This change is made in Spree 2.2 here: b367c629ce
2021-01-30 12:49:38 +00:00
Andy Brett
c28b65f772
update subs jobs delivery methods
2021-01-29 21:08:41 -08:00
Andy Brett
e694449dcc
move subs jobs out of spree namespace
2021-01-29 21:08:41 -08:00
Andy Brett
3da0c2e386
send authorization emails when running the subscriptionconfirmjob
2021-01-29 21:08:41 -08:00
Andy Brett
87bce505ec
Merge pull request #6765 from openfoodfoundation/dependabot/bundler/rack-mini-profiler-2.3.1
...
Bump rack-mini-profiler from 2.3.0 to 2.3.1
2021-01-29 20:04:13 -08:00
Andy Brett
fb5668afa6
Merge pull request #6764 from openfoodfoundation/dependabot/bundler/rubocop-1.9.0
...
Bump rubocop from 1.8.1 to 1.9.0
2021-01-29 20:03:56 -08:00
Matt-Yorkley
8466ab5675
Extract more OFN fee-handling code from Spree::Order class
2021-01-29 22:51:21 +00:00
Matt-Yorkley
793baca44f
Update fees on single line item and then order fees in LineItemsController#delete
...
Fees on other line items are left alone (not recreated), and whatever fees on the order are updated.
2021-01-29 21:53:11 +00:00
Matt-Yorkley
ce5f9a9a94
Update existing closed order fees when deleting line items on completed orders in LineItemsController#delete
...
Whatever fee adjustments there are on other line items should be left alone (not recreated), and whatever fee adjustments are already on the order should just be updated.
2021-01-29 21:53:11 +00:00
Matt-Yorkley
58c7c90624
Refactor methods for updating closed adjustments
2021-01-29 21:53:11 +00:00
Matt-Yorkley
b2b6d3ab87
Relocate specs for #provided_by_order_cycle? method extracted from Order class to service
2021-01-29 21:53:11 +00:00
Matt-Yorkley
dffa4d4f39
Update order methods delegation
2021-01-29 21:53:09 +00:00
Matt-Yorkley
3ecdfca9cf
Rename fee adjustment clear-all method
2021-01-29 21:52:28 +00:00
Matt-Yorkley
9abf6cdcdf
Rename expensive method Order#update_distribution_charge!
...
This method is named "update distribution charge". What this method actually does is delete all of the fee adjustments on an order and all it's line items, then recreate them all from scratch. We call this from lots of different places all the time, and it's incredibly expensive. It even gets called from inside of transactions being run inside callbacks. Renaming it hopefully will add a bit of clarity.
This needs to be a lot more granular!
2021-01-29 21:52:28 +00:00
Matt-Yorkley
785cdf9bdc
Extract order fees logic to service
2021-01-29 21:52:27 +00:00
Matt-Yorkley
fc06e5e4c3
Remove dead code Spree::Order#clear_adjustments
2021-01-29 19:58:05 +00:00
Transifex-Openfoodnetwork
8f163cf5b5
Updating translations for config/locales/en_CA.yml
2021-01-30 06:08:22 +11:00
Matt-Yorkley
e7866db7b1
Improve efficiency in applying enterprise fees in Order#update_distribution_charge!
2021-01-29 18:32:26 +00:00
Matt-Yorkley
b97734d918
Merge pull request #6720 from cillian/cancel-email-for-shop
...
When an order is cancelled by a customer send an email to the shop.
2021-01-29 18:30:28 +01:00
Cillian O'Ruanaidh
0cfd7de8a8
Fix the link to the order in the order cancelled email.
2021-01-29 14:14:11 +00:00
Matt-Yorkley
d03be3b8dc
Update all locales with the latest Transifex translations
2021-01-29 11:42:09 +00:00
Matt-Yorkley
e4d7e03903
Merge pull request #6740 from Matt-Yorkley/carts-cleanup
...
Remove old abandoned carts
2021-01-29 12:32:16 +01:00
Cillian O'Ruanaidh
c8198ff67c
Merge branch 'master' into include-ready-for-in-producer-notification
2021-01-29 11:30:11 +00:00
Cillian O'Ruanaidh
899dffec96
When an order is cancelled by a customer send an email to the shop.
...
Fixes #6435 i.e. If the customer paid for their order by Stripe/Paypal then the Enterprise needs to know that the order was cancelled in order to arrange a refund. Refunds are not automatically processed when an order is cancelled.
This will send a very basic email to the shop, it only includes a link to view the cancelled order in the admin area initially.
I created a CustomerOrderCancellation object here because orders can be cancelled in two ways (1) by the customer, so an email should be sent to the shop. (2) by the shop, so an email doesn't need to be sent. However the code for cancelling order happens in Order#cancel via the state machine. Rather than passing some sort of parameter into #cancel to indicate whether it is a customer or shop cancelled order it might be clearer to have a CustomerOrderCancellation object, there could be other differences between customer or shop cancelled orders in future maybe.
2021-01-29 11:23:05 +00:00
Pau Pérez Fabregat
818dfc0399
Merge pull request #6751 from jibees/4971-profile-tabs-back-forward-buttons
...
Make user's profile tabs aware of location change event
2021-01-29 10:01:58 +01:00
dependabot[bot]
32761baa68
Bump rack-mini-profiler from 2.3.0 to 2.3.1
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.3.0...v2.3.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-29 05:38:38 +00:00
dependabot[bot]
36380414a4
Bump rubocop from 1.8.1 to 1.9.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.8.1...v1.9.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-29 05:35:09 +00:00
Matt-Yorkley
4ec68dcd85
Update migration to include TaxRate model
2021-01-29 02:37:35 +00:00
Matt-Yorkley
9791287712
Run data cleanup job at 4:30am
2021-01-28 21:51:50 +00:00
Matt-Yorkley
4f7c8062a1
Create class to map join table and simplify code
2021-01-28 21:51:50 +00:00
Matt-Yorkley
d502320b14
Enable cascading deletes
2021-01-28 21:51:47 +00:00
Andy Brett
6fea2dbe46
Merge pull request #6760 from openfoodfoundation/dependabot/bundler/rswag-2.3.2
...
Bump rswag from 2.3.1 to 2.3.2
2021-01-28 13:11:33 -08:00
Pau Pérez Fabregat
45573dc522
Merge pull request #6753 from jibees/6746-epic-fullwdith-admin-layout-quick-wins
...
FullWidth admin layout quick wins
2021-01-28 21:10:06 +01:00
Pau Pérez Fabregat
0a1d4873e3
Merge pull request #6736 from jibees/6707-remove-anchor-jump
...
Remove anchor in URL so avoid browser scrolling to the top of the page when editing order
2021-01-28 21:09:08 +01:00
Pau Pérez Fabregat
abe2cb9fac
Merge pull request #6728 from emclaughlin1215/add_tax_rates_i18n_key
...
Adding a tax_rates key to en.yml to match the key used everywhere.
2021-01-28 21:04:22 +01:00
Matt-Yorkley
dcbe9c4011
Merge pull request #6756 from andrewpbrett/fix-sca-regression
...
Fix SCA regression
2021-01-28 19:45:08 +01:00
Pau Pérez Fabregat
d4f6f903c9
Merge pull request #6759 from openfoodfoundation/dependabot/bundler/ddtrace-0.45.0
...
Bump ddtrace from 0.44.0 to 0.45.0
2021-01-28 16:40:29 +01:00
Pau Pérez Fabregat
6cc19ac6d5
Merge pull request #6726 from filipefurtad0/shipping_methods_spec_pending_fix
...
Fixes a pending test case and improves the spec run time
2021-01-28 16:39:39 +01:00
Pau Pérez Fabregat
2668747237
Merge pull request #6723 from luisramos0/spree_routes_2
...
Move spree orders routes out of the spree engine routes into the main app routes
2021-01-28 16:31:49 +01:00
Matt-Yorkley
57f429db58
Merge pull request #6606 from mkllnk/6081-add-to-cart
...
Add quantity input to shop front
2021-01-28 15:51:08 +01:00
Matt-Yorkley
de530c2a46
Merge pull request #6750 from mkllnk/6749-i18n-in-assets
...
Use JS I18n function in assets to avoid parsing error
2021-01-28 15:50:22 +01:00
Jean-Baptiste Bellet
553053bad1
use find instead of click_link because <a> element no longer has href attribute
...
- click_link only looks for <a> element with href attribute
- Use a regexp for a case-insensitive search (as CSS use a uppercase transform)
2021-01-28 09:45:24 +01:00
dependabot[bot]
55cddbbc1a
Bump rswag from 2.3.1 to 2.3.2
...
Bumps [rswag](https://github.com/rswag/rswag ) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.3.1...2.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-28 05:46:19 +00:00
dependabot[bot]
0a128d83d0
Bump ddtrace from 0.44.0 to 0.45.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.44.0...v0.45.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-28 05:41:53 +00:00
Matt-Yorkley
c65f623ed8
Memoize and simplify objects being checked in Order#provided_by_order_cycle?
2021-01-28 01:02:57 +00:00
Luis Ramos
7cea4138c2
Fix spec setup
2021-01-27 22:44:52 +00:00
Matt-Yorkley
85c489d303
Ignore carts with failed payments in cleanup
2021-01-27 22:40:23 +00:00
Matt-Yorkley
e6c59fbd96
Update data retention periods
...
Sessions and cart data are removed if older than 3 months, instead of 6.
2021-01-27 22:40:23 +00:00
Matt-Yorkley
3fddaba4bf
Extract private methods
2021-01-27 22:40:23 +00:00
Matt-Yorkley
0a88712926
Clear orphaned records in join table spree_option_value_line_items
2021-01-27 22:40:23 +00:00
Matt-Yorkley
4230d46a06
Remove carts older than 6 months
2021-01-27 22:40:23 +00:00
Maikel
8a757812e7
Merge pull request #6735 from coopdevs/enable-mail-delivery-always
...
Enable mail delivery always
2021-01-28 09:31:12 +11:00
Matt-Yorkley
f49355e5d3
Merge pull request #6724 from Matt-Yorkley/remove-price-adjustments
...
Delete dead code Spree::Order#price_adjustments
2021-01-27 23:29:38 +01:00
Luis Ramos
12dac82b8a
Delete dead route
2021-01-27 22:08:06 +00:00
Luis Ramos
c604f4c0c6
Remove dead endpoint
2021-01-27 22:05:04 +00:00
Jean-Baptiste Bellet
bb21543ae0
remove useless brackets
2021-01-27 21:35:55 +01:00
Pau Pérez Fabregat
c3897dd3df
Merge pull request #6643 from coopdevs/customer-balance-frontoffice
...
Customer balance frontoffice
2021-01-27 19:55:56 +01:00
Andy Brett
e6e20309aa
Revert "don't try to process a payment if it's pending auth"
...
This reverts commit bba9e55006 .
2021-01-27 08:06:20 -08:00
Jean-Baptiste Bellet
9b1c0e6806
avoid inserting div in the columns grid system
...
it break the css selectors (as :first-child, ...)
fixe: #6747
2021-01-27 15:05:48 +01:00
Jean-Baptiste Bellet
c5edd74d05
remove useless wrapper and align items (both right and left)
...
Fixe: #6747
2021-01-27 15:04:45 +01:00
Jean-Baptiste Bellet
a6fba8a065
Put content into grid columns system
...
Two columns of three + a ten column rather than empty column + content outside column system
correct #6745
2021-01-27 14:40:50 +01:00
Matt-Yorkley
7525620d6c
Merge pull request #6070 from Matt-Yorkley/responsive-admin
...
Full-width admin layout
2021-01-27 12:45:06 +01:00
Matt-Yorkley
feca9e7838
Improve hubs sidebar in payment methods edit
2021-01-27 11:38:01 +00:00
Matt-Yorkley
398b4a09a1
Improve enterprise fees calculator fields
2021-01-27 11:38:01 +00:00
Matt-Yorkley
366588de95
Improve <legend> element centering
2021-01-27 11:38:01 +00:00
Matt-Yorkley
b5ab6cbf69
Improve button spacing in enterprises submenu
2021-01-27 11:38:01 +00:00
Matt-Yorkley
e762c1d02f
Adjust buttons layout on enterprise shipping and payment methods page
2021-01-27 11:38:01 +00:00
Matt-Yorkley
f72cd6222f
Adjust variant columns in inventory pages
2021-01-27 11:38:01 +00:00
Matt-Yorkley
79316560d6
Remove skeleton.css from /vendor/assets
...
This was recently imported from spree_core
2021-01-27 11:38:01 +00:00
Matt-Yorkley
539ff228e0
Adjust form layout on order cycle edit form (simple view)
2021-01-27 11:38:01 +00:00
Matt-Yorkley
afdb5e8c6f
Add a max-width of 1400px for huge monitors (1600px or more)
2021-01-27 11:38:01 +00:00
Matt-Yorkley
d40ec2d63c
Adjust order cycle edit form layout
2021-01-27 11:38:01 +00:00
Matt-Yorkley
0d99656b1b
Adjust dashboard layout
2021-01-27 11:38:01 +00:00
Matt-Yorkley
52cfa0a103
Remove old Javascript hacks for the main menu and replace with flex-based CSS properties
2021-01-27 11:38:01 +00:00
Matt-Yorkley
d886b1dcea
Tweak some styles and layout classes
2021-01-27 11:38:01 +00:00
Matt-Yorkley
29e74017a6
Replace fixed 960 grid
2021-01-27 11:38:01 +00:00
Pau Pérez Fabregat
9fe2cb1a30
Merge pull request #6681 from luisramos0/css
...
[Rails 5] Make the app work in rails 5
2021-01-27 12:08:27 +01:00
Jean-Baptiste Bellet
0242e1a0c9
avoid unnecessary javascript:void(0)
2021-01-27 10:26:05 +01:00
Jean-Baptiste Bellet
48c667d2dd
add onLocationChangeSuccess event handler
...
watch this event and toggle class if needed.
2021-01-27 10:25:05 +01:00
Maikel Linke
06983c4dc7
Use JS I18n function in asset, avoid parsing error
...
A deployment to the French server failed because a translation contained
an apostrophe `'` and we were rendering it without escaping in
Javascript. We don't have that problem and avoid other issues by using
the javascript translate function. That way the error message is
translated in the browser with the user's language and we don't have to
do any additional escaping.
2021-01-27 14:12:25 +11:00
Maikel Linke
0393e902c4
Update translations from Transifex
2021-01-27 08:28:37 +11:00
Luis Ramos
ab135e30c0
Fix order_path in stripe connect spec
2021-01-25 20:25:13 +00:00
Luis Ramos
11fdbe5e9f
Switch spree from namespace to scope in routes so helpers like order_path keep working
2021-01-25 20:01:08 +00:00
Luis Ramos
34ae3ca24d
Replace spree_order_url with order_url so we can use scope in the routes file
2021-01-25 19:56:25 +00:00
Luis Ramos
f3da7afd55
Replace spree_order_path with order_path so we can use scope in the routes file
2021-01-25 19:55:42 +00:00
Luis Ramos
dbef7b60a6
Adapt spec to new orders url
2021-01-25 19:52:48 +00:00
Luis Ramos
21f48b52c8
Fix cancel order route
2021-01-25 19:52:48 +00:00
Luis Ramos
592474189d
Fix order route in paypal controller
2021-01-25 19:52:48 +00:00
Luis Ramos
d52661fe0a
Fix admin order form to use admin orders route
2021-01-25 19:52:48 +00:00
Luis Ramos
00fcb89af1
Fix order_url routes in a few places
2021-01-25 19:52:48 +00:00
Luis Ramos
dd4ca8a8e6
Fix order path in subs emailer view
2021-01-25 19:52:48 +00:00
Luis Ramos
f25e06ddb6
Fix order path route in payments controller
2021-01-25 19:52:48 +00:00
Luis Ramos
3813b80615
Adapt order path route in order details view
2021-01-25 19:52:48 +00:00
Luis Ramos
88c21ef82e
Fix order path
2021-01-25 19:52:48 +00:00
Luis Ramos
60c3557c2d
Fix checkout form order path
2021-01-25 19:52:48 +00:00
Luis Ramos
6e7ee02191
Change spree.order_path to spree_order_path everywhere
2021-01-25 19:52:48 +00:00
Luis Ramos
e98d97ae0d
Move spree orders routes out of the spree engine routes into the main app routes, still inside the spree namespace
2021-01-25 19:52:48 +00:00
Pau Pérez Fabregat
10a60b1f72
Merge pull request #6729 from openfoodfoundation/dependabot/bundler/shoulda-matchers-4.5.1
...
Bump shoulda-matchers from 4.5.0 to 4.5.1
2021-01-25 16:34:13 +01:00
Jean-Baptiste Bellet
686dcaaa1b
remove '#' as path for link_to
...
Adding '#' to the current url makes most of browser jump to the top of the page. Avoid this by deleting this added # (meaningless) and replacing it by empty string.
2021-01-25 16:09:12 +01:00
Pau Perez
5677c86f9b
Remove enable_mail_delivery preference from DB
...
It's no longer used.
2021-01-25 13:34:13 +01:00
Pau Perez
4a5869b60c
Remove ability to toggle mail delivery
...
OFN requires mails to work so there's no point in having this
conditional with the maintenance cost it entails.
2021-01-25 13:27:44 +01:00
Pau Pérez Fabregat
efd2c81877
Merge pull request #6722 from luisramos0/spree_routes
...
Replace spree_get with simple get
2021-01-25 09:12:51 +01:00
dependabot[bot]
70bd81430d
Bump shoulda-matchers from 4.5.0 to 4.5.1
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.5.0...v4.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-25 06:13:04 +00:00
filipefurtad0
c5c9e803ab
Fixes a pending test case and improves the spec run time
2021-01-24 13:32:04 +00:00
Erin McLaughlin
609db647bb
Adding a tax_rates key to en.yml to match the key used everywhere.
2021-01-23 22:07:07 -05:00
Matt-Yorkley
ff54426e30
Expand tests on additional and inclusive taxes.
2021-01-23 03:59:32 +00:00
Matt-Yorkley
7940a42e8c
Add Spree::Order#all_adjustments scope, which can be used to get all adjustments on an order, and order's line_items, etc, not just adjustments directly on the order itself.
2021-01-23 03:59:32 +00:00
Matt-Yorkley
4d4c055577
Loosen Spree::Adjustment#tax scope to include any tax adjustments
2021-01-23 03:59:32 +00:00
Matt-Yorkley
ddfcda0c0b
Adapt imported Paypal code
...
The #additional scope from Spree 2.2 is now present, so we can tidy up this conditional.
2021-01-23 03:59:32 +00:00
Matt-Yorkley
173e502c98
Rename #included scope to #inclusive
...
This method name (#included) is reserved and used internally by ActiveRecord. After updating Ruby, this has changed from a silent warning to a fatal error.
2021-01-23 03:59:32 +00:00
Matt-Yorkley
a328a9bc1b
Use included boolean in tax adjustments
2021-01-23 03:59:32 +00:00
Matt-Yorkley
8be18cd05c
Add #included and #additional scopes to Spree::Adjustment
...
We can now do things like:
```
included_tax = order.adjustments.tax.included.sum(:amount)
additional_tax = order.adjustments.tax.additional.sum(:amount)
```
2021-01-23 03:59:32 +00:00
Matt-Yorkley
66bf69b52c
Add included column to spree_adjustments table
2021-01-23 03:59:31 +00:00
Matt-Yorkley
0247386f82
Delete dead code Spree::Order#price_adjustments
...
This method returns the same thing as the Spree::Order#line_items_adjustments scope, but in a slightly less useful format (an array instead of a relation). The method's name is also totally inaccurate, as currently the only adjustments that appear on line items are tax adjustments for inclusive tax rates, which by definition have no effect on the price whatsoever...
2021-01-23 00:05:56 +00:00
Luis Ramos
1643636d43
Replace spree_get with simple call to get
2021-01-22 22:32:48 +00:00
Luis Ramos
d6a53cb84f
Replace spree_get with simple call to get
2021-01-22 22:30:11 +00:00
Luis Ramos
94275eedfb
Replace spree_get with simple call to get
2021-01-22 22:28:53 +00:00
Luis Ramos
59e900826e
Replace spree_get with get
...
Spree helper method is not needed
2021-01-22 22:22:50 +00:00
Luis Ramos
be9ee376a3
Use get instead of spree_get
...
spree_get is not needed in these cases
2021-01-22 22:20:52 +00:00
Cillian O'Ruanaidh
9c6e97f90d
Merge branch 'master' into include-ready-for-in-producer-notification
2021-01-22 11:45:01 +00:00
Cillian O'Ruanaidh
70a557cea3
Display the pickup time for each distributor, not the coordinator, in the Notify Producers email
2021-01-22 11:39:46 +00:00
Pau Perez
cc2e46890e
Stop using deprecated req. helpers in users specs
...
This removes the following two deprecation warnings that we are getting
by millions (the two for each controller action test):
```
DEPRECATION WARNING: You are trying to generate the URL for a named route called "main_app" but no such route was found. In the future, this will result in an `ActionController::UrlGenerationError` exception. (called from process_action_with_route at /usr/
src/app/spec/support/controller_requests_helper.rb:49)
DEPRECATION WARNING: Passing the `use_route` option in functional tests are deprecated. Support for this option in the `process` method (and the related `get`, `head`, `post`, `patch`, `put` and `delete` helpers) will be removed in the next version without
replacement. Functional tests are essentially unit tests for controllers and they should not require knowledge to how the application's routes are configured. Instead, you should explicitly pass the appropiate params to the `process` method. Previously th
e engines guide also contained an incorrect example that recommended using this option to test an engine's controllers within the dummy application. That recommendation was incorrect and has since been corrected. Instead, you should override the `@routes`
variable in the test case with `Foo::Engine.routes`. See the updated engines guide for details. (called from process_action_with_route at /usr/src/app/spec/support/controller_requests_helper.rb:49)
```
It slows down our test suite and clutters the output a lot. As per my
investigation, this is something that arose in
https://github.com/rails/rails/pull/17453 and addressed in
https://github.com/rails/rails/pull/17725 . TL;DR: Engines need to define
their routes in controller tests as shown in
https://github.com/discourse/discourse/pull/3011 .
This, however, revealed a much complex reality in our case. We're still
using a `Spree::Core::Engine` with its own routes at
`Spree::Core::Engine.routes`. So we can't skip defining `routes { }` for
each of its controllers unless we merge this engine into our app, but
that's going to require more effort. What could that entail in
https://github.com/openfoodfoundation/openfoodnetwork/compare/master...coopdevs:move-users-to-app-routes .
To make it even worse, note that we override spree's core routes from
our own, resulting in a controller whose actions are being served from
routes defined in either `config/routes.rb` or `config/spree/routes.rb`
🙈 .
2021-01-22 11:42:17 +01:00
Maikel Linke
46d23f1f8a
Fit bulk buy modal on small mobile screens
...
On some Iphones the modal wouldn't fit and there were line breaks
between the input fields. The inputs are now stacked vertically on small
screens so that there is still plenty of space for large numbers in the
quantity fields.
2021-01-22 16:44:52 +11:00
Maikel Linke
4ab48c4b85
Initialise valid quantities when choosing OCs
...
Line items were initialised with undefined quantities which makes it
impossible to distinguish between the initial unset quantity and a user
entering an invalid quantity. When a user changed order cycles, all
quantities are reset and the UI displayed the quantity modifier buttons
instead of the Add button.
Initialising with the valid quantity 0 helps us to display the Add
button in that situation.
2021-01-22 16:42:21 +11:00
Maikel Linke
bd731267ec
Allow user to get maximum available quantity
...
When the user entered a number beyond the stock level, the browser was
correcting that to the max number which is very helpful. But Angular was
setting the model to undefined which removes the item from the cart.
Deactivating Angular's max behaviour let's us set the value ourselves
which is then used in the cart.
2021-01-22 16:42:21 +11:00
Maikel Linke
35b4e8c4d1
Allow editing of invalid quantities
...
If the user entered an invalid quantity, Angular set the model to
undefined and we removed the input field to show the add button. That
makes it impossible for a user to see what the maximum quantity to enter
would be. For example:
- The variant has a stock level of 5.
- The user enters 7.
- Angular sets it to undefined.
- The input field disappears.
- The user is startled and doesn't know how to proceed.
But now we hide the input only if it's deliberately set to zero.
2021-01-22 16:42:21 +11:00
Maikel Linke
0166400b03
Guard against invalid quantity input
...
The user can now type anything into the quantity field and some of it
may not be valid. These safe guards ensure that the buttons still work
even if the quantity is undefined or out of range.
Angular guards against the value being out of range but that has other
side-effects. We want to be able to de-activate some of Angular's
behaviour.
2021-01-22 16:42:20 +11:00
Maikel Linke
cf2a105b2a
Prevent line breaks within plus/minus buttons
2021-01-22 16:42:20 +11:00
Maikel Linke
688be46b10
Avoid horizontal scroll bar on small screens
2021-01-22 16:42:20 +11:00
Maikel Linke
3558d01fce
Give the new input fields more space
...
The additional input needs more space and we are adjusting columns here.
2021-01-22 16:42:20 +11:00
Maikel Linke
66423a1ec3
Add quantity input to shop front product list
...
Adding bigger quantities can now be done via an input field instead of
clicking a thousand times.
The add-button has been widened to match the new space requirements.
2021-01-22 16:42:20 +11:00
Maikel Linke
e5506df5ea
Replace bulk quantity label with input field
...
Enable the user to enter a number directly.
2021-01-22 16:42:20 +11:00
Maikel Linke
af918e63ee
Change bulk quantities on any quantity change
...
This prepares for changing the quantity with an input field. It also
applies if the quantity is changed after an ajax request.
2021-01-22 16:42:20 +11:00
Maikel Linke
7add9247d5
Update translations from Transifex
2021-01-22 11:58:27 +11:00
Maikel
d5376ce29d
Merge pull request #6702 from openfoodfoundation/transifex
...
Transifex
2021-01-22 11:54:57 +11:00
Andy Brett
84689c43be
Merge pull request #6534 from andrewpbrett/sca-emails
...
Send email when SCA authorization is required for admin payment
2021-01-21 13:53:35 -08:00
Andy Brett
91d5b55376
Merge pull request #6673 from openfoodfoundation/dependabot/bundler/paypal-sdk-merchant-1.117.2
...
Bump paypal-sdk-merchant from 1.106.1 to 1.117.2
2021-01-21 11:21:27 -08:00
Andy Brett
0f92b3c4de
Merge pull request #6685 from Matt-Yorkley/angular-csrf
...
[Rails 5] Update Angular CSRF handling
2021-01-21 11:01:06 -08:00
Andy Brett
0e7f4b2f14
Merge pull request #6537 from mkllnk/simplify-mail-config
...
Simplify mail config
2021-01-21 10:59:43 -08:00
Andy Brett
d2b2e46124
Merge pull request #6701 from Matt-Yorkley/admin-order-performance
...
Fix performance issue in loading payment methods
2021-01-21 10:58:35 -08:00
Andy Brett
3ef4a74b84
Merge pull request #6655 from Matt-Yorkley/summing-amounts
...
Improve performance on summing adjustments and payment
2021-01-21 10:58:10 -08:00
Matt-Yorkley
d8b795ebee
Merge pull request #6679 from Matt-Yorkley/soft-delete-enterprise-fees
...
Soft-delete Enterprise Fees
2021-01-21 19:57:29 +01:00
Andy Brett
70f30f5224
Merge pull request #6658 from andrewpbrett/item-counter-fix
...
Further fix #5989 (Item counter accepts values higher than the available stock)
2021-01-21 10:56:18 -08:00
Andy Brett
bba9e55006
don't try to process a payment if it's pending auth
2021-01-21 09:18:29 -08:00
Andy Brett
ce4621858d
base authorization on the payment's order
2021-01-21 09:18:29 -08:00
Andy Brett
8bcaeff6c8
resolve merge conflict; add ssl helper to base controller
2021-01-21 09:18:29 -08:00
Andy Brett
1635b83c15
add missing translation key for payment actions
2021-01-21 09:18:29 -08:00
Andy Brett
903b2e7ff4
whitelist allowed events to be sent to a Payment
2021-01-21 09:18:29 -08:00
Andy Brett
ab5ffead1d
require that the redirect url be to stripe.com and over https
2021-01-21 09:18:29 -08:00
Andy Brett
affc82b2b5
update payment jobs delivery methods
2021-01-21 09:18:29 -08:00
Andy Brett
d76db9ee51
update payment controller spec to move payment to pending
2021-01-21 09:18:29 -08:00
Andy Brett
d9b27bc556
move controller and mailer outside of spree namespace; use haml in template
2021-01-21 09:18:29 -08:00
Andy Brett
5f1669280c
update to rspec 3 expect syntax
2021-01-21 09:17:07 -08:00
Andy Brett
b669ccdc74
refactor admin payments controller
2021-01-21 09:17:07 -08:00
Andy Brett
84b5fcf2ce
add resend-authorization-email button to admin screen
2021-01-21 09:17:07 -08:00
Andy Brett
5c0408c68c
pass paymentIntent ID to capture
2021-01-21 08:48:38 -08:00
Andy Brett
8507dacc10
pass return_url option to gateway authorize
2021-01-21 08:48:33 -08:00
Andy Brett
802e49bed3
add PaymentMailer and send email if payment auth is required
2021-01-21 08:24:01 -08:00
Cillian O'Ruanaidh
40f9b063fe
Remove ability to create new product from products page, use /admin/products/new instead.
...
It's simpler if there is just one place to add a new product. Closes #6650
This removes the 'creating directly from the new product path' test scenario because we have another 'assigning important attributes' scenario above which provides enough coverage.
2021-01-21 08:24:01 -08:00
Matt-Yorkley
49c616c33c
Extract tax rate transition logic to service
2021-01-21 14:50:14 +00:00
Pau Pérez Fabregat
1833ab5ffa
Merge pull request #6710 from openfoodfoundation/dependabot/bundler/webdrivers-4.5.0
...
Bump webdrivers from 4.4.2 to 4.5.0
2021-01-21 12:27:02 +01:00
Pau Pérez Fabregat
3370271ad8
Merge pull request #6705 from coopdevs/fix-request-queuing-tracking
...
Pass request_queuing setting to Rack middleware
2021-01-21 12:04:22 +01:00
dependabot[bot]
b6e7307cb9
Bump webdrivers from 4.4.2 to 4.5.0
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.4.2 to 4.5.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.4.2...v4.5.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-21 05:16:36 +00:00
Andy Brett
77419a1e4b
Merge pull request #6675 from cillian/single-new-product-view
...
Remove ability to create new product from products page, use /admin/products/new instead.
2021-01-20 19:23:33 -08:00
Andy Brett
e31d566f7f
Merge pull request #6283 from luisramos0/sets
...
Move sets out of app/models to app/services/sets
2021-01-20 19:22:15 -08:00
Andy Brett
ca37976661
Merge pull request #6640 from jibees/2772-loading-spinner-reusable-component
...
Create a reusable "loading spinner" component
2021-01-20 19:21:31 -08:00
Andy Brett
1d4fa2983c
Merge pull request #6466 from Matt-Yorkley/package-optimisation
...
Optimise Shipment#to_package
2021-01-20 19:20:56 -08:00
Andy Brett
4a19a368dd
Merge pull request #6706 from Matt-Yorkley/adjustments-migration
...
Fix issue with orphaned adjustments in migration
2021-01-20 13:23:36 -08:00
Andy Brett
dd38c8b3e2
add down method for migration
2021-01-20 12:56:03 -08:00
Pau Perez
cc9e3fe69b
Replace double negation with proper list of states
...
We rely now on the exhaustive list of states an order can be in after
checkout. What made this all a bit more messy is that I made up the
"checkout" order state, likely mixing it from the payment model states.
This simplifies things quite a bit and gives meaningful names to things.
2021-01-20 18:34:31 +01:00
Pau Perez
d9c065a311
Remove outdated comment
...
This comment was related to the feature we removed in
https://github.com/openfoodfoundation/openfoodnetwork/pull/3609 .
2021-01-20 18:23:22 +01:00
Pau Perez
996761da67
Fix long line
2021-01-20 18:23:22 +01:00
Pau Perez
9bb49bb590
Ensure the query the class depends on is called
2021-01-20 18:23:22 +01:00
Pau Perez
db23428832
Test OutstandingBalance
...
This duplicates the scenarios tested for CustomersWithBalance.
2021-01-20 18:23:22 +01:00
Pau Perez
783863056d
Extract query object out of UsersController
...
It improves the overall readability of the code and as a result, things
became easier to manage already.
2021-01-20 18:23:22 +01:00
Pau Perez
d18e79ab19
Move query object to app/queries/ and doc it
2021-01-20 18:23:22 +01:00
Pau Perez
e8ef4acb2b
Hide new data fetching implementation under toggle
2021-01-20 18:23:22 +01:00
Pau Perez
37b7340eb1
Refactor specs to speed them up
...
We don't care about the conversion from hash to JSON (that's an
ActiveModel::Serializer responsibility that is thoroughly tested) but
our logic so we can skip that step which only slows down tests.
It consistently reduced ~1.5s on my machine but it's still too slow to wait
~8.5s to get feedback from them.
2021-01-20 18:23:22 +01:00
Pau Perez
a124f93b20
Remove old commented out code
2021-01-20 18:23:22 +01:00
Pau Perez
20abaaa950
Reuse outstanding balance statement across queries
...
Instead of relying on Spree::Order#outstanding_balance we make us of the
result set `balance_value` computed column. So, we ask PostgreSQL to
compute it instead of Ruby and then serialize it from that computed
column. That's a bit faster to compute that way and let's reuse logic.
We hide this new implementation under this features' toggle so it's only
used when enabled. We want hit the old behaviour by default.
2021-01-20 18:23:22 +01:00
Pau Perez
681a009eb6
Extract outstanding balance SQL CASE/WHEN
2021-01-20 18:23:22 +01:00
Pau Perez
caf1c9ecd9
Move data fetching from injection helper to action
...
Data fetching is a controller action responsibility. We shouldn't couple
the controller with it too much but it should trigger it, not the
view-layer.
2021-01-20 18:23:22 +01:00
Matt-Yorkley
e1c13bc194
Fix issue with orphaned adjustments in migration
2021-01-20 13:42:14 +00:00
Pau Perez
ba018df9c5
Pass request_queuing setting to Rack middleware
...
It turns out that this setting belongs to the Rack middleware Datadog
comes with to track requests (See
e4c430a174/docs/GettingStarted.md (rack) ).
The way to pass this option to it is through `configuration[:rack]`
where the `TraceMiddleware` will read it from. See
f57aefe60a/lib/ddtrace/contrib/rack/middlewares.rb (L215-L217)
and
f57aefe60a/lib/ddtrace/contrib/rack/middlewares.rb (L30-L43) .
2021-01-20 10:58:07 +01:00
Andy Brett
a53cc6bc92
Update all locales with the latest Transifex translations
2021-01-19 19:07:37 -08:00
Andy Brett
89ce850da6
Merge pull request #6703 from openfoodfoundation/fix-datadog-init
...
Revert "Enable request queuing tracking in Datadog"
2021-01-19 18:39:21 -08:00
Transifex-Openfoodnetwork
b9cf5b7a9b
Updating translations for config/locales/de_DE.yml
2021-01-20 12:46:16 +11:00
Andy Brett
012289e95f
Merge pull request #6687 from openfoodfoundation/dependabot/bundler/monetize-1.10.0
...
Bump monetize from 1.9.4 to 1.10.0
2021-01-19 17:23:33 -08:00
Matt-Yorkley
6a9505cf67
Ensure adjustments can access soft-deleted originators
...
Note: originator is generally an EnterpriseFee or a TaxRate
2021-01-19 16:46:14 +00:00
Matt-Yorkley
c4a8a38c8d
Soft-delete enterprise fees
...
These objects can hold critical information related to adjustments and tax categories. If they are hard-deleted we lose vital data that's needed by associated records.
2021-01-19 16:46:14 +00:00
Matt-Yorkley
a184075c5c
Fix performance issue in loading payment methods
...
This was loading and initializing every payment method in the database, and every calculator for each of those payment methods.
🔥
2021-01-19 15:33:44 +00:00
Pau Pérez Fabregat
b84fb5814e
Merge pull request #6696 from Matt-Yorkley/migration-issues
...
Update adjustment migration
2021-01-19 16:02:04 +01:00
Pau Pérez Fabregat
8b01c9c8ba
Merge pull request #6279 from luisramos0/base_controller
...
Merge Spree::BaseController with ApplicationController and merge StoreController with ::BaseController
2021-01-19 15:52:47 +01:00
Matt-Yorkley
79b86f535d
Move class definitions in adjustment migration
2021-01-19 13:33:37 +00:00
Luis Ramos
8007554176
Remove test_after_commit gem, it's baked into rails 5 now
2021-01-19 01:15:43 +00:00
Luis Ramos
fc40775ca8
Make paypal controller inherit from base controller and not from old store controller
2021-01-18 23:33:05 +00:00
Maikel
334e270a11
Merge pull request #6552 from Matt-Yorkley/adjustments-order-association
...
[Adjustments] Associate all adjustments with an order
2021-01-19 08:43:13 +11:00
dependabot[bot]
d1eea4654a
Bump monetize from 1.9.4 to 1.10.0
...
Bumps [monetize](https://github.com/RubyMoney/monetize ) from 1.9.4 to 1.10.0.
- [Release notes](https://github.com/RubyMoney/monetize/releases )
- [Changelog](https://github.com/RubyMoney/monetize/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RubyMoney/monetize/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-18 16:10:24 +00:00
Luis Ramos
d8436c2dab
Downgrade libv8 so that mini racer keeps working
2021-01-16 22:41:50 +00:00
Matt-Yorkley
ea9ebc8a33
Update Angular CSRF handling
2021-01-16 13:41:24 +00:00
Luis Ramos
7c9024101b
Some css fixes to make it all work in rails 5
2021-01-15 23:26:37 +00:00
Luis Ramos
4060e7debf
Replace usages of Spree::BaseController with ApplicationController
2021-01-15 21:59:16 +00:00
Luis Ramos
7a22367b4a
Make controllers use ::Basecontroller instead of StoreController
2021-01-15 21:59:16 +00:00
Luis Ramos
23e6048bde
Merge StoreController with BaseController
2021-01-15 21:59:16 +00:00
Luis Ramos
ff8a81cee7
Remove includes already present in parent ApplicationController
2021-01-15 21:59:16 +00:00
Luis Ramos
0eab1b2339
Merge Spree::BaseController with ApplicationController
2021-01-15 21:59:16 +00:00
Matt-Yorkley
c0c7c6ec78
Update checkout helper summing and add test coverage
2021-01-15 17:29:21 +00:00
Matt-Yorkley
1eb08ba31c
Define basic models in migration
2021-01-15 16:17:18 +00:00
Matt-Yorkley
8cc4c6a63f
Introduce soft-deprecation strategy when modifying tax rates
...
If an admin changes the amount on a tax rate, and that rate has been used by adjustments in the past, we need to soft-delete and clone it to preserve the data integrity of previous adjustments that were created using that rate.
2021-01-15 13:38:03 +00:00
Cillian O'Ruanaidh
79668e06a7
Remove ability to create new product from products page, use /admin/products/new instead.
...
It's simpler if there is just one place to add a new product. Closes #6650
This removes the 'creating directly from the new product path' test scenario because we have another 'assigning important attributes' scenario above which provides enough coverage.
2021-01-15 10:24:50 +00:00
Cillian O'Ruanaidh
110d692ffa
Include the 'Ready for' time for the order cycle in the Notify Producers Email
...
This is so people can distinguish which order cycle the email is referring to. Fixes #6371
2021-01-15 09:24:05 +00:00
dependabot[bot]
8e4e276995
Bump paypal-sdk-merchant from 1.106.1 to 1.117.2
...
Bumps [paypal-sdk-merchant](https://github.com/paypal/merchant-sdk-ruby ) from 1.106.1 to 1.117.2.
- [Release notes](https://github.com/paypal/merchant-sdk-ruby/releases )
- [Changelog](https://github.com/paypal/merchant-sdk-ruby/blob/master/ChangeLog.txt )
- [Commits](https://github.com/paypal/merchant-sdk-ruby/compare/v1.106.1...v1.117.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-15 05:49:20 +00:00
Luis Ramos
fd0bba19a7
Adapt enterprises code and specs to new namespace Sets::EnterpriseSet
2021-01-14 09:41:07 +00:00
Luis Ramos
ed0441dc41
Fix a few more rubocop issues
2021-01-14 09:41:07 +00:00
Luis Ramos
19b12092a0
Fix rubocop issues and adapt exceptions file
2021-01-14 09:41:07 +00:00
Luis Ramos
5d6d7f7ad0
Adapt enterprise fees code and specs to new namespace of Sets::EnterpriseFeeSet
2021-01-14 09:41:07 +00:00
Luis Ramos
96a351ad0e
Adapt usage of Sets to their new location
2021-01-14 09:41:07 +00:00
Luis Ramos
187b4a1fc2
Add Sets namespace to each set file
2021-01-14 09:41:07 +00:00
Luis Ramos
8e65d29b02
Move sets to specific services namespace
2021-01-14 09:41:07 +00:00
Maikel Linke
c922a8fd4c
Fix: Remove unused conditional
...
I forgot to remove this unused conditional in a previous commit. Spree
defaulted to overriding the email config and we never changed that.
2021-01-14 12:05:42 +11:00
Maikel Linke
f1618ec35f
Remove old spec context
...
The specs all stay the same, just changing the indent.
2021-01-14 12:05:41 +11:00
Maikel Linke
be229c9002
Simplify email config by removing unused option
...
Spree used to give you more options to configure ActionMailer but our
setup is much simpler. We can remove unused code.
The removed option was never used by OFN and defaulted to true. We don't
need a database migration because the value isn't set in the database.
2021-01-14 12:05:41 +11:00
Andy Brett
8c4d12a501
limit item counter to max quantity available even if amount is manually filled in
2021-01-13 16:23:41 -08:00
Matt-Yorkley
aacd942697
Update specs that stub associations inaccurately
...
These specs fail if the code is using #sum on stubbed objects that don't respond to it nicely.
2021-01-13 17:32:20 +00:00
Matt-Yorkley
7d0ec48bcf
Improve performance on summing adjustments and payment
...
:amount is a database field in these cases, as opposed to a method that returns a computed result. Calling `.sum(:amount)` is much more efficient here as it computes the sum at database level, as opposed to `.map(&:amount).sum`, which would fetch and instanciate all the objects first, and then sum the amounts after.
2021-01-13 16:16:49 +00:00
Pau Perez
e83a3ff76d
Revert "Enable request queuing tracking in Datadog"
...
This reverts commit 91e5276140 .
2021-01-12 10:56:11 +01:00
Matt-Yorkley
ca4de40fa2
Associate all adjustments with an order
...
This change is introduced in the adjustments updates from Spree 2.2 and used heavily in new scopes and methods (not included here).
2021-01-11 17:35:35 +00:00
Jean-Baptiste Bellet
8399b82bfd
rename component to spinner
...
A name for a "thing" rather a state
2021-01-11 16:49:56 +01:00
Jean-Baptiste Bellet
26edd83a54
do not include inside a javascript asset
...
I made a mistake by using it inside a javascript asset
revert part of commit e34050f7c
2021-01-11 16:33:44 +01:00
Jean-Baptiste Bellet
71dc5a8ff0
remove trailing space
2021-01-11 16:29:13 +01:00
Jean-Baptiste Bellet
e34050f7cb
add wrapper to show/hide loading spinner
2021-01-11 16:23:22 +01:00
Jean-Baptiste Bellet
544a7407e3
specify max-width to not overflow parent element
2021-01-11 16:22:47 +01:00
Jean-Baptiste Bellet
1b4254a5cf
Revert "replace code by reusable component"
...
This reverts commit 4d953abbe9 .
2021-01-11 16:12:17 +01:00
Jean-Baptiste Bellet
6f24ecd973
replace code by reusable component
...
There is no need to add .text-center as it's already on the parent component
2021-01-11 11:20:00 +01:00
Jean-Baptiste Bellet
4d953abbe9
replace code by reusable component
...
in a js file
2021-01-11 11:18:54 +01:00
Jean-Baptiste Bellet
b02b36b8e8
replace code by reusable component
2021-01-11 11:18:34 +01:00
Jean-Baptiste Bellet
776a61d1d9
create loading spinner reusable component
2021-01-11 11:17:33 +01:00
Matt-Yorkley
5b9db50250
Optimise Shipment#to_package
...
This is done in a later Spree commit to reduce the amount of processing done in larger orders.
See: ab01b1ec1e
2020-12-08 11:21:05 +00:00