Update regression test

This error is no longer thrown by the payment object creation
This commit is contained in:
Matt-Yorkley
2021-03-04 19:16:50 +00:00
parent 6bb85e9acd
commit 321da76005

View File

@@ -1202,20 +1202,11 @@ describe Spree::Order do
expect { order.next! }.to change { order.state }.from("delivery").to("payment")
end
it "advances to complete state despite error" do
# Regression test for https://github.com/openfoodfoundation/openfoodnetwork/issues/3924
it "advances to complete state without error" do
advance_to_delivery_state(order)
# advance to payment state
order.next!
create(:payment, order: order)
# https://github.com/openfoodfoundation/openfoodnetwork/issues/3924
observed_error = ActiveRecord::RecordNotUnique.new(
"PG::UniqueViolation",
StandardError.new
)
expect(order.shipment).to receive(:save).and_call_original
expect(order.shipment).to receive(:save).and_call_original
expect(order.shipment).to receive(:save).and_raise(observed_error)
expect { order.next! }.to change { order.state }.from("payment").to("complete")
end