Memoize and simplify objects being checked in Order#provided_by_order_cycle?

This commit is contained in:
Matt-Yorkley
2021-01-28 00:05:51 +00:00
parent 8a757812e7
commit c65f623ed8

View File

@@ -831,8 +831,8 @@ module Spree
end
def provided_by_order_cycle?(line_item)
order_cycle_variants = order_cycle.andand.variants || []
order_cycle_variants.include? line_item.variant
@order_cycle_variant_ids ||= order_cycle&.variants&.map(&:id) || []
@order_cycle_variant_ids.include? line_item.variant_id
end
def require_customer?