raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-02 21:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Turn ivars into private attr_readers

Browse Source 
This makes them more changeable and robust. Ruby will raise
NoMethodError on typos while it'll silently create a new ivar without
us noticing. Also, in my experience, a reader method gives more room to
future refactorings and eases testing because methods are easier to
stub.
This commit is contained in:
Pau Perez
2021-02-11 10:55:45 +01:00
parent e2853b9afb
commit 23b0885f4b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/services/process_payment_intent.rb
View File

@@ -10,23 +10,23 @@ class ProcessPaymentIntent
def call!
return unless valid?
@last_payment.update_attribute(:cvv_response_message, nil)
@last_payment.complete!
last_payment.update_attribute(:cvv_response_message, nil)
last_payment.complete!
end
private
attr_reader :order
attr_reader :order, :payment_intent, :last_payment
def valid?
order.present? && valid_intent_string? && matches_last_payment?
end
def valid_intent_string?
@payment_intent&.starts_with?("pi_")
payment_intent&.starts_with?("pi_")
end
def matches_last_payment?
@last_payment&.state == "pending" && @last_payment&.response_code == @payment_intent
last_payment&.state == "pending" && last_payment&.response_code == payment_intent
end
end